NRWT lies about the number of tests that it's skipping when used with --repeat-each
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
2
3         NRWT lies about the number of tests that it's skipping when used with --repeat-each
4         https://bugs.webkit.org/show_bug.cgi?id=95789
5
6         Reviewed by Ojan Vafai.
7
8         Fix miscalculation in log message.
9
10         * Scripts/webkitpy/layout_tests/views/printing.py:
11         (Printer.print_found):
12
13 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
14
15         Unreviewed, rolling out r127612, r127660, and r127664.
16         http://trac.webkit.org/changeset/127612
17         http://trac.webkit.org/changeset/127660
18         http://trac.webkit.org/changeset/127664
19         https://bugs.webkit.org/show_bug.cgi?id=95920
20
21         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
22         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
23         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
24         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
25         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
26         (MockWebRTCPeerConnectionHandler::createOffer):
27         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
28         (MockWebRTCPeerConnectionHandler):
29         (SuccessCallbackTask):
30         (FailureCallbackTask):
31
32 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
33
34         Ignore-metrics includes scroll offsets.
35         https://bugs.webkit.org/show_bug.cgi?id=95845
36
37         Reviewed by Dirk Pranke.
38
39         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
40
41         * Scripts/old-run-webkit-tests:
42         (stripMetrics):
43         * Scripts/webkitpy/layout_tests/port/driver.py:
44         (DriverOutput):
45
46 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
47
48         Unreviewed test fix.
49
50         Including a plugin source file into the build that was added in r127595.
51
52         * GNUmakefile.am:
53
54 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
55
56         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
57         https://bugs.webkit.org/show_bug.cgi?id=95839
58
59         Reviewed by Adam Barth.
60
61         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
62         up the task definitions a bit. There was no need to have them in the header file.
63
64         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
65         (RTCSessionDescriptionRequestSuccededTask):
66         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
67         (RTCSessionDescriptionRequestFailedTask):
68         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
69         (RTCVoidRequestTask):
70         (RTCVoidRequestTask::RTCVoidRequestTask):
71         (MockWebRTCPeerConnectionHandler::createOffer):
72         (MockWebRTCPeerConnectionHandler::setLocalDescription):
73         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
74         (MockWebRTCPeerConnectionHandler::localDescription):
75         (MockWebRTCPeerConnectionHandler::remoteDescription):
76         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
77         (MockWebRTCPeerConnectionHandler):
78
79 2012-09-05  Kangil Han  <kangil.han@samsung.com>
80
81         [EFL] Remove '+=' usage in String
82         https://bugs.webkit.org/show_bug.cgi?id=95808
83
84         Reviewed by Benjamin Poulain.
85
86         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
87
88         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
89         (descriptionSuitableForTestResult):
90
91 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
92
93         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
94         https://bugs.webkit.org/show_bug.cgi?id=95842
95
96         Reviewed by Kenneth Rohde Christiansen.
97
98         Provide proper implementation for TestRunner::pathToLocalResource()
99         in EFL WKTR, identical to the one for DumpRenderTree.
100
101         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
102         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
103         are found my WebKitTestRunner.
104
105         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
106         (WTR::TestRunner::pathToLocalResource):
107
108 2012-09-05  Brady Eidson  <beidson@apple.com>
109
110         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
111         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
112
113         Reviewed by Andy Estes.
114
115         Add a plug-in that always fails to initialize:
116         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
117         (NPPNewFails):
118         (NPPNewFails::NPPNewFails):
119         (NPPNewFails::NPP_New):
120
121         Add it to all the project files:
122         * DumpRenderTree/DumpRenderTree.gypi:
123         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
124         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
125         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
126         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
127
128 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
129
130         [Qt] Fix makefile race condition between derived sources and target
131
132         r121966 removed too much of the old qmake logic, including the rule
133         that ensured that qmake_all would not trigger dual runs of qmake --
134         one of the derived sources -qmake-all rule, and one for making the
135         derived sources.
136
137         We now follow a similar pattern as before, by introducing a custom
138         target that explicitly depends on the derived sources' qmake-all before
139         doing a manual run of make. That ensures a single qmake run for the derived
140         sources.
141
142         https://bugs.webkit.org/show_bug.cgi?id=93847
143
144         Reviewed by Csaba Osztrogonác.
145
146         * qmake/mkspecs/features/functions.prf:
147
148 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
149
150         WKTR doesn't implement dumpWillCacheResponse()
151         https://bugs.webkit.org/show_bug.cgi?id=94607
152
153         Reviewed by Kenneth Rohde Christiansen.
154
155         Define shouldCacheResponse() callback in resource
156         load client and provide implementation for
157         dumpWillCacheResponse() in WebKitTestRunner.
158
159         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
160         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
161         (WTR::InjectedBundlePage::InjectedBundlePage):
162         (WTR::InjectedBundlePage::shouldCacheResponse):
163         (WTR):
164         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
165         (InjectedBundlePage):
166         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
167         (WTR::TestRunner::TestRunner):
168         * WebKitTestRunner/InjectedBundle/TestRunner.h:
169         (WTR::TestRunner::dumpWillCacheResponse):
170         (WTR::TestRunner::shouldDumpWillCacheResponse):
171         (TestRunner):
172
173 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
174
175         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
176         https://bugs.webkit.org/show_bug.cgi?id=92735
177
178         Reviewed by Hajime Morita.
179
180         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
181
182         * DumpRenderTree/TestRunner.cpp:
183         (TestRunner::staticFunctions):
184         * DumpRenderTree/TestRunner.h:
185         (TestRunner):
186         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
187         (TestRunner::addUserStyleSheet):
188         * DumpRenderTree/chromium/DRTTestRunner.cpp:
189         (DRTTestRunner::DRTTestRunner):
190         (DRTTestRunner::hasCustomPageSizeStyle):
191         * DumpRenderTree/chromium/DRTTestRunner.h:
192         (DRTTestRunner):
193         * DumpRenderTree/efl/TestRunnerEfl.cpp:
194         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
195         * DumpRenderTree/mac/TestRunnerMac.mm:
196         * DumpRenderTree/qt/TestRunnerQt.cpp:
197         (TestRunner::evaluateScriptInIsolatedWorld):
198         * DumpRenderTree/qt/TestRunnerQt.h:
199         (TestRunner):
200         * DumpRenderTree/win/TestRunnerWin.cpp:
201         * DumpRenderTree/wx/TestRunnerWx.cpp:
202         (TestRunner::abortModal):
203         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
204         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
205         (WTR):
206         * WebKitTestRunner/InjectedBundle/TestRunner.h:
207         (TestRunner):
208
209 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
210
211         [Qt] Automate the use of AllInOne files in the Qt build
212         https://bugs.webkit.org/show_bug.cgi?id=95837
213
214         Reviewed by Tor Arne Vestbø.
215
216         New feature file that implements the all-in-one file automation by
217         adding the requested all-in-one files to SOURCES and removing the files
218         it includes from SOURCES.
219
220         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
221
222 2012-09-04  Tim Horton  <timothy_horton@apple.com>
223
224         Have NRWT log more output when crash logs are missing
225         https://bugs.webkit.org/show_bug.cgi?id=95814
226
227         Reviewed by Dan Bernstein.
228
229         Log the stderr and stdout of the test, in order to provide slightly more
230         context when the WebProcess times out while running tests.
231
232         * Scripts/webkitpy/layout_tests/port/driver.py:
233         (Driver.run_test):
234
235 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
236
237         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
238         https://bugs.webkit.org/show_bug.cgi?id=95770
239
240         Reviewed by Adam Barth.
241
242         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
243         (ChromiumAndroidDriver.__init__):
244         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
245         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
246         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
247         (ChromiumAndroidDriver._push_executable):
248         (ChromiumAndroidDriver._push_fonts):
249         (ChromiumAndroidDriver._push_test_resources):
250         (ChromiumAndroidDriver._run_adb_command):
251         (ChromiumAndroidDriver._get_last_stacktrace):
252         (ChromiumAndroidDriver._get_crash_log):
253         (ChromiumAndroidDriver._start):
254         (ChromiumAndroidDriver._start_once):
255         (ChromiumAndroidDriver._start_once.deadlock_detector):
256         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
257         (ChromiumAndroidDriverTest.test_get_crash_log):
258
259 2012-09-04  Satish Sampath  <satish@chromium.org>
260
261         Run git commands within the checkout directory
262         https://bugs.webkit.org/show_bug.cgi?id=95742
263
264         Reviewed by Eric Seidel.
265
266         git commands run from scm/git.py are sometimes run with cwd set to the
267         checkout_root and other times with whatever directory was the default cwd.
268         Instead all these should run with the checkout root set as the cwd
269         (except where we explicitly need a different path)
270
271         * Scripts/webkitpy/common/checkout/scm/git.py:
272         (Git._run_git):
273         (Git.find_checkout_root):
274         (Git.discard_local_commits):
275         (Git.local_commits):
276         (Git.working_directory_is_clean):
277         (Git.clean_working_directory):
278         (Git.add_list):
279         (Git.delete_list):
280         (Git.exists):
281         (Git._current_branch):
282         (Git._changes_files_for_commit):
283         (Git.revisions_changing_file):
284         (Git.svn_revision):
285         (Git._run_git_svn_find_rev):
286         (Git.contents_at_revision):
287         (Git.diff_for_file):
288         (Git.show_head):
289         (Git.committer_email_for_revision):
290         (Git.apply_reverse_diff):
291         (Git.revert_files):
292         (Git.commit_with_message):
293         (Git._commit_on_branch):
294         (Git.svn_commit_log):
295         (Git.last_svn_commit_log):
296         (Git.svn_blame):
297         (Git._branch_ref_exists):
298         (Git.delete_branch):
299         (Git.remote_merge_base):
300         (Git.commit_locally_with_message):
301         (Git.push_local_commits_to_server):
302         (Git.commit_ids_from_commitish_arguments):
303         (Git.commit_message_for_local_commit):
304         (Git.files_changed_summary_for_commit):
305
306 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
307
308         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
309         https://bugs.webkit.org/show_bug.cgi?id=95734
310
311         Reviewed by Adam Barth.
312
313         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
314         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
315         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
316         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
317         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
318         (MockWebRTCPeerConnectionHandler::createOffer):
319         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
320         (MockWebRTCPeerConnectionHandler):
321         (MockWebRTCPeerConnectionHandler::taskList):
322         (SuccessCallbackTask):
323         (FailureCallbackTask):
324
325 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
326
327         [Chromium-Android] Output time and thread info in crash log
328         https://bugs.webkit.org/show_bug.cgi?id=95768
329
330         Reviewed by Adam Barth.
331
332         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
333         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
334
335 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
336
337         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
338         https://bugs.webkit.org/show_bug.cgi?id=95721
339
340         Reviewed by Adam Barth.
341
342         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
343         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
344         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
345         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
346         (MockWebMediaStreamCenter):
347
348 2012-09-04  Tony Chang  <tony@chromium.org>
349
350         Elide test names when running new-run-webkit-tests
351         https://bugs.webkit.org/show_bug.cgi?id=95626
352
353         Reviewed by Dirk Pranke.
354
355         When the test name exceeds the number of terminal columns, it leaves
356         text on the screen. Avoid this by eliding the test name when running
357         tests. This is similar to what ninja does when compiling.
358
359         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
360         (MeteredStream):
361         (MeteredStream.number_of_columns): Helper method to get number of
362         terminal columns. Won't work on Win32 python, but meh.
363         * Scripts/webkitpy/layout_tests/views/printing.py:
364         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
365         because stderr appears to be ascii only.
366         (Printer.print_started_test): Route through _test_status_line.
367         (Printer.print_finished_test): Route through _test_status_line.
368         (Printer._print_test_trace): Route through _test_status_line.
369         (Printer._print_baseline): Route through _test_status_line.
370         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
371         (test_test_status_line): Test for _test_status_line.
372
373 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
374
375         [GTK] Print API missing documentation when generating gtkdoc
376         https://bugs.webkit.org/show_bug.cgi?id=95703
377
378         Reviewed by Carlos Garcia Campos.
379
380         Print out API missing documentation when generating gtkdoc. This makes it
381         easier to fix documentation errors.
382
383         * gtk/generate-gtkdoc:
384         (print_missing_api): Added.
385         (generate_doc): Inline the rebase step, since it now reports an error
386         when you try to rebase without generating documentation first.
387         * gtk/gtkdoc.py:
388         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
389         generating documentation first to enable a small cleanup at the caller.
390         (GTKDoc.api_missing_documentation): Added.
391
392 2012-09-04  Vincent Scheib  <scheib@chromium.org>
393
394         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
395         https://bugs.webkit.org/show_bug.cgi?id=95628
396
397         Reviewed by James Robinson.
398
399         Future tests need the ability to respond asynchronously that
400         pointer lock requests have been accepted or rejected. This patch
401         adds the following:
402             testRunner.setPointerLockWillRespondAsynchronously();
403             testRunner.didAcquirePointerLock();
404             testRunner.didNotAcquirePointerLock();
405
406         Tested in existing test:
407             pointerlockchange-pointerlockerror-events.html
408
409         * DumpRenderTree/chromium/DRTTestRunner.cpp:
410         (DRTTestRunner::DRTTestRunner):
411         (DRTTestRunner::didAcquirePointerLock):
412         (DRTTestRunner::didNotAcquirePointerLock):
413         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
414         * DumpRenderTree/chromium/DRTTestRunner.h:
415         (DRTTestRunner):
416         * DumpRenderTree/chromium/WebViewHost.cpp:
417         (WebViewHost::requestPointerLock):
418         (WebViewHost::didAcquirePointerLock):
419         (WebViewHost::didNotAcquirePointerLock):
420         * DumpRenderTree/chromium/WebViewHost.h:
421         (WebViewHost):
422         (WebViewHost::setPointerLockWillRespondAsynchronously):
423
424 2012-09-04  Ojan Vafai  <ojan@chromium.org>
425
426         Move content shell bots to their own builder group
427         https://bugs.webkit.org/show_bug.cgi?id=95765
428
429         Reviewed by Adam Barth.
430
431         In their current state of instability, they add too much noise. Once they get more stable,
432         we can add them back to the regular group or just have them replace the other bots.
433
434         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
435
436         * TestResultServer/static-dashboards/builders.js:
437         (isWebkitTestRunner):
438         (isChromiumContentShellTestRunner):
439         (isChromiumWebkitTipOfTreeTestRunner):
440         (loadBuildersList):
441
442 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
443
444         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
445         https://bugs.webkit.org/show_bug.cgi?id=95689
446
447         Reviewed by Kenneth Rohde Christiansen.
448
449         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
450         So, there are bugs that key events are always generated in url bar although
451         the user clicked the web view.
452
453         This patch recovers the focus of the web view when left button is pressed and
454         adds for MiniBrowser to toggle the focus when middle button is pressed
455         like EWebLauncher already did.
456
457         * EWebLauncher/main.c:
458         (on_mouse_down):
459         * MiniBrowser/efl/main.c:
460         (on_mouse_down):
461         (browserCreate):
462
463 2012-09-03  Tao Bai  <michaelbai@chromium.org>
464
465         Added ANDROID_GDBSERVER definition for Ant
466         https://bugs.webkit.org/show_bug.cgi?id=95265
467
468         Reviewed by Adam Barth.
469
470         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
471         is only used for finding the gdbserver.
472
473         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
474         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
475
476 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
477
478         MediaStream API: Add Ice-related functionality to RTCPeerConnection
479         https://bugs.webkit.org/show_bug.cgi?id=95565
480
481         Reviewed by Adam Barth.
482
483         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
484         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
485         (MockWebRTCPeerConnectionHandler::updateICE):
486         (MockWebRTCPeerConnectionHandler::addICECandidate):
487         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
488         (MockWebRTCPeerConnectionHandler):
489
490 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
491
492         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
493         https://bugs.webkit.org/show_bug.cgi?id=95670
494
495         Reviewed by Kenneth Rohde Christiansen.
496
497         Fix layout issues related to the URL bar in Minibrowser
498         and EWebLauncher when the window is resized.
499
500         The URL bar was not resized accordingly and the Web
501         page was moved behing the URL bar, hiding part of it.
502
503         * EWebLauncher/main.c:
504         (on_ecore_evas_resize):
505         (closeWindow):
506         * EWebLauncher/url_bar.c:
507         (url_bar_width_set):
508         (url_bar_add):
509         * EWebLauncher/url_bar.h:
510         * MiniBrowser/efl/main.c:
511         (on_ecore_evas_resize):
512         (main):
513
514 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
515
516         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
517         https://bugs.webkit.org/show_bug.cgi?id=95605
518
519         Reviewed by Dirk Pranke.
520
521         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
522
523         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
524         (ChromiumAndroidPort.check_sys_deps):
525         (ChromiumAndroidPort.expectations_files):
526         (ChromiumAndroidPort.clean_up_test_run):
527
528 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
529
530         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
531         https://bugs.webkit.org/show_bug.cgi?id=95180
532
533         Reviewed by Chris Fleizach.
534
535         The bug that was fixed stood in the way of fully implementing stringValue().
536         Testing that the bug is fixed requires stringValue() to be fully implemented
537         and object replacement characters to be printable.
538
539         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
540         (replaceCharactersForResults): New method which turns object replacement
541         characters into "<obj>" so that the characters can be properly shown in
542         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
543         accessible text of a single object in the accessible tree doesn't mess up
544         the readibility of the results.
545         (AccessibilityUIElement::stringValue): Remove the code that immediately
546         returned upon encountering an object of ATK_ROLE_PANEL and call the new
547         replaceCharactersForResults() prior to returning the accessible string
548         value.
549
550 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
551
552         MediaStream API: Add MediaStream management to RTCPeerConnection
553         https://bugs.webkit.org/show_bug.cgi?id=95543
554
555         Reviewed by Adam Barth.
556
557         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
558
559         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
560         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
561         (MockWebRTCPeerConnectionHandler::addStream):
562         (MockWebRTCPeerConnectionHandler::removeStream):
563         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
564         (MockWebRTCPeerConnectionHandler):
565
566 2012-08-31  Tony Chang  <tony@chromium.org>
567
568         Remove ENABLE_CSS3_FLEXBOX compile time flag
569         https://bugs.webkit.org/show_bug.cgi?id=95382
570
571         Reviewed by Ojan Vafai.
572
573         Everyone is already enabling this by default and the spec has stablized.
574
575         * Scripts/webkitperl/FeatureList.pm:
576         * qmake/mkspecs/features/features.pri:
577
578 2012-08-31  Pratik Solanki  <psolanki@apple.com>
579
580         objc_msgSend and IMP should be cast appropriately before using
581         https://bugs.webkit.org/show_bug.cgi?id=95242
582
583         Reviewed by Benjamin Poulain.
584
585         Fix for older compilers. Pass id as the return type to the template
586         instead of relying on default type.
587
588         * DumpRenderTree/mac/DumpRenderTree.mm:
589         (drt_NSFontManager_availableFontFamilies):
590         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
591         (WTR::wtr_NSFontManager_availableFontFamilies):
592
593 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
594
595         nrwt: use scm instead of calling svn directly to get the revision in json results generator
596         https://bugs.webkit.org/show_bug.cgi?id=89616
597
598         Reviewed by Eric Seidel.
599
600         Add the new 'executive' optional function argument to the SCM.in_working_directory
601         class method. This way we get to reuse an Executive instance which is necessary in testing
602         when we're operating with a mock version of the object.
603
604         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
605         the SCMDetector with the generator's FileSystem and Executive instances.
606
607         * Scripts/webkitpy/common/checkout/scm/detection.py:
608         (SCMDetector.detect_scm_system):
609         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
610         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
611         Executive output and test it against expected output.
612         * Scripts/webkitpy/common/checkout/scm/git.py:
613         (Git.in_working_directory):
614         * Scripts/webkitpy/common/checkout/scm/scm.py:
615         (SCM.in_working_directory):
616         * Scripts/webkitpy/common/checkout/scm/svn.py:
617         (SVN.in_working_directory):
618         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
619         (JSONResultsGeneratorBase.__init__):
620         (JSONResultsGeneratorBase._get_svn_revision):
621
622 2012-08-31  Jon Lee  <jonlee@apple.com>
623
624         [Tests] Add basic tests to http/tests/notifications
625         https://bugs.webkit.org/show_bug.cgi?id=95493
626         <rdar://problem/12209303>
627
628         Reviewed by Alexey Proskuryakov.
629
630         Add permission request support for WTR.
631
632         * WebKitTestRunner/TestController.cpp:
633         (WTR::TestController::initialize):
634         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
635         * WebKitTestRunner/TestController.h:
636         (TestController):
637
638 2012-08-31  Jon Lee  <jonlee@apple.com>
639
640         [DRT] Make simulating a web click on a notification a queued task
641         https://bugs.webkit.org/show_bug.cgi?id=95546
642         <rdar://problem/12214170>
643
644         Reviewed by Alexey Proskuryakov.
645
646         Making the web click happen asynchronously better mimics user interaction with the platform.
647
648         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
649         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
650         not set.
651         * DumpRenderTree/mac/DumpRenderTree.mm:
652         (dump): Assert that the flag is not set.
653         * DumpRenderTree/mac/TestRunnerMac.mm:
654         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
655         notification. In the case where the block gets executed after the flag has been unset, we avoid
656         performing the click.
657
658 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
659
660         [Qt] ImageDiff output is not in the expected form if image dimensions differ
661         https://bugs.webkit.org/show_bug.cgi?id=95575
662
663         Reviewed by Csaba Osztrogonác.
664
665         Output 100% difference in the case of differing image dimensions so
666         the test harness knows that we won't produce any output further.
667         This matches the behavior of other ports.
668
669         * DumpRenderTree/qt/ImageDiff.cpp:
670         (main):
671
672 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
673
674         Unreviewed, rolling out r127261.
675         http://trac.webkit.org/changeset/127261
676         https://bugs.webkit.org/show_bug.cgi?id=95572
677
678         This patch depends on other build fixes (see blockers of bug
679         95466) which should land first (Requested by milian on
680         #webkit).
681
682         * qmake/mkspecs/features/features.prf:
683
684 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
685
686         [Qt] Support WebKit2/QML on QNX
687         https://bugs.webkit.org/show_bug.cgi?id=95466
688
689         Reviewed by Noam Rosenthal.
690
691         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
692         this should finally work now.
693
694         * qmake/mkspecs/features/features.prf:
695
696 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
697
698         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
699         https://bugs.webkit.org/show_bug.cgi?id=95400
700
701         Reviewed by Dirk Pranke.
702
703         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
704
705         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
706         (ChromiumAndroidPort.skipped_layout_tests):
707
708 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
709
710         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
711         https://bugs.webkit.org/show_bug.cgi?id=95499
712
713         Unreviewed. One more fix to avoid trying to run the empty string.
714
715         * Scripts/webkitdirs.pm:
716         (buildAutotoolsProject):
717
718 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
719
720         Unreviewed, rolling out r127171.
721         http://trac.webkit.org/changeset/127171
722         https://bugs.webkit.org/show_bug.cgi?id=95505
723
724         testRunner does not need dumpWebNotificationCallbacks().
725         (Requested by jonlee on #webkit).
726
727         * DumpRenderTree/TestRunner.cpp:
728         (TestRunner::TestRunner):
729         (TestRunner::staticFunctions):
730         * DumpRenderTree/TestRunner.h:
731         (TestRunner):
732         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
733         (-[MockWebNotificationProvider webView:didShowNotification:]):
734         (-[MockWebNotificationProvider webView:didClickNotification:]):
735         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
736         * DumpRenderTree/mac/UIDelegate.mm:
737         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
738
739 2012-08-30  Pratik Solanki  <psolanki@apple.com>
740
741         objc_msgSend and IMP should be cast appropriately before using
742         https://bugs.webkit.org/show_bug.cgi?id=95242
743
744         Reviewed by Benjamin Poulain.
745
746         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
747         to a function pointer with right types when calling objc_msgSend and an
748         IMP method directly.
749
750         * DumpRenderTree/mac/DumpRenderTree.mm:
751         (drt_NSFontManager_availableFontFamilies):
752         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
753         (WTR::wtr_NSFontManager_availableFontFamilies):
754
755 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
756
757         Replace JSC::UString by WTF::String
758         https://bugs.webkit.org/show_bug.cgi?id=95271
759
760         Reviewed by Geoffrey Garen.
761
762         Get rid of UString.
763
764         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
765         * gdb/webkit.py:
766         (WTFStringPrinter.to_string):
767         (JSCIdentifierPrinter.to_string):
768         (JSCJSStringPrinter.to_string):
769         (add_pretty_printers):
770
771 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
772
773         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
774         https://bugs.webkit.org/show_bug.cgi?id=95495
775
776         Reviewed by Ojan Vafai.
777
778         This is a follow-on to bug 95370 that adds in support for
779         platform/wk2/TestExpectations and
780         platform/{mac,win}-$version/TestExpectations.
781
782         * Scripts/webkitpy/layout_tests/port/apple.py:
783         (ApplePort.expectations_files):
784         * Scripts/webkitpy/layout_tests/port/base.py:
785         (Port._skipped_file_search_paths):
786         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
787         (MacTest.test_expectations_files):
788         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
789         (MockDRTPortTest.make_port):
790         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
791         (WinPortTest.test_expectations_files):
792
793 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
794
795         executive.run_in_parallel() hangs if given nothing to do
796         https://bugs.webkit.org/show_bug.cgi?id=95387
797
798         Reviewed by Ojan Vafai.
799
800         Check to make sure that Executive.run_in_parallel() requires
801         a non-empty list of commands to execute; passing an empty list
802         seems surely like a programming error.
803
804         * Scripts/webkitpy/common/system/executive.py:
805         (Executive.run_in_parallel):
806         * Scripts/webkitpy/common/system/executive_unittest.py:
807         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
808
809 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
810
811         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
812         https://bugs.webkit.org/show_bug.cgi?id=94746
813
814         Reviewed by Ojan Vafai.
815
816         Add an assertion to diff_image() to check that we are passing
817         tolerance=0 explicitly when diffing ref test results.
818
819         * Scripts/webkitpy/layout_tests/port/test.py:
820         (TestPort.diff_image):
821
822 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
823
824         NRWT should look in mac-wk2 for a TestExpecations file
825         https://bugs.webkit.org/show_bug.cgi?id=95370
826
827         Reviewed by Ojan Vafai.
828
829         Adds support for mac-wk2 and win-wk2 to expectations_files()
830         for the apple mac and apple win ports.
831         
832         * Scripts/webkitpy/layout_tests/port/apple.py:
833         (ApplePort.expectations_files):
834         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
835         (MacTest.test_expectations_files):
836         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
837         (WinTest.test_expectations_files):
838         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
839         (PortTestCase.test_expectations_files):
840
841 2012-08-30  Jon Lee  <jonlee@apple.com>
842
843         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
844         https://bugs.webkit.org/show_bug.cgi?id=95232
845         <rdar://problem/12190776>
846
847         Reviewed by Alexey Proskuryakov.
848
849         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
850
851         * DumpRenderTree/TestRunner.cpp:
852         (TestRunner::TestRunner):
853         (dumpWebNotificationCallbacksCallback):
854         (TestRunner::staticFunctions):
855         * DumpRenderTree/TestRunner.h:
856         (TestRunner):
857         (TestRunner::dumpWebNotificationCallbacks):
858         (TestRunner::setDumpWebNotificationCallbacks):
859         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
860         (-[WebNotification _drt_descriptionSuitableForTestResult]):
861         (-[MockWebNotificationProvider webView:didShowNotification:]):
862         (-[MockWebNotificationProvider webView:didClickNotification:]):
863         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
864         * DumpRenderTree/mac/UIDelegate.mm:
865         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
866
867 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
868
869         MediaStream API: Introduce MediaConstraints
870         https://bugs.webkit.org/show_bug.cgi?id=95198
871
872         Reviewed by Adam Barth.
873
874         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
875
876         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
877         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
878         (isSupportedConstraint):
879         (isValidConstraint):
880         (MockWebRTCPeerConnectionHandler::initialize):
881         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
882         (MockWebRTCPeerConnectionHandler):
883
884 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
885
886         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
887         https://bugs.webkit.org/show_bug.cgi?id=95454
888
889         Reviewed by Kenneth Rohde Christiansen.
890
891         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
892
893         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
894         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
895
896 2012-08-30  Leo Yang  <leoyang@rim.com>
897
898         Update my email address.
899
900         Not reviewed.
901
902         * Scripts/webkitpy/common/config/committers.py:
903
904 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
905
906         [NRWT] Add support for recognizing arbitrary process names in crash lines
907         https://bugs.webkit.org/show_bug.cgi?id=95435
908
909         Reviewed by Adam Barth.
910
911         When running layout tests in the chromium port using the content shell,
912         we want to be able to report sub-process crashes as well.
913
914         * Scripts/webkitpy/layout_tests/port/driver.py:
915         (Driver._check_for_driver_crash):
916         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
917         (DriverTest.test_check_for_driver_crash):
918
919 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
920
921         Random test-webkitpy failures on the buildbot
922         https://bugs.webkit.org/show_bug.cgi?id=95096
923
924         Reviewed by Dirk Pranke.
925
926         Suppress occasional errors when running test-webkitpy on GTK builders
927         by running these tests serially. The 64-bit Release builder is especially
928         prone to these as it can run up to 24 tests in parallel.
929
930         Despite the tests not being run in parallel, the testing only lasts a handful
931         of seconds more, so this is a worthy trade-off to avoid unnecessary
932         false-alarm redness on the GTK builders.
933
934         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
935         (RunPythonTests.start):
936
937 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
938
939         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
940         https://bugs.webkit.org/show_bug.cgi?id=95380
941
942         Reviewed by Michael Saboff.
943
944         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
945         Add very basic tests for String::ascii(). This covers the case of null strings that caused
946         the crash.
947
948 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
949
950         AX: Canvas should have a distinct role
951         https://bugs.webkit.org/show_bug.cgi?id=95248
952
953         Reviewed by Chris Fleizach.
954
955         Add support for canvas accessibility role.
956
957         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
958         (roleToString):
959
960 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
961
962         [Gtk] Process Gtk 3.4 smooth scroll events properly
963         https://bugs.webkit.org/show_bug.cgi?id=88070
964
965         Added continousMouseScrollBy support in WebKitTestRunner, and added
966         implementation for gtk, and stub for Qt, mac and EFL.
967
968         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
969         scroll for emulating multi-tick mouseScrollBy events.
970
971         Reviewed by Martin Robinson.
972
973         * DumpRenderTree/gtk/EventSender.cpp:
974         (mouseScrollByCallback):
975         (continuousMouseScrollByCallback):
976         * WebKitTestRunner/EventSenderProxy.h:
977         (EventSenderProxy):
978         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
979         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
980         (WTR::EventSendingController::mouseScrollBy):
981         (WTR):
982         (WTR::EventSendingController::continuousMouseScrollBy):
983         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
984         (EventSendingController):
985         * WebKitTestRunner/TestController.cpp:
986         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
987         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
988         (WTR):
989         (WTR::EventSenderProxy::mouseScrollBy):
990         (WTR::EventSenderProxy::continuousMouseScrollBy):
991         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
992         (WTR):
993         (WTR::EventSenderProxy::continuousMouseScrollBy):
994         * WebKitTestRunner/mac/EventSenderProxy.mm:
995         (WTR::EventSenderProxy::continuousScrollBy):
996         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
997         (WTR::EventSenderProxy::continuousMouseScrollBy):
998         (WTR):
999
1000 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
1001
1002         [chromium] Support high DIP pixel tests with DumpRenderTree
1003         https://bugs.webkit.org/show_bug.cgi?id=94935
1004
1005         Reviewed by James Robinson.
1006
1007         Adding device scale factor into the drt image dumping code
1008
1009         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1010         (DRTTestRunner::reset):
1011         (DRTTestRunner::setBackingScaleFactor):
1012         * DumpRenderTree/chromium/WebViewHost.cpp:
1013         (WebViewHost::setDeviceScaleFactor):
1014         (WebViewHost::paintInvalidatedRegion):
1015         (WebViewHost::canvas):
1016         * DumpRenderTree/chromium/WebViewHost.h:
1017         (WebViewHost):
1018
1019 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
1020
1021         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
1022         https://bugs.webkit.org/show_bug.cgi?id=95177
1023
1024         Reviewed by Dirk Pranke.
1025
1026         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
1027
1028         * Scripts/webkitpy/common/checkout/scm/git.py:
1029
1030 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
1031
1032         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
1033         https://bugs.webkit.org/show_bug.cgi?id=95222
1034
1035         Reviewed by Adam Barth.
1036
1037         The code we had to remove REBASELINE lines from the
1038         TestExpectations files did not handle multiple files (in a
1039         cascade) correctly; we weren't limiting lines to a particular
1040         file correctly in without_rebaseline_modifier(). This patch
1041         fixes that and corrects the tests (which weren't correct and
1042         didn't cover things very well).
1043
1044         Note also that the webkit-patch rebaseline-commands are still
1045         using the include_overrides=False option in a couple places;
1046         this is never correct or needed at this point. This patch fixes
1047         the usage for webkit-patch rebaseline-expectations, but I still
1048         need to fix rebaseline-test-internal, which I will do in a
1049         separate patch (see bug 95268).
1050
1051         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1052         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
1053         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1054         (RebaseliningTest.assertRemove):
1055         (RebaseliningTest.test_remove):
1056         * Scripts/webkitpy/tool/commands/rebaseline.py:
1057         (RebaselineExpectations._update_expectations_files):
1058
1059 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
1060
1061         webkit-patch rebaseline-expectations hangs
1062         https://bugs.webkit.org/show_bug.cgi?id=95243
1063
1064         Reviewed by Tony Chang.
1065
1066         Don't try to run no commands in parallel; report an error
1067         instead that we didn't find any tests to rebaseline.
1068
1069         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
1070
1071         * Scripts/webkitpy/tool/commands/rebaseline.py:
1072         (RebaselineExpectations.execute):
1073         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1074         (_assert_command):
1075         (test_rebaseline_expectations_noop):
1076
1077 2012-08-29  Brady Eidson  <beidson@apple.com>
1078
1079         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
1080         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
1081
1082         Reviewed by Sam Weinig.
1083
1084         Add a test plug-in that calls back into the page with info on the NPWindow passed
1085         in to NPP_SetWindow.
1086
1087         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1088         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
1089         (LogNPPSetWindow):
1090         (LogNPPSetWindow::LogNPPSetWindow):
1091         (LogNPPSetWindow::NPP_SetWindow):
1092
1093 2012-08-29  Jon Lee  <jonlee@apple.com>
1094
1095         [Mac] Basic DRT support for web notifications
1096         https://bugs.webkit.org/show_bug.cgi?id=79492
1097         <rdar://problem/10357639>
1098
1099         Reviewed by Alexey Proskuryakov.
1100
1101         This patch implements the stubs for web notification support on DRT. Assume that when
1102         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
1103         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
1104
1105         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
1106         * DumpRenderTree/mac/DumpRenderTree.mm:
1107         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
1108         web view.
1109         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
1110
1111         * DumpRenderTree/mac/TestRunnerMac.mm:
1112         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
1113         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
1114         (TestRunner::removeAllWebNotificationPermissions):
1115         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
1116         simulate the click. This is similar to how WTR performs the click.
1117         * DumpRenderTree/mac/UIDelegate.mm:
1118         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
1119         user allows web notifications.
1120
1121         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
1122         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
1123         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
1124         (+[MockWebNotificationProvider shared]): The provider is a singleton.
1125         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
1126         (-[MockWebNotificationProvider registerWebView:]):
1127         (-[MockWebNotificationProvider unregisterWebView:]):
1128         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
1129         notification did show.
1130         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
1131         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
1132         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
1133         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
1134         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
1135         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
1136         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
1137         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
1138         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
1139         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
1140         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
1141
1142 2012-08-29  Rob Buis  <rbuis@rim.com>
1143
1144         [BlackBerry] Adjust wtf include header style
1145         https://bugs.webkit.org/show_bug.cgi?id=95368
1146
1147         Reviewed by Yong Li.
1148
1149         Switch to #include <wtf/...> like the other ports.
1150
1151         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1152         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
1153         * DumpRenderTree/blackberry/PNGImageEncoder.h:
1154         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1155         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
1156         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1157
1158 2012-08-29  Roger Fong  <roger_fong@apple.com>
1159
1160         Update cygwin-downloader.zip to match modified downloader script.
1161         https://bugs.webkit.org/show_bug.cgi?id=76936
1162
1163         Rubber Stamped by Jon Honeycutt.
1164
1165         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
1166         Updating zip to reflect changes.
1167
1168         * CygwinDownloader/cygwin-downloader.zip:
1169
1170 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
1171
1172         Stylechecker warns about comparison to zero when comparing to 0.5
1173         https://bugs.webkit.org/show_bug.cgi?id=94913
1174
1175         Reviewed by Dirk Pranke.
1176
1177         According to the python documentation, \W is the character group with all
1178         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
1179         to [^\w]. We need to exclude the dot "." as well, so that floating point
1180         values do not trigger this warning. Adding a unit test that shows the problem.
1181
1182         * Scripts/webkitpy/style/checkers/cpp.py:
1183         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
1184         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1185         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
1186
1187 2012-08-29  Jon Lee  <jonlee@apple.com>
1188
1189         WTR build fixes.
1190
1191         * WebKitTestRunner/CMakeLists.txt:
1192         * WebKitTestRunner/GNUmakefile.am:
1193         * WebKitTestRunner/Target.pri:
1194         * WebKitTestRunner/WebNotificationProvider.cpp:
1195         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
1196         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1197
1198 2012-08-29  Jon Lee  <jonlee@apple.com>
1199
1200         [WK2] Basic WTR support for web notifications
1201         https://bugs.webkit.org/show_bug.cgi?id=95154
1202         <rdar://problem/12184492>
1203
1204         Reviewed by Alexey Proskuryakov.
1205
1206         Implement WTR support, without platform event output (bug 95233).
1207
1208         Legacy APIs will not be supported, since many of the tests are skipped
1209         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
1210         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
1211         the tests to http/tests/notifications.
1212
1213         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
1214         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
1215         be invoked from the UIProcess.
1216
1217         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1218         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1219         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
1220         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
1221         notification's internal ID.
1222         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1223         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1224         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
1225         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
1226         (WTR::TestRunner::removeAllWebNotificationPermissions):
1227         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
1228         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1229
1230         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
1231         class.
1232         * WebKitTestRunner/TestInvocation.cpp:
1233         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
1234         TestInvocation forwards that request to the TestController.
1235         * WebKitTestRunner/TestController.cpp:
1236         (WTR::TestController::initialize): Set the provider.
1237         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
1238         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
1239         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
1240
1241         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
1242         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
1243         * WebKitTestRunner/WebNotificationProvider.h: Added.
1244         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
1245         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
1246         the notification got shown.
1247         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
1248         got closed.
1249         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
1250         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
1251         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
1252         permissions. For testing purposes, we always want this set to be empty.
1253         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
1254         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
1255
1256         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
1257
1258 2012-08-29  Kamil Blank  <k.blank@samsung.com>
1259
1260         [EFL] Add setting API for allow universal/file access from file URLs.
1261         https://bugs.webkit.org/show_bug.cgi?id=83121
1262
1263         Reviewed by Eric Seidel.
1264
1265         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
1266
1267         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1268         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1269         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1270         (TestRunner::setAllowUniversalAccessFromFileURLs):
1271         (TestRunner::setAllowFileAccessFromFileURLs):
1272
1273 2012-08-29  Jon Lee  <jonlee@apple.com>
1274
1275         Update TestRunner API for web notifications
1276         https://bugs.webkit.org/show_bug.cgi?id=95093
1277         <rdar://problem/12179649>
1278
1279         Reviewed by Alexey Proskuryakov.
1280
1281         As it turns out the patch for this accidentally got squashed into the commit for
1282         bug 95099 (r126909). This amendment patch adds some comments about the renaming
1283         of the older TestRunner API for web notifications.
1284
1285         * DumpRenderTree/TestRunner.h:
1286         (TestRunner):
1287
1288 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1289
1290         Unreviewed, rolling out r126972.
1291         http://trac.webkit.org/changeset/126972
1292         https://bugs.webkit.org/show_bug.cgi?id=95349
1293
1294         accessibility/canvas-description-and-role.html has been
1295         failing consistently on several bots and Dominic needs some
1296         time to investigate why (Requested by jchaffraix on #webkit).
1297
1298         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1299         (roleToString):
1300
1301 2012-08-29  Raphael Kubo da Costa  <rakuco@webkit.org>
1302
1303         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
1304         https://bugs.webkit.org/show_bug.cgi?id=84707
1305
1306         Reviewed by Gustavo Noronha Silva.
1307
1308         Most of the warnings have been fixed now that FindCairo.cmake and
1309         FindGLIB.cmake have been rewritten. The remaining one, related to
1310         FindFontconfig.cmake, shows up when building on a 64-bit
1311         Debian-based systems.
1312
1313         jhbuild installs libraries into lib64/ by default on 64-bit Linux
1314         installations, while CMake does not look for libraries in lib64/
1315         when /etc/debian_version exists on the system. The FIND_LIBRARY()
1316         would then sometimes end up using the system installation instead of
1317         the jhbuild one, causing mismatches and, when pkg-config is not used
1318         at all, failing to find libraries altogether.
1319
1320         * efl/jhbuildrc: Set the CMAKE_LIBRARY_PATH environment variable
1321         when use_lib64 is set to force CMake to look into lib64/ regardless
1322         of the presence of /etc/debian_version.
1323
1324 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
1325
1326         The 2d.imageData.object.round canvas test is failing
1327         https://bugs.webkit.org/show_bug.cgi?id=40272
1328
1329         Reviewed by Benjamin Poulain.
1330
1331         Updating patch to address Benjamin's review comments.
1332         Adding a WTF test to test lrint implementation.
1333
1334         * TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
1335         * TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
1336         * TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
1337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
1338         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
1339         (TestWebKitAPI):
1340         (TestWebKitAPI::TEST):
1341         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
1342
1343 2012-08-29  Florin Malita  <fmalita@chromium.org>
1344
1345         Unreviewed, updating Kelly Norton's email address at his request.
1346
1347         * Scripts/webkitpy/common/config/committers.py:
1348
1349 2012-08-29  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1350
1351         [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files
1352         https://bugs.webkit.org/show_bug.cgi?id=93723
1353
1354         Reviewed by Dirk Pranke.
1355
1356         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1357         (TestExpectationParser.expectation_for_skipped_test):
1358         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1359         (SkippedTests.test_skipped_entry_dont_exist):
1360
1361 2012-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1362
1363         Unreviewed, rolling out r120113.
1364         http://trac.webkit.org/changeset/120113
1365         https://bugs.webkit.org/show_bug.cgi?id=95320
1366
1367         Wrong fix for the problem, experimentally rolling it out for
1368         bug 95237. (Requested by rakuco on #webkit).
1369
1370         * efl/jhbuildrc:
1371
1372 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
1373
1374         AX: Canvas should have a distinct role
1375         https://bugs.webkit.org/show_bug.cgi?id=95248
1376
1377         Reviewed by Chris Fleizach.
1378
1379         Add support for canvas accessibility role.
1380
1381         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1382         (roleToString):
1383
1384 2012-08-28  Eric Seidel  <eric@webkit.org>
1385
1386         cr-ews bot doesn't set CWD correctly when zipping layout test results
1387         https://bugs.webkit.org/show_bug.cgi?id=91265
1388
1389         Reviewed by Kenneth Russell.
1390
1391         This should make the zips slightly less cumbersome to deal with.
1392
1393         * Scripts/webkitpy/common/system/workspace.py:
1394         (Workspace.create_zip):
1395         * Scripts/webkitpy/common/system/workspace_unittest.py:
1396         (WorkspaceTest.test_create_zip):
1397         (WorkspaceTest.test_create_zip_exception):
1398
1399 2012-08-28  Benjamin Poulain  <benjamin@webkit.org>
1400
1401         Fix the Commiters script
1402
1403         Unreviewed.
1404
1405         Remove Roger Fong from the Contributor list, he appears in the Commiter list since r126949.
1406
1407         * Scripts/webkitpy/common/config/committers.py:
1408
1409 2012-08-28  Roger Fong  <roger_fong@apple.com>
1410
1411         Unreviewed. Adding myself to committers list.
1412
1413         * Scripts/webkitpy/common/config/committers.py:
1414
1415 2012-08-28  Roger Fong  <roger_fong@apple.com>
1416
1417         Add minires to list of required cygwin install packages.
1418         https://bugs.webkit.org/show_bug.cgi?id=76936
1419
1420         Reviewed by Tim Horton.
1421
1422         * CygwinDownloader/cygwin-downloader.py:
1423
1424 2012-08-28  Xianzhu Wang  <wangxianzhu@chromium.org>
1425
1426         [Chromium-Android] Upstream layout test expectations (Part 2)
1427         https://bugs.webkit.org/show_bug.cgi?id=95212
1428
1429         Reviewed by Adam Barth.
1430
1431         - Now run both gpu path and non-gpu path of 2d canvas layout tests
1432         because both are used in chromium-android.
1433
1434         - Exclude all webgl tests because webgl is not enabled yet.
1435
1436         - Removed 'win' from the baseline fallback list. This was a mistake.
1437
1438         - Moved some small directories to TestExpectations from skipped_layout_tests().
1439
1440         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1441         (ChromiumAndroidPort):
1442         (ChromiumAndroidPort.skipped_layout_tests):
1443
1444 2012-08-28  Joanmarie Diggs  <jdiggs@igalia.com>
1445
1446         Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
1447         https://bugs.webkit.org/show_bug.cgi?id=95185
1448
1449         Reviewed by Chris Fleizach.
1450
1451         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1452         (AccessibilityUIElement::titleUIElement): Implemented
1453         Gets the ATK_RELATION_LABELLED_BY target.
1454         (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
1455         Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
1456         bug 95180 is fixed.
1457
1458 2012-08-28  Dominic Mazzoni  <dmazzoni@google.com>
1459
1460         AX: Crash due to object getting deleted inside updateBackingStore
1461         https://bugs.webkit.org/show_bug.cgi?id=94619
1462
1463         Reviewed by Chris Fleizach.
1464
1465         Change isValid to !isDetached after deleting isValid from
1466         chromium WebAccessibilityObject as being redundant.
1467
1468         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
1469         (AccessibilityUIElement::isValidGetterCallback):
1470
1471 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1472
1473         Unreviewed, rolling out r126914.
1474         http://trac.webkit.org/changeset/126914
1475         https://bugs.webkit.org/show_bug.cgi?id=95239
1476
1477         it breaks everything and fixes nothing (Requested by pizlo on
1478         #webkit).
1479
1480         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1481         (MockWebSpeechInputController::addMockRecognitionResult):
1482         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1483         (NotificationPresenter::simulateClick):
1484         (NotificationPresenter::show):
1485         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
1486         (CppBoundClass::~CppBoundClass):
1487         (CppBoundClass::invoke):
1488         (CppBoundClass::getProperty):
1489         (CppBoundClass::setProperty):
1490         (CppBoundClass::bindCallback):
1491         (CppBoundClass::bindProperty):
1492         * DumpRenderTree/chromium/WebPreferences.cpp:
1493         (applyFontMap):
1494         * DumpRenderTree/chromium/WebViewHost.cpp:
1495         (WebViewHost::printResourceDescription):
1496         * DumpRenderTree/mac/TestRunnerMac.mm:
1497         (worldIDForWorld):
1498         (TestRunner::evaluateScriptInIsolatedWorld):
1499         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1500         (AccessibilityController::~AccessibilityController):
1501         (AccessibilityController::winNotificationReceived):
1502         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1503         (ResourceLoadDelegate::descriptionSuitableForTestResult):
1504         * DumpRenderTree/win/TestRunnerWin.cpp:
1505         (worldIDForWorld):
1506         (TestRunner::evaluateScriptInIsolatedWorld):
1507         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1508         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
1509         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1510         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
1511         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1512         (WTR::TestRunner::worldIDForWorld):
1513         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
1514
1515 2012-08-28  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1516
1517         Rename first/second to key/value in HashMap iterators
1518         https://bugs.webkit.org/show_bug.cgi?id=82784
1519
1520         Reviewed by Eric Seidel.
1521
1522         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1523         (MockWebSpeechInputController::addMockRecognitionResult):
1524         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1525         (NotificationPresenter::simulateClick):
1526         (NotificationPresenter::show):
1527         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
1528         (CppBoundClass::~CppBoundClass):
1529         (CppBoundClass::invoke):
1530         (CppBoundClass::getProperty):
1531         (CppBoundClass::setProperty):
1532         (CppBoundClass::bindCallback):
1533         (CppBoundClass::bindProperty):
1534         * DumpRenderTree/chromium/WebPreferences.cpp:
1535         (applyFontMap):
1536         * DumpRenderTree/chromium/WebViewHost.cpp:
1537         (WebViewHost::printResourceDescription):
1538         * DumpRenderTree/mac/TestRunnerMac.mm:
1539         (worldIDForWorld):
1540         (TestRunner::evaluateScriptInIsolatedWorld):
1541         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1542         (AccessibilityController::~AccessibilityController):
1543         (AccessibilityController::winNotificationReceived):
1544         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1545         (ResourceLoadDelegate::descriptionSuitableForTestResult):
1546         * DumpRenderTree/win/TestRunnerWin.cpp:
1547         (worldIDForWorld):
1548         (TestRunner::evaluateScriptInIsolatedWorld):
1549         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1550         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
1551         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1552         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
1553         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1554         (WTR::TestRunner::worldIDForWorld):
1555         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
1556
1557 2012-08-27  Jon Lee  <jonlee@apple.com>
1558
1559         Update TestRunner API for web notifications
1560         https://bugs.webkit.org/show_bug.cgi?id=95093
1561         <rdar://problem/12179649>
1562
1563         Reviewed by Jessie Berlin.
1564
1565         This is work toward providing Mac support for web notifications in DRT and WTR (77969).
1566
1567         Some of the legacy APIs are less than ideal, and not tenable with the WTR infrastructure.
1568         This first patch renames the TestRunner calls to use the term "web notifications" instead of
1569         "desktop notifications", deprecates a couple API calls that are not used by anyone, and adds
1570         additional calls that will be used in the tests that test the standard API.
1571
1572         * DumpRenderTree/TestRunner.h:
1573         (TestRunner): For consistency, rename a couple member variables. Remove unused checkDesktopNotificationPermission()
1574         and areDesktopNotificationPermissionRequestsIgnored(). Remove origin mapping since each port implements its own solution.
1575         * DumpRenderTree/TestRunner.cpp: Push grantWebNotificationPermission() to individual ports.
1576         (TestRunner::TestRunner):
1577         (ignoreLegacyWebNotificationPermissionRequestsCallback): Renamed.
1578         (simulateLegacyWebNotificationClickCallback): Renamed.
1579         (grantWebNotificationPermissionCallback): Renamed.
1580         (denyWebNotificationPermissionCallback): Added.
1581         (removeAllWebNotificationPermissionsCallback): Added.
1582         (simulateWebNotificationClickCallback): Added.
1583         (TestRunner::staticFunctions):
1584         (TestRunner::ignoreLegacyWebNotificationPermissionRequests):
1585
1586         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1587         (DRTTestRunner::DRTTestRunner): Added bindings for new APIs.
1588         (DRTTestRunner::grantWebNotificationPermission):
1589         (DRTTestRunner::denyWebNotificationPermission): Stub.
1590         (DRTTestRunner::removeAllWebNotificationPermissions): Stub.
1591         (DRTTestRunner::simulateWebNotificationClick): Stub.
1592         (DRTTestRunner::simulateLegacyWebNotificationClick):
1593         * DumpRenderTree/chromium/DRTTestRunner.h:
1594         (DRTTestRunner):
1595
1596         Added stubs.
1597         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1598         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1599         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1600         * DumpRenderTree/mac/TestRunnerMac.mm: Later patch will contain implementation of this API.
1601         * DumpRenderTree/qt/TestRunnerQt.cpp: Added Qt-based stubs.
1602         * DumpRenderTree/win/TestRunnerWin.cpp:
1603
1604 2012-08-28  Szilard Ledan  <szledan@inf.u-szeged.hu>
1605
1606         [webkit-patch] gets stuck into an infinite loop if bugzilla doesn't respond in time.
1607         https://bugs.webkit.org/show_bug.cgi?id=94700
1608
1609         Reviewed by Eric Seidel.
1610
1611         Interrupting download with a timeout would be a possible solution.
1612         I imported the socket module and used the setdefaulttimeout() method.
1613         Fixing it is important, because EWS bots need to be restarted regularly
1614         because of this bug.
1615
1616         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1617         (Bugzilla._get_browser):
1618         (Bugzilla.setdefaulttimeout):
1619
1620 2012-08-28  Gabor Rapcsanyi  <rgabor@webkit.org>
1621
1622         [Qt] Keep QT_QPA_PLATFORM_PLUGIN_PATH environment variable in NRWT
1623         https://bugs.webkit.org/show_bug.cgi?id=95194
1624
1625         Reviewed by Simon Hausmann.
1626
1627         * Scripts/webkitpy/layout_tests/port/qt.py:
1628         (QtPort.setup_environ_for_server):
1629
1630 2012-08-28  Andras Becsi  <andras.becsi@nokia.com>
1631
1632         [watchlist] Unreviewed, subscribe to Qt bugs.
1633
1634         * Scripts/webkitpy/common/config/watchlist:
1635
1636 2012-08-28  Simon Hausmann  <simon.hausmann@nokia.com>
1637
1638         [Qt] New test introduced in r126611 fails: fast/css/image-set-setting.html
1639         https://bugs.webkit.org/show_bug.cgi?id=95054
1640
1641         Reviewed by Eric Seidel.
1642
1643         Enable CSS_IMAGE_SET for the Qt build.
1644
1645         * qmake/mkspecs/features/features.pri:
1646
1647 2012-08-27  Csaba Osztrogonác  <ossy@webkit.org>
1648
1649         [Qt] Enable CSS sticky position
1650         https://bugs.webkit.org/show_bug.cgi?id=95172
1651
1652         Reviewed by Simon Hausmann.
1653
1654         * qmake/mkspecs/features/features.pri:
1655
1656 2012-08-27  Zan Dobersek  <zandobersek@gmail.com>
1657
1658         [GTK] Memory cache should be cleared in between test runs
1659         https://bugs.webkit.org/show_bug.cgi?id=95105
1660
1661         Reviewed by Martin Robinson.
1662
1663         Call the new DumpRenderTreeSupportGtk helper method after every test
1664         to clear the memory cache.
1665
1666         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1667         (runTest):
1668
1669 2012-08-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1670
1671         Unreviewed, rolling out r126836.
1672         http://trac.webkit.org/changeset/126836
1673         https://bugs.webkit.org/show_bug.cgi?id=95163
1674
1675         Broke all Apple ports, EFL, and Qt. (Requested by tkent on
1676         #webkit).
1677
1678         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1679         (MockWebSpeechInputController::addMockRecognitionResult):
1680         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1681         (NotificationPresenter::simulateClick):
1682         (NotificationPresenter::show):
1683         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
1684         (CppBoundClass::~CppBoundClass):
1685         (CppBoundClass::invoke):
1686         (CppBoundClass::getProperty):
1687         (CppBoundClass::setProperty):
1688         (CppBoundClass::bindCallback):
1689         (CppBoundClass::bindProperty):
1690         * DumpRenderTree/chromium/WebPreferences.cpp:
1691         (applyFontMap):
1692         * DumpRenderTree/chromium/WebViewHost.cpp:
1693         (WebViewHost::printResourceDescription):
1694         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1695         (AccessibilityController::~AccessibilityController):
1696         (AccessibilityController::winNotificationReceived):
1697         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1698         (ResourceLoadDelegate::descriptionSuitableForTestResult):
1699         * DumpRenderTree/win/TestRunnerWin.cpp:
1700         (worldIDForWorld):
1701         (TestRunner::evaluateScriptInIsolatedWorld):
1702         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1703         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
1704         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1705         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
1706         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1707         (WTR::TestRunner::worldIDForWorld):
1708         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
1709
1710 2012-08-27  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1711
1712         Rename first/second to key/value in HashMap iterators
1713         https://bugs.webkit.org/show_bug.cgi?id=82784
1714
1715         Reviewed by Eric Seidel.
1716
1717         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1718         (MockWebSpeechInputController::addMockRecognitionResult):
1719         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1720         (NotificationPresenter::simulateClick):
1721         (NotificationPresenter::show):
1722         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
1723         (CppBoundClass::~CppBoundClass):
1724         (CppBoundClass::invoke):
1725         (CppBoundClass::getProperty):
1726         (CppBoundClass::setProperty):
1727         (CppBoundClass::bindCallback):
1728         (CppBoundClass::bindProperty):
1729         * DumpRenderTree/chromium/WebPreferences.cpp:
1730         (applyFontMap):
1731         * DumpRenderTree/chromium/WebViewHost.cpp:
1732         (WebViewHost::printResourceDescription):
1733         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1734         (AccessibilityController::~AccessibilityController):
1735         (AccessibilityController::winNotificationReceived):
1736         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1737         (ResourceLoadDelegate::descriptionSuitableForTestResult):
1738         * DumpRenderTree/win/TestRunnerWin.cpp:
1739         (worldIDForWorld):
1740         (TestRunner::evaluateScriptInIsolatedWorld):
1741         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1742         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
1743         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1744         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
1745         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1746         (WTR::TestRunner::worldIDForWorld):
1747         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
1748
1749 2012-08-24  James Robinson  <jamesr@chromium.org>
1750
1751         WebGL should not flip textures on presentation if contents are unchanged
1752         https://bugs.webkit.org/show_bug.cgi?id=94961
1753
1754         Reviewed by Kenneth Russell.
1755
1756         Run some compositing webgl tests in threaded mode to catch regressions specific to that mode.
1757
1758         * Scripts/webkitpy/layout_tests/port/chromium.py:
1759         (ChromiumPort.virtual_test_suites):
1760
1761 2012-08-27  Gavin Peters  <gavinp@chromium.org>
1762
1763         [webkit-patch] Don't crash chrome-channels command when a previously unknown platform shows up.
1764         https://bugs.webkit.org/show_bug.cgi?id=95104
1765
1766         Reviewed by Adam Barth.
1767
1768         Today I found out this command was broken by the new iOS platform showing up on omahaproxy. Now the webkit-patch chrome-channels command gracefully handles new, previously unknown platforms. Also, it prints iOS in the proper mixed case.
1769
1770         * Scripts/webkitpy/common/net/omahaproxy.py:
1771         (OmahaProxy):
1772         (OmahaProxy.get_revisions):
1773         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
1774         (OmahaProxyTest):
1775         (OmahaProxyTest.test_get_revisions):
1776
1777 2012-08-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1778
1779         [EFL][WK2] Free Url_Bar on program exit
1780         https://bugs.webkit.org/show_bug.cgi?id=95086
1781
1782         Reviewed by Eric Seidel.
1783
1784         Fix a memory leak by freeing the Url_Bar on program exit.
1785
1786         * MiniBrowser/efl/main.c:
1787         (main): Call url_bar_del() to free the Url_Bar.
1788
1789 2012-08-27  James Robinson  <jamesr@chromium.org>
1790
1791         [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
1792         https://bugs.webkit.org/show_bug.cgi?id=95115
1793
1794         Reviewed by Adam Barth.
1795
1796         Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
1797         code if the unit tests crash.
1798
1799         * Scripts/run-chromium-webkit-unit-tests:
1800
1801 2012-08-27  Benjamin Poulain  <benjamin@webkit.org>
1802
1803         Add ECMAScript Number to String conversion to WTF::String
1804         https://bugs.webkit.org/show_bug.cgi?id=95016
1805
1806         Reviewed by Geoffrey Garen.
1807
1808         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1809         (TestWebKitAPI::testNumberToStringECMAScript):
1810         (TestWebKitAPI): Add tests for String's ECMAString number conversion.
1811
1812 2012-08-27  Philippe Normand  <pnormand@igalia.com>
1813
1814         [GStreamer][Qt] WebAudio support
1815         https://bugs.webkit.org/show_bug.cgi?id=94806
1816
1817         Reviewed by Simon Hausmann.
1818
1819         * MiniBrowser/qt/qml/BrowserWindow.qml: Enable WebAudio support.
1820
1821 2012-08-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1822
1823         Rename RegisterProtocolHandler API to NavigatorContentUtils
1824         https://bugs.webkit.org/show_bug.cgi?id=94920
1825
1826         Reviewed by Adam Barth.
1827
1828         Renamed 'register-protocol-handler' feature to 'navigator-content-utils'.
1829
1830         * Scripts/webkitperl/FeatureList.pm:
1831         * qmake/mkspecs/features/features.pri:
1832
1833 2012-08-24  Benjamin Poulain  <bpoulain@apple.com>
1834
1835         Unify Number to StringImpl conversion
1836         https://bugs.webkit.org/show_bug.cgi?id=94879
1837
1838         Reviewed by Geoffrey Garen.
1839
1840         Add testing for the new IntegerToStringConversion.
1841
1842         * TestWebKitAPI/CMakeLists.txt:
1843         * TestWebKitAPI/GNUmakefile.am:
1844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1845         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp: Added.
1846
1847 2012-08-23  James Robinson  <jamesr@chromium.org>
1848
1849         [chromium] Convert WebLayerTreeView interface into pure virtual
1850         https://bugs.webkit.org/show_bug.cgi?id=94866
1851
1852         Reviewed by Adrienne Walker.
1853
1854         Updates DumpRenderTree's WebViewHost to vend a WebCompositorOutputSurface so DumpRenderTree can run compositing
1855         tests.
1856
1857         * DumpRenderTree/DumpRenderTree.gypi:
1858         * DumpRenderTree/chromium/WebViewHost.cpp:
1859         (WebViewHost::createOutputSurface):
1860         * DumpRenderTree/chromium/WebViewHost.h:
1861         (WebViewHost):
1862         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
1863         (WebKit):
1864         (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
1865         (WebKit::WebViewHostOutputSurface::~WebViewHostOutputSurface):
1866         (WebKit::WebViewHostOutputSurface::bindToClient):
1867         (WebKit::WebViewHostOutputSurface::capabilities):
1868         (WebKit::WebViewHostOutputSurface::context3D):
1869         (WebKit::WebViewHostOutputSurface::sendFrameToParentCompositor):
1870         * DumpRenderTree/chromium/WebViewHostOutputSurface.h: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
1871         (WebKit):
1872         (WebViewHostOutputSurface):
1873
1874 2012-08-24  Xianzhu Wang  <wangxianzhu@chromium.org>
1875
1876         [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
1877         https://bugs.webkit.org/show_bug.cgi?id=94865
1878
1879         Reviewed by Dirk Pranke.
1880
1881         Android detects crash of test by checking if the return value of read() is None.
1882         Added a parameter 'treat_no_data_as_crash' to let ServerProcess know the special requirement of Android.
1883         If set, ServerProcess will set _crashed unconditionaly when there is no data.
1884
1885         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1886         (ChromiumAndroidPort.__init__):
1887         (ChromiumAndroidPort):
1888         (ChromiumAndroidPort._android_server_process_constructor):
1889         (ChromiumAndroidDriver._start_once):
1890         * Scripts/webkitpy/layout_tests/port/server_process.py:
1891         (ServerProcess.__init__):
1892         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1893
1894 2012-08-24  Arnaud Renevier  <a.renevier@sisa.samsung.com>
1895
1896         build-webkit --gtk fails with Can't exec ""
1897         https://bugs.webkit.org/show_bug.cgi?id=94944
1898
1899         Reviewed by Martin Robinson.
1900
1901         When jhbuild wrapper is not needed, do unshift a blank string to build
1902         arguments.
1903
1904         * Scripts/webkitdirs.pm:
1905         (runAutogenForAutotoolsProjectIfNecessary):
1906
1907 2012-08-24  Tommy Widenflycht  <tommyw@google.com>
1908
1909         MediaStream API: Add readyState functionality to RTCPeerConnection
1910         https://bugs.webkit.org/show_bug.cgi?id=94813
1911
1912         Reviewed by Adam Barth.
1913
1914         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1915         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
1916         (MockWebRTCPeerConnectionHandler::stop):
1917         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1918         (MockWebRTCPeerConnectionHandler):
1919
1920 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
1921
1922         Unreviewed. Adding myself to committers list.
1923
1924         Also updated email information.
1925
1926         * Scripts/webkitpy/common/config/committers.py:
1927
1928 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
1929
1930         [Qt][WK2] Make viewport related experimental.test properties encapsulated.
1931         https://bugs.webkit.org/show_bug.cgi?id=88320
1932
1933         Reviewed by Kenneth Rohde Christiansen.
1934
1935         Changed the access to the viewport attributes to use the viewport object that is introduced by this change.
1936
1937         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1938
1939 2012-08-23  Dirk Pranke  <dpranke@chromium.org>
1940
1941         leak detection broken after r126247 on mac
1942         https://bugs.webkit.org/show_bug.cgi?id=94893
1943
1944         Unreviewed, build fix.
1945
1946         Adds is_snowleopard(), is_lion back() in for the mac port. We'll
1947         probably need an is_mountainlion() or equivalent at some point,
1948         I'm guessing (but I've deleted the leopard code).
1949
1950         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1951         (LeakDetector._callstacks_to_exclude_from_leaks):
1952         * Scripts/webkitpy/layout_tests/port/mac.py:
1953         (MacPort):
1954         (MacPort.is_snowleopard):
1955         (MacPort.is_lion):
1956
1957 2012-08-23  Julien Chaffraix  <jchaffraix@webkit.org>
1958
1959         [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
1960         https://bugs.webkit.org/show_bug.cgi?id=94871
1961
1962         Reviewed by Benjamin Poulain.
1963
1964         * TestWebKitAPI/TestWebKitAPI.gypi:
1965         Added the missing files to Chromium's build system.
1966
1967 2012-08-23  Raphael Kubo da Costa  <rakuco@webkit.org>
1968
1969         [watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.
1970
1971         * Scripts/webkitpy/common/config/watchlist:
1972
1973 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
1974
1975         Replay tests take forever to load
1976         https://bugs.webkit.org/show_bug.cgi?id=94764
1977
1978         Reviewed by Adam Barth.
1979
1980         Don't load about:blank at the beginning. This appears to clog the DRT.
1981
1982         * Scripts/webkitpy/performance_tests/perftest.py:
1983         (ReplayPerfTest.run_single):
1984         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1985         (TestReplayPerfTest.test_run_single):
1986         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1987
1988 2012-08-23  Kenneth Russell  <kbr@google.com>
1989
1990         Unreviewed, rolling out r126497.
1991         http://trac.webkit.org/changeset/126497
1992         https://bugs.webkit.org/show_bug.cgi?id=94764
1993
1994         Caused webkitpy-test step to start failing.
1995
1996         * Scripts/webkitpy/performance_tests/perftest.py:
1997         (ReplayPerfTest.run_single):
1998
1999 2012-08-23  Emil A Eklund  <eae@chromium.org>
2000
2001         Add saturation arithmetic support to FractionalLayoutUnit
2002         https://bugs.webkit.org/show_bug.cgi?id=94364
2003
2004         Reviewed by Benjamin Poulain.
2005
2006         Add test for new saturatedArithmetic functions.
2007
2008         * TestWebKitAPI/CMakeLists.txt:
2009         * TestWebKitAPI/GNUmakefile.am:
2010         * TestWebKitAPI/TestWebKitAPI.gypi:
2011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2012         * TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp: Added.
2013         (TestWebKitAPI):
2014         (TestWebKitAPI::TEST):
2015         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2016
2017 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
2018
2019         Replay tests take forever to load
2020         https://bugs.webkit.org/show_bug.cgi?id=94764
2021
2022         Reviewed by Adam Barth.
2023
2024         Don't load about:blank at the beginning. This appears to clog the DRT.
2025
2026         * Scripts/webkitpy/performance_tests/perftest.py:
2027         (ReplayPerfTest.run_single):
2028
2029 2012-08-23  Wei Jia  <wjia@chromium.org>
2030
2031         create different WebKit::WebMediaPlayer based on URL
2032         https://bugs.webkit.org/show_bug.cgi?id=91301
2033
2034         Reviewed by Adam Barth.
2035
2036         Pass URL to createMediaPlayer. This corresponds to change in base
2037         class WebKit::WebFrameClient.
2038
2039         * DumpRenderTree/chromium/WebViewHost.cpp:
2040         (WebViewHost::createMediaPlayer): add URL as additional argument.
2041         * DumpRenderTree/chromium/WebViewHost.h:
2042         (WebViewHost):
2043
2044 2012-08-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2045
2046         Unreviewed, upgrade gyuyoung to reviewer.
2047         http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html
2048
2049         * Scripts/webkitpy/common/config/committers.py:
2050
2051 2012-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2052
2053         REGRESSION(r126306): it broke the plugin process
2054         https://bugs.webkit.org/show_bug.cgi?id=94797
2055
2056         Reviewed by Xan Lopez.
2057
2058         * GNUmakefile.am:
2059
2060 2012-08-23  Ryuan Choi  <ryuan.choi@samsung.com>
2061
2062         [EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
2063         https://bugs.webkit.org/show_bug.cgi?id=63966
2064
2065         Reviewed by Kenneth Rohde Christiansen.
2066
2067         EWebLauncher and MiniBrowser/Efl did not have functionality that users
2068         navigates the site which they want.
2069         This patch adds the urlbar and functionality to load url which users want.
2070
2071         * CMakeLists.txt:
2072         Added to share urlbar theme for both EWebLauncher and MiniBrowser/Efl.
2073         * EWebLauncher/CMakeLists.txt:
2074         Added urlbar.c and dependency of urlbar theme.
2075         In addition, changed macro name to THEME_DIR to share the code easily.
2076         * EWebLauncher/ControlTheme/CMakeLists.txt: Added for urlbar theme.
2077         * EWebLauncher/ControlTheme/entry.edc: Implemented urlbar theme.
2078         * EWebLauncher/main.c:
2079         Implemented to use the urlbar.
2080         In addition, remove unnecessary border of webview to control webview and urlbar easily.
2081         (_ELauncher):
2082         (on_url_changed):
2083         (browserCreate):
2084         (closeWindow):
2085         (findThemePath):
2086         * EWebLauncher/url_bar.c: Implemented functionality of the urlbar.
2087         (_url_bar_url_get_with_protocol):
2088         (on_urlbar_key_down):
2089         (on_urlbar_mouse_down):
2090         (on_urlbar_focus_out):
2091         (url_bar_add):
2092         (url_bar_del):
2093         (url_bar_url_set):
2094         * EWebLauncher/url_bar.h: Added.
2095         * MiniBrowser/efl/CMakeLists.txt:
2096         * MiniBrowser/efl/main.c: Implemented to use the urlbar.
2097         (_MiniBrowser):
2098         (on_url_changed):
2099         (browserCreate):
2100
2101 2012-08-23  Balazs Kelemen  <kbalazs@webkit.org>
2102
2103         [nrwt, WTR] Remove workaround for timeout handing from r126062
2104         https://bugs.webkit.org/show_bug.cgi?id=94609
2105
2106         Reviewed by Dirk Pranke.
2107
2108         Don't try to reset state if a timeout occured but inform
2109         the harness that the web process is no longer reliable.
2110
2111         * Scripts/webkitpy/layout_tests/port/driver.py:
2112         (Driver.run_test): Remove the workaround. Furthermore, handle the case when
2113         the pid is unknown.
2114         * WebKitTestRunner/TestController.cpp:
2115         (WTR::TestController::run):
2116         * WebKitTestRunner/TestInvocation.cpp:
2117         (WTR::TestInvocation::invoke):
2118         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
2119         * WebKitTestRunner/TestInvocation.h:
2120         (TestInvocation):
2121
2122 2012-08-23  Ádám Kallai  <kadam@inf.u-szeged.hu>
2123
2124         Unreviewed. Adding myself to committers list.
2125
2126         * Scripts/webkitpy/common/config/committers.py:
2127
2128 2012-08-22  Alexis Menard  <alexis@webkit.org>
2129
2130         Unreviewed update of my email.
2131
2132         * Scripts/webkitpy/common/config/committers.py:
2133         * Scripts/webkitpy/common/config/watchlist:
2134
2135 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
2136
2137         Fix typos in r126374
2138         https://bugs.webkit.org/show_bug.cgi?id=94665
2139         Unreviewed, build fix.
2140
2141         Fix two issues that snuck in, one that caused a crash if there
2142         were no baselines to optimize and one that occurred as a result
2143         of failing to rename a variable when I changed the recursion to
2144         a loop in the previous patch.
2145
2146         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2147         (BaselineOptimizer._optimize_by_pushing_results_up):
2148
2149 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
2150
2151         Baseline optimizer should try to optimize per-port if global optimization fails
2152         https://bugs.webkit.org/show_bug.cgi?id=94665
2153
2154         Reviewed by Adam Barth.
2155
2156         Add a fallback strategy for optimizing baselines if the default
2157         one fails; this one simply attempts to shift baselines up in the
2158         tree and consolidates them if a parent and child in the fallback
2159         path have the same result. This strategy is somewhat flawed in
2160         that we will always put something in a parent dir even if we
2161         "shouldn't"; for example, if chromium-mac produces a different
2162         result from chromium-win and chromium-linux, then the new
2163         algorithm will move the mac result into platform/chromium,
2164         leaving chromium-mac empty. This result is still correct, but
2165         perhaps confusing.
2166
2167         I haven't done much testing of this algorithm yet, so it's not
2168         clear how many cases where this does a better job than the
2169         default algorithm and how many it'll do a worse job.
2170
2171         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2172         (BaselineOptimizer._find_optimal_result_placement):
2173         (BaselineOptimizer._optimize_by_most_specific_common_directory):
2174         (BaselineOptimizer):
2175         (BaselineOptimizer._optimize_by_pushing_results_up):
2176         (BaselineOptimizer._find_in_fallbackpath):
2177         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2178         (BaselineOptimizerTest.test_platform_mac_different):
2179
2180 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
2181
2182         add debug info, another test to webkit-patch optimize-baselines
2183         https://bugs.webkit.org/show_bug.cgi?id=94762
2184
2185         Reviewed by Adam Barth.
2186
2187         This patch adds more debug logging for optimize-baselines so
2188         that you can tell the before and after states and figure out
2189         what the command is actually deciding to do.
2190
2191         Also, this command adds a (disabled) test for the problem in bug
2192         94665. It's disabled because we don't have the fix yet (that
2193         will be posted in a patch to that bug).
2194
2195         There should be no functional changes in this patch apart from
2196         the additional logging.
2197
2198         Note that adding the debug logging exposed a bug in
2199         filesystem_mock.relpath() (that would return None if the path
2200         wasn't a subpath of the start); the real relpath computes a
2201         relpath with parent dirs. Fixing this revealed a bad check in
2202         the style checker's change_directory() call which was checking
2203         for None.
2204
2205         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2206         (BaselineOptimizer._find_optimal_result_placement):
2207         (BaselineOptimizer):
2208         (BaselineOptimizer._optimize_by_most_specific_common_directory):
2209         (BaselineOptimizer._move_baselines):
2210         (BaselineOptimizer.optimize):
2211         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2212         (BaselineOptimizerTest.disabled_test_platform_mac_different):
2213         * Scripts/webkitpy/common/system/filesystem.py:
2214         (FileSystem):
2215         * Scripts/webkitpy/common/system/filesystem_mock.py:
2216         (MockFileSystem):
2217         (MockFileSystem.__init__):
2218         (MockFileSystem.relpath):
2219         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2220         (RealFileSystemTest.test_sep):
2221         * Scripts/webkitpy/style/main.py:
2222         (change_directory):
2223
2224 2012-08-22  Alejandro Piñeiro  <apinheiro@igalia.com>
2225
2226         Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
2227         https://bugs.webkit.org/show_bug.cgi?id=73819
2228
2229         Reviewed by Chris Fleizach.
2230
2231         Added a new role, Toggle Button, based on whether aria-pressed is present.
2232         http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
2233
2234         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2235         (roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
2236
2237 2012-08-23  Victor Carbune  <victor@rosedu.org>
2238
2239         Add myself to the committer list
2240         https://bugs.webkit.org/show_bug.cgi?id=94659
2241
2242         Reviewed by James Robinson.
2243
2244         Added my email and IRC handle.
2245
2246         * Scripts/webkitpy/common/config/committers.py:
2247
2248 2012-08-22  Scott Graham  <scottmg@chromium.org>
2249
2250         Don't unconditionally define NOMINMAX on Windows
2251         https://bugs.webkit.org/show_bug.cgi?id=94742
2252
2253         Reviewed by Adrienne Walker.
2254
2255         Avoids a warning when building on Windows when NOMINMAX is defined
2256         elsewhere or on the command line.
2257
2258         * TestWebKitAPI/config.h:
2259
2260 2012-08-22  Zan Dobersek  <zandobersek@gmail.com>
2261
2262         REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
2263         https://bugs.webkit.org/show_bug.cgi?id=94704
2264
2265         Reviewed by Dirk Pranke.
2266
2267         Use tolerance=0 when acquiring diff image of reftest output.
2268
2269         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2270         (SingleTestRunner._compare_output_with_reference):
2271
2272 2012-08-22  Tommy Widenflycht  <tommyw@google.com>
2273
2274         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
2275         https://bugs.webkit.org/show_bug.cgi?id=93091
2276
2277         Reviewed by Adam Barth.
2278
2279         Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
2280         to complete the infrastructure for RTCPeerConnection.
2281
2282         * DumpRenderTree/DumpRenderTree.gypi:
2283         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
2284         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
2285         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
2286         (MockWebKitPlatformSupport):
2287         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2288         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
2289         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
2290         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2291         (MockWebRTCPeerConnectionHandler::initialize):
2292         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
2293         (WebKit):
2294         (MockWebRTCPeerConnectionHandler):
2295         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2296
2297 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2298
2299         Merge TestExpectationSerializer into TestExpectationLine
2300         https://bugs.webkit.org/show_bug.cgi?id=94638
2301
2302         Reviewed by Dimitri Glazkov.
2303
2304         Moved all methods except, list_to_string which was moved to TestExpectations
2305         from TestExpectationSerializer to TestExpectationLine and removed TestExpectationSerializer.
2306
2307         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2308         (TestExpectationEditorTests.assert_remove_roundtrip):
2309         (TestExpectationEditorTests.assert_update_roundtrip):
2310         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2311         (ParseError.__repr__):
2312         (TestExpectationLine):
2313         (TestExpectationLine.create_passing_expectation):
2314         (TestExpectationLine.to_string): Moved from TestExpectationSerializer.
2315         (TestExpectationLine.to_csv): Ditto.
2316         (TestExpectationLine._serialize_parsed_expectations): Ditto.
2317         (TestExpectationLine._serialize_parsed_modifiers): Ditto.
2318         (TestExpectationLine._format_line):
2319         (TestExpectations.remove_configuration_from_test):
2320         (TestExpectations.remove_rebaselined_tests):
2321         (TestExpectations.add_skipped_tests):
2322         (TestExpectations):
2323         (TestExpectations.list_to_string): Moved from TestExpectationSerializer.
2324         (TestExpectations.list_to_string.serialize):
2325         (TestExpectations.list_to_string.nones_out):
2326         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2327         (TestExpectationSerializationTests): Renamed from TestExpectationSerializerTests.
2328         (TestExpectationSerializationTests.__init__):
2329         (TestExpectationSerializationTests.assert_round_trip):
2330         (TestExpectationSerializationTests.assert_list_round_trip):
2331         (TestExpectationSerializationTests.test_unparsed_to_string):
2332         (TestExpectationSerializationTests.test_unparsed_list_to_string):
2333         (TestExpectationSerializationTests.test_parsed_to_string):
2334         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
2335         (TestExpectationSerializationTests.test_serialize_parsed_modifier_string):
2336         (TestExpectationSerializationTests.test_format_line):
2337         (TestExpectationSerializationTests.test_reconstitute_only_these):
2338         * Scripts/webkitpy/tool/commands/expectations.py:
2339         (OptimizeExpectations.execute):
2340         * Scripts/webkitpy/tool/commands/queries.py:
2341         (PrintExpectations.execute):
2342         (PrintExpectations._format_lines):
2343         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2344         (GardeningExpectationsUpdater.update_expectations):
2345
2346 2012-08-22  Alexandre Elias  <aelias@chromium.org>
2347
2348         Unreviewed, add aelias@chromium.org to committers
2349
2350         I (aelias@chromium.org) have been approved for commit access and Apple
2351         has confirmed receipt of my committer agreement.
2352
2353         * Scripts/webkitpy/common/config/committers.py:
2354
2355 2012-08-22  Alexey Proskuryakov  <ap@apple.com>
2356
2357         [WK2] Support posting injected bundle messages to a page
2358         https://bugs.webkit.org/show_bug.cgi?id=94630
2359
2360         Reviewed by Sam Weinig.
2361
2362         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2363         * TestWebKitAPI/InjectedBundleController.cpp:
2364         (TestWebKitAPI::InjectedBundleController::initialize):
2365         (TestWebKitAPI::InjectedBundleController::didReceiveMessageToPage):
2366         * TestWebKitAPI/InjectedBundleController.h:
2367         * TestWebKitAPI/InjectedBundleTest.h:
2368         (TestWebKitAPI::InjectedBundleTest::didReceiveMessageToPage):
2369         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2370         (WTR::InjectedBundle::didReceiveMessage):
2371         (WTR::InjectedBundle::didReceiveMessageToPage):
2372         (WTR::InjectedBundle::initialize):
2373         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2374         Updated for new client API call.
2375
2376 2012-08-22  Dominic Mazzoni  <dmazzoni@google.com>
2377
2378         REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
2379         https://bugs.webkit.org/show_bug.cgi?id=94200
2380
2381         Reviewed by Chris Fleizach.
2382
2383         Adds reference counting for AtkObjects referenced by
2384         AccessibilityUIElementGtk. This prevents bogus results and
2385         assertion failures on AccessibilityUIElements whose underlying
2386         object has been deleted (as opposed to just made defunct).
2387
2388         This fixes two tests that were previously failing because of this bug.
2389
2390         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2391         (AccessibilityUIElement::AccessibilityUIElement):
2392         (AccessibilityUIElement::~AccessibilityUIElement):
2393
2394 2012-08-22  Gustavo Noronha Silva  <gns@gnome.org>
2395
2396         [GTK] Split WebCore/platform into a separate library
2397         https://bugs.webkit.org/show_bug.cgi?id=94435
2398
2399         Reviewed by Martin Robinson.
2400
2401         More people have been reporting problems when linking WebCore because
2402         the command line limit is being exceeded. Splitting WebCore a bit more
2403         is in order.
2404
2405         * GNUmakefile.am: link libWebCorePlatform into DRT
2406
2407 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2408
2409         Unreviewed buildfix for Qt-minimal after r126291
2410
2411         Disable smooth scrolling when request-animation-frame has been disabled either
2412         explicitly or as part of --minimal.
2413
2414         * qmake/mkspecs/features/features.prf:
2415
2416 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2417
2418         [Qt] Optionally support smooth-scrolling on all platforms
2419         https://bugs.webkit.org/show_bug.cgi?id=74926
2420
2421         Reviewed by Simon Hausmann.
2422
2423         Enabled SMOOTH_SCROLLING on Qt, and expose the enable scroll animator
2424         setting in QtTestBrowser so it can be tested.
2425
2426         * QtTestBrowser/launcherwindow.cpp:
2427         (LauncherWindow::createChrome):
2428         (LauncherWindow::toggleScrollAnimator):
2429         * QtTestBrowser/launcherwindow.h:
2430         (WindowOptions::WindowOptions):
2431         (WindowOptions):
2432         (LauncherWindow):
2433         * qmake/mkspecs/features/features.pri:
2434
2435 2012-08-22  Dominik Röttsches  <dominik.rottsches@intel.com>
2436
2437         Unreviewed, adding myself to committers.py.
2438
2439         * Scripts/webkitpy/common/config/committers.py:
2440
2441 2012-08-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2442
2443         [GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
2444         https://bugs.webkit.org/show_bug.cgi?id=94669
2445
2446         Reviewed by Carlos Garcia Campos.
2447
2448         Fix memory leaks in DRT's EventSender code.
2449
2450         * DumpRenderTree/gtk/EventSender.cpp:
2451         (getMenuItemTitleCallback): Use JSRetainPtr and don't leak.
2452         (contextClickCallback): Use GOwnPtr to manage memory of a
2453         newly-allocated list automatically.
2454
2455 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
2456
2457         Add mountain lion to perf-tests, layout tests
2458         https://bugs.webkit.org/show_bug.cgi?id=94553
2459
2460         Reviewed by Adam Barth.
2461
2462         This patch adds support for the 'mac-mountainlion' platform and
2463         stamps out the last references to 'mac-leopard' as a supported
2464         name.
2465         
2466         This patch does a small amount of refactoring to try and make
2467         things a little clearer how we treat the "most recent version"
2468         specially for baselines and skipped files, and so you only
2469         should have to touch the VERSION_FALLBACK_ORDER constants on the
2470         ports, but unfortunately changing this list changes a bunch of
2471         the unit tests which are doing exact matches for correctness, so
2472         you have to touch more than a couple files :(. There's probably
2473         still more refactoring that can be done so that we don't have to
2474         do all of this functional testing to feel completely correct.
2475
2476         * Scripts/webkitpy/common/system/platforminfo.py:
2477         (PlatformInfo._determine_mac_version):
2478         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2479         (TestPlatformInfo.test_os_version):
2480         * Scripts/webkitpy/layout_tests/port/apple.py:
2481         (ApplePort.__init__):
2482         (ApplePort):
2483         (ApplePort._skipped_file_search_paths):
2484         (ApplePort._generate_all_test_configurations):
2485         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2486         (ChromiumMacPort):
2487         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2488         (FactoryTest.test_mac):
2489         * Scripts/webkitpy/layout_tests/port/mac.py:
2490         (MacPort):
2491         (MacPort._build_driver_flags):
2492         (MacPort.should_retry_crashes):
2493         (MacPort.default_baseline_search_path):
2494         (MacPort.operating_system):
2495         (MacPort.default_child_processes):
2496         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2497         (MacTest):
2498         (MacTest.test_skipped_file_search_paths):
2499         (test_versions):
2500         (test_baseline_search_path):
2501         * Scripts/webkitpy/layout_tests/port/win.py:
2502         (WinPort):
2503         (WinPort.default_baseline_search_path):
2504
2505 2012-08-21  Zan Dobersek  <zandobersek@gmail.com>
2506
2507         [GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
2508         https://bugs.webkit.org/show_bug.cgi?id=94617
2509
2510         Reviewed by Martin Robinson.
2511
2512         Set the 'enable-file-access-from-file-uris' setting to true when
2513         resetting default values. The other ports do this as well, giving
2514         documents with local security origin permission to load other
2515         local resources.
2516
2517         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2518         (resetDefaultsToConsistentValues):
2519
2520 2012-08-21  Kent Tamura  <tkent@chromium.org>
2521
2522         [Chromium] DRT produces wrong back-forward list
2523         https://bugs.webkit.org/show_bug.cgi?id=94575
2524
2525         Reviewed by Adam Barth.
2526
2527         DRT clears its history state before running every tests. However
2528         HistoryController in WebCore isn't reset. So, it is possible that
2529         'isNewNavigation' flag is false even though the navigation should be
2530         handled as "new" for DRT.
2531
2532         This change might fix a problem of
2533         fast/forms/select/select-state-restore.html (Bug 90207).
2534
2535         * DumpRenderTree/chromium/WebViewHost.cpp:
2536         (WebViewHost::updateForCommittedLoad):
2537         Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
2538         Without this change, a navigation entry for this loading won't be recorded.
2539
2540 2012-08-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2541
2542         [EFL] Enable CSS Text Decoration by default
2543         https://bugs.webkit.org/show_bug.cgi?id=94483
2544
2545         Reviewed by Kenneth Rohde Christiansen.
2546
2547         * Scripts/webkitperl/FeatureList.pm:
2548
2549 2012-08-21  Benjamin Poulain  <bpoulain@apple.com>
2550
2551         Store CString data in the CStringBuffer to avoid the double indirection
2552         https://bugs.webkit.org/show_bug.cgi?id=94562
2553
2554         Reviewed by Darin Adler.
2555
2556         Add test coverage for WTF::CString.
2557
2558         * TestWebKitAPI/CMakeLists.txt:
2559         * TestWebKitAPI/GNUmakefile.am:
2560         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2561         * TestWebKitAPI/Tests/WTF/CString.cpp:
2562
2563 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
2564
2565         Text Autosizing: ::first-letter pseudo-element is incorrectly sized
2566         https://bugs.webkit.org/show_bug.cgi?id=94540
2567
2568         Reviewed by Ojan Vafai.
2569
2570         Revert the changes in bugs 94517 and 94396 so that we are
2571         actually looking for stderr output from ImageDiff and doing
2572         image compares on ref tests on the wk2 ports again.
2573
2574         Also, do an actual diff_image() call if the hash checks fail on
2575         reftests, and only fail the test if we get real diffs (or don't,
2576         for mismatches).
2577
2578         Lastly, clean up the log messages to be more helpful.
2579
2580         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2581         (SingleTestRunner._compare_image):
2582         (SingleTestRunner._compare_output_with_reference):
2583         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2584         (write_test_result):
2585
2586 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
2587
2588         _compare_image() swaps actual and expected images by mistake
2589         https://bugs.webkit.org/show_bug.cgi?id=94567
2590
2591         Reviewed by Ojan Vafai.
2592
2593         Re-work the code so that we consistently pass (expected, actual)
2594         across all of the compare/diff routines.
2595
2596         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2597         (SingleTestRunner._run_compare_test):
2598         (SingleTestRunner._compare_output):
2599         (SingleTestRunner._compare_text):
2600         (SingleTestRunner._compare_audio):
2601         (SingleTestRunner._compare_image):
2602         (SingleTestRunner._run_reftest):
2603         (SingleTestRunner._compare_output_with_reference):
2604         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2605         (write_test_result):
2606
2607 2012-08-21  Adam Barth  <abarth@webkit.org>
2608
2609         Unreviewed. Move the commit-queue to building release only. Previously,
2610         we built debug too, but for some reason the debug build doesn't work on
2611         the bots. We can re-enable debug builds once we fix the underlying
2612         problem.
2613
2614         * Scripts/webkitpy/tool/commands/queues.py:
2615         (CommitQueue.build_style):
2616         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2617
2618 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2619
2620         TestExpectationsParser doesn't warn about test files that don't exist.
2621         https://bugs.webkit.org/show_bug.cgi?id=94632
2622
2623         Reviewed by Dirk Pranke.
2624
2625         Exit early and warn when the test file doesn't exist as well when a test directory doesn't exist.
2626
2627         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2628         (TestExpectationParser._parse_line):
2629         (TestExpectationParser._check_test_exists):
2630         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2631         (test_parse_warning):
2632
2633 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
2634
2635         Move free functions in test_expectations to TestExpectations class
2636         https://bugs.webkit.org/show_bug.cgi?id=94557
2637
2638         Reviewed by Dirk Pranke.
2639
2640         Moved test_result_was_expected, test_remove_pixel_failures, and test_suffixes_for_expectations into TestExpectations
2641         to allow further refactoring.
2642
2643         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2644         (JSONTestResult.did_run_as_expected):
2645         (JSONTestResult._tokenize):
2646         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2647         (TestExpectations):
2648         (TestExpectations.result_was_expected):
2649         (TestExpectations.remove_pixel_failures):
2650         (TestExpectations.has_pixel_failures):
2651         (TestExpectations.suffixes_for_expectations):
2652         (TestExpectations.matches_an_expected_result):
2653         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2654         (MockBugManager.create_bug):
2655         (test_result_was_expected):
2656         (test_remove_pixel_failures):
2657         (test_suffixes_for_expectations):
2658         * Scripts/webkitpy/tool/commands/rebaseline.py:
2659         (RebaselineExpectations._tests_to_rebaseline):
2660
2661 2012-08-21  Simon Hausmann  <simon.hausmann@nokia.com>
2662
2663         Unreviewed build fix for newer Qt 5: The meaning of private_includes changed to be fully
2664         self-contained. The module name is not appended automatically anymore.
2665
2666         * qmake/qt_webkit.pri:
2667
2668 2012-08-20  Xianzhu Wang  <wangxianzhu@chromium.org>
2669
2670         [Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
2671         https://bugs.webkit.org/show_bug.cgi?id=94558
2672
2673         Reviewed by Dirk Pranke.
2674
2675         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2676         (ChromiumAndroidDriver.run_test):
2677
2678 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
2679
2680         Cleanup TestExpectationParser.parse
2681         https://bugs.webkit.org/show_bug.cgi?id=94545
2682
2683         Reviewed by Dirk Pranke.
2684
2685         Refactor TestExpectations to simplify the code.
2686
2687         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2688         (TestExpectationParser.parse): Merged _tokenize_list.
2689         (TestExpectationParser._parse_line): Removed the call to _check_modifiers_against_expectations
2690         since the check is now done in _parser_modifiers.
2691         (TestExpectationParser._parse_modifiers): Merged _check_modifiers_against_expectations.
2692         (TestExpectationParser._tokenize_line): Renamed from _tokenize.
2693         (TestExpectationParser._split_space_separated): No longer calls lower() on all modifiers.
2694         This is done on a local variable in _parse_modifiers, preserving the original case.
2695         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): Check the existence
2696         of 'rebaseline' against parsed modifiers.
2697         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2698         (TestExpectationParserTests._tokenize):
2699         (TestExpectationParserTests.test_tokenize_valid_with_comment): Preserves case.
2700         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): Ditto.
2701         (TestExpectationSerializerTests._tokenize):
2702         (TestExpectationSerializerTests.assert_list_round_trip): Call parse since _tokenize_list has
2703         been merged into parse.
2704         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2705         (PrintExpectationsTest.test_csv): Preserves the case.
2706
2707 2012-08-20  Gustavo Noronha Silva  <gns@gnome.org>
2708
2709         [jhbuild] EFL now runs jhbuild update for every build
2710         https://bugs.webkit.org/show_bug.cgi?id=94267
2711
2712         Reviewed by Martin Robinson.
2713
2714         Try to fix WinCE build by returning the empty string instead of
2715         env when no jhbuild infrastructure is found.
2716
2717         * Scripts/webkitdirs.pm:
2718         (jhbuildWrapperPrefixIfNeeded):
2719
2720 2012-08-20  Benjamin Poulain  <benjamin@webkit.org>
2721
2722         Add a watcher for WTF changes
2723
2724         Unreviewed.
2725
2726         Add myself as a watcher for changes in WTF.
2727
2728         * Scripts/webkitpy/common/config/watchlist:
2729
2730 2012-08-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2731
2732         [EFL] Move jhbuild dependencies based on SVN to tarballs
2733         https://bugs.webkit.org/show_bug.cgi?id=90374
2734
2735         Reviewed by Kenneth Rohde Christiansen.
2736
2737         Moved all the dependencies based on SVN to tarballs taken from a
2738         equivalent snapshot from the official git mirror. This will make
2739         update-webkitefl not dependent on network connection after the first
2740         run. The bots will not fail if EFL SVN server in unreachable.
2741         The reason why git mirror is not used directly is to minimize the
2742         total size of source code we need to download.
2743
2744         * efl/jhbuild.modules:
2745
2746 2012-08-20  Simon Fraser  <simon.fraser@apple.com>
2747
2748         Lots of "error, test and reference image have different properties" in pixel test output
2749         https://bugs.webkit.org/show_bug.cgi?id=92578
2750
2751         Reviewed by Dirk Pranke.
2752
2753         Improve ImageDiff's error reporting when test result image and expected image
2754         differ in their properties.
2755
2756         * DumpRenderTree/cg/ImageDiffCG.cpp:
2757
2758 2012-08-20  Nate Chapin  <japhet@chromium.org>
2759
2760         Unsafe vsprintf usage in TestNetscapePlugin
2761         https://bugs.webkit.org/show_bug.cgi?id=94522
2762
2763         Reviewed by Adam Barth.
2764
2765         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2766         (pluginLogWithArguments): Using vsnprintf instead of vsprintf to ensure we don't overflow
2767             the message buffer.
2768         (testDocumentOpen):
2769         (testWindowOpen):
2770
2771 2012-08-20  George Staikos  <staikos@webkit.org>
2772
2773         [BlackBerry] Enable XHR Response BLOB
2774         https://bugs.webkit.org/show_bug.cgi?id=94525
2775
2776         Reviewed by Rob Buis.
2777
2778         Turn on the XHR response blob feature for the BlackBerry port.
2779
2780         * Scripts/webkitperl/FeatureList.pm: Add the feature and enable it.
2781
2782 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
2783
2784         Fix change for timeout detection to not crash if we have no output :)
2785         https://bugs.webkit.org/show_bug.cgi?id=94505
2786
2787         Unreviewed, build fix.
2788
2789         * Scripts/webkitpy/layout_tests/port/driver.py:
2790         (Driver.run_test):
2791
2792 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
2793
2794         temporarily disable ImageDiff on WK2 ports for ref tests
2795         https://bugs.webkit.org/show_bug.cgi?id=94517
2796
2797         Reviewed by Brady Eidson.
2798
2799         ImageDiff appears to be unable to handle the pngs returned from
2800         WebKitTestRunner, so we disable checking images by default
2801         for ref tests on wk2 ports (unless pixel tests is explicitly enabled).
2802
2803         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2804         (SingleTestRunner._compare_output_with_reference):
2805
2806 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
2807
2808         Add missing FIXME: to previous change.
2809         https://bugs.webkit.org/show_bug.cgi?id=94505
2810
2811         Reviewed by Ojan Vafai.
2812
2813         * Scripts/webkitpy/layout_tests/port/driver.py:
2814         (Driver.run_test):
2815
2816 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
2817
2818         Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
2819         https://bugs.webkit.org/show_bug.cgi?id=94505
2820
2821         Reviewed by Ojan Vafai.
2822
2823         It looks like if the webprocess times out, WTR may tell NRWT
2824         that the test completed, but not properly reset its internal
2825         state, and then return stale output for subsequent tests.
2826
2827         This patch modifies NRWT temporarily to check for
2828         "Timed out waiting for final message from web process" in stdout
2829         and treat that as a timeout (and thus kill WTR); this seems
2830         to solve the cascade of failures, but of course there's probably
2831         still a bug in WTR that needs to be fixed.
2832
2833         * Scripts/webkitpy/layout_tests/port/driver.py:
2834         (Driver.run_test):
2835
2836 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
2837
2838         NRWT reports unexpected EOF
2839         https://bugs.webkit.org/show_bug.cgi?id=94387
2840
2841         Reviewed by Adam Barth.
2842
2843         Stop logging "Unexpected EOF" when we are reading the last few
2844         bytes from stdout/stderr after stopping the subprocess.
2845
2846         * Scripts/webkitpy/layout_tests/port/server_process.py:
2847         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2848         (ServerProcess.stop):
2849
2850 2012-08-20  Brady Eidson  <beidson@apple.com>
2851
2852         Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
2853         https://bugs.webkit.org/show_bug.cgi?id=94506
2854
2855         Reviewed by Dirk Pranke.
2856
2857         When running WK2 tests, don't add the "abort early" command line options.
2858
2859         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2860         (ConfigureBuild.start):
2861         (RunWebKitTests):
2862         (RunWebKitTests.start):
2863         (RunWebKit2Tests.start):
2864
2865 2012-08-19  Stephanie Lewis  <slewis@apple.com>
2866
2867         Add mountain lion to build config.
2868         https://bugs.webkit.org/show_bug.cgi?id=94441
2869
2870         Reviewed by Adam Barth.
2871
2872         Add Mountain Lion to the build trigger configurations.
2873
2874         * Scripts/webkitpy/common/config/build.py:
2875         (_should_file_trigger_build):
2876         * Scripts/webkitpy/common/config/build_unittest.py:
2877         (ShouldBuildTest):
2878         (ShouldBuildTest.test_should_build):
2879
2880 2012-08-17  Kiran Muppala  <cmuppala@apple.com>
2881
2882         Add self to webkit contributors list
2883         https://bugs.webkit.org/show_bug.cgi?id=94409
2884
2885         Reviewed by Dirk Pranke.
2886
2887         Add name, email and irc handle to webkit contributors list.
2888
2889         * Scripts/webkitpy/common/config/committers.py:
2890
2891 2012-08-17  Ryosuke Niwa  <rniwa@webkit.org>
2892
2893         Perfalizer should differentiate results with and without the patch
2894         https://bugs.webkit.org/show_bug.cgi?id=94399
2895
2896         Reviewed by Dirk Pranke.
2897
2898         Add "with 12345" and "without 12345" descriptions in results JSON so that graphs in
2899         the results page are labled accordingly.
2900
2901         Also use _build_without_patch when building without a patch so that we get the right error message.
2902
2903         * Scripts/webkitpy/tool/commands/perfalizer.py:
2904         (PerfalizerTask.run):
2905         (PerfalizerTask._run_perf_test):
2906         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
2907         (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
2908
2909 2012-08-17  Dirk Pranke  <dpranke@chromium.org>
2910
2911         nrwt: don't fail tests if ImageDiff fails on the wk2 ports
2912         https://bugs.webkit.org/show_bug.cgi?id=94396
2913
2914         Reviewed by Ryosuke Niwa.
2915
2916         It appears that WTR is generating PNGs that ImageDiff doesn't
2917         like, and so we're getting lots of "can not get ImageDiff"
2918         errors (see bug 81962). The change in r124581 made this a test
2919         failure, and this is causing the WK2 bots to frequently abort
2920         with 500+ failures. 
2921
2922         This change makes ImageDiff errors not be test failures just for
2923         WK2 for now until we can better triage what's going on.
2924
2925         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2926         (SingleTestRunner._compare_image):
2927
2928 2012-08-17  James Robinson  <jamesr@chromium.org>
2929
2930         [chromium] Add a style check for #include "cc/..." in chromium files
2931         https://bugs.webkit.org/show_bug.cgi?id=94382
2932
2933         Reviewed by Adam Barth.
2934
2935         Adds a style check to make sure new chromium code follows the correct convention for including cc files.
2936
2937         * Scripts/webkitpy/style/checkers/cpp.py:
2938         (check_include_line):
2939         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2940         (OrderOfIncludesTest.test_check_cc_includes):
2941
2942 2012-08-17  Ojan Vafai  <ojan@chromium.org>
2943
2944         Delete some dead code from the flakiness dashboard
2945         https://bugs.webkit.org/show_bug.cgi?id=94380
2946
2947         Reviewed by Dirk Pranke.
2948
2949         This code became dead in one of the refactors of how we handle BuilderGroups.
2950         There's no bug here, it's just dead code.
2951         * TestResultServer/static-dashboards/builders.js:
2952         (requestBuilderList):
2953         (loadBuildersList):
2954
2955 2012-08-17  Jochen Eisinger  <jochen@chromium.org>
2956
2957         [chromium] Add content shell bots to the flakiness dashboard
2958         https://bugs.webkit.org/show_bug.cgi?id=94369
2959
2960         Reviewed by Ojan Vafai.
2961
2962         The bots are named $OS (Content Shell).
2963
2964         * TestResultServer/static-dashboards/builders.js:
2965         (isChromiumWebkitTipOfTreeTestRunner):
2966         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2967
2968 2012-08-17  Shadi Khalek  <shadi@chromium.org>
2969
2970         Add AV perf layout tests to webkit flakiness dashboard
2971         https://bugs.webkit.org/show_bug.cgi?id=94255
2972
2973         Reviewed by Ojan Vafai.
2974
2975         Added missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS.
2976         The isChromiumDepsAVTestRunner() filter does not work on current builder names. 
2977         It assumes the new names they are getting renamed to (AV Linux, AV Win7).
2978
2979         * TestResultServer/static-dashboards/builders.js:
2980         (isChromiumTipOfTreeAVTestRunner):
2981         (loadBuildersList):
2982
2983 2012-08-17  Milian Wolff  <milian.wolff@kdab.com>
2984
2985         [Qt] QtWebKit fails to build with OpenGL support on QNX
2986         https://bugs.webkit.org/show_bug.cgi?id=93278
2987
2988         Reviewed by Noam Rosenthal.
2989
2990         Change the order in which we define WTF_USE_3D_GRAPHICS and ENABLE_WEBGL.
2991         First, we now defined WTF_USE_3D_GRAPHICS=1, but only if QT_CONFIG
2992         contains opengl. Furthermore, we disable this feature on win32-* as usual,
2993         but now also disable it on QNX.
2994
2995         Then, we set ENABLE_WEBGL=1 but only if we previously set WTF_USE_3D_GRAPHICS=1.
2996
2997         * qmake/mkspecs/features/features.prf:
2998
2999 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
3000
3001         [jhbuild] EFL now runs jhbuild update for every build
3002         https://bugs.webkit.org/show_bug.cgi?id=94267
3003
3004         Reviewed by Dirk Pranke.
3005
3006         This change makes EFL's approach to jhbuild more in line with the one
3007         used by WebKitGTK+. update-webkitefl-libs will only be called by build-
3008         webkit if --update-efl is given explicitly. The EWS bot will do that
3009         from now on.
3010
3011         * Scripts/webkitdirs.pm:
3012         (jhbuildWrapperPrefixIfNeeded): return jhbuild wrapper only if the
3013         Dependencies directory exists also for EFL
3014         (generateBuildSystemFromCMakeProject): no longer run update-webkitefl-libs
3015         (buildCMakeProjectOrExit): build update-webkitefl-libs if --update-efl is
3016         given
3017         * Scripts/webkitpy/common/config/ports.py:
3018         (EflPort.build_webkit_command): make EWS bots pass --update-efl to build-webkit
3019         * Scripts/webkitpy/common/config/ports_unittest.py:
3020         (DeprecatedPortTest.test_efl_port): add unit testing for EFL port
3021
3022 2012-08-16  Kent Tamura  <tkent@chromium.org>
3023
3024         Add forms-bugs@chromium.org as a contributor.
3025
3026         * Scripts/webkitpy/common/config/committers.py:
3027
3028 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
3029
3030         Unreviewed warning fix, sys.argv is a python construct.
3031
3032         * Scripts/update-webkitefl-libs:
3033
3034 2012-08-16  Dirk Pranke  <dpranke@chromium.org>
3035
3036         NRWT cutting off the output from LayoutTest run under Valgrind
3037         https://bugs.webkit.org/show_bug.cgi?id=94011
3038
3039         Reviewed by Ojan Vafai.
3040
3041         Make NRWT work with valgrind again ... I needed to rework the
3042         driver infrastructure so that we could get the stderr written
3043         between a test completing and a process being stopped and
3044         associate it with the DriverOutput for the test; this meant that
3045         run_test() needed to stop the driver at the end of the test
3046         directly if/when appropriate. This also entailed reworking
3047         run_test() so that we would gather stderr and stdout
3048         consistently regardless of whether this was a normal test, or
3049         stop_when_done, or a crash or timeout.
3050
3051         Also, I had to rework the process_stop_time() (and renamed it to
3052         driver_stop_timeout) so that it would be longer if --time-out-ms
3053         was long as well (so that valgrind would get enough time to
3054         run), and I reworked driver.stop(kill_directly=True) to just
3055         driver.stop(timeout=0.0).
3056
3057         Lastly, adding the new stop_when_done parameter entailed
3058         touching a lot of test mock functions :(.
3059
3060         This change appeared to be well-covered by existing tests.
3061
3062         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3063         (Worker._run_test):
3064         (Worker._run_test_with_timeout):
3065         (Worker._run_test_in_another_thread):
3066         (Worker._run_test_in_another_thread.SingleTestThread.run):
3067         (Worker._run_test_in_this_thread):
3068         (Worker._run_single_test):
3069         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3070         (run_single_test):
3071         (SingleTestRunner.__init__):
3072         (SingleTestRunner._run_compare_test):
3073         (SingleTestRunner._run_rebaseline):
3074         (SingleTestRunner._run_reftest):
3075         * Scripts/webkitpy/layout_tests/port/base.py:
3076         (Port.driver_stop_timeout):
3077         (Port.variable.default_configuration):
3078         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3079         (ChromiumAndroidPort.driver_stop_timeout):
3080         (ChromiumAndroidDriver.stop):
3081         * Scripts/webkitpy/layout_tests/port/driver.py:
3082         (Driver.run_test):
3083         (Driver.stop):
3084         (DriverProxy.run_test):
3085         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3086         (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
3087         * Scripts/webkitpy/layout_tests/port/server_process.py:
3088         (ServerProcess.write):
3089         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3090         (ServerProcess.stop):
3091         (ServerProcess.kill):
3092         (ServerProcess):
3093         (ServerProcess._kill):
3094         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3095         (TrivialMockPort.__init__):
3096         (MockProc.wait):
3097         (TestServerProcess.test_basic):
3098         * Scripts/webkitpy/layout_tests/port/test.py:
3099         (TestDriver.run_test):
3100         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3101         (get_tests_run.RecordingTestDriver.run_test):
3102         * Scripts/webkitpy/performance_tests/perftest.py:
3103         (PerfTest.run_single):
3104         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3105         (TestPageLoadingPerfTest.MockDriver.run_test):
3106         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
3107         (TestReplayPerfTest.test_run_single.run_test):
3108         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
3109         (TestReplayPerfTest.test_prepare.run_test):
3110         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3111         (MainTest.TestDriver.run_test):
3112
3113 2012-08-16  Roger Fong  <roger_fong@apple.com>
3114
3115         Typo in old-run-webkit-tests script from https://bugs.webkit.org/show_bug.cgi?id=93904.
3116         https://bugs.webkit.org/show_bug.cgi?id=94228
3117
3118         Reviewed by Tim Horton.
3119
3120         I previously made the change but made a typo that causes the script not ignore mismatch ref tests.
3121
3122         * Scripts/old-run-webkit-tests:
3123         (isUsedInReftest):
3124
3125 2012-08-16  Peter Beverloo  <peter@chromium.org>
3126
3127         [Chromium] Pass the --strip-binary argument to the apk test generator
3128         https://bugs.webkit.org/show_bug.cgi?id=94224
3129
3130         Reviewed by Adam Barth.
3131
3132         The native test generator currently relies on the $STRIP environment
3133         variable to be available, which it shouldn't do. Instead, pass it as an
3134         argument to the script. The $STRIP variable is being deprecated.
3135
3136         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3137         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3138
3139 2012-08-16  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3140
3141         [BlackBerry] Update format of JS console message to keep consistent with other ports.
3142         https://bugs.webkit.org/show_bug.cgi?id=94058
3143
3144         Reviewed by Yong Li.
3145         Reviewed internally by George Staikos.
3146
3147         1. Remove line number if it's zero.
3148         2. Print only file name for "file://" URL.
3149
3150         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3151         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
3152
3153 2012-08-16  Simon Hausmann  <simon.hausmann@nokia.com>
3154
3155         [Qt] Make DRT results more reliable on X11
3156
3157         Reviewed by Jocelyn Turcotte.
3158
3159         Disable desktop setting awareness, to prevent QApplication on X11 from reading palette settings from
3160         the running desktop environment.
3161
3162         * DumpRenderTree/qt/main.cpp:
3163         (main):
3164
3165 2012-08-16  Pierre Rossi  <pierre.rossi@gmail.com>
3166
3167         [Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
3168         https://bugs.webkit.org/show_bug.cgi?id=93960
3169
3170         Reviewed by Simon Hausmann.
3171
3172         Following the removal of Qt 4 support from trunk in r124879.
3173
3174         * qmake/mkspecs/features/features.prf:
3175
3176 2012-08-16  Taiju Tsuiki  <tzik@chromium.org>
3177
3178         Add deleteFileSystem support to DumpRenderTree for chromium
3179         https://bugs.webkit.org/show_bug.cgi?id=94071
3180
3181         Reviewed by Kent Tamura.
3182
3183         * DumpRenderTree/chromium/WebViewHost.cpp:
3184         (WebViewHost::deleteFileSystem): Added
3185         * DumpRenderTree/chromium/WebViewHost.h:
3186         (WebViewHost):
3187
3188 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
3189
3190         Rename LayoutTestController to TestRunner in WebKitTestRunner
3191         https://bugs.webkit.org/show_bug.cgi?id=93942
3192
3193         Reviewed by Simon Fraser.
3194
3195         Renamed the class and relevant files.
3196
3197         * WebKitTestRunner/CMakeLists.txt:
3198         * WebKitTestRunner/DerivedSources.make:
3199         * WebKitTestRunner/GNUmakefile.am:
3200         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
3201         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl.
3202         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3203         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3204         (WTR::InjectedBundle::didReceiveMessage):
3205         (WTR::InjectedBundle::beginTesting):
3206         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3207         (WTR::InjectedBundle::testRunner):
3208         (InjectedBundle):
3209         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3210         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed.
3211         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Removed.
3212         * WebKitTestRunner/InjectedBundle/Target.pri:
3213         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp.
3214         * WebKitTestRunner/InjectedBundle/TestRunner.h: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.
3215         (TestRunner):
3216         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Removed.
3217         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp.
3218         (WTR::waitToDumpWatchdogTimerCallback):
3219         (WTR::TestRunner::platformInitialize):
3220         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3221         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3222         (WTR::TestRunner::pathToLocalResource):
3223         (WTR::TestRunner::platformName):
3224         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Removed.
3225         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp.
3226         (WTR::waitToDumpWatchdogTimerCallback):
3227         (WTR::TestRunner::platformInitialize):
3228         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3229         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3230         (WTR::TestRunner::pathToLocalResource):
3231         (WTR::TestRunner::platformName):
3232         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Removed.
3233         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm.
3234         (WTR::TestRunner::platformInitialize):
3235         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3236         (WTR::waitUntilDoneWatchdogTimerFired):
3237         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3238         (WTR::TestRunner::pathToLocalResource):
3239         (WTR::TestRunner::platformName):
3240         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Removed.
3241         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp.
3242         (WTR::WatchdogTimerHelper::timerFired):
3243         (WTR::TestRunner::platformInitialize):
3244         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3245         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3246         (WTR::TestRunner::pathToLocalResource):
3247         (WTR::TestRunner::platformName):
3248         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Removed.
3249         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp.
3250         (WTR::TestRunner::platformInitialize):
3251         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3252         (WTR::waitToDumpWatchdogTimerFired):
3253         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3254         (WTR::TestRunner::pathToLocalResource):
3255         (WTR::TestRunner::platformName):
3256         * WebKitTestRunner/PlatformEfl.cmake:
3257         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3258         * WebKitTestRunner/win/InjectedBundle.vcproj:
3259
3260 2012-08-15  Xianzhu Wang  <wangxianzhu@chromium.org>
3261
3262         [Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
3263         https://bugs.webkit.org/show_bug.cgi?id=94155
3264
3265         Reviewed by Dirk Pranke.
3266
3267         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3268         (ChromiumAndroidPort.create_driver): Force no_timeout=True
3269
3270 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
3271
3272         Add a hyperlink to perf-o-matic from build.webkit.org/root.html
3273         https://bugs.webkit.org/show_bug.cgi?id=93749
3274
3275         Reviewed by Csaba Osztrogonác.
3276
3277         Added the hyperlink to webkit-perf.appspot.com. Also added hyperlinks to the waterfall display
3278         of performance tests.
3279
3280         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3281
3282 2012-08-15  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
3283
3284         [css3-text] Add CSS3 Text decoration compile flag
3285         https://bugs.webkit.org/show_bug.cgi?id=93863
3286
3287         Reviewed by Julien Chaffraix.
3288
3289         This patch handles the compile flag implementation, which will come disabled by
3290         default, thus not exposing the CSS3 text decoration features to the web, unless
3291         when explicitly enabling it with "--css3-text-decoration" build parameter.
3292
3293         * Scripts/webkitperl/FeatureList.pm:
3294         * qmake/mkspecs/features/features.pri:
3295
3296 2012-08-15  Beth Dakin  <bdakin@apple.com>
3297
3298         https://bugs.webkit.org/show_bug.cgi?id=93693
3299         [WK2] REGRESSION(125091): pixel results don't sow scrollbars 
3300         anymore
3301
3302         Reviewed by Sam Weinig.
3303
3304         Use new API WKBundlePageCreateSnapshotWithOptions().
3305         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3306         (WTR::InjectedBundlePage::dump):
3307
3308 2012-08-15  Alexey Proskuryakov  <ap@apple.com>
3309
3310         Add rfong to Bugzilla CC "contributor" list.
3311
3312         * Scripts/webkitpy/common/config/committers.py:
3313
3314 2012-08-15  Scott Graham  <scottmg@chromium.org>
3315
3316         Rename window.internals.fastMallocStatistics to mallocStatistics
3317         https://bugs.webkit.org/show_bug.cgi?id=94033
3318
3319         Reviewed by Adam Barth.
3320
3321         * GNUmakefile.am:
3322         * Scripts/webkitpy/performance_tests/perftest.py:
3323         (PerfTest):
3324         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3325         (test_run_memory_test):
3326
3327 2012-08-15  Peter Beverloo  <peter@chromium.org>
3328
3329         Fix a warning in TestWebKitAPI's MediaTime test-suite
3330         https://bugs.webkit.org/show_bug.cgi?id=94096
3331
3332         Reviewed by Adam Barth.
3333
3334         This warning is visible when building the file with certain GCC versions,
3335         including the one used by Chromium for Android. The warning is visible in
3336         the cr-android build bot output:
3337
3338         MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90
3339
3340         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3341         (TestWebKitAPI::TEST):
3342
3343 2012-08-15  Kevin Funk  <kevin.funk@kdab.com>
3344
3345         Fix the 'git log' call in VCSUtils.pm for Windows
3346         https://bugs.webkit.org/show_bug.cgi?id=94113
3347
3348         Reviewed by Kenneth Rohde Christiansen.
3349
3350         Failed because of invalid enquoting characters.
3351
3352         * Scripts/VCSUtils.pm:
3353
3354 2012-08-14  Gustavo Noronha Silva  <gns@gnome.org>
3355
3356         [jhbuild] move md5sum checking to update-webkit-libs-jhbuild
3357         https://bugs.webkit.org/show_bug.cgi?id=93208
3358
3359         Reviewed by Martin Robinson.
3360
3361         This change makes the md5sum check and saving be done by the script
3362         that performs the dependencies update. build-webkit no longer prefixes
3363         calls to commands with jhbuild-wrapper if jhbuild has not been
3364         bootstrapped by the developer and --update-gtk is not given.
3365
3366         * Scripts/update-webkit-libs-jhbuild:
3367         (getMD5HashForFile): moved from webkitdirs.
3368         (jhbuildConfigurationChanged): ditto.
3369         (saveJhbuildMd5): ditto.
3370         (cleanJhbuild): ditto, and changed to run jhbuild clean before removing
3371         jhbuild.
3372         * Scripts/webkitdirs.pm:
3373         (runAutogenForAutotoolsProjectIfNecessary): use jhbuildWrapperPrefixIfNeeded.
3374         (buildAutotoolsProject): ditto.
3375         (jhbuildWrapperPrefixIfNeeded): add a code branch for GTK+.
3376         (generateBuildSystemFromCMakeProject): call update-webkitefl-libs
3377         unconditionally for EFL.
3378         * jhbuild/jhbuild-wrapper:
3379         (update_webkit_libs_jhbuild): removed, jhbuild-wrapper no longer runs the
3380         update script itself
3381         (ensure_jhbuild): remove update call.
3382
3383 2012-08-15  Christophe Dumez  <christophe.dumez@intel.com>
3384
3385         [WK2] Add support for Web Intents MessagePorts
3386         https://bugs.webkit.org/show_bug.cgi?id=89072
3387
3388         Reviewed by Kenneth Rohde Christiansen.
3389
3390         Use WKBundleIntent instead of WebIntentData in
3391         WebKitTestRunner. WTR now prints the number of
3392         MessagePorts in received Web intents as
3393         expected by the following layout tests:
3394         webintents/web-intents-invoke-port.html
3395         webintents/web-intents-obj-constructor.html
3396
3397         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3398         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
3399         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3400         (WTR::LayoutTestController::deliverWebIntent):
3401
3402 2012-08-14  Ryosuke Niwa  <rniwa@webkit.org>
3403
3404         Build fix after r125516. Revert the erroneous rename since we need to keep exposing
3405         layoutTestController in Chromium port as explained r124785.
3406
3407         * DumpRenderTree/chromium/TestShell.cpp:
3408         (TestShell::bindJSObjectsToWindow):
3409
3410 2012-08-14  Dan Bernstein  <mitz@apple.com>
3411
3412         fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
3413         https://bugs.webkit.org/show_bug.cgi?id=94045
3414
3415         Reviewed by Geoff Garen.
3416
3417         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3418         (-[DumpRenderTreeWindow _hasKeyAppearance]): Added. Returns [self isKeyWindow]. This is
3419         needed now that WebView uses -_hasKeyAppearance instead of -isKeyWindow.
3420
3421 2012-08-14  Alexey Proskuryakov  <ap@apple.com>
3422
3423         [WK2] Fix some typos in MiniBrowser
3424         https://bugs.webkit.org/show_bug.cgi?id=94047
3425
3426         Reviewed by Jon Honeycutt.
3427
3428         * MiniBrowser/mac/AppDelegate.m:
3429         (didReceiveMessageFromInjectedBundle): (-[BrowserAppDelegate init]):
3430         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3431         (didReceiveMessage):
3432         (WKBundleInitialize):
3433
3434 2012-08-14  Roger Fong  <roger_fong@apple.com>
3435
3436         old-run-webkit-tests should skip all file extensions for ref tests, not just .html.
3437         https://bugs.webkit.org/show_bug.cgi?id=93904
3438
3439         Reviewed by Tim Horton.
3440
3441         old-run-webkit-tests ref test only skipped .html test.
3442         They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht.
3443         
3444         * Scripts/old-run-webkit-tests:
3445         (isUsedInReftest): Skip all extensions for ref tests.
3446
3447 2012-08-14  Lauro Neto  <lauro.neto@openbossa.org>
3448
3449         Convert signals/slots to Q_* macros.
3450
3451         [Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
3452         https://bugs.webkit.org/show_bug.cgi?id=93996
3453
3454         Reviewed by Kenneth Rohde Christiansen.
3455
3456         Change usage of keyword-conflicting 'signals' and 'slots' for
3457         Q_SIGNALS and Q_SLOTS macro.
3458
3459         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3460         (NetworkAccessManager):
3461         (WebPage):
3462         * DumpRenderTree/qt/EventSenderQt.h:
3463         (EventSender):
3464         * DumpRenderTree/qt/GCControllerQt.h:
3465         (GCController):
3466         * DumpRenderTree/qt/TestRunnerQt.h:
3467         (TestRunner):
3468         * DumpRenderTree/qt/TextInputControllerQt.h:
3469         (TextInputController):
3470         * MiniBrowser/qt/BrowserWindow.h:
3471         (BrowserWindow):
3472         * MiniBrowser/qt/MiniBrowserApplication.h:
3473         (WindowOptions):
3474         * MiniBrowser/qt/UrlLoader.h:
3475         (UrlLoader):
3476         * QtTestBrowser/cookiejar.h:
3477         (TestBrowserCookieJar):
3478         * QtTestBrowser/fpstimer.h:
3479         (FpsTimer):
3480         * QtTestBrowser/launcherwindow.h:
3481         (LauncherWindow):
3482         * QtTestBrowser/locationedit.h:
3483         (LocationEdit):
3484         * QtTestBrowser/mainwindow.h:
3485         (MainWindow):
3486         * QtTestBrowser/urlloader.h:
3487         (UrlLoader):
3488         * QtTestBrowser/webinspector.h:
3489         (WebInspector):
3490         * QtTestBrowser/webpage.h:
3491         (WebPage):
3492         * QtTestBrowser/webview.h:
3493         (WebViewGraphicsBased):
3494         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3495         (WatchdogTimerHelper):
3496         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3497         (WrapperWindow):
3498         * WebKitTestRunner/qt/main.cpp:
3499         (Launcher):
3500
3501 2012-08-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3502
3503         WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
3504         https://bugs.webkit.org/show_bug.cgi?id=42332
3505
3506         Reviewed by Kenneth Rohde Christiansen.
3507
3508         Added Resource Callbacks logging. Several aux dumping functions are added.
3509
3510         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3511         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3512         (WTR::isFileScheme):
3513         (WTR):
3514         (WTR::pathSuitableForTestResult):
3515         (WTR::urlSuitableForTestResult):
3516         (WTR::InjectedBundlePage::resetAfterTest):
3517         (WTR::dumpRequestDescriptionSuitableForTestResult):
3518         (WTR::dumpResponseDescriptionSuitableForTestResult):
3519         (WTR::dumpErrorDescriptionSuitableForTestResult):
3520         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3521         (WTR::InjectedBundlePage::willSendRequestForFrame):
3522         (WTR::InjectedBundlePage::didReceiveResponseForResource):
3523         (WTR::InjectedBundlePage::didFinishLoadForResource):
3524         (WTR::InjectedBundlePage::didFailLoadForResource):
3525         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3526         (WTR::LayoutTestController::LayoutTestController):
3527         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3528         (WTR::LayoutTestController::dumpResourceLoadCallbacks):
3529         (WTR::LayoutTestController::shouldDumpResourceLoadCallbacks):
3530         (LayoutTestController):
3531
3532 2012-08-14  Alexis Menard  <alexis.menard@openbossa.org>
3533
3534         Update INdT build bot to Mountain Lion.
3535         https://bugs.webkit.org/show_bug.cgi?id=93963
3536
3537         Reviewed by Csaba Osztrogonác.
3538
3539         We updated the machine as well as the OS as the Qt port is now running
3540         on top of Qt5.
3541
3542         * BuildSlaveSupport/build.webkit.org-config/config.json:
3543
3544 2012-08-14  Peter Beverloo  <peter@chromium.org>
3545
3546         [Chromium] Remove unneeded build logic for Android
3547         https://bugs.webkit.org/show_bug.cgi?id=93962
3548
3549         Reviewed by Dimitri Glazkov.
3550
3551         The Android SDK and NDK have been checked in to the Chromium tree, which
3552         allows WebKit to leverage those as well. They will already be pulled in
3553         through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
3554         environment variable, the envsetup.sh will set the project files up
3555         appropriately for us.
3556
3557         * Scripts/webkitdirs.pm:
3558
3559 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
3560
3561         [WK2] [GTK] Plugin tests failing in WK2 bot
3562         https://bugs.webkit.org/show_bug.cgi?id=93954
3563
3564         Reviewed by Carlos Garcia Campos.
3565
3566         Plugin tests are failing in the WK2 bot because we aren't exporting
3567         the Netscape plugin when creating the product archive.
3568
3569         * BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
3570         to the list of directories to export.
3571         (archiveBuiltProduct):
3572
3573 2012-08-14  Peter Beverloo  <peter@chromium.org>
3574
3575         [Chromium] Fix apk generation for the Android platform
3576         https://bugs.webkit.org/show_bug.cgi?id=93841
3577
3578         Unreviewed build fix.
3579
3580         APK generation was broken as the configuration file assumed compilation
3581         would only occur in the Chromium tree. Pass the path to Chromium's source
3582         base directory as a property to ant.
3583
3584         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3585         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3586
3587 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
3588
3589         [GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
3590         https://bugs.webkit.org/show_bug.cgi?id=91083
3591
3592         Reviewed by Carlos Garcia Campos.
3593
3594         Unskipped a couple of API tests that should work fine from now on.
3595
3596         * Scripts/run-gtk-tests:
3597         (TestRunner):
3598
3599 2012-08-14  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3600
3601         [NRWT] Compare results between different platforms
3602         https://bugs.webkit.org/show_bug.cgi?id=90555
3603
3604         Reviewed by Dirk Pranke.
3605
3606         * Scripts/webkitpy/layout_tests/port/base.py:
3607         (Port.baseline_search_path):
3608         (Port):
3609         (Port.compare_baseline):
3610         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3611         (parse_args):
3612
3613 2012-08-13  Ryosuke Niwa  <rniwa@webkit.org>
3614
3615         Rename LayoutTestController to TestRunner in DumpRenderTree
3616         https://bugs.webkit.org/show_bug.cgi?id=93758
3617
3618         Reviewed by Tony Chang.
3619
3620         Renamed LayoutTestController to TestRunner. For Chromium port, it's renamed to DRTTestRunner
3621         since it already has TestRunner class shared between DumpRenderTree and content_shell.
3622
3623         * DumpRenderTree/DumpRenderTree.h:
3624         * DumpRenderTree/PixelDumpSupport.cpp:
3625         * DumpRenderTree/StorageTrackerDelegate.h:
3626         * DumpRenderTree/StorageTrackerDelegate.mm:
3627         * DumpRenderTree/TestRunner.cpp:
3628         * DumpRenderTree/TestRunner.h:
3629         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3630         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3631         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3632         * DumpRenderTree/chromium/DRTTestRunner.h:
3633         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3634         * DumpRenderTree/chromium/NotificationPresenter.h:
3635         * DumpRenderTree/chromium/TestShell.cpp:
3636         * DumpRenderTree/chromium/TestShell.h:
3637         * DumpRenderTree/chromium/WebPermissions.cpp:
3638         * DumpRenderTree/chromium/WebPermissions.h:
3639         * DumpRenderTree/chromium/WebViewHost.cpp:
3640         * DumpRenderTree/chromium/WebViewHost.h:
3641         * DumpRenderTree/efl/DumpRenderTree.cpp:
3642         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3643         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3644         * DumpRenderTree/efl/EditingCallbacks.cpp:
3645         * DumpRenderTree/efl/TestRunnerEfl.cpp: