REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using...
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-13  Chris Dumez  <cdumez@apple.com>
2
3         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4         https://bugs.webkit.org/show_bug.cgi?id=195684
5         <rdar://problem/48294714>
6
7         Reviewed by Antti Koivisto.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12
13 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
14
15         [ews-app] Remove unused patch view
16         https://bugs.webkit.org/show_bug.cgi?id=195669
17
18         Reviewed by Lucas Forschler.
19
20         * BuildSlaveSupport/ews-app/ews/urls.py:
21         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
22
23 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
24
25         [ews-app] Use Buildbot result code variables
26         https://bugs.webkit.org/show_bug.cgi?id=195668
27
28         Reviewed by Alexey Proskuryakov.
29
30         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
31         (Buildbot): Added Buildbot result code variables.
32         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
33         (StatusBubble._build_bubble): Used Buildbot result code variables.
34
35 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
36
37         [Flatpak] Expand submodule recursively
38         https://bugs.webkit.org/show_bug.cgi?id=195672
39
40         Building WPE with flatpak was impossible without that as it was raising an exception.
41         Also update wpebackend-fdo to match what is built in jhbuild
42
43         Reviewed by Philippe Normand.
44
45         * flatpak/flatpakutils.py:
46         (expand_submodules_recurse):
47         (expand_manifest):
48         * flatpak/org.webkit.WPEModules.yaml:
49
50 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
51
52         [ews-app] status bubble should be hidden for certain builds
53         https://bugs.webkit.org/show_bug.cgi?id=194597
54
55         Reviewed by Dewei Zhu.
56
57         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
58         (StatusBubble._build_bubble):
59         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
60         because the patch didn't have relevant changes.
61         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
62         in production yet.
63
64 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
65
66         [Win] Fix a slew of simple clang-cl warnings.
67         https://bugs.webkit.org/show_bug.cgi?id=195652
68
69         Reviewed by Don Olmstead.
70
71         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
72         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
73
74 2019-03-12  Justin Fan  <justin_fan@apple.com>
75
76         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
77         https://bugs.webkit.org/show_bug.cgi?id=195518
78         <rdar://problem/46322356>
79
80         Reviewed by Myles C. Maxfield.
81
82         * DumpRenderTree/DerivedSources-input.xcfilelist:
83         * DumpRenderTree/DerivedSources-output.xcfilelist:
84
85 2019-03-12  Commit Queue  <commit-queue@webkit.org>
86
87         Unreviewed, rolling out r242825.
88         https://bugs.webkit.org/show_bug.cgi?id=195648
89
90         "Broke webkitpy tests with my change to
91         lldb_dump_class_layout.py" (Requested by rmorisset on
92         #webkit).
93
94         Reverted changeset:
95
96         "Alter Tools/Scripts/dump-class-layout to be able to dump all
97         classes with suspicious padding"
98         https://bugs.webkit.org/show_bug.cgi?id=195573
99         https://trac.webkit.org/changeset/242825
100
101 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
102
103         [ews-build] Show status bubbles while the patch is waiting in queue
104         https://bugs.webkit.org/show_bug.cgi?id=195618
105
106         Reviewed by Lucas Forschler.
107
108         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
109         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
110         enabled in initial deployment.
111         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
112         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
113         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
114         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
115         (StatusBubble._build_bubbles_for_patch):
116
117 2019-03-12  Robin Morisset  <rmorisset@apple.com>
118
119         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
120         https://bugs.webkit.org/show_bug.cgi?id=195573
121
122         Reviewed by Simon Fraser.
123
124         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
125
126         * Scripts/dump-class-layout:
127         (main):
128         * lldb/lldb_dump_class_layout.py:
129         (ClassLayout.__init__):
130         (ClassLayout._compute_padding_recursive):
131         (LLDBDebuggerInstance.dump_layout_for_classname):
132         (LLDBDebuggerInstance):
133         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
134         (LLDBDebuggerInstance.layout_for_classname): Deleted.
135
136 2019-03-12  Chris Dumez  <cdumez@apple.com>
137
138         Device Orientation access permission should be denied unless explicitly granted by the client
139         https://bugs.webkit.org/show_bug.cgi?id=195625
140
141         Reviewed by Youenn Fablet.
142
143         add API test coverage.
144
145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
146         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
147         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
148         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
149         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
150         (runDeviceOrientationTest):
151         (TEST):
152         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
153         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
154
155 2019-03-12  Jer Noble  <jer.noble@apple.com>
156
157         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
158         https://bugs.webkit.org/show_bug.cgi?id=195137
159         <rdar://problem/48810307>
160
161         Reviewed by Eric Carlson.
162
163         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
164         (TestWebKitAPI::TEST):
165
166 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
167
168         [ews-build] Change urls from uat to production
169         https://bugs.webkit.org/show_bug.cgi?id=195566
170
171         Reviewed by Lucas Forschler.
172
173         * BuildSlaveSupport/ews-app/ews/config.py:
174         * BuildSlaveSupport/ews-build/events.py:
175         * BuildSlaveSupport/ews-build/steps.py:
176
177 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
178
179         [ews-build] change max_builds for local-worker to 1
180         https://bugs.webkit.org/show_bug.cgi?id=195568
181
182         Reviewed by Lucas Forschler.
183
184         * BuildSlaveSupport/ews-build/loadConfig.py:
185
186 2019-03-12  Tim Horton  <timothy_horton@apple.com>
187
188         Fix the build
189
190         * TestRunnerShared/spi/PencilKitTestSPI.h:
191         * TestWebKitAPI/ios/PencilKitTestSPI.h:
192
193 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
194
195         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
196         https://bugs.webkit.org/show_bug.cgi?id=194131
197
198         Reviewed by Michael Catanzaro.
199
200         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
201         (uriChanged):
202         (testUnfinishedSubresourceLoad):
203         (serverCallback):
204         (beforeAll):
205
206 2019-03-11  Alex Christensen  <achristensen@webkit.org>
207
208         WTF::Expected should use std::addressof instead of operator&
209         https://bugs.webkit.org/show_bug.cgi?id=195604
210
211         Reviewed by Myles Maxfield.
212
213         * TestWebKitAPI/Tests/WTF/Expected.cpp:
214         (TestWebKitAPI::Unique::Unique):
215         (TestWebKitAPI::Unique::operator&):
216         (TestWebKitAPI::TEST):
217
218 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
219
220         Add Optional to Forward.h.
221         https://bugs.webkit.org/show_bug.cgi?id=195586
222
223         Reviewed by Darin Adler.
224
225         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
226         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
227         Remove unnecessary includes from headers.
228
229 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
230
231         Add testing API to hit-test and scroll overflow scrollers
232         https://bugs.webkit.org/show_bug.cgi?id=195278
233
234         Reviewed by Antti Koivisto.
235         
236         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
237         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
238         
239         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
240
241         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
242         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
243         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
244         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
245         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
246         * TestRunnerShared/UIScriptContext/UIScriptController.h:
247         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
248         (WTR::enclosingScrollViewIncludingSelf):
249         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
250
251 2019-03-11  Tim Horton  <timothy_horton@apple.com>
252
253         API test WebKit.RequestTextInputContext fails on iOS
254         https://bugs.webkit.org/show_bug.cgi?id=195585
255
256         Reviewed by Wenson Hsieh and Simon Fraser.
257
258         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
259         (applyStyle):
260         (TEST):
261         Add a viewport, so that the coordinates match up on iOS.
262         Scroll by moving the UIScrollView's contentOffset.
263
264 2019-03-11  Chris Dumez  <cdumez@apple.com>
265
266         Assert in WebPageProxy::suspendCurrentPageIfPossible()
267         https://bugs.webkit.org/show_bug.cgi?id=195506
268         <rdar://problem/48733477>
269
270         Reviewed by Alex Christensen.
271
272         Add API test coverage.
273
274         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
275
276 2019-03-11  Shawn Roberts  <sroberts@apple.com>
277
278         Adding myself to contributors.json
279
280         Unreviewed, addming myself to contributors.json .
281
282         * Scripts/webkitpy/common/config/contributors.json:
283
284 2019-03-11  Alex Christensen  <achristensen@webkit.org>
285
286         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
287         https://bugs.webkit.org/show_bug.cgi?id=195511
288         <rdar://problem/44873269>
289
290         Reviewed by Darin Adler.
291
292         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
293         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
294         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
295         (TEST_F):
296
297 2019-03-11  Chris Dumez  <cdumez@apple.com>
298
299         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
300         https://bugs.webkit.org/show_bug.cgi?id=195561
301
302         Reviewed by Youenn Fablet.
303
304         Make sure the JS in the test requests for permission to receive device orientation events.
305
306         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
307
308 2019-03-11  Youenn Fablet  <youenn@apple.com>
309
310         Allow storage quota increase by default in WTR
311         https://bugs.webkit.org/show_bug.cgi?id=195541
312
313         Reviewed by Geoffrey Garen.
314
315         Allow storage quota increase by default in WTR.
316         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
317         Use this for tests that explicitly need cache increase.
318
319         Instead of increasing quota by 2, make sure the next request is
320         granted by adding all given parameters.
321
322         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
323         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
324         (WTR::TestRunner::setAllowStorageQuotaIncrease):
325         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
326         * WebKitTestRunner/InjectedBundle/TestRunner.h:
327         * WebKitTestRunner/TestController.cpp:
328         (WTR::TestController::setAllowStorageQuotaIncrease):
329         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
330         * WebKitTestRunner/TestController.h:
331         * WebKitTestRunner/TestInvocation.cpp:
332         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
333         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
334         (WTR::TestController::cocoaResetStateToConsistentValues):
335         (WTR::TestController::setAllowStorageQuotaIncrease):
336         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
337         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
338         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
339
340 2019-03-11  Xan Lopez  <xan@igalia.com>
341
342         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
343         https://bugs.webkit.org/show_bug.cgi?id=194147
344
345         Reviewed by Michael Saboff.
346
347         To make --32-bit work correctly on Linux/64bit we need to:
348
349         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
350         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
351         unfortunately CMake only allows us to do this during
352         crosscompilation, which is overkill here.
353         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
354         pkg-config detection module uses the x86 .pc files instead of the
355         x86_64 ones.
356         - Set the -m32 flags for the compiler.
357
358         * Scripts/webkitdirs.pm:
359         (generateBuildSystemFromCMakeProject):
360
361 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
362
363         Add MotionMark-1.1 plan file for run-benchmark script.
364         https://bugs.webkit.org/show_bug.cgi?id=195481
365
366         Rubber-stamped by Darin Adler.
367
368         Run-benchmark script should support MontionMark-1.1.
369
370         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
371
372 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
373
374         [ews-app] Add support for submit-to-ews url
375         https://bugs.webkit.org/show_bug.cgi?id=195477
376
377         Reviewed by Lucas Forschler.
378
379         * BuildSlaveSupport/ews-app/ews/fetcher.py:
380         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
381         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
382         * BuildSlaveSupport/ews-app/ews/urls.py:
383         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
384
385 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
386
387         Unreviewed, rolling out r242688, r242643, r242624.
388
389         Caused multiple layout test failures and crashes on iOS and macOS.
390
391         Reverted changeset:
392
393         "requestAnimationFrame should execute before the next frame"
394         https://bugs.webkit.org/show_bug.cgi?id=177484
395         https://trac.webkit.org/changeset/242624/webkit
396
397         * Tracing/SystemTracePoints.plist:
398
399 2019-03-11  John Wilander  <wilander@apple.com>
400
401         Resource Load Statistics: Make it possible exclude localhost from classification
402         https://bugs.webkit.org/show_bug.cgi?id=195474
403         <rdar://problem/47520577>
404
405         Reviewed by Brent Fulgham.
406
407         This patch allows for localhost to be excluded from classification and
408         treatment as a prevalent resource.
409
410         The WebKit Tools change adds a new function called
411         testRunner.setStatisticsIsRunningTest() which can be used to control this
412         behavior.
413
414         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
415         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
416         (WTR::TestRunner::setStatisticsIsRunningTest):
417         * WebKitTestRunner/InjectedBundle/TestRunner.h:
418         * WebKitTestRunner/TestController.cpp:
419         (WTR::TestController::setStatisticsIsRunningTest):
420         * WebKitTestRunner/TestController.h:
421         * WebKitTestRunner/TestInvocation.cpp:
422         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
423
424 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
425
426         [ews-build] Disable waterfall and console view for ews-build.webkit.org
427         https://bugs.webkit.org/show_bug.cgi?id=195560
428
429         Reviewed by Lucas Forschler.
430
431         * BuildSlaveSupport/ews-build/master.cfg:
432
433 2019-03-11  Alex Christensen  <achristensen@webkit.org>
434
435         Unreviewed, rolling out r242698.
436
437         API test crashes on bots.
438
439         Reverted changeset:
440
441         "Add a WKContentRuleList variant that uses copied memory
442         instead of mmap'd shared memory for class A containerized
443         apps"
444         https://bugs.webkit.org/show_bug.cgi?id=195511
445         https://trac.webkit.org/changeset/242698
446
447 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
448
449         [WPE] Enable web process sandbox
450         https://bugs.webkit.org/show_bug.cgi?id=195169
451
452         Reviewed by Daniel Bates.
453
454         * wpe/install-dependencies:
455         * wpe/jhbuild.modules:
456
457 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
458
459         [ews-app] Use port 17000 for worker communication
460         https://bugs.webkit.org/show_bug.cgi?id=195558
461
462         Reviewed by Lucas Forschler.
463
464         * BuildSlaveSupport/ews-build/master.cfg:
465
466 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
467
468         [ews-build] unit-tests fail when passwords.json is missing
469         https://bugs.webkit.org/show_bug.cgi?id=195557
470
471         Reviewed by Lucas Forschler.
472
473         * BuildSlaveSupport/ews-build/loadConfig.py:
474         (loadBuilderConfig):
475         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
476         (ConfigDotJSONTest.test_configuration):
477         * BuildSlaveSupport/ews-build/master.cfg:
478
479 2019-03-11  Truitt Savell  <tsavell@apple.com>
480
481         Unreviewed, rolling out r242702.
482
483         Broke High Sierra builders.
484
485         Reverted changeset:
486
487         "Add utility function to allow easy reverse range-based
488         iteration of a container"
489         https://bugs.webkit.org/show_bug.cgi?id=195542
490         https://trac.webkit.org/changeset/242702
491
492 2019-03-11  Sam Weinig  <sam@webkit.org>
493
494         Add utility function to allow easy reverse range-based iteration of a container
495         https://bugs.webkit.org/show_bug.cgi?id=195542
496
497         Reviewed by Antti Koivisto.
498
499         * TestWebKitAPI/CMakeLists.txt:
500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
501         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
502         (TestWebKitAPI::TEST):
503         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
504
505 2019-03-10  Alex Christensen  <achristensen@webkit.org>
506
507         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
508         https://bugs.webkit.org/show_bug.cgi?id=195511
509         <rdar://problem/44873269>
510
511         Reviewed by Darin Adler.
512
513         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
514         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
515         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
516         (TEST_F):
517
518 2019-03-10  Tim Horton  <timothy_horton@apple.com>
519
520         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
521         https://bugs.webkit.org/show_bug.cgi?id=195499
522
523         Reviewed by Darin Adler.
524
525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
526         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
527         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
528         (-[WKWebView synchronouslyFocusTextInputContext:]):
529         (applyStyle):
530         (applyIframe):
531         (TEST):
532         Add some tests for this SPI.
533
534 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
535
536         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
537         https://bugs.webkit.org/show_bug.cgi?id=181151
538
539         Reviewed by Don Olmstead.
540
541         * TestWebKitAPI/CMakeLists.txt:
542         * TestWebKitAPI/PlatformWin.cmake:
543         Enable TestWTF RunLoop tests in all platforms.
544
545         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
546         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
547         (TestWebKitAPI::DerivedOneShotTimer::fired):
548         (TestWebKitAPI::TEST):
549         Only a few platforms support nested RunLoop.
550
551         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
552         (TestWebKitAPI::DerivedRepeatingTimer::fired):
553
554 2019-03-10  David Quesada  <david_quesada@apple.com>
555
556         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
557         https://bugs.webkit.org/show_bug.cgi?id=152480
558
559         Reviewed by Chris Dumez.
560
561         Add a unit test based on Daniel Bates's test case that starts a download, ensures
562         there are no additional references to the process pool besides the one held by
563         the download, waits for the download to finish (in the sense that the
564         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
565         measure, also check that the process pool has been deallocated at the end of the
566         test. The test wouldn't be meaningful if the process pool were still alive.
567
568         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
569         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
570         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
571             The download will be canceled because the delegate does not implement the
572             method to decide the download's destination, so this is where we know the
573             DownloadProxyMap is done with the DownloadProxy.
574         (TEST):
575
576 2019-03-08  Chris Dumez  <cdumez@apple.com>
577
578         Add support for Device Orientation / Motion permission API
579         https://bugs.webkit.org/show_bug.cgi?id=195329
580         <rdar://problem/47645367>
581
582         Reviewed by Geoffrey Garen.
583
584         Add test infrastructure to help test the Device Orientation / Motion permission API.
585
586         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
588         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
589         * WebKitTestRunner/InjectedBundle/TestRunner.h:
590         * WebKitTestRunner/TestController.cpp:
591         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
592         (WTR::TestController::createWebViewWithOptions):
593         (WTR::TestController::resetStateToConsistentValues):
594         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
595         * WebKitTestRunner/TestController.h:
596         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
597         * WebKitTestRunner/TestInvocation.cpp:
598         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
599
600 2019-03-08  Saam barati  <sbarati@apple.com>
601
602         Add a compare-results script to compare benchmark results
603         https://bugs.webkit.org/show_bug.cgi?id=195486
604         <rdar://problem/48723397>
605
606         Reviewed by Geoffrey Garen.
607
608         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
609         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
610         to extend it to learn about our other benchmarks.
611
612         * Scripts/compare-results: Added.
613         (readJSONFile):
614         (detectJetStream2):
615         (JetStream2Results):
616         (detectSpeedometer2):
617         (Speedometer2Results):
618         (detectPLT5):
619         (PLT5Results):
620         (detectBenchmark):
621         (biggerIsBetter):
622         (ttest):
623         (getOptions):
624         (main):
625
626 2019-03-08  Stephanie Lewis  <slewis@apple.com>
627
628         Ensure old tab state is cleared between iterations of run-benchmark
629         https://bugs.webkit.org/show_bug.cgi?id=195393
630         <rdar://problem/46885583>
631
632         Reviewed by Dewei Zhu.
633
634         a) ensure the default to restore state is not set
635         b) terminate Safari correctly
636         c) Set the system default to ignore Persistent State in Safari
637
638         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
639         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
640         (OSXBrowserDriver.prepare_env): 
641         (OSXBrowserDriver.restore_env):
642         (OSXBrowserDriver.close_browsers):
643         (OSXBrowserDriver._terminate_processes):
644         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
645         (OSXChromeDriver):
646         (OSXChromeCanaryDriver):
647         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
648         (OSXFirefoxDriver):
649         (OSXFirefoxNightlyDriver):
650         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
651         (OSXSafariDriver):
652         (OSXSafariDriver.prepare_env):
653
654 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
655
656         [GTK] Several InputMethodFilter tests are failing
657         https://bugs.webkit.org/show_bug.cgi?id=195408
658
659         Reviewed by Carlos Garcia Campos.
660
661         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
662         Regressed in r241751.
663         Hexadecimal values of keycodes are expressed now in upper letters.
664         Composited characters should be cast to UTF8 strings.
665
666         (TestWebKitAPI::TEST):
667
668 2019-03-07  Tomas Popela  <tpopela@redhat.com>
669
670         [GTK] Make Tools/gtkdoc python3 compatible
671         https://bugs.webkit.org/show_bug.cgi?id=195359
672
673         Reviewed by Carlos Garcia Campos.
674
675         * gtkdoc/generate-gtkdoc:
676         ConfigParser was reworked in Python 3.2 so we have adapt the code to
677         work with Python 2 and 3.
678         (get_gtkdoc_module_paths):
679         The iteritems() was removed in Python 3, so let's use items() that's
680         available in Python 2 and 3.
681         (get_generator_for_config):
682         * gtkdoc/gtkdoc.py:
683         (GTKDoc._run_command):
684         The sys.stdout.write() is expecting str in Python 3 and not bytes
685         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
686         for passing the bytes there.
687
688 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
689
690         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
691         https://bugs.webkit.org/show_bug.cgi?id=195346
692         <rdar://problem/48667048>
693
694         Unreviewed build fix for clang-cl.
695
696         * DumpRenderTree/win/DumpRenderTree.cpp:
697         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
698
699 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
700
701         requestAnimationFrame should execute before the next frame
702         https://bugs.webkit.org/show_bug.cgi?id=177484
703
704         Reviewed by Simon Fraser.
705
706         Add trace points for the page RenderingUpdate.
707
708         * Tracing/SystemTracePoints.plist:
709
710 2019-03-07  Zalan Bujtas  <zalan@apple.com>
711
712         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
713         https://bugs.webkit.org/show_bug.cgi?id=195353
714         <rdar://problem/48626394>
715
716         Reviewed by Simon Fraser.
717
718         * WebKitTestRunner/ios/TestControllerIOS.mm:
719         (WTR::TestController::platformResetPreferencesToConsistentValues):
720
721 2019-03-07  John Wilander  <wilander@apple.com>
722
723         Resource Load Statistics: Make it possible to purge only script-accessible cookies
724         https://bugs.webkit.org/show_bug.cgi?id=195383
725         <rdar://problem/48570136>
726
727         Reviewed by Brent Fulgham.
728
729         This patch adds test infrastructure to purge only script-accessible cookies,
730         including a new testRunner function called statisticsDeleteCookiesForHost().git a
731
732         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
733         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
734         (WTR::TestRunner::statisticsDeleteCookiesForHost):
735         * WebKitTestRunner/InjectedBundle/TestRunner.h:
736         * WebKitTestRunner/TestController.cpp:
737         (WTR::TestController::statisticsDeleteCookiesForHost):
738         * WebKitTestRunner/TestController.h:
739         * WebKitTestRunner/TestInvocation.cpp:
740         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
741
742 2019-03-07  Commit Queue  <commit-queue@webkit.org>
743
744         Unreviewed, rolling out r242354.
745         https://bugs.webkit.org/show_bug.cgi?id=195402
746
747         breaks layout tests in all configurations (Requested by
748         zdobersek on #webkit).
749
750         Reverted changeset:
751
752         "[WPE] Enable web process sandbox"
753         https://bugs.webkit.org/show_bug.cgi?id=195169
754         https://trac.webkit.org/changeset/242354
755
756 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
757
758         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
759         https://bugs.webkit.org/show_bug.cgi?id=195346
760
761         Reviewed by Fujii Hironori.
762
763         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
764         (TestWebKitAPI::TEST):
765         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
766
767         * DumpRenderTree/win/DumpRenderTree.cpp:
768         (findFontFallback):
769         (addFontFallbackIfPresent):
770         (removeFontFallbackIfPresent):
771         (main):
772         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
773         (TestWebKitAPI::Util::moduleDirectory):
774         (TestWebKitAPI::Util::createInjectedBundlePath):
775         Use wchar helpers as needed.
776
777 2019-03-06  Rob Buis  <rbuis@igalia.com>
778
779         Consider supporting the `referrerpolicy` attribute.
780         https://bugs.webkit.org/show_bug.cgi?id=179053
781
782         Reviewed by Darin Adler.
783
784         Add a runtime flag for referrerpolicy attribute.
785
786         * DumpRenderTree/mac/DumpRenderTree.mm:
787         (enableExperimentalFeatures):
788
789 2019-03-05  Daniel Bates  <dabates@apple.com>
790
791         Update expected API test result following r242379
792         (https://bugs.webkit.org/show_bug.cgi?id=195125)
793
794         Update expected x-coordinate of selection rect now that the left padding of
795         a textarea is sized in ems (so dependent on the font size) just like the left
796         padding of a text field.
797
798         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
799         (TestWebKitAPI::TEST):
800
801 2019-03-05  David Quesada  <david_quesada@apple.com>
802
803         [WK2] It should be possible to follow links with 'download' attributes
804         https://bugs.webkit.org/show_bug.cgi?id=195145
805         rdar://problem/48462642
806
807         Reviewed by Alex Christensen.
808
809         Add a unit test to verify that activating links with 'download' attributes now
810         navigates to the linked resource, rather than starts downloading it. Add another
811         to verify that it is still possible to explicitly download the link via the
812         'Download' navigation action policy.
813
814         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
815         (-[DownloadAttributeTestDelegate init]):
816         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
817         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
818         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
819         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
820         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
821         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
822         (TEST):
823         * WebKitTestRunner/TestController.cpp:
824         (WTR::TestController::decidePolicyForNavigationAction):
825         * WebKitTestRunner/TestController.h:
826
827 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
828
829         [Curl] Implement Cookie Accept Policy.
830         https://bugs.webkit.org/show_bug.cgi?id=191645
831
832         Reviewed by Fujii Hironori.
833
834         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
835         (TestWebKitAPI::Curl::TEST_F):
836
837 2019-03-05  Youenn Fablet  <youenn@apple.com>
838
839         Rename requestCacheStorageSpace to requestStorageSpace
840         https://bugs.webkit.org/show_bug.cgi?id=195282
841
842         Reviewed by Chris Dumez.
843
844         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
845         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
846         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
847
848 2019-03-05  Brady Eidson  <beidson@apple.com>
849
850         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
851         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
852
853         Reviewed by Tim Horton.
854
855         Loading a file: URL into a WKWebView and then loading another file: url from a completely
856         different directory into that same WKWebView should work.
857
858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
859         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
860
861 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
862
863         Add WeakHashSet
864         https://bugs.webkit.org/show_bug.cgi?id=195152
865
866         Reviewed by Antti Koivisto.
867
868         Added tests for WeakHashSet.
869
870         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
871         (TestWebKitAPI::Base::Base): Moved.
872         (TestWebKitAPI::Derived::foo): Moved.
873         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
874         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
875         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
876         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
877
878 2019-03-04  Chris Dumez  <cdumez@apple.com>
879
880         Do not share WebProcesses between private and regular sessions
881         https://bugs.webkit.org/show_bug.cgi?id=195189
882         <rdar://problem/48421064>
883
884         Reviewed by Alex Christensen.
885
886         Add API test coverage.
887
888         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
889         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
890
891 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
892
893         [WPE] Enable web process sandbox
894         https://bugs.webkit.org/show_bug.cgi?id=195169
895
896         Reviewed by Daniel Bates.
897
898         * wpe/install-dependencies:
899         * wpe/jhbuild.modules:
900
901 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
902
903         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
904         https://bugs.webkit.org/show_bug.cgi?id=195206
905
906         Reviewed by Žan Doberšek.
907
908         Add a new test case.
909
910         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
911         (testJSCClass):
912
913 2019-03-04  Charlie Turner  <cturner@igalia.com>
914
915         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
916         https://bugs.webkit.org/show_bug.cgi?id=194898
917
918         Reviewed by Žan Doberšek.
919
920         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
921         a GCC extension that permits arithmetic on void* pointer. Inline
922         the macro until this issue is fixed upstream.
923
924 2019-03-03  Tim Horton  <timothy_horton@apple.com>
925
926         Rid the world of WK_API_ENABLED
927         https://bugs.webkit.org/show_bug.cgi?id=195263
928
929         Reviewed by Dan Bernstein.
930
931         List of changed files elided because it's useless.
932
933 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
934
935         Unreviewed follow-up to r242292.
936
937         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
938
939         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
940         (TestWebKitAPI::testStrip): Renamed from strip.
941         (TestWebKitAPI::TEST):
942
943 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
944
945         Unreviewed, remove accidentally-committed URLHelpers.cpp test
946
947         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
948         and bug #194272 for details.
949
950         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
951
952 2019-03-03  Tim Horton  <timothy_horton@apple.com>
953
954         Remove some more unused 32-bit code
955         https://bugs.webkit.org/show_bug.cgi?id=195255
956
957         Reviewed by Darin Adler.
958
959         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
960         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
961         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
962         (NPP_New):
963         (NPP_HandleEvent):
964         (handleEventCarbon): Deleted.
965
966 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
967
968         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
969
970         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
971         (TestWebKitAPI::TEST):
972
973 2019-03-01  Darin Adler  <darin@apple.com>
974
975         Finish removing String::format
976         https://bugs.webkit.org/show_bug.cgi?id=194893
977
978         Reviewed by Daniel Bates.
979 '
980         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
981
982 2019-03-01  Alex Christensen  <achristensen@webkit.org>
983
984         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
985         https://bugs.webkit.org/show_bug.cgi?id=195229
986         <rdar://problem/48520362>
987
988         Reviewed by Chris Dumez.
989
990         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
991         (TEST):
992
993 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
994
995         Add a system trace scope for event region building
996         https://bugs.webkit.org/show_bug.cgi?id=195226
997
998         Reviewed by Jon Lee.
999
1000         This trace scope measures the time spend converting element rects into Region objects,
1001         which can be large on some pages.
1002
1003         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
1004
1005         * Tracing/SystemTracePoints.plist:
1006
1007 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
1008
1009         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
1010         https://bugs.webkit.org/show_bug.cgi?id=194612
1011
1012         Reviewed by Alex Christensen.
1013
1014         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1015         Just test the new string-processing function and don't touch the actual environment.
1016         (Test cases are all as before, but based on operator== instead of strcmp.)
1017
1018 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
1019
1020         [ews-app] Update primary keys for handling multiple Buildbot instances
1021         https://bugs.webkit.org/show_bug.cgi?id=195120
1022
1023         Reviewed by Stephanie Lewis.
1024
1025         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
1026         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
1027         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
1028
1029         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
1030         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
1031         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
1032         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
1033         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
1034         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
1035
1036 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
1037
1038         [WinCairo] Enable service worker
1039         https://bugs.webkit.org/show_bug.cgi?id=188318
1040
1041         Reviewed by Youenn Fablet.
1042
1043         * DumpRenderTree/DumpRenderTreePrefix.h:
1044         * TestWebKitAPI/PlatformWin.cmake:
1045         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
1046         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
1047         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1048
1049 2019-03-01  Justin Fan  <justin_fan@apple.com>
1050
1051         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
1052         https://bugs.webkit.org/show_bug.cgi?id=195191
1053
1054         Rubber-stamped by Dean Jackson.
1055
1056         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
1057
1058         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1059
1060 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
1061
1062         Unreviewed, fix lldb webkitpy tests
1063         https://bugs.webkit.org/show_bug.cgi?id=194375
1064
1065         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
1066
1067         * lldb/lldb_webkit.py:
1068         (WTFStringImplProvider.is_8bit):
1069
1070 2019-02-28  David Quesada  <david_quesada@apple.com>
1071
1072         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
1073         https://bugs.webkit.org/show_bug.cgi?id=195121
1074         rdar://problem/48450302
1075
1076         Reviewed by Alex Christensen.
1077
1078         Add API tests for -WKNavigationAction._shouldPerformDownload in various
1079         configurations where the 'download' attribute is absent, blank, or populated
1080         with a filename, and where the anchor element is same-origin or cross-origin
1081         (meaning the 'download' attribute shouldn't be honored).
1082
1083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1084         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
1085         (-[NavigationActionTestDelegate init]):
1086         (-[NavigationActionTestDelegate navigationAction]):
1087         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
1088         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
1089         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1090         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
1091         (TEST):
1092
1093 2019-02-28  Antoine Quint  <graouts@apple.com>
1094
1095         Enable the Pointer Events runtime flag by default
1096         https://bugs.webkit.org/show_bug.cgi?id=195156
1097
1098         Reviewed by Dean Jackson.
1099
1100         * DumpRenderTree/mac/DumpRenderTree.mm:
1101         (enableExperimentalFeatures):
1102
1103 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1104
1105         Several PasteImage API tests are flaky
1106         https://bugs.webkit.org/show_bug.cgi?id=195160
1107
1108         Reviewed by Tim Horton.
1109
1110         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
1111         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
1112         listening for a "load" event after image load is already complete.
1113
1114         To address this, make these tests first register a "load" event handler, then run script to insert an image
1115         element into the document, and finally wait until the load event is observed before checking image size.
1116
1117         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1118
1119 2019-02-28  Chris Dumez  <cdumez@apple.com>
1120
1121         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
1122         https://bugs.webkit.org/show_bug.cgi?id=195107
1123
1124         Reviewed by Alex Christensen.
1125
1126         Give some time for the zoom level to get restored.
1127
1128         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1129
1130 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
1131
1132         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
1133         https://bugs.webkit.org/show_bug.cgi?id=194958
1134
1135         Reviewed by Geoffrey Garen.
1136
1137         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
1138         (TEST):
1139
1140 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
1141
1142         [ews-app] Update method to save build to handle builder_display_name
1143         https://bugs.webkit.org/show_bug.cgi?id=195047
1144
1145         Reviewed by Dewei Zhu.
1146
1147         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
1148         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
1149
1150 2019-02-28  Justin Fan  <justin_fan@apple.com>
1151
1152         [Web GPU] Enable Web GPU only on 64-bit
1153         https://bugs.webkit.org/show_bug.cgi?id=195139
1154
1155         Because Metal is only supported on 64 bit apps.
1156
1157         Unreviewed build fix.
1158
1159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1160
1161 2019-02-27  Youenn Fablet  <youenn@apple.com>
1162
1163         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
1164         https://bugs.webkit.org/show_bug.cgi?id=194959
1165
1166         Reviewed by Chris Dumez.
1167
1168         Spin loop until getting the condition to remove flakiness.
1169
1170         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1171
1172 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
1173
1174         [ews-build] Buildbot should include builder_display_name in the build events
1175         https://bugs.webkit.org/show_bug.cgi?id=195045
1176
1177         Reviewed by Dewei Zhu.
1178
1179         * BuildSlaveSupport/ews-build/events.py:
1180         (Events.buildStarted): Included builder_display_name in event data. Also renamed
1181         buildername to builder_name to be consistent in naming style.
1182         (Events.buildFinished): Ditto.
1183
1184 2019-02-27  Chris Dumez  <cdumez@apple.com>
1185
1186         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
1187         https://bugs.webkit.org/show_bug.cgi?id=194480
1188
1189         Reviewed by Brady Eidson.
1190
1191         Update existing API test to make it more likely to reproduce the issue.
1192
1193         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1194
1195 2019-02-27  Brady Eidson  <beidson@apple.com>
1196
1197         Universal links from Google search results pages don't open the app.
1198         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
1199
1200         Reviewed by Geoffrey Garen.
1201
1202         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1203         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1204         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1205         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1206
1207 2019-02-27  Chris Dumez  <cdumez@apple.com>
1208
1209         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1210         https://bugs.webkit.org/show_bug.cgi?id=195102
1211
1212         Reviewed by Geoffrey Garen.
1213
1214         If the number of processes is not yet what we expect, wait a bit and check again to give
1215         processes some time to exit.
1216
1217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1218
1219 2019-02-27  Chris Dumez  <cdumez@apple.com>
1220
1221         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1222         https://bugs.webkit.org/show_bug.cgi?id=194545
1223
1224         Reviewed by Brady Eidson.
1225
1226         Make sure the test navigates forward and then back only once. Previously, navigating
1227         back would trigger a navigation again in a timer.
1228
1229         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1230
1231 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1232
1233         High Sierra Debug JSC test queue should use faster hardware
1234         https://bugs.webkit.org/show_bug.cgi?id=194603
1235
1236         Rubber-stamped by Alexey Proskuryakov.
1237
1238         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1239
1240         * BuildSlaveSupport/build.webkit.org-config/config.json:
1241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1242         (BubbleQueueServer):
1243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1244         (WebKitBuildbot):
1245         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1246         * QueueStatusServer/config/queues.py:
1247         * Scripts/webkitpy/common/config/ews.json:
1248         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1249         (test_ews_name):
1250
1251 2019-02-27  John Wilander  <wilander@apple.com>
1252
1253         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1254         https://bugs.webkit.org/show_bug.cgi?id=195071
1255         <rdar://problem/48417690>
1256
1257         Reviewed by Alex Christensen and Brent Fulgham.
1258
1259         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1260         (TestWebKitAPI::createURL):
1261             Convenience function.
1262         (TestWebKitAPI::TEST):
1263             WebCore::AdClickAttribution now takes a URL when creating Source and
1264             Destination.
1265         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1266         (TestWebKitAPI::TEST):
1267             WebCore::AdClickAttribution now takes a URL when creating Source and
1268             Destination.
1269
1270 2019-02-27  Antoine Quint  <graouts@apple.com>
1271
1272         Support Pointer Events on macOS
1273         https://bugs.webkit.org/show_bug.cgi?id=195008
1274         <rdar://problem/47454419>
1275
1276         Reviewed by Dean Jackson.
1277
1278         * DumpRenderTree/mac/DumpRenderTree.mm:
1279         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1280         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1281
1282 2019-02-26  Mark Lam  <mark.lam@apple.com>
1283
1284         Remove remaining poisoning code.
1285         https://bugs.webkit.org/show_bug.cgi?id=194138
1286
1287         Reviewed by Saam Barati.
1288
1289         * TestWebKitAPI/CMakeLists.txt:
1290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1291         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1292         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1293         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1294         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1295         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1296         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1297
1298 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1299
1300         Move ephemeral local storage from WebProcess to UIProcess
1301         https://bugs.webkit.org/show_bug.cgi?id=195074
1302         <rdar://problem/47937975>
1303
1304         Reviewed by Geoff Garen.
1305
1306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1307
1308 2019-02-20  Jer Noble  <jer.noble@apple.com>
1309
1310         [Cocoa] Media elements will restart network buffering just before suspending
1311         https://bugs.webkit.org/show_bug.cgi?id=193691
1312
1313         Reviewed by Eric Carlson.
1314
1315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1316         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1317         (TEST):
1318
1319 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1320
1321         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1322         https://bugs.webkit.org/show_bug.cgi?id=191652
1323
1324         Reviewed by Alex Christensen.
1325
1326         Fix WinCairo MiniBrowser behavior of authentication dialog.
1327
1328         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1329         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1330
1331 2019-02-26  Youenn Fablet  <youenn@apple.com>
1332
1333         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1334         https://bugs.webkit.org/show_bug.cgi?id=195028
1335         <rdar://problem/48243733>
1336
1337         Reviewed by Eric Carlson.
1338
1339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1340
1341 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1342
1343         [WPE] Add API for webview background color configuration
1344         https://bugs.webkit.org/show_bug.cgi?id=192305
1345
1346         Reviewed by Michael Catanzaro.
1347
1348         * MiniBrowser/wpe/main.cpp:
1349         (main): Add a new option to configure the webview background
1350         color. Example: --bg-color=transparent.
1351         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1352         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1353         (beforeAll): Ditto.
1354
1355 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1356
1357         scalableNativeWebpageParameters() is not preserved on new page navigation.
1358         https://bugs.webkit.org/show_bug.cgi?id=194892
1359         <rdar://problem/47538280>
1360
1361         Reviewed by Wenson Hsieh.
1362         
1363         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1364
1365         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1366         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1367         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1368         (WTR::UIScriptController::allowsViewportShrinkToFit):
1369         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1370         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1371         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1372         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1373         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1374         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1375
1376 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1377
1378         [ews-app] Add model for handling multiple Buildbot instances
1379         https://bugs.webkit.org/show_bug.cgi?id=194863
1380
1381         Reviewed by Stephanie Lewis.
1382
1383         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1384
1385 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1386
1387         [ews-app] Remove BuilderMapping table
1388         https://bugs.webkit.org/show_bug.cgi?id=194961
1389
1390         Reviewed by Stephanie Lewis.
1391
1392         Store builder name directly in build table, instead of having a separate
1393         table for it.
1394
1395         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1396         * BuildSlaveSupport/ews-app/ews/models/build.py:
1397         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1398         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1399
1400 2019-02-25  John Wilander  <wilander@apple.com>
1401
1402         Introduce and adopt new class RegistrableDomain for eTLD+1
1403         https://bugs.webkit.org/show_bug.cgi?id=194791
1404         <rdar://problem/48179240>
1405
1406         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1407
1408         This patch adds an API test and replaces two instances of
1409         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1410
1411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1412         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1413         (TestWebKitAPI::TEST):
1414             Changed two strings to make sure the registrable domains are still considered
1415             invalid and pass the test.
1416         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1417         (TestWebKitAPI::TEST):
1418         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1419         (WTR::InjectedBundle::didReceiveMessageToPage):
1420
1421 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1422
1423         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1424         https://bugs.webkit.org/show_bug.cgi?id=195001
1425
1426         Reviewed by Carlos Garcia Campos.
1427
1428         API version 1.0 always includes the functionality previously guarded with
1429         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1430         unconditionally.
1431
1432         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1433         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1434         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1435         (WebViewTest::showInWindow): Ditto.
1436         (WebViewTest::hideView): Ditto.
1437         * wpe/backends/HeadlessViewBackend.cpp:
1438         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1439         * wpe/backends/ViewBackend.cpp:
1440         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1441         * wpe/backends/WindowViewBackend.cpp:
1442         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1443         WPE_BACKEND_CHECK_VERSION().
1444         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1445
1446 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1447
1448         [Flatpak] Add support for flatpak > 1.1.2
1449         https://bugs.webkit.org/show_bug.cgi?id=194088
1450
1451         Flatpak 1.2 is now out so we need to support that
1452         version now.
1453
1454         Reviewed by Michael Catanzaro.
1455
1456         * flatpak/flatpakutils.py:
1457         (check_flatpak):
1458         (FlatpakPackages.__init__):
1459         (FlatpakPackages.__detect_packages):
1460         (FlatpakPackages.__detect_packages.in):
1461         (FlatpakRepos.update):
1462
1463 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1464
1465         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1466         https://bugs.webkit.org/show_bug.cgi?id=194998
1467
1468         Reviewed by Carlos Garcia Campos.
1469
1470         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1471         to a Git checkout and using the latest commit containing various fixes
1472         and improvements.
1473
1474 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1475
1476         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1477         https://bugs.webkit.org/show_bug.cgi?id=194981
1478
1479         Reviewed by Žan Doberšek.
1480
1481         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1482         (TestWebKitAPI::TEST):
1483
1484 2019-02-23  Keith Miller  <keith_miller@apple.com>
1485
1486         Add new mac target numbers
1487         https://bugs.webkit.org/show_bug.cgi?id=194955
1488
1489         Reviewed by Tim Horton.
1490
1491         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1492         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1493         * MiniBrowser/Configurations/Base.xcconfig:
1494         * TestWebKitAPI/Configurations/Base.xcconfig:
1495         * WebKitTestRunner/Configurations/Base.xcconfig:
1496
1497 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1498
1499         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1500         https://bugs.webkit.org/show_bug.cgi?id=194846
1501
1502         Reviewed by Don Olmstead.
1503
1504         Added _search_paths() and _port_specific_expectations_files() for
1505         WinCairoPort.
1506
1507         * Scripts/webkitpy/port/win.py:
1508         (WinCairoPort.default_baseline_search_path):
1509         (WinCairoPort):
1510         (WinCairoPort._port_specific_expectations_files):
1511         (WinCairoPort._search_paths):
1512
1513 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1514
1515         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1516         https://bugs.webkit.org/show_bug.cgi?id=194963
1517
1518         Reviewed by Dean Jackson.
1519
1520         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1521         Do a `contains` check instead of `equals`, because in debug builds we
1522         put the GraphicsLayer pointer in a prefix.
1523
1524 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1525
1526         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1527         https://bugs.webkit.org/show_bug.cgi?id=194873
1528         <rdar://problem/46701974>
1529
1530         Reviewed by Tim Horton.
1531
1532         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1533
1534         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1535         (WTR::UIScriptController::menuRect const):
1536         (WTR::UIScriptController::isShowingMenu const):
1537         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1538         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1539         (WTR::UIScriptController::menuRect const):
1540
1541         Add a function to query the bounds of the callout menu in content coordinates.
1542
1543         (WTR::UIScriptController::isShowingMenu const):
1544
1545         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1546
1547         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1548         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1549         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1550         (WTR::UIScriptController::rectForMenuAction const):
1551         (WTR::UIScriptController::menuRect const):
1552         (WTR::UIScriptController::isShowingMenu const):
1553         (WTR::findViewInHierarchyOfType): Deleted.
1554
1555 2019-02-22  Chris Dumez  <cdumez@apple.com>
1556
1557         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1558         https://bugs.webkit.org/show_bug.cgi?id=194954
1559         <rdar://problem/48127957>
1560
1561         Reviewed by Alex Christensen.
1562
1563         Add API test coverage.
1564
1565         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1566         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1567         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1568         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1569
1570 2019-02-22  Chris Dumez  <cdumez@apple.com>
1571
1572         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1573         https://bugs.webkit.org/show_bug.cgi?id=194924
1574         <rdar://problem/48216125>
1575
1576         Reviewed by Geoffrey Garen.
1577
1578         Add API test coverage.
1579
1580         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1581
1582 2019-02-22  Chris Dumez  <cdumez@apple.com>
1583
1584         Unreviewed, disable API test added in r241928 on iOS.
1585
1586         The cache is not enabled on devices with less than 3GB of RAM.
1587
1588         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1589
1590 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1591
1592         Hardcode Visual Viewports on everywhere except iOS WK1
1593         https://bugs.webkit.org/show_bug.cgi?id=194928
1594
1595         Reviewed by Zalan Bujtas.
1596
1597         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1598         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1599         set it to false. The setting has shipped for several years and there's no need to turn
1600         it off now.
1601
1602         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1603         Visual Viewports are not enabled.
1604         
1605         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1606         that only runs in WK2
1607
1608         * MiniBrowser/mac/SettingsController.h:
1609         * MiniBrowser/mac/SettingsController.m:
1610         (-[SettingsController init]):
1611         (-[SettingsController _populateMenu]):
1612         (-[SettingsController validateMenuItem:]):
1613         (-[SettingsController visualViewportEnabled]): Deleted.
1614         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1615         * MiniBrowser/mac/WK1BrowserWindowController.m:
1616         (-[WK1BrowserWindowController didChangeSettings]):
1617         * MiniBrowser/mac/WK2BrowserWindowController.m:
1618         (-[WK2BrowserWindowController didChangeSettings]):
1619
1620 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1621
1622         Discard cached processes when clearing website data store
1623         https://bugs.webkit.org/show_bug.cgi?id=194894
1624
1625         Reviewed by Chris Dumez.
1626
1627         Added a test case.
1628
1629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1630         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1631
1632 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1633
1634         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1635         https://bugs.webkit.org/show_bug.cgi?id=194914
1636         <rdar://problem/47586889>
1637
1638         Reviewed by Geoffrey Garen.
1639
1640         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1641         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1642         (TEST):
1643         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1644
1645 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1646
1647         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1648         <https://webkit.org/b/194761>
1649
1650         Reviewed by Myles Maxfield.
1651
1652         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1653         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1654         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1655         to use ARC-compliant cast.
1656         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1657         ARC-compliant cast.
1658         (WTR::installFakeHelvetica): Log `error` to console if
1659         CTFontManagerRegisterFontsForURL() fails, but only on supported
1660         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1661         Call CFRelease() on `error` to fix the leak.  Update to use
1662         ARC-compliant cast.
1663         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1664         cast.
1665
1666 2019-02-21  Chris Dumez  <cdumez@apple.com>
1667
1668         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1669         https://bugs.webkit.org/show_bug.cgi?id=194481
1670
1671         Reviewed by Alex Christensen.
1672
1673         Give the processes a chance to shutdown and wait until we reached the expected number
1674         of processes.
1675
1676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1677
1678 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1679
1680         Fix the macOS build
1681
1682         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1683
1684 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1685
1686         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1687
1688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1689         I am a backwards.
1690
1691 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1692
1693         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1694
1695         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1696         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1697         We could force on UI-side compositing, but I feel like the test might be more
1698         valuable exercising the normal path on each platform (though the original
1699         bug was also UI-side specific). Though we can't validate that the overlay
1700         layer was installed successfully, there are layout tests that do that.
1701
1702 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1703
1704         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1705         https://bugs.webkit.org/show_bug.cgi?id=194845
1706         <rdar://problem/47944579>
1707
1708         Reviewed by Antti Koivisto.
1709
1710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1711         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1712
1713 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1714
1715         [LFC][Floats] Add support for placing formatting roots in-between floats.
1716         https://bugs.webkit.org/show_bug.cgi?id=194902
1717
1718         Reviewed by Antti Koivisto.
1719
1720         * LayoutReloaded/misc/LFC-passing-tests.txt:
1721
1722 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1723
1724         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1725         https://bugs.webkit.org/show_bug.cgi?id=194901
1726
1727         Unreviewed build fix.
1728
1729         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1730         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1731         WPEBackend-fdo-0.1 as library name.
1732
1733 2019-02-21  Rob Buis  <rbuis@igalia.com>
1734
1735         Update MIME type parser
1736         https://bugs.webkit.org/show_bug.cgi?id=180526
1737
1738         Reviewed by Darin Adler.
1739
1740         Add tests involving leading and trailing whitespace, non-token
1741         characters and quoted strings.
1742
1743         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1744         (TestWebKitAPI::TEST):
1745
1746 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1747
1748         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1749         https://bugs.webkit.org/show_bug.cgi?id=194884
1750
1751         Reviewed by Michael Catanzaro.
1752
1753         * PlatformWin.cmake:
1754
1755 2019-02-20  Chris Dumez  <cdumez@apple.com>
1756
1757         Add API test for <rdar://problem/47471222>
1758         https://bugs.webkit.org/show_bug.cgi?id=194847
1759
1760         Reviewed by Alex Christensen.
1761
1762         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1763
1764 2019-02-20  Chris Dumez  <cdumez@apple.com>
1765
1766         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1767         https://bugs.webkit.org/show_bug.cgi?id=194872
1768         <rdar://problem/47924500>
1769
1770         Reviewed by Alex Christensen.
1771
1772         Add API test coverage.
1773
1774         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1775
1776 2019-02-20  Jer Noble  <jer.noble@apple.com>
1777
1778         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1779         https://bugs.webkit.org/show_bug.cgi?id=191332
1780
1781         Reviewed by Dean Jackson.
1782
1783         * Scripts/git-is-in-range: Added.
1784
1785 2019-02-20  Andy Estes  <aestes@apple.com>
1786
1787         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1788         https://bugs.webkit.org/show_bug.cgi?id=194869
1789
1790         Rubber-stamped by Jer Noble.
1791
1792         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1793         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1794         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1795         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1797         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1798
1799 2019-02-20  Chris Dumez  <cdumez@apple.com>
1800
1801         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1802         https://bugs.webkit.org/show_bug.cgi?id=194857
1803         <rdar://problem/47759323>
1804
1805         Reviewed by Alex Christensen.
1806
1807         Add API test coverage.
1808
1809         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1810
1811 2019-02-20  Chris Dumez  <cdumez@apple.com>
1812
1813         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1814         https://bugs.webkit.org/show_bug.cgi?id=194829
1815         <rdar://problem/47889906>
1816
1817         Reviewed by Alexey Proskuryakov.
1818
1819         Every time the TestOptions were changing we were creating both a new Web view and
1820         a new WKContext, which would start a new Network process. In most cases, we only
1821         need to contruct a new Web view and we do can keep reusing the same WKContext.
1822         This patch implements this optimization and thus avoids spinning a lot of new
1823         Network processes while running the layout tests.
1824
1825         * WebKitTestRunner/TestController.cpp:
1826         (WTR::TestController::generateContextConfiguration const):
1827         (WTR::TestController::generatePageConfiguration):
1828         (WTR::TestController::createWebViewWithOptions):
1829         (WTR::TestController::resetPreferencesToConsistentValues):
1830         (WTR::updateTestOptionsFromTestHeader):
1831         * WebKitTestRunner/TestController.h:
1832         * WebKitTestRunner/TestOptions.h:
1833         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1834         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1835         (WTR::TestOptions::hasSameInitializationOptions const):
1836         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1837         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1838         (WTR::TestController::platformAddTestOptions const):
1839
1840 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1841
1842         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1843         https://bugs.webkit.org/show_bug.cgi?id=167941
1844
1845         Reviewed by Carlos Garcia Campos.
1846
1847         * MiniBrowser/gtk/main.c:
1848         (filterSavedCallback): Added.
1849         (main): Support loading a JSON rule set file for content filtering.
1850         * MiniBrowser/wpe/main.cpp:
1851         (filterSavedCallback): Added.
1852         (main): Support loading a JSON rule set file for content filtering.
1853         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1854         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1855         (WTF::derefGPtr): Ditto.
1856         (testEmptyStore):
1857         (testSaveInvalidFilter):
1858         (testSaveLoadFilter):
1859         (testSavedFilterIdentifierMatch):
1860         (testRemoveFilter):
1861         (testSaveMultipleFilters):
1862         (testSaveFilterFromFile):
1863         (testFilterPersistence):
1864         (beforeAll):
1865         (afterAll):
1866         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1867         (removeOldInjectedContentAndResetLists): Also reset content filters.
1868         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1869         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1870         the element affected by the style sheet.
1871         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1872         and returns it to be used by tests.
1873         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1874         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1875         (serverCallback): Add support for serving a CSS style sheet for testing.
1876         (beforeAll): Add call to testUserContentManagerContentFilter().
1877         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1878
1879 2019-02-19  Keith Rollin  <krollin@apple.com>
1880
1881         Add timing information to build output
1882         https://bugs.webkit.org/show_bug.cgi?id=194839
1883         <rdar://problem/48219609>
1884
1885         Reviewed by Alexey Proskuryakov.
1886
1887         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1888         emit each project's build time to its output. E.g.,
1889
1890             ** BUILD SUCCEEDED ** [0.132 sec]
1891
1892         * Scripts/webkitdirs.pm:
1893         (XcodeOptions):
1894
1895 2019-02-19  Truitt Savell  <tsavell@apple.com>
1896
1897         Unreviewed, rolling out r241784.
1898
1899         Broke all OpenSource builds.
1900
1901         Reverted changeset:
1902
1903         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1904         instances view"
1905         https://bugs.webkit.org/show_bug.cgi?id=172848
1906         https://trac.webkit.org/changeset/241784
1907
1908 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1909
1910         [LFC][Floats] Remove redundant intersecting logic
1911         https://bugs.webkit.org/show_bug.cgi?id=194804
1912
1913         Reviewed by Antti Koivisto.
1914
1915         * LayoutReloaded/misc/LFC-passing-tests.txt:
1916
1917 2019-02-19  Dean Jackson  <dino@apple.com>
1918
1919         Clean-up output from generate-xcfilelists so it can be filtered
1920         https://bugs.webkit.org/show_bug.cgi?id=194795
1921
1922         Reviewed by Joseph Pecoraro (and Keith Rollin).
1923
1924         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1925         make a slight tweak to filter-build-webkit so such lines are marked
1926         as plain.
1927
1928         * Scripts/filter-build-webkit:
1929         * Scripts/generate-xcfilelists:
1930
1931 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1932
1933         pytest is not correctly auto-installed
1934         https://bugs.webkit.org/show_bug.cgi?id=194707
1935
1936         Reviewed by Carlos Garcia Campos.
1937
1938         * Scripts/webkitpy/thirdparty/__init__.py:
1939         (AutoinstallImportHook._install_pytest):
1940
1941 2019-02-18  Chris Dumez  <cdumez@apple.com>
1942
1943         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1944         https://bugs.webkit.org/show_bug.cgi?id=194797
1945         <rdar://problem/48055151>
1946
1947         Reviewed by Geoffrey Garen.
1948
1949         Add API test coverage.
1950
1951         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1952
1953 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1954
1955         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1956         https://bugs.webkit.org/show_bug.cgi?id=194670
1957         <rdar://problem/39066529>
1958
1959         Reviewed by Tim Horton.
1960
1961         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1962         pasted in an editable area as attachment elements.
1963
1964         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1965         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1966         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1967         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1968         (TestWebKitAPI::TEST):
1969         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1970         (WTR::InjectedBundlePage::InjectedBundlePage):
1971
1972 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1973
1974         Fix API test after r241728
1975        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1976
1977         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1978         (TEST):
1979         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1980
1981 2019-02-18  Daniel Bates  <dabates@apple.com>
1982
1983         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1984         https://bugs.webkit.org/show_bug.cgi?id=192824
1985         <rdar://problem/47100332>
1986
1987         Reviewed by Wenson Hsieh.
1988
1989         Fix a bug where the wrong usage code was used for F13 thru F24.
1990
1991         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1992         (keyCodeForDOMFunctionKey):
1993
1994 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1995
1996         Bytecode cache should a have a boot-specific validation
1997         https://bugs.webkit.org/show_bug.cgi?id=194769
1998         <rdar://problem/48149509>
1999
2000         Reviewed by Keith Miller.
2001
2002         Add test for WTF::bootSessionUUIDString()
2003
2004         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2005         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
2006         (TEST):
2007
2008 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2009
2010         Disable safe browsing in WKWebView and remove its WKPreferences API
2011         https://bugs.webkit.org/show_bug.cgi?id=194723
2012         <rdar://problem/48122993>
2013
2014         Reviewed by Geoffrey Garen.
2015
2016         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2017         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2018         (TEST):
2019         (safeBrowsingView):
2020         Make tests use SPI instead of API.
2021
2022 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2023
2024         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
2025         https://bugs.webkit.org/show_bug.cgi?id=194586
2026
2027         Reviewed by Ross Kirsling.
2028
2029         * DumpRenderTree/win/DumpRenderTree.cpp:
2030         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
2031         * Scripts/webkitpy/port/driver.py:
2032         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
2033
2034 2019-02-17  David Kilzer  <ddkilzer@apple.com>
2035
2036         Unreviewed, rolling out r241620.
2037
2038         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
2039         (Requested by ddkilzer on #webkit.)
2040
2041         Reverted changeset:
2042
2043         "[WTF] Add environment variable helpers"
2044         https://bugs.webkit.org/show_bug.cgi?id=192405
2045         https://trac.webkit.org/changeset/241620
2046
2047 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2048
2049         [LFC] RenderImage's default intrinsic size is 0.
2050         https://bugs.webkit.org/show_bug.cgi?id=194745
2051
2052         Reviewed by Antti Koivisto.
2053
2054         * LayoutReloaded/misc/LFC-passing-tests.txt:
2055
2056 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2057
2058         [LFC][BFC] Add support for block replaced intrinsic width.
2059         https://bugs.webkit.org/show_bug.cgi?id=194705
2060
2061         Reviewed by Simon Fraser.
2062
2063         * LayoutReloaded/misc/LFC-passing-tests.txt:
2064
2065 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2066
2067         [LFC] Apply min/max width constraints to preferred width computation
2068         https://bugs.webkit.org/show_bug.cgi?id=194739
2069
2070         Reviewed by Simon Fraser.
2071
2072         * LayoutReloaded/misc/LFC-passing-tests.txt:
2073
2074 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
2075
2076         [WTF] Add environment variable helpers
2077         https://bugs.webkit.org/show_bug.cgi?id=192405
2078
2079         Reviewed by Michael Catanzaro.
2080
2081         * DumpRenderTree/mac/DumpRenderTree.mm:
2082         (libraryPathForDumpRenderTree):
2083         * DumpRenderTree/win/DumpRenderTree.cpp:
2084         (libraryPathForDumpRenderTree):
2085         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2086         (setUpIOSLayoutTestCommunication):
2087         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2088         (beforeAll):
2089         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2090         (main):
2091         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2092         (WebKitTestBus::run):
2093         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2094         (WTR::getOutputDir):
2095         (WTR::initializeFontConfigSetting):
2096         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2097         (WTR::InjectedBundle::platformInitialize):
2098         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2099         (WTR::topLevelPath):
2100         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2101         (WTR::topLevelPath):
2102         (WTR::getOutputDir):
2103         (WTR::activateFonts):
2104         * WebKitTestRunner/TestController.cpp:
2105         (WTR::TestController::libraryPathForTesting):
2106         (WTR::TestController::generateContextConfiguration const):
2107         (WTR::TestController::generatePageConfiguration):
2108         (WTR::TestController::decideDestinationWithSuggestedFilename):
2109         (WTR::TestController::platformAdjustContext):
2110         * WebKitTestRunner/TestController.h:
2111         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2112         (WTR::TestController::cocoaPlatformInitialize):
2113         (WTR::TestController::platformAdjustContext):
2114         * WebKitTestRunner/gtk/main.cpp:
2115         (main):
2116         * WebKitTestRunner/mac/TestControllerMac.mm:
2117         (WTR::TestController::configureContentExtensionForTest):
2118         * WebKitTestRunner/wpe/main.cpp:
2119         (main):
2120         Utilize WTF::Environment where possible.
2121
2122 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2123
2124         [iOS] WKWebView callout bar is missing Change Writing Direction item
2125         https://bugs.webkit.org/show_bug.cgi?id=190015
2126         <rdar://problem/44810366>
2127
2128         Reviewed by Tim Horton.
2129
2130         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
2131         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
2132
2133         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2134         (TestWebKitAPI::TEST):
2135
2136 2019-02-15  Chris Dumez  <cdumez@apple.com>
2137
2138         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
2139         https://bugs.webkit.org/show_bug.cgi?id=194717
2140         <rdar://problem/47884404>
2141
2142         Reviewed by Brady Eidson.
2143
2144         Add API test coverage.
2145
2146         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2147
2148 2019-02-15  Youenn Fablet  <youenn@apple.com>
2149
2150         Make navigator.mediaDevices SecureContext
2151         https://bugs.webkit.org/show_bug.cgi?id=194666
2152
2153         Reviewed by Eric Carlson.
2154
2155         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2156         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2157         (TEST_F):
2158
2159 2019-02-15  Brian Burg  <bburg@apple.com>
2160
2161         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2162         https://bugs.webkit.org/show_bug.cgi?id=194411
2163         <rdar://problem/47787614>
2164
2165         Reviewed by Joseph Pecoraro.
2166
2167         Remove unnecessary soft linking macro usage.
2168
2169         * DumpRenderTree/mac/TestRunnerMac.mm:
2170         (TestRunner::inspectorTestStubURL):
2171         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2172         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2173         (WTR::TestRunner::inspectorTestStubURL):
2174
2175 2019-02-15  Commit Queue  <commit-queue@webkit.org>
2176
2177         Unreviewed, rolling out r241559 and r241566.
2178         https://bugs.webkit.org/show_bug.cgi?id=194710
2179
2180         Causes layout test crashes under GuardMalloc (Requested by
2181         ryanhaddad on #webkit).
2182
2183         Reverted changesets:
2184
2185         "[WTF] Add environment variable helpers"
2186         https://bugs.webkit.org/show_bug.cgi?id=192405
2187         https://trac.webkit.org/changeset/241559
2188
2189         "Unreviewed build fix for WinCairo Debug after r241559."
2190         https://trac.webkit.org/changeset/241566
2191
2192 2019-02-15  Zalan Bujtas  <zalan@apple.com>
2193
2194         [LFC] Out-of-flow box is never a float box
2195         https://bugs.webkit.org/show_bug.cgi?id=194704
2196
2197         Reviewed by Antti Koivisto.
2198
2199         * LayoutReloaded/misc/LFC-passing-tests.txt:
2200
2201 2019-02-10  Darin Adler  <darin@apple.com>
2202
2203         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
2204         https://bugs.webkit.org/show_bug.cgi?id=194487
2205
2206         Reviewed by Daniel Bates.
2207
2208         * DumpRenderTree/win/DumpRenderTree.cpp:
2209         (applicationId): Use makeString instead of String::format.
2210         (main): Ditto.
2211         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2212         (TestWebKitAPI::Util::createURLForResource): Ditto.
2213         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2214         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
2215
2216         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2217         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2218         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2219         (WTR::createStringWithAttributes): Use appendLiteral.
2220         (WTR::AccessibilityUIElement::helpText const): Ditto.
2221         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2222         directly instead of using String::format.
2223         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2224         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2225
2226 2019-02-15  Truitt Savell  <tsavell@apple.com>
2227
2228         Unreviewed, rolling out r241564.
2229
2230         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2231
2232         Reverted changeset:
2233
2234         "[Mac] WebInspectorUI.framework does not need to be soft-
2235         linked anymore"
2236         https://bugs.webkit.org/show_bug.cgi?id=194411
2237         https://trac.webkit.org/changeset/241564
2238
2239 2019-02-15  Saam barati  <sbarati@apple.com>
2240
2241         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2242         https://bugs.webkit.org/show_bug.cgi?id=194036
2243
2244         Reviewed by Yusuke Suzuki.
2245
2246         * Scripts/run-jsc-stress-tests:
2247
2248 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2249
2250         Fix the build.
2251
2252         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2253         (WTR::UIScriptController::drawSquareInEditableImage):
2254         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2255         (TestWebKitAPI::drawSquareInEditableImage):
2256
2257 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2258
2259         Fix the build.
2260
2261         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2262         (WTR::UIScriptController::drawSquareInEditableImage):
2263         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2264         (TestWebKitAPI::drawSquareInEditableImage):
2265
2266 2019-02-14  Brian Burg  <bburg@apple.com>
2267
2268         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2269         https://bugs.webkit.org/show_bug.cgi?id=194411
2270         <rdar://problem/47787614>
2271
2272         Reviewed by Joseph Pecoraro.
2273
2274         Remove unnecessary soft linking macro usage.
2275
2276         * DumpRenderTree/mac/TestRunnerMac.mm:
2277         (TestRunner::inspectorTestStubURL):
2278         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2279         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2280         (WTR::TestRunner::inspectorTestStubURL):
2281
2282 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2283
2284         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2285         https://bugs.webkit.org/show_bug.cgi?id=194599
2286
2287         Reviewed by Lucas Forschler.
2288
2289         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2290         (StatusBubble._build_bubble):
2291
2292 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2293
2294         [ews-app] Set Foreign Key in Django build model
2295         https://bugs.webkit.org/show_bug.cgi?id=194667
2296
2297         Reviewed by Lucas Forschler.
2298
2299         * BuildSlaveSupport/ews-app/ews/models/build.py:
2300         (Build):
2301
2302 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2303
2304         [WTF] Add environment variable helpers
2305         https://bugs.webkit.org/show_bug.cgi?id=192405
2306
2307         Reviewed by Michael Catanzaro.
2308
2309         * DumpRenderTree/mac/DumpRenderTree.mm:
2310         (libraryPathForDumpRenderTree):
2311         * DumpRenderTree/win/DumpRenderTree.cpp:
2312         (libraryPathForDumpRenderTree):
2313         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2314         (setUpIOSLayoutTestCommunication):
2315         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2316         (TestWebKitAPI::strip):
2317         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2318         (beforeAll):
2319         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2320         (main):
2321         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2322         (WebKitTestBus::run):
2323         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2324         (WTR::getOutputDir):
2325         (WTR::initializeFontConfigSetting):
2326         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2327         (WTR::InjectedBundle::platformInitialize):
2328         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2329         (WTR::topLevelPath):
2330         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2331         (WTR::topLevelPath):
2332         (WTR::getOutputDir):
2333         (WTR::activateFonts):
2334         * WebKitTestRunner/TestController.cpp:
2335         (WTR::TestController::libraryPathForTesting):
2336         (WTR::TestController::generateContextConfiguration const):
2337         (WTR::TestController::generatePageConfiguration):
2338         (WTR::TestController::decideDestinationWithSuggestedFilename):
2339         (WTR::TestController::platformAdjustContext):
2340         * WebKitTestRunner/TestController.h:
2341         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2342         (WTR::TestController::cocoaPlatformInitialize):
2343         (WTR::TestController::platformAdjustContext):
2344         * WebKitTestRunner/gtk/main.cpp:
2345         (main):
2346         * WebKitTestRunner/mac/TestControllerMac.mm:
2347         (WTR::TestController::configureContentExtensionForTest):
2348         * WebKitTestRunner/wpe/main.cpp:
2349         (main):
2350         Utilize WTF::Environment where possible.
2351
2352 2019-02-14  Chris Dumez  <cdumez@apple.com>
2353
2354         [PSON] Introduce a WebContent Process cache
2355         https://bugs.webkit.org/show_bug.cgi?id=194594
2356         <rdar://problem/46793397>
2357
2358         Reviewed by Geoff Garen.
2359
2360         Update API tests to turn on the WebContent Process cache.
2361
2362         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2363
2364 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2365
2366         Unreviewed, build fix after r241480
2367
2368         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2369         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2370         (-[DragAndDropSimulator initWithWebView:]):
2371
2372 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2373
2374         AX: ARIA Reflection was disabled in error
2375         https://bugs.webkit.org/show_bug.cgi?id=194647
2376         <rdar://problem/48068336>
2377
2378         Reviewed by Ryosuke Niwa.
2379
2380         Remove test override now that this feature should be enabled by default.
2381
2382         * WebKitTestRunner/TestController.cpp:
2383         (WTR::TestController::resetPreferencesToConsistentValues):
2384
2385 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2386
2387         Unreviewed, rolling out r241486.
2388         https://bugs.webkit.org/show_bug.cgi?id=194655
2389
2390         causing API failures in builds (Requested by ShawnRoberts on
2391         #webkit).
2392
2393         Reverted changeset:
2394
2395         "[Cocoa] Media elements will restart network buffering just
2396         before suspending"
2397         https://bugs.webkit.org/show_bug.cgi?id=193691
2398         https://trac.webkit.org/changeset/241486
2399
2400 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2401
2402         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2403         https://bugs.webkit.org/show_bug.cgi?id=194622
2404
2405         Reviewed by Antti Koivisto.
2406
2407         * LayoutReloaded/misc/LFC-passing-tests.txt:
2408
2409 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2410
2411         [LFC] Shrink-to-fit-width should be constrained by min/max width
2412         https://bugs.webkit.org/show_bug.cgi?id=194653
2413
2414         Reviewed by Antti Koivisto.
2415
2416         * LayoutReloaded/misc/LFC-passing-tests.txt:
2417
2418 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2419
2420         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2421         https://bugs.webkit.org/show_bug.cgi?id=194641
2422
2423         Reviewed by Geoffrey Garen.
2424
2425         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2426         so that the test would fail without this fix.
2427
2428         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2429         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2430
2431 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2432
2433         [ews-app] Change log level for a log statement
2434
2435         Unreviewed minor fix.
2436
2437         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2438         (Patch.save_patch):
2439
2440 2019-02-13  Jer Noble  <jer.noble@apple.com>
2441
2442         [Cocoa] Media elements will restart network buffering just before suspending
2443         https://bugs.webkit.org/show_bug.cgi?id=193691
2444
2445         Reviewed by Eric Carlson.
2446
2447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2448         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2449         (TEST):
2450
2451 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2452
2453         [ews-app] Fetch builder id to name mapping
2454         https://bugs.webkit.org/show_bug.cgi?id=194355
2455
2456         Reviewed by Lucas Forschler.
2457
2458         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2459         (Buildbot.get_builder_id_to_name_mapping):
2460         (Buildbot._get_display_name_from_builder_name):
2461
2462 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2463
2464         Further restricting webarchive loads
2465         https://bugs.webkit.org/show_bug.cgi?id=194567
2466         <rdar://problem/47610130>
2467
2468         Reviewed by Youenn Fablet.
2469
2470         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2471         navigations on drop.
2472
2473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2474         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2475         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2476         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2477         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2478         (TestWebKitAPI::TEST):
2479         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2480         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2481         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2482         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2483         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2484         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2485         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2486
2487 2019-02-13  John Wilander  <wilander@apple.com>
2488
2489         Store Ad Click Attribution requests in the network process
2490         https://bugs.webkit.org/show_bug.cgi?id=194510
2491         <rdar://problem/47650118>
2492
2493         Reviewed by Alex Christensen and Daniel Bates.
2494
2495         This patch adds two TestRunner functions:
2496         - dumpAdClickAttribution()
2497         - clearAdClickAttribution()
2498
2499         They call into the network process to dump and clear Ad Click
2500         Attribution state, respectively.
2501
2502         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2503         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2504         (WTR::TestRunner::dumpAdClickAttribution):
2505         (WTR::TestRunner::clearAdClickAttribution):
2506         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2507         * WebKitTestRunner/TestController.cpp:
2508         (WTR::TestController::resetStateToConsistentValues):
2509         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2510         (WTR::adClickAttributionStringResultCallback):
2511         (WTR::TestController::dumpAdClickAttribution):
2512         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2513         (WTR::adClickAttributionVoidCallback):
2514         (WTR::TestController::clearAdClickAttribution):
2515         * WebKitTestRunner/TestController.h:
2516         * WebKitTestRunner/TestInvocation.cpp:
2517         (WTR::TestInvocation::dumpResults):
2518         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2519         (WTR::TestInvocation::dumpAdClickAttribution):
2520         * WebKitTestRunner/TestInvocation.h:
2521
2522 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2523
2524         [ews-app] Generate status-bubble
2525         https://bugs.webkit.org/show_bug.cgi?id=194572
2526
2527         Reviewed by Lucas Forschler.
2528
2529         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2530         (StatusBubble._build_bubble):
2531         (StatusBubble._should_show_bubble_for):
2532         (StatusBubble._build_bubbles_for_patch):
2533
2534 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2535
2536         [ews-app] Add status bubble html template
2537         https://bugs.webkit.org/show_bug.cgi?id=194571
2538
2539         Reviewed by Lucas Forschler.
2540
2541         * BuildSlaveSupport/ews-app/ews/templates: Added.
2542         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2543
2544 2019-02-12  Chris Dumez  <cdumez@apple.com>
2545
2546         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2547         https://bugs.webkit.org/show_bug.cgi?id=194568
2548         <rdar://problem/47944490>
2549
2550         Reviewed by Ryosuke Niwa.
2551
2552         Add API test coverage.
2553
2554         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2555         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2556
2557 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2558
2559         webkitpy: Remove bug_dummy from parsed test expectations
2560         https://bugs.webkit.org/show_bug.cgi?id=194562
2561         <rdar://problem/47853999>
2562
2563         Reviewed by Lucas Forschler.
2564
2565         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2566         (TestExpectationParser):
2567         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2568         skipped tests.
2569         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2570
2571 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2572
2573         [ews-app] Add method to fetch patch
2574         https://bugs.webkit.org/show_bug.cgi?id=194518
2575
2576         Reviewed by Lucas Forschler.
2577
2578         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2579         (Patch.get_patch):
2580
2581 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2582
2583         [LFC] Expand tests coverage (60 new tests -> 860)
2584
2585         Unreviewed test gardening (run-singly, --child-processes=1).
2586
2587         * LayoutReloaded/misc/LFC-passing-tests.txt:
2588
2589 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2590
2591         Allow pages to trigger programmatic paste from script on iOS
2592         https://bugs.webkit.org/show_bug.cgi?id=194271
2593         <rdar://problem/47808810>
2594
2595         Reviewed by Tim Horton.
2596
2597         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2598
2599         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2600         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2601         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2602         (WTR::UIScriptController::rectForMenuAction const):
2603
2604         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2605         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2606         for when the menu is shown or hidden.
2607
2608         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2609         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2610         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2611         (WTR::UIScriptController::setDidShowMenuCallback):
2612         (WTR::UIScriptController::didShowMenuCallback const):
2613         (WTR::UIScriptController::setDidHideMenuCallback):
2614         (WTR::UIScriptController::didHideMenuCallback const):
2615         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2616         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2617         (WTR::UIScriptController::rectForMenuAction const):
2618         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2619         * WebKitTestRunner/TestController.cpp:
2620         (WTR::TestController::resetPreferencesToConsistentValues):
2621         (WTR::updateTestOptionsFromTestHeader):
2622         * WebKitTestRunner/TestOptions.h:
2623
2624         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2625         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2626
2627         (WTR::TestOptions::hasSameInitializationOptions const):
2628         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2629         (WTR::UIScriptController::calendarType const):
2630         (WTR::UIScriptController::platformUndoManager const):
2631         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2632         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2633         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2634         (-[TestRunnerWKWebView dealloc]):
2635         (-[TestRunnerWKWebView _didShowMenu]):
2636         (-[TestRunnerWKWebView _didHideMenu]):
2637
2638         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2639
2640         * WebKitTestRunner/ios/TestControllerIOS.mm:
2641         (WTR::handleMenuWillHideNotification):
2642         (WTR::handleMenuDidHideNotification):
2643         (WTR::TestController::platformInitialize):
2644         (WTR::TestController::platformDestroy):
2645         (WTR::TestController::platformResetStateToConsistentValues):
2646
2647         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2648         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2649
2650         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2651         (WTR::forEachViewInHierarchy):
2652         (WTR::findViewInHierarchyOfType):
2653
2654         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2655         functions that dig through a given view's hierarchy in search of a view of a given class.
2656
2657         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2658         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2659         (WTR::UIScriptController::selectionCaretViewRect const):
2660         (WTR::UIScriptController::selectionRangeViewRects const):
2661         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2662         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2663
2664         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2665
2666         (WTR::UIScriptController::rectForMenuAction const):
2667
2668         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2669         callout bar) whose label matches the given string.
2670
2671         (WTR::UIScriptController::platformContentView const):
2672
2673         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2674         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2675         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2676
2677         (WTR::UIScriptController::platformUndoManager const): Deleted.
2678         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2679         (WTR::UIScriptController::platformContentView const):
2680         (WTR::UIScriptController::platformUndoManager const): Deleted.
2681
2682 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2683
2684         webkitpy: No option to only show unexpected failures in results.html for iPad
2685         https://bugs.webkit.org/show_bug.cgi?id=194554
2686         <rdar://problem/47922442>
2687
2688         Rubber-stamped by Aakash Jain.
2689
2690         Just because a TestExpecations file does not exist for a specific platform does not mean that
2691         TestExpecations are not being used, given that platforms inherit test expectations.
2692
2693         * Scripts/webkitpy/port/base.py:
2694         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2695         * Scripts/webkitpy/port/base_unittest.py:
2696         (PortTest.test_uses_test_expectations_file):
2697
2698 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2699
2700         Remove setDefersLoading infrastructure from WebKit2
2701         https://bugs.webkit.org/show_bug.cgi?id=194506
2702
2703         Reviewed by Brady Eidson.
2704
2705         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2706         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2707         (WTR::TestRunner::setDefersLoading): Deleted.
2708         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2709
2710 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2711
2712         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2713         https://bugs.webkit.org/show_bug.cgi?id=194522
2714         <rdar://problem/47789393>
2715
2716         Reviewed by Chris Dumez.
2717
2718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2719         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2720         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2721         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2722
2723 2019-02-12  Andy Estes  <aestes@apple.com>
2724
2725         [iOSMac] Enable Parental Controls Content Filtering
2726         https://bugs.webkit.org/show_bug.cgi?id=194521
2727         <rdar://39732376>
2728
2729         Reviewed by Tim Horton.
2730
2731         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2732
2733 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2734
2735         [LFC][IFC] Add intrinsic width support for float boxes.
2736         https://bugs.webkit.org/show_bug.cgi?id=194528
2737
2738         Reviewed by Antti Koivisto.
2739
2740         Expand tests coverage (2 new tests -> 800).
2741         (This is the correct test ordering --runs-singly --child-processes=1)
2742
2743         * LayoutReloaded/misc/LFC-passing-tests.txt:
2744
2745 2019-02-12  Rob Buis  <rbuis@igalia.com>
2746
2747         Implement serializing in MIME type parser
2748         https://bugs.webkit.org/show_bug.cgi?id=193909
2749
2750         Reviewed by Darin Adler.
2751
2752         Add various tests involving upper case, non-ASCII, control/null characters,
2753         various HTTP whitespace, single quotes and an unpaired surrogate.
2754
2755         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2756         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2757         (TestWebKitAPI::serializeIfValid):
2758         (TestWebKitAPI::TEST):
2759
2760 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2761
2762         [Cocoa] Ask platform for generic font family mappings
2763         https://bugs.webkit.org/show_bug.cgi?id=187723
2764         <rdar://problem/41892438>
2765
2766         Reviewed by Brent Fulgham.
2767
2768         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2769
2770         * DumpRenderTree/mac/DumpRenderTree.mm:
2771         (allowedFontFamilySet):
2772         * WebKitTestRunner/mac/TestControllerMac.mm:
2773         (WTR::allowedFontFamilySet):
2774
2775 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2776
2777         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2778         https://bugs.webkit.org/show_bug.cgi?id=193622
2779
2780         Reviewed by Michael Catanzaro.
2781
2782         This adds support for loading content extension rule sets from the JSON files which
2783         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2784         of WKTR for this could be removed, but that is left for a follow-up patch with
2785         cleanups.
2786
2787         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2788         * WebKitTestRunner/TestController.cpp:
2789         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2790         avoid having the null-terminator copied into the result.
2791         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2792         part of the preparations to run a test.
2793         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2794         (WTR::contentExtensionStoreCallback): Added.
2795         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2796         used for content extensions test.
2797         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2798         extensions and compiling the JSON rule set for tests involving content extensions.
2799         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2800         testing and disables content extensions.
2801         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2802         resetContentExtensions().
2803         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2804         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2805         configureContentExtensionForTest(), and userContentController().
2806
2807 2019-02-11  Daniel Bates  <dabates@apple.com>
2808
2809         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2810         https://bugs.webkit.org/show_bug.cgi?id=191446
2811         <rdar://problem/45929460>
2812
2813         Reviewed by Tim Horton.
2814
2815         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2816
2817         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2818         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2819         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2820         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2821         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2822         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2823         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2824         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2825         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2826         (WTR::arrayLength):
2827         (WTR::parseModifierArray):
2828         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2829         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2830         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2831         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2832
2833 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2834
2835         Unreviewed, rolling out r241272 and r241276.
2836         https://bugs.webkit.org/show_bug.cgi?id=194514
2837
2838         Broke the Apple Internal build and the fix requires human
2839         intervention :( (Requested by dydz on #webkit).
2840
2841         Reverted changesets:
2842
2843         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2844         https://bugs.webkit.org/show_bug.cgi?id=191446
2845         https://trac.webkit.org/changeset/241272
2846
2847         "Fix internal iOS build after r241272"
2848         https://bugs.webkit.org/show_bug.cgi?id=191446
2849         https://trac.webkit.org/changeset/241276
2850
2851 2019-02-11  Truitt Savell  <tsavell@apple.com>
2852
2853         Unreviewed, rolling out r241269.
2854
2855         Caused 5 layout tests crashes on Mac WK1
2856
2857         Reverted changeset:
2858
2859         "DumpRenderTree should report unknown options"
2860         https://bugs.webkit.org/show_bug.cgi?id=191303
2861         https://trac.webkit.org/changeset/241269
2862
2863 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2864
2865         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2866         https://bugs.webkit.org/show_bug.cgi?id=194313
2867
2868         Reviewed by Tim Horton.
2869
2870         Add a helper to determine whether the web view is presenting modal UI.
2871
2872         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2873         (WTR::UIScriptController::isPresentingModally const):
2874         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2875         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2876         (WTR::UIScriptController::isPresentingModally const):
2877         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2878         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2879         (WTR::UIScriptController::calendarType const): Deleted.
2880         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2881         (WTR::UIScriptController::isPresentingModally const):
2882         (WTR::UIScriptController::calendarType const):
2883         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2884         (WTR::UIScriptController::calendarType const):
2885
2886 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2887
2888         GCHeapInspector: Show the retained sizes in more places
2889         https://bugs.webkit.org/show_bug.cgi?id=194464
2890
2891         Reviewed by Simon Fraser.
2892
2893         * GCHeapInspector/gc-heap-inspector.html:
2894         * GCHeapInspector/script/interface.js:
2895         (HeapInspectorUtils.humanReadableSize):
2896         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2897         (HeapInspectorUtils.spanForNode.span.span):
2898         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2899         (HeapSnapshotInspector.prototype.buildRoots):
2900
2901 2019-02-11  Daniel Bates  <dabates@apple.com>
2902
2903         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2904         https://bugs.webkit.org/show_bug.cgi?id=191446
2905         <rdar://problem/45929460>
2906
2907         Reviewed by Tim Horton.
2908
2909         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2910
2911         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2912         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2913         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2914         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2915         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2916         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2917         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2918         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2919         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2920         (WTR::arrayLength):
2921         (WTR::parseModifierArray):
2922         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2923         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2924         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2925         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2926
2927 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2928
2929         DumpRenderTree should report unknown options
2930         https://bugs.webkit.org/show_bug.cgi?id=191303
2931
2932         Reviewed by Frédéric Wang.
2933
2934         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2935         to report unknown options.
2936         Added and assigned test options which are currently used in tests.
2937
2938         * DumpRenderTree/TestOptions.cpp:
2939         (TestOptions::TestOptions):
2940
2941 2019-02-11  Truitt Savell  <tsavell@apple.com>
2942
2943         Unreviewed, rolling out r241229.
2944
2945         Revision broke internal builds for watchOS.
2946
2947         Reverted changeset:
2948
2949         "[Cocoa] Ask platform for generic font family mappings"
2950         https://bugs.webkit.org/show_bug.cgi?id=187723
2951         https://trac.webkit.org/changeset/241229
2952
2953 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2954
2955         [WinCairo][MiniBrowser] Basic authentication always fails.
2956         https://bugs.webkit.org/show_bug.cgi?id=194496
2957
2958         Reviewed by Don Olmstead.
2959
2960         * MiniBrowser/win/DialogHelper.h:
2961         (Dialog::getText):
2962
2963 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2964
2965         [GStreamer] GstMappedBuffer testsuite build fails
2966         https://bugs.webkit.org/show_bug.cgi?id=194495
2967
2968         Reviewed by Carlos Garcia Campos.
2969
2970         Fix the build by explicitely adding the gstreamer1.0-audio include
2971         directories to the include path.
2972
2973         * TestWebKitAPI/PlatformGTK.cmake:
2974         * TestWebKitAPI/PlatformWPE.cmake:
2975
2976 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2977
2978         [GTK][WPE] Add enable-javascript-markup setting
2979         https://bugs.webkit.org/show_bug.cgi?id=193439
2980
2981         Reviewed by Michael Catanzaro.
2982
2983         Add test cases to check the new setting.
2984
2985         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2986         (testWebKitSettings):
2987         (testWebKitSettingsJavaScriptMarkup):
2988         (beforeAll):
2989
2990 2019-02-10  Darin Adler  <darin@apple.com>
2991
2992         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2993         https://bugs.webkit.org/show_bug.cgi?id=194485
2994
2995         Reviewed by Daniel Bates.
2996
2997         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2998
2999 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3000
3001         Add more tests for clampTo<>()
3002         https://bugs.webkit.org/show_bug.cgi?id=194462
3003
3004         Reviewed by Geoffrey Garen.
3005
3006         Darin suggested to test the very last floating point number
3007         at the boundaries when truncating to integer.
3008         I added test for max/min and max-1/min-1.
3009
3010         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3011         (TestWebKitAPI::TEST):
3012
3013 2019-02-09  Darin Adler  <darin@apple.com>
3014
3015         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
3016         https://bugs.webkit.org/show_bug.cgi?id=194021
3017
3018         Reviewed by Geoffrey Garen.
3019
3020         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3021         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
3022         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
3023
3024 2019-02-09  Zalan Bujtas  <zalan@apple.com>
3025
3026         [LFC][IFC] Add intrinsic width support for basic inline containers
3027         https://bugs.webkit.org/show_bug.cgi?id=194473
3028
3029         Reviewed by Antti Koivisto.
3030
3031         Expand tests coverage (11 new tests -> 798)
3032
3033         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
3034
3035 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3036
3037         Fix MiniBrowser's entitlements
3038         https://bugs.webkit.org/show_bug.cgi?id=192431
3039
3040         Reviewed by Joseph Pecoraro.
3041
3042         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
3043         files, making it impossible to load any extension.
3044
3045         * MiniBrowser/MiniBrowser.entitlements:
3046
3047 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
3048
3049         [Cocoa] Ask platform for generic font family mappings
3050         https://bugs.webkit.org/show_bug.cgi?id=187723
3051         <rdar://problem/41892438>
3052
3053         Reviewed by Brent Fulgham.
3054
3055         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3056
3057         * DumpRenderTree/mac/DumpRenderTree.mm:
3058         (allowedFontFamilySet):
3059         * WebKitTestRunner/mac/TestControllerMac.mm:
3060         (WTR::allowedFontFamilySet):
3061
3062 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
3063
3064         [GTK] Implement back/forward touchpad gesture
3065         https://bugs.webkit.org/show_bug.cgi?id=193919
3066
3067         Reviewed by Michael Catanzaro.
3068
3069         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3070         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
3071
3072 2019-02-08  Alex Christensen  <achristensen@webkit.org>
3073
3074         Add SPI to use networking daemon instead of XPC service
3075         https://bugs.webkit.org/show_bug.cgi?id=194427
3076
3077         Reviewed by Geoffrey Garen
3078
3079         * MiniBrowser/MiniBrowser.entitlements:
3080
3081 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3082
3083         [ews-build] Ensure that every builder in config.json has short name
3084         https://bugs.webkit.org/show_bug.cgi?id=194461
3085
3086         Reviewed by Lucas Forschler.
3087
3088         * BuildSlaveSupport/ews-build/loadConfig.py:
3089         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
3090
3091 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3092
3093         [ews-build] Add short name to config.json
3094         https://bugs.webkit.org/show_bug.cgi?id=194456
3095
3096         Reviewed by Lucas Forschler.
3097
3098         * BuildSlaveSupport/ews-build/config.json: Added short name.
3099         * BuildSlaveSupport/ews-build/loadConfig.py:
3100         (loadBuilderConfig): Set the short name as the builder description.
3101
3102 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
3103
3104         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
3105         https://bugs.webkit.org/show_bug.cgi?id=194418
3106
3107         Reviewed by Lucas Forschler.
3108
3109         Do not include errors trying when finding crashlogs at the end of
3110         a run-webkit-tests run since we don't process those errors.
3111
3112         * Scripts/webkitpy/port/darwin.py:
3113         (DarwinPort._look_for_all_crash_logs_in_log_dir):
3114         * Scripts/webkitpy/port/ios_device.py:
3115         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
3116         * Scripts/webkitpy/port/watch_device.py:
3117         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
3118
3119 2019-02-08  Beth Dakin  <bdakin@apple.com>
3120
3121         Add afterScreenUpdates to WKSnapshotConfiguration
3122         https://bugs.webkit.org/show_bug.cgi?id=194362
3123         -and corresponding-
3124         <rdar://problem/40655528> Please add an "after screen updates" property to 
3125         WKSnapshotConfiguration (to solve blank snapshots)
3126
3127         Reviewed by Tim Horton.
3128
3129         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
3130         (TEST):
3131
3132 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
3133
3134         clampTo(): do not convert the input to double when dealing with integers
3135         https://bugs.webkit.org/show_bug.cgi?id=194263
3136         <rdar://problem/47692312>
3137
3138         Reviewed by Darin Adler.
3139
3140         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3141         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
3142         (TestWebKitAPI::testClampFloatingPointToInteger):
3143         (TestWebKitAPI::testClampSameSignIntegers):
3144         (TestWebKitAPI::testClampUnsignedToSigned):
3145         (TestWebKitAPI::testClampSignedToUnsigned):
3146
3147 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
3148
3149         webkitpy: Respect --dedicated-simulators flag
3150         https://bugs.webkit.org/show_bug.cgi?id=194416
3151         <rdar://problem/47894722>
3152
3153         Reviewed by Lucas Forschler.
3154
3155         * Scripts/webkitpy/port/device_port.py:
3156         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
3157         available devices can be safely ignored.
3158
3159 2019-02-07  Keith Rollin  <krollin@apple.com>
3160
3161         Remove extra copy of 100x100-red.tga
3162         https://bugs.webkit.org/show_bug.cgi?id=194371
3163         <rdar://problem/47873465>
3164
3165         Reviewed by Said Abou-Hallawa.
3166
3167         In order to help it pass its tests, Bug 194190 added a second copy of
3168         the file 100x100-red.tga. However, it turns out that this additional
3169         file wasn't actually needed, and that that sole previous copy was
3170         sufficient. At the same time, this second copy -- which was copied to
3171         the same location in the build output as the first copy -- now caused
3172         XCBuild to complain because there were two production rules for the
3173         same output file. Address this by removing the newly-added extra copy.
3174
3175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3176         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
3177
3178 2019-02-07  Alex Christensen  <achristensen@webkit.org>
3179
3180         Deprecate WKBundlePageSetDefersLoading
3181         https://bugs.webkit.org/show_bug.cgi?id=191394
3182
3183         Reviewed by Dean Jackson.
3184
3185         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3186         (WTR::TestRunner::setDefersLoading):
3187
3188 2019-02-07  Zalan Bujtas  <zalan@apple.com>
3189
3190         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
3191         https://bugs.webkit.org/show_bug.cgi?id=194391
3192
3193         Reviewed by Antti Koivisto.
3194
3195         * LayoutReloaded/misc/LFC-passing-tests.txt:
3196
3197 2019-02-06  Keith Rollin  <krollin@apple.com>
3198
3199         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
3200         https://bugs.webkit.org/show_bug.cgi?id=193975
3201         <rdar://problem/47643306>
3202
3203         Reviewed by Tim Horton.
3204
3205         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
3206         the Info.plist file into the bundle. This step is not necessary as the
3207         implicit "bundle up all the build products into a framework" build
3208         phase does this already. Having the Copy Bundle Resources phase do
3209         this causes a conflict under XCBuild, which objects to two build
3210         phases producing the same file (Info.plist). Address this by removing
3211         Info.plist from the Copy Bundle Resources phase.
3212
3213         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3214
3215 2019-02-06  Keith Rollin  <krollin@apple.com>
3216
3217         Really enable the automatic checking and regenerations of .xcfilelists during builds
3218         https://bugs.webkit.org/show_bug.cgi?id=194357
3219         <rdar://problem/47861231>
3220
3221         Reviewed by Chris Dumez.
3222
3223         Bug 194124 was supposed to enable the automatic checking and
3224         regenerating of .xcfilelist files during the build. While related
3225         changes were included in that patch, the change to actually enable the
3226         operation somehow was omitted. This patch actually enables the
3227         operation. The check-xcfilelist.sh scripts now check
3228         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3229         from the checking.
3230
3231         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3232         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3233
3234 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3235
3236         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3237         <https://webkit.org/b/194286>
3238         <rdar://problem/47815558>
3239
3240         Reviewed by Alexey Proskuryakov.
3241
3242         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3243         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
3244         WKRetainPtr<> to avoid leaking the WKDataRef.
3245
3246 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3247
3248         Unreviewed, fix a typo
3249
3250         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3251
3252 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
3253
3254         [GTK][WPE] force libpsl build to use ICU in jhbuild
3255         https://bugs.webkit.org/show_bug.cgi?id=194288
3256
3257         Reviewed by Carlos Garcia Campos.
3258
3259         * gtk/jhbuild.modules:
3260         Require ICU for libpsl build in jhbuild, like done in WPE.
3261
3262 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3263
3264         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3265         https://bugs.webkit.org/show_bug.cgi?id=194209
3266
3267         Reviewed by Carlos Garcia Campos.
3268
3269         Enhance TestCookieManager to ensure this doesn't happen again.
3270
3271         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3272         (testCookieManagerPersistentStorage):
3273         (beforeAll):
3274
3275 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3276
3277         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
3278         https://bugs.webkit.org/show_bug.cgi?id=194324
3279
3280         Reviewed by Andy Estes.
3281
3282         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
3283         part of the name is already implicit, since this is in testing code in TestOptions.
3284
3285         * WebKitTestRunner/TestController.cpp:
3286         (WTR::TestController::generateContextConfiguration const):
3287         (WTR::updateTestOptionsFromTestHeader):
3288         * WebKitTestRunner/TestOptions.h:
3289         (WTR::TestOptions::hasSameInitializationOptions const):
3290
3291 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3292
3293         [ews-build] Allow * as platform for builders and workers
3294         https://bugs.webkit.org/show_bug.cgi?id=188533
3295
3296         Reviewed by Lucas Forschler.
3297
3298         * BuildSlaveSupport/ews-build/loadConfig.py:
3299         (checkWorkersAndBuildersForConsistency):
3300
3301 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3302
3303         [ews-build] Add few bots to config.json
3304         https://bugs.webkit.org/show_bug.cgi?id=194304
3305
3306         Reviewed by Lucas Forschler.
3307
3308         * BuildSlaveSupport/ews-build/config.json:
3309
3310 2019-02-05  Keith Rollin  <krollin@apple.com>
3311
3312         Enable the automatic checking and regenerations of .xcfilelists during builds
3313         https://bugs.webkit.org/show_bug.cgi?id=194124
3314         <rdar://problem/47721277>
3315
3316         Reviewed by Tim Horton.
3317
3318         Bug 193790 add a facility for checking -- during build time -- that
3319         any needed .xcfilelist files are up-to-date and for updating them if
3320         they are not. This facility was initially opt-in by setting
3321         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
3322         the process seemed robust. Its now time to enable this facility and
3323         make it opt-out. If there is a need to disable this facility, set and
3324         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
3325         running `make` or `build-webkit`, or before running Xcode from the
3326         command line.
3327
3328         Additionally, remove the step that generates a list of source files
3329         going into the UnifiedSources build step. It's only necessarily to
3330         specify Sources.txt and SourcesCocoa.txt as inputs.
3331
3332         * Scripts/generate-xcfilelists:
3333
3334 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3335
3336         [GTK][WPE] force libpsl build to use ICU in jhbuild
3337         https://bugs.webkit.org/show_bug.cgi?id=194288
3338
3339         Reviewed by Philippe Normand.
3340
3341         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
3342         This can cause build failures if libidn is detected but libunistring is not available.
3343
3344         Make sure that ICU is used for runtime and builtin PSL data.
3345
3346         * gtk/jhbuild.modules:
3347         * wpe/jhbuild.modules:
3348
3349 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3350
3351         [ews-app] Modified timestamp should be updated on updating data
3352         https://bugs.webkit.org/show_bug.cgi?id=194295
3353
3354         Reviewed by Lucas Forschler.
3355
3356         * BuildSlaveSupport/ews-app/ews/models/build.py:
3357         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3358         * BuildSlaveSupport/ews-app/ews/models/step.py:
3359
3360 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3361
3362         Unreviewed, rolling out r240742.
3363
3364         Causes crashes on iOS simulator.
3365
3366         Reverted changeset:
3367
3368         "[iOS] Keyups for non-modifier keys identified as "Dead" when
3369         not focused in a content-editable element"
3370         https://bugs.webkit.org/show_bug.cgi?id=192824
3371         https://trac.webkit.org/changeset/240742
3372
3373 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
3374
3375         run-webkit-tests emits message "...running None" when running tests
3376         https://bugs.webkit.org/show_bug.cgi?id=194133
3377         <rdar://problem/47724738>
3378
3379         Reviewed by Lucas Forschler.
3380
3381         * Scripts/webkitpy/xcode/device_type.py:
3382         (DeviceType.__str__): Use both version mapping tables and use just the variant
3383         name if no version name is available.
3384         * Scripts/webkitpy/xcode/device_type_unittest.py:
3385         (DeviceTypeTest):
3386         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
3387         an associated named.
3388
3389 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3390
3391         [WPE] require python3-setuptools for meson build in jhbuild
3392         https://bugs.webkit.org/show_bug.cgi?id=194287
3393
3394         Reviewed by Philippe Normand.
3395
3396         python3-setuptools is needed to build meson in jhbuild.
3397         It is already required by the GTK port.
3398
3399         * wpe/install-dependencies:
3400
3401 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3402
3403         [ews-app] Add method to save BuilderMapping to database
3404         https://bugs.webkit.org/show_bug.cgi?id=194264
3405
3406         Reviewed by Lucas Forschler.
3407
3408         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3409         (BuilderMapping.__str__):
3410         (BuilderMapping):
3411         (BuilderMapping.save_mapping):
3412         (BuilderMapping.update_mapping):
3413         (BuilderMapping.get_existing_mapping):
3414         (BuilderMapping.is_valid_mapping):
3415
3416 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3417
3418         [ews-app] Add timestamp fields for BuilderMappings
3419         https://bugs.webkit.org/show_bug.cgi?id=194266
3420
3421         Reviewed by Lucas Forschler.
3422
3423         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3424         (BuilderMapping):
3425
3426 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
3427
3428         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3429         https://bugs.webkit.org/show_bug.cgi?id=174816
3430
3431         Reviewed by Michael Catanzaro.
3432
3433         Add tests for webkit_uri_for_display().
3434
3435         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3436         (testURIForDisplayUnaffected):
3437         (testURIForDisplayAffected):
3438         (beforeAll):
3439         (afterAll):
3440         * TestWebKitAPI/glib/CMakeLists.txt:
3441
3442 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
3443
3444         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
3445         https://bugs.webkit.org/show_bug.cgi?id=194158
3446         <rdar://problem/47737268>
3447
3448         Rubber-stamped by Aakash Jain.
3449
3450         * Scripts/webkitpy/port/device_port.py:
3451         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3452
3453 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3454
3455         [CG] Enable setAdditionalSupportedImageTypes for WK1
3456         https://bugs.webkit.org/show_bug.cgi?id=194190
3457
3458         Reviewed by Tim Horton.
3459
3460         Add a test similar to the one under WebKit Cocoa but make it create a
3461         WebView instead of a WKWebView.
3462
3463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3464         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3465         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3466         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3467         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3468         (TestWebKitAPI::runTest):
3469         (TestWebKitAPI::TEST):
3470
3471 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3472
3473         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3474         https://bugs.webkit.org/show_bug.cgi?id=194168
3475
3476         Reviewed by Simon Fraser.
3477
3478         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3479
3480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3481         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3482         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3483         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3484         (TEST):
3485         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3486         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3487
3488 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3489
3490         REGRESSION (r237269): webkit-patch what-broke is broken 
3491         https://bugs.webkit.org/show_bug.cgi?id=193025
3492
3493         Reviewed by Aakash Jain.
3494
3495         * Scripts/webkitpy/common/host.py:
3496         (Host.buildbot):
3497         (Host.bugzilla): Renamed to 'buildbot'.
3498
3499 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3500
3501         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3502         https://bugs.webkit.org/show_bug.cgi?id=194207
3503
3504         Reviewed by Tim Horton.
3505
3506         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3507         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3508         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3509         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3510         start and delete forwards to remove the original attachment.
3511
3512         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3513         (TestWebKitAPI::TEST):
3514
3515 2019-02-04  Youenn Fablet  <youenn@apple.com>
3516
3517         Capture state should be managed consistently when doing process swapping
3518         https://bugs.webkit.org/show_bug.cgi?id=194122
3519         <rdar://problem/47609293>
3520
3521         Reviewed by Eric Carlson.
3522
3523         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3524         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3525         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3526         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3527         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3528         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3529         (WTR::TestRunner::isDoingMediaCapture const):
3530         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3531         * WebKitTestRunner/TestController.cpp:
3532         (WTR::TestController::isDoingMediaCapture const):
3533         * WebKitTestRunner/TestController.h:
3534         * WebKitTestRunner/TestInvocation.cpp:
3535         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3536         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3537         (WTR::TestController::isDoingMediaCapture const):
3538
3539 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3540
3541         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3542         https://bugs.webkit.org/show_bug.cgi?id=194142
3543
3544         Reviewed by Ross Kirsling.
3545
3546         There three 'separator' variables in TestController.cpp. Renamed
3547         it 'pathSeparator', and unified them.
3548
3549         * WebKitTestRunner/TestController.cpp:
3550         (WTR::TestController::generateContextConfiguration const):
3551         (WTR::createTestURL):
3552         (WTR::TestController::platformAdjustContext):
3553
3554 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3555
3556         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3557         https://bugs.webkit.org/show_bug.cgi?id=194198
3558
3559         Reviewed by Antti Koivisto.
3560
3561         No need to set the banner heights on navigation now, since Page stores them.
3562
3563         * MiniBrowser/mac/WK2BrowserWindowController.m:
3564         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3565
3566 2019-02-03  John Wilander  <wilander@apple.com>
3567
3568         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3569         https://bugs.webkit.org/show_bug.cgi?id=194104
3570         <rdar://problem/47649991>
3571
3572         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3573
3574         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3575         (TestWebKitAPI::TEST):
3576             Changed numeric types from unsigned short to uint32_t.
3577
3578 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3579
3580         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3581         <https://webkit.org/b/194178>
3582         <rdar://problem/47753473>
3583
3584         Reviewed by Alexey Proskuryakov.
3585
3586         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3587         (WTR::uninstallFakeHelvetica): Pass nullptr into
3588         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3589
3590 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3591
3592         [LFC] Initialize ICB's style with fixed width/height.
3593         https://bugs.webkit.org/show_bug.cgi?id=194188
3594
3595         Reviewed by Antti Koivisto.
3596
3597         * LayoutReloaded/misc/LFC-passing-tests.txt:
3598
3599 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3600
3601         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3602         https://bugs.webkit.org/show_bug.cgi?id=194185
3603
3604         Reviewed by Antti Koivisto.
3605
3606         * LayoutReloaded/misc/LFC-passing-tests.txt:
3607
3608 2018-12-16  Darin Adler  <darin@apple.com>
3609
3610         Convert additional String::format clients to alternative approaches
3611         https://bugs.webkit.org/show_bug.cgi?id=192746
3612
3613         Reviewed by Alexey Proskuryakov.
3614
3615         * WebKitTestRunner/TestController.cpp:
3616         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3617         as an intermediate in code that ultimately constructs a WTF::String.
3618         (WTR::userMediaOriginHash): Use makeString.
3619         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3620         (WTR::TestController::didPerformClientRedirect): Ditto.
3621         (WTR::TestController::didPerformServerRedirect): Ditto.
3622         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3623
3624 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3625
3626         [ews-build] Add unit test to verify builder keys
3627         https://bugs.webkit.org/show_bug.cgi?id=194152
3628
3629         Reviewed by Lucas Forschler.
3630
3631         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3632         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3633
3634 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3635
3636         [LFC] Expand tests coverage (12 new tests -> 787)
3637
3638         Unreviewed test gardening.
3639
3640         * LayoutReloaded/misc/LFC-passing-tests.txt:
3641
3642 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3643
3644         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3645         https://bugs.webkit.org/show_bug.cgi?id=194163
3646
3647         Reviewed by Simon Fraser.
3648
3649         775
3650
3651         * LayoutReloaded/misc/LFC-passing-tests.txt:
3652
3653 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3654
3655         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3656         https://bugs.webkit.org/show_bug.cgi?id=194140
3657         <rdar://problem/47728098>
3658
3659         Reviewed by Tim Horton.
3660
3661         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3662         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3663         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3664
3665         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3666         test to induce an IPC deadlock when presenting a modal alert during touch start.
3667
3668         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3669         * WebKitTestRunner/TestController.cpp:
3670         (WTR::runJavaScriptAlert):
3671
3672         Add a client callback function for running JavaScript alerts.
3673
3674         (WTR::TestController::createOtherPage):
3675         (WTR::TestController::generateContextConfiguration const):
3676
3677         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3678         the fix in this patch.
3679
3680         (WTR::TestController::createWebViewWithOptions):
3681
3682         Plumb TestOptions to generateContextConfiguration.
3683
3684         (WTR::TestController::resetPreferencesToConsistentValues):
3685         (WTR::TestController::resetStateToConsistentValues):
3686         (WTR::updateTestOptionsFromTestHeader):
3687         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3688         (WTR::TestController::handleJavaScriptAlert):
3689         * WebKitTestRunner/TestController.h:
3690         * WebKitTestRunner/TestInvocation.cpp:
3691         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3692         * WebKitTestRunner/TestOptions.h:
3693         (WTR::TestOptions::hasSameInitializationOptions const):
3694
3695 2019-02-01  Chris Dumez  <cdumez@apple.com>
3696
3697         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3698         https://bugs.webkit.org/show_bug.cgi?id=193740
3699         <rdar://problem/47527267>
3700
3701         Reviewed by Alex Christensen.
3702
3703         Add API test coverage.
3704
3705         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3706
3707 2019-02-01  Aakash Jain  <aakash_jain@apple.com>