Crash when following a Google search link to Twitter with Limit Adult Content enabled
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-26  Andy Estes  <aestes@apple.com>
2
3         Crash when following a Google search link to Twitter with Limit Adult Content enabled
4         https://bugs.webkit.org/show_bug.cgi?id=147651
5
6         Rubber-stamped by Brady Eidson.
7
8         Taught TestRunner how to decide the navigation policy after a delay.
9
10         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
11         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
12         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
13         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
14         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
15         * WebKitTestRunner/InjectedBundle/TestRunner.h:
16         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
17         * WebKitTestRunner/TestController.cpp:
18         (WTR::TestController::initialize):
19         (WTR::TestController::resetStateToConsistentValues):
20         (WTR::TestController::decidePolicyForNavigationAction):
21         * WebKitTestRunner/TestController.h:
22         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
23         * WebKitTestRunner/TestInvocation.cpp:
24         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
25
26 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
27
28         [Win] Rename 'WinLauncher' to 'MiniBrowser'
29         https://bugs.webkit.org/show_bug.cgi?id=148485
30
31         Reviewed by Alex Christensen
32
33         Move the WinLauncher project and source files to a subdirectory
34         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
35         source code and project files.
36         
37         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
38         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
39         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
40         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
41         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
42         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
43         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
44         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
45         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
46         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
47         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
48         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
49         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
50         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
51         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
52         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
53         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
54         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
55         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
56         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
57         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
58         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
59         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
60         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
61         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
62         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
63         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
64         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
65         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
66         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
67         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
68         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
69         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
70         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
71         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
72         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
73         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
74         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
75         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
76         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
77         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
78         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
79         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
80         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
81         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
82         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
83         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
84         * MiniBrowser/win: Copied from WinLauncher.
85         * MiniBrowser/win/Common.cpp:
86         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
87         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
88         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
89         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
90         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
91         * MiniBrowser/win/PageLoadTestClient.cpp:
92         * MiniBrowser/win/PageLoadTestClient.h:
93         * MiniBrowser/win/ResourceLoadDelegate.cpp:
94         * MiniBrowser/win/ResourceLoadDelegate.h:
95         * MiniBrowser/win/WinLauncher.cpp: Removed.
96         * MiniBrowser/win/WinLauncher.h: Removed.
97         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
98         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
99         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
100         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
101         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
102         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
103         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
104         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
105         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
106         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
107         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
108         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
109         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
110         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
111         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
112         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
113         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
114         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
115         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
116         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
117         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
118         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
119         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
120         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
121         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
122         * MiniBrowser/win/WinLauncherReplace.h: Removed.
123         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
124         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
125         * MiniBrowser/win/WinMain.cpp:
126         * WinLauncher: Removed.
127         * WinLauncher/AccessibilityDelegate.cpp: Removed.
128         * WinLauncher/AccessibilityDelegate.h: Removed.
129         * WinLauncher/CMakeLists.txt: Removed.
130         * WinLauncher/Common.cpp: Removed.
131         * WinLauncher/DOMDefaultImpl.cpp: Removed.
132         * WinLauncher/DOMDefaultImpl.h: Removed.
133         * WinLauncher/PageLoadTestClient.cpp: Removed.
134         * WinLauncher/PageLoadTestClient.h: Removed.
135         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
136         * WinLauncher/PrintWebUIDelegate.h: Removed.
137         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
138         * WinLauncher/ResourceLoadDelegate.h: Removed.
139         * WinLauncher/WebDownloadDelegate.cpp: Removed.
140         * WinLauncher/WebDownloadDelegate.h: Removed.
141         * WinLauncher/WinLauncher.cpp: Removed.
142         * WinLauncher/WinLauncher.h: Removed.
143         * WinLauncher/WinLauncher.vcxproj: Removed.
144         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
145         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
146         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
147         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
148         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
149         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
150         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
151         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
152         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
153         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
154         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
155         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
156         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
157         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
158         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
159         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
160         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
161         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
162         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
163         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
164         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
165         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
166         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
167         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
168         * WinLauncher/WinLauncherReplace.h: Removed.
169         * WinLauncher/WinLauncherWebHost.cpp: Removed.
170         * WinLauncher/WinLauncherWebHost.h: Removed.
171         * WinLauncher/WinMain.cpp: Removed.
172         * WinLauncher/resource.h: Removed.
173         * WinLauncher/stdafx.cpp: Removed.
174         * WinLauncher/stdafx.h: Removed.
175         * win/AssembleBuildLogs/AssembleLogs.cmd:
176
177 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
178
179         [Win] Simplify menu handling code in WinLauncher
180         https://bugs.webkit.org/show_bug.cgi?id=148461
181
182         Reviewed by Zalan Bujtas.
183
184         Revise 'ToggleMenuItem' to return a boolean value indicating if
185         it handled the message. Revise WndProc to use this to decide if it
186         should pass the message on to the default handler, rather than
187         duplicating the logic in both places.
188         
189         * WinLauncher/Common.cpp:
190         (ToggleMenuItem): Return true if the menu item message was handled.
191         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
192         the message tothe default handler.
193
194 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
195
196         Remove unused code after r188948
197         https://bugs.webkit.org/show_bug.cgi?id=148467
198
199         Reviewed by Gyuyoung Kim.
200
201         * WebKitTestRunner/TestController.cpp:
202         (WTR::TestController::platformPreferences): Deleted.
203
204 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
205
206         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
207         https://bugs.webkit.org/show_bug.cgi?id=148377
208
209         Reviewed by Carlos Garcia Campos.
210
211         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
212         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
213         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
214         EFL and GTK at the moment.
215
216         * WebKitTestRunner/TestController.cpp:
217         (WTR::TestController::platformWillRunTest):
218         * WebKitTestRunner/efl/TestControllerEfl.cpp:
219         (WTR::TestController::platformPreferences):
220         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
221         (WTR::TestController::platformPreferences):
222
223 2015-08-25  Nan Wang  <n_wang@apple.com>
224
225         AX: Enable accessibility/aria-controls.html test for mac
226         https://bugs.webkit.org/show_bug.cgi?id=148458
227
228         Reviewed by Chris Fleizach.
229
230         Implemented ariaControlsElementAtIndex(unsigned index).
231
232         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
233         (AccessibilityUIElement::ariaControlsElementAtIndex):
234         (AccessibilityUIElement::disclosedRowAtIndex):
235         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
236         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
237
238 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
239
240         Remove python tests for PassRefPtr 
241         https://bugs.webkit.org/show_bug.cgi?id=148463
242
243         Reviewed by Andy Estes.
244
245         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
246
247         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
248         (PassPtrTest): Deleted.
249         (PassPtrTest.assert_pass_ptr_check): Deleted.
250         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
251         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
252         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
253         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
254         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
255         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
256
257 2015-08-25  Andy Estes  <aestes@apple.com>
258
259         [iOS] run-webkit-tests fails if watchOS SDK is installed
260         https://bugs.webkit.org/show_bug.cgi?id=148453
261
262         Reviewed by David Kilzer.
263
264         * Scripts/webkitpy/xcode/simulator.py:
265         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
266         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
267
268 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
269
270         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
271         https://bugs.webkit.org/show_bug.cgi?id=148197
272         rdar://problem/22334382
273
274         Reviewed by Daniel Bates.
275
276         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
277         * Scripts/webkitpy/port/ios.py:
278         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
279         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
280         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
281         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
282         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
283
284 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
285
286         Remove PassRefPtr style check rule
287         https://bugs.webkit.org/show_bug.cgi?id=148432
288
289         Reviewed by Andreas Kling.
290
291         PassRefPtr is being removed. Thus style rule needs to be removed as well.
292
293         * Scripts/webkitpy/style/checkers/cpp.py:
294         (_check_parameter_name_against_text): Deleted.
295         (check_function_definition_and_pass_ptr): Deleted.
296         (check_function_definition): Deleted.
297         (check_pass_ptr_usage): Deleted.
298         (process_line): Deleted.
299         (CppChecker): Deleted.
300
301 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
302
303         [Win] Expose "Inverted Colors" option in WinLauncher
304         https://bugs.webkit.org/show_bug.cgi?id=148451
305
306         Reviewed by Tim Horton.
307
308         Add the ability to toggle the "Inverted Colors" preference
309         in WinLauncher.
310         
311         * WinLauncher/Common.cpp:
312         (ToggleMenuItem): Toggle the feature when the menu item
313         is selected.
314         (WndProc): Recognize the new menu option.
315         * WinLauncher/WinLauncher.cpp:
316         (WinLauncher::setToDefaultPreferences): Launch with "Invert
317         Colors" turned off.
318         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
319         entry for "Invert Colors".
320         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
321
322 2015-08-25  Nan Wang  <n_wang@apple.com>
323
324         [Mac] accessibility/document-attributes.html fails
325         https://bugs.webkit.org/show_bug.cgi?id=116636
326
327         Reviewed by Chris Fleizach.
328
329         Implemented documentURI() and documentEncoding().
330
331         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
332         (AccessibilityUIElement::documentEncoding):
333         (AccessibilityUIElement::documentURI):
334         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
335         (WTR::AccessibilityUIElement::documentEncoding):
336         (WTR::AccessibilityUIElement::documentURI):
337
338 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
339
340         [Win] Unreviewed test gardening.
341
342         Fix another case where the logging string is constructed using the variable 'frame',
343         but the method argument is not given a name. This causes the global 'frame' value to
344         be used, producing incorrect output.
345
346         * DumpRenderTree/win/FrameLoadDelegate.cpp:
347         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
348         argument.
349
350 2015-08-24  Tim Horton  <timothy_horton@apple.com>
351
352         (Finally...) get rid of WKViewIOS
353         https://bugs.webkit.org/show_bug.cgi?id=148404
354
355         Reviewed by Anders Carlsson.
356
357         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
358         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
359         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
360         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
361         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
362         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
363         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
364         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
365         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
366         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
367         Mark tests that use WKBrowsingContextController as Mac-only.
368
369         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
370         (WTR::AccessibilityController::addNotificationListener):
371         * WebKitTestRunner/ios/mainIOS.mm:
372         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
373         Import UIKit instead of depending on WKView.h to do so.
374
375 2015-08-24  Jason Marcell  <jmarcell@apple.com>
376
377         Add support to dashboard for displaying Git SHA's as revisions.
378         https://bugs.webkit.org/show_bug.cgi?id=148387
379
380         Reviewed by Daniel Bates.
381
382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
383         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
385         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
387         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
388
389 2015-08-24  Andy Estes  <aestes@apple.com>
390
391         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
392
393         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
394
395 2015-08-23  Andy Estes  <aestes@apple.com>
396
397         Addressed a missed piece of review feedback from r188851.
398
399         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
400
401 2015-08-23  Andy Estes  <aestes@apple.com>
402
403         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
404         https://bugs.webkit.org/show_bug.cgi?id=147872
405         rdar://problem/22044000
406
407         Reviewed by Dan Bernstein.
408         
409         Added an API test.
410
411         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
413         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
414         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
415         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
416         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
417         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
418         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
419         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
420         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
421         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
422
423 2015-08-23  Andy Estes  <aestes@apple.com>
424
425         Fixed the 32-bit Mac build after r188844.
426
427         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
428         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
429
430 2015-08-22  Andy Estes  <aestes@apple.com>
431
432         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
433         https://bugs.webkit.org/show_bug.cgi?id=148317
434
435         Reviewed by Dan Bernstein.
436
437         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
438         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
439         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
440         when creating WKWebViews.
441
442         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
443         added a new API test for bundle parameters.
444
445         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
446         named its executable TestWebKitAPI.bundle.
447         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
449         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
450         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
451         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
452         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
453         bundle parameter and asked for an initial notification.
454         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
455         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
456         mirror its value in the main frame's JSContext.
457         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
458         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
459         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
460         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
461         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
462         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
463         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
464         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
465         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
466         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
467
468 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
469
470         URTBF after r188828.
471
472         * WebKitTestRunner/PlatformWebView.h:
473
474 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
475
476         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
477         https://bugs.webkit.org/show_bug.cgi?id=148356
478
479         Reviewed by Darin Adler.
480
481         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
482         (BuildbotCombinedQueueView.prototype.update):
483
484 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
485
486         build.webkit.org/dashboard: Respect step's hidden flag
487         https://bugs.webkit.org/show_bug.cgi?id=148357
488
489         Reviewed by Darin Adler.
490
491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
492         (BuildbotIteration.prototype._parseData):
493
494 2015-08-23  Nan Wang  <n_wang@apple.com>
495
496         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
497         https://bugs.webkit.org/show_bug.cgi?id=148328
498
499         Reviewed by Darin Adler.
500
501         We should only expose stringValue() when value attribute is set.
502
503         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
504         (AccessibilityUIElement::stringValue):
505         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
506         (WTR::AccessibilityUIElement::stringValue):
507
508 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
509
510         Remove style checking rule regarding OwnPtr and PassOwnPtr
511         https://bugs.webkit.org/show_bug.cgi?id=148360
512
513         Reviewed by Darin Adler.
514
515         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
516         Removed it.
517
518         * Scripts/do-webcore-rename:
519         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
520         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
521         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
522         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
523         (WebKitStyleTest.test_names): Deleted.
524
525 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
526
527         WebKitTestRunner should use WKWebView on OS X and iOS
528         https://bugs.webkit.org/show_bug.cgi?id=143743
529         <rdar://problem/16947123>
530
531         Reviewed by Anders Carlsson.
532         Patch by Enrica Casucci and myself.
533
534         * WebKitTestRunner/PlatformWebView.h:
535         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
536         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
537         instead of WKContext and WKPageGroup.
538
539         Remove the unused, always-true windowSnapshotEnabled().
540         While technically some platforms don't have window snapshotting,
541         they just return null instead of implementing windowSnapshotEnabled().
542
543         * WebKitTestRunner/TestController.h:
544         * WebKitTestRunner/TestController.cpp:
545         (WTR::TestController::createOtherPage):
546         (WTR::TestController::initialize):
547         (WTR::TestController::createWebViewWithOptions):
548         Delegate to the various platforms for creating PlatformWebView instances,
549         for creating WKContexts, and for accessing WKPreferences,
550         so that they can do special things (like, use WKWebView instead!).
551
552         (WTR::TestController::resetPreferencesToConsistentValues):
553         Make explicit WebKitTestRunner's desired default for two preferences
554         which have differing defaults between the antique and modern API,
555         for consistency's sake.
556
557         (WTR::TestController::resetStateToConsistentValues):
558         Add platformResetStateToConsistentValues.
559
560         * WebKitTestRunner/TestInvocation.cpp:
561         (WTR::TestInvocation::dumpResults):
562         Adjust to the aforementioned removal of windowSnapshotEnabled().
563
564         * WebKitTestRunner/ios/TestControllerCocoa.mm:
565         (WTR::TestController::platformResetStateToConsistentValues):
566         (WTR::TestController::platformPreferences):
567         (WTR::TestController::platformCreateWebView):
568         (WTR::TestController::platformCreateOtherPage):
569         (WTR::TestController::platformInitializeConfiguration):
570         Implement the new platform functions for the Modern WebKit2 API,
571         in a new TestControllerCocoa file that is shared between iOS and Mac.
572         
573         For platformMaybeCreateContext, use the trick that we know we can cast
574         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
575         WKWebView's configuration.
576
577         Ditto for WKPreferencesRef and WKPreferences.
578
579         Remove user content filters on the WKWebView's userContentController.
580
581         * WebKitTestRunner/mac/TestControllerMac.mm:
582         * WebKitTestRunner/ios/TestControllerIOS.mm:
583         Move code into TestControllerCocoa.
584
585         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
586         (WTR::InjectedBundle::beginTesting):
587         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
588         (WTR::TestRunner::addUserScript):
589         (WTR::TestRunner::addUserStyleSheet):
590         Adopt WKBundlePage API for user scripts/sheets.
591
592         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
593         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
594         Make and keep a WKWebView instead of a WKView.
595         
596         * WebKitTestRunner/mac/EventSenderProxy.mm:
597         (WTR::EventSenderProxy::mouseUp):
598         (WTR::EventSenderProxy::mouseMoveTo):
599         Reach inside the WKWebView to the WKView when dispatching events.
600         This is fairly ugly and we should come up with a better solution.
601         Also, fix some flipping and style errors.
602
603 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
604
605         Unreviewed, attempt to fix GTK build after r188718
606
607         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
608         (WTR::PlatformWebView::PlatformWebView):
609
610 2015-08-21  Commit Queue  <commit-queue@webkit.org>
611
612         Unreviewed, rolling out r188807, r188813, and r188815.
613         https://bugs.webkit.org/show_bug.cgi?id=148349
614
615         lots of 32-bit build problems, better to resolve separately
616         and try again (Requested by thorton on #webkit).
617
618         Reverted changesets:
619
620         "WebKitTestRunner should use WKWebView on OS X and iOS"
621         https://bugs.webkit.org/show_bug.cgi?id=143743
622         http://trac.webkit.org/changeset/188807
623
624         "Stop building WebKitTestRunner for 32-bit platforms"
625         https://bugs.webkit.org/show_bug.cgi?id=143743
626         http://trac.webkit.org/changeset/188813
627
628         "Stop building WebKitTestRunner for 32-bit platforms"
629         https://bugs.webkit.org/show_bug.cgi?id=143743
630         http://trac.webkit.org/changeset/188815
631
632 2015-08-21  Tim Horton  <timothy_horton@apple.com>
633
634         Stop building WebKitTestRunner for 32-bit platforms
635         https://bugs.webkit.org/show_bug.cgi?id=143743
636         <rdar://problem/16947123>
637
638         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
639         This is a restriction on the valid set, not the desired set.
640
641 2015-08-21  Jason Marcell  <jmarcell@apple.com>
642
643         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
644         to work with these new objects.
645         https://bugs.webkit.org/show_bug.cgi?id=148188
646
647         Reviewed by Daniel Bates.
648
649         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
650         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
652         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
653         (repository, "branch name")-pair.
654         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
655         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
656         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
657         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
658         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
659         objects which represent a (repository, "branch name")-pair.
660         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
661         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
662         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
663         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
665         BuildbotQueue.branch to BuildbotQueue.branches.
666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
667         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
668
669 2015-08-21  Tim Horton  <timothy_horton@apple.com>
670
671         Stop building WebKitTestRunner for 32-bit platforms
672         https://bugs.webkit.org/show_bug.cgi?id=143743
673         <rdar://problem/16947123>
674
675         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
676         WKWebView is not available on 32-bit OS X.
677
678 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
679
680         [Win] Unreviewed test correction after r188709.
681
682         I removed a function argument that happened to be mirrored by a global
683         value with the same name. This prevented a compile error, but testing
684         showed that the wrong value was being used in the function.
685
686         * DumpRenderTree/win/FrameLoadDelegate.cpp:
687         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
688         back
689
690 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
691
692         WebKitTestRunner should use WKWebView on OS X and iOS
693         https://bugs.webkit.org/show_bug.cgi?id=143743
694         <rdar://problem/16947123>
695
696         Reviewed by Anders Carlsson.
697         Patch by Enrica Casucci and myself.
698
699         * WebKitTestRunner/PlatformWebView.h:
700         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
701         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
702         instead of WKContext and WKPageGroup.
703
704         Remove the unused, always-true windowSnapshotEnabled().
705         While technically some platforms don't have window snapshotting,
706         they just return null instead of implementing windowSnapshotEnabled().
707
708         * WebKitTestRunner/TestController.h:
709         * WebKitTestRunner/TestController.cpp:
710         (WTR::TestController::createOtherPage):
711         (WTR::TestController::initialize):
712         (WTR::TestController::createWebViewWithOptions):
713         Delegate to the various platforms for creating PlatformWebView instances,
714         for creating WKContexts, and for accessing WKPreferences,
715         so that they can do special things (like, use WKWebView instead!).
716
717         (WTR::TestController::resetPreferencesToConsistentValues):
718         Make explicit WebKitTestRunner's desired default for two preferences
719         which have differing defaults between the antique and modern API,
720         for consistency's sake.
721
722         (WTR::TestController::resetStateToConsistentValues):
723         Add platformResetStateToConsistentValues.
724
725         * WebKitTestRunner/TestInvocation.cpp:
726         (WTR::TestInvocation::dumpResults):
727         Adjust to the aforementioned removal of windowSnapshotEnabled().
728
729         * WebKitTestRunner/ios/TestControllerCocoa.mm:
730         (WTR::TestController::platformResetStateToConsistentValues):
731         (WTR::TestController::platformPreferences):
732         (WTR::TestController::platformCreateWebView):
733         (WTR::TestController::platformCreateOtherPage):
734         (WTR::TestController::platformInitializeConfiguration):
735         Implement the new platform functions for the Modern WebKit2 API,
736         in a new TestControllerCocoa file that is shared between iOS and Mac.
737         
738         For platformMaybeCreateContext, use the trick that we know we can cast
739         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
740         WKWebView's configuration.
741
742         Ditto for WKPreferencesRef and WKPreferences.
743
744         Remove user content filters on the WKWebView's userContentController.
745
746         * WebKitTestRunner/mac/TestControllerMac.mm:
747         * WebKitTestRunner/ios/TestControllerIOS.mm:
748         Move code into TestControllerCocoa.
749
750         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
751         (WTR::InjectedBundle::beginTesting):
752         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
753         (WTR::TestRunner::addUserScript):
754         (WTR::TestRunner::addUserStyleSheet):
755         Adopt WKBundlePage API for user scripts/sheets.
756
757         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
758         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
759         Make and keep a WKWebView instead of a WKView.
760         
761         * WebKitTestRunner/mac/EventSenderProxy.mm:
762         (WTR::EventSenderProxy::mouseUp):
763         (WTR::EventSenderProxy::mouseMoveTo):
764         Reach inside the WKWebView to the WKView when dispatching events.
765         This is fairly ugly and we should come up with a better solution.
766         Also, fix some flipping and style errors.
767
768 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
769
770         Improve how UI events are dispatched by WebKitTestRunner
771         https://bugs.webkit.org/show_bug.cgi?id=148326
772
773         Reviewed by Anders Carlsson.
774
775         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
776         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
777         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
778         asynchronous (and really, it has always been for the most part).
779
780         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
781         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
782         (WTR::EventSendingController::mouseUp): Ditto.
783         (WTR::EventSendingController::mouseMoveTo): Ditto.
784         (WTR::EventSendingController::mouseForceDown): Ditto.
785         (WTR::EventSendingController::mouseForceUp): Ditto.
786         (WTR::EventSendingController::mouseForceChanged): Ditto.
787         (WTR::EventSendingController::leapForward): Ditto.
788         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
789         (WTR::EventSendingController::keyDown): Ditto.
790         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
791         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
792         to be done in custom WebKit2 code for test wheel event handling.
793         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
794         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
795         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
796         (WTR::EventSendingController::addTouchPoint): Ditto.
797         (WTR::EventSendingController::updateTouchPoint): Ditto.
798         (WTR::EventSendingController::setTouchModifier): Ditto.
799         (WTR::EventSendingController::setTouchPointRadius): Ditto.
800         (WTR::EventSendingController::touchStart): Ditto.
801         (WTR::EventSendingController::touchMove): Ditto.
802         (WTR::EventSendingController::touchEnd): Ditto.
803         (WTR::EventSendingController::touchCancel): Ditto.
804         (WTR::EventSendingController::clearTouchPoints): Ditto.
805         (WTR::EventSendingController::releaseTouchPoint): Ditto.
806         (WTR::EventSendingController::cancelTouchPoint): Ditto.
807
808         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
809         (WTR::InjectedBundle::postSetWindowIsKey):
810         (WTR::InjectedBundle::postSimulateWebNotificationClick):
811         (WTR::InjectedBundle::isGeolocationProviderActive):
812         (WTR::InjectedBundle::shouldProcessWorkQueue):
813         Updated for WKBundlePagePostSynchronousMessage renaming.
814
815         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
816         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
817
818         * WebKitTestRunner/TestController.cpp:
819         (WTR::TestController::initialize): Allow handling the new test style messages.
820         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
821         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
822         (WTR::TestController::didReceiveMessageFromInjectedBundle):
823         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
824         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
825
826         * WebKitTestRunner/mac/EventSenderProxy.mm:
827         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
828         (WTR::EventSenderProxy::keyDown): Ditto.
829         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
830         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
831
832 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
833
834         Skip no-llint tests that fail due to running out of executable memory after r188969
835         https://bugs.webkit.org/show_bug.cgi?id=148273
836
837         Reviewed by Michael Saboff.
838
839         * Scripts/run-jsc-stress-tests:
840
841 2015-08-21  Nan Wang  <n_wang@apple.com>
842
843         [Mac] accessibility/selection-states.html fails
844         https://bugs.webkit.org/show_bug.cgi?id=116637
845
846         Reviewed by Chris Fleizach.
847
848         Implemented isSelectable() and isMultiSelectable().
849
850         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
851         (AccessibilityUIElement::isSelectable):
852         (AccessibilityUIElement::isMultiSelectable):
853         (AccessibilityUIElement::isSelectedOptionActive):
854         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
855         (WTR::AccessibilityUIElement::isSelectable):
856         (WTR::AccessibilityUIElement::isMultiSelectable):
857         (WTR::AccessibilityUIElement::isVisible):
858
859 2015-08-21  Jason Marcell  <jmarcell@apple.com>
860
861         Fix iteration over repositories on bot watcher's dashboard.
862
863         Reviewed by Alexey Proskuryakov.
864
865         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
866         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
867
868 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
869
870         [EFL] Revise PlatformWebView ctor according to r188718
871         https://bugs.webkit.org/show_bug.cgi?id=148282
872
873         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
874         instead of WKContextRef and WKPageGroupRef respectively.
875
876         Reviewed by Gyuyoung Kim.
877
878         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
879         (WTR::PlatformWebView::PlatformWebView):
880
881 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
882
883         Unreviewed, changed Devin Rousso's email.
884
885         * Scripts/webkitpy/common/config/contributors.json:
886
887 2015-08-20  Anders Carlsson  <andersca@apple.com>
888
889         Use WKPageConfigurationRef in WebKitTestRunner
890         https://bugs.webkit.org/show_bug.cgi?id=147996
891
892         Reviewed by Tim Horton.
893
894         * WebKitTestRunner/TestController.cpp:
895         (WTR::TestController::createOtherPage):
896         (WTR::TestController::initialize):
897         (WTR::TestController::createWebViewWithOptions):
898         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
899         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
900         (WTR::PlatformWebView::PlatformWebView):
901         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
902
903 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
904
905         [Win] Update Windows tools for revised MIDL interfaces
906         https://bugs.webkit.org/show_bug.cgi?id=148249
907
908         Reviewed by Dean Jackson.
909
910         This is a follow-up to Bug 148001.
911
912         Revise the testing software to use compatible signatures and
913         implementations to match the requirements of the IDL generated
914         with the SAL annotations.
915
916         * DumpRenderTree/win/DRTDataObject.cpp:
917         * DumpRenderTree/win/DRTDataObject.h:
918         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
919         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
920         * DumpRenderTree/win/DRTDropSource.cpp:
921         * DumpRenderTree/win/DRTDropSource.h:
922         * DumpRenderTree/win/DumpRenderTree.cpp:
923         * DumpRenderTree/win/EditingDelegate.cpp:
924         * DumpRenderTree/win/EditingDelegate.h:
925         * DumpRenderTree/win/FrameLoadDelegate.cpp:
926         * DumpRenderTree/win/FrameLoadDelegate.h:
927         * DumpRenderTree/win/HistoryDelegate.cpp:
928         * DumpRenderTree/win/HistoryDelegate.h:
929         * DumpRenderTree/win/PolicyDelegate.cpp:
930         * DumpRenderTree/win/PolicyDelegate.h:
931         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
932         * DumpRenderTree/win/ResourceLoadDelegate.h:
933         * DumpRenderTree/win/TestRunnerWin.cpp:
934         * DumpRenderTree/win/UIDelegate.cpp:
935         * DumpRenderTree/win/UIDelegate.h:
936         * WinLauncher/AccessibilityDelegate.cpp:
937         * WinLauncher/AccessibilityDelegate.h:
938         * WinLauncher/Common.cpp:
939         * WinLauncher/DOMDefaultImpl.cpp:
940         * WinLauncher/DOMDefaultImpl.h:
941         * WinLauncher/PageLoadTestClient.cpp:
942         * WinLauncher/PageLoadTestClient.h:
943         * WinLauncher/PrintWebUIDelegate.cpp:
944         * WinLauncher/PrintWebUIDelegate.h:
945         * WinLauncher/ResourceLoadDelegate.cpp:
946         * WinLauncher/ResourceLoadDelegate.h:
947         * WinLauncher/WebDownloadDelegate.cpp:
948         * WinLauncher/WebDownloadDelegate.h:
949         * WinLauncher/WinLauncherWebHost.cpp:
950         * WinLauncher/WinLauncherWebHost.h:
951         * WinLauncher/WinMain.cpp:
952         * win/DLLLauncher/DLLLauncherMain.cpp:
953
954 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
955
956         Unreviewed, shorten a test that runs too long and times out.
957
958         * TestWebKitAPI/Tests/WTF/Lock.cpp:
959         (TestWebKitAPI::TEST):
960
961 2015-08-20  Alex Christensen  <achristensen@webkit.org>
962
963         Clean up CMake build after r188673
964         https://bugs.webkit.org/show_bug.cgi?id=148234
965
966         Reviewed by Tim Horton.
967
968         * DumpRenderTree/PlatformWin.cmake:
969         * TestWebKitAPI/CMakeLists.txt:
970         * TestWebKitAPI/PlatformWin.cmake:
971         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
972         gtest needs to be a static library on Windows to not crash.
973
974 2015-08-19  Alex Christensen  <achristensen@webkit.org>
975
976         CMake Windows build should not include files directly from other Source directories
977         https://bugs.webkit.org/show_bug.cgi?id=148198
978
979         Reviewed by Brent Fulgham.
980
981         * DumpRenderTree/DumpRenderTreePrefix.h:
982         Include cmakeconfig.h to properly define all enabled features.
983         * DumpRenderTree/PlatformWin.cmake:
984         * TestWebKitAPI/PlatformWin.cmake:
985
986 2015-08-19  Alex Christensen  <achristensen@webkit.org>
987
988         Build TestWTF on Mac with CMake.
989         https://bugs.webkit.org/show_bug.cgi?id=147972
990
991         Reviewed by Tim Horton.
992
993         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
994         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
995
996         * TestWebKitAPI/CMakeLists.txt:
997         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
998         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
999         * TestWebKitAPI/PlatformMac.cmake: Added.
1000         * TestWebKitAPI/config.h:
1001         Postpone some build fixes until WebKit builds completely on Mac with CMake.
1002
1003 2015-08-19  Brian Burg  <bburg@apple.com>
1004
1005         Unreviewed, add Aleksandr Skachkov to the list of contributors.
1006
1007         * Scripts/webkitpy/common/config/contributors.json:
1008
1009 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1010
1011         REGRESSION(r188548): [GTK] Build broken.
1012         https://bugs.webkit.org/show_bug.cgi?id=148154
1013
1014         Reviewed by Martin Robinson.
1015
1016         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1017         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1018         Even if we don't need to add/override any settings in ViewOptions,
1019         we need to define this as an empty function to make it build.
1020
1021 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1022
1023         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
1024         https://bugs.webkit.org/show_bug.cgi?id=148073
1025
1026         Reviewed by Alexey Proskuryakov.
1027
1028         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
1029         (TestWebKitAPI::TEST):
1030
1031 2015-08-18  Anders Carlsson  <andersca@apple.com>
1032
1033         Fix test failure fallout from r188602 by using a V5 page ui client struct.
1034
1035         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1036         (TestWebKitAPI::setUpClients):
1037
1038 2015-08-18  Brian Burg  <bburg@apple.com>
1039
1040         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1041         https://bugs.webkit.org/show_bug.cgi?id=147955
1042
1043         Reviewed by Timothy Hatcher.
1044
1045         To enable sharing of common test code between protocol and model tests,
1046         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1047
1048         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1049         protocol-test.js uses to load the inspector frontend stub into its iframe
1050         from an arbitrary local file URL.
1051
1052         * DumpRenderTree/TestRunner.cpp:
1053         (getInspectorTestStubURLCallback):
1054         (TestRunner::staticValues):
1055         * DumpRenderTree/TestRunner.h:
1056         * DumpRenderTree/mac/TestRunnerMac.mm:
1057         (SOFT_LINK_STAGED_FRAMEWORK):
1058         (TestRunner::inspectorTestStubURL):
1059         * DumpRenderTree/win/TestRunnerWin.cpp:
1060         (TestRunner::inspectorTestStubURL):
1061         * WebKitTestRunner/Configurations/Base.xcconfig:
1062         Since WebKitTestRunner now includes WebCore private headers, also search
1063         for the WebCore framework inside the WebKit umbrella framework.
1064
1065         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1066         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1067         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1068         (WTR::TestRunner::inspectorTestStubURL):
1069         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1070         (WTR::TestRunner::inspectorTestStubURL):
1071         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1072         (WTR::TestRunner::inspectorTestStubURL):
1073
1074 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
1075
1076         Unreviewed, fix GTK build.
1077
1078         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1079         (TestWebKitAPI::TEST):
1080
1081 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
1082
1083         Replace all remaining uses of WTF::Mutex with WTF::Lock
1084         https://bugs.webkit.org/show_bug.cgi?id=148089
1085
1086         Reviewed by Geoffrey Garen.
1087
1088         * DumpRenderTree/JavaScriptThreading.cpp:
1089         (javaScriptThreadsMutex):
1090         (runJavaScriptThread):
1091         (startJavaScriptThreads):
1092         (stopJavaScriptThreads):
1093         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
1094         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1095         (TestWebKitAPI::TEST):
1096         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1097         (TestWebKitAPI::TEST):
1098
1099 2015-08-17  Commit Queue  <commit-queue@webkit.org>
1100
1101         Unreviewed, rolling out r188539, r188544, r188552, and
1102         r188564.
1103         https://bugs.webkit.org/show_bug.cgi?id=148122
1104
1105         Broke tests and some build styles (Requested by ap on
1106         #webkit).
1107
1108         Reverted changesets:
1109
1110         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
1111         bundle"
1112         https://bugs.webkit.org/show_bug.cgi?id=147955
1113         http://trac.webkit.org/changeset/188539
1114
1115         "Web Inspector: split TestStub.js into multiple files and
1116         modernize it"
1117         https://bugs.webkit.org/show_bug.cgi?id=148077
1118         http://trac.webkit.org/changeset/188544
1119
1120         "Web Inspector: InspectorTest should be a subclass of
1121         TestHarness"
1122         https://bugs.webkit.org/show_bug.cgi?id=148079
1123         http://trac.webkit.org/changeset/188552
1124
1125         "Unreviewed internal build fix attempt after r188539."
1126         http://trac.webkit.org/changeset/188564
1127
1128 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1129
1130         [OS X] Remove support for composite fonts
1131         https://bugs.webkit.org/show_bug.cgi?id=147920
1132
1133         Reviewed by Dan Bernstein.
1134
1135         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1136         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
1137         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1138         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1139         * DumpRenderTree/mac/DumpRenderTree.mm:
1140         (allowedFontFamilySet): Deleted.
1141         (activateTestingFonts): Deleted.
1142         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1143         (WTR::allowedFontFamilySet): Deleted.
1144         (WTR::activateFonts): Deleted.
1145         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1146         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
1147         * WebKitTestRunner/mac/TestControllerMac.mm:
1148         (WTR::allowedFontFamilySet): Deleted.
1149
1150 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
1151
1152         Unreviewed internal build fix attempt after r188539.
1153
1154         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1155
1156 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1157
1158         Fix the build
1159
1160         Unreviewed.
1161
1162         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1163
1164 2015-08-17  Alex Christensen  <achristensen@webkit.org>
1165
1166         Build Debug Suffix on Windows with CMake
1167         https://bugs.webkit.org/show_bug.cgi?id=148083
1168
1169         Reviewed by Brent Fulgham.
1170
1171         * TestWebKitAPI/CMakeLists.txt:
1172         * TestWebKitAPI/PlatformWin.cmake:
1173         Add DEBUG_SUFFIX
1174
1175 2015-08-17  Anders Carlsson  <andersca@apple.com>
1176
1177         Simplify how PlatformWebViews are created when view options change
1178         https://bugs.webkit.org/show_bug.cgi?id=148093
1179
1180         Reviewed by Sam Weinig.
1181
1182         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
1183
1184         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
1185         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
1186         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
1187
1188         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
1189
1190         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
1191         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
1192
1193         * WebKitTestRunner/TestController.cpp:
1194         (WTR::TestController::ensureViewSupportsOptionsForTest):
1195         (WTR::shouldUseFixedLayout):
1196         (WTR::TestController::viewOptionsForTest):
1197         (WTR::TestController::updateWebViewSizeForTest):
1198         (WTR::TestController::updateWindowScaleForTest):
1199         (WTR::TestController::configureViewForTest):
1200         (WTR::TestController::initialize): Deleted.
1201         (WTR::TestController::ensureViewSupportsOptions): Deleted.
1202         (WTR::TestController::updateLayoutTypeForTest): Deleted.
1203         (WTR::TestController::platformConfigureViewForTest): Deleted.
1204         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
1205         (WTR::TestController::run): Deleted.
1206         * WebKitTestRunner/TestController.h:
1207         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1208         (WTR::shouldUseFixedLayout):
1209         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1210         (WTR::TestController::platformConfigureViewForTest):
1211         (WTR::TestController::platformResetPreferencesToConsistentValues):
1212         * WebKitTestRunner/ios/TestControllerIOS.mm:
1213         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1214         * WebKitTestRunner/mac/TestControllerMac.mm:
1215         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1216         (WTR::TestController::platformConfigureViewForTest):
1217
1218 2015-08-17  Sam Weinig  <sam@webkit.org>
1219
1220         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
1221         https://bugs.webkit.org/show_bug.cgi?id=148097
1222
1223         Reviewed by Anders Carlsson.
1224
1225         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
1226         Add tests for WebsiteDataStores in the WKPageConfiguration.
1227
1228 2015-08-17  Brian Burg  <bburg@apple.com>
1229
1230         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1231         https://bugs.webkit.org/show_bug.cgi?id=147955
1232
1233         Reviewed by Timothy Hatcher.
1234
1235         To enable sharing of common test code between protocol and model tests,
1236         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1237
1238         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1239         protocol-test.js uses to load the inspector frontend stub into its iframe
1240         from an arbitrary local file URL.
1241
1242         * DumpRenderTree/TestRunner.cpp:
1243         (getInspectorTestStubURLCallback):
1244         (TestRunner::staticValues):
1245         * DumpRenderTree/TestRunner.h:
1246         * DumpRenderTree/mac/TestRunnerMac.mm:
1247         (SOFT_LINK_STAGED_FRAMEWORK):
1248         (TestRunner::inspectorTestStubURL):
1249         * DumpRenderTree/win/TestRunnerWin.cpp:
1250         (TestRunner::inspectorTestStubURL):
1251         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1252         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1253         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1254         (WTR::TestRunner::inspectorTestStubURL):
1255         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1256         (WTR::TestRunner::inspectorTestStubURL):
1257         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1258         (WTR::TestRunner::inspectorTestStubURL):
1259
1260 2015-08-17  Saam barati  <sbarati@apple.com>
1261
1262         Change email address from saambarati1@gmail.com to sbarati@apple.com
1263
1264         * Scripts/webkitpy/common/config/contributors.json:
1265
1266 2015-08-17  Jason Marcell  <jmarcell@apple.com>
1267
1268         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
1269         repositories other than "openSource" and "internal".
1270         https://bugs.webkit.org/show_bug.cgi?id=147961
1271
1272         Reviewed by Daniel Bates.
1273
1274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1275         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
1276         generically with repositories other than "openSource" and "internal".
1277
1278 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
1279
1280         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
1281         https://bugs.webkit.org/show_bug.cgi?id=148081
1282
1283         Reviewed by Tim Horton.
1284
1285         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1286         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1287
1288 2015-08-11  Andy Estes  <aestes@apple.com>
1289
1290         [Cocoa] Add redirect support to CustomProtocolManager
1291         https://bugs.webkit.org/show_bug.cgi?id=147871
1292
1293         Reviewed by Dan Bernstein.
1294
1295         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
1296
1297         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1298         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
1299         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
1300         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1301         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
1302         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
1303         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
1304         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
1305         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
1306         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1307         (TestWebKitAPI::TEST): Unregistered TestProtocol.
1308         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
1309         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
1310         (-[TestProtocol startLoading]): Taught to handle redirect responses.
1311
1312 2015-08-13  Andy Estes  <aestes@apple.com>
1313
1314         [Cocoa] Downloads do not start if policy decision is made asynchronously
1315         https://bugs.webkit.org/show_bug.cgi?id=147985
1316
1317         Reviewed by Brady Eidson.
1318
1319         Added a new API test.
1320
1321         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1322         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1323         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
1324         (TEST):
1325
1326 2015-08-14  Commit Queue  <commit-queue@webkit.org>
1327
1328         Unreviewed, rolling out r187357.
1329         https://bugs.webkit.org/show_bug.cgi?id=148032
1330
1331         webkit-patch generates incorrect patches that cannot be
1332         applied (Requested by dydz on #webkit).
1333
1334         Reverted changeset:
1335
1336         "Call fixChangeLogPatch when generating patches from webkit-
1337         patch"
1338         https://bugs.webkit.org/show_bug.cgi?id=147248
1339         http://trac.webkit.org/changeset/187357
1340
1341 2015-08-14  Jason Marcell  <jmarcell@apple.com>
1342
1343         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
1344         other than "openSource" and "internal".
1345         https://bugs.webkit.org/show_bug.cgi?id=147938
1346
1347         Reviewed by Daniel Bates.
1348
1349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1350         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
1351         repositories other than "openSource" and "internal".
1352
1353 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
1354
1355         Unreviewed, shorten another test that is timing out.
1356
1357         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1358         (TestWebKitAPI::TEST):
1359
1360 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
1361
1362         AppScale: Assertion hit when hovering a webkit-queue bubble
1363         https://bugs.webkit.org/show_bug.cgi?id=147997
1364
1365         Reviewed by Alexey Proskuryakov.
1366
1367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1368         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
1369
1370 2015-08-13  Lucas Forschler  <lforschler@apple.com>
1371
1372         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
1373         
1374         Unreviewed.
1375         
1376         * Scripts/copy-webkitlibraries-to-product-directory:
1377
1378 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
1379
1380         Run benchmark customized Dromaeo should not assume there is an internet connection.
1381         https://bugs.webkit.org/show_bug.cgi?id=147995
1382
1383         Reviewed by Ryosuke Niwa.
1384
1385         Add several dependency js libs to local.
1386
1387         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1388
1389 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1390
1391         WTF should have a compact Condition object to use with Lock
1392         https://bugs.webkit.org/show_bug.cgi?id=147986
1393
1394         Reviewed by Geoffrey Garen.
1395
1396         Add a test for WTF::Condition.
1397
1398         * TestWebKitAPI/CMakeLists.txt:
1399         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1401         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
1402         (TestWebKitAPI::TEST):
1403         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1404         (TestWebKitAPI::runLockTest): Change the name of the thread.
1405
1406 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1407
1408         Unreviewed, shorten another test. It's timing out in debug on some bot.
1409
1410         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1411         (TestWebKitAPI::TEST):
1412
1413 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
1414
1415         WTF::Lock should not suffer from the thundering herd
1416         https://bugs.webkit.org/show_bug.cgi?id=147947
1417
1418         Reviewed by Geoffrey Garen.
1419
1420         Add testing that checks that locks return to a pristine state after contention is over.
1421
1422         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1423         (TestWebKitAPI::LockInspector::isFullyReset):
1424         (TestWebKitAPI::runLockTest):
1425         (TestWebKitAPI::TEST):
1426
1427 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
1428
1429         Benchmarks supported by run_benchmark script should not assume we have internet access.
1430         https://bugs.webkit.org/show_bug.cgi?id=147959
1431
1432         Reviewed by Ryosuke Niwa.
1433
1434         For JSBench we should not request jquery.min.js from google through the internet.
1435
1436         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1437
1438 2015-08-12  Jason Marcell  <jmarcell@apple.com>
1439
1440         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
1441         other than "openSource" and "internal".
1442         https://bugs.webkit.org/show_bug.cgi?id=147796
1443
1444         Reviewed by Daniel Bates.
1445
1446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1447         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
1448         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
1449         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
1450         and another assertion that, if the previousIteration is non-null, the given repository is in
1451         previousIteration.revision.
1452         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
1453         with repositories other than "openSource" and "internal". Also added an assertion that the returned
1454         fragment has at least one child node.
1455
1456 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
1457
1458         Add a tool that dumps class and struct member layout, showing padding
1459         https://bugs.webkit.org/show_bug.cgi?id=147898
1460
1461         Reviewed by Zalan Bujtas.
1462         
1463         This 'dump-class-layout' script uses the lldb Python bindings to collect data
1464         about data member layout, and displays it.
1465         
1466         Sample output:
1467
1468               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
1469               +0 < 56>     WebCore::URL m_value;
1470               +0 <  8>         WTF::String m_string;
1471               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
1472               +0 <  8>                 WTF::StringImpl * m_ptr;
1473               +8 <  1>         bool:1 m_isValid;
1474               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
1475               +9 <  3>         <PADDING>
1476              +12 <  4>         int m_schemeEnd;
1477              +16 <  4>         int m_userStart;
1478              +20 <  4>         int m_userEnd;
1479              +24 <  4>         int m_passwordEnd;
1480              +28 <  4>         int m_hostEnd;
1481              +32 <  4>         int m_portEnd;
1482              +36 <  4>         int m_pathAfterLastSlash;
1483              +40 <  4>         int m_pathEnd;
1484              +44 <  4>         int m_queryEnd;
1485              +48 <  4>         int m_fragmentEnd;
1486              +52 <  4>         <PADDING>
1487              +52 <  4>     <PADDING>
1488              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
1489              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
1490             Total byte size: 72
1491             Total pad bytes: 11
1492             Padding percentage: 15.28 %
1493
1494         * Scripts/dump-class-layout: Added.
1495         (webkit_build_dir):
1496         (developer_dir):
1497         (import_lldb):
1498         (find_build_directory):
1499         (verify_type):
1500         (verify_type_recursive):
1501         (dump_class):
1502         (main):
1503         (main.or):
1504
1505 2015-08-12  Alex Christensen  <achristensen@webkit.org>
1506
1507         Fix Debug CMake builds on Windows
1508         https://bugs.webkit.org/show_bug.cgi?id=147940
1509
1510         Reviewed by Chris Dumez.
1511
1512         * DumpRenderTree/PlatformWin.cmake:
1513         * TestWebKitAPI/PlatformWin.cmake:
1514         The BitmapImage test is not enabled on the AppleWin port.
1515         * WinLauncher/CMakeLists.txt:
1516         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
1517
1518 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1519
1520         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
1521
1522         In r188125 I added a way to mark tests as slow to use a longer
1523         timeout. But it seems it was not enough for
1524         WTF_Lock.ContendedShortSection, so let's try again with a longer
1525         timeout now.
1526
1527         * Scripts/run-gtk-tests:
1528         (TestRunner._run_google_test):
1529
1530 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1531
1532         Allow --debug option in run-jsc
1533         https://bugs.webkit.org/show_bug.cgi?id=147923
1534
1535         Reviewed by Csaba Osztrogonác.
1536
1537         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
1538
1539         * Scripts/run-jsc:
1540
1541 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1542
1543         Fix test after build fix in r188286.
1544         https://bugs.webkit.org/show_bug.cgi?id=147907
1545
1546         Reviewed by Anders Carlsson.
1547
1548         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1549         sleep_for can now be used, but we need to include <thread>
1550
1551 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1552
1553         Always use a byte-sized lock implementation
1554         https://bugs.webkit.org/show_bug.cgi?id=147908
1555
1556         Reviewed by Geoffrey Garen.
1557
1558         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
1559         now tests of Lock.
1560
1561         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1562         (TestWebKitAPI::runLockTest):
1563         (TestWebKitAPI::TEST):
1564
1565 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
1566
1567         Make ASan build not depend on asan.xcconfig
1568         https://bugs.webkit.org/show_bug.cgi?id=147840
1569         rdar://problem/21093702
1570
1571         Reviewed by Daniel Bates.
1572
1573         * asan/asan.xcconfig:
1574         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
1575         are now marked in source code.
1576
1577 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1578
1579         Unreviewed, shorten another test since it timed out.
1580
1581         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1582         (TestWebKitAPI::TEST):
1583
1584 2015-08-11  Mark Lam  <mark.lam@apple.com>
1585
1586         Fix names of Lock tests: should be "Contended", not "Contented".
1587         https://bugs.webkit.org/show_bug.cgi?id=147905
1588
1589         Reviewed by Saam Barati.
1590
1591         We're testing the behavior of lock contention (i.e. when threads contend), not
1592         whether the locks are happy (contented).
1593
1594         * Scripts/run-gtk-tests:
1595         (TestRunner):
1596         (TestRunner.__init__): Deleted.
1597         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1598         (TestWebKitAPI::runLockTest):
1599         (TestWebKitAPI::TEST):
1600
1601 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1602
1603         Update WinCairoRequirements to VS2015.
1604
1605         * Scripts/update-webkit-wincairo-libs:
1606         Update WinCairoRequirements location.
1607
1608 2015-08-11  Jason Marcell  <jmarcell@apple.com>
1609
1610         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
1611         for internalTrac.
1612         https://bugs.webkit.org/show_bug.cgi?id=147805
1613
1614         Reviewed by Daniel Bates.
1615
1616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1617         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
1618         Dashboard.Repository.Internal.trac for internalTrac.
1619         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
1620         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
1621         respectively.
1622         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1623         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
1624         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
1625         internalTrac.
1626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
1627         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
1628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1629         (Analyzer): Ditto.
1630         (Analyzer.prototype.analyze): Ditto.
1631
1632 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1633
1634         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
1635
1636         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1637         (TestWebKitAPI::TEST):
1638
1639 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
1640
1641         [Win] Switch Windows build to Visual Studio 2015
1642         https://bugs.webkit.org/show_bug.cgi?id=147887
1643         <rdar://problem/22235098>
1644
1645         Reviewed by Alex Christensen.
1646
1647         Update Visual Studio project file settings to use the current Visual
1648         Studio and compiler. Continue targeting binaries to run on our minimum
1649         supported configuration of Windows 7.
1650
1651         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1652         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1653         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1654         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1655         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1656         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
1657         prefer the newer MSBuild included in Visual Studio 2015.
1658         (visualStudioInstallDir):
1659         (msBuildInstallDir):
1660         (visualStudioVersion):
1661         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1662         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1663         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1664         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1665         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1666         * win/record-memory/record-memory.vcxproj:
1667
1668 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1669
1670         Another speculative build fix after r188280.
1671
1672         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1673         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
1674         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
1675
1676 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1677
1678         Unreviewed build fix after r188280.
1679
1680         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1681         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
1682
1683 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
1684
1685         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
1686         https://bugs.webkit.org/show_bug.cgi?id=147665
1687
1688         Reviewed by Mark Lam.
1689
1690         * TestWebKitAPI/CMakeLists.txt:
1691         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1693         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1694         (TestWebKitAPI::TEST):
1695         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
1696         (TestWebKitAPI::TEST):
1697
1698 2015-08-11  Brian Burg  <bburg@apple.com>
1699
1700         webkit-patch should not explode when $EDITOR is set incorrectly
1701         https://bugs.webkit.org/show_bug.cgi?id=147884
1702
1703         Reviewed by Darin Adler.
1704
1705         If $EDITOR doesn't exist, log a warning and continue.
1706
1707         * Scripts/webkitpy/common/system/user.py: 
1708         (User.edit):
1709         (User.edit_changelog):
1710
1711 2015-08-11  Dan Bernstein  <mitz@apple.com>
1712
1713         Reverted r188255, because it turned out that delegates do nonot need this information.
1714
1715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1716         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
1717
1718 2015-08-11  Dan Bernstein  <mitz@apple.com>
1719
1720         [Cocoa] The UI delegate can't tell if printing was user-initiated
1721         https://bugs.webkit.org/show_bug.cgi?id=147869
1722
1723         Reviewed by Sam Weinig.
1724
1725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1726         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
1727         (-[PrintFrameController webView:didFinishNavigation:]):
1728         (-[PrintFrameController _webView:printFrame:userInitiated:]):
1729         (TEST):
1730
1731 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1732
1733         Another build fix after r188239.
1734
1735         * TestWebKitAPI/PlatformWin.cmake:
1736         Link with more libraries.
1737         * WinLauncher/CMakeLists.txt:
1738         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
1739
1740 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1741
1742         Build fix after r188237.
1743
1744         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1745         (BenchmarkBuilder.__enter__):
1746
1747 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1748
1749         Update ReadMe and correct the way to use abstract abstract class.
1750         https://bugs.webkit.org/show_bug.cgi?id=147860
1751
1752         Reviewed by Ryosuke Niwa.
1753
1754         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
1755         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
1756
1757         * Scripts/webkitpy/benchmark_runner/README.md:
1758         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1759         (BrowserDriver):
1760         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1761         (OSXBrowserDriver.restore_env):
1762         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1763         (HTTPServerDriver):
1764         (HTTPServerDriver.set_device_id):
1765         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1766         (SimpleHTTPServerDriver.get_return_code):
1767         (SimpleHTTPServerDriver):
1768         (SimpleHTTPServerDriver.set_device_id):
1769
1770 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1771
1772         Build TestWebKitAPI with CMake on Windows
1773         https://bugs.webkit.org/show_bug.cgi?id=147851
1774
1775         Reviewed by Chris Dumez.
1776
1777         * CMakeLists.txt:
1778         * TestWebKitAPI/CMakeLists.txt:
1779         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
1780         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
1781         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
1782         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
1783         * TestWebKitAPI/PlatformEfl.cmake:
1784         * TestWebKitAPI/PlatformGTK.cmake:
1785         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
1786         I did this without changing the directory structure of the existing EFL and GTK builds.
1787         * TestWebKitAPI/PlatformWin.cmake: Added.
1788         * TestWebKitAPI/win/main.cpp:
1789         (main):
1790         (dllLauncherEntryPoint):
1791         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
1792         * WinLauncher/CMakeLists.txt:
1793         AppleWin port needs /NODEFAULTLIB:MSVCRT.
1794
1795 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1796
1797         Make cleanup more robust and minor code cleaning in run benchmark script.
1798         https://bugs.webkit.org/show_bug.cgi?id=147800
1799
1800         Reviewed by Ryosuke Niwa.
1801
1802         Use 'finnaly' block to make sure cleanup code is always executed.
1803
1804         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1805         (built_benchmark):
1806         (built_benchmark.__init__):
1807         (built_benchmark.__enter__):
1808         (built_benchmark.__exit__):
1809         (test_environment):
1810         (test_environment.__init__):
1811         (test_environment.__enter__):
1812         (test_environment.__exit__):
1813         (BenchmarkRunner.__init__):
1814         (BenchmarkRunner.execute):
1815         (BenchmarkRunner._dump):
1816         (BenchmarkRunner._wrap):
1817         (BenchmarkRunner): Deleted.
1818         (BenchmarkRunner._cleanup): Deleted.
1819         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1820         (BrowserDriver.close_browsers):
1821         (BrowserDriver):
1822         (BrowserDriver.restore_env):
1823         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1824         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
1825
1826 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1827
1828         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
1829         https://bugs.webkit.org/show_bug.cgi?id=146414
1830
1831         Reviewed by Darin Adler.
1832
1833         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1834         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
1835
1836 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1837
1838         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
1839         https://bugs.webkit.org/show_bug.cgi?id=147727
1840
1841         Reviewed by Sergio Villar Senin.
1842
1843         I think it was not this test in particular, but
1844         /webkit2/WebKitWebView/custom-charset that is affecting the
1845         others. This is because changing the encoding reloads the page,
1846         but we don't wait for the page to be reloaded, so when the test
1847         finishes and other test starts the web process is still reloading
1848         the page.
1849
1850         * Scripts/run-gtk-tests:
1851         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
1852         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1853         (testWebViewCustomCharset): Wait until page is reloaded after
1854         changing the charset.
1855
1856 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1857
1858         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
1859
1860         It's timing out in the bots. My guess is that there's no installer
1861         installed in the bots and gst_install_plugins_supported() returns
1862         false, so we don't even get a permission request because no
1863         installer will be launched.
1864
1865         * Scripts/run-gtk-tests:
1866         (TestRunner):
1867
1868 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1869
1870         [GTK] Another build fix after r188157.
1871
1872         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1873         (WTR::PlatformWebView::viewSupportsOptions):
1874         Name all the things correctly!
1875
1876 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1877
1878         [EFL, GTK] Build fix after r188176.
1879
1880         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1881         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
1882
1883 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1884
1885         [GTK] Speculative build fix after r188157.
1886
1887         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1888         (WTR::PlatformWebView::PlatformWebView):
1889         Update parameter list.
1890
1891 2015-08-07  Alex Christensen  <achristensen@webkit.org>
1892
1893         Build more testing binaries with CMake on Windows
1894         https://bugs.webkit.org/show_bug.cgi?id=147799
1895
1896         Reviewed by Brent Fulgham.
1897
1898         * DumpRenderTree/CMakeLists.txt:
1899         Build TestNetscapePlugin.
1900         * DumpRenderTree/PlatformWin.cmake:
1901         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
1902         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
1903         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
1904         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
1905         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
1906         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
1907         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
1908         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1909         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
1910
1911 2015-08-07  Jason Marcell  <jmarcell@apple.com>
1912
1913         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
1914         https://bugs.webkit.org/show_bug.cgi?id=147667
1915
1916         Reviewed by Daniel Bates.
1917
1918         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1919         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
1920         other than "openSource" and "internal".
1921         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
1922         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1923         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
1924         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
1925         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1926         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
1927         (sortedPlatforms): Deleted.
1928         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1929         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
1930         (sortedPlatforms): Deleted.
1931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1932         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
1933         and sorts them by this property returning the new sorted array.
1934
1935 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
1936
1937         Lightweight locks should be adaptive
1938         https://bugs.webkit.org/show_bug.cgi?id=147545
1939
1940         Reviewed by Geoffrey Garen.
1941
1942         * TestWebKitAPI/CMakeLists.txt:
1943         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1944         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1945         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
1946         (TestWebKitAPI::runLockTest):
1947         (TestWebKitAPI::TEST):
1948
1949 2015-08-07  Anders Carlsson  <andersca@apple.com>
1950
1951         Fix a tyop.
1952
1953         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1954         (WTR::PlatformWebView::viewSupportsOptions):
1955
1956 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
1957
1958         Update AppEngine app version numbers to the latest commit.
1959
1960         * QueueStatusServer/app.yaml:
1961         * TestResultServer/app.yaml:
1962
1963 2015-08-07  Anders Carlsson  <andersca@apple.com>
1964
1965         Simplify WKTR's view options
1966         https://bugs.webkit.org/show_bug.cgi?id=147791
1967
1968         Reviewed by Sam Weinig.
1969
1970         Instead of using a WKDictionaryRef, just use a struct for the options.
1971
1972         * WebKitTestRunner/PlatformWebView.h:
1973         (WTR::PlatformWebView::options):
1974         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1975         * WebKitTestRunner/TestController.cpp:
1976         (WTR::TestController::initialize):
1977         (WTR::TestController::createWebViewWithOptions):
1978         (WTR::TestController::ensureViewSupportsOptions):
1979         (WTR::TestController::updateLayoutTypeForTest):
1980         * WebKitTestRunner/TestController.h:
1981         * WebKitTestRunner/ViewOptions.h: Added.
1982         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1983         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1984         (WTR::PlatformWebView::PlatformWebView):
1985         (WTR::PlatformWebView::viewSupportsOptions):
1986         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1987         (WTR::PlatformWebView::viewSupportsOptions):
1988         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1989         (WTR::PlatformWebView::viewSupportsOptions):
1990         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1991         (WTR::PlatformWebView::PlatformWebView):
1992         (WTR::PlatformWebView::viewSupportsOptions):
1993         * WebKitTestRunner/mac/TestControllerMac.mm:
1994         (WTR::TestController::platformConfigureViewForTest):
1995
1996 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
1997
1998         Running tests for a long time results in some tests running very slowly (throttling)
1999         https://bugs.webkit.org/show_bug.cgi?id=147718
2000
2001         Reviewed by Chris Dumez.
2002
2003         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
2004         Although COCOA ports default this setting to be disabled in WebKit1,
2005         we should make both test harnesses disable the setting for consistency.
2006
2007         * DumpRenderTree/mac/DumpRenderTree.mm:
2008         (resetWebPreferencesToConsistentValues):
2009
2010 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2011
2012         Use a specific version of Speedometer in run-benchmark
2013         https://bugs.webkit.org/show_bug.cgi?id=147769
2014
2015         Reviewed by Chris Dumez.
2016
2017         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
2018
2019         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2020
2021 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2022
2023         twisted_http_server.py should support --port
2024         https://bugs.webkit.org/show_bug.cgi?id=147771
2025
2026         Reviewed by Chris Dumez.
2027
2028         Added the option. This makes the script more useful on its own.
2029
2030         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2031
2032 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2033
2034         [GTK] WTF unit tests are timing out in the bots
2035         https://bugs.webkit.org/show_bug.cgi?id=147777
2036
2037         Reviewed by Filip Pizlo.
2038
2039         Add a way to mark google unit tests as slow and add
2040         WTF_Lock.ContentedShortSection to the list. In case of slow test
2041         we use the double of the given timeout for that particular test.
2042
2043         * Scripts/run-gtk-tests:
2044         (TestRunner):
2045         (TestRunner._run_google_test):
2046
2047 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2048
2049         [GTK] run-gtk-tests should not stop when a google test case fails
2050         https://bugs.webkit.org/show_bug.cgi?id=147778
2051
2052         Reviewed by Philippe Normand.
2053
2054         For glib based tests we run the test runner with the -k option,
2055         but for google tests we are aborting as soon as we find a failure.
2056
2057         * Scripts/run-gtk-tests:
2058         (TestRunner._run_google_test_suite): Use a global return code that
2059         is set to 1 when any test has failed.
2060
2061 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2062
2063         [GStreamer] Do not automatically show PackageKit codec installation notifications
2064         https://bugs.webkit.org/show_bug.cgi?id=135973
2065
2066         Reviewed by Philippe Normand.
2067
2068         Handle the missing media plugins installation permission request
2069         in MiniBrowser and add a test case for the new API.
2070
2071         * MiniBrowser/gtk/BrowserWindow.c:
2072         (webViewDecidePermissionRequest):
2073         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2074         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2075         (permissionRequestCallback):
2076         (testInstallMissingPluginsPermissionRequest):
2077         (beforeAll):
2078         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2079         (methodCallCallback):
2080
2081 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
2082
2083         Running tests for a long time results in some tests running very slowly (throttling)
2084         https://bugs.webkit.org/show_bug.cgi?id=147718
2085
2086         Reviewed by Alexey Proskuryakov.
2087
2088         * WebKitTestRunner/TestController.cpp:
2089         (WTR::TestController::resetPreferencesToConsistentValues):
2090         Ensure throttling settings are disabled for tests for all ports, as
2091         COCOA ports default to having these setting enabled. Note, there is
2092         still other timer throttling not covered by these setting.
2093
2094 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2095
2096         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
2097         https://bugs.webkit.org/show_bug.cgi?id=147752
2098
2099         Reviewed by Chris Dumez.
2100
2101         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
2102
2103         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
2104         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
2105
2106         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
2107         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
2108         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
2109         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
2110         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
2111         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2112         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
2113         HTTPServerDriverFactory taking the platform name as an argument.
2114         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
2115         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
2116         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
2117         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2118         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
2119         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
2120         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
2121         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2122         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
2123         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
2124         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2125         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
2126         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2127         (HTTPServerDriver): Replaced name by platforms.
2128         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2129         (SimpleHTTPServerDriver): Ditto.
2130         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2131         (parse_args): Removed --http-server-driver option.
2132         (start): Ditto.
2133
2134 2015-08-06  Chris Dumez  <cdumez@apple.com>
2135
2136         Toggle GPS state based on page visibility to save battery
2137         https://bugs.webkit.org/show_bug.cgi?id=147685
2138
2139         Reviewed by Benjamin Poulain.
2140
2141         Add testRunner.isGeolocationProviderActive() test support function.
2142
2143         * DumpRenderTree/TestRunner.cpp:
2144         (isGeolocationProviderActiveCallback):
2145         (TestRunner::staticFunctions):
2146         * DumpRenderTree/TestRunner.h:
2147         * DumpRenderTree/mac/MockGeolocationProvider.h:
2148         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2149         (-[MockGeolocationProvider isActive]):
2150         * DumpRenderTree/mac/TestRunnerMac.mm:
2151         (TestRunner::isGeolocationProviderActive):
2152         * DumpRenderTree/win/TestRunnerWin.cpp:
2153         (TestRunner::isGeolocationProviderActive):
2154         * WebKitTestRunner/GeolocationProviderMock.h:
2155         (WTR::GeolocationProviderMock::isActive):
2156         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2157         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2158         (WTR::InjectedBundle::isGeolocationProviderActive):
2159         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2160         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2161         (WTR::TestRunner::isGeolocationProviderActive):
2162         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2163         * WebKitTestRunner/TestController.cpp:
2164         (WTR::TestController::isGeolocationProviderActive):
2165         * WebKitTestRunner/TestController.h:
2166         * WebKitTestRunner/TestInvocation.cpp:
2167         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2168
2169 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2170
2171         Automate JSBench with run-benchmark
2172         https://bugs.webkit.org/show_bug.cgi?id=147716
2173
2174         Reviewed by Chris Dumez.
2175
2176         Added JSBench plan to run-benchmark.
2177
2178         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2179         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
2180         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
2181         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
2182         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
2183         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
2184         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
2185         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
2186         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
2187         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
2188         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
2189         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2190         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
2191         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
2192         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
2193         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2194
2195 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2196
2197         Pass-through the undefined options in run-jsc
2198         https://bugs.webkit.org/show_bug.cgi?id=147717
2199
2200         Undefined options in run-jsc is just passed to the actual jsc shell.
2201         We can execute `Tools/Scripts/run-jsc -d`.
2202
2203         Reviewed by Csaba Osztrogonác.
2204
2205         * Scripts/run-jsc:
2206
2207 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2208
2209         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
2210
2211         It's flaky.
2212
2213         * Scripts/run-gtk-tests:
2214         (TestRunner):
2215
2216 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
2217
2218         [EFL] Bump EFL version to 1.15.0
2219         https://bugs.webkit.org/show_bug.cgi?id=147450
2220
2221         Reviewed by Gyuyoung Kim.
2222
2223         * efl/jhbuild.modules:
2224
2225 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2226
2227         Unreviewed. Unksip TestContextMenu GTK+ API test.
2228
2229         This has been skipped for a long time, and it's very
2230         unconvenient. It has never failed for me locally, so let's try
2231         again to see if it works in the bots. I'll skip it again if it
2232         keeps failing.
2233
2234         * Scripts/run-gtk-tests:
2235         (TestRunner):
2236
2237 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
2238
2239         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
2240
2241         * DumpRenderTree/JavaScriptThreading.cpp:
2242         (javaScriptThreadsMutex):
2243         (runJavaScriptThread):
2244         (startJavaScriptThreads):
2245         (stopJavaScriptThreads):
2246         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2247         (TestWebKitAPI::TEST):
2248         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2249         (TestWebKitAPI::TEST):
2250
2251 2015-08-05  Alex Christensen  <achristensen@webkit.org>
2252
2253         Build DumpRenderTree with CMake.
2254         https://bugs.webkit.org/show_bug.cgi?id=147519
2255
2256         Reviewed by Brent Fulgham.
2257
2258         * CMakeLists.txt:
2259         Build the DumpRenderTree directory now that it builds successfully.
2260         * DumpRenderTree/CMakeLists.txt:
2261         Added missing source file and don't link with WebCore.lib.
2262         * DumpRenderTree/PlatformWin.cmake:
2263         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
2264         * WinLauncher/CMakeLists.txt:
2265         We need libcmt now that we are not linking with WebCore.lib.
2266
2267 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
2268
2269         AppScale: Use https URLs for subresources and links
2270         https://bugs.webkit.org/show_bug.cgi?id=147686
2271
2272         Reviewed by Ryosuke Niwa.
2273
2274         * QueueStatusServer/filters/webkit_extras.py:
2275         * TestResultServer/static-dashboards/dashboard_base.js:
2276         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2277         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2278         * TestResultServer/static-dashboards/treemap.js:
2279         * TestResultServer/static-dashboards/ui.js:
2280
2281 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
2282
2283         Rename Mutex to DeprecatedMutex
2284         https://bugs.webkit.org/show_bug.cgi?id=147675
2285
2286         Reviewed by Geoffrey Garen.
2287
2288         * DumpRenderTree/JavaScriptThreading.cpp:
2289         (javaScriptThreadsMutex):
2290         (runJavaScriptThread):
2291         (startJavaScriptThreads):
2292         (stopJavaScriptThreads):
2293         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2294         (TestWebKitAPI::TEST):
2295         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2296         (TestWebKitAPI::TEST):
2297
2298 2015-08-05  Timothy Hatcher  <timothy@apple.com>
2299
2300         Update the WebKit nightly icon
2301         https://bugs.webkit.org/show_bug.cgi?id=147684
2302
2303         Reviewed by Sam Weinig.
2304
2305         * WebKitLauncher/webkit.icns: Replaced.
2306
2307 2015-08-05  Daniel Bates  <dabates@apple.com>
2308
2309         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
2310         https://bugs.webkit.org/show_bug.cgi?id=147678
2311         <rdar://problem/21827815>
2312
2313         Reviewed by Brady Eidson.
2314
2315         Add a test to ensure that we restore the "should open external URLs" policy on
2316         page reload after the web content process crashes.
2317
2318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2319         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
2320         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2321         (TEST):
2322
2323 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
2324
2325         [EFL] Editing tests have been broken since r186694
2326         https://bugs.webkit.org/show_bug.cgi?id=146888
2327
2328         Reviewed by Brent Fulgham.
2329
2330         Restored some codes for the context click on GTK+ and EFL port.
2331
2332         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2333         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
2334
2335 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
2336
2337         Install twisted package for http server when necessary.
2338         https://bugs.webkit.org/show_bug.cgi?id=147082
2339
2340         Reviewed by Ryosuke Niwa.
2341
2342         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2343         * Scripts/webkitpy/thirdparty/__init__.py:
2344         (AutoinstallImportHook.find_module):
2345         (AutoinstallImportHook._install_twisted):
2346
2347 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2348
2349         [Win] Update Apple Windows build for VS2015
2350         https://bugs.webkit.org/show_bug.cgi?id=147653
2351
2352         Reviewed by Dean Jackson.
2353
2354         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
2355         something older than VS2015, define snprintf as _snprintf.
2356         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2357         Remove unneeded macro definition for snprintf.
2358         * Scripts/webkitpy/common/system/platforminfo.py:
2359         (PlatformInfo._determine_win_version): Recognize Windows 10.
2360         * Scripts/webkitpy/port/win.py:
2361         (WinPort): Ditto.
2362         * Scripts/webkitpy/port/win_unittest.py:
2363         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
2364         (WinPortTest._assert_version): Ditto.
2365
2366 2015-08-04  Brian Burg  <bburg@apple.com>
2367
2368         Unreviewed, update email addresses in contributors.json and watchlist.
2369
2370         * Scripts/webkitpy/common/config/contributors.json:
2371         * Scripts/webkitpy/common/config/watchlist:
2372
2373 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
2374
2375         Implement NPAPI redirect handling
2376         https://bugs.webkit.org/show_bug.cgi?id=138675
2377         rdar://problem/15779101
2378
2379         Patch by Jeffrey Pfau, updated and tweaked by me.
2380
2381         Reviewed by Anders Carlsson.
2382
2383         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2384         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2385         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2386         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2387         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2388         (PluginTest::NPP_URLNotify):
2389         (PluginTest::NPP_URLRedirectNotify):
2390         (PluginTest::NPP_GetValue):
2391         (PluginTest::NPN_GetURLNotify):
2392         (PluginTest::NPN_PostURLNotify):
2393         (PluginTest::NPN_GetValue):
2394         (PluginTest::NPN_ReleaseVariantValue):
2395         (PluginTest::NPN_URLRedirectResponse):
2396         (PluginTest::NPN_ConvertPoint):
2397         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2398         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
2399         (URLRedirect::URLRedirect):
2400         (URLRedirect::ScriptableObject::hasMethod):
2401         (URLRedirect::ScriptableObject::get):
2402         (URLRedirect::ScriptableObject::serviceAsync):
2403         (URLRedirect::ScriptableObject::invoke):
2404         (URLRedirect::NPP_GetValue):
2405         (URLRedirect::NPP_URLNotify):
2406         (URLRedirect::NPP_URLRedirectNotify):
2407         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2408         (NP_GetEntryPoints):
2409         (NPP_URLNotify):
2410         (NPP_URLRedirectNotify):
2411         (NPP_GetValue):
2412
2413 2015-08-04  Tim Horton  <timothy_horton@apple.com>
2414
2415         Move Matt Daiter to committers.
2416
2417         * Scripts/webkitpy/common/config/contributors.json:
2418
2419 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2420
2421         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
2422         https://bugs.webkit.org/show_bug.cgi?id=147636
2423
2424         Reviewed by Alex Christensen.
2425         
2426         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
2427         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
2428         on EWS machines)
2429
2430         * Scripts/build-webkit:
2431
2432 2015-08-04  Jason Marcell  <jmarcell@apple.com>
2433
2434         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
2435         https://bugs.webkit.org/show_bug.cgi?id=147280
2436
2437         Reviewed by Daniel Bates.
2438
2439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2440         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
2441         Refactored _parseData to handle repositories more generically.
2442         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
2443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2444         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
2445         "opensourceRevision" and "internalRevision".
2446         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2448         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
2449         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2450         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
2451         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
2452         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
2453         and "internalRevision".
2454         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
2455         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
2456         "opensourceRevision" and "internalRevision".
2457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
2458         constants for internal and opensource repositories.
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2460         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
2461         instead of "opensourceRevision" and "internalRevision".
2462         (Analyzer.prototype._countPercentageOfGreen): Ditto.
2463         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
2464         (Analyzer.prototype._countTimes): Ditto.
2465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2466         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
2467
2468 2015-08-04  Mark Lam  <mark.lam@apple.com>
2469
2470         Removed a local debugging line I accidentally left in from a previous commit.
2471
2472         Not Reviewed.
2473
2474         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2475
2476 2015-08-04  Mark Lam  <mark.lam@apple.com>
2477
2478         Unreviewed. Make Saam Barati a WebKit reviewer.
2479
2480         * Scripts/webkitpy/common/config/contributors.json:
2481
2482 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2483
2484         Unreviewed, updated Streams API watchlist.
2485
2486         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
2487
2488 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
2489
2490         [CMake] Add an option to build AllInOne files
2491         https://bugs.webkit.org/show_bug.cgi?id=102647
2492
2493         Reviewed by Alex Christensen.
2494
2495         * Scripts/webkitperl/FeatureList.pm:
2496
2497 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
2498
2499         AppScale: Add required indices
2500         https://bugs.webkit.org/show_bug.cgi?id=147593
2501
2502         Reviewed by Tim Horton.
2503
2504         * QueueStatusServer/index.yaml:
2505
2506 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
2507
2508         Check in LLVM 3.6.2 binary drops for El Capitan
2509         https://bugs.webkit.org/show_bug.cgi?id=147582
2510
2511         Reviewed by Alexey Proskuryakov.
2512         
2513         Recognize 10.11 and use the right drops.
2514
2515         * Scripts/copy-webkitlibraries-to-product-directory:
2516
2517 2015-08-03  Alex Christensen  <achristensen@webkit.org>
2518
2519         [Win] Build fix after r187733.
2520
2521         * WinLauncher/PageLoadTestClient.cpp:
2522         (PageLoadTestClient::dumpRunStatistics):
2523         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
2524
2525 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
2526
2527         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
2528         https://bugs.webkit.org/show_bug.cgi?id=118455
2529
2530         Reviewed by Filip Pizlo.
2531
2532         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2533         (TestWebKitAPI::TEST):
2534
2535 2015-07-31  Alex Christensen  <achristensen@webkit.org>
2536
2537         Prepare for VS2015
2538         https://bugs.webkit.org/show_bug.cgi?id=146579
2539
2540         Reviewed by Jon Honeycutt.
2541
2542         * WinLauncher/stdafx.h:
2543         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
2544
2545 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2546
2547         [EFL] Fix pixman build on ARM with GCC 4.9.3
2548         https://bugs.webkit.org/show_bug.cgi?id=147224
2549
2550         Reviewed by Gyuyoung Kim.
2551
2552         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
2553
2554 2015-07-30  Anders Carlsson  <andersca@apple.com>
2555
2556         Add support for window.open to WK1BrowserWindowController
2557         https://bugs.webkit.org/show_bug.cgi?id=147474
2558
2559         Reviewed by Dan Bernstein.
2560
2561         * MiniBrowser/mac/WK1BrowserWindowController.m:
2562         (-[WK1BrowserWindowController awakeFromNib]):
2563         Set javaScriptCanOpenWindowsAutomatically to YES. 
2564         If this becomes a nuisance, we can always add a menu item to toggle this.
2565
2566         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2567         Implement this UI delegate method.
2568
2569 2015-07-30  Anders Carlsson  <andersca@apple.com>
2570
2571         Undo stray commit.
2572
2573         * MiniBrowser/mac/WK1BrowserWindowController.m:
2574         (-[WK1BrowserWindowController awakeFromNib]):
2575         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2576
2577 2015-07-29  Dean Jackson  <dino@apple.com>
2578
2579         Don't use (Details) when exposing SPI
2580         https://bugs.webkit.org/show_bug.cgi?id=147426
2581         <rdar://problem/22062407>
2582
2583         Reviewed by Dan Bernstein.
2584
2585         If we are declaring the interface without any implementation,
2586         we should use class extensions.
2587
2588         * DumpRenderTree/mac/DumpRenderTree.mm:
2589         * DumpRenderTree/mac/EventSendingController.mm:
2590         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2591         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2592         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2593         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2594         * WebKitTestRunner/mac/TestControllerMac.mm:
2595
2596 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
2597
2598         Replace Google App Engine with AppScale
2599         https://bugs.webkit.org/show_bug.cgi?id=147178
2600
2601         Reviewed by Daniel Bates.
2602
2603         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2604         (RunWebKitTests):
2605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2610         (.):
2611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2612         (BubbleQueueServer):
2613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2614         (TestHistory):
2615         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2616         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
2617         * TestResultServer/app.yaml: Ditto
2618         * Scripts/webkitpy/common/config/urls.py:
2619         * TestResultServer/main.py:
2620         * TestResultServer/static-dashboards/dashboard_base.js:
2621         * TestResultServer/static-dashboards/loader.js:
2622
2623 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
2624
2625         [EFL] Enable IndexedDB based on DatabaseProcess
2626         https://bugs.webkit.org/show_bug.cgi?id=147221
2627
2628         Reviewed by Csaba Osztrogonác.
2629
2630         * Scripts/webkitperl/FeatureList.pm:
2631
2632 2015-07-30  Alex Christensen  <achristensen@webkit.org>
2633
2634         Build AppleWin port with CMake
2635         https://bugs.webkit.org/show_bug.cgi?id=147385
2636
2637         Reviewed by Martin Robinson.
2638
2639         * WinLauncher/CMakeLists.txt:
2640         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
2641
2642 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
2643
2644         Implement basic types for ECMAScript Internationalization API
2645         https://bugs.webkit.org/show_bug.cgi?id=146926
2646
2647         Reviewed by Benjamin Poulain.
2648
2649         Enable flag now that the basic objects are in place.
2650
2651         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
2652
2653 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2654
2655         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
2656         https://bugs.webkit.org/show_bug.cgi?id=147108
2657
2658         Reviewed by Gustavo Noronha Silva.
2659
2660         Add test case to check the web process limit.
2661
2662         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2663         (testWebProcessLimit):
2664         (beforeAll):
2665
2666 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2667
2668         [GTK] Missing casts in BrowserWindow.c
2669         https://bugs.webkit.org/show_bug.cgi?id=147395
2670
2671         Reviewed by Carlos Garcia Campos.
2672
2673         * MiniBrowser/gtk/BrowserWindow.c:
2674         (browserWindowSetupEditorToolbar):
2675
2676 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2677
2678         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
2679         https://bugs.webkit.org/show_bug.cgi?id=147350
2680
2681         Reviewed by Sam Weinig.
2682
2683         * Scripts/webkitperl/FeatureList.pm:
2684
2685 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2686
2687         [Freetype] Always allow font matching for strong aliases
2688         https://bugs.webkit.org/show_bug.cgi?id=147057
2689
2690         Reviewed by Martin Robinson.
2691
2692         Create family aliases needed for the new layout tests.
2693
2694         * WebKitTestRunner/gtk/fonts/fonts.conf:
2695
2696 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
2697
2698         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
2699         https://bugs.webkit.org/show_bug.cgi?id=147359
2700
2701         Reviewed by Ryosuke Niwa.
2702
2703         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2704         (NewCommitBot.begin_work_queue):
2705         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2706         (SheriffBot.begin_work_queue):
2707
2708 2015-07-27  Alex Christensen  <achristensen@webkit.org>
2709
2710         Use Ninja on Windows.
2711         https://bugs.webkit.org/show_bug.cgi?id=147228
2712
2713         Reviewed by Martin Robinson.
2714
2715         * WinLauncher/CMakeLists.txt:
2716         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
2717         * Scripts/build-webkit:
2718         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
2719
2720 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
2721
2722         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
2723         highlight after being tapped to style a selection"
2724         https://bugs.webkit.org/show_bug.cgi?id=147278
2725
2726         Reviewed by Ryosuke Niwa.
2727
2728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2729
2730         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
2731         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
2732         (TestWebKitAPI::TEST):
2733         Load a page with the string "Hello, world!", then select "world" and
2734         underline it. Test that the typing attributes for the current selection
2735         include the underline attribute.
2736
2737 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2738
2739         Unreviewed, updated my nick name in contributors.json
2740
2741         * Scripts/webkitpy/common/config/contributors.json:
2742
2743 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
2744
2745         AX: scrollable elements do not allow 3-finger swipe
2746         https://bugs.webkit.org/show_bug.cgi?id=141893
2747
2748         Reviewed by Mario Sanchez Prada.
2749
2750         Support global notification listeners for iOS code.
2751         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
2752         Implement scrollUp/Down/Left/Right.
2753
2754         * DumpRenderTree/AccessibilityController.h:
2755         * DumpRenderTree/AccessibilityUIElement.cpp:
2756         (increaseTextSelectionCallback):
2757         (scrollPageUpCallback):
2758         (scrollPageDownCallback):
2759         (scrollPageLeftCallback):
2760         (scrollPageRightCallback):
2761         (decreaseTextSelectionCallback):
2762         (getElementTextLengthCallback):
2763         (AccessibilityUIElement::getJSClass):
2764         * DumpRenderTree/AccessibilityUIElement.h:
2765         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2766         (AccessibilityController::~AccessibilityController):
2767         (AccessibilityController::elementAtPoint):
2768         (AccessibilityController::addNotificationListener):
2769         (AccessibilityController::platformResetToConsistentState):
2770         (AccessibilityController::removeNotificationListener):
2771         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2772         (AccessibilityUIElement::AccessibilityUIElement):
2773         (AccessibilityUIElement::subrole):
2774         (AccessibilityUIElement::scrollPageUp):
2775         (AccessibilityUIElement::scrollPageDown):
2776         (AccessibilityUIElement::scrollPageLeft):
2777         (AccessibilityUIElement::scrollPageRight):
2778         (AccessibilityUIElement::roleDescription):
2779         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2780         (-[AccessibilityNotificationHandler _notificationReceived:]):
2781         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2782         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2783         (WTR::AccessibilityUIElement::linkedElement):
2784         (WTR::AccessibilityUIElement::headerElementAtIndex):
2785         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2786         (WTR::AccessibilityUIElement::scrollPageUp):
2787         (WTR::AccessibilityUIElement::scrollPageDown):
2788         (WTR::AccessibilityUIElement::scrollPageLeft):
2789         (WTR::AccessibilityUIElement::scrollPageRight):
2790         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2791         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2792         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2793         (WTR::AccessibilityController::addNotificationListener):
2794         (WTR::AccessibilityController::removeNotificationListener):
2795         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2796         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2797         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2798         (WTR::AccessibilityUIElement::scrollPageUp):
2799         (WTR::AccessibilityUIElement::scrollPageDown):
2800         (WTR::AccessibilityUIElement::scrollPageLeft):
2801         (WTR::AccessibilityUIElement::scrollPageRight):
2802         (WTR::AccessibilityUIElement::increaseTextSelection):
2803
2804 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
2805
2806         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
2807         https://bugs.webkit.org/show_bug.cgi?id=147279
2808         <rdar://problem/21990767>
2809
2810         Reviewed by Dean Jackson.
2811
2812         * DumpRenderTree/win/TestRunnerWin.cpp:
2813         (TestRunner::addUserScript):
2814         (TestRunner::addUserStyleSheet):
2815         (TestRunner::setDeveloperExtrasEnabled):
2816
2817 2015-07-24  Basile Clement  <basile_clement@apple.com>
2818
2819         Call fixChangeLogPatch when generating patches from webkit-patch
2820         https://bugs.webkit.org/show_bug.cgi?id=147248
2821
2822         Reviewed by Geoffrey Garen.
2823
2824         When two consecutive patches are from the same author, diff tools
2825         create wrong-looking diffs for ChangeLog files where the apparent added
2826         author is actually the previous patch's author line, making it awkward
2827         to read - and things only get worse when committing a patch and a
2828         followup fix for the same bug shortly after.
2829
2830         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
2831         this, which we use in perl scripts (svn-create-patch et al). But it is
2832         not used by webkit-patch, which is a python script, and thus creates
2833         "bad" diffs.
2834
2835         In the long term, we should probably port fixChangeLogPatch to python -
2836         but in the short term, let's make webkit-patch call perl to run
2837         fixChangeLogPatch. We are already making various external calls there
2838         anyway.
2839
2840         * Scripts/webkitpy/common/checkout/scm/git.py:
2841         (Git.create_patch):
2842         * Scripts/webkitpy/common/checkout/scm/scm.py:
2843         (SCM.fix_changelog_patch):
2844         * Scripts/webkitpy/common/checkout/scm/svn.py:
2845         (SVN.create_patch):
2846
2847 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
2848
2849         commit-queue flags in webkit-patch are confusing
2850         https://bugs.webkit.org/show_bug.cgi?id=88694
2851
2852         Reviewed by Csaba Osztrogonác.
2853
2854         * Scripts/webkitpy/tool/steps/options.py:
2855         (Options): Updated help string to be more descriptive.
2856
2857 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
2858
2859         [Win] Implement proper High DPI support features
2860         https://bugs.webkit.org/show_bug.cgi?id=146335
2861         <rdar://problem/21558269>
2862
2863         Reviewed by Alex Christensen.
2864
2865         Update WinLauncher to take device scaling factor into account.
2866
2867         * WinLauncher/Common.cpp:
2868         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
2869         a valid font.
2870         (computeFullDesktopFrame): Handle high DPI desktops.
2871         (WndProc): Make comments more precise.
2872         * WinLauncher/WinLauncher.cpp:
2873         (WinLauncher::init): Determine device scale factor at launch.
2874         (WinLauncher::updateDeviceScaleFactor): Added.
2875         * WinLauncher/WinLauncher.h:
2876         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
2877         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
2878         (wWinMain): Ditto.
2879         * win/DLLLauncher/DLLLauncherMain.cpp:
2880         (wWinMain): Tell Windows we understand high DPI.
2881
2882 2015-07-23  Alex Christensen  <achristensen@webkit.org>
2883
2884         [Win] Unreviewed build fix after r187169.
2885
2886         * Scripts/build-webkit:
2887         Correctly find WebKit.sln.
2888
2889 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2890
2891         [GTK] Add API to allow executing editing commands that require an argument
2892         https://bugs.webkit.org/show_bug.cgi?id=146781
2893
2894         Reviewed by Gustavo Noronha Silva.
2895
2896         Add buttons to insert image/link to the MiniBrowser edit toolbar,
2897         and test cases for insert image/link commands too.
2898
2899         * MiniBrowser/gtk/BrowserWindow.c:
2900         (insertImageCommandCallback):
2901         (insertLinkCommandCallback):
2902         (browserWindowSetupEditorToolbar):
2903         (browserWindowConstructed):
2904         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
2905         (testWebViewEditorInsertImage):
2906         (testWebViewEditorCreateLink):
2907         (beforeAll):
2908
2909 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2910
2911         Unregistering and re-registering a user message handler does not work
2912         https://bugs.webkit.org/show_bug.cgi?id=138142
2913
2914         Reviewed by Martin Robinson.
2915
2916         This has probably been fixed in r184846, enable the test case
2917         blocked on it.
2918
2919         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2920         (testUserContentManagerScriptMessageReceived):
2921
2922 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
2923
2924         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
2925         https://bugs.webkit.org/show_bug.cgi?id=147212
2926
2927         Reviewed by Filip Pizlo.
2928
2929         * Scripts/webkitperl/FeatureList.pm:
2930
2931 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
2932
2933         Add --ios-simulator to run-api-tests --help.
2934
2935         Rubber-stamped by Dan Bates.
2936
2937         * Scripts/run-api-tests:
2938
2939 2015-07-22  Jason Marcell  <jmarcell@apple.com>
2940
2941         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
2942         https://bugs.webkit.org/show_bug.cgi?id=147043
2943
2944         Reviewed by Daniel Bates and Alexey Proskuryakov.
2945
2946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2947         (Buildbot.prototype._normalizeQueueInfo):
2948         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
2949         in cases where the queue.branch property is not set and the queue is not a combined queue.
2950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2951         (BuildbotCombinedQueueView):
2952         Ensuring uniformity of repository branches within a combined queue.
2953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2954         (WebKitBuildbot.prototype.get defaultBranches):
2955         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
2956         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
2957         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
2958         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
2959         implement defaultBranches so that a person can either update the definition of the sub-queue or
2960         implement defaultBranches in the derived Buildbot class they are using.
2961
2962 2015-07-22  Alex Christensen  <achristensen@webkit.org>
2963
2964         Switch WinCairo build to use CMake.
2965         https://bugs.webkit.org/show_bug.cgi?id=147169
2966
2967         Reviewed by Brent Fulgham.
2968
2969         * Scripts/build-webkit:
2970         * Scripts/webkitdirs.pm:
2971         (determineConfiguration):
2972         (determineArchitecture):
2973         (determinePassedConfiguration):
2974         (passedConfiguration):
2975         (jhbuildWrapperPrefixIfNeeded):
2976         (generateBuildSystemFromCMakeProject):
2977         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
2978
2979 2015-07-22  Alex Christensen  <achristensen@webkit.org>
2980
2981         Fix quirks in CMake build on Mac and Windows
2982         https://bugs.webkit.org/show_bug.cgi?id=147174
2983
2984         Reviewed by Gyuyoung Kim.
2985
2986         * CMakeLists.txt:
2987         Don't build DumpRenderTree with CMake for now (until we get that working).
2988         * WinLauncher/CMakeLists.txt:
2989         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
2990
2991 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2992
2993         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
2994         https://bugs.webkit.org/show_bug.cgi?id=147146
2995
2996         Reviewed by Darin Adler.
2997
2998         * Scripts/webkitpy/style/checkers/cpp.py:
2999         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
3000         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3001         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
3002
3003 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
3004
3005         Fixed VM pool allocation should have a reserve for allocations that cannot fail
3006         https://bugs.webkit.org/show_bug.cgi?id=147154
3007         rdar://problem/21847618
3008
3009         Reviewed by Geoffrey Garen.
3010         
3011         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
3012         mitigations work, these should all pass. Prior to this patch there were >20 failures.
3013
3014         * Scripts/run-jsc-stress-tests:
3015
3016 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3017
3018         [GTK] Add API to be notified about editor state changes
3019         https://bugs.webkit.org/show_bug.cgi?id=145875
3020
3021         Reviewed by Gustavo Noronha Silva.
3022
3023         Update the typing attributes toggle buttons state according to the
3024         editor state in MiniBrowser, and add a test case to the
3025         WebViewEditor unit tests.
3026
3027         * MiniBrowser/gtk/BrowserWindow.c:
3028         (browserWindowEditingCommandToggleButtonSetActive):
3029         (typingAttributesChanged):
3030         (browserWindowSetupEditorToolbar):
3031         (browserWindowConstructed):
3032         (browser_window_init):
3033         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3034         (testWebViewEditorEditorStateTypingAttributes):
3035         (beforeAll):
3036
3037 2015-07-20  Tomas Popela  <tpopela@redhat.com>
3038
3039         [GTK] Add selection-changed signal to the WebKit2 API
3040         https://bugs.webkit.org/show_bug.cgi?id=137116
3041
3042         Reviewed by Carlos Garcia Campos.
3043
3044         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
3045         (namely the selection-changed signal).
3046
3047         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3048         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
3049         (WebKitWebEditorTest::create):
3050         (WebKitWebEditorTest::selectionChangedCallback):
3051         (WebKitWebEditorTest::testSelectionSelectAll):
3052         (WebKitWebEditorTest::testSelectionCollapse):
3053         (WebKitWebEditorTest::testSelectionModifyMove):
3054         (WebKitWebEditorTest::testSelectionModifyExtend):
3055         (WebKitWebEditorTest::testSelectionUnselect):
3056         (registerTests):
3057         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
3058         (testWebKitWebEditorSelectionChanged):
3059         (beforeAll):
3060         (afterAll):
3061
3062 2015-07-20  Alex Christensen  <achristensen@webkit.org>
3063
3064         Resurrect CMake build on Windows.
3065         https://bugs.webkit.org/show_bug.cgi?id=147083
3066
3067         Reviewed by Gyuyoung Kim.
3068
3069         * DumpRenderTree/CMakeLists.txt:
3070         * DumpRenderTree/PlatformWin.cmake: Added.
3071         * WinLauncher/CMakeLists.txt:
3072
3073 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3074
3075         [GTK] Enable seccomp filter API tests
3076         https://bugs.webkit.org/show_bug.cgi?id=140071
3077
3078         Reviewed by Žan Doberšek.
3079
3080         These tests will now be run by the run-gtk-tests script.
3081
3082         * TestWebKitAPI/PlatformGTK.cmake:
3083
3084 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3085
3086         [GTK] Add seccomp filters support
3087         https://bugs.webkit.org/show_bug.cgi?id=110014
3088
3089         Reviewed by Žan Doberšek.
3090
3091         Add libseccomp to jhbuild modulesets.
3092
3093         * gtk/jhbuild.modules:
3094
3095 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
3096
3097         MiniBrowser window title is just "Window" when page has no <title>
3098         https://bugs.webkit.org/show_bug.cgi?id=147076
3099
3100         Reviewed by Tim Horton.
3101         
3102         Make MiniBrowser windows show the filename from the URL if we never get a title changed
3103         notification.
3104
3105         * MiniBrowser/mac/WK1BrowserWindowController.m:
3106         (-[WK1BrowserWindowController updateTitle:]):
3107         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
3108         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3109         * MiniBrowser/mac/WK2BrowserWindowController.m:
3110         (-[WK2BrowserWindowController updateTitle:]):
3111         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3112         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3113
3114 2015-07-17  Andy Estes  <aestes@apple.com>
3115
3116         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
3117         https://bugs.webkit.org/show_bug.cgi?id=147044
3118         rdar://problem/21567820
3119
3120         Reviewed by Brady Eidson.
3121
3122         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3123         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
3124         This matches the behavior of DumpRenderTree.
3125
3126 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
3127
3128         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
3129         https://bugs.webkit.org/show_bug.cgi?id=147032
3130
3131         Reviewed by Alex Christensen.
3132
3133         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3134         Test that the useless terms are eliminated by counting
3135         the number of NFA nodes generated.
3136
3137 2015-07-17  Dan Bernstein  <mitz@apple.com>
3138
3139         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
3140         https://bugs.webkit.org/show_bug.cgi?id=147040
3141
3142         Reviewed by Dean Jackson.
3143
3144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3145         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
3146         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
3147         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
3148         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3149         (TEST):
3150
3151 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
3152
3153         webkit-patch uses incorrect credentials from keychain to login until account lockout
3154         https://bugs.webkit.org/show_bug.cgi?id=146923
3155
3156         Reviewed by Daniel Bates.
3157
3158         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
3159         provide incorrect credentials then ask for them to be saved to the keychain
3160         webkit-patch will then use those incorrect credentials until 5 total attempts
3161         have been made to log in. This will lock the user out of Bugzilla for a
3162         half hour.
3163
3164         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3165         (Bugzilla.authenticate): Added argument to read_credentials() that
3166         passes in whether or not to use stored credentials.
3167         * Scripts/webkitpy/common/net/credentials.py:
3168         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
3169         that specifies whether or not to use credentials stored on the system. If it
3170         does, we do not auto-fill credentials since either the credentials caused
3171         the failure, or they weren't used in the first place so there is no reason
3172         to try and use them again if a failure happened.
3173         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
3174         use_stored_credentials argument.
3175         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
3176         retrieve username/password information from the local system (environment, Git, keychain,
3177         keyring) are never called. It also tests that we get back our mocked username and password.
3178         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
3179         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
3180         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
3181         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
3182         is never called.
3183         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
3184         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
3185         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
3186         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
3187         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
3188         against.
3189
3190 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3191
3192         Unreviewed, remove my redundant email information.
3193
3194         * Scripts/webkitpy/common/config/contributors.json:
3195
3196 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3197
3198         Unreviewed. Add Hyungwook Lee as a committer.
3199
3200         * Scripts/webkitpy/common/config/contributors.json:
3201
3202 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3203
3204         Added myself to the list of contributors.
3205
3206         Reviewed by Brent Fulgham.
3207
3208         * Scripts/webkitpy/common/config/contributors.json:
3209
3210 2015-07-16  Alex Christensen  <achristensen@webkit.org>
3211
3212         [Content Extensions] Cache domain actions
3213         https://bugs.webkit.org/show_bug.cgi?id=146817
3214
3215         Reviewed by Benjamin Poulain.
3216
3217         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3218         (TestWebKitAPI::TEST_F):
3219         Test if-domain and unless-domain with multiple load types.
3220
3221 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
3222
3223         [Content extensions] Combine suffixes when generating NFAs
3224         https://bugs.webkit.org/show_bug.cgi?id=146961
3225
3226         Reviewed by Alex Christensen.
3227
3228         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3229         (TestWebKitAPI::compareContents):
3230         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3231
3232 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3233
3234         [GTK] Input method filter is always enabled when the view is focused
3235         https://bugs.webkit.org/show_bug.cgi?id=146965
3236
3237         Reviewed by Martin Robinson.
3238
3239         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
3240
3241         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3242         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
3243
3244 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3245
3246         [EFL] Bump libseccomp version to 2.2.3
3247         https://bugs.webkit.org/show_bug.cgi?id=146980
3248
3249         Reviewed by Gyuyoung Kim.
3250
3251         * efl/jhbuild.modules:
3252
3253 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
3254
3255         [Win] Maintain consistent COM Interfaces
3256         https://bugs.webkit.org/show_bug.cgi?id=146983
3257         <rdar://problem/21822278>
3258
3259         Reviewed by Dean Jackson.
3260
3261         Update DumpRenderTree and WinLauncher to use the properly
3262         versioned COM interface objects.
3263
3264         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3265         (AccessibilityController::rootElement):
3266         * DumpRenderTree/win/DumpRenderTree.cpp:
3267         (resetWebPreferencesToConsistentValues):
3268         (resetWebViewToConsistentStateBeforeTesting):
3269         (runTest):
3270         (createWebViewAndOffscreenWindow):
3271         * DumpRenderTree/win/EditingDelegate.cpp:
3272         (EditingDelegate::QueryInterface):
3273         (EditingDelegate::shouldEndEditingInDOMRange):
3274         (EditingDelegate::shouldInsertNode):
3275         * DumpRenderTree/win/EditingDelegate.h:
3276         * DumpRenderTree/win/EventSender.cpp:
3277         (scalePageByCallback):
3278         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3279         (FrameLoadDelegate::didCommitLoadForFrame):
3280         * DumpRenderTree/win/TestRunnerWin.cpp:
3281         (TestRunner::callShouldCloseOnWebView):
3282         (TestRunner::applicationCacheDiskUsageForOrigin):
3283         (TestRunner::clearApplicationCacheForOrigin):
3284         (TestRunner::setDefersLoading):
3285         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3286         (TestRunner::setTabKeyCyclesThroughElements):
3287         (TestRunner::setValueForUser):
3288         (TestRunner::dispatchPendingLoadRequests):
3289         (TestRunner::setWindowIsKey):
3290         (TestRunner::execCommand):
3291         (TestRunner::addOriginAccessWhitelistEntry):
3292         (TestRunner::removeOriginAccessWhitelistEntry):
3293         (TestRunner::addUserScript):
3294         (TestRunner::addUserStyleSheet):
3295         (TestRunner::showWebInspector):
3296         (TestRunner::closeWebInspector):
3297         (TestRunner::evaluateInWebInspector):
3298         (TestRunner::setSerializeHTTPLoads):
3299         * DumpRenderTree/win/TextInputControllerWin.cpp:
3300         (TextInputController::setMarkedText):
3301         (TextInputController::hasMarkedText):
3302         (TextInputController::unmarkText):
3303         (TextInputController::markedRange):
3304         (TextInputController::insertText):
3305         (TextInputController::firstRectForCharacterRange):
3306         (TextInputController::selectedRange):
3307         * DumpRenderTree/win/UIDelegate.h:
3308         (UIDelegate::unused2):
3309         (UIDelegate::unused3):
3310         (UIDelegate::webViewScrolled):
3311         (UIDelegate::webViewShouldInterruptJavaScript):
3312         (UIDelegate::webViewReceivedFocus):
3313         (UIDelegate::unused4): Deleted.
3314         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3315         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3316         * WinLauncher/PageLoadTestClient.cpp:
3317         (PageLoadTestClient::didStartProvisionalLoad):
3318         * WinLauncher/WinLauncher.cpp:
3319         (WinLauncher::init):
3320         * WinLauncher/WinLauncher.h:
3321         * WinLauncher/WinLauncherWebHost.cpp:
3322         (WinLauncherWebHost::didFinishLoadForFrame):
3323         (WinLauncherWebHost::didFirstLayoutInFrame):
3324         * WinLauncher/WinLauncherWebHost.h:
3325
3326 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
3327
3328         Many test failures in scm_unittest.py
3329         https://bugs.webkit.org/show_bug.cgi?id=143967
3330
3331         Reviewed by Daniel Bates. 
3332
3333         * Scripts/webkitpy/common/checkout/scm/detection.py:
3334         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
3335         absolute canonical file paths. Two mutually exclusive issues cause this
3336         to be a problem.
3337             1) Python's os.path.relpath() function does not return correct relative
3338             paths between two filepaths that point to the same file, if symlinks are
3339             involved.
3340                 On Mac, /tmp points to /private/tmp
3341                 ex. os.path.relpath('/tmp', '/private/tmp')
3342                     returns '../../tmp'
3343             What we want is actually just '.'
3344             2) Git does not allow file paths to trace outside of
3345             the Git repository. This means that if you have a repository in
3346             /tmp and you refer to that repository when invoking a git command as
3347             ../tmp, Git will produce errors about working outside of the repository.
3348         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
3349         its default behavior and such, needed to be updated.
3350         (Git.changed_files): '--' was added into the command so that patch_directories
3351         were taken as positional arguments.
3352         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
3353         in the GitSVNTest class to more closely emulate the version of Git that the tests
3354         assumed a system had. Also fixed a small side-effect from the absolute canonical
3355         path fix in SCMDetector.detect_scm_system
3356         (SVNTestRepository.setup): A relative filepath was previously passed as the
3357         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
3358         an absolute canonical path before being passed in. The failing test
3359         was a "sanity check" that the svn.checkout_root and scm.checkout_root
3360         were the same.
3361         (GitSVNTest._setup_git_checkout):
3362             1) Added "--prefix ''" option to `git clone` since Git changed its default
3363             behavior in version 2.0.
3364             2) The branch master was renamed to trunk to more closely emulate what
3365             tests expected when they were written. 
3366         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
3367         original tests failed because the tests expected the trunk branch
3368         to produce its parent's commit, whereas Git merely provides the HEAD commit
3369         for a given branch (trunk in this case). Based on other tests written
3370         in the same commit, it appears these tests were failing from the point they
3371         were written.
3372
3373 2015-07-14  Anders Carlsson  <andersca@apple.com>
3374
3375         Assertions.h should include ExportMacros.h
3376         https://bugs.webkit.org/show_bug.cgi?id=146948
3377
3378         Reviewed by Tim Horton.
3379
3380         Remove now unneeded WTF_EXPORT_PRIVATE define.
3381
3382         * DumpRenderTree/cg/ImageDiffCG.cpp:
3383
3384 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3385
3386         [GTK] [Wayland] Build by default the X11 and Wayland targets.
3387         https://bugs.webkit.org/show_bug.cgi?id=146057
3388
3389         Reviewed by Carlos Garcia Campos.
3390
3391         * gtk/install-dependencies:
3392
3393 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
3394
3395         [Mac] Unable to dismiss context menu during test runs
3396         https://bugs.webkit.org/show_bug.cgi?id=146836
3397
3398         Reviewed by Tim Horton.
3399
3400         Since Context Menus are modal, the test system would block on the displayed context menu,
3401         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
3402         mouse click and generate the menu contents, but not ask AppKit to display it.
3403
3404         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
3405
3406         * DumpRenderTree/mac/EventSendingController.mm:
3407         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
3408         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3409         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
3410         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
3411         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
3412         work without actually calling on AppKit to display the menu.
3413         ask WebCore to do all the work EXCEPT displaying the menu.
3414         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3415         * WebKitTestRunner/mac/EventSenderProxy.mm:
3416         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
3417
3418 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
3419
3420         It should be possible to run the OSR exit fuzzer
3421         https://bugs.webkit.org/show_bug.cgi?id=146814
3422
3423         Reviewed by Mark Lam.
3424         
3425         This runs a test command to detect how many static OSR exit sites it had, and then for
3426         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
3427         middle opportunity), plus a mode where the check always exits. This is an exhaustive
3428         search, so in the future it'll be very appropriate for cases where we have a simple test
3429         and we want to see what happens when you eventually exit in this test.
3430         
3431         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
3432         and it seems to do the right thing.
3433
3434         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
3435         (fail):
3436
3437 2015-07-10  Alex Christensen  <achristensen@webkit.org>
3438
3439         Add tests for r186649
3440         https://bugs.webkit.org/show_bug.cgi?id=146821
3441
3442         Reviewed by Darin Adler.
3443
3444         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3445         (TestWebKitAPI::TEST_F):
3446         (TestWebKitAPI::compareContents):
3447         (TestWebKitAPI::expectedIndex):
3448         Add some larger tests to test large jumps.
3449
3450 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
3451
3452         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
3453         https://bugs.webkit.org/show_bug.cgi?id=146820
3454
3455         Reviewed by Ryosuke Niwa.
3456
3457         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3458         (OSXBrowserDriver):
3459         (OSXBrowserDriver.close_browsers):
3460         (OSXBrowserDriver._terminiate_processes):
3461         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3462         (OSXChromeDriver):
3463         (OSXChromeCanaryDriver):
3464         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3465         (OSXFirefoxDriver):
3466         (OSXFirefoxNightlyDriver):
3467         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3468         (OSXSafariDriver):
3469
3470 2015-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3471
3472         [GTK] pango should be included in the default jhbuild moduleset
3473         https://bugs.webkit.org/show_bug.cgi?id=146683
3474
3475         Reviewed by Martin Robinson.
3476
3477         Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
3478         compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
3479         fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
3480         moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
3481         the same problem again the next time pango wants to use a new fontconfig feature), or remove
3482         fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
3483         best.
3484
3485         * gtk/jhbuild-optional.modules: Remove pango
3486         * gtk/jhbuild.modules: Add pango and update to latest 1.36.8
3487
3488 2015-07-09  Devin Rousso  <drousso@apple.com>
3489
3490         Unreviewed.  Added myself as a committer.
3491
3492         * Scripts/webkitpy/common/config/contributors.json:
3493
3494 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
3495
3496         Add a way to set the default URL from Minibrowser UI
3497         https://bugs.webkit.org/show_bug.cgi?id=146780
3498
3499         Reviewed by Simon Fraser.
3500
3501         * MiniBrowser/mac/AppDelegate.m:
3502         (-[BrowserAppDelegate didChangeSettings]):
3503         * MiniBrowser/mac/BrowserWindowController.h:
3504         * MiniBrowser/mac/BrowserWindowController.m:
3505         (-[BrowserWindowController fetch:]):
3506         (-[BrowserWindowController reload:]):
3507         (-[BrowserWindowController forceRepaint:]):
3508         (-[BrowserWindowController goBack:]):
3509         (-[BrowserWindowController goForward:]):
3510         (-[BrowserWindowController showHideWebView:]):
3511         (-[BrowserWindowController removeReinsertWebView:]):
3512         (-[BrowserWindowController zoomIn:]):
3513         (-[BrowserWindowController zoomOut:]):
3514         (-[BrowserWindowController resetZoom:]):
3515         (-[BrowserWindowController canZoomIn]):
3516         (-[BrowserWindowController canZoomOut]):
3517         (-[BrowserWindowController canResetZoom]):
3518         (-[BrowserWindowController toggleZoomMode:]):
3519         (-[BrowserWindowController setScale:]):
3520         (-[BrowserWindowController toggleShrinkToFit:]):
3521         (-[BrowserWindowController dumpSourceToConsole:]):
3522         (-[BrowserWindowController find:]):
3523         (-[BrowserWindowController didChangeSettings]):
3524         (-[BrowserWindowController currentURL]):
3525         Get rid of the BrowserController protocol. It was a bad idea and confused
3526         Interface Builder more than I thought possible.
3527
3528         * MiniBrowser/mac/SettingsController.m:
3529         (-[SettingsController _populateMenu]):
3530         (-[SettingsController setDefaultURLToCurrentURL:]):
3531         If we have a BrowserWindowController, grab its URL and set the relevant default.
3532
3533         * MiniBrowser/mac/WK1BrowserWindowController.h:
3534         * MiniBrowser/mac/WK1BrowserWindowController.m:
3535         (-[WK1BrowserWindowController currentURL]):
3536         * MiniBrowser/mac/WK2BrowserWindowController.h:
3537         * MiniBrowser/mac/WK2BrowserWindowController.m:
3538         (-[WK2BrowserWindowController currentURL]):
3539         Retrieve the current URL from the WKView/WebView.
3540
3541 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
3542
3543         Increase MiniBrowser location bar maximum width
3544         https://bugs.webkit.org/show_bug.cgi?id=146779
3545
3546         Reviewed by Simon Fraser.
3547
3548         * MiniBrowser/mac/BrowserWindow.xib:
3549         Have an enormous maximum width on the location bar, so that it doesn't
3550         stop expanding with the window at 800px.
3551
3552 2015-07-08  Brady Eidson  <beidson@apple.com>
3553
3554         Crash calling [WebView close] in didFinishLoadForFrame callback.
3555         <rdar://problem/21690765> and https://bugs.webkit.org/show_bug.cgi?id=146773
3556
3557         Reviewed by David Kilzer.
3558
3559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3560         
3561         * TestWebKitAPI/Tests/mac/WebViewCloseInsideDidFinishLoadForFrame.mm: Added.
3562         (-[WebViewCloseFrameLoadDelegate webView:didFinishLoadForFrame:]):
3563         (TestWebKitAPI::TEST):
3564
3565 2015-07-08  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3566
3567         Fix ASSERTION FAILED: !m_pendingNavigationID in WebPage::reload().
3568         https://bugs.webkit.org/show_bug.cgi?id=146546
3569
3570         Reviewed by Darin Adler.
3571
3572         We did't reset pendingNavigationID value when request url is empty.
3573         Hence we need to ignore ASSERT check in this case.
3574
3575         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3576         (TestWebKitAPI::TEST):
3577
3578 2015-07-08  Benjamin Poulain  <bpoulain@apple.com>
3579
3580        &