Unreviewed. Added myself to watchlist.
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-08  Kentaro Hara  <haraken@chromium.org>
2
3         Unreviewed. Added myself to watchlist.
4
5         * Scripts/webkitpy/common/config/watchlist:
6
7 2012-03-07  Jessie Berlin  <jberlin@apple.com>
8
9         Clean Windows build fails after r110033
10         https://bugs.webkit.org/show_bug.cgi?id=80553
11
12         Rubber-stamped by Jon Honeycutt and Eric Seidel.
13
14         Add the new JavaScriptCore include directory to some more vsprops files.
15
16         * DumpRenderTree/win/ImageDiffCommon.vsprops:
17         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
18         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
19
20 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
21
22         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
23         https://bugs.webkit.org/show_bug.cgi?id=72489
24
25         Reviewed by Dirk Pranke.
26
27         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
28         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
29         --platform will override the platform name and then we'll use it.
30
31         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
32         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
33         override it in the end.
34
35         * Scripts/old-run-webkit-tests:
36         * Scripts/webkitpy/layout_tests/port/qt.py:
37         (QtPort):
38         (QtPort.determine_full_port_name):
39         (QtPort.baseline_search_path):
40
41 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
42
43         [Qt][WK2] MiniBrowser on desktop does not react to click events
44         https://bugs.webkit.org/show_bug.cgi?id=80314
45
46         Reviewed by Kenneth Rohde Christiansen.
47
48         Do not enable touch mocking on desktop mode.
49
50         * MiniBrowser/qt/MiniBrowserApplication.cpp:
51         (MiniBrowserApplication::handleUserOptions):
52
53 2012-03-07  Ojan Vafai  <ojan@chromium.org>
54
55         Automatically move to the next test after rebaseline in the results view
56         https://bugs.webkit.org/show_bug.cgi?id=80527
57
58         Reviewed by Dimitri Glazkov.
59
60         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
61         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
62
63 2012-03-07  Ojan Vafai  <ojan@chromium.org>
64
65         garden-o-matic rebaseline is broken for ports that don't have a fallback port
66         https://bugs.webkit.org/show_bug.cgi?id=80526
67
68         Reviewed by Adam Barth.
69
70         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
71         since there is no "None" port.
72
73         * Scripts/webkitpy/tool/servers/gardeningserver.py:
74         (GardeningHTTPRequestHandler.rebaseline):
75         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
76         (GardeningServerTest.test_rebaseline):
77
78 2012-03-07  James Robinson  <jamesr@chromium.org>
79
80         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
81         https://bugs.webkit.org/show_bug.cgi?id=80521
82
83         Reviewed by Kenneth Russell.
84
85         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
86         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
87         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
88
89         Covered by platform/chromium/compositing/plugins/*
90
91         * DumpRenderTree/chromium/TestWebPlugin.cpp:
92         (TestWebPlugin::TestWebPlugin):
93         (TestWebPlugin::initialize):
94         (TestWebPlugin::updateGeometry):
95         (TestWebPlugin::initScene):
96         (TestWebPlugin::destroyScene):
97         * DumpRenderTree/chromium/TestWebPlugin.h:
98         (TestWebPlugin):
99         * DumpRenderTree/chromium/WebViewHost.cpp:
100         (WebViewHost::createPlugin):
101
102 2012-03-07  Philippe Normand  <pnormand@igalia.com>
103
104         [GTK] remove webkitpy dependency in run-gtk-tests
105         https://bugs.webkit.org/show_bug.cgi?id=80500
106
107         Reviewed by Martin Robinson.
108
109         Replace Executive calls with bare subprocess calls.
110
111         * Scripts/run-gtk-tests:
112         (TestRunner):
113         (TestRunner._lookup_atspi2_binary):
114         (TestRunner.run):
115         (TestRunner.run.run_for_real):
116
117 2012-03-07  Philippe Normand  <pnormand@igalia.com>
118
119         Unreviewed, GTK build fix after r110059.
120
121         * Scripts/run-gtk-tests:
122         (TestRunner._check_if_tests_have_timed_out):
123         (TestRunner.run.run_tests):
124         (TestRunner):
125
126 2012-03-07  Philippe Normand  <pnormand@igalia.com>
127
128         [GTK] race condition in run-gtk-tests
129         https://bugs.webkit.org/show_bug.cgi?id=80495
130
131         Reviewed by Martin Robinson.
132
133         Refactored the script to wait the a11y dbus service becomes
134         available before starting the tests.
135
136         * Scripts/run-gtk-tests:
137         (TestRunner._lookup_atspi2_binary):
138         (TestRunner):
139         (TestRunner._wait_dbus_service_and_run):
140         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
141         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
142         (TestRunner.run):
143         (TestRunner.run.bailout):
144         (TestRunner.run.run_for_real):
145
146 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
147
148         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
149         https://bugs.webkit.org/show_bug.cgi?id=80425
150
151         Reviewed by Simon Hausmann.
152
153         Set startScreenPos in mock touch point
154
155         * MiniBrowser/qt/MiniBrowserApplication.cpp:
156         (MiniBrowserApplication::notify):
157         * MiniBrowser/qt/MiniBrowserApplication.h:
158         (MiniBrowserApplication):
159
160 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
161
162         [Qt] Windows build fix.
163
164         Reviewed by Tor Arne Vestbø.
165
166         Pass the -j parameter only to "make", not "nmake".
167
168         * Scripts/webkitdirs.pm:
169         (buildQMakeProjects):
170
171 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
172
173         [Qt] Fix compilation without QtQuick1
174         https://bugs.webkit.org/show_bug.cgi?id=80503
175
176         Reviewed by Tor Arne Vestbø.
177
178         Introduce HAVE_QQUICK1 as feature and added haveQtModule
179         as convenience function.
180
181         * qmake/mkspecs/features/features.prf:
182         * qmake/mkspecs/features/functions.prf:
183
184 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
185
186         [Qt] Add qmake config tests for JPEG and PNG library
187         https://bugs.webkit.org/show_bug.cgi?id=80398
188
189         Add JPEG and PNG library tests to config.tests and
190         add error() abort to WebCore.pri if tests don't work.
191
192         Reviewed by Tor Arne Vestbø.
193
194         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
195         (main):
196         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
197         * qmake/config.tests/libpng/libpng.cpp: Added.
198         (main):
199         * qmake/config.tests/libpng/libpng.pro: Added.
200         * qmake/sync.profile:
201
202 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
203
204         [EFL] Build warning: Fix warn_unused_result warnings.
205         https://bugs.webkit.org/show_bug.cgi?id=79194
206
207         Reviewed by Filip Pizlo.
208
209         Fixed build warning which is getting generated when not using return
210         value of a fuction, especially declared with warn_unused_result
211         attribute.
212
213         * DumpRenderTree/efl/ImageDiff.cpp:
214         (printImage):
215
216 2012-03-07  Kangil Han  <kangil.han@samsung.com>
217
218         [DRT] Remove PlainTextController implementations.
219         https://bugs.webkit.org/show_bug.cgi?id=79959
220
221         Reviewed by Hajime Morita.
222
223         PlainTextController usages in existing tests have been
224         replaced by internals API by bug 78570.
225         So this patch will remove PlainTextController implementations
226         to avoid further usage in new tests.
227
228         * DumpRenderTree/DumpRenderTree.gypi:
229         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
230         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
231         * DumpRenderTree/chromium/PlainTextController.h: Removed.
232         * DumpRenderTree/chromium/TestShell.cpp:
233         (TestShell::TestShell):
234         (TestShell::bindJSObjectsToWindow):
235         * DumpRenderTree/chromium/TestShell.h:
236         (TestShell):
237         * DumpRenderTree/gtk/DumpRenderTree.cpp:
238         (webViewWindowObjectCleared):
239         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
240         * DumpRenderTree/gtk/PlainTextController.h: Removed.
241         * DumpRenderTree/mac/FrameLoadDelegate.mm:
242         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
243         * DumpRenderTree/mac/PlainTextController.h: Removed.
244         * DumpRenderTree/mac/PlainTextController.mm: Removed.
245         * DumpRenderTree/qt/DumpRenderTree.pro:
246         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
247         (WebCore::DumpRenderTree::DumpRenderTree):
248         (WebCore::DumpRenderTree::initJSObjects):
249         * DumpRenderTree/qt/DumpRenderTreeQt.h:
250         (DumpRenderTree):
251         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
252         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
253         * GNUmakefile.am:
254
255 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
256
257         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
258         https://bugs.webkit.org/show_bug.cgi?id=80137
259
260         Reviewed by Eric Seidel.
261
262         Adds implementation LayoutTestController's setPopupBlockingEnabled.
263         To pass popup-blocking-click-in-iframe.html EventSender should not
264         repeat click events in idler's function. EventSender allows to
265         asynchronously send click event through ecore_idler_add.
266         This event will be called repeatedly as long as it return true.
267         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
268
269         * DumpRenderTree/efl/EventSender.cpp:
270         (sendMouseEvent): Changed return value from bool to void because it always returns true.
271         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
272         (mouseDownCallback): Remove unnecessary checking of return value.
273         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
274         (LayoutTestController::setPopupBlockingEnabled):
275
276 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
277
278         rebaseline_chromium_webkit_tests is obsolete and should be removed
279         https://bugs.webkit.org/show_bug.cgi?id=80347
280
281         Reviewed by Tony Chang.
282
283         * Scripts/rebaseline-chromium-webkit-tests: Removed.
284         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
285         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
286
287 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
288
289         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
290         https://bugs.webkit.org/show_bug.cgi?id=80468
291
292         Unreviewed, build fix.
293
294         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
295
296         * Scripts/webkitpy/layout_tests/servers/http_server.py:
297         (Lighttpd._prepare_config):
298
299 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
300
301         remove chromium_gpu ports
302         https://bugs.webkit.org/show_bug.cgi?id=80345
303
304         Reviewed by Ojan Vafai.
305
306         This change leaves in the 'graphics_type' distinction in the
307         test_expectations; removing that will require more updates and a
308         pass over test_expectations.txt, so I'm separating that out.
309
310         * Scripts/webkitpy/layout_tests/port/builders.py:
311         * Scripts/webkitpy/layout_tests/port/chromium.py:
312         (ChromiumPort):
313         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
314         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
315         * Scripts/webkitpy/layout_tests/port/factory.py:
316         (PortFactory):
317         (PortFactory.get):
318         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
319         (FactoryTest.test_qt):
320         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
321         (TestRebaseline.test_rebaseline_expectations):
322
323 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
324
325         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
326         https://bugs.webkit.org/show_bug.cgi?id=80282
327
328         Reviewed by Antonio Gomes.
329
330         Remove transitive library dependencies; they are especially
331         dangerous when one ends up linking against WTF, JSC and then WTF
332         again, since some symbols will not be defined.
333
334         Passing --no-copy-dt-needed-entries and --as-needed to the linker
335         (which some recent Linux distros do by default) makes the issue
336         even more evident.
337
338         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
339         as the other libraries have the needed symbols. Explicitly link
340         against fontconfig.
341
342 2012-03-06  Dean Jackson  <dino@apple.com>
343
344         filter-build-webkit needs more filters
345         https://bugs.webkit.org/show_bug.cgi?id=80440
346
347         Reviewed by Joseph Pecoraro.
348
349         Added as many missing filters as I could find for Apple
350         builds. Plus a few minor style updates.
351
352         * Scripts/filter-build-webkit:
353         (printLine):
354
355 2012-03-06  Ojan Vafai  <ojan@chromium.org>
356
357         Copying old baselines throws an error if the new directory doesn't exist
358         https://bugs.webkit.org/show_bug.cgi?id=80443
359
360         Reviewed by Adam Barth.
361
362         Existing tests cover the new code with the fix to filesystem_mock.
363
364         * Scripts/webkitpy/common/system/filesystem_mock.py:
365         (MockFileSystem.copyfile):
366         Fix the mock to better match python's copyfile semantics.
367
368         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
369         (Rebaseliner._create_html_baseline_files):
370         * Scripts/webkitpy/tool/commands/rebaseline.py:
371         (RebaselineTest._copy_existing_baseline):
372
373 2012-03-05  Ojan Vafai  <ojan@chromium.org>
374
375         Add a mechanism to rebaseline new ports
376         https://bugs.webkit.org/show_bug.cgi?id=80355
377
378         Reviewed by Adam Barth.
379
380         For a test that's only failing on a new port, we want
381         to first copy the existing result into the location for the
382         port it's replacing in order to not break that port.
383
384         For example, bringing up the chromium-lion port, if we just
385         stick the results in the chromium-mac directory, the snow leopard
386         will start failing. Instead, we first copy the existing result
387         to the chromium-mac-snowleopard directory.
388
389         * Scripts/webkitpy/layout_tests/port/builders.py:
390         (builder_path_for_port_name):
391         (fallback_port_name_for_new_port):
392         * Scripts/webkitpy/tool/commands/rebaseline.py:
393         (RebaselineTest):
394         (RebaselineTest._copy_existing_baseline):
395         (RebaselineTest._rebaseline_test):
396         (RebaselineTest.execute):
397         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
398         (TestRebaseline.test_rebaseline_test):
399         (TestRebaseline):
400         (TestRebaseline.test_rebaseline_and_copy_test):
401         (test_rebaseline_and_copy_test_no_existing_result):
402         (test_rebaseline_and_copy_test_with_lion_result):
403         (test_rebaseline_and_copy_no_overwrite_test):
404         * Scripts/webkitpy/tool/servers/gardeningserver.py:
405         (GardeningHTTPRequestHandler.rebaseline):
406         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
407         (GardeningServerTest.test_rebaseline):
408         (GardeningServerTest):
409         (GardeningServerTest.test_rebaseline_new_port):
410
411 2012-03-06  Beth Dakin  <bdakin@apple.com>
412
413         https://bugs.webkit.org/show_bug.cgi?id=80351
414         InlineTextBox is using the wrong origin when calling 
415         addRelevantRepaintedObject
416         -and corresponding-
417         <rdar://problem/10970221>
418
419         Reviewed by Sam Weinig.
420
421         This test has actually been broken since revision 109273. This change makes 
422         the test pass again, and it makes it specifically exercise the fix for this 
423         bug.
424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
425         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
426         (TestWebKitAPI::TEST):
427
428         Adjust comments in the other tests to reflect the API changes from 109273.
429         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
430         (TestWebKitAPI::TEST):
431         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
432         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
433         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
434         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
435         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
436         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
437         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
438
439 2012-03-06  Hans Wennborg  <hans@chromium.org>
440
441         Speech JavaScript API: add SpeechRecognitionError
442         https://bugs.webkit.org/show_bug.cgi?id=80410
443
444         Chromium: enable the runtime flag for scripted speech so we can run
445         the layout tests for it.
446
447         Reviewed by Adam Barth.
448
449         * DumpRenderTree/chromium/TestShell.cpp:
450         (TestShell::TestShell):
451
452 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
453
454         Enable universal newlines in chromium android layout test runner
455         https://bugs.webkit.org/show_bug.cgi?id=80418
456
457         Reviewed by Adam Barth.
458
459         The Chromium Android layout test runner uses the 'adb' program to
460         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
461         output lines from the test runner, while the test expectation files are
462         written with LF ('\n') delimiters. This causes the results to have
463         spurious whitespace differences, making them more difficult to
464         interpret.
465
466         The fix is to enable universal newlines for the DumpRenderTree pipe,
467         causing the output to only contain LF newlines like on other platforms.
468
469         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
470         (ChromiumAndroidDriver._start):
471
472 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
473
474         [Qt] Revert r109900, it was completly busted
475
476         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
477
478         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
479         of manual define checks.
480
481         Reviewed by Ossy.
482
483         * DumpRenderTree/qt/DumpRenderTree.pro:
484         * QtTestBrowser/QtTestBrowser.pro:
485         * WebKitTestRunner/InjectedBundle/Target.pri:
486         * qmake/mkspecs/features/features.prf:
487
488 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
489
490         [Qt] Use config test to determine if the compiler supports -MD
491
492         We used to assume that unix systems building against Qt5 would have
493         a compiler that supported -MD. Although this was usually the case,
494         we failed to take into account broken tools for distributed builds
495         (e.g. teambuilder or icecream) which would end up producing .d files
496         in the root of the build dir instead of along-side the object file.
497
498         Now that we use a config-test to determine the support, we'll capture
499         those cases, unless distributed builds are enabled after the initial
500         build-webkit run.
501
502         Reviewed by Csaba Osztrogonác.
503
504         * Tools.pro:
505         * qmake/config.tests/gccdepends/empty.cpp: Added.
506         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
507         * qmake/mkspecs/features/default_pre.prf:
508         * qmake/mkspecs/features/features.prf:
509         * qmake/mkspecs/features/unix/default_pre.prf:
510         * qmake/sync.profile:
511
512 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
513
514         REGRESSION(r109294): It broke the unittest of master.cfg
515         https://bugs.webkit.org/show_bug.cgi?id=80253
516
517         Reviewed by Tor Arne Vestbø.
518
519         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
520         (BuildBotConfigLoader._create_mock_passwords_dict):
521         (BuildBotConfigLoader._mock_open):
522         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
523         (BuildBotConfigLoader.load_config):
524
525 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
526
527         Qt API test buildstep throws exception after buildmaster update
528         https://bugs.webkit.org/show_bug.cgi?id=80249
529
530         This patch based on Peter Gal's work.
531
532         Reviewed by Csaba Osztrogonác.
533
534         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
535         (RunQtAPITests):
536         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
537
538 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
539
540         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
541
542         Reviewed by Simon Hausmann.
543         Reviewed by Ossy.
544
545         * DumpRenderTree/qt/DumpRenderTree.pro:
546         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
547         (WebKit::initializeTestFonts):
548         * QtTestBrowser/QtTestBrowser.pro:
549         * WebKitTestRunner/InjectedBundle/Target.pri:
550         * qmake/mkspecs/features/features.prf:
551
552 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
553
554         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
555
556         Reviewed by Ossy.
557
558         * qmake/mkspecs/features/default_post.prf:
559
560 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
561
562         [Qt] Make sure clean builds are followed by make qmake && make if needed
563
564         On non-GNUmake systems we have to run make qmake so that the generated
565         sources are generated before we run qmake on the target pro files. This
566         is achieved by using the 'incremental' target.
567
568         Reviewed by Ossy.
569
570         * Scripts/webkitdirs.pm:
571         (buildQMakeProjects):
572
573 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
574
575         DumpRenderTree should support preciseTime()
576         https://bugs.webkit.org/show_bug.cgi?id=80397
577
578         Reviewed by Gavin Barraclough.
579
580         * DumpRenderTree/LayoutTestController.cpp:
581         (preciseTimeCallback):
582         (LayoutTestController::staticFunctions):
583
584 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
585
586         Unreviewed, rolling out r109887.
587         http://trac.webkit.org/changeset/109887
588         https://bugs.webkit.org/show_bug.cgi?id=80402
589
590         It broke the build (Requested by Ossy on #webkit).
591
592         * DumpRenderTree/qt/DumpRenderTree.pro:
593         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
594         (WebKit::initializeTestFonts):
595         * QtTestBrowser/QtTestBrowser.pro:
596         * WebKitTestRunner/InjectedBundle/Target.pri:
597         * qmake/mkspecs/features/features.prf:
598
599 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
600
601         Unreviewed, rolling out r109837.
602         http://trac.webkit.org/changeset/109837
603         https://bugs.webkit.org/show_bug.cgi?id=80399
604
605         breaks Mac Productions builds, too late to try and fix it
606         tonight (Requested by eseidel on #webkit).
607
608         * Scripts/build-webkit:
609
610 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
611
612         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
613
614         Reviewed by Simon Hausmann.
615
616         * DumpRenderTree/qt/DumpRenderTree.pro:
617         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
618         (WebKit::initializeTestFonts):
619         * QtTestBrowser/QtTestBrowser.pro:
620         * WebKitTestRunner/InjectedBundle/Target.pri:
621         * qmake/mkspecs/features/features.prf:
622
623 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
624
625         [Qt] Create EWS to build WebKit2
626         https://bugs.webkit.org/show_bug.cgi?id=80277
627
628         Reviewed by Csaba Osztrogonác.
629
630         * QueueStatusServer/model/queues.py:
631         (Queue):
632         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
633         (QtWK2EWS):
634         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
635         (EarlyWarningSytemTest.test_builder_ewses):
636
637 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
638
639         Unreviewed, rolling out r109733.
640         http://trac.webkit.org/changeset/109733
641         https://bugs.webkit.org/show_bug.cgi?id=80378
642
643         It broke Qt5 build system (Requested by Ossy on #webkit).
644
645         * Tools.pro:
646         * qmake/config.tests/gccdepends/empty.cpp: Removed.
647         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
648         * qmake/mkspecs/features/default_pre.prf:
649         * qmake/mkspecs/features/features.prf:
650         * qmake/mkspecs/features/unix/default_pre.prf:
651         * qmake/sync.profile:
652
653 2012-03-05  Eric Seidel  <eric@webkit.org>
654
655         Update JavaScriptCore files to use fully-qualified WTF include path
656         https://bugs.webkit.org/show_bug.cgi?id=79960
657
658         Reviewed by Adam Barth.
659
660         Build WTF/WTF.xcodeproj by default on Mac.
661
662         * Scripts/build-webkit:
663
664 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
665
666         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
667         https://bugs.webkit.org/show_bug.cgi?id=69590
668
669         Reviewed by Ryosuke Niwa.
670
671         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
672         to skip the 'optimize-expectations' step.
673
674         * Scripts/webkitpy/tool/commands/rebaseline.py:
675         (RebaselineExpectations.__init__):
676         (RebaselineExpectations.execute):
677         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
678
679 2012-03-05  Kent Tamura  <tkent@chromium.org>
680
681         [Chromium] Add new popup type: PagePopup
682         https://bugs.webkit.org/show_bug.cgi?id=80106
683
684         Reviewed by Darin Fisher.
685
686         * DumpRenderTree/chromium/WebViewHost.cpp:
687         (WebViewHost::createPopupMenu):
688
689 2012-03-05  Jessie Berlin  <jberlin@apple.com>
690
691         Add myself as a reviewer.
692
693         * Scripts/webkitpy/common/config/committers.py:
694         Also, add my IRC nick so it is easier to find and yell at me.
695
696 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
697
698         Correctly compute the positions of GestureScroll* events on
699         Chromium.
700         https://bugs.webkit.org/show_bug.cgi?id=80075
701
702         Reviewed by Adam Barth.
703
704         * DumpRenderTree/chromium/EventSender.cpp:
705         (EventSender::reset):
706         (EventSender::gestureEvent):
707         * DumpRenderTree/chromium/EventSender.h:
708         (EventSender):
709
710 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
711
712         flakiness dashboard doesn't display baselines for virtual tests correctly
713         https://bugs.webkit.org/show_bug.cgi?id=80341
714
715         Reviewed by Ojan Vafai.
716
717         If the test is part of a virtual test suite, we need to look for
718         baselines in the underlying fallback path for the actual test
719         being run, as well as baselines for the virtual version.
720
721         This patch adds code to handle both branches and also pulls the
722         mapping of the test suites up into a constant.
723
724         * TestResultServer/static-dashboards/flakiness_dashboard.html:
725         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
726         (testLookupVirtualTestSuite):
727         (testBaseTest):
728
729 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
730
731         Unreviewed, rolling out r109760.
732         http://trac.webkit.org/changeset/109760
733         https://bugs.webkit.org/show_bug.cgi?id=80320
734
735         Caused many GTK+ tests to crash (Requested by mrobinson on
736         #webkit).
737
738         * gtk/jhbuild.modules:
739
740 2012-03-05  Charlie Reis  <creis@chromium.org>
741
742         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
743         https://bugs.webkit.org/show_bug.cgi?id=80057
744
745         Reviewed by Darin Fisher.
746
747         * DumpRenderTree/chromium/WebViewHost.cpp:
748         (WebViewHost::createView):
749         * DumpRenderTree/chromium/WebViewHost.h:
750         (WebViewHost):
751
752 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
753
754         [soup] Crash while loading http://www.jusco.cn
755         https://bugs.webkit.org/show_bug.cgi?id=68238
756
757         Reviewed by Philippe Normand.
758
759         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
760         in the jhbuild file.
761
762 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
763
764         Unreviewed, rolling out r109748.
765         http://trac.webkit.org/changeset/109748
766         https://bugs.webkit.org/show_bug.cgi?id=80296
767
768         Made some tests crash, will fix and recommit (Requested by
769         noamr on #webkit).
770
771         * MiniBrowser/qt/main.cpp:
772         (main):
773
774 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
775
776         [GTK] plugins/netscape-plugin-page-cache-works.html fails
777         https://bugs.webkit.org/show_bug.cgi?id=74409
778
779         Reviewed by Martin Robinson.
780
781         Add support for overriding the page-cache-for-plugins preference
782         through DumpRenderTreeSupport.
783
784         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
785         (booleanFromValue): A helper function to convert a string to boolean.
786         (LayoutTestController::overridePreference):
787
788 2012-03-05  Rob Buis  <rbuis@rim.com>
789
790         [BlackBerry] Update Tools/DumpRenderTree
791         https://bugs.webkit.org/show_bug.cgi?id=80287
792
793         Reviewed by Antonio Gomes.
794
795         Update so we are sure we can build our implementation of DRT.
796
797         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
798         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
799         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
800         (AccessibilityController::addNotificationListener): add missing hook.
801         (AccessibilityController::removeNotificationListener): add missing hook.
802         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
803         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
804         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
805         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
806         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
807
808 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
809
810         [Qt] [WK2] Support threaded renderer in WK2
811         https://bugs.webkit.org/show_bug.cgi?id=76661
812
813         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
814
815         Reviewed by Kenneth Rohde Christiansen.
816
817         * MiniBrowser/qt/main.cpp:
818         (main):
819
820 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
821
822         Unreviewed. Add myself to committer list.
823
824         * Scripts/webkitpy/common/config/committers.py:
825
826 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
827
828         [Qt] Use config test to determine if the compiler supports -MD
829
830         We used to assume that unix systems building against Qt5 would have
831         a compiler that supported -MD. Although this was usually the case,
832         we failed to take into account broken tools for distributed builds
833         (e.g. teambuilder or icecream) which would end up producing .d files
834         in the root of the build dir instead of along-side the object file.
835
836         Now that we use a config-test to determine the support, we'll capture
837         those cases, unless distributed builds are enabled after the initial
838         build-webkit run.
839
840         Reviewed by Csaba Osztrogonác.
841
842         * Tools.pro:
843         * qmake/config.tests/gccdepends/empty.cpp: Added.
844         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
845         * qmake/mkspecs/features/default_pre.prf:
846         * qmake/mkspecs/features/features.prf:
847         * qmake/mkspecs/features/unix/default_pre.prf:
848         * qmake/sync.profile:
849
850 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
851
852         Qt API test buildstep throws exception after buildmaster update
853         https://bugs.webkit.org/show_bug.cgi?id=80249
854
855         Reviewed by Zoltan Herczeg.
856
857         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
858         (BuildAndTestFactory.__init__):
859
860 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
861
862         [GTK] Unit tests are noisy when run under jhbuild
863         https://bugs.webkit.org/show_bug.cgi?id=80241
864
865         Reviewed by Philippe Normand.
866
867         Force the 'memory' backend in GSettings so that each unit
868         test doesn't produce a warning when it's forced to fall back
869         to the 'memory' backend.
870
871         * Scripts/run-gtk-tests:
872         (TestRunner.run): Force the 'memory' backend.
873
874 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
875
876         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
877         https://bugs.webkit.org/show_bug.cgi?id=80235
878
879         Reviewed by Philippe Normand.
880
881         * Scripts/run-gtk-tests:
882         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
883         inspector resources path determination is shared by all tests.
884
885 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
886
887         [GTK] REGRESSION: r108278 broke some tests that expect focus
888         https://bugs.webkit.org/show_bug.cgi?id=79084
889
890         Reviewed by Philippe Normand.
891
892         Grab focus when dumping test results and also when sending
893         events. During the course of testing, the WebView may lose
894         focus and this seems to snap it back when tests demand it.
895
896         * DumpRenderTree/gtk/DumpRenderTree.cpp:
897         (dump): Grab focus.
898         * DumpRenderTree/gtk/EventSender.cpp:
899         (dispatchEvent): Ditto.
900
901 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
902
903         Unreviewed, Add myself to committer list.
904         https://bugs.webkit.org/show_bug.cgi?id=80232
905
906         * Scripts/webkitpy/common/config/committers.py:
907
908 2012-03-04  Anders Carlsson  <andersca@apple.com>
909
910         Newer versions of clang fail to compile WebKit.
911
912         Fix build.
913
914         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
915         (descriptionOfValue):
916         (AccessibilityUIElement::rowIndexRange):
917         (AccessibilityUIElement::columnIndexRange):
918         (AccessibilityUIElement::selectedTextRange):
919         * DumpRenderTree/mac/EditingDelegate.mm:
920         (-[DOMRange dump]):
921         * DumpRenderTree/mac/PolicyDelegate.mm:
922         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
923         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
924         (-[NSError _drt_descriptionSuitableForTestResult]):
925         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
926         (WTR::descriptionOfValue):
927         (WTR::AccessibilityUIElement::rowIndexRange):
928         (WTR::AccessibilityUIElement::columnIndexRange):
929         (WTR::AccessibilityUIElement::selectedTextRange):
930
931 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
932
933         [Qt] Fix static_libs_as_shared build
934         https://bugs.webkit.org/show_bug.cgi?id=80214
935
936         Reviewed by Tor Arne Vestbø.
937
938         * WebKitTestRunner/qt/main.cpp:
939         (main): Set the correct environment variable for choosing the theme in the
940         web process.
941
942 2012-03-03  Hans Wennborg  <hans@chromium.org>
943
944         Implement Speech JavaScript API
945         https://bugs.webkit.org/show_bug.cgi?id=80019
946
947         Reviewed by Adam Barth.
948
949         Add ENABLE_SCRIPTED_SPEECH.
950
951         * Scripts/build-webkit:
952         * qmake/mkspecs/features/features.prf:
953
954 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
955
956         Fix commit queue, remove duplicate entry.
957
958         * Scripts/webkitpy/common/config/committers.py:
959
960 2012-03-02  Stephen Chenney  <schenney@chromium.org>
961
962         Unreviewed, add myself as a committer
963
964         * Scripts/webkitpy/common/config/committers.py:
965
966 2012-03-02  Ojan Vafai  <ojan@chromium.org>
967
968         Add the Chromium Lion canary bot to the flakiness dashboard.
969         * TestResultServer/static-dashboards/builders.js:
970
971 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
972
973         links for virtual tests are broken in the flakiness dashboard
974         https://bugs.webkit.org/show_bug.cgi?id=80180
975
976         Reviewed by Ojan Vafai.
977
978         * TestResultServer/static-dashboards/flakiness_dashboard.html:
979         (linkHTMLToOpenWindow):
980         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
981         (testLinkHTMLToOpenWindow): added.
982
983 2012-03-02  Philippe Normand  <pnormand@igalia.com>
984
985         [GTK] security/block-test.html baselines differ from mac
986         https://bugs.webkit.org/show_bug.cgi?id=78343
987
988         Reviewed by Martin Robinson.
989
990         Improved the FrameLoader error heuristics to match mac behavior a
991         bit more.
992
993         * DumpRenderTree/gtk/DumpRenderTree.cpp:
994         (pathFromSoupURI): Handle ftp urls the same as http urls.
995         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
996
997 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
998
999         [Qt][WK2] Fix typo in patch committed in r109575
1000
1001         Unreviewed typo fix.
1002
1003         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1004         (MiniBrowserApplication::notify): Cache the position
1005         in floating point coordinates.
1006
1007 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
1008
1009         [Qt][WK2] Infinite loop on history navigation, when panning
1010         https://bugs.webkit.org/show_bug.cgi?id=79119
1011
1012         Reviewed by Simon Hausmann.
1013
1014         Make the touch mocking more robust by creating touch events
1015         directly and sending them synchronously to the browser window.
1016         If the sent touch event was not accepted we propagate the
1017         original mouse event to its target.
1018         This way we make sure we only send either a touch or a mouse
1019         event and do not end up in an infinite loop between our mocking
1020         code and the Qt5 automatic mouse event synthesizing.
1021
1022         * MiniBrowser/qt/BrowserWindow.cpp:
1023         (BrowserWindow::updateVisualMockTouchPoints):
1024         * MiniBrowser/qt/BrowserWindow.h:
1025         (BrowserWindow):
1026         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1027         (touchRectForPosition):
1028         (MiniBrowserApplication::notify):
1029         (MiniBrowserApplication::sendTouchEvent):
1030         * MiniBrowser/qt/MiniBrowserApplication.h:
1031         (MiniBrowserApplication):
1032
1033 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1034
1035         [Qt] Use 'all' as default target when debug_and_release is in effect
1036
1037         When debug_and_release is enabled, in combination with build_all,
1038         qmake will generate an aggregate makefile that calls make on both
1039         the debug and the release makefiles, but with the 'all' target.
1040
1041         In this case we can't use 'first' as the default target, as the
1042         extra targets would then not be run, so we append extra targets
1043         to 'all' instead.
1044
1045         Reviewed by Simon Hausmann.
1046
1047         * qmake/mkspecs/features/default_post.prf:
1048
1049 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1050
1051         [Qt] Make sure activeBuildConfig() returns the right config
1052
1053         Using isActiveConfig fails, as that only checks if the given
1054         argument is in CONFIG, not the order.
1055
1056         Reviewed by Simon Hausmann.
1057
1058         * qmake/mkspecs/features/functions.prf:
1059
1060 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
1061
1062         [Qt] Fix tests run with WTR not using QStyle theme
1063         https://bugs.webkit.org/show_bug.cgi?id=80147
1064
1065         Reviewed by Csaba Osztrogonác.
1066
1067         * WebKitTestRunner/qt/main.cpp:
1068         (main): Set environment variable for web process to use QStyle theme.
1069
1070 2012-03-02  Philippe Normand  <pnormand@igalia.com>
1071
1072         Unreviewed, remove debug print call.
1073
1074         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1075         (descriptionSuitableForTestResult):
1076
1077 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
1078
1079         Updated EventSender to send complete gesture events.
1080         https://bugs.webkit.org/show_bug.cgi?id=80075
1081
1082         Reviewed by Adam Barth.
1083
1084         * DumpRenderTree/chromium/EventSender.cpp:
1085         (EventSender::gestureEvent): set additional parameters in sent events.
1086
1087 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1088
1089         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
1090         https://bugs.webkit.org/show_bug.cgi?id=80033
1091
1092         Reviewed by Gustavo Noronha Silva.
1093
1094         GCC 4.7 no longer includes unistd.h from most of the standard C++
1095         header files, so we need to explicitly include it for getcwd().
1096
1097         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
1098         not only on Mac, but on all Unix platforms.
1099
1100 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1101
1102         Actually look at the args in driver_input :(.
1103
1104         Unreviewed, build fix.
1105
1106         * Scripts/webkitpy/layout_tests/port/chromium.py:
1107         (ChromiumDriver.run_test):
1108
1109 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1110
1111         Fix typo in flag used to run gpu virtual suites.
1112
1113         Unreviewed, build fix.
1114
1115         * Scripts/webkitpy/layout_tests/port/chromium.py:
1116         (ChromiumPort.virtual_test_suites):
1117
1118 2012-03-01  Adam Barth  <abarth@webkit.org>
1119
1120         Unreviewed, rolling out r109317.
1121         http://trac.webkit.org/changeset/109317
1122
1123         Let's try watchlists again now that we're using a pure git
1124         working copy
1125
1126         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1127         (StyleQueueTask.run):
1128         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1129
1130 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1131
1132         webkitpy: test_run_test_pause_before_testing is failing after r109482
1133         https://bugs.webkit.org/show_bug.cgi?id=80084
1134
1135         Unreviewed, build fix.
1136
1137         Fixes the test string compare to ignore the time spent running
1138         the tests.
1139
1140         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1141         (test_run_test_pause_before_testing):
1142
1143 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1144
1145         nrwt: virtual tests aren't being run
1146         https://bugs.webkit.org/show_bug.cgi?id=80083
1147
1148         Reviewed by Eric Seidel.
1149
1150         If we tried to run all of the tests by default (and
1151         didn't specify any paths), the virtual tests weren't
1152         picked up.
1153
1154         * Scripts/webkitpy/layout_tests/port/base.py:
1155         (Port._virtual_tests):
1156         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1157         (PortTest.test_tests):
1158         * Scripts/webkitpy/layout_tests/port/test.py:
1159         (TestPort.virtual_test_suites):
1160
1161 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1162
1163         run-perf-tests should report the test runtime
1164         https://bugs.webkit.org/show_bug.cgi?id=80078
1165
1166         Reviewed by Hajime Morita.
1167
1168         Record and output the aggreated test run time.
1169
1170         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1171         (PerfTestsRunner._run_single_test):
1172
1173 2012-03-01  Michael Nordman  <michaeln@google.com>
1174
1175         [chromium] Use webkit_support to create session storage namespaces in DRT.
1176         https://bugs.webkit.org/show_bug.cgi?id=79933
1177
1178         Reviewed by Tony Chang.
1179
1180         * DumpRenderTree/chromium/WebViewHost.cpp:
1181         (WebViewHost::createSessionStorageNamespace):
1182
1183 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
1184
1185         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
1186         https://bugs.webkit.org/show_bug.cgi?id=80048
1187
1188         Reviewed by Adam Barth.
1189
1190         * Scripts/webkitpy/layout_tests/port/base.py:
1191         (Port.test_isfile):
1192         (Port.test_isdir):
1193         (Port):
1194         (Port.test_exists):
1195         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1196         (PortTest.test_test_exists):
1197         (PortTest):
1198         (PortTest.test_test_isfile):
1199         (PortTest.test_test_isdir):
1200         * Scripts/webkitpy/layout_tests/port/test.py:
1201         (TestPort.virtual_test_suites):
1202         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1203         (MainTest.test_virtual):
1204
1205 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
1206
1207         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
1208         https://bugs.webkit.org/show_bug.cgi?id=80031
1209
1210         Reviewed by Gustavo Noronha Silva.
1211
1212         Only build the libTestRunnerInjectedBundle.la convenience library when
1213         ENABLE_WEBKIT2 is defined.
1214
1215         * WebKitTestRunner/GNUmakefile.am:
1216
1217 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1218
1219         Unreviewed, second attempt to fix GTK NRWT after r109242.
1220
1221         * Scripts/webkitpy/layout_tests/port/gtk.py:
1222         (GtkDriver._start):
1223
1224 2012-03-01  Philippe Normand  <pnormand@igalia.com>
1225
1226         Unreviewed, GTK NRWT build fix attempt after r109242.
1227
1228         * Scripts/webkitpy/layout_tests/port/gtk.py:
1229         (GtkDriver._start):
1230
1231 2012-03-01  Kentaro Hara  <haraken@chromium.org>
1232
1233         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
1234         https://bugs.webkit.org/show_bug.cgi?id=80008
1235
1236         Reviewed by Adam Barth.
1237
1238         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
1239         to "preprocess-idls.pl". This patch renames it.
1240
1241         Test: Confirm that run-bindings-tests runs.
1242
1243         * Scripts/webkitpy/bindings/main.py:
1244         (BindingsTests.generate_supplemental_dependency):
1245
1246 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
1247
1248         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
1249         https://bugs.webkit.org/show_bug.cgi?id=78047
1250
1251         Reviewed by Kenneth Rohde Christiansen.
1252
1253         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
1254         sending to the item requires the QObject::event re-implementation to dispatch to the correct
1255         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
1256         the event handlers directly, and with the removal of our own dispatching we need to go through
1257         that code path.
1258
1259         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1260         (WTR::PlatformWebView::sendEvent):
1261         (WTR::PlatformWebView::postEvent):
1262
1263 2012-02-29  Adam Barth  <abarth@webkit.org>
1264
1265         Disable watchlist.  It's been spamming CCs.
1266
1267         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1268         (StyleQueueTask.run):
1269         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1270
1271 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1272
1273         need to clone the gpu baselines and expectations into the new "virtual" dir
1274         https://bugs.webkit.org/show_bug.cgi?id=79956
1275
1276         Reviewed by Adam Barth.
1277
1278         * Scripts/webkitpy/layout_tests/port/chromium.py:
1279         (ChromiumPort.virtual_test_suites):
1280
1281 2012-02-29  Mark Rowe  <mrowe@apple.com>
1282
1283         Switch to using json rather than simplejson now that the master is using Python 2.7.
1284
1285         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1286         (loadBuilderConfig):
1287
1288 2012-02-29  David Levin  <levin@chromium.org>
1289
1290         [chromium] Add the ability to turn off autoresize.
1291         https://bugs.webkit.org/show_bug.cgi?id=77452
1292
1293         Reviewed by Darin Fisher.
1294
1295         * DumpRenderTree/chromium/LayoutTestController.cpp:
1296         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
1297         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
1298         (LayoutTestController::disableAutoResizeMode):  Ditto.
1299         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
1300
1301 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1302
1303         nrwt: make --print trace work with virtual tests
1304         https://bugs.webkit.org/show_bug.cgi?id=79952
1305
1306         Reviewed by Adam Barth.
1307
1308         * Scripts/webkitpy/layout_tests/views/printing.py:
1309         (Printer._print_test_trace):
1310         (Printer._print_baseline):
1311
1312 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
1313
1314         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
1315         https://bugs.webkit.org/show_bug.cgi?id=79849
1316
1317         Reviewed by Beth Dakin.
1318
1319         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1320         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
1321
1322 2012-02-29  Lucas Forschler  <lforschler@apple.com>
1323
1324         Removed unused Apple buildslaves from the master configuration
1325         https://bugs.webkit.org/show_bug.cgi?id=79925
1326
1327         Reviewed by Stephanie Lewis.
1328
1329         * BuildSlaveSupport/build.webkit.org-config/config.json:
1330
1331 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1332
1333         nrwt: implement simple 'virtual test suite' support
1334         https://bugs.webkit.org/show_bug.cgi?id=79737
1335
1336         Reviewed by Adam Barth.
1337
1338         Add very basic support for 'virtual test suites' to NRWT:
1339         a virtual suite is a directory that may contain new baselines,
1340         contains a pointer to a "base" directory of tests, and an
1341         optional list of command line arguments to pass to DRT;
1342         it gives us a way to run all of the tests in a given directory
1343         multiple times with multiple (potentially differing) sets of
1344         results and baselines.
1345
1346         This patch implements the support needed for this feature, and
1347         some basic tests, but no actual port will use the feature yet.
1348
1349         This is probably the simplest implementation possible - the
1350         list of virtual suites will be hard-coded into the port's
1351         implementation. One can imagine a more data-driven approach
1352         where the suite instructions are stored in a manifest file
1353         either in LayoutTests (all suites in one file), or per-port,
1354         or per-directory. If this feature ends up being useful we
1355         should probably add something like that so people don't have
1356         to hunt around in the code to add suites.
1357
1358         * Scripts/webkitpy/layout_tests/port/base.py:
1359         (Port.__init__):
1360         (Port.expected_filename):
1361         (Port.tests):
1362         (Port):
1363         (Port._real_tests):
1364         (Port._driver_class):
1365         (Port.virtual_test_suites):
1366         (Port.virtual_suite):
1367         (Port.virtual_suite.VirtualTestSuite):
1368         (Port.virtual_suite.VirtualTestSuite.__init__):
1369         (Port.virtual_suite.VirtualTestSuite.__repr__):
1370         (Port.populated_virtual_test_suites):
1371         (Port._virtual_tests):
1372         (Port.lookup_virtual_test_base):
1373         (Port.lookup_virtual_test_args):
1374         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1375         (PortTest.test_find_with_skipped_directories):
1376         * Scripts/webkitpy/layout_tests/port/driver.py:
1377         (DriverInput.__init__):
1378         (DriverProxy.run_test):
1379         * Scripts/webkitpy/layout_tests/port/test.py:
1380         (TestPort.virtual_test_suites):
1381         (TestDriver.run_test):
1382         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1383         (MainTest.test_all):
1384         (MainTest.test_virtual):
1385
1386 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1387
1388         nrwt: support more than two drivers in DriverProxy
1389         https://bugs.webkit.org/show_bug.cgi?id=79736
1390
1391         Reviewed by Adam Barth.
1392
1393         Now that we can support per-test command lines for
1394         Drivers, modify DriverProxy to keep a map of running
1395         drivers for each needed command-line; this will allow
1396         us to transparently maintain a pool of appropriately
1397         configured DRTs without having to constantly start and stop
1398         them.
1399
1400         Note that this potentially raises a garbage collection
1401         problem - the number of running DRTs will grow with the
1402         number of different sets of command line args. For now
1403         this is no worse than the current code - if you're running
1404         with pixel tests, you will only need one DRT per worker,
1405         and if you aren't, you'll need two (one for text-only tests,
1406         and one for reftests).
1407
1408         An alternative would be to only ever have one running driver,
1409         and restart the driver as the command line changes, but this
1410         might (?) slow down execution in the text-only case - we
1411         should benchmark this because it would be simpler and possibly
1412         allow us to eliminate DriverProxy altogether.
1413
1414         * Scripts/webkitpy/layout_tests/port/driver.py:
1415         (DriverProxy.__init__):
1416         (DriverProxy):
1417         (DriverProxy._make_driver):
1418         (DriverProxy.run_test):
1419         (DriverProxy.has_crashed):
1420         (DriverProxy.stop):
1421         (DriverProxy.cmd_line):
1422         (DriverProxy._cmd_line_as_key):
1423
1424 2012-02-29  Adrienne Walker  <enne@google.com>
1425
1426         Unreviewed, add myself as a reviewer
1427
1428         * Scripts/webkitpy/common/config/committers.py:
1429
1430 2012-02-29  Greg Billock  <gbillock@google.com>
1431
1432         Add more tests for web intents
1433         https://bugs.webkit.org/show_bug.cgi?id=79527
1434
1435         Reviewed by Adam Barth.
1436
1437         * DumpRenderTree/chromium/LayoutTestController.cpp:
1438         (LayoutTestController::LayoutTestController):
1439         (LayoutTestController::sendWebIntentResponse):
1440         * DumpRenderTree/chromium/LayoutTestController.h:
1441         (LayoutTestController):
1442         * DumpRenderTree/chromium/WebViewHost.h:
1443         (WebViewHost):
1444         (WebViewHost::currentIntentRequest):
1445
1446 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1447
1448         nrwt: port/Driver needs to support per-test command line args
1449         https://bugs.webkit.org/show_bug.cgi?id=79733
1450
1451         Reviewed by Adam Barth.
1452
1453         As part of removing the 'gpu' configurations and adding support
1454         for 'virtual test suites', the Driver classes need to support
1455         per-test command lines (since different tests will need to be
1456         run with different command line options).
1457
1458         The per-test args are not yet used, so this change should have
1459         no visible effects and need no additional testing.
1460
1461         * Scripts/webkitpy/layout_tests/port/base.py:
1462         (Port.driver_cmd_line):
1463         * Scripts/webkitpy/layout_tests/port/chromium.py:
1464         (ChromiumDriver.cmd_line):
1465         (ChromiumDriver._start):
1466         (ChromiumDriver.start):
1467         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1468         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
1469         (ChromiumDriverTest):
1470         (ChromiumDriverTest.test_two_drivers):
1471         * Scripts/webkitpy/layout_tests/port/driver.py:
1472         (Driver.cmd_line):
1473         (DriverProxy.__init__):
1474         (DriverProxy.start):
1475         (DriverProxy.cmd_line):
1476         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1477         (DriverTest.test_virtual_driver_methods):
1478         * Scripts/webkitpy/layout_tests/port/gtk.py:
1479         (GtkDriver.cmd_line):
1480         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1481         * Scripts/webkitpy/layout_tests/port/test.py:
1482         (TestPort._path_to_driver):
1483         (TestDriver.cmd_line):
1484         (TestDriver.start):
1485         * Scripts/webkitpy/layout_tests/port/webkit.py:
1486         (WebKitDriver.cmd_line):
1487         (WebKitDriver._start):
1488         (WebKitDriver.run_test):
1489         (WebKitDriver.start):
1490         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1491         (WebKitDriverTest.test_no_timeout):
1492         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1493         (PerfTestsRunner._run_tests_set):
1494         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1495         (test_run_test_pause_before_testing):
1496
1497 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
1498
1499         perftestsrunner can call printer.write() after printer.cleanup()
1500         https://bugs.webkit.org/show_bug.cgi?id=79872
1501
1502         Reviewed by Ryosuke Niwa.
1503
1504         This patch fixes a unittest that was incorrectly calling
1505         PerfTestsRunner.run() twice (which led to a weird state in the
1506         printer object).
1507
1508         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1509         (MainTest.test_run_with_upload_json):
1510
1511 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
1512
1513         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1514         https://bugs.webkit.org/show_bug.cgi?id=76546
1515
1516         Reviewed by Simon Hausmann.
1517
1518         Revert the workaround introduced in r107868 and reintroduce
1519         the qml binding so we can test the code path that we are more
1520         interested in. The reason that it did not work before is that
1521         we don't have an active platform window which we now workaround
1522         by propagating the resize through QWindowSystemInterface.
1523
1524         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1525         (WTR::WrapperWindow::handleStatusChanged):
1526         (WTR::PlatformWebView::resizeTo):
1527
1528 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
1529
1530         [GTK] Small fix for cross compilation to not generate gtkdoc.
1531
1532         Rubber-stamped by Csaba Osztrogonác.
1533
1534         * Scripts/webkitdirs.pm:
1535         (isCrossCompilation):
1536
1537 2012-02-28  Lucas Forschler  <lforschler@apple.com>
1538
1539         Fix a typo in config.json
1540         linx -> linux
1541         
1542         * BuildSlaveSupport/build.webkit.org-config/config.json:
1543
1544 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1545
1546         [Qt] Allow read/write to the WebView.url property
1547         https://bugs.webkit.org/show_bug.cgi?id=77554
1548
1549         Reviewed by Tor Arne Vestbø.
1550
1551         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
1552
1553         * MiniBrowser/qt/qml/BrowserWindow.qml:
1554
1555 2012-02-28  Dan Winship  <danw@gnome.org>
1556
1557         [GTK] make tests explicitly request GSettingsBackendMemory
1558         https://bugs.webkit.org/show_bug.cgi?id=79788
1559
1560         Reviewed by Martin Robinson.
1561
1562         Explicitly request the fallback memory-based GSettings backend; if
1563         other backends are available then we don't want to use them,
1564         because they would make tests depend on the user's preferences.
1565         And if other backends aren't available, we don't need glib to
1566         print a warning about that fact.
1567
1568         * Scripts/webkitpy/layout_tests/port/gtk.py:
1569         (GtkPort.setup_environ_for_server):
1570
1571 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
1572
1573         Unreviewed, rolling out r109110.
1574         http://trac.webkit.org/changeset/109110
1575         https://bugs.webkit.org/show_bug.cgi?id=79806
1576
1577         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
1578         (Requested by aroben on #webkit).
1579
1580         * Scripts/webkitpy/common/checkout/changelog.py:
1581         (parse_bug_id):
1582         (parse_bug_id_from_changelog):
1583         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1584         * Scripts/webkitpy/common/config/urls.py:
1585
1586 2012-02-28  Adam Roben  <aroben@webkit.org>
1587
1588         Add my new email address
1589
1590         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
1591
1592         Reviewed by Anders Carlsson.
1593
1594         * Scripts/webkitpy/common/config/committers.py:
1595
1596 2012-02-28  Adam Roben  <aroben@apple.com>
1597
1598         Teach webkitpy about wkb.ug URLs
1599
1600         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
1601         use wkb.ug URLs
1602
1603         Reviewed by Anders Carlsson.
1604
1605         * Scripts/webkitpy/common/checkout/changelog.py:
1606         (parse_bug_id):
1607         (parse_bug_id_from_changelog):
1608         Fall back to the tiny URL format if neither the short nor long URL formats work.
1609
1610         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1611         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
1612
1613         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
1614         wkb.ug URLs.
1615
1616 2012-02-28  János Badics  <dicska@gmail.com>
1617
1618         [Qt] build-webkit does not detect the number of CPUs
1619         https://bugs.webkit.org/show_bug.cgi?id=76445
1620
1621         Based on Seo Sanghyeon's work (modification:
1622         Automatically determine the number of CPUs for make
1623         only if -j make argument haven't already been specified.)
1624
1625         Reviewed by Csaba Osztrogonác.
1626
1627         * Scripts/webkitdirs.pm:
1628         (buildQMakeProjects):
1629
1630 2012-02-28  Kent Tamura  <tkent@chromium.org>
1631
1632         Update a pattern for forms files of watchlist
1633         https://bugs.webkit.org/show_bug.cgi?id=79767
1634
1635         Reviewed by Kentaro Hara.
1636
1637         * Scripts/webkitpy/common/config/watchlist:
1638         Catches the following files with the "Forms" pattern.
1639         - HTMLDatListElement.*
1640         - HTMLKeygenElement.*
1641         - HTMLLegendElement.*
1642         - HTMLOutputElement.*
1643         - FormAssociatedElement.*
1644         - SliderThumbElement.*
1645         - TextControlInnerElements.*
1646         - RenderFileUploadControl.*
1647
1648 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1649
1650         Unreviewed, rolling out r109041.
1651         http://trac.webkit.org/changeset/109041
1652         https://bugs.webkit.org/show_bug.cgi?id=79741
1653
1654         Broke Chromium Win build (Requested by bashi on #webkit).
1655
1656         * DumpRenderTree/chromium/LayoutTestController.cpp:
1657         (LayoutTestController::LayoutTestController):
1658         * DumpRenderTree/chromium/LayoutTestController.h:
1659         (LayoutTestController):
1660         * DumpRenderTree/chromium/WebViewHost.h:
1661
1662 2012-02-27  James Robinson  <jamesr@chromium.org>
1663
1664         [chromium] Remove media tests from ChromiumGpu configurations
1665         https://bugs.webkit.org/show_bug.cgi?id=79720
1666
1667         Reviewed by Adam Barth.
1668
1669         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
1670         composited playback path via tests in the compositing/ directory.
1671
1672         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1673         (_default_tests_paths):
1674         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1675         (ChromiumGpuTest.test_default_tests_paths):
1676         (ChromiumGpuTest.test_test_files):
1677
1678 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
1679
1680         nrwt: log multiline stderr/crash output properly
1681         https://bugs.webkit.org/show_bug.cgi?id=79722
1682
1683         Reviewed by Adam Barth.
1684
1685         This cleans up some nits in the log output to make things
1686         slightly easier to read (every line gets timestamped, etc.).
1687
1688         Also tweaks the log message for pixel hash mismatches.
1689
1690         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1691         (SingleTestRunner._handle_error):
1692         (SingleTestRunner._compare_image):
1693
1694 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1695
1696         Touch the master.cfg to force a reconfig.
1697
1698         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1699         (BuildAndTestLeaksFactory):
1700         (NewBuildAndTestFactory):
1701
1702 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
1703
1704         [BlackBerry] Upstream BlackBerry API web page related files
1705         https://bugs.webkit.org/show_bug.cgi?id=74380
1706
1707         Reviewed by Antonio Gomes.
1708
1709         Adapt to the removing of WebPage::mainFrame(), use
1710         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
1711
1712         No new tests as this patch doesn't change behavior.
1713
1714         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1715         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1716         (BlackBerry::WebKit::DumpRenderTree::runTests):
1717
1718 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1719
1720         Add Windows and Linux Chromium perf bots
1721         https://bugs.webkit.org/show_bug.cgi?id=79418
1722
1723         Reviewed by Tony Chang.
1724
1725         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
1726         the dedicated perf bot slave (uses the same hardware).
1727
1728         * BuildSlaveSupport/build.webkit.org-config/config.json:
1729
1730 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
1731
1732         Undefined variable 'current' when running chromium_android.py
1733         https://bugs.webkit.org/show_bug.cgi?id=79696
1734
1735         Reviewed by Adam Barth.
1736
1737         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1738         (ChromiumAndroidDriver._read_prompt):
1739
1740 2012-02-27  Greg Billock  <gbillock@google.com>
1741
1742         Add more tests for web intents
1743         https://bugs.webkit.org/show_bug.cgi?id=79527
1744
1745         Reviewed by Adam Barth.
1746
1747         * DumpRenderTree/chromium/LayoutTestController.cpp:
1748         (LayoutTestController::LayoutTestController):
1749         (LayoutTestController::sendWebIntentResponse):
1750         * DumpRenderTree/chromium/LayoutTestController.h:
1751         (LayoutTestController):
1752         * DumpRenderTree/chromium/WebViewHost.h:
1753         (WebViewHost):
1754         (WebViewHost::currentIntentRequest):
1755
1756 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
1757
1758         Chromium-Android layout test script: the adb shell prompt is not always '# '
1759         https://bugs.webkit.org/show_bug.cgi?id=79506
1760
1761         Reviewed by Adam Barth.
1762
1763         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1764         (ChromiumAndroidDriver._start):
1765         (ChromiumAndroidDriver._read_prompt):
1766
1767 2012-02-27  Dan Bernstein  <mitz@apple.com>
1768
1769         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
1770         https://bugs.webkit.org/show_bug.cgi?id=79607
1771
1772         Reviewed by Adele Peterson.
1773
1774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1775         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
1776         (TestWebKitAPI::AcceptsFirstMouse::url):
1777         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
1778         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1779         (TestWebKitAPI::TEST_F):
1780         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
1781
1782 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1783
1784         Unreviewed. Fix make distcheck.
1785
1786         * GNUmakefile.am: Fix typo.
1787
1788 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1789
1790         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
1791
1792         Reviewed by Kenneth Rohde Christiansen..
1793
1794         * qmake/mkspecs/features/features.prf:
1795
1796 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
1797
1798         Add a ChromiumGpuAndroid port.
1799         https://bugs.webkit.org/show_bug.cgi?id=79628
1800
1801         Reviewed by Adam Barth.
1802
1803         Android does have a gpu port, so revert r107697.
1804
1805         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1806         (ChromiumAndroidPort.__init__):
1807         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1808         (ChromiumGpuAndroidPort):
1809         (ChromiumGpuAndroidPort.__init__):
1810         (ChromiumGpuAndroidPort.baseline_search_path):
1811         (ChromiumGpuAndroidPort.default_child_processes):
1812         (ChromiumGpuAndroidPort.tests):
1813         * Scripts/webkitpy/layout_tests/port/factory.py:
1814         (PortFactory):
1815
1816 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1817
1818         Change Build bot with BuildAndTest bot for EFL port.
1819         https://bugs.webkit.org/show_bug.cgi?id=77518
1820
1821         Reviewed by Ryosuke Niwa.
1822
1823         EFL build bot starts to support layout test.
1824
1825         * BuildSlaveSupport/build.webkit.org-config/config.json:
1826         * BuildSlaveSupport/built-product-archive:
1827         (archiveBuiltProduct):
1828         (extractBuiltProduct):
1829         * BuildSlaveSupport/test-result-archive:
1830         (archiveTestResults):
1831         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
1832         (generateBuildSystemFromCMakeProject):
1833
1834 2012-02-24  Darin Fisher  <darin@chromium.org>
1835
1836         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
1837
1838         Reviewed by James Robinson.
1839
1840         * Scripts/webkitpy/common/config/watchlist:
1841
1842 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1843
1844         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
1845         https://bugs.webkit.org/show_bug.cgi?id=79258
1846
1847         Reviewed by Ryosuke Niwa.
1848
1849         Split the fuzzy matching into separate functions so that they
1850         can be sharded and run in parallel.
1851
1852         Also, fix a bug in the svn_blame_regexp that was causing us
1853         to require ChangeLog lines to have at least one space after the
1854         author, making the code require trailing whitespace in the
1855         changelog in some places (this was making my life harder because
1856         I have my text editor set to strip trailing whitespace in python
1857         files, and that was causing test_parse_log_entries_from_changelog() to fail
1858         when the whitespace on line 275 was removed).
1859
1860         * Scripts/webkitpy/common/checkout/changelog.py:
1861         (ChangeLog):
1862         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1863         (test_fuzzy_reviewer_match__none):
1864         (test_fuzzy_reviewer_match_adam_barth):
1865         (test_fuzzy_reviewer_match_darin_adler_et_al):
1866         (test_fuzzy_reviewer_match_dimitri_glazkov):
1867         (test_fuzzy_reviewer_match_george_staikos):
1868         (test_fuzzy_reviewer_match_mark_rowe):
1869
1870 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1871
1872         webkitpy: committers_unittest fuzzy matching is really slow
1873         https://bugs.webkit.org/show_bug.cgi?id=79179
1874
1875         Reviewed by Ryosuke Niwa.
1876
1877         Break the fuzzy matching tests into individual routines for
1878         each contributor so that the intent is a little clearer, so
1879         that it's easier to test individual names (and identify
1880         duplicate tests), and so that we can eventually run
1881         them in parallel.
1882
1883         Also, mark most of them as 'integration' tests so that they
1884         can be skipped if we want to go fast (we leave a few as
1885         regular tests for functional coverage).
1886
1887         * Scripts/webkitpy/common/config/committers_unittest.py:
1888         (CommittersTest):
1889         (CommittersTest.test_contributors_by_fuzzy_match):
1890         (CommittersTest.integration_test_contributors__none):
1891         (CommittersTest.integration_test_contributors__none_2):
1892         (CommittersTest.integration_test_contributors__none_3):
1893         (CommittersTest.integration_test_contributors_ada_chan):
1894         (CommittersTest.integration_test_contributors_adele_peterson):
1895         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
1896         (CommittersTest.integration_test_contributors_alice_liu):
1897         (CommittersTest.integration_test_contributors_alp_toker):
1898         (CommittersTest.integration_test_contributors_anders_carlsson):
1899         (CommittersTest.integration_test_contributors_antti_koivisto):
1900         (CommittersTest.integration_test_contributors_beth_dakin):
1901         (CommittersTest.integration_test_contributors_brady_eidson):
1902         (CommittersTest.integration_test_contributors_cameron_zwarich):
1903         (CommittersTest.integration_test_contributors_chris_blumenberg):
1904         (CommittersTest.integration_test_contributors_dan_bernstein):
1905         (CommittersTest.integration_test_contributors_dan_bernstein_2):
1906         (CommittersTest.integration_test_contributors_darin_adler):
1907         (CommittersTest.integration_test_contributors_david_harrison):
1908         (CommittersTest.integration_test_contributors_david_harrison_2):
1909         (CommittersTest.integration_test_contributors_david_hyatt):
1910         (CommittersTest.integration_test_contributors_david_kilzer):
1911         (CommittersTest.integration_test_contributors_don_melton):
1912         (CommittersTest.integration_test_contributors_eric_seidel):
1913         (CommittersTest.integration_test_contributors_geoffrey_garen):
1914         (CommittersTest.integration_test_contributors_greg_bolsinga):
1915         (CommittersTest.integration_test_contributors_holger_freyther):
1916         (CommittersTest.integration_test_contributors_jon_sullivan):
1917         (CommittersTest.integration_test_contributors_jon_honeycutt):
1918         (CommittersTest.integration_test_contributors_joseph_pecoraro):
1919         (CommittersTest.integration_test_contributors_ken_kocienda):
1920         (CommittersTest.integration_test_contributors_kenneth_russell):
1921         (CommittersTest.integration_test_contributors_kevin_decker):
1922         (CommittersTest.integration_test_contributors_kevin_mccullough):
1923         (CommittersTest.integration_test_contributors_lars_knoll):
1924         (CommittersTest.integration_test_contributors_lars_weintraub):
1925         (CommittersTest.integration_test_contributors_maciej_stachowiak):
1926         (CommittersTest.integration_test_contributors_mark_rowe):
1927         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
1928         (CommittersTest.integration_test_contributors_oliver_hunt):
1929         (CommittersTest.integration_test_contributors_rniwa):
1930         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
1931         (CommittersTest.integration_test_contributors_steve_falkenburg):
1932         (CommittersTest.integration_test_contributors_sam_weinig):
1933         (CommittersTest.integration_test_contributors_tim_omernick):
1934         (CommittersTest.integration_test_contributors_timothy_hatcher):
1935         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
1936         (CommittersTest.integration_test_contributors_vicki_murley):
1937         (CommittersTest.integration_test_contributors_zack_rusin):
1938
1939 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1940
1941         webkitpy: should autoinstall coverage
1942         https://bugs.webkit.org/show_bug.cgi?id=79535
1943
1944         Reviewed by Eric Seidel.
1945
1946         We should automatically print the coverage report after the run, too.
1947
1948         * Scripts/webkitpy/test/main.py:
1949         (Tester._run_tests):
1950         * Scripts/webkitpy/thirdparty/__init__.py:
1951         (AutoinstallImportHook.find_module):
1952         (AutoinstallImportHook._install_coverage):
1953
1954 2012-02-24  Pablo Flouret  <pablof@motorola.com>
1955
1956         Fix copypasta in build-webkit's --vibration option description
1957         https://bugs.webkit.org/show_bug.cgi?id=79528
1958
1959         Reviewed by Andreas Kling.
1960
1961         * Scripts/build-webkit:
1962
1963 2012-02-24  Antonio Gomes  <agomes@rim.com>
1964
1965         Adding myself to ScrollingCoordinator watchlist
1966         https://bugs.webkit.org/show_bug.cgi?id=79525
1967
1968         Reviewed by Rob Buis.
1969
1970         * Scripts/webkitpy/common/config/watchlist:
1971
1972 2012-02-24  Darin Fisher  <darin@chromium.org>
1973
1974         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
1975
1976         Reviewed by Adam Barth.
1977
1978         * Scripts/webkitpy/common/config/watchlist:
1979
1980 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
1981
1982         webkitpy: config_unittest is sensitive to other tests that might've already run
1983         https://bugs.webkit.org/show_bug.cgi?id=79382
1984
1985         Reviewed by Adam Barth.
1986
1987         If another test runs prior to config_unittest and pokes the
1988         cached configuration, the first test in config_unittest might
1989         fail; the tearDown() will then allow subsequent tests to pass.
1990         Clearing the configuration prior to each test makes things
1991         slightly slower but safer.
1992
1993         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1994         (ConfigTest.setUp):
1995
1996 2012-02-24  David Kilzer  <ddkilzer@apple.com>
1997
1998         Use xcrun to find compiler paths for Generate Derived Sources build phase script
1999         <http://webkit.org/b/79512>
2000
2001         Reviewed by Dan Bernstein.
2002
2003         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2004         (Generate Derived Sources): Use xcrun to find the path to the
2005         compiler since that works on both iOS and OS X.
2006
2007 2012-02-24  James Robinson  <jamesr@chromium.org>
2008
2009         Create a watchlist for ScrollingCoordinator changes
2010         https://bugs.webkit.org/show_bug.cgi?id=79511
2011
2012         Reviewed by Anders Carlsson.
2013
2014         * Scripts/webkitpy/common/config/watchlist:
2015
2016 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2017
2018         [EFL][DRT] Implement setValueForUser and setAutofilled.
2019         https://bugs.webkit.org/show_bug.cgi?id=79237
2020
2021         Reviewed by Andreas Kling.
2022
2023         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
2024         Those implementations are related with input fields and allow to pass following tests:
2025         fast/forms/onchange-setvalueforuser.html
2026         fast/forms/input-autofilled.html
2027         fast/forms/reset-autofilled.html
2028
2029         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2030         (LayoutTestController::setValueForUser):
2031         (LayoutTestController::setAutofilled):
2032
2033 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
2034
2035         [Qt] Allow to use WebCore imagedecoders
2036         https://bugs.webkit.org/show_bug.cgi?id=32410
2037
2038         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2039
2040         Reviewed by Simon Hausmann.
2041
2042         * qmake/mkspecs/features/features.prf:
2043
2044 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
2045
2046         [Qt] Add Qt5 way to force 96 DPI for tests
2047         https://bugs.webkit.org/show_bug.cgi?id=79364
2048
2049         Reviewed by Simon Hausmann.
2050
2051         * DumpRenderTree/qt/main.cpp:
2052         (main):
2053         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2054         (WTR::activateFonts):
2055
2056 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2057
2058         [GTK] MiniBrowser should reload the view then the reload button is clicked
2059         https://bugs.webkit.org/show_bug.cgi?id=79472
2060
2061         Reviewed by Philippe Normand.
2062
2063         * MiniBrowser/gtk/BrowserWindow.c:
2064         (reloadCallback): Call webkit_web_view_reload().
2065         (browser_window_init): Connect reload item clicked even to
2066         reloadCallback instead of activateUriEntryCallback.
2067
2068 2012-02-24  Kentaro Hara  <haraken@chromium.org>
2069
2070         Add performance tests for DOM attribute getters and setters
2071         https://bugs.webkit.org/show_bug.cgi?id=79208
2072
2073         Reviewed by Ryosuke Niwa.
2074
2075         We want to allow perf tests to output info messages
2076         that do not affect the test results. To accomplish this,
2077         this patch modifies perftestsrunner.py so that it ignores
2078         a line that starts from "Info:".
2079
2080         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2081         (PerfTestsRunner):
2082
2083 2012-02-24  Andrew Lo  <anlo@rim.com>
2084
2085         [BlackBerry] Enable requestAnimationFrame
2086         https://bugs.webkit.org/show_bug.cgi?id=79408
2087
2088         Enable requestAnimationFrame for BlackBerry.
2089
2090         Reviewed by Rob Buis.
2091
2092         * Scripts/build-webkit:
2093
2094 2012-02-24  Adam Barth  <abarth@webkit.org>
2095
2096         style-queue tries to apply the patch twice
2097         https://bugs.webkit.org/show_bug.cgi?id=79459
2098
2099         Reviewed by Eric Seidel.
2100
2101         Previously, we applied the patch using both apply-patch and
2102         check-style.  This patch introduces a check-style-local to mirror the
2103         apply-watchlist-local, which operates on the current working diff.
2104
2105         This patch also cleans up some other bugs I found by running the queue
2106         locally for a while.  The queue still prints out a slightly
2107         less-than-ideal message on the bugs when it find an error, but it's ok
2108         for now.  We'll need to iterate a bit.
2109
2110         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2111         (StyleQueueTask.validate):
2112         (StyleQueueTask._check_style):
2113         * Scripts/webkitpy/tool/commands/download.py:
2114         (CheckStyleLocal):
2115         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2116         (EarlyWarningSytemTest._default_expected_stderr):
2117         (EarlyWarningSytemTest._test_testing_ews):
2118         * Scripts/webkitpy/tool/commands/queues.py:
2119         (AbstractReviewQueue.handle_script_error):
2120         (StyleQueue.review_patch):
2121         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2122         * Scripts/webkitpy/tool/commands/queuestest.py:
2123         (QueuesTest.assert_queue_outputs):
2124
2125 2012-02-23  Adam Barth  <abarth@webkit.org>
2126
2127         should_proceed_with_work_item is unused and can be removed
2128         https://bugs.webkit.org/show_bug.cgi?id=79416
2129
2130         Reviewed by Eric Seidel.
2131
2132         We used to use this function to check whether the tree is red.  Now, we
2133         don't use external measures of whether to proceed with work items.
2134         Instead, we analyze them with the idea in mind that the tree might be
2135         red.
2136
2137         * Scripts/webkitpy/tool/bot/queueengine.py:
2138         (QueueEngineDelegate.next_work_item):
2139         (QueueEngine.run):
2140         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2141         (LoggingDelegate):
2142         (LoggingDelegate.next_work_item):
2143         (RaisingDelegate.process_work_item):
2144         (QueueEngineTest.test_terminating_error):
2145         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2146         (AbstractEarlyWarningSystem.__init__):
2147         * Scripts/webkitpy/tool/commands/queues.py:
2148         (AbstractQueue.next_work_item):
2149         (FeederQueue.next_work_item):
2150         (CommitQueue.next_work_item):
2151         (AbstractReviewQueue.next_work_item):
2152         (StyleQueue.__init__):
2153         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2154         (FeederQueueTest.test_feeder_queue):
2155         (CommitQueueTest.test_commit_queue):
2156         (test_commit_queue_failure):
2157         (test_commit_queue_failure_with_failing_tests):
2158         (test_rollout):
2159         (test_rollout_lands):
2160         (StyleQueueTest.test_style_queue_with_style_exception):
2161         (test_style_queue_with_watch_list_exception):
2162         * Scripts/webkitpy/tool/commands/queuestest.py:
2163         (QueuesTest.assert_queue_outputs):
2164         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2165         (SheriffBot.next_work_item):
2166
2167 2012-02-23  Adrienne Walker  <enne@google.com>
2168
2169         Unreviewed, add Stephen Chenney to committers.py as a contributor.
2170
2171         * Scripts/webkitpy/common/config/committers.py:
2172
2173 2012-02-23  Adam Barth  <abarth@webkit.org>
2174
2175         style-queue logs bogus messages to the QueueStatusServer
2176         https://bugs.webkit.org/show_bug.cgi?id=79424
2177
2178         Reviewed by Eric Seidel.
2179
2180         Copy/paste error.
2181
2182         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2183         (StyleQueueTask._check_style):
2184         (StyleQueueTask._apply_watch_list):
2185         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2186
2187 2012-02-23  Eric Seidel  <eric@webkit.org>
2188
2189         Use self._filesystem in more places in the SCM classes
2190         https://bugs.webkit.org/show_bug.cgi?id=79415
2191
2192         Reviewed by Adam Barth.
2193
2194         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2195         (SCMDetectorTest.test_detect_scm_system):
2196         * Scripts/webkitpy/common/checkout/scm/git.py:
2197         (Git.find_checkout_root):
2198         (Git.to_object_name):
2199         * Scripts/webkitpy/common/checkout/scm/scm.py:
2200         (SCM.__init__):
2201         (SCM.in_working_directory):
2202         * Scripts/webkitpy/common/checkout/scm/svn.py:
2203         (SVN.find_uuid):
2204         (SVN.find_checkout_root):
2205
2206 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2207
2208         Unreviewed, rolling out r108685.
2209         http://trac.webkit.org/changeset/108685
2210         https://bugs.webkit.org/show_bug.cgi?id=79414
2211
2212         Broke Chromium builds (Requested by enne on #webkit).
2213
2214         * qmake/mkspecs/features/features.prf:
2215
2216 2012-02-23  Adam Barth  <abarth@webkit.org>
2217
2218         style-queue shouldn't spam bugs if it fails to update its working copy
2219         https://bugs.webkit.org/show_bug.cgi?id=79412
2220
2221         Reviewed by Eric Seidel.
2222
2223         This patch moves style-queue over to the new PatchAnalysisTask
2224         infrastructure, which is smarter about retrying patches when update
2225         fails.
2226
2227         * Scripts/webkitpy/common/system/executive_mock.py:
2228         (MockExecutive.run_and_throw_if_fail):
2229         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2230         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2231         (UnableToApplyPatch):
2232         (UnableToApplyPatch.__init__):
2233         (PatchAnalysisTask.__init__):
2234         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
2235         (StyleQueueTaskDelegate):
2236         (StyleQueueTaskDelegate.parent_command):
2237         (StyleQueueTask):
2238         (StyleQueueTask.validate):
2239         (StyleQueueTask._check_style):
2240         (StyleQueueTask._apply_watch_list):
2241         (StyleQueueTask.run):
2242         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2243         * Scripts/webkitpy/tool/commands/queues.py:
2244         (StyleQueue):
2245         (StyleQueue.should_proceed_with_work_item):
2246         (StyleQueue.review_patch):
2247         (StyleQueue.run_command):
2248         (StyleQueue.command_passed):
2249         (StyleQueue.command_failed):
2250         (StyleQueue.expected_failures):
2251         (StyleQueue.refetch_patch):
2252         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2253         (StyleQueueTest.test_style_queue_with_style_exception):
2254         (test_style_queue_with_watch_list_exception):
2255
2256 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
2257
2258         [Qt] Allow to use WebCore imagedecoders
2259         https://bugs.webkit.org/show_bug.cgi?id=32410
2260
2261         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
2262
2263         Reviewed by Simon Hausmann.
2264
2265         * qmake/mkspecs/features/features.prf:
2266
2267 2012-02-23  Eric Seidel  <eric@webkit.org>
2268
2269         Remove old broken find_checkout_root tests now that find_checkout_root is gone
2270         https://bugs.webkit.org/show_bug.cgi?id=79405
2271
2272         Reviewed by Adam Barth.
2273
2274         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
2275         (SCMDetectorTest):
2276         (SCMDetectorTest.test_find_checkout_root):
2277         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2278         (SVNTestRepository.tear_down):
2279
2280 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
2281
2282         [Qt][WK2] Implement proxy authentication dialog.
2283         https://bugs.webkit.org/show_bug.cgi?id=79350
2284
2285         Reviewed by Simon Hausmann.
2286
2287         * MiniBrowser/qt/MiniBrowser.qrc:
2288         * MiniBrowser/qt/qml/BrowserWindow.qml:
2289         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
2290
2291 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
2292
2293         [wx] Build fix, add recently added source dirs.
2294
2295         * waf/build/settings.py:
2296
2297 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
2298
2299         [Qt] Add support for touch cancellation
2300         https://bugs.webkit.org/show_bug.cgi?id=79348
2301
2302         Reviewed by Kenneth Rohde Christiansen.
2303
2304         Added straight-forward touch cancellation event sending to Qt WK1 DRT
2305         and WK2 WTR.
2306
2307         * DumpRenderTree/qt/EventSenderQt.cpp:
2308         (EventSender::touchCancel):
2309         (EventSender::cancelTouchPoint):
2310         * DumpRenderTree/qt/EventSenderQt.h:
2311         (EventSender):
2312         * WebKitTestRunner/EventSenderProxy.h:
2313         (EventSenderProxy):
2314         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2315         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2316         (WTR::EventSendingController::touchCancel):
2317         (WTR):
2318         (WTR::EventSendingController::cancelTouchPoint):
2319         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2320         (EventSendingController):
2321         * WebKitTestRunner/TestController.cpp:
2322         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2323         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2324         (WTR::EventSenderProxy::touchCancel):
2325         (WTR):
2326         (WTR::EventSenderProxy::cancelTouchPoint):
2327
2328 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2329
2330         Unreviewed, rolling out r108626.
2331         http://trac.webkit.org/changeset/108626
2332         https://bugs.webkit.org/show_bug.cgi?id=79370
2333
2334         broke qt-wk2 bot, somehow the workaround does not work on the
2335         bot (Requested by Ossy on #webkit).
2336
2337         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2338         (WTR::WrapperWindow::handleStatusChanged):
2339         (WTR::PlatformWebView::resizeTo):
2340
2341 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
2342
2343         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
2344         https://bugs.webkit.org/show_bug.cgi?id=78481
2345
2346         Reviewed by Gustavo Noronha Silva.
2347
2348         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
2349         to create gdk press key event.
2350         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2351         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2352
2353         * DumpRenderTree/gtk/EventSender.cpp:
2354         (scheduleAsynchronousClickCallback):
2355         (createKeyPressEvent):
2356         (sendKeyDown):
2357         (keyDownCallback):
2358         (sendAsynchronousKeyDown):
2359         (scheduleAsynchronousKeyDownCallback):
2360
2361 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
2362
2363         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
2364         https://bugs.webkit.org/show_bug.cgi?id=76546
2365
2366         Reviewed by Simon Hausmann.
2367
2368         Co-authored with Simon Hausmann.
2369
2370         Revert the workaround introduced in r107868 and reintroduce
2371         the qml binding so we can test the code path that we are more
2372         interested in. The reason that it did not work before is that
2373         we don't have an active platform window which we now workaround
2374         by propagating the resize through QWindowSystemInterface.
2375
2376         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2377         (WTR::WrapperWindow::handleStatusChanged):
2378         (WTR::PlatformWebView::resizeTo):
2379
2380 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2381
2382         Unreviewed, rolling out r108577.
2383         http://trac.webkit.org/changeset/108577
2384         https://bugs.webkit.org/show_bug.cgi?id=79359
2385
2386         It doesn't work as expected (Requested by Ossy on #webkit).
2387
2388         * DumpRenderTree/qt/EventSenderQt.cpp:
2389         (EventSender::postEvent):
2390         * DumpRenderTree/qt/EventSenderQt.h:
2391         (EventSender):
2392
2393 2012-02-23  Philippe Normand  <pnormand@igalia.com>
2394
2395         [GTK] FullScreen signals
2396         https://bugs.webkit.org/show_bug.cgi?id=76181
2397
2398         Reviewed by Martin Robinson.
2399
2400         Use the two new entering/leaving fullscreen signals to hide/show
2401         the tool bar, the status bar and ask the user's permission before
2402         entering fullscreen.
2403
2404         * GtkLauncher/main.c:
2405         (webViewFullscreenMessageWindowClose):
2406         (webViewWindowStateEvent):
2407         (hide_widget):
2408         (show_widget):
2409         (webViewEnteringFullScreen):
2410         (webViewLeavingFullScreen):
2411         (createBrowser):
2412         (createWindow):
2413
2414 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
2415
2416         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
2417         https://bugs.webkit.org/show_bug.cgi?id=79076
2418
2419         Reviewed by Andreas Kling.
2420
2421         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
2422         (builtDylibPathForName):
2423
2424 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2425
2426         [Qt] Add eventSender.gestureTap
2427         https://bugs.webkit.org/show_bug.cgi?id=66173
2428
2429         Reviewed by Kenneth Rohde Christiansen.
2430
2431         * DumpRenderTree/qt/EventSenderQt.cpp:
2432         (EventSender::gestureTap):
2433         * DumpRenderTree/qt/EventSenderQt.h:
2434
2435 2012-02-22  Brady Eidson  <beidson@apple.com>
2436
2437         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
2438         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
2439
2440         Reviewed by Anders Carlsson.
2441
2442         Update our tools to the new form of the PageLoadClient.
2443
2444         * MiniBrowser/mac/BrowserWindowController.m:
2445         (-[BrowserWindowController awakeFromNib]): 
2446
2447         * WebKitTestRunner/TestController.cpp:
2448         (WTR::TestController::initialize):
2449
2450 2012-02-22  Daniel Bates  <dbates@webkit.org>
2451
2452         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
2453         https://bugs.webkit.org/show_bug.cgi?id=79277
2454
2455         Reviewed by Adam Barth.
2456
2457         Pass command line argument no-saved-state to run-safari to disable Safari
2458         state restoration for the session on OS 10.7.
2459
2460         * Scripts/webkitpy/layout_tests/port/mac.py:
2461         (MacPort.show_results_html_file):
2462         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2463         (test_show_results_html_file):
2464
2465 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
2466
2467         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
2468         https://bugs.webkit.org/show_bug.cgi?id=77759
2469
2470         Reviewed by Tony Chang.
2471
2472         Fixes build with gcc 4.7.
2473
2474         r100432 added the include only for ANDROID; this changes the ifdef to
2475         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
2476         longer implicitly includes unistd.h from standard headers and other
2477         unix platforms are likely to get gcc 4.7 as well in the future.
2478
2479         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2480
2481 2012-02-22  Philippe Normand  <pnormand@igalia.com>
2482
2483         Unreviewed, rolling out r108522.
2484         http://trac.webkit.org/changeset/108522
2485         https://bugs.webkit.org/show_bug.cgi?id=76181
2486
2487         Broke 4 fullscreen tests on GTK.
2488
2489         * GtkLauncher/main.c:
2490         (createBrowser):
2491         (createWindow):
2492
2493 2012-02-20  Philippe Normand  <pnormand@igalia.com>
2494
2495         [GTK] FullScreen signals
2496         https://bugs.webkit.org/show_bug.cgi?id=76181
2497
2498         Reviewed by Martin Robinson.
2499
2500         Use the two new entering/leaving fullscreen signals to hide/show
2501         the tool bar, the status bar and ask the user's permission before
2502         entering fullscreen.
2503
2504         * GtkLauncher/main.c:
2505         (webViewFullscreenMessageWindowClose):
2506         (webViewWindowStateEvent):
2507         (hide_widget):
2508         (show_widget):
2509         (webViewEnteringFullScreen):
2510         (webViewLeavingFullScreen):
2511         (createBrowser):
2512         (createWindow):
2513
2514 2012-02-22  Rob Flack  <flackr@chromium.org>
2515
2516         Update Linux ChromiumOS builders in flakiness dashboard.
2517         https://bugs.webkit.org/show_bug.cgi?id=79238
2518
2519         Reviewed by Ojan Vafai.
2520
2521         * TestResultServer/static-dashboards/builders.js:
2522
2523 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
2524
2525         webkitpy: test_function_length_check_definition_huge_lines is slow
2526         https://bugs.webkit.org/show_bug.cgi?id=79185
2527
2528         Reviewed by Adam Barth.
2529
2530         This test takes ~3 seconds to run, apparently because we're
2531         running a test on a 10,000 line function :). Dropping the
2532         function length to 640 still exercises the code path and
2533         provides a 10x speedup.
2534
2535         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2536         (CppStyleTest):
2537         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
2538
2539 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
2540
2541         webkitpy: speed up FileLockTest.test_lock_lifecycle
2542         https://bugs.webkit.org/show_bug.cgi?id=79189
2543
2544         Reviewed by Adam Barth.
2545
2546         The unit test had a second lock trying to acquire a
2547         lock already held, and a hard-coded timeout of one second.
2548         I have changed the timeouts to a tenth of a second (which
2549         is probably still fine) and changed the hard-spin on
2550         the lock to a slow-spin every hundredth of a second.
2551
2552         * Scripts/webkitpy/common/system/file_lock.py:
2553         (FileLock.acquire_lock):
2554         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2555         (FileLockTest.setUp):
2556         (FileLockTest.test_stuck_lock):
2557
2558 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
2559
2560         build-webkit should use environment variable at number of CPU
2561         detection on all platform
2562         https://bugs.webkit.org/show_bug.cgi?id=79227
2563
2564         Reviewed by Martin Robinson.
2565
2566         * Scripts/webkitdirs.pm:
2567         (determineNumberOfCPUs):
2568
2569 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
2570
2571         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
2572         https://bugs.webkit.org/show_bug.cgi?id=78960
2573
2574         Reviewed by Csaba Osztrogonác.
2575
2576         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2577         (LayoutTestController::overridePreference):
2578
2579 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
2580
2581         [chromium] Build WebKit with MEDIA_STREAM disabled.
2582         https://bugs.webkit.org/show_bug.cgi?id=79214
2583
2584         Reviewed by Kent Tamura.
2585
2586         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
2587         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
2588         * DumpRenderTree/chromium/WebViewHost.cpp:
2589         (WebViewHost::createMediaPlayer):
2590         * DumpRenderTree/chromium/WebViewHost.h:
2591         (WebViewHost):
2592
2593 2012-02-22  Zeno Albisser  <zeno@webkit.org>
2594
2595         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
2596         https://bugs.webkit.org/show_bug.cgi?id=79124
2597
2598         WebKitTestRunnerPrefix.h should also be included
2599         when building with clang.
2600
2601         Reviewed by Kenneth Rohde Christiansen.
2602
2603         * WebKitTestRunner/Target.pri:
2604
2605 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
2606
2607         <style scoped>: Add runtime-flag
2608         https://bugs.webkit.org/show_bug.cgi?id=79074
2609
2610         Enable the runtime-flag for DRT. 
2611
2612         Reviewed by Dimitri Glazkov.
2613
2614         * DumpRenderTree/chromium/TestShell.cpp:
2615         (TestShell::TestShell):
2616
2617 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2618
2619         Unreviewed, rolling out r107351.
2620         http://trac.webkit.org/changeset/107351
2621         https://bugs.webkit.org/show_bug.cgi?id=53600
2622
2623         Several issues introduced in WebKitGTK+ API
2624
2625         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2626         (createWebView):
2627         * GtkLauncher/main.c:
2628         (createWebViewCb):
2629         (createBrowser):
2630         (createWindow):
2631         (main):
2632
2633 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
2634
2635         JSC should be a triple-tier VM
2636         https://bugs.webkit.org/show_bug.cgi?id=75812
2637         <rdar://problem/10079694>
2638
2639         Reviewed by Gavin Barraclough.
2640
2641         Changed EFL's build system to include a new directory in JavaScriptCore.
2642
2643         * DumpRenderTree/efl/CMakeLists.txt:
2644
2645 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
2646
2647         [chromium] Fix image drag out on Chromium
2648         https://bugs.webkit.org/show_bug.cgi?id=79158
2649
2650         Reviewed by Tony Chang.
2651
2652         * DumpRenderTree/chromium/EventSender.cpp:
2653         (EventSender::dumpFilenameBeingDragged):
2654         (EventSender::beginDragWithFiles):
2655         * DumpRenderTree/chromium/WebViewHost.cpp:
2656         (addDRTFakeFileToDataObject):
2657
2658 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2659
2660         webkitpy: speed up hot filesystem_mock functions
2661         https://bugs.webkit.org/show_bug.cgi?id=79159
2662
2663         Reviewed by Adam Barth.
2664
2665         Profiling run_webkit_tests_integrationtest.py revealed that
2666         isdir(), normpath(), and join() are called a lot and were very
2667         slow.This patch speeds them up substantially, shaving 20 seconds
2668         off of the execution time.
2669
2670         * Scripts/webkitpy/common/system/filesystem_mock.py:
2671         (MockFileSystem.isdir):
2672         (MockFileSystem._slow_but_correct_join):
2673         (MockFileSystem.join):
2674         (MockFileSystem.listdir):
2675         (MockFileSystem._slow_but_correct_normpath):
2676         (MockFileSystem.normpath):
2677         (MockFileSystem.write_binary_file):
2678         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2679         (MockFileSystemTest.quick_check):
2680         (MockFileSystemTest):
2681         (MockFileSystemTest.test_join):
2682         (MockFileSystemTest.test_normpath):
2683         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2684         (get_test_config): Call write_binary_file() instead of updating
2685           filesystem.files directly, so that we create directories as
2686           needed.
2687
2688 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2689
2690         nrwt: make the delay between starting workers configurable per-port
2691         https://bugs.webkit.org/show_bug.cgi?id=79148
2692
2693         Reviewed by Eric Seidel.
2694
2695         Because of bug 79147, we have to sleep a bit in between starting
2696         DRTs; however, doing so across the board slows down the Test
2697         port. Making this configurable shaves 10 seconds off of
2698         run_webkit_tests_integrationtest.py
2699         
2700         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2701         (Manager._run_tests):
2702         * Scripts/webkitpy/layout_tests/port/base.py:
2703         (Port.worker_startup_delay_secs):
2704         * Scripts/webkitpy/layout_tests/port/test.py:
2705         (TestPort.worker_startup_delay_secs):
2706
2707 2012-02-21  Jon Lee  <jonlee@apple.com>
2708
2709         Bring notifications support to WK1 mac
2710         https://bugs.webkit.org/show_bug.cgi?id=78783
2711         <rdar://problem/10610578>
2712
2713         Reviewed by Anders Carlsson.
2714
2715         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
2716         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2717         (-[UIDelegate timerFired]):
2718
2719 2012-02-21  Kentaro Hara  <haraken@chromium.org>
2720
2721         Enable the IDL attribute checker in run-bindings-tests
2722         https://bugs.webkit.org/show_bug.cgi?id=79091
2723
2724         Reviewed by Adam Barth.
2725
2726         We have enabled the IDL attribute checker in Chromium in r108322.
2727         This patch enables the IDL attribute checker in run-bindings-tests.
2728
2729         No tests. I manually checked that [Custommm], [CallWith=],
2730         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
2731         run-bindings-tests failures.
2732
2733         * Scripts/webkitpy/bindings/main.py:
2734         (BindingsTests.generate_supplemental_dependency):
2735
2736 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
2737
2738         Add rafaelw as a committer.
2739
2740         Unreviewed.
2741
2742         * Scripts/webkitpy/common/config/committers.py:
2743
2744 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2745
2746         webkitpy: update names after deleting message_broker
2747         https://bugs.webkit.org/show_bug.cgi?id=79000
2748
2749         Reviewed by Eric Seidel.
2750
2751         Part 3 of 3 in deleting message_broker.py; this change just
2752         adjusts the names for the newly merged symbols so that they are
2753         private as appropriate.
2754
2755         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2756         (get):
2757         (_Broker):
2758         (_BrokerConnection):
2759         (_BrokerConnection.__init__):
2760         (AbstractWorker.__init__):
2761         (_ManagerConnection):
2762         (_ManagerConnection.__init__):
2763         (_WorkerConnection):
2764         (_WorkerConnection.__init__):
2765
2766 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2767
2768         webkitpy: merge message_broker.py into manager_worker_broker.py
2769         https://bugs.webkit.org/show_bug.cgi?id=78999
2770
2771         Reviewed by Tony Chang.
2772
2773         This is pretty much a straight cut-and-paste of one file into
2774         another (broken up so that docstrings and imports are in the
2775         right place).
2776
2777         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2778         (BrokerClient):
2779         (BrokerClient.is_done):
2780         (BrokerClient.name):
2781         (Broker):
2782         (Broker.__init__):
2783         (Broker.add_topic):
2784         (Broker._get_queue_for_topic):
2785         (Broker.post_message):
2786         (Broker.run_message_loop):
2787         (Broker.run_all_pending):
2788         (Broker._run_loop):
2789         (Broker._dispatch_message):
2790         (_Message):
2791         (_Message.loads):
2792         (_Message.__init__):
2793         (_Message.dumps):
2794         (_Message.__repr__):
2795         (BrokerConnection):
2796         (BrokerConnection.__init__):
2797         (BrokerConnection.run_message_loop):
2798         (BrokerConnection.post_message):
2799         (BrokerConnection.raise_exception):
2800         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
2801
2802 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
2803
2804         webkitpy: prepare to delete message_broker.py
2805         https://bugs.webkit.org/show_bug.cgi?id=78997
2806
2807         Reviewed by Eric Seidel.
2808
2809         This is part 1 of 3 changes to fix bug 78187. This change
2810         prepares the code for merging message_broker.py into
2811         manager_worker_broker.py; the tests in message_broker_unittest
2812         are merged into manager_worker_broker_unittest, the symbols
2813         needed by the tests are exported from manager_worker_broker.py,
2814         and manager_worker_broker itself is updated to refer to the
2815         symbols directly (without the module prefix).
2816
2817         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2818         (get):
2819         (AbstractWorker):
2820         (AbstractWorker.__init__):
2821         (_ManagerConnection):
2822         (_ManagerConnection.__init__):
2823         (_WorkerConnection):
2824         (_WorkerConnection.__init__):
2825         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2826         (InterfaceTest.test_brokerclient_is_abstract):
2827         (InterfaceTest.test_brokerclient_is_abstract.methods):
2828         (MessageTest):
2829         (MessageTest.test__no_body):
2830         (MessageTest.test__body):
2831         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
2832
2833 2012-02-21  Sam Weinig  <sam@webkit.org>
2834
2835         Attempt to fix the Snow Leopard build.
2836
2837         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2838         * MiniBrowser/Configurations/Base.xcconfig:
2839         * TestWebKitAPI/Configurations/Base.xcconfig:
2840         * WebKitTestRunner/Configurations/Base.xcconfig:
2841
2842 2012-02-21  Sam Weinig  <sam@webkit.org>
2843
2844         Use libc++ when building with Clang on Mac
2845         https://bugs.webkit.org/show_bug.cgi?id=78981
2846
2847         Reviewed by Dan Bernstein.
2848
2849         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2850         * MiniBrowser/Configurations/Base.xcconfig:
2851         * TestWebKitAPI/Configurations/Base.xcconfig:
2852         * WebKitTestRunner/Configurations/Base.xcconfig:
2853
2854 2012-02-21  Adam Roben  <aroben@apple.com>
2855
2856         Roll out r108309, r108323, and r108326
2857
2858         They broke the 32-bit Lion build.
2859
2860         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
2861
2862         * DumpRenderTree/efl/CMakeLists.txt:
2863
2864 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
2865
2866         [Qt][WK2] Get rid of the dependency to QtWidgets
2867         https://bugs.webkit.org/show_bug.cgi?id=76276
2868
2869         Reviewed by Simon Hausmann.
2870
2871         * MiniBrowser/qt/MiniBrowser.pro:
2872         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2873         (MiniBrowserApplication::MiniBrowserApplication):
2874         (MiniBrowserApplication::notify):
2875         (MiniBrowserApplication::sendTouchEvent):
2876         * MiniBrowser/qt/MiniBrowserApplication.h:
2877         (MiniBrowserApplication):
2878         * QtTestBrowser/locationedit.h:
2879         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2880         (WTR::activateFonts):
2881         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2882
2883 2012-02-20  Adam Barth  <abarth@webkit.org>
2884
2885         mastercfg_unittest.py fails without simplejson
2886         https://bugs.webkit.org/show_bug.cgi?id=79070
2887
2888         Reviewed by Csaba Osztrogonác.
2889
2890         Now that we require Python 2.6 (and higher) we can import json rather
2891         than simplejson.  We still need to use the simplejson name because
2892         that's what the master.cfg script expects.
2893
2894         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2895         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
2896
2897 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
2898
2899         JSC should be a triple-tier VM
2900         https://bugs.webkit.org/show_bug.cgi?id=75812
2901         <rdar://problem/10079694>
2902
2903         Reviewed by Gavin Barraclough.
2904
2905         Changed EFL's build system to include a new directory in JavaScriptCore.
2906
2907         * DumpRenderTree/efl/CMakeLists.txt:
2908
2909 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
2910
2911         Update pywebsocket to 0.7.2
2912         https://bugs.webkit.org/show_bug.cgi?id=79066
2913
2914         This version includes vendor-prefixed deflate-frame extension support.
2915
2916         Reviewed by Kent Tamura.
2917
2918         * Scripts/webkitpy/thirdparty/__init__.py:
2919         (AutoinstallImportHook._install_pywebsocket):
2920
2921 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2922
2923         [UNIX] Plugin information fields are not interpreted as UTF-8
2924         https://bugs.webkit.org/show_bug.cgi?id=78635
2925
2926         Reviewed by Gustavo Noronha Silva.
2927
2928         Interpret plugin metadata as UTF8 aways. This matches the behavior
2929         of Chromium and the Totem plugin.
2930
2931         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2932         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
2933
2934 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
2935
2936         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
2937         https://bugs.webkit.org/show_bug.cgi?id=78935
2938
2939         Reviewed by Gustavo Noronha Silva.
2940
2941         Move the TestNetscapePlugin headers to a more appropriate directory and update
2942         the build files to match.
2943
2944         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
2945         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
2946         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
2947         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
2948         * GNUmakefile.am: Ditto.
2949
2950 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
2951
2952         Add a new API for the Vibration API(W3C).
2953         https://bugs.webkit.org/show_bug.cgi?id=72010
2954
2955         Reviewed by Hajime Morita.
2956
2957         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
2958
2959 2012-02-20  János Badics  <dicska@gmail.com>
2960
2961         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
2962         https://bugs.webkit.org/show_bug.cgi?id=71816
2963
2964         RunQtAPITests will notify if a timeout occurs during testing.
2965         Added unittest to the master.cfg
2966
2967         Reviewed by Csaba Osztrogonác.
2968
2969         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2970         (RunQtAPITests.evaluateCommand):
2971         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2972         (RunQtAPITestsTest):
2973         (RunQtAPITestsTest.assertResults):
2974         (RunQtAPITestsTest.test_timeout):
2975         (test_success):
2976         (test_failure):
2977         (test_timeout_and_failure):
2978
2979 2012-02-20  Andy Wingo  <wingo@igalia.com>
2980
2981         Add wingo as a committer.
2982
2983         Unreviewed.
2984
2985         * Scripts/webkitpy/common/config/committers.py: Add myself to the
2986         committers list.
2987
2988 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
2989
2990         [chromium] check that we're not running multiple modal dialogs at the same time
2991         https://bugs.webkit.org/show_bug.cgi?id=78486
2992
2993         Reviewed by Kent Tamura.
2994
2995         * DumpRenderTree/chromium/TestShell.cpp:
2996         (TestShell::TestShell):
2997         * DumpRenderTree/chromium/TestShell.h:
2998         (TestShell::setIsDisplayingModalDialog):
2999         (TestShell::isDisplayingModalDialog):
3000         (TestShell):
3001         * DumpRenderTree/chromium/WebViewHost.cpp:
3002         (WebViewHost::runModal):
3003
3004 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3005
3006         Fix WebKit2GTK+ for 'make distcheck'.
3007
3008         Instead of conditionally including WebKit2 GNUmakefiles, always
3009         include them and conditionally activate the final targets.
3010
3011         * MiniBrowser/gtk/GNUmakefile.am:
3012         * WebKitTestRunner/GNUmakefile.am:
3013
3014 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3015
3016         Enable video option for EFL port in build-webkit.
3017         https://bugs.webkit.org/show_bug.cgi?id=79006
3018
3019         Reviewed by Daniel Bates.
3020
3021         * Scripts/build-webkit:
3022
3023 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
3024
3025         [EFL] Use modifier keys to execute pre-rendering.
3026         https://bugs.webkit.org/show_bug.cgi?id=77933
3027
3028         Reviewed by Chang Shu.
3029
3030         Use modifier key to execute pre-rendering instead of using reserved function keys.
3031
3032         * EWebLauncher/main.c:
3033         (on_key_down):
3034
3035 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3036
3037         Fix one more dangling reference to worker_connection.name, delete unused code.
3038
3039         Unreviewed, build fix.
3040
3041         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3042         (Manager.update):
3043         (_WorkerState.__init__):
3044
3045 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3046
3047         Add a change that should've been in r108005.
3048
3049         Unreviewed, build fix.
3050
3051         In the refactoring/cleanup in r108005 I should've changed the
3052         implementation of WorkerConnection to make it match BrokerClient
3053         (and everything else) so that objects had a name() method
3054         instead of a name property.
3055
3056         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3057         (Manager._run_tests):
3058         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3059         (_WorkerConnection.__init__):
3060         (_WorkerConnection.name):
3061         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3062         (_TestWorker.__init__):
3063         (_TestsMixin.name):
3064         (_TestsMixin.test_name):
3065         (_TestsMixin.test_cancel):
3066         (_TestsMixin.test_unknown_message):
3067
3068 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
3069
3070         webkitpy: remove webkitpy.common.array_stream
3071         https://bugs.webkit.org/show_bug.cgi?id=78952
3072
3073         Reviewed by Eric Seidel.
3074
3075         Turns out array_stream didn't really do anything that StringIO
3076         didn't do (at least as of Python 2.6). This change removes it
3077         and updates all of the callers. Where possible, I changed the
3078         test assertions in order to capture the intent more clearly,
3079         e.g., instead of calling self.assertTrue('foo' in stream.get()),
3080         we have self.assertContainsLine(stream, 'foo'), and instead of
3081         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
3082         the latter isn't that much more readable, but StringIO doesn't
3083         export an empty() method.
3084
3085         * Scripts/webkitpy/common/array_stream.py: Removed.
3086         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
3087         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3088         (passing_run):
3089         (run_and_capture):
3090         (StreamTestingMixin):
3091         (StreamTestingMixin.assertContains):
3092         (StreamTestingMixin.assertContainsLine):
3093         (StreamTestingMixin.assertEmpty):
3094         (StreamTestingMixin.assertNotEmpty):
3095         (LintTest):
3096         (LintTest.test_lint_test_files):
3097         (LintTest.test_lint_test_files__errors):
3098         (MainTest):
3099         (MainTest.test_child_process_1):
3100         (MainTest.test_child_processes_2):
3101         (MainTest.test_child_processes_min):
3102         (MainTest.test_help_printing):
3103         (MainTest.test_hung_thread):
3104         (MainTest.test_no_tests_found):
3105         (MainTest.test_no_tests_found_2):
3106         (MainTest.test_repeat_each_iterations_num_tests):
3107         (MainTest.test_test_list):
3108         (MainTest.test_unexpected_failures):
3109         (MainTest.test_worker_model__inline_with_child_processes):
3110         (MainTest.test_additional_platform_directory):
3111         (RebaselineTest):
3112         (RebaselineTest.assertBaselines):
3113         (RebaselineTest.test_reset_results):
3114         (RebaselineTest.test_missing_results):
3115         (RebaselineTest.test_new_baseline):
3116         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3117         (MeteredStream.update):
3118         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3119         (TestMeteredStream.test_regular):
3120         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3121         (TestUtilityFunctions.assertEmpty):
3122         (TestUtilityFunctions):
3123         (TestUtilityFunctions.assertNotEmpty):
3124         (TestUtilityFunctions.assertWritten):
3125         (TestUtilityFunctions.test_configure_logging):
3126         (Testprinter.assertEmpty):
3127         (Testprinter):
3128         (Testprinter.assertNotEmpty):
3129         (Testprinter.assertWritten):
3130         (Testprinter.reset):
3131         (Testprinter.get_printer):
3132         (Testprinter.test_help_printer):
3133         (Testprinter.do_switch_tests.do_helper):
3134         (Testprinter.test_print_one_line_summary):
3135         (Testprinter.test_print_test_result):
3136         (Testprinter.test_print_progress):
3137         (Testprinter.test_write_nothing):
3138         (Testprinter.test_write_misc):
3139         (Testprinter.test_write_everything):
3140         (Testprinter.test_write_verbose):
3141         (Testprinter.test_print_unexpected_results):
3142         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3143         (MainTest.assertWritten):
3144         (create_runner):
3145         (test_run_test_set):
3146         (test_run_test_set_kills_drt_per_run):
3147         (test_run_test_set_for_parser_tests):
3148         (test_run_test_set_with_json_output):
3149         (test_run_test_set_with_json_source):
3150         (test_run_test_set_with_multiple_repositories):
3151         (test_upload_json):
3152
3153 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
3154
3155         [wx] Add the WebCore/page/scrolling directory to the build dirs.
3156
3157         * waf/build/settings.py:
3158
3159 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
3160
3161         [wx] Unreviewed build fix. Don't error out or hang if we have
3162         downloaded dependencies but server update check fails.
3163
3164         * waf/build/build_utils.py:
3165         (download_if_newer):
3166
3167 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3168
3169         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
3170         https://bugs.webkit.org/show_bug.cgi?id=69444
3171
3172         Reviewed by Tony Chang.
3173
3174         Currently if a test's image checksum doesn't match the checksum
3175         in the baseline, but the images themselves match according to
3176         ImageDiff, new-run-webkit-tests ignores the problem. This is
3177         probably bad, but it's not yet clear what the right thing to do
3178         is. This patch will log a warning to stderr, at least (but the
3179         test will still pass).
3180
3181         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3182         (SingleTestRunner._compare_image):
3183         (SingleTestRunner._run_reftest):
3184         * Scripts/webkitpy/layout_tests/port/test.py:
3185         (unit_test_list):
3186         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3187
3188 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3189
3190         NRWT does not report failure for a skipped test
3191         https://bugs.webkit.org/show_bug.cgi?id=78750
3192
3193         Reviewed by Eric Seidel.
3194
3195         If a test is listed in a Skipped file and you run it anyway
3196         with --force, and the test fails, currently NRWT will print
3197         "test ran as expected"; this is confusing, because you probably
3198         expect the test to fail and yet this might lead you to think the
3199         test passed. This patch changes the expected behavior to "PASS",
3200         so tests that fail will be reported.
3201
3202         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3203         (result_was_expected):
3204         (TestExpectationParser):
3205         (TestExpectationParser.expectation_for_skipped_test):
3206         (TestExpectations):
3207         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3208         (test_add_skipped_tests):
3209         * Scripts/webkitpy/layout_tests/port/test.py:
3210         (unit_test_list): Add some tests that are expected to be in a Skipped file.
3211         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
3212
3213 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3214
3215         webkitpy: fix test code after bug 78181
3216         https://bugs.webkit.org/show_bug.cgi?id=78870
3217
3218         Reviewed by Adam Barth.
3219
3220         I forgot to update the test code as per Tony's suggestion in
3221         bug 78181 (r108005). This change does that, and in doing so
3222         it revealed a subtle bug in _InlineWorkerConnection.run() that
3223         I am fixing as part of this (_alive would not be cleared if an
3224         exception was thrown).
3225
3226         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3227         (_InlineWorkerConnection.run):
3228         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3229         (_TestWorker.__init__):
3230         (_TestWorker.handle_stop):
3231         (_TestWorker.handle_test):
3232         (_TestWorker.run):
3233         (_TestsMixin.handle_exception):
3234         (_TestsMixin.test_unknown_message):
3235
3236 2012-02-17  Adam Roben  <aroben@apple.com>
3237
3238         Mac build fix after r108119
3239
3240         * DumpRenderTree/mac/DumpRenderTree.mm:
3241         (runThread):
3242         (runPthread):
3243         (testThreadIdentifierMap):
3244         Updated to match current WTF threading APIs.
3245
3246 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
3247
3248         revert r107147 - breaks webkit-patch on Mac SL
3249         https://bugs.webkit.org/show_bug.cgi?id=78866
3250
3251         Reviewed by Adam Barth.
3252
3253         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
3254         which is the version that ships on Mac SL. Reverting this
3255         change until we no longer have to worry about that version.
3256
3257         * Scripts/webkitpy/common/system/autoinstall.py:
3258         (AutoInstaller):
3259         (AutoInstaller._extract_all): Added a comment about SL.
3260         (AutoInstaller._unzip):
3261
3262 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
3263
3264         CSS regions enabled by default
3265         https://bugs.webkit.org/show_bug.cgi?id=78525
3266
3267         Reviewed by David Hyatt.
3268
3269         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
3270         CSSRegions are still enabled by default.
3271         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
3272
3273         * DumpRenderTree/chromium/LayoutTestController.cpp:
3274         (LayoutTestController::overridePreference):
3275         * DumpRenderTree/chromium/WebPreferences.cpp:
3276         (WebPreferences::reset):
3277         (WebPreferences::applyTo):
3278         * DumpRenderTree/chromium/WebPreferences.h:
3279         (WebPreferences):
3280         * DumpRenderTree/mac/DumpRenderTree.mm:
3281         (resetDefaultsToConsistentValues):
3282
3283 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
3284
3285         Some API tests erroneously use = instead of == (causing build failures)
3286         https://bugs.webkit.org/show_bug.cgi?id=78915
3287
3288         Reviewed by Sam Weinig.
3289
3290         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3291         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
3292         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
3293
3294 2012-02-17  Peter Beverloo  <peter@chromium.org>
3295
3296         [Chromium] Include TestShellLinux.cpp in the build for Android
3297         https://bugs.webkit.org/show_bug.cgi?id=78865
3298
3299         Reviewed by Eric Seidel.
3300
3301         Android will be re-using the TestShellLinux.cpp file. I already
3302         added this r104033, but it seems to have gotten lost in the
3303         recent refactorings.
3304
3305         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3306
3307 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3308
3309         Unreviewed, disable video build on EFL until it can be
3310         supported by EFL build bot.
3311
3312         * Scripts/build-webkit:
3313
3314 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3315
3316         [GTK] Implement zoom in/out in MiniBrowser
3317         https://bugs.webkit.org/show_bug.cgi?id=75253
3318
3319         Reviewed by Gustavo Noronha Silva.
3320
3321         * MiniBrowser/gtk/BrowserWindow.c:
3322         (browserWindowCanZoomIn):
3323         (browserWindowCanZoomOut):
3324         (browserWindowUpdateZoomActions):
3325         (webViewZoomLevelChanged):
3326         (zoomInCallback):
3327         (zoomOutCallback):
3328         (browser_window_init):
3329         (browserWindowConstructed):
3330
3331 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
3332
3333         layoutTestController.display() is flaky for SVG tests
3334         https://bugs.webkit.org/show_bug.cgi?id=78021
3335
3336         Reviewed by Adam Roben.
3337
3338         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
3339         Size the web view before running the test, not when dumping.
3340         All platforms handle this correctly now.
3341
3342         * DumpRenderTree/win/DumpRenderTree.cpp:
3343         (dump):
3344         (sizeWebViewForCurrentTest):
3345         (runTest):
3346
3347 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3348
3349         [GTK] Make install is broken when building without --enable-gtk-doc
3350         https://bugs.webkit.org/show_bug.cgi?id=78828
3351
3352         Reviewed by Martin Robinson.
3353
3354         * gtk/generate-gtkdoc:
3355         (rebase_installed_docs): Check documentation has been generated
3356         before trying to rebase it.
3357
3358 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
3359
3360         nrwt: simplify worker interface
3361         https://bugs.webkit.org/show_bug.cgi?id=78181
3362
3363         Reviewed by Tony Chang.
3364
3365         This change moves code in name(), is_done(), run(), and cancel()
3366         from Worker to AbstractWorker, since the logic is pretty much
3367         boilerplate code that any implementation would want to use.
3368
3369         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3370         (get.should):
3371         (AbstractWorker.__init__):
3372         (AbstractWorker):
3373         (AbstractWorker.name):
3374         (AbstractWorker.stop_handling_messages):
3375         (AbstractWorker.run):
3376         (AbstractWorker.is_done):
3377         (AbstractWorker.cancel):
3378         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3379         (Worker.__init__):
3380         (Worker.run):
3381         (Worker.handle_stop):
3382
3383 2012-02-16  Michael Saboff  <msaboff@apple.com>
3384
3385         ENH: Add ability to run subset of JavaScript layout tests with JSC
3386         https://bugs.webkit.org/show_bug.cgi?id=78764
3387
3388         Reviewed by Gavin Barraclough.
3389
3390         New simple test drive shell script that runs a defined
3391         list of javascript tests using jsc and the standalone-{pre,post}.js
3392         wrappers.
3393
3394         * Scripts/run-fast-jsc: Added.
3395
3396 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
3397
3398         Add new Qt performance tester bot to build.webkit.org
3399         https://bugs.webkit.org/show_bug.cgi?id=78795
3400
3401         Reviewed by Adam Roben.
3402
3403         * BuildSlaveSupport/build.webkit.org-config/config.json:
3404
3405 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
3406
3407         Disable inspector on WinCE.
3408
3409         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
3410
3411         * Scripts/build-webkit:
3412
3413 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
3414
3415         WinCE build fix after r107656.
3416
3417         Disable FTPDIR on WinCE, since it does not compile there.
3418
3419         * Scripts/build-webkit:
3420
3421 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
3422
3423         Build fix after r107863.
3424
3425         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3426
3427 2012-02-15  Tony Chang  <tony@chromium.org>
3428
3429         [chromium] add linux dbg back to garden-o-matic
3430         https://bugs.webkit.org/show_bug.cgi?id=78752
3431
3432         Reviewed by Adam Barth.
3433
3434         This reflects the current linux debug bot name (there's only one bot).
3435         I'm also remove the mac clang builder since it doesn't exist (mac
3436         always uses clang now).
3437
3438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3439         * Scripts/webkitpy/layout_tests/port/builders.py:
3440
3441 2012-02-15  Sam Weinig  <sam@webkit.org>
3442
3443         Add style check for ctype functions that are generally frowned upon in WebKit
3444         https://bugs.webkit.org/show_bug.cgi?id=78748
3445
3446         Reviewed by Anders Carlsson.
3447
3448         Not every platform has DisallowCType.h to check for uses of the ctype.h
3449         functions, so add a style check for them as well.
3450
3451         * Scripts/webkitpy/style/checkers/cpp.py:
3452         (check_ctype_functions):
3453         (check_style):
3454         (CppChecker):
3455         Add check.
3456
3457         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3458         (WebKitStyleTest.test_ctype_fucntion):
3459         Add checker.
3460
3461 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
3462
3463         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
3464         https://bugs.webkit.org/show_bug.cgi?id=76546
3465
3466         Reviewed by Simon Hausmann.
3467
3468         Resize the web view programatically because the declarative property binding
3469         does not work. Seems like our qml environment is not initialized fully but it
3470         needs more investigation.
3471
3472         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3473         (WTR::WrapperWindow::handleStatusChanged):
3474         (WTR::PlatformWebView::resizeTo):
3475
3476 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
3477
3478         webkitpy: add a worker_args concept to start_worker()
3479         https://bugs.webkit.org/show_bug.cgi?id=78572
3480
3481         Reviewed by Tony Chang.
3482
3483         This change replaces the three NRWT-specific arguments passed
3484         through the broker to the worker with a generic WorkerArguments
3485         wrapper class and a separate set_inline_arguments() call that can
3486         be used to pass additional data to the worker when it is running
3487         in the same process as the manager (this is needed for testing).
3488         With the addition of set_inline_arguments() we also no longer
3489         need to pass an optional argument to the worker.run() call.
3490
3491         Note that this method is *only* implemented on inline workers,
3492         so calling this on a regular (child process) worker will result
3493         in a runtime error.
3494
3495         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3496         (Manager._run_tests):
3497         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3498         (AbstractWorker.__init__):
3499         (AbstractWorker.run):
3500         (_ManagerConnection.start_worker):
3501         (_InlineManager.start_worker):
3502         (_InlineManager.set_inline_arguments):
3503         (_InlineManager.run_message_loop):
3504         (_MultiProcessManager.start_worker): Reworked signature.
3505         (_WorkerConnection.__init__):
3506         (_InlineWorkerConnection.__init__):
3507         (_InlineWorkerConnection.set_inline_arguments): New method.
3508         (_InlineWorkerConnection):
3509         (_InlineWorkerConnection.run):
3510         (_Process.run):
3511         (_MultiProcessWorkerConnection.__init__):
3512         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3513         (_TestWorker.__init__):
3514         (_TestWorker.set_inline_arguments):
3515         (_TestWorker.handle_test):
3516         (_TestWorker.run):
3517         (_TestsMixin.test_cancel):
3518         (_TestsMixin.test_done):
3519         (_TestsMixin.test_unknown_message):
3520         (InlineBrokerTests): New class for more testing.
3521         (InlineBrokerTests.setUp):
3522         (InlineBrokerTests.test_inline_arguments): New test.
3523         (InterfaceTest.test_managerconnection_is_abstract):
3524         (InterfaceTest.test_workerconnection_is_abstract):
3525         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3526         (WorkerArguments):
3527         (WorkerArguments.__init__):
3528         (Worker.__init__):
3529         (Worker.set_inline_arguments):
3530         (Worker):
3531         (Worker.run):
3532         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
3533         (WorkerTest.test_default_platform_in_worker):
3534
3535 2012-02-15  Adam Klein  <adamk@chromium.org>
3536
3537         Unreviewed, rolling out r107704.
3538         http://trac.webkit.org/changeset/107704
3539         https://bugs.webkit.org/show_bug.cgi?id=78486
3540
3541         Caused layout test crashes in debug builds.
3542
3543         Specific crashing tests:
3544
3545         fast/events/show-modal-dialog-onblur-onfocus.html
3546         fast/harness/show-modal-dialog.html
3547         inspector/console/console-long-eval-crash.html
3548
3549         * DumpRenderTree/chromium/TestShell.cpp:
3550         (TestShell::TestShell):
3551         * DumpRenderTree/chromium/TestShell.h:
3552         (TestShell):
3553         * DumpRenderTree/chromium/WebViewHost.cpp:
3554         (WebViewHost::runModal):
3555
3556 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
3557
3558         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
3559         https://bugs.webkit.org/show_bug.cgi?id=76347
3560
3561         Reviewed by Kenneth Rohde Christiansen.
3562
3563         * MiniBrowser/qt/MiniBrowser.qrc:
3564         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
3565         * MiniBrowser/qt/qml/BrowserWindow.qml:
3566         * MiniBrowser/qt/qml/DialogLineInput.qml:
3567
3568 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
3569
3570         [Qt] Fix WebGL in QtTestBrowser
3571
3572         Reviewed by Tor Arne Vestbø.
3573
3574         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
3575         the options for enabling GL we also pass them on properly.
3576
3577 2012-02-14  Sam Weinig  <sam@webkit.org>
3578
3579         Add #include of unistd.h on the mac for getcwd. 
3580
3581         Reviewed by Anders Carlsson.
3582
3583         This is necessary when building with libc++.
3584
3585         * WebKitTestRunner/TestInvocation.cpp:
3586
3587 2012-02-14  Sam Weinig  <sam@webkit.org>
3588
3589         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
3590         https://bugs.webkit.org/show_bug.cgi?id=78663
3591
3592         Reviewed by Anders Carlsson.
3593
3594         * DumpRenderTree/DumpRenderTreePrefix.h:
3595         * DumpRenderTree/cg/ImageDiffCG.cpp:
3596
3597 2012-02-14  Adam Barth  <abarth@webkit.org>
3598
3599         Implement an adb-based driver for the ChromiumAndroidPort
3600         https://bugs.webkit.org/show_bug.cgi?id=78627
3601
3602         Reviewed by Eric Seidel.
3603
3604         This driver mostly just wires up the ChromiumDriver through adb.  In
3605         some cases, it translates protocol elements, such as URIs, so that the
3606         rest of webkitpy is insulated from the "remoteness" of the target device.
3607
3608         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3609         (ChromiumAndroidPort.start_helper):
3610         (ChromiumAndroidPort._driver_class):
3611         (ChromiumAndroidPort._update_version):
3612         (ChromiumAndroidPort._get_stderr):
3613         (ChromiumAndroidPort):
3614         (ChromiumAndroidPort._get_last_stacktrace):
3615         (ChromiumAndroidPort._teardown_performance):
3616         (ChromiumAndroidDriver):
3617         (ChromiumAndroidDriver.__init__):
3618         (ChromiumAndroidDriver._start):
3619         (ChromiumAndroidDriver.run_test):
3620         (ChromiumAndroidDriver.stop):
3621         (ChromiumAndroidDriver._test_shell_command):
3622         (ChromiumAndroidDriver._write_command_and_read_line):
3623         (ChromiumAndroidDriver._output_image):
3624         (ChromiumAndroidDriver._has_crash_hint):
3625
3626 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3627
3628         webkitpy: the real_name() method in the Port class is no longer needed
3629         https://bugs.webkit.org/show_bug.cgi?id=78651
3630
3631         Reviewed by Eric Seidel.
3632
3633         The change in bug 78565 / r107718 made it no longer necessary
3634         (we can use options.platform instead).
3635
3636         * Scripts/webkitpy/layout_tests/port/base.py:
3637         (Port.name):
3638         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3639         (MockDRTPort.__init__):
3640
3641 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3642
3643         webkitpy: clean up options, port handling in manager_worker_broker
3644         https://bugs.webkit.org/show_bug.cgi?id=78568
3645
3646         Reviewed by Tony Chang.
3647
3648         manager_worker_broker no longer needs options or port objects
3649         directly, so we make them only be passed in start_worker().
3650
3651         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3652         (Manager._run_tests):
3653         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3654         (get):
3655         (_ManagerConnection.__init__):
3656         (_ManagerConnection.start_worker):
3657         (_InlineManager.__init__):
3658         (_InlineManager.start_worker):
3659         (_InlineManager.run_message_loop):
3660         (_MultiProcessManager.__init__):
3661         (_MultiProcessManager):
3662         (_MultiProcessManager.start_worker):
3663         (_InlineWorkerConnection.__init__):
3664         (_InlineWorkerConnection.run):
3665         (_Process.__init__):
3666         (_MultiProcessWorkerConnection.__init__):
3667         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3668         (make_broker):
3669         (_TestWorker.run):
3670         (_TestsMixin.test_cancel):
3671         (_TestsMixin.test_done):
3672         (_TestsMixin.test_unknown_message):
3673         (MultiProcessBrokerTests.setUp):
3674         (InterfaceTest.test_managerconnection_is_abstract):
3675         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
3676         (Broker.__init__):
3677
3678 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3679
3680         nrwt: add a unit test for regression introduced in bug 78565
3681         https://bugs.webkit.org/show_bug.cgi?id=78646
3682
3683         Reviewed by Tony Chang.
3684
3685         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
3686         (FakeConnection):
3687         (FakeConnection.run_message_loop):
3688         (FakeConnection.post_message):
3689         (WorkerTest):
3690         (WorkerTest.test_default_platform_in_worker):
3691
3692 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
3693
3694         NRWT is broken for the default port
3695         https://bugs.webkit.org/show_bug.cgi?id=78640
3696     
3697         Reviewed by Tony Chang.
3698
3699         The change in r107718 (bug 78565) broke NRWT if you didn't
3700         specify any sort of --platform flag or equivalent. I didn't
3701         catch this because it's a full integration test (which we don't
3702         have an automated test for) and I missed this command line
3703         variant when testing interactively.
3704
3705         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3706         (Worker.run):
3707
3708 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
3709
3710         Last character display for passwords in Android.
3711         https://bugs.webkit.org/show_bug.cgi?id=78532
3712
3713         Reviewed by Adam Barth.
3714
3715         * DumpRenderTree/chromium/WebPreferences.cpp:
3716         (WebPreferences::applyTo):
3717
3718 2012-02-14  Adam Barth  <abarth@webkit.org>
3719
3720         Finish implementing start_helper for ChromiumAndroidPort
3721         https://bugs.webkit.org/show_bug.cgi?id=78582
3722
3723         Reviewed by Eric Seidel.
3724
3725         This patch contains the remaining odds and ends for the start_helper function.
3726
3727         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3728         (ChromiumAndroidPort.start_helper):
3729         (ChromiumAndroidPort._synchronize_datetime):
3730         (ChromiumAndroidPort):