b133c30c5b7b65eb8b0f36bb77d725e675553c27
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-18  Daniel Bates  <dabates@apple.com>
2
3         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4         https://bugs.webkit.org/show_bug.cgi?id=192824
5         <rdar://problem/47100332>
6
7         Reviewed by Wenson Hsieh.
8
9         Fix a bug where the wrong usage code was used for F13 thru F24.
10
11         * WebKitTestRunner/ios/HIDEventGenerator.mm:
12         (keyCodeForDOMFunctionKey):
13
14 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
15
16         Bytecode cache should a have a boot-specific validation
17         https://bugs.webkit.org/show_bug.cgi?id=194769
18         <rdar://problem/48149509>
19
20         Reviewed by Keith Miller.
21
22         Add test for WTF::bootSessionUUIDString()
23
24         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
26         (TEST):
27
28 2019-02-18  Alex Christensen  <achristensen@webkit.org>
29
30         Disable safe browsing in WKWebView and remove its WKPreferences API
31         https://bugs.webkit.org/show_bug.cgi?id=194723
32         <rdar://problem/48122993>
33
34         Reviewed by Geoffrey Garen.
35
36         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
37         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
38         (TEST):
39         (safeBrowsingView):
40         Make tests use SPI instead of API.
41
42 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
43
44         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
45         https://bugs.webkit.org/show_bug.cgi?id=194586
46
47         Reviewed by Ross Kirsling.
48
49         * DumpRenderTree/win/DumpRenderTree.cpp:
50         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
51         * Scripts/webkitpy/port/driver.py:
52         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
53
54 2019-02-17  David Kilzer  <ddkilzer@apple.com>
55
56         Unreviewed, rolling out r241620.
57
58         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
59         (Requested by ddkilzer on #webkit.)
60
61         Reverted changeset:
62
63         "[WTF] Add environment variable helpers"
64         https://bugs.webkit.org/show_bug.cgi?id=192405
65         https://trac.webkit.org/changeset/241620
66
67 2019-02-16  Zalan Bujtas  <zalan@apple.com>
68
69         [LFC] RenderImage's default intrinsic size is 0.
70         https://bugs.webkit.org/show_bug.cgi?id=194745
71
72         Reviewed by Antti Koivisto.
73
74         * LayoutReloaded/misc/LFC-passing-tests.txt:
75
76 2019-02-16  Zalan Bujtas  <zalan@apple.com>
77
78         [LFC][BFC] Add support for block replaced intrinsic width.
79         https://bugs.webkit.org/show_bug.cgi?id=194705
80
81         Reviewed by Simon Fraser.
82
83         * LayoutReloaded/misc/LFC-passing-tests.txt:
84
85 2019-02-16  Zalan Bujtas  <zalan@apple.com>
86
87         [LFC] Apply min/max width constraints to preferred width computation
88         https://bugs.webkit.org/show_bug.cgi?id=194739
89
90         Reviewed by Simon Fraser.
91
92         * LayoutReloaded/misc/LFC-passing-tests.txt:
93
94 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
95
96         [WTF] Add environment variable helpers
97         https://bugs.webkit.org/show_bug.cgi?id=192405
98
99         Reviewed by Michael Catanzaro.
100
101         * DumpRenderTree/mac/DumpRenderTree.mm:
102         (libraryPathForDumpRenderTree):
103         * DumpRenderTree/win/DumpRenderTree.cpp:
104         (libraryPathForDumpRenderTree):
105         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
106         (setUpIOSLayoutTestCommunication):
107         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
108         (beforeAll):
109         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
110         (main):
111         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
112         (WebKitTestBus::run):
113         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
114         (WTR::getOutputDir):
115         (WTR::initializeFontConfigSetting):
116         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
117         (WTR::InjectedBundle::platformInitialize):
118         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
119         (WTR::topLevelPath):
120         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
121         (WTR::topLevelPath):
122         (WTR::getOutputDir):
123         (WTR::activateFonts):
124         * WebKitTestRunner/TestController.cpp:
125         (WTR::TestController::libraryPathForTesting):
126         (WTR::TestController::generateContextConfiguration const):
127         (WTR::TestController::generatePageConfiguration):
128         (WTR::TestController::decideDestinationWithSuggestedFilename):
129         (WTR::TestController::platformAdjustContext):
130         * WebKitTestRunner/TestController.h:
131         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
132         (WTR::TestController::cocoaPlatformInitialize):
133         (WTR::TestController::platformAdjustContext):
134         * WebKitTestRunner/gtk/main.cpp:
135         (main):
136         * WebKitTestRunner/mac/TestControllerMac.mm:
137         (WTR::TestController::configureContentExtensionForTest):
138         * WebKitTestRunner/wpe/main.cpp:
139         (main):
140         Utilize WTF::Environment where possible.
141
142 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
143
144         [iOS] WKWebView callout bar is missing Change Writing Direction item
145         https://bugs.webkit.org/show_bug.cgi?id=190015
146         <rdar://problem/44810366>
147
148         Reviewed by Tim Horton.
149
150         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
151         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
152
153         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
154         (TestWebKitAPI::TEST):
155
156 2019-02-15  Chris Dumez  <cdumez@apple.com>
157
158         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
159         https://bugs.webkit.org/show_bug.cgi?id=194717
160         <rdar://problem/47884404>
161
162         Reviewed by Brady Eidson.
163
164         Add API test coverage.
165
166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
167
168 2019-02-15  Youenn Fablet  <youenn@apple.com>
169
170         Make navigator.mediaDevices SecureContext
171         https://bugs.webkit.org/show_bug.cgi?id=194666
172
173         Reviewed by Eric Carlson.
174
175         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
176         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
177         (TEST_F):
178
179 2019-02-15  Brian Burg  <bburg@apple.com>
180
181         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
182         https://bugs.webkit.org/show_bug.cgi?id=194411
183         <rdar://problem/47787614>
184
185         Reviewed by Joseph Pecoraro.
186
187         Remove unnecessary soft linking macro usage.
188
189         * DumpRenderTree/mac/TestRunnerMac.mm:
190         (TestRunner::inspectorTestStubURL):
191         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
192         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
193         (WTR::TestRunner::inspectorTestStubURL):
194
195 2019-02-15  Commit Queue  <commit-queue@webkit.org>
196
197         Unreviewed, rolling out r241559 and r241566.
198         https://bugs.webkit.org/show_bug.cgi?id=194710
199
200         Causes layout test crashes under GuardMalloc (Requested by
201         ryanhaddad on #webkit).
202
203         Reverted changesets:
204
205         "[WTF] Add environment variable helpers"
206         https://bugs.webkit.org/show_bug.cgi?id=192405
207         https://trac.webkit.org/changeset/241559
208
209         "Unreviewed build fix for WinCairo Debug after r241559."
210         https://trac.webkit.org/changeset/241566
211
212 2019-02-15  Zalan Bujtas  <zalan@apple.com>
213
214         [LFC] Out-of-flow box is never a float box
215         https://bugs.webkit.org/show_bug.cgi?id=194704
216
217         Reviewed by Antti Koivisto.
218
219         * LayoutReloaded/misc/LFC-passing-tests.txt:
220
221 2019-02-10  Darin Adler  <darin@apple.com>
222
223         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
224         https://bugs.webkit.org/show_bug.cgi?id=194487
225
226         Reviewed by Daniel Bates.
227
228         * DumpRenderTree/win/DumpRenderTree.cpp:
229         (applicationId): Use makeString instead of String::format.
230         (main): Ditto.
231         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
232         (TestWebKitAPI::Util::createURLForResource): Ditto.
233         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
234         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
235
236         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
237         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
238         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
239         (WTR::createStringWithAttributes): Use appendLiteral.
240         (WTR::AccessibilityUIElement::helpText const): Ditto.
241         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
242         directly instead of using String::format.
243         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
244         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
245
246 2019-02-15  Truitt Savell  <tsavell@apple.com>
247
248         Unreviewed, rolling out r241564.
249
250         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
251
252         Reverted changeset:
253
254         "[Mac] WebInspectorUI.framework does not need to be soft-
255         linked anymore"
256         https://bugs.webkit.org/show_bug.cgi?id=194411
257         https://trac.webkit.org/changeset/241564
258
259 2019-02-15  Saam barati  <sbarati@apple.com>
260
261         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
262         https://bugs.webkit.org/show_bug.cgi?id=194036
263
264         Reviewed by Yusuke Suzuki.
265
266         * Scripts/run-jsc-stress-tests:
267
268 2019-02-14  Tim Horton  <timothy_horton@apple.com>
269
270         Fix the build.
271
272         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
273         (WTR::UIScriptController::drawSquareInEditableImage):
274         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
275         (TestWebKitAPI::drawSquareInEditableImage):
276
277 2019-02-14  Tim Horton  <timothy_horton@apple.com>
278
279         Fix the build.
280
281         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
282         (WTR::UIScriptController::drawSquareInEditableImage):
283         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
284         (TestWebKitAPI::drawSquareInEditableImage):
285
286 2019-02-14  Brian Burg  <bburg@apple.com>
287
288         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
289         https://bugs.webkit.org/show_bug.cgi?id=194411
290         <rdar://problem/47787614>
291
292         Reviewed by Joseph Pecoraro.
293
294         Remove unnecessary soft linking macro usage.
295
296         * DumpRenderTree/mac/TestRunnerMac.mm:
297         (TestRunner::inspectorTestStubURL):
298         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
299         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
300         (WTR::TestRunner::inspectorTestStubURL):
301
302 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
303
304         [ews-app] status bubble should fetch builder name info from BuilderMapping table
305         https://bugs.webkit.org/show_bug.cgi?id=194599
306
307         Reviewed by Lucas Forschler.
308
309         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
310         (StatusBubble._build_bubble):
311
312 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
313
314         [ews-app] Set Foreign Key in Django build model
315         https://bugs.webkit.org/show_bug.cgi?id=194667
316
317         Reviewed by Lucas Forschler.
318
319         * BuildSlaveSupport/ews-app/ews/models/build.py:
320         (Build):
321
322 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
323
324         [WTF] Add environment variable helpers
325         https://bugs.webkit.org/show_bug.cgi?id=192405
326
327         Reviewed by Michael Catanzaro.
328
329         * DumpRenderTree/mac/DumpRenderTree.mm:
330         (libraryPathForDumpRenderTree):
331         * DumpRenderTree/win/DumpRenderTree.cpp:
332         (libraryPathForDumpRenderTree):
333         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
334         (setUpIOSLayoutTestCommunication):
335         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
336         (TestWebKitAPI::strip):
337         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
338         (beforeAll):
339         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
340         (main):
341         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
342         (WebKitTestBus::run):
343         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
344         (WTR::getOutputDir):
345         (WTR::initializeFontConfigSetting):
346         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
347         (WTR::InjectedBundle::platformInitialize):
348         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
349         (WTR::topLevelPath):
350         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
351         (WTR::topLevelPath):
352         (WTR::getOutputDir):
353         (WTR::activateFonts):
354         * WebKitTestRunner/TestController.cpp:
355         (WTR::TestController::libraryPathForTesting):
356         (WTR::TestController::generateContextConfiguration const):
357         (WTR::TestController::generatePageConfiguration):
358         (WTR::TestController::decideDestinationWithSuggestedFilename):
359         (WTR::TestController::platformAdjustContext):
360         * WebKitTestRunner/TestController.h:
361         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
362         (WTR::TestController::cocoaPlatformInitialize):
363         (WTR::TestController::platformAdjustContext):
364         * WebKitTestRunner/gtk/main.cpp:
365         (main):
366         * WebKitTestRunner/mac/TestControllerMac.mm:
367         (WTR::TestController::configureContentExtensionForTest):
368         * WebKitTestRunner/wpe/main.cpp:
369         (main):
370         Utilize WTF::Environment where possible.
371
372 2019-02-14  Chris Dumez  <cdumez@apple.com>
373
374         [PSON] Introduce a WebContent Process cache
375         https://bugs.webkit.org/show_bug.cgi?id=194594
376         <rdar://problem/46793397>
377
378         Reviewed by Geoff Garen.
379
380         Update API tests to turn on the WebContent Process cache.
381
382         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
383
384 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
385
386         Unreviewed, build fix after r241480
387
388         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
389         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
390         (-[DragAndDropSimulator initWithWebView:]):
391
392 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
393
394         AX: ARIA Reflection was disabled in error
395         https://bugs.webkit.org/show_bug.cgi?id=194647
396         <rdar://problem/48068336>
397
398         Reviewed by Ryosuke Niwa.
399
400         Remove test override now that this feature should be enabled by default.
401
402         * WebKitTestRunner/TestController.cpp:
403         (WTR::TestController::resetPreferencesToConsistentValues):
404
405 2019-02-14  Commit Queue  <commit-queue@webkit.org>
406
407         Unreviewed, rolling out r241486.
408         https://bugs.webkit.org/show_bug.cgi?id=194655
409
410         causing API failures in builds (Requested by ShawnRoberts on
411         #webkit).
412
413         Reverted changeset:
414
415         "[Cocoa] Media elements will restart network buffering just
416         before suspending"
417         https://bugs.webkit.org/show_bug.cgi?id=193691
418         https://trac.webkit.org/changeset/241486
419
420 2019-02-14  Zalan Bujtas  <zalan@apple.com>
421
422         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
423         https://bugs.webkit.org/show_bug.cgi?id=194622
424
425         Reviewed by Antti Koivisto.
426
427         * LayoutReloaded/misc/LFC-passing-tests.txt:
428
429 2019-02-14  Zalan Bujtas  <zalan@apple.com>
430
431         [LFC] Shrink-to-fit-width should be constrained by min/max width
432         https://bugs.webkit.org/show_bug.cgi?id=194653
433
434         Reviewed by Antti Koivisto.
435
436         * LayoutReloaded/misc/LFC-passing-tests.txt:
437
438 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
439
440         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
441         https://bugs.webkit.org/show_bug.cgi?id=194641
442
443         Reviewed by Geoffrey Garen.
444
445         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
446         so that the test would fail without this fix.
447
448         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
449         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
450
451 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
452
453         [ews-app] Change log level for a log statement
454
455         Unreviewed minor fix.
456
457         * BuildSlaveSupport/ews-app/ews/models/patch.py:
458         (Patch.save_patch):
459
460 2019-02-13  Jer Noble  <jer.noble@apple.com>
461
462         [Cocoa] Media elements will restart network buffering just before suspending
463         https://bugs.webkit.org/show_bug.cgi?id=193691
464
465         Reviewed by Eric Carlson.
466
467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
468         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
469         (TEST):
470
471 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
472
473         [ews-app] Fetch builder id to name mapping
474         https://bugs.webkit.org/show_bug.cgi?id=194355
475
476         Reviewed by Lucas Forschler.
477
478         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
479         (Buildbot.get_builder_id_to_name_mapping):
480         (Buildbot._get_display_name_from_builder_name):
481
482 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
483
484         Further restricting webarchive loads
485         https://bugs.webkit.org/show_bug.cgi?id=194567
486         <rdar://problem/47610130>
487
488         Reviewed by Youenn Fablet.
489
490         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
491         navigations on drop.
492
493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
494         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
495         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
496         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
497         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
498         (TestWebKitAPI::TEST):
499         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
500         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
501         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
502         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
503         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
504         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
505         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
506
507 2019-02-13  John Wilander  <wilander@apple.com>
508
509         Store Ad Click Attribution requests in the network process
510         https://bugs.webkit.org/show_bug.cgi?id=194510
511         <rdar://problem/47650118>
512
513         Reviewed by Alex Christensen and Daniel Bates.
514
515         This patch adds two TestRunner functions:
516         - dumpAdClickAttribution()
517         - clearAdClickAttribution()
518
519         They call into the network process to dump and clear Ad Click
520         Attribution state, respectively.
521
522         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
523         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
524         (WTR::TestRunner::dumpAdClickAttribution):
525         (WTR::TestRunner::clearAdClickAttribution):
526         * WebKitTestRunner/InjectedBundle/TestRunner.h:
527         * WebKitTestRunner/TestController.cpp:
528         (WTR::TestController::resetStateToConsistentValues):
529         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
530         (WTR::adClickAttributionStringResultCallback):
531         (WTR::TestController::dumpAdClickAttribution):
532         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
533         (WTR::adClickAttributionVoidCallback):
534         (WTR::TestController::clearAdClickAttribution):
535         * WebKitTestRunner/TestController.h:
536         * WebKitTestRunner/TestInvocation.cpp:
537         (WTR::TestInvocation::dumpResults):
538         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
539         (WTR::TestInvocation::dumpAdClickAttribution):
540         * WebKitTestRunner/TestInvocation.h:
541
542 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
543
544         [ews-app] Generate status-bubble
545         https://bugs.webkit.org/show_bug.cgi?id=194572
546
547         Reviewed by Lucas Forschler.
548
549         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
550         (StatusBubble._build_bubble):
551         (StatusBubble._should_show_bubble_for):
552         (StatusBubble._build_bubbles_for_patch):
553
554 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
555
556         [ews-app] Add status bubble html template
557         https://bugs.webkit.org/show_bug.cgi?id=194571
558
559         Reviewed by Lucas Forschler.
560
561         * BuildSlaveSupport/ews-app/ews/templates: Added.
562         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
563
564 2019-02-12  Chris Dumez  <cdumez@apple.com>
565
566         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
567         https://bugs.webkit.org/show_bug.cgi?id=194568
568         <rdar://problem/47944490>
569
570         Reviewed by Ryosuke Niwa.
571
572         Add API test coverage.
573
574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
575         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
576
577 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
578
579         webkitpy: Remove bug_dummy from parsed test expectations
580         https://bugs.webkit.org/show_bug.cgi?id=194562
581         <rdar://problem/47853999>
582
583         Reviewed by Lucas Forschler.
584
585         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
586         (TestExpectationParser):
587         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
588         skipped tests.
589         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
590
591 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
592
593         [ews-app] Add method to fetch patch
594         https://bugs.webkit.org/show_bug.cgi?id=194518
595
596         Reviewed by Lucas Forschler.
597
598         * BuildSlaveSupport/ews-app/ews/models/patch.py:
599         (Patch.get_patch):
600
601 2019-02-12  Zalan Bujtas  <zalan@apple.com>
602
603         [LFC] Expand tests coverage (60 new tests -> 860)
604
605         Unreviewed test gardening (run-singly, --child-processes=1).
606
607         * LayoutReloaded/misc/LFC-passing-tests.txt:
608
609 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
610
611         Allow pages to trigger programmatic paste from script on iOS
612         https://bugs.webkit.org/show_bug.cgi?id=194271
613         <rdar://problem/47808810>
614
615         Reviewed by Tim Horton.
616
617         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
618
619         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
620         (WTR::UIScriptController::platformSetDidShowMenuCallback):
621         (WTR::UIScriptController::platformSetDidHideMenuCallback):
622         (WTR::UIScriptController::rectForMenuAction const):
623
624         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
625         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
626         for when the menu is shown or hidden.
627
628         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
629         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
630         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
631         (WTR::UIScriptController::setDidShowMenuCallback):
632         (WTR::UIScriptController::didShowMenuCallback const):
633         (WTR::UIScriptController::setDidHideMenuCallback):
634         (WTR::UIScriptController::didHideMenuCallback const):
635         (WTR::UIScriptController::platformSetDidShowMenuCallback):
636         (WTR::UIScriptController::platformSetDidHideMenuCallback):
637         (WTR::UIScriptController::rectForMenuAction const):
638         * TestRunnerShared/UIScriptContext/UIScriptController.h:
639         * WebKitTestRunner/TestController.cpp:
640         (WTR::TestController::resetPreferencesToConsistentValues):
641         (WTR::updateTestOptionsFromTestHeader):
642         * WebKitTestRunner/TestOptions.h:
643
644         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
645         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
646
647         (WTR::TestOptions::hasSameInitializationOptions const):
648         * WebKitTestRunner/UIScriptControllerCocoa.mm:
649         (WTR::UIScriptController::calendarType const):
650         (WTR::UIScriptController::platformUndoManager const):
651         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
652         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
653         (-[TestRunnerWKWebView initWithFrame:configuration:]):
654         (-[TestRunnerWKWebView dealloc]):
655         (-[TestRunnerWKWebView _didShowMenu]):
656         (-[TestRunnerWKWebView _didHideMenu]):
657
658         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
659
660         * WebKitTestRunner/ios/TestControllerIOS.mm:
661         (WTR::handleMenuWillHideNotification):
662         (WTR::handleMenuDidHideNotification):
663         (WTR::TestController::platformInitialize):
664         (WTR::TestController::platformDestroy):
665         (WTR::TestController::platformResetStateToConsistentValues):
666
667         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
668         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
669
670         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
671         (WTR::forEachViewInHierarchy):
672         (WTR::findViewInHierarchyOfType):
673
674         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
675         functions that dig through a given view's hierarchy in search of a view of a given class.
676
677         (WTR::UIScriptController::selectionStartGrabberViewRect const):
678         (WTR::UIScriptController::selectionEndGrabberViewRect const):
679         (WTR::UIScriptController::selectionCaretViewRect const):
680         (WTR::UIScriptController::selectionRangeViewRects const):
681         (WTR::UIScriptController::platformSetDidShowMenuCallback):
682         (WTR::UIScriptController::platformSetDidHideMenuCallback):
683
684         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
685
686         (WTR::UIScriptController::rectForMenuAction const):
687
688         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
689         callout bar) whose label matches the given string.
690
691         (WTR::UIScriptController::platformContentView const):
692
693         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
694         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
695         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
696
697         (WTR::UIScriptController::platformUndoManager const): Deleted.
698         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
699         (WTR::UIScriptController::platformContentView const):
700         (WTR::UIScriptController::platformUndoManager const): Deleted.
701
702 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
703
704         webkitpy: No option to only show unexpected failures in results.html for iPad
705         https://bugs.webkit.org/show_bug.cgi?id=194554
706         <rdar://problem/47922442>
707
708         Rubber-stamped by Aakash Jain.
709
710         Just because a TestExpecations file does not exist for a specific platform does not mean that
711         TestExpecations are not being used, given that platforms inherit test expectations.
712
713         * Scripts/webkitpy/port/base.py:
714         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
715         * Scripts/webkitpy/port/base_unittest.py:
716         (PortTest.test_uses_test_expectations_file):
717
718 2019-02-12  Alex Christensen  <achristensen@webkit.org>
719
720         Remove setDefersLoading infrastructure from WebKit2
721         https://bugs.webkit.org/show_bug.cgi?id=194506
722
723         Reviewed by Brady Eidson.
724
725         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
726         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
727         (WTR::TestRunner::setDefersLoading): Deleted.
728         * WebKitTestRunner/InjectedBundle/TestRunner.h:
729
730 2019-02-12  Alex Christensen  <achristensen@webkit.org>
731
732         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
733         https://bugs.webkit.org/show_bug.cgi?id=194522
734         <rdar://problem/47789393>
735
736         Reviewed by Chris Dumez.
737
738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
739         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
740         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
741         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
742
743 2019-02-12  Andy Estes  <aestes@apple.com>
744
745         [iOSMac] Enable Parental Controls Content Filtering
746         https://bugs.webkit.org/show_bug.cgi?id=194521
747         <rdar://39732376>
748
749         Reviewed by Tim Horton.
750
751         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
752
753 2019-02-12  Zalan Bujtas  <zalan@apple.com>
754
755         [LFC][IFC] Add intrinsic width support for float boxes.
756         https://bugs.webkit.org/show_bug.cgi?id=194528
757
758         Reviewed by Antti Koivisto.
759
760         Expand tests coverage (2 new tests -> 800).
761         (This is the correct test ordering --runs-singly --child-processes=1)
762
763         * LayoutReloaded/misc/LFC-passing-tests.txt:
764
765 2019-02-12  Rob Buis  <rbuis@igalia.com>
766
767         Implement serializing in MIME type parser
768         https://bugs.webkit.org/show_bug.cgi?id=193909
769
770         Reviewed by Darin Adler.
771
772         Add various tests involving upper case, non-ASCII, control/null characters,
773         various HTTP whitespace, single quotes and an unpaired surrogate.
774
775         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
776         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
777         (TestWebKitAPI::serializeIfValid):
778         (TestWebKitAPI::TEST):
779
780 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
781
782         [Cocoa] Ask platform for generic font family mappings
783         https://bugs.webkit.org/show_bug.cgi?id=187723
784         <rdar://problem/41892438>
785
786         Reviewed by Brent Fulgham.
787
788         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
789
790         * DumpRenderTree/mac/DumpRenderTree.mm:
791         (allowedFontFamilySet):
792         * WebKitTestRunner/mac/TestControllerMac.mm:
793         (WTR::allowedFontFamilySet):
794
795 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
796
797         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
798         https://bugs.webkit.org/show_bug.cgi?id=193622
799
800         Reviewed by Michael Catanzaro.
801
802         This adds support for loading content extension rule sets from the JSON files which
803         accompany the corresponding layout test, using the C API. The Cocoa specific parts
804         of WKTR for this could be removed, but that is left for a follow-up patch with
805         cleanups.
806
807         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
808         * WebKitTestRunner/TestController.cpp:
809         (WTR::testPath): Subtract one from the length when constructing the result std::string to
810         avoid having the null-terminator copied into the result.
811         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
812         part of the preparations to run a test.
813         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
814         (WTR::contentExtensionStoreCallback): Added.
815         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
816         used for content extensions test.
817         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
818         extensions and compiling the JSON rule set for tests involving content extensions.
819         (WTR::TestController::resetContentExtensions): Removes the content extension built for
820         testing and disables content extensions.
821         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
822         resetContentExtensions().
823         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
824         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
825         configureContentExtensionForTest(), and userContentController().
826
827 2019-02-11  Daniel Bates  <dabates@apple.com>
828
829         [iOS] Mouse/Touch/Pointer events are missing modifier keys
830         https://bugs.webkit.org/show_bug.cgi?id=191446
831         <rdar://problem/45929460>
832
833         Reviewed by Tim Horton.
834
835         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
836
837         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
838         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
839         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
840         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
841         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
842         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
843         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
844         * TestRunnerShared/UIScriptContext/UIScriptController.h:
845         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
846         (WTR::arrayLength):
847         (WTR::parseModifierArray):
848         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
849         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
850         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
851         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
852
853 2019-02-11  Commit Queue  <commit-queue@webkit.org>
854
855         Unreviewed, rolling out r241272 and r241276.
856         https://bugs.webkit.org/show_bug.cgi?id=194514
857
858         Broke the Apple Internal build and the fix requires human
859         intervention :( (Requested by dydz on #webkit).
860
861         Reverted changesets:
862
863         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
864         https://bugs.webkit.org/show_bug.cgi?id=191446
865         https://trac.webkit.org/changeset/241272
866
867         "Fix internal iOS build after r241272"
868         https://bugs.webkit.org/show_bug.cgi?id=191446
869         https://trac.webkit.org/changeset/241276
870
871 2019-02-11  Truitt Savell  <tsavell@apple.com>
872
873         Unreviewed, rolling out r241269.
874
875         Caused 5 layout tests crashes on Mac WK1
876
877         Reverted changeset:
878
879         "DumpRenderTree should report unknown options"
880         https://bugs.webkit.org/show_bug.cgi?id=191303
881         https://trac.webkit.org/changeset/241269
882
883 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
884
885         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
886         https://bugs.webkit.org/show_bug.cgi?id=194313
887
888         Reviewed by Tim Horton.
889
890         Add a helper to determine whether the web view is presenting modal UI.
891
892         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
893         (WTR::UIScriptController::isPresentingModally const):
894         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
895         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
896         (WTR::UIScriptController::isPresentingModally const):
897         * TestRunnerShared/UIScriptContext/UIScriptController.h:
898         * WebKitTestRunner/UIScriptControllerCocoa.mm:
899         (WTR::UIScriptController::calendarType const): Deleted.
900         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
901         (WTR::UIScriptController::isPresentingModally const):
902         (WTR::UIScriptController::calendarType const):
903         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
904         (WTR::UIScriptController::calendarType const):
905
906 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
907
908         GCHeapInspector: Show the retained sizes in more places
909         https://bugs.webkit.org/show_bug.cgi?id=194464
910
911         Reviewed by Simon Fraser.
912
913         * GCHeapInspector/gc-heap-inspector.html:
914         * GCHeapInspector/script/interface.js:
915         (HeapInspectorUtils.humanReadableSize):
916         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
917         (HeapInspectorUtils.spanForNode.span.span):
918         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
919         (HeapSnapshotInspector.prototype.buildRoots):
920
921 2019-02-11  Daniel Bates  <dabates@apple.com>
922
923         [iOS] Mouse/Touch/Pointer events are missing modifier keys
924         https://bugs.webkit.org/show_bug.cgi?id=191446
925         <rdar://problem/45929460>
926
927         Reviewed by Tim Horton.
928
929         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
930
931         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
932         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
933         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
934         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
935         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
936         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
937         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
938         * TestRunnerShared/UIScriptContext/UIScriptController.h:
939         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
940         (WTR::arrayLength):
941         (WTR::parseModifierArray):
942         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
943         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
944         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
945         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
946
947 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
948
949         DumpRenderTree should report unknown options
950         https://bugs.webkit.org/show_bug.cgi?id=191303
951
952         Reviewed by Frédéric Wang.
953
954         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
955         to report unknown options.
956         Added and assigned test options which are currently used in tests.
957
958         * DumpRenderTree/TestOptions.cpp:
959         (TestOptions::TestOptions):
960
961 2019-02-11  Truitt Savell  <tsavell@apple.com>
962
963         Unreviewed, rolling out r241229.
964
965         Revision broke internal builds for watchOS.
966
967         Reverted changeset:
968
969         "[Cocoa] Ask platform for generic font family mappings"
970         https://bugs.webkit.org/show_bug.cgi?id=187723
971         https://trac.webkit.org/changeset/241229
972
973 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
974
975         [WinCairo][MiniBrowser] Basic authentication always fails.
976         https://bugs.webkit.org/show_bug.cgi?id=194496
977
978         Reviewed by Don Olmstead.
979
980         * MiniBrowser/win/DialogHelper.h:
981         (Dialog::getText):
982
983 2019-02-11  Philippe Normand  <pnormand@igalia.com>
984
985         [GStreamer] GstMappedBuffer testsuite build fails
986         https://bugs.webkit.org/show_bug.cgi?id=194495
987
988         Reviewed by Carlos Garcia Campos.
989
990         Fix the build by explicitely adding the gstreamer1.0-audio include
991         directories to the include path.
992
993         * TestWebKitAPI/PlatformGTK.cmake:
994         * TestWebKitAPI/PlatformWPE.cmake:
995
996 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
997
998         [GTK][WPE] Add enable-javascript-markup setting
999         https://bugs.webkit.org/show_bug.cgi?id=193439
1000
1001         Reviewed by Michael Catanzaro.
1002
1003         Add test cases to check the new setting.
1004
1005         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1006         (testWebKitSettings):
1007         (testWebKitSettingsJavaScriptMarkup):
1008         (beforeAll):
1009
1010 2019-02-10  Darin Adler  <darin@apple.com>
1011
1012         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1013         https://bugs.webkit.org/show_bug.cgi?id=194485
1014
1015         Reviewed by Daniel Bates.
1016
1017         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1018
1019 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1020
1021         Add more tests for clampTo<>()
1022         https://bugs.webkit.org/show_bug.cgi?id=194462
1023
1024         Reviewed by Geoffrey Garen.
1025
1026         Darin suggested to test the very last floating point number
1027         at the boundaries when truncating to integer.
1028         I added test for max/min and max-1/min-1.
1029
1030         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1031         (TestWebKitAPI::TEST):
1032
1033 2019-02-09  Darin Adler  <darin@apple.com>
1034
1035         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1036         https://bugs.webkit.org/show_bug.cgi?id=194021
1037
1038         Reviewed by Geoffrey Garen.
1039
1040         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1041         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1042         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1043
1044 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1045
1046         [LFC][IFC] Add intrinsic width support for basic inline containers
1047         https://bugs.webkit.org/show_bug.cgi?id=194473
1048
1049         Reviewed by Antti Koivisto.
1050
1051         Expand tests coverage (11 new tests -> 798)
1052
1053         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1054
1055 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1056
1057         Fix MiniBrowser's entitlements
1058         https://bugs.webkit.org/show_bug.cgi?id=192431
1059
1060         Reviewed by Joseph Pecoraro.
1061
1062         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1063         files, making it impossible to load any extension.
1064
1065         * MiniBrowser/MiniBrowser.entitlements:
1066
1067 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1068
1069         [Cocoa] Ask platform for generic font family mappings
1070         https://bugs.webkit.org/show_bug.cgi?id=187723
1071         <rdar://problem/41892438>
1072
1073         Reviewed by Brent Fulgham.
1074
1075         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1076
1077         * DumpRenderTree/mac/DumpRenderTree.mm:
1078         (allowedFontFamilySet):
1079         * WebKitTestRunner/mac/TestControllerMac.mm:
1080         (WTR::allowedFontFamilySet):
1081
1082 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1083
1084         [GTK] Implement back/forward touchpad gesture
1085         https://bugs.webkit.org/show_bug.cgi?id=193919
1086
1087         Reviewed by Michael Catanzaro.
1088
1089         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1090         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1091
1092 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1093
1094         Add SPI to use networking daemon instead of XPC service
1095         https://bugs.webkit.org/show_bug.cgi?id=194427
1096
1097         Reviewed by Geoffrey Garen
1098
1099         * MiniBrowser/MiniBrowser.entitlements:
1100
1101 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1102
1103         [ews-build] Ensure that every builder in config.json has short name
1104         https://bugs.webkit.org/show_bug.cgi?id=194461
1105
1106         Reviewed by Lucas Forschler.
1107
1108         * BuildSlaveSupport/ews-build/loadConfig.py:
1109         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1110
1111 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1112
1113         [ews-build] Add short name to config.json
1114         https://bugs.webkit.org/show_bug.cgi?id=194456
1115
1116         Reviewed by Lucas Forschler.
1117
1118         * BuildSlaveSupport/ews-build/config.json: Added short name.
1119         * BuildSlaveSupport/ews-build/loadConfig.py:
1120         (loadBuilderConfig): Set the short name as the builder description.
1121
1122 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1123
1124         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1125         https://bugs.webkit.org/show_bug.cgi?id=194418
1126
1127         Reviewed by Lucas Forschler.
1128
1129         Do not include errors trying when finding crashlogs at the end of
1130         a run-webkit-tests run since we don't process those errors.
1131
1132         * Scripts/webkitpy/port/darwin.py:
1133         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1134         * Scripts/webkitpy/port/ios_device.py:
1135         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1136         * Scripts/webkitpy/port/watch_device.py:
1137         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1138
1139 2019-02-08  Beth Dakin  <bdakin@apple.com>
1140
1141         Add afterScreenUpdates to WKSnapshotConfiguration
1142         https://bugs.webkit.org/show_bug.cgi?id=194362
1143         -and corresponding-
1144         <rdar://problem/40655528> Please add an "after screen updates" property to 
1145         WKSnapshotConfiguration (to solve blank snapshots)
1146
1147         Reviewed by Tim Horton.
1148
1149         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1150         (TEST):
1151
1152 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1153
1154         clampTo(): do not convert the input to double when dealing with integers
1155         https://bugs.webkit.org/show_bug.cgi?id=194263
1156         <rdar://problem/47692312>
1157
1158         Reviewed by Darin Adler.
1159
1160         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1161         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1162         (TestWebKitAPI::testClampFloatingPointToInteger):
1163         (TestWebKitAPI::testClampSameSignIntegers):
1164         (TestWebKitAPI::testClampUnsignedToSigned):
1165         (TestWebKitAPI::testClampSignedToUnsigned):
1166
1167 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1168
1169         webkitpy: Respect --dedicated-simulators flag
1170         https://bugs.webkit.org/show_bug.cgi?id=194416
1171         <rdar://problem/47894722>
1172
1173         Reviewed by Lucas Forschler.
1174
1175         * Scripts/webkitpy/port/device_port.py:
1176         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1177         available devices can be safely ignored.
1178
1179 2019-02-07  Keith Rollin  <krollin@apple.com>
1180
1181         Remove extra copy of 100x100-red.tga
1182         https://bugs.webkit.org/show_bug.cgi?id=194371
1183         <rdar://problem/47873465>
1184
1185         Reviewed by Said Abou-Hallawa.
1186
1187         In order to help it pass its tests, Bug 194190 added a second copy of
1188         the file 100x100-red.tga. However, it turns out that this additional
1189         file wasn't actually needed, and that that sole previous copy was
1190         sufficient. At the same time, this second copy -- which was copied to
1191         the same location in the build output as the first copy -- now caused
1192         XCBuild to complain because there were two production rules for the
1193         same output file. Address this by removing the newly-added extra copy.
1194
1195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1196         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1197
1198 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1199
1200         Deprecate WKBundlePageSetDefersLoading
1201         https://bugs.webkit.org/show_bug.cgi?id=191394
1202
1203         Reviewed by Dean Jackson.
1204
1205         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1206         (WTR::TestRunner::setDefersLoading):
1207
1208 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1209
1210         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1211         https://bugs.webkit.org/show_bug.cgi?id=194391
1212
1213         Reviewed by Antti Koivisto.
1214
1215         * LayoutReloaded/misc/LFC-passing-tests.txt:
1216
1217 2019-02-06  Keith Rollin  <krollin@apple.com>
1218
1219         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1220         https://bugs.webkit.org/show_bug.cgi?id=193975
1221         <rdar://problem/47643306>
1222
1223         Reviewed by Tim Horton.
1224
1225         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1226         the Info.plist file into the bundle. This step is not necessary as the
1227         implicit "bundle up all the build products into a framework" build
1228         phase does this already. Having the Copy Bundle Resources phase do
1229         this causes a conflict under XCBuild, which objects to two build
1230         phases producing the same file (Info.plist). Address this by removing
1231         Info.plist from the Copy Bundle Resources phase.
1232
1233         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1234
1235 2019-02-06  Keith Rollin  <krollin@apple.com>
1236
1237         Really enable the automatic checking and regenerations of .xcfilelists during builds
1238         https://bugs.webkit.org/show_bug.cgi?id=194357
1239         <rdar://problem/47861231>
1240
1241         Reviewed by Chris Dumez.
1242
1243         Bug 194124 was supposed to enable the automatic checking and
1244         regenerating of .xcfilelist files during the build. While related
1245         changes were included in that patch, the change to actually enable the
1246         operation somehow was omitted. This patch actually enables the
1247         operation. The check-xcfilelist.sh scripts now check
1248         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1249         from the checking.
1250
1251         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1252         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1253
1254 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1255
1256         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1257         <https://webkit.org/b/194286>
1258         <rdar://problem/47815558>
1259
1260         Reviewed by Alexey Proskuryakov.
1261
1262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1263         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1264         WKRetainPtr<> to avoid leaking the WKDataRef.
1265
1266 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1267
1268         Unreviewed, fix a typo
1269
1270         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1271
1272 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1273
1274         [GTK][WPE] force libpsl build to use ICU in jhbuild
1275         https://bugs.webkit.org/show_bug.cgi?id=194288
1276
1277         Reviewed by Carlos Garcia Campos.
1278
1279         * gtk/jhbuild.modules:
1280         Require ICU for libpsl build in jhbuild, like done in WPE.
1281
1282 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1283
1284         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1285         https://bugs.webkit.org/show_bug.cgi?id=194209
1286
1287         Reviewed by Carlos Garcia Campos.
1288
1289         Enhance TestCookieManager to ensure this doesn't happen again.
1290
1291         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1292         (testCookieManagerPersistentStorage):
1293         (beforeAll):
1294
1295 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1296
1297         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1298         https://bugs.webkit.org/show_bug.cgi?id=194324
1299
1300         Reviewed by Andy Estes.
1301
1302         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1303         part of the name is already implicit, since this is in testing code in TestOptions.
1304
1305         * WebKitTestRunner/TestController.cpp:
1306         (WTR::TestController::generateContextConfiguration const):
1307         (WTR::updateTestOptionsFromTestHeader):
1308         * WebKitTestRunner/TestOptions.h:
1309         (WTR::TestOptions::hasSameInitializationOptions const):
1310
1311 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1312
1313         [ews-build] Allow * as platform for builders and workers
1314         https://bugs.webkit.org/show_bug.cgi?id=188533
1315
1316         Reviewed by Lucas Forschler.
1317
1318         * BuildSlaveSupport/ews-build/loadConfig.py:
1319         (checkWorkersAndBuildersForConsistency):
1320
1321 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1322
1323         [ews-build] Add few bots to config.json
1324         https://bugs.webkit.org/show_bug.cgi?id=194304
1325
1326         Reviewed by Lucas Forschler.
1327
1328         * BuildSlaveSupport/ews-build/config.json:
1329
1330 2019-02-05  Keith Rollin  <krollin@apple.com>
1331
1332         Enable the automatic checking and regenerations of .xcfilelists during builds
1333         https://bugs.webkit.org/show_bug.cgi?id=194124
1334         <rdar://problem/47721277>
1335
1336         Reviewed by Tim Horton.
1337
1338         Bug 193790 add a facility for checking -- during build time -- that
1339         any needed .xcfilelist files are up-to-date and for updating them if
1340         they are not. This facility was initially opt-in by setting
1341         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1342         the process seemed robust. Its now time to enable this facility and
1343         make it opt-out. If there is a need to disable this facility, set and
1344         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1345         running `make` or `build-webkit`, or before running Xcode from the
1346         command line.
1347
1348         Additionally, remove the step that generates a list of source files
1349         going into the UnifiedSources build step. It's only necessarily to
1350         specify Sources.txt and SourcesCocoa.txt as inputs.
1351
1352         * Scripts/generate-xcfilelists:
1353
1354 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1355
1356         [GTK][WPE] force libpsl build to use ICU in jhbuild
1357         https://bugs.webkit.org/show_bug.cgi?id=194288
1358
1359         Reviewed by Philippe Normand.
1360
1361         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1362         This can cause build failures if libidn is detected but libunistring is not available.
1363
1364         Make sure that ICU is used for runtime and builtin PSL data.
1365
1366         * gtk/jhbuild.modules:
1367         * wpe/jhbuild.modules:
1368
1369 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1370
1371         [ews-app] Modified timestamp should be updated on updating data
1372         https://bugs.webkit.org/show_bug.cgi?id=194295
1373
1374         Reviewed by Lucas Forschler.
1375
1376         * BuildSlaveSupport/ews-app/ews/models/build.py:
1377         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1378         * BuildSlaveSupport/ews-app/ews/models/step.py:
1379
1380 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1381
1382         Unreviewed, rolling out r240742.
1383
1384         Causes crashes on iOS simulator.
1385
1386         Reverted changeset:
1387
1388         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1389         not focused in a content-editable element"
1390         https://bugs.webkit.org/show_bug.cgi?id=192824
1391         https://trac.webkit.org/changeset/240742
1392
1393 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1394
1395         run-webkit-tests emits message "...running None" when running tests
1396         https://bugs.webkit.org/show_bug.cgi?id=194133
1397         <rdar://problem/47724738>
1398
1399         Reviewed by Lucas Forschler.
1400
1401         * Scripts/webkitpy/xcode/device_type.py:
1402         (DeviceType.__str__): Use both version mapping tables and use just the variant
1403         name if no version name is available.
1404         * Scripts/webkitpy/xcode/device_type_unittest.py:
1405         (DeviceTypeTest):
1406         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1407         an associated named.
1408
1409 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1410
1411         [WPE] require python3-setuptools for meson build in jhbuild
1412         https://bugs.webkit.org/show_bug.cgi?id=194287
1413
1414         Reviewed by Philippe Normand.
1415
1416         python3-setuptools is needed to build meson in jhbuild.
1417         It is already required by the GTK port.
1418
1419         * wpe/install-dependencies:
1420
1421 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1422
1423         [ews-app] Add method to save BuilderMapping to database
1424         https://bugs.webkit.org/show_bug.cgi?id=194264
1425
1426         Reviewed by Lucas Forschler.
1427
1428         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1429         (BuilderMapping.__str__):
1430         (BuilderMapping):
1431         (BuilderMapping.save_mapping):
1432         (BuilderMapping.update_mapping):
1433         (BuilderMapping.get_existing_mapping):
1434         (BuilderMapping.is_valid_mapping):
1435
1436 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1437
1438         [ews-app] Add timestamp fields for BuilderMappings
1439         https://bugs.webkit.org/show_bug.cgi?id=194266
1440
1441         Reviewed by Lucas Forschler.
1442
1443         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1444         (BuilderMapping):
1445
1446 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1447
1448         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1449         https://bugs.webkit.org/show_bug.cgi?id=174816
1450
1451         Reviewed by Michael Catanzaro.
1452
1453         Add tests for webkit_uri_for_display().
1454
1455         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1456         (testURIForDisplayUnaffected):
1457         (testURIForDisplayAffected):
1458         (beforeAll):
1459         (afterAll):
1460         * TestWebKitAPI/glib/CMakeLists.txt:
1461
1462 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1463
1464         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1465         https://bugs.webkit.org/show_bug.cgi?id=194158
1466         <rdar://problem/47737268>
1467
1468         Rubber-stamped by Aakash Jain.
1469
1470         * Scripts/webkitpy/port/device_port.py:
1471         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1472
1473 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1474
1475         [CG] Enable setAdditionalSupportedImageTypes for WK1
1476         https://bugs.webkit.org/show_bug.cgi?id=194190
1477
1478         Reviewed by Tim Horton.
1479
1480         Add a test similar to the one under WebKit Cocoa but make it create a
1481         WebView instead of a WKWebView.
1482
1483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1484         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1485         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1486         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1487         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1488         (TestWebKitAPI::runTest):
1489         (TestWebKitAPI::TEST):
1490
1491 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1492
1493         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1494         https://bugs.webkit.org/show_bug.cgi?id=194168
1495
1496         Reviewed by Simon Fraser.
1497
1498         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1499
1500         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1501         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1502         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1503         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1504         (TEST):
1505         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1506         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1507
1508 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1509
1510         REGRESSION (r237269): webkit-patch what-broke is broken 
1511         https://bugs.webkit.org/show_bug.cgi?id=193025
1512
1513         Reviewed by Aakash Jain.
1514
1515         * Scripts/webkitpy/common/host.py:
1516         (Host.buildbot):
1517         (Host.bugzilla): Renamed to 'buildbot'.
1518
1519 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1520
1521         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1522         https://bugs.webkit.org/show_bug.cgi?id=194207
1523
1524         Reviewed by Tim Horton.
1525
1526         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1527         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1528         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1529         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1530         start and delete forwards to remove the original attachment.
1531
1532         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1533         (TestWebKitAPI::TEST):
1534
1535 2019-02-04  Youenn Fablet  <youenn@apple.com>
1536
1537         Capture state should be managed consistently when doing process swapping
1538         https://bugs.webkit.org/show_bug.cgi?id=194122
1539         <rdar://problem/47609293>
1540
1541         Reviewed by Eric Carlson.
1542
1543         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1544         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1545         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1546         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1547         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1548         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1549         (WTR::TestRunner::isDoingMediaCapture const):
1550         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1551         * WebKitTestRunner/TestController.cpp:
1552         (WTR::TestController::isDoingMediaCapture const):
1553         * WebKitTestRunner/TestController.h:
1554         * WebKitTestRunner/TestInvocation.cpp:
1555         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1556         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1557         (WTR::TestController::isDoingMediaCapture const):
1558
1559 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1560
1561         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1562         https://bugs.webkit.org/show_bug.cgi?id=194142
1563
1564         Reviewed by Ross Kirsling.
1565
1566         There three 'separator' variables in TestController.cpp. Renamed
1567         it 'pathSeparator', and unified them.
1568
1569         * WebKitTestRunner/TestController.cpp:
1570         (WTR::TestController::generateContextConfiguration const):
1571         (WTR::createTestURL):
1572         (WTR::TestController::platformAdjustContext):
1573
1574 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1575
1576         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1577         https://bugs.webkit.org/show_bug.cgi?id=194198
1578
1579         Reviewed by Antti Koivisto.
1580
1581         No need to set the banner heights on navigation now, since Page stores them.
1582
1583         * MiniBrowser/mac/WK2BrowserWindowController.m:
1584         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1585
1586 2019-02-03  John Wilander  <wilander@apple.com>
1587
1588         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1589         https://bugs.webkit.org/show_bug.cgi?id=194104
1590         <rdar://problem/47649991>
1591
1592         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1593
1594         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1595         (TestWebKitAPI::TEST):
1596             Changed numeric types from unsigned short to uint32_t.
1597
1598 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1599
1600         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1601         <https://webkit.org/b/194178>
1602         <rdar://problem/47753473>
1603
1604         Reviewed by Alexey Proskuryakov.
1605
1606         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1607         (WTR::uninstallFakeHelvetica): Pass nullptr into
1608         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1609
1610 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1611
1612         [LFC] Initialize ICB's style with fixed width/height.
1613         https://bugs.webkit.org/show_bug.cgi?id=194188
1614
1615         Reviewed by Antti Koivisto.
1616
1617         * LayoutReloaded/misc/LFC-passing-tests.txt:
1618
1619 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1620
1621         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1622         https://bugs.webkit.org/show_bug.cgi?id=194185
1623
1624         Reviewed by Antti Koivisto.
1625
1626         * LayoutReloaded/misc/LFC-passing-tests.txt:
1627
1628 2018-12-16  Darin Adler  <darin@apple.com>
1629
1630         Convert additional String::format clients to alternative approaches
1631         https://bugs.webkit.org/show_bug.cgi?id=192746
1632
1633         Reviewed by Alexey Proskuryakov.
1634
1635         * WebKitTestRunner/TestController.cpp:
1636         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1637         as an intermediate in code that ultimately constructs a WTF::String.
1638         (WTR::userMediaOriginHash): Use makeString.
1639         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1640         (WTR::TestController::didPerformClientRedirect): Ditto.
1641         (WTR::TestController::didPerformServerRedirect): Ditto.
1642         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1643
1644 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1645
1646         [ews-build] Add unit test to verify builder keys
1647         https://bugs.webkit.org/show_bug.cgi?id=194152
1648
1649         Reviewed by Lucas Forschler.
1650
1651         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1652         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1653
1654 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1655
1656         [LFC] Expand tests coverage (12 new tests -> 787)
1657
1658         Unreviewed test gardening.
1659
1660         * LayoutReloaded/misc/LFC-passing-tests.txt:
1661
1662 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1663
1664         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1665         https://bugs.webkit.org/show_bug.cgi?id=194163
1666
1667         Reviewed by Simon Fraser.
1668
1669         775
1670
1671         * LayoutReloaded/misc/LFC-passing-tests.txt:
1672
1673 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1674
1675         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1676         https://bugs.webkit.org/show_bug.cgi?id=194140
1677         <rdar://problem/47728098>
1678
1679         Reviewed by Tim Horton.
1680
1681         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1682         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1683         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1684
1685         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1686         test to induce an IPC deadlock when presenting a modal alert during touch start.
1687
1688         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1689         * WebKitTestRunner/TestController.cpp:
1690         (WTR::runJavaScriptAlert):
1691
1692         Add a client callback function for running JavaScript alerts.
1693
1694         (WTR::TestController::createOtherPage):
1695         (WTR::TestController::generateContextConfiguration const):
1696
1697         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1698         the fix in this patch.
1699
1700         (WTR::TestController::createWebViewWithOptions):
1701
1702         Plumb TestOptions to generateContextConfiguration.
1703
1704         (WTR::TestController::resetPreferencesToConsistentValues):
1705         (WTR::TestController::resetStateToConsistentValues):
1706         (WTR::updateTestOptionsFromTestHeader):
1707         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1708         (WTR::TestController::handleJavaScriptAlert):
1709         * WebKitTestRunner/TestController.h:
1710         * WebKitTestRunner/TestInvocation.cpp:
1711         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1712         * WebKitTestRunner/TestOptions.h:
1713         (WTR::TestOptions::hasSameInitializationOptions const):
1714
1715 2019-02-01  Chris Dumez  <cdumez@apple.com>
1716
1717         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1718         https://bugs.webkit.org/show_bug.cgi?id=193740
1719         <rdar://problem/47527267>
1720
1721         Reviewed by Alex Christensen.
1722
1723         Add API test coverage.
1724
1725         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1726
1727 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1728
1729         [ews-app] Add display name field to BuilderMapping model
1730         https://bugs.webkit.org/show_bug.cgi?id=194153
1731
1732         Reviewed by Lucas Forschler.
1733
1734         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1735         (BuilderMapping):
1736
1737 2019-02-01  Youenn Fablet  <youenn@apple.com>
1738
1739         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1740         https://bugs.webkit.org/show_bug.cgi?id=194155
1741
1742         Reviewed by Eric Carlson.
1743
1744         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1745         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1746         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1747
1748 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1749
1750         [LFC] Adjust replaced element's intrinsic ratio
1751         https://bugs.webkit.org/show_bug.cgi?id=194154
1752
1753         Reviewed by Antti Koivisto.
1754
1755         761
1756
1757         * LayoutReloaded/misc/LFC-passing-tests.txt:
1758
1759 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1760
1761         [WPE] Show test results in minibrowser
1762         https://bugs.webkit.org/show_bug.cgi?id=194150
1763
1764         Reviewed by Žan Doberšek.
1765
1766         * Scripts/webkitpy/port/wpe.py:
1767         (WPEPort.show_results_html_file):
1768
1769 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1770
1771         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1772         https://bugs.webkit.org/show_bug.cgi?id=194151
1773
1774         Reviewed by Žan Doberšek.
1775
1776         ALT + <- go back
1777         ALT + -> go forward
1778
1779         * MiniBrowser/wpe/main.cpp:
1780         (main):
1781
1782 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1783
1784         [LFC] Set intrinsic size on Layout::Replaced
1785         https://bugs.webkit.org/show_bug.cgi?id=194139
1786
1787         Reviewed by Antti Koivisto.
1788
1789         744
1790
1791         * LayoutReloaded/misc/LFC-passing-tests.txt:
1792
1793 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1794
1795         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1796         https://bugs.webkit.org/show_bug.cgi?id=194146
1797
1798         Reviewed by Xabier Rodriguez-Calvar.
1799
1800         It allows to open relative paths.
1801
1802         * MiniBrowser/wpe/main.cpp:
1803         (main):
1804
1805 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1806
1807         Update flakiness dashboard configuration after recent queue changes
1808         https://bugs.webkit.org/show_bug.cgi?id=194127
1809
1810         Rubber-stamped by Aakash Jain.
1811
1812         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1813
1814         * TestResultServer/static-dashboards/builders.jsonp:
1815
1816 2019-01-31  Youenn Fablet  <youenn@apple.com>
1817
1818         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1819         https://bugs.webkit.org/show_bug.cgi?id=194106
1820         <rdar://problem/47676333>
1821
1822         Reviewed by Ryosuke Niwa.
1823
1824         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1825         (TestWebKitAPI::didFinishNavigation):
1826         (TestWebKitAPI::TEST):
1827         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1828
1829 2019-01-31  Chris Dumez  <cdumez@apple.com>
1830
1831         Page zoom level is lost after a process swap or a crash
1832         https://bugs.webkit.org/show_bug.cgi?id=194105
1833         <rdar://problem/47610781>
1834
1835         Reviewed by Alex Christensen.
1836
1837         Add API test coverage.
1838
1839         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1840         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1841
1842 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1843
1844         Revert r238819 which is unneeded and caused a performance regression.
1845         https://bugs.webkit.org/show_bug.cgi?id=192272
1846         <rdar://problem/46664625>
1847
1848         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1849         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1850         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1851
1852 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1853
1854         Formalize WebKitAdditions mechanism of LoadOptimizer
1855         https://bugs.webkit.org/show_bug.cgi?id=193886
1856         <rdar://problem/47696809>
1857
1858         Reviewed by Brent Fulgham.
1859
1860         * MiniBrowser/MiniBrowser.entitlements:
1861         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1862
1863 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1864
1865         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1866         https://bugs.webkit.org/show_bug.cgi?id=194090
1867
1868         Reviewed by Antti Koivisto.
1869
1870         * LayoutReloaded/misc/LFC-passing-tests.txt:
1871
1872 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1873
1874         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1875         https://bugs.webkit.org/show_bug.cgi?id=194074
1876
1877         Reviewed by Antti Koivisto.
1878
1879         * LayoutReloaded/misc/LFC-passing-tests.txt:
1880
1881 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1882
1883         [LFC][BFC] Add support for block level replaced box.
1884         https://bugs.webkit.org/show_bug.cgi?id=194071
1885
1886         Reviewed by Antti Koivisto.
1887
1888         * LayoutReloaded/misc/LFC-passing-tests.txt:
1889
1890 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1891
1892         Fix WebKitTestRunner's testPath with Windows full paths
1893         https://bugs.webkit.org/show_bug.cgi?id=194012
1894
1895         Reviewed by Alex Christensen.
1896
1897         updateTestOptionsFromTestHeader failed to open test files because
1898         testPath returned wrong file paths. It returned a path "/C:/..."
1899         if a URL "file:///C:/..." was given.
1900
1901         * WebKitTestRunner/TestController.cpp:
1902         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1903
1904 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1905
1906         [WPE] Bump font related dependencies to match the GTK+ port
1907         https://bugs.webkit.org/show_bug.cgi?id=194017
1908
1909         Reviewed by Žan Doberšek.
1910
1911         * wpe/jhbuild.modules:
1912         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1913         * wpe/patches/icudata-stdlibs.patch: Added.
1914
1915 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1916
1917         Enable swipe tests on iOS
1918         https://bugs.webkit.org/show_bug.cgi?id=194076
1919
1920         Reviewed by Geoffrey Garen.
1921
1922         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1923         it causes a debug assertion failure in runUIScript.
1924
1925         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1926         (WTR::UIScriptController::beginBackSwipe):
1927         (WTR::UIScriptController::completeBackSwipe):
1928
1929 2019-01-30  Keith Rollin  <krollin@apple.com>
1930
1931         Use correct printf format specifier
1932         https://bugs.webkit.org/show_bug.cgi?id=194062
1933         <rdar://problem/47686167>
1934
1935         Reviewed by Alexey Proskuryakov.
1936
1937         LayoutTestSpellChecker.mm is trying to format a variable of type
1938         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1939         actually an unsigned long long. Fix this by formatting with %llu.
1940
1941         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1942         (-[LayoutTestTextCheckingResult description]):
1943
1944 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1945
1946         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1947         https://bugs.webkit.org/show_bug.cgi?id=193979
1948
1949         Reviewed by Wenson Hsieh.
1950
1951         Fix the test for iOS. Make the test work with iOS UA string.
1952
1953         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1954
1955 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1956
1957         Replace High Sierra LLINT CLoop bot due to hardware failure
1958         https://bugs.webkit.org/show_bug.cgi?id=194066
1959
1960         Reviewed by Aakash Jain.
1961
1962         * BuildSlaveSupport/build.webkit.org-config/config.json:
1963
1964 2019-01-30  Keith Rollin  <krollin@apple.com>
1965
1966         [NSDragItem init] is unavailable
1967         https://bugs.webkit.org/show_bug.cgi?id=194059
1968         <rdar://problem/47685715>
1969
1970         Reviewed by Wenson Hsieh.
1971
1972         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1973         DumpRenderTree and TestWebKitAPI, which both try to create an
1974         NSDragItem in a manner that invokes this method. Address this by using
1975         -initWithPasteboardWriter instead.
1976
1977         Note that the parameter passed to initWithPasteboardWriter is likely
1978         incorrect. In both cases, the object passed does not conform to
1979         NSPasteboardWriting. However, with this fix, we're no worse off than
1980         before, and can now perform builds with newer compilers and SDKs until
1981         a real fix can be crafted. That work is tracked in
1982         https://bugs.webkit.org/show_bug.cgi?id=194060
1983
1984         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1985         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1986         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1987         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1988
1989 2019-01-30  Daniel Bates  <dabates@apple.com>
1990
1991         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1992         https://bugs.webkit.org/show_bug.cgi?id=192824
1993         <rdar://problem/47100332>
1994
1995         Reviewed by Wenson Hsieh.
1996
1997         Fix a bug where the wrong usage code was used for F13 thru F24.
1998
1999         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2000         (keyCodeForDOMFunctionKey):
2001
2002 2019-01-30  Chris Dumez  <cdumez@apple.com>
2003
2004         Regression(PSON) Load hang can occur on history navigation
2005         https://bugs.webkit.org/show_bug.cgi?id=194030
2006         <rdar://problem/47656939>
2007
2008         Reviewed by Antti Koivisto.
2009
2010         Add API test coverage.
2011
2012         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2013
2014 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2015
2016         [LFC] Expand tests coverage.
2017
2018         Unreviewed test gardening.
2019
2020         * LayoutReloaded/misc/LFC-passing-tests.txt:
2021
2022 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2023
2024         [Flatpak] Add openjpeg support
2025         https://bugs.webkit.org/show_bug.cgi?id=194019
2026
2027         Reviewed by Michael Catanzaro.
2028
2029         * flatpak/org.webkit.CommonModules.yaml:
2030
2031 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2032
2033         Unreviewed, rolling out r240708.
2034         https://bugs.webkit.org/show_bug.cgi?id=194022
2035
2036         It broke WPE build (Requested by KaL on #webkit).
2037
2038         Reverted changeset:
2039
2040         "[WPE] Bump font related dependencies to match the GTK+ port"
2041         https://bugs.webkit.org/show_bug.cgi?id=194017
2042         https://trac.webkit.org/changeset/240708
2043
2044 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2045
2046         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2047         https://bugs.webkit.org/show_bug.cgi?id=194001
2048
2049         Reviewed by Antti Koivisto.
2050
2051         * LayoutReloaded/misc/LFC-passing-tests.txt:
2052
2053 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2054
2055         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2056         https://bugs.webkit.org/show_bug.cgi?id=194020
2057
2058         Reviewed by Antti Koivisto.
2059
2060         * LayoutReloaded/misc/LFC-passing-tests.txt:
2061
2062 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2063
2064         AX: Support color well on iOS
2065         https://bugs.webkit.org/show_bug.cgi?id=194010
2066
2067         Reviewed by Joanmarie Diggs.
2068
2069         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2070         (WTR::AccessibilityUIElement::stringAttributeValue):
2071
2072 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2073
2074         [WPE] Bump font related dependencies to match the GTK+ port
2075         https://bugs.webkit.org/show_bug.cgi?id=194017
2076
2077         Reviewed by Žan Doberšek.
2078
2079         * wpe/jhbuild.modules:
2080         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2081         * wpe/patches/icudata-stdlibs.patch: Added.
2082
2083 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2084
2085         [Mac] Update window scale API usage
2086         https://bugs.webkit.org/show_bug.cgi?id=193991
2087         rdar://problem/47614795
2088
2089         Reviewed by Tim Horton.
2090
2091         * DumpRenderTree/mac/DumpRenderTree.mm:
2092         (changeWindowScaleIfNeeded):
2093         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2094         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2095         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2096
2097 2019-01-29  Chris Dumez  <cdumez@apple.com>
2098
2099         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2100         https://bugs.webkit.org/show_bug.cgi?id=193977
2101         <rdar://problem/47643716>
2102
2103         Reviewed by Geoff Garen.
2104
2105         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2106         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2107         to the previous provisional committing *before* we make the last load. 
2108
2109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2110
2111 2019-01-29  Youenn Fablet  <youenn@apple.com>
2112
2113         Adopt new SPI to evaluate server certificate trust
2114         https://bugs.webkit.org/show_bug.cgi?id=193355
2115
2116         Reviewed by Alex Christensen.
2117
2118         Add infrastructure to handle HTTPS server trust evaluation testing.
2119
2120         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2121         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2122         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2123         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2124         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2125         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2126         * WebKitTestRunner/TestController.cpp:
2127         (WTR::TestController::resetPreferencesToConsistentValues):
2128         (WTR::TestController::didReceiveAuthenticationChallenge):
2129         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2130         * WebKitTestRunner/TestController.h:
2131         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2132         * WebKitTestRunner/TestInvocation.cpp:
2133         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2134         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2135         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2136
2137 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2138
2139         [ews-build] Add build step to print bot Configuration
2140         https://bugs.webkit.org/show_bug.cgi?id=193887
2141
2142         Reviewed by Lucas Forschler.
2143
2144         * BuildSlaveSupport/ews-build/steps.py:
2145         (PrintConfiguration): Build step to print configuration.
2146         * BuildSlaveSupport/ews-build/factories.py:
2147
2148 2019-01-29  Chris Dumez  <cdumez@apple.com>
2149
2150         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2151         https://bugs.webkit.org/show_bug.cgi?id=193967
2152         <rdar://problem/47635348>
2153
2154         Reviewed by Alex Christensen.
2155
2156         Add API test coverage.
2157
2158         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2159         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2160
2161 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2162
2163         [ews-app] Handle incoming results data
2164         https://bugs.webkit.org/show_bug.cgi?id=193973
2165
2166         Reviewed by Lucas Forschler.
2167
2168         * BuildSlaveSupport/ews-app/ews/views/results.py:
2169
2170 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2171
2172         [ews-app] Make the results url generic
2173         https://bugs.webkit.org/show_bug.cgi?id=193928
2174
2175         Reviewed by Lucas Forschler.
2176
2177         * BuildSlaveSupport/ews-app/ews/urls.py:
2178
2179 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2180
2181         [ews-build] Configure buildbot to send events to ews-app
2182         https://bugs.webkit.org/show_bug.cgi?id=193968
2183
2184         Reviewed by Lucas Forschler.
2185
2186         * BuildSlaveSupport/ews-build/events.py: Added.
2187         * BuildSlaveSupport/ews-build/master.cfg:
2188
2189 2019-01-29  Keith Rollin  <krollin@apple.com>
2190
2191         Add .xcfilelists to Run Script build phases
2192         https://bugs.webkit.org/show_bug.cgi?id=193792
2193         <rdar://problem/47201785>
2194
2195         Reviewed by Alex Christensen.
2196
2197         As part of supporting XCBuild, update the necessary Run Script build
2198         phases in their Xcode projects to refer to their associated
2199         .xcfilelist files.
2200
2201         Note that the addition of these files bumps the Xcode project version
2202         number to something that's Xcode 10 compatible. This change means that
2203         older versions of the Xcode IDE can't read these projects. Nor can it
2204         fully load workspaces that refer to these projects (the updated
2205         projects are shown as non-expandable placeholders). `xcodebuild` can
2206         still build these projects; it's just that the IDE can't open them.
2207
2208         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2209         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2210
2211 2019-01-29  John Wilander  <wilander@apple.com>
2212
2213         Add data abstraction and validation for Ad Click Attribution
2214         https://bugs.webkit.org/show_bug.cgi?id=193916
2215         <rdar://problem/47603481>
2216
2217         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2218
2219         Ad click attribution has two steps. First, the storage of an ad
2220         campaign ID for a click that takes the user to a destination
2221         site. Second, a conversion on the destination site that can be
2222         attributed to the ad click.
2223
2224         This patch adds a class that represents a request for ad click
2225         attribution. Validation makes sure that the bits of entropy
2226         reported through this mechanism is limited.
2227
2228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2229         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2230         (TestWebKitAPI::TEST):
2231
2232 2019-01-29  Chris Dumez  <cdumez@apple.com>
2233
2234         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2235         https://bugs.webkit.org/show_bug.cgi?id=193932
2236         <rdar://problem/47598947>
2237
2238         Reviewed by Brady Eidson.
2239
2240         Add API test coverage.
2241
2242         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2243
2244 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2245
2246         Adding new passing LFC tests.
2247
2248         Unreviewed test gardening.
2249
2250         * LayoutReloaded/misc/LFC-passing-tests.txt:
2251
2252 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2253
2254         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2255         https://bugs.webkit.org/show_bug.cgi?id=193964
2256
2257         Reviewed by Antti Koivisto.
2258
2259         * LayoutReloaded/misc/LFC-passing-tests.txt:
2260
2261 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2262
2263         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2264         https://bugs.webkit.org/show_bug.cgi?id=193954
2265
2266         Reviewed by Antti Koivisto.
2267
2268         * LayoutReloaded/misc/LFC-passing-tests.txt:
2269
2270 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2271
2272         WebDriver: add support for running subtests
2273         https://bugs.webkit.org/show_bug.cgi?id=193904
2274
2275         Reviewed by Michael Catanzaro.
2276
2277         pytest already supports it by passing test.py::subtest, so we can do the same.
2278
2279         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2280         (get_item_name): Made this global.
2281         (CollectRecorder.__init__): Receive the parameter to ignore.
2282         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2283         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2284         (collect): Add parameter to ignore.
2285         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2286         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2287         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2288         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2289         (WebDriverTestRunnerSelenium.run): Ditto.
2290         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2291         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2292         (WebDriverTestRunnerW3C.run): Ditto.
2293
2294 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2295
2296         User agent string override for navigator.userAgent should be site specific quirks
2297         https://bugs.webkit.org/show_bug.cgi?id=193950
2298
2299         Reviewed by Brent Fulgham.
2300
2301         Updated per the _WKWebsitePolicies rename.
2302
2303         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2304         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2305
2306 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2307
2308         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2309         https://bugs.webkit.org/show_bug.cgi?id=193941
2310
2311         Reviewed by Alex Christensen.
2312
2313         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2314         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2315         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2316         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2317         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2318         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2319         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2320         * TestWebKitAPI/Tests/WTF/Time.cpp:
2321         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2322         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2323         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2324         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2325
2326 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2327
2328         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2329
2330         * Scripts/webkitpy/common/config/contributors.json:
2331
2332 2019-01-28  Andy Estes  <aestes@apple.com>
2333
2334         [watchOS] Enable Parental Controls content filtering
2335         https://bugs.webkit.org/show_bug.cgi?id=193939
2336         <rdar://problem/46641912>
2337
2338         Reviewed by Ryosuke Niwa.
2339
2340         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2341
2342 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2343
2344         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2345         <https://webkit.org/b/193884>
2346
2347         Reviewed by Jiewen Tan.
2348
2349         * Scripts/webkitpy/style/checkers/cpp.py:
2350         (check_language): Add LocalAuthentication to
2351         `frameworks_with_soft_links`.
2352
2353 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2354
2355         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2356         https://bugs.webkit.org/show_bug.cgi?id=193891
2357
2358         Reviewed by Ross Kirsling.
2359
2360         There were three problems in window sizes of WebView and the host window.
2361         1. The sizes of pixel image output were incorrect.
2362         2. The host window is going to appear after window.resize was invoked.
2363         3. window.resize resized only the host window, not WebView.
2364
2365         This change solves them with a following approach.
2366         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2367         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2368            as well as DumpRenderTree in order to match the client area and the window area.
2369         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2370         d. PlatformWebView::setWindowFrame changes both window sizes.
2371         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2372
2373         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2374         (WTR::PlatformWebView::PlatformWebView): Create the host window
2375         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2376         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2377         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2378
2379 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2380
2381         [ews-app] Add method to save Step data to database
2382         https://bugs.webkit.org/show_bug.cgi?id=193890
2383
2384         Reviewed by Lucas Forschler.
2385
2386         * BuildSlaveSupport/ews-app/ews/models/step.py:
2387         (Step.save_step): Method to save step data.
2388         (Step.update_step): Method to update step data.
2389         (Step.get_existing_step): Method to fetch existing step from database.
2390         (Step.is_valid_result): Method to validate valid step result.
2391
2392 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2393
2394         [ews-app] Add method to save Build data to database
2395         https://bugs.webkit.org/show_bug.cgi?id=193735
2396
2397         Reviewed by Lucas Forschler.
2398
2399         * BuildSlaveSupport/ews-app/ews/models/build.py:
2400         (Build.save_build): Method to save build information to database.
2401         (Build.get_existing_build): Method to fetch existing build from database.
2402         (Build.is_valid_result): Method to validate build result.
2403         * BuildSlaveSupport/ews-app/ews/common/util.py:
2404         (is_valid_int_id): Method to validate valid id.
2405
2406 2019-01-28  Chris Dumez  <cdumez@apple.com>
2407
2408         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2409         https://bugs.webkit.org/show_bug.cgi?id=193915
2410         <rdar://problem/47560907>
2411
2412         Reviewed by Alex Christensen.
2413
2414         Add API test coverage.
2415
2416         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2417
2418 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2419
2420         [ews-app] Rename id variables
2421         https://bugs.webkit.org/show_bug.cgi?id=193883
2422
2423         Reviewed by Lucas Forschler.
2424
2425         * BuildSlaveSupport/ews-app/ews/models/build.py:
2426         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2427         * BuildSlaveSupport/ews-app/ews/models/step.py:
2428         * BuildSlaveSupport/ews-app/ews/urls.py:
2429         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2430         * BuildSlaveSupport/ews-app/ews/views/results.py:
2431         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2432
2433 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2434
2435         [ews-app] Allow certain fields to be empty
2436         https://bugs.webkit.org/show_bug.cgi?id=193892
2437
2438         Reviewed by Lucas Forschler.
2439
2440         * BuildSlaveSupport/ews-app/ews/models/build.py:
2441         * BuildSlaveSupport/ews-app/ews/models/step.py:
2442
2443 2019-01-28  Rob Buis  <rbuis@igalia.com>
2444
2445         Update MIME type parser
2446         https://bugs.webkit.org/show_bug.cgi?id=180526
2447
2448         Reviewed by Frédéric Wang.
2449
2450         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2451         (TestWebKitAPI::TEST):
2452
2453 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2454
2455         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2456         https://bugs.webkit.org/show_bug.cgi?id=193896
2457
2458         Reviewed by Antti Koivisto.
2459
2460         * LayoutReloaded/misc/LFC-passing-tests.txt:
2461
2462 2018-12-15  Darin Adler  <darin@apple.com>
2463
2464         Replace many uses of String::format with more type-safe alternatives
2465         https://bugs.webkit.org/show_bug.cgi?id=192742
2466
2467         Reviewed by Mark Lam.
2468
2469         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2470         (WTR::cacheTestRunnerCallback): Use makeString.
2471         * WebKitTestRunner/TestController.cpp:
2472         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2473         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2474
2475 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2476
2477         Use a load optimizer for some sites
2478         https://bugs.webkit.org/show_bug.cgi?id=193881
2479         <rdar://problem/46325455>
2480
2481         Reviewed by Brent Fulgham.
2482
2483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2484         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2485
2486 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2487
2488         AX: Introduce a static accessibility tree
2489         https://bugs.webkit.org/show_bug.cgi?id=193348
2490         <rdar://problem/47203295>
2491
2492         Reviewed by Ryosuke Niwa.
2493
2494         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2495
2496 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2497
2498         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2499         https://bugs.webkit.org/show_bug.cgi?id=193867
2500
2501         Reviewed by Antti Koivisto.
2502
2503         * LayoutReloaded/misc/LFC-passing-tests.txt:
2504
2505 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2506
2507         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2508         https://bugs.webkit.org/show_bug.cgi?id=193865
2509
2510         Reviewed by Antti Koivisto.
2511
2512         * LayoutReloaded/misc/LFC-passing-tests.txt:
2513
2514 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2515
2516         Need a mechanism to override navigator.userAgent
2517         https://bugs.webkit.org/show_bug.cgi?id=193762
2518         <rdar://problem/47504939>
2519
2520         Reviewed by Brent Fulgham.
2521
2522         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2523
2524         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2525         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2526         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2527
2528 2019-01-25  Dean Jackson  <dino@apple.com>
2529
2530         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2531         https://bugs.webkit.org/show_bug.cgi?id=193831
2532         <rdar://problem/47399263>
2533
2534         Reviewed by Chris Dumez.
2535
2536         Two new tests that exercise cross-origin and same-origin System
2537         Previews.
2538
2539         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2540
2541 2019-01-25  Keith Rollin  <krollin@apple.com>
2542
2543         Update Xcode projects with "Check .xcfilelists" build phase
2544         https://bugs.webkit.org/show_bug.cgi?id=193790
2545         <rdar://problem/47201374>
2546
2547         Reviewed by Alex Christensen.
2548
2549         Support for XCBuild includes specifying inputs and outputs to various
2550         Run Script build phases. These inputs and outputs are specified as
2551         .xcfilelist files. Once created, these .xcfilelist files need to be
2552         kept up-to-date. In order to check that they are up-to-date or not,
2553         add an Xcode build step that invokes an external script that performs
2554         the checking. If the .xcfilelists are found to be out-of-date, update
2555         them, halt the build, and instruct the developer to restart the build
2556         with up-to-date files.
2557
2558         At this time, the checking and regenerating is performed only if the
2559         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2560         who want to use this facility can set this variable and test out the
2561         checking/regenerating. Once it seems like there are no egregious
2562         issues that upset a developer's workflow, we'll unconditionally enable
2563         this facility.
2564
2565         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2566         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2567         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2568         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2569
2570 2019-01-25  Keith Rollin  <krollin@apple.com>
2571
2572         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2573         https://bugs.webkit.org/show_bug.cgi?id=193781
2574         <rdar://problem/47201153>
2575
2576         Reviewed by Alex Christensen.
2577
2578         Part of generating the .xcfilelists used as part of adopting XCBuild
2579         includes running `make DerivedSources.make` from a standalone script.
2580         It’s important for this invocation to have the same environment as
2581         when the actual build invokes `make DerivedSources.make`. If the
2582         environments are different, then the two invocations will provide
2583         different results. In order to get the same environment in the
2584         standalone script, have the script launch xcodebuild targeting the
2585         "Apply Configuration to XCFileLists" build target, which will then
2586         re-invoke our standalone script. The script is now running again, this
2587         time in an environment with all workspace, project, target, xcconfig
2588         and other environment variables established.
2589
2590         The "Apply Configuration to XCFileLists" build target accomplishes
2591         this task via a small embedded shell script that consists only of:
2592
2593             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2594
2595         The process that invokes "Apply Configuration to XCFileLists" first
2596         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2597         evaluated and exports it into the shell environment. When xcodebuild
2598         is invoked, it inherits the value of this variable and can `eval` the
2599         contents of that variable. Our external standalone script can then set
2600         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2601         of command-line parameters needed to restart itself in the appropriate
2602         state.
2603
2604         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2605         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2606
2607 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2608
2609         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2610         https://bugs.webkit.org/show_bug.cgi?id=193802
2611         <rdar://problem/46010580>
2612
2613         Reviewed by Andy Estes.
2614
2615         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2616         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2617         (TEST):
2618
2619 2019-01-25  Daniel Bates  <dabates@apple.com>
2620
2621         [iOS] uiController.keyDown() does not translate Control modified key
2622         https://bugs.webkit.org/show_bug.cgi?id=192898
2623
2624         Reviewed by Wenson Hsieh.
2625
2626         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2627         key translation, as applicable. Among other cases, key translation occurs when performing
2628         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2629         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2630         human pressing down and releasing key(s) using a hardware keyboard.
2631
2632         * WebKitTestRunner/ios/HIDEventGenerator.h:
2633         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2634         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2635
2636         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2637         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2638         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2639         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2640         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2641         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2642         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2643         (-[HIDEventGenerator longPress:completionBlock:]):
2644         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2645         Update code for above renaming.
2646
2647         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2648         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2649
2650         (-[HIDEventGenerator keyDown:]): Added.
2651         (-[HIDEventGenerator keyUp:]): Added.
2652         (-[HIDEventGenerator keyPress:completionBlock:]):
2653         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2654         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2655         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2656         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2657         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2658         (WTR::parseModifier): Deleted.
2659
2660 2019-01-25  Keith Rollin  <krollin@apple.com>
2661
2662         Complete the implementation of generate-xcfilelists
2663         https://bugs.webkit.org/show_bug.cgi?id=193782
2664
2665         Reviewed by Alex Christensen.
2666
2667         A preliminary version of generate-xcfilelists was added in r238008.
2668         This patch updates that script in order to:
2669
2670         - Support checking of .xcfilelists
2671         - Perform better execution of `make DerivedSources.make` by
2672           relaunching generate-xcfilelists under xcodebuild
2673         - Support incremental generation and checking of .xcfilelists
2674         - Support supplementary .xcfilelists files from WebKitAdditions
2675         - Support being wrapped by parallel version of generate-xcfilelists in
2676           Internal that adds support for (re)generating WebKit projects in
2677           that repo.
2678         - Support builds that have been performed in WebKitBuild as well as
2679           ~/Library/Developer/code/DerivedData
2680         - Increase robustness and debugging facilities.
2681
2682         * Scripts/generate-xcfilelists:
2683
2684 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2685
2686         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2687         https://bugs.webkit.org/show_bug.cgi?id=193297
2688         <rdar://problem/47158841>
2689
2690         Unreviewed test case fix.
2691
2692         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2693         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2694
2695         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2696         (TEST):
2697
2698 2019-01-25  Keith Rollin  <krollin@apple.com>
2699
2700         Update existing .xcfilelists
2701         https://bugs.webkit.org/show_bug.cgi?id=193791
2702         <rdar://problem/47201706>
2703
2704         Reviewed by Alex Christensen.
2705
2706         Many .xcfilelist files were added in r238824 in order to support
2707         XCBuild. Update these with recent changes to the set of build files
2708         and with the current generate-xcfilelist script.
2709
2710         * DumpRenderTree/DerivedSources-input.xcfilelist:
2711         * DumpRenderTree/DerivedSources-output.xcfilelist:
2712         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2713         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2714
2715 2019-01-25  Keith Rollin  <krollin@apple.com>
2716
2717         Fix missing dependencies in extract-dependencies-from-makefile
2718         https://bugs.webkit.org/show_bug.cgi?id=193783
2719         <rdar://problem/47201571>
2720
2721         Reviewed by Alex Christensen.
2722
2723         The extract-dependencies-from-makefile script generates .xcfilelists
2724         for XCBuild by invoking a makefile in --debug mode, parsing the
2725         dependency information in the output, and extracting information
2726         regarding targets and dependents. However, the way `make` emits this
2727         dependency information is not rigorous, and so we need to determine
2728         what lines to look for and parse by trial and error. This approach
2729         didn't coriginally atch all the information we needed to collect, so
2730         update the script to look for the additional lines we now know to look
2731         for.
2732
2733         * Scripts/extract-dependencies-from-makefile:
2734         (Parser):
2735         (Parser.addTarget):
2736         (Parser.addPrereq):
2737         (Parser.doParse):
2738
2739 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2740
2741         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2742         https://bugs.webkit.org/show_bug.cgi?id=193297
2743         <rdar://problem/47158841>
2744
2745         Reviewed by Alex Christensen.
2746
2747         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2748             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2749         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2750         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2751         activating the message used to trigger the callback when it is set.
2752
2753 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2754
2755         WKWebView.goBack should reload if there is a safe browsing warning
2756         https://bugs.webkit.org/show_bug.cgi?id=193805
2757         <rdar://problem/46908216>
2758
2759         Reviewed by Geoff Garen.
2760
2761         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2762         (+[Simple3LookupContext sharedLookupContext]):
2763         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2764         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2765         (TEST):
2766
2767 2019-01-25  Chris Dumez  <cdumez@apple.com>
2768
2769         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2770         https://bugs.webkit.org/show_bug.cgi?id=193788
2771         <rdar://problem/47531231>
2772
2773         Reviewed by Alex Christensen.
2774
2775         Add API test coverage.
2776
2777         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2778         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2779
2780 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2781
2782         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2783         https://bugs.webkit.org/show_bug.cgi?id=193771
2784
2785         Unreviewed infrastructure fix.
2786
2787         * Scripts/webkitpy/port/darwin.py:
2788         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2789
2790 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2791
2792         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2793
2794 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2795
2796         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2797
2798         * Scripts/webkitpy/common/config/contributors.json:
2799
2800 2019-01-25  Chris Dumez  <cdumez@apple.com>
2801
2802         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2803         https://bugs.webkit.org/show_bug.cgi?id=193779
2804         <rdar://problem/46170903>
2805
2806         Reviewed by Antti Koivisto.
2807
2808         Add API test that quickly navigates forward to a previous process without waiting for it to
2809         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2810         the process' previous page when reconnecting the it for the forward navigation.
2811
2812         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2813
2814 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2815
2816         Need a way for JavaScript (or bundle) code to participate in undo
2817         https://bugs.webkit.org/show_bug.cgi?id=190009
2818         <rdar://problem/44807048>
2819
2820         Reviewed by Ryosuke Niwa.
2821
2822         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2823         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2824
2825         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2826         (WTR::UIScriptController::lastUndoLabel const):
2827         (WTR::UIScriptController::firstRedoLabel const):
2828         (WTR::UIScriptController::platformUndoManager const):
2829         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2830         (WTR::UIScriptController::lastUndoLabel const):
2831         (WTR::UIScriptController::firstRedoLabel const):
2832         (WTR::UIScriptController::platformUndoManager const):
2833         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2834         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2835         (WTR::UIScriptController::lastUndoLabel const):
2836         (WTR::UIScriptController::firstRedoLabel const):
2837         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2838         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2839         (WTR::UIScriptController::lastUndoLabel const):
2840         (WTR::UIScriptController::firstRedoLabel const):
2841         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2842         (WTR::UIScriptController::platformUndoManager const):
2843         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2844         (WTR::UIScriptController::platformUndoManager const):
2845
2846 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2847
2848         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2849         https://bugs.webkit.org/show_bug.cgi?id=193824
2850
2851         Reviewed by Antti Koivisto.
2852
2853         * LayoutReloaded/misc/LFC-passing-tests.txt:
2854
2855 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2856
2857         Update macOS JSC bot configurations
2858         https://bugs.webkit.org/show_bug.cgi?id=193739
2859
2860         Reviewed by Alexey Proskuryakov.
2861
2862         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2863         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2864         (BubbleQueueServer): Move JSC EWS to Mojave section.
2865         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2866         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2867         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2868
2869 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2870
2871         [Win][WebKitTestRunner] Implement EventSenderProxy
2872         https://bugs.webkit.org/show_bug.cgi?id=193755
2873
2874         Reviewed by Don Olmstead.
2875
2876         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2877         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2878         (WTR::EventSenderProxy::dispatchMessage):
2879         (WTR::EventSenderProxy::EventSenderProxy):
2880         (WTR::EventSenderProxy::mouseDown):
2881         (WTR::EventSenderProxy::mouseUp):
2882         (WTR::EventSenderProxy::mouseMoveTo):
2883         (WTR::EventSenderProxy::mouseScrollBy):
2884         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2885
2886 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2887
2888         Unreviewed fix for API test failure after r240437.
2889
2890         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2891
2892         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2893
2894 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2895
2896         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2897         https://bugs.webkit.org/show_bug.cgi?id=193787
2898         <rdar://problem/47497634>
2899
2900         Reviewed by Alexey Proskuryakov.
2901
2902         * Scripts/webkitdirs.pm:
2903         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2904
2905 2019-01-24  Truitt Savell  <tsavell@apple.com>
2906
2907         Unreviewed, rolling out r240446.
2908
2909         Casued 5 API failures
2910
2911         Reverted changeset:
2912
2913         "Activate the WebResourceLoadStatisticsStore in the
2914         NetworkProcess and deactivate it in the UIProcess."
2915         https://bugs.webkit.org/show_bug.cgi?id=193297
2916         https://trac.webkit.org/changeset/240446
2917
2918 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2919
2920         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2921         https://bugs.webkit.org/show_bug.cgi?id=193741
2922         <rdar://problem/47135030>
2923
2924         Reviewed by Antti Koivisto and Simon Fraser.
2925
2926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2927         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2928         (TestWebKitAPI::TEST):
2929
2930 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2931
2932         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2933         https://bugs.webkit.org/show_bug.cgi?id=193297
2934         <rdar://problem/47158841>
2935
2936         Reviewed by Alex Christensen.
2937
2938         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2939         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2940         activating the message used to trigger the callback when it is set.
2941
2942 2019-01-24  John Wilander  <wilander@apple.com>
2943
2944         Add Ad Click Attribution as an internal/experimental feature
2945         https://bugs.webkit.org/show_bug.cgi?id=193685
2946         <rdar://problem/47450399>
2947
2948         Reviewed by Brent Fulgham.
2949
2950         Added test option adClickAttributionEnabled.
2951
2952         * DumpRenderTree/TestOptions.cpp:
2953         (TestOptions::TestOptions):
2954         * DumpRenderTree/TestOptions.h:
2955         * DumpRenderTree/mac/DumpRenderTree.mm:
2956         (setWebPreferencesForTestOptions):
2957
2958 2019-01-24  Antti Koivisto  <antti@apple.com>
2959
2960         [PSON] Flash on back navigation on Mac
2961         https://bugs.webkit.org/show_bug.cgi?id=193716
2962         <rdar://problem/47148458>
2963
2964         Reviewed by Chris Dumez.
2965
2966         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2967
2968         Closing of the previous page is delayed so waiting for didFinishNavigation is
2969         not sufficient to guarantee we have received all the messages. Wait for them.
2970
2971 2019-01-24  Chris Dumez  <cdumez@apple.com>
2972
2973         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2974         https://bugs.webkit.org/show_bug.cgi?id=193761
2975         <rdar://problem/47456405>
2976
2977         Reviewed by Alex Christensen.
2978
2979         Add API test coverage.
2980
2981         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2982
2983 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2984
2985         webkitpy: Missing PID in crashlog name should not be fatal
2986         https://bugs.webkit.org/show_bug.cgi?id=193771
2987
2988         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2989         of raising an exception.
2990
2991         Reviewed by Lucas Forschler.
2992
2993         * Scripts/webkitpy/port/darwin.py:
2994         (DarwinPort._merge_crash_logs):
2995
2996 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2997
2998         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2999         https://bugs.webkit.org/show_bug.cgi?id=193746
3000
3001         Reviewed by Youenn Fablet.
3002
3003         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3004         so we'd best just not call it.
3005
3006         * Scripts/webkitpy/w3c/test_exporter.py:
3007         (WebPlatformTestExporter.create_branch_with_patch):
3008
3009 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3010
3011         Move FileSystem to WTF
3012         https://bugs.webkit.org/show_bug.cgi?id=193602
3013
3014         Reviewed by Yusuke Suzuki.
3015
3016         * DumpRenderTree/win/DumpRenderTree.cpp:
3017         * TestWebKitAPI/CMakeLists.txt:
3018         * TestWebKitAPI/PlatformGTK.cmake:
3019         * TestWebKitAPI/PlatformJSCOnly.cmake:
3020         * TestWebKitAPI/PlatformPlayStation.cmake:
3021         * TestWebKitAPI/PlatformWPE.cmake:
3022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3023         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3024         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3025         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3026         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3027         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3028         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3029         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3030         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3031         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3032
3033 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3034
3035         [WPE] Remove hard dependency on subprocess32 for the API tests
3036
3037         Rubber-stamped by Carlos Garcia Campos.
3038
3039         * glib/api_test_runner.py:
3040         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3041         its presence only when running WPEQt tests.
3042
3043 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3044
3045         [GLIB] Expose JavaScriptCore options in GLib public API
3046         https://bugs.webkit.org/show_bug.cgi?id=188742
3047
3048         Reviewed by Michael Catanzaro.
3049
3050         Add a test for the new API.
3051
3052         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3053         (testsJSCOptions):
3054         (main):
3055
3056 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3057
3058         [GTK][WPE] Support JPEG 2000 images
3059         https://bugs.webkit.org/show_bug.cgi?id=186272
3060
3061         Reviewed by Žan Doberšek.
3062
3063         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3064
3065         * gtk/jhbuild.modules:
3066         * wpe/jhbuild.modules:
3067
3068 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3069
3070         check-webkit-style should warn when using soft-linking macros in a header
3071         <https://webkit.org/b/193750>
3072
3073         Reviewed by Darin Adler.
3074
3075         * Scripts/webkitpy/style/checkers/cpp.py:
3076         (check_language): Add softlink/header check by refactoring the
3077         softlink/framework check.
3078         (CppChecker): Enable softlink/header check by default.
3079         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3080         (CppStyleTest.test_softlink_framework): Rename from
3081         CppStyleTest.test_softlink() and change test framework name in
3082         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3083         files. Set file_name for macros that only appear in headers.
3084         (CppStyleTest.test_softlink_header): Add tests for using
3085         soft-link macros in headers.
3086
3087 2019-01-23  Chris Dumez  <cdumez@apple.com>
3088
3089         Deprecate API to limit the maximum number of WebProcesses
3090         https://bugs.webkit.org/show_bug.cgi?id=193725
3091         <rdar://problem/47464879>
3092
3093         Reviewed by Geoff Garen.
3094
3095         Update existing API tests to stop using deprecated API.
3096
3097         * MiniBrowser/mac/AppDelegate.m:
3098         (defaultConfiguration):
3099         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3100         (TestWebKitAPI::TEST):
3101         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3102         (TestWebKitAPI::TEST):
3103         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3104         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3105         (TEST):
3106         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3107         (TEST):
3108
3109 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3110
3111         [ews-app] Rename ews model buildermappings to buildermapping
3112         https://bugs.webkit.org/show_bug.cgi?id=193729
3113
3114         Reviewed by Lucas Forschler.
3115
3116         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3117         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3118         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3119
3120 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3121
3122         [ews-app] Rename ews model steps to step
3123         https://bugs.webkit.org/show_bug.cgi?id=193697
3124
3125         Reviewed by Lucas Forschler.
3126
3127         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3128         (Step): Renamed Steps to Step.
3129
3130 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3131
3132         Clean up IndexedDB files between tests
3133         https://bugs.webkit.org/show_bug.cgi?id=192796
3134         <rdar://problem/46824999>
3135
3136         Reviewed by Geoffrey Garen.
3137
3138         * DumpRenderTree/mac/DumpRenderTree.mm:
3139         (runTest):
3140         * WebKitTestRunner/TestController.cpp:
3141         (WTR::TestController::resetStateToConsistentValues):
3142         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3143         (WTR::RemoveAllIndexedDatabasesCallback):
3144         (WTR::TestController::ClearIndexedDatabases):
3145         * WebKitTestRunner/TestController.h:
3146         * WebKitTestRunner/TestInvocation.cpp:
3147         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3148
3149 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3150
3151         [ews-app] Rename ews model Builds to Build
3152         https://bugs.webkit.org/show_bug.cgi?id=193695
3153
3154         Reviewed by Lucas Forschler.
3155
3156         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3157         (Build): Renamed Builds to Build.
3158
3159 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3160
3161         webkitpy: Wait longer when launching WebKitTestRunner
3162         https://bugs.webkit.org/show_bug.cgi?id=193734
3163
3164         Reviewed by Aakash Jain.
3165
3166         * Scripts/webkitpy/port/simulator_process.py:
3167         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3168
3169 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3170
3171         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3172         https://bugs.webkit.org/show_bug.cgi?id=193182
3173         <rdar://problem/47452154>
3174
3175         Reviewed by Tim Horton.
3176
3177         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3178         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3179         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3180
3181         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3182         preventing later tests from recognizing gestures.
3183
3184         * WebKitTestRunner/ios/TestControllerIOS.mm:
3185         (WTR::TestController::platformResetStateToConsistentValues):
3186
3187         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3188
3189 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3190
3191         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3192         https://bugs.webkit.org/show_bug.cgi?id=193722
3193         <rdar://problem/47481475>
3194
3195         Reviewed by Lucas Forschler.
3196
3197         iPhone and iPad ports should both use the iOS config.
3198
3199         * Scripts/webkitpy/port/ios_simulator.py:
3200         (IPhoneSimulatorPort.__init__):
3201         (IPadSimulatorPort.__init__):
3202
3203 2019-01-23  Rob Buis  <rbuis@igalia.com>
3204
3205         Update MIME type parser
3206         https://bugs.webkit.org/show_bug.cgi?id=180526
3207
3208         Reviewed by Frédéric Wang.
3209
3210         Add unit tests for both parse modes of ParsedContentType.
3211
3212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3213         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3214         (TestWebKitAPI::TEST):
3215
3216 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3217
3218         [ews-app] fetch loop should not stop on network issues
3219         https://bugs.webkit.org/show_bug.cgi?id=193666
3220
3221         Reviewed by Lucas Forschler.
3222
3223         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3224         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3225
3226 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3227
3228         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3229         https://bugs.webkit.org/show_bug.cgi?id=189165
3230         <rdar://problem/47433765>
3231
3232         Reviewed by Tim Horton.
3233
3234         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3235         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3236         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3237         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3238         would make its way to the UI process by the time the layer tree commit is finished.
3239
3240         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3241         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3242         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3243         will fail because it asks for -_autofillContext too early.
3244
3245         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3246         is handled in the UI process.
3247
3248         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3249
3250         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3251         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3252         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3253         input session.
3254
3255         (-[AutofillTestView textInputHasAutofillContext]):
3256
3257         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3258
3259         * TestWebKitAPI/cocoa/TestWKWebView.h:
3260         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3261         (nextInputSessionChangeCount):
3262
3263         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3264         This includes changing the focused element from one to another.
3265
3266         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3267         (-[TestWKWebView didStartFormControlInteraction]):
3268         (-[TestWKWebView didEndFormControlInteraction]):
3269         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3270
3271         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3272         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3273         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3274         that doesn't require an input session to one that doesn't.
3275
3276 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3277
3278         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3279         <https://webkit.org/b/193676>
3280
3281         Reviewed by Alexey Proskuryakov.
3282
3283         * Scripts/webkitpy/style/checkers/cpp.py:
3284         (check_member_initialization_list):
3285         - Don't report missing whitespace around colon if the colon at
3286           the start of the line is formatted correctly.
3287         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3288         (WebKitStyleTest.test_member_initialization_list):
3289         - Add a test for a missing permutation of existing tests.
3290         - Add a test this false-positive.
3291         - Add blank lines between subtests to make them easier to read.
3292
3293 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3294
3295         [build.webkit.org] Unit-test failure after r237113
3296         https://bugs.webkit.org/show_bug.cgi?id=193669
3297
3298         Reviewed by Michael Catanzaro.
3299
3300         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3301         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3302         multiple or zero flags.
3303
3304 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3305
3306         Cache bytecode to disk
3307         https://bugs.webkit.org/show_bug.cgi?id=192782
3308         <rdar://problem/46084932>
3309
3310         Reviewed by Keith Miller.
3311
3312         Add test helper to execute bytecode-cache tests: it executes each test
3313         twice, the first with JSC_diskCachePath set to a temporary directory
3314         and second with JSC_forceDiskCache=true (in addition to the cache path)
3315         to guarantee that only the disk cache is being used and no new
3316         UnlinkedCodeBlocks are being created.
3317
3318         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3319         * Scripts/run-jsc-stress-tests:
3320
3321 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3322
3323         [css-logical] Implement flow-relative margin, padding and border shorthands
3324         https://bugs.webkit.org/show_bug.cgi?id=188697
3325
3326         Reviewed by Simon Fraser and Antti Koivisto.
3327
3328         * DumpRenderTree/TestOptions.cpp:
3329         (TestOptions::TestOptions):
3330         * DumpRenderTree/TestOptions.h:
3331         * DumpRenderTree/mac/DumpRenderTree.mm:
3332         (setWebPreferencesForTestOptions):
3333         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3334
3335         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3336         (JSONCSSPropertiesChecker.check_codegen_properties):
3337         Allow CSS property definitions to have a 'runtime-flag' parameter which
3338         disables the property when the specified runtime flag is disabled.
3339
3340 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3341
3342         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3343         https://bugs.webkit.org/show_bug.cgi?id=193643
3344
3345         Reviewed by Michael Catanzaro.
3346
3347         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3348         * wpe/jhbuild.modules: Ditto.
3349
3350 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3351
3352         [LFC][Floats] Take float top position into account when computing containing block height.
3353         https://bugs.webkit.org/show_bug.cgi?id=193655
3354
3355         Reviewed by Antti Koivisto.
3356
3357         * LayoutReloaded/misc/LFC-passing-tests.txt:
3358
3359 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3360
3361         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3362         <https://webkit.org/b/193645>
3363         <rdar://problem/47421574>
3364
3365         Reviewed by Alex Christensen.
3366
3367         - Now checks for local soft-linking of all frameworks that have
3368           their own *SoftLinking.{cpp,h,mm} files.
3369         - Changes softlink/uikit warning to softlink/framework.
3370
3371         * Scripts/webkitpy/style/checkers/cpp.py:
3372         (check_language):
3373         (CppChecker):
3374         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3375         (CppStyleTest):
3376
3377 2019-01-20  Saam Barati  <sbarati@apple.com>
3378
3379         Rollout r240210: It broke tests on iOS
3380         https://bugs.webkit.org/show_bug.cgi?id=193640
3381
3382         Unreviewed.
3383
3384         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3385         * Scripts/run-jsc-stress-tests:
3386
3387 2019-01-20  chris fleizach  <cfleizach@apple.com>
3388
3389         AX: Support returning relative frames for accessibility
3390         https://bugs.webkit.org/show_bug.cgi?id=193414
3391         <rdar://problem/47268501>
3392
3393         Reviewed by Zalan Bujtas.
3394
3395         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3396         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3397         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3398         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3399         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3400         (WTR::attributesOfElement):
3401         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3402
3403 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3404
3405         Unreviewed, add my new email address
3406
3407         * Scripts/webkitpy/common/config/contributors.json:
3408
3409 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3410
3411         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3412         https://bugs.webkit.org/show_bug.cgi?id=193617
3413
3414         Reviewed by Antti Koivisto.
3415
3416         * LayoutReloaded/misc/LFC-passing-tests.txt:
3417
3418 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3419
3420         Unreviewed, rolling out r240209.
3421
3422         Broke GTK/WPE injected bundle
3423
3424         Reverted changeset:
3425
3426         "AX: Support returning relative frames for accessibility"
3427         https://bugs.webkit.org/show_bug.cgi?id=193414
3428         https://trac.webkit.org/changeset/240209
3429
3430 2019-01-12  Dan Bernstein  <mitz@apple.com>
3431
3432         [Cocoa] Avoid importing directly from subumbrella frameworks
3433         https://bugs.webkit.org/show_bug.cgi?id=186016
3434         <rdar://problem/40591038>
3435
3436         Reviewed by Sam Weinig.
3437
3438         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3439           LaunchServices header.
3440         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3441           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3442         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3443           when using SDKs earlier than 10.13.
3444         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3445           and OTHER_CPLUSPLUSFLAGS.
3446         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3447           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3448         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3449           LaunchServices header.
3450
3451 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3452
3453         Cache bytecode to disk
3454         https://bugs.webkit.org/show_bug.cgi?id=192782
3455         <rdar://problem/46084932>
3456
3457         Reviewed by Keith Miller.
3458
3459         Add test helper to execute bytecode-cache tests: it executes each test
3460         twice, the first with JSC_diskCachePath set to a temporary directory
3461         and second with JSC_forceDiskCache=true (in addition to the cache path)
3462         to guarantee that only the disk cache is being used and no new
3463         UnlinkedCodeBlocks are being created.
3464
3465         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3466         * Scripts/run-jsc-stress-tests:
3467
3468 2019-01-20  chris fleizach  <cfleizach@apple.com>
3469
3470         AX: Support returning relative frames for accessibility
3471         https://bugs.webkit.org/show_bug.cgi?id=193414
3472         <rdar://problem/47268501>
3473
3474         Reviewed by Zalan Bujtas.
3475
3476         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3477         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3478         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3479         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3480         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3481         (WTR::attributesOfElement):
3482         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3483
3484 2019-01-20  Antoine Quint  <graouts@apple.com>
3485
3486         Add a POINTER_EVENTS feature flag
3487         https://bugs.webkit.org/show_bug.cgi?id=193577
3488         <rdar://problem/47408511>
3489
3490         Unreviewed. Also enable Pointer Events for iosmac.
3491
3492         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3493
3494 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3495
3496         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3497         https://bugs.webkit.org/show_bug.cgi?id=193613
3498
3499         Reviewed by Antti Koivisto.
3500
3501         * LayoutReloaded/misc/LFC-passing-tests.txt:
3502
3503 2019-01-19  Antoine Quint  <graouts@apple.com>
3504
3505         Add a POINTER_EVENTS feature flag
3506         https://bugs.webkit.org/show_bug.cgi?id=193577
3507
3508         Reviewed by Dean Jackson.
3509
3510         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3511
3512 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3513
3514         Disable the run-jsc-stress-test remote host key check [second round].
3515         https://bugs.webkit.org/show_bug.cgi?id=192988
3516
3517         Reviewed by Dewei Zhu.
3518
3519         * Scripts/run-jsc-stress-tests:
3520
3521 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3522
3523         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3524         https://bugs.webkit.org/show_bug.cgi?id=193597
3525
3526         Reviewed by Lucas Forschler.
3527
3528         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3529
3530 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3531
3532         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3533         https://bugs.webkit.org/show_bug.cgi?id=193595
3534
3535         Reviewed by Lucas Forschler.
3536
3537         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3538         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3539         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3540
3541 2019-01-18  Chris Dumez  <cdumez@apple.com>
3542
3543         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3544         https://bugs.webkit.org/show_bug.cgi?id=193588
3545         <rdar://problem/47131566>
3546
3547         Reviewed by Alex Christensen.
3548
3549         Add layout test coverage.
3550
3551         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3552
3553 2019-01-18  Jer Noble  <jer.noble@apple.com>
3554
3555         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3556         https://bugs.webkit.org/show_bug.cgi?id=189553
3557
3558         Reviewed by Tim Horton.
3559
3560         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3561
3562         * ContentExtensionTester/Configurations/Base.xcconfig:
3563         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3564         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3565         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3566         * ImageDiff/cg/Configurations/Base.xcconfig:
3567         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3568         * MiniBrowser/Configurations/Base.xcconfig:
3569         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3570         * MobileMiniBrowser/Configurations/Base.xcconfig:
3571         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3572         * Scripts/webkitpy/style/checker.py:
3573         (_all_categories):
3574         (FileType):
3575         (CheckerDispatcher._file_type):
3576         (CheckerDispatcher._create_checker):
3577         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3578         (SDKVariantChecker):
3579         (SDKVariantChecker.__init__):
3580         (SDKVariantChecker.check):
3581         * TestWebKitAPI/Configurations/Base.xcconfig:
3582         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3583         * WebEditingTester/Configurations/Base.xcconfig:
3584         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3585         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3586         * WebKitTestRunner/Configurations/Base.xcconfig:
3587         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3588         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3589         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3590
3591 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3592
3593         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3594         <https://webkit.org/b/193568>
3595         <rdar://problem/47381130>
3596
3597         Reviewed by Alex Christensen.
3598
3599         Make sure no one re-introduces UIKit soft-linking by adding a
3600         style rule.
3601
3602         * Scripts/webkitpy/style/checkers/cpp.py:
3603         (check_language): Add softlink/uikit check.
3604         (CppChecker): Enable softlink/uikit check.
3605         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3606         (CppStyleTest): Add test for softlink/uikit.
3607
3608 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3609
3610         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3611         https://bugs.webkit.org/show_bug.cgi?id=193584
3612
3613         Change "-dev" to "-devel".
3614
3615         Reviewed by Michael Catanzaro.
3616
3617         * gtk/install-dependencies:
3618
3619 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3620
3621         webkitpy: Add iPhone and iPad ports
3622         https://bugs.webkit.org/show_bug.cgi?id=193537
3623         <rdar://problem/47353390>
3624
3625         Reviewed by Lucas Forschler.
3626
3627         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3628         ports. Note that this separation is optional, the --ios-simulator command remains.
3629
3630         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3631         (RunTest.test_device_type_test_division): Drive-by fix.
3632         (RunTest.test_device_type_specific_listing): Ditto.
3633         (RunTest.test_ipad_test_division):
3634         (RunTest):
3635         (RunTest.test_ipad_listing):
3636         * Scripts/webkitpy/port/factory.py:
3637         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3638         (PortFactory):
3639         * Scripts/webkitpy/port/ios_simulator.py:
3640         (IPhoneSimulatorPort):
3641         (IPadSimulatorPort):
3642
3643 2019-01-18  Chris Dumez  <cdumez@apple.com>
3644
3645         Regression(PSON) Scroll position is not always restored properly when navigating back
3646         https://bugs.webkit.org/show_bug.cgi?id=193578
3647         <rdar://problem/47386331>
3648
3649         Reviewed by Tim Horton.
3650
3651         Add API test coverage.
3652
3653         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3654
3655 2019-01-18  Youenn Fablet  <youenn@apple.com>
3656
3657         Add a new SPI to request for cache storage quota increase
3658         https://bugs.webkit.org/show_bug.cgi?id=193323
3659
3660         Reviewed by Alex Christensen.
3661
3662         Implement WebsiteDataStore quota delegate to handle quota requests.
3663         By default, do not update quota.
3664         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3665
3666         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3667         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3668         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3669         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3670         * WebKitTestRunner/TestController.cpp:
3671         (WTR::TestController::allowCacheStorageQuotaIncrease):
3672         * WebKitTestRunner/TestController.h:
3673         * WebKitTestRunner/TestInvocation.cpp:
3674         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3675         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3676         (-[CacheStorageQuotaManager init]):
3677         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3678         (WTR::initializeWebViewConfiguration):
3679         (WTR::TestController::cocoaResetStateToConsistentValues):
3680         (WTR::TestController::allowCacheStorageQuotaIncrease):
3681
3682 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3683
3684         [ews-build] Pass owner to the triggered builds
3685         https://bugs.webkit.org/show_bug.cgi?id=193574
3686
3687         Reviewed by Lucas Forschler.
3688
3689         * BuildSlaveSupport/ews-build/factories.py:
3690         (BuildFactory.propertiesToPassToTriggers):
3691
3692 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3693
3694         [ews-app] Send patch author as a build property
3695         https://bugs.webkit.org/show_bug.cgi?id=193560
3696
3697         Reviewed by Lucas Forschler.
3698
3699         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3700         (BugzillaPatchFetcher.fetch):
3701
3702 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3703
3704         webkitpy: Implement device type specific expected results (Follow-up fix)
3705         https://bugs.webkit.org/show_bug.cgi?id=192162
3706         <rdar://problem/46345449>
3707
3708         Unreviewed infrastructure fix.
3709
3710         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3711         (Manager.run): Don't boot a device if no tests are available to run on it.
3712
3713 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3714
3715         webkitpy: Implement device type specific expected results (Follow-up fix)
3716         https://bugs.webkit.org/show_bug.cgi?id=192162
3717         <rdar://problem/46345449>
3718
3719         Unreviewed infrastructure fix.
3720
3721         * Scripts/webkitpy/api_tests/manager.py:
3722         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3723
3724 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3725
3726         webkitpy: Implement device type specific expected results (Part 2)
3727         https://bugs.webkit.org/show_bug.cgi?id=192162
3728         <rdar://problem/46345449>
3729
3730         Rubber-stamped by Aakash Jain.
3731
3732         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3733         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3734         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3735
3736         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3737         (LayoutTestFinder.find_tests): Pass device_type through.
3738         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3739         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3740         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3741         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3742         (Manager._collect_tests): Pass device type to test finder.
3743         (Manager._needs_web_platform_test):
3744         (Manager._prepare_lists): Index _expectations by device type.
3745         (Manager._test_input_for_file):
3746         (Manager._test_is_slow): Ditto.
3747         (Manager._test_should_dump_jsconsolelog_in_stderr):
3748         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3749         (Manager._get_test_inputs):
3750         (Manager._update_worker_count):
3751         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3752         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3753         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3754         the one which runs the test.
3755         (Manager._run_test_subset):
3756         (Manager._run_tests): Index _expectations by current_device_type.
3757         (Manager._print_expectation_line_for_test): Ditto.
3758         (Manager._print_expectations_for_subset): Ditto.
3759         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3760         Unlike run, this function will behave the same regardless of what devices are available.
3761         (Manager._custom_device_for_test): Deleted.
3762         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3763         (ManagerTest.test_uses_custom_device): Deleted.
3764         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3765         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3766         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3767         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3768         all of the expectations.
3769         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3770         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3771         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3772         (TestExpectations.__init__): Allow device_type to be passed through.
3773         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3774         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3775         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3776         (summarize_results):
3777         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3778         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3779         a test ran with, one must check all expectations to find the first non-skip expectation.
3780         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3781         (RunTest.test_device_type_test_division):
3782         (RunTest):
3783         (RunTest.test_device_type_specific_listing):
3784         * Scripts/webkitpy/port/base.py:
3785         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3786         (Port.supported_device_types): The result of this function will change based on what devices are available.
3787         * Scripts/webkitpy/port/device_port.py:
3788         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3789         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3790         can be used.
3791         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3792         any, or the DEFAULT_DEVICE_TYPES of the port.
3793         * Scripts/webkitpy/port/ios.py:
3794         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3795         * Scripts/webkitpy/port/ios_simulator.py:
3796         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3797         * Scripts/webkitpy/port/watch.py:
3798         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3799         * Scripts/webkitpy/port/watch_simulator.py:
3800         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3801         * Scripts/webkitpy/xcode/device_type.py:
3802         (DeviceType):
3803         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3804
3805 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3806
3807         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3808         https://bugs.webkit.org/show_bug.cgi?id=193575
3809
3810         Reviewed by Michael Catanzaro.
3811
3812         Allow the script to run without explicit port argument because
3813         it's specific to the WPE port anyway.
3814
3815         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3816         and simplify the rest of the code accordingly.
3817
3818 2019-01-18  Charlie Turner  <cturner@igalia.com>
3819
3820         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3821         https://bugs.webkit.org/show_bug.cgi?id=192229
3822
3823         Reviewed by Xabier Rodriguez-Calvar.
3824
3825         * MiniBrowser/wpe/main.cpp:
3826         (main): Enable encrypted-media by default.
3827
3828 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3829
3830         [Flatpak] Missing KeyboardInterrupt exception handler
3831         https://bugs.webkit.org/show_bug.cgi?id=193570
3832
3833         Reviewed by Michael Catanzaro.
3834
3835         * flatpak/flatpakutils.py:
3836         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3837
3838 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3839
3840         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3841         https://bugs.webkit.org/show_bug.cgi?id=193564
3842
3843         Reviewed by Antti Koivisto.
3844
3845         * LayoutReloaded/misc/LFC-passing-tests.txt:
3846
3847 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3848
3849         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3850         https://bugs.webkit.org/show_bug.cgi?id=193562
3851
3852         Reviewed by Antti Koivisto.
3853
3854         * LayoutReloaded/misc/LFC-passing-tests.txt:
3855
3856 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3857
3858         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3859         https://bugs.webkit.org/show_bug.cgi?id=193555
3860
3861         Reviewed by Antti Koivisto.
3862
3863         * LayoutReloaded/misc/LFC-passing-tests.txt:
3864
3865 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3866
3867         [WPE] Add Qt extension
3868         https://bugs.webkit.org/show_bug.cgi?id=191464
3869
3870         Reviewed by Carlos Garcia Campos.
3871
3872         MiniBrowser and API tests for the WPE Qt API. To run the
3873         MiniBrowser a new script is introduced. Example invocation:
3874
3875         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3876
3877         Also note-worthy is the introduction of the python2-subprocess32
3878         dependency to run the GLib API tests.
3879
3880         * MiniBrowser/wpe/CMakeLists.txt:
3881         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3882         * MiniBrowser/wpe/qt/main.cpp: Added.
3883         (main):
3884         * MiniBrowser/wpe/qt/main.qml: Added.
3885         * MiniBrowser/wpe/qt/qml.qrc: Added.
3886         * Scripts/run-gtk-tests:
3887         (GtkTestRunner.is_google_test):
3888         (GtkTestRunner):
3889         (GtkTestRunner.is_qt_test):
3890         * Scripts/run-qt-wpe-minibrowser: Added.
3891         * Scripts/run-wpe-tests:
3892         (WPETestRunner):
3893         (WPETestRunner.is_google_test):
3894         (WPETestRunner.is_qt_test):
3895         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3896         (TestLoad::main):
3897         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3898         (TestLoadHtml::main):
3899         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3900         (TestLoadRequest::main):
3901         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3902         (TestRunJavaScript::main):
3903         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3904         (waitForSignal):
3905         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3906         (LoadSpy::LoadSpy):
3907         (LoadSpy::~LoadSpy):
3908         (LoadSpy::onLoadingChanged):
3909         (LoadStartedCatcher::LoadStartedCatcher):
3910         (LoadStartedCatcher::~LoadStartedCatcher):
3911         (LoadStartedCatcher::onLoadingChanged):
3912         (waitForLoadSucceeded):
3913         (waitForLoadFailed):
3914         * TestWebKitAPI/glib/CMakeLists.txt:
3915         * flatpak/flatpakutils.py:
3916         (WebkitFlatpak.load_from_args):
3917         (WebkitFlatpak.__init__):
3918         (WebkitFlatpak.clean_args):
3919         (WebkitFlatpak.run_in_sandbox):
3920         * flatpak/org.webkit.CommonModules.yaml:
3921         * flatpak/org.webkit.WPE.yaml:
3922         * flatpak/org.webkit.WPEModules.yaml:
3923         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3924         * flatpak/org.webkit.WebKit.yaml:
3925         * glib/api_test_runner.py:
3926         (TestRunner._run_test_qt):
3927         (TestRunner.is_qt_test):
3928         (TestRunner._run_test):
3929
3930 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3931
3932         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3933         https://bugs.webkit.org/show_bug.cgi?id=193494
3934         <rdar://problem/46859627>
3935
3936         Reviewed by Simon Fraser and Tim Horton.
3937
3938         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3939         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3940
3941         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3942         (WTR::UIScriptController::contentOffsetX const):
3943         (WTR::UIScriptController::contentOffsetY const):
3944         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3945         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3946         (WTR::UIScriptController::contentOffsetX const):
3947         (WTR::UIScriptController::contentOffsetY const):
3948         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3949
3950         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3951
3952         * WebKitTestRunner/TestController.cpp:
3953         (WTR::updateTestOptionsFromTestHeader):
3954         * WebKitTestRunner/TestOptions.h:
3955         (WTR::TestOptions::hasSameInitializationOptions const):
3956         * WebKitTestRunner/ios/TestControllerIOS.mm:
3957         (WTR::TestController::platformResetStateToConsistentValues):
3958         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3959         (WTR::UIScriptController::contentOffsetX const):
3960         (WTR::UIScriptController::contentOffsetY const):
3961
3962 2019-01-17  Truitt Savell  <tsavell@apple.com>
3963
3964         Unreviewed, rolling out r240124.
3965
3966         This commit broke an internal build.
3967
3968         Reverted changeset:
3969
3970         "SDK_VARIANT build destinations should be separate from non-
3971         SDK_VARIANT builds"
3972         https://bugs.webkit.org/show_bug.cgi?id=189553
3973         https://trac.webkit.org/changeset/240124
3974
3975 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3976
3977         Fix string concatenation API test after r239920
3978         https://bugs.webkit.org/show_bug.cgi?id=193551
3979         <rdar://problem/47359304>
3980
3981         Reviewed by Youenn Fablet.
3982
3983         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3984         (TestWebKitAPI::TEST):
3985         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3986         in WebKit's build configuration like it apparently is on Linux.
3987
3988 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3989
3990         [ews-build] validate-patch should handle the case when bug_id is None
3991         https://bugs.webkit.org/show_bug.cgi?id=193547
3992
3993         Reviewed by Lucas Forschler.
3994
3995         * BuildSlaveSupport/ews-build/steps.py:
3996         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3997         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3998
3999 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4000
4001         [ews-build] Add patch author information in build
4002         https://bugs.webkit.org/show_bug.cgi?id=193465
4003
4004         Reviewed by Lucas Forschler.
4005
4006         * BuildSlaveSupport/ews-build/steps.py:
4007         (ValidatePatch._is_patch_obsolete):
4008
4009 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4010
4011         [ews-build] Pass bug_id to the triggered builds
4012         https://bugs.webkit.org/show_bug.cgi?id=193548
4013
4014         Reviewed by Lucas Forschler.
4015
4016         * BuildSlaveSupport/ews-build/factories.py:
4017         (BuildFactory.propertiesToPassToTriggers):
4018
4019 2019-01-17  Jer Noble  <jer.noble@apple.com>
4020
4021         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
4022         https://bugs.webkit.org/show_bug.cgi?id=189553
4023
4024         Reviewed by Tim Horton.
4025
4026         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
4027
4028         * ContentExtensionTester/Configurations/Base.xcconfig:
4029         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
4030         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4031         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
4032         * ImageDiff/cg/Configurations/Base.xcconfig:
4033         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
4034         * MiniBrowser/Configurations/Base.xcconfig:
4035         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4036         * MobileMiniBrowser/Configurations/Base.xcconfig:
4037         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
4038         * Scripts/webkitpy/style/checker.py:
4039         (_all_categories):
4040         (FileType):
4041         (CheckerDispatcher._file_type):
4042         (CheckerDispatcher._create_checker):
4043         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
4044         (SDKVariantChecker):
4045         (SDKVariantChecker.__init__):
4046         (SDKVariantChecker.check):
4047         * TestWebKitAPI/Configurations/Base.xcconfig:
4048         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
4049         * WebEditingTester/Configurations/Base.xcconfig:
4050         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
4051         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
4052         * WebKitTestRunner/Configurations/Base.xcconfig:
4053         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
4054         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
4055         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
4056
4057 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4058
4059         [LFC][BFC] An element with transform is a containing block for positioned descendants.
4060         https://bugs.webkit.org/show_bug.cgi?id=193534
4061
4062         Reviewed by Antti Koivisto.
4063
4064         * LayoutReloaded/misc/LFC-passing-tests.txt:
4065
4066 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4067
4068         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
4069         https://bugs.webkit.org/show_bug.cgi?id=193528
4070
4071         Reviewed by Antti Koivisto.
4072
4073         * LayoutReloaded/misc/LFC-passing-tests.txt:
4074
4075 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4076
4077         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
4078         https://bugs.webkit.org/show_bug.cgi?id=193520
4079
4080         Reviewed by Antti Koivisto.
4081
4082         * LayoutReloaded/misc/LFC-passing-tests.txt:
4083
4084 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4085
4086         [ews-build] unapply-patch step should not update source
4087         https://bugs.webkit.org/show_bug.cgi?id=193234
4088
4089         Reviewed by Lucas Forschler.
4090
4091         * BuildSlaveSupport/ews-build/steps.py:
4092         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
4093         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
4094
4095 2019-01-16  Youenn Fablet  <youenn@apple.com>
4096
4097         Add a new SPI for controlling getUserMedia
4098         https://bugs.webkit.org/show_bug.cgi?id=192793
4099
4100         Reviewed by Eric Carlson.
4101
4102         * MiniBrowser/mac/WK2BrowserWindowController.m:
4103         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
4104         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4105         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
4106         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4107         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
4108         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4109         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
4110         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4111         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4112         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4113         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4114         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
4115         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4116         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4117
4118 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4119
4120         [LFC][BFC] Inflow non-replaced used width should not be negative.
4121         https://bugs.webkit.org/show_bug.cgi?id=193495
4122
4123         Reviewed by Antti Koivisto.
4124
4125         * LayoutReloaded/misc/LFC-passing-tests.txt:
4126
4127 2019-01-16  Chris Dumez  <cdumez@apple.com>
4128
4129         Regression(PSON) View becomes blank after click a cross-site download link
4130         https://bugs.webkit.org/show_bug.cgi?id=193361
4131         <rdar://problem/47099573>
4132
4133         Reviewed by Geoffrey Garen.
4134
4135         Add API test coverage.
4136
4137         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4138         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4139
4140 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4141
4142         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
4143         https://bugs.webkit.org/show_bug.cgi?id=193470
4144
4145         Reviewed by Antti Koivisto.
4146
4147         * LayoutReloaded/misc/LFC-passing-tests.txt:
4148
4149 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4150
4151         [LFC] Adjust margin box verification.
4152         https://bugs.webkit.org/show_bug.cgi?id=193482
4153
4154         Reviewed by Antti Koivisto.
4155
4156         * LayoutReloaded/misc/LFC-passing-tests.txt:
4157
4158 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
4159
4160         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
4161         https://bugs.webkit.org/show_bug.cgi?id=193451
4162
4163         Reviewed by Geoffrey Garen.
4164
4165         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
4166         (TEST):
4167         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4168         (runWebsiteDataStoreCustomPaths):
4169
4170 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4171
4172         webkitpy: Support boolean simctl isAvailable
4173         https://bugs.webkit.org/show_bug.cgi?id=193472
4174         <rdar://problem/47296150>
4175
4176         Reviewed by Ryosuke Niwa.
4177
4178         * Scripts/webkitpy/xcode/simulated_device.py:
4179         (SimulatedDeviceManager._create_runtimes):
4180         (SimulatedDeviceManager._create_device_with_runtime):
4181
4182 2019-01-15  Chris Dumez  <cdumez@apple.com>
4183
4184         Unreviewed, rolling out r239993, r239995, r239997, and
4185         r239999.
4186
4187         Caused assertions under
4188         ViewGestureController::disconnectFromProcess()
4189
4190         Reverted changesets:
4191
4192         "Regression(PSON) View becomes blank after click a cross-site
4193         download link"
4194         https://bugs.webkit.org/show_bug.cgi?id=193361
4195         https://trac.webkit.org/changeset/239993
4196
4197         "Unreviewed iOS build fix after r239993."
4198         https://trac.webkit.org/changeset/239995
4199
4200         "Fix iOS build after r239993"
4201         https://bugs.webkit.org/show_bug.cgi?id=193361
4202         https://trac.webkit.org/changeset/239997
4203
4204         "Unreviewed, revert part of r239997 as it is not needed to fix
4205         the build."
4206         https://trac.webkit.org/changeset/239999
4207
4208 2019-01-15  Tim Horton  <timothy_horton@apple.com>
4209
4210         Cannot tab out of WKWebView on macOS
4211         https://bugs.webkit.org/show_bug.cgi?id=161448
4212         <rdar://problem/28100085>
4213
4214         Reviewed by Dean Jackson.
4215
4216         Add a test that tabbing into and out of WKWebView works correctly.
4217
4218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4219         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
4220         (WebKit2_CommandBackForwardTest::SetUp):
4221         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
4222         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
4223         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
4224         (-[FocusableView canBecomeKeyView]):
4225         (TEST):
4226         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
4227         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
4228         (-[OffscreenWindow initWithSize:]):
4229         (-[OffscreenWindow isKeyWindow]):
4230         (-[OffscreenWindow isVisible]):
4231         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4232         (TestWebKitAPI::PlatformWebView::initialize):
4233         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
4234         (-[ActiveOffscreenWindow isVisible]): Deleted.
4235         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
4236
4237 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
4238
4239         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
4240         https://bugs.webkit.org/show_bug.cgi?id=193459
4241
4242         Reviewed by Mark Lam.
4243
4244         * BuildSlaveSupport/build.webkit.org-config/steps.py:
4245         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
4246
4247 2019-01-15  Chris Dumez  <cdumez@apple.com>
4248
4249         Regression(PSON) View becomes blank after click a cross-site download link
4250         https://bugs.webkit.org/show_bug.cgi?id=193361
4251         <rdar://problem/47099573>
4252
4253         Reviewed by Geoff Garen.
4254
4255         Add API test coverage.
4256
4257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4258         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4259
4260 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4261
4262         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
4263         https://bugs.webkit.org/show_bug.cgi?id=193448
4264
4265         Reviewed by Antti Koivisto.
4266
4267         * LayoutReloaded/misc/LFC-passing-tests.txt:
4268
4269 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4270
4271         webkitpy: Implement device type specific expected results (Part 1)
4272         https://bugs.webkit.org/show_bug.cgi?id=192162
4273
4274         Reviewed by Lucas Forschler.
4275
4276         Device type specific expected results covers two related ideas. The first (covered by this change)
4277         is where to search for -expected.* files. The second is which tests to run based on the
4278         TestExpectations.txt file.
4279
4280         After this change, the baseline search path will be determined by the type of device running a
4281         test. Device type will be passed into any function which picks a file based on the baseline search
4282         path.
4283
4284         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4285         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
4286         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4287         (Manager.run): Print baseline search path for each round of devices.
4288         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4289         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
4290         (SingleTestRunner._expected_driver_output): Ditto.
4291         (SingleTestRunner._driver_input): Ditto.
4292         * Scripts/webkitpy/layout_tests/views/printing.py:
4293         (Printer.print_config): Move printing of baseline search path to a separate function.
4294         (Printer.print_baseline_search_path): Moved from Printer.print_config.
4295         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4296         (Testprinter.test_print_config):
4297         (Testprinter.test_print_baseline_search_path):
4298         * Scripts/webkitpy/port/base.py:
4299         (Port.baseline_search_path): Pass device_type through.
4300         (Port._expected_baselines_for_suffixes): Ditto.
4301         (Port.expected_baselines): Ditto.
4302         (Port.expected_filename): Ditto.
4303         (Port.expected_checksum): Ditto.
4304         (Port.expected_image): Ditto.
4305         (Port.expected_audio): Ditto.
4306         (Port.expected_text): Ditto.
4307         (Port.reference_files): Ditto.
4308         (Port.tests): Ditto.
4309         (Port._expanded_paths): Ditto.
4310         (Port.skipped_layout_tests): Ditto.
4311         (Port.expectations_dict): Ditto.
4312         (Port._port_specific_expectations_files): Ditto.
4313         (Port.expectations_files): Ditto.
4314         (Port.test_search_path): Ditto.
4315         (Port._tests_for_other_platforms): Ditto.
4316         * Scripts/webkitpy/port/base_unittest.py:
4317         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
4318         (PortTest.test_nonexistant_expectations): Ditto.
4319         (test_ref_tests_platform_directory): Ditto.
4320         * Scripts/webkitpy/port/darwin.py:
4321         (DarwinPort._port_specific_expectations_files): Accept device_type.
4322         * Scripts/webkitpy/port/driver.py:
4323         (DriverProxy):
4324         (DriverProxy.host): Expose _target_host for device_type information.
4325         * Scripts/webkitpy/port/gtk.py:
4326         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
4327         * Scripts/webkitpy/port/ios.py:
4328         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4329         * Scripts/webkitpy/port/mac.py:
4330         (MacPort. default_baseline_search_path): Ditto.
4331         * Scripts/webkitpy/port/port_testcase.py:
4332         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
4333         * Scripts/webkitpy/port/test.py:
4334         * Scripts/webkitpy/port/watch.py:
4335         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4336         * Scripts/webkitpy/port/win.py:
4337         (WinPort.test_search_path): Accept, but do not use, device_type.
4338         * Scripts/webkitpy/port/wpe.py:
4339         (WPEPort._port_specific_expectations_files): Ditto.
4340         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4341         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
4342
4343 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4344
4345         [LFC] Use the containing block's padding box to position out-of-flow elements.
4346         https://bugs.webkit.org/show_bug.cgi?id=193431
4347
4348         Reviewed by Antti Koivisto.
4349
4350         * LayoutReloaded/misc/LFC-passing-tests.txt:
4351
4352 2019-01-14  Tim Horton  <timothy_horton@apple.com>
4353
4354         Move a test implementation file that got misplaced in the Xcode project
4355
4356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4357
4358 2019-01-14  Commit Queue  <commit-queue@webkit.org>
4359