[WebKit-https.git] / Tools / ChangeLog

2018-06-30  Thibault Saunier  <tsaunier@igalia.com>

        Make check_flatpak() not verbose when only trying to run command inside flatpak
        https://bugs.webkit.org/show_bug.cgi?id=187187

        Reviewed by Michael Catanzaro.

        * flatpak/flatpakutils.py:
        (run_in_sandbox_if_available):

2018-06-29  Daniel Bates  <dabates@apple.com>

        build-webkit: Perl "use of uninitialized value $previousContents"
        https://bugs.webkit.org/show_bug.cgi?id=185776

        Reviewed by Michael Catanzaro.

        Fixes an issue where reading an empty cached argument file would cause
        Perl "uninitialized value" warnings of the form:
            Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969.
            Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972.

        * Scripts/webkitdirs.pm:
        (isCachedArgumentfileOutOfDate):

2018-06-29  Daniel Bates  <dabates@apple.com>

        Perl uninitialized value $isEnabled when running build-jsc using a CMake build
        https://bugs.webkit.org/show_bug.cgi?id=187208

        Reviewed by Tim Horton.

        Share logic for computing the feature flags to enable in CMake with both script
        build-webkit and script build-jsc instead of duplicating it. This also fixes a
        bug in the version of this logic in build-jsc that was inadvertently not updated
        in r222394. In r222394 we removed the notion of a default value for a feature flag
        listed in webkitperl::FeatureList.

        We keep the current behavior of build-jsc and leave it up to the build system
        to determine whether to enable or disable ENABLE_EXPERIMENTAL_FEATURES.

        * Scripts/build-jsc:
        (buildMyProject):
        (cMakeArgsFromFeatures): Deleted.
        * Scripts/build-webkit:
        (cMakeArgsFromFeatures): Deleted; moved to webkitdirs.pm.
        * Scripts/webkitdirs.pm:
        (cmakeArgsFromFeatures): Moved code from script build-webkit so that it can be shared
        with build-jsc.

2018-06-29  Tim Horton  <timothy_horton@apple.com>

        Add -apple-color-filter and system appearance toggles to MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=187210

        Reviewed by Simon Fraser.

        * MiniBrowser/mac/AppDelegate.m:
        (defaultConfiguration):
        * MiniBrowser/mac/SettingsController.h:
        * MiniBrowser/mac/SettingsController.m:
        (-[SettingsController _populateMenu]):
        (-[SettingsController validateMenuItem:]):
        (-[SettingsController toggleAppleColorFilterEnabled:]):
        (-[SettingsController appleColorFilterEnabled]):
        (-[SettingsController toggleUseSystemAppearance:]):
        (-[SettingsController useSystemAppearance]):
        * MiniBrowser/mac/WK1BrowserWindowController.m:
        (-[WK1BrowserWindowController didChangeSettings]):
        * MiniBrowser/mac/WK2BrowserWindowController.m:
        (-[WK2BrowserWindowController didChangeSettings]):

2018-06-29  Aditya Keerthi  <akeerthi@apple.com>

        [macOS] Do not crash if there is an attempt to copy a file URL to the clipboard
        https://bugs.webkit.org/show_bug.cgi?id=187183

        Reviewed by Wenson Hsieh.

        Added a 'runSingly' option to the TestOptions struct. Setting this option to true
        will force a new PlatformWebView to be created before running a test. This ensures
        that any state set by previous tests are not preserved.

        One example of the importance of having this ability is in the case where we want
        to test functionality that deals with read access to files. If a test were to
        load a valid file URL, universal read access will be granted in WebProcessProxy.
        This prevents us from testing cases that rely on us not have universal read
        access. Now, if we write the test using the 'runSingly' option, any state set
        by previous tests is cleared. Consequently, our test will behave as expected.

        * WebKitTestRunner/PlatformWebView.h:
        (WTR::PlatformWebView::viewSupportsOptions const):
        * WebKitTestRunner/TestController.cpp:
        (WTR::updateTestOptionsFromTestHeader):
        * WebKitTestRunner/TestOptions.h:
        (WTR::TestOptions::hasSameInitializationOptions const):

2018-06-29  Daniel Bates  <dabates@apple.com>

        [lldb-webkit] Non-empty strings may be pretty-printed as empty
        https://bugs.webkit.org/show_bug.cgi?id=187185

        Reviewed by Simon Fraser.

        For some reason lldb(1) sometimes has an issue accessing members of WTF::StringImplShape
        via a WTF::StringImpl pointer (why?). Explicitly casting a WTF::StringImpl* to a
        WTF::StringImplShape* before accessing such members makes LLDB happy.

        I tried writing a test for this both for the LLVM project and to add to our lldb_webkit unit
        tests to no avail. I have only been able to reproduce this bug sporadically during my WebCore/WebKit
        debugging sessions so far.

        * lldb/lldb_webkit.py:
        (WTFStringImplProvider.__init__): Explicitly cast the WTF::StringImpl* to WTF::StringImplShape*.
        (WTFStringImplProvider.get_data8): Update code now that we are directly accessing WTF::StringImplShape*.
        (WTFStringImplProvider.get_data16): Ditto.

2018-06-29  Chris Dumez  <cdumez@apple.com>

        WebKitLegacy: Can trigger recursive loads triggering debug assertions
        https://bugs.webkit.org/show_bug.cgi?id=187121
        <rdar://problem/41259430>

        Reviewed by Brent Fulgham.

        Add API test coverage.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/mac/StartLoadInDidFailProvisionalLoad.mm: Added.
        (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
        (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFinishLoadForFrame:]):
        (TestWebKitAPI::TEST):

2018-06-29  Lucas Forschler  <lforschler@apple.com>

        Teach bisect-builds to retrieve supported platforms from the rest api.
        https://bugs.webkit.org/show_bug.cgi?id=187195
        
        This patch updates bisect-builds to use v2_2 of the API. v2_2 adds two api endpoints: /platforms, and /minified-platforms.
        These endpoints scan a dynamoDB database, returning the identifier key for all available platforms.
        The identifier keys are in the format: platform-architecture-configuration.

        Reviewed by Aakash Jain.

        * Scripts/bisect-builds:
        (get_api_archive_url): refactored from get_api_url.
        (get_platforms): helper function to retrieve from the platforms api.
        (minified_platforms): returns a list of minified platforms currently in the database
        (unminified_platforms): returns a list of unminified platforms currently in the database
        (is_supported_platform): checks if the platform-architecture-configuration combo is supported
        (fetch_revision_list): refactored to use get_api_archive_url
        (get_api_url): Deleted/refactored to get_api_archive_url.

2018-06-29  Keith Miller  <keith_miller@apple.com>

        run-jsc should print when jsc exits with non-zero status
        https://bugs.webkit.org/show_bug.cgi?id=187192

        Reviewed by Saam Barati.

        * Scripts/run-jsc:

2018-06-29  Aakash Jain  <aakash_jain@apple.com>

        [ews-build] Add timeout to webkitpy and webkitperl tests
        https://bugs.webkit.org/show_bug.cgi?id=187191

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/ews-build/steps.py:
        (RunWebKitPerlTests.__init__): Set timeout of 2 minutes.
        (RunWebKitPyTests.__init__): Ditto.
        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

2018-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [WPE]: Fix exception handling when flatpak is not installed
        https://bugs.webkit.org/show_bug.cgi?id=186771

        Unreviewed followup-fix after r233362

        This was causing failures when flatpak is not installed.

        * flatpak/flatpakutils.py:
        (check_flatpak):

2018-06-29  Ross Kirsling  <ross.kirsling@sony.com>

        [JSCOnly] Restore Windows build.
        https://bugs.webkit.org/show_bug.cgi?id=187127

        Reviewed by Michael Catanzaro.

        * Scripts/build-jsc:
        Fix condition for disabling FTL JIT on Windows.

        * Scripts/webkitdirs.pm:
        (executableProductDir):
        JSCOnly should still use bin64 on Windows (for consistency with full WebKit build).
        (determineIsWin64):
        JSCOnly already defaults to 64-bit on Windows with Ninja -- ensure that this is true even with MSBuild.

2018-06-29  Thibault Saunier  <tsaunier@igalia.com>

        [GTK][WPE]: Add a way to setup our development environment inside flatpak
        https://bugs.webkit.org/show_bug.cgi?id=186771

        Reviewed by Carlos Alberto Lopez Perez.

        This patch introduce a way to setup the development environment inside flatpak[0]
        removing the need for jhbuild when doing so. Anything needed to build/run minibrowser/ run
        layout tests is provided either but the org.gnome.Sdk runtime or built with flatpak-builder.

        The workflow is very similar to the "jhbuild based" one except that you should use update-webkit$PORTNAME-flatpak instead
        of update-webkit$PORTNAME-libs and that script requires to specify a build configuration (--release is default).

        Our scripts have been updated to be able to run inside that new build environment.

        Since everything runs inside a flatpak sandbox, gdb needs to be run from within the sandbox, the script exposes a way to do it
        easily with the `--gdb` option:

          $ webkit-flatpak --gdb [-m COREDUMPCTL MATCHES]

        The Layout test `GDBCrashLogGenerator` has been taugth how to use that and is able to retrieve stacktrace as with the jhbuild based workflow.

        [0] http://flatpak.org

        * Scripts/build-webkit:
        * Scripts/generate-jsc-bundle:
        (main):
        * Scripts/run-gtk-tests:
        * Scripts/run-minibrowser:
        * Scripts/run-webdriver-tests:
        * Scripts/run-webkit-tests:
        * Scripts/run-wpe-tests:
        * Scripts/update-webkitgtk-libs:
        * Scripts/update-webkitwpe-libs:
        * Scripts/webkit-flatpak: Added.
        * Scripts/webkitdirs.pm:
        (getJhbuildPath):
        (getFlatpakPath):
        (inFlatpakSandbox):
        (runInFlatpak):
        (runInFlatpakIfAvalaible):
        (wrapperPrefixIfNeeded):
        (shouldUseFlatpak):
        * Scripts/webkitpy/port/base.py:
        (Port._path_to_apache):
        (Port._is_flatpak):
        (Port._apache_config_file_name_for_platform):
        (Port._should_use_flatpak):
        (Port):
        (Port._in_flatpak_sandbox):
        (Port._should_use_jhbuild):
        * Scripts/webkitpy/port/gtk.py:
        (GtkPort.setup_environ_for_server):
        * Scripts/webkitpy/port/linux_get_crash_log.py:
        (GDBCrashLogGenerator._get_trace_from_systemd):
        (GDBCrashLogGenerator.generate_crash_log):
        * Scripts/webkitpy/port/wpe.py:
        (WPEPort.setup_environ_for_server):
        * Scripts/webkitpy/w3c/wpt_runner.py:
        (main):
        * flatpak/files/default.xkm: Added.
        * flatpak/files/httpd-autogen.sh: Added.
        * flatpak/flatpakutils.py: Added.
        (Colors):
        (Console):
        (Console.message):
        (remove_extension_points):
        (remove_comments):
        (remove_comments._replacer):
        (load_manifest):
        (expand_manifest):
        (FlatpakObject):
        (FlatpakObject.__init__):
        (FlatpakObject.flatpak):
        (FlatpakPackages):
        (FlatpakPackages.__init__):
        (FlatpakPackages.__detect_packages):
        (FlatpakPackages.__detect_packages.in):
        (FlatpakPackages.__detect_runtimes):
        (FlatpakPackages.__detect_apps):
        (FlatpakPackages.__iter__):
        (FlatpakRepos):
        (FlatpakRepos.__init__):
        (FlatpakRepos.update):
        (FlatpakRepos.add):
        (FlatpakRepo):
        (FlatpakRepo.__init__):
        (FlatpakRepo.repo_file):
        (FlatpakPackage):
        (FlatpakPackage.__init__):
        (FlatpakPackage.__str__):
        (FlatpakPackage.is_installed):
        (FlatpakPackage.install):
        (FlatpakPackage.update):
        (WebkitFlatpak):
        (WebkitFlatpak.load_from_args):
        (WebkitFlatpak.__init__):
        (WebkitFlatpak.check_flatpak):
        (WebkitFlatpak.check_flatpak.comparable_version):
        (WebkitFlatpak.clean_args):
        (WebkitFlatpak.run_in_sandbox):
        (WebkitFlatpak.run):
        (WebkitFlatpak.has_environment):
        (WebkitFlatpak.setup_dev_env):
        (WebkitFlatpak.install_all):
        (WebkitFlatpak.run_gdb):
        (WebkitFlatpak.update_all):
        (is_sandboxed):
        (run_in_sandbox_if_available):
        * flatpak/org.webkit.GTK.yaml: Added.
        * flatpak/org.webkit.WPE.yaml: Added.
        * flatpak/org.webkit.WebKit.yaml: Added.
        * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
        * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Added.

2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>

        [iOS] DataTransfer.getData always returns the empty string when dropping text
        https://bugs.webkit.org/show_bug.cgi?id=187130
        <rdar://problem/41014117>

        Reviewed by Ryosuke Niwa.

        Add 2 new API tests to verify that:
        -   When dropping an item with text, markup, and URL representations, the page is allowed to get "text/html",
            "text/plain" and "text/uri-list" data.
        -   Adding a suggested name to a plain text item causes WebKit to treat it as a file, and suppress access to
            DataTransfer.getData().

        Additionally tweaks a couple of existing API tests. Namely, in two API tests
        (ExternalSourceOverrideDropFileUpload and ExternalSourceHTMLToUploadArea) only a markup string is dropped, and
        we previously expected to handle the drop as a file. To allow this test to continue serving its purpose, tweak
        them such that the registered items appear to be file-backed (i.e. by adding a suggested filename in one of the
        tests, and specifying UIPreferredPresentationStyleAttachment in the other).

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (TestWebKitAPI::TEST):

2018-06-28  Basuke Suzuki  <Basuke.Suzuki@sony.com>

        Unreviewed, rolling out r226652.
        https://bugs.webkit.org/show_bug.cgi?id=180827

        "PlatformInfo should never be instantiated in isolation. So, PlatformInfo should
        not have default argument values. The preferred way to get a PlatformInfo object
        is to instantiate a Host object." (Requested by dbates).

        Reverted changeset:

        "[webkitpy] PlatformInfo should have default argument for casual use"
        https://bugs.webkit.org/show_bug.cgi?id=180827

2018-06-28  Simon Fraser  <simon.fraser@apple.com>

        Try to address test failures on the bots.

        Allow the test to distinguish between a failure to find the variable, and an error
        reporting vector capacity.

        * lldb/lldb_webkit_unittest.py:
        (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
        (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):

2018-06-28  Lucas Forschler  <lforschler@apple.com>

        Add Windows support for WEBKIT_API_KEY.
        https://bugs.webkit.org/show_bug.cgi?id=187155

        Reviewed by Daniel Bates.

        * EWSTools/start-queue-win.sh:

2018-06-28  Aakash Jain  <aakash_jain@apple.com>

        [ews-build] Add support for WebKitPy-Tests-EWS
        https://bugs.webkit.org/show_bug.cgi?id=187148

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/ews-build/factories.py: Added WebKitPyFactory.
        * BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPyTests.
        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
        * BuildSlaveSupport/ews-build/config.json: Updated to use CamelCase. 

2018-06-28  Daniel Bates  <dabates@apple.com>

        Fix the iOS build following r233299
        (https://bugs.webkit.org/show_bug.cgi?id=183744)

        Only build lldbWebKitTester on Mac as that is the only supported platform at the time of writing.

        * Makefile:

2018-06-28  Sihui Liu  <sihui_liu@apple.com>

        Cookie API: cookie creation time is wrong
        https://bugs.webkit.org/show_bug.cgi?id=187101

        Reviewed by Geoffrey Garen.

        Add test coverage: make sure the cookie creation time returned is the same as set.

        * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
        (TEST):

2018-06-28  Simon Fraser  <simon.fraser@apple.com>

        The lldb vector summary provider always shows zero capacity
        https://bugs.webkit.org/show_bug.cgi?id=187132

        Reviewed by Daniel Bates.
        
        WTFVectorProvider in lldb_webkit.py was calling GetChildMemberWithName('m_capacity')
        on the buffer instead of the valobj.

        * lldb/lldbWebKitTester/main.cpp:
        (testSummaryProviders):
        * lldb/lldb_webkit.py:
        (WTFVectorProvider.update):
        * lldb/lldb_webkit_unittest.py:
        (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
        (TestSummaryProviders):
        (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
        (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):

2018-06-28  Adam Barth  <abarth@webkit.org>

        Switch OS(FUCHSIA) to using JSCOnly
        https://bugs.webkit.org/show_bug.cgi?id=187133

        Reviewed by Yusuke Suzuki.

        Switch Fuchsia from being a port to just being an OS. We now use a
        CMAKE_TOOLCHAIN_FILE to configure the toolchain and the target triple.

        * Scripts/webkitdirs.pm: Remove isFuchsia() and clients. Turns out we
        can do everything we need using a CMAKE_TOOLCHAIN_FILE via the
        --cmakeargs flag.

2018-06-27  Ryosuke Niwa  <rniwa@webkit.org>

        Make MotionMark's plan file more robust against code changes
        https://bugs.webkit.org/show_bug.cgi?id=187116
        <rdar://problem/41533956>

        Reviewed by Saam Barati.

        Moved the code to auto-start the test to the load event listener.

        * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:

2018-06-27  Daniel Bates  <dabates@apple.com>

        Add some tests for lldb_webkit.py
        https://bugs.webkit.org/show_bug.cgi?id=183744

        Reviewed by Alexey Proskuryakov.

        Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
        and WTF::String objects.

        The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
        program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
        on Mac.

        * Makefile: Build the simple test tool lldbWebKitTester on Mac.
        * Scripts/build-lldbwebkittester: Added.
        (buildProjectOrDie):
        * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
        from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
        this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
        the file and take advantage of Python's default error semantics to throw an exception
        if the import fails instead of handling it ourself. This has the side effect that we
        now always import the LLDB Python module even if this script is invoked with --help.
        If this turns out to be a significant annoyance then we can look to dynamically import
        the module as we did before this change.
        (webkit_build_dir):
        (main):
        (developer_dir): Deleted.
        (import_lldb): Deleted.
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
        that fact that test-webkitpy does not support class and module fixtures. This is because
        test-webkitpy currently implements parallelism by breaking down existing test classes
        into individual test methods itself and having each worker run exactly one test method (via
        unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
        setUpModule()/setUpClass() are called for each test method as opposed to once per test
        class/test module.
        (remove_dir): Ditto.
        * Scripts/webkitpy/common/system/systemhost.py:
        (SystemHost):
        (SystemHost.path_to_lldb_python_directory): Added.
        * Scripts/webkitpy/test/main.py:
        (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
        (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
        lldbWebKitTester on Mac.
        (main): Add Tools/lldb to the test search path if the platform has lldb.py.
        (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
        (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
        If we will run these tests then build lldbWebKitTester if it has not already been built as the
        unit tests depend on this program.
        * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
        * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
        * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
        * lldb/lldbWebKitTester/Makefile: Added.
        * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
        * lldb/lldbWebKitTester/main.cpp: Added.
        (breakForTestingSummaryProviders):
        (utf16String):
        (testSummaryProviders):
        (main):
        * lldb/lldb_webkit_unittest.py: Added.
        (destroy_cached_debug_session):
        (LLDBDebugSession):
        (LLDBDebugSession.setup):
        (LLDBDebugSession.tearDown):
        (TestSummaryProviders):
        (TestSummaryProviders.setUpClass):
        (TestSummaryProviders._sbFrame):
        (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
        (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
        (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
        (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
        (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
        (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
        (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
        (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):

2018-06-27  Adam Barth  <abarth@webkit.org>

        Add Fuchsia support to build-jsc
        https://bugs.webkit.org/show_bug.cgi?id=187086

        Reviewed by Yusuke Suzuki.

        Add Fuchsia port to webkitdirs.pm. This patch is sufficient to make
        build-jsc kick off a cmake for Fuchsia.

        * Scripts/webkitdirs.pm:
        (determineSourceDir):
        (argumentsForConfiguration):
        (determineXcodeSDK):
        (findMatchingArguments):
        (determinePortName):
        (isFuchsia):
        (setupAppleWinEnv):
        (wrapperPrefixIfNeeded):
        (relaunchIOSSimulator):
        (debugMiniBrowser):

2018-06-27  Daniel Bates  <dabates@apple.com>

        style-queue "AttributeError: 'NoneType' object has no attribute 'is_obsolete'" when processing security patch
        https://bugs.webkit.org/show_bug.cgi?id=187120

        Reviewed by David Kilzer.

        Teach the style queue how to refetch a patch from the status server as we did for non-Style
        EWS queues.

        * Scripts/webkitpy/tool/bot/stylequeuetask.py:
        (StyleQueueTask.validate): Similar to change made to EarlyWarningSystemTask.validate() in r233107,
        only check if the bug associated with the patch we are processing is closed if the attachment has a
        non-None Bug object.
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (AbstractEarlyWarningSystem.refetch_patch): Extract logic to refetch a patch from here...
        * Scripts/webkitpy/tool/commands/queues.py:
        (PatchProcessingQueue._refetch_patch): ... to here.
        (StyleQueue.refetch_patch): Turn around and call PatchProcessingQueue._refetch_patch().

2018-06-27  Tadeu Zagallo  <tzagallo@apple.com>

        Unreviewed, add myself as a WebKit committer.

        * Scripts/webkitpy/common/config/contributors.json:

2018-06-27  Daniel Bates  <dabates@apple.com>

        webkit-patch should ignore non-ASCII characters in the status server API key
        https://bugs.webkit.org/show_bug.cgi?id=187107

        Reviewed by Lucas Forschler.

        The API key should only consists of ASCII characters. If it contains any
        non-ASCII characters then log a warning and ignore them.

        * Scripts/webkitpy/common/net/statusserver.py:
        (StatusServer.set_api_key): Force conversion to ASCII.
        * Scripts/webkitpy/tool/main.py:
        (WebKitPatch._status_server_api_key): Convert to ASCII, ignoring non-ASCII
        characters and logging a warning.

2018-06-27  Jonathan Bedard  <jbedard@apple.com>

        Enable WebKit iOS 12 build
        https://bugs.webkit.org/show_bug.cgi?id=187024
        <rdar://problem/39759057>

        Reviewed by David Kilzer.

        * Scripts/configure-xcode-for-ios-development:
        (copyMissingHeadersFromSDKToSDKIfNeeded): Copy launch.h into embedded SDKs.

2018-06-27  Robin Morisset  <rmorisset@apple.com>

        [WSL] Add a control-flow stack to the execution rules in WSL.ott
        https://bugs.webkit.org/show_bug.cgi?id=186310

        Rubberstamped by Filip Pizlo.

        The goal of this is to enable (future) rules about uniform control flow for barriers.
        It required adding two new special construct: Join(s) and JoinExpr(e) whose only role is to pop the last element of the stack.

        * WebGPUShadingLanguageRI/SpecWork/WSL.ott:

2018-06-27  Robin Morisset  <rmorisset@apple.com>

        [WSL] Fix minor formatting issues in the grammar section
        https://bugs.webkit.org/show_bug.cgi?id=186310

        Rubberstamped by Filip Pizlo.

        * WebGPUShadingLanguageRI/SpecWork/source/index.rst:

2018-06-27  Robin Morisset  <rmorisset@apple.com>

        [WSL] Put the full grammar in the Sphinx document
        https://bugs.webkit.org/show_bug.cgi?id=186310

        Rubberstamped by Filip Pizlo.

        Put the grammar's production rules in the Sphinx document, along with a few comments and the rules for desugaring.
        Also includes a bit of clean-up of the antlr rules.

        * WebGPUShadingLanguageRI/SpecWork/WSL.g4:
        * WebGPUShadingLanguageRI/SpecWork/source/index.rst:

2018-06-26  Chris Dumez  <cdumez@apple.com>

        Deal better with the network process crashing on startup
        https://bugs.webkit.org/show_bug.cgi?id=187065
        <rdar://problem/41451622>

        Reviewed by Geoffrey Garen.

        Add layout test coverage.

        * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
        (-[MonitorWebContentCrashNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
        (-[MonitorWebContentCrashNavigationDelegate webView:didFinishNavigation:]):
        (TestWebKitAPI::TEST):

2018-06-25  Yusuke Suzuki  <utatane.tea@gmail.com>

        Remove static initializers more
        https://bugs.webkit.org/show_bug.cgi?id=186969

        Reviewed by Michael Catanzaro.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::assignedUrlsCache):
        (WTR::dumpResourceURL):
        (WTR::InjectedBundlePage::resetAfterTest):
        (WTR::InjectedBundlePage::didInitiateLoadForResource):
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
        (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
        (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
        (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
        (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
        (WTR::AccessibilityUIElement::stringAttributeValue):
        Use NeverDestroyed<> and static functions.

2018-06-26  Aakash Jain  <aakash_jain@apple.com>

        [ews-build] Add support for compiling WebKit
        https://bugs.webkit.org/show_bug.cgi?id=187019

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/ews-build/steps.py:
        (CompileWebKit): Added, class to compile WebKit.
        (CleanBuild): Added, class to clean up the build.
        (KillOldProcesses): Added, class to kill old processes.
        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
        * BuildSlaveSupport/ews-build/config.json: Renamed ios-11-simulator to ios-simulator-11, to match with build.webkit.org code.
        Added configuration, architecture which is required for compiling. Renamed Release to release as the tools expect lower-case release.
        * BuildSlaveSupport/ews-build/factories.py: Added BuildFactory.
        * BuildSlaveSupport/ews-build/loadConfig.py: Renamed configuraton value to lower-case as tools expect lower-case values.
        * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Ditto.

2018-06-26  Aakash Jain  <aakash_jain@apple.com>

        [ews-build] Add support for WebKitPerl-Tests-EWS
        https://bugs.webkit.org/show_bug.cgi?id=187023

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/ews-build/config.json: Added WebKitPerl-tests-EWS.
        * BuildSlaveSupport/ews-build/factories.py: Added WebKitPerlFactory.
        * BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPerlTests.
        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.

2018-06-26  Aakash Jain  <aakash_jain@apple.com>

        [build.webkit.org] Rename badly named variable kls to schedulerType
        https://bugs.webkit.org/show_bug.cgi?id=186926

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
        (loadBuilderConfig): Renamed kls to schedulerType.

2018-06-26  Daniel Bates  <dabates@apple.com>

        EWS should pass --status-host-uses-http when invoking webkit-patch, if needed
        https://bugs.webkit.org/show_bug.cgi?id=187061

        Reviewed by Per Arne Vollan.

        When EWS invokes webkit-patch to perform an operation (e.g. apply an attachment)
        it should pass the command line option --status-host-uses-http, if EWS was
        started with this command line option, so that we query the status server over
        HTTP in child "webkit-patch" processes as we do in the main EWS process.

        * Scripts/webkitpy/common/net/statusserver_mock.py:
        (MockStatusServer.__init__):
        * Scripts/webkitpy/tool/commands/queues.py:
        (AbstractQueue.run_webkit_patch):

2018-06-26  Daniel Bates  <dabates@apple.com>

        webkit-patch: Make attachment commands work with status-server hosted attachments
        https://bugs.webkit.org/show_bug.cgi?id=187056

        Reviewed by Per Arne Vollan.

        Allow the EWS bots to apply, build, test, check-style, and (in the future) land
        attachments hosted on the status server. We only download an attachment from the
        status server if we do not have sufficient permission to download it from Bugzilla
        (e.g. security-sensitive patches).

        A valid status server API key is required to run these commands by hand. Otherwise,
        the status server will not provide attachment data.

        * Scripts/webkitpy/common/net/statusserver_mock.py:
        (MockStatusServer.fetch_attachment): Log a message for testing purposes.
        * Scripts/webkitpy/tool/commands/download.py:
        (ProcessAttachmentsMixin._fetch_list_of_patches_to_process): Fetch the attachment
        from the status server if we do not have permission to fetch it from Bugzilla.
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        (EarlyWarningSystemTest._default_expected_logs): Update expected result when
        using a custom work item and when fetching an attachment from the status server.
        (_test_ews): Modified to take use_security_sensitive_patch (defaults to False) as
        to whether to use a security-sensitive patch when testing.
        (test_ewses_with_security_sensitive_patch): Added.

2018-06-26  Daniel Bates  <dabates@apple.com>

        contributors.json fails to parse after r233209

        Removing trailing ',' that caused this file to be malformed. Also ran
        "validate-committer-lists -c" to canonicalize the style of this file.

        * Scripts/webkitpy/common/config/contributors.json:

2018-06-26  Timothy Horton  <timothy_horton@apple.com>

        Add Aditya to contributors.json as a contributor

        * Scripts/webkitpy/common/config/contributors.json:

2018-06-26  Brent Fulgham  <bfulgham@apple.com>

        Provide a way for Injected Bundles to indicate classes approved for NSSecureCoding
        https://bugs.webkit.org/show_bug.cgi?id=186788
        <rdar://problem/41094167>

        Reviewed by Chris Dumez.

        Add a new test case to exercise the class check during NSSecureCoding.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.h: Added.
        * TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.mm: Added.
        (-[CustomBundleObject initWithValue:]):
        (+[CustomBundleObject supportsSecureCoding]):
        (-[CustomBundleObject copyWithZone:]):
        (-[CustomBundleObject initWithCoder:]):
        (-[CustomBundleObject encodeWithCoder:]):
        * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm: Added.
        (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
        (TestWebKitAPI::didFinishLoadForFrame):
        * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter_Bundle.mm: Added.
        (TestWebKitAPI::CustomBundleParameterTest::CustomBundleParameterTest):
        (TestWebKitAPI::CustomBundleParameterTest::didCreatePage):

2018-06-25  Daniel Bates  <dabates@apple.com>

        Log a message when fetching attachment data from the status server
        https://bugs.webkit.org/show_bug.cgi?id=187032

        Reviewed by Zalan Bujtas.

        Currently we silently fetch from the status server an attachment when fetching
        the attachment from Bugzilla fails due to an access denied error. Instead we
        should emit a message when fetching data from the status server to indicate
        that webkit-patch/EWS is still processing the command/trying to obtain the
        patch.

        * Scripts/webkitpy/common/net/statusserver.py:
        (StatusServer._fetch_attachment_page):

2018-06-25  Aakash Jain  <aakash_jain@apple.com>

        [ews-build] Add support for Bindings-tests-EWS
        https://bugs.webkit.org/show_bug.cgi?id=187014

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/ews-build/factories.py:
        (BindingsFactory): Added RunBindingsTests build step to BindingsFactory.
        * BuildSlaveSupport/ews-build/steps.py:
        (RunBindingsTests): Added build-step for running Bindings tests.
        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.

2018-06-25  Aakash Jain  <aakash_jain@apple.com>

        [ews-build] Add support for Style-EWS
        https://bugs.webkit.org/show_bug.cgi?id=186955

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/ews-build/factories.py:
        (Factory): Base class for all the factory.
        * BuildSlaveSupport/ews-build/loadConfig.py: Initialize factory with required parameters.
        * BuildSlaveSupport/ews-build/runUnittests.py: Added, script to run all the unit tests.
        * BuildSlaveSupport/ews-build/steps.py: Added.
        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.

2018-06-25  Youenn Fablet  <youenn@apple.com>

        Add API to control mock media devices
        https://bugs.webkit.org/show_bug.cgi?id=186958

        Reviewed by Eric Carlson.

        Add test runner API to clear/add/remove/reset mock media devices.

        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::addMockMediaDevice):
        (WTR::TestRunner::addMockCameraDevice):
        (WTR::TestRunner::addMockMicrophoneDevice):
        (WTR::TestRunner::addMockScreenDevice):
        (WTR::TestRunner::clearMockMediaDevices):
        (WTR::TestRunner::removeMockMediaDevice):
        (WTR::TestRunner::resetMockMediaDevices):
        * WebKitTestRunner/InjectedBundle/TestRunner.h:
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::addMockMediaDevice):
        (WTR::TestController::clearMockMediaDevices):
        (WTR::TestController::removeMockMediaDevice):
        (WTR::TestController::resetMockMediaDevices):
        * WebKitTestRunner/TestController.h:
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

2018-06-25  Aakash Jain  <aakash_jain@apple.com>

        [ews-build] Add support for try Buildbot try schedulers
        https://bugs.webkit.org/show_bug.cgi?id=186948

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/ews-build/config.json: Use Try_Userpass scheduler.
        * BuildSlaveSupport/ews-build/loadConfig.py: Updated to use try scheduler.

2018-06-25  Ross Kirsling  <ross.kirsling@sony.com>

        [WinCairo] Unreviewed build fix for r233088.

        * BuildSlaveSupport/built-product-archive:
        (extractBuiltProduct):
        "move" throws instead of overwriting, so just use "copy" instead.

2018-06-25  Leo Balter  <leonardo.balter@gmail.com>

        [test262-runner] Sort the list of failing files in the HTML report
        https://bugs.webkit.org/show_bug.cgi?id=186998

        Reviewed by Michael Saboff.

        * Scripts/test262/Runner.pm:
        (printHTMLResults): The current list of failing files it not ordered and it's hard to read.
        This small patch will sort the list.

2018-06-25  Robin Morisset  <rmorisset@apple.com>

        [WSL] Start writing the Sphinx document
        https://bugs.webkit.org/show_bug.cgi?id=186310

        Rubberstamped by Filip Pizlo.

        Very early work, just has the lexer and a few fragments of the parser so far.
        Also fixing some minor mistake in the formal rules.

        * WebGPUShadingLanguageRI/SpecWork/WSL.g4:
        * WebGPUShadingLanguageRI/SpecWork/WSL.ott:
        * WebGPUShadingLanguageRI/SpecWork/source/conf.py:
        * WebGPUShadingLanguageRI/SpecWork/source/index.rst:

2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>

        [WTF] Add user-defined literal for ASCIILiteral
        https://bugs.webkit.org/show_bug.cgi?id=186839

        Reviewed by Darin Adler.

        * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/Tests/WTF/WTFString.cpp:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/Tests/WTF/WorkerPool.cpp:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
        (TEST_F):
        * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
        (TestWebKitAPI::TEST_F):
        * TestWebKitAPI/Tests/WebCore/URL.cpp:
        (TestWebKitAPI::TEST_F):
        * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
        (TestWebKitAPI::TEST_F):
        * TestWebKitAPI/Tests/WebCore/mac/GPUTest.h:
        * TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm:
        (-[MockContentFilterEnabler initWithCoder:]):
        * TestWebKitAPI/Tests/mac/ContentFiltering.mm:
        (TestWebKitAPI::loadAlternateTest):

2018-06-22  Brady Eidson  <beidson@apple.com>

        WKURLSchemeHandler doesn't handle sync XHR.
        <rdar://problem/40955884> and https://bugs.webkit.org/show_bug.cgi?id=186902

        Reviewed by Chris Dumez.

        * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
        (-[SyncScheme webView:startURLSchemeTask:]):
        (-[SyncScheme webView:stopURLSchemeTask:]):
        (-[SyncMessageHandler userContentController:didReceiveScriptMessage:]):
        (catch):

2018-06-22  Daniel Bates  <dabates@apple.com>

        Security EWS: bots fails with exception 'NoneType' object has no attribute 'is_closed'
        https://bugs.webkit.org/show_bug.cgi?id=186923

        Reviewed by Lucas Forschler.

        Attachments downloaded from the status server (http://webkit-queues.webkit.org) do not
        have an associated Bug object (i.e. Attachment.bug() is None) and reflect the state they
        were in, including flags set, at the time they were uploaded to the status server. We
        will add support for fetching up-to-date status info about the attachment and its bug
        in <https://bugs.webkit.org/show_bug.cgi?id=186817>. For now, we only check if the
        bug associated with the patch we are processing is closed if the attachment has a
        non-None Bug object.

        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
        (EarlyWarningSystemTask.validate):

2018-06-22  Ross Kirsling  <ross.kirsling@sony.com>

        [Win] ImageDiff should use DLLLauncher
        https://bugs.webkit.org/show_bug.cgi?id=186927

        ImageDiff should use DLLLauncher to find DLLs under WEBKIT_LIBRARIES, in the same way as DRT & TestWebKitAPI.

        Reviewed by Per Arne Vollan.

        * ImageDiff/CMakeLists.txt:
        * ImageDiff/ImageDiff.cpp:
        (dllLauncherEntryPoint):
        * ImageDiff/PlatformWin.cmake:

2018-06-22  Basuke Suzuki  <Basuke.Suzuki@sony.com>

        [style] Fix --git-index option for check-webkit-style command
        https://bugs.webkit.org/show_bug.cgi?id=186810

        When --git-index is specified, it should be compared with HEAD, not the origin/master.

        Reviewed by Daniel Bates.

        * Scripts/webkitpy/common/checkout/scm/git.py:
        (Git.create_patch):
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
        (test_create_patch_with_git_index): Added.

2018-06-22  Ryan Haddad  <ryanhaddad@apple.com>

        Unreviewed, fix syntax error introduced by r233088.

        * BuildSlaveSupport/built-product-archive:
        (extractBuiltProduct):

2018-06-22  Ross Kirsling  <ross.kirsling@sony.com>

        [WinCairo][Buildbot] Test bots should use same WinCairoRequirements version as the triggering build
        https://bugs.webkit.org/show_bug.cgi?id=186857

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/built-product-archive:
        (archiveBuiltProduct):
        (extractBuiltProduct):
        Save and restore the WinCairoRequirements version using the build archive.

        * Scripts/download-github-release.py: Renamed from Tools/Scripts/download-latest-github-release.py.
        Generalize download script -- get the latest version by default, but allow an arbitrary version to be specified.

        * Scripts/update-vswhere.py:
        Consume renamed script.

        * Scripts/update-webkit-wincairo-libs.py:
        Consume renamed script and specify a version to download when a config file is present.

2018-06-20  Darin Adler  <darin@apple.com>

        [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
        https://bugs.webkit.org/show_bug.cgi?id=186875

        Reviewed by Anders Carlsson.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (activateTestingFonts): Use isDirectory:NO to create a URL for a font file.
        * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
        (WTR::activateFonts): Ditto.
        (WTR::installFakeHelvetica): Ditto.

2018-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] WebDriver: use a dictionary for session capabilities in StartAutomationSession message
        https://bugs.webkit.org/show_bug.cgi?id=186915

        Reviewed by Žan Doberšek.

        Update /webkit/WebKitAutomationSession/request-session to use the new StartAutomationSession message signature.

        * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

2018-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix GLib test /webkit/WebKitSecurityManager/file-xhr after r231000

        We are now receiving two console messages instead of one. Simply update the test to check both messages.

        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
        (consoleMessageReceivedCallback):
        (testWebContextSecurityFileXHR):

2018-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed GLib gardening. Update expectations of TestSSL.

        /webkit/WebKitWebView/tls-errors-policy and /webkit/WebKitWebView/load-failed-with-tls-errors are failing only
        in the bots.

        * TestWebKitAPI/glib/TestExpectations.json:

2018-06-21  Daniel Bates  <dabates@apple.com>

        EWS for security bugs
        https://bugs.webkit.org/show_bug.cgi?id=186291
        <rdar://problem/40829658>

        Substitute webkit.status-api-key for webkit.status_api_key as Git configuration variables can
        only consist of alphanumeric characters and underscores (_) per the second paragraph of section
        Configuration File of <https://git-scm.com/docs/git-config/2.18.0#_configuration_file>:

             The variable names are case-insensitive, allow only alphanumeric characters and -, and must
             start with an alphabetic character.

        * Scripts/webkitpy/tool/main.py:
        (WebKitPatch._status_server_api_key_from_git):

2018-06-21  Daniel Bates  <dabates@apple.com>

        EWS for security bugs
        https://bugs.webkit.org/show_bug.cgi?id=186291
        <rdar://problem/40829658>

        In r232979, I inadvertently removed a line of code in _parse_authorized_api_keys() to define a local called api_keys.
        Add this code back.

        * QueueStatusServer/config/authorization.py:
        (_parse_authorized_api_keys):

2018-06-21  Daniel Bates  <dabates@apple.com>

        EWS should not try to post comments or upload result archives to security-sensitive
        bugs unless it has access
        https://bugs.webkit.org/show_bug.cgi?id=186831

        Reviewed by Lucas Forschler.

        Following r232979 security-sensitive patches are uploaded to the status server so
        that they can be retrieved and processed by EWS bots without the need for Bugzilla
        security bug access. Although the EWS machinery is robust against unexpected exceptions,
        including exceptions raised when interacting with Bugzilla bugs/attachments with
        insufficient credentials, we should not depend on such defenses as they cause webkit-
        patch to log a message for the "unexpected" exception. We should reserve such logging
        for truly unexpected exceptions that indicate a programming mistake that we need to fix.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (AbstractEarlyWarningSystem._post_reject_message_on_bug): Bail out early if we cannot
        access the bug.
        * Scripts/webkitpy/tool/commands/queues.py:
        (PatchProcessingQueue._can_access_bug): Added.
        (PatchProcessingQueue._upload_results_archive_for_patch): Only add an attachment if we
        can access the bug.
        (CommitQueue.process_work_item): Only post a rejection comment (i.e. call CommitterValidatorreject_patch_from_commit_queue())
        if we can access the bug.

2018-06-21  Lucas Forschler  <lforschler@apple.com>

        bisect-builds --list not showing all builds
        https://bugs.webkit.org/show_bug.cgi?id=185790

        The AWS Gateway API call into dynamoDB is limited to returning 1MB of query data. Our archive set has overgrown this limit,
        causing us to retrieve a truncated list of results. Fortunately, when this limit is reached, dynamoDB returns a 
        "LastEvaluatedKey", which can be used to continue the query in another request. 

        This patch teaches bisect-build to pass along this key when needed. The backend api was updated from v2 to v2_1 to support
        this new querystring option. Any existing code using v2 will not be affected.
        
        Reviewed by Aakash Jain.

        * Scripts/bisect-builds:
        (get_api_url): added optional LastEvaluatedKey argument, which will append the query string to the base api url.
        (fetch_revision_list): Added to allow a recursive call which will query until we retrieve every item requested.
        (main): teach how to use fetch_revision_list.

2018-06-21  Keith Rollin  <krollin@apple.com>

        check-webkit-style should warn about exported inline functions
        https://bugs.webkit.org/show_bug.cgi?id=186861
        <rdar://problem/41303668>

        Reviewed by Brent Fulgham.

        When checking binaries compiled with LTO enabled, WebKit's
        check-for-weak-vtables-and-externals script can complain about
        exported inline functions. For instance, in
        Source/WebCore/page/scrolling/ScrollingTree.h, the following:

        WEBCORE_EXPORT virtual void reportSynchronousScrollingReasonsChanged(MonotonicTime, SynchronousScrollingReasons) { }
        WEBCORE_EXPORT virtual void reportExposedUnfilledArea(MonotonicTime, unsigned /* unfilledArea */) { }

        Can result in the following error messages:

        ERROR: WebCore has a weak external symbol in it (.../OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore)
        ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
        ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
        ERROR: symbol __ZN7WebCore13ScrollingTree25reportExposedUnfilledAreaEN3WTF13MonotonicTimeEj
        ERROR: symbol __ZN7WebCore13ScrollingTree40reportSynchronousScrollingReasonsChangedEN3WTF13MonotonicTimeEj

        Unfortunately, these errors are only emitted when LTO is enabled,
        meaning that a developer could check-in a file that will fail an LTO
        build if they don't build with that option locally. Therefore, try to
        head this off by updating check-webkit-style to identify and warn
        about these cases (which includes when an export macro is applied
        directly to an inline method as well as when an inline method is part
        of an exported class).

        * Scripts/webkitpy/style/checkers/cpp.py:
        (_FunctionState.begin):
        (_FunctionState.export_macro):
        (_ClassInfo.__init__):
        (check_for_non_standard_constructs):
        (check_function_definition):
        (process_line):
        (CppChecker):
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (FunctionDetectionTest.perform_function_detection):
        (FunctionDetectionTest.test_webcore_export):

2018-06-21  Aakash Jain  <aakash_jain@apple.com>

        [ews-build] unit-tests fail when run from another directory
        https://bugs.webkit.org/show_bug.cgi?id=186872

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/ews-build/loadConfig.py:
        (loadBuilderConfig): Add support for passing master_prefix_path.
        * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
        (ConfigDotJSONTest.test_configuration): Set master_prefix_path as current directory.

2018-06-21  Aakash Jain  <aakash_jain@apple.com>

        Add support for using localhost worker in OpenSource EWS Buildbot
        https://bugs.webkit.org/show_bug.cgi?id=186871

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/ews-build/loadConfig.py:
        (loadBuilderConfig): Added a worker named 'local-worker' if use_localhost_worker option is used.
        * BuildSlaveSupport/ews-build/master.cfg: Check BUILDBOT_TESTING environment variable and use_localhost_worker if so.

2018-06-21  Aakash Jain  <aakash_jain@apple.com>

        Add force schedulers to OpenSource EWS Buildbot
        https://bugs.webkit.org/show_bug.cgi?id=186876

        Reviewed by Lucas Forschler.

        * BuildSlaveSupport/ews-build/loadConfig.py:
        (loadBuilderConfig): Added support for ForceScheduler.

2018-06-21  Robin Morisset  <rmorisset@apple.com>

        [WSL] Merge WSL_type.ott and WSL_exec.ott
        https://bugs.webkit.org/show_bug.cgi?id=186310

        Rubberstamped by Filip Pizlo.

        I moved the execution rules into WSL_type.ott, that was renamed WSL.ott.
        I also changed the execution judgements:
        - they now emit memory events instead of having an explicit store (so they can be connected later to a memory model)
        - the environment is now unchangeable (except inside blocks, which are the only place that variable declarations can appear)
        - various rules were simplified.

        * WebGPUShadingLanguageRI/SpecWork/WSL.ott: Copied from Tools/WebGPUShadingLanguageRI/SpecWork/WSL_type.ott.
        * WebGPUShadingLanguageRI/SpecWork/WSL_exec.ott: Removed.
        * WebGPUShadingLanguageRI/SpecWork/WSL_type.ott: Removed.

2018-06-21  Leo Balter  <leonardo.balter@gmail.com>

        [test262-runner] Improve failures output
        https://bugs.webkit.org/show_bug.cgi?id=186858

        Reviewed by Michael Saboff.

        * Scripts/test262/Runner.pm:
        (main):
        (processResult):

2018-06-21  Caitlin Potter  <caitp@igalia.com>

        [Tools] add a --debug option to test262/Runner.pm for buildbots
        https://bugs.webkit.org/show_bug.cgi?id=186113

        Reviewed by Michael Saboff.

        test262-runner runs Debug builds by default, but this allows us to be
        explicit about it in buildbots.

        * Scripts/test262/Runner.pm:
        (processCLI):

2018-06-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        run-gtk-tests (glib/common.py) cannot determine build directory when webKitBranchBuild=true
        https://bugs.webkit.org/show_bug.cgi?id=185643

        Reviewed by Frédéric Wang.

        Check if webKitBranchBuild is true in git config to add the branch name to the build path.

        * Scripts/webkitpy/common/checkout/scm/git.py:
        (Git.read_git_config): Add output_type parameter.
        (Git.read_config): Call read_git_config with cws and executive.
        (Git._upstream_branch): Use read_config().
        (Git._assert_can_squash): Ditto.
        (Git.remote_branch_ref): Ditto.
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
        (GitSVNTest.test_read_git_config):
        * glib/common.py:
        (get_build_path):

2018-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>

        [WebKit on watchOS] Fixed position elements sometimes flicker when scrolling
        https://bugs.webkit.org/show_bug.cgi?id=186860
        <rdar://problem/39953563>

        Reviewed by Tim Horton.

        Add a new API test to exercise a race condition between receiving remote layer tree commits and updating visible
        content rects which would result in the compositing layer for a fixed position element sometimes appearing in
        the wrong place. See WebKit ChangeLog for more details.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKitCocoa/fixed-nav-bar.html: Added.
        * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm: Added.
        (traverseLayerTree):
        (TEST):

2018-06-20  Daniel Bates  <dabates@apple.com>

        AttributeError: StatusServer instance has no attribute '_api_key' thrown when processing a patch
        https://bugs.webkit.org/show_bug.cgi?id=186852

        Fixes an issue where StatusServer._api_key may not be defined. This issue manifests itself
        in a Python AttributeError exception when an EWS bot tries to fetch the next patch to process.

        Currently StatusServer._api_key is only defined when either the environment variable WEBKIT_STATUS_API_KEY
        or the Git configuration key webkit.status_api_key has a non-empty value. Instead we should
        always define StatusServer._api_key in the StatusServer constructor.

        * Scripts/webkitpy/common/net/statusserver.py:
        (StatusServer.__init__):

2018-06-20  Robin Morisset  <rmorisset@apple.com>

        [WSL] Add details to the sphinx outline
        https://bugs.webkit.org/show_bug.cgi?id=186310

        Rubberstamped by Filip Pizlo.

        Mostly improving the sphinx outline.
        Also started moving the execution rules to WSL_type.ott (which will eventually become WSL.ott).
        Tried formalizing the gathering of declarations into the environment, but I think I will scratch it.
            It is both trivial to do (and to explain in english) and a bit of a pain to formalize.

        * WebGPUShadingLanguageRI/SpecWork/WSL_type.ott:
        * WebGPUShadingLanguageRI/SpecWork/source/index.rst:

2018-06-20  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r232844.
        https://bugs.webkit.org/show_bug.cgi?id=186843

        "Too many flakiness on the tests, so the EWS bots cant process
        patches correctly" (Requested by clopez on #webkit).

        Reverted changeset:

        "[GTK] Enable tests on the GTK EWS queue"
        https://bugs.webkit.org/show_bug.cgi?id=186559
        https://trac.webkit.org/changeset/232844

2018-06-20  Rob Buis  <rbuis@igalia.com>

        [GTK] ASSERTION FAILED: url == m_string in UserAgentQuirks test
        https://bugs.webkit.org/show_bug.cgi?id=186838

        This URL constructor expects canonicalized input, so fix the passed URL.

        Reviewed by Frédéric Wang.

        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
        (TestWebKitAPI::TEST):

2018-06-20  Robin Morisset  <rmorisset@apple.com>

        [WSL] Make the typing rules explicitely translate type syntax into actual types
        https://bugs.webkit.org/show_bug.cgi?id=186310

        Rubberstamped by Filip Pizlo.

        The typing rules must describe how and most importantly when typedefs and the like are resolved.
        This is important because they can be shadowed (by type variables for example), and we want to make it unambiguous what behaviour is required in that case.

        * WebGPUShadingLanguageRI/SpecWork/WSL.g4:
        * WebGPUShadingLanguageRI/SpecWork/WSL_type.ott:

2018-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>

        [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads
        https://bugs.webkit.org/show_bug.cgi?id=186836

        Reviewed by Carlos Garcia Campos.

        * TestWebKitAPI/Tests/WTF/WorkerPool.cpp:
        (TestWebKitAPI::TEST):

2018-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>

        [WPE] Remove warnings by setting nullptr for unused listeners
        https://bugs.webkit.org/show_bug.cgi?id=186835

        Reviewed by Carlos Garcia Campos.

        frame, axis_source, axis_stop, and axis_discrete are unused.
        Setting nullptr explicitly to remove warnings in GCC.

        * wpe/backends/WindowViewBackend.cpp:

2018-06-19  Leo Balter  <leonardo.balter@gmail.com>

        [test262-runner] Reduce flakiness of unit tests for the runner
        https://bugs.webkit.org/show_bug.cgi?id=186824

        Reviewed by Michael Saboff.

        * Scripts/test262/Runner.pm:
        (main):
        * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:

2018-06-19  Leo Balter  <leonardo.balter@gmail.com>

        [test262-runner] Print results report to HTML
        https://bugs.webkit.org/show_bug.cgi?id=186790

        Reviewed by Michael Saboff.

        After runing the tests, 2 html files are created with a list to failing tests and summaries.
        * Scripts/test262/Runner.pm:
        (main):
        (summarizeResults):
        (printHTML):

2018-06-19  Keith Rollin  <krollin@apple.com>

        Crash running check-webkit-style on webrtc/.../exceptions.py
        https://bugs.webkit.org/show_bug.cgi?id=186816
        <rdar://problem/41262553>

        Reviewed by Michael Catanzaro.

        It's not apparent to me why the crash is occurring. Trying to write a
        unittest that checks this file in isolation does not reproduce the
        crash. But the crash goes away when updating to pylint-0.25.2.

        * Scripts/webkitpy/thirdparty/__init__.py:
        (AutoinstallImportHook._install_pylint):

2018-06-19  Keith Rollin  <krollin@apple.com>

        cpp style checker needs to know more about NOLINT
        https://bugs.webkit.org/show_bug.cgi?id=186796

        Reviewed by Aakash Jain.

        Running check-webkit-style on
        ThirdParty/gtest/src/gtest-internal-inl.h crashes with a KeyError as
        it tries to look up information about a particular #include in a
        dictionary it maintains. The problem has to do with the following
        lines in gtest-internal-inl.h:

        #include <gtest/gtest.h>  // NOLINT
        #include <gtest/gtest-spi.h>

        The NOLINT annotation will prevent the cpp-checker from processing or
        even seeing that line. In skipping that line, information regarding
        that line is NOT added to some internal tables. However, when the code
        that checks that #includes are correctly alphabetized gets to the
        "gtest-spi.h" line, it will not respect the NOLINT annotation and will
        see the gtest.h line. When doing so, it runs afoul of the fact that it
        hadn't seen that line before and it crashes when it tries to look up
        that line in some internal records.

        Fix this by catering to the possibility that a #include line may not
        have been entered into these internal records.

        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_include_line):
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:

2018-06-19  Daniel Bates  <dabates@apple.com>

        EWS for security bugs
        https://bugs.webkit.org/show_bug.cgi?id=186291
        <rdar://problem/40829658>

        Update comment in AbstractEarlyWarningSystem.refetch_patch() to reference <https://bugs.webkit.org/show_bug.cgi?id=186817>.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (AbstractEarlyWarningSystem.refetch_patch):

2018-06-19  Daniel Bates  <dabates@apple.com>

        EWS for security bugs
        https://bugs.webkit.org/show_bug.cgi?id=186291
        <rdar://problem/40829658>

        Reviewed by Lucas Forschler.

        Part 1 of 2.

        Implements support for EWS processing of patches on security sensitive bugs. We add new
        endpoints to the status server to support uploading and downloading of patches and associated
        metadata. When webkit-patch submits a patch for EWS processing it will now upload the contents
        and metadata for the patch to the status server if the patch is on a security sensitive bug.
        We teach the EWS machinery in webkitpy to query the status server for a patch only if fetching
        the patch from Bugzilla is not permitted due to an authorization error.

        Fetching patches from the status server requires an API key. The API key is read from the
        environment variable WEBKIT_STATUS_API_KEY or the value of the Git configuration key webkit.status_api_key
        (in that order). Contact me or another Apple engineer for an API key.

        Additionally, default to using HTTPS when querying the status server and expose an optional
        command line option called --status-host-uses-http to use the former behavior of querying
        over HTTP.

        * QueueStatusServer/config/authorization.py: Added.
        (_path_to_authorized_api_keys_file): Returns the absolute filesystem path to the file authorized_api_keys.txt.
        (_parse_authorized_api_keys):
        (authorized_api_keys):
        (_parse_authorization_header): Parses the API key from the Authorization header. We use a
        custom authentication scheme: "apikey". See remark below for more details.
        (is_authorized): Checks if the request includes an API key and whether that API key is in the
        list of authorized keys (performs a case-sensitive match). The API key may be specified either
        in a HTTP header Authorization or in the query string argument "apikey". When using the HTTP
        headers approach the Authorization header should have the form: "Authorization: apikey X" where
        X is the case-sensitive API key.
        * QueueStatusServer/handlers/fetchattachment.py: Added.
        (FetchAttachment):
        (FetchAttachment.get):
        * QueueStatusServer/handlers/releasepatch.py:
        (ReleasePatch.check_processed_by_all_queues): Returns whether the specified attachment was processed by all the queues.
        (ReleasePatch.post): Delete the patch from AppEngine (if we have it) once the patch was processed
        by all the queues.
        * QueueStatusServer/handlers/submittoews.py:
        (SubmitToEWS._should_add_to_ews_queue): Fix a typo in a comment while I am working in this code.
        * QueueStatusServer/handlers/uploadattachment.py: Added.
        (UploadAttachment):
        (UploadAttachment.get):
        (UploadAttachment.post):
        * QueueStatusServer/main.py: Add new routes /upload-attachment and /attachment to upload an attachment
        and view an attachment (or its metadata), respectively.
        * QueueStatusServer/model/attachmentdata.py: Added.
        (AttachmentData):
        (AttachmentData.add_attachment_data):
        (AttachmentData.lookup_if_exists):
        (AttachmentData.remove_attachment_data):
        * QueueStatusServer/templates/uploadattachment.html: Added.
        * Scripts/webkitpy/common/net/bugzilla/attachment.py:
        (Attachment.committer):
        (Attachment):
        (Attachment.to_json): Serialize to JSON so that we can upload it to AppEngine.
        (Attachment.from_json): Deserialize from JSON. This is used as part of downloading a patch from AppEngine.
        * Scripts/webkitpy/common/net/bugzilla/attachment_unittest.py:
        (AttachmentTest.test_convert_to_json_and_back): Added.
        * Scripts/webkitpy/common/net/bugzilla/bug.py:
        (Bug.groups): Returns a frozenset of groups that the bug is a member of.
        (Bug.is_security_sensitive): Returns whether the bug is in group Security-Sensitive.
        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        (BugzillaQueries.fetch_attachment_ids_from_review_queue): Modified to take an optional boolean, only_security_bugs,
        as to whether to only fetch attachment ids for unreviewed patches associated with security bugs. By default, we
        keep the current behavior and query for the attachment ids of all unreviewed patches that the currently logged in
        Bugzilla user can see, which may include patches associated with security bugs.
        (Bugzilla._parse_date): Update for moved and renamed constant. See remark for class Bugzilla.
        (Bugzilla._parse_bug_dictionary_from_xml): Modified to return an empty dictionary if we do not have access to view the bug.
        Otherwise, extract the name of the group the bug is in.
        (Bugzilla.fetch_bug): Modified to return None if we do not have access to view the bug.
        (Bugzilla._parse_bug_title_from_attachment_page): Extracted out logic to parse the title of the Attachment page
        from _parse_bug_id_from_attachment_page() so that it can be used from both _parse_bug_id_from_attachment_page()
        and get_bug_id_for_attachment_id().
        (Bugzilla): Moved class constant _bugzilla_date_format to Scripts/webkitpy/common/net/bugzilla/constants.py
        and renamed it to BUGZILLA_DATE_FORMAT.
        (Bugzilla.AccessError):
        (Bugzilla.AccessError.__init__):
        (Bugzilla._parse_bug_id_from_attachment_page): Modified to return a tuple of ("bug id", "error code") so that
        the caller can know the reason the parse failed if it did. The parse will fail if we do not have access to view
        the bug.
        (Bugzilla.bug_id_for_attachment_id): Modified to take a boolean throw_on_access_error (default: False)
        as to whether to raise a Bugzilla.AccessError exception and pass it through to get_bug_id_for_attachment_id().
        (Bugzilla.get_bug_id_for_attachment_id): Modified to take a boolean throw_on_access_error (default: False)
        as to whether to raise a Bugzilla.AccessError exception if we do not have access to the bug associated with
        the specified attachment id.
        (Bugzilla.fetch_attachment):
        * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
        (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
        (MockBugzilla):
        (MockBugzilla.fetch_attachment):
        (MockBugzilla.fetch_attachment_contents):
        (MockBugzilla.add_patch_to_bug):
        * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
        * Scripts/webkitpy/common/net/bugzilla/constants.py: Added.
        * Scripts/webkitpy/common/net/statusserver.py:
        (StatusServer)
        (StatusServer.__init__): Modified to take an boolean use_https as to whether to query the server using
        HTTPS (default: True - use HTTPS).
        (StatusServer.set_host): Moved logic to compute the server URL from her to _server_url().
        (StatusServer.set_use_https): Added.
        (StatusServer.set_api_key): Added.
        (StatusServer._server_url): Added.
        (StatusServer._authorization_header_name_and_value_pair): Added.
        (StatusServer.results_url_for_status): Update to use _server_url().
        (StatusServer._post_status_to_server): Ditto.
        (StatusServer._post_svn_revision_to_server): Ditto.
        (StatusServer._post_work_items_to_server): Ditto.
        (StatusServer._upload_attachment_to_server): Added.
        (StatusServer.upload_attachment): Added.
        (StatusServer._post_work_item_to_ews): Update to use _server_url().
        (StatusServer.next_work_item): Ditto.
        (StatusServer._post_release_work_item): Ditto.
        (StatusServer._post_release_lock): Ditto.
        (StatusServer._fetch_attachment_page): Added.
        (StatusServer.fetch_attachment): Added.
        (StatusServer._fetch_url): Add the API Key to the request if we have one.
        (StatusServer.patch_status): Update to use _server_url().
        (StatusServer.svn_revision): Ditto.
        * Scripts/webkitpy/common/net/statusserver_mock.py:
        (MockStatusServer.upload_attachment): Added.
        (MockStatusServer.fetch_attachment): Added.
        * Scripts/webkitpy/tool/bot/feeders.py:
        (EWSFeeder.feed): Modified to download patches on security bugs and upload them to the status server (AppEngine).
        * Scripts/webkitpy/tool/commands/download.py:
        (ProcessAttachmentsMixin._fetch_list_of_patches_to_process): Modified to handle the case when fetching the
        bug details from Bugzilla fail, say because we are not allowed to the view the bug.
        (ProcessBugsMixin._fetch_list_of_patches_to_process): Filter out None values for attachments that we failed
        to fetch, say because we are not allowed to the view the bug the attachment is on.
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (AbstractEarlyWarningSystem.refetch_patch): For now, refetch the patch from the status server. Ideally, we
        need a way to ask the status server to fetch the patch again from Bugzilla (or at least its metadata) so
        that the EWS can check the current state of the patch (i.e. is it still marked r?).
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        (QueryCommandsTest.test_patches_to_review): Update expected result.
        * Scripts/webkitpy/tool/commands/queues.py:
        (AbstractPatchQueue._next_patch): Fetch the patch  from the status server if we failed to fetch it from
        Bugzilla because we do not have permission to view it.
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        (test_upload_of_security_sensitive_patch_with_no_review_and_ews): Added.
        * Scripts/webkitpy/tool/main.py:
        (WebKitPatch):
        (WebKitPatch._status_server_api_key_from_git): Read the API key from the Git configuration key webkit.status_api_key.
        (WebKitPatch._status_server_api_key): Read the API key from the environment variable WEBKIT_STATUS_API_KEY.
        (WebKitPatch.handle_global_options): Read the API key and update the state of the StatusServer object, if applicable.
        * Scripts/webkitpy/tool/steps/obsoletepatches.py:
        (ObsoletePatches.run): Modified to handle the case when fetching the bug details from Bugzilla fail, say because we
        are not allowed to the view the bug.
        * Scripts/webkitpy/tool/steps/submittoews.py:
        (SubmitToEWS.run): Upload the contents of the patch and the Bugzilla metadata about it to the status server
        if the patch was posted to a security bug.

2018-06-19  Daniel Bates  <dabates@apple.com>

        QueueStatusServer: "'NoneType' object has no attribute 'message'" in ReleasePatch.get()
        when attachment is skipped by queue
        https://bugs.webkit.org/show_bug.cgi?id=186748

        Reviewed by Lucas Forschler.

        Fixes an issue where releasing a patch that was skipped by a queue would cause an AttributeError
        in ReleasePatch.get().

        When removing a patch from a queue we update queue statistics. As part of this process
        we record the last message posted to the status server for the patch. Currently if a patch
        is skipped by the queue when picking the next patch to process (say, we failed to fetch the
        attachment) then the queue does not post a message to the status server before it asks the
        status server to remove the patch from the list of patches the queue needs to process. Instead
        the queue should tell the status server that it chose to skip the patch before asking for the
        patch to be removed from its list of patches to process.

        * Scripts/webkitpy/common/net/bugzilla/attachment.py:
        (Attachment.bug_id): Return None if we do not have a bug ID. This can happen if we failed
        to fetch the attachment from Bugzilla (say, Bugzilla's markup changed) or we do not have
        have permission to view the Bugzilla bug.
        * Scripts/webkitpy/common/net/bugzilla/attachment_unittest.py: Added.
        (AttachmentTest):
        (AttachmentTest.test_no_bug_id):
        * Scripts/webkitpy/tool/commands/queues.py:
        (AbstractPatchQueue._next_patch): Call AbstractPatchQueue._did_skip() to post a status
        update to the status server and then release the work item.
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        (AbstractPatchQueueTest.test_next_patch): Update expected result.

2018-06-19  Leo Balter  <leonardo.balter@gmail.com>

        Test262-Runner: Improve files queue to optimize CPU usage/balancing
        https://bugs.webkit.org/show_bug.cgi?id=186443

        Reviewed by Michael Saboff.

        This patch creates a queue manager for to keep the child process open while the parent process feed each child with test files to run.
        * Scripts/test262/Runner.pm:
        (processCLI):
        (main):

2018-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>

        [WebKit on watchOS] Vend username text content type when using scribble in login fields
        https://bugs.webkit.org/show_bug.cgi?id=186791
        <rdar://problem/41226935>

        Reviewed by Beth Dakin.

        Add testing support for grabbing the current text content type of the focused element.

        * DumpRenderTree/ios/UIScriptControllerIOS.mm:
        (WTR::UIScriptController::textContentType const):
        * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
        * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
        (WTR::UIScriptController::textContentType const):
        * TestRunnerShared/UIScriptContext/UIScriptController.h:
        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
        (WTR::UIScriptController::textContentType const):

2018-06-19  Robin Morisset  <rmorisset@apple.com>

        [WSL] Improving the typing rules
        https://bugs.webkit.org/show_bug.cgi?id=186310

        Rubberstamped by Filip Pizlo.

        Several changes:
        - added a "well_formed" judgement, and defined it on function definitions (tying together with the typing rules)
        - cleaned up the desugaring relation (it now works on normal statements, and deals with for loops correctly)
        - added the null literal, the comma operator, the not operator, and parens
        - fixed a bunch of minor typographic issues

        * WebGPUShadingLanguageRI/SpecWork/WSL_type.ott:

2018-06-18  Robin Morisset  <rmorisset@apple.com>

        [WSL] Starting to write the spec
        https://bugs.webkit.org/show_bug.cgi?id=186310

        Rubberstamped by Filip Pizlo.

        This is a snapshot of my current work on the WSL spec (I will try to commit more regularly in the future).

        WSL.g4 is the grammar, in antlr4 format. I only made minor changes in it since last time.

        source/index.rst is the Sphinx document. 
        It currently only contain a very rough outline, and some TODOs.
        It can be compiled with make html or make pdf, and relies on Makefile and source/conf.py.

        WSL_exec.ott is the current set of execution rules I have formalized.
        They will need a fair bit of refactoring, to account for the new desugaring phase,
            to be compatible with whatever memory model we decide on,
            and to be explicit about the memory layout of structs and arrays
        They can be compiled to latex with OTT (which in turn requires OCaml and opam).
            Just ask me by email if you want a pdf of all the rules without having to install all that.

        WSL_type.ott is the current set of local typing rules I have formalized.
            Like WSL_exex.ott, it is very incomplete, lacking all function calls among other things.

        * WebGPUShadingLanguageRI/SpecWork/Makefile: Added.
        * WebGPUShadingLanguageRI/SpecWork/WSL.g4:
        * WebGPUShadingLanguageRI/SpecWork/WSL_exec.ott: Added.
        * WebGPUShadingLanguageRI/SpecWork/WSL_type.ott: Added.
        * WebGPUShadingLanguageRI/SpecWork/source: Added.
        * WebGPUShadingLanguageRI/SpecWork/source/conf.py: Added.
        * WebGPUShadingLanguageRI/SpecWork/source/index.rst: Added.

2018-06-18  Chris Dumez  <cdumez@apple.com>

        Crash under WebProcessPool::networkProcessFailedToLaunch():
        https://bugs.webkit.org/show_bug.cgi?id=186784
        <rdar://problem/33535377>

        Reviewed by Brady Eidson.

        Add API test coverage.

        * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
        (TEST):

2018-06-18  Zan Dobersek  <zdobersek@igalia.com>

        [webkitpy] WPTRunner should remove any metadata content before (re)generating it
        https://bugs.webkit.org/show_bug.cgi?id=186755

        Reviewed by Carlos Garcia Campos.

        WPTRunner generates the WPT-compliant metadata content before each test
        run. Before it does so, it should remove the complete target directory
        for this metadata, allowing any change in the expectations JSON to be
        immediately reflected.

        For example, if a test failure expectation is removed, the related .ini
        metadata file is not generated anymore, but the stale .ini file isn't
        removed from the current metadata directory. To avoid this, purging
        the metadata directory and regenerating it from scratch should be done
        for each test run.

        * Scripts/webkitpy/w3c/wpt_runner.py:
        (WPTRunner._generate_metadata_directory):
        * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
        (WPTRunnerTest.test_generate_metadata_directory):

2018-06-12  Darin Adler  <darin@apple.com>

        [Cocoa] Make some RetainPtr refinements to get more ready for ARC
        https://bugs.webkit.org/show_bug.cgi?id=186526

        Reviewed by Anders Carlsson.

        * DumpRenderTree/mac/LayoutTestHelper.m:
        (colorProfileURLForDisplay): Use CFBridgingRelease instead of using
        CFAutorelease for a bridging use case.

2018-06-16  Leo Balter  <leonardo.balter@gmail.com>

        [test262-runner] Handle items from the config list with inline comments
        https://bugs.webkit.org/show_bug.cgi?id=186707

        Reviewed by Michael Saboff.

        This is a workaround for the Yaml parser that bundles inline comments together with any items.
        * Scripts/test262/Runner.pm:
        (shouldSkip):

2018-06-16  Valerie R Young  <valerie@bocoup.com>

        test262/Runner.pm: option to run test skipped in config file
        https://bugs.webkit.org/show_bug.cgi?id=186660

        Reviewed by Michael Saboff.

        Adds option --skipped-files, -S, to run all files skipped in the
        config.yaml file.

        * Scripts/test262/Runner.pm:
        (processCLI):
        (main):
        (getBuildPath):
        (processFile):
        (processResult):

2018-05-18  Basuke Suzuki  <basuke.suzuki@sony.com>

        Unreviewed, add myself as a WebKit committer.

        * Scripts/webkitpy/common/config/contributors.json:

2018-06-15  Chris Dumez  <cdumez@apple.com>

        Add API test coverage for SW RegistrationDatabase destruction and fix issues found by the test
        https://bugs.webkit.org/show_bug.cgi?id=186681

        Reviewed by Brady Eidson.

       Add API test coverage.

        * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

2018-06-15  Brady Eidson  <beidson@apple.com>

        Crash in both StorageProcess and UIProcess when using custom WKWebsiteDataStores for data management.
        <rdar://problem/41019893> and https://bugs.webkit.org/show_bug.cgi?id=186682

        Reviewed by Chris Dumez.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
        (TEST):

2018-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [GTK] Fix adding error in browserperfdash_runner.

        Unreviewed follow-up fix after r232820.

        * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
        (BrowserPerfDashRunner.run):

2018-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [GTK][WKE] Disable memory pressure handling when running layout tests (WTR)
        https://bugs.webkit.org/show_bug.cgi?id=186663

        Reviewed by Michael Catanzaro.

        Disable memory pressure handling when running tests via WTR by
        setting WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR=1 on the environment.

        * WebKitTestRunner/gtk/main.cpp:
        (main):
        * WebKitTestRunner/wpe/main.cpp:
        (main):

2018-06-15  Jonathan Bedard  <jbedard@apple.com>

        Add iOS 12 and watchOS 5 to webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=186285

        Reviewed by Aakash Jain.

        * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
        * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
        Trigger the right build queues for iOS 12 on check-in.
        * Scripts/webkitpy/common/version_name_map.py:
        (VersionNameMap.__init__): Add iOS 12, tvOS 12 and watchOS 5.
        * Scripts/webkitpy/common/version_name_map_unittest.py:
        (VersionMapTestCase.test_ios_name_by_version): Test iOS 12 version-name mapping.
        * Scripts/webkitpy/port/ios_device_unittest.py:
        (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
        * Scripts/webkitpy/port/ios_simulator_unittest.py:
        (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):

2018-06-14  Saam Barati  <sbarati@apple.com>

        sun spider compile time benchmark fails in run-jsc-benchmarks with JSC_validateOptions=1
        https://bugs.webkit.org/show_bug.cgi?id=186647

        Reviewed by Yusuke Suzuki.

        Let's use `unset JSC_useBlah` instead of `export JSC_useBlah=` to clear environment
        variables. The latter was causing crashes with when JSC_validateOptions was true.

        * Scripts/run-jsc-benchmarks:

2018-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [GTK][buildbot] Raise timeouts for the step benchmark-test on the GTK perf bot
        https://bugs.webkit.org/show_bug.cgi?id=186635

        Reviewed by Michael Catanzaro.

        The current maximum timeout for a run-benchmark test is 1800 (Motionmark plan),
        but the buildbot default timeout for the whole step without text output is 1200.
        That means that a timeout on a single test can cause a whole step abort because
        the buildbot one will trigger first.

        Set the benchmark-test step timeout to 2000 to avoid this.

        When this benchmark-test was added in r197505 it was already added with a higher
        timeout than default (1500) due to the above problem, but it seems this has been
        ignored so far because buildbot won't accept the timeout to be set on the class
        definition (not even on the class constructor).
        The new timeout has to be defined in the addStep call itself.
        I have double-checked that by testing locally with the script run-buildbot-test.py
        And this upstream issue confirms that https://github.com/buildbot/buildbot/issues/3887

        * BuildSlaveSupport/build.webkit.org-config/factories.py:
        (BuildAndPerfTestFactory.__init__):
        (DownloadAndPerfTestFactory.__init__):
        * BuildSlaveSupport/build.webkit.org-config/steps.py:
        (RunBenchmarkTests):

2018-06-14  Roy Reapor  <rreapor@apple.com>

        Use new jQuery file layout
        https://bugs.webkit.org/show_bug.cgi?id=186636

        Reviewed by Aakash Jain.

        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
        * TestResultServer/static-dashboards/run-embedded-unittests.html:

2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>

        [Win][MiniBrowser] Change to use WebKit by default if it's available
        https://bugs.webkit.org/show_bug.cgi?id=186633

        When MiniBrowser is built with WebKit, use it by default. Also add command
        line switch for WebKitLegacy.

        Reviewed by Youenn Fablet.

        * MiniBrowser/win/Common.cpp:
        (parseCommandLine):
        (dllLauncherEntryPoint): Deleted.
        * MiniBrowser/win/Common.h:
        * MiniBrowser/win/WinMain.cpp:
        (wWinMain):
        (dllLauncherEntryPoint):

2018-06-14  Matt Lewis  <jlewis3@apple.com>

        Unreviewed, rolling out r232823.

        This caused both test timeouts and api failures.

        Reverted changeset:

        "[Mail] Use the Mail Viewer width as the base for resolving
        horizontal viewport units"
        https://bugs.webkit.org/show_bug.cgi?id=186585
        https://trac.webkit.org/changeset/232823

2018-06-14  Youenn Fablet  <youenn@apple.com>

        TestWebKitAPI.WebKit.WKNavigationResponsePDFType fails after r232815
        https://bugs.webkit.org/show_bug.cgi?id=186631

        Reviewed by Chris Dumez.

        * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
        (TEST): Update PDF plug-in identifier.

2018-06-14  Leo Balter  <leonardo.balter@gmail.com>

        [test262-runner] Improve displayed settings, use rel paths
        https://bugs.webkit.org/show_bug.cgi?id=186626

        Reviewed by Michael Saboff.

        Use relative paths for the information printed in the settings summary after calling the Test262 Runner. This provides a cleaner summary that is easier to read and consume.
        * Scripts/test262/Runner.pm:
        (processCLI):
        (getBuildPath):

2018-06-14  Leo Balter  <leonardo.balter@gmail.com>

        Test262-Runner: Add more information in the summarized stats
        https://bugs.webkit.org/show_bug.cgi?id=185749

        Reviewed by Michael Saboff.

        This patch adds extra information in the summarized stats for the given results for each run.
        This includes a total of files, a total of executed files and a time information per path and feature.
        * Scripts/test262/Runner.pm:
        (summarizeResults):

2018-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [GTK] Enable tests on the GTK EWS queue
        https://bugs.webkit.org/show_bug.cgi?id=186559

        Reviewed by Michael Catanzaro.

        Enable testing for the gtk-wk2 EWS queue.

        * Scripts/webkitpy/common/config/ews.json:

2018-06-14  Valerie R Young  <valerie@bocoup.com>

        [test262-runner] Test output should summarize tests that are
        unexpectedly passing/failing.
        https://bugs.webkit.org/show_bug.cgi?id=186527

        Reviewed by Michael Saboff.

        * Scripts/test262/Runner.pm:
        (main):
          In verbose mode, a summary of all new failing tests
          and all new passing tests are printed at the end of
          the script output.

2018-06-14  Zan Dobersek  <zdobersek@igalia.com>

        [GTK][WPE] MiniBrowsers should be able to ignore TLS errors
        https://bugs.webkit.org/show_bug.cgi?id=186557

        Reviewed by Carlos Garcia Campos.

        Add the --ignore-tls-errors flags to the GTK and WPE MiniBrowsers.
        Enabling the flag enforces ignoring of TLS errors that occur during
        load. This is primarily useful for loading test cases from the wpt or
        run-webkit-httpd servers where testing-purpose certificates are used.

        * MiniBrowser/gtk/main.c:
        (main):
        * MiniBrowser/wpe/main.cpp:
        (main):

2018-06-13  Adrian Perez de Castro  <aperez@igalia.com>

        [WPE] Trying to access the remote inspector hits an assertion in the UIProcess
        https://bugs.webkit.org/show_bug.cgi?id=186588

        Reviewed by Carlos Garcia Campos.

        Make both the WPE and GTK+ ports use /org/webkit/inspector as base prefix
        for resource paths, which avoids needing a switcheroo depending on the port.

        * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
        (WTR::TestRunner::inspectorTestStubURL):
        * glib/generate-inspector-gresource-manifest.py:

2018-06-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [GTK] Add a script to upload the data generated with run-benchmark to a browserperfdash server and use it on the gtk perf bot
        https://bugs.webkit.org/show_bug.cgi?id=166885

        Reviewed by Michael Catanzaro.

        This patch adds a new script that will execute run-benchmark and upload the results it generates to a browserperfdash web app.

        It also modifies the buildbot config file so the GTK performance bot runs this script on the perf-test step.

        * BuildSlaveSupport/build.webkit.org-config/steps.py:
        (RunBenchmarkTests):
        * Scripts/browserperfdash-benchmark: Added.
        * Scripts/webkitpy/browserperfdash/README: Added.
        * Scripts/webkitpy/browserperfdash/__init__.py: Added.
        * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py: Added.
        (parse_args):
        (BrowserPerfDashRunner):
        (BrowserPerfDashRunner.__init__):
        (BrowserPerfDashRunner._parse_config_file):
        (BrowserPerfDashRunner._get_test_version_string):
        (BrowserPerfDashRunner._get_test_data_json_string):
        (BrowserPerfDashRunner._upload_result):
        (BrowserPerfDashRunner.run):
        (format_logger):
        (main):
        * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py: Added.
        (FakeBenchmarkRunner):
        (FakeBenchmarkRunner.__init__):
        (FakeBenchmarkRunner.execute):
        (BrowserPerfDashRunnerTest):
        (BrowserPerfDashRunnerTest.test_list_plans_at_least_five):
        (BrowserPerfDashRunnerTest.test_benchmark_runner_subclasses_at_least_two):
        (BrowserPerfDashRunnerTest.test_can_construct_runner_object_minimum_parameters):
        * Scripts/webkitpy/browserperfdash/config-file-example.txt: Added.

2018-06-13  David Fenton  <david_fenton@apple.com>

        Unreviewed, add myself as a WebKit committer.

        * Scripts/webkitpy/common/config/contributors.json:

2018-06-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [JSCOnly] Add a MIPS32el JSCOnly EWS (follow-up fix)
        https://bugs.webkit.org/show_bug.cgi?id=186523

        Unreviewed follow-up fix after r232748

        * Scripts/webkitpy/common/config/ports.py:
        (JscOnlyPort.build_jsc_command): It is needed to pass a --jsc-only argument to the build-jsc script.
        * Scripts/webkitpy/common/config/ports_unittest.py:
        (DeprecatedPortTest.test_jsconly_port):

2018-06-12  Thibault Saunier  <tsaunier@igalia.com>

        webkitpy: Implement coredumpctl support on linux
        https://bugs.webkit.org/show_bug.cgi?id=184039

        Reviewed by Daniel Bates.

        And start using an Executive to run subprocesses
        in GDBCrashLogGenerator.

        Unit tests adapted to the new API and still passing.

        * Scripts/webkitpy/port/linux_get_crash_log.py:
        (GDBCrashLogGenerator):
        (GDBCrashLogGenerator._get_trace_from_systemd):
        (GDBCrashLogGenerator.generate_crash_log):

2018-06-12  Valerie R Young  <valerie@bocoup.com>

        test262/Runner.pm: fix one test (can't find jsc)
        https://bugs.webkit.org/show_bug.cgi?id=186573

        Reviewed by Michael Saboff.

        * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:
        fix subtest to use mock JSC

2018-06-12  Tim Horton  <timothy_horton@apple.com>

        Add a API test for r232601
        https://bugs.webkit.org/show_bug.cgi?id=186417

        Reviewed by Wenson Hsieh.

        * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
        (immediateSubviewOfClass):
        (TEST):
        Ensure that we put the view hierarchy back together (move WKContentView
        out of the animated resize view) and unhide WKContentView after a
        resize-with-hidden-content.

2018-06-12  Valerie R Young  <valerie@bocoup.com>

        test262/Runner.pm: add unit tests
        https://bugs.webkit.org/show_bug.cgi?id=185783

        Reviewed by Michael Saboff.

        * Scripts/webkitperl/test262_unittest/README: Added.
        * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
        * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
        * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-fail-new-error.pl: Added.
        * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-fail.pl: Added.
        * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-pass.pl: Added.
        * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
        * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
        * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.
        (f):
        * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
        * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
        * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.
        (f):
        * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.

2018-06-12  Valerie R Young  <valerie@bocoup.com>

        test262/Runner.pm: minor updates
        https://bugs.webkit.org/show_bug.cgi?id=186399

        - If harness files cannot be found in a CLI supplied
        test262 path, then default to webkit's test262 harness files.
        - Lazily create the test262-results directory (only right before
        writing to it)
       - If an expectation file is supplied via the CLI, save to the
        supplied location instead of the default webkit location
        (JSTest/test262/expectation.yaml).

        Reviewed by Michael Saboff.

        * Scripts/test262/Runner.pm:
        (processCLI):
        (main):
        (compileTest):
        (processResult):
        (getHarness):
        (summarizeResults):

2018-06-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [JSCOnly] Add a MIPS32el JSCOnly EWS
        https://bugs.webkit.org/show_bug.cgi?id=186523

        Reviewed by Michael Catanzaro.

        Add a new jsc-mips-ews queue that will execute build-jsc for the jsc-only (Linux) port.
        The worker(s) on this queue should be pre-configured to cross-build JSC for MIPS32el.

        * QueueStatusServer/config/queues.py:
        * QueueStatusServer/model/queues.py:
        (Queue.display_name):
        * Scripts/webkitpy/common/config/ews.json:
        * Scripts/webkitpy/common/config/ports.py:
        (DeprecatedPort.port):
        (WpePort.run_webkit_tests_command):
        (JscOnlyPort):
        (JscOnlyPort.build_jsc_command):
        * Scripts/webkitpy/common/config/ports_unittest.py:
        (DeprecatedPortTest.test_wincairo_port):
        (DeprecatedPortTest):
        (DeprecatedPortTest.test_jsconly_port):
        * Scripts/webkitpy/port/factory.py:
        (PortFactory):
        * Scripts/webkitpy/port/jsc_only.py: Added. Add a basic port definition. Required by the EWS tooling.
        (JscOnlyPort):
        (JscOnlyPort.__init__):
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        (test_ews_name):

2018-06-12  Zan Dobersek  <zdobersek@igalia.com>

        Add run-web-platform-tests script
        https://bugs.webkit.org/show_bug.cgi?id=183356

        Reviewed by Carlos Alberto Lopez Perez.

        Add the run-web-platform-tests script that allows running WebKit builds
        against the external web-platform-tests project.

        The script sets up all the port-specific information, including the
        display driver. If no web-platform-tests repository location is
        specified, the TestDownloader utility is used to clone the repository,
        and path to that clone is leveraged instead.

        Port-specific TestManifest.ini and TestExpectations.json file paths are
        then constructed, bailing if any of the files is missing. The JSON file
        is then used to construct the metadata file tree, creating an .ini file
        for each test that is disabled, has a certain expectation, or has
        subtests that themselves have certain expectations. This metadata tree
        is built under the build directory, and is purged and reconstructed for
        each separate run.

        Lastly, the WPT python module is imported from the web-platform-tests
        source location, and wpt.main() is invoked along with all the necessary
        arguments that set up a web-platform-tests suite run using the WebKit
        product.

        * Scripts/run-web-platform-tests: Added.
        * Scripts/webkitpy/common/config/ports_mock.py:
        (MockPort.run_bindings_tests_command):
        (MockPort):
        (MockPort.wpt_metadata_directory):
        (MockPort.wpt_manifest_file):
        * Scripts/webkitpy/port/base.py:
        (Port.wpt_metadata_directory):
        (Port):
        (Port.wpt_manifest_file):
        * Scripts/webkitpy/w3c/common.py:
        (is_file_exportable):
        (WPTPaths):
        (WPTPaths.checkout_directory):
        (WPTPaths.wpt_checkout_path):
        * Scripts/webkitpy/w3c/test_downloader.py:
        (TestDownloader.clone_tests):
        (TestDownloader):
        (TestDownloader.download_tests):
        * Scripts/webkitpy/w3c/test_exporter.py:
        (WebPlatformTestExporter.__init__):
        * Scripts/webkitpy/w3c/wpt_runner.py: Added.
        (main):
        (parse_args):
        (create_webdriver):
        (spawn_wpt):
        (WPTRunner):
        (WPTRunner.__init__):
        (WPTRunner._prepare_wpt_checkout):
        (WPTRunner._generate_metadata_directory):
        (WPTRunner.run):
        * Scripts/webkitpy/w3c/wpt_runner_unittest.py: Added.
        (WPTRunnerTest):
        (WPTRunnerTest.MockTestDownloader):
        (WPTRunnerTest.MockTestDownloader.default_options):
        (WPTRunnerTest.MockTestDownloader.__init__):
        (WPTRunnerTest.MockTestDownloader.clone_tests):
        (WPTRunnerTest.MockWebDriver):
        (WPTRunnerTest.MockWebDriver.create):
        (WPTRunnerTest.MockWebDriver.binary_path):
        (WPTRunnerTest.MockWebDriver.browser_path):
        (WPTRunnerTest.MockWebDriver.browser_args):
        (WPTRunnerTest.MockSpawnWPT):
        (WPTRunnerTest.MockSpawnWPT.__init__):
        (WPTRunnerTest.MockSpawnWPT.__call__):
        (WPTRunnerTest.TestInstance):
        (WPTRunnerTest.TestInstance.__init__):
        (WPTRunnerTest.TestInstance.prepare_mock_files_for_run):
        (WPTRunnerTest.test_prepare_wpt_checkout):
        (WPTRunnerTest.test_prepare_wpt_checkout_specified_path):
        (WPTRunnerTest.test_generate_metadata_directory):
        (WPTRunnerTest.test_run):
        (WPTRunnerTest.test_run_with_specified_options):
        (WPTRunnerTest.test_run_with_args):

2018-06-11  Mark Lam  <mark.lam@apple.com>

        Add support for webkit-test-runner jscOptions in DumpRenderTree and WebKitTestRunner.
        https://bugs.webkit.org/show_bug.cgi?id=186451
        <rdar://problem/40875792>

        Reviewed by Tim Horton.

        This jscOptions option can be used by a layout test to specify some JSC runtime
        options needed by the test e.g. by adding something like this to the top of the
        html file after the DOCTYPE tag:
            <!-- webkit-test-runner [ jscOptions=--useIntlPluralRules=true ] -->

        If more than one option is needed, the options can be specified as a comma
        separated string e.g.
            <!-- webkit-test-runner [ jscOptions=--useIntlPluralRules=true,--useZombieMode=true ] -->

        This only works with JSC options that can be changed at runtime.  Not all JSC
        options can be changed this way as some options are only checked and set once at
        VM / process initialization time: changing this type of options may have no
        effect.  It's the test writer's responsibility to determine which options are
        appropriate for with this webkit-test-runner jscOptions option.

        This implementation is a workaround until we can change the run-webkit-tests
        scripts to parse the option and apply it to a new launch of DRT or WKTR:
        https://bugs.webkit.org/show_bug.cgi?id=186452

        * DumpRenderTree/TestOptions.cpp:
        (TestOptions::TestOptions):
        (TestOptions::webViewIsCompatibleWithOptions const):
        * DumpRenderTree/TestOptions.h:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (setJSCOptions):
        (resetWebViewToConsistentStateBeforeTesting):
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::didReceiveMessageToPage):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetStateToConsistentValues):
        (WTR::updateTestOptionsFromTestHeader):
        * WebKitTestRunner/TestOptions.h:
        (WTR::TestOptions::hasSameInitializationOptions const):

2018-06-11  Brady Eidson  <beidson@apple.com>

        Add a command line default to force WebKitTestRunner to turn on process swap on navigation.
        https://bugs.webkit.org/show_bug.cgi?id=186534

        Reviewed by Chris Dumez.

        Right now Process Swap On Navigation is enabled on a per-test basis.
        The future is to enable it by default.

        Adding a 'defaults write' helps us get to that future.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::testOptionsForTest const):
        (WTR::TestController::platformAddTestOptions const):
        * WebKitTestRunner/TestController.h:
        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
        (WTR::TestController::platformAddTestOptions const):

2018-06-11  Chris Dumez  <cdumez@apple.com>

        Allow enabling PSON in layout tests without window.open support
        https://bugs.webkit.org/show_bug.cgi?id=186537

        Reviewed by Geoffrey Garen.

        Allow enabling PSON in layout tests without window.open support since window.open support
        is far from being ready and we plan to enable PSON in layout tests soon.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::createWebViewWithOptions):
        (WTR::updateTestOptionsFromTestHeader):
        * WebKitTestRunner/TestOptions.h:
        (WTR::TestOptions::hasSameInitializationOptions const):

2018-06-11  Brady Eidson  <beidson@apple.com>

        Followup to [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
        https://bugs.webkit.org/show_bug.cgi?id=186436

        Patch by Darin Adler
        Reviewed by Brady Eidson.

        * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm:
        (TestWebKitAPI::TEST):

2018-06-11  Mark Lam  <mark.lam@apple.com>

        Gardening: skip BigInt tests on iOS until the feature is stable.
        <rdar://problem/40331121>

        Not reviewed.

        * Scripts/run-jsc-stress-tests:

2018-06-11  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] Add WebKitBrowserWindow class for modern WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=186478

        Reviewed by Alex Christensen.

        Added "New WebKit Window" and "New WebKitLegacy Window" menu
        items. Disabled the menu item "New WebKit Window" if
        !ENABLE(WEBKIT).

        * MiniBrowser/win/CMakeLists.txt: Added WebKitBrowserWindow.cpp
        source file and ENABLE_WEBKIT macro if ENABLE_WEBKIT.
        * MiniBrowser/win/MainWindow.cpp:
        (MainWindow::MainWindow):
        (MainWindow::create):
        (MainWindow::init):
        (MainWindow::WndProc):
        * MiniBrowser/win/MainWindow.h:
        * MiniBrowser/win/MiniBrowserLib.rc:
        * MiniBrowser/win/MiniBrowserLibResource.h:
        * MiniBrowser/win/PrintWebUIDelegate.cpp:
        (PrintWebUIDelegate::createWebViewWithRequest):
        * MiniBrowser/win/WebKitBrowserWindow.cpp: Added.
        (createString):
        (toUtf8):
        (createWKString):
        (createWKURL):
        (WebKitBrowserWindow::create):
        (WebKitBrowserWindow::WebKitBrowserWindow):
        (WebKitBrowserWindow::init):
        (WebKitBrowserWindow::hwnd):
        (WebKitBrowserWindow::loadURL):
        (WebKitBrowserWindow::loadHTMLString):
        (WebKitBrowserWindow::navigateForwardOrBackward):
        (WebKitBrowserWindow::navigateToHistory):
        (WebKitBrowserWindow::setPreference):
        (WebKitBrowserWindow::print):
        (WebKitBrowserWindow::launchInspector):
        (WebKitBrowserWindow::setUserAgent):
        (WebKitBrowserWindow::userAgent):
        (WebKitBrowserWindow::showLayerTree):
        (WebKitBrowserWindow::updateStatistics):
        (WebKitBrowserWindow::resetZoom):
        (WebKitBrowserWindow::zoomIn):
        (WebKitBrowserWindow::zoomOut):
        (toWebKitBrowserWindow):
        (WebKitBrowserWindow::didReceiveTitleForFrame):
        (WebKitBrowserWindow::didCommitLoadForFrame):
        * MiniBrowser/win/WebKitBrowserWindow.h:
        * MiniBrowser/win/WinMain.cpp:
        (wWinMain):

2018-06-11  Keith Miller  <keith_miller@apple.com>

        Add missing whitespace to run-jsc command
        https://bugs.webkit.org/show_bug.cgi?id=186528

        Reviewed by Mark Lam.

        * Scripts/run-jsc:

2018-06-11  Philippe Normand  <pnormand@igalia.com>

        [webkitpy] PHP7.2 support on Debian platforms
        https://bugs.webkit.org/show_bug.cgi?id=186521

        Reviewed by Michael Catanzaro.

        * Scripts/webkitpy/port/base.py:
        (Port._debian_php_version): Refactor and add PHP 7.2 version support.

2018-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WPE API and layout tests after r232670.

        Now that dyz is not installed, there's not -default.so symlink for the WPE backend, so we need to use
        WPE_BACKEND_LIBRARY environment variable to ensure tests are run with fdo backend.

        * Scripts/run-wpe-tests:
        (WPETestRunner.__init__):
        (WPETestRunner):
        (WPETestRunner.setup_testing_environment):
        * Scripts/webkitpy/port/wpe.py:
        (WPEPort.setup_environ_for_server):
        * glib/api_test_runner.py:
        (TestRunner.setup_testing_environment):
        (TestRunner.run_tests):
        (TestRunner._setup_testing_environment): Deleted.

2018-06-10  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK][WPE] Add API run run javascript from a WebKitWebView in an isolated world
        https://bugs.webkit.org/show_bug.cgi?id=186192

        Reviewed by Michael Catanzaro.

        Add tests cases for the new API.

        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
        (testWebViewRunJavaScript):
        * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
        (methodCallCallback):
        (webkit_web_extension_initialize_with_user_data):
        * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
        (runJavaScriptInWorldReadyCallback):
        (WebViewTest::runJavaScriptFromGResourceAndWaitUntilFinished):
        (WebViewTest::runJavaScriptInWorldAndWaitUntilFinished):
        * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:

2018-06-10  Carlos Garcia Campos  <cgarcia@igalia.com>

        [WPE] Add a MiniBrowser and use it to run WebDriver tests
        https://bugs.webkit.org/show_bug.cgi?id=186345

        Reviewed by Žan Doberšek.

        Most of the code is based on dyz and gtk MiniBrowser. This patch adds a new internal library WPEToolingBackends,
        including the headless view backend and a new window backend to be used by the MiniBrowser. MiniBrowser can also
        run in headless mode, by using the headless backend instead of the window one, which will allow us to run the
        WebDriver tests in the bots.

        * CMakeLists.txt:
        * MiniBrowser/wpe/CMakeLists.txt: Added.
        * MiniBrowser/wpe/main.cpp: Added.
        (automationStartedCallback):
        (createViewBackend):
        (main):
        * Scripts/run-minibrowser: Remove WPE specific code.
        * Scripts/run-webdriver-tests: Add headless display-server option.
        * Scripts/webkitdirs.pm:
        (launcherName): Remove WPE specific code.
        * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py:
        (WebDriverWPE.browser_name): Return MiniBrowser.
        (WebDriverWPE.browser_path): Return the path to the MiniBrowser in build dir.
        (WebDriverWPE.browser_args): Add --headless when running in headless mode.
        (WebDriverWPE.capabilities): Use the full browser path.
        * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
        (WebDriverTestRunnerSelenium.collect_tests): Fix early return value.
        * TestWebKitAPI/PlatformWPE.cmake: Use WPEToolingBackends instead of HeadlessViewBackend.
        * TestWebKitAPI/PlatformWebView.h: Ditto.
        * TestWebKitAPI/glib/PlatformWPE.cmake: Ditto
        * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
        (Test::createWebViewBackend): Ditto.
        * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
        (TestWebKitAPI::PlatformWebView::initialize): Ditto.
        * WebKitTestRunner/PlatformWPE.cmake: Ditto.
        * WebKitTestRunner/PlatformWebView.h: Ditto.
        * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
        (WTR::PlatformWebView::PlatformWebView): Ditto.
        * wpe/HeadlessViewBackend/CMakeLists.txt: Removed.
        * wpe/backends/CMakeLists.txt: Added.
        * wpe/backends/HeadlessViewBackend.cpp: Renamed from Tools/wpe/HeadlessViewBackend/HeadlessViewBackend.cpp.
        (WPEToolingBackends::getEGLDisplay):
        (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
        (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
        (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
        (WPEToolingBackends::HeadlessViewBackend::performUpdate):
        (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
        * wpe/backends/HeadlessViewBackend.h: Renamed from Tools/wpe/HeadlessViewBackend/HeadlessViewBackend.h.
        * wpe/backends/ViewBackend.cpp: Added.
        (WPEToolingBackends::ViewBackend::ViewBackend):
        (WPEToolingBackends::ViewBackend::~ViewBackend):
        (WPEToolingBackends::ViewBackend::initialize):
        (WPEToolingBackends::ViewBackend::setInputClient):
        (WPEToolingBackends::ViewBackend::backend const):
        (WPEToolingBackends::ViewBackend::dispatchInputPointerEvent):
        (WPEToolingBackends::ViewBackend::dispatchInputAxisEvent):
        (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent):
        * wpe/backends/ViewBackend.h: Added.
        * wpe/backends/WindowViewBackend.cpp: Added.
        (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
        (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
        (WPEToolingBackends::WindowViewBackend::displayBuffer):
        (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
        * wpe/backends/WindowViewBackend.h: Added.
        * wpe/jhbuild.modules: Remove dyz and add wayland-protocols.

2018-06-10  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] MiniBrowser class should be renamed to WebKitLegacyBrowserWindow
        https://bugs.webkit.org/show_bug.cgi?id=186427

        Reviewed by Ryosuke Niwa.

        * MiniBrowser/win/AccessibilityDelegate.cpp:
        * MiniBrowser/win/AccessibilityDelegate.h:
        (AccessibilityDelegate::AccessibilityDelegate):
        * MiniBrowser/win/CMakeLists.txt: Removed MiniBrowser.cpp. Added WebKitLegacyBrowserWindow.cpp.
        * MiniBrowser/win/Common.h:
        * MiniBrowser/win/MainWindow.cpp:
        (MainWindow::init):
        * MiniBrowser/win/MainWindow.h:
        * MiniBrowser/win/MiniBrowserWebHost.cpp:
        * MiniBrowser/win/MiniBrowserWebHost.h:
        (MiniBrowserWebHost::MiniBrowserWebHost):
        * MiniBrowser/win/PageLoadTestClient.cpp:
        (PageLoadTestClient::PageLoadTestClient):
        * MiniBrowser/win/PageLoadTestClient.h:
        * MiniBrowser/win/PrintWebUIDelegate.cpp:
        (PrintWebUIDelegate::createWebViewWithRequest):
        * MiniBrowser/win/PrintWebUIDelegate.h:
        (PrintWebUIDelegate::PrintWebUIDelegate):
        * MiniBrowser/win/ResourceLoadDelegate.cpp:
        * MiniBrowser/win/ResourceLoadDelegate.h:
        (ResourceLoadDelegate::ResourceLoadDelegate):
        * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp: Renamed from Tools/MiniBrowser/win/MiniBrowser.cpp.
        * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Renamed from Tools/MiniBrowser/win/MiniBrowser.h.
        * MiniBrowser/win/WebDownloadDelegate.cpp:
        (WebDownloadDelegate::WebDownloadDelegate):
        * MiniBrowser/win/WebDownloadDelegate.h:

2018-06-10  Chris Dumez  <cdumez@apple.com>

        Reload the Web view in case of crash if the client does not implement webViewWebContentProcessDidTerminate delegate
        https://bugs.webkit.org/show_bug.cgi?id=186468

        Reviewed by Geoffrey Garen.

        Add API test coverage.

        * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
        (-[BasicNavigationDelegateWithoutCrashHandler webView:didStartProvisionalNavigation:]):
        (-[BasicNavigationDelegateWithoutCrashHandler webView:didFinishNavigation:]):
        (TEST):

2018-06-10  Michael Catanzaro  <mcatanzaro@igalia.com>

        [WPE][GTK] paypal.com requires user agent quirk
        https://bugs.webkit.org/show_bug.cgi?id=186466

        Reviewed by Carlos Garcia Campos.

        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
        (TestWebKitAPI::TEST):

2018-06-09  Dan Bernstein  <mitz@apple.com>

        [Xcode] Clean up and modernize some build setting definitions
        https://bugs.webkit.org/show_bug.cgi?id=186463

        Reviewed by Sam Weinig.

        * DumpRenderTree/mac/Configurations/Base.xcconfig: Removed definition for macOS 10.11.
          Simplified the definition of WK_PRIVATE_FRAMEWORK_STUBS_DIR now that
          WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
        * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Removed definition for macOS
          10.11.
        * MiniBrowser/Configurations/Base.xcconfig: Ditto.
        * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
        * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
        * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Simplified the definitions of
          ENABLE_APPLE_PAY and ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest
          supported version.
        * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for
          macOS 10.11.
        * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also simplified the definition of
          WK_PRIVATE_FRAMEWORK_STUBS_DIR now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all
          supported Xcode versions
        * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Removed definition for macOS 10.11.

2018-06-09  Dan Bernstein  <mitz@apple.com>

        Added missing file references to the Configuration group.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

2018-06-08  Darin Adler  <darin@apple.com>

        [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
        https://bugs.webkit.org/show_bug.cgi?id=186436

        Reviewed by Anders Carlsson.

        * TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsTest.mm:
        (TestWebKitAPI::WebKit2CustomProtocolsTest_ProcessPoolDestroyedDuringLoading):
        Use @autoreleasepool.
        * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
        (TestWebKitAPI::buildAndPerformTest): Ditto.
        * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm:
        (TestWebKitAPI::WebKitLegacy_StopLoadingFromDidFinishLoading): Ditto.

2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>

        [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
        https://bugs.webkit.org/show_bug.cgi?id=186442
        <rdar://problem/40879364>

        Reviewed by Tim Horton.

        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

2018-06-08  Alicia Boya García  <aboya@igalia.com>

        [GTK] Update to libva-2.1.0 in jhbuild
        https://bugs.webkit.org/show_bug.cgi?id=186434

        Reviewed by Philippe Normand.

        * gstreamer/jhbuild.modules:

2018-06-07  Yusuke Suzuki  <utatane.tea@gmail.com>

        [WTF] Add WorkerPool
        https://bugs.webkit.org/show_bug.cgi?id=174569

        Reviewed by Carlos Garcia Campos.

        * TestWebKitAPI/CMakeLists.txt:
        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WTF/WorkerPool.cpp: Added.
        (TestWebKitAPI::TEST):

2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and WK2 BrowserWindow
        https://bugs.webkit.org/show_bug.cgi?id=186421

        Reviewed by Ryosuke Niwa.

        This is the core patch to make MiniBrowser to support WK1 and WK2
        windows (Bug 184770).

        I will rename MiniBrowser class to WK1BrowserWindow in a follow-up
        patch (Bug 184770 Comment 12).

        * MiniBrowser/win/BrowserWindow.h: Added.
        * MiniBrowser/win/MainWindow.cpp:
        (MainWindow::WndProc):
        * MiniBrowser/win/MainWindow.h:
        (MainWindow::browserWindow const):
        * MiniBrowser/win/MiniBrowser.cpp:
        (MiniBrowser::create):
        (MiniBrowser::navigateForwardOrBackward): Removed the unsed first argument hWnd.
        (MiniBrowser::navigateToHistory): Ditto.
        * MiniBrowser/win/MiniBrowser.h: Inherit BrowserWindow interface.
        Make all other methods private and make delegates classes friends.
        * MiniBrowser/win/PrintWebUIDelegate.cpp:
        (PrintWebUIDelegate::createWebViewWithRequest):

2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] MiniBrowser::updateDeviceScaleFactor should be a MainWindow's method
        https://bugs.webkit.org/show_bug.cgi?id=186387

        Reviewed by Ryosuke Niwa.

        MiniBrowser::updateDeviceScaleFactor does nothing for MiniBrowser.
        It should be a MainWindow's method.

        * MiniBrowser/win/MainWindow.cpp:
        (MainWindow::init): Call MainWindow::updateDeviceScaleFactor.
        (MainWindow::resizeSubViews): Do not set a font every time window size is changed.
        (MainWindow::WndProc): Call MainWindow::updateDeviceScaleFactor on WM_DPICHANGED.
        (MainWindow::updateDeviceScaleFactor): Converted from
        MiniBrowser::updateDeviceScaleFactor and
        MiniBrowser::generateFontForScaleFactor. Set a URL bar's font if DPI is changed.
        * MiniBrowser/win/MainWindow.h:
        * MiniBrowser/win/MiniBrowser.cpp:
        (MiniBrowser::init):
        (MiniBrowser::generateFontForScaleFactor): Deleted.
        (MiniBrowser::updateDeviceScaleFactor): Deleted.
        * MiniBrowser/win/MiniBrowser.h:
        (MiniBrowser::deviceScaleFactor): Deleted.
        (MiniBrowser::urlBarFont): Deleted.

2018-06-07  Jonathan Bedard  <jbedard@apple.com>

        [webkitpy] Treat svn versions as Version objects
        https://bugs.webkit.org/show_bug.cgi?id=186403
        <rdar://problem/40904860>

        Reviewed by Dan Bernstein.

        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
        * Scripts/webkitpy/common/checkout/scm/svn.py:
        (SVN.svn_version): Return Version object instead of string.
        (SVN._status_regexp): Convert version string to Version object.
        (SVN.add_list): Ditto.

2018-06-07  Tadeu Zagallo  <tzagallo@apple.com>

        Don't try to allocate JIT memory if we don't have the JIT entitlement
        https://bugs.webkit.org/show_bug.cgi?id=182605
        <rdar://problem/38271229>

        Reviewed by Mark Lam.

        Add the Security framework to the TestWTF target, since it's required by the new function to check the entitlements.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

2018-06-07  Mark Lam  <mark.lam@apple.com>

        Enhance run-jsc-stress-tests to allow a test to specify test specific options required for it to run.
        https://bugs.webkit.org/show_bug.cgi?id=186409
        <rdar://problem/40909007>

        Reviewed by Saam Barati.

        This is needed because some tests are written with specific features in mind, and
        we may not necessarily want to enable that option for all tests.

        We can now specify something like this at the top of a test file:
            //@ requireOptions("--useIntlPluralRules=true")

        ... and ensure that that test will be run with the --useIntlPluralRules=true
        option for all test configurations that run the test.

        * Scripts/run-jsc-stress-tests:

2018-06-07  Tim Horton  <timothy_horton@apple.com>

        REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing
        https://bugs.webkit.org/show_bug.cgi?id=186395
        <rdar://problem/40902427>

        Reviewed by Wenson Hsieh.

        * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
        (TEST):
        endAnimatedResize no longer synchronizes, so we have to wait for the next presentation update.

2018-06-07  Thibault Saunier  <tsaunier@igalia.com>

        [GTK][WPE] Start implementing MediaStream API
        https://bugs.webkit.org/show_bug.cgi?id=185787

        Reviewed by Philippe Normand.

        * Scripts/webkitpy/style/checker.py: Apply special formatting rules for new GObject subclasses.
        * gstreamer/jhbuild.modules: Added a patch for the gst-plugins-base.
        * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch:
        Added this fix to gst-plugings-base to fix the decodebin3. Merged as 89d0e9cc92a86aa0227ee87406737b6d31670aea

2018-06-07  Brendan McLoughlin  <brendan@bocoup.com>

        Update web-platform-tests github location in webkitpy.w3c.test_importer
        https://bugs.webkit.org/show_bug.cgi?id=186392

        Reviewed by Youenn Fablet.

        * Scripts/webkitpy/w3c/test_importer.py:
        (TestImporter.write_import_log):

2018-06-07  Jonathan Bedard  <jbedard@apple.com>

        webkitperl: Generalize .internal SDK suffix
        https://bugs.webkit.org/show_bug.cgi?id=186352
        <rdar://problem/40853947>

        Reviewed by Alexey Proskuryakov.

        * Scripts/build-webkit:
        * Scripts/package-root:
        (usage):
        * Scripts/webkitdirs.pm:
        (parseAvailableXcodeSDKS): Parse 'xcodebuild -showsdks' output.
        (availableXcodeSDKS): Generate a list of all available Xcode SDKs on this machine.
        (determineXcodeSDK): Always prefer .internal SDKs if available.
        * Scripts/webkitperl/webkitdirs_unittest/availableXcodeSDKS.pl:

2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] Support multiple windows properly
        https://bugs.webkit.org/show_bug.cgi?id=186263

        Reviewed by Ryosuke Niwa.

        The current implementation of
        PrintWebUIDelegate::createWebViewWithRequest is wrong. It is using
        CreateProcess to open a new window, and doesn't return the new
        instance of IWebView. As the result, for example, window.close
        doesn't work as expected.

        In this change, a new MainWindow is created and return the
        IWebView in PrintWebUIDelegate::createWebViewWithRequest.

        In addition to it, this change unifies the lifetime of MiniBrowser
        and its delegates AccessibilityDelegate, PrintWebUIDelegate,
        ResourceLoadDelegate and WebDownloadDelegate in order to keep
        MiniBrowser alive as long as the delegates live. Because the
        window of webview keeps references of such delegates and accesses
        those after MiniBrowser destruction.

        * MiniBrowser/win/MainWindow.h: Added s_numInstances class member
        to count the number of instance to close the application. Do not
        use unique_ptr for m_browserWindow because it has ref count now.
        * MiniBrowser/win/MainWindow.cpp:
        (MainWindow::MainWindow): Increment s_numInstances.
        (MainWindow::~MainWindow): Decrement s_numInstances.
        (MainWindow::create):
        (MainWindow::init):
        (MainWindow::WndProc): Rename thiz to thisWindow. Keep this
        instance alive during this function by using RefPtr<MainWindow>.
        Deref the MainWindow instance on WM_DESTROY. Quit the application
        when the last MainWindow is closed.
        (MainWindow::cachesDialogProc): Rename thiz to thisWindow.
        (MainWindow::customUserAgentDialogProc): Ditto.
        * MiniBrowser/win/MiniBrowser.h: Added declarations AddRef and Release.
        * MiniBrowser/win/MiniBrowser.cpp:
        (MiniBrowser::create):
        (MiniBrowser::AddRef):
        (MiniBrowser::Release):
        (MiniBrowser::init): Passes this to the constructors of delegates.
        * MiniBrowser/win/AccessibilityDelegate.cpp:
        (AccessibilityDelegate::AddRef): Delegate to MiniBrowser.
        (AccessibilityDelegate::Release): Ditto.
        * MiniBrowser/win/AccessibilityDelegate.h: Removed m_refCount.
        (AccessibilityDelegate::AccessibilityDelegate):
        * MiniBrowser/win/MiniBrowserWebHost.cpp:
        (MiniBrowserWebHost::AddRef): Delegate to MiniBrowser.
        (MiniBrowserWebHost::Release): Ditto.
        * MiniBrowser/win/MiniBrowserWebHost.h: Removed m_refCount.
        * MiniBrowser/win/PrintWebUIDelegate.cpp:
        (PrintWebUIDelegate::createWebViewWithRequest): Create a new
        MainWindow and return the IWebView.
        (PrintWebUIDelegate::AddRef): Delegate to MiniBrowser.
        (PrintWebUIDelegate::Release): Ditto.
        * MiniBrowser/win/PrintWebUIDelegate.h: Removed m_refCount.
        (PrintWebUIDelegate::PrintWebUIDelegate):
        * MiniBrowser/win/ResourceLoadDelegate.cpp:
        (ResourceLoadDelegate::AddRef): Delegate to MiniBrowser.
        (ResourceLoadDelegate::Release): Ditto.
        * MiniBrowser/win/ResourceLoadDelegate.h: Removed m_refCount.
        * MiniBrowser/win/WebDownloadDelegate.cpp:
        (WebDownloadDelegate::WebDownloadDelegate):
        (WebDownloadDelegate::AddRef): Delegate to MiniBrowser.
        (WebDownloadDelegate::Release): Ditto.
        * MiniBrowser/win/WebDownloadDelegate.h: Removed m_refCount.

2018-06-06  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] Remove gMainWindow global variable
        https://bugs.webkit.org/show_bug.cgi?id=186378

        Reviewed by Ryosuke Niwa.

        I'm going to support multiple MainWindow in Bug 186263. It should
        not be assumed that MainWindow has only one instance. gMainWindow
        is used only in DisplayAuthDialog.

        * MiniBrowser/win/Common.cpp:
        (authDialogProc): Use DWLP_USER to store the dialog data.
        (displayAuthDialog): Moved and renamed from
        MainWindow::displayAuthDialog. Use DialogBoxParam instead of
        DialogBox to pass a data pointer. Do not return S_OK if
        DialogBoxParam returns -1. Take a HWND argument as the parent
        window.
        (DisplayAuthDialog): Deleted.
        * MiniBrowser/win/Common.h:
        * MiniBrowser/win/MainWindow.cpp:
        (authDialogProc): Moved to Common.cpp.
        (MainWindow::displayAuthDialog): Ditto.
        * MiniBrowser/win/MainWindow.h:
        * MiniBrowser/win/ResourceLoadDelegate.cpp:
        (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
        * MiniBrowser/win/WinMain.cpp:
        (wWinMain): Added a local variable mainWindow instead of using
        gMainWindow.

2018-06-06  Dan Bernstein  <mitz@apple.com>

        [Xcode] Opt out of the New Build System
        https://bugs.webkit.org/show_bug.cgi?id=186380

        Reviewed by Alexey Proskuryakov.

        * Scripts/webkitdirs.pm:
        (XcodeOptions): Have -UseNewBuildSystem=NO passed to xcodebuild.

2018-06-06  Antoine Quint  <graouts@apple.com>

        Rename color-filter to -apple-color-filter and do not expose it to Web content
        https://bugs.webkit.org/show_bug.cgi?id=186306
        <rdar://problem/39874167>

        Reviewed by Simon Fraser.

        Adding an option to turn support for the -apple-color-filter property on via an HTML comment.

        * DumpRenderTree/TestOptions.cpp:
        (TestOptions::TestOptions):
        * DumpRenderTree/TestOptions.h:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (setWebPreferencesForTestOptions):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetPreferencesToConsistentValues):
        (WTR::updateTestOptionsFromTestHeader):
        * WebKitTestRunner/TestOptions.h:
        (WTR::TestOptions::hasSameInitializationOptions const):
        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
        (WTR::TestController::platformCreateWebView):

2018-06-06  Brent Fulgham  <bfulgham@apple.com>

        Adjust compile and runtime flags to match shippable state of features (Part 2)
        https://bugs.webkit.org/show_bug.cgi?id=186319
        <rdar://problem/40352045>

        Unreviewed test fix.

        TestWebKitAPI was timing out because 'color' input types are no longer support. I also discovered that the
        ASSERT_STREQ macro returns on error, which causes tests to time out whenever a 'done = true' call (needed to
        end the test) is done after ASSERT_STREQ, which might fail and return early, preventing the flag from being
        set.

        * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm:
        (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]): Make testing of
        the 'color' input type conditional on the feature being part of the build.
        * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
        (-[AutoFillDelegate _webView:didClickAutoFillButtonWithUserInfo:]): Set the 'done=true' state before performing
        string equality assertions, since they do an early return and bypass the end state of the test.
        (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]): Ditto.
        (-[AutoFillAvailableDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
        (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.

2018-06-05  Chris Dumez  <cdumez@apple.com>

        Regression(r232082): Websites get loaded inside of Messages App chat transcript
        https://bugs.webkit.org/show_bug.cgi?id=186331
        <rdar://problem/40735446>

        Reviewed by Darin Adler.

        Add API test coverage.

        * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm:
        (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
        (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:didStartProvisionalLoadForFrame:]):
        (TestWebKitAPI::TEST):
        (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Deleted.
        (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]): Deleted.
        (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]): Deleted.

2018-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>

        DataInteractionTests ContentEditableToTextarea and ContentEditableToContentEditable are failing on recent iOS 12
        https://bugs.webkit.org/show_bug.cgi?id=186325
        <rdar://problem/40527850>

        Reviewed by Tim Horton.

        Tweak these API tests so that they're robust against changes to how NSAttributedStrings are serialized in item
        providers ("public.rtf" vs. "com.apple.flat-rtfd"). Across all versions of iOS, just verify that either rich
        text type is present in the list of dragged type identifiers, and that the rich text type is placed at a higher
        fidelity than plain text.

        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
        (checkRichTextTypePrecedesPlainTextType):
        (TestWebKitAPI::TEST):
        (checkTypeIdentifierPrecedesOtherTypeIdentifier): Deleted.

2018-06-05  Brent Fulgham  <bfulgham@apple.com>

        Adjust compile and runtime flags to match shippable state of features
        https://bugs.webkit.org/show_bug.cgi?id=186319
        <rdar://problem/40352045>

        Reviewed by Maciej Stachowiak, Jon Lee, and others.

        This patch revises the compile time and runtime state for various features to match their
        suitability for end-user releases.

        * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
        WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
        Cocoa builds.
        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
        or ENABLE_INPUT_TYPE_COLOR_POPOVER.

2018-06-05  Saam Barati  <sbarati@apple.com>

        run-testmem should have a dry run option and an option to parse the stdout of executing the dry run
        https://bugs.webkit.org/show_bug.cgi?id=186293

        Reviewed by Mark Lam.

        This makes it easier to execute run-testmem on a device that doesn't have ruby
        on it. run-testmem now has a --dry option that will output commands to execute
        in bash. To run on a device that doesn't have ruby, just put its output into
        a bash script, and copy the PerformanceTests/testmem directory onto that device,
        and execute the bash script. Running that bash script will give you raw output.
        Make a file with that output and pass it into run-testmem using the --parse option.
        run-testmem will parse the raw output and compute the benchmark score.

        * Scripts/run-testmem:

2018-06-05  Youenn Fablet  <youenn@apple.com>

        ServiceWorker registration should store any script fetched through importScripts
        https://bugs.webkit.org/show_bug.cgi?id=182444
        <rdar://problem/37164835>

        Reviewed by Chris Dumez.

        Add support to crash the storage process from Internals.

        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::terminateStorageProcess):
        * WebKitTestRunner/InjectedBundle/TestRunner.h:
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::terminateStorageProcess):
        * WebKitTestRunner/TestController.h:
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

2018-06-05  Brent Fulgham  <bfulgham@apple.com>

        Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
        https://bugs.webkit.org/show_bug.cgi?id=186286
        <rdar://problem/40782992>

        Reviewed by Dan Bernstein.

        Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
        to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
        change this flag when preparing for a production release.

        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to
        determine whether experimental features should be enabled, and use it to properly define
        the feature flag.

2018-06-05  Robin Morisset  <rmorisset@apple.com>

        Add a grammar (in antlr4 format) to the WSL spec.
        https://bugs.webkit.org/show_bug.cgi?id=186310

        Rubberstamped by Filip Pizlo

        It is just the raw rules, without much comments and no typesetting.
        Compiles to any of Java/JS/C++/etc.. with antlr4 (requires a JDK)

        It does not exactly match the parser of the current js implementation of WSL, it:
        - Accepts negative literals
        - Reserves keywords fallthrough/auto
        - Refuses '_' as a valid identifier
        - Accepts several capitalizations for Null/True/False
        - Accepts variable declarations at the top-level
        - Correctly parses ternary expressions
        - Forbids empty extension list for protocols
        - Does not allow a space between '[' and ']' in type suffixes
        - Correctly parses nested generics
        - Accepts a 'fallthrough;' statement (for switches)
        - Refuses chained relational operator (e.g. x < y < z)
        - Generally a completely different structure for parsing effectful expressions, although it probably accepts about the same language
        - Currently only accepts literals and identifiers as constexpr (while the js parser accepts way too much, including '(x += 42)')
        There are probably more differences that I missed. The js parser will probably have to be mostly rewritten to follow the spec more closely (and fix all the bugs).
        I will try to see if it can be automatically derived from the antlr4 grammar.

        * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Added.

2018-06-04  Frederic Wang  <fwang@igalia.com>

        import-w3c-tests should rely on <meta name="flags"> to detect CSS manual tests
        https://bugs.webkit.org/show_bug.cgi?id=186261

        Reviewed by Youenn Fablet.

        * Scripts/webkitpy/w3c/test_parser.py:
        (TestParser.is_wpt_manualtest): Add code to detect whether a file is a manual test
        from its <meta name="flags"> tags. This is based on SourceFile::content_is_css_manual from
        the WPT repository.
        * Scripts/webkitpy/w3c/test_parser_unittest.py: Add a test to verify whether files with
        <meta name="flags"> are manual or non-manual according to CSS WG rules.

2018-06-04  Dan Bernstein  <mitz@apple.com>

        Fixed building ImageDiff with the default build system in the Xcode 10 developer beta.

        * ImageDiff/cg/Configurations/Base.xcconfig: Use #include? to include
          HaveInternalSDK.xcconfig, since it may not be preent.

2018-06-04  Dan Bernstein  <mitz@apple.com>

        Fixed building TestWebKitAPI with a shared build directory with XCBuild, which is the
        default build system in the Xcode 10 developer beta.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Changed the reference to the
          built libWTF.a to be relative to the built products directory.

2018-06-04  Chris Dumez  <cdumez@apple.com>

        Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
        https://bugs.webkit.org/show_bug.cgi?id=186287
        <rdar://problem/40783352>

        Reviewed by Youenn Fablet.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (enableExperimentalFeatures):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (enableExperimentalFeatures):

2018-06-04  Daniel Bates  <dabates@apple.com>

        Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue()
        https://bugs.webkit.org/show_bug.cgi?id=186290

        Reviewed by Aakash Jain.

        Although the usefulness of the code in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() is
        questionable we should fix a typo when calling this mocked function with argument since.

        * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
        (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):

2018-06-04  Dan Bernstein  <mitz@apple.com>

        Fixed building with the macOS Mojave seed SDK.

        * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:

2018-06-04  Alexey Proskuryakov  <ap@apple.com>

        Add Mojave support to WebKit tools
        https://bugs.webkit.org/show_bug.cgi?id=186282

        Reviewed by Daniel Bates.

        Nightly build support will be added separately.

        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png: Added.
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
        Added dashboard support.

        * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
        * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
        Trigger the right build queues on check-in.

        * Scripts/webkitpy/common/version_name_map.py:
        * Scripts/webkitpy/common/version_name_map_unittest.py:
        The main version mapping class updated.

        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
        * Scripts/webkitpy/port/mac_unittest.py:
        Updated for more platforms in unit tests.

        * TestResultServer/static-dashboards/flakiness_dashboard.js:
        Added the new platform to flakiness dashboard.

2018-06-04  Wenson Hsieh  <wenson_hsieh@apple.com>

        [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag
        https://bugs.webkit.org/show_bug.cgi?id=186279

        Reviewed by Tim Horton.

        Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS).

        * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:

2018-06-03  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] Remove gMiniBrowser global variable
        https://bugs.webkit.org/show_bug.cgi?id=186134

        Reviewed by Brent Fulgham.

        It should not be assumed there is only one main window and one browser
        window to support multiple windows properly. gMainWindow and
        gMiniBrowser global variables should be removed. This change
        removes gMiniBrowser.

        * MiniBrowser/win/Common.cpp: Removed gMiniBrowser global variable.
        * MiniBrowser/win/Common.h: Ditto.
        * MiniBrowser/win/MainWindow.cpp:
        (MainWindow::init):
        (MainWindow::WndProc):
        (EditProc): Post WM_COMMAND if the enter key is pressed in URL bar.
        (MainWindow::cachesDialogProc): Renamed from Caches.
        (MainWindow::customUserAgentDialogProc): Renamed from CustomUserAgent.
        (MainWindow::onURLBarEnter): Extracted from EditProc.
        (BackButtonProc): Deleted.
        (ForwardButtonProc): Deleted.
        (Caches): Renamed to MainWindow::cachesDialogProc.
        (CustomUserAgent): Renamed to MainWindow::customUserAgentDialogProc.
        * MiniBrowser/win/MainWindow.h: Convert hCacheWnd global variable to a member variable of MainWindow.
        * MiniBrowser/win/MiniBrowserLibResource.h:
        * MiniBrowser/win/WinMain.cpp:
        (wWinMain):

2018-06-02  Darin Adler  <darin@apple.com>

        [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
        https://bugs.webkit.org/show_bug.cgi?id=186227

        Reviewed by Dan Bernstein.

        * DumpRenderTree/mac/AccessibilityCommonMac.mm:
        (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
        (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.

        * DumpRenderTree/mac/AccessibilityControllerMac.mm: Add a missing include.

        * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
        (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
        * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
        (AccessibilityTextMarker::isEqual): Ditto.
        (AccessibilityTextMarkerRange::isEqual): Ditto.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (-[DumpRenderTree _waitForWebThread]): Use @autoreleasepool instead of NSAutoreleasePool.
        (DumpRenderTreeMain): Ditto.
        (WebThreadLockAfterDelegateCallbacksHaveCompleted): Ditto.
        (runTest): Ditto.

        * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
        (copyFile): Use a std::pair to return both a URL and an error rather than using an
        out argument for the NSError.
        (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
        Updated for the above change.

        * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
        (-[DumpRenderTreeWindow _addToOpenWindows]): Add __bridge to a bridging typecast.
        (-[DumpRenderTreeWindow close]): Ditto.
        * DumpRenderTree/mac/LayoutTestHelper.m:
        (setDisplayColorProfile): Ditto.

        * DumpRenderTree/mac/PolicyDelegate.mm: Add a missing include.

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
        Add __bridge to a bridging typecast.
        * DumpRenderTree/mac/TestRunnerMac.mm:
        (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Ditto.
        (TestRunner::apiTestNewWindowDataLoadBaseURL): Use @autoreleasepool instead of NSAutoreleasePool.

        * DumpRenderTree/mac/TextInputControllerMac.m: Fix a comment.

        * DumpRenderTree/mac/UIScriptControllerMac.mm:
        (WTR::UIScriptController::replaceTextAtRange): Add __bridge to a bridging typecast.
        (WTR::UIScriptController::contentsOfUserInterfaceItem const): Ditto.
        (WTR::UIScriptController::overridePreference): Ditto.
        * DumpRenderTree/mac/WorkQueueItemMac.mm:
        (LoadItem::invoke const): Ditto.
        (LoadHTMLStringItem::invoke const): Ditto.
        (ScriptItem::invoke const): Ditto.

        * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
        (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
        (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.

        * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
        (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
        (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.

        * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
        (WTR::AccessibilityController::accessibleElementById): Add __bridge to a bridging typecast.
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
        (-[NSString createJSStringRef]): Ditto.
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm:
        (WTR::AccessibilityTextMarker::isEqual): Ditto.
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm:
        (WTR::AccessibilityTextMarkerRange::isEqual): Ditto.
        * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
        (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
        (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::textMarkerRangeLength): Ditto.
        (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
        (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
        (WTR::AccessibilityUIElement::stringForTextMarkerRange): Ditto.
        (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
        (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
        (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
        (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
        (WTR::createJSStringRef): Ditto.
        (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
        (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
        (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
        (WTR::AccessibilityUIElement::indexForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::isTextMarkerValid): Ditto.
        (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
        (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
        (WTR::initializeWebViewConfiguration): Ditto.
        (WTR::TestController::platformContext): Ditto.
        (WTR::TestController::platformPreferences): Ditto.
        (WTR::TestController::platformAdjustContext): Ditto.
        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (WTR::PlatformWebView::PlatformWebView): Ditto.
        * WebKitTestRunner/mac/TestControllerMac.mm:
        (WTR::TestController::initializeInjectedBundlePath): Ditto.
        (WTR::TestController::initializeTestPluginDirectory): Ditto.
        (WTR::TestController::platformConfigureViewForTest): Ditto.

        * WebKitTestRunner/mac/UIScriptControllerMac.mm:
        (WTR::nsString): Use CFBridgingRelease instead of autorelease.
        (WTR::UIScriptController::platformPlayBackEventStream): Add __bridge to a bridging
        typecast.

        * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Add a missing include.

        * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
        (-[LocalPasteboard setPropertyList:forType:]): Add _bridge to a bridging typecast.
        (-[LocalPasteboard setString:forType:]): Ditto.

        * WebKitTestRunner/mac/main.mm:
        (main): Use @autoreleasepool instead of NSAutoreleasePool.

2018-06-02  Keith Miller  <keith_miller@apple.com>

        run-jsc should pass the option to use dollar vm by default
        https://bugs.webkit.org/show_bug.cgi?id=186170

        Reviewed by Yusuke Suzuki.

        * Scripts/run-jsc:

2018-06-02  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r232421.
        https://bugs.webkit.org/show_bug.cgi?id=186240

        Breaks webkitpy tests (Requested by aakashjain on #webkit).

        Reverted changeset:

        "Add some tests for lldb_webkit.py"
        https://bugs.webkit.org/show_bug.cgi?id=183744
        https://trac.webkit.org/changeset/232421

2018-06-01  Daniel Bates  <dabates@apple.com>

        Add some tests for lldb_webkit.py
        https://bugs.webkit.org/show_bug.cgi?id=183744

        Reviewed by Alexey Proskuryakov.

        Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
        and WTF::String objects.

        The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
        program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
        on Mac.

        * Makefile: Build the simple test tool lldbWebKitTester on Mac.
        * Scripts/build-lldbwebkittester: Added.
        (buildProjectOrDie):
        * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
        from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
        this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
        the file and take advantage of Python's default error semantics to throw an exception
        if the import fails instead of handling it ourself. This has the side effect that we
        now always import the LLDB Python module even if this script is invoked with --help.
        If this turns out to be a significant annoyance then we can look to dynamically import
        the module as we did before this change.
        (webkit_build_dir):
        (main):
        (developer_dir): Deleted.
        (import_lldb): Deleted.
        * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
        that fact that test-webkitpy does not support class and module fixtures. This is because
        test-webkitpy currently implements parallelism by breaking down existing test classes
        into individual test methods itself and having each worker run exactly one test method (via
        unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
        setUpModule()/setUpClass() are called for each test method as opposed to once per test
        class/test module.
        (remove_dir): Ditto.
        * Scripts/webkitpy/common/system/systemhost.py:
        (SystemHost):
        (SystemHost.path_to_lldb_python_directory): Added.
        * Scripts/webkitpy/test/main.py:
        (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
        (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
        lldbWebKitTester on Mac.
        (main): Add Tools/lldb to the test search path if the platform has lldb.py.
        (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
        (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
        If we will run these tests then build lldbWebKitTester if it has not already been built as the
        unit tests depend on this program.
        * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
        * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
        * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
        * lldb/lldbWebKitTester/Makefile: Added.
        * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
        * lldb/lldbWebKitTester/main.cpp: Added.
        (breakForTestingSummaryProviders):
        (utf16String):
        (testSummaryProviders):
        (main):
        * lldb/lldb_webkit_unittest.py: Added.
        (destroy_cached_debug_session):
        (LLDBDebugSession):
        (LLDBDebugSession.setup):
        (LLDBDebugSession.tearDown):
        (TestSummaryProviders):
        (TestSummaryProviders.setUpClass):
        (TestSummaryProviders._sbFrame):
        (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
        (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
        (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
        (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
        (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
        (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
        (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
        (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):

2018-06-01  Frederic Wang  <fwang@igalia.com>

        export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed
        https://bugs.webkit.org/show_bug.cgi?id=186133

        Reviewed by Youenn Fablet.

        * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the diff.
        * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test.

2018-05-31  Frederic Wang  <fwang@igalia.com>

        export-w3c-test-changes should use the new location & name of the WPT repo
        https://bugs.webkit.org/show_bug.cgi?id=186135

        Reviewed by Youenn Fablet.

        Web platform tests have been moved to GitHub's web-platform-tests/wpt. This patch updates the
        corresponding variables to use the new organization and repository name. It also refactors a
        bit the code to reduce the amount of hardcoded strings.

        * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name wpt. Also removes the
        final slash to WPT_GH_URL, so it can be used for repo URL too.
        * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define WPT_PR_URL from
        WPT_GH_URL.
        (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_NAME.
        (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME.
        (WebPlatformTestExporter._git): Use  WPT_GH_URL.
        (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
        (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
        (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL.
        * Scripts/webkitpy/w3c/test_exporter_unittest.py:
        (TestExporterTest.test_export): Update organization and repository names for the remote
        branch and pull request.
        (TestExporterTest.test_export_with_specific_branch): Update repository name.

2018-05-31  Ryan Haddad  <ryanhaddad@apple.com>

        Update expected results for BuildStepsConstructorTest
        https://bugs.webkit.org/show_bug.cgi?id=186119

        Reviewed by Alex Christensen.

        * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missing entries for 'WinCairo 64-bit' bots.

2018-05-31  Sihui Liu  <sihui_liu@apple.com>

        [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies use different files with/without processpool
        https://bugs.webkit.org/show_bug.cgi?id=185831
        <rdar://problem/40468716>

        Reviewed by David Kilzer.

        * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
        (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
        (TEST):

2018-05-31  Chris Dumez  <cdumez@apple.com>

        [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset is a flaky failure
        https://bugs.webkit.org/show_bug.cgi?id=184893
        <rdar://problem/39747271>

        Reviewed by Wenson Hsieh.

        Update test to wait until the view is the expected height instead of
        calling waitForNextPresentationUpdate once and expect the view to
        have the right height. This fixes the flakiness.

        * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
        (TestWebKitAPI::waitUntilInnerHeightIs):
        (TestWebKitAPI::TEST):

2018-05-31  Leo Balter  <leonardo.balter@gmail.com>

        test262-runner should run in verbose mode in automation
        https://bugs.webkit.org/show_bug.cgi?id=186115

        Reviewed by Yusuke Suzuki.

        This patch toggles the verbose mode in the build bot and reports every test file
        in order to avoid the '1200 seconds without output' issue.
        * BuildSlaveSupport/build.webkit.org-config/steps.py:
        (RunTest262Tests):
        * Scripts/test262/Runner.pm:
        (processResult):

2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
        https://bugs.webkit.org/show_bug.cgi?id=186079

        Reviewed by Alex Christensen.

        This is a sub task of Bug 184770.

        This change is partial. I'm going to remove global variables
        gMainWindow and gMiniBrowser and convert more functions to
        MainWindow's methods in follow-up patches.

        * MiniBrowser/win/CMakeLists.txt: Added Common.cpp
        * MiniBrowser/win/Common.cpp:
        (menuItemIsChecked): Moved to MainWindow.cpp.
        (turnOffOtherUserAgents): Ditto.
        (EditProc): Ditto.
        (BackButtonProc): Ditto.
        (ForwardButtonProc): Ditto.
        (About): Ditto.
        (Caches): Ditto.
        (CustomUserAgent): Ditto.
        (AuthDialogProc): Ditto.
        (DisplayAuthDialog): Converted to MainWindow's method.
        (ToggleMenuItem): Ditto.
        (loadURL): Ditto.
        * MiniBrowser/win/Common.h:
        * MiniBrowser/win/MainWindow.cpp:
        (MainWindow::init): Call SetFocus at the end of the construction.
        (MainWindow::WndProc):
        (menuItemIsChecked): Moved from Common.cpp.
        (turnOffOtherUserAgents): Ditto.
        (EditProc): Ditto.
        (BackButtonProc): Ditto.
        (ForwardButtonProc): Ditto.
        (About): Ditto.
        (Caches): Ditto.
        (CustomUserAgent): Ditto.
        (authDialogProc): Ditto.
        (MainWindow::displayAuthDialog): Converted from a function of Common.cpp.
        (MainWindow::toggleMenuItem): Ditto.
        (MainWindow::loadURL): Ditto.
        * MiniBrowser/win/MainWindow.h: Added method declarations.
        * MiniBrowser/win/MiniBrowser.h: Added pragma once.
        * MiniBrowser/win/WinMain.cpp:
        (wWinMain): Include Common.h instead of Common.cpp.

2018-05-30  Brady Eidson  <beidson@apple.com>

        REGRESSION (r224684): User-agent seen by page does not change when modified by the develop menu options after reloading.
        <rdar://problem/34918109> and https://bugs.webkit.org/show_bug.cgi?id=186111

        Reviewed by Andy Estes.

        * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
        (WTR::TestRunner::setCustomUserAgent):
        * WebKitTestRunner/InjectedBundle/TestRunner.h:
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetStateToConsistentValues):
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

2018-05-30  Youenn Fablet  <youenn@apple.com>

        Rename CrossOriginResourcePolicy same to same-origin
        https://bugs.webkit.org/show_bug.cgi?id=186080

        Reviewed by Chris Dumez.

        * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
        (TestWebKitAPI::TEST):

2018-05-30  Ms2ger  <Ms2ger@igalia.com>

        [GTK] Unreviewed test gardening
        https://bugs.webkit.org/show_bug.cgi?id=186098

        Unreviewed gardening.

        * TestWebKitAPI/glib/TestExpectations.json: update expectations.

2018-05-29  Youenn Fablet  <youenn@apple.com>

        Add a consistency check between URL and CFURL
        https://bugs.webkit.org/show_bug.cgi?id=182444
        <rdar://problem/37164835>

        Reviewed by Geoff Garen.

        DRT code expected a non null URL which is no longer the case now.
        Updated DRT to remove that assumption.

        * DumpRenderTree/TestRunner.cpp:
        (TestRunner::redirectionDestinationForURL):
        * DumpRenderTree/TestRunner.h:
        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

2018-05-29  Brendan McLoughlin  <brendan@bocoup.com>

        Export changes to web-platform-test as part of the webkit-patch upload workflow
        https://bugs.webkit.org/show_bug.cgi?id=184914

        Reviewed by Youenn Fablet.

        * Scripts/webkitpy/tool/commands/upload.py:
        (Upload):
        (CreateBug.execute):
        (WPTChangeExport):
        * Scripts/webkitpy/tool/steps/__init__.py:
        * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
        (WPTChangeExport):
        (WPTChangeExport.options):
        (WPTChangeExport.run):
        * Scripts/webkitpy/w3c/common.py:
        * Scripts/webkitpy/w3c/test_exporter.py:
        (WebPlatformTestExporter):
        (WebPlatformTestExporter.__init__):
        (WebPlatformTestExporter.username):
        (WebPlatformTestExporter.token):
        (WebPlatformTestExporter._github):
        (WebPlatformTestExporter._wpt_fork_branch_github_url):
        (WebPlatformTestExporter._wpt_fork_remote):
        (WebPlatformTestExporter._wpt_fork_push_url):
        (WebPlatformTestExporter._git):
        (WebPlatformTestExporter._branch_name):
        (WebPlatformTestExporter._public_branch_name):
        (WebPlatformTestExporter._wpt_patch):
        (WebPlatformTestExporter.has_wpt_changes):
        (WebPlatformTestExporter._find_filename):
        (WebPlatformTestExporter._is_ignored_file):
        (WebPlatformTestExporter._strip_ignored_files_from_diff):
        (WebPlatformTestExporter.write_git_patch_file):
        (WebPlatformTestExporter._prompt_for_token):
        (WebPlatformTestExporter._prompt_for_username):
        (WebPlatformTestExporter._ensure_username_and_token):
        (WebPlatformTestExporter._validate_and_save_token):
        (WebPlatformTestExporter.create_branch_with_patch):
        (WebPlatformTestExporter.push_to_wpt_fork):
        (WebPlatformTestExporter.make_pull_request):
        (WebPlatformTestExporter.delete_local_branch):
        (WebPlatformTestExporter.create_upload_remote_if_needed):
        (WebPlatformTestExporter.do_export):
        (parse_args):
        (TestExporter): Deleted.
        (TestExporter.__init__): Deleted.
        (TestExporter._ensure_wpt_repository): Deleted.
        (TestExporter._fetch_wpt_repository): Deleted.
        (TestExporter._ensure_new_branch_name): Deleted.
        (TestExporter.download_and_commit_patch): Deleted.
        (TestExporter.clean): Deleted.
        (TestExporter.create_branch_with_patch): Deleted.
        (TestExporter.push_to_wpt_fork): Deleted.
        (TestExporter.make_pull_request): Deleted.
        (TestExporter.create_wpt_pull_request): Deleted.
        (TestExporter.delete_local_branch): Deleted.
        (TestExporter.create_git_patch): Deleted.
        (TestExporter.create_upload_remote): Deleted.
        (TestExporter.do_export): Deleted.
        * Scripts/webkitpy/w3c/test_exporter_unittest.py:
        (TestExporterTest.MockGit):
        (TestExporterTest.MockGit.create_patch):
        (TestExporterTest.test_export):
        (TestExporterTest.test_export_with_specific_branch):
        (TestExporterTest):
        (TestExporterTest.test_export_interactive_mode):
        (TestExporterTest.test_export_invalid_token):
        (TestExporterTest.test_export_wrong_token):
        (TestExporterTest.test_has_wpt_changes):
        (TestExporterTest.test_has_no_wpt_changes_for_no_diff):
        (TestExporterTest.test_ignore_changes_to_expected_file):

2018-05-29  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] Move WK1 specific code from Common.cpp to MiniBrowser.cpp
        https://bugs.webkit.org/show_bug.cgi?id=186029

        Reviewed by Alex Christensen.

        This is a sub task of Bug 184770.

        * MiniBrowser/win/Common.cpp:
        (ToggleMenuItem): Extracted WK1 specific code to MiniBrowser::setPreference.
        (Caches): Call MiniBrowser::updateStatistics instead of updateStatistics.
        (AbortProc): Moved to MiniBrowser.cpp.
        (getPrinterDC): Ditto.
        (initDocStruct): Ditto.
        (PrintView): Ditto.
        (ToggleMenuFlag): Ditto.
        (setWindowText): Ditto.
        (updateStatistics): Ditto.
        * MiniBrowser/win/MainWindow.cpp:
        (MainWindow::WndProc): Call MiniBrowser::print instead of PrintView.
        * MiniBrowser/win/MiniBrowser.cpp:
        (AbortProc): Moved from Common.cpp.
        (getPrinterDC): Moved from Common.cpp.
        (initDocStruct): Moved from Common.cpp.
        (setWindowText): Moved from Common.cpp.
        (MiniBrowser::print): Renamed from PrintView of Common.cpp.
        (MiniBrowser::updateStatistics): Renamed from updateStatistics of Common.cpp.
        (MiniBrowser::setPreference): Extracted from ToggleMenuItem of Common.cpp.
        * MiniBrowser/win/MiniBrowser.h: Add method declarations.
        * MiniBrowser/win/MiniBrowserWebHost.cpp: Removed duplicated IWebFramePtr typedef.

2018-05-29  Saam Barati  <sbarati@apple.com>

        JSC should put bmalloc's scavenger into mini mode
        https://bugs.webkit.org/show_bug.cgi?id=185988

        Reviewed by Michael Saboff.

        This patch makes it so that we turn off the JIT when running run-testmem
        that way we make JSC use its mini mode.

        * Scripts/run-testmem:

2018-05-29  Sihui Liu  <sihui_liu@apple.com>

        Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
        https://bugs.webkit.org/show_bug.cgi?id=185835
        <rdar://problem/39142257>

        Reviewed by Chris Dumez.

        Add API test coverage.

        * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
        (TEST):

2018-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>

        [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired
        https://bugs.webkit.org/show_bug.cgi?id=186042
        <rdar://problem/40604182>

        Reviewed by Tim Horton.

        Adds a new API test to check that the "significant area painting" rendering milestone is dispatched when a
        significant portion of the page has been painted before document load is finished.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/WebKitCocoa/paint-significant-area-milestone.html: Added.
        * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: Added.
        (-[MissingResourceSchemeHandler webView:stopURLSchemeTask:]):
        (-[MissingResourceSchemeHandler webView:startURLSchemeTask:]):
        (-[RenderingProgressHandler initWithHandler:]):
        (-[RenderingProgressHandler _webView:renderingProgressDidChange:]):
        (TEST):

2018-05-29  Thibault Saunier  <tsaunier@igalia.com>

        [GStreamer] Update "qtdemux: Clarify field name about stream-encryption-system" patch
        https://bugs.webkit.org/show_bug.cgi?id=186040

        The patch we merge contained a type and was merged in upstream GStreamer fixing that
        (s/avalaible/available/).

        Reviewed by Xabier Rodriguez-Calvar.

        * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch:

2018-05-28  Sihui Liu  <sihui_liu@apple.com>

        Add an API test to check process privilege when using Cookie API
        https://bugs.webkit.org/show_bug.cgi?id=185406

        Reviewed by Geoffrey Garen.

        Add API test coverage.

        * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
        (TEST):

2018-05-28  Thibault Saunier  <tsaunier@igalia.com>

        [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.
        https://bugs.webkit.org/show_bug.cgi?id=185948

        Reviewed by Xabier Rodriguez-Calvar.

        When the patch introducing gst_protection_filter_systems_by_available_decryptors was merged, we changed sensibly its behaviour
        concerning the way empty results is represented (now returning NULL instead of an array of 1(NULL) element) and this change was not
        properly taken into account in the qtdemux patch that uses it and got upstreamed. Those 3 new patches fixe that and change the
        NEED_CONTEXT field names to clarify the meaning of "stream-encryption-systems".

        * gstreamer/jhbuild.modules:
        * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Added. Merged upstream as 3e063703b3a51b8aaa7f75f36c4660c583a60e93
        * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Added. Merged upstream as 43a540b1cd9f162d3dae5d50e36703dfaf558a3e
        * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Added.

2018-05-27  Dan Bernstein  <mitz@apple.com>

        Reverted the changes made for https://webkit.org/b/186016

        They broke the USE(APPLE_INTERNAL_SDK) Sierra build.

2018-05-27  Dan Bernstein  <mitz@apple.com>

        [Cocoa] Avoid importing directly from subumbrella frameworks
        https://bugs.webkit.org/show_bug.cgi?id=186016

        Reviewed by Sam Weinig.

        * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
          LaunchServices header.
        * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
          OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
        * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
          when using SDKs earlier than 10.13.
        * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
          and OTHER_CPLUSPLUSFLAGS.
        * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.h instead of an
          HIToolbox header.
        * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
          OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
        * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
          LaunchServices header.

2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] Add MainWindow class
        https://bugs.webkit.org/show_bug.cgi?id=185814

        Reviewed by Per Arne Vollan.

        This is a sub task of Bug 184770. Added a new class MainWindow to
        represent the main window which will be shared among WK1 and WK2.

        This change is partial so that it's easy to review this patch.
        I'll move more functions into MainWindow.cpp, and remove more
        global variables in forthcoming patches.

        * MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp.
        * MiniBrowser/win/Common.cpp: Removed MainWindow related global
        variables hMainWnd, hURLBarWnd, hBackButtonWnd and
        hForwardButtonWnd. Added a new global variable gMainWindow.
        (WndProc): Moved to MainWindow.cpp.
        (resizeSubViews): Ditto.
        (ToggleMenuFlag): Removed static to be called from MainWindow.cpp.
        (ToggleMenuItem): Ditto.
        (CustomUserAgent): Follow the global variables removal.
        (DisplayAuthDialog): Ditto.
        (loadURL): Ditto.
        (WndProc): Renamed to MainWindow::WndProc.
        * MiniBrowser/win/MainWindow.cpp: Added.
        (MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp.
        (MainWindow::init): Extracted MainWindow initialization code from wWinMain.
        (MainWindow::resizeSubViews): Moved from Common.cpp.
        (MainWindow::WndProc): Ditto.
        * MiniBrowser/win/MainWindow.h: Added.
        (MainWindow::hwnd):
        (MainWindow::browserWindow):
        * MiniBrowser/win/MiniBrowser.cpp:
        (MiniBrowser::init):
        (MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDefaultHTML.
        (MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews.
        * MiniBrowser/win/MiniBrowser.h:
        * MiniBrowser/win/WinMain.cpp:
        (wWinMain): Extracted MainWindow initialization code into MainWindow::init.
        (MyRegisterClass): Moved to MainWindow.cpp.

2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>

        [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
        https://bugs.webkit.org/show_bug.cgi?id=185969

        Reviewed by Alex Christensen.

        MiniBrowser::init takes URL argument, but it's used only for
        loading default HTML if URL is not given.

        - Add a new method MiniBrowser::loadHTMLString
        - Remove loadHTMLString process from MiniBrowser::prepareViews

        * MiniBrowser/win/MiniBrowser.cpp:
        (MiniBrowser::init): Removed `requestedURL` argument.
        (MiniBrowser::prepareViews): Ditto.
        (MiniBrowser::loadHTMLString): New.
        (MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead of calling loadHTMLString.
        * MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLString.
        * MiniBrowser/win/WinMain.cpp:
        (wWinMain): Call MiniBrowser::loadHTMLString if URL is not given.

2018-05-27  David Kilzer  <ddkilzer@apple.com>

        svn-apply fails when a patch has an empty file
        <https://webkit.org/b/29684>

        Reviewed by Daniel Bates.

        Prior to this change, applying the following patches resulted in:
        - svn: add empty file     (failure)
        - svn: delete empty file  (failure)
        - svn: rename empty file  (failure)
        - git: add empty file     (false-positive success)
        - git: delete empty file  (success)
        - git: rename empty file  (failure)

        * Scripts/VCSUtils.pm:
        (parseSvnDiffHeader): Handle the case when there is no patch
        following the header.  If the file exists and is empty, that
        means it's a deletion.  If the file does not exist, that means
        it's an addition. Everything else is a fatal error.
        * Scripts/svn-apply:
        (patch):
        - Only apply a patch for deletion if it has one or more text
          chunks.
        - Add a case to handle adding an empty file (an addition with no
          text chunks), and verify the file doesn't exist yet.
        - Any unhandled patch is a fatal error.
        * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
        Add tests for adding an empty file and deleting an empty file.
        * Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add.
        Used by parseSvnDiffHeader.pl unit test for "add an empty file"
        test case.

2018-05-25  Aakash Jain  <aakash_jain@apple.com>

        Display detailed error logs when a script fails in EWS
        https://bugs.webkit.org/show_bug.cgi?id=175696
        <rdar://problem/34841885>

        Reviewed by Darin Adler.

        * Scripts/webkitpy/tool/bot/queueengine.py: Set output_limit to 5000 characters instead of default 500 characters.
        * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: Ditto.
        * Scripts/webkitpy/tool/commands/download.py: Ditto.
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Ditto.
        * Scripts/webkitpy/tool/commands/queues.py: Ditto.
        * Scripts/webkitpy/tool/commands/stepsequence.py: Ditto.

2018-05-25  Daniel Bates  <dabates@apple.com>

        test-webkitpy messages logged using __main__ logger are not displayed
        https://bugs.webkit.org/show_bug.cgi?id=185823

        Rubber-stamped by Aakash Jain.

        Configure the logger for __main__ so that messages that are logged before it parses its
        command line arguments are printed to standard error.

        Currently test-webkitpy creates a named logger (__main__) for its logging. However it does
        not configure a stream to use for printing until after it parses its command line arguments
        via webkitpy.test.printer.Printer.configure(). Messages logged until then are never written
        to the console. We explicitly configure the __main__ logger instead of calling webkitpy.test.printer.Printer.configure()
        earlier because the latter both configures a stream and filters logged messages based on
        the specified verbosity. Logged messaged from code in __main__ should not be subject to
        such filtering. So, we explicitly configure the __main__ logger.

        * Scripts/webkitpy/test/main.py:
        (main):

2018-05-25  Saam Barati  <sbarati@apple.com>

        Make JSC have a mini mode that kicks in when the JIT is disabled
        https://bugs.webkit.org/show_bug.cgi?id=185931

        Reviewed by Mark Lam.

        This renames a variable for clarity.

        * Scripts/run-testmem:

2018-05-25  Alex Christensen  <achristensen@webkit.org>

        URL::host should return a StringView to reduce allocations
        https://bugs.webkit.org/show_bug.cgi?id=185986

        Reviewed by Geoff Garen.

        * TestWebKitAPI/Tests/WebCore/URL.cpp:
        (TestWebKitAPI::TEST_F):
        * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
        (TestWebKitAPI::eq):
        * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
        (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):

2018-05-25  Ms2ger  <Ms2ger@igalia.com>

        Minor improvements to wpt exporter.
        https://bugs.webkit.org/show_bug.cgi?id=185978

        Reviewed by Youenn Fablet.

        * Scripts/webkitpy/w3c/test_exporter.py:
        (TestExporter.push_to_wpt_fork): Update call to create_upload_remote().
        (TestExporter.make_pull_request): Improve the description of the created PR.
        (TestExporter.create_upload_remote): Always update the remote to override any obsolete state.

2018-05-25  Saam Barati  <sbarati@apple.com>

        Have a memory test where we can validate JSCs mini memory mode
        https://bugs.webkit.org/show_bug.cgi?id=185932

        Reviewed by Mark Lam.

        This patch adds the run-testmem script. This runs the new testmem
        CLI against the contents in the testmem benchmark. The contents of testmem
        contain tests from ARES-6, Sunspider, Octane, and JetStream.
        
        One iteration of the benchmark comprises of running each testmem test for
        a certain number of iterations. We collect the peak memory usage, the memory
        usage after running all the iterations, and the time it takes to run all the
        iterations. We then run the entire benchmark 3 times over. For each test, we
        compute the arithmetic mean over each iteration for time, peak memory, and
        end memory. The benchmark then computes a time score and memory score.
        
        peak memory score = geomean({peak memory of each individual test})
        end memory score = geomean({end memory of each individual test})
        memory score = geomean({peak memory score, end memory score})
        time score = geomean({time score of each individual test})
        
        We want the memory score to weigh improvements to peak memory usage and
        memory usage at the end equally.
        
        We plan to tune this benchmark in JSC's mini mode by improving the memory
        score while ensuring the time score is not more than 10-15% regressed.

        * Scripts/run-testmem: Added.

2018-05-25  Sihui Liu  <sihui_liu@apple.com>

        [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
        https://bugs.webkit.org/show_bug.cgi?id=185041
        <rdar://problem/34684214>

        Reviewed by Geoffrey Garen.

        Add API test coverage.

        * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
        (TEST):

2018-05-24  Chris Dumez  <cdumez@apple.com>

        Reduce copying of FontCascadeDescription objects by moving them around
        https://bugs.webkit.org/show_bug.cgi?id=185963

        Reviewed by Simon Fraser.

        Reduce copying of FontCascadeDescription objects by moving them around when possible.

        * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
        (TestWebKitAPI::TEST_F):

2018-05-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        WebDriver: implement maximize, minimize and fullscreen window commands
        https://bugs.webkit.org/show_bug.cgi?id=180398

        Reviewed by Brian Burg.