b00bf1db51cfaae36a768df73d44fb433640374b
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
4
5         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
6         (PerfTestsRunner._run_tests_set):
7         (PerfTestsRunner._run_single_test):
8         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
9         (create_runner):
10         (test_run_passing_test):
11         (test_run_silent_test):
12         (test_run_failed_test):
13         (test_run_tonguey_test):
14         (test_run_timeout_test):
15         (test_run_crash_test):
16         (test_run_test_set_kills_drt_per_run):
17         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
18         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
19         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
20
21 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
22
23         Webkit generate-coverage-data script needs update to use new test script
24         https://bugs.webkit.org/show_bug.cgi?id=77597
25
26         Reviewed by Dirk Schulze.
27
28         * Scripts/generate-coverage-data:
29
30 2012-02-01  Adam Barth  <abarth@webkit.org>
31
32         Update the tests to show that the mac-ews processes patches from
33         non-committers.
34
35         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
36         (EarlyWarningSytemTest.test_committer_only_ewses):
37         (EarlyWarningSytemTest.test_builder_ewses):
38
39 2012-02-01  Adam Barth  <abarth@webkit.org>
40
41         Mac-ews logs are huge
42         https://bugs.webkit.org/show_bug.cgi?id=77045
43
44         Reviewed by Eric Seidel.
45
46         In order to get the cr-linux-ews bot to run tests on EC2, we created
47         the chromium-xvfb port, which contained a number of tweaks to the
48         Chromium port's behavior.  This patch refactors those tweaks so they
49         can be shared with the mac-ews, mostly by moving them into the
50         non-interactive mode of RunTests.
51
52         * Scripts/webkitpy/common/config/ports.py:
53         (WebKitPort):
54         (WebKitPort.layout_tests_results_path):
55         (ChromiumPort.run_javascriptcore_tests_command):
56         (ChromiumXVFBPort):
57         (ChromiumXVFBPort.run_webkit_tests_command):
58         * Scripts/webkitpy/common/config/ports_mock.py:
59         (MockPort):
60         (MockPort.layout_tests_results_path):
61         * Scripts/webkitpy/common/config/ports_unittest.py:
62         (WebKitPortTest.test_chromium_xvfb_port):
63         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
64         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
65         * Scripts/webkitpy/tool/commands/queues_unittest.py:
66         (CommitQueueTest.test_commit_queue):
67         (test_rollout):
68         (test_manual_reject_during_processing):
69         * Scripts/webkitpy/tool/steps/runtests.py:
70         (RunTests.run):
71         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
72         (RunTestsTest.test_no_unit_tests):
73         * Scripts/webkitpy/tool/steps/steps_unittest.py:
74         (StepsTest.test_runtests_args):
75
76 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
77
78         Roll out r106442. It made some tests more stable but others less stable.
79
80         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
81         (PerfTestsRunner._run_tests_set):
82         (PerfTestsRunner._run_single_test):
83         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
84         (create_runner):
85         (test_run_passing_test):
86         (test_run_silent_test):
87         (test_run_failed_test):
88         (test_run_tonguey_test):
89         (test_run_timeout_test):
90         (test_run_crash_test):
91         (test_run_test_set):
92
93 2012-02-01  Lucas Forschler  <lforschler@apple.com>
94
95         Enable EWS for non-contributers.
96         https://bugs.webkit.org/show_bug.cgi?id=77576
97         
98         Reviewed by Adam Barth.
99
100         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
101         (MacEWS):
102
103 2012-02-01  Beth Dakin  <bdakin@apple.com>
104
105         https://bugs.webkit.org/show_bug.cgi?id=77383
106         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
107         -and corresponding-
108         <rdar://problem/10709560>
109
110         Reviewed by Sam Weinig.
111
112         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
113         for.
114         * MiniBrowser/mac/BrowserWindowController.m:
115         (-[BrowserWindowController awakeFromNib]):
116         * WebKitTestRunner/TestController.cpp:
117         (WTR::TestController::initialize):
118
119 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
120
121         TestWebKitAPI isn't being built on chromium bots any more
122         https://bugs.webkit.org/show_bug.cgi?id=77563
123
124         Reviewed by Dimitri Glazkov.
125
126         I accidentally dropped it in the refactoring in r105449.
127
128         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
129
130 2012-02-01  Hans Wennborg  <hans@chromium.org>
131
132         Rename WebSpeechInputResult::set() to assign()
133         https://bugs.webkit.org/show_bug.cgi?id=77540
134
135         Reviewed by Darin Fisher.
136
137         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
138         (MockWebSpeechInputController::addMockRecognitionResult):
139         (MockWebSpeechInputController::speechTaskFired):
140
141 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
142
143         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
144         https://bugs.webkit.org/show_bug.cgi?id=77542
145
146         Reviewed by Martin Robinson.
147
148         * gtk/generate-gtkdoc: Check first whether there's
149         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
150         instead.
151         (get_webkit2_options): Return just the options since the
152         pkg_config_path doesn't depend on options
153         (get_webkit1_options): Ditto.
154         (generate_doc): Helper function to create a generator and generate
155         documentation for the given pkg-config file with the given options.
156         * gtk/gtkdoc.py:
157         (GTKDoc.__init__): Don't use ** for args parameter, since it's
158         used as a dict and never expanded.
159         (PkgConfigGTKDoc.__init__): Ditto.
160
161 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
162
163         [GTK] API documentation is not installed even when building with --enable-gtk-doc
164         https://bugs.webkit.org/show_bug.cgi?id=77094
165
166         Reviewed by Martin Robinson.
167
168         * GNUmakefile.am: Add install-data-local and uninstall-local rules
169         to install/uninstall WebKit1 and WebKit2 API documentation.
170
171 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
172
173         Unreviewed, rolling out r106460.
174         http://trac.webkit.org/changeset/106460
175         https://bugs.webkit.org/show_bug.cgi?id=77552
176
177         It break unit tests if WEBKIT_TESTFONTS isn't defined.
178         (Requested by Ossy on #webkit).
179
180         * Scripts/webkitpy/layout_tests/port/qt.py:
181
182 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
183
184         [Qt] Automatic clean build feature always do clean build with --no-webkit2
185         https://bugs.webkit.org/show_bug.cgi?id=74519
186
187         Reviewed by Tor Arne Vestbø.
188
189         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
190
191         * qmake/mkspecs/features/features.prf:
192
193 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
194
195         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
196         https://bugs.webkit.org/show_bug.cgi?id=77466
197
198         Reviewed by Kenneth Rohde Christiansen.
199
200         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
201         is set or if we should raise an error.
202
203         * Scripts/webkitpy/layout_tests/port/qt.py:
204         (QtPort.setup_environ_for_server):
205
206 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
207
208         Reviewed by Martin Robinson.
209
210         [GTK] Improve FrameLoader signals. Resource loading
211         https://bugs.webkit.org/show_bug.cgi?id=49543
212
213         Support for the new loader signals in DRT.
214
215         * DumpRenderTree/gtk/DumpRenderTree.cpp:
216         (urlPath):
217         (willSendRequestCallback):
218         (urlSuitableForTestResult):
219         (descriptionSuitableForTestResult):
220         (didReceiveResponse):
221         (didFinishLoading):
222         (didFailLoadingWithError):
223         (createWebView):
224
225 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
226
227         run-perf-tests should restart DRT for each test
228         https://bugs.webkit.org/show_bug.cgi?id=77506
229
230         Reviewed by Adam Barth.
231
232         Always restart DRT when running performance tests in order to minimize the dependency between tests.
233
234         * Scripts/webkitpy/layout_tests/port/chromium.py:
235         (ChromiumDriver.stop):
236         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
237         (PerfTestsRunner._run_tests_set):
238         (PerfTestsRunner._run_single_test):
239         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
240         (create_runner):
241         (test_run_passing_test):
242         (test_run_silent_test):
243         (test_run_failed_test):
244         (test_run_tonguey_test):
245         (test_run_timeout_test):
246         (test_run_crash_test):
247         (test_run_test_set_kills_drt_per_run):
248         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
249         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
250         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
251
252 2012-01-31  Hans Wennborg  <hans@chromium.org>
253
254         Speech Input: Report speech element rect relative to window rather than frame
255         https://bugs.webkit.org/show_bug.cgi?id=76443
256
257         Reviewed by Darin Fisher.
258
259         Update LayoutTestController to allow for retrieving the speech
260         element's position used in a request.
261
262         In Chromium this is handled by the MockWebSpeechInputController;
263         adding stubs for the other implementations.
264
265         * DumpRenderTree/LayoutTestController.cpp:
266         (setMockSpeechInputDumpRectCallback):
267         (LayoutTestController::staticFunctions):
268         * DumpRenderTree/LayoutTestController.h:
269         (LayoutTestController):
270         * DumpRenderTree/chromium/LayoutTestController.cpp:
271         (LayoutTestController::LayoutTestController):
272         (LayoutTestController::setMockSpeechInputDumpRect):
273         * DumpRenderTree/chromium/LayoutTestController.h:
274         (LayoutTestController):
275         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
276         (MockWebSpeechInputController::setDumpRect):
277         (MockWebSpeechInputController::clearResults):
278         (MockWebSpeechInputController::startRecognition):
279         (MockWebSpeechInputController::MockWebSpeechInputController):
280         (makeRectResult):
281         (MockWebSpeechInputController::speechTaskFired):
282         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
283         (MockWebSpeechInputController):
284         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
285         (LayoutTestController::setMockSpeechInputDumpRect):
286         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
287         (LayoutTestController::setMockSpeechInputDumpRect):
288         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
289         (LayoutTestController::setMockSpeechInputDumpRect):
290         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
291         (LayoutTestController::setMockSpeechInputDumpRect):
292         * DumpRenderTree/qt/LayoutTestControllerQt.h:
293         (LayoutTestController):
294         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
295         (LayoutTestController::setMockSpeechInputDumpRect):
296         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
297         (LayoutTestController::setMockSpeechInputDumpRect):
298
299 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
300
301         [EFL] Add basic DRT/Efl implementation to support viewport test.
302         https://bugs.webkit.org/show_bug.cgi?id=77320
303
304         Reviewed by Andreas Kling.
305
306         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
307         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
308
309 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
310
311         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
312         https://bugs.webkit.org/show_bug.cgi?id=77473
313         <rdar://problem/10751357>
314
315         Reviewed by Darin Adler.
316
317         * DumpRenderTree/mac/EventSendingController.mm:
318         (-[EventSendingController keyDown:withModifiers:withLocation:]):
319         * WebKitTestRunner/mac/EventSenderProxy.mm:
320         (WTR::EventSenderProxy::keyDown):
321         Added a new special keyDown value to test this.
322
323 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
324
325         nrwt: fix the mock port to work with DriverProxy, reftests
326         https://bugs.webkit.org/show_bug.cgi?id=77170
327
328         Reviewed by Eric Seidel.
329
330         The DryrunPort used for benchmarking and testing NRWT has been
331         broken since we added the DriverProxy code. It isn't really
332         needed any more, so I've removed it.
333
334         The MockDRT port was also broken by DriverProxy, and moreover,
335         never worked w/ reftests. Since we don't exercise this module in
336         the unit tests, the code had also bitrotted some. I have cleaned
337         it up and made it use DriverInput and DriverOutput for
338         consistency.
339
340         * Scripts/webkitpy/layout_tests/port/dryrun.py:
341         (DryRunPort.__init__):
342         (DryRunPort):
343         (DryRunPort.real_name):
344         (DryRunPort.create_driver):
345         (DryRunPort.driver_cmd_line):
346         (DryRunPort._driver_class):
347         (DryrunDriver):
348         (DryrunDriver.run_test):
349         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
350         (MockDRTPort.create_driver):
351         (MockChromiumDRT.run_one_test):
352
353 2012-01-31  Ojan Vafai  <ojan@chromium.org>
354
355         run-webkit-tests calls out to webkit-build-directory twice
356         https://bugs.webkit.org/show_bug.cgi?id=77248
357
358         Reviewed by Dirk Pranke.
359
360         * Scripts/webkit-build-directory:
361         If called with no arguments, print out both the top-level directory and the 
362         configuration directory
363
364         * Scripts/webkitpy/layout_tests/port/config.py:
365         (Config.build_directory):
366         When called with no arguments, get and cache both the top-level and configuration directories.
367
368         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
369         (main):
370         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
371         (ConfigTest.assert_configuration):
372         (ConfigTest.test_build_directory.mock_webkit_build_directory):
373         (ConfigTest.test_build_directory):
374         (ConfigTest.test_default_configuration__notfound):
375         * Scripts/webkitpy/layout_tests/port/webkit.py:
376         (WebKitPort._build_path):
377         Cache the build directory in the options object so that other users
378         of the options object don't need to call out to webkit-build-directory.
379         Also, properly support the existing --build-directory argument.
380
381 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
382
383         Bump up the timeout for performance tests since DOM/DOMTable.html
384         and Parser/html5-full-render.html are timing out on the bot.
385
386         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
387         (PerfTestsRunner._parse_args):
388
389 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
390
391         Fix the update_webgl_conformance_tests.py script in order to enable it
392         to detect the SCM being used correctly.
393         https://bugs.webkit.org/show_bug.cgi?id=77462
394
395         Reviewed by Kenneth Russell.
396
397         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
398         (default_out_dir):
399
400 2012-01-31  Eric Seidel  <eric@webkit.org>
401
402         webkit-patch apply-from-bug should work regardless of your CWD
403         https://bugs.webkit.org/show_bug.cgi?id=77482
404
405         Reviewed by Adam Barth.
406
407         webkit-patch only ever works with patches made from the root
408         directory.  We should pass the CWD to svn-apply in the case
409         where we're running not from the webkit root.  I believe
410         this used to work in the past and regressed.
411
412         * Scripts/webkitpy/common/checkout/checkout.py:
413         (Checkout.apply_patch):
414         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
415         (CheckoutTest.test_apply_patch):
416
417 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
418
419         Unreviewed, rolling out r106302.
420         http://trac.webkit.org/changeset/106302
421         https://bugs.webkit.org/show_bug.cgi?id=77472
422
423         Broke building DRT before running the tests (Requested by ojan
424         on #webkit).
425
426         * Scripts/webkit-build-directory:
427         * Scripts/webkitpy/layout_tests/port/config.py:
428         (Config.build_directory):
429         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
430         (main):
431         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
432         (ConfigTest.assert_configuration):
433         (ConfigTest.test_build_directory.mock_webkit_build_directory):
434         (ConfigTest.test_build_directory):
435         (ConfigTest.test_default_configuration__notfound):
436         * Scripts/webkitpy/layout_tests/port/webkit.py:
437         (WebKitPort._build_path):
438
439 2012-01-31  Antoine Labour  <piman@chromium.org>
440
441         Merge WebGraphicsContext3D creation and initialization, and move it to
442         WebViewClient.
443         https://bugs.webkit.org/show_bug.cgi?id=76593
444
445         Reviewed by Darin Fisher.
446
447         * DumpRenderTree/chromium/TestWebPlugin.cpp:
448         (TestWebPlugin::TestWebPlugin):
449         (TestWebPlugin::initialize):
450         * DumpRenderTree/chromium/TestWebPlugin.h:
451         * DumpRenderTree/chromium/WebViewHost.cpp:
452         (WebViewHost::createGraphicsContext3D):
453         (WebViewHost::createPlugin):
454         * DumpRenderTree/chromium/WebViewHost.h:
455
456 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
457
458         [GTK] build-webkit warning.
459         https://bugs.webkit.org/show_bug.cgi?id=77411
460
461         Reviewed by Philippe Normand.
462
463         * Scripts/webkitdirs.pm:
464         (isCrossCompilation):
465
466 2012-01-31  Dan Bernstein  <mitz@apple.com>
467
468         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
469
470         Reviewed by Anders Carlsson.
471
472         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
473
474 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
475
476         If the QTDIR environment variable is set, the build system fails to compile WinCairo
477         https://bugs.webkit.org/show_bug.cgi?id=77112
478
479         Reviewed by Daniel Bates.
480
481         * Scripts/webkitdirs.pm:
482         (determineIsQt):
483
484 2012-01-31  Adam Roben  <aroben@apple.com>
485
486         Only call -typingAttributes on WebViews, not WebHTMLViews
487
488         Looks like this case was just missed in r105908.
489
490         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
491
492         Reviewed by Antti Koivisto.
493
494         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
495         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
496         earlier.
497
498 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
499
500         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
501         https://bugs.webkit.org/show_bug.cgi?id=77221
502
503         Reviewed by Kenneth Rohde Christiansen.
504
505         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
506
507         * MiniBrowser/qt/MiniBrowserApplication.cpp:
508         (MiniBrowserApplication::sendTouchEvent):
509
510 2012-01-26  Hans Wennborg  <hans@chromium.org>
511
512         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
513         https://bugs.webkit.org/show_bug.cgi?id=77083
514
515         Reviewed by Darin Fisher.
516
517         Add MockWebSpeechInputController which provides a mock implementation
518         of the WebSpeechInputController interface, and use that in
519         DumpRenderTree.
520
521         * DumpRenderTree/DumpRenderTree.gypi:
522         * DumpRenderTree/chromium/LayoutTestController.cpp:
523         (LayoutTestController::addMockSpeechInputResult):
524         * DumpRenderTree/chromium/LayoutTestController.h:
525         ():
526         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
527         (MockWebSpeechInputController::create):
528         (MockWebSpeechInputController::addMockRecognitionResult):
529         (MockWebSpeechInputController::clearResults):
530         (MockWebSpeechInputController::startRecognition):
531         (MockWebSpeechInputController::cancelRecognition):
532         (MockWebSpeechInputController::stopRecording):
533         (MockWebSpeechInputController::MockWebSpeechInputController):
534         (MockWebSpeechInputController::speechTaskFired):
535         (MockWebSpeechInputController::SpeechTask::SpeechTask):
536         (MockWebSpeechInputController::SpeechTask::stop):
537         (MockWebSpeechInputController::SpeechTask::runIfValid):
538         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
539         (WebKit):
540         (MockWebSpeechInputController):
541         (MockWebSpeechInputController::taskList):
542         (SpeechTask):
543         * DumpRenderTree/chromium/TestShell.cpp:
544         * DumpRenderTree/chromium/WebViewHost.cpp:
545         (WebViewHost::speechInputController):
546         * DumpRenderTree/chromium/WebViewHost.h:
547         (WebKit):
548         (WebViewHost::speechInputControllerMock):
549         (WebViewHost):
550         ():
551
552 2012-01-31  Hajime Morrita  <morrita@chromium.org>
553
554         [PerformanceTests] Add landing html for Dromaeo dom-query test
555         https://bugs.webkit.org/show_bug.cgi?id=77329
556
557         Reviewed by Ryosuke Niwa.
558
559         Added some more ignorable output patterns to allow warnings
560         from a third party test suite.
561
562         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
563         (PerfTestsRunner):
564         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
565
566 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
567
568         [wx] Unreviewed. Update download URLs to new domain.
569         
570         * waf/build/build_utils.py:
571         (update_wx_deps):
572
573 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
574
575         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
576         to the list of build directories.
577         
578         * waf/build/settings.py:
579
580 2012-01-30  Kentaro Hara  <haraken@chromium.org>
581
582         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
583         output an empty method name (i.e. "()")
584         https://bugs.webkit.org/show_bug.cgi?id=77336
585
586         Reviewed by Darin Adler.
587
588         r105797 tried to detect a change outside methods, but it causes a bug that
589         prepare-ChangeLog can output an empty method name, like this:
590
591             * foo/bar/baz.cpp:
592             (method1):
593             ():
594             (method2):
595
596         This is because the cpp parser in prepare-ChangeLog cannot distinguish
597         '{' as the beginning of a method with '{' as the beginning of an array definition
598         at the top level.
599
600             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
601
602             void func() { // This '{' is the beginning of a method.
603                 ...;
604             }
605
606         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
607
608         * Scripts/prepare-ChangeLog:
609         (get_function_line_ranges_for_cpp): Modified as described above.
610         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
611         an empty method name. Ideally this should not happen but may happen, since the
612         parsers are not perfect.
613         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
614         (NameSpace7):
615         (NameSpace8):
616         (Class109):
617         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
618
619 2012-01-30  Ojan Vafai  <ojan@chromium.org>
620
621         run-webkit-tests calls out to webkit-build-directory twice
622         https://bugs.webkit.org/show_bug.cgi?id=77248
623
624         Reviewed by Dirk Pranke.
625
626         This reduces to calls to webkit-build-directory to one call and
627         saves 500ms for run-webkit-tests over a single file.
628
629         * Scripts/webkit-build-directory:
630         If called with no arguments, print out both the top-level directory and the 
631         configuration directory.
632
633         * Scripts/webkit-build-directory:
634         * Scripts/webkitpy/layout_tests/port/config.py:
635         (Config.build_directory):
636         When called with no arguments, get and cache both the top-level and configuration directories.
637
638         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
639         (main):
640         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
641         (ConfigTest.assert_configuration):
642         (ConfigTest.test_build_directory.mock_webkit_build_directory):
643         (ConfigTest.test_build_directory):
644         (ConfigTest.test_default_configuration__notfound):
645         * Scripts/webkitpy/layout_tests/port/webkit.py:
646         (WebKitPort._build_path):
647         Cache the root directory in the options object so that other users
648         of the options object don't need to call out to webkit-build-directory.
649
650 2012-01-30  Ojan Vafai  <ojan@chromium.org>
651
652         Parsing test_expecations.txt + Skipped lists takes too long
653         https://bugs.webkit.org/show_bug.cgi?id=77059
654
655         Reviewed by Dirk Pranke.
656
657         This saves ~100ms on the Apple Mac port.
658         -memoize a bunch of path methods.
659         -Avoid doing multiple disk accesses per line.
660         -Parse the skipped list directly instead of turning it into a test_expecations.txt
661         formatting string and parsing that.
662
663         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
664         (TestExpectationParser):
665         (TestExpectationParser.expectation_for_skipped_test):
666         (TestExpectationParser._parse_line):
667         (TestExpectationParser._collect_matching_tests):
668         (TestExpectations.__init__):
669         (TestExpectations._add_skipped_tests):
670         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
671         (test_add_skipped_tests):
672         (test_add_skipped_tests_duplicate):
673         * Scripts/webkitpy/layout_tests/port/base.py:
674         (Port):
675         (Port.test_isfile):
676         (Port.normalize_test_name):
677         (Port.layout_tests_dir):
678         (Port.abspath_for_test):
679         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
680
681 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
682
683         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
684         
685         * Scripts/webkitpy/common/config/watchlist:
686
687 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
688
689         Unreviewed build fix following bug#76855
690
691         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
692         ():
693         (TestWebKitAPI::TEST_F):
694
695 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
696
697         [Qt] WKTR: Use a software rendering pipiline when running tests.
698         https://bugs.webkit.org/show_bug.cgi?id=76708
699
700         Reviewed by Kenneth Rohde Christiansen.
701
702         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
703         (WTR::WrapperWindow::WrapperWindow):
704         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
705
706 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
707
708         [Qt] Store build config immediately instead of waiting for a successfull build
709
710         Otherwise we will not pick up changes to the config if the build is aborted,
711         for example due to build errors or if the user pressed Ctrl+Z. We now write
712         the new config before starting a build, but still defer to write the SVN
713         revision once the build completes successfully.
714
715         Reviewed by Ossy.
716
717         * Scripts/webkitdirs.pm:
718         (buildQMakeProjects):
719
720 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
721
722         [Qt] Add "New Window" button to the Qt MiniBrowser
723         https://bugs.webkit.org/show_bug.cgi?id=77281
724
725         Reviewed by Tor Arne Vestbø.
726
727         * MiniBrowser/qt/BrowserWindow.cpp:
728         (BrowserWindow::BrowserWindow):
729         * MiniBrowser/qt/MiniBrowser.qrc:
730         * MiniBrowser/qt/icons/plus.png: Added.
731         * MiniBrowser/qt/qml/BrowserWindow.qml:
732
733 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
734
735         Unreviewed rolling out r106222.
736
737         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
738         (SingleTestRunner.__init__):
739         * Scripts/webkitpy/layout_tests/controllers/worker.py:
740         (Worker.handle_test_list):
741         * Scripts/webkitpy/layout_tests/models/test_input.py:
742         (TestInput.__init__):
743         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
744         (_set_up_derived_options):
745         (parse_args):
746         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
747         (MainTest.test_repeat_each):
748         * WebKitTestRunner/TestInvocation.cpp:
749         (WTR::TestInvocation::setIsPixelTest):
750
751 2012-01-30  Hans Wennborg  <hans@chromium.org>
752
753         Unreviewed, rolling out r106219.
754         http://trac.webkit.org/changeset/106219
755         https://bugs.webkit.org/show_bug.cgi?id=77083
756
757         This broke Chromium's test_shell.
758
759         * DumpRenderTree/DumpRenderTree.gypi:
760         * DumpRenderTree/chromium/LayoutTestController.cpp:
761         (LayoutTestController::addMockSpeechInputResult):
762         * DumpRenderTree/chromium/LayoutTestController.h:
763         (WebKit):
764         (LayoutTestController):
765         ():
766         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
767         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
768         * DumpRenderTree/chromium/TestShell.cpp:
769         * DumpRenderTree/chromium/WebViewHost.cpp:
770         (WebViewHost::speechInputController):
771         * DumpRenderTree/chromium/WebViewHost.h:
772         (WebKit):
773         (WebViewHost::speechInputControllerMock):
774         (WebViewHost):
775         ():
776
777 2012-01-26  Hans Wennborg  <hans@chromium.org>
778
779         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
780         https://bugs.webkit.org/show_bug.cgi?id=77083
781
782         Reviewed by Darin Fisher.
783
784         Add MockWebSpeechInputController which provides a mock implementation
785         of the WebSpeechInputController interface, and use that in
786         DumpRenderTree.
787
788         * DumpRenderTree/DumpRenderTree.gypi:
789         * DumpRenderTree/chromium/LayoutTestController.cpp:
790         (LayoutTestController::addMockSpeechInputResult):
791         * DumpRenderTree/chromium/LayoutTestController.h:
792         ():
793         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
794         (MockWebSpeechInputController::create):
795         (MockWebSpeechInputController::addMockRecognitionResult):
796         (MockWebSpeechInputController::clearResults):
797         (MockWebSpeechInputController::startRecognition):
798         (MockWebSpeechInputController::cancelRecognition):
799         (MockWebSpeechInputController::stopRecording):
800         (MockWebSpeechInputController::MockWebSpeechInputController):
801         (MockWebSpeechInputController::speechTaskFired):
802         (MockWebSpeechInputController::SpeechTask::SpeechTask):
803         (MockWebSpeechInputController::SpeechTask::stop):
804         (MockWebSpeechInputController::SpeechTask::runIfValid):
805         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
806         (WebKit):
807         (MockWebSpeechInputController):
808         (MockWebSpeechInputController::taskList):
809         (SpeechTask):
810         * DumpRenderTree/chromium/TestShell.cpp:
811         * DumpRenderTree/chromium/WebViewHost.cpp:
812         (WebViewHost::speechInputController):
813         * DumpRenderTree/chromium/WebViewHost.h:
814         (WebKit):
815         (WebViewHost::speechInputControllerMock):
816         (WebViewHost):
817         ():
818
819 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
820
821         Unreviewed, rolling out r106109.
822         http://trac.webkit.org/changeset/106109
823         https://bugs.webkit.org/show_bug.cgi?id=77302
824
825         It made tests crash (Requested by Ossy_weekend on #webkit).
826
827         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
828         (WTR::WrapperWindow::WrapperWindow):
829         (WTR::PlatformWebView::PlatformWebView):
830
831 2012-01-28  Nico Weber  <thakis@chromium.org>
832
833         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
834         https://bugs.webkit.org/show_bug.cgi?id=77243
835
836         Reviewed by Adam Barth.
837
838         * Scripts/update-webkit:
839         * Scripts/webkitdirs.pm:
840         (isChromiumNinja):
841         (determineIsChromiumNinja):
842         (buildChromiumNinja):
843         (buildChromium):
844
845 2012-01-27  Kentaro Hara  <haraken@chromium.org>
846
847         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
848         https://bugs.webkit.org/show_bug.cgi?id=77241
849
850         Reviewed by Ryosuke Niwa.
851
852         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
853         in a method in some namespace or class is treated as a method.
854         This patch fixes the bug.
855
856             class C {
857                 void func()
858                 {
859                     if (1) {    // This should not be treated as a method.
860                     }
861                 }
862             };
863
864         * Scripts/prepare-ChangeLog:
865         (get_function_line_ranges_for_cpp):
866         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
867         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
868         (Class108):
869         (Class108::func35):
870
871 2012-01-27  Enrica Casucci  <enrica@apple.com>
872
873         Followup to http://trac.webkit.org/changeset/106171.
874         Dan Bernstein pointed out correctly that I should
875         have used copy instead of initWithString.
876
877         Reviewed by Dan Bernstein.
878
879         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
880         (-[LocalPasteboard initWithName:]):
881
882 2012-01-27  Enrica Casucci  <enrica@apple.com>
883
884         DRT pasteboard object should return the correct pasteboard name.
885         https://bugs.webkit.org/show_bug.cgi?id=77260
886         
887         Currently the name property always returns nil.
888         Adding a memeber variable to store the pasteboard name and return its
889         value from the name method instead of returning nil always.
890
891         Reviewed by Dan Bernstein.
892
893         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
894         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
895         (-[LocalPasteboard initWithName:]):
896         (-[LocalPasteboard name]):
897
898 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
899
900         [GTK] [WK2] Implement the policy client
901         https://bugs.webkit.org/show_bug.cgi?id=76343
902
903         Reviewed by Gustavo Noronha Silva.
904
905         * gtk/generate-gtkdoc:
906         (get_webkit2_options): Update the list of skipped source files to include all clients.
907
908 2012-01-27  Ada Chan  <adachan@apple.com>
909
910         Add test for WKBundleFrameGetParentFrame().
911         https://bugs.webkit.org/show_bug.cgi?id=77161
912
913         Reviewed by Anders Carlsson.
914
915         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
916         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
917         (TestWebKitAPI):
918         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
919         (TestWebKitAPI::setInjectedBundleClient):
920         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
921         Make sure the check is successful.
922         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
923         (TestWebKitAPI):
924         (ParentFrameTest):
925         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
926         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
927         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
928         to the test controller.
929         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
930
931 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
932
933         [Gtk] DumpRenderTree lacks --no-timeout command line option
934         https://bugs.webkit.org/show_bug.cgi?id=77196
935
936         Reviewed by Martin Robinson.
937
938         Add the --no-timeout command line option and reorganize
939         watchdog code to make running DumpRenderTree without
940         timeout possible.
941
942         * DumpRenderTree/gtk/DumpRenderTree.cpp:
943         (setWaitToDumpWatchdog):
944         (shouldSetWaitToDumpWatchdog):
945         (initializeGlobalsFromCommandLineOptions):
946         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
947         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
948         (waitToDumpWatchdogFired):
949         (LayoutTestController::setWaitToDump):
950
951 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
952
953         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
954         https://bugs.webkit.org/show_bug.cgi?id=77122
955
956         Reviewed by Kenneth Rohde Christiansen.
957
958         * MiniBrowser/qt/MiniBrowserApplication.cpp:
959         (MiniBrowserApplication::MiniBrowserApplication):
960
961 2012-01-27  Zeno Albisser  <zeno@webkit.org>
962
963         [Qt][Mac] Build fails after adding ICU support (r105997).
964         https://bugs.webkit.org/show_bug.cgi?id=77118
965
966         Define WTF_USE_ICU_UNICODE if we are on mac.
967
968         Reviewed by Tor Arne Vestbø.
969
970         * qmake/mkspecs/features/features.prf:
971
972 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
973
974         Update committers.py with new contributors.
975         https://bugs.webkit.org/show_bug.cgi?id=77207
976
977         I added six new contributors into committers.py:
978
979         - Adam Kallai
980         - Balazs Ankes
981         - Janos Badics
982         - Nandor Huszka
983         - Roland Takacs
984         - Szilard Ledan-Muntean
985
986         * Scripts/webkitpy/common/config/committers.py:
987
988 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
989
990         Add Vsevolod Vlasov to reviewers list.
991
992         Reviewed by Pavel Feldman.
993
994         * Scripts/webkitpy/common/config/committers.py:
995
996 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
997
998         [Qt] WKTR: Use a software rendering pipiline when running tests.
999         https://bugs.webkit.org/show_bug.cgi?id=76708
1000
1001         Reviewed by Kenneth Rohde Christiansen.
1002
1003         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1004         (WTR::WrapperWindow::WrapperWindow):
1005         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1006
1007 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1008
1009         [wx] Unreviewed. Build fix, add WebCore/testing/js
1010         to the list of source directories we build.
1011
1012         * waf/build/settings.py:
1013
1014 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
1015
1016         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
1017         https://bugs.webkit.org/show_bug.cgi?id=77177
1018
1019         Reviewed by Jon Honeycutt.
1020
1021         * Scripts/commit-log-editor:
1022
1023 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1024
1025         Decrease sleep time when killing server_process on Mac.
1026         https://bugs.webkit.org/show_bug.cgi?id=77169
1027
1028         Reviewed by Eric Seidel.
1029
1030         This shaves another ~70ms off single test runtime.
1031
1032         * Scripts/webkitpy/layout_tests/port/server_process.py:
1033         (ServerProcess.stop):
1034
1035 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1036
1037         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
1038         https://bugs.webkit.org/show_bug.cgi?id=77164
1039
1040         Reviewed by Dirk Pranke.
1041
1042         http://trac.webkit.org/changeset/106035 depends on builder_name being
1043         falsey by default. There's other code that requires it to be iterable
1044         by default. So, make it be the empty string.
1045
1046         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1047         (parse_args):
1048
1049 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
1050
1051         run-perf-test should include relative file paths in test names
1052         https://bugs.webkit.org/show_bug.cgi?id=77144
1053
1054         Reviewed by Adam Birth.
1055
1056         Include all directory names in the test name separated by "/".
1057         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
1058
1059         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1060         (PerfTestsRunner):
1061         (PerfTestsRunner._process_parser_test_result):
1062         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1063         (test_run_test_set_with_json_output):
1064         (test_run_test_set_with_json_source):
1065
1066 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
1067
1068         webkitpy: re-land cleanup of test scaffolding
1069         https://bugs.webkit.org/show_bug.cgi?id=77153
1070
1071         Reviewed by Eric Seidel.
1072
1073         This is an attempt to reland the change in bug 76973 / 
1074         r105935. My earlier attempt to manipulate PYTHONPATH
1075         seems to only work some of the time, for reasons that
1076         elude me. Directly adding Tools/Scripts to sys.path from
1077         inside the test script appears to work (more?) reliably.
1078
1079         Also, it seemed like the files didn't actually get deleted
1080         the last time; I don't know why.
1081
1082         * Scripts/test-webkitpy:
1083         * Scripts/webkitpy/common/system/executive_unittest.py:
1084         (command_line):
1085         (ExecutiveTest):
1086         (ExecutiveTest.test_run_command_args_type):
1087         (ExecutiveTest.test_run_command_with_unicode):
1088         (ExecutiveTest.test_running_pids):
1089         (main):
1090         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1091         * Scripts/webkitpy/test/cat.py: Removed.
1092         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1093         * Scripts/webkitpy/test/echo.py: Removed.
1094         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1095
1096 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1097
1098         run-webkit-tests calls "nm" when it doesn't need to
1099         https://bugs.webkit.org/show_bug.cgi?id=77143
1100
1101         Reviewed by Dirk Pranke.
1102
1103         If we are not running any test that can be skipped by checking
1104         the DRT feature list or looking at the list of symbols, avoid calling
1105         out to DRT or calling "nm".
1106
1107         This saves ~700ms on my Mac Pro. In cases where you still have to call out
1108         to "nm" it's only a couple ms slower.
1109
1110         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1111         (TestExpectations.__init__):
1112         * Scripts/webkitpy/layout_tests/port/base.py:
1113         (Port.skipped_tests):
1114         * Scripts/webkitpy/layout_tests/port/webkit.py:
1115         (WebKitPort._should_check_for_missing_features):
1116         (WebKitPort):
1117         (WebKitPort._should_check_for_missing_symbols):
1118         (WebKitPort._skipped_tests_for_unsupported_features):
1119         (WebKitPort.skipped_layout_tests):
1120         (WebKitPort.skipped_tests):
1121         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1122         (WebKitPortTest.test_skipped_directories_for_symbols):
1123         (test_skipped_directories_for_features):
1124         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
1125         (test_skipped_layout_tests):
1126
1127 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
1128
1129         Support a suffix on ChangeLog filenames based on a configuration file
1130         https://bugs.webkit.org/show_bug.cgi?id=76956
1131
1132         Reviewed by Kentaro Hara.
1133
1134         Modify the tools used to generate, edit and resolve ChangeLogs to support
1135         the addition of a suffix to the ChangeLog filename.
1136
1137         This patch makes it easier to support alternate ChangeLog files in branches.
1138
1139         * Scripts/VCSUtils.pm:
1140         (changeLogSuffix):
1141         (changeLogFileName):
1142         * Scripts/commit-log-editor:
1143         * Scripts/prepare-ChangeLog:
1144         (getLatestChangeLogs):
1145         (generateNewChangeLogs):
1146         (generateFileList):
1147         * Scripts/resolve-ChangeLogs:
1148         (findChangeLog):
1149
1150 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1151
1152         Unreviewed, rolling out r106038.
1153         http://trac.webkit.org/changeset/106038
1154         https://bugs.webkit.org/show_bug.cgi?id=77142
1155
1156         Caused a bunch of skipped tests to not be skipped. (Requested
1157         by ojan on #webkit).
1158
1159         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1160         (TestExpectationParser):
1161         (TestExpectationParser.parse):
1162         (TestExpectationParser._parse_line):
1163         (TestExpectationParser._collect_matching_tests):
1164         (TestExpectations.__init__):
1165         (TestExpectations._add_skipped_tests):
1166         * Scripts/webkitpy/layout_tests/port/base.py:
1167         (Port.test_dirs):
1168         (Port.normalize_test_name):
1169         (Port.update_baseline):
1170         (Port.layout_tests_dir):
1171         (Port.relative_perf_test_filename):
1172         (Port.abspath_for_test):
1173
1174 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1175
1176         Parsing test_expecations.txt + Skipped lists takes too long
1177         https://bugs.webkit.org/show_bug.cgi?id=77059
1178
1179         Reviewed by Dirk Pranke.
1180
1181         This saves ~100ms on the Apple Mac port.
1182         -memoize a bunch of path methods.
1183         -Avoid doing multiple disk accesses per line.
1184         -Parse the skipped list directly instead of turning it into a test_expecations.txt
1185         formatting string and parsing that.
1186
1187         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1188         (TestExpectationParser):
1189         (TestExpectationParser.parse_skipped_tests):
1190         (TestExpectationParser._parse_line):
1191         (TestExpectationParser._collect_matching_tests):
1192         (TestExpectations.__init__):
1193         (TestExpectations._add_skipped_tests):
1194         * Scripts/webkitpy/layout_tests/port/base.py:
1195         (Port):
1196         (Port.test_isfile):
1197         (Port.normalize_test_name):
1198         (Port.layout_tests_dir):
1199         (Port.abspath_for_test):
1200
1201 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1202
1203         Only store the SVN revision in the summarized results if we're on a builder
1204         https://bugs.webkit.org/show_bug.cgi?id=76976
1205
1206         Reviewed by Dirk Pranke.
1207
1208         This shaves another ~130ms off the single test run-webkit-tests runtime.
1209
1210         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1211         (summarize_results):
1212         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1213         (ResultSummaryTest.get_result):
1214         (ResultSummaryTest):
1215         (ResultSummaryTest.get_result_summary):
1216         (ResultSummaryTest.get_unexpected_results):
1217         (ResultSummaryTest.test_no_svn_revision):
1218         (ResultSummaryTest.test_svn_revision):
1219         * Scripts/webkitpy/layout_tests/port/base.py:
1220         (Port.use_trac_links_in_results_html):
1221
1222 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
1223
1224         [Qt][WK2] fast/loader tests failed after r94178
1225         https://bugs.webkit.org/show_bug.cgi?id=67388
1226
1227         Reviewed by Simon Hausmann.
1228
1229         Applying the same fix used for Qt-WebKit1 from bug #67254 -
1230         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1231         https://bugs.webkit.org/show_bug.cgi?id=67254
1232         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1233         derived from the running location of DumpRenderTree binary.
1234
1235         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1236         (WTR::LayoutTestController::pathToLocalResource):
1237
1238 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1239
1240         Implement overridePreference for boolean preferences in WebKitTestRunner
1241         https://bugs.webkit.org/show_bug.cgi?id=77033
1242
1243         Reviewed by Alexey Proskuryakov.
1244
1245         For now overridePreference supports boolean values.
1246
1247         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1248         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1249         (WTR::LayoutTestController::setXSSAuditorEnabled):
1250         (WTR::LayoutTestController::overridePreference):
1251         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1252         * WebKitTestRunner/TestController.cpp:
1253         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
1254         explicitly and properly disable the use of PageCache when resetting the
1255         state. Tests that use PageCache can now enable it via overridePreference.
1256
1257 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1258
1259         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
1260         https://bugs.webkit.org/show_bug.cgi?id=77100
1261
1262         Reviewed by Simon Hausmann.
1263
1264         This patch makes the MiniBrowser read multiple URL's from the command
1265         line such that there will be one browser window opened for each URL.
1266
1267         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1268         (MiniBrowserApplication::handleUserOptions):
1269
1270 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1271
1272         [Qt] The Qt MiniBrowser crashes when given multiple URL's
1273         https://bugs.webkit.org/show_bug.cgi?id=77009
1274
1275         Reviewed by Simon Hausmann.
1276
1277         This patch fixes a crash in BrowserWindow::newWindow() where a
1278         BrowserWindow-object is constructed with a 0 pointer as the
1279         WindowOptions parameter which leads to a crash.
1280
1281         * MiniBrowser/qt/BrowserWindow.cpp:
1282         (BrowserWindow::BrowserWindow):
1283         (BrowserWindow::newWindow):
1284         * MiniBrowser/qt/BrowserWindow.h:
1285
1286 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1287
1288         [Qt] Use ICU if available
1289         https://bugs.webkit.org/show_bug.cgi?id=76821
1290
1291         Reviewed by Simon Hausmann.
1292
1293         Adding unicode defines for a Qt 5 based build.
1294
1295         * qmake/mkspecs/features/features.prf:
1296
1297 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1298
1299         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
1300         https://bugs.webkit.org/show_bug.cgi?id=42545
1301
1302         Reviewed by Zoltan Herczeg.
1303
1304         Implement the setGeolocationPermission method.
1305
1306         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1307         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1308         (WTR::LayoutTestController::setGeolocationPermission):
1309         (WTR):
1310         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1311         (LayoutTestController):
1312
1313 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
1314
1315         [NRWT] Support --ignore-metrics
1316         https://bugs.webkit.org/show_bug.cgi?id=76278
1317
1318         Reviewed by Tony Chang.
1319
1320         Port the feature from ORWT.
1321
1322         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1323         (SingleTestRunner._run_compare_test):
1324         * Scripts/webkitpy/layout_tests/port/driver.py:
1325         (DriverOutput):
1326         (DriverOutput.strip_metrics):
1327         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1328         (DriverOutputTest):
1329         (DriverOutputTest.test_strip_metrics):
1330         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1331         (_set_up_derived_options):
1332         (parse_args):
1333
1334 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1335
1336         Unreviewed, rolling out r105935 and r105954.
1337         http://trac.webkit.org/changeset/105935
1338         http://trac.webkit.org/changeset/105954
1339         https://bugs.webkit.org/show_bug.cgi?id=77080
1340
1341         test-webkitpy is still broken (Requested by abarth on
1342         #webkit).
1343
1344         * Scripts/test-webkitpy:
1345         * Scripts/webkitpy/common/system/executive_unittest.py:
1346         (never_ending_command):
1347         (ExecutiveTest.test_run_command_args_type):
1348         (ExecutiveTest.test_run_command_with_unicode):
1349         (ExecutiveTest.test_running_pids):
1350         * Scripts/webkitpy/common/system/fileutils.py:
1351         (make_stdout_binary):
1352         * Scripts/webkitpy/test/cat.py:
1353         (command_arguments):
1354         (main):
1355         * Scripts/webkitpy/test/cat_unittest.py:
1356         (CatTest):
1357         (CatTest.assert_cat):
1358         (CatTest.test_basic):
1359         (CatTest.test_no_newline):
1360         (CatTest.test_unicode):
1361         (CatTest.test_as_command):
1362         * Scripts/webkitpy/test/echo.py:
1363         (command_arguments):
1364         (main):
1365         * Scripts/webkitpy/test/echo_unittest.py:
1366         (EchoTest):
1367         (EchoTest.test_basic):
1368         (EchoTest.test_no_newline):
1369         (EchoTest.test_unicode):
1370         (EchoTest.test_argument_order):
1371         (EchoTest.test_empty_arguments):
1372         (EchoTest.test_no_arguments):
1373         (EchoTest.test_as_command):
1374
1375 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
1376
1377         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
1378         https://bugs.webkit.org/show_bug.cgi?id=76138
1379
1380         Reviewed by Martin Robinson.
1381
1382         * Scripts/webkitdirs.pm:
1383         (isCrossCompilation):
1384         (buildAutotoolsProject):
1385
1386 2012-01-25  Adam Barth  <abarth@webkit.org>
1387
1388         Kentaro is a reviewer now.  Yay!
1389
1390         * Scripts/webkitpy/common/config/committers.py:
1391
1392 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1393
1394         nrwt: running w/ no arguments fails
1395         https://bugs.webkit.org/show_bug.cgi?id=77064
1396
1397         Unreviewed, build fix.
1398
1399         This change fixes a regression introduced in r105944
1400         where running without --platform <foo> or one of the other
1401         platform switches would cause a null deref :(.
1402
1403         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1404         (main):
1405
1406 2012-01-25  Eric Seidel  <eric@webkit.org>
1407
1408         Automatically CC someone from Apple on any changes to Obj-C public API
1409         https://bugs.webkit.org/show_bug.cgi?id=77053
1410
1411         Reviewed by Timothy Hatcher.
1412
1413         This has long been de-facto practice, seems now that we have
1414         fancy watchlist support, we should just make the tools
1415         do this automatically.
1416
1417         * Scripts/webkitpy/common/config/watchlist:
1418
1419 2012-01-25  Antoine Labour  <piman@chromium.org>
1420
1421         Updating status in committers.py.
1422
1423         Unreviewed.
1424
1425         * Scripts/webkitpy/common/config/committers.py:
1426
1427 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1428
1429         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
1430         https://bugs.webkit.org/show_bug.cgi?id=77058
1431
1432         Reviewed by Eric Seidel.
1433
1434         r105935 broke executive_unittest by changing which script we
1435         were running and not ensuring that the PYTHONPATH was set up
1436         properly.
1437
1438         This change also fixes a regression introduced recently where
1439         test-webkitpy wasn't figuring out the path to Tools/Scripts
1440         right, either (so running ./test-webkitpy would fail).
1441
1442         * Scripts/test-webkitpy:
1443         * Scripts/webkitpy/common/system/executive_unittest.py:
1444         (script_dir):
1445         (ExecutiveTest.setUp):
1446         (ExecutiveTest):
1447         (ExecutiveTest.tearDown):
1448
1449 2012-01-25  Adam Barth  <abarth@webkit.org>
1450
1451         Disable tests on the mac-ews while we sort out hte stability issues.
1452
1453         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1454         (MacEWS):
1455
1456 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1457
1458         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
1459         https://bugs.webkit.org/show_bug.cgi?id=76475
1460
1461         Reviewed by Eric Seidel.
1462
1463         This patch cleans up the internal usage of port names for the
1464         Apple mac and Apple win ports so that 'mac' and 'win are never
1465         considered "fully specified" port names: they are still legal
1466         input to the PortFactory.get() routine, but only if run on the given
1467         platform (i.e. trying to PortFactory.get('mac') on windows or
1468         linux will return an error, since we don't know which version of
1469         the port is desired.
1470
1471         This also cleans up handling of the webkit2 variants, so that
1472         the full port names consistently follow the
1473         <operating_system>-<version>[-<wk2>] convention.
1474
1475         Lastly this patch adds some assertions and removes some
1476         try/catch logic to catch more programming and usage errors;
1477         previously mac-tiger might've been allowed -- and it would've
1478         translated into using just the baselines in platform/mac -- but
1479         now it should fail.
1480
1481         * Scripts/webkitpy/layout_tests/port/apple.py:
1482         (ApplePort.determine_full_port_name):
1483         (ApplePort.__init__):
1484         (ApplePort):
1485         (ApplePort._port_name_with_version):
1486         * Scripts/webkitpy/layout_tests/port/builders.py:
1487         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1488         (FactoryTest.test_mac):
1489         (FactoryTest.test_win):
1490         * Scripts/webkitpy/layout_tests/port/mac.py:
1491         (MacPort.baseline_search_path):
1492         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1493         (MacTest.test_versions):
1494         * Scripts/webkitpy/layout_tests/port/win.py:
1495         (WinPort.baseline_search_path):
1496         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1497         (WinTest.test_versions):
1498
1499 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1500
1501         webkitpy: print nicer errors while linting expectations files, remove redundant tests
1502         https://bugs.webkit.org/show_bug.cgi?id=76955
1503
1504         Reviewed by Adam Barth.
1505
1506         This change cleans up the errors that are printed so that the
1507         are more "quickfix" compatible (path:lineno).
1508
1509         Also, there were a bunch of redundant tests between
1510         layout_tests.models.test_expectations_unittest and
1511         style.checkers.test_expectations_unittest. The latter should
1512         just expect the former to do most of the testing.
1513
1514         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1515         (TestExpectationParser._parse_modifiers):
1516         (TestExpectations._report_errors):
1517         (TestExpectations._add_skipped_tests):
1518         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1519         (test_parse_error_nonfatal):
1520         (SemanticTests.test_bad_bugid):
1521         * Scripts/webkitpy/style/checkers/test_expectations.py:
1522         (TestExpectationsChecker.__init__):
1523         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1524         (TestExpectationsTestCase.assert_lines_lint):
1525         (TestExpectationsTestCase.test_valid_expectations):
1526         (TestExpectationsTestCase.test_invalid_expectations):
1527         (TestExpectationsTestCase.test_tab):
1528
1529 2012-01-25  Eric Seidel  <eric@webkit.org>
1530
1531         webkit-patch apply-* should always continue after failures
1532         https://bugs.webkit.org/show_bug.cgi?id=77057
1533
1534         Reviewed by Adam Barth.
1535
1536         As far as I can tell there is only one potential drawback to always
1537         forcing: that if you're somehow in the wrong directory it will create new
1538         directories for new files.  Since webkit-patch always cd's to the root
1539         it seems that's not a drawback.  The drawback of not using --force for
1540         svn-apply, is that it will stop after the first failure, which is rarely
1541         (if ever) the desired behavior.  This just removes the force option
1542         (which was strangely hidden behind --non-interactive).  This should
1543         make for a better user experiance.
1544
1545         * Scripts/webkitpy/common/checkout/checkout.py:
1546         (Checkout.apply_patch):
1547         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1548         (MockCheckout.apply_patch):
1549         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1550         (CheckoutTest.test_chromium_deps):
1551         (CheckoutTest):
1552         (CheckoutTest.test_apply_patch):
1553         * Scripts/webkitpy/tool/commands/download_unittest.py:
1554         (DownloadCommandsTest._default_options):
1555         * Scripts/webkitpy/tool/steps/applypatch.py:
1556         (ApplyPatch.options):
1557         (ApplyPatch.run):
1558         * Scripts/webkitpy/tool/steps/options.py:
1559         (Options):
1560
1561 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1562
1563         nrwt: should be able to run --platform test interactively
1564         https://bugs.webkit.org/show_bug.cgi?id=76959
1565
1566         Reviewed by Adam Barth.
1567
1568         As part of refactoring the Port interfaces, in r103254 I made
1569         passing a Host object to the Port mandatory; previously TestPort
1570         objects would create their own (mock) hosts. However,
1571         new-run-webkit-tests always passed a real Host, not a MockHost,
1572         and so you couldn't run new-run-webkit-tests --platform test
1573         interactively to debug test failures.
1574
1575         This change fixes that by creating a MockHost instead of a real
1576         host if you say --platform test*.
1577
1578         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1579         (main):
1580
1581 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1582
1583         run-webkit-tests --lint-test-files should lint all the ports by default
1584         https://bugs.webkit.org/show_bug.cgi?id=76749
1585
1586         Reviewed by Ojan Vafai.
1587
1588         Currently run-webkit-tests --lint-test-files will only lint the
1589         test_expectations for the single port determined by the command
1590         line options. This is not obvious and can produce unintended results
1591         if you want to lint the chromium port (probably the normal case
1592         for using --lint-test-files) but don't specify a port name or
1593         --chromium.
1594
1595         I think we should probably lint *all* of the ports if no port
1596         name is supplied. This change implements that, and also moves
1597         the linting logic out of the Manager class, since this really
1598         has nothing to do with Managers. It has little to do with
1599         run-webkit-tests, but splitting it into a different script would
1600         introduce compatibility issues. It might make sense to do that
1601         anyway, in a separate patch and combining that with cleaning up
1602         the style checker to share more code.
1603
1604         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1605         (Manager._strip_test_dir_prefix):
1606         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1607         (lint):
1608         (run):
1609         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1610         (LintTest.test_all_configurations): added.
1611         (LintTest.test_lint_test_files): added.
1612         (LintTest.test_lint_test_files__errors): added.
1613         (MainTest.test_lint_test_files): removed.
1614         (MainTest.test_lint_test_files__errors): removed.
1615
1616 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1617
1618         webkitpy: clean up a bunch of test scaffolding
1619         https://bugs.webkit.org/show_bug.cgi?id=76973
1620
1621         Reviewed by Eric Seidel.
1622
1623         There were several helper modules in the webkitpy.test package
1624         that appear to only be used by executive_unittest.py. I am
1625         rolling them all into that file to make that clearer.
1626
1627         * Scripts/webkitpy/common/system/executive_unittest.py:
1628         (ExecutiveTest.test_run_command_args_type):
1629         (ExecutiveTest.test_run_command_with_unicode):
1630         (ExecutiveTest.test_running_pids):
1631         (command_line):
1632         (main):
1633         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1634         * Scripts/webkitpy/test/cat.py: Removed.
1635         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1636         * Scripts/webkitpy/test/echo.py: Removed.
1637         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1638
1639 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1640
1641         webkitpy: clean up a bunch of test scaffolding
1642         https://bugs.webkit.org/show_bug.cgi?id=76973
1643
1644         Reviewed by Eric Seidel.
1645
1646         There were several helper modules in the webkitpy.test package
1647         that appear to only be used by executive_unittest.py. I am
1648         rolling them all into that file to make that clearer.
1649
1650         * Scripts/webkitpy/common/system/executive_unittest.py:
1651         (ExecutiveTest.test_run_command_args_type):
1652         (ExecutiveTest.test_run_command_with_unicode):
1653         (ExecutiveTest.test_running_pids):
1654         (command_line):
1655         (main):
1656         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1657         * Scripts/webkitpy/test/cat.py: Removed.
1658         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1659         * Scripts/webkitpy/test/echo.py: Removed.
1660         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1661
1662 2012-01-25  Eric Seidel  <eric@webkit.org>
1663
1664         Remove Python 2.5 support from WebKit
1665         https://bugs.webkit.org/show_bug.cgi?id=71593
1666
1667         Reviewed by Adam Barth.
1668
1669         Just removing support from this one core file.
1670         I'll commit the rest of the (large) change once we've
1671         gone 24 hours and seen that no bots have exploded.
1672         We can roll out this one change if we break bots
1673         and then roll in the rest once those bots are fixed.
1674
1675         * Scripts/webkitpy/common/system/executive.py:
1676         (Executive.cpu_count):
1677
1678 2012-01-25  Hajime Morita  <morrita@google.com>
1679
1680         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
1681         https://bugs.webkit.org/show_bug.cgi?id=76863
1682
1683         Reviewed by Dimitri Glazkov.
1684
1685         Added a feature flag.
1686
1687         * Scripts/build-webkit:
1688         * qmake/mkspecs/features/features.prf:
1689
1690 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
1691
1692         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
1693         https://bugs.webkit.org/show_bug.cgi?id=76344
1694
1695         Reviewed by Sam Weinig.
1696
1697         Add a test verifying that the mouse button during policy decisions for
1698         events not triggered by mouse events is NoButton.
1699
1700         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1701         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
1702         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
1703
1704 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1705
1706         run-perf-tests should timeout sooner
1707         https://bugs.webkit.org/show_bug.cgi?id=77026
1708
1709         Reviewed by Adam Barth.
1710
1711         Bump off the timeout from 10 minutes to 4 minutes.
1712
1713         Also use float instead of str in test result values to compress the size of json files bots upload.
1714
1715         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1716         (PerfTestsRunner._parse_args):
1717         (PerfTestsRunner._process_chromium_style_test_result):
1718         (PerfTestsRunner._process_parser_test_result):
1719         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1720         (test_run_test_set_for_parser_tests):
1721         (test_run_test_set_with_json_output):
1722         (test_run_test_set_with_json_source):
1723
1724 2012-01-25  Enrica Casucci  <enrica@apple.com>
1725
1726         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
1727         https://bugs.webkit.org/show_bug.cgi?id=76951
1728         <rdar://problem/9325158>
1729
1730         Reviewed by Alexey Proskuryakov.
1731
1732         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
1733         and WebHTMLView.
1734         (TestWebKitAPI::TEST):
1735
1736 2012-01-23  MORITA Hajime  <morrita@google.com>
1737
1738         [Refactoring][Internals] Should have InternalSettings
1739         https://bugs.webkit.org/show_bug.cgi?id=76424
1740
1741         Reviewed by Kent Tamura.
1742
1743         * GNUmakefile.am: Added so new files.
1744
1745 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
1746
1747         webkitpy: new-run-webkit-websocket is broken
1748         https://bugs.webkit.org/show_bug.cgi?id=76999
1749
1750         Reviewed by Dirk Pranke.
1751
1752         r105674 broke new-run-webkit-websocket, since options.chromium
1753         doesn't exist any more. new-run-webkit-httpd was also broken
1754         and already fixed at r105835.
1755         * Scripts/new-run-webkit-websocketserver:
1756         (main):
1757
1758 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1759
1760         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
1761         https://bugs.webkit.org/show_bug.cgi?id=63458
1762
1763         Reviewed by Adam Roben.
1764
1765         Implement the setPopupBlockingEnabled method.
1766
1767         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1768         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1769         (WTR::LayoutTestController::setPopupBlockingEnabled):
1770         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1771
1772 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
1773
1774         [Qt] Cleanup testfonts handling
1775         https://bugs.webkit.org/show_bug.cgi?id=76068
1776
1777         Reviewed by Simon Hausmann.
1778
1779         Factor test font initialization into it's own file  so test
1780         font users can share the implementation by adding the file
1781         to their build.
1782         Use fonts.conf from the test font directory to not require the
1783         current directory to be the WebKit root.
1784         Fix the -use-test-fonts option of QtTestBrowser by initializing
1785         the fonts earlier, before it is too late (namely before calling
1786         show on the main window).
1787
1788         * DumpRenderTree/qt/DumpRenderTree.pro:
1789         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1790         (WebCore::DumpRenderTree::open):
1791         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1792         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
1793         (WebKit::initializeTestFonts):
1794         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
1795         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
1796         we will use the one from the test fonts directory.
1797         * DumpRenderTree/qt/main.cpp:
1798         (main): Fix the ifdefs to make it clear that the code to
1799         set up the Dpi has not been ported to Qt5 yet.
1800         * QtTestBrowser/QtTestBrowser.pro:
1801         * QtTestBrowser/launcherwindow.h:
1802         (WindowOptions::WindowOptions):
1803         * QtTestBrowser/main.cpp:
1804         (launcherMain):
1805         (LauncherApplication::handleUserOptions):
1806         * WebKitTestRunner/InjectedBundle/Target.pri:
1807         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1808         (WTR::activateFonts): Remove the code to set up the Dpi
1809         because it does not work with Qt5.
1810
1811 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
1812
1813         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
1814
1815         Reviewed by Tor Arne Vestø.
1816
1817         Don't require it by making svnRevisionForDirectory return "unknown"
1818         instead of bailing out with an error.
1819
1820         * Scripts/VCSUtils.pm:
1821         (svnRevisionForDirectory):
1822
1823 2012-01-25  Adam Barth  <abarth@webkit.org>
1824
1825         Temporarily disable running the unit tests on the Chromium EWS.  These
1826         tests don't work properly (see
1827         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
1828         blocking the EWS.
1829
1830         * Scripts/webkitpy/common/config/ports.py:
1831         (ChromiumPort):
1832
1833 2012-01-25  Adam Barth  <abarth@webkit.org>
1834
1835         Update results.html version of PixelZoomer
1836         https://bugs.webkit.org/show_bug.cgi?id=76965
1837
1838         Reviewed by Ojan Vafai.
1839
1840         Improve readability as suggested by Ojan.
1841
1842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
1843
1844 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1845
1846         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
1847         https://bugs.webkit.org/show_bug.cgi?id=76899
1848
1849         Reviewed by Martin Robinson.
1850
1851         * gtk/generate-gtkdoc:
1852         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
1853         WebKitLoaderClient.
1854
1855 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1856
1857         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
1858
1859         * BuildSlaveSupport/build.webkit.org-config/config.json:
1860
1861 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
1862
1863         WebKit needs public performance tests running on public bots
1864         https://bugs.webkit.org/show_bug.cgi?id=10266
1865
1866         Reviewed by Adam Barth.
1867
1868         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
1869         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
1870
1871         * BuildSlaveSupport/build.webkit.org-config/config.json:
1872         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1873         (RunAndUploadPerfTests):
1874         (RunAndUploadPerfTests.start):
1875         (UploadPerfTestResults):
1876         (BuildAndPerfTestFactory):
1877         (BuildAndPerfTestFactory.__init__):
1878
1879 2012-01-24  Ojan Vafai  <ojan@chromium.org>
1880
1881         Initializing the browser property of the Bugzilla class takes too long
1882         https://bugs.webkit.org/show_bug.cgi?id=76960
1883
1884         Reviewed by Adam Barth.
1885
1886         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
1887         on my Mac Pro.
1888
1889         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1890         (Bugzilla.__init__):
1891         (Bugzilla._get_browser):
1892         (Bugzilla):
1893         (Bugzilla._set_browser):
1894
1895 2012-01-24  Mark Rowe  <mrowe@apple.com>
1896
1897         Death to JavaScriptGlue.
1898
1899         Rubber-stamped by Geoffrey Garen.
1900
1901         * BuildSlaveSupport/build-launcher-app:
1902         (copyNightlyLauncher):
1903         * Scripts/build-webkit:
1904         * Scripts/do-file-rename:
1905         * Scripts/do-webcore-rename:
1906         * Scripts/webkitpy/common/config/build.py:
1907         (_should_file_trigger_build):
1908         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
1909         path in conjunction with a cross-platform path.
1910         (ShouldBuildTest):
1911
1912 2012-01-24  Kentaro Hara  <haraken@chromium.org>
1913
1914         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
1915         https://bugs.webkit.org/show_bug.cgi?id=75836
1916
1917         Reviewed by David Kilzer.
1918
1919         Previously parser_unittests.pl can just test the returned value of
1920         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
1921         parser_unittests.pl so that it also tests the stdout and stderr of
1922         get_function_line_ranges().
1923
1924         This patch adds css_unittests_warning.css, which contains test cases
1925         for warning messages of the CSS parser of prepare-ChangeLog.
1926
1927         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1928         (captureOutput): Captures the stdout and stderr of a given method.
1929         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
1930         string to relative paths.
1931
1932         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
1933         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
1934         (element1):
1935         (element2):
1936         (element3):
1937         (element4):
1938         ():
1939         (element5):
1940         (element6):
1941
1942         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1943         Just updated the test results, i.e. added stdout and stderr results.
1944         No essential changes in the test results.
1945         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
1946         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
1947         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
1948         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
1949         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
1950
1951 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
1952
1953         webkitpy: new-run-webkit-httpd is broken
1954         https://bugs.webkit.org/show_bug.cgi?id=76963
1955
1956         Reviewed by Adam Barth.
1957
1958         r105674 broke new-run-webkit-httpd, since options.chromium
1959         doesn't exist any more. We didn't catch this because we don't
1960         run the integration tests by default anywhere :(.
1961
1962         * Scripts/new-run-webkit-httpd:
1963         (run):
1964         (main):
1965
1966 2012-01-24  Adam Barth  <abarth@webkit.org>
1967
1968         garden-o-matic pixel zoomer should let you look at every pixel of the image
1969         https://bugs.webkit.org/show_bug.cgi?id=76962
1970
1971         Reviewed by Ojan Vafai.
1972
1973         Previously, you couldn't get up to the right and bottom pixels.
1974
1975         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
1976
1977 2012-01-24  Enrica Casucci  <enrica@apple.com>
1978
1979         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
1980         https://bugs.webkit.org/show_bug.cgi?id=76951
1981         <rdar://problem/9325158>
1982
1983         Added test to verify that WebHTMLView supports the typingAttributes method and that it
1984         works as expected.
1985         
1986         Reviewed by Alexey Proskuryakov.
1987
1988         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1989         (TestWebKitAPI::TEST):
1990
1991 2012-01-24  James Robinson  <jamesr@chromium.org>
1992
1993         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
1994         https://bugs.webkit.org/show_bug.cgi?id=76884
1995
1996         Reviewed by Adam Barth.
1997
1998         * Scripts/webkitpy/tool/bot/irc_command.py:
1999         (Rollout.execute):
2000         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2001         (SheriffIRCBotTest.test_rollout):
2002         (SheriffIRCBotTest.test_revert):
2003         (SheriffIRCBotTest.test_multi_rollout):
2004         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
2005         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2006         (SheriffIRCBotTest.test_rollout_invalidate_reason):
2007         (test_multi_rollout_invalidate_reason):
2008
2009 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2010
2011         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
2012         https://bugs.webkit.org/show_bug.cgi?id=75531
2013
2014         Reviewed by David Kilzer.
2015
2016         Previously, the cpp parser of prepare-ChangeLog could not detect a change
2017         outside methods. Consider the following cpp file.
2018
2019             namespace N {
2020             int a;     // this change does not appear on ChangeLog.
2021             class C {
2022                 int b;     // this change does not appear on ChangeLog.
2023                 void f()
2024                 {
2025                     int c;     // this change appears on ChangeLog.
2026                 }
2027                 int d;     // this change does not appear on ChangeLog.
2028             };
2029             int e;     // this change does not appear on ChangeLog.
2030             };
2031
2032         The previous prepare-ChangeLog outputs just methods in which a change is found:
2033             (N::C::f):
2034
2035         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
2036         and methods in which a change is found:
2037             (N):
2038             (N::C):
2039             (N::C::f):
2040
2041         * Scripts/prepare-ChangeLog:
2042         (get_function_line_ranges_for_cpp): Modified as described above.
2043
2044         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
2045         (Class104):
2046         (Class105):
2047         (Class106):
2048         (Class106::func32):
2049         (Class106::func33):
2050         (NameSpace3):
2051         (NameSpace4):
2052         (NameSpace5):
2053         (NameSpace6):
2054         (Class107):
2055         (NameSpace5::NameSpace6::Class107::func34):
2056         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2057
2058 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2059
2060         prepare-ChangeLog outputs warnings for top-level { ... } blocks
2061         https://bugs.webkit.org/show_bug.cgi?id=75943
2062
2063         Reviewed by David Kilzer.
2064
2065         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
2066         because it does not distinguish '}' at the end of a subroutine
2067         with '}' at the end of a if or for statement.
2068
2069         foo.pl:
2070             if (1) {
2071             }
2072             for (@v) {
2073             }
2074
2075         output:
2076             nested functions found at top-level at foo.pl:2
2077             nested functions found at top-level at foo.pl:4
2078
2079         This patch fixes the bug.
2080
2081         * Scripts/prepare-ChangeLog:
2082         (get_function_line_ranges_for_perl):
2083         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2084         Added test cases. No change in the test results.
2085
2086 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2087
2088         r105674 broke check-webkit-style for chromium's test_expectations.
2089
2090         Unreviewed, build fix.
2091         
2092         We now need to pass in a platform name of 'chromium' if we want
2093         the chromium port; options.chromium is no longer recognized. I
2094         will follow this patch up with a separate patch that has a test,
2095         but this at least fixes the build.
2096
2097         * Scripts/webkitpy/style/checkers/test_expectations.py:
2098         (TestExpectationsChecker._determine_port_from_exepectations_path):
2099
2100 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2101
2102         check-webkit-style of the chromium test_expectations.txt file takes too long
2103         https://bugs.webkit.org/show_bug.cgi?id=76745
2104
2105         Reviewed by Dimitri Glazkov.
2106
2107         When in lint mode, have TestExpectations test all configurations instead
2108         of looping over each configuration. This also has the benefit of making
2109         the error output considerably more concise.
2110
2111         Also, got rid of the double-printing of errors when linting through check-webkit-style.
2112
2113         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2114         (Manager.lint):
2115         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2116         (TestExpectations._report_errors):
2117         (TestExpectations._add_expectations):
2118         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2119         (test_parse_error_nonfatal):
2120         (test_error_on_different_platform):
2121         * Scripts/webkitpy/style/checkers/test_expectations.py:
2122         (TestExpectationsChecker.check_test_expectations):
2123         (TestExpectationsChecker.check):
2124         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2125         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
2126         (TestExpectationsTestCase.assert_lines_lint):
2127
2128 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2129
2130         Another build fix attempt after r105543.
2131
2132         * Scripts/webkitpy/common/net/file_uploader.py:
2133         (FileUploader.upload_as_multipart_form_data):
2134
2135 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2136
2137         Build fix attempt after r105543.
2138
2139         * Scripts/webkitpy/common/net/file_uploader.py:
2140         (FileUploader.upload_as_multipart_form_data):
2141
2142 2012-01-24  Vincent Scheib  <scheib@chromium.org>
2143
2144         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
2145         https://bugs.webkit.org/show_bug.cgi?id=76411
2146
2147         Reviewed by Adam Barth.
2148
2149         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
2150         into a series of patches, this change adds a trivial
2151         pointer lock implementation to the Chromium port's DumpRenderTree
2152         and exposes LayoutTestController hooks to force failure conditions.
2153
2154         * DumpRenderTree/chromium/LayoutTestController.cpp:
2155         (LayoutTestController::LayoutTestController):
2156         (LayoutTestController::didLosePointerLock):
2157         (LayoutTestController::setPointerLockWillFailAsynchronously):
2158         (LayoutTestController::setPointerLockWillFailSynchronously):
2159         * DumpRenderTree/chromium/LayoutTestController.h:
2160         * DumpRenderTree/chromium/WebViewHost.cpp:
2161         (WebViewHost::requestPointerLock):
2162         (WebViewHost::requestPointerUnlock):
2163         (WebViewHost::isPointerLocked):
2164         (WebViewHost::didCompletePointerLock):
2165         (WebViewHost::didNotCompletePointerLock):
2166         (WebViewHost::didLosePointerLock):
2167         (WebViewHost::reset):
2168         * DumpRenderTree/chromium/WebViewHost.h:
2169         (WebViewHost::setPointerLockWillFailAsynchronously):
2170         (WebViewHost::setPointerLockWillFailSynchronously):
2171
2172 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
2173
2174         Unreviewed, skip WK2 API test timing out on some GTK bots.
2175
2176         WebKit2APITests/TestDownloads is consistently timing out on the
2177         32bit release and 64bit debug bots.
2178
2179         * Scripts/run-gtk-tests:
2180         (TestRunner): Skip WebKit2APITests/TestDownloads.
2181
2182 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2183
2184         [Qt] Fix the build with the newes Qt5 hashes
2185         https://bugs.webkit.org/show_bug.cgi?id=76657
2186
2187         Reviewed by Simon Hausmann.
2188
2189         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2190         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
2191         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
2192
2193 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2194
2195         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
2196
2197         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
2198         building with MinGW inside cmd.exe will require the same construct. Instead
2199         we assume that when the first character in PWD is a '/' we're running under
2200         Cygwin, and use the normal unix way of setting environment variables.
2201
2202         Reviewed by Simon Hausmann.
2203
2204         * qmake/mkspecs/features/default_pre.prf:
2205
2206 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
2207
2208         Some qmake build files must include Qt5's "quick" module.
2209         https://bugs.webkit.org/show_bug.cgi?id=76671
2210
2211         Unreviewed build fix.
2212
2213         * MiniBrowser/qt/MiniBrowser.pro:
2214         * WebKitTestRunner/Target.pri:
2215
2216 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2217
2218         [Qt] Fix the event timestamps for touch mocking
2219
2220         Reviewed by Simon Hausmann.
2221
2222         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2223         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
2224         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
2225
2226 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2227
2228         [GTK] Implement DownloadClient in WebKit2 GTK+ API
2229         https://bugs.webkit.org/show_bug.cgi?id=72952
2230
2231         Reviewed by Martin Robinson.
2232
2233         * gtk/generate-gtkdoc:
2234         (get_webkit2_options): Ignore WebKitDownloadClient.
2235
2236 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
2237
2238         [GTK] editing/deleting/5408255.html results are incorrect
2239         https://bugs.webkit.org/show_bug.cgi?id=53644
2240
2241         Reviewed by Martin Robinson.
2242
2243         WEBKIT_TOP_LEVEL environment variable is now set directly in either
2244         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
2245         macro. This way both tools can be run outside the test harness without
2246         the need to manually set the environment variable.
2247
2248         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2249         (getTopLevelPath):
2250         * GNUmakefile.am:
2251         * Scripts/webkitpy/layout_tests/port/gtk.py:
2252         (GtkPort.setup_environ_for_server):
2253         * WebKitTestRunner/GNUmakefile.am:
2254         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2255         (WTR::InjectedBundle::platformInitialize):
2256
2257 2012-01-23  Dmitry Lomov  <dslomov@google.com>
2258
2259         [Chromium] Implement layoutTestController.workerThreadCount in DRT
2260         https://bugs.webkit.org/show_bug.cgi?id=74653.
2261
2262         Reviewed by Darin Fisher.
2263
2264         * DumpRenderTree/chromium/LayoutTestController.cpp:
2265         (LayoutTestController::LayoutTestController):
2266         (LayoutTestController::workerThreadCount):
2267         * DumpRenderTree/chromium/LayoutTestController.h:
2268
2269 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2270
2271         nrwt: make --chromium work like --qt
2272         https://bugs.webkit.org/show_bug.cgi?id=76875
2273
2274         Reviewed by Adam Barth.
2275
2276         --chromium used to have to be handled differently from --qt
2277         due to the way the PortFactory was implemented; there's not
2278         really a good reason for that any more so this patch makes
2279         things slightly more consistent and eliminates the
2280         options.chromium flag (--chromium is now truly a synonym for
2281         --platform chromium).
2282
2283         * Scripts/webkitpy/layout_tests/port/factory.py:
2284         (PortFactory._default_port):
2285         (PortFactory.get):
2286         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2287         (FactoryTest.setUp):
2288         (FactoryTest.test_chromium_mac):
2289         (FactoryTest.test_chromium_linux):
2290         (FactoryTest.test_chromium_win):
2291         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2292         (parse_args):
2293
2294 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2295
2296         run-webkit-tests needs to propagate --chromium
2297         https://bugs.webkit.org/show_bug.cgi?id=76870
2298
2299         Reviewed by Eric Seidel.
2300
2301         run-webkit-tests removes '--chromium' argument from @ARGV when
2302         determining which port to run, which means that that doesn't
2303         propagate to new-run-webkit-tests. That's bad (and is handled
2304         for the other ports by re-adding the flag, but apparently we're
2305         just now noticing for Chromium).
2306
2307         * Scripts/run-webkit-tests:
2308
2309 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
2310
2311         More build fixing after r105646.
2312
2313         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2314         (TestWebKitAPI::TestNode::key):
2315
2316 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
2317
2318         Unreviewed build fix - r105646 broke this.
2319
2320         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2321         (TestWebKitAPI::TestNode::TestNode):
2322         (TestWebKitAPI::TestNode::key):
2323         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
2324         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
2325         (TestWebKitAPI::RedBlackTreeTest::testDriver):
2326
2327 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2328
2329         Unreviewed, rolling out r105658.
2330         http://trac.webkit.org/changeset/105658
2331         https://bugs.webkit.org/show_bug.cgi?id=76883
2332
2333         We want this eventually, but not right at this moment
2334         (Requested by abarth on #webkit).
2335
2336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2337
2338 2012-01-23  Adam Barth  <abarth@webkit.org>
2339
2340         garden-o-matic should support Chromium Mac Lion
2341         https://bugs.webkit.org/show_bug.cgi?id=76880
2342
2343         Reviewed by Eric Seidel.
2344
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2346
2347 2012-01-23  Emil A Eklund  <eae@chromium.org>
2348
2349         check-webkit-style whitespace/operators triggers on overloaded division operator
2350         https://bugs.webkit.org/show_bug.cgi?id=76650
2351
2352         Reviewed by Darin Adler.
2353
2354         * Scripts/webkitpy/style/checkers/cpp.py:
2355         (check_spacing):
2356         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2357         (CppStyleTest.test_operator_methods):
2358
2359 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2360
2361         run-perf-tests should report server-side errors
2362         https://bugs.webkit.org/show_bug.cgi?id=76802
2363
2364         Reviewed by Tony Chang.
2365
2366         Report errors whenever server's response doesn't match "OK".
2367
2368         * Scripts/webkitpy/common/net/file_uploader.py:
2369         (FileUploader.upload_single_text_file):
2370         (FileUploader.upload_as_multipart_form_data):
2371         (FileUploader._upload_data.callback):
2372         (FileUploader):
2373         (FileUploader._upload_data):
2374         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2375         (PerfTestsRunner._upload_json):
2376         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2377         (test_upload_json):
2378         (test_upload_json.MockFileUploader.upload_single_text_file):
2379
2380 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2381
2382         run-perf-tests ignore Skipped list on chromium
2383         https://bugs.webkit.org/show_bug.cgi?id=76764
2384
2385         Reviewed by Dirk Pranke.
2386
2387         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
2388         can also find skipped list. Chromium port only uses test_expectations.txt for
2389         layout tests but performacne tests don't use test_expectations.txt so Chromium port
2390         also needs to use Skipped list.
2391
2392         * Scripts/webkitpy/layout_tests/port/base.py:
2393         (Port._tests_from_skipped_file_contents):
2394         (Port):
2395         (Port._expectations_from_skipped_files):
2396         (Port.skipped_perf_tests):
2397         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2398         (PortTest.test_skipped_perf_tests):
2399         (PortTest.test_skipped_perf_tests.add_text_file):
2400         * Scripts/webkitpy/layout_tests/port/webkit.py:
2401         (WebKitPort._skipped_tests_for_unsupported_features):
2402         (WebKitPort._skipped_file_search_paths):
2403         (WebKitPort.skipped_layout_tests):
2404
2405 2012-01-23  Andy Estes  <aestes@apple.com>
2406
2407         Fix the build after r105635.
2408
2409         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2410         (TestWebKitAPI::TEST):
2411
2412 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2413
2414         Basic enhancements to StringBuilder
2415         https://bugs.webkit.org/show_bug.cgi?id=67081
2416
2417         Reviewed by Darin Adler.
2418
2419         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2420         (TestWebKitAPI::TEST):
2421
2422 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2423
2424         [GTK] run-gtk-tests randomly fails while running the xprop comand
2425         https://bugs.webkit.org/show_bug.cgi?id=76817
2426
2427         Reviewed by Gustavo Noronha Silva.
2428
2429         No need to use xprop to remove the AT_SPI_BUS property since
2430         run-gtk-tests will always run new instances of Xvfb.
2431
2432         * Scripts/run-gtk-tests:
2433         (TestRunner): Unskip TestWebKitAccessibility.
2434         (TestRunner.run): Uncomment lines for launching the accessibility
2435         bus and registry daemon, and remove lines for running xprop.
2436
2437 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2438
2439         [Qt] Don't warn about override and final being C++11 extensions
2440
2441         Clang will emit a warning when these extensions are used without passing
2442         --std=c++11, but we use feature checking to decide if we have the right
2443         extensions, so we can safely ignore these warnings. The XCode and Windows
2444         project files have the same workaround.
2445
2446         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
2447         we only have one extra compiler for Objective-C, which is also used for
2448         Objective-C++ sources, so we have to pass the flag, even if it doesn't
2449         make sense for Objective-C.
2450
2451         Reviewed by Simon Hausmann.
2452
2453         * qmake/mkspecs/features/unix/default_post.prf:
2454
2455 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2456
2457         [Qt] Change how build-webkit decides when to do full incremental builds
2458
2459         Instead of relying on update-webkit (which isn't run on the bots) to
2460         decide when to do a full incremental build (make qmake), we let the
2461         build-webkit script itself check the current SVN revision against the
2462         previous build (by storing it in .webkit.config).
2463
2464         If the two differ we assume a full incremental build is needed, since
2465         the new revisions might have introduced problematic things like new
2466         Q_OBJECT macros. If not, we assume the developer is doing changes
2467         locally, and revert to doing a plain 'make'.
2468
2469         In addition, when the build fails in the latter case, we inform the
2470         developer of possible pitfalls and how to manually run 'make qmake'.
2471
2472         Reviewed by Ossy.
2473
2474         * Scripts/update-webkit:
2475         * Scripts/webkitdirs.pm:
2476         (buildQMakeProjects):
2477
2478 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2479
2480         [GTK] run-gtk-tests randomly fails while running the xprop comand
2481         https://bugs.webkit.org/show_bug.cgi?id=76817
2482
2483         Reviewed by Philippe Normand.
2484
2485         Temporarily comment the lines related to launching the ATSPI bus
2486         and registry daemon, which are making the bots to fail randomly.
2487
2488         * Scripts/run-gtk-tests:
2489         (TestRunner): Skip TestWebKitAccessibility, as it won't run
2490         properly if the ATSPI infrastructure is not properly initialized.
2491         (TestRunner.run): Comment lines related to initialization of ATSPI.
2492
2493 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2494
2495         Windows python test build fix.
2496
2497         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2498         (PerfTestsRunner.__init__):
2499
2500 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
2501
2502         [GTK] DumpRenderTree converts "file:///" to a path differently
2503         https://bugs.webkit.org/show_bug.cgi?id=76631
2504
2505         Reviewed by Martin Robinson.
2506
2507         DumpRenderTree should print "/" as the last path component if the
2508         path is a lone slash instead of empty output.
2509
2510         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2511         (webViewConsoleMessage):
2512
2513 2012-01-20  David Levin  <levin@chromium.org>
2514
2515         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
2516         https://bugs.webkit.org/show_bug.cgi?id=76752
2517
2518         Reviewed by Eric Seidel.
2519
2520         * Scripts/webkitpy/style/checkers/cpp.py:
2521         (check_for_leaky_patterns):
2522         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2523         (LeakyPatternTest.test_create_dc):
2524         (LeakyPatternTest.test_create_compatible_dc):
2525
2526 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
2527
2528         Changed my status in commiters.py
2529
2530         Unreviewed.
2531
2532         * Scripts/webkitpy/common/config/committers.py:
2533
2534 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2535
2536         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
2537         https://bugs.webkit.org/show_bug.cgi?id=76748
2538
2539         Reviewed by Ryosuke Niwa.
2540
2541         It crawls the whole subtree and then doesn't use the data. Cutting this out
2542         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
2543
2544         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2545         (run):
2546
2547 2012-01-20  Adam Barth  <abarth@webkit.org>
2548
2549         Another tiny tweak to the garden-o-matic CSS.  This makes things line
2550         up slightly nicer when there aren't any failures.
2551
2552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2553         (#summary):
2554
2555 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2556
2557         run-perf-tests should support --test-results-server option
2558         https://bugs.webkit.org/show_bug.cgi?id=76680
2559
2560         Reviewed by Adam Barth.
2561
2562         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
2563         to be used by perf bots. Also refactor file_uploader as needed.
2564
2565         * Scripts/webkitpy/common/net/file_uploader.py:
2566         (FileUploader.__init__):
2567         (FileUploader.upload_single_file):
2568         (FileUploader.upload_as_multipart_form_data):
2569         (FileUploader):
2570         (FileUploader._upload_data):
2571         (FileUploader._upload_data.callback):
2572         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2573         (JSONResultsGeneratorBase.upload_json_files):
2574         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2575         (PerfTestsRunner):
2576         (PerfTestsRunner._parse_args):
2577         (PerfTestsRunner.run):
2578         (PerfTestsRunner._generate_json):
2579         (PerfTestsRunner._upload_json):
2580         (PerfTestsRunner._run_tests_set):
2581         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2582         (create_runner):
2583         (test_run_with_upload_json):
2584         (test_run_with_upload_json.mock_upload_json):
2585         (test_upload_json):
2586         (test_upload_json.MockFileUploader):
2587         (test_upload_json.MockFileUploader.__init__):
2588         (test_upload_json.MockFileUploader.upload_single_file):
2589         (test_parse_args):
2590
2591 2012-01-20  Adam Barth  <abarth@webkit.org>
2592
2593         The party time image overlaps real content!  This patch makes the
2594         image centered vertically.
2595
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2597         (#onebar.partytime #summary):
2598
2599 2012-01-19  Ojan Vafai  <ojan@chromium.org>
2600
2601         Refactor TestExpectationsParser in preparation for caching the results
2602         https://bugs.webkit.org/show_bug.cgi?id=76669
2603
2604         Reviewed by Dimitri Glazkov.
2605
2606         Make everything private expect for the parse method. 
2607         Eventually, we'll need the expectations lines to not be modified
2608         outside of TestExpectationsParser so we can cache the results.
2609         This makes check-webkit-style of the chromium test_expectations.txt file
2610         go from ~17 seconds to ~12 seconds on my Mac Pro.
2611
2612         This patch is just a refactor in preparation, so no new tests.
2613
2614         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2615         (TestExpectationEditorTests.make_parsed_expectation_lines):
2616         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2617         (TestExpectationParser.parse):
2618         (TestExpectationParser):
2619         (TestExpectationParser._parse_line):
2620         (TestExpectationParser._tokenize):
2621         (TestExpectationParser._tokenize_list):
2622         (TestExpectationsModel._clear_expectations_for_test):
2623         (TestExpectations.__init__):
2624         (TestExpectations._add_expectations):
2625         (TestExpectations._add_skipped_tests):
2626         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2627         (TestExpectationParserTests.test_tokenize_blank):
2628         (TestExpectationParserTests.test_tokenize_missing_colon):
2629         (TestExpectationParserTests.test_tokenize_extra_colon):
2630         (TestExpectationParserTests.test_tokenize_empty_comment):
2631         (TestExpectationParserTests.test_tokenize_comment):
2632         (TestExpectationParserTests.test_tokenize_missing_equal):
2633         (TestExpectationParserTests.test_tokenize_extra_equal):
2634         (TestExpectationParserTests.test_tokenize_valid):
2635         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2636         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2637         (TestExpectationParserTests.test_parse_empty_string):
2638         (TestExpectationSerializerTests.assert_round_trip):
2639         (TestExpectationSerializerTests.assert_list_round_trip):
2640         * Scripts/webkitpy/tool/commands/expectations.py:
2641         (OptimizeExpectations.execute):
2642         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2643         (GardeningExpectationsUpdater.update_expectations):
2644
2645 2012-01-20  Adam Barth  <abarth@webkit.org>
2646
2647         Follow-up to previous patch: don't produce NaN when the revision number
2648         is missing.
2649
2650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2652
2653 2012-01-20  Adam Barth  <abarth@webkit.org>
2654
2655         Garden-o-matic should tell me which revisions have been checked by all the bots
2656         https://bugs.webkit.org/show_bug.cgi?id=76722
2657
2658         Reviewed by Dimitri Glazkov.
2659
2660         This information helps me know when it's safe for me to roll a
2661         candidate revision.
2662
2663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2666
2667 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2668
2669         build-webkit: Don't spit out congratulations message on Ctrl+C
2670
2671         Reviewed by Andreas Kling.
2672
2673         * Scripts/build-webkit:
2674
2675 2012-01-20  Philippe Normand  <pnormand@igalia.com>
2676
2677         [GTK] Allow extra jhbuild modulesets
2678         https://bugs.webkit.org/show_bug.cgi?id=76691
2679
2680         Reviewed by Gustavo Noronha Silva.
2681
2682         * gtk/jhbuildrc: Extra modulesets and modules can be added in
2683         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
2684         env variables respectively. Use comma-separated values. Example:
2685         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
2686
2687 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2688
2689         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
2690         https://bugs.webkit.org/show_bug.cgi?id=72589
2691
2692         Reviewed by Martin Robinson.
2693
2694         Ensure the accessibility infrastructure is available when running
2695         the unit tests, otherwise WK2's accessibility tests won't work.
2696
2697         * Scripts/run-gtk-tests:
2698         (TestRunner):
2699         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
2700         where at-spi2's stuff is located (like at-spi-bus-launcher and
2701         at-spi2-registryd).
2702         (TestRunner.run): Initialize the accessibility infrastructure.
2703
2704         * gtk/generate-gtkdoc:
2705         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
2706
2707         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
2708
2709 2012-01-20  Hayato Ito  <hayato@chromium.org>
2710
2711         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
2712         https://bugs.webkit.org/show_bug.cgi?id=76353
2713
2714         Reviewed by Hajime Morita.
2715
2716         Add ShadowRoot.idl, which is enabled only on chromium port since this is
2717         under development feature.
2718         ShadowRoot.idl contains minimum API so that we can test it.
2719         Other APIs should be added on other changes so that we can isolate issues.
2720
2721         * DumpRenderTree/chromium/TestShell.cpp:
2722         (TestShell::TestShell):
2723
2724 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2725
2726         [GTK] GTK's DRT not to log events for already defunct objects
2727         https://bugs.webkit.org/show_bug.cgi?id=76620
2728
2729         Reviewed by Martin Robinson.
2730
2731         Do not log 'state-change:defunct' events.
2732
2733         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2734         (printAccessibilityEvent): Early return if a
2735         'state-change:defunct' signal is passed.
2736         (axObjectEventListener): Pass the signal name and value in
2737         separate parameters to printAccessibilityEvent.
2738
2739 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2740
2741         Unreviewed build fix. Wrong variable being used as the cwd for git
2742         remote update command.
2743
2744         * gtk/run-with-jhbuild:
2745         (update_jhbuild):
2746
2747 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2748
2749         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
2750         https://bugs.webkit.org/show_bug.cgi?id=76585
2751
2752         Reviewed by Martin Robinson.
2753
2754         This allows us to specify a minimum version of jhbuild required,
2755         while also providing stability against changes done to the master
2756         branch, by letting us choose what is the exact version that will
2757         be used.
2758
2759         * gtk/run-with-jhbuild: refactored for more hackability and easier
2760         reading
2761         (jhbuild_installed): checks whether jhbuild is installed
2762         (jhbuild_cloned): checks whether jhbuild has been cloned
2763         (jhbuild_at_expected_revision): checks whether jhbuild is at the
2764         expected revision
2765         (update_jhbuild): brings jhbuild to the expected revision
2766         (clone_jhbuild): clones jhbuild
2767         (install_jhbuild): build and installs jhbuild
2768         (update_webkitgtk_libs): runs update-webkitgtk-libs
2769         (ensure_jhbuild): high-level logic to decide whether and which of
2770         the steps above are executed
2771
2772 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2773
2774         [WK2] DumpRenderTree converts "file:///" to a path differently
2775         https://bugs.webkit.org/show_bug.cgi?id=76653
2776
2777         Reviewed by John Sullivan.
2778
2779         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
2780         Do print a slash if there are no path components.
2781
2782 2012-01-19  Eric Seidel  <eric@webkit.org>
2783
2784         webkit-patch cannot rollout patches without changelog/bug number
2785         https://bugs.webkit.org/show_bug.cgi?id=75962
2786
2787         Reviewed by Adam Barth.
2788
2789         * Scripts/webkitpy/tool/commands/download.py:
2790         (AbstractRolloutPrepCommand._prepare_state):
2791         * Scripts/webkitpy/tool/commands/download_unittest.py:
2792         (AbstractRolloutPrepCommandTest.test_prepare_state):
2793
2794 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2795
2796         [WK2] fast/url/degenerate-file-base.html fails
2797         https://bugs.webkit.org/show_bug.cgi?id=76619
2798
2799         Reviewed by Adam Roben.
2800
2801         A URL generated form local path for loading had an extra slash, making document.URL
2802         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
2803
2804         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
2805
2806 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2807
2808         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
2809         https://bugs.webkit.org/show_bug.cgi?id=76510
2810
2811         Reviewed by Adam Barth.
2812
2813         Unlike other style rules, if you get the syntax of the test_expectations.txt
2814         file wrong, the layout tests won't run. Also, this check is simple and only
2815         slows down committing if you actually modify one of the test_expectations.txt files.
2816
2817         * Scripts/webkitpy/style/checkers/test_expectations.py:
2818         (TestExpectationsChecker.check_test_expectations):
2819         (TestExpectationsChecker.check):
2820         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2821         (TestExpectationsTestCase.test_check_covers_all_configurations):
2822         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
2823         (TestExpectationsTestCase):
2824         (assert_lines_lint):
2825
2826 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2827
2828         Build fix. Revert an unintentional change to WebKitDriver in r105443.
2829
2830         * Scripts/webkitpy/layout_tests/port/driver.py:
2831         (DriverProxy.__init__):
2832
2833 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
2834
2835         remove the duplicated build rules from WebKit.gyp, Tools.gyp
2836         https://bugs.webkit.org/show_bug.cgi?id=73384
2837
2838         Reviewed by Tony Chang.
2839
2840         This patch removes the no-longer-necessary conditional logic for
2841         build_webkit_exes_from_webkit_gyp; we now always build the exes
2842         from their own dedicated gyp files.
2843
2844         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2845
2846 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2847
2848         make-new-script-test should work with HTTP tests
2849         https://bugs.webkit.org/show_bug.cgi?id=76603
2850
2851         Reviewed by Adam Roben.
2852
2853         * Scripts/make-new-script-test:
2854         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
2855         now also creates absolute paths for HTTP.
2856
2857 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2858
2859         Some perf tests time out when ran by run-perf-tests
2860         https://bugs.webkit.org/show_bug.cgi?id=76612
2861
2862         Reviewed by Dirk Pranke and Eric Seidel.
2863
2864         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
2865         Otherwise some tests such as Parser/xml-parser.html will timeout.
2866
2867         --no-timeout option is currently supported by Chromium and Mac ports.
2868
2869         * Scripts/webkitpy/layout_tests/port/base.py:
2870         (Port.to.create_driver):
2871         * Scripts/webkitpy/layout_tests/port/chromium.py:
2872         (ChromiumDriver.__init__):
2873         (ChromiumDriver._wrapper_options):
2874         * Scripts/webkitpy/layout_tests/port/driver.py:
2875         (Driver.__init__):
2876         (DriverProxy.__init__):
2877         * Scripts/webkitpy/layout_tests/port/webkit.py:
2878         (WebKitDriver.__init__):
2879         (WebKitDriver.cmd_line):
2880         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2881         (WebKitDriverTest.test_read_binary_block):
2882         (WebKitDriverTest):
2883         (WebKitDriverTest.test_no_timeout):
2884         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2885         (get_tests_run.RecordingTestDriver.__init__):
2886         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2887         (PerfTestsRunner._parse_args):
2888         (PerfTestsRunner._run_tests_set):
2889         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2890         (create_runner):
2891
2892 2012-01-19  Ben Wells  <benwells@chromium.org>
2893
2894         Add support for window.print to chromium DRT
2895         https://bugs.webkit.org/show_bug.cgi?id=76479
2896
2897         When used in a test window.print goes into print mode and then
2898         straight out again. This will allow the afterprint event to be
2899         tested by having the afterprint event happen before the dump
2900         happens.
2901
2902         Reviewed by Mihai Parparita.
2903
2904         * DumpRenderTree/chromium/WebViewHost.cpp:
2905         (WebViewHost::printPage):
2906         * DumpRenderTree/chromium/WebViewHost.h:
2907
2908 2012-01-18  Enrica Casucci  <enrica@apple.com>
2909
2910         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
2911         https://bugs.webkit.org/show_bug.cgi?id=76588
2912         <rdar://problem/9325183>
2913
2914         Added test.
2915         
2916         Reviewed by Dan Bernstein.
2917
2918         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2919         (TestWebKitAPI::TEST):
2920
2921 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2922
2923         [Qt] Do full incremental builds until bots use update-webkit
2924
2925         Rubber-stamped by Simon Hausmann.
2926
2927         * Scripts/webkitdirs.pm:
2928         (buildQMakeProjects):
2929
2930 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2931
2932         Fix the Qt build
2933
2934         Unreviewed build fix.
2935
2936         * Scripts/webkitdirs.pm:
2937         (buildQMakeProjects):
2938
2939 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2940
2941         [Qt] Make build-webkit always do safe incremental builds after update-webkit
2942
2943         When building against Qt5 with GCC we would just run 'make' in the build dir,
2944         and rely on the dependency files output by GCC (-MD) to handle dependency
2945         tracking, but that fails for special-cases like adding a Q_OBJECT macro
2946         to a header.
2947
2948         To guarantee that an incrmental build will work, we have to run 'make qmake',
2949         which we now do on every build-webkit that's followed by a successful run
2950         of update-webkit. The reasoning is that update-webkit can result in such
2951         potential corner-cases being applied, and since we can't know for sure
2952         unless we inspect the diff and account for all the corner cases we assume
2953         the worst and always run 'make qmake'.
2954
2955         After a succesful run of build-webkit we proceed to do just 'make' for any
2956         subsequent runs, since we assume that the developer knows what kind of
2957         changes he/she is doing, and when a 'make qmake' is needed.
2958
2959         Reviewed by Simon Hausmann.
2960
2961         * Scripts/update-webkit:
2962         * Scripts/webkitdirs.pm:
2963         (determineCurrentSVNRevision):
2964         (currentSVNRevision):
2965         (buildQMakeProjects):
2966         * qmake/mkspecs/features/default_post.prf:
2967
2968 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
2969
2970         run-perf-tests should support Skipped list
2971         https://bugs.webkit.org/show_bug.cgi?id=76594
2972
2973         Reviewed by Adam Barth.
2974
2975         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
2976
2977         * Scripts/webkitpy/layout_tests/port/base.py:
2978         (Port.perf_tests_dir):
2979         (Port.skipped_perf_tests):
2980         (Port.skips_perf_test):
2981         (Port.relative_perf_test_filename):
2982         * Scripts/webkitpy/layout_tests/port/test.py:
2983         (TestPort.perf_tests_dir):
2984         * Scripts/webkitpy/layout_tests/port/webkit.py:
2985         (WebKitPort._expectations_from_skipped_files):
2986         (WebKitPort):
2987         (WebKitPort.skipped_layout_tests):
2988         (WebKitPort.skipped_perf_tests):
2989         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2990         (PerfTestsRunner._collect_tests):
2991         (PerfTestsRunner.run):
2992         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2993         (test_run_test_set_with_json_output):
2994         (test_run_test_set_with_json_source):
2995         (test_collect_tests_with_skipped_list):
2996         (test_collect_tests_with_skipped_list.add_file):
2997
2998 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
2999
3000         Fix path to chromium_src_dir introduced in previous change.
3001
3002         Unreviewed, build fix.
3003
3004         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3005
3006 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
3007
3008         Need infrastructure to test Content-Disposition filename encoding support
3009         https://bugs.webkit.org/show_bug.cgi?id=76572
3010         <rdar://problem/6421825>
3011
3012         Reviewed by Sam Weinig.
3013
3014         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
3015
3016         WebKitTestRunner does not have a policy delegate yet, bug 42546.
3017
3018         * DumpRenderTree/mac/PolicyDelegate.mm:
3019         (dispositionTypeFromContentDispositionHeader):
3020         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
3021
3022 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3023
3024         Fix tests from http://trac.webkit.org/changeset/105332.
3025
3026         The code assumed that if you passed an options object with a configuration
3027         attribute that it would have a valid value. A bunch of the testing mocks
3028         do things like having a configuration value of None.
3029
3030         * Scripts/webkitpy/layout_tests/port/base.py:
3031         (Port.__init__):
3032
3033 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3034
3035         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
3036         https://bugs.webkit.org/show_bug.cgi?id=76576
3037
3038         Reviewed by Adam Barth.
3039
3040         Avoid calling default_configuration in base.py. We don't need it for
3041         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
3042         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
3043         from common.executive.
3044
3045         At some point someone should probably look into why that call is so slow
3046         since it's on the critical path for run-webkit-tests and build-webkit startup.
3047
3048         * Scripts/webkitpy/layout_tests/port/base.py:
3049         (Port.__init__):
3050         * Scripts/webkitpy/style/checkers/test_expectations.py:
3051         (TestExpectationsChecker._determine_port_from_exepectations_path):
3052
3053 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3054
3055         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
3056         https://bugs.webkit.org/show_bug.cgi?id=76505
3057
3058         Reviewed by Tony Chang.
3059
3060         Update chromium build script to use All.gyp instead of WebKit.gyp
3061
3062         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
3063         * Scripts/webkitdirs.pm:
3064
3065 2012-01-18  Sam Weinig  <sam@webkit.org>
3066
3067         Don’t hardcode the path to ‘make‘.
3068
3069         Reviewed by Dan Bernstein.
3070
3071         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3072
3073 2012-01-18  Joshua Bell  <jsbell@chromium.org>
3074
3075         Adding myself to committers.py
3076         https://bugs.webkit.org/show_bug.cgi?id=76569
3077
3078         Unreviewed.
3079
3080         * Scripts/webkitpy/common/config/committers.py:
3081
3082 2012-01-18  Adam Barth  <abarth@webkit.org>
3083
3084         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
3085         https://bugs.webkit.org/show_bug.cgi?id=76567
3086
3087         Reviewed by Eric Seidel.
3088
3089         Current the AppleMac port has slightly more failures than we allow on
3090         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
3091         which should hopefully let the mac-ews run to completion.  Once
3092         AppleMac has fewer failures, we can lower the cap again.
3093
3094         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3095         (LayoutTestResultsReaderTest.test_layout_test_results):
3096         * Scripts/webkitpy/tool/steps/runtests.py:
3097         (RunTests):
3098         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3099
3100 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
3101
3102         Provide access to user's list of preferred languages
3103         https://bugs.webkit.org/show_bug.cgi?id=76138
3104
3105         Reviewed by Alexey Proskuryakov.
3106
3107         * GNUmakefile.am: Add JSInternalsCustom.cpp.
3108
3109 2012-01-18  Adam Barth  <abarth@webkit.org>
3110
3111         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
3112         configurations.
3113
3114         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3115         (ChromiumLinuxPort.__init__):
3116
3117 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
3118
3119         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3120         https://bugs.webkit.org/show_bug.cgi?id=73460
3121
3122         Reviewed by Chris Fleizach.
3123
3124         * DumpRenderTree/AccessibilityUIElement.h:
3125         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3126         (AccessibilityUIElement::AccessibilityUIElement):
3127         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3128         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3129         (AccessibilityUIElement::scrollToGlobalPointCallback):
3130         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3131         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3132         (AccessibilityUIElement::scrollToMakeVisible):
3133         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3134         (AccessibilityUIElement::scrollToGlobalPoint):
3135         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3136         (AccessibilityUIElement::scrollToMakeVisible):
3137         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3138         (AccessibilityUIElement::scrollToGlobalPoint):
3139         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3140         (AccessibilityUIElement::scrollToMakeVisible):
3141         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3142         (AccessibilityUIElement::scrollToGlobalPoint):
3143
3144 2012-01-17  Enrica Casucci  <enrica@apple.com>
3145
3146         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
3147         https://bugs.webkit.org/show_bug.cgi?id=76490
3148         <rdar://problem/9460733>
3149
3150         Added TestWebKitAPI test.
3151         
3152         Reviewed by Dan Bernstein.
3153
3154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
3155         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
3156         changeAttributes to the WebView.
3157         
3158 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
3159
3160         [Qt] Consolidate layout test crash logging
3161         https://bugs.webkit.org/show_bug.cgi?id=75088
3162
3163         Reviewed by Simon Hausmann.
3164
3165         Move backtrace generating logic into WTFReportBacktrace
3166         and add a way to deinstall signal handlers if we know
3167         that we have already printed the backtrace.
3168
3169         * DumpRenderTree/qt/main.cpp:
3170         (crashHandler):
3171         (setupSignalHandlers):
3172         (WTFCrashHook):
3173         (main):
3174         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3175         (WTR::crashHandler):
3176         (WTR::setupSignalHandlers):
3177         (WTR::crashHook):
3178         (WTR::InjectedBundle::platformInitialize):
3179
3180 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
3181
3182         Unreviewed build fix after r105256.
3183
3184         There was a cyclic dependency between self._port and self._host assigments.
3185
3186         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3187         (PerfTestsRunner.__init__):
3188
3189 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3190
3191         Add new watchlist rule for the Qt build system
3192
3193         Reviewed by Simon Hausmann.
3194
3195         * Scripts/webkitpy/common/config/watchlist:
3196
3197 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3198
3199         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
3200
3201         Reviewed by Simon Hausmann.
3202
3203         * Tools.pro:
3204
3205 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3206
3207         [Qt] Allow building only a subset of the WebKit sub-projects
3208
3209         Fixes build-jsc, broken in r104825.
3210
3211         We no longer need the intermediate buildQMakeQtProject(), as we're the
3212         only port using qmake, and buildQMakeProject is now highly Qt specific.
3213
3214         <http://webkit.org/b/76179>
3215
3216         Reviewed by Simon Hausmann.
3217
3218         * Scripts/build-jsc:
3219         * Scripts/build-webkit:
3220         * Scripts/webkitdirs.pm:
3221         (buildQMakeProjects):
3222
3223 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3224
3225         run-perf-tests should generate a json file that summaries the result
3226         https://bugs.webkit.org/show_bug.cgi?id=76504
3227
3228         Reviewed by Adam Barth.
3229
3230         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
3231         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
3232         another json file to be merged into the generated json file.
3233
3234         Also fixed a bug that --build wasn't set by default.
3235
3236         * Scripts/webkitpy/layout_tests/port/test.py:
3237         (TestPort.webkit_base):
3238         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3239         (PerfTestsRunner.__init__):
3240         (PerfTestsRunner):
3241         (PerfTestsRunner._parse_args):
3242         (PerfTestsRunner.run):
3243         (PerfTestsRunner._generate_json_if_specified):
3244         (PerfTestsRunner._process_chromium_style_test_result):
3245         (PerfTestsRunner._process_parser_test_result):
3246         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3247         (MainTest):
3248         (create_runner):
3249         (test_run_test_set):
3250         (test_run_test_set_for_parser_tests):
3251         (test_run_test_set_with_summary_json):
3252         (test_collect_tests):
3253         (test_parse_args):
3254
3255 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3256
3257         Unreviewed, rolling out r105244.
3258         http://trac.webkit.org/changeset/105244
3259         https://bugs.webkit.org/show_bug.cgi?id=76518
3260
3261         broke Chromium Mac (Requested by rolandsteiner on #webkit).
3262
3263         * DumpRenderTree/AccessibilityUIElement.h:
3264         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3265         (AccessibilityUIElement::AccessibilityUIElement):
3266         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3267         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3268         (AccessibilityUIElement::removeSelection):
3269         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3270         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3271         (AccessibilityUIElement::removeSelection):
3272
3273 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
3274
3275         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3276         https://bugs.webkit.org/show_bug.cgi?id=73460
3277
3278         Reviewed by Chris Fleizach.
3279
3280         * DumpRenderTree/AccessibilityUIElement.h:
3281         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3282         (AccessibilityUIElement::AccessibilityUIElement):
3283         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3284         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3285         (AccessibilityUIElement::scrollToGlobalPointCallback):
3286         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3287         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3288         (AccessibilityUIElement::scrollToMakeVisible):
3289         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3290         (AccessibilityUIElement::scrollToGlobalPoint):
3291         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3292         (AccessibilityUIElement::scrollToMakeVisible):
3293         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3294         (AccessibilityUIElement::scrollToGlobalPoint):
3295         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3296         (AccessibilityUIElement::scrollToMakeVisible):
3297         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3298         (AccessibilityUIElement::scrollToGlobalPoint):
3299
3300 2012-01-17  Adam Barth  <abarth@webkit.org>
3301
3302         Enable tests on the mac-ews
3303         https://bugs.webkit.org/show_bug.cgi?id=76502
3304
3305         Reviewed by Simon Fraser.
3306
3307         Apple now has five machines running the mac-ews.  Lucas Forschler has
3308         asked that we try enabling tests to see if we have enough bandwidth.
3309
3310         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3311         (MacEWS):
3312
3313 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
3314
3315         Add a check-webkit-style exception for GDBInterface.cpp
3316         https://bugs.webkit.org/show_bug.cgi?id=76187
3317
3318         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
3319         that it does not fail the style check.
3320
3321         Reviewed by Martin Robinson.
3322
3323         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
3324         readability/naming tests on
3325         Source/JavaScriptCore/jit/GDBInterface.cpp.
3326         * Scripts/webkitpy/style/checker_unittest.py:
3327         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
3328         the above exception.
3329
3330 2012-01-17  Hajime Morrita  <morrita@chromium.org>
3331
3332         https://bugs.webkit.org/show_bug.cgi?id=76245
3333         [Mac][DRT] should allow query string for the file URL.
3334
3335         Reviewed by Tony Chang.
3336
3337         Taught DRT about file:// as a url instead of a file path.
3338         We are now able to use a path file:///foo/bar.html?baz as a url
3339         with which DRT opens "/foo/bar.html" with "baz" as a query string.
3340
3341         * DumpRenderTree/mac/DumpRenderTree.mm:
3342         (runTest):
3343
3344 2012-01-17  Ojan Vafai  <ojan@chromium.org>
3345
3346         Check style on test_expectations.txt files before commit
3347         https://bugs.webkit.org/show_bug.cgi?id=76484
3348
3349         Reviewed by Adam Barth.
3350
3351         Unlike other style rules, if you get the syntax of the test_expectations.txt
3352         file wrong, the layout tests won't run. Also, this check is simple and only
3353         slows down committing if you actually modify one of the test_expectations.txt files.
3354
3355         * Scripts/webkitpy/tool/steps/commit.py:
3356         (Commit._check_test_expectations):
3357         (Commit.run):
3358         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
3359         (CommitTest):
3360         (CommitTest.test_check_test_expectations):
3361
3362 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3363
3364         [Qt] Debug build fails with debug qt5
3365         https://bugs.webkit.org/show_bug.cgi?id=76463
3366
3367         Reviewed by Simon Hausmann.
3368
3369         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
3370
3371         * QtTestBrowser/cookiejar.h:
3372
3373 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3374
3375         webkitpy: fix json import on linux
3376         https://bugs.webkit.org/show_bug.cgi?id=76481
3377
3378         Reviewed by Adam Barth.
3379
3380         For some reason, the version of simplejson autoinstalled on my linux
3381         box seems to be broken. We should really only be using
3382         simplejson if json isn't available anyway, so this change looks
3383         for json first.
3384
3385         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3386         (JSONGeneratorTest.test_test_timings_trie):
3387
3388 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3389
3390         Fix failures in test-webkitpy caused by r105177.
3391
3392         Unreviewed, build fix.
3393
3394         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3395         (ChromiumLinuxPort._determine_driver_path_statically):
3396         (ChromiumLinuxPort._static_build_path):
3397
3398 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3399
3400         webkitpy: make PortFactory.get() be fully data-driven
3401         https://bugs.webkit.org/show_bug.cgi?id=76360
3402
3403         Reviewed by Eric Seidel.
3404
3405         Refactor PortFactory.get() to be fully data-driven.
3406
3407         * Scripts/webkitpy/layout_tests/port/factory.py:
3408         (PortFactory):
3409         (PortFactory._default_port):
3410         (PortFactory.get):
3411         (PortFactory.get.in):
3412         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3413         (FactoryTest.assert_port):
3414
3415 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3416
3417         webkitpy: add determine_full_port_name(), clean up port.__init__()
3418         https://bugs.webkit.org/show_bug.cgi?id=76357
3419
3420         Reviewed by Adam Barth.
3421
3422         Each Port class is now required to implement a 'port_name' field
3423         that will match the start of all ports constructed by this class and
3424         a 'determine_full_port_name' field that will make the port
3425         fully-qualified.
3426
3427         * Scripts/webkitpy/layout_tests/port/apple.py:
3428         (ApplePort.__init__):
3429         * Scripts/webkitpy/layout_tests/port/base.py:
3430         (Port):
3431         (Port.determine_port_name):
3432         (Port.__init__):
3433         * Scripts/webkitpy/layout_tests/port/chromium.py:
3434         (ChromiumPort.for):
3435         (ChromiumPort.__init__):
3436         (ChromiumPort):
3437         (ChromiumPort._chromium_base_dir):
3438         (ChromiumPort.path_from_chromium_base):
3439         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3440         (ChromiumGpuLinuxPort):
3441         (ChromiumGpuLinuxPort.__init__):
3442         (ChromiumGpuMacPort):
3443         (ChromiumGpuMacPort.__init__):
3444         (ChromiumGpuWinPort):
3445         (ChromiumGpuWinPort.__init__):
3446         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3447         (ChromiumLinuxPort):
3448         (ChromiumLinuxPort.determine_port_name):
3449         (ChromiumLinuxPort.__init__):
3450         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3451         (ChromiumMacPort):
3452         (ChromiumMacPort.determine_port_name):
3453         (ChromiumMacPort.__init__):
3454         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3455         (ChromiumWinPort):
3456         (ChromiumWinPort.determine_port_name):
3457         (ChromiumWinPort.__init__):
3458         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3459         (DryRunPort):
3460         (DryRunPort.determine_port_name):
3461         (DryRunPort.__init__):
3462         * Scripts/webkitpy/layout_tests/port/efl.py:
3463         (EflPort):
3464         * Scripts/webkitpy/layout_tests/port/factory.py:
3465         (PortFactory):
3466         (PortFactory._default_port):
3467         (PortFactory.get):
3468         (PortFactory.get.in):
3469         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3470         (FactoryTest.assert_port):
3471         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3472         (GoogleChromeLinux32Port):
3473         (GoogleChromeLinux32Port.determine_port_name):
3474         (GoogleChromeLinux64Port):
3475         (GoogleChromeLinux64Port.determine_port_name):
3476         (GoogleChromeMacPort):
3477         (GoogleChromeMacPort.determine_port_name):
3478         (GoogleChromeWinPort):
3479         (GoogleChromeWinPort.determine_port_name):
3480         * Scripts/webkitpy/layout_tests/port/gtk.py:
3481         (GtkPort):
3482         * Scripts/webkitpy/layout_tests/port/mac.py:
3483         (MacPort):
3484         (MacPort.determine_port_name):
3485         (MacPort.__init__):
3486         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3487         (test_versions):
3488         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3489         (MockDRTPort):
3490         (MockDRTPort.determine_port_name):
3491         (MockDRTPort.__init__):
3492         (MockDRT):
3493         (MockDRT.determine_port_name):
3494         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3495         (PortTestCase.make_port):
3496         * Scripts/webkitpy/layout_tests/port/qt.py:
3497         (QtPort):
3498         (QtPort.determine_port_name):
3499         (QtPort.__init__):
3500         * Scripts/webkitpy/layout_tests/port/test.py:
3501         (TestPort):
3502         (TestPort.determine_port_name):
3503         (TestPort.__init__):
3504         * Scripts/webkitpy/layout_tests/port/webkit.py:
3505         (WebKitPort.__init__):
3506         * Scripts/webkitpy/layout_tests/port/win.py:
3507         (WinPort):
3508         (WinPort.determine_port_name):
3509         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3510         (get_test_baselines.AllPlatformsPort.__init__):
3511         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3512         (get_test_config.TestMacPort):
3513         (get_test_config):
3514
3515 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3516
3517         webkitpy: clean up port code in preparation for static port names
3518         https://bugs.webkit.org/show_bug.cgi?id=76356
3519
3520         Reviewed by Adam Barth.
3521
3522         To fix bug 76215 and be able to determine appropriate port names
3523         in webkitpy without actually constructing Port objects, we need
3524         to shuffle some logic in the chromium ports to be able to figure
3525         out whether we built DRT in 32 or 64-bit mode.
3526
3527         * Scripts/webkitpy/layout_tests/port/chromium.py:
3528         (ChromiumPort):
3529         (ChromiumPort._chromium_base_dir):
3530         (ChromiumPort.__init__):
3531         (ChromiumPort.path_from_chromium_base):
3532         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3533         (ChromiumLinuxPort):
3534         (ChromiumLinuxPort._determine_driver_path_statically):
3535         (ChromiumLinuxPort._static_build_path):
3536         (ChromiumLinuxPort._determine_architecture):
3537         (ChromiumLinuxPort.__init__):
3538         (ChromiumLinuxPort._build_path):
3539
3540 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
3541
3542         Do not remove pixel failures for ref tests.
3543         https://bugs.webkit.org/show_bug.cgi?id=76243
3544
3545         Reviewed by Tony Chang.
3546
3547         'NRWT --no-pixel-tests' complains when reftests are expected to
3548         be image mismatch.
3549
3550         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3551         (Manager._update_summary_with_result):
3552         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3553         (is_reftest_failure):
3554         (determine_result_type):
3555
3556 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3557
3558         REGRESSION(r81225): ORWT should ignore reftests
3559         https://bugs.webkit.org/show_bug.cgi?id=67936
3560
3561         Reviewed by Csaba Osztrogonác.
3562
3563         * Scripts/old-run-webkit-tests:
3564         (isUsedInReftest): $filename should be the first parameter
3565         (findTestsToRun): run test if it isn't reftest
3566
3567 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
3568
3569         Unreviewed. Fix python unit test I broke with r105142
3570
3571         * Scripts/webkitpy/common/config/ports_unittest.py:
3572         (WebKitPortTest.test_gtk_port):
3573
3574 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3575
3576         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
3577
3578         Qt 5 no longer has that flag.
3579
3580         Reviewed by Simon Hausmann.
3581
3582         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3583         (MiniBrowserApplication::notify):
3584
3585 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3586
3587         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
3588         https://bugs.webkit.org/show_bug.cgi?id=75857
3589
3590         Reviewed by Adam Barth.
3591
3592         * Scripts/webkitdirs.pm:
3593         (buildAutotoolsProject): move cleaning the build to happen early,
3594         and handle --update-gtk right after that
3595         * Scripts/webkitpy/common/config/ports.py:
3596         (GtkPort.build_webkit_command): pass --update-gtk as an option to
3597         build-webkit, so that it is used in the EWS
3598
3599 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3600
3601         [Qt] Don't add _debug postfix to targets when building debug only
3602
3603         Reviewed by Simon Hausmann.
3604
3605         * qmake/mkspecs/features/default_post.prf:
3606         * qmake/mkspecs/features/functions.prf:
3607
3608 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3609
3610         [Qt] Add more files to project-files for easier navigation in Qt Creator
3611
3612         Reviewed by Simon Hausmann.
3613
3614         * Tools.pro:
3615         * qmake/config.tests/README: Added.
3616
3617 2012-01-17  Philippe Normand  <pnormand@igalia.com>
3618
3619         [GTK] fast/dom/constructed-objects-prototypes.html fails
3620         https://bugs.webkit.org/show_bug.cgi?id=75432
3621
3622         Reviewed by Martin Robinson.
3623
3624         * Scripts/build-webkit: Enable video-track in GTK.
3625
3626 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
3627
3628         Add toyoshim as a committer.
3629         https://bugs.webkit.org/show_bug.cgi?id=76390
3630
3631         Reviewed by Hajime Morita.
3632
3633         * Scripts/webkitpy/common/config/committers.py:
3634
3635 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
3636
3637         [WinCairo] Build fix after r104155. Several debug targets were not
3638         properly including the '*Common' property sheets.
3639
3640         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
3641         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
3642         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
3643         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
3644         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
3645
3646 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
3647
3648         REGRESSION(r105072): It broke committers_unittest.py
3649         https://bugs.webkit.org/show_bug.cgi?id=76396
3650
3651         Reviewed by Adam Barth.
3652
3653         * Scripts/webkitpy/common/config/committers_unittest.py:
3654         (CommittersTest._assert_fuzz_match): It should handle more names.
3655         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
3656
3657 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
3658
3659         [GTK] Include gtk+3 in the jhbuild modules
3660         https://bugs.webkit.org/show_bug.cgi?id=76284
3661
3662         Reviewed by Philippe Normand.
3663
3664         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
3665
3666 2012-01-16  Dan Winship  <danw@gnome.org>
3667
3668         Add myself as a committer
3669
3670         Unreviewed
3671
3672         * Scripts/webkitpy/common/config/committers.py:
3673
3674 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
3675
3676         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
3677
3678         Some recent versions of a few Linux distributions have started passing
3679         --as-needed and --no-copy-dt-needed-entries by default to the linker,
3680         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
3681         needed a few symbols from libjavascriptcore_efl.so.
3682
3683         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
3684         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
3685         libraries are searched in the right order by the linker.
3686
3687 2012-01-16  Philippe Normand  <pnormand@igalia.com>
3688
3689         [GTK] set audio resources path in NRTW
3690         https://bugs.webkit.org/show_bug.cgi?id=76380
3691
3692         Reviewed by Martin Robinson.
3693
3694         * Scripts/webkitpy/layout_tests/port/gtk.py:
3695         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
3696         the uninstalled audio resources are used during webaudio tests.
3697
3698 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3699
3700         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
3701         https://bugs.webkit.org/show_bug.cgi?id=76369
3702
3703         Reviewed by Xan Lopez.
3704
3705         If there's an installed version of webkit and there are new
3706         symbols in the build tree, gtkdoc-scanobj fails due to undefined
3707         references, because the env ldflags are given before the local
3708         ones.
3709
3710         * gtk/gtkdoc.py:
3711         (GTKDoc._run_gtkdoc_scangobj):
3712
3713 2012-01-15  Pablo Flouret  <pablof@motorola.com>
3714
3715         Fix compilation errors on build-webkit --debug --no-video on mac.
3716         https://bugs.webkit.org/show_bug.cgi?id=75867
3717
3718         Reviewed by Philippe Normand.
3719
3720         Add --[no-]video-track to build-webkit, since video track feature
3721         depends on video.
3722
3723         * Scripts/build-webkit:
3724
3725 2012-01-14  James Robinson  <jamesr@chromium.org>
3726
3727         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
3728         https://bugs.webkit.org/show_bug.cgi?id=76313
3729
3730         Reviewed by Adam Barth.
3731
3732         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
3733
3734         * Scripts/run-chromium-webkit-unit-tests:
3735
3736 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3737
3738         Unreviewed, rolling out r105017.
3739         http://trac.webkit.org/changeset/105017
3740         https://bugs.webkit.org/show_bug.cgi?id=76333
3741
3742         broke the build (Requested by philn-tp on #webkit).
3743
3744         * gtk/jhbuild.modules:
3745
3746 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
3747
3748         [GTK] Include gtk+3 in the jhbuild modules
3749         https://bugs.webkit.org/show_bug.cgi?id=76284
3750
3751         Reviewed by Philippe Normand.
3752
3753         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
3754
3755 2012-01-13  Adam Barth  <abarth@webkit.org>
3756
3757         Remove --dry-run support from webkit-patch
3758         https://bugs.webkit.org/show_bug.cgi?id=76300
3759
3760         Reviewed by Dirk Pranke.
3761
3762         This is the rest of the patch from Bug 76300.  I landed it separtely
3763         because main.py had some stray conflict markers that I needed to clean
3764         up first.
3765
3766         * Scripts/webkitpy/test/main.py:
3767         (Tester.parse_args):
3768         (Tester._run_tests):
3769
3770 2012-01-13  Adam Barth  <abarth@webkit.org>
3771
3772         test-webkitpy does not run
3773         https://bugs.webkit.org/show_bug.cgi?id=76318
3774
3775         Unreviewed.
3776
3777         Looks like some conflict markers got left in the file.
3778
3779         * Scripts/webkitpy/test/main.py:
3780         (Tester.run):
3781
3782 2012-01-13  Adam Barth  <abarth@webkit.org>
3783
3784         Remove --dry-run support from webkit-patch
3785         https://bugs.webkit.org/show_bug.cgi?id=76300
3786
3787         Reviewed by Dirk Pranke.
3788
3789         We don't use this functionality for anything, and it doesn't really
3790         work.  Someone in #webkit tried using it and and got sad/confused.  We
3791         should just remove it.
3792
3793         * Scripts/webkitpy/common/checkout/scm/git.py:
3794         (Git.push_local_commits_to_server):
3795         * Scripts/webkitpy/common/checkout/scm/scm.py:
3796         (SCM.__init__):
3797         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3798         (_shared_test_commit_with_message):
3799         (GitSVNTest.test_commit_text_parsing):
3800         * Scripts/webkitpy/common/checkout/scm/svn.py:
3801         (SVN.commit_with_message):
3802         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3803         (Bugzilla.__init__):
3804         (Bugzilla.quips):
3805         (Bugzilla.authenticate):
3806         (Bugzilla.add_attachment_to_bug):
3807         (Bugzilla.add_patch_to_bug):
3808         (Bugzilla.create_bug):
3809         (Bugzilla.clear_attachment_flags):
3810         (Bugzilla.set_flag_on_attachment):
3811         (Bugzilla.obsolete_attachment):
3812         (Bugzilla.add_cc_to_bug):
3813         (Bugzilla.post_comment_to_bug):
3814         (Bugzilla.close_bug_as_fixed):
3815         (Bugzilla.reassign_bug):
3816         (reopen_bug):
3817         * Scripts/webkitpy/test/main.py:
3818         (Tester.parse_args):
3819         (Tester.run_tests):
3820
3821 2012-01-13  David Levin  <levin@chromium.org>
3822
3823         check-webkit-style: should encourage the use of Own* classes for Windows DC.
3824         https://bugs.webkit.org/show_bug.cgi?id=76227
3825
3826         Reviewed by Dirk Pranke.
3827
3828         * Scripts/webkitpy/style/checkers/cpp.py:
3829         (check_for_leaky_patterns): The new check.
3830         (process_line): Added a call to the new check.
3831         (CppChecker): Added the new error type.
3832         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3833         (CppStyleTestBase):
3834         (CppStyleTestBase.perform_leaky_pattern_check):
3835         The check for only leaky pattern errors.
3836         (LeakyPatternTest): Test cases.
3837
3838 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3839
3840         test-webkitpy: clean up handling of test directories, QueueStatusServer
3841         https://bugs.webkit.org/show_bug.cgi?id=76238
3842
3843         Reviewed by Adam Barth.
3844
3845         This patch cleans up a bunch of hacks related to how we find all
3846         of the python unit tests and set up the sys.path variable in
3847         test-webkitpy.
3848
3849         This patch changes how test-webkitpy works slightly in that we
3850         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
3851         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
3852         This greatly simplifies the mapping of paths to module names and
3853         appears to have no significant performance impact or other drawbacks.
3854
3855         There are other ways that we could remove all of the hacks and
3856         still have a more flexible mapping of paths to module names, but
3857         the ones I've thought of so far add a decent amount of complexity to
3858         the implementation and don't seem to buy us much.
3859         
3860         * QueueStatusServer/__init__.py:
3861         * Scripts/test-webkitpy:
3862         * Scripts/webkitpy/test/main.py:
3863         (Tester._modules_from_paths):
3864         (Tester._is_module):
3865
3866 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3867
3868         test-webkitpy: should support classes and individual test names as well as modules
3869         https://bugs.webkit.org/show_bug.cgi?id=76233
3870
3871         Reviewed by Adam Barth.
3872
3873         The default unittest.main() supports a list of individual
3874         TestCase classes or individual tests as well as modules. This
3875         change adds support for the same to test-webkitpy, so now you
3876         can say
3877
3878           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
3879
3880         and
3881
3882           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
3883
3884         in addition to
3885
3886           % test-wekbitpy webkitpy.test.cat_unittest
3887
3888         * Scripts/test-webkitpy:
3889         * Scripts/webkitpy/test/cat_unittest.py:
3890         * Scripts/webkitpy/test/main.py:
3891         (Tester.parse_args):
3892         (Tester.run):
3893         (Tester):
3894         (Tester._find_modules):
3895         (Tester._exclude):
3896         (Tester._run_tests):
3897         (Tester._is_module):
3898         (Tester._log_exception):
3899
3900 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3901
3902         test-webkitpy: add basic code coverage support
3903         https://bugs.webkit.org/show_bug.cgi?id=76201
3904
3905         Reviewed by Adam Barth.
3906
3907         This test adds basic code coverage support to test-webkitpy; if
3908         you pass the -c flag, we will generate a new coverage file. We
3909         can start simply with this and add more features as necessary.
3910
3911         This patch requires coverage to be already installed on the
3912         machine. I am not auto-installing this for now.
3913
3914         * Scripts/webkitpy/test/main.py:
3915         (Tester.parse_args):
3916         (Tester.run_tests):
3917
3918 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3919
3920         StatusBubbleTest.test_build_bubble is failing
3921         https://bugs.webkit.org/show_bug.cgi?id=76222
3922
3923         Reviewed by Adam Barth.
3924
3925         * QueueStatusServer/handlers/statusbubble_unittest.py:
3926         (StatusBubbleTest.test_build_bubble):
3927
3928 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3929
3930         nrwt should use multiple http shards
3931         https://bugs.webkit.org/show_bug.cgi?id=75958
3932
3933         Add --max-locked-shards option to the nrwt for manual set
3934         the maximum number of the locked shards
3935
3936         Reviewed by Dirk Pranke.
3937
3938         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3939         (Manager._max_locked_shards):
3940         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3941         (ShardingTests.get_shards):
3942         (ShardingTests.test_multiple_locked_shards):
3943         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3944         (parse_args):
3945
3946 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
3947
3948         prepare-ChangeLog: Look for a text editor in a few more variables.
3949         https://bugs.webkit.org/show_bug.cgi?id=76289
3950
3951         Reviewed by Ryosuke Niwa.
3952
3953         A text editor was looked for only in the CHANGE_LOG_EDITOR and
3954         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
3955         to the OS X-specific open(1) command.
3956
3957         As there does not seem to be a common way of looking for a text editor
3958         among the scripts in Tools/Scripts right now, just look at $VISUAL and
3959         $EDITOR (set much more often than the other variables in Unix systems)
3960         before falling back to open(1).
3961
3962         * Scripts/prepare-ChangeLog:
3963         (openChangeLogs):
3964
3965 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
3966
3967         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
3968         https://bugs.webkit.org/show_bug.cgi?id=76269
3969
3970         Reviewed by Martin Robinson.
3971
3972         * gtk/gtkdoc.py:
3973         (GTKDoc._run_gtkdoc_scangobj):
3974
3975 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3976
3977         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
3978         https://bugs.webkit.org/show_bug.cgi?id=76247
3979
3980         Reviewed by Kenneth Rohde Christiansen.
3981
3982         * WebKitTestRunner/TestController.cpp:
3983         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
3984
3985 2012-01-13  Hajime Morrita  <morrita@chromium.org>
3986
3987         [Mac][DRT] Should support --no-timeout
3988         https://bugs.webkit.org/show_bug.cgi?id=76242
3989
3990         Reviewed by Darin Adler.
3991
3992         * DumpRenderTree/mac/DumpRenderTree.mm:
3993         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
3994         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
3995         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
3996         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3997         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3998         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
3999
4000 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
4001
4002         Mitigate scrollbar differences when running pixel tests
4003         https://bugs.webkit.org/show_bug.cgi?id=67217
4004
4005         Reviewed by Dan Bernstein.
4006         
4007         Enable mock scrollbars by default for tests.
4008
4009         * DumpRenderTree/mac/DumpRenderTree.mm:
4010         (resetDefaultsToConsistentValues):
4011         * WebKitTestRunner/TestController.cpp:
4012         (WTR::TestController::resetStateToConsistentValues):
4013
4014 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
4015
4016         Need a script to run tests in PerformanceTests
4017         https://bugs.webkit.org/show_bug.cgi?id=76132
4018
4019         Reviewed by Adam Barth.
4020
4021         Add run-perf-tests to run performance tests using parser/resources/runner.js.
4022         Unfortunately, there isn't an easy way of telling which test uses which format
4023         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
4024
4025         All test outputs are re-formatted to match Chromium perf-bot style.
4026
4027         * Scripts/run-inspector-perf-tests.py:
4028         * Scripts/run-perf-tests: Added.
4029         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4030         (PerfTestsRunner):
4031         (PerfTestsRunner.__init__):
4032         (PerfTestsRunner._collect_tests):
4033         (PerfTestsRunner.run):
4034         (PerfTestsRunner._print_status):
4035         (PerfTestsRunner._run_tests_set):
4036         (PerfTestsRunner._process_chromium_style_test_result):
4037         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
4038         (PerfTestsRunner._process_parser_test_result):
4039         (PerfTestsRunner._run_single_test):
4040         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4041         (MainTest.TestDriver.run_test):
4042         (create_runner):
4043         (run_test):
4044         (test_run_test_set):
4045         (test_run_test_set_for_parser_tests):
4046         (test_collect_tests):
4047
4048 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
4049
4050         webkitpy: clean up port unit tests in preparation for making port_name mandatory
4051         https://bugs.webkit.org/show_bug.cgi?id=76123
4052
4053         Reviewed by Adam Barth.
4054
4055         This change updates the unit tests to be more consistent in how
4056         ports are created, in preparation for making port_name a
4057         mandatory parameter to the constructor and removing any version
4058         interpretation from it.
4059
4060         There should be no functional changes in this patch, but some
4061         tests that are no longer relevant have been removed or reworked.
4062
4063         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4064         (PortTest.test_get_option__default):
4065         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4066         (ChromiumLinuxPortTest):
4067         (ChromiumLinuxPortTest.assert_architecture):
4068         (ChromiumLinuxPortTest.test_determine_architecture_fails):
4069         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4070         (ChromiumMacPortTest):
4071         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4072         (ChromiumPortTest):
4073         (ChromiumPortTest.test_all_test_configurations):
4074         (ChromiumPortTest.TestMacPort.__init__):
4075         (ChromiumPortTest.TestLinuxPort.__init__):
4076         (ChromiumPortTest.TestWinPort.__init__):
4077         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4078         (ChromiumWinTest):
4079         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
4080         (EflPortTest):
4081         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
4082         (GtkPortTest):
4083         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4084         (MacTest):
4085         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4086         (MockDRTPortTest):
4087         (MockDRTPortTest.make_port):
4088         * Scripts/webkitpy/layout_tests/port/qt.py:
4089         (QtPort._port_flag_for_scripts):
4090         (QtPort.__init__):
4091         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4092         (QtPortTest):
4093         (QtPortTest._assert_search_path):
4094         (QtPortTest.test_baseline_search_path):
4095         (QtPortTest.test_operating_system):
4096         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4097         (WebKitPortTest):
4098         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4099         (WinPortTest):
4100         (WinPortTest._assert_search_path):
4101         (WinPortTest.test_baseline_search_path):
4102         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
4103         (get_test_config.TestMacPort.__init__):
4104
4105 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
4106
4107         test-webkitpy: clean up logging and provide a real --help message
4108         https://bugs.webkit.org/show_bug.cgi?id=76142
4109
4110         Reviewed by Adam Barth.
4111
4112         This test is mostly more refactoring - it calls objects in
4113         unittest directly instead of routing through unittest.main() --
4114         in order to gain more control over the logging and to provide a
4115         correct --help message. This will also give us a better
4116         foundation for adding more feautures down the road.
4117
4118         This patch adds different levels of logging controlled by the
4119         '-s', '-q', and '-v' options (see --help for details), and
4120         removes the --verbose-logging option.
4121
4122         * Scripts/test-webkitpy:
4123         * Scripts/webkitpy/test/main.py:
4124         (Tester):
4125         (Tester.clean_packages):
4126         (Tester.__init__):
4127         (Tester.parse_args):
4128         (Tester.configure):
4129         (Tester._configure_logging):
4130         (Tester.find_modules):
4131         (Tester._exclude):
4132         (Tester._modules_from_paths):
4133         (Tester.run_tests):
4134
4135 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
4136
4137         Make the new WTF module build on Qt
4138         https://bugs.webkit.org/show_bug.cgi?id=76163
4139
4140         Reviewed by Tor Arne Vestbø.
4141
4142         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
4143
4144 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
4145
4146         Unreviewed, mac DumpRenderTree fix.
4147
4148         * DumpRenderTree/mac/UIDelegate.mm:
4149         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4150
4151 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
4152
4153         WebKitTestRunner should not print console message line number when it is equal to zero.
4154         https://bugs.webkit.org/show_bug.cgi?id=76167
4155
4156         Reviewed by Csaba Osztrogonác.
4157
4158         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4159         (WTR::InjectedBundlePage::willAddMessageToConsole):
4160
4161 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
4162
4163         Make default console messages line numbers consistent.
4164         https://bugs.webkit.org/show_bug.cgi?id=74075
4165
4166         Reviewed by Pavel Feldman.
4167
4168         Unset line numbers are not printed to console now.
4169         Added Source/WebCore/inspector to efl DumpRenderTree include path.
4170
4171         * DumpRenderTree/chromium/WebViewHost.cpp:
4172         (WebViewHost::didAddMessageToConsole):
4173         * DumpRenderTree/efl/CMakeLists.txt:
4174         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
4175         (onConsoleMessage):
4176         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4177         (webViewConsoleMessage):
4178         * DumpRenderTree/mac/UIDelegate.mm:
4179         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4180         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4181         (WebCore::WebPage::javaScriptConsoleMessage):
4182         * DumpRenderTree/win/UIDelegate.cpp:
4183         (UIDelegate::webViewAddMessageToConsole):
4184         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
4185         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
4186
4187 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
4188
4189         test-webkitpy: push more logic into webkitpy.test.main, clean up code
4190         https://bugs.webkit.org/show_bug.cgi?id=76021
4191
4192         Reviewed by Eric Seidel.
4193
4194         I plan to add more functionality to test-webkitpy, but it is
4195         difficult to hack on now; this patch is the first of two that
4196         brings test-webkitpy more inline with current coding style by
4197         pushing more logic into the webkitpy.test.main.Tester class (so
4198         that it will be testable itself).
4199         
4200         There should be no functional changes in this patch.
4201
4202         * Scripts/test-webkitpy:
4203         (_path_from_webkit_root):
4204         * Scripts/webkitpy/test/main.py:
4205         (Tester):
4206         (Tester.init):
4207         (Tester.configure_logging):
4208         (Tester.configure_logging.filter):
4209         (Tester.clean_packages):
4210         (Tester.run_tests):
4211
4212 2012-01-11  Wei Jia  <wjia@chromium.org>
4213
4214         implement layout tests for <video> with media stream
4215         https://bugs.webkit.org/show_bug.cgi?id=74882
4216
4217         Reviewed by Kent Tamura.
4218
4219         * DumpRenderTree/DumpRenderTree.gypi:
4220         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
4221         (WebKit::WebUserMediaClientMock::create):
4222         (WebKit::WebUserMediaClientMock::IsMockStream):
4223         (WebKit::WebUserMediaClientMock::requestUserMedia):
4224         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
4225         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
4226         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
4227         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
4228         * DumpRenderTree/chromium/WebViewHost.cpp:
4229         (WebViewHost::userMediaClient):
4230         (WebViewHost::userMediaClientMock):
4231         (WebViewHost::createMediaPlayer):
4232         (WebViewHost::mediaStreamUtil):
4233         (WebViewHost::testMediaStreamClient):
4234         * DumpRenderTree/chromium/WebViewHost.h:
4235
4236 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
4237
4238         Unreviewed, build fix.
4239
4240         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
4241
4242         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4243         (ChromiumWinPort.__init__):
4244
4245 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
4246
4247         Sheriffbot build fix. Don't emit empty lines on IRC.
4248
4249         * Scripts/webkitpy/tool/bot/irc_command.py:
4250         (LastGreenRevision.execute):
4251
4252 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
4253
4254         last-green-revision should report the revision that succeeded on all bots
4255         https://bugs.webkit.org/show_bug.cgi?id=76109
4256
4257         Reviewed by Adam Barth.
4258
4259         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
4260         considered green by this algorithm, all matching builders must have a successful run at the revision
4261         or two consecutive successful runs before and after the revision.
4262
4263         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
4264         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
4265
4266         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4267         (BuildBot._revisions_for_builder):
4268         (BuildBot):
4269         (BuildBot._find_green_revision):
4270         (BuildBot.last_green_revision):
4271         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
4272         (MockBuildBot.last_green_revision):
4273         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4274         (test_revisions_for_builder):
4275         (test_find_green_revision):
4276         (test_last_green_revision):
4277         * Scripts/webkitpy/tool/bot/irc_command.py:
4278         (LastGreenRevision.execute):
4279         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
4280         (SheriffIRCBotTest.test_lgr):
4281         * Scripts/webkitpy/tool/commands/queries.py:
4282         (LastGreenRevision):
4283
4284 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
4285
4286         Unreviewed, fix build bustage on win32 introduced by r104725.
4287
4288         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4289         (MockDRTPortTest.make_port):
4290         (MockChromiumDRTTest.test_pixeltest__fails):
4291
4292 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
4293
4294         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
4295         https://bugs.webkit.org/show_bug.cgi?id=75618
4296
4297         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
4298
4299         Reviewed by Tony Chang.
4300
4301         * DumpRenderTree/chromium/LayoutTestHelper.mm:
4302         (installLayoutTestColorProfile):
4303         (restoreUserColorProfile):
4304         (main):
4305
4306 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
4307
4308         test-webkitpy: fix -v and eliminate some spurious warnings
4309         https://bugs.webkit.org/show_bug.cgi?id=76099
4310
4311         Reviewed by Adam Barth.
4312
4313         when we added support for --xml output, we broke the -v flag.
4314
4315         Also, fix the code to swallow a harmless warning from
4316         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
4317
4318         test-webkitpy is now silent again except for the one known
4319         logging issue.
4320
4321         * Scripts/webkitpy/common/checkout/checkout.py:
4322         (Checkout.commit_message_for_this_commit):
4323         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4324         (test_commit_message_for_this_commit):
4325         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4326         (JSONChecker.check):
4327         (JSONChecker.line_number_from_json_exception):
4328         * Scripts/webkitpy/test/main.py:
4329         (Tester.run_tests):
4330
4331 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
4332
4333         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
4334         https://bugs.webkit.org/show_bug.cgi?id=76084
4335
4336         Reviewed by Adam Barth.
4337
4338         This will help make it easier to catch layering violations. This
4339         change just refactors test code; there are no changes to
4340         production code.
4341
4342         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4343         (PortTest.make_port):
4344         (PortTest.test_find_no_paths_specified):
4345         (PortTest.test_find_one_test):
4346         (PortTest.test_find_glob):
4347         (PortTest.test_find_with_skipped_directories):
4348         (PortTest.test_find_with_skipped_directories_2):
4349         (PortTest.test_parse_reftest_list):
4350         (PortTest.test_httpd_returns_error_code):
4351         (PortTest.test_virtual_methods):
4352         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4353         (ChromiumGpuTest.assert_port_works):
4354         (ChromiumGpuTest._assert_baseline_path):
4355         (ChromiumGpuTest.test_graphics_type):
4356         (ChromiumGpuTest.test_default_tests_paths.test_paths):
4357         (ChromiumGpuTest.test_test_files):
4358         (ChromiumGpuTest.test_test_files.test_paths):
4359         (ChromiumGpuTest):
4360         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4361         (ChromiumLinuxPortTest.assert_architecture):
4362         (ChromiumLinuxPortTest.test_check_illegal_port_names):
4363         (ChromiumLinuxPortTest.test_determine_architecture_fails):
4364         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
4365         (DriverTest.make_port):
4366         (DriverTest):
4367         (DriverTest.assertVirtual):