Unreviewed. Unskip inspector server unit tests.
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Unreviewed. Unskip inspector server unit tests.
4
5         They should pass now.
6
7         * Scripts/run-gtk-tests:
8         (TestRunner):
9
10 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
11
12         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
13         https://bugs.webkit.org/show_bug.cgi?id=132044
14
15         Reviewed by Brian Burg.
16
17         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
18         (openRemoteDebuggingSession): Remove trailing slash when
19         concatenating base inspector URL with the page, because the
20         inspector returns the relative paths with a leading slash.
21
22 2014-10-20  Tanay C  <tanay.c@samsung.com>
23
24         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
25         https://bugs.webkit.org/show_bug.cgi?id=137023
26
27         Reviewed by Gyuyoung Kim.
28
29         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
30         (search_box_show): Modified.
31         (search_box_hide): Modified.
32         (on_search_field_activated): Modified.
33         (on_search_backward_button_clicked): Modified.
34         (on_search_forward_button_clicked): Modified.
35         (on_search_case_option_changed): Added.
36         (on_search_word_start_option_changed): Added.
37         (window_create): Modified.
38
39 2014-10-20  Tanay C  <tanay.c@samsung.com>
40
41         [GTK][Minibrowser] Escape key does not hide the search box
42         https://bugs.webkit.org/show_bug.cgi?id=137734
43
44         Reviewed by Philippe Normand.
45
46         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
47         (stopPageLoad): Modified.
48
49 2014-10-18  Antti Koivisto  <antti@apple.com>
50
51         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
52         https://bugs.webkit.org/show_bug.cgi?id=137855
53
54         Reviewed by Dan Bernstein.
55
56         Test and warn if the dumped response mime type differs from the platform response mime type.
57
58         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
59         (WTR::InjectedBundlePage::didReceiveResponseForResource):
60         (WTR::InjectedBundlePage::platformResponseMimeType):
61         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
62         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
63         (WTR::InjectedBundlePage::platformResponseMimeType):
64
65 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
66
67         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
68         https://bugs.webkit.org/show_bug.cgi?id=137835
69
70         Reviewed by Andreas Kling.
71
72         * Scripts/run-inspector-perf-tests.py: Removed.
73         This script is stale, as PerformanceTests/inspector no longer exists.
74
75 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
76
77         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
78
79         * Scripts/webkitpy/port/ios.py:
80         (IOSSimulatorPort.default_baseline_search_path):
81
82 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
83
84         [iOS] Simplify test fallback paths for iOS Simulator testing
85         https://bugs.webkit.org/show_bug.cgi?id=137830
86
87         Reviewed by Zalan Bujtas.
88         
89         Make the fallback paths be:
90             ios-simulator -> generic
91             ios-simulator-wk2->ios-simulator -> generic
92         
93         so don't include mac in the fallback path. Also remove the
94         version handling for simplicity.
95
96         * Scripts/webkitpy/port/ios.py:
97         (IOSSimulatorPort):
98         (IOSSimulatorPort.default_baseline_search_path):
99
100 2014-10-17  Dana Burkart  <dburkart@apple.com>
101
102         Fix typos in the dashboard config file.
103
104         Unreviewed.
105
106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
107         (WebKitBuildbot):
108
109 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
110
111         [Win] Allow WinLauncher to specify Custom User Agent strings
112         https://bugs.webkit.org/show_bug.cgi?id=137828
113
114         Reviewed by Dean Jackson.
115
116         * WinLauncher/Common.cpp: Add support for custom user agent strings.
117         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
118         and set the user agent strings.
119         * WinLauncher/WinLauncher.h:
120         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
121         resources and dialog for setting custom User Agent strings.
122         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
123
124 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
125
126         [iOS] Turn off font autosizing for iOS WebKitTestRunner
127         https://bugs.webkit.org/show_bug.cgi?id=137806
128
129         Reviewed by Sam Weinig.
130
131         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
132         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
133         to disable font autosizing.
134         
135         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
136         test controller to set platform-specific prefs.
137
138         * WebKitTestRunner/TestController.cpp:
139         (WTR::TestController::resetPreferencesToConsistentValues):
140         (WTR::TestController::platformResetPreferencesToConsistentValues):
141         * WebKitTestRunner/TestController.h:
142         * WebKitTestRunner/ios/TestControllerIOS.mm:
143         (WTR::TestController::platformResetPreferencesToConsistentValues):
144         * WebKitTestRunner/mac/TestControllerMac.mm:
145         (WTR::TestController::platformResetPreferencesToConsistentValues):
146
147 2014-10-16  Dan Bernstein  <mitz@apple.com>
148
149         OSObjectPtr is missing leakRef()
150         https://bugs.webkit.org/show_bug.cgi?id=137798
151
152         Reviewed by Sam Weinig.
153
154         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
155         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
156
157 2014-10-16  Lucas Forschler  <lforschler@apple.com>
158
159         Update target platform to remove Leopard, Snow Leopard, Lion.
160         Add Yosemite. 
161         
162         Unreviewed.
163
164         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
165         (_should_file_trigger_build):
166
167 2014-10-16  David Kilzer  <ddkilzer@apple.com>
168
169         commit-queue: fails to replace OO-PS! with reviewer name
170         <http://webkit.org/b/137795>
171
172         Reviewed by Alexey Proskuryakov.
173
174         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
175         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
176         email addresses to unauthenticated page loads, so we must always
177         authenticate before getting bug data so we get full email
178         addresses.
179
180 2014-10-16  David Kilzer  <ddkilzer@apple.com>
181
182         commit-queue: fails to close bugs after successfully landing patches
183         <http://webkit.org/b/137794>
184
185         Reviewed by Alexey Proskuryakov.
186
187         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
188         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
189         tell Mechanize to use the second <textarea> on the page with
190         name="comment".
191
192 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
193
194         [Win] Update DRT to match Mac Logic
195         https://bugs.webkit.org/show_bug.cgi?id=137787
196
197         Reviewed by Dean Jackson.
198
199         * DumpRenderTree/win/DumpRenderTree.cpp:
200         (initialize): 0 -> nullptr
201         (runTest): Initialize MSG structure before using.
202         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
203         Also, cleanly shut down COM when exiting.
204         * DumpRenderTree/win/FrameLoadDelegate.cpp:
205         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
206         header and add printf to match Mac.
207         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
208         * DumpRenderTree/win/FrameLoadDelegate.h:
209         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
210         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
211         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
212         (isLocalhost): Added.
213         (hostIsUsedBySomeTestsToGenerateError): Added.
214         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
215         of certain error and redirect host names.
216         * DumpRenderTree/win/UIDelegate.cpp:
217         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
218         anything should be output to the console. This modifies behavior to match the Mac.
219         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
220         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
221         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
222         (UIDelegate::webViewAddMessageToConsole): Ditto.
223         * WinLauncher/PageLoadTestClient.cpp:
224         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
225         added last week.
226
227 2014-10-16  Commit Queue  <commit-queue@webkit.org>
228
229         Unreviewed, rolling out r174754.
230         https://bugs.webkit.org/show_bug.cgi?id=137789
231
232         Speculative fix for Windows test was ineffective. (Requested
233         by rfong on #webkit).
234
235         Reverted changeset:
236
237         "[Windows] Add some more logging to debug Windows test
238         issues."
239         http://trac.webkit.org/changeset/174754
240
241 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
242
243         Unreviewed, add myself to CoordinatedGraphics watchers.
244
245         * Scripts/webkitpy/common/config/watchlist:
246
247 2014-10-15  Roger Fong  <roger_fong@apple.com>
248
249         [Windows] Speculative Windows test fix.
250
251         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
252
253 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
254
255         import-w3c-test rewrites relative src paths in ref files incorrectly
256         https://bugs.webkit.org/show_bug.cgi?id=137586
257
258         This patch fixes a bug in test_converter.py where src paths were getting 
259         rewritten as ../../some-path instead of <script src="../../some-path>". 
260         It also adds support for rewriting src paths in style  elements, which was 
261         missing before and it adds tests for this case.
262
263         Reviewed by Bem Jones-Bey.
264
265         * Scripts/webkitpy/w3c/test_converter.py:
266         (_W3CTestConverter.convert_attributes_if_needed):
267         * Scripts/webkitpy/w3c/test_converter_unittest.py:
268         (test_convert_attributes_if_needed):
269         (verify_reference_relative_paths):
270
271 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
272
273         Add --json flag to test-webkitpy to emit JSON formatted test results
274         to stdout
275         https://bugs.webkit.org/show_bug.cgi?id=137353
276
277         Reviewed by Daniel Bates.
278
279         * Scripts/webkitpy/port/server_process_unittest.py:
280         Adds the read method to MockFile to allow the stdout of test_webkitpy
281         to be redirected without causing erroneous test failures.
282         In particular,
283         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
284         and
285         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
286         because when redirecting to a file, the
287         _wait_for_data_and_update_buffers_using_select method in 
288         server_process.py will find that there is a read file descriptor in
289         its call to select.select, which eventually leads to it calling read()
290         on the MockFile object.
291         (MockFile.read):
292         * Scripts/webkitpy/test/main.py:
293         Adds the _print_results_as_json method and the --json flag which
294         determines whether _print_results_as_json will get called.
295         (Tester._parse_args):
296         (Tester._print_results_as_json):
297         (Tester._print_results_as_json.result_dict_from_tuple):
298         (Tester._run_tests):
299
300 2014-10-13  David Farler  <dfarler@apple.com>
301
302         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
303         https://bugs.webkit.org/show_bug.cgi?id=137662
304
305         Reviewed by Darin Adler.
306
307         The layout test harness can close LayoutTestRelay's subprocess
308         stdout and stderr in the case of a timeout or if a run is
309         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
310         finds that no one is listening to its stdout/stderr (broken
311         pipe), then just exit(1), there is nothing to report.
312
313         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
314         (-[LTRelayController didReceiveStdoutData:]):
315         Add @try/@catch for NSFileHandleOperationException.
316         (-[LTRelayController didReceiveStderrData:]):
317         Add @try/@catch for NSFileHandleOperationException.
318
319 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
320
321         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
322         https://bugs.webkit.org/show_bug.cgi?id=137060
323
324         Reviewed by Philippe Normand.
325
326         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
327
328         * MiniBrowser/gtk/BrowserWindow.c:
329         (zoomInCallback):
330         (zoomOutCallback):
331         (defaultZoomCallback): Callback for default zoom keyboard support.
332         (browser_window_init):
333
334 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
335
336         [Mac] DRT stderr logging after the test completes gets attributed to the next test
337
338         Reviewed by Alexey Proskuryakov.
339         
340         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
341         logging to stderr to get associated with the next test.
342         
343         Fix by logging #EOF to stderr later, after we've completely finished with this test.
344
345         * DumpRenderTree/mac/DumpRenderTree.mm:
346         (dumpTestResults):
347         (runTest):
348
349 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
350
351         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
352
353         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
354
355 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
356
357         [cmake] Fix the make build after r174683
358         https://bugs.webkit.org/show_bug.cgi?id=137703
359
360         Reviewed by Martin Robinson.
361
362         * Scripts/webkitdirs.pm:
363         (buildCMakeGeneratedProject):
364
365 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
366
367         Adding myself to the watchlist to CachedFont
368
369         Unreviewed.
370
371         * Scripts/webkitpy/common/config/watchlist:
372
373 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
374
375         [EFL][GTK] Make it possible to get verbose output with ninja
376         https://bugs.webkit.org/show_bug.cgi?id=137606
377
378         Reviewed by Csaba Osztrogonác.
379
380         * Scripts/webkitdirs.pm:
381         (buildCMakeGeneratedProject):
382
383 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
384
385         [EFL] Make it possible to use ninja for EFL build too
386         https://bugs.webkit.org/show_bug.cgi?id=137605
387
388         Reviewed by Csaba Osztrogonác.
389
390         * Scripts/webkitdirs.pm:
391         (generateBuildSystemFromCMakeProject):
392         * efl/install-dependencies:
393
394 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
395
396         [GTK] Minibrowser : Add home buton and keyboard support for home page load
397         https://bugs.webkit.org/show_bug.cgi?id=137486
398
399         Reviewed by Philippe Normand.
400
401         * MiniBrowser/gtk/BrowserWindow.c:
402         (loadHomePage): Callback for home page load.
403         (browser_window_init):
404         * MiniBrowser/gtk/BrowserWindow.h:
405         * MiniBrowser/gtk/main.c:
406         (main):
407
408 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
409
410         import-w3c-tests doesn't prefix property values
411         https://bugs.webkit.org/show_bug.cgi?id=137600
412
413         Reviewed by Bem Jones-Bey.
414
415         Some property values are prefixed in WebKit. Modified the W3C import
416         script in order to prefix property values and not only properties.
417         The patch re-uses most of the already existent logic to prefix
418         properties.
419
420         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
421         from CSSValueKeywords.in and adapt converter to modify both properties
422         and property values.
423         (convert_for_webkit):
424         (_W3CTestConverter.__init__):
425         (_W3CTestConverter.output):
426         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
427         (_W3CTestConverter):
428         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
429         (_W3CTestConverter.add_webkit_prefix_following_regex):
430         (_W3CTestConverter.convert_reference_relpaths):
431         (_W3CTestConverter.convert_style_data):
432         (_W3CTestConverter.convert_attributes_if_needed):
433         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
434         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
435         include checks for property values too.
436         (W3CTestConverterTest.test_read_prefixed_property_list):
437         (verify_no_conversion_happened):
438         (verify_prefixed_properties):
439         (verify_prefixed_property_values):
440         (generate_test_content_properties_and_values):
441         (generate_test_content):
442         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
443         prefixed property values and inform about them.
444         (TestImporter.import_tests):
445         (TestImporter.write_import_log):
446
447 2014-10-13  Jer Noble  <jer.noble@apple.com>
448
449         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
450         https://bugs.webkit.org/show_bug.cgi?id=137533
451
452         Reviewed by Andy Estes.
453
454         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
455
456         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
457         (TestWebKitAPI::isMSEEnabledCallback):
458         (TestWebKitAPI::TEST):
459
460 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
461
462         [Win] Implement a page load profiling tool
463         https://bugs.webkit.org/show_bug.cgi?id=137673
464
465         Reviewed by Dean Jackson.
466
467         Add a tool to capture and summarize page load statistics.
468
469         * WinLauncher/Common.cpp:
470         (parseCommandLine): Move from WinMain.cpp so that it can
471         be shared with internal tools.
472         * WinLauncher/PageLoadTestClient.cpp: Added.
473         (PageLoadTestClient::PageLoadTestClient):
474         (PageLoadTestClient::pageLoadStartedAtTime):
475         (PageLoadTestClient::didStartProvisionalLoad):
476         (PageLoadTestClient::didCommitLoad):
477         (PageLoadTestClient::didFirstLayoutForMainFrame):
478         (PageLoadTestClient::didHandleOnLoadEvents):
479         (PageLoadTestClient::didFinishLoad):
480         (PageLoadTestClient::didFailLoad):
481         (PageLoadTestClient::didInitiateResourceLoad):
482         (PageLoadTestClient::didEndResourceLoad):
483         (PageLoadTestClient::pageLoadEndedAtTime):
484         (PageLoadTestClient::endPageLoad):
485         (PageLoadTestClient::clearPageLoadState):
486         (PageLoadTestClient::shouldConsiderPageLoadEnded):
487         (PageLoadTestClient::maybeEndPageLoadSoon):
488         (PageLoadTestClient::setPageURL):
489         (PageLoadTestClient::dumpRunStatistics):
490         * WinLauncher/PrintWebUIDelegate.cpp:
491         (PrintWebUIDelegate::createWebViewWithRequest): Handle
492         nullptr URL properly.
493         * WinLauncher/ResourceLoadDelegate.cpp: Added.
494         (ResourceLoadDelegate::QueryInterface):
495         (ResourceLoadDelegate::AddRef):
496         (ResourceLoadDelegate::Release):
497         (ResourceLoadDelegate::identifierForInitialRequest):
498         (ResourceLoadDelegate::willSendRequest):
499         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
500         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
501         (ResourceLoadDelegate::didReceiveResponse):
502         (ResourceLoadDelegate::didReceiveContentLength):
503         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
504         (ResourceLoadDelegate::didFailLoadingWithError):
505         (ResourceLoadDelegate::plugInFailedWithError):
506         * WinLauncher/ResourceLoadDelegate.h: Added.
507         (ResourceLoadDelegate::ResourceLoadDelegate):
508         * WinLauncher/WinLauncher.cpp:
509         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
510         page loading statistics.
511         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
512         and set private load delegate state.
513         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
514         that sets the view's resource load delegate.
515         (WinLauncher::loadURL): If no URL is passed, load the test document.
516         * WinLauncher/WinLauncher.h:
517         (WinLauncher::pageLoadTestClient):
518         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
519         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
520         * WinLauncher/WinLauncherWebHost.cpp:
521         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
522         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
523         it could be used from other source files.
524         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
525         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
526         (WinLauncherWebHost::didFailLoadWithError): Ditto.
527         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
528         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
529         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
530         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
531         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
532         * WinLauncher/WinLauncherWebHost.h:
533         * WinLauncher/WinMain.cpp:
534         (wWinMain): Create and use new delegates for gathering page load data.
535         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
536
537 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
538
539         Improve the test image diffs page
540         https://bugs.webkit.org/show_bug.cgi?id=137674
541
542         Reviewed by Alexey Proskuryakov.
543         
544         Don't treat the input file as a format string, otherwise we have to escape special
545         characters. Just do a couple of replaces.
546
547         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
548         (TestResultWriter.write_image_diff_files):
549
550 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
551
552         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
553         https://bugs.webkit.org/show_bug.cgi?id=137659
554
555         Reviewed by Martin Robinson.
556
557         * Scripts/webkitpy/port/xvfbdriver.py:
558         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
559
560 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
561
562         Add more detailed wait time information to EWS metrics
563         https://bugs.webkit.org/show_bug.cgi?id=137649
564
565         Reviewed by Daniel Bates.
566
567         Added average and worst time (we used to only have median), and also a percentage
568         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
569
570         There is always some wait due to the polling nature of the queues, which is well understood
571         and doesn't need to be measured. What needs to be measured is whether there is enough
572         bot machines to process patches as soon as they are submitted.
573
574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
575         (Analyzer.prototype._analyzeBubblePerformance):
576         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
577         (MetricsBubbleView.prototype._update):
578
579 2014-10-11  Jer Noble  <jer.noble@apple.com>
580
581         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
582         https://bugs.webkit.org/show_bug.cgi?id=137533
583
584         Reviewed by Darin Adler.
585
586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
587         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
588         (TestWebKitAPI::TEST):
589         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
590         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
591
592 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
593
594         iOS DRT snapshots are limited to the page visible area
595         https://bugs.webkit.org/show_bug.cgi?id=137650
596
597         Reviewed by Daniel Bates.
598         
599         LegacyTileCache drawing was limited to the window's visible area, found by
600         crawling up the layer hierarchy to the root layer. This caused test snapshots to
601         be missing non-composited content outside the iPhone visible area, which hinders
602         testing.
603         
604         Fix by adding a test-only mode where the window visible area is the entire window.
605         
606         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
607         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
608         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
609         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
610         for the DRT window.
611         
612
613 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
614
615         Page not fully rendered in iOS DRT snapshots
616         https://bugs.webkit.org/show_bug.cgi?id=137638
617
618         Reviewed by Tim Horton.
619         
620         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
621         to ensure that the page has laid out and is rendered by the time we take
622         the snapshot.
623
624         * DumpRenderTree/mac/DumpRenderTree.mm:
625         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
626         (-[DumpRenderTree _webThreadInvoked]): Moved.
627         (-[DumpRenderTree _waitForWebThreadThenDump]):
628         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
629         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
630         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
631         relies on dispatch_async too, and the inner block won't complete until the outer block
632         has completed.
633         (dumpTestResults): Move the guts of dump() here.
634         (runTest): Whitespace.
635
636 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
637
638         Adding svn:ignore so that .pyc files don't show up as new.
639
640         * Scripts/webkitpy/xcode: Added property svn:ignore.
641
642 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
643
644         [EFL] Introduce EWebKit_Extension
645         https://bugs.webkit.org/show_bug.cgi?id=134921
646
647         Reviewed by Gyuyoung Kim.
648
649         * MiniBrowser/efl/main.c: Added x option to test extension path.
650         (window_create):
651         (elm_main):
652         * Scripts/webkitpy/common/config/watchlist:
653         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
654         * Scripts/webkitpy/style/checker.py:
655         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
656
657 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
658
659         After r174628 we send the test process a SIGTERM before the SIGKILL.
660
661         * Scripts/webkitpy/common/system/executive_unittest.py:
662         (ExecutiveTest.serial_test_kill_process):
663
664 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
665
666         [EFL] Enable WebP support.
667         https://bugs.webkit.org/show_bug.cgi?id=136156
668
669         Reviewed by Gyuyoung Kim.
670
671         Include libwebp-dev package to support WebP for WK2 Efl.
672
673         * efl/install-dependencies:
674
675 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
676
677         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
678         https://bugs.webkit.org/show_bug.cgi?id=137485
679
680         Reviewed by Sergio Villar Senin.
681
682         Update GMainLoopSource tests. Most of the tests are now run twice,
683         first with a GMainLoopSource and then with a
684         GThreadSafeMainLoopSource, since both should have the same
685         behaviour. The threading test uses GThreadSafeMainLoopSource and
686         the delete on destroy test uses GMainLoopSource. The tests
687         themselves haven't changed, since there's no change in behaviour.
688
689         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
690         (TestWebKitAPI::GMainLoopSourceTest::source):
691         (TestWebKitAPI::basicRescheduling):
692         (TestWebKitAPI::TEST):
693         (TestWebKitAPI::reentrantRescheduling):
694         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
695         (TestWebKitAPI::basicDestroyCallbacks):
696         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
697         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
698
699 2014-10-10  Dana Burkart  <dburkart@apple.com>
700
701         Fix fat-fingered function name in git-add-reviewer.
702
703         Unreviewed.
704
705         * Scripts/git-add-reviewer:
706         (getConfigValue):
707
708 2014-10-10  David Farler  <dfarler@apple.com>
709
710         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
711         https://bugs.webkit.org/show_bug.cgi?id=137528
712
713         Reviewed by Simon Fraser.
714
715         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
716         and SIGKILL the paired simulator app before exiting cleanly.
717
718         webkitpy only uses SIGKILL to kill processes which you cannot
719         catch. Send SIGTERM to the process and give it chance to do
720         its thing before sending SIGKILL. Sending a SIGKILL to an already
721         dead PID is safe.
722
723         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
724         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
725         (-[LTRelayController finish]):
726         * LayoutTestRelay/LayoutTestRelay/main.m:
727         (receivedSignal):
728         (main):
729
730 2014-10-10  David Farler  <dfarler@apple.com>
731
732         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
733         https://bugs.webkit.org/show_bug.cgi?id=137527
734
735         Reviewed by Simon Fraser.
736
737         NSFileHandle doesn't notify of EOF in its readability handler.
738         Use a dispatch_source_t and an event handler that is called when reading is possible.
739         In the handler block, do a run-of-the-mill read(2) from standard input and
740         detect EOF in the usual way by checking that zero bytes were read.
741
742         Once an EOF is received, the FIFOs are disconnected, the simulator app
743         is killed, and the relay exits with status 0.
744
745         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
746         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
747         (-[LTRelayController didDisconnect]):
748         (-[LTRelayController didConnect]):
749         (-[LTRelayController launchApp]):
750         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
751         confusion with this new dispatch source, called "standardInputDispatchSource".
752         (-[LTRelayController finish]): Added.
753         (-[LTRelayController readFileHandle:]): Deleted.
754
755 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
756
757         [EFL] Crash on facebook.com
758         https://bugs.webkit.org/show_bug.cgi?id=137562
759
760         Reviewed by Chris Dumez.
761
762         Crash occurs on the facebook.com when the webview is resized
763         after the <select> item is clicked but no item is chosen.
764         This crash is just caused by the reference of invalidated variable.
765         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
766         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
767         on MiniBrowser is called.
768         As a result, just set ewk_menu to NULL in order to prevent crash condition.
769
770         * MiniBrowser/efl/main.c:
771         (on_popup_menu_hide):
772
773 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
774
775         A small wording change for clarity.
776
777         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
778         (MetricsBubbleView.prototype._update):
779
780 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
781
782         Dashboard metrics page should have EWS statistics
783         https://bugs.webkit.org/show_bug.cgi?id=137626
784
785         Reviewed by Ryosuke Niwa.
786
787         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
788         (BubbleQueue): Put shortName in the object, so that it's actually useful.
789
790         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
791         (BubbleQueueServer): Re-ordered queues to match bubble order.
792         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
793         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
794
795         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
796         Added analysis for bubble queues.
797
798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
799
800         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
801         (buildBubbleQueuesTable): Build the UI.
802
803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
804         Added JS sources to load.
805
806         * QueueStatusServer/app.yaml: To update app version.
807
808         * QueueStatusServer/handlers/processingtimesjson.py: Added.
809
810         * QueueStatusServer/main.py: Added a handler for processing-times-json.
811
812 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
813
814         REGRESSION: Commit queue doesn't process rollouts
815         https://bugs.webkit.org/show_bug.cgi?id=137623
816
817         Reviewed by Tim Horton.
818
819         * QueueStatusServer/app.yaml:
820         * QueueStatusServer/handlers/updateworkitems.py:
821         (UpdateWorkItems._work_items_from_request):
822
823 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
824
825         Fix syntax error after r174601.
826
827         * Scripts/run-javascriptcore-tests:
828
829 2014-10-10  Michael Saboff  <msaboff@apple.com>
830
831         Add ability to select tarfile name in run-jsc-stress-tests
832         https://bugs.webkit.org/show_bug.cgi?id=137614
833
834         Reviewed by Mark Hahnenberg.
835
836         Added optional file name argument to the --tarball option.  
837
838         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
839         extra test given after the options wont be used for the optional tarball file name.
840         * Scripts/run-jsc-stress-tests:
841
842 2014-10-10  Chris Dumez  <cdumez@apple.com>
843
844         Unreviewed, update my information in contributors.json
845
846         Use my preferred first name and update my expertise areas.
847
848         * Scripts/webkitpy/common/config/contributors.json:
849
850 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
851
852         Fix perl scripts to run with env on Linux
853         https://bugs.webkit.org/show_bug.cgi?id=137601
854
855         Reviewed by Csaba Osztrogonác.
856
857         Use of arguments in #! is nonstandard and does not behave the same on
858         different systems. Linux would look for an executable named "perl -w" 
859         "use warnings;" does the same things in a more portable way.
860
861         * Scripts/commit-log-editor:
862         * Scripts/num-cpus:
863         * Scripts/prepare-ChangeLog:
864         * Scripts/run-launcher:
865         * Scripts/svn-create-patch:
866
867 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
868
869         [jhbuild] We should be able to disable wiping on configuration change
870         https://bugs.webkit.org/show_bug.cgi?id=137446
871
872         Reviewed by Csaba Osztrogonác.
873
874         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
875         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
876         or passing --no-wipe-on-change command line option.
877
878         * Scripts/update-webkit-libs-jhbuild:
879
880 2014-10-09  Andy Estes  <aestes@apple.com>
881
882         Teach webkitpy about OS X Yosemite
883         https://bugs.webkit.org/show_bug.cgi?id=137585
884
885         Reviewed by Simon Fraser.
886
887         * Scripts/webkitpy/common/system/platforminfo.py:
888         (PlatformInfo._determine_mac_version):
889         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
890         (TestPlatformInfo.test_os_version):
891         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
892         (TestExpectationParser):
893         * Scripts/webkitpy/port/builders.py:
894         * Scripts/webkitpy/port/mac.py:
895         (MacPort):
896         * Scripts/webkitpy/port/mac_unittest.py:
897         (test_versions):
898         (test_baseline_search_path):
899         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
900         (TestRebaselineTest.test_baseline_directory):
901         (TestRebaselineExpectations.test_rebaseline_expectations):
902
903 2014-10-09  Dana Burkart  <dburkart@apple.com>
904
905         Add Mac OS Yosemite dashboard support.
906
907         Rubber-stamped by Lucas Forschler.
908
909         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
910         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
911         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
912         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
913         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
914
915 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
916
917         Add Babak to contributors.json and add historical email addresses for some contributors
918         https://bugs.webkit.org/show_bug.cgi?id=137546
919
920         Reviewed by Christophe Dumez.
921
922         contributors.json is used to analyze historical commit data and change logs.
923
924         Add back historical email addresses for some contributors and also add Babak (Shafiei).
925
926         * Scripts/webkitpy/common/config/contributors.json:
927
928 2014-10-09  Lucas Forschler  <lforschler@apple.com>
929
930         Add Mac OS Yosemite webkit build infrastructure.
931         
932         This patch adds 15 bots to our build.webkit.org configuration.
933         We are matching the current Mavericks machines 1:1.
934         
935         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
936         
937         Reviewed by Matt Hanson.
938
939         * BuildSlaveSupport/build.webkit.org-config/config.json:
940
941 2014-10-09  Dana Burkart  <dburkart@apple.com>
942
943         Don't use backticks when running commands, as we run into sh-related
944         interpolation issues. Also, fix our usage of system() to properly
945         retrieve the status code.
946         https://bugs.webkit.org/show_bug.cgi?id=137541
947
948         Reviewed by Darin Adler.
949
950         * Scripts/git-add-reviewer:
951         (interactive):
952         (nonInteractive):
953         (requireCleanWorkTree):
954         (cherryPick):
955         (commit):
956         (addReviewerToFile):
957         (head):
958         (isAncestor):
959         (toCommit):
960         (changeLogsForCommit):
961         (resetToCommit):
962         (getConfigValue):
963         (runCommandWithOutput):
964
965 2014-10-09  Tim Horton  <timothy_horton@apple.com>
966
967         Add a WebKit1 preference for selection services
968         https://bugs.webkit.org/show_bug.cgi?id=137498
969         <rdar://problem/18572699>
970
971         Reviewed by Simon Fraser.
972
973         * MiniBrowser/mac/WK1BrowserWindowController.m:
974         (-[WK1BrowserWindowController awakeFromNib]):
975         Turn on image and selection services in the Legacy WebKit MiniBrowser.
976
977 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
978
979         Get the patch scripts running on Haiku
980         https://bugs.webkit.org/show_bug.cgi?id=137559
981
982         Reviewed by Benjamin Poulain.
983
984         Use /usr/bin/env instead of hardcoding path to perl.
985         Declare haiku platform in platforminfo.py to avoid check-webkit-style
986         failure.
987
988         * Scripts/commit-log-editor:
989         * Scripts/num-cpus:
990         * Scripts/prepare-ChangeLog:
991         * Scripts/run-launcher:
992         * Scripts/svn-create-patch:
993         * Scripts/webkitpy/common/system/platforminfo.py:
994         (PlatformInfo._determine_os_name):
995
996 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
997
998         StyleQueue should throw a PatchIsNotValid exception to achieve
999         consistency with CommitQueue and EWS
1000         https://bugs.webkit.org/show_bug.cgi?id=137500
1001
1002         Reviewed by Alexey Proskuryakov.
1003
1004         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1005         Adds a call to validate() in run().
1006         (StyleQueueTask.run):
1007         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1008         Adds a return False in the patch is not valid exception statement.
1009         (AbstractEarlyWarningSystem.review_patch):
1010         * Scripts/webkitpy/tool/commands/queues.py:
1011         Adds a return False in the patch is not valid exception statement in
1012         commit queue, and adds an except statement to catch PatchIsNotValid
1013         exceptions in style queue.
1014         (CommitQueue.process_work_item):
1015         (StyleQueue.review_patch):
1016
1017 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1018
1019         Race condition with WebKitWebView:is-loading after starting page load
1020         https://bugs.webkit.org/show_bug.cgi?id=136692
1021
1022         Reviewed by Gustavo Noronha Silva.
1023
1024         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1025         (loadChangedCallback): Only check is-loading is false when load
1026         has finished if the load didn't fail due to a cancellation.
1027         (loadFailedCallback): Only check is-loading is false if the load
1028         didn't fail due to a cancellation.
1029         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1030         (WebViewTest::loadURI): Check is-loading is true and active URI is
1031         the requested one rigth after requesting the load.
1032         (WebViewTest::loadHtml): Ditto.
1033         (WebViewTest::loadPlainText): Ditto.
1034         (WebViewTest::loadBytes): Ditto.
1035         (WebViewTest::loadRequest): Ditto.
1036         (WebViewTest::loadAlternateHTML): Ditto.
1037         (WebViewTest::goBack): Ditto.
1038         (WebViewTest::goForward): Ditto.
1039         (WebViewTest::goToBackForwardListItem): Ditto.
1040
1041 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
1042
1043         [Win] Resolve various static analyzer warnings in Tools.
1044         https://bugs.webkit.org/show_bug.cgi?id=137534
1045
1046         Reviewed by Dean Jackson.
1047
1048         * DumpRenderTree/cg/ImageDiffCG.cpp:
1049         (main): User proper printf specifiers.
1050         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1051         (AccessibilityUIElement::childrenCount): Handle possibility that
1052         gcc_accChildCount returns with an error.
1053         (accessibilityState): Ditto for gcc_accState.
1054         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1055         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
1056         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
1057         be treated as such.
1058         * DumpRenderTree/win/DumpRenderTree.cpp:
1059         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
1060         by comparing an unsigned value as being greater-than zero.
1061         * DumpRenderTree/win/EditingDelegate.cpp:
1062         (dump): Pass proper character pointer type to printf.
1063         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
1064         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1065         (EditingDelegate::shouldInsertNode): Ditto.
1066         (EditingDelegate::shouldInsertText): Ditto.
1067         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1068         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1069         (EditingDelegate::shouldApplyStyle): Ditto.
1070         * DumpRenderTree/win/EventSender.cpp:
1071         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
1072         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
1073         system headers.
1074         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
1075         from CreateDIBSection.
1076         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
1077         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
1078         older versions of MSVC we no longer support.
1079         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
1080         for 64-bit builds.
1081         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
1082         * TestWebKitAPI/TestsController.h: Ditto.
1083         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
1084         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
1085         performing bitwise | before the comparison is done.
1086
1087 2014-10-08  Ada Chan  <adachan@apple.com>
1088
1089         Add a test for WKPageIsPlayingAudio().
1090         https://bugs.webkit.org/show_bug.cgi?id=137048
1091
1092         Reviewed by Darin Adler.
1093
1094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1095         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
1096         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
1097         (TestWebKitAPI::nullJavaScriptCallback):
1098         (TestWebKitAPI::didFinishLoadForFrame):
1099         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
1100         (TestWebKitAPI::setUpClients):
1101         (TestWebKitAPI::TEST):
1102         This test loads a page with a video in it. When the page is loaded, we first check that
1103         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
1104         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
1105         now returns true for the page.
1106         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
1107         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
1108         This is a video copied from LayoutTests/media/content.
1109
1110 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
1111
1112         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
1113         https://bugs.webkit.org/show_bug.cgi?id=137516
1114
1115         Reviewed by Alexey Proskuryakov.
1116
1117         * Scripts/webkitpy/thirdparty/__init__.py:
1118         (AutoinstallImportHook._install_irc):
1119
1120 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1121
1122         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
1123         https://bugs.webkit.org/show_bug.cgi?id=137520
1124
1125         Reviewed by Philippe Normand.
1126
1127         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
1128         For other distributions, we are already installing libjpeg-turbo.
1129         So, do the same for Debian and derivatives.
1130
1131         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
1132
1133 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1134
1135         [webkitpy] Add back the workaround to replace ZipFile.extractall()
1136         https://bugs.webkit.org/show_bug.cgi?id=137519
1137
1138         Reviewed by Csaba Osztrogonác.
1139
1140         It was removed by <http://trac.webkit.org/changeset/174266>,
1141         because the comment stated it is a workaround for buggy python
1142         2.6.1 which shipped on Snow Leopard. But it turned out the bug
1143         is still valid with python 2.7 shipped on the latest Ubuntu
1144         (12.04 and 14.04) and OS X 10.9.
1145
1146         * Scripts/webkitpy/common/system/autoinstall.py:
1147         (AutoInstaller):
1148         (AutoInstaller._extract_all):
1149         (AutoInstaller._unzip):
1150
1151 2014-10-08  Commit Queue  <commit-queue@webkit.org>
1152
1153         Unreviewed, rolling out r174335.
1154         https://bugs.webkit.org/show_bug.cgi?id=137515
1155
1156         It broke EFL layout test totally (Requested by gyuyoung on
1157         #webkit).
1158
1159         Reverted changeset:
1160
1161         "[EFL] Introduce EWebKit_Extension"
1162         https://bugs.webkit.org/show_bug.cgi?id=134921
1163         http://trac.webkit.org/changeset/174335
1164
1165 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1166
1167         [GTK] Make forwarding headers generation depend on source code
1168         https://bugs.webkit.org/show_bug.cgi?id=137394
1169
1170         Reviewed by Philippe Normand.
1171
1172         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
1173         * TestWebKitAPI/PlatformGTK.cmake: Only run
1174         generate-forwarding-headers.pl when source code changes.
1175         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
1176
1177 2014-10-07  Tanay C  <tanay.c@samsung.com>
1178
1179         Remove build warnings in Hashmap API tests
1180         https://bugs.webkit.org/show_bug.cgi?id=137484
1181
1182         Reviewed by Darin Adler.
1183
1184         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1185         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
1186
1187 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
1188
1189         Commit queue doesn't drop obsolete patches sometimes
1190         https://bugs.webkit.org/show_bug.cgi?id=137460
1191
1192         Reviewed by Alexey Proskuryakov.
1193
1194         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1195         Adds another test patch for use in queues_unittest.py.
1196         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1197         (MockBugzilla):
1198         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1199         Raises a PatchIsNotValid exception in the case of validate() returning
1200         false.
1201         (CommitQueueTask.run):
1202         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1203         Raises a PatchIsNotValid exception in the case of validate() returning
1204         false.
1205         (EarlyWarningSystemTask.run):
1206         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1207         Defines PatchIsNotValid exception. 
1208         (PatchIsNotValid):
1209         (PatchIsNotValid.__init__):
1210         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1211         Remove call to validate() and instead catches the PatchIsNotValid
1212         exception.
1213         (AbstractEarlyWarningSystem.review_patch):
1214         * Scripts/webkitpy/tool/commands/queues.py:
1215         Adds logic to catch the PatchIsNotValid exception.
1216         (CommitQueue.process_work_item):
1217         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1218         Adds the test_non_valid_patch test to ensure that invalid patches are
1219         handled properly, and don't just result in indefinite spinning.
1220         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1221         (test_non_valid_patch):
1222
1223 2014-10-07  Daniel Bates  <dabates@apple.com>
1224
1225         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
1226         https://bugs.webkit.org/show_bug.cgi?id=137499
1227
1228         Reviewed by Simon Fraser.
1229
1230         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
1231         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
1232         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
1233         bit simulator builds of iOS WebKit.
1234
1235         * Scripts/webkitpy/port/ios.py:
1236         (IOSSimulatorPort._generate_all_test_configurations):
1237
1238 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1239
1240         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
1241         https://bugs.webkit.org/show_bug.cgi?id=137482
1242
1243         Reviewed by Martin Robinson.
1244
1245         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
1246
1247 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1248
1249         [SOUP] TLS errors should take precedence over HTTP authentication
1250         https://bugs.webkit.org/show_bug.cgi?id=137300
1251
1252         Reviewed by Sergio Villar Senin.
1253
1254         Add a test case to check that authenticate signal is not emitted
1255         in case of TLS errors, and the load fails instead.
1256
1257         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1258         (webViewAuthenticationCallback):
1259         (testTLSErrorsHTTPAuth):
1260         (httpsServerCallback):
1261         (beforeAll):
1262
1263 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
1264
1265         Make webkit-patch find-users useful
1266         https://bugs.webkit.org/show_bug.cgi?id=137475
1267
1268         Reviewed by Alexey Proskuryakov.
1269
1270         Make find-users use the CommitterList instead of accessing Bugzilla.
1271
1272         This essentially exposes the same functionality as webkitbot's whois command.
1273
1274         * Scripts/webkitpy/tool/commands/findusers.py:
1275         (FindUsers.execute):
1276
1277 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
1278
1279         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
1280         https://bugs.webkit.org/show_bug.cgi?id=137289
1281
1282         Unreviewed build fix.
1283
1284         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1285         (AccessibilityUIElement::getChildrenWithRange):
1286
1287 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1288
1289         build.webkit.org/dashboard: Add commit queue
1290         https://bugs.webkit.org/show_bug.cgi?id=137462
1291
1292         Reviewed by Tim Horton.
1293
1294         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
1295         Style queue is still invisible, as it doesn't have an associated platform, and also
1296         we never have problems with it anyway, so it's not worth watching.
1297
1298         The UI now allows for adding more bots to the Other column (such as leaks bot).
1299         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
1300         sources of data in a cell.
1301
1302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
1303         (BubbleQueue):
1304         (BubbleQueue.prototype.get statusPageURL):
1305         (BubbleQueue.prototype.update):
1306         (BubbleQueue.prototype.loadDetailedStatus):
1307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
1308         (BubbleQueueServer):
1309         (BubbleQueueServer.prototype.jsonQueueLengthURL):
1310         (BubbleQueueServer.prototype.jsonQueueStatusURL):
1311         (BubbleQueueServer.prototype.queueStatusURL):
1312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
1313         (BubbleQueueView):
1314         (BubbleQueueView.prototype.update.appendQueue):
1315         (BubbleQueueView.prototype.update):
1316         (BubbleQueueView.prototype._addQueueHeadingToPopover):
1317         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
1318         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
1319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
1320         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
1321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
1322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1323         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1325         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
1326         (.bubble-server-popover .latest-status-no-link):
1327         (.bubble-server-popover .bot-status-description):
1328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1329
1330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1331         (buildAggregateTable):
1332         (buildQueuesTable):
1333         Removed dysfunctional support for EWS for now. It will be different.
1334
1335 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1336
1337         One more case of incorrect comparison in recordpatchevent.py
1338         https://bugs.webkit.org/show_bug.cgi?id=137459
1339
1340         Reviewed by Tim Horton.
1341
1342         * QueueStatusServer/app.yaml:
1343         * QueueStatusServer/loggers/recordpatchevent.py:
1344         (RecordPatchEvent.started):
1345
1346 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1347
1348         webkit-queues PatchLog is incorrect for patches that took less than a second
1349         https://bugs.webkit.org/show_bug.cgi?id=137453
1350
1351         Reviewed by Tim Horton.
1352
1353         * QueueStatusServer/app.yaml: Updated app version.
1354
1355         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
1356         Don't bail out for patches that took 0 seconds to process (as frequently happens
1357         when a patch is obsolete).
1358
1359 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
1360
1361         EWS bubble hover shows wrong timestamps
1362         https://bugs.webkit.org/show_bug.cgi?id=137252
1363
1364         Reviewed by Alexey Proskuryakov.
1365
1366         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
1367
1368         * QueueStatusServer/handlers/queuestatusjson.py:
1369         (QueueStatusJSON.get):
1370         * QueueStatusServer/handlers/statusbubble.py:
1371         (StatusBubble._iso_time):
1372
1373 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
1374
1375         Unreviewed, updated list of email addresses in contributors.json
1376
1377         * Scripts/webkitpy/common/config/contributors.json: Added my former
1378         email address in Igalia, for the sake of completeness.
1379
1380 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1381
1382         Unreviewed, moved myself to the list of committers.
1383
1384         * Scripts/webkitpy/common/config/contributors.json:
1385
1386 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
1387
1388         [EFL] Introduce EWebKit_Extension
1389         https://bugs.webkit.org/show_bug.cgi?id=134921
1390
1391         Reviewed by Gyuyoung Kim.
1392
1393         * MiniBrowser/efl/main.c: Added x option to test extension path.
1394         (window_create):
1395         (elm_main):
1396         * Scripts/webkitpy/common/config/watchlist:
1397         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1398         * Scripts/webkitpy/style/checker.py:
1399         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1400
1401 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
1402
1403         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
1404         https://bugs.webkit.org/show_bug.cgi?id=137390
1405
1406         Reviewed by Carlos Garcia Campos.
1407
1408         * Scripts/update-webkit-libs-jhbuild:
1409
1410 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1411
1412         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
1413         https://bugs.webkit.org/show_bug.cgi?id=137391
1414
1415         Reviewed by Martin Robinson.
1416
1417         Add a custom command to only re-generate
1418         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
1419
1420         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1421
1422 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1423
1424         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
1425         https://bugs.webkit.org/show_bug.cgi?id=135502
1426
1427         Reviewed by Martin Robinson.
1428
1429         When writing to stdout/stderr fails due to a UnicodeDecodeError
1430         exception, try again without encoding the output.
1431
1432         * gtk/gtkdoc.py:
1433         (GTKDoc._run_command):
1434
1435 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1436
1437         Bugzilla status bubble displays an exception showing attachment 175738
1438         https://bugs.webkit.org/show_bug.cgi?id=137410
1439
1440         Reviewed by Tim Horton.
1441
1442         * QueueStatusServer/app.yaml: Update version.
1443
1444         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
1445         Don't fail even if expected status message is missing.
1446
1447         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
1448         the field in the same way it's defined in QueueStatus table.
1449
1450 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1451
1452         Record latest message in PatchLog for quick access
1453         https://bugs.webkit.org/show_bug.cgi?id=137405
1454
1455         Fixing a typo.
1456
1457         * QueueStatusServer/app.yaml:
1458         * QueueStatusServer/handlers/releasepatch.py:
1459
1460 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1461
1462         Record latest message in PatchLog for quick access
1463         https://bugs.webkit.org/show_bug.cgi?id=137405
1464
1465         Reviewed by Ryosuke Niwa.
1466
1467         It's no SQL...
1468
1469         * QueueStatusServer/handlers/releasepatch.py:
1470         * QueueStatusServer/handlers/updatestatus.py:
1471         * QueueStatusServer/loggers/recordpatchevent.py:
1472         * QueueStatusServer/model/patchlog.py:
1473
1474 2014-10-02  David Farler  <dfarler@apple.com>
1475
1476         -asan-blacklist option also renamed to generic -fsanitize-blacklist
1477         https://bugs.webkit.org/show_bug.cgi?id=137377
1478
1479         Reviewed by Daniel Bates.
1480
1481         * asan/asan.xcconfig:
1482         -asan-blacklist -> -fsanitize-blacklist
1483
1484         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1485
1486 2014-10-03  Roger Fong  <roger_fong@apple.com>
1487
1488         [Windows] Include batch size argument to layout tests on Windows.
1489
1490         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1491         (RunWebKitTests.start): 
1492         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
1493         These crashes seem to happen on random tests though generally in a spread out fashion.
1494         It seems possible that the DRT instance is being clobbered somehow after running too many
1495         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
1496
1497 2014-10-03  Roger Fong  <roger_fong@apple.com>
1498
1499         [Windows] Settle for 2 chid processes running NRWT on Windows.
1500
1501         * Scripts/webkitpy/port/win.py:
1502         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
1503
1504 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
1505
1506         [GTK] Bump up and patch dependencies to allow building for aarch64
1507         https://bugs.webkit.org/show_bug.cgi?id=137147
1508
1509         Reviewed by Martin Robinson.
1510
1511         The currently used versions of pixman, libffi, librsvg, glib,
1512         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
1513         and/or build for aarch64, so they are bumped up and patched where
1514         necessary. Wherever possible, the same versions and patches were used as
1515         for the EFL port bump-up
1516         (https://bugs.webkit.org/show_bug.cgi?id=135885).
1517
1518         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
1519         regression by crashing http/tests/media/video-redirect.html . A patch
1520         already in upstream fixes that bug.
1521
1522         This change does not touch xserver, which also needs bumping up, but 
1523         will be dealt with later.
1524
1525         * gtk/jhbuild.modules:
1526         Specified versions and patches necessary to correctly build for aarch64.
1527         * gtk/patches/gst-events-arent-gstobjects.patch:
1528         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
1529         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
1530         Added. Patches gst-plugins-base to configure correctly for aarch64.
1531         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
1532         Added. Bumps up config.guess and config.sub in librsvg to recognize
1533         aarch64.
1534         * gtk/patches/libxml2-2.9.0-dtd.patch:
1535         Removed. Not necessary for libxml2 v2.9.1 anymore.
1536
1537 2014-09-28  Sam Weinig  <sam@webkit.org>
1538
1539         Remove RefPtrHashMap
1540         https://bugs.webkit.org/show_bug.cgi?id=137200
1541
1542         Reviewed by Darin Adler.
1543
1544         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1545         (TestWebKitAPI::TEST):
1546         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
1547         a minimum of refcount churn occurs.
1548
1549 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1550
1551         Remove workarounds for versions of Python before 2.7
1552         https://bugs.webkit.org/show_bug.cgi?id=137338
1553
1554         Reviewed by Csaba Osztrogonác.
1555
1556         * Scripts/webkitpy/common/system/autoinstall.py:
1557         (AutoInstaller._extract_targz):
1558         (AutoInstaller._unzip):
1559         (AutoInstaller): Deleted.
1560         (AutoInstaller._extract_all): Deleted.
1561         * Scripts/webkitpy/common/webkitunittest.py:
1562         (TestCase.setUp): Deleted.
1563         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1564         (TestConfigurationConverter.collapse_macros):
1565         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1566         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1567         (TestConfigurationConverter):
1568         (TestConfigurationConverter.combinations): Deleted.
1569         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1570         * Scripts/webkitpy/port/base.py:
1571
1572 2014-10-03  Commit Queue  <commit-queue@webkit.org>
1573
1574         Unreviewed, rolling out r174264.
1575         https://bugs.webkit.org/show_bug.cgi?id=137392
1576
1577         It broke run-webkit-tests (Requested by ebalazsfalvi on
1578         #webkit).
1579
1580         Reverted changeset:
1581
1582         "Remove workarounds for versions of Python before 2.7"
1583         https://bugs.webkit.org/show_bug.cgi?id=137338
1584         http://trac.webkit.org/changeset/174264
1585
1586 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1587
1588         Remove workarounds for versions of Python before 2.7
1589         https://bugs.webkit.org/show_bug.cgi?id=137338
1590
1591         Reviewed by Csaba Osztrogonác.
1592
1593         * Scripts/webkitpy/common/system/autoinstall.py:
1594         (AutoInstaller._extract_targz):
1595         (AutoInstaller._unzip):
1596         (AutoInstaller): Deleted.
1597         (AutoInstaller._extract_all): Deleted.
1598         * Scripts/webkitpy/common/webkitunittest.py:
1599         (TestCase.setUp): Deleted.
1600         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1601         (TestConfigurationConverter.collapse_macros):
1602         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1603         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1604         (TestConfigurationConverter):
1605         (TestConfigurationConverter.combinations): Deleted.
1606         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1607         * Scripts/webkitpy/port/base.py:
1608         * Scripts/webkitpy/port/driver.py:
1609         (ContentBlock.__init__):
1610         * Scripts/webkitpy/port/server_process.py:
1611         (ServerProcess._reset):
1612
1613 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1614
1615         Remove autoinstaller workaround for python 2.6
1616         https://bugs.webkit.org/show_bug.cgi?id=137343
1617
1618         Reviewed by Daniel Bates.
1619
1620         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
1621         2.6, nor Snow Leopard is supported anymore, so the workaround is not
1622         needed anymore.
1623
1624         * Scripts/webkitpy/common/system/autoinstall.py:
1625         (AutoInstaller.install):
1626         * Scripts/webkitpy/test/main.py:
1627         (Tester._run_tests):
1628         * Scripts/webkitpy/thirdparty/__init__.py:
1629         (AutoinstallImportHook._install_mechanize):
1630         (AutoinstallImportHook._install_pep8):
1631         (AutoinstallImportHook._install_pylint):
1632         (AutoinstallImportHook._install_buildbot):
1633         (AutoinstallImportHook._install_coverage):
1634         (AutoinstallImportHook._install_eliza):
1635         (AutoinstallImportHook._install_irc):
1636         (AutoinstallImportHook._install):
1637         (autoinstall_everything):
1638
1639 2014-10-02  Daniel Bates  <dabates@apple.com>
1640
1641         Use version number 101000 instead of 10100 for OS X Yosemite
1642         https://bugs.webkit.org/show_bug.cgi?id=137372
1643
1644         Reviewed by Mark Rowe.
1645
1646         The version number for OS X Yosemite is 101000.
1647
1648         * DumpRenderTree/mac/TextInputController.m:
1649
1650 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
1651
1652         update-work-items should never delete items
1653         https://bugs.webkit.org/show_bug.cgi?id=137366
1654
1655         Reviewed by Ryosuke Niwa.
1656
1657         As we don't just replace the whole list any more, indicate which items are high
1658         priority, and which are not. Hight priority ones will be prepended to the queue,
1659         others will be appended.
1660
1661         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
1662         But hopefully we will never have many rollouts competing like that.
1663
1664         * QueueStatusServer/app.yaml: Update version.
1665
1666         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
1667         priority and regular items separately. Removed some error handling that used to
1668         end up in returning status 500 - an uncaught exception does that automatically.
1669
1670         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
1671
1672         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
1673
1674         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
1675         priority items.
1676
1677         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1678         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
1679         line that complicated testing.
1680
1681         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
1682
1683         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
1684         priority items into separate lists.
1685
1686         * Scripts/webkitpy/common/net/statusserver_mock.py:
1687         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1688         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1689         Updated tests.
1690
1691 2014-10-02  Brendan Long  <b.long@cablelabs.com>
1692
1693         Annoying build warnings in WTFString API tests
1694         https://bugs.webkit.org/show_bug.cgi?id=137360
1695
1696         Reviewed by Darin Adler.
1697
1698         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1699         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
1700
1701 2014-10-02  Roger Fong  <roger_fong@apple.com>
1702
1703         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
1704
1705         * Scripts/webkitpy/port/win.py:
1706         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
1707
1708 2014-10-02  David Farler  <dfarler@apple.com>
1709
1710         Move ASan arguments from LLVM (-mllvm) to the frontend
1711         https://bugs.webkit.org/show_bug.cgi?id=137365
1712
1713         Reviewed by David Kilzer.
1714
1715         * asan/asan.xcconfig:
1716         Remove the -mllvm prefix to the asan-blacklist argument, moving it
1717         to the clang frontend.
1718
1719         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1720
1721 2014-10-02  Commit Queue  <commit-queue@webkit.org>
1722
1723         Unreviewed, rolling out r174120.
1724         https://bugs.webkit.org/show_bug.cgi?id=137350
1725
1726         While number of failures is reasonable with 2 processes, test
1727         results seem to be inconsistent between runs (Requested by
1728         rfong on #webkit).
1729
1730         Reverted changeset:
1731
1732         "[Windows] Back to 2 child processes for NRWT on Windows."
1733         http://trac.webkit.org/changeset/174120
1734
1735 2014-10-02  Jeff Miller  <jeffm@apple.com>
1736
1737         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
1738         https://bugs.webkit.org/show_bug.cgi?id=137347
1739
1740         Reviewed by Dan Bernstein.
1741
1742         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1743         Use WebKitSystemInterfaceYosemite on OS X 10.10.
1744
1745         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1746         Ditto.
1747
1748 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1749
1750         [GTK] [JHBuild] Switch sourceware.org mirror to http.
1751
1752         Unreviewed.
1753
1754         The ftp access is recently failing to work as expected, and the
1755         bots fail to download the file.
1756         The same mirror is available via http and seems to work better.
1757
1758         * gtk/jhbuild.modules:
1759
1760 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1761
1762         Unreviewed, rolling out r174185.
1763         https://bugs.webkit.org/show_bug.cgi?id=137334
1764
1765         Patch that adds logging causes webkitpy failures (Requested by
1766         rfong on #webkit).
1767
1768         Reverted changeset:
1769
1770         "commitqueuetasks_unittest references a non-existent member
1771         variable"
1772         https://bugs.webkit.org/show_bug.cgi?id=137303
1773         http://trac.webkit.org/changeset/174185
1774
1775 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1776
1777         EWS and Commit Queue should know better than to spew 500 failed
1778         results in the case of extremely red patches.
1779         https://bugs.webkit.org/show_bug.cgi?id=137324
1780
1781         Reviewed by Alexey Proskuryakov.
1782
1783         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1784         Adds a check for did_exceed_test_failure_limit.
1785         (AbstractEarlyWarningSystem._failing_tests_message):
1786         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1787         Alters the task mock to respond properly to
1788         results_from_patch_test_run(patch)
1789         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1790         * Scripts/webkitpy/tool/commands/queues.py:
1791         Adds a check for did_exceed_test_failure_limit.
1792         (CommitQueue._failing_tests_message):
1793
1794 2014-10-01  Daniel Bates  <dabates@apple.com>
1795
1796         Unreviewed, rolling out r174192.
1797
1798         Revert the unit test fix in r174192 since we reverted r174187
1799         in r174194 due to correctness issues. See
1800         <http://webkit.org/b/137329> for more details.
1801
1802         Reverted changeset:
1803
1804         "Test fix after r174187"
1805         http://trac.webkit.org/changeset/174192
1806
1807 2014-10-01  Mark Rowe  <mrowe@apple.com>
1808
1809         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
1810
1811         Reviewed by Dan Bernstein.
1812
1813         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
1814         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
1815         for the LLVM components when on Yosemite.
1816
1817 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1818
1819         Unreviewed, rolling out r174187.
1820         https://bugs.webkit.org/show_bug.cgi?id=137329
1821
1822         webkitpy failures, and thorton says the patch is wrong
1823         (Requested by dethbakin on #webkit).
1824
1825         Reverted changeset:
1826
1827         "[Windows] Increase layout test timeout for Windows following
1828         r174162."
1829         http://trac.webkit.org/changeset/174187
1830
1831 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
1832
1833         Test fix after r174187
1834
1835         * Scripts/webkitpy/port/win_unittest.py:
1836         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
1837
1838 2014-10-01  Roger Fong  <roger_fong@apple.com>
1839
1840         [Windows] Increase layout test timeout for Windows following r174162.
1841
1842         * Scripts/webkitpy/port/win.py:
1843         (WinPort.default_timeout_ms):
1844
1845 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1846
1847         commitqueuetasks_unittest references a non-existent member variable
1848         when mock-reporting flaky tests.
1849         https://bugs.webkit.org/show_bug.cgi?id=137303
1850
1851         Reviewed by Daniel Bates.
1852
1853         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1854         (MockCommitQueue.report_flaky_tests):
1855         Makes the appropriate name change.
1856         (test_simple_flaky_test_failure):
1857         Adds a unit test to make sure that the code is excercised.
1858
1859 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1860
1861         EWS is inconclusively spinning forever on a patch that breaks 500+
1862         tests
1863         https://bugs.webkit.org/show_bug.cgi?id=137223
1864
1865         Reviewed by Tim Horton.
1866
1867         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1868         Checks to see whether the tests have exceeded the failure limit, and
1869         only spins off another test if they have not exceeded the limit.
1870         (PatchAnalysisTask._test_patch):
1871
1872 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
1873
1874         Unreviewed, add Katie Madonna as a contributor.
1875
1876         * Scripts/webkitpy/common/config/contributors.json:
1877
1878 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1879
1880         commitqueuetasks_unittest does not construct FailingTestCommitQueue
1881         objects properly in its test cases.
1882         https://bugs.webkit.org/show_bug.cgi?id=137281
1883
1884         Reviewed by Daniel Bates.
1885
1886         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1887         (FailingTestCommitQueue.test_results):
1888         Adds an assert to make FailingTestCommitQueue harder to mis-use.
1889         (test_double_flaky_test_failure):
1890         Nests the intended test failure strings into one-length lists.
1891         (test_red_test_failure):
1892         Nests the intended test failure strings into one-length lists.
1893
1894 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1895
1896         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
1897         https://bugs.webkit.org/show_bug.cgi?id=136987
1898
1899         Reviewed by Daniel Bates.
1900
1901         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1902         Specify the default encoding for all WebKit developers to get consistent results.
1903
1904 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1905
1906         EWS is too eager to say that a patch does not apply to trunk of repository
1907         https://bugs.webkit.org/show_bug.cgi?id=137290
1908
1909         Reviewed by Ryosuke Niwa.
1910
1911         * QueueStatusServer/app.yaml: Updated app version.
1912
1913         * QueueStatusServer/handlers/statusbubble.py:
1914         (StatusBubble._build_bubble):
1915         (StatusBubble._build_bubbles_for_attachment):
1916         Rewrote to make more sense.
1917
1918 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1919
1920         Remove thirdparty/unittest2 from webkitpy
1921         https://bugs.webkit.org/show_bug.cgi?id=137251
1922
1923         Reviewed by Brent Fulgham.
1924
1925         Additionally ordered imports in related webkitpy files and
1926         removed unnecessary shebangs from unittest files.
1927
1928         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
1929         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1930         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1931         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1932         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1933         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1934         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1935         * Scripts/webkitpy/common/config/committers_unittest.py:
1936         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1937         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
1938         * Scripts/webkitpy/common/config/ports_unittest.py:
1939         * Scripts/webkitpy/common/config/urls_unittest.py:
1940         * Scripts/webkitpy/common/editdistance_unittest.py:
1941         * Scripts/webkitpy/common/find_files_unittest.py:
1942         * Scripts/webkitpy/common/lru_cache_unittest.py:
1943         * Scripts/webkitpy/common/memoized_unittest.py:
1944         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1945         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1946         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1947         * Scripts/webkitpy/common/net/credentials_unittest.py:
1948         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1949         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
1950         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1951         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1952         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1953         * Scripts/webkitpy/common/net/statusserver_unittest.py:
1954         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1955         * Scripts/webkitpy/common/newstringio_unittest.py:
1956         * Scripts/webkitpy/common/prettypatch_unittest.py:
1957         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1958         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1959         * Scripts/webkitpy/common/system/environment_unittest.py:
1960         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
1961         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
1962         * Scripts/webkitpy/common/system/executive_unittest.py:
1963         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1964         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1965         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1966         * Scripts/webkitpy/common/system/logtesting.py:
1967         * Scripts/webkitpy/common/system/logutils_unittest.py:
1968         * Scripts/webkitpy/common/system/outputcapture.py:
1969         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1970         * Scripts/webkitpy/common/system/outputtee_unittest.py:
1971         * Scripts/webkitpy/common/system/path_unittest.py:
1972         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1973         * Scripts/webkitpy/common/system/profiler_unittest.py:
1974         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
1975         * Scripts/webkitpy/common/system/user_unittest.py:
1976         * Scripts/webkitpy/common/system/workspace_unittest.py:
1977         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1978         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
1979         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
1980         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
1981         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
1982         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
1983         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1984         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
1985         * Scripts/webkitpy/common/webkitunittest.py:
1986         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1987         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1988         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1989         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1990         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1991         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1992         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1993         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1994         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
1995         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1996         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1997         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1998         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
1999         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2000         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2001         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
2002         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2003         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2004         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2005         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2006         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2007         * Scripts/webkitpy/port/base_unittest.py:
2008         * Scripts/webkitpy/port/builders_unittest.py:
2009         * Scripts/webkitpy/port/config_unittest.py:
2010         * Scripts/webkitpy/port/driver_unittest.py:
2011         * Scripts/webkitpy/port/efl_unittest.py:
2012         * Scripts/webkitpy/port/factory_unittest.py:
2013         * Scripts/webkitpy/port/gtk_unittest.py:
2014         * Scripts/webkitpy/port/http_lock_unittest.py:
2015         * Scripts/webkitpy/port/image_diff_unittest.py:
2016         * Scripts/webkitpy/port/leakdetector_unittest.py:
2017         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
2018         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2019         * Scripts/webkitpy/port/mock_drt_unittest.py:
2020         * Scripts/webkitpy/port/port_testcase.py:
2021         * Scripts/webkitpy/port/server_process_unittest.py:
2022         * Scripts/webkitpy/port/westondriver_unittest.py:
2023         * Scripts/webkitpy/port/win_unittest.py:
2024         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2025         * Scripts/webkitpy/style/checker_unittest.py:
2026         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2027         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2028         * Scripts/webkitpy/style/checkers/common_unittest.py:
2029         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2030         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
2031         * Scripts/webkitpy/style/checkers/js_unittest.py:
2032         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
2033         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
2034         * Scripts/webkitpy/style/checkers/png_unittest.py:
2035         * Scripts/webkitpy/style/checkers/python_unittest.py:
2036         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2037         * Scripts/webkitpy/style/checkers/text_unittest.py:
2038         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
2039         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
2040         * Scripts/webkitpy/style/checkers/xml_unittest.py:
2041         * Scripts/webkitpy/style/error_handlers_unittest.py:
2042         * Scripts/webkitpy/style/filereader_unittest.py:
2043         * Scripts/webkitpy/style/filter_unittest.py:
2044         * Scripts/webkitpy/style/main_unittest.py:
2045         * Scripts/webkitpy/style/optparser_unittest.py:
2046         * Scripts/webkitpy/style/patchreader_unittest.py:
2047         * Scripts/webkitpy/test/finder_unittest.py:
2048         * Scripts/webkitpy/test/main.py: Ordered imports.
2049         * Scripts/webkitpy/test/main_unittest.py:
2050         * Scripts/webkitpy/test/printer.py: Ordered imports.
2051         (Printer.configure):
2052         * Scripts/webkitpy/test/runner_unittest.py:
2053         * Scripts/webkitpy/test/skip_unittest.py:
2054         * Scripts/webkitpy/thirdparty/__init__.py:
2055         (AutoinstallImportHook._install_irc):
2056         (AutoinstallImportHook._install_unittest2): Deleted.
2057         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2058         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
2059         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2060         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2061         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2062         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2063         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2064         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2065         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2066         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2067         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2068         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2069         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2070         * Scripts/webkitpy/tool/commands/download_unittest.py:
2071         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2072         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
2073         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2074         * Scripts/webkitpy/tool/commands/queuestest.py:
2075         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2076         * Scripts/webkitpy/tool/grammar_unittest.py:
2077         * Scripts/webkitpy/tool/mocktool_unittest.py:
2078         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2079         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2080         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2081         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
2082         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
2083         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2084         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2085         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2086         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2087         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
2088         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2089         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2090         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2091         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2092         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2093         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2094         * Scripts/webkitpy/tool/steps/update_unittest.py:
2095         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2096         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2097         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2098         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2099         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2100
2101 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
2102
2103         LayoutTestResults and ExpectedFailures should know about the
2104         interrupted flag from the json results file
2105         https://bugs.webkit.org/show_bug.cgi?id=137229
2106
2107         Reviewed by Daniel Bates.
2108
2109         Changes LayoutTestResults to use the interrupted flag instead of
2110         counting failures.
2111
2112         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2113         (BuilderTest._install_fetch_build._mock_fetch_build):
2114         (BuilderTest.test_latest_layout_test_results):
2115         * Scripts/webkitpy/common/net/layouttestresults.py:
2116         Removes notion of failure_limit_count, and adds
2117         did_exceed_test_failure_limit.
2118
2119         (LayoutTestResults.results_from_string):
2120         (LayoutTestResults.__init__):
2121         (LayoutTestResults.did_exceed_test_failure_limit):
2122         (LayoutTestResults): Deleted.
2123         (LayoutTestResults.set_failure_limit_count): Deleted.
2124         (LayoutTestResults.failure_limit_count): Deleted.
2125         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2126         Removes unit test for failure_limit_count logic.
2127
2128         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
2129         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2130         Instead of providing a class method that returns a list of
2131         TestResults objects, resultsjsonparser now provides a class
2132         ParsedJSONResults that serves as an interface between the results.json
2133         file and the rest of webkitpy.
2134
2135         (ParsedJSONResults):
2136         (ParsedJSONResults.__init__):
2137         (ParsedJSONResults.did_exceed_test_failure_limit):
2138         (ParsedJSONResults.test_results):
2139         (ResultsJSONParser): Deleted.
2140         (ResultsJSONParser.parse_results_json): Deleted.
2141         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2142         Updates the unit test so that it can test the new ResultsJSONParser
2143         class.
2144
2145         (ParsedJSONResultsTest):
2146         (test_basic):
2147         (ResultsJSONParserTest): Deleted.
2148         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2149         Updates the unit test to instantiate ResultsJSONParser objects rather
2150         than simple lists of TestResult objects.
2151
2152         (MockCommitQueue.test_results):
2153         (FailingTestCommitQueue.test_results):
2154         (test_flaky_test_failure):
2155         (test_failed_archive):
2156         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2157         Updates ExpectedFailures to use the did_exceed_test_failure_limit
2158         method rather than counting the number of failed tests.
2159
2160         (ExpectedFailures._should_trust):
2161         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2162         Updates MockResults to more closely resemble the updated
2163         LayoutTestResults class.
2164
2165         (MockResults.__init__):
2166         (MockResults.did_exceed_test_failure_limit):
2167         (ExpectedFailuresTest.test_can_trust_results):
2168         (ExpectedFailuresTest.test_unexpected_failures_observed):
2169         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
2170         (MockResults.failure_limit_count): Deleted.
2171         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2172         Removes a FIXME regarding the use of the
2173         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
2174
2175         (LayoutTestResultsReader.results):
2176         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2177         Updates test to not check the now-nonexistant failure_count_limit
2178         method.
2179
2180         (test_missing_unit_test_results_path):
2181         (test_layout_test_results):
2182         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2183         Accounts for name change: ResultsJSONParserTest ->
2184         ParsedJSONParserTest.
2185
2186         (RebaselineTestTest.test_gather_baselines):
2187
2188 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2189
2190         [EFL] Rename TEST_THEME_DIR macro
2191         https://bugs.webkit.org/show_bug.cgi?id=137244
2192
2193         Reviewed by Csaba Osztrogonác.
2194
2195         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
2196         DEFAULT_THEME_DIR is better than it.
2197
2198         * MiniBrowser/efl/main.c:
2199         (window_create):
2200         * TestWebKitAPI/efl/PlatformWebView.cpp:
2201         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2202         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2203         (WTR::PlatformWebView::PlatformWebView):
2204
2205 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2206
2207         Windows EWS went purple when it failed to build
2208         https://bugs.webkit.org/show_bug.cgi?id=137267
2209
2210         Reviewed by Ryosuke Niwa.
2211
2212         * QueueStatusServer/app.yaml: Update the version.
2213
2214         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
2215         Make it work for style and win-ews queues.
2216
2217 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
2218
2219         It should be fun and easy to run every possible JavaScript benchmark from the command line
2220         https://bugs.webkit.org/show_bug.cgi?id=137245
2221
2222         Reviewed by Oliver Hunt.
2223         
2224         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
2225         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
2226         having their own private scripts for doing benchmark runs, and didn't share them in the open
2227         source community, because of fears about the shady licensing of the benchmarks suites that
2228         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
2229         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
2230         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
2231         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
2232         but some of them are. The non-public tests are exclusively those that were not made by any
2233         WebKit contributor, but which JSC/WebKit devs found useful for testing.
2234
2235         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
2236         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
2237         checked into WebKit svn at all) can be run by passing the path to them via a configuration
2238         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
2239         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
2240         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
2241         probably never be checked in because there is no license text anywhere in that benchmark.
2242         A valid ~/.run-jsc-benchmarks file will just be something like:
2243         
2244             {
2245                 "OctanePath": "/path/to/Octane2",
2246                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
2247             }
2248         
2249         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
2250         run-jsc-benchmarks will just gracefully avoid running that test suite.
2251         
2252         Finally, a word about policy: it is understood that different organizations that do
2253         development on JSC may find themselves having internal benchmarks that they cannot share
2254         because of weird licensing. It happens - usually because the organization doing JSC
2255         development found some test in the wild that is owned by someone else and therefore cannot
2256         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
2257         that add support for some new kind of benchmark suite even if the suite is not made public
2258         as part of the same patch - so long as the patch isn't too invasive. An example of
2259         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
2260         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
2261         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
2262         completely open-sourced and committed to the WebKit repo - but the reality is that this
2263         can't always be done safely.
2264
2265         * Scripts/bencher: Removed.
2266         * Scripts/run-jsc-benchmarks: Added.
2267
2268 2014-09-30  Roger Fong  <roger_fong@apple.com>
2269
2270         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
2271
2272         * Scripts/webkitpy/port/drdiver.py:
2273         (Driver.stop):
2274         * Scripts/webkitpy/port/server_process.py:
2275         (ServerProcess.stop):
2276
2277 2014-09-30  Roger Fong  <roger_fong@apple.com>
2278
2279         [Windows] Back to 2 child processes for NRWT on Windows.
2280
2281         * Scripts/webkitpy/port/win.py:
2282         (WinPort.default_child_processes):
2283         Changing the number of processes to 1 did not have an effect on the layout test results. 
2284         It does introduce an issue with one of the workers hanging indefinitely and causing the 
2285         layout tests to timeout as a whole occasionally, but we should just fix that.
2286
2287 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2288
2289         Remove an accidentally committed line..
2290
2291         * QueueStatusServer/handlers/statusbubble.py:
2292         (StatusBubble._build_bubble):
2293
2294 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2295
2296         build.webkit.org/dashboard: Switch EWS view to using actual retry count
2297         https://bugs.webkit.org/show_bug.cgi?id=137240
2298
2299         Reviewed by Ryosuke Niwa.
2300
2301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2302         (EWSQueue.prototype.loadDetailedStatus):
2303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2304         (EWSQueueView.prototype._popoverContentForEWSQueue):
2305         Use the new retry_count data member from JSON.
2306
2307         * QueueStatusServer/app.yaml: Updating the version.
2308
2309         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
2310         Instead of message_count, produce retry_count.
2311
2312 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2313
2314         EWS doesn't need to show all the bubbles when a patch fails to apply
2315         https://bugs.webkit.org/show_bug.cgi?id=137256
2316
2317         Reviewed by Ryosuke Niwa.
2318
2319         * QueueStatusServer/app.yaml: Updated app version.
2320
2321         * QueueStatusServer/handlers/statusbubble.py:
2322         (StatusBubble._build_bubble):
2323         (StatusBubble._build_bubbles_for_attachment):
2324         (StatusBubble.get):
2325         * QueueStatusServer/templates/statusbubble.html:
2326         When some queues fail to apply, and no queues had meaningful output (meaning that
2327         they will almost certainly fail to apply later), we can show a single bubble
2328         telling the user just that.
2329
2330 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2331
2332         [EFL] Bump EFL version to 1.11.2
2333         https://bugs.webkit.org/show_bug.cgi?id=137118
2334
2335         Reviewed by Gyuyoung Kim.
2336
2337         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
2338         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
2339
2340         * efl/jhbuild.modules:
2341         * efl/patches/ecore.patch: Removed.
2342
2343 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2344
2345         REGRESSION(r173929): [GTK] TestInspector fails after r173929
2346         https://bugs.webkit.org/show_bug.cgi?id=137247
2347
2348         Reviewed by Philippe Normand.
2349
2350         Wait until can-attach property changes before trying to attach the
2351         inspector after resizing the view.
2352
2353         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
2354         (testInspectorDefault):
2355
2356 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2357
2358         Require Python 2.7 version
2359         https://bugs.webkit.org/show_bug.cgi?id=137112
2360
2361         Reviewed by Csaba Osztrogonác.
2362
2363         * Scripts/ensure-valid-python:
2364         (checkPythonVersion):
2365         * Scripts/webkitpy/common/version_check.py:
2366
2367 2014-09-30  Martin Hock  <mhock@apple.com>
2368
2369         Skip a JSC test after r174036.
2370         https://bugs.webkit.org/show_bug.cgi?id=137236
2371
2372         Reviewed by Csaba Osztrogonác.
2373
2374         * Scripts/run-javascriptcore-tests:
2375
2376 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2377
2378         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
2379         https://bugs.webkit.org/show_bug.cgi?id=137212
2380
2381         This moves TestNetscapePlugin to a new folder (lib/plugins).
2382         We should not use the same directory for TestNetscapePlugin and
2383         the other libraries, because we end up scanning all the .so in the
2384         lib dir for every test.
2385
2386         Reviewed by Carlos Garcia Campos.
2387
2388         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
2389         * Scripts/webkitpy/port/efl.py:
2390         (EflPort.setup_environ_for_server): Update plugin path.
2391         * Scripts/webkitpy/port/gtk.py:
2392         (GtkPort.setup_environ_for_server): Update plugin path.
2393         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
2394
2395 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2396
2397         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
2398
2399         Rubber-stamped by Tim Horton.
2400
2401         * QueueStatusServer/app.yaml:
2402         * QueueStatusServer/handlers/statusbubble.py:
2403         (StatusBubble._build_bubble):
2404
2405 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2406
2407         Typo fix, suggested by Tim Horton.
2408
2409         * QueueStatusServer/handlers/statusbubble.py:
2410         (StatusBubble._build_message_for_provisional_failure):
2411
2412 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2413
2414         Improve Bugzilla status bubbles
2415         https://bugs.webkit.org/show_bug.cgi?id=137232
2416
2417         Reviewed by Ryosuke Niwa.
2418
2419         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
2420
2421         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
2422         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
2423         that are stuck, as it was only confusing that they disappeared after 99.
2424
2425         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
2426         by old bubbles. We need a lot more information to determine color, so the implementation
2427         can not be here.
2428
2429         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
2430         always have a link for consistency. Added code to convert timestamps in tooltips
2431         to local time zone.
2432
2433 2014-09-29  Commit Queue  <commit-queue@webkit.org>
2434
2435         Unreviewed, rolling out r174045.
2436         https://bugs.webkit.org/show_bug.cgi?id=137231
2437
2438         Introduced a crash during page loading tests on Mac (Requested
2439         by rniwa on #webkit).
2440
2441         Reverted changeset:
2442
2443         "Replace OSObjectPtr with RetainPtr/adoptOS"
2444         https://bugs.webkit.org/show_bug.cgi?id=137158
2445         http://trac.webkit.org/changeset/174045
2446
2447 2014-09-29  Tim Horton  <timothy_horton@apple.com>
2448
2449         Add Jake as a contributor.
2450
2451         * Scripts/webkitpy/common/config/contributors.json:
2452
2453 2014-09-29  Roger Fong  <roger_fong@apple.com>
2454
2455         [Windows] Skip a javascriptcore test following r174036.
2456
2457         * Scripts/run-javascriptcore-tests:
2458
2459 2014-09-29  Roger Fong  <roger_fong@apple.com>
2460
2461         [Windows] Reduce number of processes used by NRWT on Windows to 1.
2462
2463         * Scripts/webkitpy/port/win.py:
2464         (WinPort.default_child_processes):
2465         Reduce number of processes to 1 so we can get a good baseline for what failures
2466         we should be expecting to see from the Windows bots.
2467
2468 2014-09-29  Darin Adler  <darin@apple.com>
2469
2470         Tweak and tighten SVG font converter
2471         https://bugs.webkit.org/show_bug.cgi?id=136956
2472
2473         Reviewed by Myles Maxfield.
2474
2475         I was investigating behavior of String::toInt, String::toDouble, and
2476         String::toFloat for various failure cases, and decided to start some
2477         unit tests for those functions here.
2478
2479         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2480         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
2481         StringToDouble testing.
2482
2483 2014-09-29  Philippe Normand  <pnormand@igalia.com>
2484
2485         [GTK][CMake] TestWebCore target build sometimes fail
2486         https://bugs.webkit.org/show_bug.cgi?id=137207
2487
2488         Reviewed by Csaba Osztrogon.
2489
2490         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
2491         headers are generated before the TestWebCore target is built.
2492
2493 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2494
2495         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
2496         https://bugs.webkit.org/show_bug.cgi?id=137209
2497
2498         Reviewed by Philippe Normand.
2499
2500         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
2501         from the WebCore test sources.
2502
2503 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
2504
2505         Allow webkit-patch upload to respect the --directory argument with git checkouts
2506         https://bugs.webkit.org/show_bug.cgi?id=137166
2507
2508         Reviewed by Darin Adler.
2509
2510         We simply hadn't plumbed it through.
2511
2512         * Scripts/webkitpy/common/checkout/scm/detection.py:
2513         (SCMDetector.detect_scm_system):
2514         * Scripts/webkitpy/common/checkout/scm/git.py:
2515         (Git.__init__):
2516         (Git.changed_files):
2517
2518 2014-09-26  Sam Weinig  <sam@webkit.org>
2519
2520         Replace OSObjectPtr with RetainPtr/adoptOS
2521         https://bugs.webkit.org/show_bug.cgi?id=137158
2522
2523         Reviewed by Dan Bernstein.
2524
2525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2526         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
2527         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
2528         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
2529
2530 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
2531
2532         Disable function.arguments
2533         https://bugs.webkit.org/show_bug.cgi?id=137167
2534
2535         Rubber stamped by Geoffrey Garen
2536         
2537         Enable the feature by default during tests.
2538
2539         * Scripts/run-jsc-stress-tests:
2540
2541 2014-09-26  Beth Dakin  <bdakin@apple.com>
2542
2543         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
2544         https://bugs.webkit.org/show_bug.cgi?id=137089
2545
2546         Reviewed by Tim Horton.
2547
2548         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
2549         tests run at 1x, but that code does not seem to execute at the right time for 
2550         these tests, so if we just ensure we start out at 1x, that appears to fix these 
2551         tests and does not break the HiDPI tests either.
2552         * WebKitTestRunner/TestController.cpp:
2553         (WTR::TestController::createWebViewWithOptions):
2554
2555 2014-09-26  Roger Fong  <roger_fong@apple.com>
2556
2557         [Windows] Decrease default number of child processes used by Windows.
2558
2559         * Scripts/webkitpy/port/win.py:
2560         (WinPort.default_child_processes):
2561         Having too many seems to cause many tests to crash or timeout. 
2562         We may even need to make it have only 1 child process if we’re still seeing problems after this.
2563
2564 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2565
2566         Mac EWS bots do not keep logs as promised
2567         https://bugs.webkit.org/show_bug.cgi?id=137151
2568
2569         Reviewed by Ryosuke Niwa.
2570
2571         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
2572
2573 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2574
2575         Get rid of webkit-queues dashboard
2576         https://bugs.webkit.org/show_bug.cgi?id=137141
2577
2578         Reviewed by Ryosuke Niwa.
2579
2580         * QueueStatusServer/app.yaml: Updated version.
2581
2582         * QueueStatusServer/templates/dashboard.html: Removed.
2583         * QueueStatusServer/handlers/dashboard.py: Removed.
2584         * QueueStatusServer/main.py:
2585         Kill it!
2586
2587         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
2588         (.status-cell): Deleted.
2589         (.status-cell:hover): Deleted.
2590         (.status-cell.pass): Deleted.
2591         (.status-cell.fail): Deleted.
2592         (.status-cell.pending): Deleted.
2593         (.status-cell.error): Deleted.
2594         * QueueStatusServer/stylesheets/dashboard.css: Removed.
2595         * QueueStatusServer/templates/activebots.html:
2596         * QueueStatusServer/templates/patch.html:
2597         * QueueStatusServer/templates/queuestatus.html:
2598         * QueueStatusServer/templates/recentstatus.html:
2599         Renamed dashboard.css to common.css, and removed dashboard-only rules.
2600
2601 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2602
2603         Get rid of Retry status in webkit-queues
2604         https://bugs.webkit.org/show_bug.cgi?id=137135
2605
2606         Reviewed by Ryosuke Niwa.
2607
2608         * QueueStatusServer/config/messages.py: Removed Retry.
2609
2610         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
2611         no longer needs to check the latest status. It just always both unlocks the patch
2612         and removes it from WorkItems.
2613
2614         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
2615         I don't understand why we even needed to check for retries here, but now that there
2616         are no retries, that code can go to /dev/null.
2617
2618         * QueueStatusServer/loggers/recordpatchevent.py:
2619         (RecordPatchEvent.started):
2620         (RecordPatchEvent.retrying): Deleted.
2621         Fixed retry counting, it should work for all queues now.
2622
2623         * QueueStatusServer/model/queuestatus.py:
2624         (QueueStatus.is_retry_request): Deleted. These are no more.
2625
2626         * Scripts/webkitpy/common/net/statusserver_mock.py:
2627         (MockStatusServer.release_lock):
2628         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2629         Did whatever it took to keep passing the tests. The particular test doesn't seem
2630         quite right, but whatever.
2631
2632         * Scripts/webkitpy/tool/commands/queues.py:
2633         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
2634         and let others pick up. Also, added explicit returns for clarity.
2635         (AbstractPatchQueue._did_retry): Deleted.
2636
2637 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
2638
2639         [EFL] Fix the gst-libav build on ARM Thumb2
2640         https://bugs.webkit.org/show_bug.cgi?id=137022
2641
2642         Reviewed by Zoltan Herczeg.
2643
2644         * efl/jhbuild.modules:
2645         * efl/patches/gst-libav.patch: Added.
2646
2647 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
2648
2649         [EFL] Bump up dependencies not to conflict with the GTK port.
2650         https://bugs.webkit.org/show_bug.cgi?id=137143
2651
2652         Reviewed by Gyuyoung Kim.
2653
2654         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
2655         installing and removing different versions of libgnutls-dev, thus
2656         hindering the development for both ports on the same machine. GTK is
2657         using the newer version of the package, now bumping up EFL to use the 
2658         same.
2659
2660         * efl/install-dependencies:
2661
2662 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
2663
2664         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
2665         https://bugs.webkit.org/show_bug.cgi?id=136854
2666
2667         Reviewed by Gyuyoung Kim.
2668
2669         'Escape' key should exit fullscreen first and then should be used to stop page load.
2670
2671         * MiniBrowser/efl/main.c:
2672         (on_key_down):
2673
2674 2014-09-25  Dean Jackson  <dino@apple.com>
2675
2676         Add Said to the contributors list so his name completes in bugzilla.
2677
2678         * Scripts/webkitpy/common/config/contributors.json:
2679
2680 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
2681
2682         EWS only repeats its cycle every two hours
2683         https://bugs.webkit.org/show_bug.cgi?id=137129
2684
2685         Reviewed by Ryosuke Niwa.
2686
2687         * QueueStatusServer/app.yaml: Updated version.
2688
2689         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
2690
2691         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
2692         the patch from work items.
2693
2694         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
2695
2696         * QueueStatusServer/main.py: Added release-lock.
2697
2698         * QueueStatusServer/model/activeworkitems.py:
2699         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
2700
2701         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
2702         we don't want it to be immediately picked up again, it's better to give other patches
2703         a chance.
2704
2705         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
2706         these interactive versions, but OK.
2707
2708         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
2709         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
2710         or svn is down).
2711
2712         * Scripts/webkitpy/tool/commands/queues.py:
2713         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
2714         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
2715         meaning that these handlers could never do the right thing. We'd either get a duplicate
2716         _did_fail, or try to unlock an already unlocked patch.
2717         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
2718         making it eligible for retry immediately.
2719
2720         * Scripts/webkitpy/common/net/statusserver.py:
2721         (StatusServer._post_release_lock):
2722         (StatusServer.release_lock):
2723         Added a call to release-lock.
2724
2725 2014-09-25  Roger Fong  <roger_fong@apple.com>
2726
2727         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
2728
2729         * Scripts/webkitpy/common/system/path.py:
2730         (_CygPath.convert):
2731
2732 2014-09-25  Roger Fong  <roger_fong@apple.com>
2733
2734         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
2735
2736         * Scripts/webkitpy/common/system/path.py:
2737         (_CygPath.convert):
2738
2739 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2740
2741         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
2742         https://bugs.webkit.org/show_bug.cgi?id=136377
2743
2744         Reviewed by Philippe Normand.
2745
2746         * Scripts/webkitdirs.pm:
2747         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
2748
2749 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
2750
2751         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
2752         https://bugs.webkit.org/show_bug.cgi?id=137117
2753
2754         Tools/efl/install-dependencies relies on apt-get to install packages.
2755         Unfortunately, if a package does not exist (e.g., for a given
2756         architecture) then apt-get install is not able to ignore the missing
2757         package and install the rest but fails to run entirely (and there
2758         seems to be no intent to change this behaviour).
2759
2760         On ARM64, the luajit package is missing and currently it needs manual
2761         editing of install-dependencies to get the script install as much as it
2762         can.
2763
2764         This patch separates the installation of the universally available
2765         packages from those which might not be available for all architectures.
2766
2767         Reviewed by Gyuyoung Kim.
2768
2769         * efl/install-dependencies:
2770
2771 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
2772
2773         Remove WinCE port from trunk
2774         https://bugs.webkit.org/show_bug.cgi?id=136951
2775
2776         Reviewed by Alex Christensen.
2777
2778         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2779         (_should_file_trigger_build):
2780         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2781         (ShouldBuildTest):
2782         * CMakeLists.txt:
2783         * DumpRenderTree/win/DRTDataObject.cpp:
2784         (DRTDataObject::CopyMedium):
2785         * Scripts/build-webkit:
2786         * Scripts/webkit-build-directory:
2787         * Scripts/webkitdirs.pm:
2788         (argumentsForConfiguration):
2789         (builtDylibPathForName):
2790         (isAppleWinWebKit):
2791         (launcherPath):
2792         (launcherName):
2793         (shouldRemoveCMakeCache):
2794         (cmakeBasedPortArguments):
2795         (cmakeBasedPortName):
2796         (isCMakeBuild):
2797         (isWinCE): Deleted.
2798         (determineIsWinCE): Deleted.
2799         * Scripts/webkitperl/FeatureList.pm:
2800         * Scripts/webkitpy/port/port_testcase.py:
2801         (test_apache_config_file_name_for_platform):
2802         * TestWebKitAPI/config.h:
2803         * WinCELauncher/CMakeLists.txt: Removed.
2804         * WinCELauncher/main.cpp: Removed.
2805         * gtk/manifest.txt:
2806
2807 2014-09-23  David Farler  <dfarler@apple.com>
2808
2809         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
2810         https://bugs.webkit.org/show_bug.cgi?id=136895
2811
2812         Reviewed by David Kilzer.
2813
2814         Create Device, DeviceType, and Runtime data classes.
2815         Create Simulator class represent simctl output.
2816
2817         Wherever possible, use structured data classes anywhere a raw
2818         identifier or UDID string was used for a cleaner implementation
2819         and to encapsulate the inherent fragility of scraping simctl output.
2820
2821         Create a suitably named testing device if one doesn't exist.
2822
2823         Finally, accurately handle having multiple simulator runtimes (SDKs)
2824         installed in the active Xcode.app bundle.
2825
2826         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2827         (_set_up_derived_options):
2828         * Scripts/webkitpy/port/driver.py:
2829         (IOSSimulatorDriver.cmd_line):
2830         Construct DeviceType and Runtime objects from identifiers passed at the
2831         command line, still providing sensible defaults for 32- and 64-bit testing.
2832         * Scripts/webkitpy/port/ios.py:
2833         (IOSSimulatorPort.__init__):
2834         (IOSSimulatorPort.setup_test_run):
2835         (IOSSimulatorPort):
2836         (IOSSimulatorPort.testing_device):
2837         Cache the testing device once it is created or found.
2838         (IOSSimulatorPort.reset_preferences):
2839         Get the device path from the Device object instead of consructing it
2840         in the port class.
2841         (IOSSimulatorPort.simulator_udid): Deleted.
2842         Get the UDID from the testing_device :: Device object itself.
2843         * Scripts/webkitpy/xcode/simulator.py:
2844         Created Device, DeviceType, Runtime, and Simulator classes.
2845         (get_runtimes): Deleted.
2846         (get_devices): Deleted.
2847         (get_device_types): Deleted.
2848         (get_latest_runtime): Deleted.
2849
2850 2014-09-24  Roger Fong  <roger_fong@apple.com>
2851
2852         [Windows] Tentative fix for Windows test bots.
2853
2854         * Scripts/webkitpy/common/system/path.py:
2855         (_CygPath.convert):
2856
2857 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
2858
2859         Change more build.webkit.org links to https
2860         https://bugs.webkit.org/show_bug.cgi?id=137049
2861
2862         Reviewed by Csaba Osztrogonác.
2863
2864         Fix appspot, svn.webkit.org and Trac links.
2865
2866         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2867         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2868         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
2870         (ViewController.prototype._domForBuildName):
2871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2872         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2873         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2874         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2875         (.):
2876         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2877         (EWS):
2878         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2880         (TestHistory):
2881         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2882
2883 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
2884
2885         Update the list of u-szeged contributors.
2886
2887         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
2888
2889         * Scripts/webkitpy/common/config/contributors.json:
2890
2891 2014-09-23  Roger Fong  <roger_fong@apple.com>
2892
2893         [Windows] More debugging for the Windows bots.
2894
2895         * Scripts/webkitpy/common/system/path.py:
2896         (_CygPath):
2897
2898 2014-09-23  Roger Fong  <roger_fong@apple.com>
2899
2900         Unreviewed. Fix for r173899, those tabs should be spaces.
2901
2902         * Scripts/webkitpy/port/driver.py:
2903         (Driver._command_from_driver_input):
2904         (Driver): Deleted.
2905
2906 2014-09-23  Roger Fong  <roger_fong@apple.com>
2907
2908         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
2909
2910         * Scripts/webkitpy/port/driver.py:
2911         (Driver):
2912
2913 2014-09-23  Jer Noble  <jer.noble@apple.com>
2914
2915         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
2916         https://bugs.webkit.org/show_bug.cgi?id=137031
2917
2918         Reviewed by Joseph Pecoraro.
2919
2920         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
2921         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
2922         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
2923         ChangeLog locations before passing them to createCommitMessage().
2924
2925         * Scripts/commit-log-editor:
2926
2927 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2928
2929         W3C test importer should detect manual and reference tests according their filenames
2930         https://bugs.webkit.org/show_bug.cgi?id=133852
2931
2932         Reviewed by Bem Jones-Bey.
2933
2934         * Scripts/webkitpy/w3c/test_parser.py:
2935         (TestParser.analyze_test): Adding checks based on WPT filename rules.
2936         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
2937         (TestParser):
2938         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
2939         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
2940         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2941         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
2942
2943 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
2944
2945         Unreviewed, add Rebecca Hauck as a contributor.
2946
2947         * Scripts/webkitpy/common/config/contributors.json:
2948
2949 2014-09-23  David Kilzer  <ddkilzer@apple.com>
2950
2951         Switch build.webkit.org URLs to https
2952
2953         Reviewed by Lucas Forschler and Alexey Proskuryakov.
2954
2955         * TestResultServer/app.yaml: Update version to this commit
2956         revision.
2957
2958         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2960         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2961         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
2962         (WebKitBuildbot):
2963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2964         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2966         (.):
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2968         (WebKitBuildbot):
2969         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2970         * Scripts/webkitpy/common/config/urls.py:
2971         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2972         (test_builder_with_name):
2973         * Scripts/webkitpy/tool/commands/queries.py:
2974         (TreeStatus):
2975         * TestResultServer/generate_builders_json.py:
2976         (main):
2977         * TestResultServer/generate_builders_json_unittest.py:
2978         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2979         (GenerateBuildersJsonTest):
2980         (GenerateBuildersJsonTest.test_generate_json_data):
2981         * TestResultServer/static-dashboards/builders.jsonp:
2982         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2983         (loadExpectationsLayoutTests):
2984         * TestResultServer/static-dashboards/timeline_explorer.js:
2985
2986 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2987
2988         W3C test importer should copy .htaccess files
2989         https://bugs.webkit.org/show_bug.cgi?id=136850
2990
2991         Reviewed by Bem Jones-Bey.
2992
2993         * Scripts/webkitpy/w3c/test_importer.py:
2994         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
2995         (TestImporter):
2996         (TestImporter.find_importable_tests): Making use of new helper function.
2997
2998 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
2999
3000         Trying to revive bot watcher's dashboard after HSTS.
3001
3002         Unreviewed.
3003
3004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3005         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
3006
3007 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3008
3009         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
3010         https://bugs.webkit.org/show_bug.cgi?id=137026
3011
3012         Reviewed by Csaba Osztrogonác.
3013
3014         * BuildSlaveSupport/wait-for-SVN-server.py:
3015         (getLatestSVNRevision):
3016         (waitForSVNRevision):
3017
3018 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3019
3020         Remove unlinkZeroFiles from build-webkit
3021         https://bugs.webkit.org/show_bug.cgi?id=137018
3022
3023         Reviewed by Csaba Osztrogonác.
3024
3025         * Scripts/build-webkit:
3026         (unlinkZeroFiles): Deleted.
3027
3028 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
3029
3030         [GTK] Minibrowser : Add keyboard support for stop page load
3031         https://bugs.webkit.org/show_bug.cgi?id=136857
3032
3033         Reviewed by Philippe Normand.
3034
3035         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
3036
3037         * MiniBrowser/gtk/BrowserWindow.c:
3038         (stopPageLoad): Callback to stop page load.
3039         (browser_window_init):
3040
3041 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
3042
3043         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
3044         https://bugs.webkit.org/show_bug.cgi?id=136813
3045
3046         Reviewed by Gyuyoung Kim.
3047
3048         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
3049
3050         * MiniBrowser/efl/main.c:
3051         (on_key_down):
3052
3053 2014-09-22  Daniel Bates  <dabates@apple.com>
3054
3055         [Cocoa] Add UI delegate callback when window.close() is called
3056         https://bugs.webkit.org/show_bug.cgi?id=137008
3057         <rdar://problem/17801001>
3058
3059         Reviewed by Anders Carlsson.
3060
3061         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
3062         for window opened via JavaScript (i.e. window.open()).
3063
3064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3065         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
3066         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
3067
3068 2014-09-22  Youenn Fablet  <youennf@gmail.com>
3069
3070         W3C importer should import html files within resources folders
3071         https://bugs.webkit.org/show_bug.cgi?id=127548
3072
3073         Reviewed by Ryosuke Niwa.
3074         
3075         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
3076
3077         * Scripts/webkitpy/w3c/test_importer.py:
3078         (TestImporter.find_importable_tests):
3079
3080 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3081
3082         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
3083         https://bugs.webkit.org/show_bug.cgi?id=136998
3084
3085         Reviewed by Philippe Normand.
3086
3087         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3088         (testWebViewCanShowMIMEType): Remove the check of PDF as
3089         unsupported MIME type.
3090
3091 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3092
3093         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
3094
3095         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
3096         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
3097
3098         * Scripts/webkitpy/common/config/watchlist: Use
3099         Source/WebCore/platform/gtk/po/ as directory to watch for
3100         WebKitGTKTranslations rule and add berto and myself to the list of
3101         watchers.
3102
3103 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
3104
3105         Fix syntaxError in watchlist since r173594
3106         https://bugs.webkit.org/show_bug.cgi?id=136996
3107
3108         Reviewed by Philippe Normand.
3109
3110         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
3111
3112 2014-09-20  Sam Weinig  <sam@webkit.org>
3113
3114         Make possible HashSet<std::unique_ptr<>>
3115         https://bugs.webkit.org/show_bug.cgi?id=136166
3116
3117         Reviewed by Darin Adler.
3118
3119         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
3120         * TestWebKitAPI/Counters.cpp: Added.
3121         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
3122         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
3123         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
3124         translation unit.
3125     
3126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3127         Add new files.
3128
3129         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3130         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
3131
3132         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3133         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
3134
3135 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3136
3137         run-webkit-tests should count tests submitted as absolute paths once
3138         https://bugs.webkit.org/show_bug.cgi?id=136848
3139
3140         Reviewed by Darin Adler.
3141
3142         * Scripts/webkitpy/port/base.py:
3143         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
3144
3145 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
3146
3147         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
3148         https://bugs.webkit.org/show_bug.cgi?id=136974
3149
3150         Reviewed by Chris Fleizach.
3151
3152         * DumpRenderTree/AccessibilityUIElement.cpp:
3153         (selectTextWithCriteriaCallback):
3154         Be sure to release the string if it was allocated.
3155
3156 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
3157
3158         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
3159         https://bugs.webkit.org/show_bug.cgi?id=136966
3160
3161         Reviewed by Daniel Bates.
3162
3163         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3164         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
3165
3166 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3167
3168         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
3169         https://bugs.webkit.org/show_bug.cgi?id=136917
3170
3171         Reviewed by Darin Adler.
3172
3173         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
3174
3175         * TestWebKitAPI/PlatformEfl.cmake:
3176         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
3177         (TestWebKitAPI::didFinishLoadForFrame):
3178         (TestWebKitAPI::TEST):
3179         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
3180
3181 2014-09-19  Daniel Bates  <dabates@apple.com>
3182
3183         Always assume internal SDK when building configuration Production
3184         https://bugs.webkit.org/show_bug.cgi?id=136925
3185         <rdar://problem/18362399>
3186
3187         Reviewed by Dan Bernstein.
3188
3189         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3190         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3191         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3192         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3193
3194 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3195
3196         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
3197         https://bugs.webkit.org/show_bug.cgi?id=136847
3198
3199         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
3200
3201         Reviewed by Alexey Proskuryakov.
3202
3203         * WebKitTestRunner/TestController.cpp:
3204         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
3205
3206 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3207
3208         [GTK] Missing inspector files in the tarball
3209         https://bugs.webkit.org/show_bug.cgi?id=136952
3210
3211         Reviewed by Gustavo Noronha Silva.
3212
3213         * gtk/manifest.txt: Add
3214         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
3215         to the tarball.
3216
3217 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3218
3219         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
3220         https://bugs.webkit.org/show_bug.cgi?id=136632
3221
3222         Reviewed by Gustavo Noronha Silva.
3223
3224         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
3225         the gtk icons.
3226         * gtk/manifest.txt: Only include the free icons in the tarball.
3227
3228 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3229
3230         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
3231         https://bugs.webkit.org/show_bug.cgi?id=136943
3232
3233         Reviewed by Philippe Normand.
3234
3235         Update the script to receive the list of files from the command
3236         line instead of scanning the given directories.
3237
3238         * gtk/generate-inspector-gresource-manifest.py:
3239         (get_filenames): Convert filenames to use relative paths.
3240         (find_all_files_in_directory): Deleted.
3241         (find_all_files_in_directory.select_file): Deleted.
3242
3243 2014-09-18  Tanay C  <tanay.c@samsung.com>
3244
3245         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
3246         https://bugs.webkit.org/show_bug.cgi?id=136739
3247
3248         Reviewed by Gyuyoung Kim.
3249
3250         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
3251         (on_mouse_wheel): Modified.
3252
3253 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3254
3255         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
3256         https://bugs.webkit.org/show_bug.cgi?id=136923
3257
3258         Reviewed by Gustavo Noronha Silva.
3259
3260         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3261         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
3262         the source.
3263
3264 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
3265
3266         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
3267         https://bugs.webkit.org/show_bug.cgi?id=136856
3268
3269         Reviewed by Darin Adler.
3270
3271         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3272         (RunLLINTCLoopTests.countFailures):
3273         (Run32bitJSCTests.countFailures):
3274         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3275         (RunLLINTCLoopTestsTest.test_failures):
3276         (RunLLINTCLoopTestsTest.test_failure):
3277         (RunLLINTCLoopTestsTest.test_no_failure):
3278         (Run32bitJSCTestsTest.test_failures):
3279         (Run32bitJSCTestsTest.test_failure):
3280         (Run32bitJSCTestsTest.test_no_failure):
3281
3282 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
3283
3284         GMainLoopSource is exposed to race conditions
3285         https://bugs.webkit.org/show_bug.cgi?id=135800
3286
3287         Reviewed by Carlos Garcia Campos.
3288
3289         Add unit tests for GMainLoopSource.
3290
3291         The tests check correct behavior of GMainLoopSource in various conditions --
3292         from the most simple rescheduling to rescheduling during dispatch, cancelling
3293         or destroying the GMainLoopSource during dispatch, proper destroy callback
3294         dispatching etc.
3295
3296         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
3297         State of the GMainLoopSource object (either ready, sheduled or active) is
3298         thoroughly tested throughout the lifetime of that object.
3299
3300         Still missing are tests for socket callbacks, which are a bit trickier because
3301         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
3302         are also not tested thoroughly, simply because it is at the moment impossible
3303         to test that the objects are actually destroyed when the corresponding source
3304         is finally deleted.
3305
3306         * TestWebKitAPI/PlatformGTK.cmake:
3307         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
3308         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3309         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3310         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3311         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
3312         (TestWebKitAPI::GMainLoopSourceTest::finish):
3313         (TestWebKitAPI::GMainLoopSourceTest::source):
3314         (TestWebKitAPI::TEST):
3315
3316 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
3317
3318         Unreviewed, Update my email in contributors.json
3319
3320         * Scripts/webkitpy/common/config/contributors.json:
3321
3322 2014-09-17  Daniel Bates  <dabates@apple.com>
3323
3324         Unreviewed, rolling out r173695.
3325
3326         Broke building third-party Legacy WebKit apps; will
3327         investigate offline
3328
3329         Reverted changeset:
3330
3331         "[iOS] Make WebCore build with public iOS SDK"
3332         https://bugs.webkit.org/show_bug.cgi?id=136487
3333         http://trac.webkit.org/changeset/173695
3334
3335 2014-09-17  Daniel Bates  <dabates@apple.com>
3336
3337         [iOS] Make WebCore build with public iOS SDK
3338         https://bugs.webkit.org/show_bug.cgi?id=136487
3339
3340         Reviewed by David Kilzer.
3341
3342         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
3343
3344         * DumpRenderTree/mac/CheckedMalloc.cpp:
3345
3346 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3347
3348         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
3349         https://bugs.webkit.org/show_bug.cgi?id=136889
3350
3351         Reviewed by Gustavo Noronha Silva.
3352
3353         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3354         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
3355         event was added to the events vector.
3356         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3357         (loadFailedCallback): Do not assume the web view URI is the
3358         failing URI when the load fails before the committed state.
3359         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
3360         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
3361         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
3362         (LoadTrackingTest::loadFailedWithTLSErrors): Add
3363         LoadFailedWithTLSErrors event to the events vector.
3364         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3365
3366 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
3367
3368         [EFL][GTK] Remove WebKit1 related codes
3369         https://bugs.webkit.org/show_bug.cgi?id=136853
3370
3371         Reviewed by Csaba Osztrogonác.
3372
3373         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
3374         from scripts.
3375
3376         * BuildSlaveSupport/build.webkit.org-config/config.json:
3377         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3378         (Compile32bitJSC):
3379         (BuildAndTestWebKit2Factory):
3380         (CompileWebKit1Only): Deleted.
3381         (CompileWebKit2Only): Deleted.
3382         (BuildAndTestWebKit1OnlyFactory): Deleted.
3383         (BuildAndTestWebKit2OnlyFactory): Deleted.
3384         * Scripts/build-webkit:
3385         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3386         * Scripts/webkitpy/common/config/ports.py:
3387         (GtkWK2Port.build_webkit_command):
3388         (EflWK2Port.build_webkit_command):
3389         * Scripts/webkitpy/common/config/ports_unittest.py:
3390         (DeprecatedPortTest.test_gtk_wk2_port):
3391         * Scripts/webkitpy/port/efl.py:
3392         (EflPort.build_webkit_command):
3393         * Scripts/webkitpy/port/gtk.py:
3394         (GtkPort._built_libraries_path):
3395         (GtkPort._search_paths):
3396         (GtkPort.test_expectations_file_position):
3397         (GtkPort.build_webkit_command):
3398         (GtkPort.run_webkit_tests_command):
3399         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
3400
3401 2014-09-16  Daniel Bates  <dabates@apple.com>
3402
3403         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3404         https://bugs.webkit.org/show_bug.cgi?id=136862
3405
3406         Reviewed by David Kilzer.
3407
3408         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3409         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3410         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
3411         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
3412
3413 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3414
3415         Mac queue slaves should reboot every so often
3416         https://bugs.webkit.org/show_bug.cgi?id=136791
3417
3418         Reviewed by Alexey Proskuryakov.
3419
3420         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
3421
3422         * EWSTools/start-queue-mac.sh:
3423
3424 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3425
3426         Unreviewed gardening, skip one more tests on Windows.
3427
3428         * Scripts/run-javascriptcore-tests:
3429
3430 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3431
3432         JSC test gardening
3433         https://bugs.webkit.org/show_bug.cgi?id=136823
3434
3435         Reviewed by Geoffrey Garen.
3436
3437         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
3438
3439 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3440
3441         Remove shouldAbortEarly cruft from master.cfg
3442         https://bugs.webkit.org/show_bug.cgi?id=136779
3443
3444         Reviewed by Csaba Osztrogonác.
3445
3446         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3447         (ConfigureBuild.start):
3448         (RunWebKitTests.start):
3449         (RunWebKit2Tests.start): Deleted.
3450
3451 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3452
3453         Remove ORWT related crufts from webkitdirs.pm
3454         https://bugs.webkit.org/show_bug.cgi?id=136821
3455
3456         Reviewed by Alexey Proskuryakov.
3457
3458         * Scripts/webkitdirs.pm:
3459         (isPerianInstalled): Deleted.
3460         (determineIPhoneSimulatorVersion): Deleted.
3461         (iPhoneSimulatorVersion): Deleted.
3462         (isSnowLeopard): Deleted.
3463         (isLion): Deleted.
3464         (quitIOSSimulator): Deleted.
3465
3466 2014-09-15  Roger Fong  <roger_fong@apple.com>
3467
3468         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
3469         https://bugs.webkit.org/show_bug.cgi?id=25160
3470
3471         * Scripts/run-javascriptcore-tests:
3472
3473 2014-09-15  Lucas Forschler  <lforschler@apple.com>
3474
3475         Add another Apple build slave to the Mountain Lion Debug WK1 queue
3476         
3477         Rubber stamped by Matt Hanson.
3478         
3479         * BuildSlaveSupport/build.webkit.org-config/config.json:
3480
3481 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3482
3483         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
3484         https://bugs.webkit.org/show_bug.cgi?id=136822
3485
3486         Reviewed by Gyuyoung Kim.
3487
3488         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
3489         initialized as we already does it in PlatformWebView::PlatformWebView
3490         calling ewk_init(). The reason for that was to ensure testing for example,
3491         WTF where creating the view is not mandatory.
3492
3493         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
3494         in order to properly initalize and release EWebKit.
3495
3496         * TestWebKitAPI/PlatformEfl.cmake:
3497         * TestWebKitAPI/efl/PlatformWebView.cpp:
3498         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3499         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3500         * TestWebKitAPI/efl/main.cpp:
3501         (main):
3502
3503 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
3504
3505         [WinCairo] Make it easier to enable/disable GStreamer.
3506         https://bugs.webkit.org/show_bug.cgi?id=135766
3507
3508         Reviewed by Brent Fulgham.
3509
3510         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
3511
3512         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
3513
3514 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
3515
3516         Web Inspector: remind about rebaselining generator test results
3517         https://bugs.webkit.org/show_bug.cgi?id=136759
3518
3519         Reviewed by Joseph Pecoraro.
3520
3521         For now, we can implement this as a watchlist message. Add watchlist
3522         groups and messages for the inspector and web replay generators.
3523
3524         * Scripts/webkitpy/common/config/watchlist:
3525
3526 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3527
3528         build.webkit.org/dashboard: Overlapping text when status is long
3529         https://bugs.webkit.org/show_bug.cgi?id=136794
3530
3531         Reviewed by Timothy Hatcher.
3532
3533         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3534         (.status-line): Replaces height with min-height.
3535
3536 2014-09-12  Timothy Hatcher  <timothy@apple.com>
3537
3538         Make Brian Burg a WebKit reviewer.
3539
3540         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
3541
3542 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3543
3544         Multiple EWS or commit bots can pick up processing of the same patch
3545         https://bugs.webkit.org/show_bug.cgi?id=136793
3546
3547         Reviewed by Ryosuke Niwa.
3548
3549         Change timeout from one hour to two hours. This will let bots finish, and in the
3550         unlikely event of a bot being frozen, will only delay patch processing restart by
3551         one hour.
3552
3553         * QueueStatusServer/app.yaml:
3554         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
3555
3556 2014-09-11  Andy Estes  <aestes@apple.com>
3557
3558         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
3559         https://bugs.webkit.org/show_bug.cgi?id=136768
3560
3561         Reviewed by Tim Horton.
3562
3563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3564         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
3565         (TestWebKitAPI::TEST):
3566
3567 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3568
3569         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
3570         https://bugs.webkit.org/show_bug.cgi?id=136669
3571
3572         Reviewed by Antti Koivisto.
3573
3574         * Scripts/run-gtk-tests:
3575         (TestRunner): Unskip SSL test.
3576
3577 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
3578
3579         Strip extraneous AVFoundation and CoreMedia logging
3580         https://bugs.webkit.org/show_bug.cgi?id=136747
3581
3582         Reviewed by Jer Noble.
3583
3584         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3585         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
3586
3587         * Scripts/webkitpy/port/base.py:
3588         (Port.stderr_patterns_to_strip): Base class, empty list
3589
3590         * Scripts/webkitpy/port/driver.py:
3591         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
3592
3593         * Scripts/webkitpy/port/ios.py:
3594         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
3595
3596         * Scripts/webkitpy/port/mac.py:
3597         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
3598
3599
3600 2014-09-11  Michael Saboff  <msaboff@apple.com>
3601
3602         lldb_webkit.py:btjs doesn't work with release builds
3603         https://bugs.webkit.org/show_bug.cgi?id=136760
3604
3605         Reviewed by Jer Noble.
3606
3607         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
3608         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
3609         we can't get a valid result from trying either call.  In that case, we fallback to
3610         just showing the PC.  Also added check for both entry points.  If neither is found,
3611         we issue a warning and output the stack trace without JavaScript annotations.
3612
3613         * lldb/lldb_webkit.py:
3614         (btjs):
3615
3616 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
3617
3618         webkitpy test failures from import-w3c-tests
3619         https://bugs.webkit.org/show_bug.cgi?id=136752
3620
3621         Reviewed by Bem Jones-Bey.
3622
3623         This patch fixes a bug in import-w3c-tests where we were appending
3624         the wrong set of files to the copy_list. This also updates the tests
3625         to clear the failures introduced in the patch for bug 135929.
3626
3627         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3628         (W3CTestConverterTest.test_read_prefixed_property_list):
3629         * Scripts/webkitpy/w3c/test_parser.py:
3630         (TestParser.analyze_test):
3631         (TestParser.support_files):
3632         * Scripts/webkitpy/w3c/test_parser_unittest.py: