2011-06-14 Lucas Forschler <lforschler@apple.com>
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-14  Lucas Forschler  <lforschler@apple.com>
2
3         Reviewed by Stephanie Lewis.
4
5         https://bugs.webkit.org/show_bug.cgi?id=62495
6         Bug 62495 - combine windows and mac kill-old-processes script
7         Add a platform agnostic script.  Remove the recently added mac flavor.
8         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
9         
10         * BuildSlaveSupport/kill-old-processes: Added.
11         * BuildSlaveSupport/mac: Removed.
12         * BuildSlaveSupport/mac/kill-old-processes: Removed.
13
14 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
15
16         Reviewed by Tony Chang.
17
18         nrwt: handle worker exceptions cleanly
19         https://bugs.webkit.org/show_bug.cgi?id=62614
20
21         This change modifiers new-run-webkit-tests to handle exceptions
22         raised by worker threads better, by:
23         - capturing the worker's stack and logging it in the manager
24         - propagating the worker's exception in the caller correctly
25         - attempting to cancel the workers and clean up even when
26           we get an unexpected exception
27
28         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
29         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
30         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
31         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
32
33 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
34
35         Reviewed by Laszlo Gombos.
36
37         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
38         https://bugs.webkit.org/show_bug.cgi?id=62227
39
40         QtWebkit does not yet support different CacheModels. This change will 
41         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
42
43         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
44         (LayoutTestController::setCacheModel):
45         * DumpRenderTree/qt/LayoutTestControllerQt.h:
46
47 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
48
49         Reviewed by Andreas Kling.
50
51         [Qt] tst_QWebFrame::overloadedSlots() fails
52         https://bugs.webkit.org/show_bug.cgi?id=37319
53
54         Since we don't implictly convert 'document' object to QWebElement
55         in metacalls anymore, change the controller to expect QVariantMap instead.
56
57         The method plainText() was updated to use QVariantMap as well to let the bridge
58         do the conversion directly for us.
59
60         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
61         (LayoutTestController::nodesFromRect):
62         * DumpRenderTree/qt/LayoutTestControllerQt.h:
63         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
64         (PlainTextController::plainText):
65         * DumpRenderTree/qt/PlainTextControllerQt.h:
66
67 2011-06-14  Andras Becsi  <abecsi@webkit.org>
68
69         Reviewed by Csaba Osztrogonác.
70
71         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
72         https://bugs.webkit.org/show_bug.cgi?id=62630
73
74         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
75         (NPP_New): remove dead variable 'forceCarbon'
76
77 2011-06-13  Hayato Ito  <hayato@chromium.org>
78
79         Reviewed by Ojan Vafai.
80
81         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
82         https://bugs.webkit.org/show_bug.cgi?id=59188
83
84         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
85         WebKitDriver should always return an actual hash value if DRT returns that.
86
87         No tests since I'll add sample reftests to make sure mismatch reftests work later,
88         which should be in a separate patch.
89
90         * Scripts/webkitpy/layout_tests/port/webkit.py:
91
92 2011-06-13  Kent Tamura  <tkent@chromium.org>
93
94         [Chromium-win] Fix two wrong assertions exposed by r88757.
95
96         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
97         (WebThemeEngineDRTWin::paintTrackbar):
98
99 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
100
101         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
102         and commit queue happy.
103
104         * Scripts/webkitpy/common/config/committers.py:
105
106 2011-06-13  Chris Rogers  <crogers@google.com>
107
108         Unreviewed build fix.
109
110         Build fix to chromium DRT until we can rebaseline some tests
111         https://bugs.webkit.org/show_bug.cgi?id=62608
112
113         * DumpRenderTree/chromium/TestShell.cpp:
114         (TestShell::TestShell):
115
116 2011-06-13  Chris Rogers  <crogers@google.com>
117
118         Reviewed by Dirk Pranke.
119
120         Add Web Audio support to chromium DRT
121         https://bugs.webkit.org/show_bug.cgi?id=62306
122
123         * DumpRenderTree/chromium/LayoutTestController.cpp:
124         (LayoutTestController::LayoutTestController):
125         (LayoutTestController::reset):
126         (LayoutTestController::setEncodedAudioData):
127         * DumpRenderTree/chromium/LayoutTestController.h:
128         (LayoutTestController::encodedAudioData):
129         (LayoutTestController::shouldDumpAsAudio):
130         (LayoutTestController::setShouldDumpAsAudio):
131         * DumpRenderTree/chromium/TestEventPrinter.cpp:
132         (DRTPrinter::handleAudioHeader):
133         (TestShellPrinter::handleAudioHeader):
134         * DumpRenderTree/chromium/TestEventPrinter.h:
135         * DumpRenderTree/chromium/TestShell.cpp:
136         (TestShell::TestShell):
137         (TestShell::dump):
138
139 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
140
141         Reviewed by Eric Seidel.
142
143         [EFL] Add load error handler to EWebLauncher
144         https://bugs.webkit.org/show_bug.cgi?id=62347
145
146         Add a handler function of "load,error" to EWebLauncher.
147         EWebLauncher now displays a simple error page on load errors.
148
149         * EWebLauncher/main.c:
150         (on_load_error):
151         (browserCreate):
152
153 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
154
155         Reviewed by Eric Seidel.
156
157         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
158         https://bugs.webkit.org/show_bug.cgi?id=62385
159
160         Remove duplicate TestNetscapePlugIn implementation. Having two copies
161         of this code makes keeping it in sync much more difficult. The files are
162         almost identical and this change ports the X11 changes to main.cpp.
163
164         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
165         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
166         some results on Qt and this seems to be unnecessary for the moment.
167         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
168         (handleEventX11): Use the handler to properly convert the keycode. Do not print
169         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
170         it should not be in the results.
171         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
172         XP_UNIX block is first by guarding against using a null instance.
173         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
174         the XP_UNIX define for Linux.
175         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
176         * GNUmakefile.am: Update source list.
177
178 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
179
180         Unreviewed, rolling out r88671.
181         http://trac.webkit.org/changeset/88671
182         https://bugs.webkit.org/show_bug.cgi?id=62591
183
184         "didn't work" (Requested by dpranke on #webkit).
185
186         * Scripts/new-run-webkit-httpd:
187         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
188         * Scripts/webkitpy/layout_tests/port/http_server.py:
189         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
190         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
191         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
192         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
193
194 2011-06-13  Nate Chapin  <japhet@chromium.org>
195
196         Reviewed by Darin Fisher.
197
198         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
199
200         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
201
202 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
203
204         Reviewed by Tony Chang.
205
206         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
207         https://bugs.webkit.org/show_bug.cgi?id=62251
208
209         shut_down_http_server() was a total hack that was only used by
210         new-run-webkit-httpd, so I've moved the code there and switched
211         to using executive.kill_process() for the common case. The
212         method itself will be removed in the patch on bug 59993.
213
214         * Scripts/new-run-webkit-httpd:
215         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
216         * Scripts/webkitpy/layout_tests/port/http_server.py:
217         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
218         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
219
220 2011-06-13  Tony Chang  <tony@chromium.org>
221
222         Reviewed by Dimitri Glazkov.
223
224         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
225         https://bugs.webkit.org/show_bug.cgi?id=62578
226
227         * Scripts/build-webkit:
228
229 2011-06-13  Tony Chang  <tony@chromium.org>
230
231         Reviewed by Adam Barth.
232
233         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
234         https://bugs.webkit.org/show_bug.cgi?id=62545
235
236         * Scripts/build-webkit:
237
238 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
239
240         Reviewed by Martin Robinson.
241
242         [GTK] Export an API similar to WebKit1
243         https://bugs.webkit.org/show_bug.cgi?id=57820
244
245         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
246         code, but linking to libwebkit2gtk.
247
248         * GNUmakefile.am:
249         * GtkLauncher/main.c:
250         (createBrowser):
251         (main):
252
253 2011-06-12  MORITA Hajime  <morrita@google.com>
254
255         Unreviewed, rolling out r88625.
256         http://trac.webkit.org/changeset/88625
257         https://bugs.webkit.org/show_bug.cgi?id=61073
258
259         Breaks SL Webkit2 Tests
260
261         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
262         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
263         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
264         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
265         (WTR::InjectedBundlePage::didClearWindowForFrame):
266         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
267
268 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
269
270         Reviewed by Antonio Gomes.
271
272         [Qt] LayoutTestController needs setTextDirection implementation
273         https://bugs.webkit.org/show_bug.cgi?id=62442
274
275         Implements LayoutController.setTextDirection.
276
277         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
278         (LayoutTestController::setTextDirection):
279         * DumpRenderTree/qt/LayoutTestControllerQt.h:
280
281 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
282
283         Reviewed by Hajime Morita.
284
285         Add window.internals to WebKit2's WebKitTestRunner.
286         https://bugs.webkit.org/show_bug.cgi?id=61073
287
288         Test: fast/harness/internals-object.html
289
290         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
291         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
292         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
293         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
294         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
295         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
296
297 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
298
299         Unreviewed, rolling out r88616.
300         http://trac.webkit.org/changeset/88616
301         https://bugs.webkit.org/show_bug.cgi?id=62517
302
303         It broke editing/text-iterator/findString.html (Requested by
304         tonikitoo on #webkit).
305
306         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
307         * DumpRenderTree/qt/LayoutTestControllerQt.h:
308
309 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
310
311         Reviewed by Antonio Gomes.
312
313         [Qt] LayoutTestController needs setTextDirection implementation
314         https://bugs.webkit.org/show_bug.cgi?id=62442
315
316         Implements LayoutController.setTextDirection.
317
318         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
319         (LayoutTestController::setTextDirection):
320         * DumpRenderTree/qt/LayoutTestControllerQt.h:
321
322 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
323
324         Reviewed by Ojan Vafai.
325
326         new-run-webkit-tests: 'images' links on results.html don't work
327         https://bugs.webkit.org/show_bug.cgi?id=62194
328
329         Use relative path when generating images-diffs.html
330
331         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
332         Added _output_testname.
333
334 2011-06-10  Lucas Forschler  <lforschler@apple.com>
335
336         Reviewed by Stephanie Lewis.
337
338         Script to kill old processes on Mac.
339         This matches the windows version.
340         https://bugs.webkit.org/show_bug.cgi?id=62479  
341         
342         * BuildSlaveSupport/mac: Added.
343         * BuildSlaveSupport/mac/kill-old-processes: Added.
344
345 2011-06-10  Adam Barth  <abarth@webkit.org>
346
347         Reviewed by James Robinson.
348
349         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
350         https://bugs.webkit.org/show_bug.cgi?id=62489
351
352         * Scripts/webkitpy/tool/bot/sheriff.py:
353         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
354
355 2011-06-10  Tony Chang  <tony@chromium.org>
356
357         Reviewed by Ojan Vafai.
358
359         add a compile guard ENABLE(FLEXBOX)
360         https://bugs.webkit.org/show_bug.cgi?id=62049
361
362         * Scripts/build-webkit:
363
364 2011-06-10  Mark Rowe  <mrowe@apple.com>
365
366         Reviewed by Dimitri Glazkov.
367
368         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
369
370         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
371         header file.
372
373         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
374         * DumpRenderTree/mac/Configurations/Base.xcconfig:
375
376 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
377
378         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
379
380         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
381         (handleEventX11):
382         (NPP_GetValue):
383         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
384         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
385         (webkit_test_plugin_new_instance):
386         (webkit_test_plugin_destroy_instance):
387         (webkit_test_plugin_set_window):
388         (executeScript):
389         (webkit_test_plugin_new_stream):
390         (webkit_test_plugin_destroy_stream):
391         (webkit_test_plugin_stream_as_file):
392         (webkit_test_plugin_write_ready):
393         (webkit_test_plugin_write):
394         (webkit_test_plugin_print):
395         (keyEventToChar):
396         (webkit_test_plugin_handle_event):
397         (webkit_test_plugin_url_notify):
398         (webkit_test_plugin_get_value):
399         (webkit_test_plugin_set_value):
400         (NP_GetMIMEDescription):
401         (NP_Initialize):
402         (NP_Shutdown):
403         (NP_GetValue):
404         * GNUmakefile.am:
405
406 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
407
408         Reviewed by Eric Seidel.
409
410         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
411         https://bugs.webkit.org/show_bug.cgi?id=55603
412
413         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
414         TextInputController support.
415
416         * DumpRenderTree/gtk/TextInputController.cpp:
417         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
418         of start and end. This matches the other ports. Do not use GLib style early returns.
419         (hasMarkedTextCallback): Added.
420         (markedRangeCallback): Added.
421         (insertTextCallback): Cleanup as described above.
422         (unmarkTextCallback): Cleanup as described above.
423         (firstRectForCharacterRangeCallback): Cleanup as described above.
424         (selectedRangeCallback): Cleanup as described above.
425
426 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
427
428         Reviewed by Tony Chang.
429
430         nrwt: support webaudio in chromium driver
431         https://bugs.webkit.org/show_bug.cgi?id=62226
432
433         * Scripts/webkitpy/layout_tests/port/chromium.py:
434
435 2011-06-09  Dan Bernstein  <mitz@apple.com>
436
437         Reviewed by Anders Carlsson.
438
439         Added a test for Vector::reverse()
440         https://bugs.webkit.org/show_bug.cgi?id=62393
441
442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
443         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
444         (TestWebKitAPI::TEST):
445         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
446
447 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
448
449         Reviewed by Andreas Kling.
450
451         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
452         https://bugs.webkit.org/show_bug.cgi?id=62385
453
454         Remove duplicate TestNetscapePlugIn implementation. Having two copies
455         of this code makes keeping it in sync much more difficult. The files are
456         almost identical and this change ports the X11 changes to main.cpp.
457
458         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
459         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
460         (handleEventX11): Use the handler to properly convert the keycode. Do not print
461         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
462         it should not be in the results.
463         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
464         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
465         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
466         * GNUmakefile.am: Update source list.
467
468 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
469
470         Reviewed by Tony Chang.
471
472         Test plugin should support event logging on the windows port.
473         https://bugs.webkit.org/show_bug.cgi?id=61721
474
475         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
476         calls to mean the plugin handled the event.
477
478         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
479         (handleEventWin): Return 0 for each event on windows.
480
481 2011-06-09  Chang Shu  <cshu@webkit.org>
482
483         Reviewed by Andreas Kling.
484
485         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
486         https://bugs.webkit.org/show_bug.cgi?id=62381
487
488         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
489         QWKPagePrivate::isViewFocused() will check it later.
490
491         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
492         (WTR::PlatformWebView::PlatformWebView):
493
494 2011-06-09  Robert Hogan  <robert@webkit.org>
495
496         Reviewed by Andreas Kling.
497
498         Teach Qt about window.internals
499         https://bugs.webkit.org/show_bug.cgi?id=61074
500
501         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
502         (WebCore::DumpRenderTree::initJSObjects):
503
504 2011-06-09  Eric Seidel  <eric@webkit.org>
505
506         Reviewed by Adam Barth.
507
508         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
509         https://bugs.webkit.org/show_bug.cgi?id=62362
510
511         The mac bots are failing inspector tests.  We don't know why yet.
512         So for now, turning run-webkit-tests off for the mac-ews.
513
514         Also noticed that due to the wrong variable name the cr-linux
515         bots weren't running tests!
516
517         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
518
519 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
520
521         Reviewed by Csaba Osztrogonac.
522
523         [Qt][WK2] Canvas tests make css2.1 ones failing
524         https://bugs.webkit.org/show_bug.cgi?id=53427
525
526         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
527         Since the Qt port should eventually go to QRawFont, this issue will be resolved
528         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
529         needed for the workaround.
530
531         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
532         (WTR::LayoutTestController::platformInitialize):
533
534 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
535
536         Reviewed by Chris Fleizach.
537
538         [GTK] Provide a way in DRT to check the platform name
539         https://bugs.webkit.org/show_bug.cgi?id=56855
540
541         Patch for adding 'platformName' static property to DRT's
542         LayoutController and provide platform specific implementations.
543
544         In principle, this feature will be only of interest for writing
545         accessibility tests, so that's why it's only implemented in the
546         Mac, Gtk and Win platforms.
547
548         * DumpRenderTree/LayoutTestController.h: New method platformName().
549         * DumpRenderTree/LayoutTestController.cpp:
550         (getPlatformNameCallback): New callback for 'platformName'.
551         (LayoutTestController::staticValues): New static property.
552
553         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
554         (LayoutTestController::platformName): Implemented.
555
556         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
557         (LayoutTestController::platformName): Implemented.
558
559         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
560         (LayoutTestController::platformName): Implemented.
561
562 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
563
564         Reviewed by James Robinson.
565
566         Add mikelawther to committers.py
567         https://bugs.webkit.org/show_bug.cgi?id=62354
568
569         * Scripts/webkitpy/common/config/committers.py:
570
571 2011-06-08  Kent Tamura  <tkent@chromium.org>
572
573         [Chromium] Fix a typo.
574
575         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
576         (WebThemeControlDRTWin::draw):
577
578 2011-06-08  Kent Tamura  <tkent@chromium.org>
579
580         Reviewed by Hajime Morita.
581
582         [Chromium] Support vertical sliders in Windows DRT
583         https://bugs.webkit.org/show_bug.cgi?id=62352
584
585         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
586         (WebThemeControlDRTWin::draw):
587           Paint VerticalSliderThumbType and VerticalSliderTrackType.
588         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
589           Add VerticalSliderTrackType and VerticalSliderThumbType.
590         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
591         (WebThemeEngineDRTWin::paintTrackbar):
592           Convert Windows identifiers to the internal identifiers for vertical sliders.
593
594 2011-06-08  Ojan Vafai  <ojan@chromium.org>
595
596         Reviewed by Tony Chang.
597
598         add a short-flag for --experimental-fully-parallel
599         https://bugs.webkit.org/show_bug.cgi?id=62321
600
601         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
602
603 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
604
605         Reviewed by Tony Chang.
606
607         new-run-webkit-tests: don't turn the tree red when there are new passes
608         https://bugs.webkit.org/show_bug.cgi?id=62311
609
610         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
611         to match commandComplete.
612
613         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
614
615 2011-06-08  Tom Hudson  <tomhudson@google.com>
616
617         Reviewed by Mihai Parparita.
618
619         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
620         https://bugs.webkit.org/show_bug.cgi?id=60964
621
622         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
623         Add 'Sort tests by metric' link.
624         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
625         (disableSorting): Activate 'Sort tests by metric' link.
626         (enableSorting): Deactivate 'Sort tests by metric' link.
627         (selectDirectory): Call enableSorting()/disableSorting() depending
628         on currently selected failure type, and sort tests if requested.
629         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
630         New .disabled-control class for deactivated links.
631
632 2011-06-08  Tom Sepez  <tsepez@chromium.org>
633
634         Reviewed by Adam Barth.
635
636         Add web permissions callbacks for mixed content blocking.
637         https://bugs.webkit.org/show_bug.cgi?id=61946
638
639         * DumpRenderTree/chromium/LayoutTestController.cpp:
640         (LayoutTestController::setAllowDisplayOfInsecureContent):
641         (LayoutTestController::setAllowRunningOfInsecureContent):
642         (LayoutTestController::overridePreference):
643         * DumpRenderTree/chromium/WebPermissions.cpp:
644         (WebPermissions::allowDisplayingInsecureContent):
645         (WebPermissions::allowRunningInsecureContent):
646         (WebPermissions::setDisplayingInsecureContentAllowed):
647         (WebPermissions::setRunningInsecureContentAllowed):
648         (WebPermissions::reset):
649         * DumpRenderTree/chromium/WebPermissions.h:
650
651 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
652
653         Reviewed by Tony Chang.
654
655         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
656         https://bugs.webkit.org/show_bug.cgi?id=62259
657
658         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
659
660 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
661
662         Reviewed by Tony Chang.
663
664         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
665         https://bugs.webkit.org/show_bug.cgi?id=62303
666
667         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
668
669         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
670
671 2011-06-08  Greg Simon  <gregsimon@chromium.org>
672
673         Reviewed by Dimitri Glazkov.
674
675         Control Indexeddb backends from LayoutTestController
676         https://bugs.webkit.org/show_bug.cgi?id=61000
677
678         * DumpRenderTree/chromium/LayoutTestController.cpp:
679         (LayoutTestController::LayoutTestController):
680         (LayoutTestController::setOverrideIndexedDBBackingStore):
681         (LayoutTestController::clearAllDatabases):
682         * DumpRenderTree/chromium/LayoutTestController.h:
683
684 2011-06-08  Andreas Kling  <kling@webkit.org>
685
686         Add Pierre Rossi to contributors list for EZ-CC.
687
688         * Scripts/webkitpy/common/config/committers.py:
689
690 2011-06-08  Ilya Sherman  <isherman@chromium.org>
691
692         Reviewed by Andreas Kling.
693
694         Add Ilya Sherman to list of committers
695         https://bugs.webkit.org/show_bug.cgi?id=62270
696
697         * Scripts/webkitpy/common/config/committers.py:
698
699 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
700
701         Reviewed by Tony Chang.
702
703         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
704         https://bugs.webkit.org/show_bug.cgi?id=62178
705
706         Added commandComplete and evaluateCommand for NewRunWebKitTests class
707         to parse new-run-webkit-tests' results.
708
709         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
710
711 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
712
713         Reviewed by Eric Seidel.
714
715         webkitpy: add a popen() call to executive
716         https://bugs.webkit.org/show_bug.cgi?id=62179
717
718         This change adds a popen() wrapper call to the Executive object.
719         This will allow other webkitpy scripts that currently call
720         subprocess directly to use Executive, instead.
721
722         No additional tests are necessary (the existing tests cover the code).
723
724         * Scripts/webkitpy/common/system/executive.py:
725
726 2011-06-07  Sam Weinig  <sam@webkit.org>
727
728         Reviewed by Anders Carlsson.
729
730         Remove repeated IPC traffic from SetRenderTreeSize message
731         https://bugs.webkit.org/show_bug.cgi?id=62244
732
733         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
734         (WTR::InjectedBundlePage::InjectedBundlePage):
735         Add stub for didLayoutForFrame.
736
737 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
738
739         Reviewed by Tony Chang.
740
741         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
742         https://bugs.webkit.org/show_bug.cgi?id=62241
743
744         * Scripts/webkitpy/layout_tests/port/chromium.py:
745
746 2011-06-07  Adam Barth  <abarth@webkit.org>
747
748         Rubber-stamped by Eric Seidel.
749
750         Enable tests on the mac-ews
751
752         When we bring the mac-ews back up, we're going to try running tests!
753
754         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
755
756 2011-06-07  Dmitry Lomov  <dslomov@google.com>
757
758         Reviewed by David Levin.
759
760         https://bugs.webkit.org/show_bug.cgi?id=62215
761         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
762
763         * Scripts/webkitpy/style/checkers/cpp.py:
764         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
765
766 2011-06-07  Nico Weber  <thakis@chromium.org>
767
768         Reviewed by Dimitri Glazkov.
769
770         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
771         https://bugs.webkit.org/show_bug.cgi?id=62210
772
773         The change to TestEventPrinter fixes a latent bug, because
774         objects are deleted through the TestEventPrinter type, but none
775         of the subclasses have destructors or non-POD members.
776
777         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
778         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
779         discussed at http://codereview.chromium.org/7094005/, we prefer making
780         leaf class destructors virtual over making the leaf classes final.
781
782         * DumpRenderTree/chromium/NotificationPresenter.cpp:
783         (NotificationPresenter::~NotificationPresenter):
784         * DumpRenderTree/chromium/NotificationPresenter.h:
785         * DumpRenderTree/chromium/TestEventPrinter.cpp:
786         (TestEventPrinter::~TestEventPrinter):
787         * DumpRenderTree/chromium/TestEventPrinter.h:
788         * DumpRenderTree/chromium/WebViewHost.h:
789
790 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
791
792         Reviewed by Dirk Pranke.
793
794         [chromium] Chromium bots on build.webkit.org don't upload results.html
795         https://bugs.webkit.org/show_bug.cgi?id=61961
796
797         Don't fix the path on chromium port erroneously.
798
799         * BuildSlaveSupport/test-result-archive:
800
801 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
802
803         Fix the GTK+ build by ensuring that the autogenerated sources
804         necessary for libWebCoreInternals are recorded in a predeclared
805         variable before assigning to BUILT_SOURCES.
806
807         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
808
809 2011-06-06  Yong Li  <yoli@rim.com>
810
811         Reviewed by Eric Seidel.
812
813         https://bugs.webkit.org/show_bug.cgi?id=62097
814         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
815
816         * Scripts/webkitpy/style/checkers/cpp.py:
817         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
818
819 2011-06-06  Xan Lopez  <xlopez@igalia.com>
820
821         Reviewed by Martin Robinson.
822
823         [GTK] Enable feature/symbol detection in NWRT/GTK
824         https://bugs.webkit.org/show_bug.cgi?id=62136
825
826         Disable feature detection through DRT, since we don't support it,
827         and set the libwebcore patch correctly so that symbol detection
828         through 'nm' works.
829
830         * Scripts/webkitpy/layout_tests/port/gtk.py:
831
832 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
833
834         Reviewed by Tony Gentilcore.
835
836         Add a "prerender" state for page visibility.
837         https://bugs.webkit.org/show_bug.cgi?id=62062
838
839         * DumpRenderTree/chromium/LayoutTestController.cpp:
840         (LayoutTestController::setPageVisibility):
841
842 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
843
844         [Qt] Implement download feature for QtTestBrowser
845         https://bugs.webkit.org/show_bug.cgi?id=61865
846
847         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
848
849         * QtTestBrowser/launcherwindow.cpp:
850         (LauncherWindow::LauncherWindow):
851         * QtTestBrowser/launcherwindow.h:
852
853 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
854
855         Reviewed by Csaba Osztrogonác.
856
857         [Qt] Implement download feature for QtTestBrowser
858         https://bugs.webkit.org/show_bug.cgi?id=61865
859
860         * QtTestBrowser/launcherwindow.cpp:
861         (LauncherWindow::LauncherWindow):
862         (LauncherWindow::downloadRequest):
863         (LauncherWindow::fileDownloadFinished):
864         * QtTestBrowser/launcherwindow.h:
865
866 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
867
868         Reviewed by Dimitri Glazkov.
869
870         Make DumpRenderTree initialize window.internals.
871         https://bugs.webkit.org/show_bug.cgi?id=61076
872
873         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
874         * DumpRenderTree/win/FrameLoadDelegate.cpp:
875         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
876
877 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
878
879         Reviewed by Kent Tamura.
880
881         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
882         https://bugs.webkit.org/show_bug.cgi?id=61628
883
884         * Scripts/build-webkit:
885
886 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
887
888         Reviewed by Kent Tamura.
889
890         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
891         https://bugs.webkit.org/show_bug.cgi?id=61631
892
893         * Scripts/build-webkit:
894
895 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
896
897         Unreviewed. Fix the GTK+ build.
898
899         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
900
901 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
902
903         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
904         works properly).
905
906         * Scripts/webkitpy/common/config/committers.py:
907
908 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
909
910         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
911         WebKit scripts expect, so other scripts work properly with wx.
912
913         * waf/build/build_utils.py:
914         * waf/build/settings.py:
915
916 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
917
918         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
919         to build on Mac.
920
921         * waf/build/settings.py:
922         * wx/install-unix-extras:
923
924 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
925
926         [wx] Unreviewed build fixes for recent trunk changes.
927
928         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
929         (LayoutTestController::setTextDirection):
930         * waf/build/settings.py:
931
932 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
933
934         Fix the GTK+ build.
935
936         * GNUmakefile.am: Add some missing newline escape.
937
938 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
939
940         Try to fix the GTK+ bulid.
941
942         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
943         source list.
944
945 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
946
947         Reviewed by Adam Barth.
948
949         nrwt: should skip chromium test expectation overrides on upstream bots
950         https://bugs.webkit.org/show_bug.cgi?id=61888
951
952         * Scripts/webkitpy/layout_tests/port/chromium.py:
953         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
954
955 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
956
957         Reviewed by Ojan Vafai.
958
959         new-run-webkit-tests: minor logging, code cleanup
960         https://bugs.webkit.org/show_bug.cgi?id=62055
961
962         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
963         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
964
965 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
966
967         Try to fix the build failure on the GTK+ 32-bit Release bot.
968
969         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
970
971 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
972
973         Reviewed by Ryosuke Niwa.
974
975         [GTK] Support smart replace for the pasteboard
976         https://bugs.webkit.org/show_bug.cgi?id=61734
977
978         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
979         This is required to produce consistent test results.
980
981         * DumpRenderTree/gtk/DumpRenderTree.cpp:
982         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
983         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
984         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
985         methods which calls into DumpRenderTreeSupportGtk.
986
987 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
988
989         Reviewed by Dimitri Glazkov.
990
991         Teach Gtk build about window.internals
992         https://bugs.webkit.org/show_bug.cgi?id=61071
993
994         * DumpRenderTree/gtk/DumpRenderTree.cpp:
995         (webViewWindowObjectCleared): Inject the new internals object when the
996         window object clears.
997         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
998         Also do a little bit of cleanup.
999
1000 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1001
1002         Reviewed by Tony Chang.
1003
1004         Worker may not be stopped after LT.
1005         https://bugs.webkit.org/show_bug.cgi?id=61847
1006
1007         Re-submit a variant of the first fix for this bug. It's possible
1008         that actually calling cleanup() in the worker threads was taking
1009         too long and we triggered the assertions in the manager thread.
1010
1011         I've bumped up the timeout in the manager and added better
1012         diagnostics. I also cleaned up the cleanup() code a bit because
1013         there was some unnecessary if-checks.
1014
1015         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1016         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1017
1018 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
1019
1020         Reviewed by Tony Chang.
1021
1022         nrwt: fix duplicate logging regression
1023         https://bugs.webkit.org/show_bug.cgi?id=61981
1024
1025         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1026
1027 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
1028
1029         Reviewed by Adam Barth.
1030
1031         Modified addTouchPoint to correctly re-use touchPoint id values starting
1032         from the lowest not-un-use touchPoint id as is done by the embedder
1033         APIs. (Fixes BUGCR36415)
1034
1035         https://bugs.webkit.org/show_bug.cgi?id=62016
1036
1037         * DumpRenderTree/chromium/EventSender.cpp:
1038         (EventSender::addTouchPoint):
1039
1040 2011-06-03  Cary Clark  <caryclark@google.com>
1041
1042         Reviewed by Eric Seidel.
1043
1044         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
1045         https://bugs.webkit.org/show_bug.cgi?id=61534
1046
1047         Skia on Mac uses Skia to render WebKit, and CG
1048         to render UI elements. The CG elements need a
1049         transcribed graphics context that preserves the
1050         canvas matrix, and the canvas clip.
1051
1052         The SkiaBitLocker utility class sets up a CGContext
1053         from the SkCanvas, locks the bitmap's bits, and
1054         releases the lock when the class goes out of scope.
1055
1056         The SkiaBitLocker implementation is described by
1057         this patch:
1058         http://codereview.chromium.org/7031006/
1059
1060         When WebKit uses Skia for rendering, the WebCanvas
1061         is an SkCanvas. Create an equivalent CGContext to
1062         draw the scrollbar thumb.
1063
1064         As the Chrome Mac port does not yet use Skia, this
1065         patch has no effect and requires no tests.
1066
1067         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1068         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1069
1070 2011-06-03  Andras Becsi  <abecsi@webkit.org>
1071
1072         Unreviewed build fix.
1073
1074         Fix typo.
1075
1076         * Scripts/old-run-webkit-tests:
1077
1078 2011-06-03  Andras Becsi  <abecsi@webkit.org>
1079
1080         Reviewed by Csaba Osztrogonác.
1081
1082         Print error message when there is no httpd present on the system
1083         https://bugs.webkit.org/show_bug.cgi?id=61939
1084
1085         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
1086         * Scripts/webkitperl/httpd.pm:
1087
1088 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
1089
1090         Reviewed by Yury Semikhatsky.
1091
1092         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
1093         https://bugs.webkit.org/show_bug.cgi?id=61533
1094
1095         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
1096
1097         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1098         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
1099         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1100         * DumpRenderTree/chromium/LayoutTestController.cpp:
1101         (LayoutTestController::LayoutTestController):
1102         (LayoutTestController::setJavaScriptProfilingEnabled):
1103         * DumpRenderTree/chromium/LayoutTestController.h:
1104         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1105         (LayoutTestController::setJavaScriptProfilingEnabled):
1106         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1107         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
1108         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1109
1110 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
1111
1112         Reviewed by Tony Chang.
1113
1114         NRWT needs a way to log to a file without including backspaces without needing --verbose
1115         https://bugs.webkit.org/show_bug.cgi?id=60328
1116
1117         This change modifies NRWT so that if it can tell if it is
1118         writing to a terminal, it will overwrite any messages printed
1119         in the 'one-line-progress' and 'updates' print options, and if
1120         not (or if --verbose was specified) the messages will be printed
1121         without backspaces.
1122
1123         If the overwriting updates are disabled, one-line-progress will
1124         only print every 10 seconds instead of on every update. This
1125         ensures that we still get updates once in a while while the
1126         tests are running, even if we're not in --verbose mode. Note
1127         that one-line-progress will now still be printed in --verbose,
1128         since it's useful as long as you're not flooded with the
1129         updates.
1130
1131         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1132         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1133         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1134
1135 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
1136
1137         Reviewed by Gustavo Noronha Silva.
1138
1139         [GTK] autogen.sh is run twice for each buld on the bots
1140         https://bugs.webkit.org/show_bug.cgi?id=61951
1141
1142         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
1143         for the WebKit project. This prevents build-jsc runs from forcing subsequent
1144         build-webkit runs to re-rerun autogen.sh.
1145
1146 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1147
1148         Unreviewed, rolling out r87946.
1149         http://trac.webkit.org/changeset/87946
1150         https://bugs.webkit.org/show_bug.cgi?id=61965
1151
1152         Cause NRWT to break (Requested by abarth|gardener on #webkit).
1153
1154         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1155
1156 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1157
1158         Reviewed by Darin Adler.
1159
1160         Add build logistics and plumbing for window.internals object.
1161         https://bugs.webkit.org/show_bug.cgi?id=60313
1162
1163         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1164         * DumpRenderTree/chromium/TestShell.cpp:
1165         (TestShell::bindJSObjectsToWindow): Added injection code.
1166         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1167         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1168
1169 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
1170
1171         Reviewed by Dirk Pranke.
1172
1173         Call cleanup() explicitly at the end of worker.run().
1174         https://bugs.webkit.org/show_bug.cgi?id=61847
1175
1176         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1177
1178 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1179
1180         Unreviewed, rolling out r87926.
1181         http://trac.webkit.org/changeset/87926
1182         https://bugs.webkit.org/show_bug.cgi?id=60313
1183
1184         Fails to find WebCoreTestSupport.dylib on bots.
1185
1186         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1187         * DumpRenderTree/chromium/TestShell.cpp:
1188         (TestShell::bindJSObjectsToWindow):
1189         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1190         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1191
1192 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
1193
1194         Reviewed by Darin Adler.
1195
1196         Add build logistics and plumbing for window.internals object.
1197         https://bugs.webkit.org/show_bug.cgi?id=60313
1198
1199         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1200         * DumpRenderTree/chromium/TestShell.cpp:
1201         (TestShell::bindJSObjectsToWindow): Added injection code.
1202         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1203         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1204
1205 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1206
1207         Reviewed by Eric Seidel.
1208
1209         Adjust efl coding style to more efl directories
1210         https://bugs.webkit.org/show_bug.cgi?id=61903
1211
1212         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
1213
1214 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
1215
1216         Reviewed by Tony Chang.
1217
1218         old-run-webkit-tests: add support for audio files
1219         https://bugs.webkit.org/show_bug.cgi?id=57992
1220
1221         * Scripts/old-run-webkit-tests:
1222
1223 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
1224
1225         Reviewed by Adam Barth.
1226
1227         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
1228         https://bugs.webkit.org/show_bug.cgi?id=34314
1229
1230         * DumpRenderTree/DumpRenderTree.gypi:
1231         * DumpRenderTree/chromium/LayoutTestController.cpp:
1232         (LayoutTestController::LayoutTestController):
1233         (LayoutTestController::setImagesAllowed):
1234         (LayoutTestController::setStorageAllowed):
1235         * DumpRenderTree/chromium/LayoutTestController.h:
1236         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
1237         (WebPermissions::WebPermissions):
1238         (WebPermissions::~WebPermissions):
1239         (WebPermissions::allowImages):
1240         (WebPermissions::allowStorage):
1241         (WebPermissions::setImagesAllowed):
1242         (WebPermissions::setStorageAllowed):
1243         (WebPermissions::reset):
1244         * DumpRenderTree/chromium/WebPermissions.h:
1245
1246 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
1247
1248         Reviewed by Tony Chang.
1249
1250         Test plugin should support event logging on the windows port.
1251         https://bugs.webkit.org/show_bug.cgi?id=61721
1252
1253         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1254         (handleEventWin): Well, handle them.
1255
1256 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
1257
1258         Reviewed by Tony Chang.
1259
1260         [chromium] Use correct file name for dragging out images.
1261         https://bugs.webkit.org/show_bug.cgi?id=24887
1262
1263         * DumpRenderTree/chromium/EventSender.cpp:
1264         (EventSender::EventSender):
1265         (EventSender::dumpFilenameBeingDragged):
1266         * DumpRenderTree/chromium/EventSender.h:
1267
1268 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
1269
1270         Reviewed by Tony Chang.
1271
1272         nrwt: make webaudio work w/o content-length header
1273         https://bugs.webkit.org/show_bug.cgi?id=61819
1274
1275         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1276         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1277         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1278         * Scripts/webkitpy/layout_tests/port/webkit.py:
1279
1280 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1281
1282         Reviewed by Andreas Kling.
1283
1284         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
1285         https://bugs.webkit.org/show_bug.cgi?id=61802
1286
1287         Add command line parameter and menu item to MiniBrowser application 
1288         enabling use of QGLWidget for browser viewport.
1289
1290         * MiniBrowser/qt/BrowserWindow.cpp:
1291         (BrowserWindow::BrowserWindow):
1292         (BrowserWindow::toggleGLViewport):
1293         * MiniBrowser/qt/BrowserWindow.h:
1294         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1295         (MiniBrowserApplication::handleUserOptions):
1296         * MiniBrowser/qt/MiniBrowserApplication.h:
1297         (WindowOptions::WindowOptions):
1298
1299 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
1300
1301         Reviewed by Xan Lopez.
1302
1303         Print out autogen arguments when they differ from the last set, to help
1304         with debugging build issues.
1305
1306         * Scripts/webkitdirs.pm: Print out previous and current build arguments
1307         when they differ.
1308
1309 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1310
1311         Reviewed by Martin Robinson.
1312
1313         [GTK] run-launcher should run MiniBrowser in WebKit2
1314         https://bugs.webkit.org/show_bug.cgi?id=61858
1315
1316         * Scripts/run-launcher: Check whether -2 command line option has
1317         been passed and run MiniBrowser instead of GtkLauncher.
1318
1319 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
1320
1321         Reviewed by Dirk Pranke.
1322
1323         Fix exception in verbose printing mode.
1324         https://bugs.webkit.org/show_bug.cgi?id=61723
1325
1326         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1327
1328 2011-05-31  Yong Li  <yoli@rim.com>
1329
1330         Reviewed by Eric Seidel.
1331
1332         https://bugs.webkit.org/show_bug.cgi?id=54807
1333         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
1334         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
1335         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
1336         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
1337         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
1338         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
1339         rule we should have in order to make our code independent from compilers and compiler flags.
1340
1341         * Scripts/webkitpy/style/checkers/cpp.py:
1342
1343 2011-05-31  Hironori Bono  <hbono@chromium.org>
1344
1345         Reviewed by Eric Seidel.
1346
1347         Add a JavaScript function layoutTestController.setTextDirection().
1348         https://bugs.webkit.org/show_bug.cgi?id=50952
1349
1350         This change adds a new JavaScript function setTextDirection() to the
1351         LayoutTestController class of Safari and Chrome to write layout tests
1352         that changes the text direction of an editable element.
1353
1354         * DumpRenderTree/LayoutTestController.cpp:
1355         (setTextDirectionCallback):
1356         (LayoutTestController::staticFunctions):
1357         * DumpRenderTree/LayoutTestController.h:
1358         * DumpRenderTree/chromium/LayoutTestController.cpp:
1359         (LayoutTestController::LayoutTestController):
1360         (LayoutTestController::setTextDirection):
1361         * DumpRenderTree/chromium/LayoutTestController.h:
1362         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1363         (LayoutTestController::setTextDirection):
1364         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1365         (LayoutTestController::setTextDirection):
1366         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1367         (LayoutTestController::setTextDirection):
1368
1369 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1370
1371         Reviewed by Simon Hausmann.
1372
1373         [Qt] User-agent list of Qt test browsers is very outdated
1374         https://bugs.webkit.org/show_bug.cgi?id=61531
1375
1376         The user can edit the user-agent manually, so there's no need to have
1377         a super complete and up to date list, but it's nice to have it
1378         minimally updated.
1379
1380         * MiniBrowser/qt/useragentlist.txt:
1381         * QtTestBrowser/useragentlist.txt:
1382
1383 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
1384
1385         Reviewed by Adam Roben.
1386
1387         [GTK] [WebKit2] Implement a basic WebKitTestRunner
1388         https://bugs.webkit.org/show_bug.cgi?id=57068
1389
1390         Add an implementation of WebKitTestRunner for GTK+.
1391
1392         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
1393         * Scripts/old-run-webkit-tests: Ditto.
1394         * Scripts/run-launcher: Ditto.
1395         * Scripts/webkitdirs.pm: Ditto.
1396         * WebKitTestRunner/GNUmakefile.am: Added.
1397         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1398         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
1399         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1400         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1401         * WebKitTestRunner/PlatformWebView.h:
1402         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
1403         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
1404         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1405         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1406         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
1407         (main): Added.
1408
1409 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
1410
1411         Reviewed by Tony Chang.
1412
1413         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
1414         https://bugs.webkit.org/show_bug.cgi?id=60241
1415
1416         * Scripts/new-run-webkit-tests:
1417
1418 2011-05-31  Eric Seidel  <eric@webkit.org>
1419
1420         Reviewed by David Kilzer.
1421
1422         webkitpy should create zips with zip -9
1423         https://bugs.webkit.org/show_bug.cgi?id=61789
1424
1425         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
1426
1427         * Scripts/webkitpy/common/system/workspace.py:
1428         * Scripts/webkitpy/common/system/workspace_unittest.py:
1429
1430 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1431
1432         Reviewed by Csaba Osztrogonác.
1433
1434         [Qt] Implement find feature for QtTestBrowser
1435         https://bugs.webkit.org/show_bug.cgi?id=61425
1436
1437         Buildfix for --minimal and CONFIG+=qt_minimal build.
1438
1439         * QtTestBrowser/launcherwindow.cpp:
1440         (LauncherWindow::LauncherWindow):
1441         (LauncherWindow::createChrome):
1442         * QtTestBrowser/launcherwindow.h:
1443
1444 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1445
1446         Reviewed by Csaba Osztrogonác.
1447
1448         [Qt] Implement find feature for QtTestBrowser
1449         https://bugs.webkit.org/show_bug.cgi?id=61425
1450
1451         * QtTestBrowser/launcherwindow.cpp:
1452         (LauncherWindow::LauncherWindow):
1453         (LauncherWindow::createChrome):
1454         (LauncherWindow::showFindBar):
1455         (LauncherWindow::find):
1456         * QtTestBrowser/launcherwindow.h:
1457
1458 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1459
1460         Reviewed by Martin Robinson.
1461
1462         [GTK] Implement JavaScript dialogs in MiniBrowser
1463         https://bugs.webkit.org/show_bug.cgi?id=61725
1464
1465         * MiniBrowser/gtk/BrowserWindow.c:
1466         (WKStringGetCString): Helper function to get a UTF-8 c string from
1467         a WKStringRef.
1468         (WKURLGetCString): Helper function to get a UTF-8 c string from a
1469         WKURLRef.
1470         (browserWindowUpdateURL): Update to use WKURLGetCString.
1471         (didReceiveTitleForFrame): Update to use WKStringGetCString.
1472         (createMessageDialog): Create a GtkMessageDialog.
1473         (runJavaScriptAlert):
1474         (runJavaScriptConfirm):
1475         (runJavaScriptPrompt):
1476         (browserWindowUIClientInit):
1477
1478 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
1479
1480         Reviewed by Kent Tamura.
1481
1482         WebSocket closing handshake
1483         https://bugs.webkit.org/show_bug.cgi?id=35721
1484
1485         * Scripts/webkitpy/thirdparty/__init__.py:
1486         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1487         to get the right behavior of closing handshake.
1488
1489 2011-05-29  Daniel Bates  <dbates@rim.com>
1490
1491         Reviewed by David Kilzer.
1492
1493         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
1494         https://bugs.webkit.org/show_bug.cgi?id=61162
1495
1496         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
1497         that omits a line count. In particular, the chunk range regular expression does
1498         not match a chunk range line that omits a line count. GNU diff(1) will omit the
1499         line count in the chunk range if the line count is exactly 1. For example, appending
1500         a new line to the end of an existing file F that contains exactly one line of text will
1501         be represented in a diff with a chunk range line that omits the line count for F.
1502
1503         * Scripts/VCSUtils.pm:
1504           (parseChunkRange): Added.
1505         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
1506         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1507           - Added unit test "Git: Append new line to the end of an existing file".
1508
1509 2011-05-28  Adam Barth  <abarth@webkit.org>
1510
1511         Reviewed by Eric Seidel.
1512
1513         EWS builds patches that fail to build twice, which seems useless and slows down the bots
1514         https://bugs.webkit.org/show_bug.cgi?id=55585
1515
1516         This patch switches all the early warning system bots over to the new
1517         PatchAnalysisTask-based infrastructure.  This patch makes these bots
1518         more efficient (in the case where patches fail to build) and paves the
1519         way for running tests on these bots!
1520
1521         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1522         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1523         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1524         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1525         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1526         * Scripts/webkitpy/tool/commands/queues.py:
1527
1528 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
1529
1530         Reviewed by Kent Tamura.
1531
1532         Add bashi as a committer.
1533
1534         https://bugs.webkit.org/show_bug.cgi?id=61685
1535
1536         * Scripts/webkitpy/common/config/committers.py:
1537
1538 2011-05-27  Adam Barth  <abarth@webkit.org>
1539
1540         Reviewed by Eric Seidel.
1541
1542         When checking whether the tree is red, the EWS posts a link to the wrong log
1543         https://bugs.webkit.org/show_bug.cgi?id=61072
1544
1545         We need to cache the original script error because that contains the
1546         failure log we want to upload.  If we don't cache that script error,
1547         self._script_error will get overwritten when we sanity check the clean
1548         tree (and it also has test failures).
1549
1550         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1551             - This testing approach is slightly goofy.  We'd like to use
1552               assertRaisesRegexp, but that's not available until Python 2.7.
1553         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1554
1555 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
1556
1557         Reviewed by Adam Barth.
1558
1559         Add layoutTestController.setStorageAllowed() to control whether access
1560         to the localStorage API is enabled via the WebPermissionClient
1561         https://bugs.webkit.org/show_bug.cgi?id=61581
1562
1563         * DumpRenderTree/chromium/LayoutTestController.cpp:
1564         (LayoutTestController::LayoutTestController):
1565         (LayoutTestController::setStorageAllowed):
1566         * DumpRenderTree/chromium/LayoutTestController.h:
1567         * DumpRenderTree/chromium/TestShell.cpp:
1568         (TestShell::TestShell):
1569         (TestShell::createNewWindow):
1570         * DumpRenderTree/chromium/TestShell.h:
1571         * DumpRenderTree/chromium/WebPermissions.h: Added.
1572         (WebPermissions::WebPermissions):
1573         (WebPermissions::allowStorage):
1574         (WebPermissions::setStorageAllowed):
1575         (WebPermissions::reset):
1576
1577 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1578
1579         Reviewed by Eric Seidel.
1580
1581         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
1582         https://bugs.webkit.org/show_bug.cgi?id=60326
1583
1584         This patch removes a lot of the complexity from the
1585         metered_stream implementation that was unnecessary since there
1586         was only one caller and the logic could be coordinated better.
1587
1588         There should be no functional changes in this patch, just code
1589         getting deleted and cleaned up.
1590
1591         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
1592         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
1593         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1594         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1595
1596 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1597
1598         Reviewed by Eric Seidel.
1599
1600         NRWT: minor cleanup in printing module
1601         https://bugs.webkit.org/show_bug.cgi?id=60329
1602
1603         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1604
1605 2011-05-27  Steve Lacey  <sjl@chromium.org>
1606
1607         Reviewed by David Levin.
1608
1609         Add sjl@chromium.org as a committer.
1610
1611         https://bugs.webkit.org/show_bug.cgi?id=61672
1612
1613         * Scripts/webkitpy/common/config/committers.py:
1614
1615 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1616
1617         Reviewed by Adam Barth.
1618
1619         NRWT: remove --print detailed-progress
1620         https://bugs.webkit.org/show_bug.cgi?id=60324
1621
1622         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1623         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1624         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1625         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1626
1627 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
1628
1629         Reviewed by Ojan Vafai.
1630
1631         NRWT: debug messages from the workers are being logged twice
1632         https://bugs.webkit.org/show_bug.cgi?id=60428
1633
1634         It looks like when the workers are run in separate processes
1635         we end up getting two copies of every log message they print.
1636         This has to do with the multiprocessing module on UNIX cloning
1637         the log configuration in a way I wasn't expecting, and so two
1638         log handlers end up getting registered.
1639
1640         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
1641         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1642         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1643         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1644
1645 2011-05-27  Adam Roben  <aroben@apple.com>
1646
1647         Always decode tester names from location.hash
1648
1649         When navigating directly to a tester-specific URL (e.g.,
1650         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
1651         with a URL-encoded tester name in the page, and then the encoded name could make its way
1652         into Bugzilla bugs. Bad!
1653
1654         Reviewed by David Kilzer.
1655
1656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1657         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
1658         decodeURIComponent before trying to use it.
1659
1660 2011-05-27  Adam Roben  <aroben@apple.com>
1661
1662         Remove testing code that snuck into r87528
1663
1664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1665         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
1666
1667 2011-05-27  Adam Roben  <aroben@apple.com>
1668
1669         Add links to TestFailures to easily file bugs about failing tests
1670
1671         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
1672         links to file bugs for failing tests
1673
1674         Reviewed by David Kilzer.
1675
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1677         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
1678         for a particular build.
1679         (Builder.prototype._getFailingTests): Use resultsPageURL.
1680
1681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1682         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
1683         failures.
1684         (ViewController.prototype._domForBuildName): Use resultsPageURL.
1685         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
1686         new bug link. The bug has a title, description, and URL already filled in for you!
1687
1688 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1689
1690         Unreviewed, rolling out r87464.
1691         http://trac.webkit.org/changeset/87464
1692         https://bugs.webkit.org/show_bug.cgi?id=61643
1693
1694         client-close/server-close tests are flaky on Chromium Mac and
1695         Windows (Requested by aklein on #webkit).
1696
1697         * Scripts/webkitpy/thirdparty/__init__.py:
1698
1699 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
1700
1701         Added Douglas Davidson to contributors list for easier CC'ing.
1702
1703         * Scripts/webkitpy/common/config/committers.py:
1704
1705 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1706
1707         Reviewed by Adam Barth.
1708
1709         Fix worldID and destinationDomain argument names
1710         https://bugs.webkit.org/show_bug.cgi?id=61571
1711
1712         As part of working on r87423, I noticed a couple of inconsistencies in
1713         argument names:
1714         - We would use worldId in .h files but worldID in .cpp files.
1715           Standardize on the latter
1716         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
1717           destinationDomains argument, even though the actual parameter was for
1718           a single domain (renamed to be singular).
1719
1720         * DumpRenderTree/LayoutTestController.h:
1721         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1722         (LayoutTestController::evaluateScriptInIsolatedWorld):
1723
1724 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
1725
1726         Reviewed by Kent Tamura.
1727
1728         WebSocket closing handshake
1729         https://bugs.webkit.org/show_bug.cgi?id=35721
1730
1731         * Scripts/webkitpy/thirdparty/__init__.py:
1732         Pull in pywebsocket 0.6b1. We need to update pywebsocket
1733         to get the right behavior of closing handshake.
1734
1735 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
1736
1737         Reviewed by Andreas Kling.
1738
1739         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
1740         https://bugs.webkit.org/show_bug.cgi?id=42676
1741
1742         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
1743
1744         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1745         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1746         (WTR::InjectedBundle::beginTesting):
1747         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1748         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
1749         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1750
1751 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1752
1753         Reviewed by Andreas Kling.
1754
1755         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
1756         https://bugs.webkit.org/show_bug.cgi?id=61527
1757
1758         The setMaximumHeight() call is unecessary and breaks the dialog at
1759         least on my setup.
1760
1761         * QtTestBrowser/launcherwindow.cpp:
1762         (LauncherWindow::showUserAgentDialog):
1763
1764 2011-05-02  Robert Hogan  <robert@webkit.org>
1765
1766         Reviewed by Adam Roben.
1767
1768         [Qt] Allow popup windows from plugins when initiated by a user gesture
1769
1770         https://bugs.webkit.org/show_bug.cgi?id=41292
1771
1772         Support parameters introduced in plugin-initiate-popup-window.html
1773
1774         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1775         (webkit_test_plugin_new_instance):
1776         (webkit_test_plugin_handle_event):
1777
1778 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
1779
1780         Reviewed by Adam Barth.
1781
1782         Support cross-origin XMLHttpRequest in isolated worlds
1783         https://bugs.webkit.org/show_bug.cgi?id=59843
1784
1785         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
1786
1787         * DumpRenderTree/chromium/LayoutTestController.cpp:
1788         (LayoutTestController::LayoutTestController):
1789         (LayoutTestController::setIsolatedWorldSecurityOrigin):
1790         * DumpRenderTree/chromium/LayoutTestController.h:
1791
1792 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
1793
1794         Reviewed by Adam Roben.
1795
1796         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
1797         https://bugs.webkit.org/show_bug.cgi?id=61474
1798         <rdar://problem/9468337>
1799
1800         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1801         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
1802
1803 2011-05-26  Andreas Kling  <kling@webkit.org>
1804
1805         Unreviewed, correct address to webkit-committers mailing list.
1806
1807         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1808
1809 2011-05-25  Adam Roben  <aroben@apple.com>
1810
1811         Don't assume that builds finish in the order they were started
1812
1813         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
1814         build when one slave is taking a long time to finish a build
1815
1816         Reviewed by Antti Koivisto.
1817
1818         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1819         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
1820         newer than the oldest in-progress build are also themselves in progress. Just check whether
1821         each build is actually in progress (as signified by its presence in the currentBuilds set).
1822
1823 2011-05-25  Adam Roben  <aroben@apple.com>
1824
1825         Correctly detect cases where only a single test failed/crashed/timed out
1826
1827         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
1828         failing test
1829
1830         Reviewed by Darin Adler.
1831
1832         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1833         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
1834         will be singular when only a single test fails/crashes/times out.
1835
1836         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1837         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
1838         failed/crashed/timed out.
1839
1840 2011-05-26  Tom Hudson  <tomhudson@google.com>
1841
1842         Reviewed by Tony Chang.
1843
1844         Add flags to Chromium ImageDiff to write image comparison metrics on
1845         stdout.
1846         https://bugs.webkit.org/show_bug.cgi?id=60569
1847
1848         * DumpRenderTree/chromium/ImageDiff.cpp:
1849         (Image::createFromStdin): Fix spelling.
1850         (maxOf3): New function to do 3-way maximum.
1851         (getRedComponent): Extract red component from ABGR packed encoding.
1852         (getGreenComponent): Extract green component from ABGR packed encoding.
1853         (getBlueComponent): Extract blue component from ABGR packed encoding.
1854         (weightedPercentageDifferent): Determine % of pixels different in two
1855         images multiplied by intensity difference of each pixel.
1856         (printHelp): Document new arguments.
1857         (compareImages): Parameterize.
1858         (untestedCompareImages): Parameterize.
1859         (diffImages): Parameterize; write results on stdout if requested.
1860         (main): Parse new arguments.
1861
1862 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1863
1864         Reviewed by Simon Hausmann.
1865
1866         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
1867         https://bugs.webkit.org/show_bug.cgi?id=42697
1868
1869         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
1870
1871         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1872         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1873         (WTR::InjectedBundle::beginTesting):
1874         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1875         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
1876         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1877
1878 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
1879
1880         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
1881         https://bugs.webkit.org/show_bug.cgi?id=61428
1882         <rdar://problem/9457006>
1883
1884         Reviewed by Adam Roben.
1885
1886         The crash occurs when Flash posts a message to a window that it
1887         creates, and in processing the message, it calls NPN_Evaluate to
1888         evaluate JavaScript that removes the plug-in from the page. Flash then
1889         crashes when we return to Flash code.
1890
1891         This test emulates that behavior.
1892
1893         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
1894         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
1895         Initialize member vars.
1896         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
1897         Remove our custom property from the message window, and destroy it.
1898         (CallJSThatDestroysPlugin::NPP_Destroy):
1899         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
1900         layout test controller that we're done.
1901         (wndProc):
1902         Get the PluginTest object, and call its runTest() function.
1903         (CallJSThatDestroysPlugin::NPP_New):
1904         Setup the test: register a class for the message-only window, create
1905         it, and post a message to it to run the test.
1906         (CallJSThatDestroysPlugin::runTest):
1907         Execute JS that removes the plug-in from the page, and if we're not
1908         destroyed, log a success message.
1909
1910         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1911         Add new test to project.
1912
1913 2011-05-25  Tony Chang  <tony@chromium.org>
1914
1915         Reviewed by Adam Barth.
1916
1917         webkitpy's NetworkTransaction shouldn't use mechanize
1918         https://bugs.webkit.org/show_bug.cgi?id=61450
1919
1920         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1921         use urllib2 directly.  Re-add NetworkTransaction to
1922         test_results_uploader.py (reverting r87124).
1923
1924         * Scripts/webkitpy/common/net/networktransaction.py:
1925         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1926
1927 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1928
1929         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1930         until the port begins using those export macros.
1931
1932         * DumpRenderTree/chromium/config.h:
1933
1934 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1935
1936         Unreviewed, rolling out r87257.
1937         http://trac.webkit.org/changeset/87257
1938         https://bugs.webkit.org/show_bug.cgi?id=61457
1939
1940         This broke layout tests, see bug 61431. (Requested by
1941         hwennborg on #webkit).
1942
1943         * DumpRenderTree/chromium/LayoutTestController.cpp:
1944         (LayoutTestController::LayoutTestController):
1945         (LayoutTestController::clearAllDatabases):
1946         * DumpRenderTree/chromium/LayoutTestController.h:
1947
1948 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1949
1950         Reviewed by Andreas Kling.
1951
1952         [Qt] fast/css/disabled-author-styles.html failed
1953         https://bugs.webkit.org/show_bug.cgi?id=61438
1954
1955         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1956
1957         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1958         (WebCore::WebPage::resetSettings):
1959         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1960         (LayoutTestController::setAuthorAndUserStylesEnabled):
1961         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1962
1963 2011-05-25  Adam Roben  <aroben@apple.com>
1964
1965         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1966
1967         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1968         started exiting early due to too many crashes, timeouts, or failures
1969
1970         Reviewed by David Kilzer.
1971
1972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1973         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1974         run-webkit-tests exits early due to too many failures, pass that information in another
1975         argument to the callback.
1976         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1977         the new structure of the object passed to the callback.
1978         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1979         getNumberOfFailingTests and to pass that along to our own callbacks.
1980         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1981         from _getFailingTests and to store that value in the history object.
1982
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1984         (.info): Added.
1985
1986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1987         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1988         object and to add a note when run-webkit-tests exited early due to too many failures.
1989         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1990         latestBuildInfos since each entry now contains more than just the tester and failure count.
1991         Now displays a message for testers where the latest build exited early due to too many
1992         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1993         store that value in latestBuildInfos.
1994
1995 2011-05-24  Keishi Hattori  <keishi@webkit.org>
1996
1997         Reviewed by Kent Tamura.
1998
1999         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
2000         https://bugs.webkit.org/show_bug.cgi?id=61273
2001
2002         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
2003
2004 2011-05-24  Greg Simon  <gregsimon@chromium.org>
2005
2006         Reviewed by Dimitri Glazkov.
2007
2008         Control Indexeddb backends from LayoutTestController
2009         https://bugs.webkit.org/show_bug.cgi?id=61000
2010
2011         * DumpRenderTree/chromium/LayoutTestController.cpp:
2012         (LayoutTestController::LayoutTestController):
2013         (LayoutTestController::setOverrideIndexedDBBackingStore):
2014         (LayoutTestController::clearAllDatabases):
2015         * DumpRenderTree/chromium/LayoutTestController.h:
2016
2017 2011-05-24  Robert Hogan  <robert@webkit.org>
2018
2019         Reviewed by Ryosuke Niwa.
2020
2021         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
2022         https://bugs.webkit.org/show_bug.cgi?id=61393
2023
2024         * DumpRenderTree/qt/EventSenderQt.h:
2025         * DumpRenderTree/qt/EventSenderQt.cpp:
2026         (getModifiers): static function for interpreting modifiers
2027         (EventSender::mouseDown): Respect keyboard modifiers
2028         (EventSender::keyDown): use new static function
2029         (EventSender::sendOrQueueEvent): whitespace fix
2030
2031 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
2032
2033         Reviewed by Adam Barth.
2034
2035         Adding MHTML reading support.
2036         https://bugs.webkit.org/show_bug.cgi?id=7168
2037
2038         * Scripts/build-webkit:
2039         * Scripts/old-run-webkit-tests:
2040         * Scripts/webkitperl/features.pm:
2041         * Scripts/webkitpy/layout_tests/port/test_files.py:
2042         * Scripts/webkitpy/layout_tests/port/webkit.py:
2043
2044 2011-05-24  Stephen White  <senorblanco@chromium.org>
2045
2046         Reviewed by Kenneth Russell.
2047
2048         Remove most style checks on Source/ThirdParty/glu, since it doesn't
2049         follow WebKit style.
2050         https://bugs.webkit.org/show_bug.cgi?id=61365
2051
2052         * Scripts/webkitpy/style/checker.py:
2053
2054 2011-05-24  Adam Roben  <aroben@apple.com>
2055
2056         Don't allow forcing builds through the build.webkit.org web interface
2057
2058         Someone has been forcing bogus builds.
2059
2060         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2061
2062 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
2063
2064         Reviewed by Adam Roben.
2065
2066         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2067         https://bugs.webkit.org/show_bug.cgi?id=42669
2068
2069         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the 
2070         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
2071         Because that case changed the setting.
2072
2073         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2074         (WTR::InjectedBundle::beginTesting):
2075
2076 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2077
2078         Reviewed by Kenneth Rohde Christiansen.
2079
2080         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
2081         https://bugs.webkit.org/show_bug.cgi?id=61052
2082
2083         * Scripts/old-run-webkit-tests:
2084
2085 2011-05-24  Adam Roben  <aroben@apple.com>
2086
2087         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
2088
2089         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
2090         that don't have any failing tests, which isn't useful
2091
2092         Reviewed by David Kilzer.
2093
2094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
2095         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
2096         instead of name strings.
2097         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
2098         builder names into an array of builders.
2099
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2101         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
2102         the most recently completed build, or -1 if there is no such build.
2103         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
2104         in the given build, or -1 if the number could not be determined. Some of this code came from
2105         _getFailingTests.
2106         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
2107         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
2108         getNumberOfFailingTests functions.
2109
2110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2111         (ViewController.prototype._displayTesters): Get the current number of test failures for each
2112         tester and show it in the list. Omit testers that have no failures at all. We keep the
2113         testers and failure counts in an array and sort it before displaying the current data, as
2114         the order in which data will be fetched is unpredictable.
2115
2116 2011-05-23  Tony Chang  <tony@chromium.org>
2117
2118         Reviewed by Ojan Vafai.
2119
2120         [nrwt] don't use NetworkTranslation when uploading results
2121         https://bugs.webkit.org/show_bug.cgi?id=61315
2122
2123         This avoids autoinstalling mechanize.  It didn't matter anyway
2124         because test_results_uploader.py wasn't using mechanize to make the
2125         request so NetworkTransaction::run wasn't doing anything extra
2126         (it only matters if it catches mechanize.HTTPError).
2127
2128         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2129
2130 2011-05-23  Tony Chang  <tony@chromium.org>
2131
2132         Reviewed by Dirk Pranke.
2133
2134         [chromium] fix the rebaseline tool to work with Linux GPU failures
2135         https://bugs.webkit.org/show_bug.cgi?id=61312
2136
2137         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2138
2139 2011-05-23  Darin Adler  <darin@apple.com>
2140
2141         Ignore generated .pyc files in a directory full of python code.
2142
2143         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
2144
2145 2011-05-23  Adam Barth  <abarth@webkit.org>
2146
2147         Reviewed by Eric Seidel.
2148
2149         sheriffbot should give more details about the failures in IRC
2150         https://bugs.webkit.org/show_bug.cgi?id=61233
2151
2152         With this patch, sheriffbot will annonce the set of failing tests,
2153         which might help folks triage the problem.
2154
2155         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2156         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2157
2158 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2159
2160         Unreviewed, rolling out r87078.
2161         http://trac.webkit.org/changeset/87078
2162         https://bugs.webkit.org/show_bug.cgi?id=61294
2163
2164         Patch contains errors and seems likely to break a bunch of
2165         bots (Requested by abarth on #webkit).
2166
2167         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2168         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2169         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2170
2171 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
2172
2173         Reviewed by Ojan Vafai.
2174
2175         Convert json_results_generator.py to output version 4 JSON.
2176         https://bugs.webkit.org/show_bug.cgi?id=60869
2177
2178         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2179         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2180         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2181
2182 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
2183
2184         Reviewed by Adam Barth.
2185
2186         Move generation of shell_command from port to executive
2187         https://bugs.webkit.org/show_bug.cgi?id=61251
2188
2189         After move it's possible to use the code in other places too.
2190
2191         * Scripts/webkitpy/common/config/ports.py:
2192         * Scripts/webkitpy/common/system/executive.py:
2193
2194 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
2195
2196         Reviewed by Darin Adler.
2197
2198         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
2199         https://bugs.webkit.org/show_bug.cgi?id=42669
2200
2201         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
2202
2203         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2204         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2205         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
2206         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2207
2208 2011-05-22  Robert Hogan  <robert@webkit.org>
2209
2210         Reviewed by Kenneth Rohde Christiansen.
2211
2212         Fix policyDelegate in Qt DRT
2213         https://bugs.webkit.org/show_bug.cgi?id=61247
2214
2215         Use the 'policy delegate' implemented in FrameLoaderClient
2216         for layout tests. The partial implementation in DumpRenderTreeQt
2217         is redundant, so remove it.
2218
2219         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2220         (WebCore::WebPage::acceptNavigationRequest):
2221         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2222         (LayoutTestController::waitForPolicyDelegate):
2223
2224 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
2225
2226         Reviewed by Darin Adler.
2227
2228         Use double quotes for filename arguments
2229         https://bugs.webkit.org/show_bug.cgi?id=61250
2230
2231         Windows does not support single quotes on the command line,
2232         so replace them with double quotes.
2233
2234         * Scripts/prepare-ChangeLog:
2235
2236 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
2237
2238         Reviewed by Sam Weinig.
2239
2240         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
2241         https://bugs.webkit.org/show_bug.cgi?id=42550
2242         
2243         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
2244
2245         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2246         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2247         Copy the code for pausing animations, FIXME comments and all.
2248         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2249         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2250
2251 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
2252
2253         Reviewed by Stephen White.
2254
2255         Adding myself to the committers list.
2256
2257         * Scripts/webkitpy/common/config/committers.py:
2258
2259 2011-05-19  Adam Roben  <aroben@apple.com>
2260
2261         Test that the WebKit2 UI process doesn't crash when starting a download
2262
2263         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
2264         (preceded by assertion) in fastMalloc when downloading a file
2265
2266         Reviewed by Darin Adler.
2267
2268         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
2269
2270         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
2271         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
2272         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
2273         started, cancel the download, and return a bogus string.
2274
2275         (TestWebKitAPI::setContextDownloadClient):
2276         (TestWebKitAPI::setPagePolicyClient):
2277         Simple helper functions.
2278
2279         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
2280         our policy client, and run until we know that the download was started. If we haven't
2281         crashed, we win!
2282
2283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2284         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2285         * TestWebKitAPI/win/copy-resources.cmd:
2286         Added new files.
2287
2288 2011-05-20  Kent Tamura  <tkent@chromium.org>
2289
2290         Reviewed by Ryosuke Niwa.
2291
2292         Fix style errors in DumpRenderTree/chromium/.
2293         https://bugs.webkit.org/show_bug.cgi?id=61172
2294
2295         * DumpRenderTree/chromium/CppBoundClass.cpp:
2296         (CppBoundClass::getAsCppVariant):
2297         (CppBoundClass::bindToJavascript):
2298         * DumpRenderTree/chromium/CppBoundClass.h:
2299         (CppBoundClass::GetterCallback::~GetterCallback):
2300         (CppBoundClass::CppBoundClass):
2301         (CppBoundClass::Callback::~Callback):
2302         (CppBoundClass::MemberCallback::MemberCallback):
2303         (CppBoundClass::MemberCallback::~MemberCallback):
2304         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
2305         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
2306         * DumpRenderTree/chromium/CppVariant.h:
2307         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2308         (DRTDevToolsAgent::~DRTDevToolsAgent):
2309         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2310         (DRTDevToolsClient::sendFrontendLoaded):
2311         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2312         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2313         (main):
2314         * DumpRenderTree/chromium/EventSender.cpp:
2315         (SavedEvent::SavedEvent):
2316         (EventSender::EventSender):
2317         (EventSender::keyDown):
2318         * DumpRenderTree/chromium/EventSender.h:
2319         * DumpRenderTree/chromium/ImageDiff.cpp:
2320         (Image::Image):
2321         * DumpRenderTree/chromium/LayoutTestController.cpp:
2322         (LayoutTestController::LayoutTestController):
2323         (LayoutTestController::WorkQueue::reset):
2324         (WorkItemBackForward::WorkItemBackForward):
2325         (WorkItemLoadingScript::WorkItemLoadingScript):
2326         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
2327         (WorkItemLoad::WorkItemLoad):
2328         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2329         (LayoutTestController::pathToLocalResource):
2330         * DumpRenderTree/chromium/LayoutTestController.h:
2331         (LayoutTestController::WorkItem::~WorkItem):
2332         (LayoutTestController::WorkQueue::WorkQueue):
2333         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2334         (MockSpellCheck::MockSpellCheck):
2335         (MockSpellCheck::~MockSpellCheck):
2336         * DumpRenderTree/chromium/MockSpellCheck.h:
2337         * DumpRenderTree/chromium/NotificationPresenter.h:
2338         (NotificationPresenter::NotificationPresenter):
2339         * DumpRenderTree/chromium/Task.cpp:
2340         (WebTask::WebTask):
2341         * DumpRenderTree/chromium/Task.h:
2342         (TaskList::TaskList):
2343         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2344         (DRTPrinter::DRTPrinter):
2345         (TestShellPrinter::TestShellPrinter):
2346         * DumpRenderTree/chromium/TestNavigationController.cpp:
2347         (TestNavigationEntry::TestNavigationEntry):
2348         (TestNavigationEntry::~TestNavigationEntry):
2349         (TestNavigationController::TestNavigationController):
2350         (TestNavigationController::reload):
2351         (TestNavigationController::loadEntry):
2352         (TestNavigationController::didNavigateToEntry):
2353         * DumpRenderTree/chromium/TestNavigationController.h:
2354         (TestShellExtraData::TestShellExtraData):
2355         * DumpRenderTree/chromium/TestShell.cpp:
2356         (dumpHistoryItem):
2357         * DumpRenderTree/chromium/TestShell.h:
2358         (TestParams::TestParams):
2359         * DumpRenderTree/chromium/TestShellWin.cpp:
2360         (TestShell::waitTestFinished):
2361         * DumpRenderTree/chromium/TestWebWorker.h:
2362         (TestWebWorker::startWorkerContext):
2363         (TestWebWorker::terminateWorkerContext):
2364         (TestWebWorker::postMessageToWorkerContext):
2365         (TestWebWorker::clientDestroyed):
2366         (TestWebWorker::postMessageToWorkerObject):
2367         (TestWebWorker::postExceptionToWorkerObject):
2368         (TestWebWorker::postConsoleMessageToWorkerObject):
2369         (TestWebWorker::confirmMessageFromWorkerObject):
2370         (TestWebWorker::reportPendingActivity):
2371         (TestWebWorker::workerContextClosed):
2372         (TestWebWorker::~TestWebWorker):
2373         * DumpRenderTree/chromium/TextInputController.cpp:
2374         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2375         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2376         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2377         (WebThemeEngineDRTWin::paintButton):
2378         (WebThemeEngineDRTWin::paintMenuList):
2379         (WebThemeEngineDRTWin::paintTrackbar):
2380         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2381         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2382         * DumpRenderTree/chromium/WebViewHost.cpp:
2383         (WebViewHost::navigate):
2384         (WebViewHost::updateSessionHistory):
2385         (WebViewHost::paintInvalidatedRegion):
2386         * DumpRenderTree/chromium/WebViewHost.h:
2387
2388 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2389
2390         Reviewed by Adam Roben.
2391
2392         Detect hangs in run-api-tests
2393         https://bugs.webkit.org/show_bug.cgi?id=48043
2394
2395         * Scripts/run-api-tests: Added test timeouts
2396
2397 2011-05-19  Dmitry Lomov  <dslomov@google.com>
2398
2399         Reviewed by Adam Roben.
2400
2401         run-api-tests should run one test per process
2402         https://bugs.webkit.org/show_bug.cgi?id=61088
2403
2404         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows, 
2405         return code, and parsing GTest output format.
2406
2407 2011-05-15  Robert Hogan  <robert@webkit.org>
2408
2409         Reviewed by Antonio Gomes.
2410
2411         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
2412         https://bugs.webkit.org/show_bug.cgi?id=60834
2413         Fix unix test plugin for plugins/get-url-with-javascript-url.html
2414
2415         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2416         (webkit_test_plugin_new_stream):
2417         (webkit_test_plugin_write_ready):
2418         (webkit_test_plugin_write):
2419
2420 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2421
2422         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
2423         http://trac.webkit.org/changeset/86869
2424         http://trac.webkit.org/changeset/86873
2425         http://trac.webkit.org/changeset/86875
2426         http://trac.webkit.org/changeset/86877
2427         https://bugs.webkit.org/show_bug.cgi?id=61139
2428
2429         broke builds and debug DRT (Requested by rniwa on #webkit).
2430
2431         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2432         * DumpRenderTree/chromium/TestShell.cpp:
2433         (TestShell::bindJSObjectsToWindow):
2434         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2435         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2436
2437 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
2438
2439         Reviewed by Darin Adler.
2440
2441         Add build logistics and plumbing for window.internals object.
2442         https://bugs.webkit.org/show_bug.cgi?id=60313
2443
2444         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
2445         * DumpRenderTree/chromium/TestShell.cpp:
2446         (TestShell::bindJSObjectsToWindow): Added injection code.
2447         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2448         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
2449
2450 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
2451
2452         Reviewed by Csaba Osztrogonác.
2453
2454         [Qt] Implement eventSender.scalePageBy
2455         https://bugs.webkit.org/show_bug.cgi?id=60015
2456
2457         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2458         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2459         * DumpRenderTree/qt/EventSenderQt.cpp:
2460         (EventSender::scalePageBy):
2461         * DumpRenderTree/qt/EventSenderQt.h:
2462
2463 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
2464
2465         Reviewed by Kent Tamura.
2466
2467         [Chromium] IME candidate window appears wrong position in an iframe
2468         https://bugs.webkit.org/show_bug.cgi?id=61023
2469
2470         Call the focused frame's firstRectForCharacterRange() instead of the
2471         main frame so that DRT behaves as the same as Chromium.
2472
2473         * DumpRenderTree/chromium/TextInputController.cpp:
2474         (TextInputController::firstRectForCharacterRange):
2475
2476 2011-05-18  Adam Roben  <aroben@apple.com>
2477
2478         Add a new page to build.webkit.org to help find when tests started failing
2479
2480         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
2481         right now, but already shows some useful information. It's somewhat similar to webkit-patch
2482         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
2483         little more convenient than either of them, though, because it's all done in the browser
2484         (and thus it's easy to go directly to the relevant test results).
2485
2486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
2487         (Buildbot): This class represents a Buildbot server.
2488         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
2489         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
2490         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
2491         callback.
2492         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
2493         be implemented by a derived class that understands this server's build naming scheme.
2494         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2495         particular build.
2496
2497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
2498         (Builder): This class represents one builder on the buildbot.
2499         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
2500         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
2501         information about a particular test failure.
2502         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
2503         information about when tests started failing.
2504         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
2505         particular build.
2506         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
2507         callback.
2508         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
2509         extracts all the failing tests listed in it, passing them to the callback.
2510         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
2511         build, merges them into the build history, and calls the callback telling it whether the
2512         next build should be fetched to provide more information.
2513
2514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2515         Added. Just some simple styles.
2516
2517         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
2518         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
2519         (getResource): Wrapper around XMLHttpRequest.
2520         (Array.prototype.findFirst): Finds the first element matching the given predicate and
2521         returns it.
2522         (Array.prototype.last): Returns the last element of the array.
2523
2524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
2525         (ViewController): This class contains the main logic for displaying the page.
2526         (ViewController.loaded): Just calls through to parseHash.
2527         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
2528         shows the list of all testers so one can be chosen. This function is called when the page
2529         loads and whenever we get a hashchange event.
2530         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
2531         as it is fetched. The display ends up grouping tests by when they started failing.
2532         (ViewController._displayTesters): Gets the list of testers and displays it.
2533
2534         (ViewController._domForBuildName):
2535         (ViewController._domForFailedTest):
2536         Helper functions to create descriptions and links for a particular build or failed test.
2537
2538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
2539         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
2540         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
2541
2542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
2543         loads all the files and sets up a ViewController, which does the rest.
2544
2545         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
2546         page.
2547
2548 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2549
2550         Reviewed by Csaba Osztrogonác.
2551
2552         [Qt] Implement layoutTestController.setValueForUser()
2553         https://bugs.webkit.org/show_bug.cgi?id=60956
2554
2555         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2556         (LayoutTestController::setValueForUser):
2557         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2558
2559 2011-05-16  Robert Hogan  <robert@webkit.org>
2560
2561         Reviewed by Kenneth Rohde Christiansen.
2562
2563         plugins/invalidate_rect.html fails on linux ports
2564
2565         - Make the unix test netscape plugin recognize the onPaintEvent
2566           and windowedPlugin parameters.
2567
2568         https://bugs.webkit.org/show_bug.cgi?id=54051
2569
2570         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2571         (handleEventX11):
2572         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2573         (LayoutTestController::displayInvalidatedRegion):
2574         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2575         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2576         (webkit_test_plugin_new_instance):
2577         (webkit_test_plugin_handle_event):
2578
2579 2011-05-17  Tony Chang  <tony@chromium.org>
2580
2581         Reviewed by Ojan Vafai.
2582
2583         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
2584         https://bugs.webkit.org/show_bug.cgi?id=60895
2585
2586         Update the tools to handle the move.  Lucid 32 results now go in
2587         chromium-linux-x86 and the default platform on Linux is now x86_64.
2588
2589         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
2590         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2591         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
2592         * Scripts/webkitpy/layout_tests/port/base.py: ditto
2593         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
2594         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2595         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
2596         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
2597         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
2598
2599 2011-05-17  Adam Roben  <aroben@apple.com>
2600
2601         Make run-api-tests work on Windows when there are spaces in the path
2602
2603         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
2604         spaces in the path to TestWebKitAPI.exe
2605
2606         Reviewed by David Levin.
2607
2608         * Scripts/run-api-tests:
2609         (runTestTool): Use the "direct object" form of system() to avoid having the path to
2610         TestWebKitAPI.exe be split by the shell.
2611
2612 2011-05-16  Ian Henderson  <ianh@apple.com>
2613
2614         Reviewed by Joseph Pecoraro.
2615
2616         Page::goToItem doesn't work while loading is deferred
2617         https://bugs.webkit.org/show_bug.cgi?id=60412
2618
2619         Add setDefersLoading and goBack methods to LayoutTestController.  We
2620         need to use goBack() instead of history.back() because the latter goes
2621         through NavigationScheduler, hence doesn't exhibit the bug.
2622
2623         * DumpRenderTree/LayoutTestController.cpp:
2624         (goBackCallback):
2625         (setDefersLoadingCallback):
2626         (LayoutTestController::staticFunctions):
2627         * DumpRenderTree/LayoutTestController.h:
2628         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2629         (LayoutTestController::goBack):
2630         (LayoutTestController::setDefersLoading):
2631         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2632         (LayoutTestController::goBack):
2633         (LayoutTestController::setDefersLoading):
2634         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2635         (LayoutTestController::goBack):
2636         (LayoutTestController::setDefersLoading):
2637         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2638         (LayoutTestController::goBack):
2639         (LayoutTestController::setDefersLoading):
2640
2641 2011-05-16  Sam Weinig  <sam@webkit.org>
2642
2643         Reviewed by Anders Carlsson.
2644
2645         TestWebKitAPI should build with clang if it can
2646         https://bugs.webkit.org/show_bug.cgi?id=60918
2647
2648         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2649         Update CompilerVersion.xcconfig to match others.
2650
2651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2652         Add CompilerVersion.xcconfig to the project.
2653
2654         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2655         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2656         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2657         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2658         Add some casts to quiet warnings from clang.
2659
2660 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
2661
2662         Reviewed by David Levin.
2663
2664         add dpranke as a reviewer
2665         https://bugs.webkit.org/show_bug.cgi?id=60919
2666
2667         * Scripts/webkitpy/common/config/committers.py:
2668
2669 2011-05-16  Robert Hogan  <robert@webkit.org>
2670
2671         Reviewed by Anders Carlsson.
2672
2673         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
2674
2675         https://bugs.webkit.org/show_bug.cgi?id=60838
2676
2677         The unix test plugin needs to call the test's NPP_URLNotify
2678         rather than the browsers.
2679
2680         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2681         (webkit_test_plugin_url_notify):
2682
2683 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
2684
2685         Rubber-stamped by Adam Roben.
2686
2687         Adding myself as a reviewer.
2688         * Scripts/webkitpy/common/config/committers.py:
2689
2690 2011-05-16  Sam Weinig  <sam@webkit.org>
2691
2692         Fix typo pointed out by Dave Levin.
2693
2694         * TestWebKitAPI/PlatformUtilities.h:
2695         (TestWebKitAPI::Util::assertWKStringEqual):
2696         Strig -> String.
2697
2698 2011-05-16  Sam Weinig  <sam@webkit.org>
2699
2700         Reviewed by David Levin.
2701
2702         Convert api tester over to using gtest expectations directly
2703         https://bugs.webkit.org/show_bug.cgi?id=60862
2704
2705         * TestWebKitAPI/PlatformUtilities.cpp:
2706         (TestWebKitAPI::Util::toSTD):
2707         * TestWebKitAPI/PlatformUtilities.h:
2708         (TestWebKitAPI::Util::assertWKStrigEqual):
2709         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
2710         the implementation of the macro simpler.
2711
2712         * TestWebKitAPI/Test.h:
2713         Remove TEST_ASSERT forwarder.
2714
2715         [Test changes elided]
2716
2717 2011-05-16  David Kilzer  <ddkilzer@apple.com>
2718
2719         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
2720         <rdar://problem/9446430>
2721
2722         Reviewed by Mark Rowe.
2723
2724         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
2725         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2726         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2727
2728 2011-05-16  Jon Lee  <jonlee@apple.com>
2729
2730         Reviewed by Simon Fraser.
2731
2732         Can't horizontally scroll iframes and overflow because wheel events are always accepted
2733         https://bugs.webkit.org/show_bug.cgi?id=60779
2734
2735         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2736         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
2737
2738 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
2739
2740         Reviewed by Csaba Osztrogonác.
2741
2742         [Qt] Tools.pro misses include(common.pri)
2743         https://bugs.webkit.org/show_bug.cgi?id=60883
2744
2745         It includes features.pri, which depends on common.pri (the build is
2746         not broken today with the default options, but this is the right
2747         thing to do).
2748
2749         * Tools.pro:
2750
2751 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
2752
2753         Unreviewed: adding myself to committers.py.
2754
2755         * Scripts/webkitpy/common/config/committers.py:
2756
2757 2011-05-15  Daniel Bates  <dbates@webkit.org>
2758
2759         Reviewed by Chris Jerdonek.
2760
2761         svn-apply can't handle Git diff that only changes executable bit
2762         https://bugs.webkit.org/show_bug.cgi?id=60848
2763
2764         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
2765         that only has an executable bit change.
2766
2767         * Scripts/VCSUtils.pm:
2768           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
2769         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
2770         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
2771         * Scripts/svn-apply:
2772         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
2773         * Scripts/svn-unapply:
2774         (patch): Ditto.
2775         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2776           - Updated expected results for test cases to account for numTextChunks.
2777           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
2778           - Added test case "Git: file that only has an executable bit change".
2779         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2780           - Updated expected results for test cases to account for numTextChunks.
2781
2782 2011-05-15  Sam Weinig  <sam@webkit.org>
2783
2784         Fix windows build.
2785
2786         * TestWebKitAPI/win/main.cpp:
2787         (main):
2788
2789 2011-05-15  Sam Weinig  <sam@webkit.org>
2790
2791         Reviewed by David Levin.
2792
2793         Make API tester more gtest friendly
2794         https://bugs.webkit.org/show_bug.cgi?id=60859
2795
2796         * Scripts/run-api-tests:
2797         Numerous changes:
2798         - Remove logic to run tests one at a time.
2799         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to 
2800           the test runner and allow gtest to print it for us.
2801         - Forward stdout from the test tool to stdout, even in non-verbose runs.
2802         - Run test tool from the current working directory instead of the root webkit
2803           directory.
2804
2805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2806         Move plist to be with other bundle sources.
2807
2808         * TestWebKitAPI/TestsController.cpp:
2809         (TestWebKitAPI::TestsController::TestsController):
2810         (TestWebKitAPI::TestsController::run):
2811         * TestWebKitAPI/TestsController.h:
2812         * TestWebKitAPI/mac/main.mm:
2813         Simplify TestController down to a single run function. We should consider removing the class
2814         entirely at some point.
2815
2816 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2817
2818         Unreviewed, rolling out r86504.
2819         http://trac.webkit.org/changeset/86504
2820         https://bugs.webkit.org/show_bug.cgi?id=60853
2821
2822         "Broke Qt EventSender in editing/selection tests" (Requested
2823         by mwenge on #webkit).
2824
2825         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2826         (WebCore::WebPage::WebPage):
2827         (WebCore::DumpRenderTree::DumpRenderTree):
2828         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2829         (WebCore::DumpRenderTree::initJSObjects):
2830         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2831         (WebCore::DumpRenderTree::eventSender):
2832         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2833         (webkit_test_plugin_new_instance):
2834         (webkit_test_plugin_set_window):
2835         (webkit_test_plugin_handle_event):
2836
2837 2011-05-12  Robert Hogan  <robert@webkit.org>
2838
2839         Reviewed by Benjamin Poulain.
2840
2841         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2842
2843         The support for this test added to the unix test plugin here
2844         may allow other platforms to pass it (nearly everyone
2845         skips it). On Qt it required a bit of trickiness with
2846         the page's EventSender object to get it working fully though,
2847         so only unskipping Qt here.
2848
2849         https://bugs.webkit.org/show_bug.cgi?id=60722
2850
2851         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2852         (WebCore::WebPage::WebPage):
2853         (WebCore::WebPage::eventSender):
2854         (WebCore::DumpRenderTree::DumpRenderTree):
2855         (WebCore::DumpRenderTree::initJSObjects):
2856         (WebCore::DumpRenderTree::createWindow):
2857         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2858         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2859         (webkit_test_plugin_new_instance):
2860         (webkit_test_plugin_set_window):
2861         (webkit_test_plugin_handle_event):
2862
2863 2011-05-14  Arno Renevier  <arno@renevier.net>
2864
2865         Reviewed by Martin Robinson.
2866
2867         make run-gtk-tests executable
2868         https://bugs.webkit.org/show_bug.cgi?id=59278
2869
2870         * Scripts/run-gtk-tests:
2871
2872 2011-05-14  Anders Carlsson  <andersca@apple.com>
2873
2874         Reviewed by Kevin Decker.
2875
2876         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2877         https://bugs.webkit.org/show_bug.cgi?id=60823
2878         <rdar://problem/9430386>
2879
2880         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2881
2882         * DumpRenderTree/DumpRenderTree.gypi:
2883         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2884         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2885         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2886         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2887         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2888         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2889         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2890         * GNUmakefile.am:
2891
2892 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2893
2894         Unreviewed, rolling out r86476.
2895         http://trac.webkit.org/changeset/86476
2896         https://bugs.webkit.org/show_bug.cgi?id=60832
2897
2898         It made plugins/get-url-notify-with-url-that-fails-to-
2899         load.html crash on GTK (Requested by Ossy on #webkit).
2900
2901         * DumpRenderTree/DumpRenderTree.gypi:
2902         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2903         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
2904         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2905         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2906         * GNUmakefile.am:
2907
2908 2011-05-13  Anders Carlsson  <andersca@apple.com>
2909
2910         Reviewed by Sam Weinig.
2911
2912         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
2913         https://bugs.webkit.org/show_bug.cgi?id=60823
2914         <rdar://problem/9430386>
2915
2916         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2917
2918         * DumpRenderTree/DumpRenderTree.gypi:
2919         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2920         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2921         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2922         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2923         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2924         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2925         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2926         * GNUmakefile.am:
2927
2928 2011-05-13  Anders Carlsson  <andersca@apple.com>
2929
2930         Build fix.
2931
2932         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2933
2934 2011-05-13  Anders Carlsson  <andersca@apple.com>
2935
2936         Reviewed by Sam Weinig.
2937
2938         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2939         https://bugs.webkit.org/show_bug.cgi?id=60810
2940
2941         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2942
2943         * DumpRenderTree/DumpRenderTree.gypi:
2944         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2945         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2946         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2947         * GNUmakefile.am:
2948         Add files.
2949
2950         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2951         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2952         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2953
2954         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2955         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2956         (GetURLWithJavaScriptURL::NPP_New):
2957         (GetURLWithJavaScriptURL::NPP_NewStream):
2958         (GetURLWithJavaScriptURL::NPP_DestroyStream):
2959         (GetURLWithJavaScriptURL::NPP_WriteReady):
2960         (GetURLWithJavaScriptURL::NPP_Write):
2961         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2962         (NPP_NewStream):
2963         (NPP_WriteReady):
2964         (NPP_Write):
2965         (NPP_URLNotify):
2966         call the PluginTest NPP wrappers.
2967
2968 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2969
2970         Unreviewed, rolling out r86447.
2971         http://trac.webkit.org/changeset/86447
2972         https://bugs.webkit.org/show_bug.cgi?id=60809
2973
2974         "Broke some uses of EventSender object on Qt" (Requested by
2975         mwenge on #webkit).
2976
2977         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2978         (WebCore::WebPage::WebPage):
2979         (WebCore::DumpRenderTree::DumpRenderTree):
2980         (WebCore::DumpRenderTree::initJSObjects):
2981         (WebCore::DumpRenderTree::createWindow):
2982         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2983         (WebCore::DumpRenderTree::eventSender):
2984         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2985         (webkit_test_plugin_new_instance):
2986         (webkit_test_plugin_set_window):
2987         (webkit_test_plugin_handle_event):
2988
2989 2011-05-13  Robert Hogan  <robert@webkit.org>
2990
2991         Reviewed by Benjamin Poulain.
2992
2993         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2994
2995         The support for this test added to the unix test plugin here
2996         may allow other platforms to pass it (nearly everyone
2997         skips it). On Qt it required a bit of trickiness with
2998         the page's EventSender object to get it working fully though,
2999         so only unskipping Qt here.
3000
3001         https://bugs.webkit.org/show_bug.cgi?id=60722
3002
3003         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3004         (WebCore::WebPage::WebPage):
3005         (WebCore::WebPage::eventSender):
3006         (WebCore::DumpRenderTree::DumpRenderTree):
3007         (WebCore::DumpRenderTree::initJSObjects):
3008         (WebCore::DumpRenderTree::createWindow):
3009         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3010         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3011         (webkit_test_plugin_new_instance):
3012         (webkit_test_plugin_set_window):
3013         (webkit_test_plugin_handle_event):
3014
3015 2011-05-13  Adam Roben  <aroben@apple.com>
3016
3017         Exclude the Leopard NRWT bot from the core builder set
3018
3019         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
3020
3021         Reviewed by Darin Adler.
3022
3023         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3024         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
3025         in the core builder set.
3026
3027         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3028         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
3029         regexps.
3030
3031 2011-05-13  Adam Roben  <aroben@apple.com>
3032
3033         Group all the NRWT bots together
3034
3035         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
3036         bots are experimental, it seems best not to clutter up the non-experimental bots with
3037         experimental ones.
3038
3039         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
3040         on build.webkit.org
3041
3042         Reviewed by Dan Bernstein.
3043
3044         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
3045         Chromium testers, which also use new-run-webkit-tests.
3046
3047 2011-05-13  Adam Roben  <aroben@apple.com>
3048
3049         Add a plugin test that dumps the plugin window's rect
3050
3051         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
3052         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
3053
3054         Reviewed by Dan Bernstein.
3055
3056         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
3057         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
3058         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
3059         harness window and log it.
3060
3061         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
3062
3063 2011-05-13  Adam Roben  <aroben@apple.com>
3064
3065         Move code required for most tests of plugin window geometry into a base class
3066
3067         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
3068         having all the trickiness in a shared base class, writing new window geometry tests will be
3069         much easier.
3070
3071         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
3072
3073         Reviewed by Anders Carlsson.
3074
3075         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3076         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
3077         WindowGeometryTest base class. Most of the code from this class was moved to the new base
3078         class.
3079         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
3080         This is called by the base class when it is safe to check the window's geometry. Note that
3081         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
3082         just vestigial code from an earlier version of this test.
3083
3084         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
3085         WindowGeometryTest class.
3086
3087         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
3088         WindowRegionIsSetToClipRect.
3089         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
3090         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
3091         Subclasses can implement that function to perform their own tests.
3092
3093         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
3094
3095 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
3096
3097         Reviewed by Csaba Osztrogonác.
3098
3099         Missing 2nd #EOF if WebProcess is killed.
3100         https://bugs.webkit.org/show_bug.cgi?id=60761
3101
3102         If the WebProcess is killed, only one #EOF is yielded
3103         by WebKitTestRunner. However, run-webkit-test wait for
3104         a second #EOF, which signals the finishing of pixel dump.
3105         Since this never happens, run-webkit-test waits forever.
3106
3107         * WebKitTestRunner/TestInvocation.cpp:
3108         (WTR::TestInvocation::dump):
3109         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3110         * WebKitTestRunner/TestInvocation.h:
3111
3112 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3113
3114         Reviewed by Csaba Osztrogonác.
3115
3116         [NRWT] chromium-linux tests shouldn't run on other platforms
3117         https://bugs.webkit.org/show_bug.cgi?id=60162
3118
3119         Remove _tests_for_other_platforms defs because r82753
3120         implemented it properly in the baseclass in webkit.py.
3121
3122         * Scripts/webkitpy/layout_tests/port/gtk.py:
3123         * Scripts/webkitpy/layout_tests/port/qt.py:
3124         * Scripts/webkitpy/layout_tests/port/win.py:
3125
3126 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
3127
3128         Reviewed by Antonio Gomes.
3129
3130         [EFL] Remove unused option of EWeblauncher
3131         https://bugs.webkit.org/show_bug.cgi?id=60747
3132
3133         Remove sudo-workaround option.
3134         This option is not used and make other option wrong.
3135
3136         * EWebLauncher/main.c:
3137
3138 2011-05-12  Lucas Forschler  <lforschler@apple.com>
3139
3140         Reviewed by Stephanie Lewis.
3141
3142         Fix config.json to address missing WK2 builder/tester config.
3143         Fix naming of machines (xserve not macpro)
3144
3145         * BuildSlaveSupport/build.webkit.org-config/config.json:
3146
3147 2011-05-12  Lucas Forschler  <lforschler@apple.com>
3148
3149         Reviewed by Stephanie Lewis.
3150
3151         Add SnowLeopard Debug builder and Test bot.
3152         apple-xserve-8 = SL Debug Tester.
3153         apple-xserve-9 = SL Debug Builder.
3154         
3155         * BuildSlaveSupport/build.webkit.org-config/config.json:
3156
3157 2011-05-12  Adam Barth  <abarth@webkit.org>
3158
3159         This patch disables sheriffbot's bug postings.  He's just been way too
3160         spammy recently due to test flakiness.
3161
3162         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3163         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3164
3165 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
3166
3167         Reviewed by Anders Carlsson.
3168
3169         After relaunching an unresponsive web process, web page stops responding to mouse movement
3170         https://bugs.webkit.org/show_bug.cgi?id=60669
3171         <rdar://problem/9409934>
3172         
3173         This test follows the steps needed to reproduce this bug:
3174         1) Hang the web process
3175         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
3176         3) Kill and restart the WebProcess
3177         4) Move the mouse
3178         
3179         We are testing that we receive mouse move events after the WebProcess has restarted.
3180
3181         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
3182         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
3183         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
3184         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
3185         (TestWebKitAPI::setPageLoaderClient):
3186         (TestWebKitAPI::TEST):
3187         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
3188         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
3189         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
3190         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
3191
3192         * TestWebKitAPI/PlatformWebView.h:
3193         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3194         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
3195         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3196         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
3197
3198         Add new files.
3199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3200         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3201         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3202         * TestWebKitAPI/win/copy-resources.cmd:
3203
3204 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
3205
3206         Reviewed by Antonio Gomes.
3207
3208         [EFL] Added initialization/shutdown for ecore_file library
3209         https://bugs.webkit.org/show_bug.cgi?id=60457
3210
3211         Added initialization and shuthown for ecore_file library and replaced
3212         realpath function to ecore_file_realpath.
3213
3214         * EWebLauncher/main.c:
3215         (quit):
3216         (findThemePath):
3217         (main):
3218
3219 2011-05-12  Young Han Lee  <joybro@company100.net>
3220
3221         Reviewed by Kenneth Rohde Christiansen.
3222
3223         [Qt] Implement layoutTestController.layerTreeAsText()
3224         https://bugs.webkit.org/show_bug.cgi?id=60367
3225
3226         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3227         (LayoutTestController::layerTreeAsText):
3228         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3229
3230 2011-05-11  Eric Seidel  <eric@webkit.org>
3231
3232         Reviewed by David Levin.
3233
3234         Teach validate-committer-lists how to validate committers bugzilla_email()
3235         https://bugs.webkit.org/show_bug.cgi?id=60651
3236
3237         It turns out we currently have 9 committers with invalid values for their
3238         bugzilla_email field (meaning we don't know what email is their bugzilla account).
3239         "Alexander Kellett" <lypanov@mac.com>
3240         "Andre Boule" <aboule@apple.com>
3241         "Cameron McCormack" <cam@webkit.org>
3242         "Chris Petersen" <cpetersen@apple.com>
3243         "Eli Fidler" <eli@staikos.net>
3244         "Matt Lilek" <webkit@mattlilek.com>
3245         "Pierre d'Herbemont" <pdherbemont@free.fr>
3246         "Scott Violet" <sky@chromium.org>
3247         "Adam Treat" <treat@kde.org>
3248
3249         Most of those haven't committed in a very long time, so it's not suprising
3250         that we haven't noticed that their bugzilla emails are bogus.
3251
3252         * Scripts/validate-committer-lists:
3253         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3254         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3255
3256 2011-05-11  Dmitry Lomov  <dslomov@google.com>
3257
3258         Reviewed by David Levin.
3259
3260         https://bugs.webkit.org/show_bug.cgi?id=59561
3261         Switch TestWebKitAPI to GTest
3262
3263         Fixes Makefiles and WinCairo build as well
3264
3265         * Makefile:
3266         * Scripts/build-api-tests:
3267         * Scripts/run-api-tests:
3268         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3269         * TestWebKitAPI/Test.h:
3270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3271         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3272         (TestWebKitAPI::TEST):
3273         * TestWebKitAPI/TestsController.cpp:
3274         (TestWebKitAPI::TestsController::TestsController):
3275         (TestWebKitAPI::TestsController::dumpTestNames):
3276         (TestWebKitAPI::TestsController::runTestNamed):
3277         (TestWebKitAPI::TestsController::runAllTests):
3278         * TestWebKitAPI/TestsController.h:
3279         * TestWebKitAPI/mac/main.mm:
3280         (main):
3281
3282 2011-05-11  Eric Seidel  <eric@webkit.org>
3283
3284         Reviewed by Alexey Proskuryakov.
3285
3286         Add Luke Macpherson to committers.py as a Contributor
3287         https://bugs.webkit.org/show_bug.cgi?id=60639
3288
3289         * Scripts/webkitpy/common/config/committers.py:
3290
3291 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
3292
3293         Reviewed by Kenneth Rohde Christiansen.
3294
3295         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
3296         https://bugs.webkit.org/show_bug.cgi?id=60439
3297
3298         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
3299
3300         * Scripts/build-webkit:
3301
3302 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
3303
3304         Reviewed by Adam Roben.
3305
3306         REGRESSION (r86161): WKPreferences API test failing on Windows
3307         https://bugs.webkit.org/show_bug.cgi?id=60658
3308
3309         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3310         (TestWebKitAPI::TEST):
3311
3312 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
3313
3314         Reviewed by Ojan Vafai.
3315
3316         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
3317         https://bugs.webkit.org/show_bug.cgi?id=60521
3318
3319         First steps towards making the results JSON all hierarchical.
3320
3321         * TestResultServer/model/jsonresults.py:
3322         * TestResultServer/model/jsonresults_unittest.py:
3323
3324 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
3325
3326         [wx] Build fix, adding new LayoutTestController method stubs.
3327
3328         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3329         (LayoutTestController::localStorageDiskUsageForOrigin):
3330         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3331
3332 2011-05-11  Jessie Berlin  <jberlin@apple.com>
3333
3334         Reviewed by Darin Adler.
3335
3336         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
3337         about the usage for both the origin overall and the database in question.
3338         https://bugs.webkit.org/show_bug.cgi?id=60573
3339
3340         * WebKitTestRunner/TestController.cpp:
3341         (WTR::exceededDatabaseQuota):
3342
3343 2011-05-10  Stephen White  <senorblanco@chromium.org>
3344
3345         Reviewed by David Levin.
3346
3347         Adding myself as a reviewer.
3348         https://bugs.webkit.org/show_bug.cgi?id=60587
3349
3350         * Scripts/webkitpy/common/config/committers.py:
3351
3352 2011-05-11  Eric Seidel  <eric@webkit.org>
3353
3354         Reviewed by Csaba Osztrogonác.
3355
3356         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
3357         https://bugs.webkit.org/show_bug.cgi?id=60614
3358
3359         AppEngine has a result limit of 1000.  We hit that when trying
3360         to find out how many patches the style-queue (and other queues)
3361         have passed in the last 30 days.  So lets display 1000+ instead
3362         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
3363
3364         I also made the status pages show "never" instead of just "ago" when we
3365         haven't seen a pass or boot message in the last 1000 messages.
3366
3367         * QueueStatusServer/handlers/queuestatus.py:
3368         * QueueStatusServer/templates/queuestatus.html:
3369
3370 2011-05-11  Adam Barth  <abarth@webkit.org>
3371
3372         Reviewed by Eric Seidel.
3373
3374         sheriffbot shouldn't spam bugs when it can't figure out who to blame
3375         https://bugs.webkit.org/show_bug.cgi?id=60613
3376
3377         This patch limits the number of bugs sheriffbot will spam to three.
3378         Ideally, we'd come up with some smarter huerstics, but hopefully this
3379         will cut down on the bugmail spam for slow bots.
3380
3381         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3382
3383 2011-05-10  Eric Seidel  <eric@webkit.org>
3384
3385         Reviewed by Adam Barth.
3386
3387         EWS bots should be robust against test-webkitpy hangs
3388         https://bugs.webkit.org/show_bug.cgi?id=60579
3389
3390         Added a killAfterTimeout subroutine, which takes a child_pid
3391         and timeout, and will setup a watchdog process to kill that child
3392         after the timeout.  killAfterTimeout will waitpid on the child.
3393
3394         * EWSTools/start-queue.sh:
3395
3396 2011-05-10  MORITA Hajime  <morrita@google.com>
3397
3398         Unreviewed, moved myself to the reviewers list.
3399
3400         * Scripts/webkitpy/common/config/committers.py:
3401
3402 2011-05-10  Anton D'Auria  <adauria@apple.com>
3403
3404         Reviewed by David Levin.
3405
3406         StorageTracker should report actual local storage usage on disk
3407         https://bugs.webkit.org/show_bug.cgi?id=60558
3408
3409         * DumpRenderTree/LayoutTestController.cpp:
3410         (localStorageDiskUsageForOriginCallback):
3411         (LayoutTestController::staticFunctions):
3412         * DumpRenderTree/LayoutTestController.h:
3413         * DumpRenderTree/chromium/LayoutTestController.cpp:
3414         (LayoutTestController::LayoutTestController):
3415         (LayoutTestController::localStorageDiskUsageForOrigin):
3416         * DumpRenderTree/chromium/LayoutTestController.h:
3417         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3418         (LayoutTestController::localStorageDiskUsageForOrigin):
3419         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3420         (LayoutTestController::localStorageDiskUsageForOrigin):
3421         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3422         (LayoutTestController::localStorageDiskUsageForOrigin):
3423         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3424         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3425         (LayoutTestController::localStorageDiskUsageForOrigin):
3426
3427 2011-05-10  Anton D'Auria  <adauria@apple.com>
3428
3429         Reviewed by Alexey Proskuryakov.
3430
3431         Add ApplicationCache API to get disk usage per origin
3432         https://bugs.webkit.org/show_bug.cgi?id=57127
3433
3434         Added test that loads two frames with ~15Kb image, checks usage,
3435         deletes app cache, verifies usage is 0.
3436
3437         * DumpRenderTree/LayoutTestController.cpp:
3438         (applicationCacheDiskUsageForOriginCallback):
3439         (LayoutTestController::staticFunctions):
3440         * DumpRenderTree/LayoutTestController.h:
3441         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3442         (LayoutTestController::LayoutTestController):
3443         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3444         * DumpRenderTree/chromium/LayoutTestController.h:
3445         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3446         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3447         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3448         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3449         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3450         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3451         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3452         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3453         (LayoutTestController::applicationCacheDiskUsageForOrigin):
3454
3455 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3456
3457         Unreviewed, adding Rafael Antognolli as a committer.
3458
3459         * Scripts/webkitpy/common/config/committers.py:
3460
3461 2011-05-10  Chris Evans  <cevans@chromium.org>
3462
3463         Reviewed by Adam Barth.
3464
3465         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
3466         https://bugs.webkit.org/show_bug.cgi?id=58378
3467
3468         * DumpRenderTree/chromium/LayoutTestController.cpp:
3469         (LayoutTestController::LayoutTestController):
3470         (LayoutTestController::setAllowDisplayOfInsecureContent):
3471         (LayoutTestController::setAllowRunningOfInsecureContent):
3472         * DumpRenderTree/chromium/LayoutTestController.h:
3473         * DumpRenderTree/chromium/WebPreferences.cpp:
3474         (WebPreferences::reset):
3475         (WebPreferences::applyTo):
3476         * DumpRenderTree/chromium/WebPreferences.h:
3477         Add plumbing for new settings to Chromium DRT.
3478
3479 2011-05-10  Enrica Casucci  <enrica@apple.com>
3480
3481         Reviewed by Beth Dakin.
3482
3483         Added my name to the reviewers list and removed my name from
3484         to committer-only list.
3485
3486         * Scripts/webkitpy/common/config/committers.py:
3487
3488 2011-05-10  David Levin  <levin@chromium.org>
3489
3490         Reviewed by Shinichiro Hamaji.
3491
3492         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
3493         https://bugs.webkit.org/show_bug.cgi?id=60466
3494
3495         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
3496         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
3497           that property was removed.
3498         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
3499           filtering for errors.
3500         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
3501           verify that the line filtering is turned off.
3502         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
3503           and remove the unused file_path parameter.
3504         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
3505           line filtering is turned off (and fix test_no_error).
3506         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
3507           of errors based on the lines changed in the patch.
3508         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
3509           the filtering.
3510
3511 2011-05-10  Adam Roben  <aroben@apple.com>
3512
3513         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
3514
3515         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
3516         platform/win/plugins/window-geometry-initialized-before-set-window.html and
3517         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
3518         (WebKit2 Tests)
3519
3520         Reviewed by Anders Carlsson.
3521
3522         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3523         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
3524         WindowedPluginTest::testHarnessWindow function.
3525
3526         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
3527         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
3528         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
3529         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
3530         created for.
3531
3532         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
3533         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
3534         WindowedPluginTest, and initialized new members.
3535         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
3536         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
3537         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
3538         then clean up and tell the test harness we're done.
3539         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
3540         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
3541         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
3542         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
3543         window becomes visible.
3544         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
3545         if it was hidden at the start of the test.
3546         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
3547         This should cause our window to become visible and our window region to get set. When we get
3548         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
3549         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
3550         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
3551         "startTest".
3552         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
3553
3554         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
3555         (WindowedPluginTest::testHarnessWindow):
3556         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
3557         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
3558
3559 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
3560
3561         Reviewed by Kenneth Rohde Christiansen.
3562
3563         [Qt] Add new qt-4.8 platform for layout testing
3564         https://bugs.webkit.org/show_bug.cgi?id=60544
3565
3566         * Scripts/old-run-webkit-tests:
3567         * Scripts/webkitdirs.pm:
3568
3569 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3570
3571         Unreviewed, rolling out r86108.
3572         http://trac.webkit.org/changeset/86108
3573         https://bugs.webkit.org/show_bug.cgi?id=60533
3574
3575         Broke makefile based builds and Cairo (Requested by weinig on
3576         #webkit).
3577
3578         * Scripts/build-api-tests:
3579         * Scripts/run-api-tests:
3580         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3581         * TestWebKitAPI/Test.h:
3582         (TestWebKitAPI::Test::~Test):
3583         (TestWebKitAPI::Test::name):
3584         (TestWebKitAPI::Test::Register::Register):
3585         (TestWebKitAPI::Test::Register::create):
3586         (TestWebKitAPI::Test::Test):
3587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3588         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3589         (TestWebKitAPI::TEST):
3590         * TestWebKitAPI/TestsController.cpp:
3591         (TestWebKitAPI::TestsController::TestsController):
3592         (TestWebKitAPI::TestsController::dumpTestNames):
3593         (TestWebKitAPI::TestsController::runTestNamed):
3594         (TestWebKitAPI::TestsController::testFailed):
3595         (TestWebKitAPI::TestsController::registerCreateTestFunction):
3596         * TestWebKitAPI/TestsController.h:
3597         * TestWebKitAPI/mac/main.mm:
3598         (main):
3599
3600 2011-05-09  Hayato Ito  <hayato@chromium.org>
3601
3602         Reviewed by Ojan Vafai.
3603
3604         Skip reftests if pixel tests are disabled.
3605
3606         https://bugs.webkit.org/show_bug.cgi?id=59078
3607
3608         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3609         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3610         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3611         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3612
3613 2011-05-09  Chang Shu  <cshu@webkit.org>
3614
3615         Reviewed by Kenneth Rohde Christiansen.
3616
3617         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
3618         https://bugs.webkit.org/show_bug.cgi?id=60499
3619
3620         The implementation is similar to gtk.
3621
3622         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3623         (TextInputController::unmarkText):
3624         * DumpRenderTree/qt/TextInputControllerQt.h:
3625
3626 2011-05-09  James Robinson  <jamesr@chromium.org>
3627
3628         Reviewed by Eric Seidel.
3629
3630         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
3631         https://bugs.webkit.org/show_bug.cgi?id=60520
3632
3633         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3634
3635 2011-05-09  Dmitry Lomov  <dslomov@google.com>
3636
3637         Reviewed by Sam Weinig.
3638
3639         Switch TestWebKitAPI to GTest
3640         https://bugs.webkit.org/show_bug.cgi?id=59561
3641
3642         * Scripts/build-api-tests:
3643         * Scripts/run-api-tests:
3644         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3645         * TestWebKitAPI/Test.h:
3646         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3647         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
3648         (TestWebKitAPI::TEST):
3649         * TestWebKitAPI/TestsController.cpp:
3650         (TestWebKitAPI::TestsController::TestsController):
3651         (TestWebKitAPI::TestsController::dumpTestNames):
3652         (TestWebKitAPI::TestsController::runTestNamed):
3653         (TestWebKitAPI::TestsController::runAllTests):
3654         * TestWebKitAPI/TestsController.h:
3655         * TestWebKitAPI/mac/main.mm:
3656         (main):
3657
3658 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
3659
3660         Reviewed by Andreas Kling.
3661
3662         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
3663         https://bugs.webkit.org/show_bug.cgi?id=60487
3664
3665         When adding a new touch point, the start position of this point needs to be set.
3666