1 2015-06-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3 Remove ewstool scripts used by chromium port
4 https://bugs.webkit.org/show_bug.cgi?id=145789
6 Reviewed by Csaba Osztrogonác.
8 * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
9 * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
10 * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
11 * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
12 * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
14 2015-06-09 Michał Pakuła vel Rutka <m.pakula@samsung.com>
16 Unreviewed, updated my list of email addresses.
18 * Scripts/webkitpy/common/config/contributors.json:
20 2015-06-09 Csaba Osztrogonác <ossy@webkit.org>
22 [cmake] Fix the style issues in cmake project files
23 https://bugs.webkit.org/show_bug.cgi?id=145755
25 Reviewed by Darin Adler.
27 * TestWebKitAPI/CMakeLists.txt:
28 * TestWebKitAPI/PlatformEfl.cmake:
30 2015-06-08 Ryosuke Niwa <rniwa@webkit.org>
32 Fix a typo in r185345.
34 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
35 (OSXSafariDriver.closeBrowsers):
37 2015-06-08 Ryosuke Niwa <rniwa@webkit.org>
39 Yet another unreviewed build fix :(
41 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
43 (OSXSafariDriver.launchUrl):
44 (OSXSafariDriver.closeBrowsers):
46 2015-06-08 Ryosuke Niwa <rniwa@webkit.org>
48 Unreviewed build fix. Initialize result in the case things blow up below.
50 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
51 (BenchmarkRunner.execute):
53 2015-06-08 Ryosuke Niwa <rniwa@webkit.org>
55 Partially revert and fix after r185243.
57 * Scripts/benchmark_runner/benchmark_runner.py:
58 * Scripts/run-benchmark:
60 2015-06-08 Daniel Bates <dabates@apple.com>
62 Many LayoutTests/http tests time out in DumpRenderTree
63 https://bugs.webkit.org/show_bug.cgi?id=145770
64 <rdar://problem/19593910>
66 Reviewed by Alexey Proskuryakov.
68 * DumpRenderTree/ios/Info.plist: Add ATS key.
69 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
70 (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
71 and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
72 that make use of testRunner.pathToLocalResource().
74 2015-06-08 Csaba Osztrogonác <ossy@webkit.org>
76 [GTK] Fix parentheses warning in TestWebKitWebView.cpp
77 https://bugs.webkit.org/show_bug.cgi?id=145759
79 Reviewed by Carlos Garcia Campos.
81 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
84 2015-06-07 Carlos Garcia Campos <cgarcia@igalia.com>
86 [GTK] Add editor mode to MiniBrowser
87 https://bugs.webkit.org/show_bug.cgi?id=145595
89 Reviewed by Sergio Villar Senin.
91 It loads an empty editable web view with an edit toolbar. It makes
92 easier to test the editor, editing commands and input methods.
94 * MiniBrowser/gtk/BrowserWindow.c:
95 (editingCommandCallback):
96 (browserWindowSetupEditorToolbar):
97 (browserWindowConstructed):
98 * MiniBrowser/gtk/main.c:
99 (createBrowserWindow):
101 2015-06-05 Zalan Bujtas <zalan@apple.com>
103 From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
105 Reviewed by Dan Bernstein.
107 * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
108 (TestWebKitAPI::TEST):
110 2015-06-05 Gyuyoung Kim <gyuyoung.kim@webkit.org>
112 [EFL] API test has been broken since r184357
113 https://bugs.webkit.org/show_bug.cgi?id=145635
115 Reviewed by Darin Adler.
117 r184357 suppress cmake build warning using TARGET_FILE property. However
118 many EFL API test cases have been broken after applying it.
120 * TestWebKitAPI/CMakeLists.txt:
122 2015-06-05 Anders Carlsson <andersca@apple.com>
124 Make the network cache directory part of WKContextConfigurationRef
125 https://bugs.webkit.org/show_bug.cgi?id=145711
127 Reviewed by Antti Koivisto.
129 * WebKitTestRunner/TestController.cpp:
130 (WTR::TestController::initialize):
132 2015-06-05 Anders Carlsson <andersca@apple.com>
134 Make the application cache directory part of WKContextConfigurationRef
135 https://bugs.webkit.org/show_bug.cgi?id=145704
137 Reviewed by Geoffrey Garen.
139 * WebKitTestRunner/TestController.cpp:
140 (WTR::TestController::initialize):
142 2015-06-04 Carlos Alberto Lopez Perez <clopez@igalia.com>
144 check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
145 https://bugs.webkit.org/show_bug.cgi?id=145680
147 Reviewed by Brent Fulgham.
149 * Scripts/webkitpy/style/checkers/cpp.py:
151 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
152 (WebKitStyleTest.test_null_false_zero):
154 2015-06-05 Stephanie Lewis <slewis@apple.com>
156 Make the web server more robust to timing issues..
158 Reviewed by Ryosuke Niwa.
160 Cleaned up exception handling.
161 Test server is actually serving pages before returning.
162 Clean up some style issues.
164 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
165 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
166 (SimpleHTTPServerDriver.__init__):
167 (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
168 (SimpleHTTPServerDriver.baseUrl):
169 (SimpleHTTPServerDriver.fetchResult):
170 (SimpleHTTPServerDriver.killServer):
171 (SimpleHTTPServerDriver.getReturnCode):
173 2015-06-05 Stephanie Lewis <slewis@apple.com>
176 Add errors to run-benchmark exception handling.
178 Reviewed by Ryosuke Niwa.
180 * Scripts/run-benchmark:
182 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
183 (GenericBenchmarkBuilder.prepare):
184 (GenericBenchmarkBuilder._runCreateScript):
185 (GenericBenchmarkBuilder._applyPatch):
186 (GenericBenchmarkBuilder.clean):
187 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
188 (BenchmarkRunner.__init__):
189 (BenchmarkRunner.execute):
191 (BenchmarkRunner.cleanup):
192 * Scripts/webkitpy/benchmark_runner/generic_factory.py:
193 (GenericFactory.iterateGetItem):
194 (GenericFactory.create):
195 * Scripts/webkitpy/benchmark_runner/utils.py:
200 2015-06-05 Stephanie Lewis <slewis@apple.com>
202 Streamline run-benchmark browser
204 Reviewed by Ryosuke Niwa.
206 Add Caffeinate so computer won't sleep while running.
207 Remove calls to collect output since we were just dumping to stdout anyway.
209 Default to system safari.
211 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
212 (OSXBrowserDriver.launchProcess):
213 (OSXBrowserDriver.terminateProcesses):
215 (OSXBrowserDriver.launchCaffeinateForProcess):
216 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
217 (OSXSafariDriver.launchUrl):
218 (OSXSafariDriver.closeBrowsers):
220 2015-06-04 Benjamin Poulain <bpoulain@apple.com>
222 Combine tiny DFAs into slightly larger ones
223 https://bugs.webkit.org/show_bug.cgi?id=145572
225 Reviewed by Alex Christensen.
227 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
228 * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
229 (TestWebKitAPI::DFACombinerTest::SetUp):
230 (TestWebKitAPI::combine):
231 (TestWebKitAPI::TEST_F):
232 * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
233 (TestWebKitAPI::countLiveNodes):
234 (TestWebKitAPI::createNFAs):
235 (TestWebKitAPI::buildDFAFromPatterns):
236 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
237 (TestWebKitAPI::countLiveNodes): Deleted.
238 (TestWebKitAPI::createNFAs): Deleted.
239 (TestWebKitAPI::buildDFAFromPatterns): Deleted.
241 2015-06-04 Alexey Proskuryakov <ap@apple.com>
243 WebKitTestRunner leaks strings in generateWhitelist()
244 https://bugs.webkit.org/show_bug.cgi?id=145665
246 Reviewed by Myles C. Maxfield.
248 * WebKitTestRunner/mac/TestControllerMac.mm:
249 (WTR::generateWhitelist):
251 2015-06-03 Yusuke Suzuki <utatane.tea@gmail.com>
253 Fix options in build-jsc for CMake builds
254 https://bugs.webkit.org/show_bug.cgi?id=145636
256 Reviewed by Gyuyoung Kim.
258 CMake only accepts -DXXX=YYY style options.
259 And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
263 2015-06-03 Matthew Daiter <mdaiter@apple.com>
265 Added a patch so that the colors displayed on the page could be toggled
266 in case people need accessibility colors displayed in their browser.
267 https://bugs.webkit.org/show_bug.cgi?id=145570
268 <rdar://problem/20994468>
270 Added in CSS colors and toggle buttons for checkmarks in the page, so that
271 the page could be rendered in a specific way for accessibility needs if needed.
273 Reviewed by Alexey Proskuryakov.
275 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
276 (updateHiddenPlatforms):
277 (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
278 (toggleAccessibilityColors): Toggle colors on and off
279 (documentReady): Needed to make changes to the initialization
280 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
282 (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
283 (div.cellButton.hide, div.accessibilityButton.hide):
284 (div.cellButton.unhide, div.accessibilityButton.unhide):
285 (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
286 (.popover-tracking:hover):
287 (.accessibilityButton):
288 (div.cellButton): Deleted.
289 (div.cellButton.hide): Deleted.
290 (div.cellButton.unhide): Deleted.
291 (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
292 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
293 (.status-line.neutral .bubble):
294 (.status-line.unauthorized .bubble):
295 (.status-line.danger .bubble.pictogram):
296 (.status-line.bad .bubble.pictogram):
297 (.status-line.no-bubble .message):
298 (.status-line.bad .bubble):
299 (.status-line.good .bubble):
300 (.status-line.good .message):
301 (.status-line.bad .message):
302 (body.accessibility-colors .status-line.good .bubble):
303 (body.accessibility-colors .status-line.bad .bubble):
304 (body.accessibility-colors .status-line.good .message):
305 (body.accessibility-colors .status-line.bad .message):
306 (.status-line.danger .message):
307 (.status-line.unauthorized .message):
309 2015-06-03 Ryosuke Niwa <rniwa@webkit.org>
311 Unreviewed build fix for Dromaeo.
313 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
314 (BenchmarkResults._aggregate_results_for_test):
316 2015-06-03 Anders Carlsson <andersca@apple.com>
320 * DumpRenderTree/mac/TestRunnerMac.mm:
322 2015-06-03 Daniel Bates <dabates@apple.com>
324 WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
325 https://bugs.webkit.org/show_bug.cgi?id=145616
327 Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
328 of the test. Further investigation is needed.
330 * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
331 * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
333 2015-06-03 Brady Eidson <beidson@apple.com>
335 REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
336 https://bugs.webkit.org/show_bug.cgi?id=145580
338 Reviewed by Mark Lam.
340 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
341 (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
343 2015-06-03 Alexey Proskuryakov <ap@apple.com>
345 Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
347 * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
348 (TestWebKitAPI::TEST): Update the syntax.
350 2015-06-02 Mark Lam <mark.lam@apple.com>
352 build-jsc's --cloop option is broken.
353 https://bugs.webkit.org/show_bug.cgi?id=145516
355 Reviewed by Darin Adler.
358 - Make sure to disable the JIT when --cloop is specified.
359 Did analogous fix for --ftljit.
361 2015-06-02 Daniel Bates <dabates@apple.com>
363 Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
365 Rubber-stamped by Alexey Proskuryakov.
367 * MiniBrowser/mac/Info.plist:
368 * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
370 2015-06-01 Commit Queue <commit-queue@webkit.org>
372 Unreviewed, rolling out r185066.
373 https://bugs.webkit.org/show_bug.cgi?id=145543
375 it breaks the FTL JIT builds with a local checkout of llvm
376 (Requested by pizlo on #webkit).
380 "build-jsc's --cloop option is broken."
381 https://bugs.webkit.org/show_bug.cgi?id=145516
382 http://trac.webkit.org/changeset/185066
384 2015-06-01 Daniel Bates <dabates@apple.com>
386 Notify client that we began editing when text field is focused
387 https://bugs.webkit.org/show_bug.cgi?id=145439
388 <rdar://problem/21142108>
390 Reviewed by Anders Carlsson.
392 Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
393 a text field is focused and defocused.
395 * TestWebKitAPI/CMakeLists.txt:
396 * TestWebKitAPI/PlatformEfl.cmake:
397 * TestWebKitAPI/PlatformGTK.cmake:
398 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
399 * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
400 (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
401 (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
402 (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
403 (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
404 (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
405 (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
406 (TestWebKitAPI::TEST_F):
407 * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
408 (TestWebKitAPI::textFieldDidBeginEditing):
409 (TestWebKitAPI::textFieldDidEndEditing):
410 (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
411 (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
412 * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
414 2015-06-01 Alex Christensen <achristensen@webkit.org>
416 [Content Extensions] resource-type and load-type should be independent.
417 https://bugs.webkit.org/show_bug.cgi?id=145528
418 rdar://problem/21190765
420 Reviewed by Benjamin Poulain.
422 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
423 (TestWebKitAPI::TEST_F):
425 2015-06-01 Daniel Bates <dabates@apple.com>
427 Add ATS keys to WebKitTestRunnerApp
428 https://bugs.webkit.org/show_bug.cgi?id=145519
430 Reviewed by Alexey Proskuryakov.
432 Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
434 * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
436 2015-06-01 Brady Eidson <beidson@apple.com>
438 Add WKTR support for "should open external URLs".
439 https://bugs.webkit.org/show_bug.cgi?id=145505
441 Reviewed by Darin Adler.
443 - Add a new option to "queueLoad" to allow javascript to queue a load that has the
444 "should open external URLs" bit set.
446 - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
447 the policy delegate, including whether or not the bit was set.
449 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
450 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
451 (WTR::TestRunner::queueLoad):
452 * WebKitTestRunner/InjectedBundle/TestRunner.h:
453 (WTR::TestRunner::dumpPolicyDelegateCallbacks):
454 (WTR::TestRunner::shouldDumpPolicyCallbacks):
456 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
457 (WTR::InjectedBundle::queueLoad):
458 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
460 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
461 (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
463 * WebKitTestRunner/TestInvocation.cpp:
464 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
466 * WebKitTestRunner/WorkQueueManager.cpp:
467 (WTR::WorkQueueManager::queueLoad):
468 * WebKitTestRunner/WorkQueueManager.h:
470 2015-06-01 Mark Lam <mark.lam@apple.com>
472 build-jsc's --cloop option is broken.
473 https://bugs.webkit.org/show_bug.cgi?id=145516
475 Reviewed by Darin Adler.
478 - Make sure to disable the JIT when --cloop is specified.
479 Did analogous fix for --ftljit.
481 2015-06-01 Csaba Osztrogonác <ossy@webkit.org>
483 [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
484 https://bugs.webkit.org/show_bug.cgi?id=144959
486 Reviewed by Darin Adler.
488 * Scripts/webkitpy/style/checkers/cmake.py:
489 (CMakeChecker.check): Use enumerate instead of xrange.
490 (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
491 * Scripts/webkitpy/style/checkers/cmake_unittest.py:
492 (CMakeCheckerTest.test_check): Update the expected results.
494 2015-06-01 Csaba Osztrogonác <ossy@webkit.org>
496 Fix the webkitpy scm unittests after r174051
497 https://bugs.webkit.org/show_bug.cgi?id=145511
499 Reviewed by Darin Adler.
501 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
502 (GitTestWithMock.make_scm):
504 2015-06-01 Csaba Osztrogonác <ossy@webkit.org>
506 EWS provides misleading information for not applyable patches
507 https://bugs.webkit.org/show_bug.cgi?id=145307
509 Reviewed by Alexey Proskuryakov.
511 * Scripts/svn-apply: Die if there is no applyable diff in the patch.
513 2015-06-01 Alexey Proskuryakov <ap@apple.com>
515 Further tweak results of WebKit1.StringTruncator after r184965.
517 * TestWebKitAPI/Tests/mac/StringTruncator.mm:
519 2015-06-01 Csaba Osztrogonác <ossy@webkit.org>
521 [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
522 https://bugs.webkit.org/show_bug.cgi?id=145264
524 Reviewed by Carlos Garcia Campos.
526 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
528 2015-05-30 Ryosuke Niwa <rniwa@webkit.org>
530 Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
532 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
533 (BenchmarkResults._lint_subtest_results):
534 * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
535 (test_aggregate_nested_results):
537 * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
539 2015-05-29 Ryosuke Niwa <rniwa@webkit.org>
541 run-benchmark should print out the results
542 https://bugs.webkit.org/show_bug.cgi?id=145398
544 Reviewed by Antti Koivisto.
546 Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
547 of the output to catch early errors.
549 * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
550 (BenchmarkResults): Added.
551 (BenchmarkResults.__init__): Added.
552 (BenchmarkResults.format): Added.
553 (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
554 (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
555 Uses the sample standard deviation to compute the significant figures for the value.
556 (BenchmarkResults._unit_from_metric): Added.
557 (BenchmarkResults._aggregate_results): Added.
558 (BenchmarkResults._aggregate_results_for_test): Added.
559 (BenchmarkResults._flatten_list): Added.
560 (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
561 by the iteration number so that i-th array contains values for all subtests at i-th iteration.
562 (BenchmarkResults._aggregate_values): Added.
563 (BenchmarkResults._lint_results): Added.
564 (BenchmarkResults._lint_subtest_results): Added.
565 (BenchmarkResults._lint_aggregator_list): Added.
566 (BenchmarkResults._lint_configuration): Added.
567 (BenchmarkResults._lint_values): Added.
568 (BenchmarkResults._is_numeric): Added.
569 * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
570 (BenchmarkResultsTest):
571 (BenchmarkResultsTest.test_init):
572 (BenchmarkResultsTest.test_format):
573 (test_format_values_with_large_error):
574 (test_format_values_with_small_error):
575 (test_format_values_with_time):
576 (test_format_values_with_no_error):
577 (test_format_values_with_small_difference):
578 (test_aggregate_results):
579 (test_aggregate_results_with_gropus):
580 (test_aggregate_nested_results):
582 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
583 (BenchmarkRunner.execute): Added a call to show_results
584 (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
585 (BenchmarkRunner.show_results): Added.
587 2015-05-15 Ryosuke Niwa <rniwa@webkit.org>
589 run_benchmark should have an option to specify the number of runs
590 https://bugs.webkit.org/show_bug.cgi?id=145091
592 Reviewed by Antti Koivisto.
594 Added --count option.
596 * Scripts/run-benchmark:
598 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
599 (BenchmarkRunner.__init__):
601 2015-05-28 Alexey Proskuryakov <ap@apple.com>
603 Update results of WebKit1.StringTruncator after r184965. I missed one letter.
605 * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
607 2015-05-28 Alexey Proskuryakov <ap@apple.com>
609 Update results of WebKit1.StringTruncator after r184965.
611 * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
613 2015-05-28 Gyuyoung Kim <gyuyoung.kim@webkit.org>
615 Unreviewed, updated my list of email addresses.
617 * Scripts/webkitpy/common/config/contributors.json:
619 2015-05-27 Dean Jackson <dino@apple.com>
621 img.currentSrc problem in strict mode with old picturefill
622 https://bugs.webkit.org/show_bug.cgi?id=144095
623 <rdar://problem/21087013>
625 Reviewed by Simon Fraser.
627 Add a PICTURE_SIZES flag.
629 * Scripts/webkitperl/FeatureList.pm:
631 2015-05-26 Dana Burkart <dburkart@apple.com>
633 Fixes compatibility issues with recent dashboard cleanup.
634 https://bugs.webkit.org/show_bug.cgi?id=144814
636 Reviewed by Alexey Proskuryakov.
638 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
639 (BuildbotStaticAnalyzerQueueView):
640 (BuildbotStaticAnalyzerQueueView.prototype.update):
641 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
644 2015-05-26 Alexey Proskuryakov <ap@apple.com>
646 Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
647 https://bugs.webkit.org/show_bug.cgi?id=143091
648 rdar://problem/19330328
650 Reviewed by Darin Adler and Timothy Hatcher.
652 We have many of these, which are hard to fit on the dashboard. Added a view that
653 collapses to a single green bubble when everything is good, and expands when there
654 are failures (or manually).
656 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
658 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
659 (Buildbot.prototype.set isAuthenticated):
660 (Buildbot.prototype._normalizeQueueInfo):
661 (Buildbot.prototype._normalizeQueuesInfo):
662 (Buildbot.prototype.updateQueues):
663 Moved queue info normalization here from BuildbitQueue. The latter is a model class
664 that shouldn't have to know about presentation, and this lets us leep the knowledge
665 about combined queues out if it. Later, we can refactor existing code, and move out
666 all knowledge about headings and such.
668 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
669 Added the new view. It's not quite universal, and doesn't have as helpful popovers
670 as other views, but we can extend it when/if we use it for more than JSC.
672 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
673 (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
675 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
676 (documentReady): Added support for combined queues. These are currently always ending up
677 in Other column, but it's easy to customize in the future if we need to.
679 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
680 (WebKitBuildbot): Added JSC queus.
682 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
683 (.combined-queue-popover):
684 (.combined-queue-popover .revision):
685 Added styles for the combined view.
687 2015-05-26 Dan Bernstein <mitz@apple.com>
689 Changed a file to use Unix line endings.
691 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
693 2015-05-26 Dan Bernstein <mitz@apple.com>
695 <rdar://problem/21104551> Update build settings
697 Reviewed by Anders Carlsson.
699 * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
700 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
701 * MiniBrowser/Configurations/DebugRelease.xcconfig:
702 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
703 * WebEditingTester/Configurations/DebugRelease.xcconfig:
704 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
705 * asan/asan.xcconfig:
707 2015-05-26 Anders Carlsson <andersca@apple.com>
711 * WebKitTestRunner/mac/EventSenderProxy.mm:
712 (WTR::EventSenderProxy::mouseForceDown):
713 (WTR::EventSenderProxy::mouseForceUp):
714 (WTR::EventSenderProxy::mouseForceChanged):
716 2015-05-26 Alexey Proskuryakov <ap@apple.com>
718 build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
719 https://bugs.webkit.org/show_bug.cgi?id=145342
721 Reviewed by Darin Adler.
723 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
724 (BuildbotIteration.prototype._parseData):
726 2015-05-26 Milan Crha <mcrha@redhat.com>
728 [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
729 https://bugs.webkit.org/show_bug.cgi?id=138134
731 Reviewed by Žan Doberšek.
733 * gtk/generate-inspector-gresource-manifest.py:
734 (get_filenames): Command line with expanded resources exceeds 32KB, which
735 is a limit on Windows. It's better to expand wildcards inside the python script.
737 2015-05-25 Carlos Garcia Campos <cgarcia@igalia.com>
739 [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
740 https://bugs.webkit.org/show_bug.cgi?id=140882
742 Reviewed by Gustavo Noronha Silva.
744 Make sure unit tests write IndexedDB databases to the temporary
745 directory, and add a test case to check that the directory is
746 correctly created at the expected path.
748 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
749 (testWebContextConfiguration):
751 * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
754 2015-05-25 Carlos Garcia Campos <cgarcia@igalia.com>
756 [GTK] Enable IndexedDB
757 https://bugs.webkit.org/show_bug.cgi?id=98932
759 Reviewed by Žan Doberšek.
761 * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
763 2015-05-24 Sam Weinig <sam@webkit.org>
765 Crash when using a removed ScriptMessageHandler
766 <rdar://problem/20888499>
767 https://bugs.webkit.org/show_bug.cgi?id=145359
769 Reviewed by Dan Bernstein.
771 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
772 Add tests for removing script message handlers.
774 2015-05-23 Dan Bernstein <mitz@apple.com>
776 Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
777 https://bugs.webkit.org/show_bug.cgi?id=145345
779 Reviewed by Sam Weinig.
781 * DumpRenderTree/mac/Configurations/Base.xcconfig:
782 * LayoutTestRelay/Configurations/Base.xcconfig:
783 * TestWebKitAPI/Configurations/Base.xcconfig:
784 * WebKitTestRunner/Configurations/Base.xcconfig:
786 2015-05-23 Yusuke Suzuki <utatane.tea@gmail.com>
788 Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
789 https://bugs.webkit.org/show_bug.cgi?id=144848
791 Reviewed by Darin Adler.
793 Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
795 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
797 2015-05-22 Alexey Proskuryakov <ap@apple.com>
799 Fix one more merge error in static analyzer support.
801 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
802 (BuildbotStaticAnalyzerQueueView):
804 2015-05-22 Dana Burkart <dburkart@apple.com>
806 Fix internal dashboard breakage from recent commit.
807 https://bugs.webkit.org/show_bug.cgi?id=144814
809 Unreviewed build fix.
811 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
812 (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
813 (BuildbotStaticAnalyzerQueueView.prototype.update):
815 2015-05-22 Alexey Proskuryakov <ap@apple.com>
817 REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
818 https://bugs.webkit.org/show_bug.cgi?id=130463
819 rdar://problem/20461342
821 Reviewed by Tim Horton.
823 This was more of a timing related flakiness than an actual OS version specific bug,
824 we weren't getting window visibility notifications.
826 I will look into adding this function call to DumpRenderTree separately, layout tests
827 might actually rely on the broken behavior.
829 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
830 (TestWebKitAPI::TEST_F):
831 * TestWebKitAPI/mac/mainMac.mm:
834 2015-05-22 Dana Burkart <dburkart@apple.com>
836 Add missing file from r184804 (mis-applied diff).
837 https://bugs.webkit.org/show_bug.cgi?id=144814
839 Reviewed by Alexey Proskuryakov.
841 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
842 (BuildbotStaticAnalyzerQueueView):
843 (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
844 (BuildbotStaticAnalyzerQueueView.prototype.update):
846 2015-05-22 Dana Burkart <dburkart@apple.com>
848 Add support to the botwatchers dashboard for a static analyzer bot.
849 https://bugs.webkit.org/show_bug.cgi?id=144814
851 Reviewed by Alexey Proskuryakov.
853 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
854 scan-build should be considered a productive step.
856 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
858 Adds support for the staticAnalyzer property
860 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
861 (BuildbotTestResults.prototype._parseResults):
862 Get bug count from the scan-build step output
864 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
866 Rename the performance column 'Other', and merge the current 'Other' column with it.
868 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
870 Now that performance bots are part of the 'Other' column, give them better headings.
872 2015-05-22 Tim Horton <timothy_horton@apple.com>
874 Turn on autosaving of toolbar configuration in MiniBrowser
876 Rubber-stamped by Dan Bernstein.
878 * MiniBrowser/mac/BrowserWindow.xib:
880 2015-05-22 Alexey Proskuryakov <ap@apple.com>
882 build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
883 https://bugs.webkit.org/show_bug.cgi?id=145297
885 Reviewed by Tim Horton.
887 This is a refactoring to simplify code, and to make it more logical.
889 It is up to the view to decide how to present the queues, and whether to split
890 them into debug and release, or in some different way.
892 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
893 (BuildbotBuilderQueueView.filterQueues):
894 (BuildbotBuilderQueueView):
895 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
896 (BuildbotLeaksQueueView):
897 (BuildbotLeaksQueueView.prototype.update):
898 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
899 (BuildbotPerformanceQueueView):
900 (BuildbotPerformanceQueueView.prototype.update):
901 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
903 (BuildbotQueueView.prototype._updateQueues):
904 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
905 (BuildbotTesterQueueView):
906 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
909 2015-05-22 Tim Horton <timothy_horton@apple.com>
911 Remove action menu support
912 https://bugs.webkit.org/show_bug.cgi?id=145305
913 <rdar://problem/21070771>
915 Reviewed by Anders Carlsson.
917 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
918 * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
919 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
920 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
921 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
922 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
925 2015-05-22 Dan Bernstein <mitz@apple.com>
927 Removed the Use Shrink To Fit button from the toolbar’s default set.
929 Rubber-stamped by Tim Horton.
931 * MiniBrowser/mac/BrowserWindow.xib:
933 2015-05-21 Joanmarie Diggs <jdiggs@igalia.com>
935 AX: [GTK] Implement computedRoleString in AccessibilityUIElement
936 https://bugs.webkit.org/show_bug.cgi?id=128420
938 Reviewed by Chris Fleizach.
940 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
941 (WTR::AccessibilityUIElement::computedRoleString): Implemented.
943 2015-05-21 Csaba Osztrogonác <ossy@webkit.org>
945 [EFL] Bump libsoup version to 2.50.0
946 https://bugs.webkit.org/show_bug.cgi?id=145127
948 Reviewed by Gyuyoung Kim.
950 * efl/jhbuild.modules:
951 * efl/patches/soup-clang-warning-fix1.patch: Removed.
952 * efl/patches/soup-clang-warning-fix2.patch: Removed.
954 2015-05-20 Zan Dobersek <zdobersek@igalia.com>
956 [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
957 https://bugs.webkit.org/show_bug.cgi?id=145117
959 Reviewed by Csaba Osztrogonác.
961 Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
962 Tools/TestWebKitAPI/Tests/WTF/glib/.
964 * TestWebKitAPI/PlatformGTK.cmake:
965 * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
966 (TestWebKitAPI::TEST):
968 2015-05-20 KwangHyuk Kim <hyuki.kim@samsung.com>
970 [EFL] fix efreet error
971 https://bugs.webkit.org/show_bug.cgi?id=143670
973 Reviewed by Gyuyoung Kim.
975 Fix efreet error by using external variable efreet_cache_update.
976 As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
977 efreet error for efreet_cache does not occur.
979 * MiniBrowser/efl/main.c:
982 2015-05-20 Michael Saboff <msaboff@apple.com>
984 Add option to run_jsc_stress_tests to disable JIT testing
985 https://bugs.webkit.org/show_bug.cgi?id=145233
987 Reviewed by Mark Lam.
989 Added --no-jit option.
991 * Scripts/run-jsc-stress-tests:
993 2015-05-20 Alex Christensen <achristensen@webkit.org>
995 Use correct String for StringView in WTF API tests
996 https://bugs.webkit.org/show_bug.cgi?id=145226
997 rdar://problem/20361786
999 Reviewed by Benjamin Poulain.
1001 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1002 (TestWebKitAPI::TEST):
1003 Use patternHolder for pattern.
1005 2015-05-20 Alex Christensen <achristensen@webkit.org>
1007 [Content Extensions] Relax restrictions on triggers that match everything.
1008 https://bugs.webkit.org/show_bug.cgi?id=145069
1010 Reviewed by Benjamin Poulain.
1012 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1013 (TestWebKitAPI::TEST_F):
1014 Update and add tests for new possibilities with .*
1016 2015-05-20 Rohit Kumar <kumar.rohit@samsung.com>
1018 [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
1019 https://bugs.webkit.org/show_bug.cgi?id=144992
1021 Reviewed by Gyuyoung Kim.
1023 * MiniBrowser/efl/main.c:
1024 (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
1026 (on_fullscreen_enter):
1027 (on_fullscreen_exit):
1030 2015-05-19 Yusuke Suzuki <utatane.tea@gmail.com>
1032 Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
1033 https://bugs.webkit.org/show_bug.cgi?id=145109
1035 Reviewed by Darin Adler.
1037 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1038 (TestWebKitAPI::TEST):
1040 2015-05-19 Anders Carlsson <andersca@apple.com>
1042 Add alternate menu items for performing operations on the default data store
1043 https://bugs.webkit.org/show_bug.cgi?id=145184
1045 Reviewed by Sam Weinig.
1047 This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
1048 associated with a data store.
1050 * MiniBrowser/mac/AppDelegate.m:
1051 (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
1052 (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
1053 (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
1054 * MiniBrowser/mac/MainMenu.xib:
1056 2015-05-19 Csaba Osztrogonác <ossy@webkit.org>
1058 Fix tautological-compare warning in AtomicString.cpp
1059 https://bugs.webkit.org/show_bug.cgi?id=145120
1061 Reviewed by Alexey Proskuryakov.
1063 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1064 (TestWebKitAPI::TEST): Removed always true assert.
1066 2015-05-18 Csaba Osztrogonác <ossy@webkit.org>
1068 [EFL] Fix unsequenced warning in MiniBrowser's main.c
1069 https://bugs.webkit.org/show_bug.cgi?id=145123
1071 Reviewed by Gyuyoung Kim.
1073 * MiniBrowser/efl/main.c:
1076 2015-05-18 Daniel Bates <dabates@apple.com>
1078 prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
1079 when staged non-empty file for commit
1080 https://bugs.webkit.org/show_bug.cgi?id=145082
1082 Reviewed by Darin Adler.
1084 Fixes two issues when running prepare-ChangeLog:
1085 1. The function above a deleted function is reported as changed.
1086 2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
1087 a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
1088 included in this patch).
1090 Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
1091 prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
1092 generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
1093 has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
1094 chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
1095 VCSUtil::parseChunkRange() has existing test coverage.
1097 * Scripts/prepare-ChangeLog:
1098 (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
1099 when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
1100 all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
1101 examine files that only have deletions. Currently this works as a side effect of the behavior of
1102 extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
1103 a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
1104 (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
1105 (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
1106 the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
1107 We return (-1, -1) when the change represents a deletion.
1108 (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
1109 the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
1110 We return (-1, -1) when the change represents an addition.
1111 * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
1114 2015-05-18 Anders Carlsson <andersca@apple.com>
1116 Add ATS keys to MiniBrowser
1117 https://bugs.webkit.org/show_bug.cgi?id=145141
1119 Reviewed by Sam Weinig.
1121 * MiniBrowser/mac/Info.plist:
1123 2015-05-17 David Kilzer <ddkilzer@apple.com>
1125 bisect-builds: Add 'retry' option when prompting whether the bug reproduced
1126 <http://webkit.org/b/145100>
1128 Reviewed by Darin Adler.
1130 * Scripts/bisect-builds:
1131 - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
1132 - Switch to using PROMPT_RESPONSE_* constants when testing the
1133 value of $didReproduceBug.
1134 - Add do { } while loops to implement 'retry' mode.
1136 - Switch to returning PROMPT_RESPONSE_* constants.
1137 - Add support for 'retry' response.
1139 2015-05-16 Tanay C <tanay.c@samsung.com>
1141 [EFL][WK2] Minibrowser : Add search icon to search bar
1142 https://bugs.webkit.org/show_bug.cgi?id=139773
1144 Reviewed by Gyuyoung Kim.
1146 * MiniBrowser/efl/main.c:
1147 (search_icon_show): Added.
1148 (search_box_show): Modified.
1150 2015-05-15 Ryosuke Niwa <rniwa@webkit.org>
1152 run_benchmark should have an option to specify the number of runs
1153 https://bugs.webkit.org/show_bug.cgi?id=145091
1155 Reviewed by Stephanie Lewis.
1157 Added --count option.
1159 * Scripts/run-benchmark:
1161 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1162 (BenchmarkRunner.__init__):
1164 2015-05-15 Timothy Horton <timothy_horton@apple.com>
1166 Temporarily disable failing API test.
1168 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1169 (TestWebKitAPI::TEST):
1171 2015-05-15 Ravi Phaneendra Kasibhatla <r.kasibhatla@samsung.com>
1173 User interruption while running of run-webkit-tests should also generate results.html
1174 https://bugs.webkit.org/show_bug.cgi?id=122154
1176 Reviewed by Csaba Osztrogonác.
1178 Generation of results.html on execution of run-webkit-tests happens only
1179 on completion of entire layout tests run. It should be created even when
1180 the execution has been interrupted - either by user (by pressing Ctrl+C)
1181 or because of other interruptions (like exit-after-n-failures option).
1183 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1184 (LayoutTestRunner.run_tests):
1185 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1187 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1188 (TestRunResults.__init__):
1189 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1191 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1192 (RunTest.test_keyboard_interrupt):
1193 (MainTest.test_exception_handling):
1195 2015-05-15 Csaba Osztrogonác <ossy@webkit.org>
1197 [buildbot] Fix the URL of the performance bots
1198 https://bugs.webkit.org/show_bug.cgi?id=145043
1200 Reviewed by Ryosuke Niwa.
1202 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1204 2015-05-14 Timothy Horton <timothy_horton@apple.com>
1206 Add a layout mode that scales down the view to try to fit the document
1207 https://bugs.webkit.org/show_bug.cgi?id=145022
1208 <rdar://problem/19790341>
1210 Reviewed by Dean Jackson.
1212 * MiniBrowser/mac/BrowserWindow.xib:
1213 * MiniBrowser/mac/BrowserWindowController.h:
1214 * MiniBrowser/mac/WK2BrowserWindowController.m:
1215 (-[WK2BrowserWindowController toggleShrinkToFit:]):
1216 (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
1217 Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
1219 2015-05-14 Michael Catanzaro <mcatanzaro@igalia.com>
1221 [CMake] Don't read the LOCATION property of targets
1222 https://bugs.webkit.org/show_bug.cgi?id=145018
1224 Reviewed by Martin Robinson.
1226 Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
1227 bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
1228 be the same at configure-time as it is at generate-time.
1230 * TestWebKitAPI/CMakeLists.txt:
1232 2015-05-14 Myles C. Maxfield <mmaxfield@apple.com>
1234 Add String literal overloads to equalIgnoringASCIICase()
1235 https://bugs.webkit.org/show_bug.cgi?id=145008
1237 Reviewed by Benjamin Poulain.
1239 Test changes to WTF.
1241 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1242 (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
1243 (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
1244 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1245 (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
1246 (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
1248 2015-05-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
1250 SharedBuffer::createWithContentsOfFile should use map file routines
1251 https://bugs.webkit.org/show_bug.cgi?id=144192
1253 Reviewed by Darin Adler.
1255 Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
1257 * TestWebKitAPI/PlatformGTK.cmake:
1258 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1259 * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
1260 (TestWebKitAPI::FileSystemTest::tempFilePath):
1261 (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
1262 (TestWebKitAPI::TEST_F):
1263 * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
1264 (TestWebKitAPI::SharedBufferTest::tempFilePath):
1265 (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
1266 (TestWebKitAPI::TEST_F):
1268 2015-05-13 Alex Christensen <achristensen@webkit.org>
1270 [Content Extensions] Test interactions between multiple extensions and multiple domains.
1271 https://bugs.webkit.org/show_bug.cgi?id=144967
1273 Reviewed by Benjamin Poulain.
1275 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1276 Xcode wanted to fix an alphabetization issue.
1277 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1278 (TestWebKitAPI::TEST_F):
1279 Test interactions that worked but were not explicitly tested before.
1281 2015-05-12 Ryosuke Niwa <rniwa@webkit.org>
1283 Unreviewed build fix.
1285 Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
1287 * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
1289 2015-05-12 Ryosuke Niwa <rniwa@webkit.org>
1291 Fix the previous commit, which made both bubbles green.
1293 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1294 (.status-line.good .bubble):
1295 (.status-line.bad .bubble):
1296 (.status-line.good .message):
1298 2015-05-12 Ryosuke Niwa <rniwa@webkit.org>
1300 People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
1301 https://bugs.webkit.org/show_bug.cgi?id=144929
1303 Reviewed by Eric Carlson.
1305 Tweaked colors as I see fit.
1307 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1308 (.status-line.good .bubble):
1309 (.status-line.bad .bubble):
1311 2015-05-11 Alexey Proskuryakov <ap@apple.com>
1313 [Mac] Share cookie storage between UI process and secondary processes
1314 https://bugs.webkit.org/show_bug.cgi?id=144820
1315 rdar://problem/20572830
1317 Reviewed by Darin Adler.
1319 * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1320 Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
1323 2015-05-12 Jake Nielsen <jacob_nielsen@apple.com>
1325 Fix internal build configuration issues
1326 https://bugs.webkit.org/show_bug.cgi?id=144762
1328 Reviewed by David Kilzer.
1330 Modifies DumpRenderTree's xcconfig files to use SDK selectors.
1332 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1333 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1334 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1335 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1336 * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
1337 * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1338 * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1339 * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1341 2015-05-12 David Kilzer <ddkilzer@apple.com>
1343 Switch to launching iOS Simulator using bundle ID
1344 <rdar://problem/20916096>
1346 This is required to fix the layout tests on internal bots.
1348 * Scripts/webkitdirs.pm:
1349 (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
1350 Simulator. Add FIXME.
1351 (quitIOSSimulator): Add FIXME.
1352 * Scripts/webkitpy/port/ios.py:
1353 (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
1354 launch iOS Simulator. Add FIXME.
1355 (IOSSimulatorPort.check_sys_deps): Add FIXME.
1357 2015-05-12 Per Arne Vollan <peavo@outlook.com>
1359 Fix run-javascriptcore-tests step on the WinCairo bot
1360 https://bugs.webkit.org/show_bug.cgi?id=144866
1362 Reviewed by Csaba Osztrogonác.
1364 Catch exception when failing to create soft link, so we can fall back to copy.
1366 * Scripts/run-jsc-stress-tests:
1368 2015-05-12 Joanmarie Diggs <jdiggs@igalia.com>
1370 [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
1371 https://bugs.webkit.org/show_bug.cgi?id=116971
1373 Reviewed by Chris Fleizach.
1375 Implement rowAtIndex for ATK.
1377 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1378 (WTR::AccessibilityUIElement::rowAtIndex):
1380 2015-05-11 Dan Bernstein <mitz@apple.com>
1382 Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
1384 Reviewed by Alexey Proskuryakov.
1386 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1387 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
1388 * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
1389 (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
1391 2015-05-11 Jake Nielsen <jacob_nielsen@apple.com>
1393 Fix internal build configuration issues
1394 https://bugs.webkit.org/show_bug.cgi?id=144762
1396 Reviewed by Darin Adler.
1398 Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
1400 * TestWebKitAPI/Configurations/Base.xcconfig:
1401 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1402 * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1403 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1404 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1405 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1406 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1408 2015-05-11 Brent Fulgham <bfulgham@apple.com>
1410 [Win] Move Windows build target to Windows 7 (or newer)
1411 https://bugs.webkit.org/show_bug.cgi?id=144890
1412 <rdar://problem/20707307>
1414 Reviewed by Anders Carlsson.
1416 Update linked SDK and minimal Windows level to be compatible with
1419 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1420 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1421 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1422 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1423 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1424 * DumpRenderTree/config.h:
1425 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1426 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1427 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1428 * WinLauncher/stdafx.h:
1430 2015-05-11 Commit Queue <commit-queue@webkit.org>
1432 Unreviewed, rolling out r184119.
1433 https://bugs.webkit.org/show_bug.cgi?id=144888
1435 broke JSC tests on Apple Windows bots (Requested by kling on
1440 "Fix run-javascriptcore-tests step on the WinCairo bot"
1441 https://bugs.webkit.org/show_bug.cgi?id=144866
1442 http://trac.webkit.org/changeset/184119
1444 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
1446 run-benchmark should support Dromaeo
1447 https://bugs.webkit.org/show_bug.cgi?id=144849
1449 Reviewed by Chris Dumez.
1451 Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
1452 they can take as much as 15 minutes to run each.
1454 * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
1455 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
1456 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
1457 * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
1459 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
1461 Build fix. jetstream has a local copy, not remote archive.
1463 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1465 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
1467 run-benchmark should support SunSpider, Kraken and Octane
1468 https://bugs.webkit.org/show_bug.cgi?id=144840
1470 Reviewed by Darin Adler.
1472 Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
1473 Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
1474 download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
1475 for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
1477 Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
1478 specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
1480 In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
1481 needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
1483 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
1484 RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
1485 now has the ability to run an arbitrary "create script".
1487 * Scripts/run-benchmark:
1488 (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
1489 This also overrides the remote archive URL specified in the plan.
1491 * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
1493 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
1494 JetStreamBenchmarkBuilder.
1496 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1497 (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
1498 by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
1499 _runCreateScript and _applyPatch to clean after themselves.
1500 (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
1501 JetStream, SunSpider, Kraken all use this feature.
1502 (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
1503 the leaf directory name since the latter is not available when a remote ZIP file is used.
1504 (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
1505 (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
1506 the benchmark name in the patches.
1508 * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
1510 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1511 (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
1512 (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
1513 the browser opens by planName as the plan file no longer contains that.
1515 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
1516 the top directory of JetStream instead of its parent.
1517 * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
1518 * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
1519 * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
1520 the top directory of JetStream instead of its parent.
1521 * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
1522 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
1523 the script to run. The entry point was changed to the relative path from the top directory of JetStream as
1524 done in JetStream.patch.
1525 * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
1526 * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
1527 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
1528 path from the top directory of JetStream as done in JetStream.patch.
1529 * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
1531 2015-05-11 Csaba Osztrogonác <ossy@webkit.org>
1533 Fix run-javascriptcore-tests step on the WinCairo bot
1534 https://bugs.webkit.org/show_bug.cgi?id=144866
1536 Reviewed by Darin Adler.
1538 * Scripts/run-jsc-stress-tests:
1540 2015-05-11 Alex Christensen <achristensen@webkit.org>
1542 [Content Extensions] Support domain-specific rules and exceptions.
1543 https://bugs.webkit.org/show_bug.cgi?id=144833
1545 Reviewed by Darin Adler.
1547 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1548 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1549 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1550 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1551 Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
1552 (TestWebKitAPI::mainDocumentRequest):
1553 (TestWebKitAPI::subResourceRequest):
1554 (TestWebKitAPI::TEST_F):
1555 (TestWebKitAPI::checkCompilerError):
1556 Added tests for parsing and functionality of if-domain and unless-domain.
1558 2015-05-11 Ryosuke Niwa <rniwa@webkit.org>
1560 run-benchmark should support Chrome Canary and Firefox Nightly
1561 https://bugs.webkit.org/show_bug.cgi?id=144850
1563 Reviewed by Darin Adler.
1565 Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
1567 This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
1569 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
1570 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
1572 (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
1573 (OSXBrowserDriver.closeBrowsers): Ditto.
1574 (OSXBrowserDriver.launchProcess): Ditto.
1575 (OSXBrowserDriver.terminateProcesses): Ditto.
1576 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1577 (OSXChromeDriver): Removed the unused self.chromePreferences.
1578 (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
1579 (OSXChromeDriver.closeBrowsers): Ditto.
1580 (OSXChromeDriver.launchUrl):
1581 (OSXChromeCanaryDriver): Added.
1582 (OSXChromeCanaryDriver.launchUrl):
1583 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
1584 (OSXFirefoxDriver): Added.
1585 (OSXFirefoxDriver.launchUrl):
1586 (OSXFirefoxNightlyDriver): Added.
1587 (OSXFirefoxNightlyDriver.launchUrl):
1588 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1590 (OSXSafariDriver.closeBrowsers):
1592 2015-05-11 Tim Horton <timothy_horton@apple.com>
1594 Page overlay action context override should indicate the source of the request
1595 https://bugs.webkit.org/show_bug.cgi?id=144832
1596 <rdar://problem/20562594>
1598 Reviewed by Darin Adler.
1600 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
1601 (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1603 2015-05-10 Martin Robinson <mrobinson@igalia.com>
1605 [GTK] fast/events/page-visibility-transition-test.html is timing out
1606 https://bugs.webkit.org/show_bug.cgi?id=114789
1608 Reviewed by Darin Adler.
1610 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1611 (WTR::TestController::setHidden): Map and unmap the WebView when the harness
1612 requests visibility changes.
1614 2015-05-10 Csaba Osztrogonác <ossy@webkit.org>
1616 [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
1617 https://bugs.webkit.org/show_bug.cgi?id=144798
1619 Reviewed by Darin Adler.
1621 * efl/install-dependencies:
1623 2015-05-09 Ryosuke Niwa <rniwa@webkit.org>
1625 Make arguments of run-benchmark more user friendly
1626 https://bugs.webkit.org/show_bug.cgi?id=144835
1628 Reviewed by Darin Adler.
1630 Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
1631 of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
1632 instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
1633 default values from --platform and --browser as they are required arguments.
1635 * Scripts/run-benchmark:
1636 (main): Made --build-directory optional, and removed default values from --platform and --browser.
1637 Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
1638 are not dynamically obtained via BrowserDriverFactory.
1639 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1640 (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
1641 file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
1642 run any benchmark in that case.
1643 (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
1644 the specified file isn't a valid relative or an absolute path.
1645 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1646 (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
1648 (BrowserDriverFactory.available_browsers): Ditto.
1649 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1650 (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
1651 calls launchUrl with this argument so removed the default value. Also added a fallback path for when
1652 browserBuildPath was None.
1653 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1654 (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
1655 so that we can use locally built WebKit to launch Safari.
1657 2015-05-09 Yoav Weiss <yoav@yoav.ws>
1659 Remove the PICTURE_SIZES build flag
1660 https://bugs.webkit.org/show_bug.cgi?id=144679
1662 Reviewed by Benjamin Poulain.
1664 Removed the PICTURE_SIZES build time flag.
1666 * Scripts/webkitperl/FeatureList.pm:
1668 2015-05-09 David Kilzer <ddkilzer@apple.com>
1670 Layout tests broke due to unexpected simctl output
1672 * Scripts/webkitpy/xcode/simulator.py:
1673 (Simulator._parse_devices): Handle new Device Pairs header.
1674 * Scripts/webkitpy/xcode/simulator_unittest.py:
1675 (test_device_pairs): Add unit test for Device Pairs header.
1677 2015-05-08 Myles C. Maxfield <mmaxfield@apple.com>
1679 Remove convenience constructors for TextRun
1680 https://bugs.webkit.org/show_bug.cgi?id=144752
1682 Reviewed by Anders Carlsson.
1684 Test the StringView which takes a StringImpl*.
1686 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1687 (StringView8Bit): Testing is8Bit() on StringView
1689 2015-05-07 Sam Weinig <sam@webkit.org>
1691 [Content Extensions] Add simple tester that takes an extension and compiles it
1692 https://bugs.webkit.org/show_bug.cgi?id=144781
1694 Reviewed by Dan Bates.
1696 * ContentExtensionTester: Added.
1697 * ContentExtensionTester/Configurations: Added.
1698 * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
1699 * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
1700 * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
1701 * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
1702 * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
1703 * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
1704 * ContentExtensionTester/main.m: Added.
1705 * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
1707 2015-05-08 Alexey Proskuryakov <ap@apple.com>
1711 Reviewed by Dan Bernstein.
1713 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1714 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1715 (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
1716 (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
1717 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1718 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1719 (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
1720 (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
1722 2015-05-08 Martin Robinson <mrobinson@igalia.com>
1724 [GTK] Some tests fail because they do not assume the popup menu captures click events
1725 https://bugs.webkit.org/show_bug.cgi?id=40601
1727 Reviewed by Carlos Garcia Campos.
1729 Popdown all attached menus when moving between tests and between each new
1730 event sent to the WebView. This prevents context and popup menus from eating
1733 * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
1734 * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
1735 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1736 (WTR::dispatchEvent): Popdown all menus between dispatching events.
1737 (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
1738 (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
1739 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1740 (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
1741 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1742 (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
1743 longer in the platform-independent file.
1744 (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
1746 015-05-08 Michael Catanzaro <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
1748 [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1749 https://bugs.webkit.org/show_bug.cgi?id=144746
1751 Reviewed by Carlos Garcia Campos.
1753 Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1755 * MiniBrowser/gtk/main.c:
1758 2015-05-08 Commit Queue <commit-queue@webkit.org>
1760 Unreviewed, rolling out r183996.
1761 https://bugs.webkit.org/show_bug.cgi?id=144806
1763 ASan detected use-after free (Requested by ap on #webkit).
1767 "Remove convenience constructors for TextRun"
1768 https://bugs.webkit.org/show_bug.cgi?id=144752
1769 http://trac.webkit.org/changeset/183996
1771 2015-05-08 Myles C. Maxfield <mmaxfield@apple.com>
1773 Remove convenience constructors for TextRun
1774 https://bugs.webkit.org/show_bug.cgi?id=144752
1776 Reviewed by Anders Carlsson.
1778 Test the StringView which takes a StringImpl*.
1780 * TestWebKitAPI/Tests/WTF/StringView.cpp:
1781 (StringView8Bit): Testing is8Bit() on StringView
1783 2015-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
1785 [GTK] WTR doesn't correctly handle the Escape key
1786 https://bugs.webkit.org/show_bug.cgi?id=144788
1788 Reviewed by Martin Robinson.
1790 Correctly handle 0x001B character code in GTK+ event sender to be
1791 recognized as Escape key, because gdk_unicode_to_keyval() doesn't
1792 handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
1793 to dismiss popup menus.
1795 Fixes editing/selection/5354455-1.html.
1797 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1798 (WTR::getGDKKeySymForKeyRef):
1800 2015-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
1802 [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
1803 https://bugs.webkit.org/show_bug.cgi?id=144748
1805 Reviewed by Sergio Villar Senin.
1807 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1808 (testWebKitSettings): Check the new setting is correctly
1809 initialized and updated.
1810 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1811 (testWebContextSecurityFileXHR): Check XHR to local files is
1812 allowed from file URLs after changing the setting.
1813 (beforeAll): Add new test.
1815 2015-05-08 Commit Queue <commit-queue@webkit.org>
1817 Unreviewed, rolling out r183945.
1818 https://bugs.webkit.org/show_bug.cgi?id=144789
1820 "It broke all the GTK+ tests" (Requested by KaL on #webkit).
1824 "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
1825 https://bugs.webkit.org/show_bug.cgi?id=144746
1826 http://trac.webkit.org/changeset/183945
1828 2015-05-07 Anders Carlsson <andersca@apple.com>
1832 * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
1833 (TestWebKitAPI::TEST):
1834 * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
1835 (TestWebKitAPI::TEST):
1838 2015-05-07 Filip Pizlo <fpizlo@apple.com>
1840 GC has trouble with pathologically large array allocations
1841 https://bugs.webkit.org/show_bug.cgi?id=144609
1843 Reviewed by Geoffrey Garen.
1845 Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
1846 and it's a frequently requested feature.
1848 Also add the ability to run a test pretending that your system has a particular RAM size.
1849 This is useful for GC tests, and the new GC test that I added uses this.
1851 * Scripts/run-javascriptcore-tests:
1852 (runJSCStressTests):
1853 * Scripts/run-jsc-stress-tests:
1855 2015-05-07 Csaba Osztrogonác <ossy@webkit.org>
1857 [EFL] Bump EFL version to 1.14.0
1858 https://bugs.webkit.org/show_bug.cgi?id=144743
1860 Reviewed by Darin Adler.
1862 Bump EFL and elementary version to 1.14.0 and removed
1863 md5sum, because it isn't used at all if hash is present.
1865 * efl/jhbuild.modules:
1867 2015-05-07 Saam Barati <saambarati1@gmail.com>
1869 exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
1870 https://bugs.webkit.org/show_bug.cgi?id=144753
1872 Reviewed by Mark Lam.
1874 * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1876 2015-05-07 Beth Dakin <bdakin@apple.com>
1878 New force-related DOM events should fire in WK1 views
1879 https://bugs.webkit.org/show_bug.cgi?id=144663
1881 rdar://problem/20281886
1883 Reviewed by Sam Weinig.
1885 PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event
1887 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1888 (TestWebKitAPI::buildAndPerformTest):
1890 2015-05-07 Michael Catanzaro <mcatanzaro@igalia.com>
1892 [GTK] Checks for DEVELOPMENT_BUILD are all wrong
1893 https://bugs.webkit.org/show_bug.cgi?id=144746
1895 Reviewed by Martin Robinson.
1897 Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
1899 * MiniBrowser/gtk/main.c:
1902 2015-05-05 Myles C. Maxfield <mmaxfield@apple.com>
1904 Revert "Introducing the Platform Abstraction Layer (PAL)"
1905 https://bugs.webkit.org/show_bug.cgi?id=144751
1909 PAL should be a new target inside WebCore, rather than a top-level folder.
1911 * Scripts/build-webkit: Add it to build-webkit.
1913 2015-05-07 Ada Chan <adachan@apple.com>
1915 Add a test for WKPageCopySessionState() with filtering.
1916 https://bugs.webkit.org/show_bug.cgi?id=144666
1918 Reviewed by Darin Adler.
1920 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1921 * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
1922 (TestWebKitAPI::didFinishLoadForFrame):
1923 (TestWebKitAPI::setPageLoaderClient):
1924 (TestWebKitAPI::filterFirstItemCallback):
1925 (TestWebKitAPI::filterAllItemsCallback):
1926 (TestWebKitAPI::createSessionStates):
1927 (TestWebKitAPI::TEST):
1929 2015-05-06 Alexey Proskuryakov <ap@apple.com>
1931 iOS build fix attempt
1933 Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
1935 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1937 2015-05-06 Matt Baker <mattbaker@apple.com>
1939 Unreviewed, updated my list of email addresses.
1941 * Scripts/webkitpy/common/config/contributors.json:
1943 2015-05-06 Alexey Proskuryakov <ap@apple.com>
1945 Do not link tools to WebKit2.framework
1946 https://bugs.webkit.org/show_bug.cgi?id=144699
1948 Unreviewed build fix.
1950 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1951 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1952 These linked to WebKit2 in two ways, eliminating the other one.
1954 2015-05-05 Myles C. Maxfield <mmaxfield@apple.com>
1956 Introducing the Platform Abstraction Layer (PAL)
1957 https://bugs.webkit.org/show_bug.cgi?id=143358
1959 Reviewed by Simon Fraser.
1961 * Scripts/build-webkit: Add it to build-webkit.
1963 2015-05-06 Alex Christensen <achristensen@webkit.org>
1965 Fix api tests after r183877.
1967 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1968 (TestWebKitAPI::TEST_F):
1969 Generate all DFAs before compiling them.
1971 2015-05-06 Alexey Proskuryakov <ap@apple.com>
1973 Do not link tools to WebKit2.framework
1974 https://bugs.webkit.org/show_bug.cgi?id=144699
1976 Reviewed by Tim Horton.
1978 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1979 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1980 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1982 2015-05-06 Alex Christensen <achristensen@webkit.org>
1984 [Content Extensions] Test splitting NFAs by max NFA size.
1985 https://bugs.webkit.org/show_bug.cgi?id=144659
1987 Reviewed by Darin Adler.
1989 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1990 (TestWebKitAPI::createNFAs):
1991 (TestWebKitAPI::TEST_F):
1992 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1993 (TestWebKitAPI::createNFAs):
1995 2015-05-05 daegyu lee <daegyu.lee@navercorp.com>
1997 Remove the remaining vestiges of SVG feature define
1998 https://bugs.webkit.org/show_bug.cgi?id=144655
2000 Reviewed by Alexey Proskuryakov.
2002 * Scripts/webkitperl/FeatureList.pm:
2004 2015-05-05 Timothy Horton <timothy_horton@apple.com>
2006 Add a layout mode for computing fixed layout size from a minimum size
2007 https://bugs.webkit.org/show_bug.cgi?id=144610
2008 <rdar://problem/19790341>
2010 Reviewed by Simon Fraser.
2012 * MiniBrowser/mac/BrowserWindow.xib:
2013 * MiniBrowser/mac/BrowserWindowController.h:
2014 * MiniBrowser/mac/WK1BrowserWindowController.m:
2015 (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
2016 * MiniBrowser/mac/WK2BrowserWindowController.m:
2017 (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
2018 Add a optional toolbar item to toggle a minimum view size of 1024x0.
2020 2015-05-05 Alex Christensen <achristensen@webkit.org>
2022 [Content Extensions] Release input NSString when finished copying it.
2023 https://bugs.webkit.org/show_bug.cgi?id=144642
2025 Reviewed by Brian Weinstein.
2027 * WebKitTestRunner/mac/TestControllerMac.mm:
2028 (WTR::TestController::platformConfigureViewForTest):
2029 Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
2031 2015-05-05 Brent Fulgham <bfulgham@apple.com>
2033 Unreviewed test fix after r183798.
2035 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2036 (convertToDRTLabel): Mimic behavior of Mac accessibility output
2037 so we can share results.
2039 2015-05-05 Alex Christensen <achristensen@webkit.org>
2041 [Content Extensions] Use less memory to store the json input.
2042 https://bugs.webkit.org/show_bug.cgi?id=144604
2044 Reviewed by Benjamin Poulain.
2046 * MiniBrowser/mac/ExtensionManagerWindowController.m:
2047 (-[ExtensionManagerWindowController add:]):
2048 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2049 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2050 * WebKitTestRunner/mac/TestControllerMac.mm:
2051 (WTR::TestController::platformConfigureViewForTest):
2053 2015-05-05 Yusuke Suzuki <utatane.tea@gmail.com>
2055 Unreviewed. Make myself a WebKit reviewer.
2057 * Scripts/webkitpy/common/config/contributors.json:
2059 2015-05-05 Joanmarie Diggs <jdiggs@igalia.com>
2061 [GTK] r183783 breaks build
2062 https://bugs.webkit.org/show_bug.cgi?id=144632
2064 Reviewed by Martin Robinson.
2066 Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
2068 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2069 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2071 2015-05-05 Alex Christensen <achristensen@webkit.org>
2073 [Content Extensions] Combine NFAs properly and free memory as we compile.
2074 https://bugs.webkit.org/show_bug.cgi?id=144485
2076 Reviewed by Benjamin Poulain.
2078 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2079 (TestWebKitAPI::TEST_F):
2080 Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
2081 Added tests for deep NFAs.
2083 2015-05-04 Alex Christensen <achristensen@webkit.org>
2085 [Content Extensions] Use less memory when writing byte code to file
2086 https://bugs.webkit.org/show_bug.cgi?id=144602
2088 Reviewed by Darin Adler.
2090 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2092 2015-05-05 Carlos Garcia Campos <cgarcia@igalia.com>
2094 [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
2095 https://bugs.webkit.org/show_bug.cgi?id=144541
2097 Reviewed by Žan Doberšek.
2099 Add a test case to WorkQueue unit test, to check that sources of
2100 asynchronous IO operations running in the WorkQueue thread are
2101 dispatched by the WorkQueue main loop.
2103 * TestWebKitAPI/PlatformGTK.cmake:
2104 * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
2105 (TestWebKitAPI::TEST):
2107 2015-05-04 Brent Fulgham <bfulgham@apple.com>
2109 Correct '--show-webview' option for Tiled Drawing tests
2110 https://bugs.webkit.org/show_bug.cgi?id=144621
2112 Reviewed by Simon Fraser.
2114 The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
2115 sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
2117 * WebKitTestRunner/mac/TestControllerMac.mm:
2118 (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
2119 WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
2121 2015-05-04 Filip Pizlo <fpizlo@apple.com>
2123 Large array shouldn't be slow
2124 https://bugs.webkit.org/show_bug.cgi?id=144617
2126 Reviewed by Geoffrey Garen.
2128 Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
2129 SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
2130 long-running. So, hash-map sort of belongs here.
2132 * Scripts/run-jsc-benchmarks:
2134 2015-05-04 Doug Russell <d_russell@apple.com>
2136 AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
2137 https://bugs.webkit.org/show_bug.cgi?id=144489
2139 Reviewed by Chris Fleizach.
2141 Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
2142 on the returned control.
2143 Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
2144 Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
2145 Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
2146 Add support for setSelectedVisibleTextRange() in accessibility tests.
2148 * DumpRenderTree/AccessibilityUIElement.cpp:
2149 (setSelectedVisibleTextRangeCallback):
2150 (AccessibilityUIElement::setSelectedVisibleTextRange):
2151 (AccessibilityUIElement::getJSClass):
2152 (AccessibilityUIElement::textMarkerForIndex): Deleted.
2153 * DumpRenderTree/AccessibilityUIElement.h:
2154 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2155 (AccessibilityUIElement::setSelectedVisibleTextRange):
2156 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2157 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2158 (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
2159 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2160 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2161 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2162 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2163 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2164 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2165 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2166 (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
2168 2015-05-04 Brent Fulgham <bfulgham@apple.com>
2170 [Win] Implement the "--show-webview" option for Windows
2171 https://bugs.webkit.org/show_bug.cgi?id=144589
2173 Reviewed by Alex Christensen.
2175 Add another runtime flag (--show-webview) that causes DumpRenderTree
2176 to draw its view on-screen, rather than the standard offscreen mode.
2178 * DumpRenderTree/win/DumpRenderTree.cpp:
2179 (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
2180 (initializeGlobalsFromCommandLineOptions): Recognize the new
2181 command-line argument, and set the global 'showWebView' state if
2184 2015-05-04 Csaba Osztrogonác <ossy@webkit.org>
2186 Remove dead code from TestInvocationCairo.cpp
2187 https://bugs.webkit.org/show_bug.cgi?id=144564
2189 Reviewed by Gyuyoung Kim.
2191 Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
2193 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2194 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2196 2015-05-04 Joonghun Park <jh718.park@samsung.com>
2198 [GTK] Add libnotify in gtk install-dependencies
2199 https://bugs.webkit.org/show_bug.cgi?id=144379
2201 Reviewed by Csaba Osztrogonác.
2203 * gtk/install-dependencies:
2205 2015-05-01 Dan Bernstein <mitz@apple.com>
2207 Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
2208 https://bugs.webkit.org/show_bug.cgi?id=144501
2210 Reviewed by Darin Adler.
2212 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2213 * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
2214 (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
2215 (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
2217 2015-05-01 Mario Sanchez Prada <mario@endlessm.com>
2219 check-webkit-style fails due to system pylint
2220 https://bugs.webkit.org/show_bug.cgi?id=144360
2222 Reviewed by Darin Adler.
2224 Make sure that the directory containing third party autoinstalled modules
2225 is at the beginning of the search path, to avoid conflicts with other
2226 versions of the same modules installed in the system (e.g. pylint).
2228 * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
2229 modules directory to sys.path, instead of appending it.
2231 2015-05-01 Mario Sanchez Prada <mario@endlessm.com>
2233 Unreviewed, updated my list of email addresses.
2235 * Scripts/webkitpy/common/config/contributors.json: Updated.
2237 2015-05-01 Martin Robinson <mrobinson@igalia.com>
2239 USE(...) macro should expect unprefixed variables
2240 https://bugs.webkit.org/show_bug.cgi?id=144454
2242 Reviewed by Daniel Bates.
2244 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
2245 * DumpRenderTree/config.h: Ditto.
2246 * TestWebKitAPI/config.h: Ditto.
2248 2015-05-01 Basile Clement <basile_clement@apple.com>
2250 Unreviewed. Add myself as a commiter in contributors.json.
2252 * Scripts/webkitpy/common/config/contributors.json:
2254 2015-05-01 Dewei Zhu <dewei_zhu@apple.com>
2256 Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
2257 https://bugs.webkit.org/show_bug.cgi?id=144487
2259 Reviewed by Ryosuke Niwa.
2261 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2262 (BenchmarkRunner.merge): Fix bug.
2263 * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
2265 2015-05-01 Brady Eidson <beidson@apple.com>
2267 Add API to disable meta refreshes.
2268 <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
2270 Reviewed by Alexey Proskuryakov.
2272 * DumpRenderTree/mac/DumpRenderTree.mm:
2273 (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
2275 2015-05-01 Brent Fulgham <bfulgham@apple.com>
2277 Provide a runtime flag to run-webkit-tests that shows the test view
2278 https://bugs.webkit.org/show_bug.cgi?id=144079.
2280 Unreviewed correction to r183651.
2282 * WebKitTestRunner/TestController.cpp:
2283 (WTR::TestController::initialize): Make sure the state of the '--show-webview'
2284 flag is included in the options dictionary passed to the PlatformWebView.
2286 2015-05-01 Antti Koivisto <antti@apple.com>
2288 Remove network process load serialization code
2289 https://bugs.webkit.org/show_bug.cgi?id=144448
2291 Reviewed by Alexey Proskuryakov.
2293 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2294 (WTR::InjectedBundle::beginTesting):
2295 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2296 (WTR::TestRunner::setSerializeHTTPLoads):
2297 (WTR::TestRunner::dispatchPendingLoadRequests):
2299 2015-05-01 Xabier Rodriguez Calvar <calvaris@igalia.com>
2301 [GTK] Add libhyphen-dev to the build dependencies
2302 https://bugs.webkit.org/show_bug.cgi?id=144452
2304 Reviewed by Martin Robinson.
2306 * gtk/install-dependencies: Added hyphen as Fedora and Arch
2309 2015-04-30 Brent Fulgham <bfulgham@apple.com>
2311 Provide a runtime flag to run-webkit-tests that shows the test view
2312 https://bugs.webkit.org/show_bug.cgi?id=144079.
2314 Reviewed by Dean Jackson.
2316 Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
2317 their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
2320 --additional-drt-flag="--show-webview"
2322 * DumpRenderTree/mac/DumpRenderTree.mm:
2323 (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
2324 '--show-webview' flag.
2325 (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
2326 * WebKitTestRunner/Options.cpp:
2327 (WTR::Options::Options):
2328 (WTR::handleOptionShowWebView):
2329 (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
2330 * WebKitTestRunner/Options.h:
2331 * WebKitTestRunner/TestController.cpp:
2332 (WTR::TestController::TestController):
2333 (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
2334 * WebKitTestRunner/TestController.h:
2335 (WTR::TestController::shouldShowWebView):
2336 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2337 (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
2338 options dictionary. If it is true, display the web view while running the test.
2340 2015-04-30 Alexey Proskuryakov <ap@apple.com>
2342 r183355 didn't trigger Mac tests
2343 https://bugs.webkit.org/show_bug.cgi?id=144464
2345 Reviewed by Simon Fraser.
2347 Update badly neglected filters and unit tests.
2349 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2350 (_should_file_trigger_build):
2351 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2353 (ShouldBuildTest.test_should_build):
2355 2015-04-30 Xabier Rodriguez Calvar <calvaris@igalia.com>
2357 [GTK] Add libhyphen-dev to the build dependencies
2358 https://bugs.webkit.org/show_bug.cgi?id=144452
2360 Reviewed by Martin Robinson.
2362 * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
2365 2015-04-30 Martin Robinson <mrobinson@igalia.com>
2367 [GTK] Testing dictionaries are not installed automatically
2368 https://bugs.webkit.org/show_bug.cgi?id=144460
2370 Reviewed by Carlos Garcia Campos.
2372 * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
2374 2015-04-30 Dewei Zhu <dewei_zhu@apple.com>
2376 Fix return code issue, check return code of safari process and dump results to log
2377 https://bugs.webkit.org/show_bug.cgi?id=144436
2379 Reviewed by Ryosuke Niwa.
2381 * Scripts/run-benchmark:
2382 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2383 (BenchmarkRunner.dump): Correct typo.
2384 (BenchmarkRunner.wrap): Add results to console.
2385 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
2386 (OSXSafariDriver.prepareEnv):
2387 (OSXSafariDriver.launchUrl):
2388 (OSXSafariDriver.closeBrowsers):
2390 2015-04-29 Joseph Pecoraro <pecoraro@apple.com>
2392 Should no longer need to worry about very old versions of Xcode
2393 https://bugs.webkit.org/show_bug.cgi?id=144437
2395 Reviewed by Dan Bernstein.
2397 * Scripts/check-for-exit-time-destructors:
2398 * Scripts/check-for-global-initializers:
2399 * Scripts/check-for-weak-vtables-and-externals:
2401 2015-04-29 Joseph Pecoraro <pecoraro@apple.com>
2403 REGRESSION(183583): [Mac] make without SDKROOT has issues
2404 https://bugs.webkit.org/show_bug.cgi?id=144431
2406 Reviewed by Dan Bernstein.
2409 * WebKitTestRunner/Makefile:
2410 Assume an empty SDKROOT means an macosx variant, so only
2411 enable settings if the SDKROOT is not empty and does not
2414 2015-04-29 Brent Fulgham <bfulgham@apple.com>
2416 Expand test infrastructure to support scrolling tests
2417 https://bugs.webkit.org/show_bug.cgi?id=143684
2418 <rdar://problem/20375516>
2420 Reviewed by Simon Fraser.
2422 * DumpRenderTree/mac/DumpRenderTree.mm:
2423 (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
2424 reset before the next test run.
2425 * WebKitTestRunner/TestController.cpp:
2426 (WTR::TestController::resetStateToConsistentValues): Ditto."
2428 2015-04-29 Alex Christensen <achristensen@webkit.org>
2430 Run javascriptcore tests on Windows without cygwin
2431 https://bugs.webkit.org/show_bug.cgi?id=144419
2433 Reviewed by Brent Fulgham.
2435 * Scripts/run-javascriptcore-tests:
2436 (runJSCStressTests):
2437 Just call ruby, not /usr/bin/env ruby.
2439 2015-04-29 Yusuke Suzuki <utatane.tea@gmail.com>
2441 [GTK] Add --enable-shared option to LLVM to build mesa
2442 https://bugs.webkit.org/show_bug.cgi?id=144393
2444 Reviewed by Martin Robinson.
2446 The updated mesa requires the shared LLVM libraries.
2447 To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
2448 to LLVM configure script. It will provide shared libraries in addition to static libraries.
2450 * gtk/jhbuild-optional.modules:
2452 2015-04-29 Martin Robinson <mrobinson@igalia.com>
2454 [GTK] Add support for automatic hyphenation
2455 https://bugs.webkit.org/show_bug.cgi?id=44478
2457 Reviewed by Carlos Garcia Campos.
2459 * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
2460 all systems will use the same dictionaries for testing purposes.
2462 2015-04-29 Jake Nielsen <jacob_nielsen@apple.com>
2464 Failure when building WebKit for appletvsimulator.
2465 https://bugs.webkit.org/show_bug.cgi?id=144356
2467 Reviewed by Alexey Proskuryakov.
2469 Changes Makefile logic to check for "not OS X" rather than "is iOS" to
2470 make TVOS and WatchOS behave correctly.
2473 * WebKitTestRunner/Makefile:
2475 2015-04-29 Alexey Proskuryakov <ap@apple.com>
2477 Use-after-free when invalidating WKPageForceRepaint callback
2478 https://bugs.webkit.org/show_bug.cgi?id=144401
2479 rdar://problem/20741111
2481 Reviewed by Tim Horton.
2483 * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
2485 * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
2486 Don't do anything on error, because the context may be a stale pointer now.
2488 2015-04-29 David Kilzer <ddkilzer@apple.com>
2490 check-webkit-style: Don't complain about returning value from Objective-C method call in header
2491 <http://webkit.org/b/144395>
2493 Reviewed by Andy Estes.
2495 * Scripts/webkitpy/style/checkers/cpp.py:
2496 (check_spacing): Update regex so 'return' is ignored if it
2497 precedes the whitespace and bracket. Change category name to
2498 'whitespace/brackets'. Add period to error message.
2499 (CppChecker): Add 'whitespace/brackets' as a category.
2500 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2501 (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
2502 'CppChecker.categories' since that's where the list lives now.
2503 (CppStyleTest.test_spacing_before_brackets): Add tests for
2504 'whitespace/brackets' issues and non-issues.
2506 2015-04-29 Alex Christensen <achristensen@webkit.org>
2510 * Scripts/webkitdirs.pm:
2511 (determinePassedConfiguration):
2512 WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
2514 2015-04-29 Myles C. Maxfield <mmaxfield@apple.com>
2516 [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
2517 https://bugs.webkit.org/show_bug.cgi?id=132159
2519 Reviewed by Darin Adler.
2521 Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
2522 swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
2524 * DumpRenderTree/mac/DumpRenderTree.mm:
2527 (createWebViewAndOffscreenWindow):
2528 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2529 (WTR::activateFonts):
2530 * WebKitTestRunner/mac/TestControllerMac.mm:
2531 (WTR::allowedFontFamilySet):
2532 (WTR::systemHiddenFontFamilySet):
2533 (WTR::generateWhitelist):
2534 (WTR::TestController::platformInitializeContext):
2536 2015-04-29 Alexey Proskuryakov <ap@apple.com>
2538 fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2539 https://bugs.webkit.org/show_bug.cgi?id=144155
2541 Reviewed by Andreas Kling.
2543 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
2544 Make sure that test window is "visible" before each test. While there is no concrete
2545 evidence that this is the problem indeed, the behavior is consistent with what would
2546 happen for an invisible window. Also, WKTR obviously needs to do this to protect
2547 against potential buggy tests that hide the window and don't show it.
2549 2015-04-29 Carlos Garcia Campos <cgarcia@igalia.com>
2551 Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
2553 Latest changes in the inspector UI made this test fail. We were
2554 relying that the sidebar was always visible and the first 'li'
2555 element of the inspector was the one containing the title. This is
2556 no longer true, so better use document title that is not likely
2559 * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2560 (openRemoteDebuggingSession):
2562 2015-04-29 Andres Gomez <agomez@igalia.com>
2564 Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
2566 * Scripts/webkitpy/common/config/contributors.json:
2568 2015-04-29 Andres Gomez <agomez@igalia.com>
2570 Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
2572 * Scripts/webkitpy/common/config/watchlist:
2574 2015-04-29 Hunseop Jeong <hs85.jeong@samsung.com>
2576 [EFL] Allow to run the tests on the native X display
2577 https://bugs.webkit.org/show_bug.cgi?id=144247
2579 Reviewed by Gyuyoung Kim.
2581 Added the USE_NATIVE_XDISPLAY option for the WTR.
2582 We can select the Xorg driver if environment variable is set up before running the tests.
2584 * Scripts/webkitpy/port/efl.py:
2585 (EflPort._driver_class):
2587 2015-04-29 Joonghun Park <jh718.park@samsung.com>
2589 [GTK] Add libnotify-dev in gtk install-dependencies
2590 https://bugs.webkit.org/show_bug.cgi?id=144379
2592 Reviewed by Žan Doberšek.
2594 * gtk/install-dependencies:
2596 2015-04-28 Ryuan Choi <ryuan.choi@navercorp.com>
2598 [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
2599 https://bugs.webkit.org/show_bug.cgi?id=143001
2601 Reviewed by Gyuyoung Kim.
2603 * WebKitTestRunner/TestController.cpp:
2604 (WTR::shouldUseFixedLayout):
2606 2015-04-28 Dewei Zhu <dewei_zhu@apple.com>
2608 Increase stablility of run-benchmark script
2609 https://bugs.webkit.org/show_bug.cgi?id=144361
2611 Reviewed by Ryosuke Niwa.
2613 * Scripts/run-benchmark:
2615 * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
2616 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2617 (GenericBenchmarkBuilder.clean):
2618 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
2619 (BenchmarkRunner.__init__):
2620 (BenchmarkRunner.execute):
2621 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2622 (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
2623 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
2624 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
2625 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
2626 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2627 (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
2628 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2629 (HTTPServerDriver.fetchResult):
2631 (HTTPServerDriver.killServer): Add kill server interface.
2632 (HTTPServerDriver.getReturnCode): Add get return code interface.
2633 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
2634 (SimpleHTTPServerDriver.serve):
2635 (SimpleHTTPServerDriver.fetchResult):
2636 (SimpleHTTPServerDriver):
2637 (SimpleHTTPServerDriver.killServer):
2638 (SimpleHTTPServerDriver.getReturnCode):
2639 * Scripts/webkitpy/benchmark_runner/utils.py:
2640 (forceRemove): Provide python version of 'rm -rf'.
2642 2015-04-28 Sam Weinig <sam@webkit.org>
2644 [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
2645 https://bugs.webkit.org/show_bug.cgi?id=144363
2647 Reviewed by Alex Christensen.
2649 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2650 (TestWebKitAPI::createNFAs):
2651 (TestWebKitAPI::TEST_F):
2652 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2653 (TestWebKitAPI::countLiveNodes):
2654 (TestWebKitAPI::createNFAs):
2655 (TestWebKitAPI::buildDFAFromPatterns):
2656 Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
2658 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com>
2660 Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2661 https://bugs.webkit.org/show_bug.cgi?id=144304
2663 Reviewed by Geoffrey Garen.
2665 * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
2666 set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2667 * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2669 2015-04-28 Commit Queue <commit-queue@webkit.org>
2671 Unreviewed, rolling out r183514.
2672 https://bugs.webkit.org/show_bug.cgi?id=144359
2674 It broke cloop test bots (Requested by mcatanzaro on #webkit).
2678 "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
2679 https://bugs.webkit.org/show_bug.cgi?id=144304
2680 http://trac.webkit.org/changeset/183514
2682 2015-04-28 Michael Catanzaro <mcatanzaro@igalia.com>
2684 Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
2685 https://bugs.webkit.org/show_bug.cgi?id=144304
2687 Reviewed by Geoffrey Garen.
2689 * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
2690 checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
2691 of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
2692 * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
2694 2015-04-28 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2696 [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
2697 https://bugs.webkit.org/show_bug.cgi?id=144319
2699 Reviewed by Csaba Osztrogonác.
2701 * TestWebKitAPI/CMakeLists.txt:
2702 * TestWebKitAPI/PlatformEfl.cmake:
2704 2015-04-28 Joseph Pecoraro <pecoraro@apple.com>
2706 Fix common typo "targetting" => "targeting"
2707 https://bugs.webkit.org/show_bug.cgi?id=144349
2709 Reviewed by Daniel Bates.
2711 * Scripts/webkitdirs.pm:
2712 (execMacWebKitAppForDebugging):
2714 2015-04-28 Joanmarie Diggs <jdiggs@igalia.com>
2716 [GTK][jhbuild] Mesa build failure with llvm 3.6
2717 https://bugs.webkit.org/show_bug.cgi?id=144250
2719 Reviewed by Žan Doberšek.
2721 Bump the version of Mesa to 10.5.4
2723 * gtk/jhbuild.modules:
2725 2015-04-28 Alexey Proskuryakov <ap@apple.com>
2727 Disable App Nap in WebKitTestRunner UI process
2728 https://bugs.webkit.org/show_bug.cgi?id=144308
2730 Reviewed by Daniel Bates.
2732 * WebKitTestRunner/mac/main.mm:
2733 (disableAppNapInUIProcess):
2736 2015-04-28 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
2738 [GTK] Update JHBuild Mesa download directory
2739 https://bugs.webkit.org/show_bug.cgi?id=144318
2741 Update the download directory of Mesa module since the previous one
2742 doesn't exist any more.
2744 Reviewed by Žan Doberšek.
2746 * gtk/jhbuild.modules:
2748 2015-04-28 Commit Queue <commit-queue@webkit.org>
2750 Unreviewed, rolling out r183477.
2751 https://bugs.webkit.org/show_bug.cgi?id=144334
2753 Roll back the Mesa dependency bump in fear of uncaught
2754 regressions while the testing bots are no-op. (Requested by
2755 zdobersek on #webkit).
2759 "[GTK][jhbuild] Mesa build failure with llvm 3.6"
2760 https://bugs.webkit.org/show_bug.cgi?id=144250
2761 http://trac.webkit.org/changeset/183477
2763 2015-04-28 Joanmarie Diggs <jdiggs@igalia.com>
2765 [GTK][jhbuild] Mesa build failure with llvm 3.6
2766 https://bugs.webkit.org/show_bug.cgi?id=144250
2768 Reviewed by Žan Doberšek.
2770 Bump the version of Mesa to 10.5.4
2772 * gtk/jhbuild.modules:
2774 2015-04-27 Dewei Zhu <dewei_zhu@apple.com>
2776 Add '__init__.py' and fix known bug in benchmark runner.
2777 https://bugs.webkit.org/show_bug.cgi?id=144296
2779 Reviewed by Ryosuke Niwa
2781 * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
2782 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
2783 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2784 (BenchmarkRunner.__init__):
2785 (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
2786 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
2787 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
2789 2015-04-27 Alexey Proskuryakov <ap@apple.com>
2793 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2794 (-[AccessibilityNotificationHandler _notificationReceived:]):
2795 Use -objectForKey:, not array subscript.
2797 2015-04-27 Alexey Proskuryakov <ap@apple.com>
2799 Catch unexpected exits in DumpRenderTree
2800 https://bugs.webkit.org/show_bug.cgi?id=144288
2802 Reviewed by Tim Horton.
2804 * DumpRenderTree/mac/DumpRenderTree.mm:
2806 (DumpRenderTreeMain):
2808 2015-04-27 Alexey Proskuryakov <ap@apple.com>
2812 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2813 (-[AccessibilityNotificationHandler _notificationReceived:]):
2814 Use -objectForKey:, not array subscript.
2816 2015-04-27 Alexey Proskuryakov <ap@apple.com>
2818 fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
2819 https://bugs.webkit.org/show_bug.cgi?id=144155
2821 Reviewed by Tim Horton.
2823 * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
2824 Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
2825 and we clearly don't want App Nap while testing.
2827 2015-04-22 Martin Robinson <mrobinson@igalia.com>
2829 [CMake] Autogenerate cmakeconfig.h.cmake
2830 https://bugs.webkit.org/show_bug.cgi?id=143997
2832 Reviewed by Csaba Osztrogonác.
2834 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
2835 definitions since TestNetscapePlugIn does not use cmakeconfig.h.
2837 2015-04-27 Brent Fulgham <bfulgham@apple.com>
2839 REGRESSION(r182879): Images and video can no longer be downloaded
2840 https://bugs.webkit.org/show_bug.cgi?id=144267
2841 <rdar://problem/20702844>
2843 Reviewed by Simon Fraser.
2845 Revise tests to check for proper download menu state.
2846 1. Downloading a loal image should be disabled.
2847 2. Downloading a local media file should be disabled.
2848 3. Downloading non-downloadable media should be disabled.
2850 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2851 (TestWebKitAPI::TEST):
2853 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
2855 Merge run-launcher into run-minibrowser
2856 https://bugs.webkit.org/show_bug.cgi?id=141928
2858 Reviewed by Darin Adler.
2860 * Scripts/run-iexploder-tests:
2861 (runSafariWithIExploder):
2862 * Scripts/run-launcher: Removed.
2863 * Scripts/run-minibrowser:
2864 * Scripts/webkitdirs.pm:
2866 * Scripts/webkitpy/port/efl.py:
2867 (EflPort.show_results_html_file):
2868 * Scripts/webkitpy/port/efl_unittest.py:
2869 (EflPortTest.test_show_results_html_file):
2870 * Scripts/webkitpy/port/gtk.py:
2871 (GtkPort.print_leaks_summary):
2872 (GtkPort.show_results_html_file):
2874 * Scripts/webkitpy/port/gtk_unittest.py:
2875 (GtkPortTest.test_show_results_html_file):
2877 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
2879 [buildbot] Fix the output of perf-test buildstep on timeout
2880 https://bugs.webkit.org/show_bug.cgi?id=144097
2882 Reviewed by Ryosuke Niwa.
2884 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2885 (RunAndUploadPerfTests.getText2):
2886 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2887 (RunAndUploadPerfTestsTest.test_buildbot_timeout):
2888 (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
2890 2015-04-27 Csaba Osztrogonác <ossy@webkit.org>
2892 [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
2893 https://bugs.webkit.org/show_bug.cgi?id=143874
2895 Reviewed by Gyuyoung Kim.
2897 * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
2899 2015-04-24 Philippe Normand <pnormand@igalia.com>
2901 [JHBuild] Move to upstream OpenWebRTC
2902 https://bugs.webkit.org/show_bug.cgi?id=144145
2904 Reviewed by Carlos Garcia Campos.
2906 * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
2907 and add a new simple patch to gst-plugins-base, required for
2909 * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2910 * gtk/jhbuild.modules: Ditto.
2911 * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
2913 2015-04-26 Yusuke Suzuki <utatane.tea@gmail.com>
2915 [ES6] Implement ES6 template literals
2916 https://bugs.webkit.org/show_bug.cgi?id=142691
2918 Reviewed by Darin Adler.
2920 Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
2922 * Scripts/webkitperl/FeatureList.pm:
2924 2015-04-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
2926 [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake
2927 https://bugs.webkit.org/show_bug.cgi?id=144217
2929 Reviewed by Darin Adler.
2931 * WebKitTestRunner/PlatformEfl.cmake:
2933 2015-04-26 Doug Russell <d_russell@apple.com>
2935 AX: richer text change notifications (142719)
2936 https://bugs.webkit.org/show_bug.cgi?id=142719
2938 Reviewed by Darin Adler.
2940 Richer accessibility value change notifications. Introduce AXTextEditType,
2941 postTextStateChangeNotification and postTextReplacementNotification to give assistive
2942 tech apps more reliable context for responding to changes in web content. Also implement
2943 a mechanism to post value changes in password form fields in coalesced ticks to thwart
2944 analyzing the cadence of changes.
2946 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
2947 and an overload of postTextReplacementNotification to give assistive tech apps more
2948 reliable context for responding to changes in web content selection. Also block posting
2949 selection changes on password fields.
2951 * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
2952 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2953 (-[AccessibilityNotificationHandler stopObserving]):
2954 (-[AccessibilityNotificationHandler _notificationReceived:]):
2955 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2956 (AccessibilityUIElement::removeNotificationListener):
2957 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2958 (-[AccessibilityNotificationHandler _notificationReceived:]):
2959 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2960 (WTR::AccessibilityUIElement::removeNotificationListener):
2962 2015-04-25 Sungmann Cho <sungmann.cho@navercorp.com>
2964 Add myself to contributors.json
2965 https://bugs.webkit.org/show_bug.cgi?id=144204
2967 Reviewed by Darin Adler.
2969 * Scripts/webkitpy/common/config/contributors.json:
2971 2015-04-25 Martin Robinson <mrobinson@igalia.com>
2973 Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
2974 https://bugs.webkit.org/show_bug.cgi?id=144182
2976 Reviewed by Simon Fraser.
2978 * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
2980 2015-04-25 Dewei Zhu <dewei_zhu@apple.com>
2982 https://bugs.webkit.org/show_bug.cgi?id=144038
2984 Reviewed by Ryosuke Niwa
2986 Add a script to run Speedometer and JetStream on a browser.
2988 * Scripts/run-benchmark: Wrapper script to run benchmark.
2990 * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
2991 * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
2992 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
2993 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
2994 (BenchmarkBuilderFactory):
2995 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
2996 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
2997 (GenericBenchmarkBuilder):
2998 (GenericBenchmarkBuilder.prepare):
2999 (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
3000 (GenericBenchmarkBuilder._applyPatch):
3001 (GenericBenchmarkBuilder.clean):
3002 * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
3003 (JetStreamBenchmarkBuilder):
3004 (JetStreamBenchmarkBuilder.prepare):
3005 (JetStreamBenchmarkBuilder._runCreateScript):
3006 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
3008 (BenchmarkRunner.__init__):
3009 (BenchmarkRunner.execute):
3010 (BenchmarkRunner.dump):
3011 (BenchmarkRunner.wrap):
3012 (BenchmarkRunner.merge):
3013 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
3014 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
3016 (BrowserDriver.prepareEnv):
3017 (BrowserDriver.launchUrl):
3018 (BrowserDriver.closeBrowser):
3019 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
3020 (BrowserDriverFactory):
3021 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
3022 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
3024 (OSXChromeDriver.prepareEnv):
3025 (OSXChromeDriver.launchUrl):
3026 (OSXChromeDriver.closeBrowsers):
3027 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
3029 (OSXSafariDriver.prepareEnv):
3030 (OSXSafariDriver.launchUrl):
3031 (OSXSafariDriver.closeBrowsers):
3032 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
3033 * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
3034 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
3035 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
3036 * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
3038 (GenericFactory.iterateGetItem):
3039 (GenericFactory.create):
3040 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
3041 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
3043 (ServerControl.render_GET):
3044 (ServerControl.render_POST):
3045 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
3047 (HTTPServerDriver.serve):
3048 (HTTPServerDriver.fetchResult):
3049 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
3050 (HTTPServerDriverFactory):
3051 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
3052 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
3053 (SimpleHTTPServerDriver):
3054 (SimpleHTTPServerDriver.depends):
3055 (SimpleHTTPServerDriver.__init__):
3056 (SimpleHTTPServerDriver.serve):
3057 (SimpleHTTPServerDriver.baseUrl):
3058 (SimpleHTTPServerDriver.fetchResult):
3059 * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
3060 (ModuleNotFoundError):
3062 (getPathFromProjectRoot):
3067 (timeout.handle_timeout):
3068 (timeout.__enter__):
3071 2015-04-24 Commit Queue <commit-queue@webkit.org>
3073 Unreviewed, rolling out r183303.
3074 https://bugs.webkit.org/show_bug.cgi?id=144181
3076 Change was incorrect, broke builds (Requested by smfr on
3082 http://trac.webkit.org/changeset/183303
3084 2015-04-24 Simon Fraser <simon.fraser@apple.com>
3088 * MiniBrowser/mac/WK2BrowserWindowController.m:
3089 (-[WK2BrowserWindowController initWithConfiguration:]):
3091 2015-04-24 Brent Fulgham <bfulgham@apple.com>
3093 Disable ActionMenusPDFTest due to timeout on test bot
3095 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3096 (TestWebKitAPI::TEST):
3098 2015-04-24 Commit Queue <commit-queue@webkit.org>
3100 Unreviewed, rolling out r183266.
3101 https://bugs.webkit.org/show_bug.cgi?id=144164
3103 Broke 32-bit build and a test. (Requested by ap on #webkit).
3107 "AX: richer text change notifications (142719)"
3108 https://bugs.webkit.org/show_bug.cgi?id=142719
3109 http://trac.webkit.org/changeset/183266
3111 2015-04-24 Brent Fulgham <bfulgham@apple.com>
3113 REGRESSION: WebKit2.ActionMenusTest API test fails
3114 https://bugs.webkit.org/show_bug.cgi?id=144149
3115 <rdar://problem/20677770>
3117 Reviewed by Tim Horton.
3119 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
3120 as the 'ActionMenusPDFTest'.
3121 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3122 (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
3123 to match the hit test on the 'action-menu-target.pdf' test file.
3125 2015-04-24 Daniel Bates <dabates@apple.com>
3127 Cleanup: Use @memoized for property IOSSimulator.testing_device
3128 https://bugs.webkit.org/show_bug.cgi?id=141715
3130 Reviewed by Darin Adler.
3132 Simplify the caching of the result of IOSSimulator.testing_device
3133 and make the code more readable by making use of the @memoized declarator
3134 instead of explicitly managing a private instance variable,
3135 IOSSimulator._testing_device, for the cached result.
3137 * Scripts/webkitpy/port/ios.py:
3138 (IOSPort.determine_full_port_name):
3139 (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
3141 (IOSSimulatorPort.testing_device): No need to cache the created device object in
3142 IOSSimulatorPort._testing_device since we are marking this function @memoized.
3143 (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
3144 of caching in local variable since we only make use of this value exactly once in this function.
3145 (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
3146 been used since being added in r178622. So, we can remove this constructor since
3147 it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
3149 2015-04-24 Anders Carlsson <andersca@apple.com>
3151 Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
3152 https://bugs.webkit.org/show_bug.cgi?id=144158
3154 Reviewed by Beth Dakin.
3156 * MiniBrowser/mac/WK2BrowserWindowController.m:
3157 (-[WK2BrowserWindowController initWithConfiguration:]):
3159 2015-04-24 Doug Russell <d_russell@apple.com>
3161 AX: richer text change notifications (142719)
3162 https://bugs.webkit.org/show_bug.cgi?id=142719
3164 Reviewed by Darin Adler.
3166 Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
3168 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
3170 * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
3171 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
3172 (-[AccessibilityNotificationHandler stopObserving]):
3173 (-[AccessibilityNotificationHandler _notificationReceived:]):
3174 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3175 (AccessibilityUIElement::removeNotificationListener):
3176 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3177 (-[AccessibilityNotificationHandler _notificationReceived:]):
3178 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3179 (WTR::AccessibilityUIElement::removeNotificationListener):
3181 2015-04-24 Darin Adler <darin@apple.com>
3183 Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
3184 https://bugs.webkit.org/show_bug.cgi?id=128007
3186 Reviewed by Anders Carlsson.
3188 * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
3189 * DumpRenderTree/win/UIDelegate.h: Ditto.
3191 * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
3192 * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
3194 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
3196 * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
3197 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
3198 * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
3199 (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
3200 * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3201 (WebKitDOMDOMWindowTest::create): Ditto.
3202 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3203 (documentLoadedCallback): Use a queue of DelayedSignal objects instead
3204 of smart pointers to DelayedSIgnal objects.
3205 (uriChangedCallback): Ditto.
3207 2015-04-24 Brent Fulgham <bfulgham@apple.com>
3209 [Mac] Unreviewed test fix.
3210 https://bugs.webkit.org/show_bug.cgi?id=144149
3212 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3213 (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
3216 2015-04-23 Darin Adler <darin@apple.com>
3218 Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
3219 https://bugs.webkit.org/show_bug.cgi?id=144090
3221 Reviewed by Anders Carlsson.
3223 * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
3225 2015-04-23 Michael Saboff <msaboff@apple.com>
3227 lldb macro btjs sometimes can't get a frame description
3228 https://bugs.webkit.org/show_bug.cgi?id=144130
3230 Reviewed by Filip Pizlo.
3232 We look to execute ExecState::describeFrame(). It appears that in some contexts the
3233 debugger can't find ExecState. In those cases, CallFrame works as it is a typedef of
3234 ExecState. Therefore we can fallback to using CallFrame::describeFrame().
3236 * lldb/lldb_webkit.py:
3239 2015-04-23 Alex Christensen <achristensen@webkit.org>
3241 Use less memory when compiling content extensions.
3242 https://bugs.webkit.org/show_bug.cgi?id=144051
3244 Reviewed by Darin Adler and Benjamin Poulain.
3246 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3247 (TestWebKitAPI::TEST_F):
3248 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3249 (TestWebKitAPI::countLiveNodes):
3251 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com>
3253 [CMake] Clean up JSC JIT options
3254 https://bugs.webkit.org/show_bug.cgi?id=143998
3256 Reviewed by Filip Pizlo.
3258 * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
3259 * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
3261 2015-04-21 Brent Fulgham <bfulgham@apple.com>
3263 [Mac] Extend action menus to support PDF
3264 https://bugs.webkit.org/show_bug.cgi?id=143895
3265 <rdar://problem/19003333>
3267 Reviewed by Tim Horton.
3269 Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
3270 of PDF content works.
3272 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
3273 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
3274 * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
3275 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
3276 (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
3277 Update to support PDF tests.
3278 (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
3279 (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
3281 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
3283 Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
3285 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3287 (testWebViewAudioOnlyUserMediaPermissionRequests):
3289 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com>
3291 Add myself to watchlist
3292 https://bugs.webkit.org/show_bug.cgi?id=144041
3294 Reviewed by Alex Christensen.
3296 Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
3298 * Scripts/webkitpy/common/config/watchlist:
3300 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
3302 [GTK] MiniBrowser should use NetworkProcess by default
3303 https://bugs.webkit.org/show_bug.cgi?id=143948
3305 Reviewed by Sergio Villar Senin.
3307 Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
3308 unless MINIBROWSER_SINGLEPROCESS environment variable is present.
3310 * MiniBrowser/gtk/main.c:
3313 2015-04-21 Matthew Hanson <matthew_hanson@apple.com>
3315 Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
3317 Unreviewed build fix.
3319 * Scripts/prepare-ChangeLog:
3320 (get_function_line_ranges_for_cpp):
3321 Use grep instead of any to determine if a string is an element of an array.
3323 2015-04-21 Anders Carlsson <andersca@apple.com>
3325 Fix block signatures
3326 https://bugs.webkit.org/show_bug.cgi?id=144002
3328 Reviewed by Andreas Kling.
3330 * MiniBrowser/mac/WK2BrowserWindowController.m:
3331 (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3333 2015-04-21 Philippe Normand <pnormand@igalia.com>
3335 [GTK] jhbuild should not use a branch for openwebrtc
3336 https://bugs.webkit.org/show_bug.cgi?id=143981
3338 Reviewed by Carlos Garcia Campos.
3340 * gtk/jhbuild.modules:
3342 2015-04-20 Matthew Hanson <matthew_hanson@apple.com>
3344 Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
3346 Unreviewed build fix.
3348 The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
3349 However, it has been exposed by List::MoreUtils since its inception. This patch uses
3350 the any function exposed by List::MoreUtils for greater compatibility.
3352 * Scripts/prepare-ChangeLog:
3353 Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
3354 the any function in all of versions of Perl used by our infrastructure.
3356 2015-04-20 Alex Christensen <achristensen@webkit.org>
3358 Remove unnecessary logs when resetting tests.
3360 * WebKitTestRunner/mac/TestControllerMac.mm:
3361 (WTR::TestController::platformResetPreferencesToConsistentValues):
3362 In r183020 I added some logs when compiling or removing content extensions fails.
3363 We often try to remove a content extension that does not exist, and that is not a problem.
3365 2015-04-17 Matthew Hanson <matthew_hanson@apple.com>
3367 prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
3368 https://bugs.webkit.org/show_bug.cgi?id=143897
3370 Reviewed by David Kilzer.
3372 This is a speculative fix that addresses two issues:
3374 1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
3375 We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
3377 So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
3381 Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
3382 Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
3384 This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
3385 to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
3387 The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
3389 2. Creating git diffs from HEAD and not origin/master by default.
3391 Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
3392 when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
3394 * Scripts/prepare-ChangeLog:
3396 Use HEAD instead of origin/master in default Git case.
3398 (generateFunctionLists):
3399 Ensure that the end line is not less than the start line.
3401 (extractLineRangeAfterChange):
3402 Set the end line to the start line if the end line is less than the start line.
3404 (extractLineRangeBeforeChange):
3407 2015-04-17 Matthew Hanson <matthew_hanson@apple.com>
3409 Suppress warning in prepare-ChangeLog.
3410 https://bugs.webkit.org/show_bug.cgi?id=143882
3412 Reviewed by David Kilzer.
3414 Prune noisy prepare-ChangeLog output by using the List::Util::any function
3415 instead of the deprecated smartmatch operator.
3417 * Scripts/prepare-ChangeLog:
3418 Import the List::Util::any function.
3420 (get_function_line_ranges_for_cpp):
3421 Use the any function instead of smartmatch.
3423 2015-04-20 Anders Carlsson <andersca@apple.com>
3425 Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
3426 https://bugs.webkit.org/show_bug.cgi?id=143966
3428 Reviewed by Dan Bernstein.
3430 * MiniBrowser/mac/WK2BrowserWindowController.m:
3432 (-[WK2BrowserWindowController fetchWebsiteData:]):
3433 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3434 (-[WK2BrowserWindowController clearWebsiteData:]):
3436 2015-04-20 Alex Christensen <achristensen@webkit.org>
3438 Fix content extension test flakiness.
3439 https://bugs.webkit.org/show_bug.cgi?id=143950
3441 Reviewed by Brady Eidson.
3443 * WebKitTestRunner/mac/TestControllerMac.mm:
3444 (WTR::TestController::platformResetPreferencesToConsistentValues):
3445 Remove the TestContentExtensions if it exists.
3446 (WTR::TestController::platformConfigureViewForTest):
3447 Log errors in case there are any.
3449 2015-04-20 Alex Christensen <achristensen@webkit.org>
3451 Properly report errors from _WKUserContentExtensionStore.
3452 https://bugs.webkit.org/show_bug.cgi?id=143808
3454 Reviewed by Darin Adler.
3456 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3459 2015-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
3461 Add a rule for NetworkCache to watchlist file
3462 https://bugs.webkit.org/show_bug.cgi?id=143945
3464 Reviewed by Sergio Villar Senin.
3466 And add myself to the list of watchers.
3468 * Scripts/webkitpy/common/config/watchlist:
3470 2015-04-19 Darin Adler <darin@apple.com>
3472 Update RefPtr documentation and deprecation
3473 https://bugs.webkit.org/show_bug.cgi?id=143936
3475 Reviewed by Andreas Kling.
3477 * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
3479 2015-04-19 Yusuke Suzuki <utatane.tea@gmail.com>
3481 Introduce bytecode intrinsics
3482 https://bugs.webkit.org/show_bug.cgi?id=143926
3484 Reviewed by Filip Pizlo.
3486 Change cpplint to accept emit_intrinsic_XXX.
3488 * Scripts/webkitpy/style/checkers/cpp.py:
3489 (check_identifier_name_in_declaration):
3491 2015-04-18 Simon Fraser <simon.fraser@apple.com>
3493 Fix lldb_webkit.py to show StringImpls correctly
3494 https://bugs.webkit.org/show_bug.cgi?id=143920
3496 Reviewed by Andreas Kling.
3498 Update WTFStringImplProvider's is_8bit to use the correct bitmask.
3500 * lldb/lldb_webkit.py:
3501 (WTFStringImplProvider.is_8bit):
3503 2015-04-17 Daniel Bates <dabates@apple.com>
3505 Not able to build WebKit against iOS Simulator 8.3 SDK
3506 https://bugs.webkit.org/show_bug.cgi?id=143883
3508 Reviewed by David Kilzer.
3510 Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
3511 so that Xcode uses them.
3513 * Scripts/copy-webkitlibraries-to-product-directory:
3515 2015-04-17 Beth Dakin <bdakin@apple.com>
3517 Force mouse events should go through normal mouse event handling code paths
3518 https://bugs.webkit.org/show_bug.cgi?id=143749
3520 rdar://problem/20472895
3522 Reviewed by Dean Jackson.
3524 Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner.
3525 Since there is not a way to create an NSEventTypePressure from scratch, we
3526 subclass NSEvent and override all of the critical methods.
3528 * WebKitTestRunner/EventSenderProxy.h:
3529 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3530 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3531 (WTR::EventSendingController::mouseForceDown):
3532 (WTR::EventSendingController::mouseForceUp):
3533 (WTR::EventSendingController::mouseForceChanged):
3534 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3535 * WebKitTestRunner/TestController.cpp:
3536 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3537 * WebKitTestRunner/mac/EventSenderProxy.mm:
3538 (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3539 (-[EventSenderPressureEvent timestamp]):
3540 (-[EventSenderPressureEvent type]):
3541 (-[EventSenderPressureEvent locationInWindow]):
3542 (-[EventSenderPressureEvent location]):
3543 (-[EventSenderPressureEvent stage]):
3544 (-[EventSenderPressureEvent pressure]):
3545 (-[EventSenderPressureEvent phase]):
3546 (-[EventSenderPressureEvent eventNumber]):
3547 (WTR::EventSenderProxy::mouseForceDown):
3548 (WTR::EventSenderProxy::mouseForceUp):
3549 (WTR::EventSenderProxy::mouseForceChanged):
3551 2015-04-17 Alexey Proskuryakov <ap@apple.com>
3553 build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
3554 https://bugs.webkit.org/show_bug.cgi?id=143885
3556 Reviewed by Tim Horton.
3558 Fixed a case where we have two builds with the same revision(s). An in order build
3559 is one for which the revision is strictly higher.
3561 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3562 (BuildbotQueue.prototype._checkForInOrderResult):
3563 (BuildbotQueue.prototype.compareIterationsByRevisions):
3565 2015-04-17 Commit Queue <commit-queue@webkit.org>
3567 Unreviewed, rolling out r182912 and r182920.
3568 https://bugs.webkit.org/show_bug.cgi?id=143881
3570 Build breakage in some configurations (Requested by ap on
3573 Reverted changesets:
3575 "Force mouse events should go through normal mouse event
3576 handling code paths"
3577 https://bugs.webkit.org/show_bug.cgi?id=143749
3578 http://trac.webkit.org/changeset/182912
3580 http://trac.webkit.org/changeset/182920
3582 2015-04-17 Csaba Osztrogonác <ossy@webkit.org>
3584 [GTK] One more unreviewed fix after r182882.
3586 * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
3588 2015-04-17 Csaba Osztrogonác <ossy@webkit.org>
3590 [GTK] Unreviewed speculative clean build fix after r182882.
3592 TestWebKitAPI's forwarding header generator depended on WeKit2's
3593 which generated SOUP related forwarding headers too.
3595 This dependency isn't necessary and was removed by r182882 to make
3596 forwarding header generators parallelizable. But in this case
3597 TestWebKitAPI's and WebKitTestRunner's forwarding header generator
3598 should generate SOUP related forwarding headers too similar to EFL.
3600 * TestWebKitAPI/PlatformGTK.cmake:
3601 * WebKitTestRunner/PlatformGTK.cmake:
3603 2015-04-17 Carlos Garcia Campos <cgarcia@igalia.com>
3605 [SOUP] Redirect to non HTTP destination is broken
3606 https://bugs.webkit.org/show_bug.cgi?id=143866
3608 Reviewed by Sergio Villar Senin.
3610 Add a unit test to check that redirect to a data URI works.
3612 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3613 (testRedirectToDataURI):
3617 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com>
3619 Changes method of quitting iOS Simulator to be more correct.
3620 https://bugs.webkit.org/show_bug.cgi?id=143847
3621 <rdar://problem/20530344>
3623 Reviewed by Darin Adler.
3625 Fixes by addressing the app by ID rather than by name.
3627 * Scripts/webkitdirs.pm:
3629 * Scripts/webkitpy/port/ios.py:
3630 (IOSSimulatorPort.check_sys_deps):
3632 2015-04-16 Anders Carlsson <andersca@apple.com>
3634 Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
3635 https://bugs.webkit.org/show_bug.cgi?id=143844
3637 Reviewed by Dan Bernstein.
3639 * MiniBrowser/mac/AppDelegate.m:
3640 (-[BrowserAppDelegate newPrivateWindow:]):
3641 * MiniBrowser/mac/WK2BrowserWindowController.m:
3642 (-[WK2BrowserWindowController initWithConfiguration:]):
3643 (-[WK2BrowserWindowController fetchWebsiteData:]):
3644 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3645 (-[WK2BrowserWindowController clearWebsiteData:]):
3647 2015-04-16 Alex Christensen <achristensen@webkit.org>
3651 * WebKitTestRunner/mac/TestControllerMac.mm:
3652 (WTR::TestController::platformResetPreferencesToConsistentValues):
3653 (WTR::TestController::platformConfigureViewForTest):
3654 Added WK_API_ENABLED.
3656 2015-04-16 Alex Christensen <achristensen@webkit.org>
3658 Removed unused WKUserContentFilterRef.
3659 https://bugs.webkit.org/show_bug.cgi?id=143852
3661 Reviewed by Sam Weinig.
3663 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3664 * WebKitTestRunner/mac/TestControllerMac.mm:
3665 (WTR::TestController::platformResetPreferencesToConsistentValues):
3666 (WTR::TestController::platformConfigureViewForTest):
3668 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com>
3670 Unreviewed. Adding myself as a commiter in contributers.json.
3672 * Scripts/webkitpy/common/config/contributors.json:
3674 2015-04-16 Alexey Proskuryakov <ap@apple.com>
3676 It is very hard to attach a debugger to WebProcess to debug tests
3677 https://bugs.webkit.org/show_bug.cgi?id=143837