Remove a FIXME comment that is already fixed.
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
2
3         Remove a FIXME comment that is already fixed.
4         https://bugs.webkit.org/show_bug.cgi?id=127468
5
6         Reviewed by Csaba Osztrogonác.
7
8         * Scripts/webkitpy/style/filereader.py:
9         (TextFileReader.__init__):
10
11 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
12
13         [GLIB] Use GUniquePtr instead of GOwnPtr
14         https://bugs.webkit.org/show_bug.cgi?id=127431
15
16         Reviewed by Martin Robinson.
17
18         GUniquePtr is a template alias of std::unique_ptr with a custom
19         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
20         where the output pointer is needed, but it will also be replaced soon.
21
22         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
23         (printAccessibilityEvent):
24         (axObjectEventListener):
25         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
26         (indexRangeInTable):
27         (AccessibilityUIElement::role):
28         (AccessibilityUIElement::title):
29         (AccessibilityUIElement::description):
30         (AccessibilityUIElement::stringValue):
31         (AccessibilityUIElement::language):
32         (AccessibilityUIElement::lineForIndex):
33         (AccessibilityUIElement::selectedTextRange):
34         (AccessibilityUIElement::url):
35         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
36         (AccessibilityController::accessibleElementById):
37         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
38         (AccessibilityController::accessibleElementById):
39         * DumpRenderTree/gtk/DumpRenderTree.cpp:
40         (getOutputDir):
41         (getFontsPath):
42         (initializeFonts):
43         (dumpFramesAsText):
44         (compareHistoryItems):
45         (dumpHistoryItem):
46         (soupURIToStringPreservingPassword):
47         (resetDefaultsToConsistentValues):
48         (temporaryDatabaseDirectory):
49         (webViewTitleChanged):
50         (webFrameLoadStatusNotified):
51         (pathFromSoupURI):
52         (convertWebResourceToURLPath):
53         (urlSuitableForTestResult):
54         (descriptionSuitableForTestResult):
55         (willSendRequestCallback):
56         (frameLoadEventCallback):
57         * DumpRenderTree/gtk/EditingCallbacks.cpp:
58         (dumpNodePath):
59         (dumpRange):
60         (shouldApplyStyle):
61         * DumpRenderTree/gtk/EventSender.cpp:
62         (contextClickCallback):
63         (beginDragWithFilesCallback):
64         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
65         (TestRunner::pathToLocalResource):
66         (TestRunner::queueLoad):
67         (TestRunner::removeOriginAccessWhitelistEntry):
68         (TestRunner::setMockGeolocationPositionUnavailableError):
69         (TestRunner::setIconDatabaseEnabled):
70         (TestRunner::findString):
71         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
72         (TestRunner::overridePreference):
73         (TestRunner::addUserScript):
74         (TestRunner::addUserStyleSheet):
75         (TestRunner::setTextDirection):
76         * DumpRenderTree/gtk/TextInputController.cpp:
77         (setMarkedTextCallback):
78         (insertTextCallback):
79         (doCommandCallback):
80         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
81         (LoadHTMLStringItem::invoke):
82         * TestWebKitAPI/PlatformGTK.cmake:
83         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
84         (WebKitDOMNodeTest::testTagNames):
85         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
86         (testBackForwardListLimitAndCache):
87         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
88         (testContextMenuSmartSeparators):
89         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
90         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
91         (testDownloadLocalFile):
92         (testDownloadLocalFileError):
93         (addContentDispositionHTTPHeaderToResponse):
94         (serverCallback):
95         (testDownloadRemoteFileError):
96         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
97         (startTestServer):
98         (testInspectorServerPageList):
99         (openRemoteDebuggingSession):
100         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
101         (testPrintOperationPrint):
102         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
103         (addCacheHTTPHeadersToResponse):
104         (serverCallback):
105         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
106         (httpsServerCallback):
107         (httpServerCallback):
108         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
109         (testWebViewJavaScriptDialogs):
110         (testWebViewWindowProperties):
111         (testWebViewFileChooserRequest):
112         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
113         (testWebExtensionWindowObjectCleared):
114         (testWebExtensionIsolatedWorld):
115         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
116         (startTestServer):
117         (checkAtspiAccessible):
118         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
119         (serverCallback):
120         (testClearDatabase):
121         (testGetFaviconURI):
122         (webkitFaviconDatabaseFinalizedCallback):
123         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
124         (testWebContextGetPlugins):
125         (testWebContextURIScheme):
126         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
127         (testWebViewRunJavaScript):
128         (testWebViewMode):
129         (testWebViewPageVisibility):
130         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
131         (isStyleSheetInjectedForURLAtPath):
132         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
133         (testWebViewEditorCutCopyPasteNonEditable):
134         (testWebViewEditorCutCopyPasteEditable):
135         (testWebViewEditorSelectAllNonEditable):
136         (testWebViewEditorSelectAllEditable):
137         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
138         (sendRequestCallback):
139         (methodCallCallback):
140         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
141         (TestWebKitAPI::Util::createInjectedBundlePath):
142         (TestWebKitAPI::Util::createURLForResource):
143         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
144         (TestWebKitAPI::doKeyStroke):
145         (TestWebKitAPI::doMouseButtonEvent):
146         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
147         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
148         (loadFailedCallback):
149         (LoadTrackingTest::loadURI):
150         (LoadTrackingTest::loadHtml):
151         (LoadTrackingTest::loadPlainText):
152         (LoadTrackingTest::loadRequest):
153         (LoadTrackingTest::reload):
154         (LoadTrackingTest::goBack):
155         (LoadTrackingTest::goForward):
156         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
157         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
158         (registerGResource):
159         (removeNonEmptyDirectory):
160         (main):
161         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
162         (Test::getWebKit1TestResoucesDir):
163         (Test::getResourcesDir):
164         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
165         (WebKitTestBus::run):
166         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
167         (WebKitTestServer::WebKitTestServer):
168         (WebKitTestServer::getURIForPath):
169         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
170         (WebProcessTestRunner::runTest):
171         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
172         (resourceGetDataCallback):
173         (WebViewTest::mainResourceData):
174         (WebViewTest::mouseMoveTo):
175         (WebViewTest::keyStroke):
176         (WebViewTest::doMouseButtonEvent):
177         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
178         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
179         (WTR::AccessibilityController::accessibleElementById):
180         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
181         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
182         (WTR::AccessibilityUIElement::role):
183         (WTR::AccessibilityUIElement::title):
184         (WTR::AccessibilityUIElement::description):
185         (WTR::AccessibilityUIElement::stringValue):
186         (WTR::AccessibilityUIElement::language):
187         (WTR::AccessibilityUIElement::lineForIndex):
188         (WTR::AccessibilityUIElement::selectedTextRange):
189         (WTR::AccessibilityUIElement::url):
190         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
191         (WTR::getOutputDir):
192         (WTR::getFontsPath):
193         (WTR::initializeFontConfigSetting):
194         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
195         (WTR::topLevelPath):
196         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
197         (WTR::TestRunner::pathToLocalResource):
198         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
199         (WTR::TestController::initializeInjectedBundlePath):
200         (WTR::TestController::initializeTestPluginDirectory):
201
202 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
203
204         [GTK] [CMake] run-webkit-tests should support the CMake build
205         https://bugs.webkit.org/show_bug.cgi?id=126503
206
207         Reviewed by Daniel Bates.
208
209         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
210         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
211
212         * Scripts/run-launcher: Work properly with the gtkcmake flag.
213         * Scripts/webkitpy/port/gtk.py:
214         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
215         file to detect a CMake build.
216         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
217         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
218         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
219         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
220         (GtkPort._path_to_driver): Use the new helper.
221         (GtkPort._path_to_image_diff): Use the new helper.
222         (GtkPort._path_to_webcore_library): Use the new helper.
223         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
224
225 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
226
227         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
228         https://bugs.webkit.org/show_bug.cgi?id=127417
229
230         Reviewed by Gyuyoung Kim.
231
232         * EWebLauncher/main.c:
233         (on_key_down): Removed shortcut to test pre render.
234
235 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
236
237         Remove CSS3_TEXT_DECORATION define
238         https://bugs.webkit.org/show_bug.cgi?id=127333
239
240         This is required for unprefixing the text-decoration-* CSS properties.
241
242         Reviewed by Simon Fraser.
243
244         * Configurations/FeatureDefines.xcconfig:
245
246 2014-01-22  Andy Estes  <aestes@apple.com>
247
248         [iOS] Prepare for upstreaming DumpRenderTree changes
249         https://bugs.webkit.org/show_bug.cgi?id=127412
250
251         Reviewed by Simon Fraser.
252
253         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
254         an application bundle. Instead of upstreaming a separate target for the
255         app that duplicates the 'Compile Sources' phase of the tool, separate
256         out the compilation into a static library target that both the
257         command-line tool and the app can link against. Also, perform some
258         unrelated cleanup.
259
260         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
261         project file format from 2.4- to 3.2-compatible. Removed the
262         'Copy Headers' build phase and removed all files from the
263         'Compile Sources' build phase of DumpRenderTree. Added some files that
264         were missing from the project. Created a 'DumpRenderTree (Library)'
265         target for building the static library and made the 'DumpRenderTree'
266         target depend on it. Added a 'Compile Sources' build phase to this
267         target that builds the same files the DumpRenderTree target used to.
268         Created DumpRenderTreeMain.mm as the only source file of the
269         DumpRenderTree target, since targets won't link a binary without at
270         least one source file. Made DumpRenderTree (Library) use
271         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
272         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
273         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
274         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
275         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
276         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
277         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
278         This is needed to correctly link a static library containing an Objective-C
279         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
280         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
281         * DumpRenderTree/mac/DumpRenderTree.mm:
282         (DumpRenderTreeMain): Renamed from main.
283         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
284         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
285         (main): Called DumpRenderTreeMain from main.
286
287 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
288
289         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
290         https://bugs.webkit.org/show_bug.cgi?id=127073
291
292         Reviewed by Daniel Bates.
293
294         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
295         the new isCMakeBuild conditional. This allows us to share more code between ports.
296         Pass the build arguments to the removeCMakeCache function.
297         * Scripts/webkitdirs.pm:
298         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
299         because it's now shared with the CMake build.
300         (cachedArgumentFileOutOfDate): Renamed.
301         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
302         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
303         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
304         as well as checking if build-webkit has been run with different arguments.
305         (removeCMakeCache): Call shouldRemoveCMakeCache now.
306         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
307         (isCMakeBuild): Added.
308
309 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
310
311         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
312         https://bugs.webkit.org/show_bug.cgi?id=127119
313
314         Reviewed by Mario Sanchez Prada.
315
316         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
317
318         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
319         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
320         * DumpRenderTree/gtk/DumpRenderTree.cpp:
321         (resetDefaultsToConsistentValues):
322         (webViewWindowObjectCleared):
323         (main):
324         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
325         (WTR::AccessibilityController::platformName):
326         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
327         (WTR::AccessibilityUIElement::isIndeterminate):
328
329 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
330
331
332         [GTK] Add GUniquePtr
333         https://bugs.webkit.org/show_bug.cgi?id=127170
334
335         Reviewed by Gustavo Noronha Silva.
336
337         Add unit tests for GUniquePtr.
338
339         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
340         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
341         (log):
342         (takeLogStr):
343         (TestWebKitAPI::TEST):
344
345 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
346
347         Remove Nix files from Tools
348         https://bugs.webkit.org/show_bug.cgi?id=127418
349
350         Reviewed by Csaba Osztrogonác.
351
352         * Scripts/build-webkit:
353         * Scripts/update-webkit-libs-jhbuild:
354         * Scripts/webkitdirs.pm:
355         (determineArchitecture):
356         (argumentsForConfiguration):
357         (jscProductDir):
358         (builtDylibPathForName):
359         (isAppleWebKit):
360         (launcherPath):
361         (launcherName):
362         (checkRequiredSystemConfig):
363         (copyInspectorFrontendFiles):
364         (jhbuildWrapperPrefixIfNeeded):
365         (buildCMakeProjectOrExit):
366         (cmakeBasedPortName):
367         * Scripts/webkitpy/common/config/ports.py:
368         (DeprecatedPort.port):
369         (EflWK2Port.build_webkit_command):
370         * Scripts/webkitpy/port/factory.py:
371         (platform_options):
372         (PortFactory):
373         * Scripts/webkitpy/port/nix.py: Removed.
374         * Scripts/webkitpy/port/nix_unittest.py: Removed.
375
376 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
377
378         Add Ian and Ricky to the contributor list
379
380         * Scripts/webkitpy/common/config/contributors.json:
381         I am too old to remember all those email addresses :)
382
383 2014-01-21  David Farler  <dfarler@apple.com>
384
385         Upstream package-root for iOS
386
387         Reviewed by Daniel bates.
388
389         * Scripts/package-root: Added.
390         (usage):
391         * Scripts/webkitdirs.pm:
392         (XcodeSDKPath): Added function.
393
394 2014-01-21  Daniel Bates  <dabates@apple.com>
395
396         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
397         https://bugs.webkit.org/show_bug.cgi?id=127368
398
399         Reviewed by Tim Horton.
400
401         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
402         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
403         Tools.
404
405         * Makefile:
406
407 2014-01-21  Daniel Bates  <dabates@apple.com>
408
409         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
410         https://bugs.webkit.org/show_bug.cgi?id=127364
411
412         Reviewed by Simon Fraser.
413
414         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
415         projects fail to build because we need to upstream the relevant iOS changes.
416         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
417         aren't building TestWebKitAPI.
418
419         * Scripts/build-webkit:
420
421 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
422
423         Unreviewed, remove myself from some watchlist entries.
424
425         * Scripts/webkitpy/common/config/watchlist:
426
427 2014-01-21  Zalan Bujtas  <zalan@apple.com>
428
429         Use 64 as the default value for the subpixel denominator.
430
431         Reviewed by Simon Fraser.
432
433         * lldb/lldb_webkit.py:
434         (WebCoreLayoutUnitProvider.to_string):
435
436 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
437
438         [GTK] Fix a c++11 compliance issue for fontconfig
439         https://bugs.webkit.org/show_bug.cgi?id=127283
440
441         Reviewed by Martin Robinson.
442
443         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
444         hotfix until bumping fontconfig up.
445
446         * gtk/jhbuild.modules:
447         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
448
449 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
450
451         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
452         like run_webkit_test does
453         https://bugs.webkit.org/show_bug.cgi?id=127349
454
455         Reviewed by Csaba Osztrogonác.
456
457         * Scripts/run-jsc-stress-tests:
458
459 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
460
461         [GTK] Allow passing extra data to web extensions
462         https://bugs.webkit.org/show_bug.cgi?id=125990
463
464         Reviewed by Carlos Garcia Campos.
465
466         Allow passing additional information to the injected bundle. On top
467         of the string containing the path to the web extensions directory,
468         a GVariant can be set with additional data using
469         webkit_web_context_set_web_extensions_initialization_user_data().
470         Also, a new initialize-web-extensions signal is emitted before
471         launching a new WebProcess to allow setting different user data
472         for each process. The GVariant is serialized as a string, passed
473         to the injected bundle, and the injected bundle deserializes back
474         the data, which is passed to web extensions which define the
475         webkit_web_extension_initialize_with_user_data() function (for
476         backwards compatibility, webkit_web_extension_initialize() is
477         used as a fallback.)
478
479         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
480         (initializeWebExtensions): Handles the initialize-web-extensions
481         signal, and sets the web extensions directory and the initialization
482         user data.
483         (testWebExtensionInitializationUserData): New test case for checking
484         the user data passed on initialization to web extensions.
485         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
486         (methodCallCallback): Added implementation for the
487         GetInitializationUserData D-Bus method, used by
488         testWebExtensionInitializationUserData().
489         (webkit_web_extension_initialize_with_user_data): Define the
490         initialization function with the additional user data parameter.
491
492 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
493
494         Change my email address in contributors.json.
495
496         Unreviewed.
497
498         * Scripts/webkitpy/common/config/contributors.json:
499
500 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
501
502         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
503         https://bugs.webkit.org/show_bug.cgi?id=127291
504
505         Reviewed by Mario Sanchez Prada.
506
507         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
508
509         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
510         (AccessibilityUIElement::ariaFlowToElementAtIndex):
511         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
512         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
513
514 2014-01-20  Zalan Bujtas  <zalan@apple.com>
515
516         Force float division when calculating CSS px value.
517
518         Reviewed by Simon Fraser.
519
520         Note that in Python 3, this is the default behavior.
521
522         * lldb/lldb_webkit.py:
523         (WebCoreLayoutUnitProvider.to_string):
524
525 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
526
527         build.webkit.org/dashboard should display information about patches in EWS
528         https://bugs.webkit.org/show_bug.cgi?id=127006
529
530         Reviewed by Ryosuke Niwa.
531
532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
533         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
534         (Bugzilla.prototype.detailsURLForAttachment):
535         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
536         which is needed when one wants to do something with a patch EWS is stuck on.
537
538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
539         Create a Bugzilla instance.
540
541         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
542         (EWS.prototype.jsonQueueLengthURL):
543         (EWS.prototype.jsonQueueStatusURL):
544         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
545
546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
547         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
548         of second guessing.
549         (EWSQueue.prototype.get chartsPageURL): Added.
550         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
551         additional data already loaded (it's reset with every update).
552         (EWSQueue.prototype.get patches): Get patch queue.
553         (EWSQueue.prototype.get bots): Get bots.
554         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
555         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
556
557         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
558         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
559         in the queue.
560         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
561         (EWSQueueView.prototype.addTextToRow): Ditto.
562         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
563         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
564         (EWSQueueView.prototype._addDividerToPopover): Ditto.
565         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
566         relative string.
567         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
568         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
569         it when done.
570
571         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
572         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
573         Changed a few difficult to read padding styles to padding-left.
574
575 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
576
577         Fix webkitpy tests.
578
579         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
580         Added a mock implementation, as we now call this function.
581
582 2014-01-20  Darin Adler  <darin@apple.com>
583
584         Update style checker and tests to deal with override instead of OVERRIDE
585         https://bugs.webkit.org/show_bug.cgi?id=127175
586
587         Reviewed by Anders Carlsson.
588
589         * Scripts/webkitpy/style/checkers/cpp.py:
590         (check_braces): Use override instead of OVERRIDE.
591         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
592         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
593
594 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
595
596         EWS should provide better information to Dashboard via JSON
597         https://bugs.webkit.org/show_bug.cgi?id=127265
598
599         Reviewed by Ryosuke Niwa.
600
601         * QueueStatusServer/app.yaml: Updated version.
602
603         * QueueStatusServer/main.py:
604         * QueueStatusServer/handlers/queuelengthjson.py:
605         Added a way to cheaply get only the queue length, which is all the dashboard
606         needs unless a popover is opened.
607
608         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
609         that we will need. Changed some field names to be more meaningful. Fixed bot listing
610         to understand that a bot can be reprurposed and used in a different queue.
611
612 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
613
614         Make uploading results to EWS work despite robots.txt
615         https://bugs.webkit.org/show_bug.cgi?id=127296
616
617         Reviewed by Ryosuke Niwa.
618
619         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
620         checking robots.txt.
621
622         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
623         Removed a comment saying that we would want to stop doing this. Not checking
624         robots.txt is more efficient than checking it.
625
626 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
627
628         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
629         https://bugs.webkit.org/show_bug.cgi?id=127214
630
631         Reviewed by Gyuyoung Kim.
632
633         Followed the changes of API.
634
635         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
636         (drtViewAdd):
637         * EWebLauncher/main.c:
638         (windowCreate):
639
640 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
641
642         [EFL][WK2] Add touch events option to MiniBrowser.
643         https://bugs.webkit.org/show_bug.cgi?id=127262
644
645         Reviewed by Gyuyoung Kim.
646
647         As a default, touch events are disabled and mouse events are enabled.
648         If touch events option sets to true, touch events are enabled and mouse
649         events are disabled.
650
651         * MiniBrowser/efl/main.c:
652         (window_create):
653         (elm_main):
654
655 2014-01-19  Zalan Bujtas  <zalan@apple.com>
656
657         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
658         https://bugs.webkit.org/show_bug.cgi?id=126080
659
660         Reviewed by Sam Weinig.
661
662         This changes the output of printing LayoutUnits to be in px but it also
663         preserves the original LayoutUnit value.
664
665         This will lead to lldb output like: (and it works even when subpixel is disabled)
666
667         (const WebCore::LayoutRect) $0 = {
668             m_location = { x = 2.25px (144), y = 1px (64)}
669             m_size = { width = 13.75px (880), height = 20px (1280) }
670
671
672         And gdb output like:
673
674         m_frameRect = {
675             m_location = LayoutPoint(0px (0), 0px(0)),
676             m_size = LayoutSize(8px (512), 5px (320))
677         }
678
679         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
680
681         * gdb/webkit.py:
682         (WebCoreLayoutUnitPrinter):
683         (WebCoreLayoutUnitPrinter.__init__):
684         (WebCoreLayoutUnitPrinter.to_string):
685         (WebCoreLayoutSizePrinter):
686         (WebCoreLayoutSizePrinter.__init__):
687         (WebCoreLayoutSizePrinter.to_string):
688         (WebCoreLayoutPointPrinter):
689         (WebCoreLayoutPointPrinter.__init__):
690         (WebCoreLayoutPointPrinter.to_string):
691         (add_pretty_printers):
692         * lldb/lldb_webkit.py:
693         (__lldb_init_module):
694         (WebCoreLayoutUnit_SummaryProvider):
695         (WebCoreLayoutSize_SummaryProvider):
696         (WebCoreLayoutPoint_SummaryProvider):
697         (WebCoreLayoutUnitProvider):
698         (WebCoreLayoutUnitProvider.__init__):
699         (WebCoreLayoutUnitProvider.to_string):
700         (WebCoreLayoutSizeProvider):
701         (WebCoreLayoutSizeProvider.__init__):
702         (WebCoreLayoutSizeProvider.get_width):
703         (WebCoreLayoutSizeProvider.get_height):
704         (WebCoreLayoutPointProvider):
705         (WebCoreLayoutPointProvider.__init__):
706         (WebCoreLayoutPointProvider.get_x):
707         (WebCoreLayoutPointProvider.get_y):
708
709 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
710
711         Add robots.txt to http://webkit-queues.appspot.com
712         https://bugs.webkit.org/show_bug.cgi?id=127240
713
714         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
715
716 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
717
718         Add robots.txt to http://webkit-queues.appspot.com
719         https://bugs.webkit.org/show_bug.cgi?id=127240
720
721         Reviewed by Ryosuke Niwa.
722
723         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
724
725         * QueueStatusServer/robots.txt: Added.
726
727 2014-01-18  Alberto Garcia  <berto@igalia.com>
728
729         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
730         https://bugs.webkit.org/show_bug.cgi?id=127217
731
732         Reviewed by Daniel Bates.
733
734         The syntax File::Temp->tempdir() was explicitly made invalid
735         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
736         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
737
738         Use File::Temp::tempdir() instead.
739
740         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
741
742 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
743
744         build.webkit.org/dashboard should have image diff links in test results popovers
745         https://bugs.webkit.org/show_bug.cgi?id=127188
746
747         Reviewed by Timothy Hatcher.
748
749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
750         (Buildbot.prototype.layoutTestImagesURLForIteration):
751         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
753         (BuildbotIteration.prototype.loadLayoutTestResults):
754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
755         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
756         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
757         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
758
759 2014-01-18  Anders Carlsson  <andersca@apple.com>
760
761         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
762         https://bugs.webkit.org/show_bug.cgi?id=127225
763
764         Reviewed by Andreas Kling.
765
766         This concludes the removal of over 8.8 million lines of threaded parser code.
767
768         * Scripts/webkitperl/FeatureList.pm:
769
770 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
771
772         build.webkit.org/dashboard should have diff links in test results popovers
773         https://bugs.webkit.org/show_bug.cgi?id=126986
774
775         Reviewed by Tim Horton.
776
777         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
778         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
779         (Buildbot.prototype.layoutTestStderrURLForIteration):
780         (Buildbot.prototype.layoutTestDiffURLForIteration):
781         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
783         (BuildbotIteration.prototype.loadLayoutTestResults):
784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
785         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
786
787 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
788
789         Add the bare minimum support for branches to the bot-watchers dashboard
790         https://bugs.webkit.org/show_bug.cgi?id=127124
791
792         This patch simply introduces the notion of branches into the bot-watchers dashboard.
793         Subsequent patches will build functionality on top of this simple bit of infrastructure.
794
795         Reviewed by Timothy Hatcher.
796
797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
798         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
800         Initialize the Dashboard.Branch object
801
802 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
803
804         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
805         https://bugs.webkit.org/show_bug.cgi?id=127141
806
807         Reviewed by Alexey Proskuryakov.
808
809         Make sure to reset the notification handler each time.
810
811         * DumpRenderTree/AccessibilityController.cpp:
812         (AccessibilityController::resetToConsistentState):
813         * DumpRenderTree/AccessibilityController.h:
814         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
815         (AccessibilityController::platformResetToConsistentState):
816         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
817         (AccessibilityController::platformResetToConsistentState):
818         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
819         (AccessibilityController::~AccessibilityController):
820         (AccessibilityController::platformResetToConsistentState):
821         (AccessibilityController::removeNotificationListener):
822         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
823         (AccessibilityController::platformResetToConsistentState):
824
825 2014-01-17  Alberto Garcia  <berto@igalia.com>
826
827         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
828         https://bugs.webkit.org/show_bug.cgi?id=82329
829
830         Reviewed by Carlos Garcia Campos.
831
832         Unskip, this is working fine now.
833
834         * Scripts/run-gtk-tests:
835         (TestRunner):
836
837 2014-01-17  Alberto Garcia  <berto@igalia.com>
838
839         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
840         https://bugs.webkit.org/show_bug.cgi?id=82328
841
842         Reviewed by Carlos Garcia Campos.
843
844         This was caused by the icon database being corrupted in the
845         Release bot. After removing it the test works fine so it can be
846         run again.
847
848         * Scripts/run-gtk-tests:
849         (TestRunner):
850
851 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
852
853         Test results popovers at http://build.webkit.org/dashboard should link to stderr
854         https://bugs.webkit.org/show_bug.cgi?id=126929
855
856         Reviewed by Timothy Hatcher.
857
858         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
859         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
860         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
861
862         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
863         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
864
865         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
866         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
867         Add a link to stderr output if present.
868
869         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
870         (.test-results-popover .additional-link): Style with light grey (will use the same style
871         for diff links).
872
873 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
874
875         Automate DoYouEvenBench
876         https://bugs.webkit.org/show_bug.cgi?id=124497
877
878         Reviewed by Geoffrey Garen.
879
880         * Scripts/webkitpy/performance_tests/perftest.py:
881         (PerfTestMetric.__init__): Added the aggregator name as an argument.
882         (PerfTestMetric.aggregator): Added.
883         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
884         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
885         should be parsed as the metric and the aggregator respectively.
886         (PerfTest._run_with_driver): Pass in the aggregator name.
887         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
888         which generates subtests of subtests within a single test file.
889
890         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
891         (test_parse_output_with_subtests_and_total): Added.
892
893         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
894         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
895
896         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
897         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
898
899 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
900
901         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
902         https://bugs.webkit.org/show_bug.cgi?id=127141
903
904         Reviewed by Alexey Proskuryakov.
905
906         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
907
908         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
909         (AccessibilityController::~AccessibilityController):
910
911 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
912
913         EWS shouldn't comment on Bugzilla for failing builds or style errors
914         https://bugs.webkit.org/show_bug.cgi?id=127079
915
916         Reviewed by Anders Carlsson.
917
918         Since patch authors and reviewers could retrieve this information from bubbles,
919         we shouldn't spam the Bugzilla with useless comments.
920
921         We still post style errors but not python paths we used since it's a pure noise.
922
923         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
924         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
925         * Scripts/webkitpy/tool/commands/queues.py:
926         (StyleQueue.review_patch):
927
928 2014-01-15  Roger Fong  <roger_fong@apple.com>
929
930         Add support for handling WebGL load policies.
931         https://bugs.webkit.org/show_bug.cgi?id=126935
932         <rdar://problem/15790448>.
933
934         Reviewed by Timothy Horton.
935
936         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
937         (WTR::TestController::createWebViewWithOptions):
938
939 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
940
941         Remove workaround for compilers not supporting explicit override control
942         https://bugs.webkit.org/show_bug.cgi?id=127111
943
944         Reviewed by Anders Carlsson.
945
946         Now all compilers support explicit override control, this workaround can be removed.
947
948         * DumpRenderTree/gtk/fonts/fonts.conf:
949         * Scripts/do-webcore-rename:
950         Removed this rename operation from the list of contemplated future renames.
951         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
952         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
953         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
954         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
955         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
956
957 2014-01-16  Oliver Hunt  <oliver@apple.com>
958
959         Stop run-jsc from consuming stderr output
960         https://bugs.webkit.org/show_bug.cgi?id=127115
961
962         Reviewed by Mark Lam.
963
964         Simple patch to make run-jsc easier to deal with
965
966         * Scripts/run-jsc:
967
968 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
969
970         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
971         https://bugs.webkit.org/show_bug.cgi?id=126323
972
973         Reviewed by Csaba Osztrogonác.
974
975         * gtk/generate-feature-defines-files:
976
977 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
978
979         [EFL][WK2] Implement TestController::setHidden
980         https://bugs.webkit.org/show_bug.cgi?id=127036
981
982         Reviewed by Gyuyoung Kim.
983
984         WebKitTestRunner needs TestController::setHidden implementation to
985         properly handle page visibility API layout tests after r161105.
986
987         * WebKitTestRunner/efl/TestControllerEfl.cpp:
988         (WTR::TestController::setHidden):
989
990 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
991
992         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
993         https://bugs.webkit.org/show_bug.cgi?id=127083
994
995         Reviewed by Carlos Garcia Campos.
996
997         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
998         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
999
1000         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
1001         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
1002         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
1003         BrowserWindow object is being finalized, preventing the callback from firing.
1004
1005         * MiniBrowser/gtk/BrowserWindow.c:
1006         (resetEntryProgress):
1007         (webViewLoadProgressChanged):
1008         (browserWindowFinalize):
1009
1010 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
1011
1012         DumpRenderTree doesn't disable web preferences autosave
1013         https://bugs.webkit.org/show_bug.cgi?id=127062
1014
1015         Reviewed by Dan Bernstein.
1016
1017         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1018         Do it.
1019
1020 2014-01-15  Dean Jackson  <dino@apple.com>
1021
1022         Improve filter-build-webkit, especially for iOS builds
1023         https://bugs.webkit.org/show_bug.cgi?id=81046
1024
1025         Reviewed by Joseph Pecoraro.
1026
1027         Lots of updates to the filtering rules, mostly from the
1028         iOS build output. Other highlights include:
1029         - ignoring escape sequences for color ouput
1030         - detecting escaped spaces in file name regexps
1031
1032         * Scripts/filter-build-webkit:
1033         (shouldIgnoreLine):
1034
1035 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1036
1037         [GTK] Web process sometimes crashes when printing in synchronous mode
1038         https://bugs.webkit.org/show_bug.cgi?id=126979
1039
1040         Reviewed by Gustavo Noronha Silva.
1041
1042         * Scripts/run-gtk-tests:
1043         (TestRunner): Unskip
1044         /webkit2/WebKitPrintOperation/close-after-print.
1045
1046 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
1047
1048         [EFL] Change test font installed path to webkitgtk-font-tests
1049         https://bugs.webkit.org/show_bug.cgi?id=126723
1050
1051         Reviewed by Gyuyoung Kim.
1052
1053         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
1054         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
1055         hard-coded in FontManagement.cpp#105
1056
1057         * DumpRenderTree/PlatformEfl.cmake:
1058         * WebKitTestRunner/PlatformEfl.cmake:
1059         * efl/jhbuild.modules:
1060
1061 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
1062
1063         Make DoYouEvenBench runnable by run-perf-tests
1064         https://bugs.webkit.org/show_bug.cgi?id=127030
1065
1066         Reviewed by Andreas Kling.
1067
1068         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
1069         ":Total" to appear at the end of a test name. We don't do anything with it for now.
1070
1071         * Scripts/webkitpy/performance_tests/perftest.py:
1072         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
1073         to the JSON in a follow up patch for the perf dashboard.
1074         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
1075
1076 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1077
1078         [GTK] UI process crashes when the web process crashes while printing
1079         https://bugs.webkit.org/show_bug.cgi?id=126977
1080
1081         Reviewed by Gustavo Noronha Silva.
1082
1083         Add new test case to check that closing the window right after
1084         printing works. It's skipped for now, because this patch only
1085         fixes the UI process crash, but not the web process one.
1086
1087         * Scripts/run-gtk-tests:
1088         (TestRunner): Skip
1089         /webkit2/WebKitPrintOperation/close-after-print.
1090         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1091         (testPrintOperationPrintPrinter):
1092         (findPrintToFilePrinter):
1093         (testPrintOperationPrint):
1094         (testPrintOperationErrors):
1095         (testPrintOperationCloseAfterPrint):
1096         (beforeAll):
1097
1098 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
1099
1100         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
1101         https://bugs.webkit.org/show_bug.cgi?id=127002
1102
1103         Reviewed by David Kilzer.
1104
1105         * Scripts/webkitdirs.pm:
1106         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
1107
1108 2014-01-14  Commit Queue  <commit-queue@webkit.org>
1109
1110         Unreviewed, rolling out r162000.
1111         http://trac.webkit.org/changeset/162000
1112         https://bugs.webkit.org/show_bug.cgi?id=127009
1113
1114         API versioning is wrong (Requested by rfong on #webkit).
1115
1116         * MiniBrowser/mac/WK2BrowserWindowController.m:
1117         (-[WK2BrowserWindowController awakeFromNib]):
1118         * WebKitTestRunner/TestController.cpp:
1119         (WTR::TestController::createOtherPage):
1120         (WTR::TestController::createWebViewWithOptions):
1121
1122 2014-01-13  Roger Fong  <roger_fong@apple.com>
1123
1124         Add support for handling WebGL load policies.
1125         https://bugs.webkit.org/show_bug.cgi?id=126935
1126         <rdar://problem/15790448>.
1127
1128         Reviewed by Brent Fulgham.
1129
1130         * MiniBrowser/mac/WK2BrowserWindowController.m:
1131         (-[WK2BrowserWindowController awakeFromNib]):
1132         * WebKitTestRunner/TestController.cpp:
1133         (WTR::TestController::createWebViewWithOptions):
1134
1135 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
1136
1137         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
1138         https://bugs.webkit.org/show_bug.cgi?id=120110
1139
1140         Reviewed by Martin Robinson.
1141
1142         Skip the FontConfig settings initialization in WebKitTestRunner if the
1143         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
1144         This is useful when profiling the WebKitTestRunner execution, where at the startup
1145         this step takes considerable amount of time and disturbs the profiling output.
1146
1147         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1148         (WTR::initializeFontConfigSetting):
1149
1150 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
1151
1152         Add ENABLE(WEB_REPLAY) feature flag to the build system
1153         https://bugs.webkit.org/show_bug.cgi?id=126949
1154
1155         Reviewed by Joseph Pecoraro.
1156
1157         * Scripts/webkitperl/FeatureList.pm:
1158
1159 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
1160
1161         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
1162         https://bugs.webkit.org/show_bug.cgi?id=126702
1163
1164         Reviewed by Alexey Proskuryakov.
1165
1166         Resolve regression and remove a FIXME comment that is already fixed.
1167
1168         * Scripts/webkitpy/common/system/filesystem.py:
1169         (FileSystem.open_text_file_for_reading):
1170         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1171         (RealFileSystemTest.test_read_and_write_file):
1172         * Scripts/webkitpy/style/filereader.py:
1173         (TextFileReader._read_lines):
1174         * Scripts/webkitpy/style/filereader_unittest.py:
1175         (TextFileReaderTest.test_count_delete_only_file):
1176         (TextFileReaderTest):
1177         (TextFileReaderTest.test_process_malformed_file):
1178
1179 2014-01-02  Brian Holt  <brian.holt@samsung.com>
1180
1181         [GTK] Parse Valgrind xml leak files
1182         https://bugs.webkit.org/show_bug.cgi?id=119446
1183
1184         Reviewed by Alejandro G. Castro.
1185
1186         Parse the xml files generated by Valgrind to yield useful
1187         information about the memory leaks.
1188
1189         * Scripts/webkitpy/port/gtk.py:
1190         (GtkPort.__init__):
1191         (GtkPort.setup_test_run): Clear the previous output files before new
1192         run.
1193         (GtkPort.print_leaks_summary):
1194
1195         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
1196         Parse the xml files generated by Valgrind and summarise leaks
1197         into an easily understandable list.
1198         (get_text_of):
1199         (get_CDATA_of):
1200         (gather_frames):
1201         (ValgrindError):
1202         (ValgrindError.__init__):
1203         (ValgrindError.__str__):
1204         (ValgrindError.unique_string):
1205         (ValgrindError.error_hash):
1206         (ValgrindError.__hash__):
1207         (ValgrindError.__eq__):
1208         (LeakDetectorValgrind):
1209         (LeakDetectorValgrind.__init__):
1210         (LeakDetectorValgrind._parse_leaks_output):
1211         (LeakDetectorValgrind.leaks_files_in_results_directory):
1212         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
1213         (LeakDetectorValgrind.parse_and_print_leaks_detail):
1214
1215         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
1216         (make_mock_valgrind_output):
1217         (make_mock_incomplete_valgrind_output):
1218         (make_mock_valgrind_results):
1219         (make_mock_valgrind_results_incomplete):
1220         (make_mock_valgrind_results_empty):
1221         (make_mock_valgrind_results_misformatted):
1222         (mock_run_cppfilt_command):
1223         (LeakDetectorValgrindTest):
1224         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
1225         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
1226         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
1227         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
1228         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
1229         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
1230         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
1231         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
1232
1233 2014-01-13  Lucas Forschler  <lforschler@apple.com>
1234
1235         Update the LLINT CLoop Bot build infrastructure
1236         https://bugs.webkit.org/show_bug.cgi?id=126604
1237         
1238         Unreviewed.
1239         
1240         * BuildSlaveSupport/build.webkit.org-config/config.json:
1241         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1242         (CompileLLINTCLoop):
1243         (RunLLINTCLoopTests):
1244         (BuildAndTestLLINTCLoopFactory):
1245         (BuildAndTestLLINTCLoopFactory.__init__):
1246
1247 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
1248
1249         [EFL][WK2] Disable failing API tests
1250         https://bugs.webkit.org/show_bug.cgi?id=126960
1251
1252         Reviewed by Gyuyoung Kim.
1253
1254         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
1255
1256         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1257         (TestWebKitAPI::TEST):
1258
1259 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
1260
1261         Remove wdiff
1262         https://bugs.webkit.org/show_bug.cgi?id=124766
1263
1264         Reviewed by Ryosuke Niwa.
1265
1266         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1267         (ResultsJSONParserTest):
1268         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1269         (TestResultWriter):
1270         (TestResultWriter.create_text_diff_and_write_result):
1271         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1272         (summarize_results):
1273         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1274         (RunTest.test_output_diffs):
1275         * Scripts/webkitpy/port/base.py:
1276         (Port.__init__):
1277         (Port.driver_stop_timeout):
1278         (Port.check_image_diff):
1279         (Port.repository_paths):
1280         (Port._path_to_lighttpd_php):
1281         * Scripts/webkitpy/port/base_unittest.py:
1282         (PortTest.test_default_child_processes):
1283         (PortTest.test_pretty_patch_script_error):
1284         * Scripts/webkitpy/port/port_testcase.py:
1285         (PortTestCase.test_diff_image_crashed):
1286         * Scripts/webkitpy/port/test.py:
1287         (TestPort.operating_system):
1288
1289 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
1290
1291         Build fix for the GTK+ CMake port
1292
1293         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
1294
1295 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
1296
1297         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
1298         https://bugs.webkit.org/show_bug.cgi?id=126881
1299
1300         Reviewed by Carlos Garcia Campos.
1301
1302         * MiniBrowser/gtk/BrowserWindow.c:
1303         (browser_window_new):
1304         Explicitly cast GtkWindow** to gpointer* in call to
1305         g_object_add_weak_pointer to avoid compiler warnings.
1306
1307 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1308
1309         Remove parsing of old-run-webkit-tests output from master.cfg
1310         https://bugs.webkit.org/show_bug.cgi?id=126690
1311
1312         Reviewed by Csaba Osztrogonác.
1313
1314         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1315         Removed parsing of ORWT output, as it is not used anymore.
1316         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1317         Updated unit tests accordingly.
1318
1319 2014-01-13  Commit Queue  <commit-queue@webkit.org>
1320
1321         Unreviewed, rolling out r161808.
1322         http://trac.webkit.org/changeset/161808
1323         https://bugs.webkit.org/show_bug.cgi?id=126874
1324
1325         This patch make several files to be always regenerated on
1326         every make (Requested by KaL on #webkit).
1327
1328         * WebKitTestRunner/GNUmakefile.am:
1329
1330 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
1331
1332         [GTK] Make MiniBrowser windows non-transient by default
1333         https://bugs.webkit.org/show_bug.cgi?id=126840
1334
1335         Reviewed by Carlos Garcia Campos.
1336
1337         Instead of making new browser windows transient as soon as they are
1338         created, save the pointer to the parent window and set the transient
1339         state later on when handling the "run-as-modal" signal. This makes
1340         it easier to use the MiniBrowser to do tests involving multiple
1341         windows, and will be useful as well when multi-web-process mode is
1342         enabled for the GTK port.
1343
1344         * MiniBrowser/gtk/BrowserWindow.c:
1345         (webViewRunAsModal): Set the parent window using
1346         gtk_window_set_transient_for() using the saved parent
1347         window.
1348         (browser_window_new): Save the parent window using
1349         g_object_set_data() instead of making the new window
1350         transient immediately.
1351
1352 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
1353
1354         [EFL][WK2] Make API tests work again
1355         https://bugs.webkit.org/show_bug.cgi?id=126769
1356
1357         Reviewed by Gyuyoung Kim.
1358
1359         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
1360         [E]WebKit2, respectively, and this causes problems because the logic to find
1361         where WebProcess is to look in the same directory of the running process and
1362         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
1363
1364         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
1365         Gtk port, which allows us to look for WebProcess initially in this directory,
1366         if it's defined.
1367
1368         * TestWebKitAPI/efl/main.cpp:
1369         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
1370
1371 2014-01-12  Daniel Bates  <dabates@apple.com>
1372
1373         [iOS] Fix the build
1374
1375         For now, ensure we build WebKit System Interface before we build WebKit.
1376         We'll remove this constraint and the constraint to build WebKit Additions
1377         in a subsequent commit.
1378
1379         * Scripts/build-webkit:
1380
1381 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1382
1383         Unreviewed. Fix make distcheck.
1384
1385         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
1386         to EXTRA_DIST.
1387
1388 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
1389
1390         --disable-dependency-tracking causes build failure due to missing directories
1391         https://bugs.webkit.org/show_bug.cgi?id=94488
1392
1393         Reviewed by Gustavo Noronha Silva.
1394
1395         Autotools build fix: Ensure output directory existing
1396         before generating DerivedSources. This allows for
1397         --disable-dependency-tracking to be run.
1398
1399
1400         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
1401
1402 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1403
1404         [GTK] Fix return value of WebKitDownload::created-destination
1405         https://bugs.webkit.org/show_bug.cgi?id=126741
1406
1407         Reviewed by Martin Robinson.
1408
1409         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
1410         value of several callbacks.
1411
1412 2014-01-11  Sam Weinig  <sam@webkit.org>
1413
1414         Add support for null StringViews
1415         https://bugs.webkit.org/show_bug.cgi?id=126827
1416
1417         Reviewed by Anders Carlsson.
1418
1419         Add new test for StringView.
1420
1421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1422         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
1423         (TestWebKitAPI::TEST):
1424
1425 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
1426
1427         Remove the BlackBerry port from trunk
1428         https://bugs.webkit.org/show_bug.cgi?id=126715
1429
1430         Reviewed by Anders Carlsson.
1431
1432         * DumpRenderTree/DumpRenderTree.h:
1433         * DumpRenderTree/PixelDumpSupport.cpp:
1434
1435 2014-01-10  Daniel Bates  <dabates@apple.com>
1436
1437         [iOS] Fix project build order
1438
1439         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
1440         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
1441         time of writing.
1442
1443         * Scripts/build-webkit:
1444
1445 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
1446
1447         Move platformName property from testRunner to accessibilityController
1448         https://bugs.webkit.org/show_bug.cgi?id=126689
1449
1450         Reviewed by Chris Fleizach.
1451
1452         Move the platformName property from the testRunner into
1453         accessibilityController, since this is a concept that has only be
1454         used by accessibility tests since it got added, and also because
1455         the real intention was not to distinguish among "ports" (mac, win,
1456         gtk, efl) but between platforms (atk, mac, win).
1457
1458         This change will be very useful to merge GTK's roles-exposed.html
1459         and Mac's role-subrole-roledescription.html into one single test,
1460         since we will be specifying in the test itself which elements are
1461         supported in which accessibility "platform". In this context,
1462         being able to check accessibilityController.platformName directly
1463         against a list of supported accessibility platforms (e.g. "atk,mac")
1464         will certainly maintain the code cleaner and simpler.
1465
1466         * DumpRenderTree/TestRunner.h:
1467         (TestRunner::platformName): Removed.
1468         * DumpRenderTree/TestRunner.cpp:
1469         (getPlatformNameCallback): Removed.
1470         (TestRunner::staticValues): Removed platformName
1471         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1472         (TestRunner::platformName): Removed.
1473         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1474         (TestRunner::platformName): Removed.
1475         * DumpRenderTree/mac/TestRunnerMac.mm:
1476         (TestRunner::platformName): Removed.
1477         * DumpRenderTree/win/TestRunnerWin.cpp:
1478         (TestRunner::platformName): Removed.
1479
1480         * DumpRenderTree/AccessibilityController.h:
1481         (AccessibilityController::platformName): Added.
1482         * DumpRenderTree/AccessibilityController.cpp:
1483         (getPlatformNameCallback): Added.
1484         (AccessibilityController::getJSClass): Added platformName.
1485         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1486         (AccessibilityController::platformName): Added, returning "atk".
1487         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1488         (AccessibilityController::platformName): Ditto, returning "mac".
1489         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1490         (AccessibilityController::platformName): Ditto, returning "ios".
1491         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1492         (AccessibilityController::platformName): Ditto, returning "win".
1493
1494         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1495         (platformName): Removed.
1496         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1497         (TestRunner::platformName): Removed.
1498         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1499         (TestRunner::platformName): Removed.
1500         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1501         (TestRunner::platformName): Removed.
1502         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1503         (TestRunner::platformName): Removed.
1504         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1505         (TestRunner::platformName): Removed.
1506
1507         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1508         (WTR:AccessibilityController::platformName): Added.
1509         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1510         (platformName): Added.
1511         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1512         (WTR::AccessibilityController::platformName): Added, returning "atk".
1513         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1514         (WTR::AccessibilityController::platformName): Added, returning "mac".
1515
1516 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
1517
1518         Remove the BlackBerry port from trunk
1519         https://bugs.webkit.org/show_bug.cgi?id=126715
1520
1521         Reviewed by Anders Carlsson.
1522
1523         * Scripts/webkitpy/common/config/watchlist:
1524
1525 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
1526
1527         Remove the BlackBerry files outside WebCore
1528         https://bugs.webkit.org/show_bug.cgi?id=126715
1529
1530         Reviewed by Anders Carlsson.
1531
1532         * DumpRenderTree/blackberry: Removed.
1533
1534 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
1535
1536         Remove knowledge of Blackberry from build scripts
1537         https://bugs.webkit.org/show_bug.cgi?id=126766
1538
1539         Reviewed by Anders Carlsson.
1540         
1541         Remove isBlackBerry() and references to it, and rmeove
1542         blackberry-related stuff from the watchlist.
1543
1544         * Scripts/build-webkit:
1545         * Scripts/webkit-build-directory:
1546         * Scripts/webkitdirs.pm:
1547         (determineBaseProductDir):
1548         (argumentsForConfiguration):
1549         (builtDylibPathForName):
1550         (isAppleWebKit):
1551         (buildCMakeProjectOrExit):
1552         (cmakeBasedPortArguments):
1553         (cmakeBasedPortName):
1554         * Scripts/webkitperl/FeatureList.pm:
1555         * Scripts/webkitpy/common/config/watchlist:
1556
1557 2014-01-10  Daniel Bates  <dabates@apple.com>
1558
1559         [iOS] Fix up simulator build and enable default features
1560
1561         Rubber-stamped by Joseph Pecoraro.
1562
1563         * Scripts/webkitdirs.pm:
1564         (determineArchitecture):
1565         (determinePassedArchitecture):
1566         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
1567         by default only in iOS).
1568
1569 2014-01-10  Daniel Bates  <dabates@apple.com>
1570
1571         [iOS] Upstream WebCore and Tools miscellaneous changes
1572         https://bugs.webkit.org/show_bug.cgi?id=126698
1573
1574         Reviewed by David Kilzer.
1575
1576         * Scripts/check-for-inappropriate-objc-class-names:
1577         * Scripts/check-for-webkit-framework-include-consistency:
1578
1579 2014-01-09  Dan Bernstein  <mitz@apple.com>
1580
1581         [Cocoa] Promote WKBackForwardList{,Item}.h to public
1582         https://bugs.webkit.org/show_bug.cgi?id=126707
1583
1584         Reviewed by Sam Weinig.
1585
1586         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
1587         left behind in the build products directory after a private header is made public.
1588
1589 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1590
1591         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
1592         https://bugs.webkit.org/show_bug.cgi?id=126686
1593
1594         Reviewed by Martin Robinson.
1595
1596         Test that partial files are not left on disk after a download has
1597         been cancelled after the destination has been decided. To make
1598         sure the download is cancelled after the destination has been
1599         decided and before the operation finishes, we cancel the download
1600         in the destination decided callback, and we use an infinite
1601         resource that writes chunks to the response body and never
1602         completes the body.
1603
1604         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1605         (addContentDispositionHTTPHeaderToResponse): Helper function to
1606         add the Content-Disposition to the response headers.
1607         (writeNextChunkIdle): Write next chunk to response body.
1608         (writeNextChunk): Write next chunk in an idle to avoid flooding
1609         the network with the inifnite resource.
1610         (serverCallback): Add an inifinite resource.
1611         (testDownloadRemoteFileError): Check that partial file is not
1612         present after the download has been cancelled.
1613
1614 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
1615
1616         Move myself to the committers list.
1617
1618         Unreviewed.
1619
1620         * Scripts/webkitpy/common/config/contributors.json:
1621
1622 2014-01-08  Seokju Kwon  <seokju@webkit.org>
1623
1624         [GTK] Unreviewed build fix after r161522.
1625
1626         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
1627
1628 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1629
1630         Missleading style error when mixing system and non-system header include lines.
1631         https://bugs.webkit.org/show_bug.cgi?id=126564
1632
1633         Reviewed by Ryosuke Niwa.
1634
1635         * Scripts/webkitpy/style/checkers/cpp.py:
1636         (check_include_line):
1637         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1638         (OrderOfIncludesTest.test_check_alphabetical_include_order):
1639         (OrderOfIncludesTest.test_public_primary_header):
1640
1641 2014-01-08  Seokju Kwon  <seokju@webkit.org>
1642
1643         [EFL] Unreviewed build fix after r161522.
1644
1645         * TestWebKitAPI/CMakeLists.txt:
1646         * TestWebKitAPI/PlatformEfl.cmake:
1647
1648 2014-01-08  Anders Carlsson  <andersca@apple.com>
1649
1650         Remove WKConnectionRef tests
1651         https://bugs.webkit.org/show_bug.cgi?id=126666
1652
1653         Reviewed by Dan Bernstein.
1654
1655         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
1656         Remove the API tests as a first step towards killing the entire thing.
1657
1658         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1659         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
1660         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
1661
1662 2014-01-08  Commit Queue  <commit-queue@webkit.org>
1663
1664         Unreviewed, rolling out r161512.
1665         http://trac.webkit.org/changeset/161512
1666         https://bugs.webkit.org/show_bug.cgi?id=126655
1667
1668         Broke webkitpy tests (Requested by ap on #webkit).
1669
1670         * Scripts/webkitpy/port/gtk.py:
1671         (GtkPort.__init__):
1672         (GtkPort.setup_test_run):
1673         (GtkPort._port_specific_expectations_files):
1674         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
1675         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
1676
1677 2014-01-08  Commit Queue  <commit-queue@webkit.org>
1678
1679         Unreviewed, rolling out r161517.
1680         http://trac.webkit.org/changeset/161517
1681         https://bugs.webkit.org/show_bug.cgi?id=126659
1682
1683         The fix didn't completely remove the problem and is now
1684         standing in the way of the rollout of the offending patch
1685         (Requested by zdobersek on #webkit).
1686
1687         * Scripts/webkitpy/port/gtk.py:
1688         (GtkPort.__init__):
1689
1690 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
1691
1692         Unreviewed. Attempting to fix webkitpy tests after r161512.
1693
1694         * Scripts/webkitpy/port/gtk.py:
1695         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
1696
1697 2014-01-08  Brian Holt  <brian.holt@samsung.com>
1698
1699         [GTK] Parse Valgrind xml leak files
1700         https://bugs.webkit.org/show_bug.cgi?id=119446
1701
1702         Reviewed by Alejandro G. Castro.
1703
1704         Parse the xml files generated by Valgrind to yield useful
1705         information about the memory leaks.
1706
1707         * Scripts/webkitpy/port/gtk.py:
1708         (GtkPort.__init__):
1709         (GtkPort.setup_test_run): Clear the previous output files before new
1710         run.
1711         (GtkPort.print_leaks_summary):
1712
1713         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
1714         Parse the xml files generated by Valgrind and summarise leaks
1715         into an easily understandable list.
1716         (get_text_of):
1717         (get_CDATA_of):
1718         (gather_frames):
1719         (ValgrindError):
1720         (ValgrindError.__init__):
1721         (ValgrindError.__str__):
1722         (ValgrindError.unique_string):
1723         (ValgrindError.error_hash):
1724         (ValgrindError.__hash__):
1725         (ValgrindError.__eq__):
1726         (LeakDetectorValgrind):
1727         (LeakDetectorValgrind.__init__):
1728         (LeakDetectorValgrind._parse_leaks_output):
1729         (LeakDetectorValgrind.leaks_files_in_results_directory):
1730         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
1731         (LeakDetectorValgrind.parse_and_print_leaks_detail):
1732
1733         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
1734         (make_mock_valgrind_output):
1735         (make_mock_incomplete_valgrind_output):
1736         (make_mock_valgrind_results):
1737         (make_mock_valgrind_results_incomplete):
1738         (make_mock_valgrind_results_empty):
1739         (make_mock_valgrind_results_misformatted):
1740         (LeakDetectorValgrindTest):
1741         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
1742         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
1743         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
1744         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
1745         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
1746         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
1747         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
1748         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
1749
1750 2014-01-08  Commit Queue  <commit-queue@webkit.org>
1751
1752         Unreviewed, rolling out r161427.
1753         http://trac.webkit.org/changeset/161427
1754         https://bugs.webkit.org/show_bug.cgi?id=126645
1755
1756         Emits a stye error on any newly added files (Requested by ap
1757         on #webkit).
1758
1759         * Scripts/webkitpy/style/checkers/cpp.py:
1760         (check_style):
1761         (CppChecker):
1762         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1763         (WebKitStyleTest.test_other):
1764
1765 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1766
1767         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
1768         https://bugs.webkit.org/show_bug.cgi?id=126580
1769
1770         Reviewed by Csaba Osztrogonác.
1771
1772         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1773         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
1774         run-webkit-tests script.
1775         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
1776         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
1777
1778 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1779
1780         Update the list of non-committer u-szeged contributors
1781         https://bugs.webkit.org/show_bug.cgi?id=126640
1782
1783         Reviewed by Csaba Osztrogonác.
1784
1785         * Scripts/webkitpy/common/config/contributors.json:
1786
1787 2014-01-08  Alberto Garcia  <berto@igalia.com>
1788
1789         Fix some compilation warnings
1790         https://bugs.webkit.org/show_bug.cgi?id=126635
1791
1792         Reviewed by Csaba Osztrogonác.
1793
1794         * GtkLauncher/main.c:
1795         (createWindow): This function is not supposed to receive any
1796         parameter, yet we are passing one.
1797
1798 2014-01-08  Brian Holt  <brian.holt@samsung.com>
1799
1800         [GTK][WK2] unskip passing unit tests
1801         https://bugs.webkit.org/show_bug.cgi?id=126637
1802
1803         Reviewed by Carlos Garcia Campos.
1804
1805         Unskip TestResources and TestAuthentication unit tests since they
1806         are passing both under Xvfb and X.
1807
1808         * Scripts/run-gtk-tests:
1809         (TestRunner):
1810
1811 2014-01-08  Alberto Garcia  <berto@igalia.com>
1812
1813         REGRESSION(r160304): [GTK] Disable libtool fast install
1814         https://bugs.webkit.org/show_bug.cgi?id=126381
1815
1816         Reviewed by Gustavo Noronha Silva.
1817
1818         Disable the libtool fast-install mode in developer/test builds.
1819
1820         In this mode binaries are generated ready to be used directly from
1821         the build tree. Otherwise they would need to be relinked when they
1822         are executed, which can take a lot of resources, particularly in
1823         debug builds.
1824
1825         * Scripts/webkitdirs.pm:
1826         (runAutogenForAutotoolsProjectIfNecessary):
1827
1828 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
1829
1830         Unreviewed GTK gardening.
1831
1832         * Scripts/run-gtk-tests:
1833         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
1834         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
1835
1836 2014-01-07  Lucas Forschler  <lforschler@apple.com>
1837
1838         Add buildbot infrasctructure for building and testing JSC cloop
1839         https://bugs.webkit.org/show_bug.cgi?id=126604
1840
1841         Reviewed by Geoffrey Garen.
1842
1843         * BuildSlaveSupport/build.webkit.org-config/config.json:
1844         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1845         (CompileCLOOP):
1846         (RunCLOOPTests):
1847         (RunCLOOPTests.countFailures):
1848         (BuildAndTestCLOOP):
1849
1850 2014-01-07  Brian Burg  <bburg@apple.com>
1851
1852         Unreviewed. Add myself as a committer.
1853
1854         * Scripts/webkitpy/common/config/contributors.json:
1855
1856 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
1857
1858         Popovers at build.webkit.org/dashboard could have titles
1859         https://bugs.webkit.org/show_bug.cgi?id=126495
1860
1861         Reviewed by Timothy Hatcher.
1862
1863         Added titles to all popovers except for pending revisions one, which I would like
1864         to improve more (probably add an ETA).
1865
1866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1867         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
1868         adding a title to base class.
1869
1870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1871         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
1872         a divider to a separate function.
1873         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
1874         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
1875         title from above function.
1876         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
1877         variable to "content" to match all other code.
1878         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
1879         (BuildbotQueueView.prototype._addDividerToPopover): Added.
1880
1881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1882         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
1883         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
1884         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
1885
1886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1887
1888 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
1889
1890         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
1891         https://bugs.webkit.org/show_bug.cgi?id=126472
1892
1893         Reviewed by Timothy Hatcher.
1894
1895         Added a delay when quickly switching to a different popover, making it easier to
1896         move mouse pointer from active element to its popover without accidentally opening
1897         a different popover.
1898
1899         Used this code to add a delay before creating a popover. This doesn't change UI
1900         behavior, as there was alerady a delay before it became visible, but it avoids
1901         flooding buildbot server with http requests when quickly moving the mouse over
1902         dashboard page.
1903
1904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
1905         Fixed a case where popover could get stuck. If content was updated while fade-out
1906         transition was already in place, the transition was removed for no good reason.
1907
1908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
1909         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
1910
1911         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
1912         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
1913         popover delay from 1s to 800ms.
1914
1915 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
1916
1917         Improve display of failed builds at build.webkit.org/dashboard
1918         https://bugs.webkit.org/show_bug.cgi?id=126542
1919         <rdar://problem/15753550>
1920
1921         Reviewed by Timothy Hatcher.
1922
1923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1924         Instead of hardcoding step name, look for the first step that failed.
1925         While at it, added a popover with more links. There are multiple, and it's good
1926         to have a choice of which one to look at in each situation.
1927
1928         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1929         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
1930         of having failed. Many iterations are interrupted for whatever reason internal to
1931         Buildbot, and these are suppoed to be orange, not red.
1932         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
1933         not only WillRetry ones.
1934         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
1935         actually failed, more likely indicating a problem with code base.
1936         (BuildbotIteration.prototype.get firstFailedStepName):
1937         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
1938         (BuildbotIteration.prototype.get failureLogs): Ditto.
1939         (BuildbotIteration.prototype.update): Store complete results for the failed step.
1940         Not every failure stops the iteration, so we could have multiple failed steps,
1941         but let's see if seeing just the first one will be enough.
1942
1943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1944         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
1945         terms of successful iterations.
1946         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
1947
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1949         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
1950         terms of successful iterations.
1951
1952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1953         Removed code to create a path to build output, we now take it from results JSON.
1954
1955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1956         Added styles for the new popover.
1957
1958 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1959
1960         defined constants should use all uppercase names with words separated by underscores.
1961         https://bugs.webkit.org/show_bug.cgi?id=126055
1962
1963         Reviewed by Alexey Proskuryakov.
1964
1965         * Scripts/webkitpy/style/checkers/cpp.py:
1966         (check_style):
1967         (CppChecker):
1968         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1969         (WebKitStyleTest.test_define_constants):
1970
1971 2014-01-07  Brian Holt  <brian.holt@samsung.com>
1972
1973         Unreviewed. Add myself as a committer.
1974
1975         * Scripts/webkitpy/common/config/contributors.json:
1976
1977 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1978
1979         Remove the WinCE buildbot from build.webkit.org
1980         https://bugs.webkit.org/show_bug.cgi?id=126517
1981
1982         Reviewed by Alexey Proskuryakov.
1983
1984         * BuildSlaveSupport/build.webkit.org-config/config.json:
1985         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1986         (appendCustomBuildFlags):
1987
1988 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
1989
1990         [EFL] Change ATK version to 2.11.4
1991         https://bugs.webkit.org/show_bug.cgi?id=126573
1992
1993         Reviewed by Gyuyoung Kim.
1994
1995         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
1996
1997         * efl/jhbuild.modules:
1998
1999 2014-01-07  Alberto Garcia  <berto@igalia.com>
2000
2001         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
2002         https://bugs.webkit.org/show_bug.cgi?id=117275
2003
2004         Reviewed by Carlos Garcia Campos.
2005
2006         If we are not using the internal jhbuild we must not use the
2007         jhbuild-wrapper script, else it will try to download and install
2008         it.
2009
2010         * Scripts/run-launcher:
2011
2012 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2013
2014         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
2015         https://bugs.webkit.org/show_bug.cgi?id=125855
2016
2017         Reviewed by Mario Sanchez Prada.
2018
2019         Added new function isIndeterminate for testing aria-checked mixed state.
2020         I provided respective, but empty function in mac port. Mac testing it differently.
2021
2022         * DumpRenderTree/AccessibilityUIElement.cpp:
2023         (getIsIndeterminate):
2024         (AccessibilityUIElement::getJSClass):
2025         * DumpRenderTree/AccessibilityUIElement.h:
2026         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2027         (AccessibilityUIElement::isIndeterminate):
2028         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
2029         (AccessibilityUIElement::isIndeterminate):
2030         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
2031         (AccessibilityUIElement::isIndeterminate):
2032         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
2033         (AccessibilityUIElement::isIndeterminate):
2034         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2035         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2036         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2037         (WTR::AccessibilityUIElement::isIndeterminate):
2038         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2039         (WTR::AccessibilityUIElement::isIndeterminate):
2040
2041 2014-01-06  Mark Rowe  <mrowe@apple.com>
2042
2043         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
2044
2045         Reviewed by Ryosuke Niwa.
2046
2047         * DumpRenderTree/mac/DumpRenderTree.mm:
2048         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
2049         with a single case. This avoids the potential for warnings about unhandled cases.
2050         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2051         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
2052
2053 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2054
2055         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
2056         https://bugs.webkit.org/show_bug.cgi?id=126342
2057
2058         Reviewed by Gustavo Noronha Silva.
2059
2060         * CMakeLists.txt: Include the new unit tests subdirectories.
2061         * Scripts/run-gtk-tests: Update to refer to the new build locations.
2062         * Scripts/webkitpy/style/checker.py: Update the style checker.
2063         * Scripts/webkitpy/style/checker_unittest.py:
2064         * TestWebKitAPI/GNUmakefile.am:
2065         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
2066         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
2067         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
2068         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
2069         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
2070         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
2071         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
2072         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
2073         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
2074         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
2075         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
2076         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
2077         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
2078         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
2079         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
2080         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
2081         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
2082         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
2083         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
2084         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
2085         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
2086         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
2087         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
2088         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
2089         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
2090         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
2091         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
2092         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
2093         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
2094         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
2095         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
2096         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
2097         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
2098         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
2099         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
2100         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
2101         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
2102         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
2103         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
2104         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
2105         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
2106         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
2107         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
2108         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
2109         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
2110         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
2111         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
2112         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
2113         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
2114         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
2115         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
2116         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
2117         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
2118         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
2119         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
2120         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
2121         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
2122         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
2123         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
2124         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
2125         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
2126         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
2127         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
2128         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
2129         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
2130         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
2131         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
2132         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
2133         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
2134         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
2135         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
2136         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
2137         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
2138         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
2139         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
2140         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
2141         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
2142         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
2143         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
2144         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
2145         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
2146         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
2147         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
2148         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
2149         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
2150         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
2151         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
2152
2153 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
2154
2155         Gtk and Efl API test results confuse the dashboard
2156         https://bugs.webkit.org/show_bug.cgi?id=126535
2157
2158         Reviewed by Tim Horton.
2159
2160         Added "API tests" step as "platform api tests".
2161
2162         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2163         (Buildbot.prototype.platformAPITestResultsURLForIteration):
2164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2165         (BuildbotIteration):
2166         (BuildbotIteration.prototype.update):
2167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2168         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2169         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2170
2171 2014-01-06  Tim Horton  <timothy_horton@apple.com>
2172
2173         build.webkit.org/dashboard should still function if localStorage is disabled
2174         https://bugs.webkit.org/show_bug.cgi?id=126511
2175
2176         Reviewed by Alexey Proskuryakov.
2177
2178         If localStorage is disabled, we should carry on with a warning.
2179
2180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2181         Don't show the gear if localStorage isn't working.
2182
2183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2184         (QueueView.prototype._updateHiddenState):
2185         Bail if localStorage isn't working.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2188         (Settings.prototype.available):
2189
2190 2014-01-02  Roger Fong  <roger_fong@apple.com>
2191
2192         Set VSINSTALLDIR in win ews start script.
2193         https://bugs.webkit.org/show_bug.cgi?id=126407
2194
2195         Reviewed by Brent Fulgham.
2196
2197         * EWSTools/start-queue-win.sh:
2198
2199 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
2200
2201         Adding myself as a reviewer.
2202
2203         Unreviewed.
2204
2205         * Scripts/webkitpy/common/config/contributors.json:
2206
2207 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
2208
2209         Unreviewed. Unbreaking JSC tests after r161328.
2210
2211         * Scripts/webkitdirs.pm:
2212         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
2213         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
2214
2215 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
2216
2217         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
2218         https://bugs.webkit.org/show_bug.cgi?id=126212
2219
2220         Reviewed by Daniel Bates.
2221
2222         Allow building the GTK+ cmake port with --gtkcmake.
2223
2224         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
2225         when appropriate. Skip the autotoos path when isGtkAutotools is false.
2226         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
2227         Add isGtk which checks isGtkCMake || isGtkAutotools
2228         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
2229         (argumentsForConfiguration): use --gtkcmake when appropriate.
2230         (jscProductDir): Look in the CMake directory when appropriate.
2231         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
2232         (determineIsGtkCMake): Added.
2233         (isGtkCMake): Added.
2234         (isGtkAutotools): Renamed from isGtk.
2235         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
2236         (determineIsGtkAutotools): Renamed from determineIsGtk.
2237         (cmakeBasedPortName): Added a GTK+ path.
2238
2239 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
2240
2241         [GTK] [CMake] Fix the video and audio build
2242         https://bugs.webkit.org/show_bug.cgi?id=126464
2243
2244         Reviewed by Philippe Normand.
2245
2246         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
2247
2248 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2249
2250         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
2251         https://bugs.webkit.org/show_bug.cgi?id=126467
2252
2253         Reviewed by Geoffrey Garen.
2254
2255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2256         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
2257         pointer, or to tap.
2258
2259 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2260
2261         build.webkit.org/dashboard says "failed build" even if it's another step that failed
2262         https://bugs.webkit.org/show_bug.cgi?id=126461
2263
2264         Reviewed by Geoffrey Garen.
2265
2266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2267         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
2268         build page if it's not the compilation that failed. Use text from buildbot for description.
2269         Show a yellow icon if it's a different kind of failure.
2270
2271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2272         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
2273
2274 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
2275
2276         setup-git-clone fails to get email address from git
2277         https://bugs.webkit.org/show_bug.cgi?id=126446
2278
2279         Reviewed by Ryosuke Niwa.
2280
2281         The setup-git-clone command fails to get an email address from git
2282         because of a bug in VCSUtils. This patch fixes that bug, and also
2283         makes it so that when VCSUtils fails for real because of a local
2284         misconfiguration, the error message is actually presented to the user
2285         of setup-git-clone.
2286
2287         * Scripts/VCSUtils.pm:
2288         (gitConfig): Call isGit() instead of accessing $isGit directly to make
2289             sure that $isGit is properly initialized.
2290         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2291         (SetupGitClone.execute): Pull out username and email acquistion to
2292             it's own method.
2293         (SetupGitClone._get_username_and_email): Catch the exception thrown
2294             when VCSUtils fails and print out the error message so that the
2295             user actually knows why the command failed.
2296
2297 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2298
2299         It feels too hard to get rid of a popover at build.webkit.org/dashboard
2300         https://bugs.webkit.org/show_bug.cgi?id=126451
2301
2302         Reviewed by Simon Fraser.
2303
2304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
2305         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
2306         when moving the mouse from an element to its popover.
2307
2308 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2309
2310         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
2311         https://bugs.webkit.org/show_bug.cgi?id=122181
2312
2313         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2314         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
2315         popover.present signature change.
2316
2317 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2318
2319         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
2320         https://bugs.webkit.org/show_bug.cgi?id=122181
2321
2322         Reviewed by Timothy Hatcher and Timothy Horton.
2323
2324         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
2325         JSONP). Dashboard will load them on demand.
2326
2327         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2328         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
2329         and made it use a function from WebKitBuildbot that builds results directory path.
2330         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
2331         a URL for full_results.json.
2332         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
2333         a URL for a crash log.
2334
2335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2336         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
2337         the iteration.
2338
2339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
2340         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
2341         popover API (see below).
2342         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
2343
2344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2345         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
2346         for iterations that were interrupted (previously, they were displayed incorrectly,
2347         often as passes). Install popover trackers for failure bubbles for which we can currently
2348         display something useful.
2349         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
2350         a popover for layout test regressions when we have the data loaded on demand.
2351         We have test paths, special indicators for crashes/timeouts, and links to test history
2352         at flakiness dashboard.
2353         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
2354         the popover for layout test regressions. Just shows "Loading..." until the data is
2355         loaded.
2356         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
2357         types of failures if there are multiple. There is a lot of similarity with
2358         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
2359
2360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2361         Create a global test history object, which is used for links in layout test popover.
2362
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
2364         Changed the API to be more like WebInspector again, allowing for changing content
2365         of an existing popover. As the size of a popover can change, making the mouse pointer
2366         enter it without a mousenter event, install a handler for mousewheel instead, and block
2367         document scrolling from this event handler when needed.
2368
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2370         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
2371         bubble element, making it possible to install a popover on it.
2372
2373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2374         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
2375
2376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2377         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
2378         building a complete results URL to only building one for root results path. This is
2379         the part that depends on specific buildbot installation, everything relative to it
2380         is the same.
2381
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
2383         Build a path to test history page. In the future, we may consider adding code to
2384         load the data and display it inline.
2385
2386         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2387         Added styles for this new popover.
2388
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
2390         a new file, WebKitTestHistory.js.
2391
2392 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2393
2394         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
2395         https://bugs.webkit.org/show_bug.cgi?id=126430
2396
2397         Reviewed by Martin Robinson.
2398
2399         * Scripts/run-gtk-tests:
2400         (TestRunner._setup_testing_environment):
2401         * gtk/common.py: Use common.tests_library_build_path() instead.
2402         (tests_library_build_path): Helper funtion that returns the path
2403         where the tests libraries are built.
2404
2405 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
2406
2407         [CMake] Build TestWebKitAPI tests into a directory structure
2408         https://bugs.webkit.org/show_bug.cgi?id=126358
2409
2410         Reviewed by Gyuyoung Kim.
2411
2412         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
2413         is useful for keeping the "bin" directory tidy during building and will make it easier
2414         to integrate the CMake build into the existing WebKitGTK+ scripts.
2415
2416         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
2417         and make the names simpler now that the directory identifies what category the test is in.
2418
2419 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2420
2421         Provide a visual clue when element has a popover at build.webkit.org/dashboard
2422         https://bugs.webkit.org/show_bug.cgi?id=126281
2423
2424         Reviewed by Timothy Hatcher.
2425
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2427         (PopoverTracker): Add a class name to elements with popovers.
2428
2429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2430         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
2431         I might have broke that recently.
2432         (*:link): Show hand cursor over links.
2433         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
2434
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2436         (.status-line .message .revision-number): Show text selection cursor on our only
2437         selectable text element.
2438         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
2439         a white shadow than with a dark one on hover.
2440
2441 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2442
2443         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
2444         https://bugs.webkit.org/show_bug.cgi?id=124652
2445
2446         Reviewed by Martin Robinson.
2447
2448         * MiniBrowser/gtk/BrowserWindow.c:
2449         (webViewDecidePolicy): Use the new API instead of
2450         webkit_web_view_can_show_mime_type().
2451
2452 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2453
2454         REGRESSION(r160304): [GTK] Disable libtool fast install
2455         https://bugs.webkit.org/show_bug.cgi?id=126381
2456
2457         Reviewed by Martin Robinson.
2458
2459         Remove -no-fast-install ld flag since fast install is now disabled
2460         globally.
2461
2462         * GNUmakefile.am:
2463         * GtkLauncher/GNUmakefile.am:
2464         * MiniBrowser/gtk/GNUmakefile.am:
2465         * TestWebKitAPI/GNUmakefile.am:
2466         * WebKitTestRunner/GNUmakefile.am:
2467
2468 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
2469
2470         Unreviewed. Add myself to EFL and related watch lists.
2471
2472         * Scripts/webkitpy/common/config/watchlist:
2473
2474 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
2475
2476         [GTK] fixing ycm_extra_conf.py file
2477         https://bugs.webkit.org/show_bug.cgi?id=126371
2478
2479         It's an attempt to fix three problems with the current ycm_extra_conf file.
2480         The current implementation assumes that it's a symlink, which is not true.
2481         Usually python creates a pyc file, and this is what you get in __file__.
2482         the .pyc is not a symlink, and the current implementation doesn't work
2483         if that's the case.
2484
2485         It also assumes that the user is in the root folder.
2486         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
2487
2488         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
2489         exception since "flag" doesn't exists.
2490
2491         All those things were fixed.
2492
2493         Reviewed by Martin Robinson.
2494
2495         * gtk/ycm_extra_conf.py:
2496         (transform_relative_paths_to_absolute_paths):
2497
2498 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
2499
2500         Bindings tests results links are broken at build.webkit.org/dashboard
2501         https://bugs.webkit.org/show_bug.cgi?id=126402
2502
2503         Reviewed by Tim Horton.
2504
2505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2506         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
2507         since the beginning.
2508
2509 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
2510
2511         "+" is very confusing at http://build.webkit.org/dashboard
2512         https://bugs.webkit.org/show_bug.cgi?id=126400
2513
2514         Reviewed by Tim Horton.
2515
2516         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2517         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
2518         source and internal counts separately, simply add them. One can always open a popover
2519         for more detail.
2520
2521 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
2522
2523         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
2524         https://bugs.webkit.org/show_bug.cgi?id=126391
2525
2526         Reviewed by Dan Bernstein.
2527
2528         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
2529         One can request credentials use via Initialization.js.
2530
2531         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2532         (Trac):
2533         (Trac.prototype.update):
2534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2535         (loadXML):
2536
2537 2014-01-02  Commit Queue  <commit-queue@webkit.org>
2538
2539         Unreviewed, rolling out r160846.
2540         http://trac.webkit.org/changeset/160846
2541         https://bugs.webkit.org/show_bug.cgi?id=126395
2542
2543         Breaks build scripts for Windows when Visual Studio is not
2544         installed in Program Files (Requested by rfong on #webkit).
2545
2546         * Scripts/webkitdirs.pm:
2547         (visualStudioInstallDir):
2548
2549 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
2550
2551         [GTK] [CMake] run-gtk-tests should run with the cmake build
2552         https://bugs.webkit.org/show_bug.cgi?id=126341
2553
2554         Reviewed by Carlos Garcia Campos.
2555
2556         * Scripts/run-gtk-tests:
2557         (TestRunner.__init__): Use the new calling conventions for the common script.
2558         (TestRunner._setup_testing_environment): Ditto.
2559         * gtk/common.py:
2560         (set_build_types): Added set_build_types, to avoid having build_type arguments
2561         for all functions in common.
2562         (binary_build_path): Added this function which gets the path to the built binaries.
2563         (get_build_path): Removed the build_types argument.
2564         (build_path): Removed the build_types argument and call get_build_path directly now.
2565
2566 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
2567
2568         https://bugs.webkit.org/show_bug.cgi?id=126391
2569         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
2570
2571         Rubber-stamped by Dan Bernstein.
2572
2573         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2574         (loadXML): Quick and dirty fix, with a FIXME.
2575
2576 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
2577
2578         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
2579         https://bugs.webkit.org/show_bug.cgi?id=126349
2580
2581         Reviewed by Carlos Garcia Campos.
2582
2583         All CMake ports use "libTestNetscapePlugin," so choosing the same
2584         name in the autotools port will make the transition easier.
2585
2586         * GNUmakefile.am: Rename the plugin library.
2587
2588 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
2589
2590         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
2591         https://bugs.webkit.org/show_bug.cgi?id=126354
2592
2593         Reviewed by Carlos Garcia Campos.
2594
2595         The latest visited site for backward history should be placed on the top of a history stack
2596         as a common behavior. However currently its order is reverse.
2597
2598         * MiniBrowser/gtk/BrowserWindow.c:
2599         (browserWindowUpdateNavigationActions):
2600
2601 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
2602
2603         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
2604         https://bugs.webkit.org/show_bug.cgi?id=126297
2605
2606         Reviewed by Philippe Normand.
2607
2608         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
2609         (TestRunner): Ditto.
2610         (TestRunner._run_test): Ditto.
2611
2612 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
2613
2614         full_results.json should distinguish unexpected failures from expected ones
2615         https://bugs.webkit.org/show_bug.cgi?id=126300
2616
2617         Reviewed by Timothy Hatcher.
2618
2619         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2620         (summarize_results): Add "report" element to JSON, which tells the consumer how
2621         this result was counted for summary.
2622
2623         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2624         Updated results to include the new element.
2625
2626         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2627         (print_unexpected_results): Added a comment pointing to another place that
2628         summarizes results, and should stay in sync.
2629
2630 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
2631
2632         Replace remaning CoreIPC namespace to IPC
2633         https://bugs.webkit.org/show_bug.cgi?id=126305
2634
2635         Reviewed by Anders Carlsson.
2636
2637         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
2638         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
2639         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
2640         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
2641
2642 2013-12-30  Brendan Long  <self@brendanlong.com>
2643
2644         Add myself to the committers list.
2645
2646         Unreviewed.
2647
2648         * Scripts/webkitpy/common/config/contributors.json:
2649
2650 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2651
2652         [GTK] Split WebKit2APITests/TestWebKitWebView
2653         https://bugs.webkit.org/show_bug.cgi?id=126284
2654
2655         Reviewed by Philippe Normand.
2656
2657         Skip only WebKitWebView/mouse-target and all TestAuthentication
2658         tests that are timing out when running under xvfb.
2659
2660         * Scripts/run-gtk-tests:
2661         (TestRunner):
2662
2663 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2664
2665         [EFL][WK2] Disable geolocation API test
2666         https://bugs.webkit.org/show_bug.cgi?id=125851
2667
2668         Reviewed by Gyuyoung Kim.
2669
2670         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
2671
2672         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
2673
2674 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
2675
2676         [EFL] Remove ewk_view_tiled
2677         https://bugs.webkit.org/show_bug.cgi?id=125961
2678
2679         Reviewed by Gyuyoung Kim.
2680
2681         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2682         (shouldUseTiledBackingStore):
2683         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
2684         instead of switching ewk_view_tiled.
2685         (DumpRenderTreeChrome::createView):
2686         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2687         (drtViewAdd):
2688         * EWebLauncher/main.c: Removed ewk_view_tiled option.
2689         (windowCreate):
2690         (parseUserArguments):
2691
2692 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
2693
2694         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
2695         https://bugs.webkit.org/show_bug.cgi?id=126278
2696
2697         Reviewed by Timothy Hatcher.
2698
2699         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2700         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
2701         as StatusLineView message element has extra padding, and doesn't fit the text snugly.
2702         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
2703
2704         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2705         (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
2706
2707         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2708         Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
2709
2710 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
2711
2712         Interrupted test runs should not count at build.webkit.org/dashboard
2713         https://bugs.webkit.org/show_bug.cgi?id=126279
2714
2715         Reviewed by Timothy Hatcher.
2716
2717         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2718         (BuildbotIteration.prototype.get productive):
2719         (BuildbotIteration.prototype.get previousProductiveIteration): Replaced previous with
2720         this accessor to skips iterations that don't have relevant data. We still want to
2721         display them, but revision ranges should not be affected.
2722         (BuildbotIteration.prototype.update): Record whether the iteration was up for retry.
2723
2724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2725         Use latest productive iteration instead of latest iteration for pending revision
2726         count and popovers.
2727
2728 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
2729
2730         Please display (and link to) revision ranges at build.webkit.org/dashboard
2731         https://bugs.webkit.org/show_bug.cgi?id=122187
2732
2733         Reviewed by Timothy Hatcher.
2734
2735         Added popovers for revision numbers. Removed direct links, because they were misleading -
2736         a test run covers a revision range, not just the latest revision. This also makes
2737         selecting a revision for copy easier.
2738
2739         All revision numbers have the popovers for consistency, although they are most useful
2740         for iterations that are not the last ones in a view, because the content is a delta
2741         from previous iteration.
2742
2743         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2744         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2745         revisionLinksForIteration() is now named revisionContentForIteration().
2746
2747         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2748         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2749         Ditto.
2750
2751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2752         (BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
2753
2754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2755         Refactored to support the new popover variation. Replaced revisionLinksForIteration()
2756         with a function that builds an element with popover.
2757
2758         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2759         Changed to take a function for popover presentation instead of delegate object.
2760         We only need one delegate function, and it's easier to have multiple popovers per view class
2761         this way.
2762
2763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2764         Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
2765
2766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2767         Renamed pending-commits-popover class to commit-history-popover.
2768
2769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2770         (.status-line .message .revision-number): Added a rule for revision numbers.
2771
2772 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
2773
2774         Please display information about pending runs in build.webkit.org/dashboard
2775         https://bugs.webkit.org/show_bug.cgi?id=122180
2776
2777         Reviewed by Timothy Hatcher.
2778
2779         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2780         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Added a semicolon at the end of a line.
2781
2782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2783         (BuildbotQueueView.prototype._latestFinishedIteration): Factored out of _appendPendingRevisionCount.
2784         (BuildbotQueueView.prototype._appendPendingRevisionCount): Install a popover tracker over the element.
2785         (BuildbotQueueView.prototype.lineForCommit): Build an element for a particular commit ot be shown in popover.
2786         (BuildbotQueueView.prototype.presentPopoverForElement): Build and show popover content when PopoverTracker
2787         asks us to.
2788
2789         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Geometry.js: Added.
2790         Taken from WebInspector with minimal changes:
2791         - Changed root name from WebInspector to Dashboard.
2792         - Removed some unused functionality.
2793         - Added Rect.containsPoint.
2794
2795         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js: Added.
2796         Popover has extensive changes compared to WebInspector version, only drawing code is the same:
2797         - Fixed to work in scrollable pages - WebInspector version assumes that window
2798         and document coordinates are the same, and also erroneously dismisses a scrollable
2799         popover if scrolling cascades out of it after reaching a bound.
2800         - Simplified API and implementation to Dashboard needs, it is no longer possible to
2801         change content of an existing popover.
2802         - Rewrote visibility tracking to be more complete, and not rely on external tracker
2803         object so much.
2804         - Added code to flash scroll bars when showing a scrollable popover.
2805
2806         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js: Added.
2807         Objects of this class show and hide popovers as appropriate for registered active elements.
2808
2809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2810         (StatusLineView.prototype.get messageElement): Added an accessor, so that we could
2811         install a popover on message element. It's the only visible element in pending commit
2812         line, but the line has different bounds, so we can't install a popover on it (it
2813         would be incorrectly positioned if we did).
2814
2815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2816         (Trac.prototype._convertCommitInfoElementToObject):
2817         - Some trac installations report author in a different element, updated to support that.
2818         - Changed to parse title out of description, because trac titles are ugly. Also,
2819         we get a nice HTML with links from the description.
2820
2821         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2822         (Node.prototype.isAncestor): Copied from Web Inspector, only changing the form for
2823         consistency with the rest of this file (add a property on prototype with assignment
2824         instead of using Object.defineProperty).
2825         (Node.prototype.isDescendant): Ditto.
2826         (Node.prototype.isSelfOrAncestor): Ditto.
2827         (Node.prototype.isSelfOrDescendant): Ditto.
2828         (DOMTokenList.prototype.contains): Ditto.
2829
2830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css: Added.
2831         Like JS counterpart, mostly lifted from Web Inspector.
2832
2833         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2834         Added style rules for pending commits popover.
2835
2836         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2837         (.status-line.no-bubble .message): Changed to display:inline-block, so that it fits
2838         to content, and we can show the popover in a correct place.
2839
2840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added new files.
2841
2842 2013-12-27  Gavin Barraclough  <barraclough@apple.com>
2843
2844         Merge PageVisibilityState & ViewState::IsVisible in WebKit2
2845         https://bugs.webkit.org/show_bug.cgi?id=126214
2846
2847         Reviewed by Alexey Proskuryakov.
2848
2849         WebKit2 redundantly tracks the visibility of the view through two mechanisms - the visibility
2850         state, and the view state. Remove visibility state from the WebKit2 layer. The visibility
2851         state also tracks the prerender state - so split this out and handle it separately (a change
2852         we should make in WebCore, too).
2853
2854         Tools - WebKit2 no longer (poorly) supports a fake visibility state, so to test the page
2855         visibility mechanisms we should actually be changing characteristics of the view that will
2856         be detected by WebKit2 as a visibility change. This affects three things:
2857             1) On setVisibilityState WebKitTestRunner must actually change visibility of the view.
2858             2) The 'PageVisibilityState' test in the API tests is useless (as evidenced by the fact
2859                that page visibility has been broken in WebKit2 for a couple of months, and didn't
2860                catch this fact). Removed in favour of:
2861             3) 'PageVisibilityStateWithWindowChanges' - this is the good stuff. This actually tests
2862                the visibility mechanism. Beef this test up by adding coverage for: a) the prerender
2863             state, b) document.hidden, and c) too many state change notifications (it already looks
2864             for too few).
2865
2866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2867         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Removed.
2868             - Removed PageVisibilityState - this test was ineffective, API no longer supports this
2869               test, and behaviour is covered by PageVisibilityStateWithWindowChanges.
2870         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2871         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2872         (runJavaScriptAlert):
2873             - Add checking for too many calls to the alert.
2874         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::setPrerender):
2875             - Added methods to set visibility to prerender.
2876         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2877             - Added checking of 'document.hidden'.
2878         * WebKitTestRunner/TestController.cpp:
2879         (WTR::TestController::setVisibilityState):
2880         * WebKitTestRunner/TestController.h:
2881         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2882         (WTR::TestController::setHidden):
2883         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2884         (WTR::TestController::setHidden):
2885         * WebKitTestRunner/mac/TestControllerMac.mm:
2886         (WTR::TestController::setHidden):
2887             - Add setHidden method; call this from setVisibilityState.
2888
2889 2013-12-27  Alexey Proskuryakov  <ap@apple.com>
2890
2891         Display EWS status on bot watcher's dashboard
2892         https://bugs.webkit.org/show_bug.cgi?id=126224
2893
2894         Silence spurious exceptions, no visible behavior change.
2895
2896         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2897         (EWSQueue.prototype.update): Removed code that was only needed for an experimental
2898         feature that wasn't landed.
2899
2900 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
2901
2902         Display EWS status on bot watcher's dashboard
2903         https://bugs.webkit.org/show_bug.cgi?id=126224
2904
2905         Reviewed by Timothy Hatcher.
2906
2907         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added.
2909         Moved platform definitions out of Buildbot.js, as they are also needed for EWS.
2910
2911         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2912         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: Added.
2913         (QueueView):
2914         (QueueView.prototype.updateSoon):
2915         (QueueView.prototype.update):
2916         (QueueView.prototype._updateHiddenState):
2917         Moved auto-update and hide logic to a base class, as it equally applies to EWS.
2918
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Added.
2920         This is a peer to Buildbot.js and WebKitBuildbot.js.
2921
2922         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Added.
2923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Added.
2924         Quite simple for now, only keeping track of queue size.
2925         
2926         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2927         Initialize EWS.
2928
2929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2930         Create EWS views.
2931
2932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2933         Updated for Buildbot.Platform rename, it's now Dashboard.Platform.
2934
2935         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Removed.
2936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Removed.
2937         These were empty, no reason to waste the time loading them.
2938
2939         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Removed.
2940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css.
2941         Renamed, as these styles apply to all queues, not just buildbot ones (and they have to, as columns should look alike).
2942
2943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2944             - Changed page title, as it no longer displays just buildbot status.
2945             - Updated subresource lists for the new, renamed and removed files.
2946
2947 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
2948
2949         EWS status JSON should include Access-Control-Allow-Origin
2950         https://bugs.webkit.org/show_bug.cgi?id=126246
2951
2952         Reviewed by Ryosuke Niwa.
2953
2954         * QueueStatusServer/app.yaml: Update version.
2955         * QueueStatusServer/handlers/queuestatusjson.py:
2956         (QueueStatusJSON.get): Add the header field.
2957
2958 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
2959
2960         Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
2961         https://bugs.webkit.org/show_bug.cgi?id=126234
2962
2963         Reviewed by Timothy Hatcher.
2964
2965         Changed elements that are semantically links from <div> to <a>.
2966
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2968         (StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
2969         Don't try simulate a link with CSS/JS, it's not needed any more.
2970         (StatusLineView.prototype._clicked): Removed.
2971
2972         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
2973         Removed text-decoration rules, default ones in Main.css now work for queue elements.
2974
2975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2976         Simplified cursor rules.
2977         Added a universal rule for links to only show underline on hover, as this is what
2978         we want almost everywhere.
2979
2980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2981         (.status-line .bubble): Added text-decoration: none, as this is the one place where
2982         we don't want it even on hover.
2983         (.status-line .label): Force display: block for consistent layout between <a>
2984         and <div>.
2985
2986 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
2987
2988         Please clarify "pending" reporting at build.webkit.org/dashboard
2989         https://bugs.webkit.org/show_bug.cgi?id=122191
2990
2991         Reviewed by Timothy Hatcher.
2992
2993         Reporting the count of pending runs didn't make a lot of sense - first, runs are
2994         coalesced and sometimes even out of order, and second, buildbot's notion of pending
2995         run was confusingly different from dashboard's.
2996
2997         Let's display how many SVN revisions are pending. This can be somewhat misleading
2998         too, because some revisions (like those for other platforms) don't trigger builds,
2999         but it's better than what we had.
3000
3001         This patch also lays the groundwork for displaying detailed information about
3002         pending revisions.
3003
3004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3005         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
3006         building pending status line directly, call newly added base class method.
3007
3008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3009         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Ditto.
3010
3011         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3012         (BuildbotQueueView): Listen for events when new SVN revisions are landed, and update the view.
3013         (BuildbotQueueView.prototype._appendPendingRevisionCount): Add a line for pending
3014         SVN revisions. It uses a new style, StatusLineView.Status.NoBubble, because this
3015         information is secondary, and doesn't need as much attention.
3016         (BuildbotQueueView.prototype.revisionLinksForIteration): Build revisionURL through
3017         Trac, not through Buildbot.
3018         (BuildbotQueueView.prototype._newCommitsRecorded): Schedule an update, just like when
3019         iterations are updated.
3020
3021         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3022         Initialize a global webkitTrac object.
3023
3024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3026         Added a new style for messages without a bubble.
3027
3028         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3029         Added a model class for Trac, which keeps track of SVN timeline, and notifies
3030         listeners of changes. It uses an RSS interface to Trac, because there is no JSON one.
3031
3032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3033         (loadXML): Added a function to load XML asynchronously, just like existing JSON.load.
3034
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3036         Removed tracRevisionURL() function. Now that we have a Trac object, it just makes
3037         more sense to build trac URLs through it.
3038
3039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3040         Load Trac.js.
3041
3042 2013-12-25  Jongwoo Choi  <jw0330.choi@samsung.com>
3043
3044         [EFL] Activate keyboard homepage shortcut on efl minibrowser.
3045         https://bugs.webkit.org/show_bug.cgi?id=124636
3046
3047         Reviewed by Gyuyoung Kim.
3048
3049         * MiniBrowser/efl/main.c: Added.
3050         (on_key_down): Add a homepage shortcut using Alt + Home key. 
3051
3052 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
3053
3054         Revision selection behavior at build.webkit.org/dashboard is annoying
3055         https://bugs.webkit.org/show_bug.cgi?id=126235
3056
3057         Reviewed by Tim Horton.
3058
3059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3060         (BuildbotQueueView.prototype.revisionLinksForIteration): Make the whole message
3061         selectable, not just the numbers in it.
3062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3063         (.selectable): Make selectable enable default behavior, not user-select:all.
3064
3065 2013-12-25  Martin Robinson  <mrobinson@igalia.com>
3066
3067         [GTK] [CMake] Clean up generated sources directories
3068         https://bugs.webkit.org/show_bug.cgi?id=126216
3069
3070         Reviewed by Gustavo Noronha Silva.
3071
3072         * DumpRenderTree/PlatformGTK.cmake: Use the new derived sources variables.
3073         * GtkLauncher/CMakeLists.txt: Ditto.
3074         * MiniBrowser/gtk/CMakeLists.txt: Ditto.
3075         * TestWebKitAPI/CMakeLists.txt: Now that the EFL and GTK+ forwarding header locations differ,
3076         move the platform-specific includes to the EFL and GTK platform files. Also clean up forwarding
3077         header generation into on target.
3078         * TestWebKitAPI/PlatformEfl.cmake: Added EFL-specific locations to the include list.
3079         * TestWebKitAPI/PlatformGTK.cmake: Added GTK-specific locations to the include list.
3080         * WebKitTestRunner/CMakeLists.txt: Same as for TestWebKitAPI.
3081         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
3082         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3083         * gtk/generate-gtkdoc: Update to select the appropriate derived sources locations for
3084         the cmake build.
3085
3086 2013-12-23  Alexey Proskuryakov  <ap@apple.com>
3087
3088         Add a JSON interface for getting EWS queue status
3089         https://bugs.webkit.org/show_bug.cgi?id=126182
3090
3091         Reviewed by Ryosuke Niwa.
3092
3093         The current goal is to add an indicator of how many patches are in the queue, and
3094         the JSON also includes some other information that was easy to add.
3095
3096         * QueueStatusServer/app.yaml: Updated version for deployment.
3097
3098         * QueueStatusServer/handlers/queuestatusjson.py: Added. Returns a JSON with some
3099         bot and patch queue information.
3100
3101         * QueueStatusServer/index.yaml: Added an index for a new query that only returns
3102         bot ids.
3103
3104         * QueueStatusServer/main.py: Map /queue-status-json/ directory to QueueStatusJSON
3105         handler.
3106
3107         * QueueStatusServer/config: Added property svn:ignore.
3108         * QueueStatusServer/filters: Added property svn:ignore.
3109         * QueueStatusServer/loggers: Added property svn:ignore.
3110         * QueueStatusServer/handlers: Added property svn:ignore.
3111         * QueueStatusServer/model: Added property svn:ignore.
3112         Ignore compiled *.pyc files in all directories they appear in when running locally.
3113
3114 2013-12-23  Martin Robinson  <mrobinson@igalia.com>
3115
3116         Try to fix the build after r161017
3117
3118         * gtk/common.py:
3119         (is_cmake_build): Instead of checking whether the return value of build_path
3120         of the CMakeCache.txt file is None, check if a file actually exists at that path.
3121
3122 2013-12-23  Gustavo Noronha Silva  <gns@gnome.org>
3123
3124         [GTK] [CMake] Add support for generating gtkdoc
3125         https://bugs.webkit.org/show_bug.cgi?id=116376
3126
3127         Reviewed by Martin Robinson.
3128
3129         * gtk/common.py: look for files in the directories used by the cmake build as well.
3130
3131 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3132
3133         [GTK] Build with network process unconditionally
3134         https://bugs.webkit.org/show_bug.cgi?id=126128
3135
3136         Reviewed by Martin Robinson.
3137
3138         * Scripts/webkitperl/FeatureList.pm: Remove network-process
3139         feature command line option.
3140
3141 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3142
3143         [GTK] run-gtk-tests should always run glib tests with -k option
3144         https://bugs.webkit.org/show_bug.cgi?id=126132
3145
3146         Reviewed by Philippe Normand.
3147
3148         With -k command line option, gtester continues running all other
3149         test cases after a failure.
3150
3151         * Scripts/run-gtk-tests:
3152         (TestRunner._run_test_glib): Use -k option when runing glib tests
3153         to not stop on failure.
3154
3155 2013-12-22  Martin Robinson  <mrobinson@igalia.com>
3156
3157         [GTK][CMake] Integrate GResource for inspector files (and others?)
3158         https://bugs.webkit.org/show_bug.cgi?id=125569
3159
3160         Reviewed by Gustavo Noronha Silva.
3161
3162         * gtk/generate-inspector-gresource-manifest.py: Added.
3163
3164 2013-12-22  Csaba Osztrogonác  <ossy@webkit.org>
3165
3166         Last URTBF after r160971 to make EFL build happy.
3167
3168         * TestWebKitAPI/efl/PlatformWebView.cpp:
3169         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3170
3171 2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3172
3173         Unreviewed. Add myself to some more watch lists.
3174
3175         * Scripts/webkitpy/common/config/watchlist: Watch also soup, gst
3176         and binding scripts patches.
3177
3178 2013-12-20  Commit Queue  <commit-queue@webkit.org>
3179
3180         Unreviewed, rolling out r160941.
3181         http://trac.webkit.org/changeset/160941
3182         https://bugs.webkit.org/show_bug.cgi?id=126095
3183
3184         Doesn't handle subpixel layout being disabled (Requested by
3185         smfr on #webkit).
3186
3187         * gdb/webkit.py:
3188         (JSCJSStringPrinter.to_string):
3189         (add_pretty_printers):
3190         * lldb/lldb_webkit.py:
3191         (WTFMediaTime_SummaryProvider):
3192         (WTFStringProvider.to_string):
3193
3194 2013-12-20  Bem Jones-Bey  <bjonesbe@adobe.com>
3195
3196         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb
3197         https://bugs.webkit.org/show_bug.cgi?id=126080
3198
3199         Reviewed by Anders Carlsson.
3200
3201         This changes the output of printing LayoutUnits to be in px, removing
3202         the need to divide by 64 manually.
3203
3204         This will lead to gdb output like:
3205
3206         m_frameRect = {
3207             m_location = LayoutPoint(0px, 0px),
3208             m_size = LayoutSize(800px, 585px)
3209         }
3210
3211         And lldb output like:
3212
3213         (const WebCore::LayoutRect) $0 = {
3214           m_location = { x = 744px, y = 1px }
3215           m_size = { width = 236px, height = 40px }
3216         }
3217
3218         This patch is based on patch for Blink by cbiesinger@chromium.org.
3219
3220         * gdb/webkit.py:
3221         (WebCoreLayoutUnitPrinter):
3222         (WebCoreLayoutUnitPrinter.__init__):
3223         (WebCoreLayoutUnitPrinter.to_string):
3224         (WebCoreLayoutSizePrinter):
3225         (WebCoreLayoutSizePrinter.__init__):
3226         (WebCoreLayoutSizePrinter.to_string):
3227         (WebCoreLayoutPointPrinter):
3228         (WebCoreLayoutPointPrinter.__init__):
3229         (WebCoreLayoutPointPrinter.to_string):
3230         (add_pretty_printers):
3231         * lldb/lldb_webkit.py:
3232         (__lldb_init_module):
3233         (WebCoreLayoutUnit_SummaryProvider):
3234         (WebCoreLayoutSize_SummaryProvider):
3235         (WebCoreLayoutPoint_SummaryProvider):
3236         (WebCoreLayoutUnitProvider):
3237         (WebCoreLayoutUnitProvider.__init__):
3238         (WebCoreLayoutUnitProvider.to_string):
3239         (WebCoreLayoutSizeProvider):
3240         (WebCoreLayoutSizeProvider.__init__):
3241         (WebCoreLayoutSizeProvider.get_width):
3242         (WebCoreLayoutSizeProvider.get_height):
3243         (WebCoreLayoutPointProvider):
3244         (WebCoreLayoutPointProvider.__init__):
3245         (WebCoreLayoutPointProvider.get_x):
3246         (WebCoreLayoutPointProvider.get_y):
3247
3248 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
3249
3250         [GTK] [CMake] Add support for building ImageDiff
3251         https://bugs.webkit.org/show_bug.cgi?id=125960
3252
3253         Reviewed by Gustavo Noronha Silva.
3254
3255         * CMakeLists.txt: Build ImageDiff for GTK+.
3256         * ImageDiff/PlatformGTK.cmake: Added.
3257
3258 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
3259
3260         [GTK] [CMake] Add support for building DumpRenderTree
3261         https://bugs.webkit.org/show_bug.cgi?id=125767
3262
3263         Reviewed by Gustavo Noronha Silva.
3264
3265         * CMakeLists.txt: Load the DumpRenderTree cmake file for GTK+ when WebKit1 is enabled.
3266         * DumpRenderTree/PlatformGTK.cmake: Added.
3267
3268 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
3269
3270         [GTK] [CMake] Add support for building WebKitTestRunner
3271         https://bugs.webkit.org/show_bug.cgi?id=125768
3272
3273         Reviewed by Gustavo Noronha Silva.
3274
3275         * CMakeLists.txt: Compile WebKitTestRunner for GTK+ when WebKit2 is enabled.
3276         * WebKitTestRunner/CMakeLists.txt: Remove some EFL specific flags from the common
3277         build file.
3278         * WebKitTestRunner/PlatformEfl.cmake: Move the flags here.
3279         * WebKitTestRunner/PlatformGTK.cmake: Added.
3280
3281 2013-12-20  Myles C. Maxfield  <mmaxfield@apple.com>
3282
3283         Myles C. Maxfield is a committer now
3284
3285         Unreviewed.
3286
3287         * Scripts/webkitpy/common/config/contributors.json:
3288
3289 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3290
3291         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
3292         https://bugs.webkit.org/show_bug.cgi?id=125854
3293
3294         Reviewed by Chris Fleizach.
3295
3296         Ensure we don't ever create instances of AccessibilityUIElement
3297         wrapping invalid platform-specific accessibility objects in DRT,
3298         both for consistency with what WKTR does (so we avoid situations
3299         where some tests fail in WK2 and not in WK1) and also to avoid
3300         overlooking tests that might not be checking the right thing.
3301
3302         * DumpRenderTree/AccessibilityUIElement.cpp:
3303         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
3304         nullPtr if the platformUIElement() is not a valid one.
3305         * DumpRenderTree/AccessibilityUIElement.h:
3306         (AccessibilityUIElement::platformUIElement): Added const modifier.
3307
3308 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3309
3310         Programmatically-inserted children lack accessibility events
3311         https://bugs.webkit.org/show_bug.cgi?id=100275
3312
3313         Reviewed by Chris Fleizach.
3314
3315         Update DRT and WebKitTestRunner to handle the children-changed
3316         signal properly, considering the detail and optional parameters.
3317
3318         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
3319         (axObjectEventListener):
3320         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
3321
3322 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3323
3324         Removed unused BUILDER_BASE_URL.
3325         https://bugs.webkit.org/show_bug.cgi?id=125442
3326
3327         Reviewed by Csaba Osztrogonác.
3328
3329         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3330         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
3331
3332 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3333
3334         Removed unused BUILDER_BASE_URL.
3335         https://bugs.webkit.org/show_bug.cgi?id=125442
3336
3337         Reviewed by Csaba Osztrogonác.
3338
3339         The string constant BUILDER_BASE_URL is passed around several times,
3340         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
3341
3342         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3343         (Manager._upload_json_files):
3344         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3345         (JSONLayoutResultsGenerator.__init__):
3346         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3347         (JSONResultsGenerator.__init__):
3348
3349 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
3350
3351         check-webkit-style mistakenly flags assigning to a dereferenced pointer
3352         https://bugs.webkit.org/show_bug.cgi?id=126041
3353
3354         Reviewed by Ryosuke Niwa.
3355
3356         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
3357         sure that there is a declaration. This patch makes sure that there is a
3358         declaration in order to flag spacing around asterisks.
3359
3360         * Scripts/webkitpy/style/checkers/cpp.py:
3361         (check_spacing):
3362         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3363         (CppStyleTest.test_pointer_reference_marker_location):
3364
3365 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
3366
3367         check-webkit-style marks rvalue references as violations
3368         https://bugs.webkit.org/show_bug.cgi?id=126000
3369
3370         Reviewed by Ryosuke Niwa.
3371
3372         Previously, check-webkit-style was making sure that any line with "&&" had
3373         spaces around it. However, we can now legitimately use "&&" without a previous
3374         space when declaring an rvalue reference. This patch relaxes this check.
3375
3376         * Scripts/webkitpy/style/checkers/cpp.py:
3377         (check_spacing):
3378         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3379         (CppStyleTest.test_spacing_for_binary_ops):
3380
3381 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
3382
3383         check-webkit-style marks auto return types for functions as violations
3384         https://bugs.webkit.org/show_bug.cgi?id=125999
3385
3386         Reviewed by Ryosuke Niwa.
3387
3388         If a function declaration ends with a "->" followed by a non whitespace
3389         string, don't mark as an invalid "{" on its own line
3390
3391         * Scripts/webkitpy/style/checkers/cpp.py:
3392         (check_braces):
3393         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3394         (CppStyleTest.test_brace_at_begin_of_line):
3395
3396 2013-12-19  Alex Christensen  <achristensen@webkit.org>
3397
3398         [WinCairo] More GStreamer preparations.
3399
3400         Unreviewed.
3401
3402         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
3403         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
3404
3405 2013-12-19  Lucas Forschler  <lforschler@apple.com>
3406
3407         Add Apple Mavericks perf bot.
3408         
3409         Unreviewed.
3410
3411         * BuildSlaveSupport/build.webkit.org-config/config.json:
3412
3413 2013-12-19  Commit Queue  <commit-queue@webkit.org>
3414
3415         Unreviewed, rolling out r160842.
3416         http://trac.webkit.org/changeset/160842
3417         https://bugs.webkit.org/show_bug.cgi?id=126003
3418
3419         broke accessibility/loading-iframe-updates-axtree.html
3420         (Requested by ap on #webkit).
3421
3422         * DumpRenderTree/AccessibilityUIElement.cpp:
3423         (AccessibilityUIElement::makeJSAccessibilityUIElement):
3424         * DumpRenderTree/AccessibilityUIElement.h:
3425         (AccessibilityUIElement::platformUIElement):
3426
3427 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3428
3429         get_test_baseline should get Host from test_config
3430         https://bugs.webkit.org/show_bug.cgi?id=125989
3431
3432         Reviewed by Ryosuke Niwa.
3433
3434         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3435         (TestConfig.__init__):
3436         (RebaselineServer._prepare_config):
3437         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3438         (get_test_baselines):
3439         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3440         (get_test_config):
3441
3442 2013-12-19  Roger Fong  <roger_fong@apple.com>
3443
3444         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
3445         https://bugs.webkit.org/show_bug.cgi?id=125998.
3446
3447         Reviewed by Alexey Proskuryakov.
3448
3449         * Scripts/webkitdirs.pm:
3450         (visualStudioInstallDir):
3451         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
3452
3453 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
3454
3455         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
3456         https://bugs.webkit.org/show_bug.cgi?id=125854
3457
3458         Reviewed by Chris Fleizach.
3459
3460         Ensure we don't ever create instances of AccessibilityUIElement
3461         wrapping invalid platform-specific accessibility objects in DRT,
3462         both for consistency with what WKTR does (so we avoid situations
3463         where some tests fail in WK2 and not in WK1) and also to avoid
3464         overlooking tests that might not be checking the right thing.
3465
3466         * DumpRenderTree/AccessibilityUIElement.cpp:
3467         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
3468         nullPtr if the platformUIElement() is not a valid one.
3469         * DumpRenderTree/AccessibilityUIElement.h:
3470         (AccessibilityUIElement::platformUIElement): Added const modifier.
3471
3472 2013-12-18  Anders Carlsson  <andersca@apple.com>
3473
3474         Deprecate some WKMutableDictionary functions
3475         https://bugs.webkit.org/show_bug.cgi?id=125962
3476
3477         Reviewed by Tim Horton.
3478
3479         * TestWebKitAPI/PlatformUtilities.cpp:
3480         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
3481         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
3482         (TestWebKitAPI::didAssociateFormControls):
3483         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
3484         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
3485         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
3486         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3487         (WTR::createMouseMessageBody):
3488         (WTR::EventSendingController::mouseMoveTo):
3489         (WTR::EventSendingController::leapForward):
3490         (WTR::createKeyDownMessageBody):
3491         (WTR::EventSendingController::mouseScrollBy):
3492         (WTR::EventSendingController::continuousMouseScrollBy):
3493         (WTR::EventSendingController::addTouchPoint):
3494         (WTR::EventSendingController::updateTouchPoint):
3495         (WTR::EventSendingController::setTouchModifier):
3496         (WTR::EventSendingController::setTouchPointRadius):
3497         (WTR::EventSendingController::touchStart):
3498         (WTR::EventSendingController::touchMove):
3499         (WTR::EventSendingController::touchEnd):
3500         (WTR::EventSendingController::touchCancel):
3501         (WTR::EventSendingController::clearTouchPoints):
3502         (WTR::EventSendingController::releaseTouchPoint):
3503         (WTR::EventSendingController::cancelTouchPoint):
3504         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3505         (WTR::InjectedBundle::done):
3506         (WTR::InjectedBundle::setMockGeolocationPosition):
3507         (WTR::InjectedBundle::setCustomPolicyDelegate):
3508         (WTR::InjectedBundle::setVisibilityState):
3509         (WTR::InjectedBundle::queueLoad):
3510         (WTR::InjectedBundle::queueLoadHTMLString):
3511         * WebKitTestRunner/TestController.cpp:
3512         (WTR::TestController::initialize):
3513         (WTR::TestController::resetStateToConsistentValues):
3514         * WebKitTestRunner/TestInvocation.cpp:
3515         (WTR::updateThreadedScrollingForCurrentTest):
3516         (WTR::updateLayoutType):
3517         (WTR::TestInvocation::invoke):
3518
3519 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
3520
3521         [GTK] [CMake] Add support for building GtkLauncher
3522         https://bugs.webkit.org/show_bug.cgi?id=125766
3523
3524         Reviewed by Gustavo Noronha Silva.
3525
3526         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
3527         * GtkLauncher/CMakeLists.txt: Added.
3528         * GtkLauncher/main.c: Support including the CMake config file.
3529
3530 2013-12-18  Alex Christensen  <achristensen@webkit.org>
3531
3532         [WinCairo] Preparation for GStreamer on Windows.
3533         https://bugs.webkit.org/show_bug.cgi?id=125946
3534
3535         Reviewed by Brent Fulgham.
3536
3537         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3538         Use new GStreamer property sheets for WinCairo.
3539         * win/DLLLauncher/DLLLauncherMain.cpp:
3540         (modifyPath):
3541         (wWinMain):
3542         Prepend GStreamer bin directory to path if it exists.
3543
3544 2013-12-18  Anders Carlsson  <andersca@apple.com>
3545
3546         Remove now useless test.
3547
3548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3549         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
3550         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
3551         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
3552
3553 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
3554
3555         Fix page visibility api test, initialization in WebKit2
3556         https://bugs.webkit.org/show_bug.cgi?id=125933
3557
3558         Reviewed by Anders Carlsson.
3559
3560         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
3561         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
3562
3563         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3564         (TestWebKitAPI::TEST_F):
3565             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
3566
3567 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3568
3569         Should not have identifiers with underscores in them, especially not leading underscores.
3570         https://bugs.webkit.org/show_bug.cgi?id=125847
3571