Remove remaining poisoning code.
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-26  Mark Lam  <mark.lam@apple.com>
2
3         Remove remaining poisoning code.
4         https://bugs.webkit.org/show_bug.cgi?id=194138
5
6         Reviewed by Saam Barati.
7
8         * TestWebKitAPI/CMakeLists.txt:
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
11         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
12         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
13         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
14         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
15         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
16
17 2019-02-26  Alex Christensen  <achristensen@webkit.org>
18
19         Move ephemeral local storage from WebProcess to UIProcess
20         https://bugs.webkit.org/show_bug.cgi?id=195074
21         <rdar://problem/47937975>
22
23         Reviewed by Geoff Garen.
24
25         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
26
27 2019-02-20  Jer Noble  <jer.noble@apple.com>
28
29         [Cocoa] Media elements will restart network buffering just before suspending
30         https://bugs.webkit.org/show_bug.cgi?id=193691
31
32         Reviewed by Eric Carlson.
33
34         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
35         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
36         (TEST):
37
38 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
39
40         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
41         https://bugs.webkit.org/show_bug.cgi?id=191652
42
43         Reviewed by Alex Christensen.
44
45         Fix WinCairo MiniBrowser behavior of authentication dialog.
46
47         * MiniBrowser/win/WebKitBrowserWindow.cpp:
48         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
49
50 2019-02-26  Youenn Fablet  <youenn@apple.com>
51
52         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
53         https://bugs.webkit.org/show_bug.cgi?id=195028
54         <rdar://problem/48243733>
55
56         Reviewed by Eric Carlson.
57
58         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
59
60 2019-02-26  Philippe Normand  <pnormand@igalia.com>
61
62         [WPE] Add API for webview background color configuration
63         https://bugs.webkit.org/show_bug.cgi?id=192305
64
65         Reviewed by Michael Catanzaro.
66
67         * MiniBrowser/wpe/main.cpp:
68         (main): Add a new option to configure the webview background
69         color. Example: --bg-color=transparent.
70         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
71         (testWebViewBackgroundColor): Enable background color API tests for WPE.
72         (beforeAll): Ditto.
73
74 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
75
76         scalableNativeWebpageParameters() is not preserved on new page navigation.
77         https://bugs.webkit.org/show_bug.cgi?id=194892
78         <rdar://problem/47538280>
79
80         Reviewed by Wenson Hsieh.
81         
82         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
83
84         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
85         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
86         * DumpRenderTree/mac/UIScriptControllerMac.mm:
87         (WTR::UIScriptController::allowsViewportShrinkToFit):
88         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
89         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
90         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
91         * TestRunnerShared/UIScriptContext/UIScriptController.h:
92         * WebKitTestRunner/UIScriptControllerCocoa.mm:
93         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
94
95 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
96
97         [ews-app] Add model for handling multiple Buildbot instances
98         https://bugs.webkit.org/show_bug.cgi?id=194863
99
100         Reviewed by Stephanie Lewis.
101
102         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
103
104 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
105
106         [ews-app] Remove BuilderMapping table
107         https://bugs.webkit.org/show_bug.cgi?id=194961
108
109         Reviewed by Stephanie Lewis.
110
111         Store builder name directly in build table, instead of having a separate
112         table for it.
113
114         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
115         * BuildSlaveSupport/ews-app/ews/models/build.py:
116         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
117         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
118
119 2019-02-25  John Wilander  <wilander@apple.com>
120
121         Introduce and adopt new class RegistrableDomain for eTLD+1
122         https://bugs.webkit.org/show_bug.cgi?id=194791
123         <rdar://problem/48179240>
124
125         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
126
127         This patch adds an API test and replaces two instances of
128         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
129
130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
131         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
132         (TestWebKitAPI::TEST):
133             Changed two strings to make sure the registrable domains are still considered
134             invalid and pass the test.
135         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
136         (TestWebKitAPI::TEST):
137         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
138         (WTR::InjectedBundle::didReceiveMessageToPage):
139
140 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
141
142         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
143         https://bugs.webkit.org/show_bug.cgi?id=195001
144
145         Reviewed by Carlos Garcia Campos.
146
147         API version 1.0 always includes the functionality previously guarded with
148         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
149         unconditionally.
150
151         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
152         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
153         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
154         (WebViewTest::showInWindow): Ditto.
155         (WebViewTest::hideView): Ditto.
156         * wpe/backends/HeadlessViewBackend.cpp:
157         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
158         * wpe/backends/ViewBackend.cpp:
159         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
160         * wpe/backends/WindowViewBackend.cpp:
161         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
162         WPE_BACKEND_CHECK_VERSION().
163         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
164
165 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
166
167         [Flatpak] Add support for flatpak > 1.1.2
168         https://bugs.webkit.org/show_bug.cgi?id=194088
169
170         Flatpak 1.2 is now out so we need to support that
171         version now.
172
173         Reviewed by Michael Catanzaro.
174
175         * flatpak/flatpakutils.py:
176         (check_flatpak):
177         (FlatpakPackages.__init__):
178         (FlatpakPackages.__detect_packages):
179         (FlatpakPackages.__detect_packages.in):
180         (FlatpakRepos.update):
181
182 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
183
184         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
185         https://bugs.webkit.org/show_bug.cgi?id=194998
186
187         Reviewed by Carlos Garcia Campos.
188
189         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
190         to a Git checkout and using the latest commit containing various fixes
191         and improvements.
192
193 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
194
195         [WPE][GTK] Remove user agent quirk for washingtonpost.com
196         https://bugs.webkit.org/show_bug.cgi?id=194981
197
198         Reviewed by Žan Doberšek.
199
200         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
201         (TestWebKitAPI::TEST):
202
203 2019-02-23  Keith Miller  <keith_miller@apple.com>
204
205         Add new mac target numbers
206         https://bugs.webkit.org/show_bug.cgi?id=194955
207
208         Reviewed by Tim Horton.
209
210         * DumpRenderTree/mac/Configurations/Base.xcconfig:
211         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
212         * MiniBrowser/Configurations/Base.xcconfig:
213         * TestWebKitAPI/Configurations/Base.xcconfig:
214         * WebKitTestRunner/Configurations/Base.xcconfig:
215
216 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
217
218         [WinCairo] Enable wk1/wk2 suffix for platform search path.
219         https://bugs.webkit.org/show_bug.cgi?id=194846
220
221         Reviewed by Don Olmstead.
222
223         Added _search_paths() and _port_specific_expectations_files() for
224         WinCairoPort.
225
226         * Scripts/webkitpy/port/win.py:
227         (WinCairoPort.default_baseline_search_path):
228         (WinCairoPort):
229         (WinCairoPort._port_specific_expectations_files):
230         (WinCairoPort._search_paths):
231
232 2019-02-22  Tim Horton  <timothy_horton@apple.com>
233
234         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
235         https://bugs.webkit.org/show_bug.cgi?id=194963
236
237         Reviewed by Dean Jackson.
238
239         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
240         Do a `contains` check instead of `equals`, because in debug builds we
241         put the GraphicsLayer pointer in a prefix.
242
243 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
244
245         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
246         https://bugs.webkit.org/show_bug.cgi?id=194873
247         <rdar://problem/46701974>
248
249         Reviewed by Tim Horton.
250
251         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
252
253         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
254         (WTR::UIScriptController::menuRect const):
255         (WTR::UIScriptController::isShowingMenu const):
256         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
257         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
258         (WTR::UIScriptController::menuRect const):
259
260         Add a function to query the bounds of the callout menu in content coordinates.
261
262         (WTR::UIScriptController::isShowingMenu const):
263
264         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
265
266         * TestRunnerShared/UIScriptContext/UIScriptController.h:
267         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
268         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
269         (WTR::UIScriptController::rectForMenuAction const):
270         (WTR::UIScriptController::menuRect const):
271         (WTR::UIScriptController::isShowingMenu const):
272         (WTR::findViewInHierarchyOfType): Deleted.
273
274 2019-02-22  Chris Dumez  <cdumez@apple.com>
275
276         Regression(PSON) Unable to preview password-protected documents on iCloud.com
277         https://bugs.webkit.org/show_bug.cgi?id=194954
278         <rdar://problem/48127957>
279
280         Reviewed by Alex Christensen.
281
282         Add API test coverage.
283
284         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
285         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
286         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
287         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
288
289 2019-02-22  Chris Dumez  <cdumez@apple.com>
290
291         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
292         https://bugs.webkit.org/show_bug.cgi?id=194924
293         <rdar://problem/48216125>
294
295         Reviewed by Geoffrey Garen.
296
297         Add API test coverage.
298
299         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
300
301 2019-02-22  Chris Dumez  <cdumez@apple.com>
302
303         Unreviewed, disable API test added in r241928 on iOS.
304
305         The cache is not enabled on devices with less than 3GB of RAM.
306
307         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
308
309 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
310
311         Hardcode Visual Viewports on everywhere except iOS WK1
312         https://bugs.webkit.org/show_bug.cgi?id=194928
313
314         Reviewed by Zalan Bujtas.
315
316         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
317         change the default value of the Setting to 'true', and hardcode WebView on iOS to
318         set it to false. The setting has shipped for several years and there's no need to turn
319         it off now.
320
321         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
322         Visual Viewports are not enabled.
323         
324         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
325         that only runs in WK2
326
327         * MiniBrowser/mac/SettingsController.h:
328         * MiniBrowser/mac/SettingsController.m:
329         (-[SettingsController init]):
330         (-[SettingsController _populateMenu]):
331         (-[SettingsController validateMenuItem:]):
332         (-[SettingsController visualViewportEnabled]): Deleted.
333         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
334         * MiniBrowser/mac/WK1BrowserWindowController.m:
335         (-[WK1BrowserWindowController didChangeSettings]):
336         * MiniBrowser/mac/WK2BrowserWindowController.m:
337         (-[WK2BrowserWindowController didChangeSettings]):
338
339 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
340
341         Discard cached processes when clearing website data store
342         https://bugs.webkit.org/show_bug.cgi?id=194894
343
344         Reviewed by Chris Dumez.
345
346         Added a test case.
347
348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
349         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
350
351 2019-02-21  Alex Christensen  <achristensen@webkit.org>
352
353         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
354         https://bugs.webkit.org/show_bug.cgi?id=194914
355         <rdar://problem/47586889>
356
357         Reviewed by Geoffrey Garen.
358
359         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
360         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
361         (TEST):
362         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
363
364 2019-02-21  David Kilzer  <ddkilzer@apple.com>
365
366         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
367         <https://webkit.org/b/194761>
368
369         Reviewed by Myles Maxfield.
370
371         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
372         (WTR::activateSystemCoreWebFonts): Log `error` to console if
373         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
374         to use ARC-compliant cast.
375         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
376         ARC-compliant cast.
377         (WTR::installFakeHelvetica): Log `error` to console if
378         CTFontManagerRegisterFontsForURL() fails, but only on supported
379         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
380         Call CFRelease() on `error` to fix the leak.  Update to use
381         ARC-compliant cast.
382         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
383         cast.
384
385 2019-02-21  Chris Dumez  <cdumez@apple.com>
386
387         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
388         https://bugs.webkit.org/show_bug.cgi?id=194481
389
390         Reviewed by Alex Christensen.
391
392         Give the processes a chance to shutdown and wait until we reached the expected number
393         of processes.
394
395         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
396
397 2019-02-21  Tim Horton  <timothy_horton@apple.com>
398
399         Fix the macOS build
400
401         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
402
403 2019-02-21  Tim Horton  <timothy_horton@apple.com>
404
405         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
406
407         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
408         I am a backwards.
409
410 2019-02-21  Tim Horton  <timothy_horton@apple.com>
411
412         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
413
414         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
415         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
416         We could force on UI-side compositing, but I feel like the test might be more
417         valuable exercising the normal path on each platform (though the original
418         bug was also UI-side specific). Though we can't validate that the overlay
419         layer was installed successfully, there are layout tests that do that.
420
421 2019-02-21  Tim Horton  <timothy_horton@apple.com>
422
423         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
424         https://bugs.webkit.org/show_bug.cgi?id=194845
425         <rdar://problem/47944579>
426
427         Reviewed by Antti Koivisto.
428
429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
430         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
431
432 2019-02-21  Zalan Bujtas  <zalan@apple.com>
433
434         [LFC][Floats] Add support for placing formatting roots in-between floats.
435         https://bugs.webkit.org/show_bug.cgi?id=194902
436
437         Reviewed by Antti Koivisto.
438
439         * LayoutReloaded/misc/LFC-passing-tests.txt:
440
441 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
442
443         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
444         https://bugs.webkit.org/show_bug.cgi?id=194901
445
446         Unreviewed build fix.
447
448         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
449         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
450         WPEBackend-fdo-0.1 as library name.
451
452 2019-02-21  Rob Buis  <rbuis@igalia.com>
453
454         Update MIME type parser
455         https://bugs.webkit.org/show_bug.cgi?id=180526
456
457         Reviewed by Darin Adler.
458
459         Add tests involving leading and trailing whitespace, non-token
460         characters and quoted strings.
461
462         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
463         (TestWebKitAPI::TEST):
464
465 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
466
467         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
468         https://bugs.webkit.org/show_bug.cgi?id=194884
469
470         Reviewed by Michael Catanzaro.
471
472         * PlatformWin.cmake:
473
474 2019-02-20  Chris Dumez  <cdumez@apple.com>
475
476         Add API test for <rdar://problem/47471222>
477         https://bugs.webkit.org/show_bug.cgi?id=194847
478
479         Reviewed by Alex Christensen.
480
481         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
482
483 2019-02-20  Chris Dumez  <cdumez@apple.com>
484
485         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
486         https://bugs.webkit.org/show_bug.cgi?id=194872
487         <rdar://problem/47924500>
488
489         Reviewed by Alex Christensen.
490
491         Add API test coverage.
492
493         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
494
495 2019-02-20  Jer Noble  <jer.noble@apple.com>
496
497         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
498         https://bugs.webkit.org/show_bug.cgi?id=191332
499
500         Reviewed by Dean Jackson.
501
502         * Scripts/git-is-in-range: Added.
503
504 2019-02-20  Andy Estes  <aestes@apple.com>
505
506         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
507         https://bugs.webkit.org/show_bug.cgi?id=194869
508
509         Rubber-stamped by Jer Noble.
510
511         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
512         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
513         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
514         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
516         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
517
518 2019-02-20  Chris Dumez  <cdumez@apple.com>
519
520         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
521         https://bugs.webkit.org/show_bug.cgi?id=194857
522         <rdar://problem/47759323>
523
524         Reviewed by Alex Christensen.
525
526         Add API test coverage.
527
528         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
529
530 2019-02-20  Chris Dumez  <cdumez@apple.com>
531
532         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
533         https://bugs.webkit.org/show_bug.cgi?id=194829
534         <rdar://problem/47889906>
535
536         Reviewed by Alexey Proskuryakov.
537
538         Every time the TestOptions were changing we were creating both a new Web view and
539         a new WKContext, which would start a new Network process. In most cases, we only
540         need to contruct a new Web view and we do can keep reusing the same WKContext.
541         This patch implements this optimization and thus avoids spinning a lot of new
542         Network processes while running the layout tests.
543
544         * WebKitTestRunner/TestController.cpp:
545         (WTR::TestController::generateContextConfiguration const):
546         (WTR::TestController::generatePageConfiguration):
547         (WTR::TestController::createWebViewWithOptions):
548         (WTR::TestController::resetPreferencesToConsistentValues):
549         (WTR::updateTestOptionsFromTestHeader):
550         * WebKitTestRunner/TestController.h:
551         * WebKitTestRunner/TestOptions.h:
552         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
553         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
554         (WTR::TestOptions::hasSameInitializationOptions const):
555         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
556         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
557         (WTR::TestController::platformAddTestOptions const):
558
559 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
560
561         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
562         https://bugs.webkit.org/show_bug.cgi?id=167941
563
564         Reviewed by Carlos Garcia Campos.
565
566         * MiniBrowser/gtk/main.c:
567         (filterSavedCallback): Added.
568         (main): Support loading a JSON rule set file for content filtering.
569         * MiniBrowser/wpe/main.cpp:
570         (filterSavedCallback): Added.
571         (main): Support loading a JSON rule set file for content filtering.
572         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
573         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
574         (WTF::derefGPtr): Ditto.
575         (testEmptyStore):
576         (testSaveInvalidFilter):
577         (testSaveLoadFilter):
578         (testSavedFilterIdentifierMatch):
579         (testRemoveFilter):
580         (testSaveMultipleFilters):
581         (testSaveFilterFromFile):
582         (testFilterPersistence):
583         (beforeAll):
584         (afterAll):
585         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
586         (removeOldInjectedContentAndResetLists): Also reset content filters.
587         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
588         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
589         the element affected by the style sheet.
590         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
591         and returns it to be used by tests.
592         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
593         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
594         (serverCallback): Add support for serving a CSS style sheet for testing.
595         (beforeAll): Add call to testUserContentManagerContentFilter().
596         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
597
598 2019-02-19  Keith Rollin  <krollin@apple.com>
599
600         Add timing information to build output
601         https://bugs.webkit.org/show_bug.cgi?id=194839
602         <rdar://problem/48219609>
603
604         Reviewed by Alexey Proskuryakov.
605
606         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
607         emit each project's build time to its output. E.g.,
608
609             ** BUILD SUCCEEDED ** [0.132 sec]
610
611         * Scripts/webkitdirs.pm:
612         (XcodeOptions):
613
614 2019-02-19  Truitt Savell  <tsavell@apple.com>
615
616         Unreviewed, rolling out r241784.
617
618         Broke all OpenSource builds.
619
620         Reverted changeset:
621
622         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
623         instances view"
624         https://bugs.webkit.org/show_bug.cgi?id=172848
625         https://trac.webkit.org/changeset/241784
626
627 2019-02-19  Zalan Bujtas  <zalan@apple.com>
628
629         [LFC][Floats] Remove redundant intersecting logic
630         https://bugs.webkit.org/show_bug.cgi?id=194804
631
632         Reviewed by Antti Koivisto.
633
634         * LayoutReloaded/misc/LFC-passing-tests.txt:
635
636 2019-02-19  Dean Jackson  <dino@apple.com>
637
638         Clean-up output from generate-xcfilelists so it can be filtered
639         https://bugs.webkit.org/show_bug.cgi?id=194795
640
641         Reviewed by Joseph Pecoraro (and Keith Rollin).
642
643         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
644         make a slight tweak to filter-build-webkit so such lines are marked
645         as plain.
646
647         * Scripts/filter-build-webkit:
648         * Scripts/generate-xcfilelists:
649
650 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
651
652         pytest is not correctly auto-installed
653         https://bugs.webkit.org/show_bug.cgi?id=194707
654
655         Reviewed by Carlos Garcia Campos.
656
657         * Scripts/webkitpy/thirdparty/__init__.py:
658         (AutoinstallImportHook._install_pytest):
659
660 2019-02-18  Chris Dumez  <cdumez@apple.com>
661
662         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
663         https://bugs.webkit.org/show_bug.cgi?id=194797
664         <rdar://problem/48055151>
665
666         Reviewed by Geoffrey Garen.
667
668         Add API test coverage.
669
670         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
671
672 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
673
674         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
675         https://bugs.webkit.org/show_bug.cgi?id=194670
676         <rdar://problem/39066529>
677
678         Reviewed by Tim Horton.
679
680         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
681         pasted in an editable area as attachment elements.
682
683         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
684         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
685         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
686         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
687         (TestWebKitAPI::TEST):
688         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
689         (WTR::InjectedBundlePage::InjectedBundlePage):
690
691 2019-02-18  Alex Christensen  <achristensen@webkit.org>
692
693         Fix API test after r241728
694        ​https://bugs.webkit.org/show_bug.cgi?id=194723
695
696         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
697         (TEST):
698         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
699
700 2019-02-18  Daniel Bates  <dabates@apple.com>
701
702         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
703         https://bugs.webkit.org/show_bug.cgi?id=192824
704         <rdar://problem/47100332>
705
706         Reviewed by Wenson Hsieh.
707
708         Fix a bug where the wrong usage code was used for F13 thru F24.
709
710         * WebKitTestRunner/ios/HIDEventGenerator.mm:
711         (keyCodeForDOMFunctionKey):
712
713 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
714
715         Bytecode cache should a have a boot-specific validation
716         https://bugs.webkit.org/show_bug.cgi?id=194769
717         <rdar://problem/48149509>
718
719         Reviewed by Keith Miller.
720
721         Add test for WTF::bootSessionUUIDString()
722
723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
724         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
725         (TEST):
726
727 2019-02-18  Alex Christensen  <achristensen@webkit.org>
728
729         Disable safe browsing in WKWebView and remove its WKPreferences API
730         https://bugs.webkit.org/show_bug.cgi?id=194723
731         <rdar://problem/48122993>
732
733         Reviewed by Geoffrey Garen.
734
735         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
736         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
737         (TEST):
738         (safeBrowsingView):
739         Make tests use SPI instead of API.
740
741 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
742
743         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
744         https://bugs.webkit.org/show_bug.cgi?id=194586
745
746         Reviewed by Ross Kirsling.
747
748         * DumpRenderTree/win/DumpRenderTree.cpp:
749         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
750         * Scripts/webkitpy/port/driver.py:
751         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
752
753 2019-02-17  David Kilzer  <ddkilzer@apple.com>
754
755         Unreviewed, rolling out r241620.
756
757         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
758         (Requested by ddkilzer on #webkit.)
759
760         Reverted changeset:
761
762         "[WTF] Add environment variable helpers"
763         https://bugs.webkit.org/show_bug.cgi?id=192405
764         https://trac.webkit.org/changeset/241620
765
766 2019-02-16  Zalan Bujtas  <zalan@apple.com>
767
768         [LFC] RenderImage's default intrinsic size is 0.
769         https://bugs.webkit.org/show_bug.cgi?id=194745
770
771         Reviewed by Antti Koivisto.
772
773         * LayoutReloaded/misc/LFC-passing-tests.txt:
774
775 2019-02-16  Zalan Bujtas  <zalan@apple.com>
776
777         [LFC][BFC] Add support for block replaced intrinsic width.
778         https://bugs.webkit.org/show_bug.cgi?id=194705
779
780         Reviewed by Simon Fraser.
781
782         * LayoutReloaded/misc/LFC-passing-tests.txt:
783
784 2019-02-16  Zalan Bujtas  <zalan@apple.com>
785
786         [LFC] Apply min/max width constraints to preferred width computation
787         https://bugs.webkit.org/show_bug.cgi?id=194739
788
789         Reviewed by Simon Fraser.
790
791         * LayoutReloaded/misc/LFC-passing-tests.txt:
792
793 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
794
795         [WTF] Add environment variable helpers
796         https://bugs.webkit.org/show_bug.cgi?id=192405
797
798         Reviewed by Michael Catanzaro.
799
800         * DumpRenderTree/mac/DumpRenderTree.mm:
801         (libraryPathForDumpRenderTree):
802         * DumpRenderTree/win/DumpRenderTree.cpp:
803         (libraryPathForDumpRenderTree):
804         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
805         (setUpIOSLayoutTestCommunication):
806         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
807         (beforeAll):
808         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
809         (main):
810         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
811         (WebKitTestBus::run):
812         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
813         (WTR::getOutputDir):
814         (WTR::initializeFontConfigSetting):
815         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
816         (WTR::InjectedBundle::platformInitialize):
817         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
818         (WTR::topLevelPath):
819         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
820         (WTR::topLevelPath):
821         (WTR::getOutputDir):
822         (WTR::activateFonts):
823         * WebKitTestRunner/TestController.cpp:
824         (WTR::TestController::libraryPathForTesting):
825         (WTR::TestController::generateContextConfiguration const):
826         (WTR::TestController::generatePageConfiguration):
827         (WTR::TestController::decideDestinationWithSuggestedFilename):
828         (WTR::TestController::platformAdjustContext):
829         * WebKitTestRunner/TestController.h:
830         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
831         (WTR::TestController::cocoaPlatformInitialize):
832         (WTR::TestController::platformAdjustContext):
833         * WebKitTestRunner/gtk/main.cpp:
834         (main):
835         * WebKitTestRunner/mac/TestControllerMac.mm:
836         (WTR::TestController::configureContentExtensionForTest):
837         * WebKitTestRunner/wpe/main.cpp:
838         (main):
839         Utilize WTF::Environment where possible.
840
841 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
842
843         [iOS] WKWebView callout bar is missing Change Writing Direction item
844         https://bugs.webkit.org/show_bug.cgi?id=190015
845         <rdar://problem/44810366>
846
847         Reviewed by Tim Horton.
848
849         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
850         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
851
852         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
853         (TestWebKitAPI::TEST):
854
855 2019-02-15  Chris Dumez  <cdumez@apple.com>
856
857         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
858         https://bugs.webkit.org/show_bug.cgi?id=194717
859         <rdar://problem/47884404>
860
861         Reviewed by Brady Eidson.
862
863         Add API test coverage.
864
865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
866
867 2019-02-15  Youenn Fablet  <youenn@apple.com>
868
869         Make navigator.mediaDevices SecureContext
870         https://bugs.webkit.org/show_bug.cgi?id=194666
871
872         Reviewed by Eric Carlson.
873
874         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
875         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
876         (TEST_F):
877
878 2019-02-15  Brian Burg  <bburg@apple.com>
879
880         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
881         https://bugs.webkit.org/show_bug.cgi?id=194411
882         <rdar://problem/47787614>
883
884         Reviewed by Joseph Pecoraro.
885
886         Remove unnecessary soft linking macro usage.
887
888         * DumpRenderTree/mac/TestRunnerMac.mm:
889         (TestRunner::inspectorTestStubURL):
890         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
891         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
892         (WTR::TestRunner::inspectorTestStubURL):
893
894 2019-02-15  Commit Queue  <commit-queue@webkit.org>
895
896         Unreviewed, rolling out r241559 and r241566.
897         https://bugs.webkit.org/show_bug.cgi?id=194710
898
899         Causes layout test crashes under GuardMalloc (Requested by
900         ryanhaddad on #webkit).
901
902         Reverted changesets:
903
904         "[WTF] Add environment variable helpers"
905         https://bugs.webkit.org/show_bug.cgi?id=192405
906         https://trac.webkit.org/changeset/241559
907
908         "Unreviewed build fix for WinCairo Debug after r241559."
909         https://trac.webkit.org/changeset/241566
910
911 2019-02-15  Zalan Bujtas  <zalan@apple.com>
912
913         [LFC] Out-of-flow box is never a float box
914         https://bugs.webkit.org/show_bug.cgi?id=194704
915
916         Reviewed by Antti Koivisto.
917
918         * LayoutReloaded/misc/LFC-passing-tests.txt:
919
920 2019-02-10  Darin Adler  <darin@apple.com>
921
922         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
923         https://bugs.webkit.org/show_bug.cgi?id=194487
924
925         Reviewed by Daniel Bates.
926
927         * DumpRenderTree/win/DumpRenderTree.cpp:
928         (applicationId): Use makeString instead of String::format.
929         (main): Ditto.
930         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
931         (TestWebKitAPI::Util::createURLForResource): Ditto.
932         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
933         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
934
935         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
936         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
937         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
938         (WTR::createStringWithAttributes): Use appendLiteral.
939         (WTR::AccessibilityUIElement::helpText const): Ditto.
940         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
941         directly instead of using String::format.
942         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
943         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
944
945 2019-02-15  Truitt Savell  <tsavell@apple.com>
946
947         Unreviewed, rolling out r241564.
948
949         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
950
951         Reverted changeset:
952
953         "[Mac] WebInspectorUI.framework does not need to be soft-
954         linked anymore"
955         https://bugs.webkit.org/show_bug.cgi?id=194411
956         https://trac.webkit.org/changeset/241564
957
958 2019-02-15  Saam barati  <sbarati@apple.com>
959
960         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
961         https://bugs.webkit.org/show_bug.cgi?id=194036
962
963         Reviewed by Yusuke Suzuki.
964
965         * Scripts/run-jsc-stress-tests:
966
967 2019-02-14  Tim Horton  <timothy_horton@apple.com>
968
969         Fix the build.
970
971         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
972         (WTR::UIScriptController::drawSquareInEditableImage):
973         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
974         (TestWebKitAPI::drawSquareInEditableImage):
975
976 2019-02-14  Tim Horton  <timothy_horton@apple.com>
977
978         Fix the build.
979
980         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
981         (WTR::UIScriptController::drawSquareInEditableImage):
982         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
983         (TestWebKitAPI::drawSquareInEditableImage):
984
985 2019-02-14  Brian Burg  <bburg@apple.com>
986
987         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
988         https://bugs.webkit.org/show_bug.cgi?id=194411
989         <rdar://problem/47787614>
990
991         Reviewed by Joseph Pecoraro.
992
993         Remove unnecessary soft linking macro usage.
994
995         * DumpRenderTree/mac/TestRunnerMac.mm:
996         (TestRunner::inspectorTestStubURL):
997         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
998         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
999         (WTR::TestRunner::inspectorTestStubURL):
1000
1001 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1002
1003         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1004         https://bugs.webkit.org/show_bug.cgi?id=194599
1005
1006         Reviewed by Lucas Forschler.
1007
1008         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1009         (StatusBubble._build_bubble):
1010
1011 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1012
1013         [ews-app] Set Foreign Key in Django build model
1014         https://bugs.webkit.org/show_bug.cgi?id=194667
1015
1016         Reviewed by Lucas Forschler.
1017
1018         * BuildSlaveSupport/ews-app/ews/models/build.py:
1019         (Build):
1020
1021 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1022
1023         [WTF] Add environment variable helpers
1024         https://bugs.webkit.org/show_bug.cgi?id=192405
1025
1026         Reviewed by Michael Catanzaro.
1027
1028         * DumpRenderTree/mac/DumpRenderTree.mm:
1029         (libraryPathForDumpRenderTree):
1030         * DumpRenderTree/win/DumpRenderTree.cpp:
1031         (libraryPathForDumpRenderTree):
1032         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1033         (setUpIOSLayoutTestCommunication):
1034         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1035         (TestWebKitAPI::strip):
1036         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1037         (beforeAll):
1038         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1039         (main):
1040         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1041         (WebKitTestBus::run):
1042         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1043         (WTR::getOutputDir):
1044         (WTR::initializeFontConfigSetting):
1045         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1046         (WTR::InjectedBundle::platformInitialize):
1047         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1048         (WTR::topLevelPath):
1049         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1050         (WTR::topLevelPath):
1051         (WTR::getOutputDir):
1052         (WTR::activateFonts):
1053         * WebKitTestRunner/TestController.cpp:
1054         (WTR::TestController::libraryPathForTesting):
1055         (WTR::TestController::generateContextConfiguration const):
1056         (WTR::TestController::generatePageConfiguration):
1057         (WTR::TestController::decideDestinationWithSuggestedFilename):
1058         (WTR::TestController::platformAdjustContext):
1059         * WebKitTestRunner/TestController.h:
1060         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1061         (WTR::TestController::cocoaPlatformInitialize):
1062         (WTR::TestController::platformAdjustContext):
1063         * WebKitTestRunner/gtk/main.cpp:
1064         (main):
1065         * WebKitTestRunner/mac/TestControllerMac.mm:
1066         (WTR::TestController::configureContentExtensionForTest):
1067         * WebKitTestRunner/wpe/main.cpp:
1068         (main):
1069         Utilize WTF::Environment where possible.
1070
1071 2019-02-14  Chris Dumez  <cdumez@apple.com>
1072
1073         [PSON] Introduce a WebContent Process cache
1074         https://bugs.webkit.org/show_bug.cgi?id=194594
1075         <rdar://problem/46793397>
1076
1077         Reviewed by Geoff Garen.
1078
1079         Update API tests to turn on the WebContent Process cache.
1080
1081         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1082
1083 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1084
1085         Unreviewed, build fix after r241480
1086
1087         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1088         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1089         (-[DragAndDropSimulator initWithWebView:]):
1090
1091 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1092
1093         AX: ARIA Reflection was disabled in error
1094         https://bugs.webkit.org/show_bug.cgi?id=194647
1095         <rdar://problem/48068336>
1096
1097         Reviewed by Ryosuke Niwa.
1098
1099         Remove test override now that this feature should be enabled by default.
1100
1101         * WebKitTestRunner/TestController.cpp:
1102         (WTR::TestController::resetPreferencesToConsistentValues):
1103
1104 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1105
1106         Unreviewed, rolling out r241486.
1107         https://bugs.webkit.org/show_bug.cgi?id=194655
1108
1109         causing API failures in builds (Requested by ShawnRoberts on
1110         #webkit).
1111
1112         Reverted changeset:
1113
1114         "[Cocoa] Media elements will restart network buffering just
1115         before suspending"
1116         https://bugs.webkit.org/show_bug.cgi?id=193691
1117         https://trac.webkit.org/changeset/241486
1118
1119 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1120
1121         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1122         https://bugs.webkit.org/show_bug.cgi?id=194622
1123
1124         Reviewed by Antti Koivisto.
1125
1126         * LayoutReloaded/misc/LFC-passing-tests.txt:
1127
1128 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1129
1130         [LFC] Shrink-to-fit-width should be constrained by min/max width
1131         https://bugs.webkit.org/show_bug.cgi?id=194653
1132
1133         Reviewed by Antti Koivisto.
1134
1135         * LayoutReloaded/misc/LFC-passing-tests.txt:
1136
1137 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1138
1139         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1140         https://bugs.webkit.org/show_bug.cgi?id=194641
1141
1142         Reviewed by Geoffrey Garen.
1143
1144         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1145         so that the test would fail without this fix.
1146
1147         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1148         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1149
1150 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1151
1152         [ews-app] Change log level for a log statement
1153
1154         Unreviewed minor fix.
1155
1156         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1157         (Patch.save_patch):
1158
1159 2019-02-13  Jer Noble  <jer.noble@apple.com>
1160
1161         [Cocoa] Media elements will restart network buffering just before suspending
1162         https://bugs.webkit.org/show_bug.cgi?id=193691
1163
1164         Reviewed by Eric Carlson.
1165
1166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1167         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1168         (TEST):
1169
1170 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1171
1172         [ews-app] Fetch builder id to name mapping
1173         https://bugs.webkit.org/show_bug.cgi?id=194355
1174
1175         Reviewed by Lucas Forschler.
1176
1177         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1178         (Buildbot.get_builder_id_to_name_mapping):
1179         (Buildbot._get_display_name_from_builder_name):
1180
1181 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1182
1183         Further restricting webarchive loads
1184         https://bugs.webkit.org/show_bug.cgi?id=194567
1185         <rdar://problem/47610130>
1186
1187         Reviewed by Youenn Fablet.
1188
1189         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1190         navigations on drop.
1191
1192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1193         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1194         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1195         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1196         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1197         (TestWebKitAPI::TEST):
1198         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1199         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1200         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1201         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1202         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1203         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1204         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1205
1206 2019-02-13  John Wilander  <wilander@apple.com>
1207
1208         Store Ad Click Attribution requests in the network process
1209         https://bugs.webkit.org/show_bug.cgi?id=194510
1210         <rdar://problem/47650118>
1211
1212         Reviewed by Alex Christensen and Daniel Bates.
1213
1214         This patch adds two TestRunner functions:
1215         - dumpAdClickAttribution()
1216         - clearAdClickAttribution()
1217
1218         They call into the network process to dump and clear Ad Click
1219         Attribution state, respectively.
1220
1221         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1222         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1223         (WTR::TestRunner::dumpAdClickAttribution):
1224         (WTR::TestRunner::clearAdClickAttribution):
1225         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1226         * WebKitTestRunner/TestController.cpp:
1227         (WTR::TestController::resetStateToConsistentValues):
1228         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1229         (WTR::adClickAttributionStringResultCallback):
1230         (WTR::TestController::dumpAdClickAttribution):
1231         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1232         (WTR::adClickAttributionVoidCallback):
1233         (WTR::TestController::clearAdClickAttribution):
1234         * WebKitTestRunner/TestController.h:
1235         * WebKitTestRunner/TestInvocation.cpp:
1236         (WTR::TestInvocation::dumpResults):
1237         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1238         (WTR::TestInvocation::dumpAdClickAttribution):
1239         * WebKitTestRunner/TestInvocation.h:
1240
1241 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1242
1243         [ews-app] Generate status-bubble
1244         https://bugs.webkit.org/show_bug.cgi?id=194572
1245
1246         Reviewed by Lucas Forschler.
1247
1248         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1249         (StatusBubble._build_bubble):
1250         (StatusBubble._should_show_bubble_for):
1251         (StatusBubble._build_bubbles_for_patch):
1252
1253 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1254
1255         [ews-app] Add status bubble html template
1256         https://bugs.webkit.org/show_bug.cgi?id=194571
1257
1258         Reviewed by Lucas Forschler.
1259
1260         * BuildSlaveSupport/ews-app/ews/templates: Added.
1261         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1262
1263 2019-02-12  Chris Dumez  <cdumez@apple.com>
1264
1265         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1266         https://bugs.webkit.org/show_bug.cgi?id=194568
1267         <rdar://problem/47944490>
1268
1269         Reviewed by Ryosuke Niwa.
1270
1271         Add API test coverage.
1272
1273         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1274         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1275
1276 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1277
1278         webkitpy: Remove bug_dummy from parsed test expectations
1279         https://bugs.webkit.org/show_bug.cgi?id=194562
1280         <rdar://problem/47853999>
1281
1282         Reviewed by Lucas Forschler.
1283
1284         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1285         (TestExpectationParser):
1286         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1287         skipped tests.
1288         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1289
1290 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1291
1292         [ews-app] Add method to fetch patch
1293         https://bugs.webkit.org/show_bug.cgi?id=194518
1294
1295         Reviewed by Lucas Forschler.
1296
1297         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1298         (Patch.get_patch):
1299
1300 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1301
1302         [LFC] Expand tests coverage (60 new tests -> 860)
1303
1304         Unreviewed test gardening (run-singly, --child-processes=1).
1305
1306         * LayoutReloaded/misc/LFC-passing-tests.txt:
1307
1308 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1309
1310         Allow pages to trigger programmatic paste from script on iOS
1311         https://bugs.webkit.org/show_bug.cgi?id=194271
1312         <rdar://problem/47808810>
1313
1314         Reviewed by Tim Horton.
1315
1316         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1317
1318         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1319         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1320         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1321         (WTR::UIScriptController::rectForMenuAction const):
1322
1323         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1324         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1325         for when the menu is shown or hidden.
1326
1327         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1328         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1329         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1330         (WTR::UIScriptController::setDidShowMenuCallback):
1331         (WTR::UIScriptController::didShowMenuCallback const):
1332         (WTR::UIScriptController::setDidHideMenuCallback):
1333         (WTR::UIScriptController::didHideMenuCallback const):
1334         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1335         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1336         (WTR::UIScriptController::rectForMenuAction const):
1337         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1338         * WebKitTestRunner/TestController.cpp:
1339         (WTR::TestController::resetPreferencesToConsistentValues):
1340         (WTR::updateTestOptionsFromTestHeader):
1341         * WebKitTestRunner/TestOptions.h:
1342
1343         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1344         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1345
1346         (WTR::TestOptions::hasSameInitializationOptions const):
1347         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1348         (WTR::UIScriptController::calendarType const):
1349         (WTR::UIScriptController::platformUndoManager const):
1350         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1351         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1352         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1353         (-[TestRunnerWKWebView dealloc]):
1354         (-[TestRunnerWKWebView _didShowMenu]):
1355         (-[TestRunnerWKWebView _didHideMenu]):
1356
1357         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1358
1359         * WebKitTestRunner/ios/TestControllerIOS.mm:
1360         (WTR::handleMenuWillHideNotification):
1361         (WTR::handleMenuDidHideNotification):
1362         (WTR::TestController::platformInitialize):
1363         (WTR::TestController::platformDestroy):
1364         (WTR::TestController::platformResetStateToConsistentValues):
1365
1366         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1367         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1368
1369         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1370         (WTR::forEachViewInHierarchy):
1371         (WTR::findViewInHierarchyOfType):
1372
1373         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1374         functions that dig through a given view's hierarchy in search of a view of a given class.
1375
1376         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1377         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1378         (WTR::UIScriptController::selectionCaretViewRect const):
1379         (WTR::UIScriptController::selectionRangeViewRects const):
1380         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1381         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1382
1383         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1384
1385         (WTR::UIScriptController::rectForMenuAction const):
1386
1387         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1388         callout bar) whose label matches the given string.
1389
1390         (WTR::UIScriptController::platformContentView const):
1391
1392         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1393         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1394         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1395
1396         (WTR::UIScriptController::platformUndoManager const): Deleted.
1397         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1398         (WTR::UIScriptController::platformContentView const):
1399         (WTR::UIScriptController::platformUndoManager const): Deleted.
1400
1401 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1402
1403         webkitpy: No option to only show unexpected failures in results.html for iPad
1404         https://bugs.webkit.org/show_bug.cgi?id=194554
1405         <rdar://problem/47922442>
1406
1407         Rubber-stamped by Aakash Jain.
1408
1409         Just because a TestExpecations file does not exist for a specific platform does not mean that
1410         TestExpecations are not being used, given that platforms inherit test expectations.
1411
1412         * Scripts/webkitpy/port/base.py:
1413         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1414         * Scripts/webkitpy/port/base_unittest.py:
1415         (PortTest.test_uses_test_expectations_file):
1416
1417 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1418
1419         Remove setDefersLoading infrastructure from WebKit2
1420         https://bugs.webkit.org/show_bug.cgi?id=194506
1421
1422         Reviewed by Brady Eidson.
1423
1424         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1426         (WTR::TestRunner::setDefersLoading): Deleted.
1427         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1428
1429 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1430
1431         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1432         https://bugs.webkit.org/show_bug.cgi?id=194522
1433         <rdar://problem/47789393>
1434
1435         Reviewed by Chris Dumez.
1436
1437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1438         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1439         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1440         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1441
1442 2019-02-12  Andy Estes  <aestes@apple.com>
1443
1444         [iOSMac] Enable Parental Controls Content Filtering
1445         https://bugs.webkit.org/show_bug.cgi?id=194521
1446         <rdar://39732376>
1447
1448         Reviewed by Tim Horton.
1449
1450         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1451
1452 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1453
1454         [LFC][IFC] Add intrinsic width support for float boxes.
1455         https://bugs.webkit.org/show_bug.cgi?id=194528
1456
1457         Reviewed by Antti Koivisto.
1458
1459         Expand tests coverage (2 new tests -> 800).
1460         (This is the correct test ordering --runs-singly --child-processes=1)
1461
1462         * LayoutReloaded/misc/LFC-passing-tests.txt:
1463
1464 2019-02-12  Rob Buis  <rbuis@igalia.com>
1465
1466         Implement serializing in MIME type parser
1467         https://bugs.webkit.org/show_bug.cgi?id=193909
1468
1469         Reviewed by Darin Adler.
1470
1471         Add various tests involving upper case, non-ASCII, control/null characters,
1472         various HTTP whitespace, single quotes and an unpaired surrogate.
1473
1474         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1475         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1476         (TestWebKitAPI::serializeIfValid):
1477         (TestWebKitAPI::TEST):
1478
1479 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1480
1481         [Cocoa] Ask platform for generic font family mappings
1482         https://bugs.webkit.org/show_bug.cgi?id=187723
1483         <rdar://problem/41892438>
1484
1485         Reviewed by Brent Fulgham.
1486
1487         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1488
1489         * DumpRenderTree/mac/DumpRenderTree.mm:
1490         (allowedFontFamilySet):
1491         * WebKitTestRunner/mac/TestControllerMac.mm:
1492         (WTR::allowedFontFamilySet):
1493
1494 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1495
1496         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1497         https://bugs.webkit.org/show_bug.cgi?id=193622
1498
1499         Reviewed by Michael Catanzaro.
1500
1501         This adds support for loading content extension rule sets from the JSON files which
1502         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1503         of WKTR for this could be removed, but that is left for a follow-up patch with
1504         cleanups.
1505
1506         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1507         * WebKitTestRunner/TestController.cpp:
1508         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1509         avoid having the null-terminator copied into the result.
1510         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1511         part of the preparations to run a test.
1512         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1513         (WTR::contentExtensionStoreCallback): Added.
1514         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1515         used for content extensions test.
1516         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1517         extensions and compiling the JSON rule set for tests involving content extensions.
1518         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1519         testing and disables content extensions.
1520         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1521         resetContentExtensions().
1522         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1523         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1524         configureContentExtensionForTest(), and userContentController().
1525
1526 2019-02-11  Daniel Bates  <dabates@apple.com>
1527
1528         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1529         https://bugs.webkit.org/show_bug.cgi?id=191446
1530         <rdar://problem/45929460>
1531
1532         Reviewed by Tim Horton.
1533
1534         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1535
1536         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1537         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1538         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1539         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1540         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1541         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1542         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1543         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1544         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1545         (WTR::arrayLength):
1546         (WTR::parseModifierArray):
1547         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1548         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1549         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1550         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1551
1552 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1553
1554         Unreviewed, rolling out r241272 and r241276.
1555         https://bugs.webkit.org/show_bug.cgi?id=194514
1556
1557         Broke the Apple Internal build and the fix requires human
1558         intervention :( (Requested by dydz on #webkit).
1559
1560         Reverted changesets:
1561
1562         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1563         https://bugs.webkit.org/show_bug.cgi?id=191446
1564         https://trac.webkit.org/changeset/241272
1565
1566         "Fix internal iOS build after r241272"
1567         https://bugs.webkit.org/show_bug.cgi?id=191446
1568         https://trac.webkit.org/changeset/241276
1569
1570 2019-02-11  Truitt Savell  <tsavell@apple.com>
1571
1572         Unreviewed, rolling out r241269.
1573
1574         Caused 5 layout tests crashes on Mac WK1
1575
1576         Reverted changeset:
1577
1578         "DumpRenderTree should report unknown options"
1579         https://bugs.webkit.org/show_bug.cgi?id=191303
1580         https://trac.webkit.org/changeset/241269
1581
1582 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1583
1584         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1585         https://bugs.webkit.org/show_bug.cgi?id=194313
1586
1587         Reviewed by Tim Horton.
1588
1589         Add a helper to determine whether the web view is presenting modal UI.
1590
1591         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1592         (WTR::UIScriptController::isPresentingModally const):
1593         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1594         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1595         (WTR::UIScriptController::isPresentingModally const):
1596         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1597         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1598         (WTR::UIScriptController::calendarType const): Deleted.
1599         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1600         (WTR::UIScriptController::isPresentingModally const):
1601         (WTR::UIScriptController::calendarType const):
1602         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1603         (WTR::UIScriptController::calendarType const):
1604
1605 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1606
1607         GCHeapInspector: Show the retained sizes in more places
1608         https://bugs.webkit.org/show_bug.cgi?id=194464
1609
1610         Reviewed by Simon Fraser.
1611
1612         * GCHeapInspector/gc-heap-inspector.html:
1613         * GCHeapInspector/script/interface.js:
1614         (HeapInspectorUtils.humanReadableSize):
1615         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1616         (HeapInspectorUtils.spanForNode.span.span):
1617         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1618         (HeapSnapshotInspector.prototype.buildRoots):
1619
1620 2019-02-11  Daniel Bates  <dabates@apple.com>
1621
1622         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1623         https://bugs.webkit.org/show_bug.cgi?id=191446
1624         <rdar://problem/45929460>
1625
1626         Reviewed by Tim Horton.
1627
1628         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1629
1630         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1631         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1632         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1633         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1634         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1635         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1636         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1637         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1638         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1639         (WTR::arrayLength):
1640         (WTR::parseModifierArray):
1641         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1642         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1643         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1644         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1645
1646 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1647
1648         DumpRenderTree should report unknown options
1649         https://bugs.webkit.org/show_bug.cgi?id=191303
1650
1651         Reviewed by Frédéric Wang.
1652
1653         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1654         to report unknown options.
1655         Added and assigned test options which are currently used in tests.
1656
1657         * DumpRenderTree/TestOptions.cpp:
1658         (TestOptions::TestOptions):
1659
1660 2019-02-11  Truitt Savell  <tsavell@apple.com>
1661
1662         Unreviewed, rolling out r241229.
1663
1664         Revision broke internal builds for watchOS.
1665
1666         Reverted changeset:
1667
1668         "[Cocoa] Ask platform for generic font family mappings"
1669         https://bugs.webkit.org/show_bug.cgi?id=187723
1670         https://trac.webkit.org/changeset/241229
1671
1672 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1673
1674         [WinCairo][MiniBrowser] Basic authentication always fails.
1675         https://bugs.webkit.org/show_bug.cgi?id=194496
1676
1677         Reviewed by Don Olmstead.
1678
1679         * MiniBrowser/win/DialogHelper.h:
1680         (Dialog::getText):
1681
1682 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1683
1684         [GStreamer] GstMappedBuffer testsuite build fails
1685         https://bugs.webkit.org/show_bug.cgi?id=194495
1686
1687         Reviewed by Carlos Garcia Campos.
1688
1689         Fix the build by explicitely adding the gstreamer1.0-audio include
1690         directories to the include path.
1691
1692         * TestWebKitAPI/PlatformGTK.cmake:
1693         * TestWebKitAPI/PlatformWPE.cmake:
1694
1695 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1696
1697         [GTK][WPE] Add enable-javascript-markup setting
1698         https://bugs.webkit.org/show_bug.cgi?id=193439
1699
1700         Reviewed by Michael Catanzaro.
1701
1702         Add test cases to check the new setting.
1703
1704         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1705         (testWebKitSettings):
1706         (testWebKitSettingsJavaScriptMarkup):
1707         (beforeAll):
1708
1709 2019-02-10  Darin Adler  <darin@apple.com>
1710
1711         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1712         https://bugs.webkit.org/show_bug.cgi?id=194485
1713
1714         Reviewed by Daniel Bates.
1715
1716         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1717
1718 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1719
1720         Add more tests for clampTo<>()
1721         https://bugs.webkit.org/show_bug.cgi?id=194462
1722
1723         Reviewed by Geoffrey Garen.
1724
1725         Darin suggested to test the very last floating point number
1726         at the boundaries when truncating to integer.
1727         I added test for max/min and max-1/min-1.
1728
1729         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1730         (TestWebKitAPI::TEST):
1731
1732 2019-02-09  Darin Adler  <darin@apple.com>
1733
1734         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1735         https://bugs.webkit.org/show_bug.cgi?id=194021
1736
1737         Reviewed by Geoffrey Garen.
1738
1739         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1740         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1741         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1742
1743 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1744
1745         [LFC][IFC] Add intrinsic width support for basic inline containers
1746         https://bugs.webkit.org/show_bug.cgi?id=194473
1747
1748         Reviewed by Antti Koivisto.
1749
1750         Expand tests coverage (11 new tests -> 798)
1751
1752         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1753
1754 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1755
1756         Fix MiniBrowser's entitlements
1757         https://bugs.webkit.org/show_bug.cgi?id=192431
1758
1759         Reviewed by Joseph Pecoraro.
1760
1761         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1762         files, making it impossible to load any extension.
1763
1764         * MiniBrowser/MiniBrowser.entitlements:
1765
1766 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1767
1768         [Cocoa] Ask platform for generic font family mappings
1769         https://bugs.webkit.org/show_bug.cgi?id=187723
1770         <rdar://problem/41892438>
1771
1772         Reviewed by Brent Fulgham.
1773
1774         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1775
1776         * DumpRenderTree/mac/DumpRenderTree.mm:
1777         (allowedFontFamilySet):
1778         * WebKitTestRunner/mac/TestControllerMac.mm:
1779         (WTR::allowedFontFamilySet):
1780
1781 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1782
1783         [GTK] Implement back/forward touchpad gesture
1784         https://bugs.webkit.org/show_bug.cgi?id=193919
1785
1786         Reviewed by Michael Catanzaro.
1787
1788         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1789         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1790
1791 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1792
1793         Add SPI to use networking daemon instead of XPC service
1794         https://bugs.webkit.org/show_bug.cgi?id=194427
1795
1796         Reviewed by Geoffrey Garen
1797
1798         * MiniBrowser/MiniBrowser.entitlements:
1799
1800 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1801
1802         [ews-build] Ensure that every builder in config.json has short name
1803         https://bugs.webkit.org/show_bug.cgi?id=194461
1804
1805         Reviewed by Lucas Forschler.
1806
1807         * BuildSlaveSupport/ews-build/loadConfig.py:
1808         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1809
1810 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1811
1812         [ews-build] Add short name to config.json
1813         https://bugs.webkit.org/show_bug.cgi?id=194456
1814
1815         Reviewed by Lucas Forschler.
1816
1817         * BuildSlaveSupport/ews-build/config.json: Added short name.
1818         * BuildSlaveSupport/ews-build/loadConfig.py:
1819         (loadBuilderConfig): Set the short name as the builder description.
1820
1821 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1822
1823         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1824         https://bugs.webkit.org/show_bug.cgi?id=194418
1825
1826         Reviewed by Lucas Forschler.
1827
1828         Do not include errors trying when finding crashlogs at the end of
1829         a run-webkit-tests run since we don't process those errors.
1830
1831         * Scripts/webkitpy/port/darwin.py:
1832         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1833         * Scripts/webkitpy/port/ios_device.py:
1834         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1835         * Scripts/webkitpy/port/watch_device.py:
1836         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1837
1838 2019-02-08  Beth Dakin  <bdakin@apple.com>
1839
1840         Add afterScreenUpdates to WKSnapshotConfiguration
1841         https://bugs.webkit.org/show_bug.cgi?id=194362
1842         -and corresponding-
1843         <rdar://problem/40655528> Please add an "after screen updates" property to 
1844         WKSnapshotConfiguration (to solve blank snapshots)
1845
1846         Reviewed by Tim Horton.
1847
1848         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1849         (TEST):
1850
1851 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1852
1853         clampTo(): do not convert the input to double when dealing with integers
1854         https://bugs.webkit.org/show_bug.cgi?id=194263
1855         <rdar://problem/47692312>
1856
1857         Reviewed by Darin Adler.
1858
1859         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1860         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1861         (TestWebKitAPI::testClampFloatingPointToInteger):
1862         (TestWebKitAPI::testClampSameSignIntegers):
1863         (TestWebKitAPI::testClampUnsignedToSigned):
1864         (TestWebKitAPI::testClampSignedToUnsigned):
1865
1866 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1867
1868         webkitpy: Respect --dedicated-simulators flag
1869         https://bugs.webkit.org/show_bug.cgi?id=194416
1870         <rdar://problem/47894722>
1871
1872         Reviewed by Lucas Forschler.
1873
1874         * Scripts/webkitpy/port/device_port.py:
1875         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1876         available devices can be safely ignored.
1877
1878 2019-02-07  Keith Rollin  <krollin@apple.com>
1879
1880         Remove extra copy of 100x100-red.tga
1881         https://bugs.webkit.org/show_bug.cgi?id=194371
1882         <rdar://problem/47873465>
1883
1884         Reviewed by Said Abou-Hallawa.
1885
1886         In order to help it pass its tests, Bug 194190 added a second copy of
1887         the file 100x100-red.tga. However, it turns out that this additional
1888         file wasn't actually needed, and that that sole previous copy was
1889         sufficient. At the same time, this second copy -- which was copied to
1890         the same location in the build output as the first copy -- now caused
1891         XCBuild to complain because there were two production rules for the
1892         same output file. Address this by removing the newly-added extra copy.
1893
1894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1895         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1896
1897 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1898
1899         Deprecate WKBundlePageSetDefersLoading
1900         https://bugs.webkit.org/show_bug.cgi?id=191394
1901
1902         Reviewed by Dean Jackson.
1903
1904         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1905         (WTR::TestRunner::setDefersLoading):
1906
1907 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1908
1909         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1910         https://bugs.webkit.org/show_bug.cgi?id=194391
1911
1912         Reviewed by Antti Koivisto.
1913
1914         * LayoutReloaded/misc/LFC-passing-tests.txt:
1915
1916 2019-02-06  Keith Rollin  <krollin@apple.com>
1917
1918         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1919         https://bugs.webkit.org/show_bug.cgi?id=193975
1920         <rdar://problem/47643306>
1921
1922         Reviewed by Tim Horton.
1923
1924         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1925         the Info.plist file into the bundle. This step is not necessary as the
1926         implicit "bundle up all the build products into a framework" build
1927         phase does this already. Having the Copy Bundle Resources phase do
1928         this causes a conflict under XCBuild, which objects to two build
1929         phases producing the same file (Info.plist). Address this by removing
1930         Info.plist from the Copy Bundle Resources phase.
1931
1932         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1933
1934 2019-02-06  Keith Rollin  <krollin@apple.com>
1935
1936         Really enable the automatic checking and regenerations of .xcfilelists during builds
1937         https://bugs.webkit.org/show_bug.cgi?id=194357
1938         <rdar://problem/47861231>
1939
1940         Reviewed by Chris Dumez.
1941
1942         Bug 194124 was supposed to enable the automatic checking and
1943         regenerating of .xcfilelist files during the build. While related
1944         changes were included in that patch, the change to actually enable the
1945         operation somehow was omitted. This patch actually enables the
1946         operation. The check-xcfilelist.sh scripts now check
1947         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1948         from the checking.
1949
1950         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1951         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1952
1953 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1954
1955         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1956         <https://webkit.org/b/194286>
1957         <rdar://problem/47815558>
1958
1959         Reviewed by Alexey Proskuryakov.
1960
1961         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1962         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1963         WKRetainPtr<> to avoid leaking the WKDataRef.
1964
1965 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1966
1967         Unreviewed, fix a typo
1968
1969         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1970
1971 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1972
1973         [GTK][WPE] force libpsl build to use ICU in jhbuild
1974         https://bugs.webkit.org/show_bug.cgi?id=194288
1975
1976         Reviewed by Carlos Garcia Campos.
1977
1978         * gtk/jhbuild.modules:
1979         Require ICU for libpsl build in jhbuild, like done in WPE.
1980
1981 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1982
1983         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1984         https://bugs.webkit.org/show_bug.cgi?id=194209
1985
1986         Reviewed by Carlos Garcia Campos.
1987
1988         Enhance TestCookieManager to ensure this doesn't happen again.
1989
1990         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1991         (testCookieManagerPersistentStorage):
1992         (beforeAll):
1993
1994 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1995
1996         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1997         https://bugs.webkit.org/show_bug.cgi?id=194324
1998
1999         Reviewed by Andy Estes.
2000
2001         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2002         part of the name is already implicit, since this is in testing code in TestOptions.
2003
2004         * WebKitTestRunner/TestController.cpp:
2005         (WTR::TestController::generateContextConfiguration const):
2006         (WTR::updateTestOptionsFromTestHeader):
2007         * WebKitTestRunner/TestOptions.h:
2008         (WTR::TestOptions::hasSameInitializationOptions const):
2009
2010 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2011
2012         [ews-build] Allow * as platform for builders and workers
2013         https://bugs.webkit.org/show_bug.cgi?id=188533
2014
2015         Reviewed by Lucas Forschler.
2016
2017         * BuildSlaveSupport/ews-build/loadConfig.py:
2018         (checkWorkersAndBuildersForConsistency):
2019
2020 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2021
2022         [ews-build] Add few bots to config.json
2023         https://bugs.webkit.org/show_bug.cgi?id=194304
2024
2025         Reviewed by Lucas Forschler.
2026
2027         * BuildSlaveSupport/ews-build/config.json:
2028
2029 2019-02-05  Keith Rollin  <krollin@apple.com>
2030
2031         Enable the automatic checking and regenerations of .xcfilelists during builds
2032         https://bugs.webkit.org/show_bug.cgi?id=194124
2033         <rdar://problem/47721277>
2034
2035         Reviewed by Tim Horton.
2036
2037         Bug 193790 add a facility for checking -- during build time -- that
2038         any needed .xcfilelist files are up-to-date and for updating them if
2039         they are not. This facility was initially opt-in by setting
2040         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2041         the process seemed robust. Its now time to enable this facility and
2042         make it opt-out. If there is a need to disable this facility, set and
2043         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2044         running `make` or `build-webkit`, or before running Xcode from the
2045         command line.
2046
2047         Additionally, remove the step that generates a list of source files
2048         going into the UnifiedSources build step. It's only necessarily to
2049         specify Sources.txt and SourcesCocoa.txt as inputs.
2050
2051         * Scripts/generate-xcfilelists:
2052
2053 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2054
2055         [GTK][WPE] force libpsl build to use ICU in jhbuild
2056         https://bugs.webkit.org/show_bug.cgi?id=194288
2057
2058         Reviewed by Philippe Normand.
2059
2060         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2061         This can cause build failures if libidn is detected but libunistring is not available.
2062
2063         Make sure that ICU is used for runtime and builtin PSL data.
2064
2065         * gtk/jhbuild.modules:
2066         * wpe/jhbuild.modules:
2067
2068 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2069
2070         [ews-app] Modified timestamp should be updated on updating data
2071         https://bugs.webkit.org/show_bug.cgi?id=194295
2072
2073         Reviewed by Lucas Forschler.
2074
2075         * BuildSlaveSupport/ews-app/ews/models/build.py:
2076         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2077         * BuildSlaveSupport/ews-app/ews/models/step.py:
2078
2079 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2080
2081         Unreviewed, rolling out r240742.
2082
2083         Causes crashes on iOS simulator.
2084
2085         Reverted changeset:
2086
2087         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2088         not focused in a content-editable element"
2089         https://bugs.webkit.org/show_bug.cgi?id=192824
2090         https://trac.webkit.org/changeset/240742
2091
2092 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2093
2094         run-webkit-tests emits message "...running None" when running tests
2095         https://bugs.webkit.org/show_bug.cgi?id=194133
2096         <rdar://problem/47724738>
2097
2098         Reviewed by Lucas Forschler.
2099
2100         * Scripts/webkitpy/xcode/device_type.py:
2101         (DeviceType.__str__): Use both version mapping tables and use just the variant
2102         name if no version name is available.
2103         * Scripts/webkitpy/xcode/device_type_unittest.py:
2104         (DeviceTypeTest):
2105         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2106         an associated named.
2107
2108 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2109
2110         [WPE] require python3-setuptools for meson build in jhbuild
2111         https://bugs.webkit.org/show_bug.cgi?id=194287
2112
2113         Reviewed by Philippe Normand.
2114
2115         python3-setuptools is needed to build meson in jhbuild.
2116         It is already required by the GTK port.
2117
2118         * wpe/install-dependencies:
2119
2120 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2121
2122         [ews-app] Add method to save BuilderMapping to database
2123         https://bugs.webkit.org/show_bug.cgi?id=194264
2124
2125         Reviewed by Lucas Forschler.
2126
2127         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2128         (BuilderMapping.__str__):
2129         (BuilderMapping):
2130         (BuilderMapping.save_mapping):
2131         (BuilderMapping.update_mapping):
2132         (BuilderMapping.get_existing_mapping):
2133         (BuilderMapping.is_valid_mapping):
2134
2135 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2136
2137         [ews-app] Add timestamp fields for BuilderMappings
2138         https://bugs.webkit.org/show_bug.cgi?id=194266
2139
2140         Reviewed by Lucas Forschler.
2141
2142         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2143         (BuilderMapping):
2144
2145 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2146
2147         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2148         https://bugs.webkit.org/show_bug.cgi?id=174816
2149
2150         Reviewed by Michael Catanzaro.
2151
2152         Add tests for webkit_uri_for_display().
2153
2154         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2155         (testURIForDisplayUnaffected):
2156         (testURIForDisplayAffected):
2157         (beforeAll):
2158         (afterAll):
2159         * TestWebKitAPI/glib/CMakeLists.txt:
2160
2161 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2162
2163         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2164         https://bugs.webkit.org/show_bug.cgi?id=194158
2165         <rdar://problem/47737268>
2166
2167         Rubber-stamped by Aakash Jain.
2168
2169         * Scripts/webkitpy/port/device_port.py:
2170         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2171
2172 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2173
2174         [CG] Enable setAdditionalSupportedImageTypes for WK1
2175         https://bugs.webkit.org/show_bug.cgi?id=194190
2176
2177         Reviewed by Tim Horton.
2178
2179         Add a test similar to the one under WebKit Cocoa but make it create a
2180         WebView instead of a WKWebView.
2181
2182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2183         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2184         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2185         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2186         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2187         (TestWebKitAPI::runTest):
2188         (TestWebKitAPI::TEST):
2189
2190 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2191
2192         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2193         https://bugs.webkit.org/show_bug.cgi?id=194168
2194
2195         Reviewed by Simon Fraser.
2196
2197         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2198
2199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2200         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2201         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2202         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2203         (TEST):
2204         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2205         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2206
2207 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2208
2209         REGRESSION (r237269): webkit-patch what-broke is broken 
2210         https://bugs.webkit.org/show_bug.cgi?id=193025
2211
2212         Reviewed by Aakash Jain.
2213
2214         * Scripts/webkitpy/common/host.py:
2215         (Host.buildbot):
2216         (Host.bugzilla): Renamed to 'buildbot'.
2217
2218 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2219
2220         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2221         https://bugs.webkit.org/show_bug.cgi?id=194207
2222
2223         Reviewed by Tim Horton.
2224
2225         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2226         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2227         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2228         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2229         start and delete forwards to remove the original attachment.
2230
2231         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2232         (TestWebKitAPI::TEST):
2233
2234 2019-02-04  Youenn Fablet  <youenn@apple.com>
2235
2236         Capture state should be managed consistently when doing process swapping
2237         https://bugs.webkit.org/show_bug.cgi?id=194122
2238         <rdar://problem/47609293>
2239
2240         Reviewed by Eric Carlson.
2241
2242         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2243         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2244         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2245         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2246         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2247         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2248         (WTR::TestRunner::isDoingMediaCapture const):
2249         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2250         * WebKitTestRunner/TestController.cpp:
2251         (WTR::TestController::isDoingMediaCapture const):
2252         * WebKitTestRunner/TestController.h:
2253         * WebKitTestRunner/TestInvocation.cpp:
2254         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2255         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2256         (WTR::TestController::isDoingMediaCapture const):
2257
2258 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2259
2260         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2261         https://bugs.webkit.org/show_bug.cgi?id=194142
2262
2263         Reviewed by Ross Kirsling.
2264
2265         There three 'separator' variables in TestController.cpp. Renamed
2266         it 'pathSeparator', and unified them.
2267
2268         * WebKitTestRunner/TestController.cpp:
2269         (WTR::TestController::generateContextConfiguration const):
2270         (WTR::createTestURL):
2271         (WTR::TestController::platformAdjustContext):
2272
2273 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2274
2275         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2276         https://bugs.webkit.org/show_bug.cgi?id=194198
2277
2278         Reviewed by Antti Koivisto.
2279
2280         No need to set the banner heights on navigation now, since Page stores them.
2281
2282         * MiniBrowser/mac/WK2BrowserWindowController.m:
2283         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2284
2285 2019-02-03  John Wilander  <wilander@apple.com>
2286
2287         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2288         https://bugs.webkit.org/show_bug.cgi?id=194104
2289         <rdar://problem/47649991>
2290
2291         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2292
2293         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2294         (TestWebKitAPI::TEST):
2295             Changed numeric types from unsigned short to uint32_t.
2296
2297 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2298
2299         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2300         <https://webkit.org/b/194178>
2301         <rdar://problem/47753473>
2302
2303         Reviewed by Alexey Proskuryakov.
2304
2305         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2306         (WTR::uninstallFakeHelvetica): Pass nullptr into
2307         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2308
2309 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2310
2311         [LFC] Initialize ICB's style with fixed width/height.
2312         https://bugs.webkit.org/show_bug.cgi?id=194188
2313
2314         Reviewed by Antti Koivisto.
2315
2316         * LayoutReloaded/misc/LFC-passing-tests.txt:
2317
2318 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2319
2320         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2321         https://bugs.webkit.org/show_bug.cgi?id=194185
2322
2323         Reviewed by Antti Koivisto.
2324
2325         * LayoutReloaded/misc/LFC-passing-tests.txt:
2326
2327 2018-12-16  Darin Adler  <darin@apple.com>
2328
2329         Convert additional String::format clients to alternative approaches
2330         https://bugs.webkit.org/show_bug.cgi?id=192746
2331
2332         Reviewed by Alexey Proskuryakov.
2333
2334         * WebKitTestRunner/TestController.cpp:
2335         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2336         as an intermediate in code that ultimately constructs a WTF::String.
2337         (WTR::userMediaOriginHash): Use makeString.
2338         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2339         (WTR::TestController::didPerformClientRedirect): Ditto.
2340         (WTR::TestController::didPerformServerRedirect): Ditto.
2341         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2342
2343 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2344
2345         [ews-build] Add unit test to verify builder keys
2346         https://bugs.webkit.org/show_bug.cgi?id=194152
2347
2348         Reviewed by Lucas Forschler.
2349
2350         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2351         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2352
2353 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2354
2355         [LFC] Expand tests coverage (12 new tests -> 787)
2356
2357         Unreviewed test gardening.
2358
2359         * LayoutReloaded/misc/LFC-passing-tests.txt:
2360
2361 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2362
2363         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2364         https://bugs.webkit.org/show_bug.cgi?id=194163
2365
2366         Reviewed by Simon Fraser.
2367
2368         775
2369
2370         * LayoutReloaded/misc/LFC-passing-tests.txt:
2371
2372 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2373
2374         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2375         https://bugs.webkit.org/show_bug.cgi?id=194140
2376         <rdar://problem/47728098>
2377
2378         Reviewed by Tim Horton.
2379
2380         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2381         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2382         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2383
2384         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2385         test to induce an IPC deadlock when presenting a modal alert during touch start.
2386
2387         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2388         * WebKitTestRunner/TestController.cpp:
2389         (WTR::runJavaScriptAlert):
2390
2391         Add a client callback function for running JavaScript alerts.
2392
2393         (WTR::TestController::createOtherPage):
2394         (WTR::TestController::generateContextConfiguration const):
2395
2396         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2397         the fix in this patch.
2398
2399         (WTR::TestController::createWebViewWithOptions):
2400
2401         Plumb TestOptions to generateContextConfiguration.
2402
2403         (WTR::TestController::resetPreferencesToConsistentValues):
2404         (WTR::TestController::resetStateToConsistentValues):
2405         (WTR::updateTestOptionsFromTestHeader):
2406         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2407         (WTR::TestController::handleJavaScriptAlert):
2408         * WebKitTestRunner/TestController.h:
2409         * WebKitTestRunner/TestInvocation.cpp:
2410         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2411         * WebKitTestRunner/TestOptions.h:
2412         (WTR::TestOptions::hasSameInitializationOptions const):
2413
2414 2019-02-01  Chris Dumez  <cdumez@apple.com>
2415
2416         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2417         https://bugs.webkit.org/show_bug.cgi?id=193740
2418         <rdar://problem/47527267>
2419
2420         Reviewed by Alex Christensen.
2421
2422         Add API test coverage.
2423
2424         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2425
2426 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2427
2428         [ews-app] Add display name field to BuilderMapping model
2429         https://bugs.webkit.org/show_bug.cgi?id=194153
2430
2431         Reviewed by Lucas Forschler.
2432
2433         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2434         (BuilderMapping):
2435
2436 2019-02-01  Youenn Fablet  <youenn@apple.com>
2437
2438         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2439         https://bugs.webkit.org/show_bug.cgi?id=194155
2440
2441         Reviewed by Eric Carlson.
2442
2443         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2444         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2445         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2446
2447 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2448
2449         [LFC] Adjust replaced element's intrinsic ratio
2450         https://bugs.webkit.org/show_bug.cgi?id=194154
2451
2452         Reviewed by Antti Koivisto.
2453
2454         761
2455
2456         * LayoutReloaded/misc/LFC-passing-tests.txt:
2457
2458 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2459
2460         [WPE] Show test results in minibrowser
2461         https://bugs.webkit.org/show_bug.cgi?id=194150
2462
2463         Reviewed by Žan Doberšek.
2464
2465         * Scripts/webkitpy/port/wpe.py:
2466         (WPEPort.show_results_html_file):
2467
2468 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2469
2470         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2471         https://bugs.webkit.org/show_bug.cgi?id=194151
2472
2473         Reviewed by Žan Doberšek.
2474
2475         ALT + <- go back
2476         ALT + -> go forward
2477
2478         * MiniBrowser/wpe/main.cpp:
2479         (main):
2480
2481 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2482
2483         [LFC] Set intrinsic size on Layout::Replaced
2484         https://bugs.webkit.org/show_bug.cgi?id=194139
2485
2486         Reviewed by Antti Koivisto.
2487
2488         744
2489
2490         * LayoutReloaded/misc/LFC-passing-tests.txt:
2491
2492 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2493
2494         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2495         https://bugs.webkit.org/show_bug.cgi?id=194146
2496
2497         Reviewed by Xabier Rodriguez-Calvar.
2498
2499         It allows to open relative paths.
2500
2501         * MiniBrowser/wpe/main.cpp:
2502         (main):
2503
2504 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2505
2506         Update flakiness dashboard configuration after recent queue changes
2507         https://bugs.webkit.org/show_bug.cgi?id=194127
2508
2509         Rubber-stamped by Aakash Jain.
2510
2511         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2512
2513         * TestResultServer/static-dashboards/builders.jsonp:
2514
2515 2019-01-31  Youenn Fablet  <youenn@apple.com>
2516
2517         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2518         https://bugs.webkit.org/show_bug.cgi?id=194106
2519         <rdar://problem/47676333>
2520
2521         Reviewed by Ryosuke Niwa.
2522
2523         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2524         (TestWebKitAPI::didFinishNavigation):
2525         (TestWebKitAPI::TEST):
2526         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2527
2528 2019-01-31  Chris Dumez  <cdumez@apple.com>
2529
2530         Page zoom level is lost after a process swap or a crash
2531         https://bugs.webkit.org/show_bug.cgi?id=194105
2532         <rdar://problem/47610781>
2533
2534         Reviewed by Alex Christensen.
2535
2536         Add API test coverage.
2537
2538         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2539         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2540
2541 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2542
2543         Revert r238819 which is unneeded and caused a performance regression.
2544         https://bugs.webkit.org/show_bug.cgi?id=192272
2545         <rdar://problem/46664625>
2546
2547         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2548         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2549         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2550
2551 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2552
2553         Formalize WebKitAdditions mechanism of LoadOptimizer
2554         https://bugs.webkit.org/show_bug.cgi?id=193886
2555         <rdar://problem/47696809>
2556
2557         Reviewed by Brent Fulgham.
2558
2559         * MiniBrowser/MiniBrowser.entitlements:
2560         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2561
2562 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2563
2564         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2565         https://bugs.webkit.org/show_bug.cgi?id=194090
2566
2567         Reviewed by Antti Koivisto.
2568
2569         * LayoutReloaded/misc/LFC-passing-tests.txt:
2570
2571 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2572
2573         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2574         https://bugs.webkit.org/show_bug.cgi?id=194074
2575
2576         Reviewed by Antti Koivisto.
2577
2578         * LayoutReloaded/misc/LFC-passing-tests.txt:
2579
2580 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2581
2582         [LFC][BFC] Add support for block level replaced box.
2583         https://bugs.webkit.org/show_bug.cgi?id=194071
2584
2585         Reviewed by Antti Koivisto.
2586
2587         * LayoutReloaded/misc/LFC-passing-tests.txt:
2588
2589 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2590
2591         Fix WebKitTestRunner's testPath with Windows full paths
2592         https://bugs.webkit.org/show_bug.cgi?id=194012
2593
2594         Reviewed by Alex Christensen.
2595
2596         updateTestOptionsFromTestHeader failed to open test files because
2597         testPath returned wrong file paths. It returned a path "/C:/..."
2598         if a URL "file:///C:/..." was given.
2599
2600         * WebKitTestRunner/TestController.cpp:
2601         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2602
2603 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2604
2605         [WPE] Bump font related dependencies to match the GTK+ port
2606         https://bugs.webkit.org/show_bug.cgi?id=194017
2607
2608         Reviewed by Žan Doberšek.
2609
2610         * wpe/jhbuild.modules:
2611         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2612         * wpe/patches/icudata-stdlibs.patch: Added.
2613
2614 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2615
2616         Enable swipe tests on iOS
2617         https://bugs.webkit.org/show_bug.cgi?id=194076
2618
2619         Reviewed by Geoffrey Garen.
2620
2621         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2622         it causes a debug assertion failure in runUIScript.
2623
2624         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2625         (WTR::UIScriptController::beginBackSwipe):
2626         (WTR::UIScriptController::completeBackSwipe):
2627
2628 2019-01-30  Keith Rollin  <krollin@apple.com>
2629
2630         Use correct printf format specifier
2631         https://bugs.webkit.org/show_bug.cgi?id=194062
2632         <rdar://problem/47686167>
2633
2634         Reviewed by Alexey Proskuryakov.
2635
2636         LayoutTestSpellChecker.mm is trying to format a variable of type
2637         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2638         actually an unsigned long long. Fix this by formatting with %llu.
2639
2640         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2641         (-[LayoutTestTextCheckingResult description]):
2642
2643 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2644
2645         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2646         https://bugs.webkit.org/show_bug.cgi?id=193979
2647
2648         Reviewed by Wenson Hsieh.
2649
2650         Fix the test for iOS. Make the test work with iOS UA string.
2651
2652         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2653
2654 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2655
2656         Replace High Sierra LLINT CLoop bot due to hardware failure
2657         https://bugs.webkit.org/show_bug.cgi?id=194066
2658
2659         Reviewed by Aakash Jain.
2660
2661         * BuildSlaveSupport/build.webkit.org-config/config.json:
2662
2663 2019-01-30  Keith Rollin  <krollin@apple.com>
2664
2665         [NSDragItem init] is unavailable
2666         https://bugs.webkit.org/show_bug.cgi?id=194059
2667         <rdar://problem/47685715>
2668
2669         Reviewed by Wenson Hsieh.
2670
2671         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2672         DumpRenderTree and TestWebKitAPI, which both try to create an
2673         NSDragItem in a manner that invokes this method. Address this by using
2674         -initWithPasteboardWriter instead.
2675
2676         Note that the parameter passed to initWithPasteboardWriter is likely
2677         incorrect. In both cases, the object passed does not conform to
2678         NSPasteboardWriting. However, with this fix, we're no worse off than
2679         before, and can now perform builds with newer compilers and SDKs until
2680         a real fix can be crafted. That work is tracked in
2681         https://bugs.webkit.org/show_bug.cgi?id=194060
2682
2683         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2684         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2685         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2686         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2687
2688 2019-01-30  Daniel Bates  <dabates@apple.com>
2689
2690         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2691         https://bugs.webkit.org/show_bug.cgi?id=192824
2692         <rdar://problem/47100332>
2693
2694         Reviewed by Wenson Hsieh.
2695
2696         Fix a bug where the wrong usage code was used for F13 thru F24.
2697
2698         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2699         (keyCodeForDOMFunctionKey):
2700
2701 2019-01-30  Chris Dumez  <cdumez@apple.com>
2702
2703         Regression(PSON) Load hang can occur on history navigation
2704         https://bugs.webkit.org/show_bug.cgi?id=194030
2705         <rdar://problem/47656939>
2706
2707         Reviewed by Antti Koivisto.
2708
2709         Add API test coverage.
2710
2711         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2712
2713 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2714
2715         [LFC] Expand tests coverage.
2716
2717         Unreviewed test gardening.
2718
2719         * LayoutReloaded/misc/LFC-passing-tests.txt:
2720
2721 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2722
2723         [Flatpak] Add openjpeg support
2724         https://bugs.webkit.org/show_bug.cgi?id=194019
2725
2726         Reviewed by Michael Catanzaro.
2727
2728         * flatpak/org.webkit.CommonModules.yaml:
2729
2730 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2731
2732         Unreviewed, rolling out r240708.
2733         https://bugs.webkit.org/show_bug.cgi?id=194022
2734
2735         It broke WPE build (Requested by KaL on #webkit).
2736
2737         Reverted changeset:
2738
2739         "[WPE] Bump font related dependencies to match the GTK+ port"
2740         https://bugs.webkit.org/show_bug.cgi?id=194017
2741         https://trac.webkit.org/changeset/240708
2742
2743 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2744
2745         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2746         https://bugs.webkit.org/show_bug.cgi?id=194001
2747
2748         Reviewed by Antti Koivisto.
2749
2750         * LayoutReloaded/misc/LFC-passing-tests.txt:
2751
2752 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2753
2754         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2755         https://bugs.webkit.org/show_bug.cgi?id=194020
2756
2757         Reviewed by Antti Koivisto.
2758
2759         * LayoutReloaded/misc/LFC-passing-tests.txt:
2760
2761 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2762
2763         AX: Support color well on iOS
2764         https://bugs.webkit.org/show_bug.cgi?id=194010
2765
2766         Reviewed by Joanmarie Diggs.
2767
2768         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2769         (WTR::AccessibilityUIElement::stringAttributeValue):
2770
2771 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2772
2773         [WPE] Bump font related dependencies to match the GTK+ port
2774         https://bugs.webkit.org/show_bug.cgi?id=194017
2775
2776         Reviewed by Žan Doberšek.
2777
2778         * wpe/jhbuild.modules:
2779         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2780         * wpe/patches/icudata-stdlibs.patch: Added.
2781
2782 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2783
2784         [Mac] Update window scale API usage
2785         https://bugs.webkit.org/show_bug.cgi?id=193991
2786         rdar://problem/47614795
2787
2788         Reviewed by Tim Horton.
2789
2790         * DumpRenderTree/mac/DumpRenderTree.mm:
2791         (changeWindowScaleIfNeeded):
2792         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2793         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2794         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2795
2796 2019-01-29  Chris Dumez  <cdumez@apple.com>
2797
2798         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2799         https://bugs.webkit.org/show_bug.cgi?id=193977
2800         <rdar://problem/47643716>
2801
2802         Reviewed by Geoff Garen.
2803
2804         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2805         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2806         to the previous provisional committing *before* we make the last load. 
2807
2808         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2809
2810 2019-01-29  Youenn Fablet  <youenn@apple.com>
2811
2812         Adopt new SPI to evaluate server certificate trust
2813         https://bugs.webkit.org/show_bug.cgi?id=193355
2814
2815         Reviewed by Alex Christensen.
2816
2817         Add infrastructure to handle HTTPS server trust evaluation testing.
2818
2819         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2820         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2821         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2822         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2823         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2824         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2825         * WebKitTestRunner/TestController.cpp:
2826         (WTR::TestController::resetPreferencesToConsistentValues):
2827         (WTR::TestController::didReceiveAuthenticationChallenge):
2828         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2829         * WebKitTestRunner/TestController.h:
2830         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2831         * WebKitTestRunner/TestInvocation.cpp:
2832         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2833         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2834         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2835
2836 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2837
2838         [ews-build] Add build step to print bot Configuration
2839         https://bugs.webkit.org/show_bug.cgi?id=193887
2840
2841         Reviewed by Lucas Forschler.
2842
2843         * BuildSlaveSupport/ews-build/steps.py:
2844         (PrintConfiguration): Build step to print configuration.
2845         * BuildSlaveSupport/ews-build/factories.py:
2846
2847 2019-01-29  Chris Dumez  <cdumez@apple.com>
2848
2849         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2850         https://bugs.webkit.org/show_bug.cgi?id=193967
2851         <rdar://problem/47635348>
2852
2853         Reviewed by Alex Christensen.
2854
2855         Add API test coverage.
2856
2857         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2858         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2859
2860 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2861
2862         [ews-app] Handle incoming results data
2863         https://bugs.webkit.org/show_bug.cgi?id=193973
2864
2865         Reviewed by Lucas Forschler.
2866
2867         * BuildSlaveSupport/ews-app/ews/views/results.py:
2868
2869 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2870
2871         [ews-app] Make the results url generic
2872         https://bugs.webkit.org/show_bug.cgi?id=193928
2873
2874         Reviewed by Lucas Forschler.
2875
2876         * BuildSlaveSupport/ews-app/ews/urls.py:
2877
2878 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2879
2880         [ews-build] Configure buildbot to send events to ews-app
2881         https://bugs.webkit.org/show_bug.cgi?id=193968
2882
2883         Reviewed by Lucas Forschler.
2884
2885         * BuildSlaveSupport/ews-build/events.py: Added.
2886         * BuildSlaveSupport/ews-build/master.cfg:
2887
2888 2019-01-29  Keith Rollin  <krollin@apple.com>
2889
2890         Add .xcfilelists to Run Script build phases
2891         https://bugs.webkit.org/show_bug.cgi?id=193792
2892         <rdar://problem/47201785>
2893
2894         Reviewed by Alex Christensen.
2895
2896         As part of supporting XCBuild, update the necessary Run Script build
2897         phases in their Xcode projects to refer to their associated
2898         .xcfilelist files.
2899
2900         Note that the addition of these files bumps the Xcode project version
2901         number to something that's Xcode 10 compatible. This change means that
2902         older versions of the Xcode IDE can't read these projects. Nor can it
2903         fully load workspaces that refer to these projects (the updated
2904         projects are shown as non-expandable placeholders). `xcodebuild` can
2905         still build these projects; it's just that the IDE can't open them.
2906
2907         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2908         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2909
2910 2019-01-29  John Wilander  <wilander@apple.com>
2911
2912         Add data abstraction and validation for Ad Click Attribution
2913         https://bugs.webkit.org/show_bug.cgi?id=193916
2914         <rdar://problem/47603481>
2915
2916         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2917
2918         Ad click attribution has two steps. First, the storage of an ad
2919         campaign ID for a click that takes the user to a destination
2920         site. Second, a conversion on the destination site that can be
2921         attributed to the ad click.
2922
2923         This patch adds a class that represents a request for ad click
2924         attribution. Validation makes sure that the bits of entropy
2925         reported through this mechanism is limited.
2926
2927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2928         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2929         (TestWebKitAPI::TEST):
2930
2931 2019-01-29  Chris Dumez  <cdumez@apple.com>
2932
2933         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2934         https://bugs.webkit.org/show_bug.cgi?id=193932
2935         <rdar://problem/47598947>
2936
2937         Reviewed by Brady Eidson.
2938
2939         Add API test coverage.
2940
2941         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2942
2943 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2944
2945         Adding new passing LFC tests.
2946
2947         Unreviewed test gardening.
2948
2949         * LayoutReloaded/misc/LFC-passing-tests.txt:
2950
2951 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2952
2953         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2954         https://bugs.webkit.org/show_bug.cgi?id=193964
2955
2956         Reviewed by Antti Koivisto.
2957
2958         * LayoutReloaded/misc/LFC-passing-tests.txt:
2959
2960 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2961
2962         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2963         https://bugs.webkit.org/show_bug.cgi?id=193954
2964
2965         Reviewed by Antti Koivisto.
2966
2967         * LayoutReloaded/misc/LFC-passing-tests.txt:
2968
2969 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2970
2971         WebDriver: add support for running subtests
2972         https://bugs.webkit.org/show_bug.cgi?id=193904
2973
2974         Reviewed by Michael Catanzaro.
2975
2976         pytest already supports it by passing test.py::subtest, so we can do the same.
2977
2978         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2979         (get_item_name): Made this global.
2980         (CollectRecorder.__init__): Receive the parameter to ignore.
2981         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2982         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2983         (collect): Add parameter to ignore.
2984         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2985         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2986         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2987         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2988         (WebDriverTestRunnerSelenium.run): Ditto.
2989         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2990         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2991         (WebDriverTestRunnerW3C.run): Ditto.
2992
2993 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2994
2995         User agent string override for navigator.userAgent should be site specific quirks
2996         https://bugs.webkit.org/show_bug.cgi?id=193950
2997
2998         Reviewed by Brent Fulgham.
2999
3000         Updated per the _WKWebsitePolicies rename.
3001
3002         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3003         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3004
3005 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3006
3007         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3008         https://bugs.webkit.org/show_bug.cgi?id=193941
3009
3010         Reviewed by Alex Christensen.
3011
3012         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3013         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3014         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3015         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3016         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3017         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3018         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3019         * TestWebKitAPI/Tests/WTF/Time.cpp:
3020         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3021         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3022         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3023         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3024
3025 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3026
3027         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3028
3029         * Scripts/webkitpy/common/config/contributors.json:
3030
3031 2019-01-28  Andy Estes  <aestes@apple.com>
3032
3033         [watchOS] Enable Parental Controls content filtering
3034         https://bugs.webkit.org/show_bug.cgi?id=193939
3035         <rdar://problem/46641912>
3036
3037         Reviewed by Ryosuke Niwa.
3038
3039         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3040
3041 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3042
3043         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3044         <https://webkit.org/b/193884>
3045
3046         Reviewed by Jiewen Tan.
3047
3048         * Scripts/webkitpy/style/checkers/cpp.py:
3049         (check_language): Add LocalAuthentication to
3050         `frameworks_with_soft_links`.
3051
3052 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3053
3054         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3055         https://bugs.webkit.org/show_bug.cgi?id=193891
3056
3057         Reviewed by Ross Kirsling.
3058
3059         There were three problems in window sizes of WebView and the host window.
3060         1. The sizes of pixel image output were incorrect.
3061         2. The host window is going to appear after window.resize was invoked.
3062         3. window.resize resized only the host window, not WebView.
3063
3064         This change solves them with a following approach.
3065         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3066         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3067            as well as DumpRenderTree in order to match the client area and the window area.
3068         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3069         d. PlatformWebView::setWindowFrame changes both window sizes.
3070         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3071
3072         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3073         (WTR::PlatformWebView::PlatformWebView): Create the host window
3074         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3075         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3076         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3077
3078 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3079
3080         [ews-app] Add method to save Step data to database
3081         https://bugs.webkit.org/show_bug.cgi?id=193890
3082
3083         Reviewed by Lucas Forschler.
3084
3085         * BuildSlaveSupport/ews-app/ews/models/step.py:
3086         (Step.save_step): Method to save step data.
3087         (Step.update_step): Method to update step data.
3088         (Step.get_existing_step): Method to fetch existing step from database.
3089         (Step.is_valid_result): Method to validate valid step result.
3090
3091 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3092
3093         [ews-app] Add method to save Build data to database
3094         https://bugs.webkit.org/show_bug.cgi?id=193735
3095
3096         Reviewed by Lucas Forschler.
3097
3098         * BuildSlaveSupport/ews-app/ews/models/build.py:
3099         (Build.save_build): Method to save build information to database.
3100         (Build.get_existing_build): Method to fetch existing build from database.
3101         (Build.is_valid_result): Method to validate build result.
3102         * BuildSlaveSupport/ews-app/ews/common/util.py:
3103         (is_valid_int_id): Method to validate valid id.
3104
3105 2019-01-28  Chris Dumez  <cdumez@apple.com>
3106
3107         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3108         https://bugs.webkit.org/show_bug.cgi?id=193915
3109         <rdar://problem/47560907>
3110
3111         Reviewed by Alex Christensen.
3112
3113         Add API test coverage.
3114
3115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3116
3117 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3118
3119         [ews-app] Rename id variables
3120         https://bugs.webkit.org/show_bug.cgi?id=193883
3121
3122         Reviewed by Lucas Forschler.
3123
3124         * BuildSlaveSupport/ews-app/ews/models/build.py:
3125         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3126         * BuildSlaveSupport/ews-app/ews/models/step.py:
3127         * BuildSlaveSupport/ews-app/ews/urls.py:
3128         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3129         * BuildSlaveSupport/ews-app/ews/views/results.py:
3130         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3131
3132 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3133
3134         [ews-app] Allow certain fields to be empty
3135         https://bugs.webkit.org/show_bug.cgi?id=193892
3136
3137         Reviewed by Lucas Forschler.
3138
3139         * BuildSlaveSupport/ews-app/ews/models/build.py:
3140         * BuildSlaveSupport/ews-app/ews/models/step.py:
3141
3142 2019-01-28  Rob Buis  <rbuis@igalia.com>
3143
3144         Update MIME type parser
3145         https://bugs.webkit.org/show_bug.cgi?id=180526
3146
3147         Reviewed by Frédéric Wang.
3148
3149         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3150         (TestWebKitAPI::TEST):
3151
3152 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3153
3154         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3155         https://bugs.webkit.org/show_bug.cgi?id=193896
3156
3157         Reviewed by Antti Koivisto.
3158
3159         * LayoutReloaded/misc/LFC-passing-tests.txt:
3160
3161 2018-12-15  Darin Adler  <darin@apple.com>
3162
3163         Replace many uses of String::format with more type-safe alternatives
3164         https://bugs.webkit.org/show_bug.cgi?id=192742
3165
3166         Reviewed by Mark Lam.
3167
3168         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3169         (WTR::cacheTestRunnerCallback): Use makeString.
3170         * WebKitTestRunner/TestController.cpp:
3171         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3172         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3173
3174 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3175
3176         Use a load optimizer for some sites
3177         https://bugs.webkit.org/show_bug.cgi?id=193881
3178         <rdar://problem/46325455>
3179
3180         Reviewed by Brent Fulgham.
3181
3182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3183         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3184
3185 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3186
3187         AX: Introduce a static accessibility tree
3188         https://bugs.webkit.org/show_bug.cgi?id=193348
3189         <rdar://problem/47203295>
3190
3191         Reviewed by Ryosuke Niwa.
3192
3193         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3194
3195 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3196
3197         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3198         https://bugs.webkit.org/show_bug.cgi?id=193867
3199
3200         Reviewed by Antti Koivisto.
3201
3202         * LayoutReloaded/misc/LFC-passing-tests.txt:
3203
3204 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3205
3206         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3207         https://bugs.webkit.org/show_bug.cgi?id=193865
3208
3209         Reviewed by Antti Koivisto.
3210
3211         * LayoutReloaded/misc/LFC-passing-tests.txt:
3212
3213 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3214
3215         Need a mechanism to override navigator.userAgent
3216         https://bugs.webkit.org/show_bug.cgi?id=193762
3217         <rdar://problem/47504939>
3218
3219         Reviewed by Brent Fulgham.
3220
3221         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3222
3223         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3224         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3225         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3226
3227 2019-01-25  Dean Jackson  <dino@apple.com>
3228
3229         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3230         https://bugs.webkit.org/show_bug.cgi?id=193831
3231         <rdar://problem/47399263>
3232
3233         Reviewed by Chris Dumez.
3234
3235         Two new tests that exercise cross-origin and same-origin System
3236         Previews.
3237
3238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3239
3240 2019-01-25  Keith Rollin  <krollin@apple.com>
3241
3242         Update Xcode projects with "Check .xcfilelists" build phase
3243         https://bugs.webkit.org/show_bug.cgi?id=193790
3244         <rdar://problem/47201374>
3245
3246         Reviewed by Alex Christensen.
3247
3248         Support for XCBuild includes specifying inputs and outputs to various
3249         Run Script build phases. These inputs and outputs are specified as
3250         .xcfilelist files. Once created, these .xcfilelist files need to be
3251         kept up-to-date. In order to check that they are up-to-date or not,
3252         add an Xcode build step that invokes an external script that performs
3253         the checking. If the .xcfilelists are found to be out-of-date, update
3254         them, halt the build, and instruct the developer to restart the build
3255         with up-to-date files.
3256
3257         At this time, the checking and regenerating is performed only if the
3258         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3259         who want to use this facility can set this variable and test out the
3260         checking/regenerating. Once it seems like there are no egregious
3261         issues that upset a developer's workflow, we'll unconditionally enable
3262         this facility.
3263
3264         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3265         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3266         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3267         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3268
3269 2019-01-25  Keith Rollin  <krollin@apple.com>
3270
3271         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3272         https://bugs.webkit.org/show_bug.cgi?id=193781
3273         <rdar://problem/47201153>
3274
3275         Reviewed by Alex Christensen.
3276
3277         Part of generating the .xcfilelists used as part of adopting XCBuild
3278         includes running `make DerivedSources.make` from a standalone script.
3279         It’s important for this invocation to have the same environment as
3280         when the actual build invokes `make DerivedSources.make`. If the
3281         environments are different, then the two invocations will provide
3282         different results. In order to get the same environment in the
3283         standalone script, have the script launch xcodebuild targeting the
3284         "Apply Configuration to XCFileLists" build target, which will then
3285         re-invoke our standalone script. The script is now running again, this
3286         time in an environment with all workspace, project, target, xcconfig
3287         and other environment variables established.
3288
3289         The "Apply Configuration to XCFileLists" build target accomplishes
3290         this task via a small embedded shell script that consists only of:
3291
3292             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3293
3294         The process that invokes "Apply Configuration to XCFileLists" first
3295         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3296         evaluated and exports it into the shell environment. When xcodebuild
3297         is invoked, it inherits the value of this variable and can `eval` the
3298         contents of that variable. Our external standalone script can then set
3299         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3300         of command-line parameters needed to restart itself in the appropriate
3301         state.
3302
3303         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3304         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3305
3306 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3307
3308         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3309         https://bugs.webkit.org/show_bug.cgi?id=193802
3310         <rdar://problem/46010580>
3311
3312         Reviewed by Andy Estes.
3313
3314         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3315         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3316         (TEST):
3317
3318 2019-01-25  Daniel Bates  <dabates@apple.com>
3319
3320         [iOS] uiController.keyDown() does not translate Control modified key
3321         https://bugs.webkit.org/show_bug.cgi?id=192898
3322
3323         Reviewed by Wenson Hsieh.
3324
3325         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3326         key translation, as applicable. Among other cases, key translation occurs when performing
3327         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3328         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3329         human pressing down and releasing key(s) using a hardware keyboard.
3330
3331         * WebKitTestRunner/ios/HIDEventGenerator.h:
3332         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3333         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3334
3335         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3336         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3337         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3338         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3339         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3340         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3341         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3342         (-[HIDEventGenerator longPress:completionBlock:]):
3343         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3344         Update code for above renaming.
3345
3346         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3347         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3348
3349         (-[HIDEventGenerator keyDown:]): Added.
3350         (-[HIDEventGenerator keyUp:]): Added.
3351         (-[HIDEventGenerator keyPress:completionBlock:]):
3352         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3353         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3354         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3355         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3356         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3357         (WTR::parseModifier): Deleted.
3358
3359 2019-01-25  Keith Rollin  <krollin@apple.com>
3360
3361         Complete the implementation of generate-xcfilelists
3362         https://bugs.webkit.org/show_bug.cgi?id=193782
3363
3364         Reviewed by Alex Christensen.
3365
3366         A preliminary version of generate-xcfilelists was added in r238008.
3367         This patch updates that script in order to:
3368
3369         - Support checking of .xcfilelists
3370         - Perform better execution of `make DerivedSources.make` by
3371           relaunching generate-xcfilelists under xcodebuild
3372         - Support incremental generation and checking of .xcfilelists
3373         - Support supplementary .xcfilelists files from WebKitAdditions
3374         - Support being wrapped by parallel version of generate-xcfilelists in
3375           Internal that adds support for (re)generating WebKit projects in
3376           that repo.
3377         - Support builds that have been performed in WebKitBuild as well as
3378           ~/Library/Developer/code/DerivedData
3379         - Increase robustness and debugging facilities.
3380
3381         * Scripts/generate-xcfilelists:
3382
3383 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3384
3385         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3386         https://bugs.webkit.org/show_bug.cgi?id=193297
3387         <rdar://problem/47158841>
3388
3389         Unreviewed test case fix.
3390
3391         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3392         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3393
3394         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3395         (TEST):
3396
3397 2019-01-25  Keith Rollin  <krollin@apple.com>
3398
3399         Update existing .xcfilelists
3400         https://bugs.webkit.org/show_bug.cgi?id=193791
3401         <rdar://problem/47201706>
3402
3403         Reviewed by Alex Christensen.
3404
3405         Many .xcfilelist files were added in r238824 in order to support
3406         XCBuild. Update these with recent changes to the set of build files
3407         and with the current generate-xcfilelist script.
3408
3409         * DumpRenderTree/DerivedSources-input.xcfilelist:
3410         * DumpRenderTree/DerivedSources-output.xcfilelist:
3411         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3412         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3413
3414 2019-01-25  Keith Rollin  <krollin@apple.com>
3415
3416         Fix missing dependencies in extract-dependencies-from-makefile
3417         https://bugs.webkit.org/show_bug.cgi?id=193783
3418         <rdar://problem/47201571>
3419
3420         Reviewed by Alex Christensen.
3421
3422         The extract-dependencies-from-makefile script generates .xcfilelists
3423         for XCBuild by invoking a makefile in --debug mode, parsing the
3424         dependency information in the output, and extracting information
3425         regarding targets and dependents. However, the way `make` emits this
3426         dependency information is not rigorous, and so we need to determine
3427         what lines to look for and parse by trial and error. This approach
3428         didn't coriginally atch all the information we needed to collect, so
3429         update the script to look for the additional lines we now know to look
3430         for.
3431
3432         * Scripts/extract-dependencies-from-makefile:
3433         (Parser):
3434         (Parser.addTarget):
3435         (Parser.addPrereq):
3436         (Parser.doParse):
3437
3438 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3439
3440         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3441         https://bugs.webkit.org/show_bug.cgi?id=193297
3442         <rdar://problem/47158841>
3443
3444         Reviewed by Alex Christensen.
3445
3446         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3447             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3448         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3449         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3450         activating the message used to trigger the callback when it is set.
3451
3452 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3453
3454         WKWebView.goBack should reload if there is a safe browsing warning
3455         https://bugs.webkit.org/show_bug.cgi?id=193805
3456         <rdar://problem/46908216>
3457
3458         Reviewed by Geoff Garen.
3459
3460         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3461         (+[Simple3LookupContext sharedLookupContext]):
3462         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3463         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3464         (TEST):
3465
3466 2019-01-25  Chris Dumez  <cdumez@apple.com>
3467
3468         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3469         https://bugs.webkit.org/show_bug.cgi?id=193788
3470         <rdar://problem/47531231>
3471
3472         Reviewed by Alex Christensen.
3473
3474         Add API test coverage.
3475
3476         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3477         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3478
3479 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3480
3481         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3482         https://bugs.webkit.org/show_bug.cgi?id=193771
3483
3484         Unreviewed infrastructure fix.
3485
3486         * Scripts/webkitpy/port/darwin.py:
3487         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3488
3489 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3490
3491         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3492
3493 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3494
3495         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3496
3497         * Scripts/webkitpy/common/config/contributors.json:
3498
3499 2019-01-25  Chris Dumez  <cdumez@apple.com>
3500
3501         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3502         https://bugs.webkit.org/show_bug.cgi?id=193779
3503         <rdar://problem/46170903>
3504
3505         Reviewed by Antti Koivisto.
3506
3507         Add API test that quickly navigates forward to a previous process without waiting for it to
3508         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3509         the process' previous page when reconnecting the it for the forward navigation.
3510
3511         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3512
3513 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3514
3515         Need a way for JavaScript (or bundle) code to participate in undo
3516         https://bugs.webkit.org/show_bug.cgi?id=190009
3517         <rdar://problem/44807048>
3518
3519         Reviewed by Ryosuke Niwa.
3520
3521         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3522         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3523
3524         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3525         (WTR::UIScriptController::lastUndoLabel const):
3526         (WTR::UIScriptController::firstRedoLabel const):
3527         (WTR::UIScriptController::platformUndoManager const):
3528         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3529         (WTR::UIScriptController::lastUndoLabel const):
3530         (WTR::UIScriptController::firstRedoLabel const):
3531         (WTR::UIScriptController::platformUndoManager const):
3532         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3533         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3534         (WTR::UIScriptController::lastUndoLabel const):
3535         (WTR::UIScriptController::firstRedoLabel const):
3536         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3537         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3538         (WTR::UIScriptController::lastUndoLabel const):
3539         (WTR::UIScriptController::firstRedoLabel const):
3540         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3541         (WTR::UIScriptController::platformUndoManager const):
3542         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3543         (WTR::UIScriptController::platformUndoManager const):
3544
3545 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3546
3547         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3548         https://bugs.webkit.org/show_bug.cgi?id=193824
3549
3550         Reviewed by Antti Koivisto.
3551
3552         * LayoutReloaded/misc/LFC-passing-tests.txt:
3553
3554 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3555
3556         Update macOS JSC bot configurations
3557         https://bugs.webkit.org/show_bug.cgi?id=193739
3558
3559         Reviewed by Alexey Proskuryakov.
3560
3561         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3563         (BubbleQueueServer): Move JSC EWS to Mojave section.
3564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3565         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3566         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3567
3568 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3569
3570         [Win][WebKitTestRunner] Implement EventSenderProxy
3571         https://bugs.webkit.org/show_bug.cgi?id=193755
3572
3573         Reviewed by Don Olmstead.
3574
3575         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3576         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3577         (WTR::EventSenderProxy::dispatchMessage):
3578         (WTR::EventSenderProxy::EventSenderProxy):
3579         (WTR::EventSenderProxy::mouseDown):
3580         (WTR::EventSenderProxy::mouseUp):
3581         (WTR::EventSenderProxy::mouseMoveTo):
3582         (WTR::EventSenderProxy::mouseScrollBy):
3583         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3584
3585 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3586
3587         Unreviewed fix for API test failure after r240437.
3588
3589         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3590
3591         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3592
3593 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3594
3595         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3596         https://bugs.webkit.org/show_bug.cgi?id=193787
3597         <rdar://problem/47497634>
3598
3599         Reviewed by Alexey Proskuryakov.
3600
3601         * Scripts/webkitdirs.pm:
3602         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3603
3604 2019-01-24  Truitt Savell  <tsavell@apple.com>
3605
3606         Unreviewed, rolling out r240446.
3607
3608         Casued 5 API failures
3609
3610         Reverted changeset:
3611
3612         "Activate the WebResourceLoadStatisticsStore in the
3613         NetworkProcess and deactivate it in the UIProcess."
3614         https://bugs.webkit.org/show_bug.cgi?id=193297
3615         https://trac.webkit.org/changeset/240446
3616
3617 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3618
3619         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3620         https://bugs.webkit.org/show_bug.cgi?id=193741
3621         <rdar://problem/47135030>
3622
3623         Reviewed by Antti Koivisto and Simon Fraser.
3624
3625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3626         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3627         (TestWebKitAPI::TEST):
3628
3629 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3630
3631         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3632         https://bugs.webkit.org/show_bug.cgi?id=193297
3633         <rdar://problem/47158841>
3634
3635         Reviewed by Alex Christensen.
3636
3637         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3638         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3639         activating the message used to trigger the callback when it is set.
3640
3641 2019-01-24  John Wilander  <wilander@apple.com>
3642
3643         Add Ad Click Attribution as an internal/experimental feature
3644         https://bugs.webkit.org/show_bug.cgi?id=193685
3645         <rdar://problem/47450399>
3646
3647         Reviewed by Brent Fulgham.
3648
3649         Added test option adClickAttributionEnabled.
3650
3651         * DumpRenderTree/TestOptions.cpp:
3652         (TestOptions::TestOptions):
3653         * DumpRenderTree/TestOptions.h:
3654         * DumpRenderTree/mac/DumpRenderTree.mm:
3655         (setWebPreferencesForTestOptions):
3656
3657 2019-01-24  Antti Koivisto  <antti@apple.com>
3658
3659         [PSON] Flash on back navigation on Mac
3660         https://bugs.webkit.org/show_bug.cgi?id=193716
3661         <rdar://problem/47148458>
3662
3663         Reviewed by Chris Dumez.
3664
3665         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3666
3667         Closing of the previous page is delayed so waiting for didFinishNavigation is
3668         not sufficient to guarantee we have received all the messages. Wait for them.
3669
3670 2019-01-24  Chris Dumez  <cdumez@apple.com>
3671
3672         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3673         https://bugs.webkit.org/show_bug.cgi?id=193761
3674         <rdar://problem/47456405>
3675
3676         Reviewed by Alex Christensen.
3677
3678         Add API test coverage.
3679
3680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3681
3682 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3683
3684         webkitpy: Missing PID in crashlog name should not be fatal
3685         https://bugs.webkit.org/show_bug.cgi?id=193771
3686
3687         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3688         of raising an exception.
3689
3690         Reviewed by Lucas Forschler.
3691
3692         * Scripts/webkitpy/port/darwin.py:
3693         (DarwinPort._merge_crash_logs):
3694
3695 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3696
3697         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3698         https://bugs.webkit.org/show_bug.cgi?id=193746
3699
3700         Reviewed by Youenn Fablet.