Update flakiness dashboard configuration for iOS 13 queues
[WebKit-https.git] / Tools / ChangeLog
1 2019-09-18  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Update flakiness dashboard configuration for iOS 13 queues
4         https://bugs.webkit.org/show_bug.cgi?id=201711
5
6         Reviewed by Jonathan Bedard.
7
8         * TestResultServer/static-dashboards/builders.jsonp:
9
10 2019-09-18  Adrian Perez de Castro  <aperez@igalia.com>
11
12         [WPE][GTK] Update build environments to use libwpe+WPEBackend-fdo 1.4.0
13         https://bugs.webkit.org/show_bug.cgi?id=201915
14
15         Reviewed by Michael Catanzaro.
16
17         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.4.0
18         * gtk/jhbuild.modules: Ditto.
19         * wpe/jhbuild.modules: Ditto.
20
21 2019-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
22
23         [Win][MiniBrowser] Remove unused DOMDefaultImpl.cpp
24         https://bugs.webkit.org/show_bug.cgi?id=201867
25
26         Reviewed by Darin Adler.
27
28         * MiniBrowser/win/CMakeLists.txt: Removed DOMDefaultImpl.cpp.
29         * MiniBrowser/win/DOMDefaultImpl.cpp: Removed.
30         * MiniBrowser/win/DOMDefaultImpl.h: Removed.
31         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
32
33 2019-09-17  Dean Jackson  <dino@apple.com>
34
35         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
36         https://bugs.webkit.org/show_bug.cgi?id=201864
37         <rdar://55190038>
38
39         Reviewed by Simon Fraser.
40
41         Test for the suggested actions.
42
43         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
44         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
45         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
46         (TEST):
47
48 2019-09-17  Jonathan Bedard  <jbedard@apple.com>
49
50         results.webkit.org results bubbles' tooltips should include SDK information
51         https://bugs.webkit.org/show_bug.cgi?id=201823
52
53         Rubber-stamped by Aakash Jain.
54
55         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
56         (Configuration.prototype.compare): Like the Python instance of this class,
57         support using null as a wildcard.
58         (Configuration.prototype.compareSDKs): Ditto.
59         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
60         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Construct a configuration
61         object from all bits of data used to construct a given bubble.
62         (TimelineFromEndpoint.prototype.render):
63
64 2019-09-17  Keith Rollin  <krollin@apple.com>
65
66         Remove some support for < iOS 12
67         https://bugs.webkit.org/show_bug.cgi?id=201851
68         <rdar://problem/55422044>
69
70         Reviewed by Jiewen Tan and Alexey Proskuryakov.
71
72         Remove some support for iOS versions less than 12.0.
73
74         Update conditionals that reference __IPHONE_OS_VERSION_MIN_REQUIRED
75         and __IPHONE_OS_VERSION_MAX_ALLOWED, assuming that they both have
76         values >= 120000. This means that expressions like
77         "__IPHONE_OS_VERSION_MIN_REQUIRED < 101200" are always False and
78         "__IPHONE_OS_VERSION_MIN_REQUIRED >= 101200" are always True.
79
80         This removal is part of a series of patches effecting such removal.
81
82         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
83         (WTR::installFakeHelvetica):
84
85 2019-09-17  David Kilzer  <ddkilzer@apple.com>
86
87         run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test()
88         <https://webkit.org/b/201873>
89
90         Reviewed by Jonathan Bedard.
91
92         * Scripts/webkitpy/port/driver.py:
93         (Driver.run_test): Call self.do_post_tests_work() when a test
94         shard has completed, but didn't crash or time out.
95
96 2019-09-17  Chris Dumez  <cdumez@apple.com>
97
98         REGRESSION (r249923): ASSERTION FAILED: sessionID == WebProcess::singleton().sessionID() in WebCore::SWClientConnection *WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID)
99         https://bugs.webkit.org/show_bug.cgi?id=201859
100         <rdar://problem/55426742>
101
102         Reviewed by Alex Christensen.
103
104         Update API test to use WKWebsiteDataStoreRef C API to do private browsing instead of using
105         the legacy WKPreferencesSetPrivateBrowsingEnabled() C API.
106
107         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
108         (TestWebKitAPI::TEST):
109
110 2019-09-17  Ryan Haddad  <ryanhaddad@apple.com>
111
112         Bring up queues for iOS 13
113         https://bugs.webkit.org/show_bug.cgi?id=201710
114
115         Reviewed by Jonathan Bedard.
116
117         * BuildSlaveSupport/build.webkit.org-config/config.json: Move iOS 12 queues to iOS 13.
118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Ditto.
119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
120         (WebKitBuildbot):
121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
122         (table.queue-grid tr.platform.ios-simulator-12 img.logo): Deleted.
123         (table.queue-grid tr.platform.ios-12 img.logo): Deleted.
124         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit tests.
125         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
126         (_should_file_trigger_build):
127         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
128         (ShouldBuildTest):
129         (ShouldBuildTest.test_should_build):
130         * BuildSlaveSupport/ews-build/config.json: Move iOS 12 queues to iOS 13.
131
132 2019-09-17  Truitt Savell  <tsavell@apple.com>
133
134         Unreviewed, rolling out r249950.
135
136         Broke the iOS build.
137
138         Reverted changeset:
139
140         "Remove the "Show Link Previews" and "Hide Link Previews"
141         action menus in the preview platter"
142         https://bugs.webkit.org/show_bug.cgi?id=201864
143         https://trac.webkit.org/changeset/249950
144
145 2019-09-17  Dean Jackson  <dino@apple.com>
146
147         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
148         https://bugs.webkit.org/show_bug.cgi?id=201864
149         <rdar://55190038>
150
151         Reviewed by Simon Fraser.
152
153         Test for the suggested actions.
154
155         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
156         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
157         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
158         (TEST):
159
160 2019-09-16  Alex Christensen  <achristensen@webkit.org>
161
162         Remove "gopher" from list of special schemes in URLParser
163         https://bugs.webkit.org/show_bug.cgi?id=201852
164
165         Reviewed by Simon Fraser.
166
167         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
168         (TestWebKitAPI::TEST_F):
169         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
170         (TestWebKitAPI::TEST_F):
171         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
172
173 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
174
175         results.webkit.org: Shard result archives
176         https://bugs.webkit.org/show_bug.cgi?id=201734
177
178         Reviewed by Dewei Zhu.
179
180         Cassandra advertises being able to store up to 2 GB in a single blob-storage row.
181         In practice, this usually doesn't work according to the Cassandra developers,
182         large blobs should be broken up into shards of, at most, 10 MB.
183
184         * resultsdbpy/resultsdbpy/model/archive_context.py:
185         (ArchiveContext):
186         (ArchiveContext.ArchiveMetaDataByCommit): Point to the archive shards by hash.
187         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
188         (ArchiveContext.ArchiveChunks): Store archive shards, indexed by hash.
189         (ArchiveContext.__init__):
190         (ArchiveContext.register): When saving archives, save a reference hash and then
191         shard the actual archive data before saving.
192         (ArchiveContext.find_archive): Search for archive by meta-data, then reconstruct
193         the archive. Raise an exception if we determine that memory usage is a problem.
194         (ArchiveContext.ArchivesByCommit): Deleted.
195         (ArchiveContext.ArchivesByCommit.unpack): Deleted.
196         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py:
197         (ArchiveContextTest.init_database): Allow configuration and archive to be specified.
198         (ArchiveContextTest):
199         (ArchiveContextTest.test_large_archive): Test archive sharding.
200
201 2019-09-16  Jiewen Tan  <jiewen_tan@apple.com>
202
203         [WebAuthn] Support more than two FIDO protocol versions
204         https://bugs.webkit.org/show_bug.cgi?id=198408
205         <rdar://problem/51292176>
206
207         Reviewed by Chris Dumez.
208
209         Adds a new test case that includes a FIDO_2_1_PRE version string.
210
211         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
212         (TestWebKitAPI::TEST):
213         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
214
215 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
216
217         results.webkit.org: Configurations should be branch specific
218         https://bugs.webkit.org/show_bug.cgi?id=201561
219
220         Reviewed by Dewei Zhu.
221
222         Partition configurations by branch in both Redis and Cassandra.
223
224         * resultsdbpy/resultsdbpy/controller/upload_controller.py:
225         (UploadController.suites): Allow the user to specify branches while listing suites.
226         * resultsdbpy/resultsdbpy/model/archive_context.py:
227         (ArchiveContext.register): Register each configuration with a branch.
228         * resultsdbpy/resultsdbpy/model/configuration_context.py:
229         (ConfigurationContext.ByPlatform): Index by branch.
230         (ConfigurationContext.ByPlatformAndVersion): Ditto.
231         (ConfigurationContext.ByArchitecture): Ditto.
232         (ConfigurationContext.ByModel): Ditto.
233         (ConfigurationContext.__init__): Populate Redis cache with branch.
234         (ConfigurationContext._convert_to_redis_key): Accept branch in Redis key.
235         (ConfigurationContext._register_in_redis): Register configuration with branch.
236         (ConfigurationContext.register_configuration): Ditto.
237         (ConfigurationContext.search_for_configuration): Search for configuration with branch.
238         (ConfigurationContext.search_for_recent_configuration): Ditto.
239         (ConfigurationContext.select_from_table_with_configurations): Ditto.
240         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
241         (ConfigurationContextTest.register_configurations): Register with branch.
242         (ConfigurationContextTest.test_repopulate_recent): Construct ConfigurationContext with
243         CommitContext object.
244         * resultsdbpy/resultsdbpy/model/upload_context.py:
245         (UploadContext.SuitesByConfiguration): Index by branch.
246         (UploadContext.upload_test_results): Register each configuration with a branch.
247         (UploadContext.find_suites): Pass branch to search for configurations.
248         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Check for new configurations when the branch is changed.
249         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Add branch to suites query.
250
251 2019-09-16  David Kilzer  <ddkilzer@apple.com>
252
253         check-webkit-style: Fix warning message for std::make_unique<typename[]>
254         <https://webkit.org/b/201818>
255
256         Reviewed by Darin Adler.
257
258         * Scripts/webkitpy/style/checkers/cpp.py:
259         (check_wtf_make_unique): Emit different error message when using
260         std::make_unique<>() to create an array.  Personalize the error
261         message by including the original type name, which also
262         demonstrates that WTF::makeUniqueArray<>() does not need square
263         brackets for its typename.
264         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
265         (WebKitStyleTest.test_wtf_make_unique): Add test.
266         (WebKitStyleTest.test_wtf_make_unique_array): Ditto.
267
268 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
269
270         Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
271         https://bugs.webkit.org/show_bug.cgi?id=201820
272
273         Reviewed by Chris Fleizach.
274
275         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
276         (AccessibilityUIElement::insertText):
277         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
278         (AccessibilityUIElement::insertText):
279         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
280         (WTR::AccessibilityUIElement::insertText):
281         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
282         (WTR::AccessibilityUIElement::insertText):
283
284 2019-09-16  David Kilzer  <ddkilzer@apple.com>
285
286         Fix leaks in DumpRenderTree and WebKitTestRunner
287         <https://webkit.org/b/201814>
288
289         Reviewed by Darin Adler.
290
291         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
292         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
293         Add CF_RETURNS_RETAINED to document behavior.
294         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
295         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
296
297         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
298         (takeWindowSnapshot): Add CF_RETURNS_RETAINED to document
299         behavior.
300         (createBitmapContextFromWebView): Fix leak of CGImageRef when
301         generating a replacement image.
302
303         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Add @dynamic
304         declaration for _stableStateOverride so compiler wouldn't try to
305         create another instance variable for it.
306
307         * WebKitTestRunner/mac/EventSenderProxy.mm:
308         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
309         Release `cgEvent` to fix leak.
310
311 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
312
313         Expose misspelling ranges for editable content to accessibility clients.
314         https://bugs.webkit.org/show_bug.cgi?id=201752
315         <rdar://problem/49556828>
316
317         Reviewed by Chris Fleizach.
318
319         Test code needed for LayoutTests/accessibility/misspelling-range.html.
320         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
321         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
322         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
323         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
324         (WTR::AccessibilityUIElement::indexForTextMarker):
325         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
326         (WTR::misspellingSearchParameterizedAttributeForCriteria):
327         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
328
329 2019-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
330
331         REGRESSION(r249142): [GTK] Epiphany delayed page loads continue indefinitely
332         https://bugs.webkit.org/show_bug.cgi?id=201544
333
334         Reviewed by Michael Catanzaro.
335
336         Add new test cases.
337
338         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
339         (testWebViewActiveURI):
340         (testWebViewIsLoading):
341         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
342         (loadChangedCallback):
343         (LoadTrackingTest::loadAlternateHTML):
344         (LoadTrackingTest::reset):
345         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h:
346
347 2019-09-15  David Kilzer  <ddkilzer@apple.com>
348
349         block-spammers should obtain credentials the same way as webkit-patch
350         <https://webkit.org/b/201733>
351
352         Reviewed by Lucas Forschler.
353
354         * Scripts/block-spammers: Import Credentials from webkitpy.
355         Remove unused imports.  Enable logging at info level to match
356         webkit-patch.
357         (get_bugzilla_token): Use Credentials module to get
358         bugs.webkit.org credentials.
359         * Scripts/webkitpy/common/net/credentials.py:
360         (Credentials._run_security_tool): Change logging level from
361         error to info since multiple attempts are made at reading the
362         keychain.  Fix typos in comment.
363         (Credentials._credentials_from_security_command): Extract common
364         logic from Credentials._credentials_from_keychain into new
365         method.
366         (Credentials._credentials_from_keychain): Make fallback logic
367         for checking for credentials in the keychain more consistent and
368         easier to read.  Add error logging if no credentials are found.
369
370 2019-09-13  Youenn Fablet  <youenn@apple.com>
371
372         WPT importer should check META global tag in .any.js files to generate the valid .html stub files
373         https://bugs.webkit.org/show_bug.cgi?id=201718
374
375         Reviewed by Chris Dumez.
376
377         Read meta tag information to select the environments where the any.js template tests will be run.
378         Added support to run service worker tests from any.js template tests.
379
380         Covered by unit test.
381         Since we import only a single repository nowadays, use a test config file with just one repository
382         to simplify the new test.
383
384         * Scripts/webkitpy/w3c/test_importer.py:
385         (TestImporter.__init__):
386         (TestImporter.readEnvironmentsForTemplateTest):
387         (TestImporter.write_html_files_for_templated_js_tests):
388         * Scripts/webkitpy/w3c/test_importer_unittest.py:
389         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
390         (TestImporterTest.test_import_dir_with_no_tests):
391         (TestImporterTest.test_import_dir_with_empty_init_py):
392         (TestImporterTest.test_harnesslinks_conversion):
393         (TestImporterTest.test_submodules_generation):
394         (test_checkout_directory):
395         (test_clean_directory_option):
396         (test_git_ignore_generation):
397         (test_initpy_generation):
398         (test_remove_obsolete_content):
399         (test_manual_slow_test):
400         (test_webkit_test_runner_options):
401         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
402         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
403         (test_template_test):
404
405 2019-09-13  Dean Jackson  <dino@apple.com>
406
407         Provide a prototype for AR QuickLook to trigger processing in the originating page
408         https://bugs.webkit.org/show_bug.cgi?id=201371
409         <rdar://54904781>
410
411         Disable the test for the moment.
412
413         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
414         (TestWebKitAPI::TEST):
415
416 2019-09-11  Dean Jackson  <dino@apple.com>
417
418         Provide a prototype for AR QuickLook to trigger processing in the originating page
419         https://bugs.webkit.org/show_bug.cgi?id=201371
420         <rdar://54904781>
421
422         Reviewed by Simon Fraser.
423
424         * TestWebKitAPI/Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
426         * TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html: Added.
427
428 2019-09-13  Youenn Fablet  <youenn@apple.com>
429
430         Partition processes running service workers by session ID
431         https://bugs.webkit.org/show_bug.cgi?id=201643
432
433         Reviewed by Chris Dumez.
434
435         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
436
437 2019-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
438
439         Re-add myself to the list of committers
440
441         Unreviewed.
442
443         * Scripts/webkitpy/common/config/contributors.json:
444
445 2019-09-13  Alex Christensen  <achristensen@webkit.org>
446
447         [iOS] TestWebKitAPI.WebKit.TLSVersionWebSocket is a flaky failure
448         https://bugs.webkit.org/show_bug.cgi?id=201745
449
450         Reviewed by Chris Dumez.
451
452         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
453         (TestWebKitAPI::TEST):
454         The exact message isn't important.  The fact that the TLS handshake failed is, which is checked by the TCPServer.
455
456 2019-09-13  Patrick Griffis  <pgriffis@igalia.com>
457
458         [JHBuild] Fix building gst-plugins-good against glibc 2.30
459         https://bugs.webkit.org/show_bug.cgi?id=201715
460
461         Reviewed by Xabier Rodriguez-Calvar.
462
463         * gstreamer/patches/gst-plugins-good-glibc-2.30-compat.patch: Added.
464
465 2019-09-12  Chris Dumez  <cdumez@apple.com>
466
467         [WKTR] Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED()
468         https://bugs.webkit.org/show_bug.cgi?id=201546
469
470         Reviewed by Alex Christensen.
471
472         Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED() from WebKitTestRunner as it does not do
473         the right thing for WebKit2 and tests have been rewritten to not use it.
474
475         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
476         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
477         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED): Deleted.
478         * WebKitTestRunner/InjectedBundle/TestRunner.h:
479
480 2019-09-12  Brady Eidson  <beidson@apple.com>
481
482         PDF exporting on iOS should include URL rects.
483         <rdar://problem/54900133> and https://bugs.webkit.org/show_bug.cgi?id=201693
484
485         Reviewed by Tim Horton.
486
487         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
488         (TestWebKitAPI::TEST): Enable on iOS.
489
490 2019-09-12  Adrian Perez de Castro  <aperez@igalia.com>
491
492         [GTK][WPE] webkit_settings_set_user_agent() allows content forbidden in HTTP headers
493         https://bugs.webkit.org/show_bug.cgi?id=201077
494
495         Reviewed by Carlos Garcia Campos.
496
497         * TestWebKitAPI/CMakeLists.txt: Add missing HTTPParsers.cpp to be built into TestWebCore.
498         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
499         (TestWebKitAPI::TEST): Add tests for WebCore::isValidUserAgentHeaderValue().
500
501 2019-09-12  Mark Lam  <mark.lam@apple.com>
502
503         Harden JSC against the abuse of runtime options.
504         https://bugs.webkit.org/show_bug.cgi?id=201597
505         <rdar://problem/55167068>
506
507         Reviewed by Filip Pizlo.
508
509         Linux parts contributed by Carlos Garcia Campos <cgarcia@igalia.com>.
510         Windows parts contributed by Fujii Hironori <Hironori.Fujii@sony.com>.
511
512         Call JSC::Config::configureForTesting() in test harnesses or at the top of tests
513         to disable the hardening on test runs.  Tests rely on setting options to enable
514         test features.
515
516         * DumpRenderTree/mac/DumpRenderTree.mm:
517         (dumpRenderTree):
518         * DumpRenderTree/win/DumpRenderTree.cpp:
519         (initialize):
520         * TestWebKitAPI/PlatformUtilities.cpp:
521         (TestWebKitAPI::Util::createContextWithInjectedBundle):
522         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
523         (main):
524         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
525         (TestWebKitAPI::TEST):
526         (TestWebKitAPI::runActiveSessionTest):
527         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
528         (TEST):
529         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
530         (TEST):
531         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
532         (TestWebKitAPI::TEST):
533         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
534         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
535         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
536         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
537         * WebKitTestRunner/TestController.cpp:
538         (WTR::TestController::generateContextConfiguration const):
539
540 2019-09-12  Keith Rollin  <krollin@apple.com>
541
542         Fix PDFKit references in TestWebKitAPI
543         https://bugs.webkit.org/show_bug.cgi?id=201700
544         <rdar://problem/55279539>
545
546         Reviewed by Youenn Fablet.
547
548         These references fail in watchOS and tvOS, so remove them on those
549         platforms.
550
551         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
553         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
554         * TestWebKitAPI/cocoa/TestPDFDocument.h:
555         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
556         * TestWebKitAPI/config.h:
557
558 2019-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
559
560         [Win][MiniBrowser] Select all text in the URL bar by clicking it
561         https://bugs.webkit.org/show_bug.cgi?id=201677
562
563         Reviewed by Don Olmstead.
564
565         * MiniBrowser/win/MainWindow.cpp:
566         (EditProc): Post EM_SETSEL in WM_SETFOCUS to select all text.
567
568 2019-09-11  Carlos Garcia Campos  <cgarcia@igalia.com>
569
570         [GTK][WPE] Stop using the session bus in the unit tests
571         https://bugs.webkit.org/show_bug.cgi?id=201636
572
573         Reviewed by Žan Doberšek.
574
575         We are actually using GTestDBus, not the actual session bus of the user session, but it would still be better to
576         use a private p2p DBus connection. This is also the way we encourage apps to implement the communication with
577         the web process extension. This patch removes the WebKitTestBus class and starts a DBus server before every
578         test. The server address is passed to the web extension as initialization parameter to connect directly to
579         it. We keep a global list of connections to the server and a HashMap to get the current active connection for
580         a WebKitWebView.
581
582         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
583         (beforeAll):
584         (afterAll):
585         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
586         (testProcessPerWebView):
587         (beforeAll):
588         (afterAll):
589         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
590         (testWebExtensionGetTitle):
591         (testWebExtensionInputElementIsUserEdited):
592         (testDocumentLoadedSignal):
593         (testWebKitWebViewProcessCrashed):
594         (testWebExtensionIsolatedWorld):
595         (testInstallMissingPluginsPermissionRequest):
596         (testWebExtensionFormControlsAssociated):
597         (FormSubmissionTest::FormSubmissionTest):
598         (beforeAll):
599         (afterAll):
600         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
601         (DelayedSignal::DelayedSignal):
602         (emitPageCreated):
603         (pageCreatedCallback):
604         (webkit_web_extension_initialize_with_user_data):
605         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
606         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
607         (AccessibilityTest::AccessibilityTest):
608         (AccessibilityTest::ensureProxy):
609         (beforeAll):
610         (afterAll):
611         * TestWebKitAPI/glib/CMakeLists.txt:
612         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
613         (dbusConnectionClosed):
614         (dbusServerConnection):
615         (startDBusServer):
616         (stopDBusServer):
617         (main):
618         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
619         (Test::initializeWebExtensions):
620         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Removed.
621         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Removed.
622         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
623         (WebViewTest::~WebViewTest):
624         (WebViewTest::extensionProxy):
625         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
626
627 2019-09-10  Dean Jackson  <dino@apple.com>
628
629         setup-git-clone is using http not https
630         https://bugs.webkit.org/show_bug.cgi?id=201658
631
632         Reviewed by Sam Weinig.
633
634         * Scripts/webkitpy/tool/commands/setupgitclone.py:
635         (SetupGitClone.execute):
636
637 2019-09-10  Matt Lewis  <jlewis3@apple.com>
638
639         run-webkit-test: Allow results to be uploaded without scm checkout
640         https://bugs.webkit.org/show_bug.cgi?id=200787
641
642         Reviewed by Jonathan Bedard.
643
644         * Scripts/webkitpy/common/checkout/scm/detection.py:
645         (SCMDetector.detect_scm_system): Added in detection of stub repository.
646         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
647         (StubRepository):
648         (StubRepository.__init__):
649         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
650         find the directory containing the checkout_information.json of the stub repository.
651         (StubRepository.in_working_directory): Required functions to be implemented.
652         (StubRepository.svn_revision): Required functions to be implemented.
653         (StubRepository.native_revision): Required functions to be implemented.
654         (StubRepository.native_branch): Required functions to be implemented.
655         (StubRepository._decode_json): Decodes checkout_information.json.
656         (StubRepository.find_checkout_root): Required functions to be implemented.
657         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
658         (StubRepositoryTest): Unit test for stub_repository SCM.
659         (StubRepositoryTest.mock_host_for_stub_repository):
660         (StubRepositoryTest.test_in_working_directory):
661         (StubRepositoryTest.test_native_revision):
662         (StubRepositoryTest.test_native_branch):
663         (StubRepositoryTest.test_svn_revision):
664         (StubRepositoryTest.test_find_checkout_root):
665         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
666         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
667         * Scripts/webkitpy/port/base.py:
668         (Port.commits_for_upload): Removed unnecessary scm initialization.
669
670 2019-09-10  Brady Eidson  <beidson@apple.com>
671
672         Add SPI to save a PDF from the contents of a WKWebView.
673         <rdar://problem/48955900> and https://bugs.webkit.org/show_bug.cgi?id=195765
674
675         Reviewed by Tim Horton.
676
677         -Add an "Export to PDF..." menu option to MiniBrowser.
678         -Add API tests for the API itself.
679
680         * MiniBrowser/MiniBrowser.entitlements:
681
682         * MiniBrowser/mac/BrowserWindowController.h:
683         * MiniBrowser/mac/BrowserWindowController.m:
684         (-[BrowserWindowController forceRepaint:]):
685         (-[BrowserWindowController saveAsPDF:]):
686
687         * MiniBrowser/mac/MainMenu.xib:
688
689         * MiniBrowser/mac/WK1BrowserWindowController.m:
690         (-[WK1BrowserWindowController validateMenuItem:]):
691         * MiniBrowser/mac/WK2BrowserWindowController.m:
692         (-[WK2BrowserWindowController validateMenuItem:]):
693         (-[WK2BrowserWindowController saveAsPDF:]):
694
695         * TestWebKitAPI/Configurations/Base.xcconfig:
696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
697         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm: Added.
698         (TestWebKitAPI::TEST):
699         * TestWebKitAPI/cocoa/TestPDFDocument.h: Added.
700         * TestWebKitAPI/cocoa/TestPDFDocument.mm: Added.
701         (TestWebKitAPI::toCGRect):
702         (TestWebKitAPI::toPlatformPoint):
703         (TestWebKitAPI::TestPDFAnnotation::TestPDFAnnotation):
704         (TestWebKitAPI::TestPDFAnnotation::isLink const):
705         (TestWebKitAPI::TestPDFAnnotation::bounds const):
706         (TestWebKitAPI::TestPDFAnnotation::linkURL const):
707         (TestWebKitAPI::TestPDFPage::create):
708         (TestWebKitAPI::TestPDFPage::TestPDFPage):
709         (TestWebKitAPI::TestPDFPage::annotations):
710         (TestWebKitAPI::TestPDFPage::characterCount const):
711         (TestWebKitAPI::TestPDFPage::text const):
712         (TestWebKitAPI::TestPDFPage::rectForCharacterAtIndex const):
713         (TestWebKitAPI::TestPDFPage::characterIndexAtPoint const):
714         (TestWebKitAPI::TestPDFPage::bounds const):
715         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
716         (TestWebKitAPI::TestPDFDocument::createFromData):
717         (TestWebKitAPI::TestPDFDocument::TestPDFDocument):
718         (TestWebKitAPI::TestPDFDocument::pageCount const):
719         (TestWebKitAPI::TestPDFDocument::page):
720
721 2019-09-10  Keith Rollin  <krollin@apple.com>
722
723         Remove SSL-based TLSDeprecation.mm contents
724         https://bugs.webkit.org/show_bug.cgi?id=201657
725         <rdar://problem/55237678>
726
727         Reviewed by Alex Christensen.
728
729         This file does not build on watchOS due to references to SSL
730         facilities. Conditionalize out the contents on HAVE_SSL.
731
732         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
733
734 2019-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
735
736         Unreviewed, remove myself from watchlists
737
738         * Scripts/webkitpy/common/config/watchlist:
739
740 2019-09-09  Alex Christensen  <achristensen@webkit.org>
741
742         Rebase API test after r249675
743         https://bugs.webkit.org/show_bug.cgi?id=201596
744
745         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
746         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
747         We removed the restriction on WebsitePolicies with non-default persistent sessions.
748         We needed to change the expectations of the test that exercised that code path.
749
750 2019-09-09  Alex Christensen  <achristensen@webkit.org>
751
752         Fix iOS API tests after r249684
753         https://bugs.webkit.org/show_bug.cgi?id=201573
754
755         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
756         (TestWebKitAPI::getWebSocketEventWebKitLegacy):
757         (TestWebKitAPI::TEST):
758         The web thread still exists :(
759         That makes iOS immediate failure results more like WK2, which is fine.
760         The point is that the connection fails somehow and the server sees a TLS failure, which the test verifies.
761
762 2019-09-09  Chris Dumez  <cdumez@apple.com>
763
764         REGRESSION: http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html is frequently timing out on iOS EWS bots
765         https://bugs.webkit.org/show_bug.cgi?id=201550
766
767         Reviewed by Alex Christensen.
768
769         Update testRunner.statisticsNotifyObserver() to return a boolean indicating if it did
770         anything or not.
771
772         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
773         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
774         (WTR::InjectedBundle::statisticsNotifyObserver):
775         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
776         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
777         (WTR::TestRunner::statisticsNotifyObserver):
778         * WebKitTestRunner/InjectedBundle/TestRunner.h:
779
780 2019-09-09  Timothy Hatcher  <timothy@apple.com>
781
782         Tap and hold on Facebook sometimes creates a tall empty selection.
783         https://bugs.webkit.org/show_bug.cgi?id=201618
784         rdar://53630145
785
786         Reviewed by Megan Gardner.
787
788         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
789         * TestWebKitAPI/Tests/ios/SelectionByWord.mm: Added.
790
791 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
792
793         [EWS] Watchlist doesn't work sometimes
794         https://bugs.webkit.org/show_bug.cgi?id=201433
795
796         Reviewed by Michael Catanzaro.
797
798         * Scripts/webkitpy/common/config/watchlist: Updated the email addresses to the one associated with
799         corresponding Bugzilla accounts.
800
801 2019-09-09  Alex Christensen  <achristensen@webkit.org>
802
803         Disable TLS 1.0 and 1.1 in WebSockets
804         https://bugs.webkit.org/show_bug.cgi?id=201573
805
806         Reviewed by Youenn Fablet.
807
808         * TestWebKitAPI/SourcesCocoa.txt:
809         * TestWebKitAPI/TCPServer.cpp:
810         (sk_CRYPTO_BUFFER_num):
811         (sk_CRYPTO_BUFFER_value):
812         (TestWebKitAPI::deleter<CRYPTO_BUFFER>::operator()):
813         (TestWebKitAPI::TCPServer::TCPServer):
814         (TestWebKitAPI::TCPServer::listenForConnections):
815         (TestWebKitAPI::deleter<X509>::operator()): Deleted.
816         (TestWebKitAPI::deleter<uint8_t::operator()): Deleted.
817         * TestWebKitAPI/TCPServer.h:
818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
819         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: Added.
820         (-[WebSocketDelegate waitForMessage]):
821         (-[WebSocketDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
822         (TestWebKitAPI::TEST):
823         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
824         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
825         (-[TestNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
826         (-[TestNavigationDelegate waitForDidFailProvisionalNavigation]):
827
828 2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
829
830         [Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references
831         https://bugs.webkit.org/show_bug.cgi?id=201600
832
833         Reviewed by Brent Fulgham.
834
835         There were some circular references between
836         WebKitLegacyBrowserWindow and its delegation classes. For
837         example, WebKitLegacyBrowserWindow has a reference of
838         WebDownloadDelegate, and WebDownloadDelegate shares the ref
839         counter with WebKitLegacyBrowserWindow.
840
841         WebNotificationObserver was leaked because it wasn't unregistered
842         from the default notification center by using
843         IWebNotificationCenter::removeObserver.
844
845         If a new legacy window was created by mouse right click a link,
846         WebView was released twice because
847         PrintWebUIDelegate::createWebViewWithRequest didn't AddRef the
848         WebView.
849
850         This change does:
851         1. Make delegation classes have own ref-counter to avoid circular references
852         2. Do removeObserver notification observers
853         3. AddRef WebView in PrintWebUIDelegate::createWebViewWithRequest
854
855         * MiniBrowser/win/AccessibilityDelegate.cpp:
856         (AccessibilityDelegate::AddRef):
857         (AccessibilityDelegate::Release):
858         * MiniBrowser/win/AccessibilityDelegate.h: Added m_refCount.
859         * MiniBrowser/win/MiniBrowserWebHost.cpp:
860         (MiniBrowserWebHost::QueryInterface):
861         (MiniBrowserWebHost::AddRef):
862         (MiniBrowserWebHost::Release):
863         * MiniBrowser/win/MiniBrowserWebHost.h: Added m_refCount.
864         * MiniBrowser/win/PrintWebUIDelegate.cpp:
865         (PrintWebUIDelegate::createWebViewWithRequest): Do AddRef for the returned IWebView.
866         (PrintWebUIDelegate::AddRef):
867         (PrintWebUIDelegate::Release):
868         * MiniBrowser/win/PrintWebUIDelegate.h: Added m_refCount.
869         * MiniBrowser/win/ResourceLoadDelegate.cpp:
870         (ResourceLoadDelegate::AddRef):
871         (ResourceLoadDelegate::Release):
872         * MiniBrowser/win/ResourceLoadDelegate.h: Added m_refCount.
873         * MiniBrowser/win/WebDownloadDelegate.cpp:
874         (WebDownloadDelegate::AddRef):
875         (WebDownloadDelegate::Release):
876         * MiniBrowser/win/WebDownloadDelegate.h: Added m_refCount.
877         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
878         (WebKitLegacyBrowserWindow::~WebKitLegacyBrowserWindow): Do removeObserver notification observers.
879         (WebKitLegacyBrowserWindow::init):
880         (WebKitLegacyBrowserWindow::setUIDelegate):
881         (WebKitLegacyBrowserWindow::setAccessibilityDelegate):
882         (WebKitLegacyBrowserWindow::setResourceLoadDelegate):
883         (WebKitLegacyBrowserWindow::setDownloadDelegate):
884         (WebKitLegacyBrowserWindow::AddRef): Deleted.
885         (WebKitLegacyBrowserWindow::Release): Deleted.
886         (WebKitLegacyBrowserWindow::setFrameLoadDelegate): Deleted.
887         (WebKitLegacyBrowserWindow::setFrameLoadDelegatePrivate): Deleted.
888         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
889
890 2019-09-09  Chris Dumez  <cdumez@apple.com>
891
892         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html
893         https://bugs.webkit.org/show_bug.cgi?id=201596
894
895         Reviewed by Alex Christensen.
896
897         Add new testRunner.setShouldSwapToEphemeralSessionOnNextNavigation() / testRunner.setShouldSwapToDefaultSessionOnNextNavigation()
898         test functions to support dynamic switching between ephemeral and default/persistent session in layout tests. The new methods
899         do the right thing for WebKit2 and truly switch session, unlike setPrivateBrowsingEnabled_DEPRECATED() which was merely making
900         the WebCore::Document think it changed session.
901
902         * DumpRenderTree/TestRunner.cpp:
903         (setShouldSwapToEphemeralSessionOnNextNavigationCallback):
904         (setShouldSwapToDefaultSessionOnNextNavigationCallback):
905         (TestRunner::staticFunctions):
906         (TestRunner::willNavigate):
907         * DumpRenderTree/TestRunner.h:
908         (TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
909         (TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
910         * DumpRenderTree/mac/FrameLoadDelegate.mm:
911         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
912         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
913         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
914         (WTR::TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
915         (WTR::TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
916         * WebKitTestRunner/InjectedBundle/TestRunner.h:
917         * WebKitTestRunner/TestController.cpp:
918         (WTR::TestController::decidePolicyForNavigationAction):
919         * WebKitTestRunner/TestController.h:
920         (WTR::TestController::setShouldSwapToEphemeralSessionOnNextNavigation):
921         (WTR::TestController::setShouldSwapToDefaultSessionOnNextNavigation):
922         * WebKitTestRunner/TestInvocation.cpp:
923         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
924
925 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
926
927         EWS testtube emoji doesn't exist on macOS Mojave
928         https://bugs.webkit.org/show_bug.cgi?id=201532
929
930         Reviewed by Simon Fraser.
931
932         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
933         (StatusBubble): Change the emoji to microscope emoji.
934
935 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
936
937         [EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
938         https://bugs.webkit.org/show_bug.cgi?id=201607
939
940         Reviewed by Jonathan Bedard.
941
942         * BuildSlaveSupport/ews-build/steps.py:
943         (AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
944         (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.
945
946 2019-09-07  Keith Miller  <keith_miller@apple.com>
947
948         OSR entry into wasm misses some contexts
949         https://bugs.webkit.org/show_bug.cgi?id=201569
950
951         Reviewed by Yusuke Suzuki.
952
953         Add new test harness mode for tests created from wast files.
954
955         * Scripts/run-jsc-stress-tests:
956
957 2019-09-09  Daniel Bates  <dabates@apple.com>
958
959         Remove all selection view animations before dumping results
960         https://bugs.webkit.org/show_bug.cgi?id=199241
961
962         Reviewed by Wenson Hsieh.
963
964         On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
965         historical tests that were written for Mac and expect Mac's lack of animations that we run on
966         iOS and are flaky. Let's try to remove all selection view animations before dumping results and
967         see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
968         API for a test to remove selection animations at any time during the run.
969
970         * WebKitTestRunner/ios/TestControllerIOS.mm:
971         (WTR::TestController::notifyDone):
972
973 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
974
975         run-webkit-tests: Report results archive to results.webkit.org
976         https://bugs.webkit.org/show_bug.cgi?id=201321
977
978         Reviewed by Aakash Jain.
979
980         * Scripts/webkitpy/layout_tests/controllers/manager.py:
981         (Manager.run): After all tests are finish, upload the results archive for each
982         configuration.
983         * Scripts/webkitpy/results/upload.py:
984         (Upload):
985         (Upload.__init__): Automatically define timestamp.
986         (Upload.upload_archive): Upload an archive associated with the test run.
987         * Scripts/webkitpy/results/upload_unittest.py:
988         (UploadTest.test_buildbot):
989         (UploadTest):
990         (UploadTest.test_archive_upload):
991
992 2019-09-09  Chris Dumez  <cdumez@apple.com>
993
994         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html
995         https://bugs.webkit.org/show_bug.cgi?id=201590
996
997         Reviewed by Youenn Fablet.
998
999         Add a new API test to check that if the default session registers a service worker, the
1000         hasServiceWorkerRegistration flag is still false in an ephemeral session.
1001
1002         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1003
1004 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
1005
1006         results.webkit.org: mobile-sidebar-control should override button
1007         https://bugs.webkit.org/show_bug.cgi?id=201566
1008
1009         Rubber-stamped by Aakash Jain.
1010
1011         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1012         (@media screen and (min-width: 600px)):
1013         (.mobile-sidebar-control):
1014         (.mobile-sidebar-control.display):
1015
1016 2019-09-07  Chris Dumez  <cdumez@apple.com>
1017
1018         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test
1019         https://bugs.webkit.org/show_bug.cgi?id=201574
1020
1021         Reviewed by Alex Christensen.
1022
1023         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test so that
1024         we truly test private browsing. testRunner.setPrivateBrowsingEnabled_DEPRECATED() is a hack which
1025         does not work well for WK2.
1026
1027         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1028
1029 2019-09-07  Chris Dumez  <cdumez@apple.com>
1030
1031         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test
1032         https://bugs.webkit.org/show_bug.cgi?id=201547
1033
1034         Reviewed by Alex Christensen.
1035
1036         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test so
1037         it can use a true ephemeral session instead of the testRunner.setPrivateBrowsingEnabled_DEPRECATED()
1038         hack.
1039
1040         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1041         (-[LocalStorageNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1042         (-[LocalStorageNavigationDelegate webView:didFinishNavigation:]):
1043         (TEST):
1044
1045 2019-09-07  Alex Christensen  <achristensen@webkit.org>
1046
1047         Remove WebsiteDataStore::legacyDefaultDataStoreConfiguration
1048         https://bugs.webkit.org/show_bug.cgi?id=200054
1049
1050         Reviewed by Carlos Garcia Campos.
1051
1052         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1053         This test relied on the default data store having been instantiated.
1054
1055 2019-09-07  Alex Christensen  <achristensen@webkit.org>
1056
1057         Remove calls to WKContextGetWebsiteDataStore missed in r249614
1058         https://bugs.webkit.org/show_bug.cgi?id=200050
1059
1060         * WebKitTestRunner/TestController.cpp:
1061         (WTR::TestController::resetPreferencesToConsistentValues):
1062         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1063         * WebKitTestRunner/TestInvocation.cpp:
1064         (WTR::TestInvocation::invoke):
1065
1066 2019-09-07  Alex Christensen  <achristensen@webkit.org>
1067
1068         Remove invalid assertion added in r249614
1069         https://bugs.webkit.org/show_bug.cgi?id=200050
1070
1071         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1072         (WTR::TestController::cocoaResetStateToConsistentValues):
1073         Something is instantiating the default data store, which is no problem right now.
1074
1075 2019-09-07  Ryan Haddad  <ryanhaddad@apple.com>
1076
1077         Unreviewed, rolling out r249353.
1078
1079         The test for this change is a flaky failure.
1080
1081         Reverted changeset:
1082
1083         "Add support for postMessage buffering between the service
1084         worker and window"
1085         https://bugs.webkit.org/show_bug.cgi?id=201169
1086         https://trac.webkit.org/changeset/249353
1087
1088 2019-09-07  Alex Christensen  <achristensen@webkit.org>
1089
1090         Deprecate WKContextGetWebsiteDataStore
1091         https://bugs.webkit.org/show_bug.cgi?id=200050
1092
1093         Reviewed by Geoff Garen.
1094
1095         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1096         (WebKitBrowserWindow::updateProxySettings):
1097         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1098         * WebKitTestRunner/TestController.cpp:
1099         (WTR::TestController::generateContextConfiguration const):
1100         (WTR::TestController::websiteDataStore):
1101         (WTR::TestController::generatePageConfiguration):
1102         (WTR::TestController::resetStateToConsistentValues):
1103         (WTR::TestController::platformAdjustContext):
1104         (WTR::TestController::clearServiceWorkerRegistrations):
1105         (WTR::TestController::clearDOMCache):
1106         (WTR::TestController::clearDOMCaches):
1107         (WTR::TestController::ClearIndexedDatabases):
1108         (WTR::TestController::hasDOMCache):
1109         (WTR::TestController::domCacheSize):
1110         (WTR::TestController::setStatisticsDebugMode):
1111         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1112         (WTR::TestController::setStatisticsLastSeen):
1113         (WTR::TestController::setStatisticsPrevalentResource):
1114         (WTR::TestController::setStatisticsVeryPrevalentResource):
1115         (WTR::TestController::dumpResourceLoadStatistics):
1116         (WTR::TestController::isStatisticsPrevalentResource):
1117         (WTR::TestController::isStatisticsVeryPrevalentResource):
1118         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1119         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1120         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1121         (WTR::TestController::setStatisticsHasHadUserInteraction):
1122         (WTR::TestController::isStatisticsHasHadUserInteraction):
1123         (WTR::TestController::setStatisticsGrandfathered):
1124         (WTR::TestController::isStatisticsGrandfathered):
1125         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
1126         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
1127         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
1128         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1129         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1130         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1131         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1132         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1133         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1134         (WTR::TestController::statisticsUpdateCookieBlocking):
1135         (WTR::TestController::statisticsSubmitTelemetry):
1136         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1137         (WTR::TestController::setStatisticsIsRunningTest):
1138         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1139         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1140         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1141         (WTR::TestController::setStatisticsGrandfatheringTime):
1142         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1143         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1144         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1145         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1146         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1147         (WTR::TestController::statisticsDeleteCookiesForHost):
1148         (WTR::TestController::isStatisticsHasLocalStorage):
1149         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1150         (WTR::TestController::statisticsResetToConsistentState):
1151         (WTR::TestController::setWebAuthenticationMockConfiguration):
1152         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1153         * WebKitTestRunner/TestController.h:
1154         * WebKitTestRunner/TestInvocation.cpp:
1155         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1156         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1157         (WTR::initializeWebViewConfiguration):
1158
1159 2019-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1160
1161         Incorrect selection rect revealed after pasting images in a contenteditable element
1162         https://bugs.webkit.org/show_bug.cgi?id=201549
1163         <rdar://problem/50956429>
1164
1165         Reviewed by Simon Fraser.
1166
1167         Add an API test to exercise the scenario where we scroll to reveal the selection after pasting an image that was
1168         directly written to the pasteboard.
1169
1170         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1171
1172 2019-09-06  Matt Lewis  <jlewis3@apple.com>
1173
1174         Unreviewed, rolling out r249582.
1175
1176         This caused results.html fail to be created on internal
1177         testers.
1178
1179         Reverted changeset:
1180
1181         "run-webkit-test: Allow results to be uploaded without scm
1182         checkout"
1183         https://bugs.webkit.org/show_bug.cgi?id=200787
1184         https://trac.webkit.org/changeset/249582
1185
1186 2019-09-06  Aakash Jain  <aakash_jain@apple.com>
1187
1188         [ews-app] Status bubble should only display important messages in pop-over - part 2
1189         https://bugs.webkit.org/show_bug.cgi?id=201557
1190
1191         Reviewed by Jonathan Bedard.
1192
1193         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1194         (StatusBubble): Add few more strings to STEPS_TO_HIDE.
1195
1196 2019-09-06  Alex Christensen  <achristensen@webkit.org>
1197
1198         Deprecate all WKCookieManagerRef functions
1199         https://bugs.webkit.org/show_bug.cgi?id=201473
1200
1201         Reviewed by Chris Dumez.
1202
1203         Adopt replacement C API in WebKitTestRunner.
1204
1205         * TestWebKitAPI/CMakeLists.txt:
1206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1207         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp: Removed, because the functions it tests were removed.
1208         * WebKitTestRunner/TestController.cpp:
1209         (WTR::TestController::resetPreferencesToConsistentValues):
1210         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1211         * WebKitTestRunner/TestInvocation.cpp:
1212         (WTR::TestInvocation::invoke):
1213         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1214         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1215         (WTR::initializeWebViewConfiguration):
1216
1217 2019-09-06  Tim Horton  <timothy_horton@apple.com>
1218
1219         Marking up a note on iOS results in a PDF with no contents
1220         https://bugs.webkit.org/show_bug.cgi?id=201530
1221         <rdar://problem/53686019>
1222
1223         Reviewed by Andy Estes.
1224
1225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1226         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm:
1227         Add some tests for WKWebViewPrintFormatter; specifically that it is
1228         possible to _recalcPageCount twice in quick succession, and that
1229         we don't hang if we start painting the printed content immediately
1230         after a Web Content process crash.
1231
1232 2019-09-06  Matt Lewis  <jlewis3@apple.com>
1233
1234         run-webkit-test: Allow results to be uploaded without scm checkout
1235         https://bugs.webkit.org/show_bug.cgi?id=200787
1236
1237         Reviewed by Jonathan Bedard.
1238
1239         * Scripts/webkitpy/common/checkout/scm/detection.py:
1240         (SCMDetector.detect_scm_system): Added in detection of stub repository.
1241         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
1242         (StubRepository):
1243         (StubRepository.__init__):
1244         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
1245         find the directory containing the checkout_information.json of the stub repository.
1246         (StubRepository.in_working_directory): Required functions to be implemented.
1247         (StubRepository.svn_revision): Required functions to be implemented.
1248         (StubRepository.native_revision): Required functions to be implemented.
1249         (StubRepository.native_branch): Required functions to be implemented.
1250         (StubRepository._decode_json): Decodes checkout_information.json.
1251         (StubRepository.find_checkout_root): Required functions to be implemented.
1252         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
1253         (StubRepositoryTest): Unit test for stub_repository SCM.
1254         (StubRepositoryTest.mock_host_for_stub_repository):
1255         (StubRepositoryTest.test_in_working_directory):
1256         (StubRepositoryTest.test_native_revision):
1257         (StubRepositoryTest.test_native_branch):
1258         (StubRepositoryTest.test_svn_revision):
1259         (StubRepositoryTest.test_find_checkout_root):
1260         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1261         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
1262         * Scripts/webkitpy/port/base.py:
1263         (Port.commits_for_upload): Removed unnecessary scm initialization.
1264
1265 2019-09-06  Alex Christensen  <achristensen@webkit.org>
1266
1267         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
1268         https://bugs.webkit.org/show_bug.cgi?id=201480
1269
1270         Reviewed by Youenn Fablet.
1271
1272         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1273         (WTR::InjectedBundle::beginTesting):
1274         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1275         (WTR::TestRunner::setPrivateBrowsingEnabled):
1276
1277 2019-09-06  Rob Buis  <rbuis@igalia.com>
1278
1279         Add runtime flag for lazy image loading
1280         https://bugs.webkit.org/show_bug.cgi?id=199794
1281
1282         Reviewed by Frédéric Wang.
1283
1284         Remove parts of r248409 that were meant for WK1 since
1285         lazy image loading is WK2 only.
1286
1287         * DumpRenderTree/TestOptions.cpp:
1288         (TestOptions::TestOptions):
1289         * DumpRenderTree/TestOptions.h:
1290         * DumpRenderTree/mac/DumpRenderTree.mm:
1291         (enableExperimentalFeatures):
1292         (setWebPreferencesForTestOptions):
1293         * DumpRenderTree/win/DumpRenderTree.cpp:
1294         (enableExperimentalFeatures):
1295
1296 2019-09-05  Chris Dumez  <cdumez@apple.com>
1297
1298         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
1299         https://bugs.webkit.org/show_bug.cgi?id=201519
1300
1301         Reviewed by Alex Christensen.
1302
1303         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
1304         as it does not truly enable private browsing for WebKit2. Instead, have WKTR / DRT set the
1305         TestOption::useEphemeralSession flag based on the test folder.
1306
1307         * DumpRenderTree/mac/DumpRenderTree.mm:
1308         (shouldUseEphemeralSession):
1309         (runTest):
1310         * WebKitTestRunner/TestOptions.cpp:
1311         (WTR::shouldUseEphemeralSession):
1312         (WTR::TestOptions::TestOptions):
1313
1314 2019-09-05  Fujii Hironori  <Hironori.Fujii@sony.com>
1315
1316         [Win] Support Per-Monitor (V2) DPI Awareness
1317         https://bugs.webkit.org/show_bug.cgi?id=201450
1318
1319         Reviewed by Don Olmstead.
1320
1321         * MiniBrowser/win/MainWindow.cpp:
1322         (MainWindow::WndProc): Set the window position suggested by WM_DPICHANGED.
1323         * MiniBrowser/win/WinMain.cpp:
1324         (wWinMain): Call SetProcessDpiAwarenessContext by using soft linking.
1325
1326 2019-09-05  Chris Dumez  <cdumez@apple.com>
1327
1328         REGRESSION: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html are flaky timeouts
1329         https://bugs.webkit.org/show_bug.cgi?id=201440
1330         <rdar://problem/54998427>
1331
1332         Reviewed by Alex Christensen.
1333
1334         Since r249350, it is now possible for a WebContent process to have a suspended WebPage for the current web view.
1335         This was confusing InjectedBundle::page() in WebKitTestRunner which was assuming that the WebPage that was first
1336         created in the WebContent process is the one that is currently running the test and that we want to talk to.
1337         Update InjectedBundle::page() to ignore suspended WebPages in order to address the issue.
1338
1339         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1340         (WTR::InjectedBundle::page const):
1341
1342 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
1343
1344         results.webkit.org: Assign notifyRerender before calling
1345         https://bugs.webkit.org/show_bug.cgi?id=201510
1346
1347         Reviewed by Aakash Jain.
1348
1349         Timelines should define notifyRerender to an empty function,
1350         rename notifiyRerender to notifyRerender.
1351
1352         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1353         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1354         * resultsdbpy/resultsdbpy/view/templates/search.html:
1355         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1356
1357 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
1358
1359         results.webkit.org: Fix prepending search result on empty list 
1360         https://bugs.webkit.org/show_bug.cgi?id=201512
1361
1362         Reviewed by Aakash Jain.
1363
1364         * resultsdbpy/resultsdbpy/view/templates/search.html:
1365
1366 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
1367
1368         results.webkit.org: Retain certain parameters when following menu links
1369         https://bugs.webkit.org/show_bug.cgi?id=201463
1370
1371         Rubber-stamped by Aakash Jain.
1372
1373         * resultsdbpy/resultsdbpy/view/site_menu.py:
1374         (SiteMenu.add_endpoint): Allow added endpoints to define parameters to be retained.
1375         * resultsdbpy/resultsdbpy/view/templates/base.html: When clicking on a site-menu link,
1376         retain the specified parameters
1377         * resultsdbpy/resultsdbpy/view/view_routes.py:
1378         (ViewRoutes.__init__):
1379
1380 2019-09-05  Chris Dumez  <cdumez@apple.com>
1381
1382         [WK2] Add proper layout test support for ephemeral sessions
1383         https://bugs.webkit.org/show_bug.cgi?id=201475
1384
1385         Reviewed by Antti Koivisto.
1386
1387         Add proper layout test support for ephemeral sessions via:
1388         <!-- webkit-test-runner [ useEphemeralSession=true ] -->
1389
1390         This actually creates a new WebView using an ephemeral data store to load the test which
1391         is *true* private browsing.
1392
1393         testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent
1394         process, which is a hack and does not truly enable private browsing because the UIProcess and
1395         the NetworkProcess are not properly updated on WK2. This patch renames testRunner.setPrivateBrowsingEnabled()
1396         to testRunner.setPrivateBrowsingEnabled_DEPRECATED() to discourage its use since I am try to
1397         get rid of it.
1398
1399         Note that WK2 does not support using a WebContent process for different sessions / data stores.
1400         Each WebContent process has a single associated data store and testRunner.setPrivateBrowsingEnabled()
1401         is currently the only exception to that. This leads to additional complexity in our code base (e.g. in ITP),
1402         simply to support testRunner.setPrivateBrowsingEnabled().
1403
1404         * DumpRenderTree/TestOptions.cpp:
1405         (TestOptions::TestOptions):
1406         * DumpRenderTree/TestOptions.h:
1407         * DumpRenderTree/TestRunner.cpp:
1408         (TestRunner::staticFunctions):
1409         * DumpRenderTree/mac/DumpRenderTree.mm:
1410         (setWebPreferencesForTestOptions):
1411         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1412         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1413         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED):
1414         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1415         * WebKitTestRunner/TestController.cpp:
1416         (WTR::TestController::generatePageConfiguration):
1417         (WTR::updateTestOptionsFromTestHeader):
1418         * WebKitTestRunner/TestOptions.h:
1419         (WTR::TestOptions::hasSameInitializationOptions const):
1420         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1421         (WTR::TestController::platformCreateWebView):
1422
1423 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
1424
1425         REGRESSION (iOS 13): Bulleted list copied from Notes to Mail results in Times New Roman
1426         https://bugs.webkit.org/show_bug.cgi?id=201490
1427
1428         Reviewed by Daniel Bates.
1429
1430         Added a test.
1431
1432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1433         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1434         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-lists.html: Added.
1435
1436 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
1437
1438         Remove unused SPI that accesses MemoryCache directly
1439         https://bugs.webkit.org/show_bug.cgi?id=201468
1440
1441         Reviewed by Youenn Fablet.
1442
1443         Removed the API test.
1444
1445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1446         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Removed.
1447
1448 2019-09-04  Timothy Hatcher  <timothy@apple.com>
1449
1450         Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
1451         https://bugs.webkit.org/show_bug.cgi?id=201368
1452         rdar://problem/40529867
1453
1454         Reviewed by Ryosuke Niwa.
1455
1456         Added Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
1457             PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent
1458
1459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1460         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1461         (createWebViewWithCustomPasteboardDataSetting): Added argument to enable color filter.
1462         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
1463         (createWebViewWithCustomPasteboardDataEnabled): Added argument to enable color filter.
1464         * TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html: Added.
1465         * TestWebKitAPI/cocoa/TestWKWebView.h:
1466         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1467         (-[TestWKWebView forceDarkMode]):
1468
1469 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1470
1471         MobileSafari may crash when invoking the C++ lambda in -[WKContentView _shareForWebView:]
1472         https://bugs.webkit.org/show_bug.cgi?id=201479
1473         <rdar://problem/51511834>
1474
1475         Reviewed by Tim Horton.
1476
1477         Add a test to verify that the UI process doesn't crash when invoking `_share:` while there's no selection.
1478
1479         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1480         * TestWebKitAPI/ios/UIKitSPI.h:
1481
1482 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1483
1484         -[WKContentView selectedText] returns an empty string when selecting more than 200 characters
1485         https://bugs.webkit.org/show_bug.cgi?id=201471
1486         <rdar://problem/55039227>
1487
1488         Reviewed by Tim Horton.
1489
1490         Add an API test to ensure that -selectedText is non-empty in the case where more than 200 characters are
1491         selected.
1492
1493         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1494         (TestWebKitAPI::TEST):
1495         * TestWebKitAPI/ios/UIKitSPI.h:
1496
1497 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
1498
1499         results.webkit.org: Fix mobile vs desktop mode
1500         https://bugs.webkit.org/show_bug.cgi?id=201441
1501
1502         Rubber-stamped by Aakash Jain.
1503
1504         We should unconditionally use desktop mode if the device screen-width
1505         is large enough.
1506
1507         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1508
1509 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
1510
1511         run-api-tests: Add support for specifying additional environment variables
1512         https://bugs.webkit.org/show_bug.cgi?id=201311
1513         <rdar://problem/54852698>
1514
1515         Reviewed by Daniel Bates.
1516
1517         * Scripts/webkitpy/api_tests/run_api_tests.py:
1518         (parse_args): Add --additional-env-var flag.
1519         * Scripts/webkitpy/port/base.py:
1520         (Port._append_value_colon_separated): Use os.pathsep instead of ':'.
1521         (Port.environment_for_api_tests): Add the values from --additional-env-var to the
1522         environment.
1523
1524 2019-09-04  Aakash Jain  <aakash_jain@apple.com>
1525
1526         EWS bubbles should indicate builder vs tester
1527         https://bugs.webkit.org/show_bug.cgi?id=201253
1528
1529         Reviewed by Jonathan Bedard.
1530
1531         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1532         (StatusBubble._build_bubble): Add icons to the bubbles appropriately.
1533         (StatusBubble._is_tester_queue): Method to determine if the queue is tester queue.
1534         (StatusBubble._is_builder_queue): Method to determine if the queue is builder queue.
1535         (StatusBubble.get):
1536         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1537         (Buildbot.fetch_config): Method to fetch the config from Buildbot server.
1538         (Buildbot.update_icons_for_queues_mapping): Method to update the icons for queues mapping.
1539         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1540         (FetchLoop.run): Update the icons for queues mapping.
1541         * BuildSlaveSupport/ews-build/config.json: Add icon information for the queues.
1542         * BuildSlaveSupport/ews-build/loadConfig.py: Remove 'icon' key from builder before passing it to Buildbot.
1543         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: .
1544         (test_builder_keys): Update unit-test accordingly. Also minor drive-by fix to improve failure string formatting.
1545
1546 2019-09-03  Yusuke Suzuki  <ysuzuki@apple.com>
1547
1548         [bmalloc] IsoTLSLayout and AllIsoHeaps registration is racy with derived class initialization with virtual functions
1549         https://bugs.webkit.org/show_bug.cgi?id=201448
1550
1551         Reviewed by Mark Lam.
1552
1553         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1554         (TEST):
1555
1556 2019-09-03  Dean Jackson  <dino@apple.com>
1557
1558         Test for ContextMenus with images
1559         https://bugs.webkit.org/show_bug.cgi?id=201437
1560
1561         Reviewed by Wenson Hsieh.
1562
1563         Add a test for ContextMenus that trigger on images, and make
1564         sure that they ask for alternate URLs (added in r249171).
1565
1566         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1567         (contextMenuWebViewDriver):
1568         (-[TestContextMenuImageUIDelegate _webView:contextMenuConfigurationForElement:completionHandler:]):
1569         (-[TestContextMenuImageUIDelegate _webView:alternateURLFromImage:userInfo:]):
1570         (-[TestContextMenuImageUIDelegate webView:contextMenuWillPresentForElement:]):
1571         (-[TestContextMenuImageUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1572         (-[TestContextMenuImageUIDelegate webView:contextMenuDidEndForElement:]):
1573         (TEST):
1574
1575 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
1576
1577         results.webkit.org: Move legend into sidebar
1578         https://bugs.webkit.org/show_bug.cgi?id=201258
1579
1580         Rubber-stamped by Aakash Jain.
1581
1582         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: 
1583         (Legend): Make the legend vertical instead of horizontal, add ToolTip to dots in the legend.
1584         * resultsdbpy/resultsdbpy/view/static/js/tooltip.css: Add left and right tooltip arrows.
1585         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
1586         (isPointInElement): Make bound check include borders.
1587         (_ToolTip.toString): Add left/right cases.
1588         (_ToolTip.prototype.setByElement): Set the tooltip location given an element.
1589         * resultsdbpy/resultsdbpy/view/templates/search.html: Put the legend into the sidebar.
1590         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1591
1592 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
1593
1594         results.webkit.org: Increase default limit for LimitSlider
1595         https://bugs.webkit.org/show_bug.cgi?id=201424
1596
1597         Reviewed by Aakash Jain.
1598
1599         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
1600         (LimitSlider): Increase the default limit, make limit slider linear instead of logarithmic.
1601
1602 2019-09-03  Antoine Quint  <graouts@apple.com>
1603
1604         [iOS] Treat a two-finger single tap as if the user tapped with the Cmd key pressed
1605         https://bugs.webkit.org/show_bug.cgi?id=201420
1606         <rdar://problem/53207786>
1607
1608         Reviewed by Simon Fraser.
1609
1610         Add a new twoFingerSingleTapAtPoint() method to UIScriptController, which just calls into the existing (but unused)
1611         -[HIDEventGenerator twoFingerTap:completionBlock:].
1612
1613         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1614         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1615         (WTR::UIScriptController::twoFingerSingleTapAtPoint):
1616         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
1617         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1618         (WTR::UIScriptControllerIOS::twoFingerSingleTapAtPoint):
1619
1620 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
1621
1622         [WPE] MiniBrowser should handle the WebKitWebView::create signal
1623         https://bugs.webkit.org/show_bug.cgi?id=201417
1624
1625         Reviewed by Carlos Garcia Campos.
1626
1627         WPE's MiniBrowser should connect to and handle the
1628         WebKitWebView::create signal, constructing a new bit related
1629         WebKitWebView object upon invocation.
1630
1631         * MiniBrowser/wpe/main.cpp:
1632         (webViewClose):
1633         (createWebView):
1634         (main):
1635
1636 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
1637
1638         [WPE] Make view backends multi-view-friendly
1639         https://bugs.webkit.org/show_bug.cgi?id=201415
1640
1641         Reviewed by Carlos Garcia Campos.
1642
1643         Have the Wayland EGL connection for WindowViewBackend instances managed
1644         through a per-process singleton, allowing multiple backend objects
1645         use it for different views. HeadlessViewBackend already does this, but
1646         the code there is refurbished into a singleton structure.
1647
1648         The ViewBackend classes are adjusted to work with the backend-specific
1649         EGLDisplay objects (as constructed through the backend-specific EGL
1650         connection approach).
1651
1652         * wpe/backends/HeadlessViewBackend.cpp:
1653         (WPEToolingBackends::HeadlessEGLConnection::singleton):
1654         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1655         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
1656         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1657         (WPEToolingBackends::getEGLDisplay): Deleted.
1658         * wpe/backends/ViewBackend.cpp:
1659         (WPEToolingBackends::ViewBackend::initialize):
1660         (WPEToolingBackends::ViewBackend::deinitialize):
1661         (WPEToolingBackends::ViewBackend::~ViewBackend): Deleted.
1662         * wpe/backends/ViewBackend.h:
1663         * wpe/backends/WindowViewBackend.cpp:
1664         (WPEToolingBackends::WaylandEGLConnection::singleton):
1665         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1666         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
1667         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1668
1669 2019-09-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1670
1671         [WPE][GTK] Deprecate nonfunctional process limit APIs
1672         https://bugs.webkit.org/show_bug.cgi?id=193749
1673
1674         Reviewed by Žan Doberšek.
1675
1676         * MiniBrowser/gtk/main.c:
1677         (main):
1678         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1679         (beforeAll):
1680         (testWebProcessLimit): Deleted.
1681
1682 2019-09-02  Zan Dobersek  <zdobersek@igalia.com>
1683
1684         [WPE] WindowBackend should do resizing properly
1685         https://bugs.webkit.org/show_bug.cgi?id=201386
1686
1687         Reviewed by Carlos Garcia Campos.
1688
1689         The WindowBackend implementation is resized via the XDG protocol. The
1690         initial size is stored for the object's lifetime and fallen back to when
1691         the XDG protocol reports (0,0) configuration size.
1692
1693         Upon each resize, we have to recreate the texture. We also have to size
1694         the GL viewport accordingly.
1695
1696         * wpe/backends/WindowViewBackend.cpp:
1697         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1698         (WPEToolingBackends::WindowViewBackend::createViewTexture):
1699         (WPEToolingBackends::WindowViewBackend::resize):
1700         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1701         * wpe/backends/WindowViewBackend.h:
1702
1703 2019-09-01  Fujii Hironori  <Hironori.Fujii@sony.com>
1704
1705         Unreviewed, rolling out r249366.
1706
1707         WinCairo WebKit2 crashes in some websites and the device scale
1708         factor is not correct in high DPI.
1709
1710         Reverted changeset:
1711
1712         "[WinCairo, FTW] Properly handle device scale factor"
1713         https://bugs.webkit.org/show_bug.cgi?id=201361
1714         https://trac.webkit.org/changeset/249366
1715
1716 2019-09-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1717
1718         Long presses that interrupt accelerated scrolling dispatch clicks on apps linked against iOS 12 or earlier
1719         https://bugs.webkit.org/show_bug.cgi?id=201346
1720         <rdar://problem/54885784>
1721
1722         Reviewed by Dean Jackson.
1723
1724         Add a new test option to allow tests to disable link previews.
1725
1726         * WebKitTestRunner/TestController.cpp:
1727         (WTR::updateTestOptionsFromTestHeader):
1728         * WebKitTestRunner/TestOptions.h:
1729
1730         Drive-by fix: also check enableLazyImageLoading when determining whether two TestOptions are the same.
1731
1732         (WTR::TestOptions::hasSameInitializationOptions const):
1733         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1734         (WTR::TestController::platformCreateWebView):
1735
1736 2019-08-30  Brent Fulgham  <bfulgham@apple.com>
1737
1738         [WinCairo, FTW] Properly handle device scale factor
1739         https://bugs.webkit.org/show_bug.cgi?id=201361
1740
1741         Reviewed by Don Olmstead.
1742
1743         Reset zoom to 1.0; device scale is handled elsewhere.
1744
1745         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1746         (WebKitBrowserWindow::resetZoom):
1747
1748 2019-08-30  Zhifei Fang  <zhifei_fang@apple.com>
1749
1750         [results.webkit.org Timeline] Add notify rerender API for timeline
1751         https://bugs.webkit.org/show_bug.cgi?id=201363
1752
1753         Reviewed by Jonathan Bedard.
1754
1755         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Export notifyRerender API to timeline class
1756         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1757         (XScrollableCanvasProvider): Add an event stream to receive notification that it will need to render 
1758         (prototype.ExpandableSeriesComponent): Notify the rerender when expanded, because this may change the layout.
1759         (prototype.Timeline.CanvasContainer):
1760
1761 2019-08-30  Aakash Jain  <aakash_jain@apple.com>
1762
1763         [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
1764         https://bugs.webkit.org/show_bug.cgi?id=201350
1765
1766         Reviewed by Jonathan Bedard.
1767
1768         * BuildSlaveSupport/ews-build/steps.py:
1769         (RunWebKit1Tests.start): Set build property to use dump-render-tree.
1770         (RunWebKitTests.start): Use dump-render-tree whenever the corresponding build property is set.
1771
1772 2019-08-30  Jonathan Bedard  <jbedard@apple.com>
1773
1774         results.webkit.org: Add endpoints to upload and download archives
1775         https://bugs.webkit.org/show_bug.cgi?id=201100
1776
1777         Reviewed by Aakash Jain.
1778
1779         Add the endpoint to upload and download a zip archive associated with a test run.
1780
1781         * resultsdbpy/resultsdbpy/controller/api_routes.py:
1782         (APIRoutes.__init__): Add archive endpoint.
1783         * resultsdbpy/resultsdbpy/controller/archive_controller.py: Added.
1784         (ArchiveController):
1785         (ArchiveController.__init__):
1786         (ArchiveController.endpoint):
1787         (ArchiveController.download):
1788         (ArchiveController.upload):
1789         * resultsdbpy/resultsdbpy/controller/archive_controller_unittest.py: Added.
1790         (ArchiveControllerUnittest):
1791         * resultsdbpy/resultsdbpy/model/configuration_context.py:
1792         (ClusteredByConfiguration.register_configuration): Make error message more clear.
1793
1794 2019-08-30  Simon Fraser  <simon.fraser@apple.com>
1795
1796         Add system tracing points for compositing updates, and touch-event dispatching
1797         https://bugs.webkit.org/show_bug.cgi?id=201327
1798
1799         Reviewed by Alex Christensen.
1800
1801         * Tracing/SystemTracePoints.plist:
1802
1803 2019-08-30  Keith Rollin  <krollin@apple.com>
1804
1805         Simplify PLATFORM expression
1806         https://bugs.webkit.org/show_bug.cgi?id=201286
1807         <rdar://problem/54822347>
1808
1809         Reviewed by Alexey Proskuryakov.
1810
1811         The preprocessor expression conditionalizing the inclusion of the body
1812         of ExitFullscreenOnEnterPiP.mm evolved into:
1813
1814             #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR))
1815
1816         Simplify this to just:
1817
1818             #if !PLATFORM(IOS_FAMILY_SIMULATOR)
1819
1820         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1821
1822 2019-08-30  Keith Rollin  <krollin@apple.com>
1823
1824         Remove AppKitCompatibilityDeclarations.h
1825         https://bugs.webkit.org/show_bug.cgi?id=201283
1826         <rdar://problem/54822042>
1827
1828         Reviewed by Alexey Proskuryakov.
1829
1830         The two copies of these files -- on in WTF, one in MiniBrowser -- are
1831         empty and can be removed.
1832
1833         * DumpRenderTree/mac/EventSendingController.mm:
1834         * DumpRenderTree/mac/TextInputControllerMac.m:
1835         * MiniBrowser/AppKitCompatibilityDeclarations.h: Removed.
1836         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1837         * MiniBrowser/mac/SettingsController.m:
1838         * MiniBrowser/mac/WK1BrowserWindowController.m:
1839         * MiniBrowser/mac/WK2BrowserWindowController.m:
1840         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
1841         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1842         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1843         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1844         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
1845         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
1846         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1847         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1848         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1849         * TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
1850         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1851         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1852         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
1853         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1854         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
1855         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1856         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1857         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1858         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1859         * WebKitTestRunner/mac/EventSenderProxy.mm:
1860         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1861         * WebKitTestRunner/mac/TestControllerMac.mm:
1862
1863 2019-08-30  Adrian Perez de Castro  <aperez@igalia.com>
1864
1865         [WPE][GTK] New API to remove a filter from an user content manager given its identifier
1866         https://bugs.webkit.org/show_bug.cgi?id=200479
1867
1868         Reviewed by Carlos Garcia Campos.
1869
1870         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1871         (testUserContentManagerContentFilter): Test also the new
1872         webkit_user_content_manager_remove_filter_by_id() public API function.
1873
1874 2019-08-30  Philippe Normand  <pnormand@igalia.com>
1875
1876         [WPE][Qt] loadingChanged signal parameter is unusable
1877         https://bugs.webkit.org/show_bug.cgi?id=201301
1878
1879         Reviewed by Carlos Garcia Campos.
1880
1881         * MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
1882         * Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for
1883         readablity/parameter_name code styl checker rule.
1884
1885 2019-08-29  Keith Rollin  <krollin@apple.com>
1886
1887         Update .xcconfig symbols to reflect the current set of past and future product versions.
1888         https://bugs.webkit.org/show_bug.cgi?id=200720
1889         <rdar://problem/54305032>
1890
1891         Reviewed by Alex Christensen.
1892
1893         Remove version symbols related to old OS's we no longer support,
1894         ensure that version symbols are defined for OS's we do support.
1895
1896         * ContentExtensionTester/Configurations/Base.xcconfig:
1897         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1898         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1899         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1900         * ImageDiff/cg/Configurations/Base.xcconfig:
1901         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1902         * MiniBrowser/Configurations/Base.xcconfig:
1903         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1904         * TestWebKitAPI/Configurations/Base.xcconfig:
1905         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1906         * WebEditingTester/Configurations/Base.xcconfig:
1907         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1908         * WebKitTestRunner/Configurations/Base.xcconfig:
1909         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1910         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1911         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
1912
1913 2019-08-29  Keith Rollin  <krollin@apple.com>
1914
1915         Remove empty FontCache.cpp file in TestWebKitAPI
1916         https://bugs.webkit.org/show_bug.cgi?id=201277
1917         <rdar://problem/54820726>
1918
1919         Reviewed by Alex Christensen.
1920
1921         Bug 200694 emptied out the contents of FontCache.cpp. This patch
1922         removes the file from the project.
1923
1924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1925         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
1926
1927 2019-08-29  Aakash Jain  <aakash_jain@apple.com>
1928
1929         [ews-app] Status bubble should only display important messages in pop-over
1930         https://bugs.webkit.org/show_bug.cgi?id=201308
1931
1932         Reviewed by Jonathan Bedard.
1933
1934         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added various build-steps which are of low interest
1935         to end-users in STEPS_TO_HIDE. If any of these steps fail, it will not be hidden.
1936
1937 2019-08-29  Keith Rollin  <krollin@apple.com>
1938
1939         Remove support for macOS < 10.13 (part 3)
1940         https://bugs.webkit.org/show_bug.cgi?id=201224
1941         <rdar://problem/54795934>
1942
1943         Reviewed by Darin Adler.
1944
1945         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
1946         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
1947         like _MACOS_SINCE_1013.
1948
1949         Also added some macOS target numbers.
1950
1951         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
1952
1953 2019-08-29  Jonathan Bedard  <jbedard@apple.com>
1954
1955         results.webkit.org: Remove border from tooltip
1956         https://bugs.webkit.org/show_bug.cgi?id=201239
1957
1958         Reviewed by Alex Christensen.
1959
1960         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
1961         (.tooltip-content): Remove border.
1962
1963 2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1964
1965         [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
1966         https://bugs.webkit.org/show_bug.cgi?id=201215
1967
1968         Reviewed by Don Olmstead.
1969
1970         MiniBrowser crashed if it was going to go to a unreachable page
1971         because WKPageCopyActiveURL returned a nullptr.
1972
1973         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1974         (createString): Added null checking of the argument.
1975
1976 2019-08-28  Tim Horton  <timothy_horton@apple.com>
1977
1978         Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
1979         https://bugs.webkit.org/show_bug.cgi?id=201256
1980         <rdar://problem/54809509>
1981
1982         Reviewed by Simon Fraser.
1983
1984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1985         * TestWebKitAPI/Tests/WebKit/long-email-viewport.html: Added.
1986         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm: Added.
1987         (TestWebKitAPI::TEST):
1988         Add a test. I left many comments because I had a great deal of trouble
1989         writing this test and wanted to document my findings.
1990
1991 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
1992
1993         results.webkit.org: Do not display branch selector if only one branches available
1994         https://bugs.webkit.org/show_bug.cgi?id=201244
1995
1996         Rubber-stamped by Aakash Jain.
1997
1998         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Hide the branch selector's
1999         container if there aren't multiple branches to choose from.
2000
2001 2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2002
2003         WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
2004         https://bugs.webkit.org/show_bug.cgi?id=201241
2005         <rdar://problem/54317588>
2006
2007         Reviewed by Tim Horton.
2008
2009         For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
2010         communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
2011         the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
2012         -dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
2013         it believes that the web view has rejected the drop from being handled.
2014
2015         Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
2016         to make sure that the web process has had time to send a response after each update.
2017
2018         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2019         (-[DragAndDropSimulator _advanceProgress]):
2020
2021 2019-08-28  Megan Gardner  <megan_gardner@apple.com>
2022
2023         Null check webFrame when creating a print preview to prevent a crash.
2024         https://bugs.webkit.org/show_bug.cgi?id=201237
2025         <rdar://problem/51618863>
2026
2027         Reviewed by Tim Horton.
2028
2029         Test to verify that if we don't have the WebPageProxy, we will not crash when making a print preview.
2030
2031         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2032         (TEST):
2033
2034 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
2035
2036         results.webkit.org: Move drawer to the right, open by default
2037         https://bugs.webkit.org/show_bug.cgi?id=200977
2038
2039         Rubber-stamped by Aakash Jain.
2040
2041         The drawer was both unpopular and not discoverable. After feedback from bot watchers,
2042         moving the drawer to the right side of the screen, opening it by default and have it displace
2043         instead of hide the main content.
2044
2045         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py:
2046         (CommitViewUnittest.test_drawer): Support new drawer style.
2047         (CommitViewUnittest.test_range_slider): Ditto.
2048         (CommitViewUnittest.test_one_line_switch): Ditto.
2049         (CommitViewUnittest.test_branch_selection): Ditto.
2050         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Removed.
2051         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2052         (setEnableRecursive): Disable all elements underneath this one 
2053         (Drawer): Make drawer a sidebar.
2054         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2055         (.header>.title, .topbar>.title): Overflow of titles should be hidden.
2056         (:root): Move boldInverseColor into webkit.css.
2057         (@media (prefers-color-scheme: dark)):
2058         (.sidebar): Sidebars on mobile should behave like drawers.
2059         (.sidebar.hidden): Add concept of hidden sidebar.
2060         (.mobile-sidebar-control): Add a control to collapse sidebar that only exists on mobile.
2061         (.mobile-sidebar-control.display):
2062         (.main.under-topbar-with-actions):
2063         (@media screen and (min-width: 600px) and (orientation: landscape)):
2064         (.sidebar.left.hidden):
2065         (.sidebar.right.hidden):
2066         (.main.right.hidden):
2067         (.main.left.hidden):
2068         (@media screen and (min-width: 768px) and (orientation: landscape)):
2069         (.sidebar.right):
2070         (a.disabled): Add ability to disable a link.
2071         (.desktop-control): Add a control which only exists on desktop.
2072         * resultsdbpy/resultsdbpy/view/templates/base.html: Add hamburger drawer-button for mobile.
2073         * resultsdbpy/resultsdbpy/view/templates/commits.html: Use main since Drawer is now a sidebar.
2074         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Ditto.
2075         * resultsdbpy/resultsdbpy/view/templates/search.html: Ditto.
2076         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
2077         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
2078         (WebSiteTestCase.toggle_drawer): Support new drawer style.
2079         (WebSiteTestCase.find_input_with_name): Ditto.
2080
2081 2019-08-28  Keith Rollin  <krollin@apple.com>
2082
2083         Remove support for macOS < 10.13 (part 2)
2084         https://bugs.webkit.org/show_bug.cgi?id=201197
2085         <rdar://problem/54759985>
2086
2087         Reviewed by Darin Adler.
2088
2089         Update conditionals that reference WK_MACOS_1013 and suffixes like
2090         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
2091         later and that these conditionals are always True or False.
2092
2093         See Bug 200694 for earlier changes in this area.
2094
2095         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2096
2097 2019-08-28  Alicia Boya García  <aboya@igalia.com>
2098
2099         [MSE][GStreamer] WebKitMediaSrc rework
2100         https://bugs.webkit.org/show_bug.cgi?id=199719
2101
2102         Reviewed by Xabier Rodriguez-Calvar.
2103
2104         Added WebKitMediaSourceGStreamer.cpp to the GStreamer-style coding
2105         whitelist.
2106
2107         * Scripts/webkitpy/style/checker.py:
2108
2109 2019-08-28  Alexey Proskuryakov  <ap@apple.com>
2110
2111         Updating inactive contributors in contributors.json.
2112
2113         * Scripts/webkitpy/common/config/contributors.json:
2114
2115 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
2116
2117         results.webkit.org: Auto-expand single configurations
2118         https://bugs.webkit.org/show_bug.cgi?id=201218
2119
2120         Rubber-stamped by Aakash Jain.
2121
2122         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2123         (TimelineFromEndpoint.toString): Automatically expand timeline when only one
2124         configuration has been specified.
2125         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2126         (prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
2127         is expanded or collapsed by default.
2128
2129 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
2130
2131         results.webkit.org: Sanitize all commit arguments on upload
2132         https://bugs.webkit.org/show_bug.cgi?id=201189
2133         <rdar://problem/54564837>
2134
2135         Reviewed by Aakash Jain.
2136
2137         * resultsdbpy/resultsdbpy/controller/commit.py:
2138         (Commit.__init__): Only allow commits to be constructed with valid values.
2139         * resultsdbpy/resultsdbpy/controller/commit_controller.py:
2140         (CommitController.register): Strip potential API key.
2141         * resultsdbpy/resultsdbpy/controller/commit_unittest.py:
2142         (CommitUnittest.test_invalid): Test that commits which contain html inside the
2143         repository_id, branch or commit id are rejected.
2144
2145 2019-08-02  Claudio Saavedra  <csaavedra@igalia.com>
2146
2147         [GTK][WPE] Implement HSTS for the soup network backend
2148         https://bugs.webkit.org/show_bug.cgi?id=192074
2149
2150         Reviewed by Carlos Garcia Campos.
2151
2152         libsoup 2.67.1 introduced HSTS support via a SoupSessionFeature.
2153         Add support to the soup network backend by adding the feature to
2154         SoupNetworkSession and handling HSTS protocol upgrades, by
2155         propagating the scheme change further to clients. This patch adds
2156         the HSTS feature unconditionally, but it still possible to add
2157         a boolean property to the web context class if desired.
2158
2159         Additionally, add API to the WebKitWebsiteDataManager to specify
2160         the directory where the HSTS database is saved. If the directory
2161         is not set or if the data manager is ephemeral, use a
2162         non-persistent, memory only HSTS enforcer.
2163
2164         Implement as well the methods needed to clean-up and delete HSTS
2165         policies from the storage and expose the feature in GTK+
2166         MiniBrowser's about:data.
2167
2168         * MiniBrowser/gtk/main.c:
2169         (gotWebsiteDataCallback):
2170         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2171         (serverCallback):
2172         (testWebsiteDataConfiguration):
2173         (testWebsiteDataEphemeral):
2174         (prepopulateHstsData):
2175         (testWebsiteDataHsts):
2176         (beforeAll):
2177         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2178         (Test::Test):
2179         * gtk/jhbuild.modules: Bump libsoup to 2.67.91 for the new APIs
2180         * wpe/jhbuild.modules: Ditto
2181         * MiniBrowser/gtk/main.c:
2182         (gotWebsiteDataCallback):
2183
2184 2019-08-27  James Darpinian  <jdarpinian@google.com>
2185
2186         Fix applying diffs that only change file mode
2187         https://bugs.webkit.org/show_bug.cgi?id=201191
2188
2189         Reviewed by Daniel Bates.
2190
2191         * Scripts/svn-apply:
2192         (patch): Handle case of file mode change without content change
2193
2194 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
2195
2196         [ews] Status bubble should be red for CANCELLED builds
2197         https://bugs.webkit.org/show_bug.cgi?id=201204
2198
2199         Reviewed by Jonathan Bedard.
2200
2201         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2202         (StatusBubble._build_bubble):
2203
2204 2019-08-27  Zhifei Fang  <zhifei_fang@apple.com>
2205
2206         [results.webkit.org Webkit.css] Center the legend symbols
2207         https://bugs.webkit.org/show_bug.cgi?id=201187
2208
2209         Reviewed by Jonathan Bedard.
2210
2211         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2212         (.lengend>.item .dot .text): center the dot symbol vertically
2213
2214 2019-08-27  Jonathan Bedard  <jbedard@apple.com>
2215
2216         run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
2217         https://bugs.webkit.org/show_bug.cgi?id=201000
2218         <rdar://problem/53778938>
2219
2220         Unreviewed follow-up fix.
2221
2222         * Scripts/webkitpy/port/darwin.py:
2223         (DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
2224         spindump call failed.
2225         * Scripts/webkitpy/port/darwin_testcase.py:
2226         * Scripts/webkitpy/port/ios_device_unittest.py:
2227
2228 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
2229
2230         [ews-build] Use update-webkit script in Apply-WatchList EWS
2231         https://bugs.webkit.org/show_bug.cgi?id=201179
2232
2233         Reviewed by Jonathan Bedard.
2234
2235         * BuildSlaveSupport/ews-build/factories.py:
2236         (WatchListFactory): Updated to use CheckOutSource step as well.
2237
2238 2019-08-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2239
2240         W3C test importer should be able to handle expected references with an absolute path.
2241         https://bugs.webkit.org/show_bug.cgi?id=200717
2242
2243         Reviewed by Youenn Fablet.
2244
2245         This patch implements the logic to resolve test references with absolute paths
2246         when importing w3c tests (like web-platform-tests).
2247         When an absolute path is found for a test reference, the parser now
2248         tries to find the right file by looking for a relative path inside
2249         the root directory of the source test repository.
2250         It works when the tool is run in download-mode as well as when the
2251         tool is run to import the tests from a local directory.
2252
2253         This fixes the import of test references for tests like
2254         web-platform-tests/css/css-images/multiple-position-color-stop-linear-2.html
2255
2256         * Scripts/webkitpy/w3c/test_importer.py:
2257         (TestImporter._source_root_directory_for_path):
2258         (TestImporter.find_importable_tests):
2259         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2260         (TestImporterTest.import_directory):
2261         (test_webkit_test_runner_options):
2262         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
2263         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
2264         * Scripts/webkitpy/w3c/test_parser.py:
2265         (TestParser.__init__):
2266         (TestParser.analyze_test):
2267
2268 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2269
2270         Remove UIHelper.activateElementAtHumanSpeed
2271         https://bugs.webkit.org/show_bug.cgi?id=201147
2272
2273         Reviewed by Tim Horton.
2274
2275         Add plumbing for a new script controller hook to wait for the double tap delay to pass. On non-iOS, this
2276         resolves immediately; on iOS, we inspect the content view for tap gestures that require more than one tap, and
2277         find the value of the maximum double tap delay. We then delay for this amount of time before resolving.
2278
2279         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2280         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2281         (WTR::UIScriptController::doAfterDoubleTapDelay):
2282         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
2283         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2284         (WTR::UIScriptControllerIOS::doAfterDoubleTapDelay):
2285
2286 2019-08-26  Zhifei Fang  <zhifei_fang@apple.com>
2287
2288         [results.webkit.org Timline] Add symbols to the timeline dot
2289         https://bugs.webkit.org/show_bug.cgi?id=201105
2290
2291         Reviewed by Jonathan Bedard.
2292
2293         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2294         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2295         (Timeline.CanvasSeriesComponent): Modify the drawDot api to provide user ability to add symbol to the dots, it supports unicode symbol
2296         * resultsdbpy/resultsdbpy/view/templates/base.html: Add the encoding UTF-8 for the page, so that we can add unicode symbol to the dots
2297
2298 2019-08-26  Yusuke Suzuki  <ysuzuki@apple.com>
2299
2300         Unreviewed, remove useMaximalFlushInsertionPhase use
2301         https://bugs.webkit.org/show_bug.cgi?id=201036
2302
2303         * Scripts/run-jsc-stress-tests:
2304
2305 2019-08-26  David Kilzer  <ddkilzer@apple.com>
2306
2307         Don't compute upconverted characters twice in buildQuery() in DataDetection.mm
2308         <https://webkit.org/b/201144>
2309         <rdar://problem/54689399>
2310
2311         Reviewed by Brent Fulgham.
2312
2313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
2314         DataDetectorsTestIOS.mm to the project.
2315         * TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm: Add a new
2316         test for Data Detectors for phone numbers.
2317
2318 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2319
2320         REGRESSION (iOS 13): Tests that simulate multiple back-to-back single taps fail or time out
2321         https://bugs.webkit.org/show_bug.cgi?id=201129
2322         <rdar://problem/51857277>
2323
2324         Reviewed by Tim Horton.
2325
2326         The tests in editing/pasteboard/ios were timing out on iOS 13 before this change. This is because they simulate
2327         back-to-back single taps; while this is recognized as two single taps on iOS 12 and prior, only the first single
2328         tap is recognized on iOS 13 (and the second is simply dropped on the floor). This occurs because the synthetic
2329         single tap gesture is reset slightly later on iOS 13 compared to iOS 12, so when the second tap is dispatched,
2330         the gesture recognizer is still in "ended" state after the first tap on iOS 13, which means the gesture isn't
2331         capable of recognizing further touches yet.
2332
2333         In UIKit, a gesture recognizer is only reset once its UIGestureEnvironment's containing dependency subgraph no
2334         longer contains gestures that are active. In iOS 12, the synthetic click gesture is a part of a dependency
2335         subgraph that contains only itself and the normal (blocking) double tap gesture which requires the click to fail
2336         before it can be recognized; immediately after simulating the tap, both these gestures are inactive, which
2337         allows both of them to be reset.
2338
2339         However, in iOS 13, the synthetic click gesture is part of a gesture dependency graph that contains the double
2340         tap for double click gesture, as well as the non-blocking double tap gesture, both of which are still active
2341         immediately after sending the first tap. This change in dependencies is caused by the introduction of
2342         UIUndoGestureInteraction's single and double three-finger tap gestures, which (in -[UIUndoGestureInteraction
2343         gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]) explicitly add all other taps as failure
2344         requirements. This effectively links the synthetic single tap gesture to most of the other gestures in
2345         WKContentView's dependency graph by way of these tap gestures for the undo interaction.
2346
2347         All this means that there is now a short (~50 ms) delay after the synthetic single tap gestures is recognized,
2348         before it can be recognized again. To account for this new delay in our test infrastructure, simply wait for
2349         single tap gestures that have ended to reset before attempting to send subsequent single taps. We do this by
2350         introducing WebKit testing SPI to invoke a completion handler after resetting the synthetic click gesture (only
2351         if necessary - i.e., if the gesture is in ended state when we are about to begin simulating the tap). This
2352         allows calls to `UIScriptController::singleTapAtPoint` to be reliably recognized as single taps without
2353         requiring arbitrary 120 ms "human speed" delays.
2354
2355         This fixes a number of flaky or failing layout tests, including the tests in editing/pasteboard/ios.
2356
2357         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2358         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2359         (WTR::UIScriptController::doubleTapAtPoint):
2360
2361         Add a `delay` parameter to `doubleTapAtPoint`. A number of layout tests were actually simulating double click
2362         gestures by simulating two back-to-back single taps; this is done for the purposes of being able to add a "human
2363         speed" delay prior to the second single tap gesture. After the change to wait for the single tap gesture to
2364         reset before attempting to simulate the next tap, this strategy no longer works, since the second gesture is
2365         recognized only as a single tap instead of a double tap.
2366
2367         Instead, we add a delay parameter to `UIScriptController::doubleTapAtPoint`, which the "human speed" double tap
2368         gestures use instead to wait after simulating the first tap.
2369
2370         * WebKitTestRunner/ios/HIDEventGenerator.h:
2371         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2372         (-[HIDEventGenerator _waitFor:]):
2373         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:delay:completionBlock:]):
2374
2375         Plumb the tap gesture delay through to this helper method.
2376
2377         (-[HIDEventGenerator tap:completionBlock:]):
2378         (-[HIDEventGenerator doubleTap:delay:completionBlock:]):
2379         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2380         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]): Deleted.
2381         (-[HIDEventGenerator doubleTap:completionBlock:]): Deleted.
2382         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
2383         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2384         (WTR::UIScriptControllerIOS::waitForSingleTapToReset const):
2385
2386         Add a new helper to wait for the content view's single tap gesture to reset if needed; call this before
2387         attempting to simulate single taps (either using a stylus, or with a regular touch).
2388
2389         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
2390         (WTR::UIScriptControllerIOS::doubleTapAtPoint):
2391         (WTR::UIScriptControllerIOS::stylusTapAtPointWithModifiers):
2392
2393 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
2394
2395         results.webkit.org: Allow clicking on the tooltip arrow
2396         https://bugs.webkit.org/show_bug.cgi?id=201103
2397
2398         Rubber-stamped by Aakash Jain.
2399
2400         By design, the arrow sits above the canvas and intercepts mouse events from it.
2401         This will often make an element that has a tooltip unclickable.
2402
2403         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2404         (xAxisFromScale):
2405         (TimelineFromEndpoint.prototype.render.onDotEnterFactory):
2406         (TimelineFromEndpoint.prototype.render):
2407         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
2408         (_ToolTip):
2409         (_ToolTip.prototype.toString): Trigger onClick callback when the arrow is clicked.
2410         (_ToolTip.prototype.set): Set the onClick callback.
2411
2412 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
2413
2414         [EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot
2415         https://bugs.webkit.org/show_bug.cgi?id=201140
2416
2417         Reviewed by Jonathan Bedard.
2418
2419         * BuildSlaveSupport/ews-build/steps.py:
2420         (TestWithFailureCount.getResultSummary): Do not append (failure) when in case of custom status.
2421         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2422
2423 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
2424
2425         run-webkit-tests: Cap the number of automatically booted simulators at 12
2426         https://bugs.webkit.org/show_bug.cgi?id=201139
2427
2428         Reviewed by Aakash Jain.
2429
2430         To make local development with simulators more pleasant, machines should
2431         never automatically boot more than 12 simulators.
2432
2433         * Scripts/webkitpy/xcode/simulated_device.py:
2434         (SimulatedDeviceManager.max_supported_simulators):
2435
2436 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
2437
2438         [ews] Add EWS queue for applying watchlist
2439         https://bugs.webkit.org/show_bug.cgi?id=201072
2440
2441         Reviewed by Jonathan Bedard.
2442
2443         * BuildSlaveSupport/ews-build/steps.py:
2444         (ApplyWatchList): Build step to apply watchlist.
2445         (ApplyWatchList.__init__): Set logEnviron to False.
2446         (ApplyWatchList.getResultSummary): Updated the description in case of failure.
2447         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2448         * BuildSlaveSupport/ews-build/factories.py:
2449         (WatchListFactory): Build factory for WatchList.
2450         * BuildSlaveSupport/ews-build/loadConfig.py:
2451         * BuildSlaveSupport/ews-build/config.json:
2452
2453 2019-08-26  Youenn Fablet  <youenn@apple.com>
2454
2455         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
2456         https://bugs.webkit.org/show_bug.cgi?id=196870
2457
2458         Reviewed by Alex Christensen.
2459
2460         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
2461         Accept any server certificate by default.
2462
2463         * WebKitTestRunner/TestController.cpp:
2464         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2465         (WTR::TestController::cocoaResetStateToConsistentValues):
2466         (WTR::TestController::setAllowsAnySSLCertificate):
2467         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
2468         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2469         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
2470         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
2471
2472 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
2473
2474         Increase log level for watchlist result
2475         https://bugs.webkit.org/show_bug.cgi?id=201081
2476
2477         Reviewed by Jonathan Bedard.
2478
2479         * Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
2480         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
2481         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
2482
2483 2019-08-23  Chris Dumez  <cdumez@apple.com>
2484
2485         [geolocation] Rename interfaces and remove [NoInterfaceObject]
2486         https://bugs.webkit.org/show_bug.cgi?id=200885
2487
2488         Reviewed by Alex Christensen.
2489
2490         * DumpRenderTree/mac/TestRunnerMac.mm:
2491         (TestRunner::setMockGeolocationPosition):
2492
2493 2019-08-23  Ryan Haddad  <ryanhaddad@apple.com>
2494
2495         Unreviewed, rolling out r249001.
2496
2497         Caused one layout test to fail on all configurations and
2498         another to time out on Catalina / iOS 13.
2499
2500         Reverted changeset:
2501
2502         "Add a WebsiteDataStore delegate to handle
2503         AuthenticationChallenge that do not come from pages"
2504         https://bugs.webkit.org/show_bug.cgi?id=196870
2505         https://trac.webkit.org/changeset/249001
2506
2507 2019-08-23  Jonathan Bedard  <jbedard@apple.com>
2508
2509         results.webkit.org: Escape html in changelog
2510         https://bugs.webkit.org/show_bug.cgi?id=201025
2511         <rdar://problem/54564837>
2512
2513         Reviewed by Darin Adler.
2514
2515         * resultsdbpy/resultsdbpy/view/commit_view.py:
2516         (CommitView.commit): Output a dictionary instead of a JSON encoded string.
2517         * resultsdbpy/resultsdbpy/view/templates/commit.html: Unpack commits dictionary
2518         directly into a JavaScript dictionary.
2519
2520 2019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
2521
2522         [WebAuthn] Support NFC authenticators for iOS
2523         https://bugs.webkit.org/show_bug.cgi?id=188624
2524         <rdar://problem/43354214>
2525
2526         Reviewed by Chris Dumez.
2527
2528         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2529         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2530         Setup NFC mock testing configuration.
2531
2532 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
2533
2534         [ews] Enable Style queue on new EWS
2535         https://bugs.webkit.org/show_bug.cgi?id=201071
2536
2537         Reviewed by Jonathan Bedard.
2538
2539         * BuildSlaveSupport/ews-build/config.json: Enabled the scheduler for Style queue.
2540         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled style queue bubble on new EWS.
2541         * QueueStatusServer/config/queues.py: Removed style queue from old EWS.
2542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2543         (BubbleQueueServer): Removed style queue from bot-watcher's dashboard.
2544
2545 2019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
2546
2547         [Win][MiniBrowser] URL bar should be updated for in-page navigations
2548         https://bugs.webkit.org/show_bug.cgi?id=201032
2549
2550         Reviewed by Darin Adler.
2551
2552         * MiniBrowser/win/BrowserWindow.h: Added activeURLChanged to BrowserWindowClient interface.
2553         * MiniBrowser/win/MainWindow.cpp:
2554         (MainWindow::init):
2555         (MainWindow::activeURLChanged): Added.
2556         * MiniBrowser/win/MainWindow.h:
2557         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2558         (MiniBrowserWebHost::didCommitLoadForFrame):
2559         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Added.
2560         (MiniBrowserWebHost::updateAddressBar): Deleted.
2561         (MiniBrowserWebHost::loadURL): Deleted.
2562         * MiniBrowser/win/MiniBrowserWebHost.h:
2563         (MiniBrowserWebHost::MiniBrowserWebHost):
2564         (MiniBrowserWebHost::didCommitLoadForFrame): Deleted.
2565         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Deleted.
2566         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2567         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2568         (WebKitBrowserWindow::create):
2569         (WebKitBrowserWindow::WebKitBrowserWindow):
2570         (WebKitBrowserWindow::didChangeIsLoading): Removed an unused variable.
2571         (WebKitBrowserWindow::didChangeActiveURL): Added.
2572         (WebKitBrowserWindow::createNewPage):
2573         (WebKitBrowserWindow::didCommitNavigation): Deleted.
2574         * MiniBrowser/win/WebKitBrowserWindow.h: Removed m_urlBarWnd.
2575         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2576         (WebKitLegacyBrowserWindow::create):
2577         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
2578         (WebKitLegacyBrowserWindow::init):
2579         (WebKitLegacyBrowserWindow::navigateToHistory):
2580         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Removed m_urlBarWnd.
2581
2582 2019-08-22  Andy Estes  <aestes@apple.com>
2583
2584         [watchOS] Disable Content Filtering in the simulator build
2585         https://bugs.webkit.org/show_bug.cgi?id=201047
2586
2587         Reviewed by Tim Horton.
2588
2589         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2590
2591 2019-08-22  Chris Dumez  <cdumez@apple.com>
2592
2593         Try to recover nicely when getting an unexpected schema in the service workers database
2594         https://bugs.webkit.org/show_bug.cgi?id=201002
2595         <rdar://problem/54574991>
2596
2597         Reviewed by Youenn Fablet.
2598
2599         Add API test coverage.
2600
2601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2602         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2603
2604 2019-08-22  Keith Rollin  <krollin@apple.com>
2605
2606         Remove support for tvOS < 13.0
2607         https://bugs.webkit.org/show_bug.cgi?id=200963
2608         <rdar://problem/54541355>
2609
2610         Reviewed by Tim Horton.
2611
2612         Update conditionals that reference __TV_OS_VERSION_MIN_REQUIRED and
2613         __TV_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
2614         130000. This means that expressions like "__TV_OS_VERSION_MIN_REQUIRED
2615         < 130000" are always False and "__TV_OS_VERSION_MIN_REQUIRED >=
2616         130000" are always True.
2617
2618         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2619         (TestWebKitAPI::TEST):
2620
2621 2019-08-22  Daniel Bates  <dabates@apple.com>
2622
2623         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
2624         https://bugs.webkit.org/show_bug.cgi?id=200742
2625
2626         Reviewed by Simon Fraser.
2627
2628         The OptionSet synthetic provider must respond to requests for the value of m_storage
2629         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
2630         of the type summary.
2631
2632         Synthetic providers substitute alternative debug information (children) for the default
2633         information for a variable. The OptionSet type summary is implemented in terms of the
2634         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
2635         before invoking the type summary handler then evaluating GetChildMemberWithName() on
2636         the SBValue passed to the type summary handler will access the substitute information
2637         instead of the original debug information. As a result OptionSet's synthetic provider's
2638         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
2639         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
2640         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
2641         should return a valid value.
2642
2643         * lldb/lldb_webkit.py:
2644         (FlagEnumerationProvider.__init__):
2645         (FlagEnumerationProvider):
2646         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
2647         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
2648         (FlagEnumerationProvider.size): Added.
2649         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
2650         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
2651         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
2652         and removed self.size. For the latter we can just expose a getter that returns the size of
2653         the list self._elements.
2654         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
2655         value of m_storage.
2656         (WTFOptionSetProvider):
2657         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
2658         matches the specified index.
2659         * lldb/lldb_webkit_unittest.py:
2660         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Update expected result now
2661         that we return the value of m_storage as the last synthetic child.
2662
2663 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
2664
2665         results.webkit.org: Remove branch and repository information from commit tooltip
2666         https://bugs.webkit.org/show_bug.cgi?id=201035
2667
2668         Reviewed by Aakash Jain.
2669
2670         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2671         (xAxisFromScale): Remove branch and repository information from tooltip.
2672
2673 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
2674
2675         run-webkit-tests: Use -noBulkSymbolication when calling spindump
2676         https://bugs.webkit.org/show_bug.cgi?id=201000
2677         <rdar://problem/53778938>
2678
2679         Reviewed by Alexey Proskuryakov.
2680
2681         * Scripts/webkitpy/port/darwin.py:
2682         (DarwinPort.sample_process): Attempt to symbolicate with -noBulkSymbolication first.
2683         * Scripts/webkitpy/port/darwin_testcase.py:
2684         (DarwinTest.test_tailspin):
2685         (DarwinTest.test_get_crash_log): Deleted.
2686         * Scripts/webkitpy/port/ios_device_unittest.py:
2687         (IOSDeviceTest.test_tailspin):
2688
2689 2019-08-22  Zhifei Fang  <zhifei_fang@apple.com>
2690
2691         [results.webkit.org Webkit.css] Change input's disable style
2692         The disable input style will always show the label like it has a value 
2693         https://bugs.webkit.org/show_bug.cgi?id=200998
2694
2695         Reviewed by Jonathan Bedard.
2696
2697         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value
2698         *resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs:
2699         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
2700         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2701         (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value
2702         (.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,):
2703         (@media (prefers-color-scheme: dark)):
2704
2705 2019-08-17  Darin Adler  <darin@apple.com>
2706
2707         Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends
2708         https://bugs.webkit.org/show_bug.cgi?id=200862
2709
2710         Reviewed by Ryosuke Niwa.
2711
2712         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2713         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Use makeString.
2714         * WebKitTestRunner/TestController.cpp:
2715         (WTR::TestController::findAndDumpWebKitProcessIdentifiers): Ditto.
2716         (WTR::TestController::downloadDidReceiveServerRedirectToURL): Ditto.
2717         (WTR::TestController::downloadDidFail): Ditto.
2718
2719 2019-08-22  clopez@igalia.com  <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
2720
2721         [GTK][WPE] Support for command "--version" on the MiniBrowser (follow-up fix)
2722         https://bugs.webkit.org/show_bug.cgi?id=200978
2723
2724         Unreviewed follow-up fix.
2725
2726         Update the string format specifier for unsigned it.
2727
2728         * MiniBrowser/gtk/main.c:
2729         (main):
2730         * MiniBrowser/wpe/main.cpp:
2731         (main):
2732
2733 2019-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2734
2735         [GTK][WPE] Support for command "--version" on the MiniBrowser
2736         https://bugs.webkit.org/show_bug.cgi?id=200978
2737
2738         Reviewed by Žan Doberšek.
2739
2740         Printing the engine version used from the MiniBrowser is useful.
2741         For example, the test scripts on WPT can use this info to better
2742         tag the generated results.
2743
2744         * MiniBrowser/gtk/main.c: Print the engine version when called with --version or -v.
2745         (main):
2746         * MiniBrowser/wpe/main.cpp: Ditto.
2747         (main):
2748
2749 2019-08-22  Youenn Fablet  <youenn@apple.com>
2750
2751         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
2752         https://bugs.webkit.org/show_bug.cgi?id=196870
2753
2754         Reviewed by Alex Christensen.
2755
2756         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
2757         Accept any server certificate by default.
2758
2759         * WebKitTestRunner/TestController.cpp:
2760         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2761         (WTR::TestController::cocoaResetStateToConsistentValues):
2762         (WTR::TestController::setAllowsAnySSLCertificate):
2763         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
2764         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2765         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
2766         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
2767
2768 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
2769
2770         results.webkit.org: Fix drawer style
2771         https://bugs.webkit.org/show_bug.cgi?id=200988
2772
2773         Rubber-stamped by Aakash Jain.
2774
2775         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2776         (Drawer): Nothing in the drawer should be selectable.
2777         (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
2778         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2779         (.action:hover): Disable underline on 'links' which are actually actions
2780         (.unselectable): Make a div unselectable.
2781         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2782         (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
2783
2784 2019-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2785
2786         [Win][MiniBrowser] Add a progress indicator to the main window
2787         https://bugs.webkit.org/show_bug.cgi?id=200970
2788
2789         Reviewed by Alex Christensen.
2790
2791         * MiniBrowser/win/BrowserWindow.h: Added BrowserWindowClient class.
2792         * MiniBrowser/win/MainWindow.cpp:
2793         (MainWindow::init):
2794         (MainWindow::resizeSubViews):
2795         (MainWindow::progressChanged):
2796         (MainWindow::progressFinished):
2797         * MiniBrowser/win/MainWindow.h: Inherited BrowserWindowClient.
2798         Added m_hProgressIndicator.
2799         (MainWindow::hwnd const): Deleted.
2800         (MainWindow::browserWindow const): Deleted.
2801         (): Deleted.
2802         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2803         (MiniBrowserWebHost::onNotify):
2804         * MiniBrowser/win/MiniBrowserWebHost.h:
2805         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2806         (WebKitBrowserWindow::create):
2807         (WebKitBrowserWindow::WebKitBrowserWindow):
2808         (WebKitBrowserWindow::didChangeIsLoading):
2809         (WebKitBrowserWindow::didChangeEstimatedProgress):
2810         (WebKitBrowserWindow::createNewPage):
2811         * MiniBrowser/win/WebKitBrowserWindow.h:
2812         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2813         (WebKitLegacyBrowserWindow::create):
2814         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
2815         (WebKitLegacyBrowserWindow::init):
2816         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2817
2818 2019-08-21  Ryan Haddad  <ryanhaddad@apple.com>
2819
2820         Unreviewed, rolling out r248970.
2821
2822         Caused
2823         lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
2824         to fail.
2825
2826         Reverted changeset:
2827
2828         "[lldb-webkit] OptionSet summary shows size 0 sometimes for
2829         non-empty set"
2830         https://bugs.webkit.org/show_bug.cgi?id=200742
2831         https://trac.webkit.org/changeset/248970
2832
2833 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
2834
2835         results.webkit.org: Add database table to save zip archives to
2836         https://bugs.webkit.org/show_bug.cgi?id=200718
2837
2838         Rubber-stamped by Aakash Jain.
2839
2840         * resultsdbpy/resultsdbpy/model/archive_context.py: Added.
2841         (ArchiveContext):
2842         (ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
2843         (ArchiveContext.ArchivesByCommit.unpack):
2844         (ArchiveContext.assert_zipfile):
2845         (ArchiveContext.open_zipfile):
2846         (ArchiveContext.__init__):
2847         (ArchiveContext.__enter__):
2848         (ArchiveContext.__exit__):
2849         (ArchiveContext.register): Save the provided archive to Cassandra.
2850         (ArchiveContext.find_archive): Find all archives matching the specified criteria.
2851         (ArchiveContext._files_for_archive):
2852         (ArchiveContext.ls): List all files in the matching archives.
2853         (ArchiveContext.file): Extract a file from the matching archives.
2854         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
2855         (ArchiveContextTest):
2856         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
2857         (MockModelFactory):
2858         (MockModelFactory.process_results):
2859         (MockModelFactory.add_mock_archives):
2860         * resultsdbpy/resultsdbpy/model/model.py:
2861         (Model.__init__): Add an ArchiveContext to the model.
2862
2863 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
2864
2865         [ews-build] view layout test results option should be displayed next to layout-test build step
2866         https://bugs.webkit.org/show_bug.cgi?id=200048
2867
2868         Reviewed by Jonathan Bedard.
2869
2870         * BuildSlaveSupport/ews-build/steps.py:
2871         (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
2872         (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
2873
2874 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
2875
2876         [ews] Fix capitalization in Found x new Test failure message
2877         https://bugs.webkit.org/show_bug.cgi?id=201004
2878
2879         Reviewed by Alexey Proskuryakov.
2880
2881         * BuildSlaveSupport/ews-build/steps.py:
2882         (AnalyzeLayoutTestsResults.report_failure):
2883         (AnalyzeAPITestsResults.analyzeResults):
2884         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2885
2886 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
2887
2888         Assign ews117 to EWS High-Sierra Debug queues
2889         https://bugs.webkit.org/show_bug.cgi?id=200993
2890
2891         Reviewed by Jonathan Bedard.
2892
2893         * BuildSlaveSupport/ews-build/config.json:
2894
2895 2019-08-21  Daniel Bates  <dabates@apple.com>
2896
2897         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
2898         https://bugs.webkit.org/show_bug.cgi?id=200742
2899
2900         Reviewed by Simon Fraser.
2901
2902         The OptionSet synthetic provider must respond to requests for the value of m_storage
2903         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
2904         of the type summary.
2905
2906         Synthetic providers substitute alternative debug information (children) for the default
2907         information for a variable. The OptionSet type summary is implemented in terms of the
2908         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
2909         before invoking the type summary handler then evaluating GetChildMemberWithName() on
2910         the SBValue passed to the type summary handler will access the substitute information
2911         instead of the original debug information. As a result OptionSet's synthetic provider's
2912         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
2913         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
2914         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
2915         should return a valid value.
2916
2917         * lldb/lldb_webkit.py:
2918         (FlagEnumerationProvider.__init__):
2919         (FlagEnumerationProvider):
2920         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
2921         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
2922         (FlagEnumerationProvider.size): Added.
2923         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
2924         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
2925         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
2926         and removed self.size. For the latter we can just expose a getter that returns the size of
2927         the list self._elements.
2928         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
2929         value of m_storage.
2930         (WTFOptionSetProvider):
2931         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
2932         matches the specified index.
2933
2934 2019-08-21  Alex Christensen  <achristensen@webkit.org>
2935
2936         Disabling text autosizing should prevent text autosizing
2937         https://bugs.webkit.org/show_bug.cgi?id=200955
2938         <rdar://problem/48095374>
2939
2940         Reviewed by Simon Fraser.
2941
2942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2943         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
2944         (TEST):
2945
2946 2019-08-21  Adrian Perez de Castro  <aperez@igalia.com>
2947
2948         [GTK][WPE] Make debug-test-runner work
2949         https://bugs.webkit.org/show_bug.cgi?id=193576
2950
2951         Reviewed by Michael Catanzaro.
2952
2953         * Scripts/webkitdirs.pm:
2954         (wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
2955         (setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
2956         TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
2957         (execUnixAppForDebugging): Added.
2958         (debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
2959
2960 2019-08-20  Ryosuke Niwa  <rniwa@webkit.org>
2961
2962         Put keygen element behind a runtime flag and disable it by default
2963         https://bugs.webkit.org/show_bug.cgi?id=200850
2964
2965         Reviewed by Antti Koivisto.
2966
2967         Added the support for enableKeygenElement test runner option, which enables keygen element in layout tests.
2968
2969         * DumpRenderTree/TestOptions.cpp:
2970         (TestOptions::TestOptions):
2971         * DumpRenderTree/TestOptions.h:
2972         * DumpRenderTree/mac/DumpRenderTree.mm:
2973         (setWebPreferencesForTestOptions):
2974         * DumpRenderTree/win/DumpRenderTree.cpp:
2975         (setWebPreferencesForTestOptions):
2976         * WebKitTestRunner/TestController.cpp:
2977         (WTR::TestController::resetPreferencesToConsistentValues):
2978         (WTR::updateTestOptionsFromTestHeader):
2979         * WebKitTestRunner/TestOptions.h:
2980         (WTR::TestOptions::hasSameInitializationOptions const):
2981
2982 2019-08-21  Chris Dumez  <cdumez@apple.com>
2983
2984         Add internal setting to disable SecureContext checks
2985         https://bugs.webkit.org/show_bug.cgi?id=200980
2986         <rdar://problem/54438512>
2987
2988         Reviewed by Alex Christensen.
2989
2990         Add API test coverage.
2991
2992         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2993         (log):
2994         (requestPermission):
2995
2996 2019-08-21  Keith Rollin  <krollin@apple.com>
2997
2998         Remove support for watchOS < 6.0
2999         https://bugs.webkit.org/show_bug.cgi?id=200937
3000         <rdar://problem/54524009>
3001
3002         Reviewed by Darin Adler.
3003
3004         Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and
3005         __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
3006         60000. This means that expressions like
3007         "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and
3008         "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True.
3009
3010         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
3011         (TestWebKitAPI::TEST):
3012
3013 2019-08-20  Zhifei Fang  <zhifei_fang@apple.com>
3014
3015         [results.webkit.org Webkit.css] Add right sidebar
3016         https://bugs.webkit.org/show_bug.cgi?id=200946
3017
3018         Reviewed by Jonathan Bedard.
3019
3020         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3021         (@media screen and (min-width: 600px) and (orientation: landscape)):
3022         (.main.left):
3023         (@media screen and (min-width: 768px) and (orientation: landscape)):
3024         (.sidebar.right):
3025
3026 2019-08-20  Jonathan Bedard  <jbedard@apple.com>
3027
3028         results.webkit.org: Add ToolTips
3029         https://bugs.webkit.org/show_bug.cgi?id=200801
3030
3031         Rubber-stamped by Aakash Jain.
3032
3033         When dots or scale labels are hovered over, we should display a tool tip with additional information about
3034         The specific element.
3035
3036         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Added.
3037         (.tooltip): Add class for ToolTip text box.
3038         (.tooltip-arrow-up): Add class for ToolTip arrow pointing up.
3039         (.tooltip-arrow-down): Add class for ToolTip arrow pointing down.
3040         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
3041         (_CommitBank.prototype.commitsDuringUuid): Return a list of commits which were the trunk of their respective
3042         repositories at a given time.
3043         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3044         (xAxisFromScale): Add callbacks triggered when the mouse enters or leaves elements in the scale canvas.
3045         (TimelineFromEndpoint.render): Add callbacks triggered when the mouse enters or leaves dot elements.
3046         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js: Added.
3047         (isPointInElement): Given an element and a point, return true if that point is within the bounds of the element.
3048         (_ToolTip):
3049         (_ToolTip.prototype.set): Set the content and location of the ToolTip.
3050         (_ToolTip.prototype.toString): Return the html needed to render the ToolTip.
3051         (_ToolTip.prototype.unset): Clear and hide the ToolTip.
3052         (_ToolTip.prototype.isIn): Check if a given point is contained within the ToolTip.
3053         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3054         (Timeline.CanvasSeriesComponent): Convert onHover events to onEnter/onLeave events. Add toolTips points to both
3055         dot and scale elements.
3056         * resultsdbpy/resultsdbpy/view/templates/search.html: Add ToolTip.
3057         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
3058
3059 2019-08-20  Justin Michaud  <justin_michaud@apple.com>
3060
3061         Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
3062         https://bugs.webkit.org/show_bug.cgi?id=200782
3063
3064         Reviewed by Saam Barati.
3065
3066         * Scripts/run-jsc-stress-tests:
3067
3068 2019-08-20  Darin Adler  <darin@apple.com>
3069
3070         Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly
3071         https://bugs.webkit.org/show_bug.cgi?id=200921
3072
3073         Reviewed by Saam Barati.
3074
3075         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3076         Changed tests to use EXPECT macros instead of ASSERT macros since we don't
3077         need to abort after the first failure. Added three new tests to the VariadicAppend
3078         test to cover various cases of upconverting from 8-bit to 16-bit strings.
3079
3080 2019-08-20  Dean Jackson  <dino@apple.com>
3081
3082         REGRESSION: Open in New Tab is missing from context menu
3083         https://bugs.webkit.org/show_bug.cgi?id=200909
3084         <rdar://problem/54476169>
3085
3086         Reviewed by Simon Fraser.
3087
3088         Add a new test that runs through the legacy context menu
3089         flow, and verifies that it will be called if there aren't
3090         appropriate delegates for the new API.
3091
3092         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
3093         (contextMenuWebViewDriver):
3094         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
3095         (TEST):
3096         (-[LegacyPreviewViewController previewActionItems]):
3097         (-[LegacyContextMenuUIDelegate webView:shouldPreviewElement:]):
3098         (-[LegacyContextMenuUIDelegate webView:previewingViewControllerForElement:defaultActions:]):
3099         (-[LegacyContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
3100         (-[LegacyContextMenuUIDelegate _webView:contextMenuDidEndForElement:]):
3101         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
3102
3103 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
3104
3105         [JSC] OSR entry to Wasm OMG
3106         https://bugs.webkit.org/show_bug.cgi?id=200362
3107
3108         Reviewed by Michael Saboff.
3109
3110         * Scripts/run-jsc-stress-tests:
3111
3112 2019-08-19  Zhifei Fang  <zhifei_fang@apple.com>
3113
3114         [results.webkit.org Timeline] Disable back gesture
3115         https://bugs.webkit.org/show_bug.cgi?id=200839
3116
3117         Reviewed by Jonathan Bedard.
3118
3119         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
3120         * resultsdbpy/resultsdbpy/view/templates/base.html:
3121
3122 2019-08-19  Jonathan Bedard  <jbedard@apple.com>
3123
3124         results-webkit.org: Add timeout to Redis locks
3125         https://bugs.webkit.org/show_bug.cgi?id=200890
3126
3127         Reviewed by Aakash Jain.
3128
3129         * resultsdbpy/resultsdbpy/model/upload_context.py:
3130         (UploadContext._find_job_with_attempts): Add timeout to Redis lock.
3131
3132 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
3133
3134         Remove IDB-specific quota
3135         https://bugs.webkit.org/show_bug.cgi?id=196545
3136         <rdar://problem/54201783>
3137
3138         Reviewed by Youenn Fablet.
3139
3140         * DumpRenderTree/TestRunner.cpp:
3141         (TestRunner::staticFunctions):
3142         (setIDBPerOriginQuotaCallback): Deleted.
3143         * DumpRenderTree/TestRunner.h:
3144         * DumpRenderTree/mac/DumpRenderTree.mm:
3145         (runTest):
3146         * DumpRenderTree/mac/TestRunnerMac.mm:
3147         (TestRunner::setIDBPerOriginQuota): Deleted.
3148         * DumpRenderTree/win/TestRunnerWin.cpp:
3149         (TestRunner::setIDBPerOriginQuota): Deleted.
3150         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3151         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3152         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
3153         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3154         * WebKitTestRunner/TestController.cpp:
3155         (WTR::TestController::resetStateToConsistentValues):
3156         (WTR::TestController::setIDBPerOriginQuota): Deleted.
3157         * WebKitTestRunner/TestController.h:
3158         * WebKitTestRunner/TestInvocation.cpp:
3159         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3160
3161 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
3162
3163         [WTF] Style checker should tell errors when it finds std::make_unique
3164         https://bugs.webkit.org/show_bug.cgi?id=200878
3165
3166         Reviewed by Ross Kirsling.
3167
3168         * Scripts/webkitpy/style/checkers/cpp.py:
3169         (check_wtf_make_unique):
3170         (check_style):
3171         (CppChecker):
3172
3173 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
3174
3175         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
3176         https://bugs.webkit.org/show_bug.cgi?id=200620
3177
3178         Reviewed by Geoffrey Garen.
3179
3180         * DumpRenderTree/TestRunner.cpp:
3181         (addURLToRedirectCallback):
3182         (setWillSendRequestClearHeaderCallback):
3183         (TestRunner::setAccummulateLogsForChannel):
3184         (TestRunner::runUIScript):
3185         (TestRunner::setOpenPanelFiles):
3186         * DumpRenderTree/mac/DumpRenderTree.mm:
3187         (dumpFramesAsText):
3188         * DumpRenderTree/mac/EventSendingController.mm:
3189         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
3190         * DumpRenderTree/win/DRTDataObject.cpp:
3191         (DRTDataObject::SetData):
3192         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3193         (FrameLoadDelegate::FrameLoadDelegate):
3194         * DumpRenderTree/win/UIDelegate.cpp:
3195         (DRTUndoManager::DRTUndoManager):
3196         (UIDelegate::UIDelegate):
3197         (UIDelegate::resetUndoManager):
3198         * TestWebKitAPI/JavaScriptTest.cpp:
3199         (TestWebKitAPI::runJSTest):
3200         * TestWebKitAPI/PlatformUtilities.cpp:
3201         (TestWebKitAPI::Util::toSTD):
3202         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3203         (TestWebKitAPI::TEST):
3204         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
3205         (TestWebKitAPI::TEST):
3206         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3207         (TestWebKitAPI::TEST):
3208         (TestWebKitAPI::testMovingUsingEnsure):
3209         (TestWebKitAPI::testMovingUsingAdd):
3210         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3211         (TestWebKitAPI::TEST):
3212         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3213         (TestWebKitAPI::TEST):
3214         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3215         (TestWebKitAPI::runLockTest):
3216         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3217         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3218         (TestWebKitAPI::TEST):
3219         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
3220         (TestWebKitAPI::TEST):
3221         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3222         (TestWebKitAPI::TEST):
3223         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3224         (TestWebKitAPI::TEST):
3225         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:
3226         (TestWebKitAPI::CARingBufferTest::SetUp):
3227         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3228         (TestWebKitAPI::createTestValue):
3229         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3230         (TestWebKitAPI::TEST):
3231         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3232         (TestWebKitAPI::TEST_F):
3233         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3234         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3235         (TestWebKitAPI::createNewPage):
3236         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3237         (TestWebKitAPI::createNewPage):
3238         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
3239         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
3240         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
3241         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
3242         (TestWebKitAPI::WebKit2WillLoadTest::SetUp):
3243         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3244         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3245         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3246         (serverCallback):
3247         (testWebViewAuthenticationProxyHTTPS):
3248         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
3249         (WebKitDOMDOMWindowTest::create):
3250         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
3251         (TestWebKitAPI::Util::toSTD):
3252         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3253         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
3254         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3255         * TestWebKitAPI/mac/TestFontOptions.mm:
3256         (-[TestFontOptions initWithFontOptions:]):
3257         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3258         (WTR::EventSendingController::callAfterScrollingCompletes):
3259         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3260         (WTR::InjectedBundle::didCreatePage):
3261         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3262         (WTR::TestRunner::setOpenPanelFiles):
3263         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3264         * WebKitTestRunner/StringFunctions.h:
3265         (WTR::toSTD):
3266         (WTR::toWTFString):
3267         * WebKitTestRunner/TestController.cpp:
3268         (WTR::TestController::initialize):
3269         (WTR::TestController::generatePageConfiguration):
3270         (WTR::TestController::resetStateToConsistentValues):
3271         (WTR::createTestURL):
3272         (WTR::TestController::runTest):
3273         (WTR::TestController::platformCreateWebView):
3274         * WebKitTestRunner/TestInvocation.cpp:
3275         (WTR::TestInvocation::runUISideScript):
3276         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3277         (WTR::TestController::platformCreateWebView):
3278         (WTR::TestController::setDefaultCalendarType):
3279         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3280         (WTR::getGDKKeySymForKeyRef):
3281         * WebKitTestRunner/ios/TestControllerIOS.mm:
3282         (WTR::TestController::platformResetStateToConsistentValues):
3283         (WTR::TestController::setKeyboardInputModeIdentifier):
3284         * WebKitTestRunner/mac/EventSenderProxy.mm:
3285         (WTR::EventSenderProxy::mouseDown):
3286         (WTR::EventSenderProxy::mouseUp):
3287         (WTR::EventSenderProxy::mouseMoveTo):
3288         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3289         (WTR::wpeKeySymForKeyRef):
3290
3291 2019-08-17  Ross Kirsling  <ross.kirsling@sony.com>
3292
3293         [ESNext] Implement optional chaining
3294         https://bugs.webkit.org/show_bug.cgi?id=200199
3295
3296         Reviewed by Yusuke Suzuki.
3297
3298         * Scripts/run-jsc-stress-tests:
3299
3300 2019-08-17  Tim Horton  <timothy_horton@apple.com>
3301
3302         Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
3303         https://bugs.webkit.org/show_bug.cgi?id=200866
3304         <rdar://problem/50254021>
3305
3306         Reviewed by Simon Fraser.
3307
3308         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3309         (WTR::PlatformWebView::windowSnapshotImage):
3310         Replace some logging with release assertions that we are snapshotting a reasonable
3311         view and get a reasonable snapshot back. Failing to snapshot is a big deal, and
3312         "silently" failing with just a log that will be ignored is not helpful.
3313
3314 2019-08-17  Yusuke Suzuki  <ysuzuki@apple.com>
3315
3316         [WTF] ThreadGroupRemove test is flaky
3317         https://bugs.webkit.org/show_bug.cgi?id=200763
3318
3319         Reviewed by Mark Lam.
3320
3321         ThreadGroup.ThreadGroupRemove test is flaky since its `threadRunning` modification and check in Thread are racy.
3322         It can lead to infinite wait on waitForCompletion. We should do more idiomatic to avoid race: When notifying condition
3323         variables, we should first take a lock, modify the condition shared and notify the condition change while taking a lock,
3324         and releasing the lock after that.
3325
3326         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
3327         (TestWebKitAPI::TEST):
3328
3329 2019-08-17  Eric Liang  <ericliang@apple.com>
3330
3331         Tested that accessibility WebProcessLoader bundle is loaded for the correct path.
3332         https://bugs.webkit.org/show_bug.cgi?id=200367
3333
3334         Reviewed by Darin Adler.
3335
3336         Added AccessibilityTestPlugin on the web process to report whether a bundle is loaded and its path, so that it can be tested on WKContentView. 
3337
3338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3339         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestPlugin.mm: Added.
3340         (-[AccessibilityTestPlugin webProcessPlugIn:didCreateBrowserContextController:]):
3341         (-[AccessibilityTestPlugin checkAccessibilityWebProcessLoaderBundleIsLoaded:]):
3342         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestSupportProtocol.h: Added.
3343         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3344         (TestWebKitAPI::TEST):
3345
3346 2019-08-17  Sam Weinig  <weinig@apple.com>
3347
3348         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
3349         https://bugs.webkit.org/show_bug.cgi?id=200756
3350
3351         Reviewed by Darin Adler.
3352
3353         Update call sites for rename from StringBuilder::flexibleAppend(...) to 
3354         StringBuilder::append(...).
3355
3356         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3357         (TestWebKitAPI::TEST):
3358
3359 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
3360
3361         [iOS WK2] Scroll indicators disappear sometimes
3362         https://bugs.webkit.org/show_bug.cgi?id=200791
3363
3364         Reviewed by Tim Horton.
3365
3366         Tests that test that scroll indicators survive subview replacement, and that
3367         a custom view also survives subview replacement.
3368
3369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3370         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
3371         (TestWebKitAPI::TEST):
3372         * TestWebKitAPI/cocoa/TestWKWebView.h:
3373         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3374         (-[TestWKWebView performAfterLoading:]):
3375         (-[UIView wkFirstSubviewWithClass:]):
3376         (-[UIView wkFirstSubviewWithBoundsSize:]):
3377         * TestWebKitAPI/ios/composited.html: Added.
3378         * TestWebKitAPI/ios/overflow-scroll.html: Added.
3379
3380 2019-08-16  John Wilander  <wilander@apple.com>
3381
3382         Add John Wilander as WebKit Reviewer
3383         https://bugs.webkit.org/show_bug.cgi?id=200837
3384
3385         Unreviewed update to contributors.json to change my status to reviewer.
3386         See email on reviewers mailing list for proof of granted privileges.
3387
3388         * Scripts/webkitpy/common/config/contributors.json:
3389
3390 2019-08-16  Timothy Hatcher  <timothy@apple.com>
3391
3392         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
3393         https://bugs.webkit.org/show_bug.cgi?id=200802
3394         rdar://problem/54357818
3395
3396         Reviewed by Tim Horton.
3397
3398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
3399         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
3400         (-[OpaqueTestWKWebView isOpaque]): Added.
3401         (-[NonOpaqueTestWKWebView isOpaque]): Added.
3402         (isOpaque): Added.
3403         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
3404         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
3405         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
3406
3407 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
3408
3409         [ews] Add build steps for Windows Factory
3410         https://bugs.webkit.org/show_bug.cgi?id=200813
3411
3412         Reviewed by Jonathan Bedard.
3413
3414         * BuildSlaveSupport/ews-build/factories.py:
3415         (WindowsFactory.__init__):
3416
3417 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
3418
3419         [ews] Report machine uptime in PrintConfiguration
3420         https://bugs.webkit.org/show_bug.cgi?id=200812
3421
3422         Reviewed by Jonathan Bedard.
3423
3424         * BuildSlaveSupport/ews-build/steps.py:
3425         (PrintConfiguration): Added uptime command.
3426         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3427
3428 2019-08-16  Chris Lord  <clord@igalia.com>
3429
3430         Add shared-mime-info to WPE WebKit jhbuild
3431         https://bugs.webkit.org/show_bug.cgi?id=200768
3432
3433         Reviewed by Carlos Alberto Lopez Perez.
3434
3435         * wpe/jhbuild.modules:
3436
3437 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
3438
3439         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
3440         https://bugs.webkit.org/show_bug.cgi?id=200620
3441
3442         Reviewed by Geoffrey Garen.
3443
3444         * DumpRenderTree/AccessibilityController.h:
3445         * DumpRenderTree/GCController.h:
3446         * DumpRenderTree/win/DRTDataObject.cpp:
3447         * DumpRenderTree/win/DRTDataObject.h:
3448         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3449         * DumpRenderTree/win/DRTDropSource.h:
3450         * DumpRenderTree/win/DraggingInfo.h:
3451         * DumpRenderTree/win/EditingDelegate.h:
3452         * DumpRenderTree/win/EventSender.cpp:
3453         * DumpRenderTree/win/FrameLoadDelegate.h:
3454         * DumpRenderTree/win/HistoryDelegate.h:
3455         * DumpRenderTree/win/MD5.h:
3456         * DumpRenderTree/win/PolicyDelegate.h:
3457         * DumpRenderTree/win/ResourceLoadDelegate.h:
3458         * DumpRenderTree/win/TextInputController.h:
3459         * DumpRenderTree/win/UIDelegate.cpp:
3460         * DumpRenderTree/win/UIDelegate.h:
3461         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3462         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
3463         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
3464         * TestWebKitAPI/Counters.h:
3465         * TestWebKitAPI/PlatformWebView.h:
3466         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3467         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3468         (TestWebKitAPI::DerefObserver::ref):
3469         (TestWebKitAPI::DerefObserver::deref):
3470         (TestWebKitAPI::TEST):
3471         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3472         (TestWebKitAPI::DerefObserver::ref):
3473         (TestWebKitAPI::DerefObserver::deref):
3474         (TestWebKitAPI::TEST):
3475         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3476         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3477         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3478         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3479         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3480         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
3481         * WebKitTestRunner/EventSenderProxy.h:
3482         * WebKitTestRunner/GeolocationProviderMock.h:
3483         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3484         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3485         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3486         * WebKitTestRunner/PlatformWebView.h:
3487         * WebKitTestRunner/TestInvocation.h:
3488
3489 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
3490
3491         Some improvements on web storage
3492         https://bugs.webkit.org/show_bug.cgi?id=200373
3493
3494         Reviewed by Geoffrey Garen.
3495
3496         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3497         (TEST): update expectation for behavior change.
3498
3499         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to 
3500         database file.
3501         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3502         (WTR::TestRunner::syncLocalStorage):
3503         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3504
3505         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
3506         (WTR::TestController::resetStateToConsistentValues):
3507         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
3508         (WTR::StorageVoidCallback):
3509         (WTR::TestController::clearIndexedDatabases):
3510         (WTR::TestController::clearLocalStorage):
3511         (WTR::TestController::syncLocalStorage):
3512         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
3513         with StorageVoidCallbackContext for general usage.
3514         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
3515         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
3516         * WebKitTestRunner/TestController.h:
3517
3518         * WebKitTestRunner/TestInvocation.cpp:
3519         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message 
3520         SyncLocalStorage.
3521
3522 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
3523
3524         results.webkit.org: Add content hook to FlaskRequestsResponse
3525         https://bugs.webkit.org/show_bug.cgi?id=200721
3526
3527         Rubber-stamped by Aakash Jain.
3528
3529         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
3530         (FlaskRequestsResponse):
3531         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
3532         Response, conforming to request's API.
3533
3534 2019-08-15  Alex Christensen  <achristensen@webkit.org>
3535
3536         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
3537         https://bugs.webkit.org/show_bug.cgi?id=200750
3538         <rdar://problem/54232261> and <rdar://problem/52355829>
3539
3540         Reviewed by Tim Horton.
3541
3542         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
3543         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
3544         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
3545         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
3546         (contextMenuWebViewDriver):
3547         (TEST):
3548
3549 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
3550
3551         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
3552         https://bugs.webkit.org/show_bug.cgi?id=200726
3553
3554         Reviewed by Simon Fraser.
3555
3556         To get the pixels as an array of colors, draw the image into a memory
3557         context. The backing memory buffer can then be accessed to get the image
3558         pixels' colors.
3559
3560         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3561         (TestWebKitAPI::TEST):
3562
3563 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
3564
3565         Unreviewed, rolling out r248526.
3566
3567         Caused two IndexedDB perf tests to fail
3568
3569         Reverted changeset:
3570
3571         "Remove IDB-specific quota"
3572         https://bugs.webkit.org/show_bug.cgi?id=196545
3573         https://trac.webkit.org/changeset/248526
3574
3575 2019-08-14  Keith Rollin  <krollin@apple.com>
3576
3577         Remove support for macOS < 10.13
3578         https://bugs.webkit.org/show_bug.cgi?id=200694
3579         <rdar://problem/54278851>
3580
3581         Reviewed by Youenn Fablet.
3582
3583         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
3584         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
3585         101300. This means that expressions like
3586         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
3587         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
3588
3589         * MiniBrowser/AppKitCompatibilityDeclarations.h: