AX: WKTR: Don't update isolated tree mode behavior if not required
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-26  Chris Fleizach  <cfleizach@apple.com>
2
3         AX: WKTR: Don't update isolated tree mode behavior if not required
4         https://bugs.webkit.org/show_bug.cgi?id=209555
5         <rdar://problem/60885094>
6
7         Reviewed by Darin Adler.
8
9         If the isolated tree mode has not changed, then we should not poke at the mechanisms for turning it on/off.
10         This might have the side effect of turning on accessibility unexpectedly.
11
12         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
13         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
14
15 2020-03-26  Philippe Normand  <pnormand@igalia.com>
16
17         [Flatpak SDK] Pass all the arguments of build-webkit to webkit-flatpak
18         https://bugs.webkit.org/show_bug.cgi?id=209558
19
20         Reviewed by Žan Doberšek.
21
22         When using flatpak some of the arguments we pass to build-webkit
23         are not meant to be used by that script but by webkit-flatpak. However we are
24         not passing all of them to webkit-flatpak but just the configuration ones
25         (port, release/debug...). This means that all the arguments that configure the
26         behaviour of webkit-flatpak are lost.
27
28         * Scripts/webkitdirs.pm:
29         (runInFlatpak): Filter-out Flatpak SDK-specific arguments to a
30         separate array, passed to webkit-flatpak.
31
32 2020-03-26  Commit Queue  <commit-queue@webkit.org>
33
34         Unreviewed, reverting r259035.
35         https://bugs.webkit.org/show_bug.cgi?id=209597
36
37         broke windows layout-tests (Requested by aakashjain on
38         #webkit).
39
40         Reverted changeset:
41
42         "[Win] lld-link: error: /manifestdependency: is not allowed in
43         .drectve"
44         https://bugs.webkit.org/show_bug.cgi?id=204831
45         https://trac.webkit.org/changeset/259035
46
47 2020-03-26  Philippe Normand  <pnormand@igalia.com>
48
49         [Flatpak SDK] update-webkitgtk-libs fails
50         https://bugs.webkit.org/show_bug.cgi?id=209546
51
52         Reviewed by Žan Doberšek.
53
54         Simplify the code a bit, add a `--assumeyes` argument to the
55         `flatpak update` command to make it non-interactive and improve
56         error handling/reporting a bit as well.
57
58         * flatpak/flatpakutils.py:
59         (FlatpakObject.flatpak):
60         (WebkitFlatpak.main):
61         (WebkitFlatpak.run):
62         (WebkitFlatpak.install_all):
63         (WebkitFlatpak.update_all): Deleted.
64
65 2020-03-26  Philippe Normand  <pnormand@igalia.com>
66
67         [Flatpak SDK] Crash post-mortem debugging is broken
68         https://bugs.webkit.org/show_bug.cgi?id=209537
69
70         Reviewed by Žan Doberšek.
71
72         webkit-flatpak --gdb now properly launches gdb to inspect the last
73         crash reported to coredumpctl. The -m argument can be used to
74         select another crash dump.
75
76         * flatpak/flatpakutils.py:
77         (WebkitFlatpak.clean_args):
78         (WebkitFlatpak.run_in_sandbox):
79         (WebkitFlatpak.run_gdb):
80
81 2020-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
82
83         [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
84         https://bugs.webkit.org/show_bug.cgi?id=204831
85
86         Reviewed by Ross Kirsling.
87
88         * TestWebKitAPI/win/main.cpp:
89         * win/DLLLauncher/DLLLauncherMain.cpp:
90
91 2020-03-25  Alexey Shvayka  <shvaikalesh@gmail.com>
92
93         Invalid numeric and named references should be early syntax errors
94         https://bugs.webkit.org/show_bug.cgi?id=178175
95
96         Reviewed by Ross Kirsling.
97
98         Removes FIXME as YarrParser is correct not to throw errors as it is
99         parsing in non-Unicode mode. Also adds a few named groups tests.
100
101         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
102
103 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
104
105         [Timeline] A better default get label function, which fit the assumpation the label is always a string
106         https://bugs.webkit.org/show_bug.cgi?id=209567
107
108         Reviewed by Jonathan Bedard.
109
110         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
111
112 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
113
114         [Timeline] Fix the out of bound dot index
115         https://bugs.webkit.org/show_bug.cgi?id=209492
116
117         Reviewed by Jonathan Bedard.
118
119         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
120         (Timeline.CanvasSeriesComponent):
121
122 2020-03-25  Daniel Bates  <dabates@apple.com>
123
124         Element context character rects may be in wrong coordinate system
125         https://bugs.webkit.org/show_bug.cgi?id=209493
126         <rdar://problem/60840261>
127
128         Reviewed by Wenson Hsieh.
129
130         Add some tests.
131
132         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
133         (TEST):
134
135 2020-03-25  Doug Kelly  <dougk@apple.com>
136
137         Unreviewed, add new committer to contributors.json
138
139         * Scripts/webkitpy/common/config/contributors.json:
140
141 2020-03-25  Frank Yang  <guowei_yang@apple.com>
142
143         Unprefix -webkit-text-orientation
144         https://bugs.webkit.org/show_bug.cgi?id=196139
145
146         Reviewed by Myles C. Maxfield.
147
148         This change is made to add the extra flag "related-property" in CSSProperty.json
149         in the jsonchecker so that the jsonchecker would not complain about unrecognized key
150
151         * Scripts/webkitpy/style/checkers/jsonchecker.py: added check for related-property
152         (JSONCSSPropertiesChecker.check_codegen_properties): 
153
154 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
155
156         [ews] commit-queue should comment on bug if it fails to find any modified ChangeLog
157         https://bugs.webkit.org/show_bug.cgi?id=209550
158
159         Reviewed by Jonathan Bedard.
160
161         * BuildSlaveSupport/ews-build/steps.py:
162         (FindModifiedChangeLogs): Set haltOnFailure to false.
163         (FindModifiedChangeLogs.getResultSummary):
164         (FindModifiedChangeLogs.evaluateCommand): Add build steps to comment on bug and set cq- on patch appropriately.
165         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
166
167 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
168
169         [ews] status-bubble should link to buildbot queue while waiting in queue
170         https://bugs.webkit.org/show_bug.cgi?id=209543
171
172         Reviewed by Jonathan Bedard.
173
174         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
175         (StatusBubble._build_bubble): Link to buildbot queue whil patch is waiting in queue.
176         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
177         (Buildbot.update_icons_for_queues_mapping): Generate the mapping for shortname to full queue name.
178
179 2020-03-25  Ting-Wei Lan  <lantw44@gmail.com>
180
181         [GTK] Add user agent quirk for auth.mayohr.com
182         https://bugs.webkit.org/show_bug.cgi?id=209378
183
184         Reviewed by Michael Catanzaro.
185
186         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
187         (TestWebKitAPI::assertUserAgentForURLHasNoSafariVersionQuirk):
188         (TestWebKitAPI::TEST):
189
190 2020-03-24  Daniel Bates  <dabates@apple.com>
191
192         Unreviewed, reverting r258945.
193
194         Revert change that broke API tests while I investigate
195         offline.
196
197         Reverted changeset:
198
199         "Element context character rects may be in wrong coordinate
200         system"
201         https://bugs.webkit.org/show_bug.cgi?id=209493
202         https://trac.webkit.org/changeset/258945
203
204 2020-03-24  Jiewen Tan  <jiewen_tan@apple.com>
205
206         Unreviewed, skips a test for iOS
207
208         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
209
210 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
211
212         results.webkit.org: Documentation for uncollapsed failure endpoints is wrong
213         https://bugs.webkit.org/show_bug.cgi?id=209496
214
215         Rubber-stamped by Aakash Jain.
216
217         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
218
219 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
220
221         results.webkit.org: Filter suite results by expectation by default
222         https://bugs.webkit.org/show_bug.cgi?id=209500
223
224         Rubber-stamped by Aakash Jain.
225
226         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Allow the Legend constructor
227         to set a willFilterExpected default.
228         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
229
230 2020-03-24  Per Arne Vollan  <pvollan@apple.com>
231
232         [Cocoa] Fix launch time regression with CF prefs direct mode enabled
233         https://bugs.webkit.org/show_bug.cgi?id=209244
234
235         Reviewed by Darin Adler.
236
237         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
238         (TEST):
239         (sharedInstanceMethodOverride):
240
241 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
242
243         results.webkit.org: Correct UUID capitalization in documentation
244         https://bugs.webkit.org/show_bug.cgi?id=209497
245
246         Reviewed by Aakash Jain.
247
248         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
249
250 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
251
252         [ews] commit-queue should comment on bug if it fails to create git commit
253         https://bugs.webkit.org/show_bug.cgi?id=209487
254
255         Reviewed by Jonathan Bedard.
256
257         * BuildSlaveSupport/ews-build/steps.py:
258         (CreateLocalGITCommit):
259         (CreateLocalGITCommit.start):
260         (CreateLocalGITCommit.evaluateCommand):
261         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
262
263 2020-03-24  Daniel Bates  <dabates@apple.com>
264
265         Element context character rects may be in wrong coordinate system
266         https://bugs.webkit.org/show_bug.cgi?id=209493
267         <rdar://problem/60840261>
268
269         Reviewed by Wenson Hsieh.
270
271         Add some tests.
272
273         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
274         (TEST):
275
276 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
277
278         [ews] position in queue shown in status-bubble is larger than actual position
279         https://bugs.webkit.org/show_bug.cgi?id=209481
280
281         Reviewed by Jonathan Bedard.
282
283         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
284         (StatusBubble._queue_position): Use created timestamp instead of modified.
285
286 2020-03-24  Daniel Bates  <dabates@apple.com>
287
288         [iOS][WK2] Set text trait isSingleLineDocument
289         https://bugs.webkit.org/show_bug.cgi?id=209391
290         <rdar://problem/60705870>
291
292         Reviewed by Darin Adler.
293
294         Add a test.
295
296         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
297         (TestWebKitAPI::TEST):
298         * TestWebKitAPI/ios/UIKitSPI.h: Expose more SPI.
299
300 2020-03-24  Alex Christensen  <achristensen@webkit.org>
301
302         Unreviewed, reverting r258862.
303
304         SPI was not what was needed
305
306         Reverted changeset:
307
308         "Add SPI to move localStorage to a different domain"
309         https://bugs.webkit.org/show_bug.cgi?id=209260
310         https://trac.webkit.org/changeset/258862
311
312 2020-03-24  Chris Lord  <clord@igalia.com>
313
314         [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working
315         https://bugs.webkit.org/show_bug.cgi?id=209478
316
317         Make sure *_PROCESS_CMD_PREFIX variables are whitelisted in the Flatpak sandbox.
318
319         Reviewed by Philippe Normand.
320
321         * flatpak/flatpakutils.py:
322         (WebkitFlatpak.run_in_sandbox):
323
324 2020-03-23  Simon Fraser  <simon.fraser@apple.com>
325
326         [mac-wk1] fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky timeout
327         https://bugs.webkit.org/show_bug.cgi?id=209427
328
329         Reviewed by Wenson Hsieh.
330         
331         0 => NULL
332
333         * DumpRenderTree/mac/DumpRenderTree.mm:
334         (invalidateAnyPreviousWaitToDumpWatchdog):
335
336 2020-03-23  Dean Jackson  <dino@apple.com>
337
338         webkitpy Git class must expose the repository URL
339         https://bugs.webkit.org/show_bug.cgi?id=209439
340         <rdar://problem/60792668>
341
342         Reviewed by Simon Fraser.
343
344         Some internal tools were relying on the svn_url() method
345         that was changed/removed in r258164. Add a replacement.
346
347         * Scripts/webkitpy/common/checkout/scm/git.py:
348         (Git.svn_repository_url):
349
350 2020-03-23  Alex Christensen  <achristensen@webkit.org>
351
352         Fix memory leak introduced in r257726
353         https://bugs.webkit.org/show_bug.cgi?id=208399
354
355         Reviewed by John Wilander.
356
357         * WebKitTestRunner/TestController.cpp:
358         (WTR::TestController::websiteDataStore):
359         We were leaking page configurations.
360
361 2020-03-23  John Wilander  <wilander@apple.com>
362
363         Add the capability to change all of a website's cookies to SameSite=Strict
364         https://bugs.webkit.org/show_bug.cgi?id=209369
365         <rdar://problem/60710690>
366
367         Reviewed by Alex Christensen and David Kilzer.
368
369         These changes add TestRunner function statisticsSetToSameSiteStrictCookies().
370
371         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
372         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
373         (WTR::InjectedBundle::didReceiveMessageToPage):
374         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
375         (WTR::TestRunner::statisticsSetToSameSiteStrictCookies):
376         (WTR::TestRunner::statisticsCallDidSetToSameSiteStrictCookiesCallback):
377         * WebKitTestRunner/InjectedBundle/TestRunner.h:
378         * WebKitTestRunner/TestController.cpp:
379         (WTR::TestController::setStatisticsToSameSiteStrictCookies):
380         * WebKitTestRunner/TestController.h:
381         * WebKitTestRunner/TestInvocation.cpp:
382         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
383         (WTR::TestInvocation::didSetToSameSiteStrictCookies):
384         * WebKitTestRunner/TestInvocation.h:
385
386 2020-03-23  Nikos Mouchtaris  <nmouchtaris@apple.com>
387
388         Uneviewed, added myself to contributors.json.
389
390         * Scripts/webkitpy/common/config/contributors.json:
391
392 2020-03-23  Daniel Bates  <dabates@apple.com>
393
394         Support inserting text or dictation alternative by simulating keyboard input
395         https://bugs.webkit.org/show_bug.cgi?id=209380
396         <rdar://problem/59445102>
397
398         Reviewed by Darin Adler.
399
400         Add tests to ensure that DOM events are dispatched on insertion when shouldSimulateKeyboardInput
401         is enabled.
402
403         I also added a convenience assertion function, EXPECT_NS_EQUAL, that can
404         compare NSObjects so long as they implement -isEqual and -description. I
405         make use of this to compare the actual array of fired DOM events types to
406         an expected array.
407
408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
409         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
410         (TestWebKitAPI::shouldSimulateKeyboardInputOnTextInsertionOverride):
411         (TestWebKitAPI::TEST):
412         * TestWebKitAPI/cocoa/TestCocoa.h:
413         (TestWebKitAPI::Util::assertNSObjectsAreEqual): Added.
414         (EXPECT_NS_EQUAL): Added.
415         * TestWebKitAPI/ios/insert-text.html: Added.
416
417 2020-03-23  Kate Cheney  <katherine_cheney@apple.com>
418
419         Add checks for app-bound navigations when evaluating user style sheets
420         https://bugs.webkit.org/show_bug.cgi?id=209368
421         <rdar://problem/60204230>
422
423         Reviewed by Brent Fulgham.
424
425         Tested cases based on those in UserContentController.mm.
426
427         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
428         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
429         (expectScriptEvaluatesToColor):
430         (TEST):
431
432
433 2020-03-23  Alex Christensen  <achristensen@webkit.org>
434
435         Add SPI to move localStorage to a different domain
436         https://bugs.webkit.org/show_bug.cgi?id=209260
437         <rdar://problem/60285683>
438
439         Reviewed by Brady Eidson.
440
441         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
442         (TEST):
443
444 2020-03-23  youenn fablet  <youenn@apple.com>
445
446         Disable TestWebKitAPI.ProcessSwap.GetUserMediaCaptureState if getUserMedia is not supported
447         https://bugs.webkit.org/show_bug.cgi?id=209428
448
449         Reviewed by Jonathan Bedard.
450
451         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
452
453 2020-03-23  Chris Lord  <clord@igalia.com>
454
455         Add missing committer status to Chris Lord in contributors.json
456
457         Unreviewed
458
459         * Scripts/webkitpy/common/config/contributors.json:
460
461 2020-03-23  youenn fablet  <youenn@apple.com>
462
463         StringView::startsWith and String::startsWith do not treat null strings the same
464         https://bugs.webkit.org/show_bug.cgi?id=209273
465
466         Reviewed by Darin Adler.
467
468         * TestWebKitAPI/Tests/WTF/StringView.cpp:
469         (TestWebKitAPI::TEST):
470         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
471         (TestWebKitAPI::TEST):
472
473 2020-03-22  Antoine Quint  <graouts@apple.com>
474
475         DocumentTimeline / CSSTransition objects are leaking on CNN.com
476         https://bugs.webkit.org/show_bug.cgi?id=208069
477         <rdar://problem/59680143>
478
479         Reviewed by Simon Fraser, Geoffrey Garen and Darin Adler.
480
481         Add a test that checks that a ListHashSet containing RefPtr<> types correctly calls the destructor for those items when the assignment operator is used.
482
483         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
484         (TestWebKitAPI::ListHashSetReferencedItem::create):
485         (TestWebKitAPI::ListHashSetReferencedItem::ListHashSetReferencedItem):
486         (TestWebKitAPI::ListHashSetReferencedItem::~ListHashSetReferencedItem):
487         (TestWebKitAPI::FakeElementAnimationRareData::FakeElementAnimationRareData):
488         (TestWebKitAPI::FakeElementAnimationRareData::~FakeElementAnimationRareData):
489         (TestWebKitAPI::FakeElementAnimationRareData::collection):
490         (TestWebKitAPI::FakeElementAnimationRareData::setCollection):
491         (TestWebKitAPI::TEST):
492
493 2020-03-21  Michael Catanzaro  <mcatanzaro@gnome.org>
494
495         [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
496         https://bugs.webkit.org/show_bug.cgi?id=208970
497
498         Reviewed by Konstantin Tokarev.
499
500         We are allowed to use /usr/bin/env in this script because it's not installed (so not
501         packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
502         case.
503
504         * gtkdoc/generate-gtkdoc:
505
506 2020-03-20  Jonathan Bedard  <jbedard@apple.com>
507
508         run-webkit-tests: Report MacCatalyst as a unique platform
509         https://bugs.webkit.org/show_bug.cgi?id=209361
510
511         Rubber-stamped by Aakash Jain.
512
513         * Scripts/webkitpy/port/mac.py:
514         (MacCatalystPort):
515         (MacCatalystPort.configuration_for_upload): Treat MacCatalyst as a separate platform from Mac.
516
517 2020-03-20  Alex Christensen  <achristensen@webkit.org>
518
519         CORS-disabling SPI introduced in r253978 should make responses non-opaque
520         https://bugs.webkit.org/show_bug.cgi?id=209351
521         <rdar://problem/60024850>
522
523         Reviewed by Chris Dumez.
524
525         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
526
527 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
528
529         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
530         https://bugs.webkit.org/show_bug.cgi?id=208938
531
532         Reviewed by Jonathan Bedard.
533
534         * BuildSlaveSupport/ews-build/steps.py:
535         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
536         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
537         (CheckPatchStatusOnEWSQueues.get_patch_status):
538         (CheckPatchStatusOnEWSQueues.start):
539         * BuildSlaveSupport/ews-build/steps_unittest.py:
540         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
541         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
542         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
543         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
544
545 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
546
547         [ews] Better organize patch status api data
548         https://bugs.webkit.org/show_bug.cgi?id=209342
549
550         Reviewed by Jonathan Bedard.
551
552         * BuildSlaveSupport/ews-app/ews/views/status.py:
553         (Status._build_status):
554         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
555         (Status.get): Remove safe=false now that we are returning a dictionary.
556
557 2020-03-20  Tim Horton  <timothy_horton@apple.com>
558
559         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
560         https://bugs.webkit.org/show_bug.cgi?id=209307
561
562         Reviewed by Andy Estes.
563
564         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
565
566 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
567
568         Unreviewed, reverting r258748.
569
570         This commit broke the Catalina build
571
572         Reverted changeset:
573
574         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
575         https://bugs.webkit.org/show_bug.cgi?id=209307
576         https://trac.webkit.org/changeset/258748
577
578 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
579
580         [ews] commit-queue should comment on bug if patch fails to apply
581         https://bugs.webkit.org/show_bug.cgi?id=209334
582
583         Reviewed by Jonathan Bedard.
584
585         * BuildSlaveSupport/ews-build/steps.py:
586         (ApplyPatch):
587         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
588         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
589         (TestApplyPatch):
590         (TestApplyPatch.setUp):
591         (TestApplyPatch.setUp.mock_start):
592         (TestApplyPatch.tearDown):
593         (TestApplyPatch.test_success):
594         (TestApplyPatch.test_failure):
595         (TestApplyPatch.test_failure_on_commit_queue):
596
597 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
598
599         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
600         https://bugs.webkit.org/show_bug.cgi?id=209122
601
602         Reviewed by Jonathan Bedard.
603
604         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
605         (StatusBubble._build_bubble):
606
607 2020-03-19  Tim Horton  <timothy_horton@apple.com>
608
609         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
610         https://bugs.webkit.org/show_bug.cgi?id=209307
611
612         Reviewed by Andy Estes.
613
614         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
615
616 2020-03-19  Alex Christensen  <achristensen@webkit.org>
617
618         Remove test failing after r258734
619         https://bugs.webkit.org/show_bug.cgi?id=209303
620
621         We removed the functionality it was testing because it did nothing useful except call the callback.
622         I'm about to remove the only user of WKContextGetStatistics.
623
624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
625         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
626
627 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
628
629         commit-queue status-bubble shows incorrect position in queue
630         https://bugs.webkit.org/show_bug.cgi?id=209313
631
632         Reviewed by Jonathan Bedard.
633
634         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
635         (StatusBubble._queue_position):
636
637 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
638
639         [Curl] Add an API returns description of verification errors.
640         https://bugs.webkit.org/show_bug.cgi?id=208913
641
642         Reviewed by Fujii Hironori.
643
644         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
645         Browser can display more precise error information with this API.
646
647         API Test: Curl.CertificateAPI
648
649         * MiniBrowser/win/Common.cpp:
650         (askServerTrustEvaluation):
651         * MiniBrowser/win/Common.h:
652         * MiniBrowser/win/WebKitBrowserWindow.cpp:
653         (createPEMString):
654         (WebKitBrowserWindow::canTrustServerCertificate):
655         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
656         (TestWebKitAPI::Curl::TEST):
657
658 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
659
660         Update build.webkit.org link for EWS
661         https://bugs.webkit.org/show_bug.cgi?id=209280
662
663         Reviewed by Alexey Proskuryakov.
664
665         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
666
667 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
668
669         [WinCairo] extract-built-product fails after r258612
670         https://bugs.webkit.org/show_bug.cgi?id=209285
671
672         extractBuiltProduct also references the old name for the
673         requirements on wincairo.
674
675         Reviewed by Ross Kirsling.
676
677         * BuildSlaveSupport/built-product-archive:
678
679 2020-03-19  Philippe Normand  <pnormand@igalia.com>
680
681         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
682         https://bugs.webkit.org/show_bug.cgi?id=209223
683
684         Reviewed by Carlos Alberto Lopez Perez.
685
686         flatpak build doesn't expose a --socket option for white-listing
687         the systemd journal socket. So white-list everything in /run. 🤷
688
689         * flatpak/flatpakutils.py:
690         (WebkitFlatpak.run_in_sandbox):
691
692 2020-03-19  Charlie Turner  <cturner@igalia.com>
693
694         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
695         https://bugs.webkit.org/show_bug.cgi?id=209146
696
697         Reviewed by Darin Adler.
698
699         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
700         (TestWebKitAPI::TEST):
701         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
702         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
703         (testDownloadMIMEType):
704         (testContextMenuDownloadActions):
705         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
706
707 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
708
709         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
710         https://bugs.webkit.org/show_bug.cgi?id=209278
711
712         Reviewed by Philippe Normand.
713
714         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
715         means flatpak.
716
717         * Scripts/webkitdirs.pm:
718         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
719
720 2020-03-19  Philippe Normand  <pnormand@igalia.com>
721
722         [CMake] cache not cleared when build-webkit options change
723         https://bugs.webkit.org/show_bug.cgi?id=209277
724
725         Reviewed by Adrian Perez de Castro.
726
727         * Scripts/webkitdirs.pm:
728         (shouldRemoveCMakeCache): The expected function signature never
729         included the cache file path. Remove it.
730
731 2020-03-18  Philippe Normand  <pnormand@igalia.com>
732
733         REGRESSION(r258626): webkit-dirs warning
734         https://bugs.webkit.org/show_bug.cgi?id=209221
735
736         Reviewed by Adrian Perez de Castro.
737
738         * Scripts/webkitdirs.pm:
739         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
740
741 2020-03-19  Chris Lord  <clord@igalia.com>
742
743         Add Chris Lord (clord@igalia.com) to the list of contributors
744         https://bugs.webkit.org/show_bug.cgi?id=209274
745
746         Unreviewed
747
748         * Scripts/webkitpy/common/config/contributors.json:
749
750 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
751
752         Remove commit queue bubble from bot watchers dashboard
753         https://bugs.webkit.org/show_bug.cgi?id=209271
754
755         Reviewed by Alexey Proskuryakov.
756
757         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
758
759         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
760         (BubbleQueueServer): 
761
762 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
763
764         eventSender.monitorWheelEvents() is very fragile
765         https://bugs.webkit.org/show_bug.cgi?id=197819
766         <rdar://problem/51319456>
767
768         Reviewed by Tim Horton.
769
770         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
771         adding back changes from r257844 that were reverted in r258558.
772         
773         First, have EventSendingController keep track of whether it's seen then "end" event
774         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
775         now waits until it sees these, which prevents premature triggering which was a common cause of
776         failure before.
777         
778         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
779         for completion in a callout from the end of Page::updateRendering(), which makes it test
780         and fire at a more consistent time.
781         
782         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
783         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
784         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
785         also resulting in a premature trigger.
786
787         * DumpRenderTree/mac/EventSendingController.h:
788         * DumpRenderTree/mac/EventSendingController.mm:
789         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
790         (-[EventSendingController monitorWheelEvents]):
791         (-[EventSendingController callAfterScrollingCompletes:]):
792         * DumpRenderTree/win/EventSender.cpp:
793         (mouseScrollBy):
794         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
795         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
796         (WTR::EventSendingController::monitorWheelEvents):
797         (WTR::EventSendingController::callAfterScrollingCompletes):
798         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
799
800 2020-03-18  John Wilander  <wilander@apple.com>
801
802         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
803         https://bugs.webkit.org/show_bug.cgi?id=209245
804         <rdar://problem/60511121>
805
806         Reviewed by Chris Dumez.
807
808         These changes to the TestRunner makes sure that
809         - statisticsClearInMemoryAndPersistentStore()
810         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
811         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
812         and adds the infrastructure for that.
813
814         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
815         (WTR::InjectedBundle::didReceiveMessageToPage):
816         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
817         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
818         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
819         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
820         * WebKitTestRunner/InjectedBundle/TestRunner.h:
821         * WebKitTestRunner/TestController.cpp:
822         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
823         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
824         * WebKitTestRunner/TestInvocation.cpp:
825         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
826         * WebKitTestRunner/TestInvocation.h:
827
828 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
829
830         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
831         https://bugs.webkit.org/show_bug.cgi?id=209218
832         <rdar://problem/60560831>
833
834         Reviewed by Tim Horton.
835
836         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
837         those views must be parented (i.e. they must be connected to a UIWindow).
838
839         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
840         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
841         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
842         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
843
844 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
845
846         [ews] commit-queue should comment on bug in case of test failures
847         https://bugs.webkit.org/show_bug.cgi?id=209226
848
849         Reviewed by Jonathan Bedard.
850
851         * BuildSlaveSupport/ews-build/steps.py:
852         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
853         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
854         (SetBuildSummary): Ditto.
855         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
856
857 2020-03-18  Philippe Normand  <pnormand@igalia.com>
858
859         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
860         https://bugs.webkit.org/show_bug.cgi?id=209238
861
862         Reviewed by Jonathan Bedard.
863
864         * Scripts/test262-runner: Perform the flatpak check on Linux only.
865
866 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
867
868         [WinCairo] archive-built-product fails after r258612
869         https://bugs.webkit.org/show_bug.cgi?id=209237
870
871         Reviewed by Alex Christensen.
872
873         * BuildSlaveSupport/built-product-archive:
874         Update name of version file for requirements version
875         file for wincairo.
876
877 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
878
879         commit-queue should allow patches which are reviewed by patch author
880         https://bugs.webkit.org/show_bug.cgi?id=209231
881
882         Reviewed by Jonathan Bedard.
883
884         * BuildSlaveSupport/ews-build/steps.py:
885         (BugzillaMixin._does_patch_have_acceptable_review_flag):
886
887 2020-03-18  Philippe Normand  <pnormand@igalia.com>
888
889         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
890         https://bugs.webkit.org/show_bug.cgi?id=209222
891
892         Reviewed by Carlos Alberto Lopez Perez.
893
894         * Scripts/webkitdirs.pm:
895         (runInFlatpakIfAvailable): If a command wrapper is required it
896         means Flatpak shouldn't be used.
897
898 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
899
900         [ews] commit-queue should comment on bug in case patch fails to build
901         https://bugs.webkit.org/show_bug.cgi?id=209227
902
903         Reviewed by Jonathan Bedard.
904
905         * BuildSlaveSupport/ews-build/steps.py:
906         (AnalyzeCompileWebKitResults.start):
907         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
908
909 2020-03-18  Philippe Normand  <pnormand@igalia.com>
910
911         [GTK][WPE] Migrate to Flatpak-based dev SDK
912         https://bugs.webkit.org/show_bug.cgi?id=205658
913
914         Reviewed by Carlos Alberto Lopez Perez.
915
916         JHBuild will now be used only if the WEBKIT_JHBUILD environment
917         variable is set to 1, which is the case for the time being on the
918         GTK and WPE EWS/build bots.
919
920         By default the build dependencies are now locally installed from a
921         Flatpak repository hosted at https://software.igalia.com. The
922         repository can be regenerated with the scripts from the
923         webkit-flatpak-sdk Github project
924         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
925         transparently with the update-webkit{gtk,wpe}-libs scripts. As
926         there is no need to rebuild the dependencies from scratch, the
927         developer user-experience should now be much more friendly and
928         overall build times reduced.
929
930         As an additional commodity, the new environment supports the
931         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
932         environment variable to your gst-build path. This feature was
933         contributed by Thibault Saunier.
934
935         The JHBuild infrastructure will be removed once all the bots have
936         been switched over to Flatpak.
937
938         * BuildSlaveSupport/ews-build/steps.py:
939         (InstallGtkDependencies):
940         (InstallWpeDependencies):
941         (CompileWebKit.start):
942         * BuildSlaveSupport/gtk/buildbot/run:
943         * Scripts/build-webkit:
944         * Scripts/run-bindings-tests:
945         * Scripts/run-builtins-generator-tests:
946         * Scripts/run-gtk-tests:
947         * Scripts/run-javascriptcore-tests:
948         * Scripts/run-minibrowser:
949         * Scripts/run-qt-wpe-minibrowser:
950         * Scripts/run-webdriver-tests:
951         * Scripts/run-wpe-tests:
952         * Scripts/test-webkitperl:
953         * Scripts/test-webkitpy:
954         * Scripts/test262-runner:
955         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
956         * Scripts/update-webkitgtk-libs:
957         * Scripts/update-webkitwpe-flatpak: Removed.
958         * Scripts/update-webkitwpe-libs:
959         * Scripts/webkitdirs.pm:
960         (getUserFlatpakPath):
961         (inFlatpakSandbox):
962         (runInFlatpakIfAvailable):
963         (wrapperPrefixIfNeeded):
964         (shouldUseJhbuild):
965         (shouldUseFlatpak):
966         (shouldRemoveCMakeCache):
967         * Scripts/webkitpy/common/system/executive.py:
968         (Executive.kill_all):
969         * Scripts/webkitpy/port/base.py:
970         (Port._path_to_apache):
971         (Port._should_run_as_pixel_test):
972         (Port._in_flatpak_sandbox):
973         * Scripts/webkitpy/port/gtk.py:
974         (GtkPort.setup_environ_for_server):
975         (GtkPort._get_crash_log):
976         * Scripts/webkitpy/port/linux_get_crash_log.py:
977         (GDBCrashLogGenerator):
978         (GDBCrashLogGenerator.__init__):
979         (GDBCrashLogGenerator.generate_crash_log):
980         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
981         (GDBCrashLogGeneratorTest.test_generate_crash_log):
982         * Scripts/webkitpy/port/wpe.py:
983         (WPEPort.setup_environ_for_server):
984         (WPEPort._get_crash_log):
985         * Scripts/webkitpy/port/xvfbdriver.py:
986         (XvfbDriver._setup_environ_for_test):
987         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
988         (WTR::getFontsPath):
989         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
990         (WTR::getFontsPath):
991         * flatpak/files/default.xkm: Removed.
992         * flatpak/files/httpd-autogen.sh: Removed.
993         * flatpak/flatpakutils.py:
994         (check_flatpak):
995         (FlatpakRepos.update):
996         (FlatpakPackage.__repr__):
997         (FlatpakPackage.__str__):
998         (WebkitFlatpak.load_from_args):
999         (WebkitFlatpak.__init__):
1000         (WebkitFlatpak.clean_args):
1001         (WebkitFlatpak.setup_builddir):
1002         (WebkitFlatpak):
1003         (WebkitFlatpak.setup_gstbuild):
1004         (WebkitFlatpak.run_in_sandbox):
1005         (WebkitFlatpak.run):
1006         (WebkitFlatpak.has_environment):
1007         (WebkitFlatpak.save_config):
1008         (WebkitFlatpak.setup_dev_env):
1009         (WebkitFlatpak.install_all):
1010         (WebkitFlatpak.run_gdb):
1011         * flatpak/org.webkit.CommonModules.yaml: Removed.
1012         * flatpak/org.webkit.GTK.yaml: Removed.
1013         * flatpak/org.webkit.WPE.yaml: Removed.
1014         * flatpak/org.webkit.WPEModules.yaml: Removed.
1015         * flatpak/org.webkit.WPEQT.yaml: Removed.
1016         * flatpak/org.webkit.WebKit.yaml: Removed.
1017         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
1018         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
1019         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
1020
1021 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
1022
1023         Expand In-App-Browser-Privacy testing
1024         https://bugs.webkit.org/show_bug.cgi?id=209142
1025         <rdar://problem/60496618>
1026
1027         Reviewed by Darin Adler.
1028
1029         Expanded test coverage by adding new tests and creating a custom url
1030         scheme handler to get around the fact that local file loads are
1031         always classified as app-bound.
1032
1033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1034         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1035         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
1036         If the path indicates testing user scripts on load, notify the script message
1037         handler that the navigation has finished. If the path indicates
1038         testing user-agent scripts, set the window.wkUserScriptInjected
1039         variable to true. A user agent script will attempt to read this
1040         variable and should fail.
1041
1042         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
1043         (initializeInAppBrowserPrivacyTestSettings):
1044         Basic test setup. Initialize the main run loop and make sure we are
1045         starting with a clean state.
1046
1047         (TEST):
1048         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
1049         except for blob files which must be generated within the web content.
1050
1051         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
1052         Basic html document to test local file loads are classified as
1053         app-bound.
1054
1055         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
1056         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
1057         These files are no longer needed as their content is directly copied
1058         into the URL scheme handler.
1059
1060 2020-03-17  Chris Dumez  <cdumez@apple.com>
1061
1062         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
1063         https://bugs.webkit.org/show_bug.cgi?id=207307
1064         <rdar://problem/59206964>
1065
1066         Reviewed by Alex Christensen.
1067
1068         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
1069         notifications from the map but not tell WebCore that the notification were discarded. As a result,
1070         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
1071         notification would no longer be in the map, causing us to hit an assertion in debug.
1072
1073         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
1074         to let WebCore know the notification was discarded. This is similar to what is already done for
1075         WebKit2 in WebNotificationManager::clearNotifications().
1076
1077         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1078         (-[MockWebNotificationProvider reset]):
1079
1080 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
1081
1082         [WinCairo][FTW] Update path to requirements download
1083         https://bugs.webkit.org/show_bug.cgi?id=209202
1084
1085         Reviewed by Ross Kirsling.
1086
1087         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
1088         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
1089         WebKitRequirementsWin64.zip.
1090
1091         * Scripts/update-webkit-wincairo-libs.py:
1092
1093 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
1094
1095         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
1096         https://bugs.webkit.org/show_bug.cgi?id=208920
1097
1098         Reviewed by Jonathan Bedard.
1099
1100         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1101         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
1102         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
1103         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
1104         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1105         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
1106         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1107         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
1108         for commit-queue which isn't expected to change.
1109         (BugzillaPatchFetcher.fetch_commit_queue_patches):
1110         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
1111         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
1112         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
1113         setting cq+ flag on bugzilla.
1114
1115 2020-03-17  Chris Dumez  <cdumez@apple.com>
1116
1117         [WKTR] testRunner API that takes in a completion handler should use async IPC
1118         https://bugs.webkit.org/show_bug.cgi?id=209187
1119
1120         Reviewed by John Wilander.
1121
1122         testRunner API that takes in a completion handler should use async IPC. This hangs
1123         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
1124         to IPC the WebProcess as a result of this testRunner call.
1125
1126         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1127         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1128         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1129         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1130         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1131         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1132         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
1133         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
1134         (WTR::TestRunner::statisticsResetToConsistentState):
1135         (WTR::TestRunner::getAllStorageAccessEntries):
1136         (WTR::TestRunner::removeAllSessionCredentials):
1137         (WTR::TestRunner::getApplicationManifestThen):
1138         * WebKitTestRunner/TestInvocation.cpp:
1139         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1140         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1141
1142 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
1143
1144         [ews-app] Timestamp shown in status-bubble hover-over message is in future
1145         https://bugs.webkit.org/show_bug.cgi?id=196628
1146
1147         Reviewed by Jonathan Bedard.
1148
1149         * BuildSlaveSupport/ews-build/events.py:
1150         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
1151         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1152         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
1153         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
1154
1155 2020-03-17  Alex Christensen  <achristensen@webkit.org>
1156
1157         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
1158         https://bugs.webkit.org/show_bug.cgi?id=209192
1159         <rdar://problem/51313336>
1160
1161         Reviewed by Geoff Garen.
1162
1163         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1164         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
1165         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
1166         (TEST):
1167
1168 2020-03-17  Chris Dumez  <cdumez@apple.com>
1169
1170         Use less sync IPC for ITP testRunner methods
1171         https://bugs.webkit.org/show_bug.cgi?id=209184
1172
1173         Reviewed by Alex Christensen.
1174
1175         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1176         (WTR::TestRunner::setStatisticsDebugMode):
1177         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1178         (WTR::TestRunner::setStatisticsLastSeen):
1179         (WTR::TestRunner::setStatisticsMergeStatistic):
1180         (WTR::TestRunner::setStatisticsPrevalentResource):
1181         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1182         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1183         * WebKitTestRunner/TestInvocation.cpp:
1184         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1185         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1186
1187 2020-03-17  Chris Dumez  <cdumez@apple.com>
1188
1189         [WKTR] Crash when trying to open a new window in an ephemeral session test
1190         https://bugs.webkit.org/show_bug.cgi?id=209181
1191
1192         Reviewed by Geoffrey Garen.
1193
1194         Make sure that the new WKWebView is using the same data store as its related WKWebView.
1195
1196         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1197         (WTR::TestController::platformCreateOtherPage):
1198
1199 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
1200
1201         Unreviewed, reverting r257844.
1202
1203         this revision caused a test to start timing out
1204
1205         Reverted changeset:
1206
1207         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
1208         zero.html is a flaky failure"
1209         https://bugs.webkit.org/show_bug.cgi?id=207948
1210         https://trac.webkit.org/changeset/257844
1211
1212 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
1213
1214         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
1215         https://bugs.webkit.org/show_bug.cgi?id=209151
1216
1217         Reviewed by Yusuke Suzuki.
1218
1219         * Scripts/webkitpy/common/config/contributors.json:
1220
1221 2020-03-16  Chris Dumez  <cdumez@apple.com>
1222
1223         Crash under WebCookieCache::clearForHost()
1224         https://bugs.webkit.org/show_bug.cgi?id=209149
1225         <rdar://problem/60453086>
1226
1227         Reviewed by Alex Christensen.
1228
1229         Add API test coverage.
1230
1231         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
1232         (TEST):
1233
1234 2020-03-16  Keith Rollin  <krollin@apple.com>
1235
1236         Remove support for WebKitSystemInterface
1237         https://bugs.webkit.org/show_bug.cgi?id=208894
1238         <rdar://problem/60297590>
1239
1240         Reviewed by Brent Fulgham.
1241
1242         This project provided support for facilities that are now handled
1243         elsewhere and is no longer needed.
1244
1245         * Scripts/copy-webkitlibraries-to-product-directory:
1246
1247 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
1248
1249         [macOS] Accessibility sandbox regressions
1250         https://bugs.webkit.org/show_bug.cgi?id=209065
1251
1252         Reviewed by Brent Fulgham.
1253
1254         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
1255         (TEST):
1256         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
1257         (TEST):
1258
1259 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
1260
1261         Unreviewed infrastructure fix.
1262
1263         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
1264         while the hardware is out for repair.
1265
1266 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
1267
1268         [WebXR] IDLs, stubs and build configuration for WPE
1269         https://bugs.webkit.org/show_bug.cgi?id=208702
1270
1271         Reviewed by Dean Jackson.
1272
1273         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
1274         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
1275
1276 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
1277
1278         [Cocoa] Limit set of classes that can be decoded when a preference has changed
1279         https://bugs.webkit.org/show_bug.cgi?id=208012
1280
1281         Reviewed by Brent Fulgham.
1282
1283         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
1284         (TEST):
1285
1286 2020-03-16  youenn fablet  <youenn@apple.com>
1287
1288         Unique origins should not be Potentially Trustworthy
1289         https://bugs.webkit.org/show_bug.cgi?id=209049
1290
1291         Reviewed by Darin Adler.
1292
1293         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1294         (TestWebKitAPI::TEST_F):
1295
1296 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1297
1298         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
1299         https://bugs.webkit.org/show_bug.cgi?id=207324
1300
1301         Reviewed by Darin Adler.
1302
1303         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
1304         (TestWebKitAPI::generateRandomData): Added.
1305         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
1306
1307 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
1308
1309         Should not use variable-length-array (VLA)
1310         https://bugs.webkit.org/show_bug.cgi?id=209043
1311
1312         Reviewed by Mark Lam.
1313
1314         * ContentExtensionTester/Configurations/Base.xcconfig:
1315         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1316
1317 2020-03-13  Alex Christensen  <achristensen@webkit.org>
1318
1319         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
1320         https://bugs.webkit.org/show_bug.cgi?id=209011
1321         <rdar://problem/59370588>
1322
1323         Reviewed by Youenn Fablet.
1324
1325         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1326         (TestWebKitAPI::TEST):
1327
1328 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1329
1330         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
1331         https://bugs.webkit.org/show_bug.cgi?id=209089
1332
1333         Reviewed by Tim Horton.
1334
1335         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
1336         marketing name for the feature.
1337
1338         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1339         (runUntilReceivesAutoplayEvent):
1340
1341         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
1342         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
1343         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
1344         be any compelling reason to compare against different types here (especially since we only set
1345         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
1346         these all to be `_WKAutoplayEvent`.
1347
1348         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1349         (-[AutoFillTestView _autofillInputView]):
1350         (-[AutoFillTestView textInputHasAutoFillContext]):
1351         (TestWebKitAPI::TEST):
1352         (-[AutofillTestView initWithFrame:]): Deleted.
1353         (-[AutofillTestView _autofillInputView]): Deleted.
1354         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
1355         * TestWebKitAPI/ios/UIKitSPI.h:
1356
1357 2020-03-13  Chris Dumez  <cdumez@apple.com>
1358
1359         Unreviewed, reverting r256232.
1360
1361         Caused ResizeObserver tests to become flaky
1362
1363         Reverted changeset:
1364
1365         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
1366         override TestOptions"
1367         https://bugs.webkit.org/show_bug.cgi?id=207481
1368         https://trac.webkit.org/changeset/256232
1369
1370 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1371
1372         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
1373         https://bugs.webkit.org/show_bug.cgi?id=209016
1374         <rdar://problem/60329530> 
1375
1376         Reviewed by Chris Dumez.
1377
1378         Re-initialize the app-bound domains when the correct
1379         TestOptions parameter is set.
1380
1381         * WebKitTestRunner/TestController.cpp:
1382         (WTR::TestController::createWebViewWithOptions):
1383         (WTR::TestController::reinitializeAppBoundDomains):
1384         * WebKitTestRunner/TestController.h:
1385
1386 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1387
1388         Report all third party loads on a per-page basis
1389         https://bugs.webkit.org/show_bug.cgi?id=209032
1390         <rdar://problem/60397323>
1391
1392         Reviewed by Chris Dumez.
1393
1394         Mostly naming updates to reflect the change in use for this SPI call.
1395         It now returns all loaded third party domains, not just prevalent ones.
1396
1397         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1398         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1399         (WTR::InjectedBundle::didReceiveMessageToPage):
1400         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1401         (WTR::TestRunner::getLoadedThirdPartyDomains):
1402         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
1403         (WTR::TestRunner::getPrevalentDomains): Deleted.
1404         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
1405         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1406         * WebKitTestRunner/TestController.cpp:
1407         (WTR::TestController::resetStateToConsistentValues):
1408         (WTR::TestController::getLoadedThirdPartyDomains):
1409         (WTR::TestController::clearLoadedThirdPartyDomains):
1410         (WTR::TestController::getPrevalentDomains): Deleted.
1411         (WTR::TestController::clearPrevalentDomains): Deleted.
1412         * WebKitTestRunner/TestController.h:
1413         * WebKitTestRunner/TestInvocation.cpp:
1414         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1415         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
1416         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
1417         * WebKitTestRunner/TestInvocation.h:
1418         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1419         (WTR::TestController::getLoadedThirdPartyDomains):
1420         (WTR::TestController::clearLoadedThirdPartyDomains):
1421         (WTR::TestController::getPrevalentDomains): Deleted.
1422         (WTR::TestController::clearPrevalentDomains): Deleted.
1423
1424 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1425
1426         [ews] run FindModifiedChangeLogs early in the build
1427         https://bugs.webkit.org/show_bug.cgi?id=209060
1428
1429         Reviewed by Jonathan Bedard.
1430
1431         * BuildSlaveSupport/ews-build/factories.py:
1432         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
1433
1434 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
1435
1436         [GTK] Add EWS testers to run GTK layout tests
1437         https://bugs.webkit.org/show_bug.cgi?id=207648
1438
1439         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
1440
1441         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
1442         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
1443         tests (layout tests).
1444
1445         * BuildSlaveSupport/ews-build/config.json: Added new queue for
1446         WK2 tests.
1447         * BuildSlaveSupport/ews-build/factories.py:
1448         (GTKTestsFactory):
1449         * BuildSlaveSupport/ews-build/factories_unittest.py:
1450         (TestCommitQueueFactory.test_commit_queue_factory):
1451         (TestGTKFactory): Added unit-test.
1452         (TestGTKFactory.test_gtk_factory):
1453         * BuildSlaveSupport/ews-build/loadConfig.py:
1454         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1455         (TagsForBuilderTest.test_getTagsForBuilder):
1456
1457 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1458
1459         Add API endpoint in EWS django app to provide patch status in json format
1460         https://bugs.webkit.org/show_bug.cgi?id=208940
1461
1462         Reviewed by Jonathan Bedard.
1463
1464         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
1465         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
1466
1467 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1468
1469         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
1470         https://bugs.webkit.org/show_bug.cgi?id=209055
1471         <rdar://problem/60272692>
1472
1473         Reviewed by Simon Fraser.
1474
1475         Now that WebKitTestRunner has a bundleID, its' user default values
1476         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
1477         to NO before running tests. It will be set to YES in PlatformWebView
1478         if specified by the test.
1479
1480         * WebKitTestRunner/mac/main.mm:
1481         (setDefaultsToConsistentValuesForTesting):
1482
1483 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
1484
1485         [CMake] Eleminate mismatches between Find* module names and variables they set
1486         https://bugs.webkit.org/show_bug.cgi?id=208948
1487
1488         Reviewed by Michael Catanzaro.
1489
1490         * wpe/backends/CMakeLists.txt:
1491
1492 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1493
1494         [ews-app] reduce logging
1495         https://bugs.webkit.org/show_bug.cgi?id=209062
1496
1497         Reviewed by Jonathan Bedard.
1498
1499         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1500         (BugzillaBeautifulSoup.authenticate):
1501         (BugzillaBeautifulSoup._load_query):
1502
1503 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
1504
1505         Crash in TextIterator::node via TextManipulationController::replace
1506         https://bugs.webkit.org/show_bug.cgi?id=209048
1507
1508         Reviewed by Wenson Hsieh.
1509
1510         Added a regression test.
1511
1512         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1513         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
1514
1515 2020-03-13  Saam Barati  <sbarati@apple.com>
1516
1517         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
1518         https://bugs.webkit.org/show_bug.cgi?id=209038
1519
1520         Reviewed by Keith Miller.
1521
1522         This allows us to automatically pull in some tests that are in non open sourced Apple
1523         checkouts.
1524
1525         * Scripts/run-javascriptcore-tests:
1526         (runJSCStressTests):
1527
1528 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
1529
1530         Crash in TextManipulationController::replace
1531         https://bugs.webkit.org/show_bug.cgi?id=209021
1532
1533         Reviewed by Wenson Hsieh.
1534
1535         Added a regression test.
1536
1537         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1538         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
1539
1540 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
1541
1542         [macOS] _AXSApplicationAccessibilityEnabled should not be called
1543         https://bugs.webkit.org/show_bug.cgi?id=208953
1544
1545         Reviewed by Brent Fulgham.
1546
1547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1548
1549 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
1550
1551         Resource load statistics data summary should return all third party data
1552         https://bugs.webkit.org/show_bug.cgi?id=209000
1553         <rdar://problem/60348306>
1554
1555         Reviewed by John Wilander.
1556
1557         Marked only 2 of 3 domains prevalent in data summary tests to ensure
1558         the call returns all third parties, not just prevalent ones.
1559         Added a more aggressive check for the size of the array at the
1560         beginning of the test to ensure the array is still returning 3 values. 
1561         Also removed the ASSERT statements as they seem to cause timeouts (not
1562         clear crashes) when they are not true, which is hard to debug.
1563         If these values are nil, the test will fail in the EXPECT_WK_STREQ
1564         checks, we don't need ASSERT statements.
1565
1566         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1567         (TEST):
1568
1569 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
1570
1571         resultsdpy: Add script to run local instance
1572         https://bugs.webkit.org/show_bug.cgi?id=208746
1573
1574         Rubber-stamped by Aakash Jain.
1575
1576         * resultsdbpy/resultsdbpy/example: Added.
1577         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
1578         * resultsdbpy/resultsdbpy/example/environment.py: Added.
1579         (Environment): Organize environment variables used by results database.
1580         (ModelFromEnvironment): Construct the database model from the environment.
1581         (main): Create and drop tables, if required.
1582         * resultsdbpy/resultsdbpy/example/main.py: Added.
1583         (health): Web-server health check.
1584         (handle_errors):
1585         (main): Run results database web-server.
1586         * resultsdbpy/resultsdbpy/example/worker.py: Added.
1587         (main): Asynchronously process uploaded results.
1588         * resultsdbpy/resultsdbpy/run: Added.
1589
1590 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1591
1592         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
1593         https://bugs.webkit.org/show_bug.cgi?id=209004
1594
1595         Reviewed by Tim Horton.
1596
1597         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
1598         `use_gpu_process` is specified.
1599
1600         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1601         (parse_args):
1602
1603 2020-03-12  Matt Lewis  <jlewis3@apple.com>
1604
1605         Make flatpack import for run-webkit-tests only happen on linux systems
1606         https://bugs.webkit.org/show_bug.cgi?id=208954
1607
1608         Reviewed by Philippe Normand.
1609
1610         * Scripts/run-webkit-tests: Added an if statement to find the system platform
1611         to determine if we need the flatpackutils import. 
1612
1613 2020-03-12  Alex Christensen  <achristensen@webkit.org>
1614
1615         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
1616         https://bugs.webkit.org/show_bug.cgi?id=207609
1617
1618         Reviewed by Ryosuke Niwa.
1619
1620         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1621         (TestWebKitAPI::TEST):
1622
1623 2020-03-12  Daniel Bates  <dabates@apple.com>
1624
1625         FocusController::setFocusedElement() should tell client of refocused element
1626         https://bugs.webkit.org/show_bug.cgi?id=208880
1627
1628         Reviewed by Wenson Hsieh.
1629
1630         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
1631         to start an input session. Currently, it does not even try.
1632
1633         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1634         (TEST):
1635
1636 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
1637
1638         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
1639         https://bugs.webkit.org/show_bug.cgi?id=208970
1640
1641         Reviewed by Daniel Bates.
1642
1643         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
1644         #!/usr/bin/env python.
1645
1646         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
1647         probably has similar rules.
1648
1649         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
1650         Everything else that does so is probably only used by webkit-build.
1651
1652         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
1653
1654         * gtkdoc/generate-gtkdoc:
1655
1656 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
1657
1658         [WebAuthn] Formalize the Keychain schema
1659         https://bugs.webkit.org/show_bug.cgi?id=183533
1660         <rdar://problem/43347926>
1661
1662         Reviewed by Brent Fulgham.
1663
1664         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
1665         the original combination of RP ID and user handle.
1666
1667         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1668         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1669         (WTR::TestRunner::cleanUpKeychain):
1670         (WTR::TestRunner::keyExistsInKeychain):
1671         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1672         * WebKitTestRunner/TestController.h:
1673         * WebKitTestRunner/TestInvocation.cpp:
1674         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1675         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1676         (WTR::TestController::cleanUpKeychain):
1677         (WTR::TestController::keyExistsInKeychain):
1678
1679 2020-03-11  Keith Miller  <keith_miller@apple.com>
1680
1681         Test262-runner should always consider crashes as new failures
1682         https://bugs.webkit.org/show_bug.cgi?id=208943
1683
1684         Reviewed by Yusuke Suzuki.
1685
1686         Right now the runner will consider crashes with no output as passes, which is obviously bad.
1687         Since we should never crash on a conformance test we should consider a crash as a new failure
1688         100% of the time.
1689
1690         * Scripts/test262/Runner.pm:
1691         (processFile):
1692         (runTest):
1693         (processResult):
1694
1695 2020-03-11  Chris Dumez  <cdumez@apple.com>
1696
1697         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
1698         https://bugs.webkit.org/show_bug.cgi?id=208927
1699         <rdar://problem/55448331>
1700
1701         Reviewed by Alex Christensen.
1702
1703         Add API test coverage.
1704
1705         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1706
1707 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
1708
1709         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
1710         https://bugs.webkit.org/show_bug.cgi?id=208860
1711
1712         Reviewed by Carlos Alberto Lopez Perez.
1713
1714         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1715         (StatusBubble): Added 'api-gtk'.
1716         * BuildSlaveSupport/ews-build/config.json:
1717         * BuildSlaveSupport/ews-build/factories.py:
1718         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
1719         GTK.
1720         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
1721         GTK.
1722         (GTKBuildFactory):
1723         (GTKBuildFactory.__init__): Deleted.
1724         (GTKBuildAndTestFactory): Deleted.
1725         (GTKBuildAndTestFactory.__init__): Deleted.
1726         (GTKAPIBuildAndTestFactory): Deleted.
1727         * BuildSlaveSupport/ews-build/loadConfig.py:
1728
1729 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
1730
1731         [ews] Add unit test to prevent multiple schedulers for a builder.
1732         https://bugs.webkit.org/show_bug.cgi?id=208917
1733
1734         Reviewed by Carlos Alberto Lopez Perez.
1735
1736         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1737         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
1738         (TagsForBuilderTest): Fixed a typo.
1739
1740 2020-03-11 Philippe Normand  <pnormand@igalia.com>
1741
1742         [GTK] Failing API tests under the Flatpak SDK environment
1743         https://bugs.webkit.org/show_bug.cgi?id=208871
1744
1745         Reviewed by Michael Catanzaro.
1746
1747         The load-failed signal callback should return a boolean result,
1748         otherwise we enter in unknown territory depending on how the
1749         toolchain compiles this, possibly triggering bad behavior (with
1750         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
1751         GCC toolchain on buildbots).
1752
1753         Patch suggested by Michael Catanzaro.
1754
1755         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1756         (loadFailedCallback):
1757
1758 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
1759
1760         Sync FeatureList.pm with CMake definitions
1761         https://bugs.webkit.org/show_bug.cgi?id=208866
1762
1763         Reviewed by Michael Catanzaro.
1764
1765         * Scripts/webkitperl/FeatureList.pm:
1766
1767 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1768
1769         [ews] Add unit tests for commit queue factory
1770         https://bugs.webkit.org/show_bug.cgi?id=208862
1771
1772         Reviewed by Jonathan Bedard.
1773
1774         * BuildSlaveSupport/ews-build/factories_unittest.py:
1775         (TestCommitQueueFactory):
1776         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
1777
1778 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1779
1780         [ews-app] Status bubble should only display important messages in pop-over - part 3
1781         https://bugs.webkit.org/show_bug.cgi?id=208865
1782
1783         Reviewed by Jonathan Bedard.
1784
1785         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1786         (StatusBubble): Added more strings to STEPS_TO_HIDE.
1787
1788 2020-03-10  Lauro Moura  <lmoura@igalia.com>
1789
1790         [WPE] MiniBrowser: Close child WebViews when exiting
1791         https://bugs.webkit.org/show_bug.cgi?id=208689
1792
1793         Reviewed by Carlos Garcia Campos.
1794
1795         Store created views so we can release them before exiting.
1796
1797         * MiniBrowser/wpe/main.cpp:
1798         (webViewClose):
1799         (createWebView):
1800         (main):
1801
1802 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1803
1804         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
1805         https://bugs.webkit.org/show_bug.cgi?id=208861
1806
1807         Reviewed by Jonathan Bedard.
1808
1809         * BuildSlaveSupport/ews-build/factories.py:
1810         (Factory.__init__): Remove verifycqplus parameter.
1811         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
1812         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
1813         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
1814
1815 2020-03-10  Philippe Normand  <pnormand@igalia.com>
1816
1817         [GTK] API favicon test flaky timeouts
1818         https://bugs.webkit.org/show_bug.cgi?id=208189
1819
1820         Reviewed by Carlos Garcia Campos.
1821
1822         Sometimes the favicon changes already during the load. Keeping
1823         track of it in the WebView favicon property notification handler
1824         gets us rid of the race.
1825
1826         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1827         (testFaviconDatabaseGetFavicon):
1828
1829 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1830
1831         Generate commit-queue status bubble from new EWS
1832         https://bugs.webkit.org/show_bug.cgi?id=208811
1833
1834         Reviewed by Jonathan Bedard.
1835
1836         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1837         (StatusBubble._build_bubbles_for_patch):
1838
1839 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
1840
1841         Remove obsolete feature flags
1842         https://bugs.webkit.org/show_bug.cgi?id=208830
1843
1844         Reviewed by Alex Christensen.
1845
1846         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
1847         are no longer used.
1848
1849         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
1850         when the compilation flag was removed in r258148.
1851
1852         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
1853         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
1854
1855         * Scripts/webkitperl/FeatureList.pm:
1856         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1857
1858 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
1859
1860         WebKitTestRunner bundleID should not be cleared before every test
1861         https://bugs.webkit.org/show_bug.cgi?id=208823
1862         <rdar://problem/60204539>
1863
1864         Reviewed by Per Arne Vollan.
1865
1866         This is causing test failures for layout tests which rely on the Info.plist 
1867         bundle identifier (not the one set via the override method).
1868
1869         * WebKitTestRunner/TestController.cpp:
1870         (WTR::TestController::createWebViewWithOptions):
1871         (WTR::TestController::ensureViewSupportsOptionsForTest):
1872         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1873
1874 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
1875
1876         [macOS] Notification observer is not removed
1877         https://bugs.webkit.org/show_bug.cgi?id=208834
1878
1879         Reviewed by Tim Horton.
1880
1881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1882         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
1883         (TEST):
1884
1885 2020-03-06  Brian Burg  <bburg@apple.com>
1886
1887         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
1888         https://bugs.webkit.org/show_bug.cgi?id=208729
1889         <rdar://problem/60105447>
1890
1891         Reviewed by Jonathan Bedard.
1892
1893         Improve upload.py to look for the svn branch and revision for the 'webkit'
1894         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
1895
1896         * Scripts/webkitpy/common/checkout/scm/git.py:
1897         (Git):
1898         (Git.git_svn_id_regexp):
1899         (Git._field_from_git_svn_id):
1900         (Git.svn_revision):
1901         (Git.svn_branch):
1902         (Git.svn_url):
1903         (Git.native_branch):
1904         Refactor svn revision, branch, url to use the same regexp and helper code.
1905
1906         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1907         (StubRepository.svn_branch):
1908         Expose a stub since this is used unconditionally by Port.commits_for_upload.
1909
1910         * Scripts/webkitpy/common/checkout/scm/svn.py:
1911         (SVN.svn_branch):
1912         (SVN.native_revision):
1913         (SVN):
1914         (SVN.native_branch):
1915         Refactor so the actual implementation is contained in svn_revision / svn_branch.
1916         The native_* methods call out to the SVN equivalents since this is an SVN repository.
1917
1918         * Scripts/webkitpy/port/base.py:
1919         (Port.commits_for_upload):
1920         Add special git-svn handling for the WebKit repository so that SVN branch and revision
1921         is preferred over the git equivalents.
1922
1923 2020-03-09  Antoine Quint  <graouts@apple.com>
1924
1925         TestWebKitAPI fails to build on watchOS
1926         https://bugs.webkit.org/show_bug.cgi?id=208820
1927
1928         Reviewed by Tim Horton.
1929
1930         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1931
1932 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
1933
1934         resultsdbpy: Add tool to manage resultsdbpy container
1935         https://bugs.webkit.org/show_bug.cgi?id=208743
1936
1937         Rubber-stamped by Aakash Jain.
1938
1939         Add tool to start, stop and restart the resultsdbpy Docker container.
1940
1941         * resultsdbpy/resultsdbpy/container: Added.
1942
1943 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1944
1945         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
1946         https://bugs.webkit.org/show_bug.cgi?id=208706
1947
1948         Reviewed by Žan Doberšek.
1949
1950         Add test case to check surrounding text in multiline context.
1951
1952         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
1953         (testWebKitInputMethodContextSurrounding):
1954
1955 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
1956
1957         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
1958         https://bugs.webkit.org/show_bug.cgi?id=208783
1959
1960         Reviewed by Brent Fulgham.
1961
1962         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1963
1964 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
1965
1966         Replace the use of term "rollout" to "revert" in various tools
1967         https://bugs.webkit.org/show_bug.cgi?id=208775
1968
1969         Reviewed by Ryosuke Niwa.
1970
1971         See this webkit-dev thread for the originating discussion:
1972         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
1973
1974         'rollout' is a confusing term to anyone unacquainted with WebKit;
1975         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
1976
1977         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
1978         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
1979
1980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
1981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
1984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1987         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1988         * BuildSlaveSupport/ews-build/steps.py:
1989         * BuildSlaveSupport/ews-build/steps_unittest.py:
1990         * Scripts/webkit-tools-completion.sh:
1991         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1992         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1993         * Scripts/webkitpy/common/checkout/scm/svn.py:
1994         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1995         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1996         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1997         * Scripts/webkitpy/tool/bot/feeders.py:
1998         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1999         * Scripts/webkitpy/tool/bot/irc_command.py:
2000         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2001         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2002         * Scripts/webkitpy/tool/bot/sheriff.py:
2003         * Scripts/webkitpy/tool/commands/download.py:
2004         * Scripts/webkitpy/tool/commands/download_unittest.py:
2005         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2006         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2007         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2008         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2009         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2010         * Scripts/webkitpy/tool/steps/__init__.py:
2011         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2012         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2013         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2014         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
2015
2016 2020-03-07  David Quesada  <david_quesada@apple.com>
2017
2018         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
2019         https://bugs.webkit.org/show_bug.cgi?id=208781
2020         rdar://problem/60061016
2021
2022         Reviewed by Alex Christensen.
2023
2024         Add a test that recreates the conditions of this crash:
2025         - Send a message from the injected bundle to the UI process that contains a reply block.
2026         - Hold a reference to the reply block.
2027         - Let the web view deallocate.
2028         - Call the block, and expect not to crash.
2029
2030         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2031         (localObjectInterface):
2032         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2033         (-[LocalObject doSomethingWithCompletionHandler:]):
2034         (TEST):
2035         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2036         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
2037
2038 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
2039
2040         TextManipulationController should work with ARIA labels
2041         https://bugs.webkit.org/show_bug.cgi?id=208759
2042
2043         Reviewed by Wenson Hsieh.
2044
2045         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2046         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
2047         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
2048         the expected number of tokens for the first item as the very first image is correctly
2049         detected per the code change. 
2050         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
2051
2052 2020-03-07  Alex Christensen  <achristensen@webkit.org>
2053
2054         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
2055         https://bugs.webkit.org/show_bug.cgi?id=208767
2056
2057         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2058         The frameID of the main frame before loading is only 0 on Mac right now.
2059         The test is still good because it validates that execution works in the main frame before loading.
2060
2061 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2062
2063         [ews] commit queue is not skipping layout tests for rollout patches
2064         https://bugs.webkit.org/show_bug.cgi?id=208716
2065
2066         Unreviewed minor fix.
2067
2068         * BuildSlaveSupport/ews-build/steps.py:
2069         (RunWebKitTests.doStepIf):
2070         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
2071         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
2072
2073 2020-03-05  Sam Weinig  <weinig@apple.com>
2074
2075         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2076         https://bugs.webkit.org/show_bug.cgi?id=207436
2077         <rdar://problem/59296762>
2078
2079         Reviewed by Darin Adler.
2080
2081         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2082         Remove JSC related defines.
2083
2084 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
2085
2086         AX: Provide a way to run tests in isolated tree mode
2087         https://bugs.webkit.org/show_bug.cgi?id=208629
2088         <rdar://problem/60075583>
2089
2090         Reviewed by Ryosuke Niwa.
2091
2092         Provide the ability to run tests for accessibility in the isolated tree mode.
2093         This sends a flag over to the injected bundle which calls the right HIServices override so that
2094         the system thinks it is in isolated mode.
2095
2096         * Scripts/compare-webkit-configurations:
2097         (flag_for_comparison):
2098         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2099         (parse_args):
2100         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2101         (parse_args):
2102         * Scripts/webkitpy/port/driver.py:
2103         (Driver.cmd_line):
2104         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2105         (WTR::AccessibilityController::AccessibilityController):
2106         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
2107         (WTR::AccessibilityController::updateIsolatedTreeMode):
2108         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
2109         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2110         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2111         (WTR::InjectedBundle::didReceiveMessageToPage):
2112         (WTR::InjectedBundle::beginTesting):
2113         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2114         * WebKitTestRunner/Options.cpp:
2115         (WTR::handleOptionAccessibilityIsolatedTreeMode):
2116         (WTR::OptionsHandler::OptionsHandler):
2117         * WebKitTestRunner/Options.h:
2118         * WebKitTestRunner/TestController.cpp:
2119         (WTR::TestController::initialize):
2120         (WTR::TestController::resetPreferencesToConsistentValues):
2121         (WTR::TestController::resetStateToConsistentValues):
2122         * WebKitTestRunner/TestController.h:
2123         (WTR::TestController::accessibilityIsolatedTreeMode const):
2124
2125 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
2126
2127         [Cocoa] Re-enable CFPrefs direct mode
2128         https://bugs.webkit.org/show_bug.cgi?id=208690
2129
2130         Reviewed by Brent Fulgham.
2131
2132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2133         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
2134         (TEST):
2135         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2136         (TestWebKitAPI::TEST):
2137
2138 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
2139
2140         UIProcess needs mechanism to specify AppBound domains
2141         https://bugs.webkit.org/show_bug.cgi?id=208528
2142         <rdar://problem/59980340>
2143
2144         Reviewed by Brent Fulgham.
2145
2146         Added test app-bound domains to the plist and tested that the domains
2147         are properly stored in the website data store after a navigation.
2148
2149         * TestWebKitAPI/Info.plist:
2150         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2151         (TEST):
2152
2153 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2154
2155         Add SPI to disable cross origin access control checks
2156         https://bugs.webkit.org/show_bug.cgi?id=208748
2157
2158         Reviewed by Tim Hatcher.
2159
2160         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2161         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
2162
2163 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
2164
2165         [webkitpy] Fix executive on Windows to run wpt server correctly
2166         https://bugs.webkit.org/show_bug.cgi?id=208693
2167
2168         Reviewed by Jonathan Bedard.
2169
2170         Bug fix for Windows environment a) fixing a typo. b) fixing path
2171         c) fix how to kill subprocesses.
2172
2173         * Scripts/webkitpy/common/system/executive.py:
2174         (Executive._windows_kill_command):
2175         (Executive.interrupt):
2176         (Executive.kill_all):
2177         * Scripts/webkitpy/port/base.py:
2178         (Port.web_platform_test_server_doc_root):
2179
2180 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2181
2182         Evaluating JavaScript in main frame before loading should succeed
2183         https://bugs.webkit.org/show_bug.cgi?id=208733
2184
2185         Reviewed by Tim Horton.
2186
2187         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2188
2189 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
2190
2191         TextManipulationController should preserve images
2192         https://bugs.webkit.org/show_bug.cgi?id=208692
2193
2194         Reviewed by Wenson Hsieh.
2195
2196         Added tests for preserving images and their ordering.
2197
2198         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2199         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
2200         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
2201         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
2202
2203 2020-03-06  David Quesada  <david_quesada@apple.com>
2204
2205         Add _WKResourceLoadInfo.resourceType SPI
2206         https://bugs.webkit.org/show_bug.cgi?id=208723
2207
2208         Reviewed by Alex Christensen.
2209
2210         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2211         (TEST):
2212
2213 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
2214
2215         Stop reporting to webkit-test-results.webkit.org
2216         https://bugs.webkit.org/show_bug.cgi?id=207218
2217
2218         Reviewed by Alexey Proskuryakov.
2219
2220         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2221         (RunWebKitTests):
2222
2223 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
2224
2225         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
2226         https://bugs.webkit.org/show_bug.cgi?id=208365
2227         <rdar://problem/59877296>
2228
2229         Reviewed by Geoffrey Garen.
2230
2231         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2232         (TEST):
2233
2234 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2235
2236         EWS should be able to fetch patch status for security bugs while processing them
2237         https://bugs.webkit.org/show_bug.cgi?id=206511
2238
2239         Reviewed by Alexey Proskuryakov.
2240
2241         * BuildSlaveSupport/ews-build/steps.py:
2242         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
2243         (BugzillaMixin.get_patch_json): 
2244         (BugzillaMixin.get_bug_json):
2245         (BugzillaMixin._is_bug_closed):
2246         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
2247         (TransferToS3.hideStepIf): Ditto.
2248
2249 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2250
2251         [ews] commit-queue should show the trac url for the commit on the build page
2252         https://bugs.webkit.org/show_bug.cgi?id=208715
2253
2254         Reviewed by Jonathan Bedard.
2255
2256         * BuildSlaveSupport/ews-build/steps.py:
2257         (PushCommitToWebKitRepo.evaluateCommand):
2258
2259 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2260
2261         Fix ResourceLoadDelegate.LoadInfo API test after r257816
2262         https://bugs.webkit.org/show_bug.cgi?id=208550
2263
2264         * TestWebKitAPI/cocoa/HTTPServer.mm:
2265         (TestWebKitAPI::HTTPServer::respondToRequests):
2266         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
2267         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
2268
2269 2020-03-06  Lauro Moura <lmoura@igalia.com>
2270
2271         [WPE][WebDriver] MiniBrowser should react to close session commands
2272         https://bugs.webkit.org/show_bug.cgi?id=207529
2273
2274         Reviewed by Carlos Garcia Campos.
2275
2276         Do not call g_object_unref on the first created view if it has already
2277         been disposed in the "close" signal handler.
2278
2279         Based on original patch by Yury Semikhatsky.
2280
2281         * MiniBrowser/wpe/main.cpp:
2282         (main):
2283
2284 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
2285
2286         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
2287         https://bugs.webkit.org/show_bug.cgi?id=208647
2288
2289         Reviewed by Carlos Garcia Campos.
2290
2291         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2292         (TestWebKitAPI::TEST):
2293
2294 2020-03-05  Alex Christensen  <achristensen@webkit.org>
2295
2296         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
2297         https://bugs.webkit.org/show_bug.cgi?id=208670
2298
2299         Reviewed by Brady Eidson.
2300
2301         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2302         (-[FrameNavigationDelegate waitForNavigations:]):
2303         (-[FrameNavigationDelegate requests]):
2304         (-[FrameNavigationDelegate frames]):
2305         (-[FrameNavigationDelegate callbacks]):
2306         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
2307         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
2308         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
2309         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
2310         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
2311         (TEST):
2312
2313 2020-03-05  Alex Christensen  <achristensen@webkit.org>
2314
2315         Add WKFrameInfo._parentFrameHandle SPI
2316         https://bugs.webkit.org/show_bug.cgi?id=208674
2317
2318         Reviewed by Brady Eidson.
2319
2320         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2321
2322 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
2323
2324         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
2325         https://bugs.webkit.org/show_bug.cgi?id=208626
2326         <rdar://problem/60074148>
2327
2328         Reviewed by Brent Fulgham.
2329
2330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2331         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2332         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
2333         (TestWebKitAPI::TEST):
2334         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
2335         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
2336         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
2337
2338 2020-03-05  Antoine Quint  <graouts@apple.com>
2339
2340         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
2341         https://bugs.webkit.org/show_bug.cgi?id=208644
2342         <rdar://problem/60042429>
2343
2344         Reviewed by Brady Eidson.
2345
2346         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
2347         
2348         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
2349            empty document has been removed in favor of the document for the requested URL,
2350         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
2351            correctly does not injected the style sheet.
2352
2353         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2354
2355 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2356
2357         [ews] Add build step to push commit to WebKit repository
2358         https://bugs.webkit.org/show_bug.cgi?id=208589
2359
2360         Reviewed by Jonathan Bedard.
2361
2362         * BuildSlaveSupport/ews-build/steps.py:
2363         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
2364         (PushCommitToWebKitRepo.start): Initialize log observer.
2365         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
2366         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
2367         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
2368         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
2369         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2370         * BuildSlaveSupport/ews-build/factories.py:
2371
2372 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2373
2374         [ews] Add unit tests for ValidateCommiterAndReviewer build step
2375         https://bugs.webkit.org/show_bug.cgi?id=208262
2376
2377         Reviewed by Jonathan Bedard.
2378
2379         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
2380
2381 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2382
2383         commit-queue should run WK2 tests instead of WK1 tests
2384         https://bugs.webkit.org/show_bug.cgi?id=208544
2385
2386         Reviewed by Jonathan Bedard.
2387
2388         * BuildSlaveSupport/ews-build/factories.py:
2389
2390 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2391
2392         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
2393         https://bugs.webkit.org/show_bug.cgi?id=208645
2394
2395         Reviewed by Alexey Proskuryakov.
2396
2397         * BuildSlaveSupport/ews-build/steps.py:
2398         (ValidateCommiterAndReviewer.load_contributors):
2399         (ValidateCommiterAndReviewer.start):
2400
2401 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2402
2403         style-checker: Add UAF to the list of security words to warn about.
2404         https://bugs.webkit.org/show_bug.cgi?id=208643
2405
2406         Reviewed by Jonathan Bedard.
2407
2408         UAF is a common acronym used for use after free.
2409
2410         * Scripts/webkitpy/style/checkers/changelog.py:
2411         (ChangeLogChecker.check_for_unwanted_security_phrases):
2412
2413 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
2414
2415         [MSVC] Add .natvis support of WebKit types
2416         https://bugs.webkit.org/show_bug.cgi?id=193119
2417
2418         Reviewed by Don Olmstead.
2419
2420         To help the WebKit developer while debugging, this file defines how
2421         WebKit types are displayed in debugger of Visual Studio.
2422         Very limited set of WebKit types, but it changes the world.
2423
2424         * VisualStudio/WebKit.natvis: Added.
2425
2426 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2427
2428         Add system trace points around display list replay
2429         https://bugs.webkit.org/show_bug.cgi?id=208616
2430
2431         Reviewed by Simon Fraser.
2432
2433         Add a new "Display list replay" trace point.
2434
2435         * Tracing/SystemTracePoints.plist:
2436
2437 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2438
2439         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
2440         https://bugs.webkit.org/show_bug.cgi?id=208615
2441         <rdar://problem/59406743>
2442
2443         Reviewed by Alex Christensen.
2444
2445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2446         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
2447         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2448         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
2449         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2450         (TEST):
2451         Also make a test written in bug 206310 actually run code.
2452
2453 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2454
2455         [build.webkit.org] Remove leaks queue
2456         https://bugs.webkit.org/show_bug.cgi?id=208580
2457
2458         Reviewed by Jonathan Bedard.
2459
2460         * BuildSlaveSupport/build.webkit.org-config/config.json:
2461         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2462         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2463
2464 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2465
2466         Add SPI to evaluate JavaScript in an iframe
2467         https://bugs.webkit.org/show_bug.cgi?id=208605
2468
2469         Reviewed by Brady Eidson.
2470
2471         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2472
2473 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
2474
2475         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
2476         https://bugs.webkit.org/show_bug.cgi?id=208533
2477         <rdar://problem/60010184>
2478
2479         Reviewed by Alex Christensen.
2480
2481         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2482         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2483         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
2484         (TestWebKitAPI::TEST):
2485         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
2486         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
2487
2488 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2489
2490         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
2491         https://bugs.webkit.org/show_bug.cgi?id=208593
2492
2493         Reviewed by Brady Eidson.
2494
2495         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2496         (TestWebKitAPI::TEST):
2497
2498 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2499
2500         WKWebView's frames accessor should return a traversable type
2501         https://bugs.webkit.org/show_bug.cgi?id=208591
2502
2503         Reviewed by Brady Eidson.
2504
2505         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2506
2507 2020-03-04  Antoine Quint  <graouts@apple.com>
2508
2509         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
2510         https://bugs.webkit.org/show_bug.cgi?id=208575
2511         <rdar://problem/59773690>
2512
2513         Reviewed by Brady Eidson.
2514
2515         Add new tests for the new SPI which check:
2516         
2517         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
2518            specified WKWebView alone,
2519         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
2520         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
2521         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
2522         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
2523         6. and that the same test also works with PSON enabled.
2524
2525         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2526
2527 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
2528
2529         [macOS] test-lldb-webkit failing on debug bots
2530         https://bugs.webkit.org/show_bug.cgi?id=208545
2531
2532         Reviewed by Jonathan Bedard.
2533
2534         The lldb-webkit-test step must pass in the build configuration as an
2535         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
2536         binary that is downloaded with the rest of the build products. Without this
2537         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
2538         regardless of their actual build configuration.
2539
2540         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2541         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
2542         * Scripts/test-lldb-webkit:
2543         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
2544
2545 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2546
2547         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
2548         https://bugs.webkit.org/show_bug.cgi?id=208539
2549
2550         Unreviewed follow-up fix.
2551
2552         * BuildSlaveSupport/ews-build/steps.py:
2553
2554 2020-03-04  Daniel Bates  <dabates@apple.com>
2555
2556         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
2557         https://bugs.webkit.org/show_bug.cgi?id=208565
2558
2559         Reviewed by Wenson Hsieh.
2560
2561         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
2562         of its frame as a means to find all the editable elements in the visible content area
2563         of the web view.
2564
2565         Coincidentally this makes no difference to the test results right now because the web view
2566         happens to be located at the origin (0, 0) in the window. However if in the future the
2567         web view would be located at some other point then the tests may fail because the rectangle
2568         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
2569         rectangle for the visible content area.
2570
2571         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2572         (TEST):
2573
2574 2020-03-04  Daniel Bates  <dabates@apple.com>
2575
2576         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
2577         https://bugs.webkit.org/show_bug.cgi?id=208564
2578
2579         Reviewed by Alex Christensen.
2580
2581         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
2582         to make it easy to run just these tests.
2583
2584         Currently, the tests are organized under the test case name WebKit. This means you need to
2585         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
2586         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
2587         so that a person can run just these test using:
2588         
2589                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
2590
2591         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2592         (TEST):
2593
2594 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2595
2596         [ews] Add build step to create local git commit for commit-queue
2597         https://bugs.webkit.org/show_bug.cgi?id=208539
2598
2599         Reviewed by Jonathan Bedard.
2600
2601         * BuildSlaveSupport/ews-build/steps.py:
2602         (CreateLocalGITCommit): Build step to create local git commit.
2603         (CreateLocalGITCommit.start):
2604         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
2605         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
2606         * BuildSlaveSupport/ews-build/factories.py:
2607
2608 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
2609
2610         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
2611         https://bugs.webkit.org/show_bug.cgi?id=207948
2612
2613         Reviewed by Zalan Bujtas.
2614
2615         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
2616         so that it receives the wheel events.
2617
2618         * DumpRenderTree/mac/EventSendingController.mm:
2619         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2620         * DumpRenderTree/win/EventSender.cpp:
2621         (mouseScrollBy):
2622
2623 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
2624
2625         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
2626         https://bugs.webkit.org/show_bug.cgi?id=208520
2627         <rdar://problem/60000214>
2628
2629         Reviewed by Chris Fleizach.
2630
2631         Calling InjectedBundle::singleton().page()->page() in the constructor
2632         of the AccessibilityController is having this side effect on iOS.
2633         So #if to MAC where it's actually being used.
2634
2635         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2636         (WTR::AccessibilityController::AccessibilityController):
2637
2638 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2639
2640         Add SPI _WKResourceLoadInfo.loadedFromCache
2641         https://bugs.webkit.org/show_bug.cgi?id=208554
2642
2643         Reviewed by Wenson Hsieh.
2644
2645         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2646         (TEST):
2647
2648 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2649
2650         Batch observations and completions of text manipulations
2651         https://bugs.webkit.org/show_bug.cgi?id=208406
2652
2653         Reviewed by Wenson Hsieh.
2654
2655         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
2656         multiple paragraphs at once.
2657
2658         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2659         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
2660         (-[TextManipulationDelegate items]):
2661         (-[LegacyTextManipulationDelegate init]):
2662         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
2663         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
2664         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
2665         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
2666         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
2667         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
2668         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
2669
2670 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
2671
2672         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2673         https://bugs.webkit.org/show_bug.cgi?id=208415
2674
2675         Reviewed by Brent Fulgham.
2676
2677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2678         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2679         (TEST):
2680
2681 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2682
2683         Add response to _WKResourceLoadDelegate didCompleteWithError callback
2684         https://bugs.webkit.org/show_bug.cgi?id=208553
2685
2686         Reviewed by Simon Fraser.
2687
2688         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2689         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
2690         (TEST):
2691         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
2692
2693 2020-03-03  Brady Eidson  <beidson@apple.com>
2694
2695         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
2696         https://bugs.webkit.org/show_bug.cgi?id=198795
2697
2698         Reviewed by Chris Dumez.
2699
2700         This test appears to no longer be flaky.
2701         
2702         Let's re-enable it.
2703         
2704         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2705         (TestWebKitAPI::TEST):
2706
2707 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2708
2709         Requests sent to _WKResourceLoadDelegate should include HTTPBody
2710         https://bugs.webkit.org/show_bug.cgi?id=208550
2711
2712         Reviewed by Tim Hatcher.
2713
2714         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2715         (TEST):
2716         * TestWebKitAPI/cocoa/HTTPServer.mm:
2717         (TestWebKitAPI::HTTPServer::respondToRequests):
2718         HTTPServer now looks for Content-Length in its request.
2719         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
2720
2721 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2722
2723         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
2724         https://bugs.webkit.org/show_bug.cgi?id=208522
2725
2726         Reviewed by Brian Weinstein.
2727
2728         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2729         (TEST):
2730
2731 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2732
2733         commit-queue should update working directory and reapply patch just before commiting
2734         https://bugs.webkit.org/show_bug.cgi?id=208521
2735
2736         Reviewed by Jonathan Bedard.
2737
2738         * BuildSlaveSupport/ews-build/factories.py:
2739
2740 2020-03-03  Matt Lewis  <jlewis3@apple.com>
2741
2742         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
2743         https://bugs.webkit.org/show_bug.cgi?id=208485
2744
2745         Reviewed by Jonathan Bedard.
2746
2747         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2748         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
2749         that we don't have to recreate the variables that are already created.
2750         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
2751         from each module, rather than making extra imports that we don't need.
2752         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
2753         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
2754         and not part of the host.
2755         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
2756         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
2757         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
2758         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
2759         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
2760         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
2761         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
2762         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
2763         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
2764         if we were geting any value at all
2765         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
2766         sure we aren't gabking the wrong key:value pair
2767         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
2768         come with the MockHosts and MockHost inherits from MockSystemHost.
2769         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
2770         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
2771         to the various upload steps.
2772
2773 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2774
2775         [ews] Add build step to find list of modified changelogs
2776         https://bugs.webkit.org/show_bug.cgi?id=208514
2777
2778         Reviewed by Jonathan Bedard.
2779
2780         * BuildSlaveSupport/ews-build/factories.py:
2781         * BuildSlaveSupport/ews-build/steps.py:
2782         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
2783         (FindModifiedChangeLogs.start): Initialize log observer.
2784         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
2785         (FindModifiedChangeLogs.evaluateCommand):
2786         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
2787         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
2788         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
2789         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2790
2791 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
2792
2793         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2794         https://bugs.webkit.org/show_bug.cgi?id=208451
2795
2796         Unreviewed test gardening.
2797
2798         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
2799
2800 2020-03-03  Jiten Mehta  <jmehta@apple.com>
2801
2802         Adopt HTTP Alternative Services Storage
2803         https://bugs.webkit.org/show_bug.cgi?id=208387
2804
2805         Reviewed by Alex Christensen.
2806
2807         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2808         (checkUntilEntryFound):
2809         (TEST):
2810
2811 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
2812
2813         Check for navigation to app-bound domain during script evaluation
2814         https://bugs.webkit.org/show_bug.cgi?id=208319
2815         <rdar://problem/57569321>
2816
2817         Reviewed by Brent Fulgham.
2818
2819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2820         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
2821         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2822         (TEST):
2823         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
2824         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
2825
2826 2020-03-03  Commit Queue  <commit-queue@webkit.org>
2827
2828         Unreviewed, rolling out r257754.
2829         https://bugs.webkit.org/show_bug.cgi?id=208513
2830
2831         Introduced API test failure (Requested by perarne on #webkit).
2832
2833         Reverted changeset:
2834
2835         "[Cocoa] Mapping from MIME type to UTI type should be done in
2836         the UI process"
2837         https://bugs.webkit.org/show_bug.cgi?id=208415
2838         https://trac.webkit.org/changeset/257754
2839
2840 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
2841
2842         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
2843         https://bugs.webkit.org/show_bug.cgi?id=208506
2844
2845         Reviewed by Carlos Garcia Campos.
2846
2847         * WebKitTestRunner/TestController.cpp:
2848         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
2849
2850 2020-03-02  Ben Nham  <nham@apple.com>
2851
2852         Add performance probes for HTML parsing
2853         https://bugs.webkit.org/show_bug.cgi?id=208271
2854
2855         Reviewed by Daniel Bates.
2856
2857         This adds probes that show which lines of HTML are have been parsed.
2858
2859         * Tracing/SystemTracePoints.plist:
2860
2861 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2862
2863         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2864         https://bugs.webkit.org/show_bug.cgi?id=208415
2865
2866         Reviewed by Brent Fulgham.
2867
2868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2869         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2870         (TEST):
2871
2872 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2873
2874         Unreviewed, rolling out r257725.
2875
2876         This commit caused 10 API tests to fail
2877
2878         Reverted changeset:
2879
2880         "[Cocoa] Mapping from MIME type to UTI type should be done in
2881         the UI process"
2882         https://bugs.webkit.org/show_bug.cgi?id=208415
2883         https://trac.webkit.org/changeset/257725
2884
2885 2020-03-02  Saam Barati  <sbarati@apple.com>
2886
2887         Don't skip tests unnecessarily on arm64
2888         https://bugs.webkit.org/show_bug.cgi?id=208470
2889         <rdar://problem/59968869>
2890
2891         Reviewed by Tadeu Zagallo.
2892
2893         * Scripts/run-jsc-stress-tests:
2894
2895 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
2896
2897         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
2898         https://bugs.webkit.org/show_bug.cgi?id=208434
2899
2900         Reviewed by Chris Fleizach.
2901
2902         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2903         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
2904         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
2905         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2906         (WTR::AccessibilityController::accessibleElementById): Same as above.
2907
2908 2020-03-02  John Wilander  <wilander@apple.com>
2909
2910         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
2911         https://bugs.webkit.org/show_bug.cgi?id=208399
2912         <rdar://problem/24731650>
2913
2914         Reviewed by Brent Fulgham.
2915
2916         The majority of the changes in WTR::TestController is (partially) fixing a bug
2917         where the TestRunner would statically use the default website datastore instead
2918         of the website data store configure for the page. This worked for persistent
2919         storage testing but not for ephemeral sessions which is what this patch is all
2920         about. The previous TestController::websiteDataStore() is now called
2921         TestController::defaultWebsiteDataStore() and the new
2922         TestController::websiteDataStore() returns the configured website data store.
2923         Most of the use of the default website data store should probably change but
2924         that's not really for this patch to deal with. I did however move all of
2925         resource load statistics' use to the new TestController::websiteDataStore().
2926
2927         A new TestRunner function was added: isStatisticsEphemeral()
2928         It allows test cases to query the ephemeral status of resource load statistics.
2929
2930         One problem that is mitigated in this patch but not fully fixed is that for
2931         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
2932         TestController::generatePageConfiguration() via C API 
2933         WKPageConfigurationSetWebsiteDataStore(), and then again in 
2934         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
2935         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
2936         I tried removing the latter since one session for all platforms should be
2937         Enough but got broken behavior as a result. So now both are still there
2938         and both enable resource load statistics.
2939
2940         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2941         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2942         (WTR::TestRunner::isStatisticsEphemeral):
2943         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2944         * WebKitTestRunner/TestController.cpp:
2945         (WTR::TestController::defaultWebsiteDataStore):
2946         (WTR::TestController::websiteDataStore):
2947         (WTR::TestController::generatePageConfiguration):
2948         (WTR::TestController::resetPreferencesToConsistentValues):
2949         (WTR::TestController::resetStateToConsistentValues):
2950         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2951         (WTR::TestController::decidePolicyForNavigationAction):
2952         (WTR::TestController::platformAdjustContext):
2953         (WTR::TestController::clearServiceWorkerRegistrations):
2954         (WTR::TestController::clearDOMCache):
2955         (WTR::TestController::clearDOMCaches):
2956         (WTR::TestController::clearIndexedDatabases):
2957         (WTR::TestController::clearLocalStorage):
2958         (WTR::TestController::hasDOMCache):
2959         (WTR::TestController::domCacheSize):
2960         (WTR::TestController::setStatisticsEnabled):
2961         (WTR::TestController::isStatisticsEphemeral):
2962         (WTR::TestController::setStatisticsDebugMode):
2963         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
2964         (WTR::TestController::setStatisticsLastSeen):
2965         (WTR::TestController::setStatisticsMergeStatistic):
2966         (WTR::TestController::setStatisticsPrevalentResource):
2967         (WTR::TestController::setStatisticsVeryPrevalentResource):
2968         (WTR::TestController::dumpResourceLoadStatistics):
2969         (WTR::TestController::isStatisticsPrevalentResource):
2970         (WTR::TestController::isStatisticsVeryPrevalentResource):
2971         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
2972         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2973         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2974         (WTR::TestController::setStatisticsHasHadUserInteraction):
2975         (WTR::TestController::isStatisticsHasHadUserInteraction):
2976         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
2977         (WTR::TestController::setStatisticsGrandfathered):
2978         (WTR::TestController::isStatisticsGrandfathered):
2979         (WTR::TestController::setUseITPDatabase):
2980         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2981         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2982         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2983         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
2984         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
2985         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
2986         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2987         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2988         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2989         (WTR::TestController::statisticsUpdateCookieBlocking):
2990         (WTR::TestController::statisticsSubmitTelemetry):
2991         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2992         (WTR::TestController::setStatisticsIsRunningTest):
2993         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2994         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2995         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2996         (WTR::TestController::setStatisticsGrandfatheringTime):
2997         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2998         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2999         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
3000         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3001         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
3002         (WTR::TestController::statisticsDeleteCookiesForHost):
3003         (WTR::TestController::isStatisticsHasLocalStorage):
3004         (WTR::TestController::setStatisticsCacheMaxAgeCap):
3005         (WTR::TestController::hasStatisticsIsolatedSession):
3006         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
3007         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
3008         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
3009         (WTR::TestController::statisticsResetToConsistentState):
3010         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
3011         * WebKitTestRunner/TestController.h:
3012         * WebKitTestRunner/TestInvocation.cpp:
3013         (WTR::TestInvocation::invoke):
3014         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3015         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3016         (WTR::initializeWebViewConfiguration):
3017         (WTR::TestController::platformCreateWebView):
3018
3019 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
3020
3021         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
3022         https://bugs.webkit.org/show_bug.cgi?id=208415
3023
3024         Reviewed by Brent Fulgham.
3025
3026         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3027         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
3028         (TEST):
3029
3030 2020-03-02  Daniel Bates  <dabates@apple.com>
3031
3032         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
3033         https://bugs.webkit.org/show_bug.cgi?id=208352
3034         <rdar://problem/59867815>
3035
3036         Reviewed by Wenson Hsieh.
3037
3038         Update test results to reflect the new behavior. To do this I also need to fix up the test code
3039         to actually scroll the web content. This also means we now execute the same code on both Mac and
3040         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
3041         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
3042         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
3043
3044         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3045         (TEST):
3046
3047 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
3048
3049         Unreviewed, rolling out r257687.
3050
3051         This commit caused debug tests to crash for macOS & iOS
3052
3053         Reverted changeset:
3054
3055         "[Cocoa] Mapping from MIME type to UTI type should be done in
3056         the UI process"
3057         https://bugs.webkit.org/show_bug.cgi?id=208415
3058         https://trac.webkit.org/changeset/257687
3059
3060 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3061
3062         Unreviewed, rolling out r257618.
3063
3064         This allegedly causes Safari to crash when closing a window
3065         (see rdar://problem/59922725).
3066
3067         Reverted changeset:
3068
3069         "UIProcess crash after using _prepareForMoveToWindow, then
3070         deallocating the WKWebView before moving to the window"
3071         https://bugs.webkit.org/show_bug.cgi?id=208365
3072         https://trac.webkit.org/changeset/257618
3073
3074 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
3075
3076         Remove std::lock_guard
3077         https://bugs.webkit.org/show_bug.cgi?id=206451
3078
3079         Reviewed by Anders Carlsson.
3080
3081         Add std::lock_guard lint rule to prevent from using it.
3082
3083         * Scripts/webkitpy/style/checkers/cpp.py:
3084         (check_lock_guard):
3085         (check_style):
3086         (CppChecker):
3087         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3088         (WebKitStyleTest.test_lock_guard):
3089         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3090         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3091         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3092         (assertHasObjects):
3093         (assertHasOnlyObjects):
3094         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3095         (WTR::AXThread::dispatch):
3096         (WTR::AXThread::dispatchFunctionsFromAXThread):
3097         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3098         (WTR::AXThread::initializeRunLoop):
3099
3100 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
3101
3102         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
3103         https://bugs.webkit.org/show_bug.cgi?id=208415
3104
3105         Reviewed by Brent Fulgham.
3106
3107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3108         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
3109         (TEST):
3110
3111 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3112
3113         Unreviewed, rolling out r257565.
3114
3115         It broke WinCairo MiniBrowser
3116
3117         Reverted changeset:
3118
3119         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
3120         https://bugs.webkit.org/show_bug.cgi?id=206894
3121         https://trac.webkit.org/changeset/257565
3122
3123 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3124
3125         EWS fails to retry build in case of kill-old-processes exception
3126         https://bugs.webkit.org/show_bug.cgi?id=208003
3127
3128         Reviewed by Jonathan Bedard.
3129
3130         * BuildSlaveSupport/ews-build/steps.py:
3131         (KillOldProcesses.evaluateCommand):
3132         (KillOldProcesses.getResultSummary):
3133
3134 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3135
3136         [ews] commit-queue should update the ChangeLog with Reviewer name
3137         https://bugs.webkit.org/show_bug.cgi?id=206535
3138
3139         Reviewed by Jonathan Bedard.
3140
3141         * BuildSlaveSupport/ews-build/steps.py:
3142         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
3143
3144 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
3145
3146         run-javascriptcore-tests: Make upload format valid
3147         https://bugs.webkit.org/show_bug.cgi?id=208341
3148
3149         Rubber-stamped by Aakash Jain.
3150
3151         * Scripts/run-javascriptcore-tests:
3152         (uploadResults): Remove. FIXME.
3153         * Scripts/webkitdirs.pm:
3154         (splitVersionString): Handle case where the subminor version number has a - in it.
3155         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
3156
3157 2020-02-28  youenn fablet  <youenn@apple.com>
3158
3159         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
3160         https://bugs.webkit.org/show_bug.cgi?id=208130
3161
3162         Reviewed by Eric Carlson.
3163
3164         * WebKitTestRunner/TestOptions.h:
3165         Use GPU process to capture by default.
3166         We will remove this option once done verifying that every test works smoothly.
3167
3168 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3169
3170         [ews] commit queue should skip building and testing for rollout patches
3171         https://bugs.webkit.org/show_bug.cgi?id=208329
3172
3173         Reviewed by Jonathan Bedard.
3174
3175         * BuildSlaveSupport/ews-build/steps.py:
3176         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
3177         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
3178         (RunWebKit1Tests.doStepIf): Ditto.
3179         * BuildSlaveSupport/ews-build/steps_unittest.py:
3180         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
3181         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
3182
3183 2020-02-28  Daniel Bates  <dabates@apple.com>
3184
3185         Update my watch list preferences and contributor's entry.
3186
3187         * Scripts/webkitpy/common/config/contributors.json:
3188         * Scripts/webkitpy/common/config/watchlist:
3189
3190 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3191
3192         Fix WebCore export macros for declspec
3193         https://bugs.webkit.org/show_bug.cgi?id=208363
3194
3195         Reviewed by Konstantin Tokarev.
3196
3197         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
3198         files. Removed precompiled headers that were empty.
3199
3200         * DumpRenderTree/DumpRenderTreePrefix.h:
3201         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
3202         * MiniBrowser/win/stdafx.h:
3203         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
3204         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
3205         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
3206         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
3207         * WebKitTestRunner/PlatformFTW.cmake:
3208         * WebKitTestRunner/PlatformWin.cmake:
3209         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3210
3211 2020-02-27  Tim Horton  <timothy_horton@apple.com>
3212
3213         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
3214         https://bugs.webkit.org/show_bug.cgi?id=208365
3215
3216         Reviewed by Alex Christensen.
3217
3218         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
3219         (TEST):
3220         Add a test! It was a 100% repro crash before this change.
3221
3222 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
3223
3224         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
3225         https://bugs.webkit.org/show_bug.cgi?id=208260
3226         <rdar://problem/59820107>
3227
3228         Reviewed by Tim Horton.
3229
3230         Followed instructions for adding an Info.plist for Single-File Tools
3231         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
3232
3233         The default WebsiteDataStore file path will change with this test to
3234         reflect the new bundleID so we must change expectations for any api
3235         tests which rely on knowing the path.
3236
3237         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3239         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
3240         (TEST):
3241         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3242         (TEST):
3243         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
3244         (TEST):
3245         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
3246         (TEST):
3247         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3248         (TEST):
3249         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
3250         (TEST):
3251         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
3252         (TEST):
3253         (defaultWebsiteCacheDirectory):
3254         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
3255         (TEST):
3256         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3257         (TEST):
3258         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3259         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3260         (TEST):
3261         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3262         (TEST):
3263         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3264         (runWebsiteDataStoreCustomPaths):
3265         (TEST):
3266         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3267         (TestWebKitAPI::resetTestState):
3268         Now that we set a bundleID, we have to reset the cache model between
3269         tests, otherwise it gets stored between tests.
3270
3271         (TestWebKitAPI::TEST):
3272         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3273         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3274
3275 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3276
3277         TextManipulationController should not generate a new item for content in manipulated paragraphs
3278         https://bugs.webkit.org/show_bug.cgi?id=208286
3279
3280         Reviewed by Wenson Hsieh.
3281
3282         Added a regression test.
3283
3284         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3285         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
3286
3287 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
3288
3289         run-javascriptcore-tests: Make upload format valid
3290         https://bugs.webkit.org/show_bug.cgi?id=208341
3291
3292         Reviewed by Aakash Jain.
3293
3294         * Scripts/run-javascriptcore-tests:
3295         (uploadResults): Print json blob for upload after failure for debugging.
3296
3297 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3298
3299         [CMake] Add WebKit::PAL target
3300         https://bugs.webkit.org/show_bug.cgi?id=198493
3301
3302         Reviewed by Michael Catanzaro.
3303
3304         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
3305
3306         * DumpRenderTree/PlatformWin.cmake:
3307
3308 2020-02-27  Alex Christensen  <achristensen@webkit.org>
3309
3310         Add SPI to query WKFrameInfos in a WKWebView
3311         https://bugs.webkit.org/show_bug.cgi?id=208212
3312
3313         Reviewed by Brady Eidson.
3314
3315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3316         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
3317         * WebKitTestRunner/TestController.cpp:
3318         (WTR::TestController::saltForOrigin):
3319
3320 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
3321
3322         Unreviewed, rolling out r257530.
3323
3324         This commit seems to have broke the build internally for
3325         watchOS
3326
3327         Reverted changeset:
3328
3329         "Add SPI to query WKFrameInfos in a WKWebView"
3330         https://bugs.webkit.org/show_bug.cgi?id=208212
3331         https://trac.webkit.org/changeset/257530
3332
3333 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3334
3335         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
3336         https://bugs.webkit.org/show_bug.cgi?id=206894
3337
3338         Reviewed by Adrian Perez de Castro.
3339
3340         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
3341         MiniBrowsers.
3342
3343         * MiniBrowser/gtk/CMakeLists.txt:
3344         * MiniBrowser/win/CMakeLists.txt:
3345         * MiniBrowser/wpe/CMakeLists.txt:
3346
3347 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3348
3349         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
3350         https://bugs.webkit.org/show_bug.cgi?id=206456
3351
3352         Reviewed by Brady Eidson.
3353
3354         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3355         (TEST):
3356
3357 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3358
3359         _WKUserContentWorld should be a wrapper around WKContentWorld
3360         https://bugs.webkit.org/show_bug.cgi?id=208274
3361
3362         Reviewed by Brady Eidson.
3363
3364         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
3365         (TEST):
3366         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3367         (TEST):
3368
3369 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
3370
3371         Unreviewed, rolling out r257522.
3372
3373         Caused 16 API test failures on the bots
3374
3375         Reverted changeset:
3376
3377         "TestWebKitAPI and WebKitTestRunner should have bundle
3378         identifiers"
3379         https://bugs.webkit.org/show_bug.cgi?id=208260
3380         https://trac.webkit.org/changeset/257522
3381
3382 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3383
3384         Add SPI to query WKFrameInfos in a WKWebView
3385         https://bugs.webkit.org/show_bug.cgi?id=208212
3386
3387         Reviewed by Brady Eidson.
3388
3389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3390         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
3391         * WebKitTestRunner/TestController.cpp:
3392         (WTR::TestController::saltForOrigin):
3393
3394 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3395
3396         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
3397         https://bugs.webkit.org/show_bug.cgi?id=208260
3398         <rdar://problem/59820107>
3399
3400         Reviewed by Tim Horton.
3401
3402         Followed instructions for adding an Info.plist for Single-File Tools
3403         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
3404
3405         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3406         * TestWebKitAPI/Info.plist: Added.
3407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3408         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3409         * WebKitTestRunner/Info.plist: Added.
3410         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3411
3412 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3413
3414         Tests should each use a unique ResourceLoadStatistics file path for its database store
3415         https://bugs.webkit.org/show_bug.cgi?id=208206
3416         <rdar://problem/59690272>
3417
3418         Reviewed by Brady Eidson.
3419
3420         Initialize a default website data store before checking for the ITP
3421         store to ensure the directory exists after the file has been deleted.
3422
3423         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3424         (TEST):
3425
3426 2020-02-26  Christopher Reid  <chris.reid@sony.com>
3427
3428         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
3429         https://bugs.webkit.org/show_bug.cgi?id=197684
3430         <rdar://problem/59467397>
3431
3432         Reviewed by Yusuke Suzuki.
3433
3434         Add test for FileSystem::createFile
3435
3436         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3437
3438 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
3439
3440         [ews] commit-queue should verify patch committer and reviewer
3441         https://bugs.webkit.org/show_bug.cgi?id=206532
3442
3443         Reviewed by Jonathan Bedard.
3444
3445         * BuildSlaveSupport/ews-build/steps.py:
3446         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
3447         (ValidateCommiterAndReviewer._addToLog):
3448         (ValidateCommiterAndReviewer.getResultSummary):
3449         (ValidateCommiterAndReviewer.fail_build):
3450         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
3451         (ValidateCommiterAndReviewer.is_reviewer):
3452         (ValidateCommiterAndReviewer.is_committer):
3453         (ValidateCommiterAndReviewer.full_name_from_email):
3454         (ValidateCommiterAndReviewer.start):
3455
3456 2020-02-26  Daniel Bates  <dabates@apple.com>
3457
3458         [iOS] Send focus update immediately on becoming or resigning first responder
3459         https://bugs.webkit.org/show_bug.cgi?id=208082
3460         <rdar://problem/59688413>
3461
3462         Rubber-stamped by Jer Noble.
3463
3464         Add a test to ensure that selecting a position at a point after the web view
3465         becomes first responder is allowed. Such an operation is only allowed if the
3466         web view is focused.
3467
3468         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3469         (-[TestWKWebView selectPositionAtPoint:]):
3470         (TEST):
3471         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
3472
3473 2020-02-26  Chris Dumez  <cdumez@apple.com>
3474
3475         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
3476
3477         The test was added for macOS and times out on iOS.
3478
3479         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3480         (TEST):
3481
3482 2020-02-26  Youenn Fablet  <youenn@apple.com>
3483
3484         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
3485         https://bugs.webkit.org/show_bug.cgi?id=208238
3486
3487         Reviewed by Eric Carlson.
3488
3489         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3490         (TEST):
3491         Remove use of deleted parameter.
3492
3493 2020-02-25  Devin Rousso  <drousso@apple.com>
3494
3495         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
3496         https://bugs.webkit.org/show_bug.cgi?id=206911
3497         <rdar://problem/58026635>
3498
3499         Reviewed by Brian Burg.
3500
3501         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3502         (TestWebKitAPI::TEST):
3503         Add test for `WTF::HashSet::reserveInitialCapacity`.
3504
3505         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3506         (TestWebKitAPI::TEST):
3507         Actually check the value of `WTF::HashMap::capacity`.
3508
3509         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
3510         (-[InspectorDelegate _webView:didAttachInspector:])
3511         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
3512         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
3513         (TestWebKitAPI::TEST):
3514         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3515         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
3516         (TestWebKitAPI::TEST): Deleted.
3517
3518 2020-02-25  Matt Lewis  <jlewis3@apple.com>
3519
3520         Add checkout_root to stubrepository.py
3521         https://bugs.webkit.org/show_bug.cgi?id=208213
3522
3523         Reviewed by Jonathan Bedard.
3524
3525         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3526         (StubRepository.__init__):
3527
3528         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
3529         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
3530
3531 2020-02-25  Daniel Bates  <dabates@apple.com>
3532
3533         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
3534         https://bugs.webkit.org/show_bug.cgi?id=208214
3535
3536         Reviewed by Wenson Hsieh.
3537
3538         Wait until the copy operation completes before loading the second web view and testing paste
3539         to ensure that something was actually copied to the clipboard.
3540
3541         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
3542         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3543         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
3544         so that we wait until the command completes.
3545
3546 2020-02-25  Chris Dumez  <cdumez@apple.com>
3547
3548         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
3549         https://bugs.webkit.org/show_bug.cgi?id=208199
3550         <rdar://problem/59746887>
3551
3552         Reviewed by Alex Christensen.
3553
3554         Add API test coverage.
3555
3556         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3557         (TEST):
3558
3559 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3560
3561         spinRunLoop should take a non-zero integer as parameter
3562         https://bugs.webkit.org/show_bug.cgi?id=208148
3563         <rdar://problem/59766682>
3564
3565         Unreviewed iOS build fix.
3566
3567         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3568         (TestWebKitAPI::Util::spinRunLoop):
3569
3570 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3571
3572         spinRunLoop should take a non-zero integer as parameter
3573         https://bugs.webkit.org/show_bug.cgi?id=208148
3574
3575         Reviewed by Darin Adler.
3576
3577         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3578         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3579         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3580         (TestWebKitAPI::Util::spinRunLoop):
3581
3582 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3583
3584         [WTF] Add tests for CompactRefPtrTuple
3585         https://bugs.webkit.org/show_bug.cgi?id=208172
3586
3587         Reviewed by Darin Adler.
3588
3589         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
3590         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
3591
3592         * TestWebKitAPI/CMakeLists.txt:
3593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3594         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
3595         (TestWebKitAPI::TEST):
3596
3597 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
3598
3599         [ews] commit-queue should check that patch have appropriate review flag
3600         https://bugs.webkit.org/show_bug.cgi?id=208138
3601
3602         Reviewed by Jonathan Bedard.
3603
3604         * BuildSlaveSupport/ews-build/steps.py:
3605         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
3606         (BugzillaMixin._is_patch_cq_plus):
3607         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
3608         (ValidatePatch.start):
3609
3610 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
3611
3612         [WebAuthn] Implement SPI for the platform authenticator
3613         https://bugs.webkit.org/show_bug.cgi?id=208087
3614         <rdar://problem/59369305>
3615
3616         Reviewed by Brent Fulgham.
3617
3618         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
3619
3620         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
3621         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3623         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3624         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3625         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
3626         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
3627         (TestWebKitAPI::TEST):
3628         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
3629         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
3630         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
3631         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
3632
3633 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3634
3635         Unreviewed, updating LLDB test for CompactPointerTuple.
3636         https://bugs.webkit.org/show_bug.cgi?id=207827
3637
3638         * lldb/lldb_webkit.py:
3639         (WTFCompactPointerTupleProvider):
3640         (WTFCompactPointerTupleProvider.update):
3641
3642 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
3643
3644         Provide alternate way to name Web Content process
3645         https://bugs.webkit.org/show_bug.cgi?id=205224
3646         rdar://57038084
3647
3648         Reviewed by Alex Christensen.
3649
3650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3651         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
3652         (TestWebKitAPI::TEST):
3653
3654 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
3655
3656         results.webkit.org: Link to result archives
3657         https://bugs.webkit.org/show_bug.cgi?id=207646
3658         <rdar://problem/59395807>
3659
3660         Rubber-stamped by Aakash Jain.
3661
3662         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
3663         (_ArchiveRouter): Retrieve json from archive-router endpoint.
3664         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
3665         return the most specific value.
3666         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
3667         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
3668         (_ArchiveRouter.prototype.labelFor): Return