[GTK] Hardcoded text color in input fields
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Hardcoded text color in input fields
4         https://bugs.webkit.org/show_bug.cgi?id=126907
5
6         Reviewed by Michael Catanzaro.
7
8         Add dark-mode command line option to MiniBrowser.
9
10         * MiniBrowser/gtk/main.c:
11         (main):
12
13 2019-04-24  Zalan Bujtas  <zalan@apple.com>
14
15         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
16         https://bugs.webkit.org/show_bug.cgi?id=196948
17         <rdar://problem/49927131>
18
19         Reviewed by Tim Horton.
20
21         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
22         (TEST):
23         The expected order of incoming events is
24         1. didInvalidateIntrinsicContentSize
25         2. didFirstLayout
26         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
27         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
28         (and remember, all we care about is ordering).
29
30 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
31
32         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
33         https://bugs.webkit.org/show_bug.cgi?id=197171
34         <rdar://problem/47454979>
35
36         Reviewed by Youenn Fablet.
37
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
40         (TestWebKitAPI::TEST):
41
42 2019-04-24  Brady Eidson  <beidson@apple.com>
43
44         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
45         https://bugs.webkit.org/show_bug.cgi?id=191362
46
47         Reviewed by Alex Christensen.
48
49         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
50           from an XHR to a custom protocol.
51
52 2019-04-24  John Wilander  <wilander@apple.com>
53
54         Age out unconverted Ad Click Attributions after one week.
55         https://bugs.webkit.org/show_bug.cgi?id=197238
56         <rdar://problem/50177349>
57
58         Reviewed by Chris Dumez.
59
60         This patch adds infrastructure to allow tests to expire all unconverted
61         attributions early.
62
63         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
64         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
65         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
66         * WebKitTestRunner/InjectedBundle/TestRunner.h:
67         * WebKitTestRunner/TestController.cpp:
68         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
69         * WebKitTestRunner/TestController.h:
70         * WebKitTestRunner/TestInvocation.cpp:
71         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
72
73 2019-04-24  Chris Dumez  <cdumez@apple.com>
74
75         Fix flaky crashes in a couple of PSON API tests
76         https://bugs.webkit.org/show_bug.cgi?id=197239
77
78         Reviewed by Tim Horton.
79
80         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
81
82         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
83
84 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
85
86         Make it possible to control the renderTreeAsText output by setting options on testRunner
87         https://bugs.webkit.org/show_bug.cgi?id=197133
88
89         Reviewed by Sam Weinig.
90
91         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
92         that make sense in testing (those that don't dump unstable data like addresses), and plumb
93         these flags through the various framework layers.
94
95         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
96
97         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
98         and hand-code DumpRenderTree bindings.
99
100         Some cleanup of the TestRunners, using member initializers.
101
102         * DumpRenderTree/TestRunner.cpp:
103         (TestRunner::TestRunner):
104         (setRenderTreeDumpOptionsCallback):
105         (TestRunner::staticFunctions):
106         (TestRunner::setRenderTreeDumpOptions):
107         * DumpRenderTree/TestRunner.h:
108         (TestRunner::renderTreeDumpOptions const):
109         * DumpRenderTree/mac/DumpRenderTree.mm:
110         (dump):
111         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
112         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
113         (WTR::InjectedBundlePage::dump):
114         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
115         (WTR::TestRunner::TestRunner):
116         (WTR::TestRunner::setRenderTreeDumpOptions):
117         * WebKitTestRunner/InjectedBundle/TestRunner.h:
118         (WTR::TestRunner::renderTreeDumpOptions const):
119
120 2019-04-24  Alex Christensen  <achristensen@webkit.org>
121
122         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
123         https://bugs.webkit.org/show_bug.cgi?id=197078
124         <rdar://problem/49564348>
125
126         Reviewed by Geoff Garen.
127
128         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
129         (TEST_F):
130         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
131         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
132         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
133
134 2019-04-24  Alex Christensen  <achristensen@webkit.org>
135
136         Add unit test for r239322
137         https://bugs.webkit.org/show_bug.cgi?id=197236
138
139         Reviewed by Chris Dumez.
140
141         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
142         May as well add the test infrastructure which was needed before and will be needed in the future.
143
144         * TestWebKitAPI/TCPServer.cpp:
145         (TestWebKitAPI::TCPServer::TCPServer):
146         * TestWebKitAPI/TCPServer.h:
147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
148         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
149         (TestWebKitAPI::TEST):
150         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
151         (TestWebKitAPI::downloadAtRate):
152         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
153         (TEST):
154         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
155         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
156         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
157         (TestWebKitAPI::TEST):
158         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
159         (TEST):
160
161 2019-04-24  Chris Dumez  <cdumez@apple.com>
162
163         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
164         https://bugs.webkit.org/show_bug.cgi?id=197214
165         <rdar://problem/49237544>
166
167         Reviewed by Alex Christensen.
168
169         Extend API test coverage.
170
171         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
172         (TEST):
173
174 2019-04-24  Philippe Normand  <pnormand@igalia.com>
175
176         [Build][GStreamer] Update to 1.16.0
177         https://bugs.webkit.org/show_bug.cgi?id=197157
178
179         Reviewed by Xabier Rodriguez-Calvar.
180
181         The upstreamed patches were removed and a new one was added for a
182         regression detected in the scaletempo GStreamer element. The GNOME
183         Flatpak was migrated to 3.32 and I switched a few modules to Meson
184         on the way, as it is the preferred build system now in GStreamer
185         1.16.
186
187         * flatpak/files/httpd-autogen.sh:
188         * flatpak/flatpakutils.py:
189         (FlatpakPackage.install):
190         (WebkitFlatpak.run_in_sandbox):
191         * flatpak/org.webkit.CommonModules.yaml:
192         * flatpak/org.webkit.WebKit.yaml:
193         * gstreamer/jhbuild.modules:
194         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
195         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
196         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
197         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
198         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
199         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
200         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
201         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
202         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
203         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
204         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
205         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
206         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
207         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
208         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
209         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
210         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
211         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
212         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
213         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
214         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
215         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
216
217 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
218
219         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
220         https://bugs.webkit.org/show_bug.cgi?id=197156
221
222         Reviewed by Michael Catanzaro.
223
224         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
225         support was added.
226
227         * MiniBrowser/gtk/BrowserTab.c:
228         (browser_tab_set_background_color): Set the passed in color as web view background color.
229         * MiniBrowser/gtk/BrowserTab.h:
230         * MiniBrowser/gtk/BrowserWindow.c:
231         (browser_window_init): Initialize backgroundColor.
232         (browser_window_append_view): Call browser_tab_set_background_color().
233         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
234         are added.
235         * MiniBrowser/gtk/main.c:
236         (main): Call browser_window_set_background_color() before creating the tabs.
237
238 2019-04-23  John Wilander  <wilander@apple.com>
239
240         Move Ad Click Attribution from internal feature to experimental feature
241         https://bugs.webkit.org/show_bug.cgi?id=197218
242         <rdar://problem/47651691>
243
244         Reviewed by Brent Fulgham.
245
246         * DumpRenderTree/TestOptions.cpp:
247         (TestOptions::TestOptions):
248
249 2019-04-23  Andy Estes  <aestes@apple.com>
250
251         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
252         https://bugs.webkit.org/show_bug.cgi?id=196749
253         <rdar://problem/35773454>
254
255         Reviewed by Daniel Bates.
256
257         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
258
259         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
260         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
261         (-[QuickLookDelegate webView:didFinishNavigation:]):
262         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
263         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
264         (runTest):
265         (runTestDecideBeforeLoading):
266         (runTestDecideAfterLoading):
267         (TEST):
268
269 2019-04-23  John Wilander  <wilander@apple.com>
270
271         Remove Ad Click Attribution data when removing website data
272         https://bugs.webkit.org/show_bug.cgi?id=197215
273         <rdar://problem/47668988>
274
275         Reviewed by Chris Dumez.
276
277         This patch adds test infrastructure to delete Ad Click Attribution data
278         through WebsiteDataStore::removeData().
279
280         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
281         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
282         (WTR::TestRunner::clearAdClickAttribution):
283         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
284         * WebKitTestRunner/InjectedBundle/TestRunner.h:
285         * WebKitTestRunner/TestController.cpp:
286         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
287         * WebKitTestRunner/TestController.h:
288         * WebKitTestRunner/TestInvocation.cpp:
289         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
290
291 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
292
293         webkitpy: Kill unresponsive worker processes
294         https://bugs.webkit.org/show_bug.cgi?id=197205
295         <rdar://problem/50104388>
296
297         Reviewed by Lucas Forschler.
298
299         * Scripts/webkitpy/common/message_pool.py:
300         (_MessagePool.__init__): Add close timeout.
301         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
302
303 2019-04-23  Alex Christensen  <achristensen@webkit.org>
304
305         Add unit tests for WKWebView.serverTrust
306         https://bugs.webkit.org/show_bug.cgi?id=197202
307
308         Reviewed by Youenn Fablet
309
310         * TestWebKitAPI/TCPServer.cpp:
311         (TestWebKitAPI::deleter<BIO>::operator()):
312         (TestWebKitAPI::deleter<SSL>::operator()):
313         (TestWebKitAPI::deleter<X509>::operator()):
314         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
315         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
316         (TestWebKitAPI::TCPServer::TCPServer):
317         (TestWebKitAPI::TCPServer::listenForConnections):
318         * TestWebKitAPI/TCPServer.h:
319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
320         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
321         (TestWebKitAPI::TEST):
322         (verifyCertificateAndPublicKey):
323         (-[ServerTrustDelegate webView:didFinishNavigation:]):
324         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
325         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
326         (TestWebKitAPI::downloadAtRate):
327         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
328         (TEST):
329         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
330         (TEST):
331
332 2019-04-23  Commit Queue  <commit-queue@webkit.org>
333
334         Unreviewed, rolling out r244556.
335         https://bugs.webkit.org/show_bug.cgi?id=197212
336
337         Causing build failures on multiple builders (Requested by
338         ShawnRoberts on #webkit).
339
340         Reverted changeset:
341
342         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
343         https://bugs.webkit.org/show_bug.cgi?id=197171
344         https://trac.webkit.org/changeset/244556
345
346 2019-04-23  Alex Christensen  <achristensen@webkit.org>
347
348         Fix iOS build.
349         https://bugs.webkit.org/show_bug.cgi?id=195537
350
351         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
352         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
353         AdoptWK constructor is private now.  Use adoptWK instead.
354
355 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
356
357         Accessibility text search and selection API enhancements.
358         https://bugs.webkit.org/show_bug.cgi?id=197095
359         <rdar://problem/48181791>
360
361         Reviewed by Chris Fleizach.
362
363         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
364
365         * DumpRenderTree/AccessibilityTextMarker.h:
366         * DumpRenderTree/AccessibilityUIElement.cpp:
367         (searchTextWithCriteriaCallback):
368         (AccessibilityUIElement::getJSClass):
369         * DumpRenderTree/AccessibilityUIElement.h:
370         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
371         (convertVectorToObjectArray):
372         (convertNSArrayToVector):
373         (searchTextParameterizedAttributeForCriteria):
374         (AccessibilityUIElement::getLinkedUIElements):
375         (AccessibilityUIElement::getDocumentLinks):
376         (AccessibilityUIElement::getChildren):
377         (AccessibilityUIElement::getChildrenWithRange):
378         (AccessibilityUIElement::rowHeaders const):
379         (AccessibilityUIElement::columnHeaders const):
380         (AccessibilityUIElement::uiElementArrayAttributeValue const):
381         (AccessibilityUIElement::searchTextWithCriteria):
382         (AccessibilityUIElement::attributesOfColumnHeaders):
383         (AccessibilityUIElement::attributesOfRowHeaders):
384         (AccessibilityUIElement::attributesOfColumns):
385         (AccessibilityUIElement::attributesOfRows):
386         (AccessibilityUIElement::attributesOfVisibleCells):
387         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
388         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
389         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
390         (WTR::convertVectorToObjectArray):
391         (WTR::convertNSArrayToVector):
392         (WTR::searchTextParameterizedAttributeForCriteria):
393         (WTR::AccessibilityUIElement::getLinkedUIElements):
394         (WTR::AccessibilityUIElement::getDocumentLinks):
395         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
396         (WTR::AccessibilityUIElement::getChildren):
397         (WTR::AccessibilityUIElement::getChildrenWithRange):
398         (WTR::AccessibilityUIElement::rowHeaders const):
399         (WTR::AccessibilityUIElement::columnHeaders const):
400         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
401         (WTR::AccessibilityUIElement::searchTextWithCriteria):
402         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
403         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
404         (WTR::AccessibilityUIElement::attributesOfColumns):
405         (WTR::AccessibilityUIElement::attributesOfRows):
406         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
407         (WTR::convertElementsToObjectArray): Deleted.
408
409 2019-04-23  Guy Lewin  <guy@lewin.co.il>
410
411         Multiple File Input Icon Set Regardless of File List
412         https://bugs.webkit.org/show_bug.cgi?id=195537
413
414         Reviewed by Alexey Proskuryakov.
415
416         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
417         display string in iOS file inputs
418
419         * DumpRenderTree/TestRunner.cpp:
420         (SetOpenPanelFilesMediaIconCallback):
421         (TestRunner::staticFunctions):
422         (TestRunner::setOpenPanelFilesMediaIcon):
423         * DumpRenderTree/TestRunner.h:
424         (TestRunner::openPanelFilesMediaIcon const):
425         * DumpRenderTree/mac/UIDelegate.mm:
426         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
427         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
428         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
429         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
430         * WebKitTestRunner/InjectedBundle/TestRunner.h:
431         * WebKitTestRunner/TestController.cpp:
432         (WTR::runOpenPanel):
433         (WTR::TestController::resetStateToConsistentValues):
434         * WebKitTestRunner/TestController.h:
435         (WTR::TestController::openPanelFileURLsMediaIcon const):
436         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
437         * WebKitTestRunner/TestInvocation.cpp:
438         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
439
440 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
441
442         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
443         https://bugs.webkit.org/show_bug.cgi?id=197171
444         <rdar://problem/47454979>
445
446         Reviewed by Youenn Fablet.
447
448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
449         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
450         (TestWebKitAPI::TEST):
451
452 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
453
454         [ews-build] Add unit tests for UnApplyPatchIfRequired
455         https://bugs.webkit.org/show_bug.cgi?id=197197
456
457         Reviewed by Lucas Forschler.
458
459         * BuildSlaveSupport/ews-build/steps_unittest.py:
460         (TestUnApplyPatchIfRequired):
461         (TestUnApplyPatchIfRequired.test_success):
462         (TestUnApplyPatchIfRequired.test_failure):
463         (TestUnApplyPatchIfRequired.test_skip):
464
465 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
466
467         [ews-build] Add unit tests for CleanWorkingDirectory
468         https://bugs.webkit.org/show_bug.cgi?id=197195
469
470         Reviewed by Lucas Forschler.
471
472         * BuildSlaveSupport/ews-build/steps_unittest.py:
473         (TestCleanWorkingDirectory):
474         (TestCleanWorkingDirectory.test_success):
475         (TestCleanWorkingDirectory.test_failure):
476
477 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
478
479         [ews-build] Use explicit imports instead of wildcard imports
480         https://bugs.webkit.org/show_bug.cgi?id=197194
481
482         Reviewed by Lucas Forschler.
483
484         * BuildSlaveSupport/ews-build/factories.py:
485         * BuildSlaveSupport/ews-build/loadConfig.py:
486         * BuildSlaveSupport/ews-build/steps_unittest.py:
487
488 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
489
490         [ews-build] Add unit tests for DownloadBuiltProduct
491         https://bugs.webkit.org/show_bug.cgi?id=197193
492
493         Reviewed by Lucas Forschler.
494
495         * BuildSlaveSupport/ews-build/steps_unittest.py:
496         (TestDownloadBuiltProduct):
497         (TestDownloadBuiltProduct.setUp):
498         (TestDownloadBuiltProduct.tearDown):
499         (TestDownloadBuiltProduct.test_success):
500         (TestDownloadBuiltProduct.test_failure):
501
502 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
503
504         [ews-app] Exception while loading status-bubble when no build step has started
505         https://bugs.webkit.org/show_bug.cgi?id=196676
506
507         Reviewed by Lucas Forschler.
508
509         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
510         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
511
512 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
513
514         [PlayStation] Support running of JSC tests on remote playstation devices
515         https://bugs.webkit.org/show_bug.cgi?id=197170
516
517         Reviewed by Ross Kirsling.
518
519         Script changes
520
521         * Scripts/run-javascriptcore-tests:
522         (runJSCStressTests): Pass arguments for playstation to
523         run-jsc-stress-tests
524         * Scripts/run-jsc-stress-tests:
525         Handle $hostOS=="playstation" for determineArchitecture, turning
526         off $isFTLPlatform and runProfiler and defaulting test writer.
527         * Scripts/webkitdirs.pm:
528         (jscPath): PlayStation WebKit executables have .elf extension
529         (executableProductDir): PlayStation builds on Windows hosts but
530         uses bin directory rather than bin64/bin32 for executable output
531         location.
532         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
533
534 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
535
536         [CMake][Win] Use target oriented design for WebKit
537         https://bugs.webkit.org/show_bug.cgi?id=197173
538
539         Reviewed by Alex Christensen.
540
541         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
542         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
543
544 2019-04-23  Chris Dumez  <cdumez@apple.com>
545
546         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
547         https://bugs.webkit.org/show_bug.cgi?id=197097
548         <rdar://problem/50048318>
549
550         Reviewed by Alex Christensen.
551
552         Add API test coverage.
553
554         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
555         (-[PSONScheme webView:startURLSchemeTask:]):
556
557 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
558
559         [ATK] Implement AtkComponentIface scroll_to methods
560         https://bugs.webkit.org/show_bug.cgi?id=196856
561
562         Reviewed by Michael Catanzaro.
563
564         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
565         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
566         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
567         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
568
569 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
570
571         [ews-build] Improve summary for UploadBuiltProduct step
572         https://bugs.webkit.org/show_bug.cgi?id=197182
573
574         Reviewed by Lucas Forschler.
575
576         * BuildSlaveSupport/ews-build/steps.py:
577         (UploadBuiltProduct): Added descriptionDone.
578         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
579         * BuildSlaveSupport/ews-build/steps_unittest.py:
580         (TestUploadBuiltProduct.test_success): Updated unit-test.
581         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
582
583 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
584
585         [ews-build] Trigger queues only after uploading the archive
586         https://bugs.webkit.org/show_bug.cgi?id=197180
587
588         Reviewed by Lucas Forschler.
589
590         * BuildSlaveSupport/ews-build/factories.py:
591         (Factory.__init__):
592         (BuildFactory.__init__): Remove trigger step from factories.
593         (BuildFactory.propertiesToPassToTriggers): Deleted.
594         * BuildSlaveSupport/ews-build/steps.py:
595         (ConfigureBuild.__init__): Confiure triggers property.
596         (Trigger): Step to trigger other queues.
597         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
598         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
599
600 2019-04-22  Alex Christensen  <achristensen@webkit.org>
601
602         Deprecate WKContextCreateWithInjectedBundlePath
603         https://bugs.webkit.org/show_bug.cgi?id=197169
604
605         Reviewed by Youenn Fablet.
606
607         * TestWebKitAPI/PlatformUtilities.cpp:
608         (TestWebKitAPI::Util::createContextWithInjectedBundle):
609         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
610
611 2019-04-22  Alex Christensen  <achristensen@webkit.org>
612
613         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
614         https://bugs.webkit.org/show_bug.cgi?id=197093
615         <rdar://problem/49708268>
616
617         Reviewed by Chris Dumez.
618
619         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
620         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
621         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
622         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
623         and one for loads without credentials, so there are two TCP connections to the same server in this test.
624
625         * TestWebKitAPI/TCPServer.cpp:
626         (TestWebKitAPI::TCPServer::TCPServer):
627         (TestWebKitAPI::TCPServer::~TCPServer):
628         (TestWebKitAPI::TCPServer::socketBindListen):
629         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
630         * TestWebKitAPI/TCPServer.h:
631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
632         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
633         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
634         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
635         (respondWithChallengeThenOK):
636         (TestWebKitAPI::TEST):
637         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
638         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
639         (TEST):
640
641 2019-04-22  Chris Dumez  <cdumez@apple.com>
642
643         Delayed WebProcessLaunch may break the _relatedWebView SPI
644         https://bugs.webkit.org/show_bug.cgi?id=197160
645
646         Reviewed by Alex Christensen.
647
648         Add API test coverage.
649
650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
651
652 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
653
654         Use curl to download packages for webkitpy autoinstaller
655         https://bugs.webkit.org/show_bug.cgi?id=197164
656
657         Reviewed by Darin Adler.
658
659         * Scripts/webkitpy/common/system/autoinstall.py:
660         (AutoInstaller._download): Use curl(1) to download packages necessary for
661         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
662         errors which are not present when using curl(1).
663
664 2019-04-22  Chris Dumez  <cdumez@apple.com>
665
666         Unreviewed, rolling out r244502.
667
668         Caused crashes on the bots
669
670         Reverted changeset:
671
672         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
673         https://bugs.webkit.org/show_bug.cgi?id=197160
674         https://trac.webkit.org/changeset/244502
675
676 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
677
678         Unreviewed, rolling out r244437.
679
680         Still breaks internal tests.
681
682         Reverted changeset:
683
684         "InjectedBundle parameters often need initialization function
685         called before unarchiving"
686         https://bugs.webkit.org/show_bug.cgi?id=189709
687         https://trac.webkit.org/changeset/244437
688
689 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
690
691         [ews-build] Use singular verb in failure description in case of single api test failure
692         https://bugs.webkit.org/show_bug.cgi?id=197013
693
694         Reviewed by Lucas Forschler.
695
696         * BuildSlaveSupport/ews-build/steps.py:
697         (AnalyzeAPITestsResults.analyzeResults):
698
699 2019-04-22  Chris Dumez  <cdumez@apple.com>
700
701         Delayed WebProcessLaunch may break the _relatedWebView SPI
702         https://bugs.webkit.org/show_bug.cgi?id=197160
703
704         Reviewed by Alex Christensen.
705
706         Add API test coverage.
707
708         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
709
710 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
711
712         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
713         https://bugs.webkit.org/show_bug.cgi?id=194630
714
715         Reviewed by Michael Catanzaro.
716
717         Return early from getAttributeSet() is passed in accessible is nullptr.
718
719         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
720
721 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
722
723         Defer EditorState updates until the next layer tree flush in a few additional circumstances
724         https://bugs.webkit.org/show_bug.cgi?id=197145
725         <rdar://problem/50078170>
726
727         Reviewed by Darin Adler.
728
729         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
730         focus, or showing the font manager.
731
732         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
733         (TestWebKitAPI::TEST):
734         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
735         (TEST):
736         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
737         (TestWebKitAPI::TEST):
738
739 2019-04-21  Brian Burg  <bburg@apple.com>
740
741         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
742         https://bugs.webkit.org/show_bug.cgi?id=197125
743         <rdar://problem/50061468>
744
745         Reviewed by Darin Adler.
746
747         Sometimes I want to run wptserve independently of tests. Make it easier to script that
748         using this class rather than making our own ./wpt serve invocation.
749
750         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
751         (WebDriverW3CWebServer):
752         (WebDriverW3CWebServer.document_root): Expose this to clients.
753         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
754
755         (WebDriverW3CWebServer.__enter__):
756         (WebDriverW3CWebServer.__exit__):
757         Make it possible to use the web server with a 'with' statement.
758
759 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
760
761         [CMake][Win] Use target oriented design for WebKitLegacy
762         https://bugs.webkit.org/show_bug.cgi?id=197112
763
764         Reviewed by Konstantin Tokarev.
765
766         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
767
768         * DumpRenderTree/CMakeLists.txt:
769         * DumpRenderTree/PlatformWin.cmake:
770         * DumpRenderTree/win/EventSender.cpp:
771
772 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
773
774         Update text for old EWS submit button
775         https://bugs.webkit.org/show_bug.cgi?id=197140
776
777         Reviewed by Alexey Proskuryakov.
778
779         * QueueStatusServer/templates/statusbubble.html:
780
781 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
782
783         [ews-app] New EWS should poll bugzilla more frequently
784         https://bugs.webkit.org/show_bug.cgi?id=197138
785
786         Reviewed by Alexey Proskuryakov.
787
788         * BuildSlaveSupport/ews-app/ews/fetcher.py:
789         (FetchLoop.__init__):
790
791 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
792
793         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
794         https://bugs.webkit.org/show_bug.cgi?id=197139
795
796         Reviewed by Alexey Proskuryakov.
797
798         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
799         * QueueStatusServer/templates/statusbubble.html:
800
801 2019-04-20  Chris Dumez  <cdumez@apple.com>
802
803         Unreviewed, fix iOS build with recent SDKs.
804
805         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
806
807 2019-04-19  Keith Miller  <keith_miller@apple.com>
808
809         Add script to merge run_benchmark jsons
810         https://bugs.webkit.org/show_bug.cgi?id=197107
811
812         Reviewed by Michael Saboff.
813
814         The script basically recursively decends through all json objects until it gets
815         to an array or JSON primitive and concats or takes the first value, respectively.
816
817         This patch also adds +x bits to the compare-results script so it
818         can be run directly from the command line. I had to add a new line so that svn
819         will accept the change... yay svn!
820
821         * Scripts/compare-results:
822         * Scripts/merge-result-jsons: Added.
823         (readJSONFile):
824         (deepAppend):
825         (mergeJSONs):
826         (main):
827
828 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
829
830         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
831         https://bugs.webkit.org/show_bug.cgi?id=197079
832
833         Reviewed by Darin Adler.
834
835         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
836
837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
838         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
839
840 2019-04-18  Commit Queue  <commit-queue@webkit.org>
841
842         Unreviewed, rolling out r244434.
843         https://bugs.webkit.org/show_bug.cgi?id=197089
844
845         caused 1 API test failure (Requested by zalan on #webkit).
846
847         Reverted changeset:
848
849         "Regression (r244291): Broken API Test
850         AutoLayoutRenderingProgressRelativeOrdering"
851         https://bugs.webkit.org/show_bug.cgi?id=196948
852         https://trac.webkit.org/changeset/244434
853
854 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
855
856         Add new compatibility mode API on WKNavigation
857         https://bugs.webkit.org/show_bug.cgi?id=197069
858         <rdar://problem/50025800>
859
860         Reviewed by Tim Horton.
861
862         Add a block property for -didCommitNavigation to TestNavigationDelegate.
863
864         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
865         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
866         (-[TestNavigationDelegate webView:didCommitNavigation:]):
867
868 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
869
870         [CMake] Make WebCore headers copies
871         https://bugs.webkit.org/show_bug.cgi?id=182512
872         <rdar://problem/37510435>
873
874         Reviewed by Alex Christensen.
875
876         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
877         ports.
878
879         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
880         of WebCore headers using "*.h" were modified to <WebCore/*.h>
881
882         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
883         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
884         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
885         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
886         * TestWebKitAPI/CMakeLists.txt:
887         * TestWebKitAPI/PlatformWin.cmake:
888         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
889         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
890         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
891
892 2019-04-18  Jer Noble  <jer.noble@apple.com>
893
894         Add support for parsing FairPlayStreaming PSSH boxes.
895         https://bugs.webkit.org/show_bug.cgi?id=197064
896
897         Reviewed by Eric Carlson.
898
899         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
900         (TestWebKitAPI::TEST):
901
902 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
903
904         InjectedBundle parameters often need initialization function called before unarchiving
905         https://bugs.webkit.org/show_bug.cgi?id=189709
906         <rdar://problem/44573653>
907
908         Reviewed by Ryosuke Niwa.
909
910         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
911         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
912
913 2019-04-18  Zalan Bujtas  <zalan@apple.com>
914
915         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
916         https://bugs.webkit.org/show_bug.cgi?id=196948
917         <rdar://problem/49927131>
918
919         Reviewed by Tim Horton.
920
921         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
922         (TEST): 
923         The expected order of incoming events is
924         1. didInvalidateIntrinsicContentSize
925         2. didFirstLayout
926         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
927         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
928         (and remember, all we care about is ordering).
929
930 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
931
932         Unreviewed, rolling out r244299.
933
934         Breaks internal tests.
935
936         Reverted changeset:
937
938         "InjectedBundle parameters often need initialization function
939         called before unarchiving"
940         https://bugs.webkit.org/show_bug.cgi?id=189709
941         https://trac.webkit.org/changeset/244299
942
943 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
944
945         [WTF] StringBuilder should set correct m_is8Bit flag when merging
946         https://bugs.webkit.org/show_bug.cgi?id=197053
947
948         Reviewed by Saam Barati.
949
950         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
951         (TestWebKitAPI::TEST):
952
953 2019-04-17  Tim Horton  <timothy_horton@apple.com>
954
955         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
956         https://bugs.webkit.org/show_bug.cgi?id=197028
957         <rdar://problem/49985290>
958
959         Reviewed by Wenson Hsieh.
960
961         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
962         (TEST):
963         Liberal application of waitForNextPresentationUpdate works around a race
964         where if the page rapidly changes its viewport arguments (or an API client
965         rapidly changes its viewport arguments), we'd get stuck thinking that the
966         user had intentionally zoomed the page, and stop resetting the initial scale.
967         This deserves a separate bug, but no need to keep the test failing while
968         we think about it.
969
970 2019-04-17  Tim Horton  <timothy_horton@apple.com>
971
972         REGRESSION (r241988): Switching tabs is slow
973         https://bugs.webkit.org/show_bug.cgi?id=197037
974         <rdar://problem/49951473>
975
976         Reviewed by Simon Fraser.
977
978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
979         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
980         (TEST):
981         * TestWebKitAPI/cocoa/TestWKWebView.h:
982         * TestWebKitAPI/cocoa/TestWKWebView.mm:
983         (-[TestWKWebView addToTestWindow]):
984         Add a test that hangs without this fix.
985
986 2019-04-17  Truitt Savell  <tsavell@apple.com>
987
988         Unreviewed, rolling out r244400.
989
990         Caused testing to exit early with assertionon Debug WK2
991
992         Reverted changeset:
993
994         "UI↔Web deadlock when printing with a JavaScript alert
995         visible"
996         https://bugs.webkit.org/show_bug.cgi?id=196839
997         https://trac.webkit.org/changeset/244400
998
999 2019-04-17  Brady Eidson  <beidson@apple.com>
1000
1001         Link clicks in PDFs shouldn't send referrer headers.
1002         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1003
1004         Reviewed by Tim Horton.
1005
1006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1007         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1008         (putPDFBytesCallback):
1009         (emptyReleaseInfoCallback):
1010         (createPDFWithLinkToURL):
1011         (TEST):
1012
1013 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1014
1015         UI↔Web deadlock when printing with a JavaScript alert visible
1016         https://bugs.webkit.org/show_bug.cgi?id=196839
1017         <rdar://problem/49157642>
1018
1019         Reviewed by Andy Estes.
1020
1021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1022         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1023         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1024         (TEST):
1025
1026 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1027
1028         WKRetainPtr's adoption constructor should be private
1029         https://bugs.webkit.org/show_bug.cgi?id=197019
1030
1031         Reviewed by Tim Horton.
1032
1033         * DumpRenderTree/mac/DumpRenderTree.mm:
1034         (dumpFramesAsText):
1035         * TestWebKitAPI/InjectedBundleController.cpp:
1036         (TestWebKitAPI::InjectedBundleController::initialize):
1037         * TestWebKitAPI/PlatformUtilities.cpp:
1038         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1039         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1040         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1041         (TestWebKitAPI::Util::toWK):
1042         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1043         (TestWebKitAPI::TEST):
1044         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1045         (TestWebKitAPI::TEST):
1046         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1047         (TestWebKitAPI::TEST):
1048         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1049         (TestWebKitAPI::TEST):
1050         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1051         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1052         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1053         (TestWebKitAPI::TEST):
1054         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1055         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1056         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1057         (TestWebKitAPI::TEST):
1058         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1059         (TestWebKitAPI::TEST):
1060         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1061         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1062         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1063         (TestWebKitAPI::TEST):
1064         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1065         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1066         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1067         (TestWebKitAPI::TEST):
1068         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1069         (TestWebKitAPI::TEST):
1070         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1071         (TestWebKitAPI::TEST):
1072         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1073         (TestWebKitAPI::TEST):
1074         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1075         (TestWebKitAPI::TEST):
1076         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1077         (TestWebKitAPI::TEST):
1078         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1079         (TestWebKitAPI::TEST):
1080         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1081         (TestWebKitAPI::TEST):
1082         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1083         (TestWebKitAPI::TEST):
1084         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1085         (TestWebKitAPI::TEST):
1086         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1087         (TestWebKitAPI::TEST):
1088         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1089         (TestWebKitAPI::TEST):
1090         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1091         (TestWebKitAPI::TEST):
1092         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1093         (TestWebKitAPI::TEST):
1094         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1095         (TestWebKitAPI::TEST):
1096         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1097         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1098         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1099         (TestWebKitAPI::TEST):
1100         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1101         (TestWebKitAPI::TEST):
1102         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1103         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1104         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1105         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1106         (TestWebKitAPI::TEST):
1107         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1108         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1109         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1110         (TestWebKitAPI::TEST):
1111         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1112         (TestWebKitAPI::TEST):
1113         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1114         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1115         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1116         (TestWebKitAPI::TEST):
1117         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1118         (TestWebKitAPI::loadAlternateHTMLString):
1119         (TestWebKitAPI::TEST):
1120         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1121         (TestWebKitAPI::TEST):
1122         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1123         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1124         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1125         (TestWebKitAPI::buildAndPerformTest):
1126         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1127         (TestWebKitAPI::TEST):
1128         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1129         (TestWebKitAPI::TEST):
1130         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1131         (TestWebKitAPI::TEST):
1132         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1133         (TestWebKitAPI::TEST):
1134         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1135         (TestWebKitAPI::TEST):
1136         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1137         (TestWebKitAPI::TEST):
1138         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1139         (TestWebKitAPI::TEST):
1140         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1141         (TestWebKitAPI::TEST):
1142         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1143         (TestWebKitAPI::TEST):
1144         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1145         (TestWebKitAPI::TEST):
1146         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1147         (TestWebKitAPI::TEST):
1148         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1149         (TestWebKitAPI::TEST):
1150         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1151         (TestWebKitAPI::TEST):
1152         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1153         (TestWebKitAPI::TEST):
1154         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1155         (TestWebKitAPI::TEST):
1156         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1157         (TestWebKitAPI::TEST):
1158         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1159         (TestWebKitAPI::TEST):
1160         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1161         (TestWebKitAPI::TEST):
1162         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1163         (TestWebKitAPI::TEST):
1164         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1165         (TestWebKitAPI::TEST):
1166         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1167         (TestWebKitAPI::TEST):
1168         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1169         (TestWebKitAPI::TEST):
1170         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1171         (TestWebKitAPI::TEST):
1172         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1173         (TestWebKitAPI::TEST):
1174         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1175         (TestWebKitAPI::TEST):
1176         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1177         (TestWebKitAPI::TEST):
1178         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1179         (TestWebKitAPI::TEST):
1180         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1181         (TestWebKitAPI::TEST):
1182         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1183         (TestWebKitAPI::TEST):
1184         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1185         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1186         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1187         (TestWebKitAPI::TEST):
1188         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1189         (TestWebKitAPI::TEST):
1190         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1191         (TestWebKitAPI::TEST):
1192         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1193         (TestWebKitAPI::TEST):
1194         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1195         (TestWebKitAPI::TEST):
1196         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1197         (TestWebKitAPI::TEST):
1198         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1199         (TestWebKitAPI::TEST):
1200         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1201         (TestWebKitAPI::TEST):
1202         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1203         (TestWebKitAPI::TEST):
1204         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1205         (TestWebKitAPI::TEST):
1206         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1207         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1208         (TEST):
1209         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1210         (TEST):
1211         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1212         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1213         (TEST):
1214         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1215         (TestWebKitAPI::TEST):
1216         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1217         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1218         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1219         (WTR::getMenuItemTitleCallback):
1220         (WTR::createMouseMessageBody):
1221         (WTR::EventSendingController::mouseDown):
1222         (WTR::EventSendingController::mouseUp):
1223         (WTR::EventSendingController::mouseMoveTo):
1224         (WTR::EventSendingController::mouseForceClick):
1225         (WTR::EventSendingController::startAndCancelMouseForceClick):
1226         (WTR::EventSendingController::mouseForceDown):
1227         (WTR::EventSendingController::mouseForceUp):
1228         (WTR::EventSendingController::mouseForceChanged):
1229         (WTR::EventSendingController::leapForward):
1230         (WTR::EventSendingController::scheduleAsynchronousClick):
1231         (WTR::createKeyDownMessageBody):
1232         (WTR::EventSendingController::keyDown):
1233         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1234         (WTR::EventSendingController::mouseScrollBy):
1235         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1236         (WTR::EventSendingController::continuousMouseScrollBy):
1237         (WTR::EventSendingController::addTouchPoint):
1238         (WTR::EventSendingController::updateTouchPoint):
1239         (WTR::EventSendingController::setTouchModifier):
1240         (WTR::EventSendingController::setTouchPointRadius):
1241         (WTR::EventSendingController::touchStart):
1242         (WTR::EventSendingController::touchMove):
1243         (WTR::EventSendingController::touchEnd):
1244         (WTR::EventSendingController::touchCancel):
1245         (WTR::EventSendingController::clearTouchPoints):
1246         (WTR::EventSendingController::releaseTouchPoint):
1247         (WTR::EventSendingController::cancelTouchPoint):
1248         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1249         (WTR::InjectedBundle::didCreatePage):
1250         (WTR::InjectedBundle::didReceiveMessage):
1251         (WTR::InjectedBundle::didReceiveMessageToPage):
1252         (WTR::InjectedBundle::booleanForKey):
1253         (WTR::InjectedBundle::done):
1254         (WTR::InjectedBundle::dumpToStdErr):
1255         (WTR::InjectedBundle::outputText):
1256         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1257         (WTR::InjectedBundle::postAddChromeInputField):
1258         (WTR::InjectedBundle::postRemoveChromeInputField):
1259         (WTR::InjectedBundle::postFocusWebView):
1260         (WTR::InjectedBundle::postSetBackingScaleFactor):
1261         (WTR::InjectedBundle::postSetWindowIsKey):
1262         (WTR::InjectedBundle::postSetViewSize):
1263         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1264         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1265         (WTR::InjectedBundle::setGeolocationPermission):
1266         (WTR::InjectedBundle::setMockGeolocationPosition):
1267         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1268         (WTR::InjectedBundle::isGeolocationProviderActive const):
1269         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1270         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1271         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1272         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1273         (WTR::InjectedBundle::setCustomPolicyDelegate):
1274         (WTR::InjectedBundle::setHidden):
1275         (WTR::InjectedBundle::setCacheModel):
1276         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1277         (WTR::InjectedBundle::processWorkQueue):
1278         (WTR::InjectedBundle::queueBackNavigation):
1279         (WTR::InjectedBundle::queueForwardNavigation):
1280         (WTR::InjectedBundle::queueLoad):
1281         (WTR::InjectedBundle::queueLoadHTMLString):
1282         (WTR::InjectedBundle::queueReload):
1283         (WTR::InjectedBundle::queueLoadingScript):
1284         (WTR::InjectedBundle::queueNonLoadingScript):
1285         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1286         (WTR::frameToStr):
1287         (WTR::InjectedBundlePage::InjectedBundlePage):
1288         (WTR::dumpFrameDescriptionSuitableForTestResult):
1289         (WTR::dumpFrameScrollPosition):
1290         (WTR::dumpDescendantFrameScrollPositions):
1291         (WTR::dumpFrameText):
1292         (WTR::dumpDescendantFramesText):
1293         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1294         (WTR::TestRunner::shouldDumpPixels const):
1295         (WTR::TestRunner::setDumpPixels):
1296         (WTR::TestRunner::whatToDump const):
1297         (WTR::TestRunner::setWhatToDump):
1298         (WTR::TestRunner::setWaitUntilDone):
1299         (WTR::TestRunner::shouldWaitUntilDone const):
1300         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1301         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1302         (WTR::TestRunner::clearAllDatabases):
1303         (WTR::TestRunner::setIDBPerOriginQuota):
1304         (WTR::TestRunner::originsWithApplicationCache):
1305         (WTR::TestRunner::setCanOpenWindows):
1306         (WTR::TestRunner::setXSSAuditorEnabled):
1307         (WTR::TestRunner::setMediaDevicesEnabled):
1308         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1309         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1310         (WTR::TestRunner::setCustomUserAgent):
1311         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1312         (WTR::TestRunner::setModernMediaControlsEnabled):
1313         (WTR::TestRunner::setWebGL2Enabled):
1314         (WTR::TestRunner::setWritableStreamAPIEnabled):
1315         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1316         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1317         (WTR::TestRunner::setAllowsAnySSLCertificate):
1318         (WTR::TestRunner::setPluginsEnabled):
1319         (WTR::TestRunner::setValueForUser):
1320         (WTR::TestRunner::setAudioResult):
1321         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1322         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1323         (WTR::TestRunner::setAlwaysAcceptCookies):
1324         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1325         (WTR::TestRunner::isDoingMediaCapture const):
1326         (WTR::TestRunner::queueLoad):
1327         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1328         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1329         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1330         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1331         (WTR::TestRunner::setAuthenticationUsername):
1332         (WTR::TestRunner::setAuthenticationPassword):
1333         (WTR::TestRunner::secureEventInputIsEnabled const):
1334         (WTR::TestRunner::setBlockAllPlugins):
1335         (WTR::TestRunner::setPluginSupportedMode):
1336         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1337         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1338         (WTR::TestRunner::setNavigationGesturesEnabled):
1339         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1340         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1341         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1342         (WTR::TestRunner::terminateNetworkProcess):
1343         (WTR::TestRunner::terminateServiceWorkerProcess):
1344         (WTR::TestRunner::runUIScript):
1345         (WTR::TestRunner::setStatisticsDebugMode):
1346         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1347         (WTR::TestRunner::setStatisticsLastSeen):
1348         (WTR::TestRunner::setStatisticsPrevalentResource):
1349         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1350         (WTR::TestRunner::dumpResourceLoadStatistics):
1351         (WTR::TestRunner::isStatisticsPrevalentResource):
1352         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1353         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1354         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1355         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1356         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1357         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1358         (WTR::TestRunner::setStatisticsGrandfathered):
1359         (WTR::TestRunner::isStatisticsGrandfathered):
1360         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1361         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1362         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1363         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1364         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1365         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1366         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1367         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1368         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1369         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1370         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1371         (WTR::TestRunner::statisticsSubmitTelemetry):
1372         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1373         (WTR::TestRunner::setStatisticsIsRunningTest):
1374         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1375         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1376         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1377         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1378         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1379         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1380         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1381         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1382         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1383         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1384         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1385         (WTR::TestRunner::statisticsResetToConsistentState):
1386         (WTR::TestRunner::setStorageAccessAPIEnabled):
1387         (WTR::TestRunner::getAllStorageAccessEntries):
1388         (WTR::TestRunner::addMockMediaDevice):
1389         (WTR::TestRunner::clearMockMediaDevices):
1390         (WTR::TestRunner::removeMockMediaDevice):
1391         (WTR::TestRunner::resetMockMediaDevices):
1392         (WTR::TestRunner::connectMockGamepad):
1393         (WTR::TestRunner::disconnectMockGamepad):
1394         (WTR::TestRunner::setMockGamepadDetails):
1395         (WTR::TestRunner::setMockGamepadAxisValue):
1396         (WTR::TestRunner::setMockGamepadButtonValue):
1397         (WTR::TestRunner::removeAllSessionCredentials):
1398         (WTR::TestRunner::clearDOMCache):
1399         (WTR::TestRunner::clearDOMCaches):
1400         (WTR::TestRunner::hasDOMCache):
1401         (WTR::TestRunner::domCacheSize):
1402         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1403         (WTR::TestRunner::getApplicationManifestThen):
1404         (WTR::TestRunner::injectUserScript):
1405         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1406         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1407         (WTR::TestRunner::addTestKeyToKeychain):
1408         (WTR::TestRunner::cleanUpKeychain):
1409         (WTR::TestRunner::keyExistsInKeychain):
1410         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1411         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1412         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1413         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1414         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1415         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1416         * WebKitTestRunner/TestController.cpp:
1417         (WTR::TestController::initialize):
1418         (WTR::parseStringTestHeaderValueAsRelativePath):
1419         (WTR::updateTestOptionsFromTestHeader):
1420         (WTR::TestController::runTest):
1421         (WTR::TestController::didReceiveLiveDocumentsList):
1422         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1423         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1424         (WTR::TestController::didFinishNavigation):
1425         (WTR::TestController::didReceiveAuthenticationChallenge):
1426         * WebKitTestRunner/TestInvocation.cpp:
1427         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1428         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1429         (WTR::TestInvocation::uiScriptDidComplete):
1430         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1431         * WebKitTestRunner/WebNotificationProvider.cpp:
1432         (WTR::WebNotificationProvider::closeWebNotification):
1433         * WebKitTestRunner/WorkQueueManager.cpp:
1434         (WTR::ScriptItem::ScriptItem):
1435         (WTR::WorkQueueManager::queueLoad):
1436         (WTR::WorkQueueManager::queueLoadHTMLString):
1437
1438 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1439
1440         Add a comment to make my test from r244139 less mysterious.
1441         https://bugs.webkit.org/show_bug.cgi?id=196744
1442
1443         As suggested by Darin Adler.
1444
1445         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1446         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1447
1448 2019-04-17  Chris Dumez  <cdumez@apple.com>
1449
1450         Remember device orientation permission for the duration of the browsing session
1451         https://bugs.webkit.org/show_bug.cgi?id=196992
1452         <rdar://problem/49946067>
1453
1454         Reviewed by Alex Christensen.
1455
1456         Add API test coverage.
1457
1458         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1459         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1460         (TEST):
1461
1462 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1463
1464         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1465         https://bugs.webkit.org/show_bug.cgi?id=196675
1466
1467         Reviewed by Lucas Forschler.
1468
1469         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1470         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1471
1472 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1473
1474         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1475         https://bugs.webkit.org/show_bug.cgi?id=196919
1476         <rdar://problem/41630459>
1477
1478         Reviewed by Tim Horton.
1479
1480         Add iOS support for several new testing hooks. See below for more detail.
1481
1482         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1483         (WTR::UIScriptController::isDismissingMenu const):
1484
1485         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1486         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1487         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1488
1489         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1490         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1491         (WTR::UIScriptController::isDismissingMenu const):
1492         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1493         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1494         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1495         (WTR::InjectedBundle::didReceiveMessageToPage):
1496         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1497         (WTR::TestRunner::setAllowedMenuActions):
1498
1499         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1500         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1501         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1502         against the name of the custom action.
1503
1504         (WTR::TestRunner::installCustomMenuAction):
1505
1506         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1507         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1508         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1509         triggered.
1510
1511         (WTR::TestRunner::performCustomMenuAction):
1512
1513         Invoked when the custom menu action is triggered.
1514
1515         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1516         * WebKitTestRunner/TestController.cpp:
1517         (WTR::TestController::installCustomMenuAction):
1518         (WTR::TestController::setAllowedMenuActions):
1519         * WebKitTestRunner/TestController.h:
1520         * WebKitTestRunner/TestInvocation.cpp:
1521         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1522         (WTR::TestInvocation::performCustomMenuAction):
1523
1524         Add plumbing to call back into the injected bundle when performing the custom action.
1525
1526         * WebKitTestRunner/TestInvocation.h:
1527         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1528         (WTR::TestController::installCustomMenuAction):
1529         (WTR::TestController::setAllowedMenuActions):
1530         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1531         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1532         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1533         (-[TestRunnerWKWebView becomeFirstResponder]):
1534         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1535
1536         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1537         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1538         in the Mail app on iOS.
1539
1540         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1541         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1542         (-[TestRunnerWKWebView resetCustomMenuAction]):
1543         (-[TestRunnerWKWebView performCustomAction:]):
1544         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1545         (-[TestRunnerWKWebView _willHideMenu]):
1546         (-[TestRunnerWKWebView _didHideMenu]):
1547         * WebKitTestRunner/ios/TestControllerIOS.mm:
1548         (WTR::TestController::platformResetStateToConsistentValues):
1549
1550         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1551         if specified.
1552
1553         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1554         (WTR::UIScriptController::isDismissingMenu const):
1555
1556 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1557
1558         Allow sharing from imageSheet on an image document
1559         https://bugs.webkit.org/show_bug.cgi?id=196891
1560         <rdar://problem/25377386>
1561
1562         Reviewed by Tim Horton.
1563
1564         Test to make sure that the correct imageURL is extracted from an image element.
1565
1566         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1567         (TestWebKitAPI::TEST):
1568
1569 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1570
1571         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1572         https://bugs.webkit.org/show_bug.cgi?id=196995
1573
1574         Reviewed by Brady Eidson.
1575
1576         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1577         (TEST):
1578
1579 2019-04-16  Chris Dumez  <cdumez@apple.com>
1580
1581         URL set by document.open() is not communicated to the UIProcess
1582         https://bugs.webkit.org/show_bug.cgi?id=196941
1583         <rdar://problem/49237544>
1584
1585         Reviewed by Geoff Garen.
1586
1587         Add API test coverage.
1588
1589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1590         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1591         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1592         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1593         (TEST):
1594
1595 2019-04-16  Commit Queue  <commit-queue@webkit.org>
1596
1597         Unreviewed, rolling out r244321.
1598         https://bugs.webkit.org/show_bug.cgi?id=196968
1599
1600         Causing all WK2 Debug builds to exit early after Assertion
1601         failures. (Requested by ShawnRoberts on #webkit).
1602
1603         Reverted changeset:
1604
1605         "URL set by document.open() is not communicated to the
1606         UIProcess"
1607         https://bugs.webkit.org/show_bug.cgi?id=196941
1608         https://trac.webkit.org/changeset/244321
1609
1610 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1611
1612         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1613         https://bugs.webkit.org/show_bug.cgi?id=196948
1614
1615         Reviewed by Zalan Bujtas.
1616
1617         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1618         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1619
1620 2019-04-15  Chris Dumez  <cdumez@apple.com>
1621
1622         URL set by document.open() is not communicated to the UIProcess
1623         https://bugs.webkit.org/show_bug.cgi?id=196941
1624         <rdar://problem/49237544>
1625
1626         Reviewed by Geoffrey Garen.
1627
1628         Add API test coverage.
1629
1630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1631         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1632         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1633         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1634         (TEST):
1635
1636 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1637
1638         Using Tools/Scripts/clean-webkit should not install requests
1639         https://bugs.webkit.org/show_bug.cgi?id=196940
1640
1641         Reviewed by Lucas Forschler.
1642
1643         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1644         existing, depending on the path autoinstalled is run through.
1645         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1646         needed.
1647         (Port.configuration_for_upload):
1648         (Port.commits_for_upload):
1649
1650 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1651
1652         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1653         https://bugs.webkit.org/show_bug.cgi?id=196773
1654
1655         Reviewed by Jer Noble.
1656
1657         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1658         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1659         (TEST):
1660
1661 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1662
1663         ews-build should clearly indicate flaky test failures
1664         https://bugs.webkit.org/show_bug.cgi?id=196947
1665
1666         Reviewed by Lucas Forschler.
1667
1668         * BuildSlaveSupport/ews-build/steps.py:
1669         (AnalyzeAPITestsResults.analyzeResults):
1670
1671 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1672
1673         InjectedBundle parameters often need initialization function called before unarchiving
1674         https://bugs.webkit.org/show_bug.cgi?id=189709
1675         <rdar://problem/44573653>
1676
1677         Reviewed by Ryosuke Niwa.
1678
1679         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1680         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1681
1682 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1683
1684         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1685         https://bugs.webkit.org/show_bug.cgi?id=196681
1686
1687         Reviewed by Darin Adler.
1688
1689         Added tests.
1690
1691         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1692         (WTF_HashSet.RemoveIf):
1693         (WTF_HashSet.RemoveIfShrinkToBestSize):
1694
1695 2019-04-15  John Wilander  <wilander@apple.com>
1696
1697         Send delayed Ad Click Attribution conversion requests to the click source
1698         https://bugs.webkit.org/show_bug.cgi?id=196838
1699         <rdar://problem/47650157>
1700
1701         Reviewed by Chris Dumez and Youenn Fablet.
1702
1703         This patch adds test infrastructure to override the default behavior in
1704         WebKit::NetworkAdClickAttribution.
1705
1706         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1707         (TestWebKitAPI::TEST):
1708         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1709         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1710         (WTR::TestRunner::dumpAdClickAttribution):
1711         (WTR::TestRunner::clearAdClickAttribution):
1712         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1713         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1714         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1715         * WebKitTestRunner/TestController.cpp:
1716         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1717         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1718         * WebKitTestRunner/TestController.h:
1719         * WebKitTestRunner/TestInvocation.cpp:
1720         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1721
1722 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1723
1724         [ews-app] status-bubble should display position in queue
1725         https://bugs.webkit.org/show_bug.cgi?id=196607
1726
1727         Reviewed by Lucas Forschler.
1728
1729         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1730         (StatusBubble._build_bubble):
1731         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1732
1733 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1734
1735         [ews-build] Do not run clean build by default on EWS builders
1736         https://bugs.webkit.org/show_bug.cgi?id=196897
1737
1738         Reviewed by Lucas Forschler.
1739
1740         * BuildSlaveSupport/ews-build/steps.py:
1741         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1742         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1743         untracked directories like WebKitBuild).
1744         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1745         untracked files/directories (like WebKitBuild).
1746
1747 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1748
1749         TestRunner::notifyDone() should be safely reentrant
1750         https://bugs.webkit.org/show_bug.cgi?id=196898
1751
1752         Reviewed by Darin Adler.
1753
1754         It is currently possible that TestRunner::notifyDone() will call itself, since
1755         notifyDone() will force a repaint, which can start executing JavaScript, which
1756         may call notifyDone() again. This can lead to test failures and flakiness.
1757         Fix this by setting the m_waitToDump flag before calling the dump() method.
1758
1759         * DumpRenderTree/mac/TestRunnerMac.mm:
1760         (TestRunner::notifyDone):
1761         (TestRunner::forceImmediateCompletion):
1762         * DumpRenderTree/win/TestRunnerWin.cpp:
1763         (TestRunner::notifyDone):
1764         (TestRunner::forceImmediateCompletion):
1765
1766 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1767
1768         [GTK][WPE] Add enable-media websetting
1769         https://bugs.webkit.org/show_bug.cgi?id=196863
1770
1771         Reviewed by Michael Catanzaro.
1772
1773         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1774         (testWebKitSettings): Add test for the enable-media web-setting.
1775
1776 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1777
1778         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1779         https://bugs.webkit.org/show_bug.cgi?id=196905
1780         <rdar://problem/49886096>
1781
1782         Reviewed by Tim Horton.
1783
1784         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1785         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1786         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1787         delay timer, we end up with this sequence of events in the problematic (failure) case:
1788
1789         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1790             ...IPC from UI to web process...
1791         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1792             ...IPC from web to UI process...
1793         (c) [UI]    Invoke completion handler for script #1
1794         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1795             ...IPC from UI to web process...
1796         (e) [Web]   Evaluate script #2 in the web process
1797         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1798
1799         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1800         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1801         #2 is run in step (e).
1802
1803         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1804         the UI process by waiting on a script message posted by the web process, after attachment updates are
1805         dispatched.
1806
1807         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1808         (TestWebKitAPI::TEST):
1809
1810 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1811
1812         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1813         https://bugs.webkit.org/show_bug.cgi?id=196909
1814
1815         Reviewed by Wenson Hsieh.
1816
1817         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1818         (TestWebKitAPI::TEST):
1819
1820 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1821
1822         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1823         https://bugs.webkit.org/show_bug.cgi?id=196880
1824
1825         Reviewed by Yusuke Suzuki.
1826
1827         Add a new function for bytecode cache tests that does not forceDiskCache
1828         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1829         test added in this patch, since the code is invalid and therefore won't be
1830         cached. It should also be useful for tests that evaluate dynamically
1831         generated code.
1832
1833         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1834         * Scripts/run-jsc-stress-tests:
1835
1836 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1837
1838         Update AudioSession route sharing policy
1839         https://bugs.webkit.org/show_bug.cgi?id=196776
1840         <rdar://problem/46501611>
1841
1842         Reviewed by Jer Noble.
1843
1844         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1845         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1846         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1847         (TestWebKitAPI::TEST):
1848
1849 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1850
1851         [iOS] Software keyboard is shown too frequently on some websites
1852         https://bugs.webkit.org/show_bug.cgi?id=195856
1853         <rdar://problem/49191395>
1854
1855         Reviewed by Darin Adler.
1856
1857         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1858
1859         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1860         (WTR::UIScriptController::setHardwareKeyboardAttached):
1861         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1862         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1863         (WTR::UIScriptController::setHardwareKeyboardAttached):
1864         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1865         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1866
1867         Additionally link against GraphicsServices in WebKitTestRunner.
1868
1869         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1870         (WTR::TestController::platformResetStateToConsistentValues):
1871         (WTR::UIScriptController::setHardwareKeyboardAttached):
1872
1873 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1874
1875         [GTK][WPE] Fix pacman install-dependencies packages
1876         https://bugs.webkit.org/show_bug.cgi?id=196817
1877
1878         Reviewed by Žan Doberšek.
1879         
1880         python3-setuptools is called python-setuptools
1881         ruby-highline is only available on AUR
1882         libv4l-devel is incorporated in v4l-utils
1883
1884         * gtk/install-dependencies:
1885         * wpe/install-dependencies:
1886
1887 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1888
1889         [GTK] REGRESSION(r243860): Many tests failing
1890         https://bugs.webkit.org/show_bug.cgi?id=196791
1891
1892         Reviewed by Joanmarie Diggs.
1893
1894         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1895         multiple documents and check that accessibility hierarchy is updated after a navigation.
1896
1897         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1898         (loadChangedCallback):
1899         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1900         (AccessibilityTest::AccessibilityTest):
1901         (AccessibilityTest::~AccessibilityTest):
1902         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1903         (AccessibilityTest::findTestServerApplication):
1904         (AccessibilityTest::findDocumentWeb):
1905         (AccessibilityTest::findRootObject):
1906         (AccessibilityTest::waitUntilChildrenRemoved):
1907         (AccessibilityTest::ensureProxy):
1908         (testAtspiBasicHierarchy):
1909         (beforeAll):
1910         (afterAll):
1911
1912 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1913
1914         [ews-build] Handle bug titles with unicode characters
1915         https://bugs.webkit.org/show_bug.cgi?id=196802
1916
1917         Reviewed by Dewei Zhu.
1918
1919         * BuildSlaveSupport/ews-build/steps.py:
1920         (ValidatePatch._is_bug_closed):
1921
1922 2019-04-11  Michael Saboff  <msaboff@apple.com>
1923
1924         Improve the Inline Cache Stats code
1925         https://bugs.webkit.org/show_bug.cgi?id=196836
1926
1927         Reviewed by Saam Barati.
1928
1929         Added a new script to consolidate and arrange the output of --useICStats option.
1930
1931         This script merges the output from every group into one large table and sorts it from most common to
1932         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1933         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1934         Put together, this is useful to see what property accesses are not getting cached.
1935
1936         * Scripts/ic-stats.py: Added.
1937         (ICStats):
1938         (ICStats.__init__):
1939         (ICStats.parse):
1940         (ICStats.dumpStats):
1941         (usage):
1942
1943 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1944
1945         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1946         https://bugs.webkit.org/show_bug.cgi?id=196809
1947         <rdar://49800762>
1948
1949         Reviewed by Brady Eidson.
1950
1951         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1952         (TEST):
1953
1954 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1955
1956         requestAnimationFrame should execute before the next frame
1957         https://bugs.webkit.org/show_bug.cgi?id=177484
1958
1959         Reviewed by Simon Fraser.
1960
1961         Add trace points for the page RenderingUpdate.
1962
1963         * Tracing/SystemTracePoints.plist:
1964
1965 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1966
1967         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1968         https://bugs.webkit.org/show_bug.cgi?id=196760
1969
1970         Reviewed by Don Olmstead.
1971
1972         vswhere.exe has been bundled since Visual Studio 2017 version
1973         15.2. We shouldn't download vswhere.exe.
1974
1975         * Scripts/build-jsc: Do not call update-vswhere.py.
1976         * Scripts/build-webkit: Ditto.
1977         * Scripts/update-vswhere.py: Removed.
1978         * Scripts/webkitdirs.pm:
1979         (requireModulesForVSWhere): Deleted.
1980         (pickCurrentVisualStudioInstallation): Deleted.
1981         (visualStudioInstallDirVSWhere): Return the latest installed VS
1982         installation path by using the bundled vswhere.exe.
1983         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1984         (visualStudioInstallDirFallback): Removed.
1985
1986 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1987
1988         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1989         https://bugs.webkit.org/show_bug.cgi?id=196780
1990
1991         Reviewed by Alexey Proskuryakov.
1992
1993         * BuildSlaveSupport/ews-build/steps.py:
1994         * BuildSlaveSupport/ews-build/steps_unittest.py:
1995
1996 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1997
1998         Add SPI WKNavigationResponse._downloadAttribute
1999         https://bugs.webkit.org/show_bug.cgi?id=196755
2000         <rdar://49587365>
2001
2002         Reviewed by Brady Eidson.
2003
2004         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2005         (-[NavigationResponseTestDelegate navigationResponse]):
2006         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2007         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2008         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2009         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2010         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2011         (readRequest):
2012         (writeResponse):
2013         (TEST):
2014
2015 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2016
2017         Add modern API for overriding the page's specified viewport configuration
2018         https://bugs.webkit.org/show_bug.cgi?id=167734
2019         <rdar://problem/30331795>
2020
2021         Reviewed by Simon Fraser.
2022
2023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2024         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2025
2026 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2027
2028         Add support for incremental bytecode cache updates
2029         https://bugs.webkit.org/show_bug.cgi?id=195000
2030
2031         Reviewed by Filip Pizlo.
2032
2033         Exit when the initial run to generate bytecode fails.
2034
2035         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2036
2037 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2038
2039         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2040         https://bugs.webkit.org/show_bug.cgi?id=196744
2041         <rdar://49415309>
2042
2043         Reviewed by Chris Dumez.
2044
2045         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2046         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2047
2048 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2049
2050         Add a way to opt into modern compatibility mode in layout tests
2051         https://bugs.webkit.org/show_bug.cgi?id=196770
2052         <rdar://problem/49777550>
2053
2054         Reviewed by Antoine Quint.
2055
2056         Add a new test option to enable modern compatibility mode in layout tests.
2057
2058         * WebKitTestRunner/TestController.cpp:
2059         (WTR::updateTestOptionsFromTestHeader):
2060         * WebKitTestRunner/TestController.h:
2061         * WebKitTestRunner/TestOptions.h:
2062         (WTR::TestOptions::hasSameInitializationOptions const):
2063         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2064         (WTR::TestController::platformCreateWebView):
2065         (WTR::TestController::enableModernCompatibilityMode):
2066
2067 2019-04-10  Andy Estes  <aestes@apple.com>
2068
2069         Try to fix the 32-bit watchOS build.
2070
2071         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2072         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2073
2074 2019-04-10  Antoine Quint  <graouts@apple.com>
2075
2076         Enable Pointer Events on watchOS
2077         https://bugs.webkit.org/show_bug.cgi?id=196771
2078         <rdar://problem/49040909>
2079
2080         Reviewed by Dean Jackson.
2081
2082         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2083
2084 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2085
2086         Unreviewed. Fix WPE accessibility tests after r244059.
2087
2088         We are failing to load the injected bundle due to undefined symbol
2089         AccessibilityUIElement::replaceTextInRange().
2090
2091         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2092         (WTR::AccessibilityUIElement::replaceTextInRange):
2093
2094 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2095
2096         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2097         https://bugs.webkit.org/show_bug.cgi?id=196727
2098
2099         Reviewed by Fujii Hironori.
2100
2101         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2102         (WebKitBrowserWindow::create):
2103
2104 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2105
2106         [ews-build] Add unit tests for PrintConfiguration
2107         https://bugs.webkit.org/show_bug.cgi?id=196752
2108
2109         Reviewed by Dewei Zhu.
2110
2111         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2112
2113 2019-04-09  Keith Rollin  <krollin@apple.com>
2114
2115         Unreviewed build maintenance -- update .xcfilelists.
2116
2117         * DumpRenderTree/DerivedSources-input.xcfilelist:
2118         * DumpRenderTree/DerivedSources-output.xcfilelist:
2119
2120 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2121
2122         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2123         https://bugs.webkit.org/show_bug.cgi?id=196743
2124         <rdar://problem/43897551>
2125
2126         Reviewed by Tim Horton.
2127
2128         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2129         (TEST):
2130
2131 2019-04-09  Youenn Fablet  <youenn@apple.com>
2132
2133         Close service worker database on network process suspension
2134         https://bugs.webkit.org/show_bug.cgi?id=196623
2135         <rdar://problem/48930869>
2136
2137         Reviewed by Alex Christensen.
2138
2139         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2140
2141 2019-04-09  Daniel Bates  <dabates@apple.com>
2142
2143         [iPad] Should open popover when the spacebar is pressed
2144         https://bugs.webkit.org/show_bug.cgi?id=196360
2145         <rdar://problem/49389129>
2146
2147         Reviewed by Brent Fulgham.
2148
2149         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2150
2151         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2152         (WTR::UIScriptController::isShowingPopover const): Added.
2153         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2154         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2155         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2156         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2157         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2158         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2159         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2160         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2161         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2162         (WTR::UIScriptController::isShowingPopover const): Added.
2163         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2164         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2165         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2166         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2167         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2168         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2169         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2170         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2171         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2172         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2173         (WTR::UIScriptController::isShowingPopover const): Added.
2174         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2175         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2176
2177 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2178
2179         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2180         https://bugs.webkit.org/show_bug.cgi?id=196665
2181         <rdar://45115669>
2182
2183         Reviewed by Geoff Garen.
2184
2185         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2186         (goBack):
2187         (+[SimpleLookupContext sharedLookupContext]):
2188         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2189         (TEST):
2190         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2191         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2192
2193 2019-04-09  John Wilander  <wilander@apple.com>
2194
2195         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2196         https://bugs.webkit.org/show_bug.cgi?id=196558
2197         <rdar://problem/47650245>
2198
2199         Reviewed by Youenn Fablet.
2200
2201         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2202         (TestWebKitAPI::TEST):
2203             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2204
2205 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2206
2207         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2208         https://bugs.webkit.org/show_bug.cgi?id=196720
2209
2210         Reviewed by Konstantin Tokarev.
2211
2212         * TestWebKitAPI/PlatformMac.cmake:
2213
2214 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2215
2216         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2217         https://bugs.webkit.org/show_bug.cgi?id=196694
2218         <rdar://problem/48388734>
2219
2220         Rubber-stamped by Aakash Jain.
2221
2222         * Scripts/webkitpy/port/image_diff.py:
2223         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2224         * Scripts/webkitpy/port/server_process.py:
2225         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2226         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2227         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2228         * Scripts/webkitpy/port/server_process_mock.py:
2229         (MockServerProcess.has_available_stdout):
2230         * Scripts/webkitpy/port/server_process_unittest.py:
2231         (TestServerProcess.serial_test_basic):
2232
2233 2019-04-09  Jer Noble  <jer.noble@apple.com>
2234
2235         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2236         https://bugs.webkit.org/show_bug.cgi?id=196097
2237
2238         Reviewed by Eric Carlson.
2239
2240         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2241
2242         * DumpRenderTree/mac/DumpRenderTree.mm:
2243         (resetWebPreferencesToConsistentValues):
2244         * WebKitTestRunner/TestController.cpp:
2245         (WTR::TestController::resetPreferencesToConsistentValues):
2246
2247 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2248
2249         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2250         https://bugs.webkit.org/show_bug.cgi?id=196690
2251
2252         Reviewed by Michael Catanzaro.
2253
2254         * QueueStatusServer/config/queues.py:
2255         * Scripts/webkitpy/common/config/ews.json:
2256         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2257         (test_ews_name):
2258
2259 2019-04-09  Chris Dumez  <cdumez@apple.com>
2260
2261         Loads using loadHTMLString() cause flashing when process-swapping
2262         https://bugs.webkit.org/show_bug.cgi?id=196714
2263         <rdar://problem/49637354>
2264
2265         Reviewed by Antti Koivisto.
2266
2267         Add API test coverage.
2268
2269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2270
2271 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2272
2273         Unreviewed. Fix ATK accessibility tests after r244059.
2274
2275         We are failing to load the injected bundle due to undefined symbol
2276         AccessibilityUIElement::replaceTextInRange().
2277
2278         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2279         (WTR::AccessibilityUIElement::replaceTextInRange):
2280
2281 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2282
2283         AX: Support API: accessibilityReplaceRange:withText
2284         https://bugs.webkit.org/show_bug.cgi?id=196636
2285
2286         Unreviewed build fix for Windows port.
2287
2288         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2289         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2290
2291 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2292
2293         [CMake][WinCairo] Separate copied headers into different directories
2294         https://bugs.webkit.org/show_bug.cgi?id=196655
2295
2296         Reviewed by Michael Catanzaro.
2297
2298         * DumpRenderTree/CMakeLists.txt:
2299         * MiniBrowser/win/CMakeLists.txt:
2300         * TestWebKitAPI/CMakeLists.txt:
2301         * TestWebKitAPI/PlatformWin.cmake:
2302
2303 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2304
2305         Log stack-trace for run-webkit-tests when interrupted
2306         https://bugs.webkit.org/show_bug.cgi?id=176393
2307         <rdar://problem/34262310>
2308
2309         Reviewed by Lucas Forschler.
2310
2311         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2312         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2313         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2314         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2315         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2316         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2317         (main): Set handlers to log stack trace on interruption.
2318
2319 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2320
2321         AX: Support API: accessibilityReplaceRange:withText
2322         https://bugs.webkit.org/show_bug.cgi?id=196636
2323
2324         Unreviewed build fix for Windows port.
2325
2326         * DumpRenderTree/AccessibilityUIElement.cpp:
2327         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2328
2329 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2330
2331         [ews-build] Scripts using Buildbot API have CORS error
2332         https://bugs.webkit.org/show_bug.cgi?id=196709
2333
2334         Reviewed by Alexey Proskuryakov.
2335
2336         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2337
2338 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2339
2340         AX: Support API: accessibilityReplaceRange:withText
2341         https://bugs.webkit.org/show_bug.cgi?id=196636
2342
2343         Reviewed by Daniel Bates.
2344
2345         * DumpRenderTree/AccessibilityUIElement.cpp:
2346         (replaceTextInRangeCallback):
2347         (AccessibilityUIElement::replaceTextInRange):
2348         (AccessibilityUIElement::getJSClass):
2349         * DumpRenderTree/AccessibilityUIElement.h:
2350         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2351         (AccessibilityUIElement::replaceTextInRange):
2352         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2353         (AccessibilityUIElement::replaceTextInRange):
2354         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2355         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2356         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2357         (WTR::AccessibilityUIElement::replaceTextInRange):
2358         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2359         (WTR::AccessibilityUIElement::replaceTextInRange):
2360
2361 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2362
2363         [iOS] Do not allow starting selection drags when selection views are not visible
2364         https://bugs.webkit.org/show_bug.cgi?id=196686
2365         <rdar://problem/49399192>
2366
2367         Reviewed by Tim Horton.
2368
2369         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2370         also add some new API tests to cover scenarios where the web view is not first responder.
2371
2372         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2373         (TestWebKitAPI::TEST):
2374         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2375
2376         Add a switch to optionally make the web view first responder when starting the simulated drag.
2377
2378         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2379         (-[DragAndDropSimulator initWithWebView:]):
2380         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2381
2382 2019-04-08  Justin Fan  <justin_fan@apple.com>
2383
2384         [Web GPU] Fix Web GPU experimental feature on iOS
2385         https://bugs.webkit.org/show_bug.cgi?id=196632
2386
2387         Reviewed by Myles C. Maxfield.
2388
2389         Properly make Web GPU available on iOS 11+.
2390
2391         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2392
2393 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2394
2395         [ews-build] Do not upload archive when Compile Fails
2396         https://bugs.webkit.org/show_bug.cgi?id=196674
2397
2398         Reviewed by Alexey Proskuryakov.
2399
2400         * BuildSlaveSupport/ews-build/factories.py:
2401         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2402         * BuildSlaveSupport/ews-build/steps.py:
2403         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2404         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2405         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2406
2407 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2408
2409         Enable DFG on MIPS
2410         https://bugs.webkit.org/show_bug.cgi?id=196689
2411
2412         Reviewed by Žan Doberšek.
2413
2414         Since the bytecode change, we enabled the baseline JIT on mips in
2415         r240432, but DFG is still missing. With this change, all tests are
2416         passing on a ci20 board.
2417
2418         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2419
2420 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2421
2422         [Flatpak] Second run update-webkitwpe-flatpak fails
2423         https://bugs.webkit.org/show_bug.cgi?id=192702
2424
2425         Reviewed by Carlos Garcia Campos.
2426
2427         * flatpak/flatpakutils.py:
2428         (FlatpakObject.flatpak): Fix typo.
2429         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2430         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2431
2432 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2433
2434         [GTK][WPE] outlook.live.com displays old-fashioned UI
2435         https://bugs.webkit.org/show_bug.cgi?id=196642
2436
2437         Reviewed by Carlos Garcia Campos.
2438
2439         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2440         (TestWebKitAPI::TEST): New Mac platform quirk test.
2441
2442 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2443
2444         Unreviewed, rolling out r243956.
2445         https://bugs.webkit.org/show_bug.cgi?id=196688
2446
2447         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2448         by aakashjain on #webkit).
2449
2450         Reverted changeset:
2451
2452         "Clicking "Go Back" from a safe browsing warning from an
2453         iframe should navigate the WKWebView back to the previous
2454         page"
2455         https://bugs.webkit.org/show_bug.cgi?id=196665
2456         https://trac.webkit.org/changeset/243956
2457
2458 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2459
2460         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2461         https://bugs.webkit.org/show_bug.cgi?id=196669
2462
2463         Reviewed by Geoffrey Garen.
2464
2465         Added three new unit tests for WeakHashSet.
2466
2467         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2468         (WTF_WeakPtr.WeakHashSetConstObjects):
2469         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2470         (WTF_WeakPtr.WeakHashSetComputeSize):
2471
2472 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2473
2474         Hide next and previous form control buttons when WKWebView is editable
2475         https://bugs.webkit.org/show_bug.cgi?id=196672
2476         <rdar://problem/35625321>
2477
2478         Reviewed by Tim Horton.
2479
2480         Add a new API test.
2481
2482         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2483         (-[TestWKWebView lastTrailingBarButtonGroup]):
2484         (TestWebKitAPI::TEST):
2485         * TestWebKitAPI/ios/UIKitSPI.h:
2486
2487 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2488
2489         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2490         https://bugs.webkit.org/show_bug.cgi?id=196077
2491         <rdar://problem/49108202>
2492
2493         Reviewed by Chris Dumez.
2494
2495         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2496         on new web view.
2497
2498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2499
2500 2019-04-05  Saam Barati  <sbarati@apple.com>
2501
2502         Make compare-results understand MotionMark
2503         https://bugs.webkit.org/show_bug.cgi?id=196666
2504
2505         Reviewed by Yusuke Suzuki.
2506
2507         * Scripts/compare-results:
2508         (PLT5Results):
2509         (detectMotionMark):
2510         (detectMotionMark1_1):
2511         (motionMarkResults):
2512         (motionMark1_1Results):
2513         (detectBenchmark):
2514         (biggerIsBetter):
2515         (main):
2516
2517 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2518
2519         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2520         https://bugs.webkit.org/show_bug.cgi?id=196665
2521         <rdar://45115669>
2522
2523         Reviewed by Geoff Garen.
2524
2525         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2526         (goBack):
2527         (+[SimpleLookupContext sharedLookupContext]):
2528         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2529         (TEST):
2530         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2531         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2532
2533 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2534
2535         [ews-build] Add configuration and architecture for windows builders
2536         https://bugs.webkit.org/show_bug.cgi?id=196660
2537
2538         Reviewed by Lucas Forschler.
2539
2540         * BuildSlaveSupport/ews-build/config.json:
2541
2542 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2543
2544         webkitpy: Don't run subsequent rounds if interrupted
2545         https://bugs.webkit.org/show_bug.cgi?id=196646
2546
2547         Reviewed by Aakash Jain.
2548
2549         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2550         (Manager.run): Bail out if interrupted.
2551
2552 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2553
2554         Test sessionStorage in PSON private browsing mode
2555         https://bugs.webkit.org/show_bug.cgi?id=196561
2556
2557         Reviewed by Alex Christensen.
2558
2559         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2560
2561 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2562
2563         Unreviewed, rolling out r243833.
2564         https://bugs.webkit.org/show_bug.cgi?id=196645
2565
2566         This change breaks build of WPE and GTK ports (Requested by
2567         annulen on #webkit).
2568
2569         Reverted changeset:
2570
2571         "[CMake][WTF] Mirror XCode header directories"
2572         https://bugs.webkit.org/show_bug.cgi?id=191662
2573         https://trac.webkit.org/changeset/243833
2574
2575 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2576
2577         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2578         https://bugs.webkit.org/show_bug.cgi?id=196635
2579
2580         Reviewed by Antti Koivisto.
2581         
2582         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
2583         for a test to enable async frame scrolling via:
2584             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
2585         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
2586         
2587         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
2588
2589         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2590         (WTR::InjectedBundle::beginTesting):
2591         * WebKitTestRunner/TestController.cpp:
2592         (WTR::TestController::resetPreferencesToConsistentValues):
2593
2594 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2595
2596         Use a correct LC_RPATH when building with ASan
2597         https://bugs.webkit.org/show_bug.cgi?id=196576
2598
2599         Reviewed by David Kilzer.
2600
2601         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2602         so that ../Frameworks is checked. This is simpler and more reliable than updating
2603         each SPC service xcconfig.
2604
2605 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2606
2607         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2608         https://bugs.webkit.org/show_bug.cgi?id=196629
2609
2610         Reviewed by Lucas Forschler.
2611
2612         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2613
2614 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2615
2616         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2617         https://bugs.webkit.org/show_bug.cgi?id=196618
2618
2619         Reviewed by Lucas Forschler.
2620
2621         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2622         (StatusBubble): Added QUEUE_TRIGGERS.
2623         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2624         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2625         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2626         its parent(builder).
2627
2628 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2629
2630         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2631         https://bugs.webkit.org/show_bug.cgi?id=196625
2632
2633         Reviewed by Lucas Forschler.
2634
2635         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2636         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2637
2638 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2639
2640         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2641         https://bugs.webkit.org/show_bug.cgi?id=196630
2642
2643         Reviewed by Wenson Hsieh.
2644
2645         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2646
2647 2019-04-04  Youenn Fablet  <youenn@apple.com>
2648
2649         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2650         https://bugs.webkit.org/show_bug.cgi?id=196543
2651
2652         Reviewed by Alex Christensen.
2653
2654         * WebKitTestRunner/TestController.cpp:
2655         (WTR::TestController::generatePageConfiguration):
2656
2657 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2658
2659         [ews-app] Status bubble should not display skipped buildbot steps
2660         https://bugs.webkit.org/show_bug.cgi?id=196584
2661
2662         Reviewed by Lucas Forschler.
2663
2664         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2665
2666 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2667
2668         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2669         https://bugs.webkit.org/show_bug.cgi?id=196620
2670
2671         Reviewed by Lucas Forschler.
2672
2673         * BuildSlaveSupport/ews-app/ews/config.py:
2674
2675 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2676
2677         [Win] DumpRenderTreeWatchDog.py is not checked into source
2678         https://bugs.webkit.org/show_bug.cgi?id=196567
2679         <rdar://problem/49525901>
2680
2681         Reviewed by Lucas Forschler.
2682
2683         This script is used on Win EWS bots to terminate hanging DRT processes.
2684
2685         * EWSTools/dumprendertreewatchdog.py: Added.
2686
2687 2019-04-04  Chris Dumez  <cdumez@apple.com>
2688
2689         Unreviewed, roll out r243858 which made tests time out.
2690
2691         Disable new API tests on Windows instead.
2692
2693         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2694         (TestWebKitAPI::TEST):
2695
2696 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2697
2698         [ATK] Cleanup WebPageAccessibilityObjectAtk
2699         https://bugs.webkit.org/show_bug.cgi?id=196537
2700
2701         Reviewed by Michael Catanzaro.
2702
2703         Also consider files under atk directories as exceptions for GObject conventions.
2704
2705         * Scripts/webkitpy/style/checkers/cpp.py:
2706         (check_identifier_name_in_declaration):
2707
2708 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2709
2710         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2711         https://bugs.webkit.org/show_bug.cgi?id=196588
2712         <rdar://problem/49365787>
2713
2714         Unreviewed build fix for Windows port.
2715
2716         error C3861: 'kill': identifier not found
2717
2718         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2719         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2720
2721 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2722
2723         [ews-build] Cancel build and similar operations should have authentication
2724         https://bugs.webkit.org/show_bug.cgi?id=196520
2725
2726         Reviewed by Dewei Zhu.
2727
2728         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2729         environment variables.
2730
2731 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2732
2733         [ews-build] Do not trigger queues which are not in production yet
2734         https://bugs.webkit.org/show_bug.cgi?id=196581
2735
2736         Reviewed by Dewei Zhu.
2737
2738         * BuildSlaveSupport/ews-build/config.json:
2739
2740 2019-04-03  Chris Dumez  <cdumez@apple.com>
2741
2742         Unreviewed, fix typo in the name of API test added in r243848.
2743
2744         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2745         (TestWebKitAPI::TEST):
2746
2747 2019-04-03  Chris Dumez  <cdumez@apple.com>
2748
2749         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2750         https://bugs.webkit.org/show_bug.cgi?id=196588
2751         <rdar://problem/49365787>
2752
2753         Reviewed by Ryosuke Niwa.
2754
2755         Add API test coverage.
2756
2757         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2758         (TestWebKitAPI::nullJavaScriptCallback):
2759         (TestWebKitAPI::didCrashCheckFrames):
2760         (TestWebKitAPI::TEST):
2761
2762 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2763
2764         run-webkit-tests: Upload test results (new results database)
2765         https://bugs.webkit.org/show_bug.cgi?id=196577
2766         <rdar://problem/34841155>
2767
2768         Reviewed by Lucas Forschler.
2769
2770         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2771         (Manager.run): Upload results after each device shard, since the configuration will be
2772         different for each device.
2773         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2774         uploaded to a results database.
2775         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2776         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2777
2778 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2779
2780         -apple-trailing-word is needed for browser detection
2781         https://bugs.webkit.org/show_bug.cgi?id=196575
2782
2783         Unreviewed.
2784
2785         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2786
2787 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2788
2789         [CMake][WTF] Mirror XCode header directories
2790         https://bugs.webkit.org/show_bug.cgi?id=191662
2791
2792         Reviewed by Konstantin Tokarev.
2793
2794         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2795         builds.
2796
2797         * CMakeLists.txt:
2798         * DumpRenderTree/CMakeLists.txt:
2799         * DumpRenderTree/PlatformWin.cmake:
2800         * MiniBrowser/win/CMakeLists.txt:
2801         * TestWebKitAPI/CMakeLists.txt:
2802         * TestWebKitAPI/PlatformWin.cmake:
2803         * WebKitTestRunner/PlatformGTK.cmake:
2804         * WebKitTestRunner/PlatformWin.cmake:
2805
2806 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2807
2808         [ews-app] Status bubble should not display certain infrastructure status messages
2809         https://bugs.webkit.org/show_bug.cgi?id=196550
2810
2811         Reviewed by Lucas Forschler.
2812
2813         Do not display the steps which are un-needed for end-user. This information is still avaiable
2814         if the user click on the bubble and look at the Buildbot build.
2815         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2816         (StatusBubble._steps_messages):
2817         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2818
2819 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2820
2821         [ews-build] Use https for sending data to ews-app
2822         https://bugs.webkit.org/show_bug.cgi?id=196492
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * BuildSlaveSupport/ews-build/events.py:
2827
2828 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2829
2830         Remove support for -apple-trailing-word
2831         https://bugs.webkit.org/show_bug.cgi?id=196525
2832
2833         Reviewed by Zalan Bujtas.
2834
2835         This CSS property is nonstandard and not used.
2836
2837         * Scripts/webkitperl/FeatureList.pm:
2838         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2839
2840 2019-04-03  Youenn Fablet  <youenn@apple.com>
2841
2842         Add a test for DOMCache on multiple browsing in case of private browsing
2843         https://bugs.webkit.org/show_bug.cgi?id=196524
2844
2845         Reviewed by Alex Christensen.
2846
2847         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2848         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2849
2850 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2851
2852         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2853         https://bugs.webkit.org/show_bug.cgi?id=196540
2854
2855         Reviewed by Aakash Jain.
2856
2857         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2858
2859 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2860
2861         Add plumbing for a compatibility mode preference in WebKit
2862         https://bugs.webkit.org/show_bug.cgi?id=196005
2863
2864         Reviewed by Tim Horton.
2865
2866         Add new API tests.
2867
2868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2869         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2870
2871 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2872
2873         [WPE][GTK] Update libsrtp dependency package for Debian
2874         https://bugs.webkit.org/show_bug.cgi?id=196528
2875
2876         Reviewed by Frédéric Wang.
2877
2878         * gtk/install-dependencies:
2879         * wpe/install-dependencies:
2880
2881 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2882
2883         [WK2] Add support for Window's beforeprint / afterprint events
2884         https://bugs.webkit.org/show_bug.cgi?id=196478
2885         <rdar://problem/49535124>
2886
2887         Unreviewed build fix for MSVC.
2888
2889         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2890
2891         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2892
2893         * WebKitTestRunner/TestController.cpp:
2894         (WTR::printFrame): Use int and float literals.
2895
2896 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2897
2898         [ews-build] Reassign bots to queues
2899
2900         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2901
2902 2019-04-02  Chris Dumez  <cdumez@apple.com>
2903
2904         [WK2] Add support for Window's beforeprint / afterprint events
2905         https://bugs.webkit.org/show_bug.cgi?id=196478
2906
2907         Reviewed by Alex Christensen.
2908
2909         Add minimal implementation for printFrame in WebKitTestRunner.
2910
2911         * WebKitTestRunner/TestController.cpp:
2912         (WTR::printFrame):
2913         (WTR::TestController::createOtherPage):
2914         (WTR::TestController::createWebViewWithOptions):
2915
2916 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2917
2918         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2919         https://bugs.webkit.org/show_bug.cgi?id=196491
2920
2921         Reviewed by Lucas Forschler.
2922
2923         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2924
2925 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2926
2927         [ews-build] Configure buildbot try credentials in environment variables
2928         https://bugs.webkit.org/show_bug.cgi?id=196501
2929
2930         Reviewed by Lucas Forschler.
2931
2932         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2933         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2934         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2935
2936 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2937
2938         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2939         https://bugs.webkit.org/show_bug.cgi?id=196496
2940         <rdar://problem/49521634>
2941
2942         Reviewed by Chris Dumez.
2943
2944         Add new API tests (see WebKit ChangeLog for more detail).
2945
2946         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2947         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2948         (TEST):
2949
2950 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2951
2952         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2953         <https://webkit.org/b/196499>
2954
2955         Reviewed by Alexey Proskuryakov.
2956
2957         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2958         ENABLE_ADDRESS_SANITIZER.
2959
2960 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2961
2962         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2963         https://bugs.webkit.org/show_bug.cgi?id=182757
2964
2965         Reviewed by Don Olmstead.
2966
2967         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2968         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2969
2970 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2971
2972         run-api-tests: Upload test results
2973         https://bugs.webkit.org/show_bug.cgi?id=196323
2974         <rdar://problem/49356714>
2975
2976         Reviewed by Lucas Forschler.
2977
2978         * Scripts/webkitpy/api_tests/manager.py:
2979         (Manager):
2980         (Manager.run): Upload results to a results database.
2981         * Scripts/webkitpy/api_tests/run_api_tests.py:
2982         (parse_args): Add upload arguments.
2983         * Scripts/webkitpy/port/base.py:
2984         (Port):
2985         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2986         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2987         with commits from any other associated repositories.
2988         * Scripts/webkitpy/port/device.py:
2989         (Device):
2990         (Device.build_version): Access build_versoin of underlying platform device.
2991         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2992         (IOSSimulatorTest):
2993         (IOSSimulatorTest.test_configuration_for_upload):
2994         * Scripts/webkitpy/port/device_port.py:
2995         (DevicePort):
2996         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2997         the same as the machine uploading results.
2998         * Scripts/webkitpy/port/mac.py:
2999         (MacPort):
3000         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3001         * Scripts/webkitpy/port/mac_unittest.py:
3002         (MacTest):
3003         (MacTest.test_configuration_for_upload):
3004         * Scripts/webkitpy/xcode/simulated_device.py:
3005         (SimulatedDeviceManager._create_device_with_runtime):
3006         (SimulatedDevice.__init__): Create simulated device with a build_version.
3007         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3008         (test_existing_simulator):
3009
3010 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3011
3012         Remove extra newline characters (Follow-up fix to r243707)
3013
3014         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3015
3016 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3017
3018         [ews-app] Use API_KEY to accept results data
3019         https://bugs.webkit.org/show_bug.cgi?id=196461
3020
3021         Reviewed by Dewei Zhu.
3022
3023         * BuildSlaveSupport/ews-app/ews/views/results.py:
3024         (Results.post): Validate EWS_API_KEY before accepting any data.
3025         * BuildSlaveSupport/ews-build/events.py:
3026         (Events.sendData): Send EWS_API_KEY if available along with event data.
3027
3028 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3029
3030         Unable to copy and paste a PDF from Notes into Mail compose body
3031         https://bugs.webkit.org/show_bug.cgi?id=196442
3032         <rdar://problem/48573098>
3033
3034         Reviewed by Tim Horton.
3035
3036         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3037         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3038         to be specified on the item providers.
3039
3040         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3041         (TestWebKitAPI::mapItemForTesting):
3042         (TestWebKitAPI::contactItemForTesting):
3043
3044 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3045
3046         Make UIWKDocumentContext rects per-character instead of per-word
3047         https://bugs.webkit.org/show_bug.cgi?id=196459
3048
3049         Reviewed by Wenson Hsieh.
3050
3051         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3052         (TEST):
3053         Adjust test results due to switching to per-character rects.
3054
3055 2019-04-01  Chris Dumez  <cdumez@apple.com>
3056
3057         UIProcess crash when a prewarmed process is terminated
3058         https://bugs.webkit.org/show_bug.cgi?id=196451
3059         <rdar://problem/49245471>
3060
3061         Reviewed by Geoffrey Garen.
3062
3063         Add API test coverage.
3064
3065         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3066         (TEST):
3067
3068 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3069
3070         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3071         https://bugs.webkit.org/show_bug.cgi?id=196449
3072
3073         Reviewed by Lucas Forschler.
3074
3075         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3076         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3077         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3078         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3079
3080 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3081
3082         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3083         https://bugs.webkit.org/show_bug.cgi?id=196444
3084
3085         Reviewed by Lucas Forschler.
3086
3087         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3088
3089 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3090
3091         Add SPI to canonicalize NSURLs with WTF::URL
3092         https://bugs.webkit.org/show_bug.cgi?id=196415
3093         <rdar://problem/44980271>
3094
3095         Reviewed by Darin Adler.
3096
3097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3098         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3099         (TestWebKitAPI::TEST):
3100
3101 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3102
3103         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3104         https://bugs.webkit.org/show_bug.cgi?id=196441
3105
3106         Reviewed by Carlos Garcia Campos.
3107
3108         Don't cache the wpe_view_backend object that might not exist yet at the
3109         time of EventSenderProxy constructor invocation, but instead retrieve
3110         that object whenever it's required for event dispatching. This should
3111         avoid crashes in this constructor now that it's invoked before any
3112         PlatformWindow has been set up (as changed in r243496).
3113
3114         * WebKitTestRunner/EventSenderProxy.h:
3115         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3116         (WTR::viewBackend):
3117         (WTR::EventSenderProxy::EventSenderProxy):
3118         (WTR::EventSenderProxy::mouseDown):
3119         (WTR::EventSenderProxy::mouseUp):
3120         (WTR::EventSenderProxy::mouseMoveTo):
3121         (WTR::EventSenderProxy::mouseScrollBy):
3122         (WTR::EventSenderProxy::keyDown):
3123         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3124
3125 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3126
3127         [Win][WebKit] MiniBrowser should support high DPI display
3128         https://bugs.webkit.org/show_bug.cgi?id=196391
3129
3130         Reviewed by Alex Christensen.
3131
3132         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3133         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3134         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3135         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3136
3137 2019-03-31  Sam Weinig  <weinig@apple.com>
3138
3139         Remove more i386 specific configurations
3140         https://bugs.webkit.org/show_bug.cgi?id=196430
3141
3142         Reviewed by Alexey Proskuryakov.
3143
3144         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3145         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3146
3147 2019-03-31  Andy Estes  <aestes@apple.com>
3148
3149         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3150         https://bugs.webkit.org/show_bug.cgi?id=196433
3151         <rdar://problem/49293305>
3152
3153         Reviewed by Tim Horton.
3154
3155         Enhanced API test coverage to include all navigation response policy decisions in both
3156         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3157
3158         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3159         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3160         (TestWebKitAPI::TEST):
3161         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3162         (readFile):
3163         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3164         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3165         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3166         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3167         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3168         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3169         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3170         (-[QuickLookDelegate _downloadDidStart:]):
3171         (-[QuickLookDelegate _download:didReceiveResponse:]):
3172         (-[QuickLookDelegate _download:didReceiveData:]):
3173         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3174         (-[QuickLookDelegate _downloadDidFinish:]):
3175         (-[QuickLookDelegate _download:didFailWithError:]):
3176         (-[QuickLookDelegate _downloadDidCancel:]):
3177         (-[QuickLookDelegate verifyDownload]):
3178         (runTest):
3179         (runTestDecideBeforeLoading):
3180         (runTestDecideAfterLoading):
3181         (TEST):
3182         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3183         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3184         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3185         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3186         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3187         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3188         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3189         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3190         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3191         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3192         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3193         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3194         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3195         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3196
3197 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3198
3199         [CMake] add testdfg as target with build-jsc
3200         https://bugs.webkit.org/show_bug.cgi?id=196393
3201
3202         Reviewed by Saam Barati.
3203
3204         Added testdfg as one of the targets to build when
3205         using CMake.
3206
3207         * Scripts/build-jsc:
3208
3209 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3210
3211         Delete WebMetal implementation in favor of WebGPU
3212         https://bugs.webkit.org/show_bug.cgi?id=195418
3213
3214         Reviewed by Dean Jackson.
3215
3216         * DumpRenderTree/mac/DumpRenderTree.mm:
3217         (enableExperimentalFeatures):
3218         (resetWebPreferencesToConsistentValues):
3219         * Scripts/webkitperl/FeatureList.pm:
3220         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3222         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3223         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3224         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3225         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3226         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3227         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3228         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3229         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3230         (WTR::InjectedBundle::beginTesting):
3231         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3232         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3233         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3234
3235 2019-03-29  Chris Dumez  <cdumez@apple.com>
3236
3237         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3238         https://bugs.webkit.org/show_bug.cgi?id=196405
3239         <rdar://problem/49428130>
3240
3241         Reviewed by Wenson Hsieh.
3242
3243         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3244         the popover presentation methods to be no-ops. Use this in the new test added in
3245         r243523 so that we do not swizzle those methods for all tests. This is needed because
3246         those WatchOS tests rely on the popover getting presented and interactive.
3247
3248         * WebKitTestRunner/TestController.cpp:
3249         (WTR::updateTestOptionsFromTestHeader):
3250         * WebKitTestRunner/TestController.h:
3251         * WebKitTestRunner/TestOptions.h:
3252         (WTR::TestOptions::hasSameInitializationOptions const):
3253         * WebKitTestRunner/ios/TestControllerIOS.mm:
3254         (WTR::TestController::platformInitialize):
3255         (WTR::TestController::platformResetStateToConsistentValues):
3256
3257 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3258
3259         [Curl] Add Server Trust Evaluation Support.
3260         https://bugs.webkit.org/show_bug.cgi?id=191646
3261
3262         Reviewed by Fujii Hironori.
3263
3264         Implemented MiniBrowser UI for asking if user trusts the server.
3265
3266         * MiniBrowser/win/Common.cpp:
3267         (askServerTrustEvaluation):
3268         (replaceString):
3269         * MiniBrowser/win/Common.h:
3270         * MiniBrowser/win/MiniBrowserLib.rc:
3271         * MiniBrowser/win/MiniBrowserLibResource.h:
3272         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3273         (createPEMString):
3274         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3275         (WebKitBrowserWindow::canTrustServerCertificate):
3276         * MiniBrowser/win/WebKitBrowserWindow.h:
3277
3278 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3279
3280         Implement ResizeObserver.
3281         https://bugs.webkit.org/show_bug.cgi?id=157743
3282
3283         Reviewed by Simon Fraser.
3284
3285         Support resizeObserverEnabled webPreferences.
3286
3287         * DumpRenderTree/TestOptions.cpp:
3288         (TestOptions::TestOptions):
3289         * DumpRenderTree/TestOptions.h:
3290         * DumpRenderTree/mac/DumpRenderTree.mm:
3291         (setWebPreferencesForTestOptions):
3292         * DumpRenderTree/win/DumpRenderTree.cpp:
3293         (enableExperimentalFeatures):
3294         * Scripts/webkitperl/FeatureList.pm:
3295         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3296
3297 2019-03-28  John Wilander  <wilander@apple.com>
3298
3299         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3300         https://bugs.webkit.org/show_bug.cgi?id=196281
3301         <rdar://problem/48938748>
3302
3303         Reviewed by Alex Christensen.
3304
3305         This patch adds the function isStatisticsHasLocalStorage() to the
3306         TestRunner. With it, the page can query the WebsiteDataStore in the
3307         UI process to make sure that it sees LocalStorage.
3308
3309         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3310         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3311         (WTR::TestRunner::isStatisticsHasLocalStorage):
3312         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3313         * WebKitTestRunner/TestController.cpp:
3314         (WTR::TestController::isStatisticsHasLocalStorage):
3315         * WebKitTestRunner/TestController.h:
3316         * WebKitTestRunner/TestInvocation.cpp:
3317         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3318
3319 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3320
3321         API::Data::createWithoutCopying should do a null check before calling CFRelease
3322         https://bugs.webkit.org/show_bug.cgi?id=196276
3323         <rdar://problem/48059859>
3324
3325         Reviewed by Alex Christensen.
3326
3327         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3328
3329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3330         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3331         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3332         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3333         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3334         (TestWebKitAPI::TEST):
3335
3336 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3337
3338         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3339         https://bugs.webkit.org/show_bug.cgi?id=186276
3340
3341         Reviewed by Carlos Garcia Campos.
3342
3343         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3344         (webViewLoadChanged):
3345         (testWebResourceGetDataError):
3346         (testWebResourceGetDataEmpty):
3347         (beforeAll):
3348         (webViewloadChanged): Deleted.
3349
3350 2019-03-27  Andy Estes  <aestes@apple.com>
3351
3352         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3353         https://bugs.webkit.org/show_bug.cgi?id=196317
3354
3355         Reviewed by Dan Bernstein.
3356
3357         package-root copies built products into a staging directory using ditto(1), which does not
3358         follow symbolic links as it traverses a directory. Now that the files in
3359         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3360         itself, these become broken links when ditto'd into the staging directory.
3361
3362         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3363
3364         * Scripts/package-root:
3365
3366 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3367
3368         [ews-app] Update display text of Submit for ews analysis
3369         https://bugs.webkit.org/show_bug.cgi?id=196309
3370
3371         Reviewed by Dewei Zhu.
3372
3373         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3374
3375 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3376
3377         run-webkit-tests should check for leaks in WebKit processes
3378         <https://webkit.org/b/193772>
3379         <rdar://problem/46526680>
3380
3381         Reviewed by Ryosuke Niwa.
3382
3383         This works by doing the following:
3384         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3385           The list of child processes are returned one per line:
3386           process.name: pid
3387         - Run the "#LIST CHILD PROCESSES" command just before the
3388           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3389           processes on the ServerProcess object.
3390         - When the `--leaks` switch is handled, run check_for_leaks() on
3391           each child process after the main test harness.
3392
3393         * DumpRenderTree/mac/DumpRenderTree.mm:
3394         (handleControlCommand):
3395         - Use strncmp() instead of strcmp().
3396         - Add support for handling "#LIST CHILD PROCESSES" command.
3397
3398         * Scripts/webkitpy/port/base.py:
3399         (Port.check_for_leaks):
3400         * Scripts/webkitpy/port/darwin.py:
3401         (DarwinPort.check_for_leaks):
3402         - Rename redundant 'process_pid' argument to 'process_id'.
3403
3404         * Scripts/webkitpy/port/driver.py:
3405         (Driver.do_post_tests_work):
3406         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3407           longer the only command this sends to WebKitTestRunner.
3408         - If the `--leaks` switch is present, send the
3409           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3410           result using Port.set_webkit_processes().
3411         (Driver._parse_child_processes_output):
3412         - Add helper method to parse list of child process names and
3413           process IDs returned from WebKitTestRunner.
3414
3415         * Scripts/webkitpy/port/ios_device.py:
3416         (IOSDevicePort.check_for_leaks):
3417         - Rename redundant 'process_pid' argument to 'process_id'.
3418
3419         * Scripts/webkitpy/port/leakdetector.py:
3420         (LeakDetector._parse_leaks_output):
3421         - Return early if there is no leaks_output.
3422         (LeakDetector.check_for_leaks):
3423         - Rename redundant 'process_pid' argument to 'process_id'.
3424
3425         * Scripts/webkitpy/port/server_process.py:
3426         (ServerProcess.__init__):
3427         (ServerProcess.child_processes):
3428         (ServerProcess.set_child_processes):
3429         - Add instance variable to Port to store list of child process
3430           names and process IDs returned from WebKitTestRunner.
3431         (ServerProcess._start):
3432         - Clear self._child_processes.
3433         (ServerProcess.stop):
3434         - If self._child_processes is set, call
3435           self._port.check_for_leaks() for each child process.
3436
3437         * Scripts/webkitpy/port/server_process_unittest.py:
3438         (TrivialMockPort.check_for_leaks):
3439         - Rename redundant 'process_pid' argument to 'process_id'.
3440
3441         * Scripts/webkitpy/port/simulator_process.py:
3442         (SimulatorProcess.stop):
3443         - If self._child_processes is set, call
3444           self._port.check_for_leaks() for each child process.
3445
3446         * Scripts/webkitpy/port/watch_device.py:
3447         (WatchDevicePort.check_for_leaks):
3448         - Rename redundant 'process_pid' argument to 'process_id'.
3449
3450         * WebKitTestRunner/TestController.cpp:
3451         (WTR::TestController::dumpResponse):
3452         - Extract method from findAndDumpWorldLeaks() so that it may be
3453           reused by findAndDumpWebKitProcessIdentifiers().
3454         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3455         - Add method to output process name and process ID of both the
3456           WebContent and Networking processes.
3457         (WTR::TestController::findAndDumpWorldLeaks):
3458         - Fix missing newline in output when there were no abandoned
3459           documents.
3460         - Call dumpResponse() for extracted code.
3461         (WTR::TestController::handleControlCommand):
3462         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3463         - Use strncmp() instead of strcmp().
3464         - Call findAndDumpWebKitProcessIdentifiers() when
3465           "#LIST CHILD PROCESSES" command is sent.
3466         * WebKitTestRunner/TestController.h:
3467         (WTR::TestController::dumpResponse):
3468         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3469         - Declare methods.
3470
3471 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3472
3473         Unreviewed. Add GLib API test cases after r243434.
3474
3475         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3476         (testWebViewActiveURI):
3477         (serverCallback):
3478         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3479         (sendRequestCallback):
3480
3481 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3482
3483         Geolocation request not complete when watch request was started in a different web process
3484         https://bugs.webkit.org/show_bug.cgi?id=195996
3485
3486         Reviewed by Alex Christensen.
3487
3488         Add a test case.
3489
3490         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3491         (TestWebKitAPI::runJavaScriptAlert):
3492         (TestWebKitAPI::TEST):
3493
3494 2019-03-26  Keith Rollin  <krollin@apple.com>
3495
3496         Update the way generate-xcfilelists returns strings from functions
3497         https://bugs.webkit.org/show_bug.cgi?id=195975
3498         <rdar://problem/49040807>
3499
3500         Reviewed by Dean Jackson.
3501
3502         There are places where generate-xcfilelists executes assignments with
3503         statements like:
3504
3505             FOO=$(some_function)
3506
3507         where "some_function" return a string by echoing it. E.g.
3508
3509             some_function()
3510             {
3511                 echo "Hello, World"
3512             }
3513
3514         This is a common idiom, but it has a problem if "some_function" needs
3515         to call "exit" in an attempt to halt the entire script right then and
3516         there. Since "some_function" is called inside of $(), it's being
3517         executed in a sub-shell. Calling exit in that sub-shell simply exits
3518         that shell; it doesn't not exit the outer shell in which the main part
3519         of the script is still running. As such, the main script keeps
3520         executing when the intent was for the script to halt.
3521
3522         The solution to this is to use a different idiom for returning
3523         strings. The one we now is to pass in the name of the variable to
3524         receive the string result:
3525
3526             some_function()
3527             {
3528                 variable_name=$1
3529                 eval $variable_name ="Hello, World"
3530             }
3531
3532         The call site now looks like
3533
3534             some_function FOO
3535
3536         Because there's no invocation of a sub-shell, some_function can now
3537         call "exit" if it wants to, and the entire script will exit at that
3538         point.
3539
3540         * Scripts/generate-xcfilelists:
3541
3542 2019-03-26  Chris Dumez  <cdumez@apple.com>
3543
3544         Add basic layout test coverage for File Picker on iOS
3545         https://bugs.webkit.org/show_bug.cgi?id=196265
3546
3547         Reviewed by Wenson Hsieh.
3548
3549         Add layout test infrastructure to test the file picker on iOS.
3550
3551         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3552         (WTR::UIScriptController::dismissFilePicker):
3553         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3554         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3555         (WTR::UIScriptController::dismissFilePicker):
3556         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3557         * WebKitTestRunner/TestController.cpp:
3558         (WTR::TestController::createWebViewWithOptions):
3559         (WTR::updateTestOptionsFromTestHeader):
3560         * WebKitTestRunner/TestOptions.h:
3561         (WTR::TestOptions::hasSameInitializationOptions const):
3562         * WebKitTestRunner/ios/TestControllerIOS.mm:
3563         (overridePresentViewController):
3564         (WTR::TestController::platformInitialize):
3565         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3566         (WTR::UIScriptController::dismissFilePicker):
3567
3568 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3569
3570         Implement async paste method on UIWKInteractionViewProtocol
3571         https://bugs.webkit.org/show_bug.cgi?id=196267
3572         <rdar://problem/49236346>
3573
3574         Reviewed by Tim Horton.
3575
3576         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3577         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3578         are now a part of all iOS 12 internal SDKs.
3579
3580         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3581
3582         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
3583         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
3584
3585         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3586         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3587         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3588         * TestWebKitAPI/ios/UIKitSPI.h:
3589
3590 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3591
3592         [ews-build] Use PostgreSQL for ews.webkit.org database
3593         https://bugs.webkit.org/show_bug.cgi?id=196270
3594
3595         Reviewed by Lucas Forschler.
3596
3597         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3598
3599 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3600
3601         [ews] Reset simctl states on reboot
3602         https://bugs.webkit.org/show_bug.cgi?id=196260
3603
3604         Rubber-stamped by Aakash Jain.
3605
3606         * EWSTools/start-queue-mac.sh:
3607
3608 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3609
3610         [ews-build] Use PostgreSQL for ews-build database
3611         https://bugs.webkit.org/show_bug.cgi?id=196229
3612
3613         Reviewed by Lucas Forschler.
3614
3615         * BuildSlaveSupport/ews-build/master.cfg:
3616
3617 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3618
3619         [ews-build] Get master_hostname dynamically in master.cfg
3620         https://bugs.webkit.org/show_bug.cgi?id=196255
3621
3622         Reviewed by Lucas Forschler.
3623
3624         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3625         send events data in test mode.
3626
3627 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3628
3629         [ews-app] Set db_constraint to False for Foreign Keys
3630         https://bugs.webkit.org/show_bug.cgi?id=196252
3631
3632         Reviewed by Lucas Forschler.
3633
3634         * BuildSlaveSupport/ews-app/ews/models/build.py:
3635         * BuildSlaveSupport/ews-app/ews/models/step.py:
3636
3637 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3638
3639         [ews-build] is_test_mode_enabled should default to True
3640         https://bugs.webkit.org/show_bug.cgi?id=196248
3641
3642         Reviewed by Lucas Forschler.
3643
3644         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3645
3646 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3647
3648         [ews-app] Add webkitperl to ENABLED_QUEUES
3649  &nbs