acaec8bf7a00a581b5c9b5c551abc62d261068cf
[WebKit-https.git] / Tools / ChangeLog
1 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Do not print worker environment variables in each build step
4         https://bugs.webkit.org/show_bug.cgi?id=197319
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/steps.py:
9         (CheckOutSource.__init__): Disabled logging of environment variables.
10         (ApplyPatch.__init__): Ditto.
11         (KillOldProcesses.__init__): Ditto.
12         (ArchiveBuiltProduct.__init__): Ditto.
13         (DownloadBuiltProduct.__init__): Ditto.
14         (ExtractBuiltProduct.__init__): Ditto.
15         (RunAPITests.__init__): Ditto.
16         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
17
18 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
19
20         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
21         https://bugs.webkit.org/show_bug.cgi?id=199232
22         <rdar://problem/51718328>
23
24         Reviewed by Youenn Fablet.
25
26         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
27         (TestWebKitAPI::TEST):
28         Add a test that utilizes TCPServer as local files always omit referrer.
29
30 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
31
32         [ews-build] Add configuration and architecture for WPE and GTK builders
33         https://bugs.webkit.org/show_bug.cgi?id=199249
34
35         Reviewed by Jonathan Bedard.
36
37         * BuildSlaveSupport/ews-build/config.json:
38
39 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
40
41         [ews-build] Add check for duplicate workers in config.json
42         https://bugs.webkit.org/show_bug.cgi?id=199240
43
44         Reviewed by Jonathan Bedard.
45
46         * BuildSlaveSupport/ews-build/loadConfig.py:
47         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
48         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
49         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
50
51 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
52
53         [Win] MiniBrowser should make better font choices
54         https://bugs.webkit.org/show_bug.cgi?id=199244
55
56         Reviewed by Brent Fulgham.
57
58         * MiniBrowser/win/MainWindow.cpp:
59         (MainWindow::updateDeviceScaleFactor):
60         * MiniBrowser/win/MiniBrowserLib.rc:
61
62 2019-06-26  Alex Christensen  <achristensen@webkit.org>
63
64         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
65         https://bugs.webkit.org/show_bug.cgi?id=199230
66         <rdar://51757107>
67
68         Reviewed by Andy Estes.
69
70         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
71         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
72         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
73         * WebKitTestRunner/TestController.cpp:
74         (WTR::TestController::generatePageConfiguration):
75         (WTR::TestController::createWebViewWithOptions):
76         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
77         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
78         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
79         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
80         * WebKitTestRunner/TestController.h:
81         * WebKitTestRunner/TestInvocation.cpp:
82         (WTR::TestInvocation::invoke):
83         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
84
85 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
86
87         [Win][MiniBrowser] Remove obsolete code after r246814.
88         https://bugs.webkit.org/show_bug.cgi?id=199233
89
90         Reviewed by Fujii Hironori.
91
92         * MiniBrowser/win/MiniBrowserWebHost.cpp:
93         (MiniBrowserWebHost::didFinishLoadForFrame):
94         (SimpleEventListener::SimpleEventListener): Deleted.
95         (SimpleEventListener::handleEvent): Deleted.
96
97 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
98
99         Implement a new SPI to inform clients about AppSSO
100         https://bugs.webkit.org/show_bug.cgi?id=199085
101         <rdar://problem/50028246>
102
103         Reviewed by Geoffrey Garen.
104
105         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
106         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
107         (-[TestSOAuthorizationNavigationDelegate init]):
108         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
109         (TestWebKitAPI::TEST):
110
111 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
112
113         [ews-build] Retry Layout test in case of failures
114         https://bugs.webkit.org/show_bug.cgi?id=199194
115
116         Reviewed by Jonathan Bedard.
117
118         * BuildSlaveSupport/ews-build/steps.py:
119         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
120         (ReRunWebKitTests): Build step to re-run layout tests.
121         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
122         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
123         (RunWebKitTestsWithoutPatch.evaluateCommand):
124
125 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
126
127         [ews-build] Combine various patchFailed*Tests properties
128         https://bugs.webkit.org/show_bug.cgi?id=199193
129
130         Reviewed by Jonathan Bedard.
131
132         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
133         can also be used for layout-tests later on.
134         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
135
136 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
137
138         [Win] MiniBrowser should default to webkit.org
139         https://bugs.webkit.org/show_bug.cgi?id=199201
140
141         Reviewed by Don Olmstead.
142
143         * MiniBrowser/win/BrowserWindow.h:
144         * MiniBrowser/win/MiniBrowserReplace.h:
145         * MiniBrowser/win/WebKitBrowserWindow.cpp:
146         (WebKitBrowserWindow::loadHTMLString): Deleted.
147         * MiniBrowser/win/WebKitBrowserWindow.h:
148         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
149         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
150         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
151         * MiniBrowser/win/WinMain.cpp:
152         (wWinMain):
153
154 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
155
156         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
157         https://bugs.webkit.org/show_bug.cgi?id=199192
158         <rdar://problem/51554509>
159
160         Reviewed by Tim Horton.
161
162         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
163         verify that we gracefully handle web process termination and web view unparenting mid-drag.
164
165         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
166         (TestWebKitAPI::TEST):
167         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
168         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
169         (-[DragAndDropSimulator _resetSimulatedState]):
170         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
171         (-[DragAndDropSimulator _advanceProgress]):
172         (-[DragAndDropSimulator liftPreviews]):
173         (-[DragAndDropSimulator cancellationPreviews]):
174         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
175         (-[DragAndDropSimulator sessionWillBeginBlock]):
176         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
177
178 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
179
180         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
181         https://bugs.webkit.org/show_bug.cgi?id=199178
182
183         Reviewed by Jonathan Bedard.
184
185         * BuildSlaveSupport/ews-build/steps.py:
186         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
187         (ExtractTestResults.__init__): Ditto.
188         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
189
190 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
191
192         Add user agent quirk for bankofamerica.com
193         https://bugs.webkit.org/show_bug.cgi?id=199154
194
195         Reviewed by Carlos Garcia Campos.
196
197         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
198         (TestWebKitAPI::TEST):
199
200 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
201
202         Fully rename WebKitGTK+ -> WebKitGTK everywhere
203         https://bugs.webkit.org/show_bug.cgi?id=199159
204
205         Reviewed by Carlos Garcia Campos.
206
207         * BuildSlaveSupport/gtk/README:
208         * MiniBrowser/gtk/BrowserWindow.c:
209         * MiniBrowser/gtk/main.c:
210         (aboutURISchemeRequestCallback):
211         * Scripts/webkitpy/common/config/contributionareas.py:
212         * Scripts/webkitpy/common/config/contributors.json:
213         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
214         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
215         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
216         (testWebViewResources):
217         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
218         (testWebViewMouseTarget):
219         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
220         (testWebExtensionGetTitle):
221         (testDocumentLoadedSignal):
222         (testWebExtensionFormControlsAssociated):
223         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
224         (testWebKitSettingsUserAgent):
225         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
226         (testWebViewRunJavaScript):
227         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
228         (main):
229         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
230         (prepareContextMenuTestView):
231         (testContextMenuPopulateMenu):
232         (testContextMenuCustomMenu):
233         (testContextMenuDisableMenu):
234         (testContextMenuSubMenu):
235         (testContextMenuDismissed):
236         (testContextMenuWebExtensionMenu):
237         (testContextMenuWebExtensionNode):
238         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
239         (testInspectorDefault):
240         (testInspectorManualAttachDetach):
241         (testInspectorCustomContainerDestroyed):
242         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
243         (testWebViewPrint):
244         (testPrintOperationPrint):
245         (testPrintOperationErrors):
246         * gtk/install-dependencies:
247         * gtk/jhbuild.modules:
248         * gtkdoc/generate-gtkdoc:
249         * wpe/install-dependencies:
250
251 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
252
253         contributors.json not canonicalized since r243297
254         https://bugs.webkit.org/show_bug.cgi?id=199161
255
256         Reviewed by Alexey Proskuryakov.
257
258         Canonicalize it using 'validate-committer-lists --canonicalize'
259
260         * Scripts/webkitpy/common/config/contributors.json:
261
262 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
263
264         webkitpy: Build style should be lower-case
265         https://bugs.webkit.org/show_bug.cgi?id=199158
266
267         Reviewed by Aakash Jain.
268
269         * Scripts/webkitpy/test/main.py:
270         (Tester._run_tests): Make all styles lower-case.
271
272 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
273
274         [ews-build] Remove iOS queue from old EWS and dashboard
275         https://bugs.webkit.org/show_bug.cgi?id=199150
276
277         Reviewed by Jonathan Bedard.
278
279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
280         * QueueStatusServer/config/queues.py:
281
282 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
283
284         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
285         https://bugs.webkit.org/show_bug.cgi?id=198795
286
287         Unreviewed test gardening.
288
289         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
290         (TestWebKitAPI::TEST): Disable flaky test.
291
292 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
293
294         [ews-build] Enable iOS-12-Build queue on new EWS
295         https://bugs.webkit.org/show_bug.cgi?id=199149
296
297         Reviewed by Jonathan Bedard.
298
299         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
300         this queue.
301         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
302         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
303         will keep the builders to the left and testers to the right.
304
305 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
306
307         [ews-build] Upload test results after running layout-tests
308         https://bugs.webkit.org/show_bug.cgi?id=199120
309
310         Reviewed by Jonathan Bedard.
311
312         * BuildSlaveSupport/ews-build/steps.py:
313         (RunWebKitTests.evaluateCommand):
314         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
315
316 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
317
318         [ews-build] EWS should provide option to download layout test results zip file
319         https://bugs.webkit.org/show_bug.cgi?id=199121
320
321         Reviewed by Jonathan Bedard.
322
323         * BuildSlaveSupport/ews-build/steps.py:
324         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
325         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
326
327 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
328
329         Add user agent quirk for Google Drive
330         https://bugs.webkit.org/show_bug.cgi?id=199153
331
332         Reviewed by Carlos Garcia Campos.
333
334         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
335         (TestWebKitAPI::TEST):
336
337 2019-06-22  Zalan Bujtas  <zalan@apple.com>
338
339         [LFC] Expand tests coverage (328 new tests -> 2652).
340
341         * LayoutReloaded/misc/LFC-passing-tests.txt:
342
343 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
344
345         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
346         https://bugs.webkit.org/show_bug.cgi?id=199107
347         <rdar://problem/43663611>
348
349         Reviewed by Chris Fleizach.
350
351         iOS implementation for AccessibilityUIElement::hasPopup.
352         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
353         (WTR::AccessibilityUIElement::hasPopup const):
354
355 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
356
357         Unreviewed, add myself to CMake watchlist
358
359         * Scripts/webkitpy/common/config/watchlist:
360
361 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
362
363         openDatabase should return an empty object when WebSQL is disabled
364         https://bugs.webkit.org/show_bug.cgi?id=198805
365
366         Reviewed by Geoffrey Garen.
367
368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
369         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
370         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
371         (TEST):
372         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
373
374 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
375
376         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
377         https://bugs.webkit.org/show_bug.cgi?id=199114
378         <rdar://problem/51671674>
379
380         Reviewed by Youenn Fablet.
381
382         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
383         (-[TestSOAuthorizationNavigationDelegate init]):
384         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
385         (configureSOAuthorizationWebView):
386         (TestWebKitAPI::TEST):
387
388 2019-06-21  Youenn Fablet  <youenn@apple.com>
389
390         WebPageProxy should use the right path for sandbox extension
391         https://bugs.webkit.org/show_bug.cgi?id=198902
392         <rdar://problem/50772810>
393
394         Reviewed by Geoffrey Garen.
395
396         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
397         (TEST):
398         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
399
400 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
401
402         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
403         https://bugs.webkit.org/show_bug.cgi?id=199094
404
405         Reviewed by Carlos Garcia Campos.
406
407         * MiniBrowser/gtk/BrowserTab.c:
408         (runColorChooserCallback):
409         (browserTabConstructed):
410         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
411         (testWebViewSyncRequestOnMaxConns):
412         (beforeAll):
413         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
414         (testWebSocketTLSErrors):
415         (beforeAll):
416         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
417         (WebKitTestServer::~WebKitTestServer):
418         (WebKitTestServer::getWebSocketURIForPath const):
419         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
420         (WTR::AccessibilityUIElement::rowHeaders const):
421         (WTR::AccessibilityUIElement::columnHeaders const):
422         (WTR::AccessibilityUIElement::isAttributeSettable):
423         (WTR::AccessibilityUIElement::x):
424         (WTR::AccessibilityUIElement::y):
425         (WTR::AccessibilityUIElement::width):
426         (WTR::AccessibilityUIElement::height):
427         (WTR::AccessibilityUIElement::clickPointX):
428         (WTR::AccessibilityUIElement::clickPointY):
429         (WTR::AccessibilityUIElement::intValue const):
430         (WTR::AccessibilityUIElement::minValue):
431         (WTR::AccessibilityUIElement::maxValue):
432         (WTR::stringAtOffset):
433
434 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
435
436         test-webkitpy is broken on macOS Catalina
437         https://bugs.webkit.org/show_bug.cgi?id=199078
438
439         Reviewed by Jonathan Bedard.
440
441         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
442         to the runner.
443         (main): 
444         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
445
446 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
447
448         Change status to "committer" in contributors.json
449
450         Unreviewed.
451
452         * Scripts/webkitpy/common/config/contributors.json:
453
454 2019-06-20  Alex Christensen  <achristensen@webkit.org>
455
456         Add unit test for UIContextMenuConfiguration API
457         https://bugs.webkit.org/show_bug.cgi?id=199043
458
459         Reviewed by Wenson Hsieh.
460
461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
462         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
463         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
464         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
465         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
466         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
467         (TEST):
468         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
469         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
470         (-[TestContextMenuDriver delegate]):
471         (-[TestContextMenuDriver setDelegate:]):
472         (-[TestContextMenuDriver view]):
473         (-[TestContextMenuDriver setView:]):
474         (-[TestContextMenuDriver allowableMovement]):
475         (-[TestContextMenuDriver setAllowableMovement:]):
476         (-[TestContextMenuDriver primaryGestureRecognizer]):
477         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
478         (-[TestContextMenuDriver touchDuration]):
479         (-[TestContextMenuDriver setTouchDuration:]):
480         (-[TestContextMenuDriver locationInCoordinateSpace:]):
481         (-[TestContextMenuDriver cancelInteraction]):
482         (-[TestContextMenuDriver begin:]):
483         (-[TestContextMenuDriver clickDown]):
484         (-[TestContextMenuDriver clickUp]):
485         (-[TestContextMenuDriver end]):
486         * TestWebKitAPI/ios/UIKitSPI.h:
487
488 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
489
490         [ews-app] Status bubble should not turn orange when any build step is skipped
491         https://bugs.webkit.org/show_bug.cgi?id=199079
492
493         Reviewed by Jonathan Bedard.
494
495         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
496
497 2019-06-20  Alex Christensen  <achristensen@webkit.org>
498
499         Fix an internal engineering build after r246605
500        ​https://bugs.webkit.org/show_bug.cgi?id=197800
501
502         * TestWebKitAPI/TCPServer.cpp:
503
504 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
505
506         [ews-build] Triggered builds should use same revision as parent build
507         https://bugs.webkit.org/show_bug.cgi?id=198289
508
509         Reviewed by Jonathan Bedard.
510
511         * BuildSlaveSupport/ews-build/steps.py:
512         (CheckOutSpecificRevision): Build step to checkout specific revision.
513         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
514         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
515         (CheckOutSpecificRevision.start): Run appropriate git command.
516         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
517         builds use same revision as parent build.
518         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
519         * BuildSlaveSupport/ews-build/factories.py:
520         (Factory.__init__): Added CheckOutSpecificRevision step.
521
522 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
523
524         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
525         https://bugs.webkit.org/show_bug.cgi?id=199073
526
527         Reviewed by Jonathan Bedard.
528
529         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
530
531 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
532
533         [GTK] Enable navigation swipe layout tests
534         https://bugs.webkit.org/show_bug.cgi?id=198995
535
536         Reviewed by Michael Catanzaro.
537
538         Add a way for tests to enable and then control swipe gesture on GTK.
539
540         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
541         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
542         * WebKitTestRunner/PlatformGTK.cmake:
543         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
544         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
545         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
546         (WTR::UIScriptController::beginBackSwipe):
547         (WTR::UIScriptController::completeBackSwipe):
548
549 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
550
551         [GTK] HTTP layout tests don't run in flatpak
552         https://bugs.webkit.org/show_bug.cgi?id=199067
553
554         Reviewed by Michael Catanzaro.
555
556         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
557         check that path. Instead, add /app/lib/perl to Apache config directly.
558
559         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
560         /.flatpak-info instead.
561
562         * Scripts/webkitpy/port/base.py:
563         (Port._is_flatpak):
564         (Port._in_flatpak_sandbox):
565         * flatpak/flatpakutils.py:
566         (WebkitFlatpak.run_in_sandbox):
567         (is_sandboxed):
568
569 2019-06-18  Darin Adler  <darin@apple.com>
570
571         Tidy up the remaining bits of the AtomicString to AtomString rename
572         https://bugs.webkit.org/show_bug.cgi?id=198990
573
574         Reviewed by Michael Catanzaro.
575
576         * Scripts/do-webcore-rename: Removed already-done renames.
577         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
578
579 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
580
581         [GTK] Remove support for GTK2 plugins
582         https://bugs.webkit.org/show_bug.cgi?id=199065
583
584         Reviewed by Sergio Villar Senin.
585
586         * EWSTools/ubuntu-ews-packages:
587         * TestWebKitAPI/PlatformGTK.cmake:
588         * WebKitTestRunner/PlatformGTK.cmake:
589         * flatpak/org.webkit.GTK.yaml:
590         * gtk/install-dependencies:
591
592 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
593
594         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
595         https://bugs.webkit.org/show_bug.cgi?id=199053
596
597         Reviewed by Saam Barati.
598
599         Added a test stressing IsoHeap with multiple threads.
600
601         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
602         (assertHasObjects):
603         (assertHasOnlyObjects):
604         (assertClean):
605         (TEST):
606
607 2019-06-19  Zalan Bujtas  <zalan@apple.com>
608
609         [LFC] Expand tests coverage (1126 new tests -> 2324).
610
611         * LayoutReloaded/misc/LFC-passing-tests.txt:
612
613 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
614
615         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
616         https://bugs.webkit.org/show_bug.cgi?id=198957
617
618         Reviewed by Alex Christensen.
619
620         * TestWebKitAPI/CMakeLists.txt:
621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
622         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
623
624 2019-06-19  Keith Rollin  <krollin@apple.com>
625
626         Relocate some test tools in non-mac builds
627         https://bugs.webkit.org/show_bug.cgi?id=198984
628         <rdar://problem/51873261>
629
630         Reviewed by Andy Estes.
631
632         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
633         TestNetscapePlugin get created in
634         WebKit.framework/Versions/A/Resources on non-mac builds. This is
635         incorrect, as those bundles are shallow bundles that don't use the
636         Versions hierarchy. Instead, store these files directly in
637         WebKit.framework.
638
639         Note that getting rid of just the "Versions/A" path components and
640         putting the files in WebKit.framework/Resources doesn't work as
641         `codesign` treats the result as an invalid layout.
642
643         The work in this patch involves changing the definition of the custom
644         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
645         variable INSTALL_PATH is defined in terms of this variable. In order
646         to increase visiblity into this relationship, move both of these
647         variables into .xcconfig files if they weren't already. This
648         refactoring was done in a way to be the least disruptive and most
649         compatible with the previous definitions, even at the cost of being
650         repetitive.
651
652         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
653         * DumpRenderTree/mac/Configurations/Base.xcconfig:
654         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
655         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
656         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
657         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
658
659 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
660
661         [ews-build] Patch link should open the pretty patch
662         https://bugs.webkit.org/show_bug.cgi?id=199031
663
664         Reviewed by Jonathan Bedard.
665
666         * BuildSlaveSupport/ews-build/steps.py:
667         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
668
669 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
670
671         [ews-build] Add step to analyze Compile WebKit failures
672         https://bugs.webkit.org/show_bug.cgi?id=199025
673
674         Reviewed by Jonathan Bedard.
675
676         * BuildSlaveSupport/ews-build/steps.py:
677         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
678         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
679         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
680         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
681         this step is run only when compile-webkit failed.
682
683 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
684
685         [ews-build] Send email notifications for failures
686         https://bugs.webkit.org/show_bug.cgi?id=198919
687
688         Reviewed by Jonathan Bedard.
689
690         * BuildSlaveSupport/ews-build/master.cfg:
691
692 2019-06-19  Alex Christensen  <achristensen@webkit.org>
693
694         Add a unit test for client certificate authentication
695         https://bugs.webkit.org/show_bug.cgi?id=197800
696
697         Reviewed by Youenn Fablet.
698
699         Make better abstractions for reading and writing from/to TCPServer.
700         Add a unit test that causes a client certificate authentication challenge to happen.
701
702         * TestWebKitAPI/TCPServer.cpp:
703         (TestWebKitAPI::TCPServer::TCPServer):
704         (TestWebKitAPI::TCPServer::read):
705         (TestWebKitAPI::TCPServer::write):
706         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
707         (TestWebKitAPI::TCPServer::respondWithOK):
708         * TestWebKitAPI/TCPServer.h:
709         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
710         (credentialWithIdentity):
711         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
712         (TEST):
713         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
714         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
715         (-[ClientCertificateDelegate challengeCount]):
716         (TestWebKitAPI::TEST):
717         (respondWithChallengeThenOK): Deleted.
718         (credentialWithIdentityAndKeychainPath): Deleted.
719         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
720         (TEST):
721         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
722         (TestWebKitAPI::TEST):
723         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
724         (TEST):
725         (readRequest): Deleted.
726         (writeResponse): Deleted.
727         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
728         (TestWebKitAPI::TEST):
729         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
730
731 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
732
733         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
734
735         System headers are being included without SYSTEM again here.
736
737         * TestWebKitAPI/PlatformGTK.cmake:
738
739 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
740
741         [JSC] JSLock should be WebThread aware
742         https://bugs.webkit.org/show_bug.cgi?id=198911
743
744         Reviewed by Geoffrey Garen.
745
746         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
747         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
748         (TestWebKitAPI::TEST):
749
750 2019-06-18  Keith Miller  <keith_miller@apple.com>
751
752         webkit-patch should allow for a bugzilla url not just bugzilla id
753         https://bugs.webkit.org/show_bug.cgi?id=198972
754
755         Reviewed by Dewei Zhu.
756
757         When prompting for a bugzilla id or a new title we should also
758         allow for a bugzilla url.
759
760         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
761         (PromptForBugOrTitle.run):
762
763 2019-06-18  David Quesada  <david_quesada@apple.com>
764
765         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
766         https://bugs.webkit.org/show_bug.cgi?id=198954
767         rdar://problem/51711556
768
769         Reviewed by Alex Christensen.
770
771         For these tests, kill the web process after the download starts. This makes the deallocation
772         of the download-originating web views, which these tests depend on, more reliable.
773
774         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
775         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
776         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
777
778 2019-06-18  Dan Bernstein  <mitz@apple.com>
779
780         Revert workaround for bug 198904 from run-webkit-archive
781         https://bugs.webkit.org/show_bug.cgi?id=198931
782
783         Reviewed by Alexey Proskuryakov.
784
785         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
786         pick up the built frameworks.
787
788         * WebKitArchiveSupport/run-webkit-archive:
789         (set_dyld_framework_path):
790
791 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
792
793         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
794         https://bugs.webkit.org/show_bug.cgi?id=198854
795         <rdar://problem/51386058>
796
797         Reviewed by Geoffrey Garen.
798
799         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
800         (TestWebKitAPI::TEST):
801
802 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
803
804         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
805         https://bugs.webkit.org/show_bug.cgi?id=198831
806
807         Reviewed by Žan Doberšek.
808
809         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
810         * wpe/jhbuild.modules: Ditto.
811         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
812         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
813
814 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
815
816         Move SOAuthorization from WebKitAdditions to WebKit
817         https://bugs.webkit.org/show_bug.cgi?id=198874
818         <rdar://problem/47573431>
819
820         Reviewed by Brent Fulgham.
821
822         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
823
824         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
825         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
826         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
827         (-[TestSOAuthorizationNavigationDelegate init]):
828         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
829         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
830         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
831         (-[TestSOAuthorizationViewController viewDidAppear]):
832         (-[TestSOAuthorizationViewController viewDidDisappear]):
833         (overrideCanPerformAuthorizationWithURL):
834         (overrideSetDelegate):
835         (overrideBeginAuthorizationWithURL):
836         (overrideCancelAuthorization):
837         (overrideAddObserverForName):
838         (overrideIsURLFromAppleOwnedDomain):
839         (resetState):
840         (configureSOAuthorizationWebView):
841         (generateHtml):
842         (checkAuthorizationOptions):
843         (TestWebKitAPI::TEST):
844
845 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
846
847         Ensure ITP state is relayed to Network Process on restart
848         https://bugs.webkit.org/show_bug.cgi?id=198797
849         <rdar://problem/51646944>
850
851         Reviewed by Youenn Fablet.
852
853         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
854         (cleanupITPDatabase): Added.
855         (TEST:EnableDisableITP): Update to use cleanup method.
856         (TEST:NetworkProcessRestart): Added.
857
858 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
859
860         New EWS can't process patches larger than 640kb
861         https://bugs.webkit.org/show_bug.cgi?id=198851
862
863         Reviewed by Jonathan Bedard.
864
865         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
866
867 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
868
869         webkitpy: Add macOS Catalina, iOS 13
870         https://bugs.webkit.org/show_bug.cgi?id=198492
871
872         Reviewed by Alexey Proskuryakov.
873
874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
875         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
876         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
877         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
878         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
880         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
882         * BuildSlaveSupport/ews-build/steps.py:
883         * Scripts/webkitpy/common/version_name_map.py:
884         * Scripts/webkitpy/common/version_name_map_unittest.py:
885         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
886         * TestResultServer/static-dashboards/flakiness_dashboard.js:
887
888 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
889
890         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
891
892         * gtk/jhbuild.modules:
893         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
894         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
895
896 2019-06-16  Zalan Bujtas  <zalan@apple.com>
897
898         [LFC] Expand tests coverage (325 new tests -> 1198).
899
900         * LayoutReloaded/misc/LFC-passing-tests.txt:
901
902 2019-06-16  Darin Adler  <darin@apple.com>
903
904         Rename AtomicString to AtomString
905         https://bugs.webkit.org/show_bug.cgi?id=195276
906
907         Reviewed by Michael Catanzaro.
908
909         * many files: Let do-webcore-rename do the renaming.
910
911         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
912         that mention "atomic string" and changed them to instead say "atom string".
913
914 2019-06-16  Zalan Bujtas  <zalan@apple.com>
915
916         [LFC] Unreviewed test gardening.
917
918         Unsupported alignments.
919
920         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
921         fast/borders/empty-outline-border-assert.html -vertical-align: super
922         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
923
924         * LayoutReloaded/misc/LFC-passing-tests.txt:
925
926 2019-06-15  Youenn Fablet  <youenn@apple.com>
927
928         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
929         https://bugs.webkit.org/show_bug.cgi?id=198780
930
931         Reviewed by Jonathan Bedard.
932
933         * Scripts/webkitpy/w3c/test_importer.py:
934         (TestImporter._webkit_test_runner_options):
935         In case the test file cannot be read as text, consider that there is no WTR option.
936
937 2019-06-14  Youenn Fablet  <youenn@apple.com>
938
939         WebResourceLoadStatisticsStore should not use its network session if invalidated
940         https://bugs.webkit.org/show_bug.cgi?id=198814
941
942         Reviewed by Geoffrey Garen.
943
944         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
945         (TEST):
946
947 2019-06-14  Youenn Fablet  <youenn@apple.com>
948
949         import-w3c-tests should respect WEBKIT_OUTPUTDIR
950         https://bugs.webkit.org/show_bug.cgi?id=198682
951         <rdar://problem/51536931>
952
953         Reviewed by Jonathan Bedard.
954
955         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
956         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
957
958         * Scripts/webkitpy/common/webkit_finder.py:
959         (WebKitFinder.path_from_webkit_outputdir):
960         * Scripts/webkitpy/w3c/common.py:
961         (WPTPaths):
962         (WPTPaths.checkout_directory):
963         (WPTPaths.wpt_checkout_path):
964         * Scripts/webkitpy/w3c/test_importer.py:
965         (TestImporter.__init__):
966         * Scripts/webkitpy/w3c/test_importer_unittest.py:
967         (test_checkout_directory):
968
969 2019-06-13  Antoine Quint  <graouts@apple.com>
970
971         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
972         https://bugs.webkit.org/show_bug.cgi?id=198800
973         <rdar://problem/51679634>
974
975         Reviewed by Tim Horton.
976
977         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
978         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
979
980         * DumpRenderTree/mac/EventSendingController.mm:
981         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
982         (-[EventSendingController mouseDown:withModifiers:]):
983         (-[EventSendingController mouseUp:withModifiers:]):
984         (-[EventSendingController mouseMoveToX:Y:]):
985
986 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
987
988         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
989         https://bugs.webkit.org/show_bug.cgi?id=198820
990
991         Reviewed by Ross Kirsling.
992
993         WebView window paints nothing because it is moved out of the
994         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
995         as DumpRenderTree does.
996
997         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
998         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
999
1000 2019-06-13  Tim Horton  <timothy_horton@apple.com>
1001
1002         Make it possible for validate-committer-lists to dump a mailmap file
1003         https://bugs.webkit.org/show_bug.cgi?id=198517
1004
1005         Reviewed by Simon Fraser.
1006
1007         Mailmaps wildly improve the output of various Git tools, including
1008         `git shortlog -sne`, mapping committers to our canonical name/email pair.
1009
1010         * Scripts/validate-committer-lists:
1011         (CommitterListFromGit):
1012         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
1013         Add some missing legacy username mappings.
1014
1015         (dump_mailmap):
1016         (dump_mailmap.format_email):
1017         (dump_mailmap.format_email_with_gitsvn_uuid):
1018         (dump_mailmap.map_emails_to_legacy_username):
1019         (main):
1020         Add `validate-committer-lists --dump-mailmap`, which generates
1021         one given committers.json and the existing mapping of legacy username
1022         to email addresses that exists in validate-committer-lists.
1023
1024 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
1025
1026         Replace double-quotes with single quotes in loadConfig.py
1027         https://bugs.webkit.org/show_bug.cgi?id=198792
1028
1029         Reviewed by Jonathan Bedard.
1030
1031         * BuildSlaveSupport/ews-build/loadConfig.py:
1032         * BuildSlaveSupport/ews-build/steps_unittest.py:
1033
1034 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
1035
1036         Add mechanism and test case to check if ITP is active
1037         https://bugs.webkit.org/show_bug.cgi?id=198694
1038         <rdar://problem/51557704>
1039
1040         Reviewed by Youenn Fablet.
1041
1042         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1043         (TEST):
1044
1045 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1046
1047         [WPE][GTK] Deprecate WebSQL APIs
1048         https://bugs.webkit.org/show_bug.cgi?id=195011
1049
1050         Reviewed by Carlos Garcia Campos.
1051
1052         * MiniBrowser/gtk/main.c:
1053         (gotWebsiteDataCallback):
1054         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1055         (testWebsiteDataConfiguration):
1056         (testWebsiteDataEphemeral):
1057         (testWebsiteDataDatabases):
1058
1059 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1060
1061         [WPE][GTK] Enable hyperlink auditing
1062         https://bugs.webkit.org/show_bug.cgi?id=197845
1063
1064         Reviewed by Carlos Garcia Campos.
1065
1066         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1067         (testWebKitSettings):
1068
1069 2019-06-11  Keith Rollin  <krollin@apple.com>
1070
1071         Open up xcfilelist processing to more platforms
1072         https://bugs.webkit.org/show_bug.cgi?id=198675
1073         <rdar://problem/51533238>
1074
1075         Reviewed by Jonathan Bedard.
1076
1077         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
1078         platforms on which to perform xcfilelist generation/updating.
1079
1080         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
1081         (JavaScriptCoreGenerator):
1082         (WebCoreGenerator):
1083         (WebKitGenerator):
1084
1085 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
1086
1087         webkitpy: Fix device ASan reporting, add testing for report configurations
1088         https://bugs.webkit.org/show_bug.cgi?id=198756
1089
1090         Reviewed by Aakash Jain.
1091
1092         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
1093         configuration thoroughly in webkitpy.
1094
1095         * Scripts/webkitpy/port/config.py:
1096         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
1097         * Scripts/webkitpy/port/device_port.py:
1098         (DevicePort.configuration_for_upload): Add ASan as style.
1099         * Scripts/webkitpy/port/ios_device_unittest.py:
1100         (IOSDeviceTest):
1101         (IOSDeviceTest.test_default_upload_configuration):
1102         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1103         (IOSSimulatorTest.test_default_upload_configuration):
1104         * Scripts/webkitpy/port/mock_drt_unittest.py:
1105         (MockDRTPortTest.test_asan_upload_configuration):
1106         * Scripts/webkitpy/port/port_testcase.py:
1107         (test_default_upload_configuration):
1108         (test_debug_upload_configuration):
1109         (test_asan_upload_configuration):
1110         (test_guard_malloc_configuration):
1111         * Scripts/webkitpy/port/watch_simulator_unittest.py:
1112         (WatchSimulatorTest):
1113         (WatchSimulatorTest.test_default_upload_configuration):
1114
1115 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1116
1117         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
1118         https://bugs.webkit.org/show_bug.cgi?id=198749
1119
1120         Reviewed by Carlos Garcia Campos.
1121
1122         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1123         (TestWebKitAPI::TEST):
1124
1125 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1126
1127         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
1128         https://bugs.webkit.org/show_bug.cgi?id=198735
1129         <rdar://problem/51557159>
1130
1131         Reviewed by Megan Gardner.
1132
1133         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
1134         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
1135
1136         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1137         (TestWebKitAPI::TEST):
1138
1139 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
1140
1141         Unreviewed, add myself to the JavaScriptCore watchlist.
1142
1143         * Scripts/webkitpy/common/config/watchlist:
1144
1145 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
1146
1147         Unreviewed, change my status to be a WebKit reviewer
1148
1149         * Scripts/webkitpy/common/config/contributors.json:
1150
1151 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1152
1153         [WPE] Use new exported image API from fdo backend
1154         https://bugs.webkit.org/show_bug.cgi?id=198558
1155
1156         Reviewed by Philippe Normand.
1157
1158         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
1159         WPEToolingBackends that already depends on fdo backend and libxkb
1160         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
1161         * wpe/backends/HeadlessViewBackend.cpp:
1162         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1163         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1164         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
1165         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
1166         * wpe/backends/HeadlessViewBackend.h:
1167         * wpe/backends/ViewBackend.cpp:
1168         (WPEToolingBackends::ViewBackend::initialize):
1169         * wpe/backends/ViewBackend.h:
1170         * wpe/backends/WindowViewBackend.cpp:
1171         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1172         * wpe/backends/WindowViewBackend.h:
1173
1174 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
1175
1176         Extend run-benchmark to allow diagnosing before closing browser on test failure.
1177         https://bugs.webkit.org/show_bug.cgi?id=198729
1178
1179         Reviewed by Ryosuke Niwa.
1180
1181         Add '--diagnose-directory' option to store diagnose information when test failed.
1182
1183         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1184         (BenchmarkRunner.__init__):
1185         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1186         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
1187         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
1188         (parse_args):
1189         (run_benchmark_plan):
1190         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
1191         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
1192         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1193         (WebServerBenchmarkRunner.__init__):
1194         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
1195
1196 2019-06-10  Sam Weinig  <weinig@apple.com>
1197
1198         Remove Dashboard support
1199         https://bugs.webkit.org/show_bug.cgi?id=198615
1200
1201         Reviewed by Ryosuke Niwa.
1202
1203         * DumpRenderTree/TestRunner.cpp:
1204         (TestRunner::staticFunctions):
1205         (setUseDashboardCompatibilityModeCallback): Deleted.
1206         * DumpRenderTree/TestRunner.h:
1207         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1208         * DumpRenderTree/mac/DumpRenderTree.mm:
1209         (resetWebViewToConsistentStateBeforeTesting):
1210         * DumpRenderTree/mac/TestRunnerMac.mm:
1211         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
1212         * ImageDiff/cg/Configurations/Base.xcconfig:
1213         * Scripts/webkitperl/FeatureList.pm:
1214         * TestWebKitAPI/Configurations/Base.xcconfig:
1215         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1217         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
1218         * WebKitTestRunner/Configurations/Base.xcconfig:
1219         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1220         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1221         (WTR::InjectedBundle::beginTesting):
1222         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1223         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
1224         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1225
1226 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
1227
1228         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
1229         https://bugs.webkit.org/show_bug.cgi?id=198616
1230         rdar://problem/36386573
1231
1232         Reviewed by David Kilzer.
1233
1234         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
1235
1236         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1237         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1238         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1239         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
1240         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
1241         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
1242         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
1243         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1244         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1245         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1246
1247 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1248
1249         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
1250         https://bugs.webkit.org/show_bug.cgi?id=198699
1251         <rdar://problem/50501718>
1252
1253         Reviewed by Simon Fraser.
1254
1255         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
1256         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
1257         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
1258         viewport parameters are used.
1259
1260         * WebKitTestRunner/ios/TestControllerIOS.mm:
1261         (WTR::TestController::platformResetPreferencesToConsistentValues):
1262         (WTR::TestController::platformConfigureViewForTest):
1263
1264 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
1265
1266         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
1267         https://bugs.webkit.org/show_bug.cgi?id=198023
1268
1269         Reviewed by Saam Barati.
1270
1271         * Scripts/run-jsc-stress-tests:
1272
1273 2019-06-10  Timothy Hatcher  <timothy@apple.com>
1274
1275         Integrate dark mode support for iOS.
1276         https://bugs.webkit.org/show_bug.cgi?id=198687
1277         rdar://problem/51545643
1278
1279         Reviewed by Tim Horton.
1280
1281         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1282
1283 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
1284
1285         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
1286         https://bugs.webkit.org/show_bug.cgi?id=198723
1287
1288         Reviewed by Aakash Jain.
1289
1290         * Scripts/webkitpy/xcode/simulated_device.py:
1291         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
1292
1293 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
1294
1295         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
1296         https://bugs.webkit.org/show_bug.cgi?id=198635
1297         <rdar://problem/46010232>
1298
1299         Reviewed by Ryosuke Niwa.
1300
1301         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1302         (areCookiesEqual):
1303         (TEST):
1304
1305 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
1306
1307         [JHBuild] Bump shared-mime-info to version ≥ 1.6
1308         https://bugs.webkit.org/show_bug.cgi?id=198714
1309
1310         Reviewed by Carlos Garcia Campos.
1311
1312         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
1313         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
1314         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
1315
1316 2019-06-10  Philippe Normand  <pnormand@igalia.com>
1317
1318         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
1319         https://bugs.webkit.org/show_bug.cgi?id=198713
1320
1321         Reviewed by Carlos Garcia Campos.
1322
1323         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
1324         patches currently used in JHBuild.
1325
1326 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
1327
1328         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
1329         https://bugs.webkit.org/show_bug.cgi?id=198711
1330
1331         Reviewed by Philippe Normand.
1332
1333         * flatpak/org.webkit.GTK.yaml: Also include modules from
1334         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
1335
1336 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
1337
1338         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
1339         avoids double-free condition that's causing bots to exit early.
1340
1341         * gtk/jhbuild.modules:
1342         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
1343         * wpe/jhbuild.modules:
1344         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
1345
1346 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1347
1348         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
1349         https://bugs.webkit.org/show_bug.cgi?id=198655
1350
1351         Reviewed by Ross Kirsling.
1352
1353         MediaCapabilities is enabled by default for WK2, but WinCairo
1354         doesn't implemented yet. Disable it in MiniBrowser.
1355
1356         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1357         (WebKitBrowserWindow::create):
1358
1359 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1360
1361         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
1362         https://bugs.webkit.org/show_bug.cgi?id=198693
1363         <rdar://problem/51555371>
1364
1365         Reviewed by Tim Horton.
1366
1367         Augment an existing API test to exercise three additional scenarios:
1368             -   The web view configuration's application name is never set; the default should not include
1369                 "Mobile/15E148" in desktop mode.
1370             -   The application name is explicitly set to nil; the default application name should still not include
1371                 "Mobile/15E148".
1372             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
1373                 this when generating the user agent, even in desktop mode.
1374
1375         * TestWebKitAPI/ios/PreferredContentMode.mm:
1376         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
1377         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
1378         (TestWebKitAPI::TEST):
1379
1380 2019-06-08  Zalan Bujtas  <zalan@apple.com>
1381
1382         [LFC] Unreviewed test gardening.
1383
1384         Remove rtl tests. They were mistakenly marked as pass.
1385
1386         * LayoutReloaded/misc/LFC-passing-tests.txt:
1387
1388 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1389
1390         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
1391         https://bugs.webkit.org/show_bug.cgi?id=198664
1392
1393         Reviewed by Simon Fraser.
1394
1395         Delete repeated entries which were submitted by mistake.
1396
1397         * Tracing/SystemTracePoints.plist:
1398
1399 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1400
1401         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
1402         https://bugs.webkit.org/show_bug.cgi?id=198631
1403         <rdar://problem/51505431>
1404
1405         Reviewed by Tim Horton.
1406
1407         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
1408
1409         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1410         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
1411         (-[CustomInputWebView inputView]):
1412         (-[CustomInputWebView inputAccessoryView]):
1413         (TestWebKitAPI::TEST):
1414
1415 2019-06-07  Daniel Bates  <dabates@apple.com>
1416
1417         [lldb-webkit] Pretty-print all kinds of Documents
1418         https://bugs.webkit.org/show_bug.cgi?id=198620
1419
1420         Reviewed by Simon Fraser.
1421
1422         Register formatters for all classes derived from WebCore::Document so we get nice summaries
1423         without having to drill down in Xcode- or casting- to the base class, Document.
1424
1425         Older LLDB versions use to do this automatically, but this functionality was removed in newer
1426         versions:
1427             [[
1428                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
1429                 chains, but also through inheritance chains. This feature has been removed since it
1430                 significantly degrades performance. You need to set up your formatters for every type in
1431                 inheritance chains to which you want the formatter to apply.
1432             ]]
1433             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
1434
1435         * lldb/lldb_webkit.py:
1436         (__lldb_init_module):
1437
1438 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
1439
1440         webkitpy: Support reporting results for uncommon test configurations
1441         https://bugs.webkit.org/show_bug.cgi?id=198662
1442         <rdar://problem/51524128>
1443
1444         Reviewed by Aakash Jain.
1445
1446         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1447         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
1448         * Scripts/webkitpy/port/base.py:
1449         (Port.configuration_for_upload): Set flavor based on options.
1450         * Scripts/webkitpy/results/options.py:
1451         (upload_options): Add result-report-flavor option.
1452         * Scripts/webkitpy/test/main.py:
1453         (Tester._run_tests): Set flavor based on options.
1454
1455 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1456
1457         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
1458         https://bugs.webkit.org/show_bug.cgi?id=198641
1459         <rdar://problem/51266310>
1460
1461         Reviewed by Tim Horton.
1462
1463         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
1464         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
1465         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
1466         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
1467         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
1468         reproduces on iOS simulator.
1469
1470         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
1471         representation is actually ignored by most clients anyways (including WebKit), in favor of using
1472         "com.apple.flat-rtfd".
1473
1474         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1475         (TestWebKitAPI::TEST):
1476         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1477         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
1478         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1479
1480 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1481
1482         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
1483         https://bugs.webkit.org/show_bug.cgi?id=198607
1484
1485         Reviewed by Michael Catanzaro.
1486
1487         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
1488         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
1489         determine the type of the tests.
1490
1491         * Scripts/run-gtk-tests:
1492         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
1493         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
1494         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
1495         (GtkTestRunner.is_google_test): Ditto.
1496         * Scripts/run-wpe-tests:
1497         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
1498         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
1499         (WPETestRunner.is_google_test): Ditto.
1500         * glib/api_test_runner.py:
1501         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
1502         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
1503
1504 2019-06-06  Keith Rollin  <krollin@apple.com>
1505
1506         Remove SSL-based tests from TestWebKitAPI on some configurations
1507         https://bugs.webkit.org/show_bug.cgi?id=198551
1508         <rdar://problem/51424996>
1509
1510         Reviewed by Jonathan Bedard.
1511
1512         Not all platforms have SSL handy, so don't include SSL-based tests on
1513         those platforms.
1514
1515         * TestWebKitAPI/TCPServer.cpp:
1516         * TestWebKitAPI/TCPServer.h:
1517         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1518         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1519         * TestWebKitAPI/config.h:
1520
1521 2019-06-06  Daniel Bates  <dabates@apple.com>
1522
1523         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
1524         non-default port number
1525         https://bugs.webkit.org/show_bug.cgi?id=198618
1526
1527         Reviewed by Brent Fulgham.
1528
1529         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
1530         a string before we concatenate it with another string when building the string representation
1531         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
1532         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
1533
1534         * lldb/lldb_webkit.py:
1535         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
1536
1537 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
1538
1539         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
1540         https://bugs.webkit.org/show_bug.cgi?id=198613
1541
1542         Reviewed by Alexey Proskuryakov.
1543
1544         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
1545
1546 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
1547
1548         webkitpluginhost: Support ASan as a style
1549         https://bugs.webkit.org/show_bug.cgi?id=198586
1550         <rdar://problem/51459088>
1551
1552         Reviewed by Alexey Proskuryakov.
1553
1554         * Scripts/webkitpy/port/base.py:
1555         (Port.configuration_for_upload): Add ASan as a style.
1556         * Scripts/webkitpy/port/config.py:
1557         (Config._read_configuration):
1558         (Config):
1559         (Config.asan): Add property to check if the ASan configuration is active.
1560         * Scripts/webkitpy/port/config_unittest.py:
1561         (ConfigTest.test_default_configuration__scripterror):
1562         (ConfigTest):
1563         (ConfigTest.test_asan):
1564         * Scripts/webkitpy/test/main.py:
1565         (Tester._run_tests): Add Asan as a style.
1566
1567 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
1568
1569         block-spammers tool doesn't block e-mail
1570         https://bugs.webkit.org/show_bug.cgi?id=198570
1571
1572         Reviewed by Jonathan Bedard.
1573
1574         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
1575         recognize "false" here. Also, request body is unnecessary.
1576
1577 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1578
1579         [GTK][WPE] Enable PSON
1580         https://bugs.webkit.org/show_bug.cgi?id=194979
1581
1582         Reviewed by Žan Doberšek.
1583
1584         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
1585
1586         * gtk/jhbuild.modules:
1587         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
1588         * wpe/jhbuild.modules:
1589         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
1590
1591 2019-06-05  Andy Estes  <aestes@apple.com>
1592
1593         [macOS] Stop calling -[NSDraggingItem setItem:]
1594         https://bugs.webkit.org/show_bug.cgi?id=198588
1595         <rdar://problem/48297453>
1596
1597         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
1598
1599         Reviewed by Wenson Hsieh.
1600
1601         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
1602         TestRunnerShared group.
1603
1604         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1605         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1606         Changed to call -[NSDraggingItem _initWithItem:] when available.
1607
1608         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
1609         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
1610         declarations here from DumpRenderTree.
1611
1612         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1613         Added TestRunnerShared/spi/AppKitTestSPI.h.
1614
1615         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1616         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1617         Changed to call -[NSDraggingItem _initWithItem:] when available.
1618
1619 2019-06-05  Jer Noble  <jer.noble@apple.com>
1620
1621         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
1622         https://bugs.webkit.org/show_bug.cgi?id=198585
1623
1624         Reviewed by Chris Dumez.
1625
1626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1627         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1628         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
1629         (TEST):
1630         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
1631
1632 2019-06-05  Alex Christensen  <achristensen@webkit.org>
1633
1634         Re-enable safe browsing in WKWebView
1635         https://bugs.webkit.org/show_bug.cgi?id=196161
1636         <rdar://problem/49171413>
1637
1638         Reviewed by Ryosuke Niwa.
1639
1640         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1641         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1642         (TEST):
1643         (safeBrowsingView):
1644
1645 == Rolled over to ChangeLog-2019-06-05 ==