lint-test-expectations should be run during style checking
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2
3         lint-test-expectations should be run during style checking
4         https://bugs.webkit.org/show_bug.cgi?id=173559
5         <rdar://problem/32854941>
6
7         Reviewed by Aakash Jain.
8
9         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
10         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
11         prevents identifying errors on specific lines in a file.
12         * Scripts/webkitpy/style/main_unittest.py:
13         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
14         case where a linter error is in the file modified, but the line modified is not related to
15         the linter error.
16
17 2017-07-20  Brady Eidson  <beidson@apple.com>
18
19         Remove WebIconDatabase from WebKitLegacy/win.
20         https://bugs.webkit.org/show_bug.cgi?id=174608
21
22         Reviewed by Alex Christensen.
23
24         * DumpRenderTree/win/DumpRenderTree.cpp:
25         (main):
26         * DumpRenderTree/win/TestRunnerWin.cpp:
27         (TestRunner::setIconDatabaseEnabled):
28
29 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
30
31         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
32         https://bugs.webkit.org/show_bug.cgi?id=174671
33
34         Reviewed by Carlos Garcia Campos.
35
36         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
37         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
38         priority for this source in order to have it dispatched on the same
39         priority as the other WebKit-controlled GSource objects.
40
41 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
42
43         lint-test-expectations should be run during style checking
44         https://bugs.webkit.org/show_bug.cgi?id=173559
45         <rdar://problem/32854941>
46
47         Reviewed by Daniel Bates.
48
49         Follow up fix addressing style and a few minor bugs.
50
51         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
52         (TestExpectationParser.__init__): Use lambda x: x instead of str
53         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
54         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
55         reduce the calls of _shorten_filename, fix minor bug in appending the current
56         expectation's line number instead of the previous ones, clarify treatment of None
57         in file-to-line-number mapping.
58         (TestExpectations._report_warnings): Collapse call.
59         * Scripts/webkitpy/style/checkers/test_expectations.py:
60         (TestExpectationsChecker.lint_test_expectations):
61         * Scripts/webkitpy/style/filereader.py: Re-write comment.
62         (TextFileReader.process_file): Add comment explaining treatment of None in
63         file-to-line-number mapping.
64         (TextFileReader.delete_file): Collapse call.
65
66 2017-07-19  Chris Dumez  <cdumez@apple.com>
67
68         Unreviewed attempt to fix API test failure after r219663.
69
70         The test was hard-coding an exception string and the string has changed slightly
71         in r219663.
72
73         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
74         (TEST):
75
76 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
77
78         Don't write file URLs to iOS Pasteboard
79         https://bugs.webkit.org/show_bug.cgi?id=174647
80         <rdar://problem/33199730>
81
82         Reviewed by Wenson Hsieh.
83
84         Updating tests to reflect the lack of file URLs for images.
85
86         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
87         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
88         (checkEstimatedSize):
89         (TestWebKitAPI::TEST):
90
91 2017-07-19  Brady Eidson  <beidson@apple.com>
92
93         iBooks sometimes crashes when closing a book.
94         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
95
96         Reviewed by Oliver Hunt.
97
98         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
99         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
100         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
101         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
102         (TestWebKitAPI::TEST):
103
104         Add a "spin the runloop X number of times" utility:
105         * TestWebKitAPI/Utilities.h:
106         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
107         (TestWebKitAPI::Util::spinRunLoop):
108
109 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
110
111         lint-test-expectations should be run during style checking
112         https://bugs.webkit.org/show_bug.cgi?id=173559
113         <rdar://problem/32854941>
114
115         Reviewed by David Kilzer.
116
117         Running the test expectation linter requires reading both files and lines not in the
118         patch because, for example, deletion of a test can cause a lint failure even though
119         no test expectations where modified. This means that the linter will occasionally warn
120         about lines which were not changed in a given patch but whose error is related to a
121         change made in that patch.
122
123         * Scripts/webkitpy/common/system/filesystem_mock.py:
124         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
125         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
126         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
127         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
128         content, description of the error and the name of the associated test.
129         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
130         (TestExpectationParser.__init__): Pass shorten_filename function to
131         TestExpectationsParser to add a deleted file to the related_files dictionary.
132         (TestExpectationParser._check_test_exists): If the test does not exist, add the
133         missing path to the related_files dictionary.
134         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
135         files and line numbers related to this test expectation line. This will allow
136         tracking linter errors in the style checker occurring across multiple files.
137         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
138         lines to related_files dictionary.
139         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
140         (TestExpectations._report_warnings): Construct warning object instead of string
141         when adding to warnings list.
142         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
143         clean-up log.
144         * Scripts/webkitpy/style/checker.py:
145         (ProcessorBase.do_association_check): Add required function for processor classes.
146         (StyleProcessor):
147         (StyleProcessor.do_association_check): Run the TestExpectations linter when
148         checking for errors between associated files.
149         * Scripts/webkitpy/style/checkers/test_expectations.py:
150         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
151         (TestExpectationsChecker):
152         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
153         of modified files, the current working directory and the host, determine if the linter
154         warning is associated with the changes.
155         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
156         style checker.
157         * Scripts/webkitpy/style/filereader.py:
158         (TextFileReader):
159         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
160         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
161         (TextFileReader.process_file): Track both the number of files changed and which lines
162         in those files were changed.
163         (TextFileReader.do_association_check): Run the processor's association check on all
164         modified or deleted files processed by TextFileReader.
165         (TextFileReader.delete_file): Track deleted files in _files dictionary.
166         (TextFileReader.count_delete_only_file): Deleted.
167         * Scripts/webkitpy/style/filereader_unittest.py:
168         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
169         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
170         * Scripts/webkitpy/style/main.py:
171         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
172         explicitly run the association check on the file reader.
173         * Scripts/webkitpy/style/main_unittest.py:
174         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
175         embedded in the style checker.
176         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
177         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
178         construct the TextFileReader object with a StyleProcessor used to run style checks on
179         specific files.
180         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
181         testing the test expectation linter inside the style checker. This host must contain a
182         mock file system with the basic structure of test expectations.
183         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
184         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
185         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
186         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
187         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
188         * Scripts/webkitpy/style/patchreader.py:
189         (PatchReader.check): Specify which file was deleted, run the association check.
190         * Scripts/webkitpy/style/patchreader_unittest.py:
191         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
192         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
193         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
194
195 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
196
197         [WTF] Implement WTF::ThreadGroup
198         https://bugs.webkit.org/show_bug.cgi?id=174081
199
200         Reviewed by Mark Lam.
201
202         Add WTF::ThreadGroup tests.
203
204         * TestWebKitAPI/CMakeLists.txt:
205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
206         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
207         (TestWebKitAPI::testThreadGroup):
208         (TestWebKitAPI::TEST):
209
210 2017-07-18  Andy Estes  <aestes@apple.com>
211
212         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
213         https://bugs.webkit.org/show_bug.cgi?id=174631
214
215         Reviewed by Tim Horton.
216
217         * DumpRenderTree/mac/Configurations/Base.xcconfig:
218         * MiniBrowser/Configurations/Base.xcconfig:
219         * MobileMiniBrowser/Configurations/Base.xcconfig:
220         * TestWebKitAPI/Configurations/Base.xcconfig:
221         * WebKitTestRunner/Configurations/Base.xcconfig:
222
223 2017-07-18  Andy Estes  <aestes@apple.com>
224
225         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
226         https://bugs.webkit.org/show_bug.cgi?id=174631
227
228         Reviewed by Sam Weinig.
229
230         * DumpRenderTree/mac/Configurations/Base.xcconfig:
231         * MiniBrowser/Configurations/Base.xcconfig:
232         * MobileMiniBrowser/Configurations/Base.xcconfig:
233         * TestWebKitAPI/Configurations/Base.xcconfig:
234         * WebKitTestRunner/Configurations/Base.xcconfig:
235
236 2017-07-18  Daniel Bates  <dabates@apple.com>
237
238         lldb: Add type summary for StringView
239         https://bugs.webkit.org/show_bug.cgi?id=174637
240
241         Reviewed by Sam Weinig.
242
243         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
244         StringView object will print output that has the form:
245
246             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
247               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
248               m_length = 2
249               m_is8Bit = true
250               m_underlyingString = 0x0000614000000a90
251             }
252
253         * lldb/lldb_webkit.py:
254         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
255         (WTFStringView_SummaryProvider):
256         (WTFStringViewProvider):
257         (WTFStringViewProvider.__init__):
258         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
259         (WTFStringViewProvider.get_length): Access field StringView.m_length.
260         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
261         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
262
263 2017-07-18  Andy Estes  <aestes@apple.com>
264
265         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
266         https://bugs.webkit.org/show_bug.cgi?id=174631
267
268         Reviewed by Dan Bernstein.
269
270         * DumpRenderTree/mac/Configurations/Base.xcconfig:
271         * MiniBrowser/Configurations/Base.xcconfig:
272         * MobileMiniBrowser/Configurations/Base.xcconfig:
273         * TestWebKitAPI/Configurations/Base.xcconfig:
274         * WebKitTestRunner/Configurations/Base.xcconfig:
275
276 2017-07-18  Devin Rousso  <drousso@apple.com>
277
278         Web Inspector: Add memoryCost to Inspector Protocol objects
279         https://bugs.webkit.org/show_bug.cgi?id=174478
280
281         Reviewed by Joseph Pecoraro.
282
283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
284         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
285         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
286         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
287         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
288         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
289         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
290         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
291         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
292         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
293         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
294         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
295         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
296         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
297         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
298         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
299         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
300
301 2017-07-18  Andy Estes  <aestes@apple.com>
302
303         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
304         https://bugs.webkit.org/show_bug.cgi?id=174631
305
306         Reviewed by Darin Adler.
307
308         * DumpRenderTree/mac/Configurations/Base.xcconfig:
309         * MiniBrowser/Configurations/Base.xcconfig:
310         * MobileMiniBrowser/Configurations/Base.xcconfig:
311         * TestWebKitAPI/Configurations/Base.xcconfig:
312         * WebKitTestRunner/Configurations/Base.xcconfig:
313
314 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
315
316         Unreviewed, fix the iOS build.
317
318         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
319
320         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
321         (TestWebKitAPI::TEST):
322
323 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
324
325         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
326         https://bugs.webkit.org/show_bug.cgi?id=174585
327         <rdar://problem/33302541>
328
329         Reviewed by Tim Horton.
330
331         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
332         being dragged when initiating a drag.
333
334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
335         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
336         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
337         (TestWebKitAPI::TEST):
338         * TestWebKitAPI/cocoa/TestWKWebView.h:
339
340         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
341
342         * TestWebKitAPI/cocoa/TestWKWebView.mm:
343         (-[TestWKWebView synchronouslyLoadHTMLString:]):
344
345 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
346
347         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
348         https://bugs.webkit.org/show_bug.cgi?id=174547
349
350         Reviewed by Alex Christensen.
351
352         * DumpRenderTree/PlatformWin.cmake:
353         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
354
355 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
356
357         Update style checker to deal with "final"
358         https://bugs.webkit.org/show_bug.cgi?id=174528
359
360         Reviewed by Alex Christensen.
361         
362         check-webkit-style shouldn't complain about an open brace to start a
363         line after a function definition with "final" or "const final".
364
365         * Scripts/webkitpy/style/checkers/cpp.py:
366         (check_braces):
367         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
368         (CppStyleTest.test_brace_at_begin_of_line):
369
370 2017-07-17  Alex Christensen  <achristensen@webkit.org>
371
372         Modernize content extension code
373         https://bugs.webkit.org/show_bug.cgi?id=174588
374
375         Reviewed by Sam Weinig.
376
377         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
378         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
379         (TestWebKitAPI::testRequest):
380         (TestWebKitAPI::makeBackend):
381         (TestWebKitAPI::TEST_F):
382
383 2017-07-17  Brady Eidson  <beidson@apple.com>
384
385         WKHTTPCookieStore observing only works on the default cookie store.
386         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
387
388         Reviewed by Sam Weinig.
389
390         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
391         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
392           called for the default store, a non-persistent store, and a custom store.
393         (TEST):
394
395 2017-07-16  Sam Weinig  <sam@webkit.org>
396
397         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
398         https://bugs.webkit.org/show_bug.cgi?id=174575
399
400         Reviewed by Brady Eidson.
401
402         * Scripts/svn-create-patch:
403         (findModificationType):
404         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
405         default value of "unknown".
406
407         (generateFileList):
408         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
409         for untracked, which matches our old behavior.
410
411 2017-07-17  Charlie Turner  <cturner@igalia.com>
412
413         Add some missing build dependencies on Fedora
414         https://bugs.webkit.org/show_bug.cgi?id=174578
415
416         Unreviewed dependency update.
417
418         * gtk/install-dependencies:
419
420 2017-07-16  Brady Eidson  <beidson@apple.com>
421
422         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
423         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
424
425         Reviewed by Tim Horton.
426
427         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
428         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
429         (TEST):
430
431 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
432
433         [GTK] Sort inspector GResource manifest to ensure reproducible builds
434         https://bugs.webkit.org/show_bug.cgi?id=174540
435
436         Reviewed by Michael Catanzaro.
437
438         * gtk/generate-inspector-gresource-manifest.py:
439         (get_filenames): sort list of input files
440
441 2017-07-15  Brady Eidson  <beidson@apple.com>
442
443         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
444         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
445
446         Reviewed by Tim Horton.
447
448         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
449         (TEST): Make this test more reliable by clearing everything beforehand.
450
451 2017-07-15  David Kilzer  <ddkilzer@apple.com>
452
453         Make it possible to extend check-webkit-style with Apple-internal checkers
454         <https://webkit.org/b/174464>
455         <rdar://problem/25564402>
456
457         Reviewed by Darin Adler.
458
459         * Scripts/webkitpy/style/checker.py: Import apple_additions.
460         (_all_categories): Add categories from apple_additions() if it
461         exists.
462         (CheckerDispatcher._create_checker): Create python checker
463         from apple_additions() if it exists.
464
465 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
466
467         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
468         https://bugs.webkit.org/show_bug.cgi?id=174539
469         <rdar://problem/33307395>
470
471         Reviewed by Darin Adler.
472
473         Adds a new unit test suite to cover action sheet popover presentation.
474
475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
476         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
477         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
478         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
479
480         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
481
482         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
483         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
484
485         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
486
487         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
488         (TestWebKitAPI::TEST):
489
490 2017-07-15  Sam Weinig  <sam@webkit.org>
491
492         [Scripts] Make svn-create-patch work better when called in sub directories
493         https://bugs.webkit.org/show_bug.cgi?id=174551
494
495         Reviewed by Darin Adler.
496
497         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
498           by ensuring that the prefix is applied as is done in generateDiff.
499         - Silence output of explanatory lines from svn stat (" > move to ...")
500           that show up in STDERR when running svn-create-patch.
501         - Add verbose logging that I found useful while debugging this issue.
502
503         * Scripts/svn-create-patch:
504         (findBaseUrl):
505         (findMimeType):
506         (findSourceFileAndRevision):
507         (generateDiff):
508         (generateFileList):
509         (manufacturePatchForAdditionWithHistory):
510
511 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
512
513         Unreviewed build fix after r219537.
514
515         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
516
517 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
518
519         Add iOS 11 SPI
520         https://bugs.webkit.org/show_bug.cgi?id=174430
521         <rdar://problem/33269288>
522
523         Reviewed by Tim Horton.
524
525         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
526         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
527         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
528
529 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
530
531         Failing to install on iPad simulators
532         https://bugs.webkit.org/show_bug.cgi?id=174532
533         <rdar://problem/33328347>
534
535         Reviewed by Stephanie Lewis.
536
537         * Scripts/webkitpy/xcode/simulated_device.py:
538         (SimulatedDevice.install_app): Place install command in retry try-except block.
539
540 2017-07-14  Jeff Miller  <jeffm@apple.com>
541
542         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
543         https://bugs.webkit.org/show_bug.cgi?id=174524
544
545         Reviewed by Sam Weinig.
546
547         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
548         (TEST):
549         Renamed TestParameter to TestParameter1.
550         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
551
552         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
553         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
554         Observe changes for two bundle parameters.
555
556         (-[BundleParametersPlugIn dealloc]):
557         Remove observers for two bundle parameters.
558
559 2017-07-14  Commit Queue  <commit-queue@webkit.org>
560
561         Unreviewed, rolling out r219510.
562         https://bugs.webkit.org/show_bug.cgi?id=174525
563
564         Need to revert length() == 0 check for null string (Requested
565         by yusukesuzuki on #webkit).
566
567         Reverted changeset:
568
569         "[WTF] Newly added AtomicStringImpl should use BufferInternal
570         static string if StringImpl is static"
571         https://bugs.webkit.org/show_bug.cgi?id=174501
572         http://trac.webkit.org/changeset/219510
573
574 2017-07-14  Jer Noble  <jer.noble@apple.com>
575
576         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
577         https://bugs.webkit.org/show_bug.cgi?id=174514
578
579         Reviewed by Sam Weinig.
580
581         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
582         (TestWebKitAPI::TEST_F):
583
584 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
585
586         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
587         https://bugs.webkit.org/show_bug.cgi?id=174501
588
589         Reviewed by Darin Adler.
590
591         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
592         (TestWebKitAPI::TEST):
593
594 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
595
596         Bring mac expectations in-line with other platforms
597         https://bugs.webkit.org/show_bug.cgi?id=174472
598         <rdar://problem/33297388>
599
600         Reviewed by David Kilzer.
601
602         The override order for Mac test expectations does not conform to the pattern used by iOS,
603         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
604
605             platform/mac-wk2
606             platform/wk2
607             platform/mac-elcapitan
608             platform/mac-sierra
609             generic
610
611         After this change, El Capitan's baseline search path looks like this:
612
613             platform/mac-sierra-wk2
614             platform/mac-sierra
615             platform/mac-wk2
616             platform/wk2
617             generic
618
619         * Scripts/webkitpy/port/mac.py:
620         (MacPort.__init__): If a specific version is specified in the port name, use that
621         as the os version.
622         (MacPort.default_baseline_search_path): Expectation search paths should work the
623         same way they do on other ports. Port + version overrides port, port overrides generic
624         and wk1/wk2 should override expectations for the two combined.
625         * Scripts/webkitpy/port/mac_unittest.py:
626         (MacTest.test_tests_for_other_platforms): Deleted.
627         (MacTest._assert_search_path): Deleted.
628         (MacTest.test_baseline_search_path): Deleted.
629         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
630         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
631         (test_rebaseline_test_and_print_scm_changes): Ditto.
632         (test_rebaseline_and_copy_test): Ditto.
633         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
634         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
635         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
636
637 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
638
639         Fix style checker unit test
640
641         Unreviewed WebKit2 => WebKit fixup.
642
643         * Scripts/webkitpy/style/checker_unittest.py:
644         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
645
646 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
647
648         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
649
650         Unreviewed build fix.
651
652         r219492 missed one hunk from its partial revert of r219489.
653         This patch reverts that hunk.
654
655         * TestWebKitAPI/CMakeLists.txt:
656
657 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
658
659         Use the old WebKit/WebKit2 targets for CMake builds.
660
661         Unreviewed build fix.
662
663         We can update the target names to match the Framework names in a future patch.
664         This is a partial revert of r219489.
665
666         * TestWebKitAPI/CMakeLists.txt:
667         WebKitLegacy => WebKit
668         WebKit => WebKit2
669
670 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
671
672         Fix TestWebKit API.
673         https://bugs.webkit.org/show_bug.cgi?id=174164
674         rdar://problem/33137595
675
676         Reviewed by Dan Bernstein.
677
678         * TestWebKitAPI/CMakeLists.txt:
679         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
680         * TestWebKitAPI/PlatformGTK.cmake:
681
682 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
683
684         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
685         https://bugs.webkit.org/show_bug.cgi?id=174164
686         rdar://problem/33137595
687
688         Reviewed by Dan Bernstein.
689
690         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
691         (ShouldBuildTest):
692         * DumpRenderTree/mac/Configurations/Base.xcconfig:
693         * Scripts/build-webkit:
694         * Scripts/do-file-rename:
695         * Scripts/do-webcore-rename:
696         * Scripts/update-webkit-localizable-strings:
697         * Scripts/webkitpy/common/config/watchlist:
698         * Scripts/webkitpy/style/checker.py:
699         * Scripts/webkitpy/style/checkers/featuredefines.py:
700         * gtk/make-dist.py:
701         (ensure_version_if_possible):
702         * gtk/manifest.txt.in:
703
704 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
705
706         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
707         https://bugs.webkit.org/show_bug.cgi?id=174162
708         rdar://problem/33137594
709
710         Reviewed by Dan Bernstein.
711
712         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
713
714         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
715         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
716         * EWSTools/configure-clang-linux.sh:
717         * Scripts/build-webkit:
718         * Scripts/do-file-rename:
719         * Scripts/do-webcore-rename:
720         * Scripts/update-webkit-localizable-strings:
721         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
722         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
723         * Scripts/webkitpy/style/checkers/featuredefines.py:
724         * gtk/manifest.txt.in:
725
726 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
727
728         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
729         https://bugs.webkit.org/show_bug.cgi?id=174438
730         <rdar://problem/33277112>
731
732         Reviewed by Aakash Jain.
733
734         Given a patch, this will convert the changes from the path to the new directory structure.
735
736         * Scripts/rebase-patch-after-webkit-move: Added.
737         (append_source): Append 'Source' to the provided path.
738         (is_editable_line): Return true if a line the script expects to modify.
739         (needs_rebase): Return if a line needs to be rebased based on it's content.
740         (rebase_line): Rebase the provided line.
741         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
742         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
743         were provided.
744
745 2017-07-12  Nan Wang  <n_wang@apple.com>
746
747         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
748         https://bugs.webkit.org/show_bug.cgi?id=174393
749         <rdar://problem/33248006>
750
751         Reviewed by Chris Fleizach.
752
753         * DumpRenderTree/AccessibilityUIElement.cpp:
754         (textMarkerRangeMatchesTextNearMarkersCallback):
755         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
756         (AccessibilityUIElement::getJSClass):
757         * DumpRenderTree/AccessibilityUIElement.h:
758         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
759         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
760         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
761         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
762         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
763         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
764         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
765         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
766
767 2017-07-12  Matt Lewis  <jlewis3@apple.com>
768
769         Unreviewed, rolling out r219409.
770
771         The revision caused the Windows builds to fail.
772
773         Reverted changeset:
774
775         "AX: [iOS] Implement a way to retrieve a text marker range
776         with desired text that is closest to a position"
777         https://bugs.webkit.org/show_bug.cgi?id=174393
778         http://trac.webkit.org/changeset/219409
779
780 2017-07-12  Nan Wang  <n_wang@apple.com>
781
782         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
783         https://bugs.webkit.org/show_bug.cgi?id=174393
784         <rdar://problem/33248006>
785
786         Reviewed by Chris Fleizach.
787
788         * DumpRenderTree/AccessibilityUIElement.cpp:
789         (textMarkerRangeMatchesTextNearMarkersCallback):
790         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
791         (AccessibilityUIElement::getJSClass):
792         * DumpRenderTree/AccessibilityUIElement.h:
793         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
794         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
795         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
796         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
797         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
798         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
799         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
800         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
801
802 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
803
804         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
805         https://bugs.webkit.org/show_bug.cgi?id=174197
806
807         Reviewed by Darin Adler.
808
809         This bit me the first time I tried to submit a patch to WebKit, and still I have
810         to manually edit the ChangeLog every time I use the script.
811
812         This generates a more convenient and standard ChangeLog entry.
813
814         * Scripts/prepare-ChangeLog:
815         (generateNewChangeLogs):
816
817 2017-07-12  Matt Lewis  <jlewis3@apple.com>
818
819         Unreviewed, rolling out r219401.
820
821         This revision rolled out the previous patch, but after talking
822         with reviewer, a rebaseline is what was needed.Rolling back in
823         before rebaseline.
824
825         Reverted changeset:
826
827         "Unreviewed, rolling out r219379."
828         https://bugs.webkit.org/show_bug.cgi?id=174400
829         http://trac.webkit.org/changeset/219401
830
831 2017-07-12  Matt Lewis  <jlewis3@apple.com>
832
833         Unreviewed, rolling out r219379.
834
835         This revision caused a consistent failure in the test
836         fast/dom/Window/property-access-on-cached-window-after-frame-
837         removed.html.
838
839         Reverted changeset:
840
841         "Remove NAVIGATOR_HWCONCURRENCY"
842         https://bugs.webkit.org/show_bug.cgi?id=174400
843         http://trac.webkit.org/changeset/219379
844
845 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
846
847         [WPE] Use libepoxy
848         https://bugs.webkit.org/show_bug.cgi?id=172104
849
850         Reviewed by Michael Catanzaro.
851
852         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
853         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
854
855 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
856
857         [GTK][WPE] Align Jhbuild patches for GStreamer packages
858         https://bugs.webkit.org/show_bug.cgi?id=174363
859
860         Reviewed by Michael Catanzaro.
861
862         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
863         between the GTK+ and WPE port. There's no reason for the two ports to apply
864         different patches over same versions of GStreamer releases.
865
866         This aligns the two ports on this specific issue. Next we'll look into
867         creating a single GStreamer-specific Jhbuild moduleset that will allow us
868         to keep these patches in a single place, avoiding duplicate files.
869
870         * gtk/jhbuild.modules:
871         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
872         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
873         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
874         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
875
876 2017-07-11  Dean Jackson  <dino@apple.com>
877
878         Remove NAVIGATOR_HWCONCURRENCY
879         https://bugs.webkit.org/show_bug.cgi?id=174400
880
881         Reviewed by Sam Weinig.
882
883         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
884
885 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
886
887         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
888         https://bugs.webkit.org/show_bug.cgi?id=174239
889
890         Reviewed by Brady Eidson.
891
892         Create windows with specific features set and make sure those are properly reflected in the
893         WKWindowFeatures object.
894
895         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
896         (resetToConsistentState):
897         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
898         (TEST):
899
900 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
901
902         Do not duplicate files when deleting directories with svn 1.9
903         https://bugs.webkit.org/show_bug.cgi?id=174339
904         <rdar://problem/33226781>
905
906         Reviewed by David Kilzer.
907
908         * Scripts/svn-create-patch:
909         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
910         (generateFileList): Determine which files are deleted because they are part of a
911         directory being deleted.
912
913 2017-07-11  Dean Jackson  <dino@apple.com>
914
915         Rolling out r219372.
916
917         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
918
919 2017-07-11  Dean Jackson  <dino@apple.com>
920
921         Remove NAVIGATOR_HWCONCURRENCY
922         https://bugs.webkit.org/show_bug.cgi?id=174400
923
924         Reviewed by Sam Weinig.
925
926         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
927
928 2017-07-11  Lucas Forschler  <lforschler@apple.com>
929
930         Teach build workers to fetch archives from S3.
931         https://bugs.webkit.org/show_bug.cgi?id=174384
932
933         Reviewed by Aakash Jain.
934
935         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
936         (DownloadBuiltProduct):
937
938 2017-07-11  Lucas Forschler  <lforschler@apple.com>
939
940         Configure buildbot to transfer all archives to S3.
941         Previously this was Mac only, but it's time to expand!
942         https://bugs.webkit.org/show_bug.cgi?id=174378
943         
944         Reviewed by Aakash Jain.
945
946         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
947         (BuildFactory.__init__):
948
949 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
950
951         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
952         https://bugs.webkit.org/show_bug.cgi?id=174350
953
954         Reviewed by Xabier Rodriguez-Calvar.
955
956         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
957         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
958         patches are removed. The patches for gst-plugins-good are updated, removing
959         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
960         rtpbin elements that will help with the EMEv3 development.
961
962         * wpe/jhbuild.modules:
963         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
964         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
965         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
966         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
967         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
968         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
969         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
970         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
971         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
972
973 2017-07-10  John Wilander  <wilander@apple.com>
974
975         Resource Load Statistics: Prune statistics in orders of importance
976         https://bugs.webkit.org/show_bug.cgi?id=174215
977         <rdar://problem/33164403>
978
979         Reviewed by Chris Dumez.
980
981         Nest infrastructure. Adds these functions:
982         1. testRunner.setStatisticsLastSeen()
983         2. setStatisticsMaxStatisticsEntries()
984         3. setStatisticsPruneEntriesDownTo()
985
986         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
987         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
988         (WTR::TestRunner::setStatisticsLastSeen):
989         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
990         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
991         * WebKitTestRunner/InjectedBundle/TestRunner.h:
992         * WebKitTestRunner/TestController.cpp:
993         (WTR::TestController::setStatisticsLastSeen):
994         (WTR::TestController::setMaxStatisticsEntries):
995         (WTR::TestController::setPruneEntriesDownTo):
996         * WebKitTestRunner/TestController.h:
997         * WebKitTestRunner/TestInvocation.cpp:
998         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
999         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1000         (WTR::TestController::setStatisticsLastSeen):
1001         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1002         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1003
1004 2017-07-03  Brian Burg  <bburg@apple.com>
1005
1006         Web Replay: remove some unused code
1007         https://bugs.webkit.org/show_bug.cgi?id=173903
1008
1009         Rubber-stamped by Joseph Pecoraro.
1010
1011         * Scripts/run-input-generator-tests: Removed.
1012         * Scripts/webkitpy/replay/__init__.py: Removed.
1013         * Scripts/webkitpy/replay/main.py: Removed.
1014
1015 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1016
1017         [WPE] Fix layout test baseline and TestExpectations hierarchy
1018         https://bugs.webkit.org/show_bug.cgi?id=174092
1019
1020         Reviewed by Michael Catanzaro.
1021
1022         Like for the GTK+ port, override the default_baseline_search_path() and
1023         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1024         Both methods operate on a short list of search paths that defaults to 'wpe' and
1025         'wk2', along with any other user-specified platform directory.
1026
1027         The test_expectations_file_position() method is overridden for testing purposes,
1028         and relevant unit tests are added.
1029
1030         * Scripts/webkitpy/port/wpe.py:
1031         (WPEPort._search_paths):
1032         (WPEPort):
1033         (WPEPort.default_baseline_search_path):
1034         (WPEPort._port_specific_expectations_files):
1035         (WPEPort.test_expectations_file_position):
1036         * Scripts/webkitpy/port/wpe_unittest.py:
1037         (WPEPortTest.test_default_baseline_search_path):
1038         (WPEPortTest):
1039         (WPEPortTest.test_port_specific_expectations_files):
1040
1041 2017-07-10  Chris Dumez  <cdumez@apple.com>
1042
1043         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1044         https://bugs.webkit.org/show_bug.cgi?id=174301
1045
1046         Reviewed by Brent Fulgham.
1047
1048         Rename some of the testRunner API for clarity and to better match what it calls
1049         internally.
1050
1051         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1052         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1053         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1054         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1055         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1056         * WebKitTestRunner/TestController.cpp:
1057         (WTR::TestController::statisticsUpdateCookiePartitioning):
1058         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1059         * WebKitTestRunner/TestController.h:
1060         * WebKitTestRunner/TestInvocation.cpp:
1061         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1062         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1063         (WTR::TestController::statisticsUpdateCookiePartitioning):
1064         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1065
1066 2017-07-10  Charlie Turner  <cturner@igalia.com>
1067
1068         [GStreamer] Live twitch.tv videos do not play
1069         https://bugs.webkit.org/show_bug.cgi?id=174222
1070
1071         Reviewed by Michael Catanzaro.
1072
1073         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1074         fixes videos not playing on twitch.tv.
1075
1076         * gtk/jhbuild.modules:
1077
1078 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1079
1080         Add WebGL2 configuration option to build-webkit
1081         https://bugs.webkit.org/show_bug.cgi?id=174251
1082
1083         Reviewed by Michael Catanzaro.
1084
1085         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1086         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1087         is marked as enabled for the Apple Cocoa ports.
1088
1089 2017-07-08  Chris Dumez  <cdumez@apple.com>
1090
1091         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1092         https://bugs.webkit.org/show_bug.cgi?id=174290
1093
1094         Reviewed by Brent Fulgham.
1095
1096         Rename testRunner API to match the new internal API names.
1097
1098         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1099         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1100         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1101         (WTR::TestRunner::statisticsSubmitTelemetry):
1102         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1103         * WebKitTestRunner/TestController.cpp:
1104         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1105         (WTR::TestController::statisticsSubmitTelemetry):
1106         * WebKitTestRunner/TestController.h:
1107         * WebKitTestRunner/TestInvocation.cpp:
1108         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1109         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1110         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1111         (WTR::TestController::statisticsSubmitTelemetry):
1112
1113 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1114
1115         Drop NOSNIFF compile flag
1116         https://bugs.webkit.org/show_bug.cgi?id=174289
1117
1118         Reviewed by Michael Catanzaro.
1119
1120         * Scripts/webkitperl/FeatureList.pm:
1121         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1122
1123 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1124
1125         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1126         https://bugs.webkit.org/show_bug.cgi?id=174219
1127         <rdar://problem/32083177>
1128
1129         Reviewed by Ryosuke Niwa.
1130
1131         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1132         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1133         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1134         place.
1135
1136         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1137         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1138         no action is taken when dropping.
1139
1140         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1141         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1142         (TestWebKitAPI::TEST):
1143         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1144         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1145         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1146         (-[MockDragDropSession allowsMoveOperation]):
1147         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1148         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1149         (-[DataInteractionSimulator initWithWebView:]):
1150         (-[DataInteractionSimulator runFrom:to:]):
1151         (-[DataInteractionSimulator _advanceProgress]):
1152         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1153         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1154         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1155
1156 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1157
1158         Unreviewed, rolling out r219238, r219239, and r219241.
1159         https://bugs.webkit.org/show_bug.cgi?id=174265
1160
1161         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1162         (Requested by yusukesuzuki on #webkit).
1163
1164         Reverted changesets:
1165
1166         "[WTF] Implement WTF::ThreadGroup"
1167         https://bugs.webkit.org/show_bug.cgi?id=174081
1168         http://trac.webkit.org/changeset/219238
1169
1170         "Unreviewed, build fix after r219238"
1171         https://bugs.webkit.org/show_bug.cgi?id=174081
1172         http://trac.webkit.org/changeset/219239
1173
1174         "Unreviewed, CLoop build fix after r219238"
1175         https://bugs.webkit.org/show_bug.cgi?id=174081
1176         http://trac.webkit.org/changeset/219241
1177
1178 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1179
1180         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1181         https://bugs.webkit.org/show_bug.cgi?id=174250
1182
1183         Reviewed by Carlos Alberto Lopez Perez.
1184
1185         * Scripts/webkitperl/FeatureList.pm:
1186
1187 2017-07-07  Charlie Turner  <cturner@igalia.com>
1188         [GStreamer] vid.me videos do not play
1189         https://bugs.webkit.org/show_bug.cgi?id=172240
1190
1191         Reviewed by Xabier Rodriguez-Calvar.
1192
1193         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1194         have the existing libsoup build against GNOME to avoid header drift
1195         against GStreamer's linked Soup library.
1196
1197         * gtk/jhbuild.modules:
1198
1199 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1200
1201         Write a support script to enable buildbot to upload to S3
1202         https://bugs.webkit.org/show_bug.cgi?id=174196
1203         
1204         Reviewed by Stephanie Lewis.
1205
1206         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1207         (uploadToS3):
1208         (archiveExists):
1209
1210 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1211
1212         Enabling uploading archives to S3.
1213         https://bugs.webkit.org/show_bug.cgi?id=174198
1214         
1215         Reviewed by Stephanie Lewis.
1216
1217         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1218         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1219         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1220         (TransferToS3): Transfer full and minified archives to S3
1221
1222 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1223
1224         [WTF] Implement WTF::ThreadGroup
1225         https://bugs.webkit.org/show_bug.cgi?id=174081
1226
1227         Reviewed by Mark Lam.
1228
1229         Add WTF::ThreadGroup tests.
1230
1231         * TestWebKitAPI/CMakeLists.txt:
1232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1233         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1234         (TestWebKitAPI::TEST):
1235
1236 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1237
1238         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1239         https://bugs.webkit.org/show_bug.cgi?id=174150
1240
1241         Reviewed by Mark Lam.
1242
1243         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1244         (TestWebKitAPI::TEST):
1245         * TestWebKitAPI/TestsController.cpp:
1246         (TestWebKitAPI::TestsController::TestsController):
1247
1248 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1249
1250         Enabling uploading archives to S3.
1251         https://bugs.webkit.org/show_bug.cgi?id=174198
1252         
1253         Reviewed by Lucas Forschler.
1254
1255         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1256         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1257         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1258         (TransferToS3): Transfer full and minified archives to S3
1259
1260 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1261
1262         [GTK][WPE] kill-old-process should kill more webkit related process
1263         https://bugs.webkit.org/show_bug.cgi?id=174220
1264
1265         Reviewed by Michael Catanzaro.
1266
1267         Generate list of possible webkit-related process names and add
1268         them to the list of process to kill.
1269         Also update the possible system related process for GTK+/WPE.
1270
1271         * BuildSlaveSupport/kill-old-processes:
1272         (listAllWebKitPrograms):
1273         (main):
1274
1275 2017-07-06  Chris Dumez  <cdumez@apple.com>
1276
1277         FileMonitor should not be ref counted
1278         https://bugs.webkit.org/show_bug.cgi?id=174166
1279
1280         Reviewed by Brent Fulgham.
1281
1282         Update the API tests to reflect the API change.
1283
1284         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1285         (TestWebKitAPI::TEST_F):
1286
1287 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1288
1289         Unreviewed, rolling out r219194.
1290         https://bugs.webkit.org/show_bug.cgi?id=174207
1291
1292         it broke some layout tests (Requested by clopez on #webkit).
1293
1294         Reverted changeset:
1295
1296         "[GStreamer] vid.me videos do not play"
1297         https://bugs.webkit.org/show_bug.cgi?id=172240
1298         http://trac.webkit.org/changeset/219194
1299
1300 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1301
1302         Unreviewed, rolling out r219178.
1303
1304         This caused a consistent failure with the API test
1305         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1306
1307         Reverted changeset:
1308
1309         "[WTF] Clean up StringStatics.cpp by using
1310         LazyNeverDestroyed<> for Atoms"
1311         https://bugs.webkit.org/show_bug.cgi?id=174150
1312         http://trac.webkit.org/changeset/219178
1313
1314 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1315
1316         Add CWD to Perl library path (no longer the default since 5.26.0)
1317         https://bugs.webkit.org/show_bug.cgi?id=174200
1318
1319         Reviewed by Michael Catanzaro.
1320
1321         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1322         (SetupGitClone._get_username_and_email):
1323
1324 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1325
1326         Unreviewed, update my email address.
1327
1328         * Scripts/webkitpy/common/config/contributors.json:
1329
1330 2017-07-06  Charlie Turner  <cturner@igalia.com>
1331         [GStreamer] vid.me videos do not play
1332         https://bugs.webkit.org/show_bug.cgi?id=172240
1333
1334         Reviewed by Xabier Rodriguez-Calvar.
1335
1336         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1337         have the existing libsoup build against GNOME to avoid header drift
1338         against GStreamer's linked Soup library.
1339
1340         * gtk/jhbuild.modules:
1341
1342 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1343
1344         [WTF] Move SoftLinking.h into WTF
1345         https://bugs.webkit.org/show_bug.cgi?id=174000
1346
1347         Reviewed by Alex Christensen.
1348
1349         * DumpRenderTree/mac/TestRunnerMac.mm:
1350         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1351         (test_primary_header):
1352         (ErrorCollector.__init__): Deleted.
1353         (ErrorCollector.__call__): Deleted.
1354         (ErrorCollector.results): Deleted.
1355         (ErrorCollector.result_list): Deleted.
1356         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1357         (MockIo.open): Deleted.
1358         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1359         (CppFunctionsTest.test_create_acronym): Deleted.
1360         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1361         (CppFunctionsTest.test_parameter): Deleted.
1362         (CppFunctionsTest.test_single_line_view): Deleted.
1363         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1364         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1365         (CppFunctionsTest.test_parameter_list): Deleted.
1366         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1367         (CppStyleTestBase.process_file_data): Deleted.
1368         (CppStyleTestBase.perform_lint): Deleted.
1369         (CppStyleTestBase.perform_single_line_lint): Deleted.
1370         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1371         (CppStyleTestBase.perform_language_rules_check): Deleted.
1372         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1373         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1374         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1375         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1376         (CppStyleTestBase.perform_header_guard_check): Deleted.
1377         (CppStyleTestBase.assert_lint): Deleted.
1378         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1379         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1380         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1381         (CppStyleTestBase.assert_language_rules_check): Deleted.
1382         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1383         (CppStyleTestBase.assert_header_guard): Deleted.
1384         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1385         (CppStyleTestBase.assert_positions_equal): Deleted.
1386         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1387         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1388         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1389         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1390         (FunctionDetectionTest.test_ignore_macros): Deleted.
1391         (FunctionDetectionTest.test_non_functions): Deleted.
1392         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1393         (FunctionDetectionTest.test_parameter_list): Deleted.
1394         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1395         (CppStyleTest.test_asm_lines_ignored): Deleted.
1396         (CppStyleTest.test_get_line_width): Deleted.
1397         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1398         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1399         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1400         (CppStyleTest.test_position): Deleted.
1401         (CppStyleTest.test_rfind_in_lines): Deleted.
1402         (CppStyleTest.test_close_expression): Deleted.
1403         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1404         (CppStyleTest.test_cstyle_cast): Deleted.
1405         (CppStyleTest.test_runtime_casting): Deleted.
1406         (CppStyleTest.test_runtime_selfinit): Deleted.
1407         (CppStyleTest.test_runtime_rtti): Deleted.
1408         (CppStyleTest.test_static_cast_readability): Deleted.
1409         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1410         (CppStyleTest.void): Deleted.
1411         (CppStyleTest.test_deprecated_cast): Deleted.
1412         (CppStyleTest.test_mock_method): Deleted.
1413         (CppStyleTest.test_sizeof_type): Deleted.
1414         (CppStyleTest.cases): Deleted.
1415         (CppStyleTest.for): Deleted.
1416         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1417         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1418         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1419         (CppStyleTest.test_include_what_you_use): Deleted.
1420         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1421         (CppStyleTest.test_cleanse_line): Deleted.
1422         (CppStyleTest.test_multi_line_comments): Deleted.
1423         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1424         (CppStyleTest.test_multiline_strings): Deleted.
1425         (CppStyleTest.test_platformh_comments): Deleted.
1426         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1427         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1428         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1429         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1430         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1431         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1432         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1433         (CppStyleTest.test_check_posix_threading): Deleted.
1434         (CppStyleTest.test_insecure_string_operations): Deleted.
1435         (CppStyleTest.test_format_strings): Deleted.
1436         (CppStyleTest.test_insecure_temp_file): Deleted.
1437         (CppStyleTest.test_variable_length_array_detection): Deleted.
1438         (CppStyleTest.test_braces): Deleted.
1439         (CppStyleTest.test_check_check): Deleted.
1440         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1441         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1442         (CppStyleTest.test_spacing_for_fncall): Deleted.
1443         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1444         (CppStyleTest.test_spacing_before_braces): Deleted.
1445         (CppStyleTest.test_spacing_between_braces): Deleted.
1446         (CppStyleTest.test_spacing_before_brackets): Deleted.
1447         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1448         (CppStyleTest.test_objective_c_block): Deleted.
1449         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1450         (CppStyleTest.test_spacing_around_else): Deleted.
1451         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1452         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1453         (CppStyleTest.test_operator_methods): Deleted.
1454         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1455         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1456         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1457         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1458         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1459         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1460         (CppStyleTest.test_space_after_comment_marker): Deleted.
1461         (CppStyleTest.test_newline_at_eof): Deleted.
1462         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1463         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1464         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1465         (CppStyleTest.test_invalid_utf8): Deleted.
1466         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1467         (CppStyleTest.test_is_blank_line): Deleted.
1468         (CppStyleTest.test_blank_lines_check): Deleted.
1469         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1470         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1471         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1472         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1473         (CppStyleTest.test_comma): Deleted.
1474         (CppStyleTest.test_declaration): Deleted.
1475         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1476         (CppStyleTest.test_indent): Deleted.
1477         (CppStyleTest.test_indent.Foo): Deleted.
1478         (CppStyleTest.test_not_alabel): Deleted.
1479         (CppStyleTest.test_tab): Deleted.
1480         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1481         (CppStyleTest.test_build_class): Deleted.
1482         (CppStyleTest.test_build_class.definitions): Deleted.
1483         (CppStyleTest.test_build_class.Foo): Deleted.
1484         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1485         (CppStyleTest.test_build_end_comment): Deleted.
1486         (CppStyleTest.test_build_forward_decl): Deleted.
1487         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1488         (CppStyleTest.test_build_header_guard): Deleted.
1489         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1490         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1491         (CppStyleTest.test_build_printf_format): Deleted.
1492         (CppStyleTest.test_runtime_printf_format): Deleted.
1493         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1494         (CppStyleTest.test_build_storage_class): Deleted.
1495         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1496         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1497         (CppStyleTest.test_build_storage_class.after): Deleted.
1498         (CppStyleTest.test_build_storage_class.is): Deleted.
1499         (CppStyleTest.test_legal_copyright): Deleted.
1500         (CppStyleTest.test_invalid_increment): Deleted.
1501         (CppStyleTest.test_enum_bitfields): Deleted.
1502         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1503         (CleansedLinesTest.test_init_empty): Deleted.
1504         (CleansedLinesTest.test_collapse_strings): Deleted.
1505         (OrderOfIncludesTest.tearDown): Deleted.
1506         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1507         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1508         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1509         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1510         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1511         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1512         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1513         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1514         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1515         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1516         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1517         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1518         (OrderOfIncludesTest.test_primary_header): Deleted.
1519         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1520         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1521         (OrderOfIncludesTest.test_classify_include): Deleted.
1522         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1523         (CheckForFunctionLengthsTest.tearDown): Deleted.
1524         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1525         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1526         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1527         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1528         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1529         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1530         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1531         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1532         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1533         (CheckForFunctionLengthsTest.function_body): Deleted.
1534         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1535         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1536         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
1537         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
1538         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
1539         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
1540         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
1541         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
1542         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
1543         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
1544         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
1545         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
1546         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
1547         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
1548         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
1549         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
1550         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
1551         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
1552         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
1553         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
1554         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
1555         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
1556         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
1557         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
1558         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
1559         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
1560         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
1561         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
1562         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
1563         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
1564         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
1565         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
1566         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
1567         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
1568         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
1569         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
1570         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
1571         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
1572         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
1573         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
1574         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
1575         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
1576         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
1577         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
1578         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
1579         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
1580         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
1581         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
1582         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
1583         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
1584         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
1585         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
1586         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
1587         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
1588         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
1589         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
1590         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
1591         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
1592         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
1593         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
1594         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
1595         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
1596         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
1597         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
1598         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
1599         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
1600         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
1601         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
1602         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
1603         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
1604         (LeakyPatternTest.test_get_dc): Deleted.
1605         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
1606         (LeakyPatternTest.test_own_get_dc): Deleted.
1607         (LeakyPatternTest.test_create_dc): Deleted.
1608         (LeakyPatternTest.test_create_compatible_dc): Deleted.
1609         (WebKitStyleTest.test_indentation): Deleted.
1610         (WebKitStyleTest.test_indentation.Foo): Deleted.
1611         (WebKitStyleTest.test_indentation.Document): Deleted.
1612         (WebKitStyleTest.test_spacing): Deleted.
1613         (WebKitStyleTest.test_line_breaking): Deleted.
1614         (WebKitStyleTest.test_braces): Deleted.
1615         (WebKitStyleTest.test_braces.MyClass): Deleted.
1616         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
1617         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
1618         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
1619         (WebKitStyleTest.test_null_false_zero): Deleted.
1620         (WebKitStyleTest.test_directive_indentation): Deleted.
1621         (WebKitStyleTest.test_using_std): Deleted.
1622         (WebKitStyleTest.test_using_namespace): Deleted.
1623         (WebKitStyleTest.test_max_macro): Deleted.
1624         (WebKitStyleTest.test_min_macro): Deleted.
1625         (WebKitStyleTest.test_wtf_move): Deleted.
1626         (WebKitStyleTest.test_ctype_fucntion): Deleted.
1627         (WebKitStyleTest.test_names): Deleted.
1628         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
1629         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
1630         (WebKitStyleTest.test_names.declarations): Deleted.
1631         (WebKitStyleTest.test_names.struct): Deleted.
1632         (WebKitStyleTest.test_names.VectorType): Deleted.
1633         (WebKitStyleTest.test_parameter_names): Deleted.
1634         (WebKitStyleTest.test_comments): Deleted.
1635         (WebKitStyleTest.test_webkit_export_check): Deleted.
1636         (WebKitStyleTest.test_member_initialization_list): Deleted.
1637         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
1638         (WebKitStyleTest.test_other): Deleted.
1639         (CppCheckerTest.mock_handle_style_error): Deleted.
1640         (CppCheckerTest._checker): Deleted.
1641         (CppCheckerTest.test_init): Deleted.
1642         (CppCheckerTest.test_eq): Deleted.
1643         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
1644         (CppCheckerTest.test_ne): Deleted.
1645         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1646         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1647         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1648         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1649         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1650         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1651
1652 2017-07-05  Saam Barati  <sbarati@apple.com>
1653
1654         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
1655         https://bugs.webkit.org/show_bug.cgi?id=174188
1656         <rdar://problem/30581423>
1657
1658         Reviewed by Mark Lam.
1659
1660         * Scripts/run-jsc-stress-tests:
1661
1662 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1663
1664         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1665         https://bugs.webkit.org/show_bug.cgi?id=174150
1666
1667         Reviewed by Mark Lam.
1668
1669         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1670         (TestWebKitAPI::TEST):
1671
1672 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1673
1674         Remove copy of ICU headers from WebKit
1675         https://bugs.webkit.org/show_bug.cgi?id=116407
1676
1677         Reviewed by Alex Christensen.
1678
1679         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1680         * TestWebKitAPI/Configurations/Base.xcconfig:
1681         * WebKitTestRunner/Configurations/Base.xcconfig:
1682
1683 2017-07-05  Chris Dumez  <cdumez@apple.com>
1684
1685         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
1686         https://bugs.webkit.org/show_bug.cgi?id=174163
1687         <rdar://problem/33067518>
1688
1689         Reviewed by Alex Christensen.
1690
1691         Add API test coverage.
1692
1693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1694         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
1695         (TEST):
1696
1697 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1698
1699         When dragging a selection, clearing the selection in dragstart should not crash the web process
1700         https://bugs.webkit.org/show_bug.cgi?id=174142
1701         <rdar://problem/33067501>
1702
1703         Reviewed by Tim Horton.
1704
1705         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
1706         drag is starting up.
1707
1708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1709         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
1710         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1711         (TestWebKitAPI::TEST):
1712
1713 2017-07-05  Daniel Bates  <dabates@apple.com>
1714
1715         Do not pass API::FrameInfo for source frame or clear out page of target frame on
1716         API navigation
1717         https://bugs.webkit.org/show_bug.cgi?id=174170
1718         <rdar://problem/33140328>
1719
1720         Reviewed by Brady Eidson.
1721
1722         Update tests as needed for the behavior change.
1723
1724         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1725         (TEST):
1726
1727 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
1728
1729         Add WebKitPrivateFrameworkStubs for iOS 11
1730         https://bugs.webkit.org/show_bug.cgi?id=173988
1731
1732         Reviewed by David Kilzer.
1733
1734         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
1735         should use the same directory for private framework stubs.
1736         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1737
1738 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
1739
1740         [MediaStream] Protect request and web view during gUM client callback
1741         https://bugs.webkit.org/show_bug.cgi?id=174096
1742         <rdar://problem/32833102>
1743
1744         Reviewed by Youenn Fablet.
1745
1746         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1747         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1748
1749 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1750
1751         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
1752
1753         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1754
1755 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1756
1757         Unreviewed, rolling out r219128.
1758
1759         Spoke with engineer who originally submitted, Patch for APi
1760         test to follow.
1761
1762         Reverted changeset:
1763
1764         "Unreviewed, rolling out r219070."
1765         https://bugs.webkit.org/show_bug.cgi?id=174082
1766         http://trac.webkit.org/changeset/219128
1767
1768 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1769
1770         Unreviewed, rolling out r219070.
1771
1772         This revision caused consistent failures of the API test
1773         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
1774
1775         Reverted changeset:
1776
1777         "Pasting single words copied to UIPasteboard inserts URLs in
1778         editable areas"
1779         https://bugs.webkit.org/show_bug.cgi?id=174082
1780         http://trac.webkit.org/changeset/219070
1781
1782 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1783
1784         Remove unused EFL logo from bot watcher dashboard
1785         https://bugs.webkit.org/show_bug.cgi?id=174136
1786
1787         Reviewed by Alexey Proskuryakov.
1788
1789         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
1790         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
1791
1792 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1793
1794         [GTK] Add more GTK bots to dashboard
1795         https://bugs.webkit.org/show_bug.cgi?id=174129
1796
1797         Reviewed by Carlos Alberto Lopez Perez.
1798
1799         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
1800         them.
1801
1802         This also changes the sort order to put WPE above GTK so that it's not buried under all the
1803         less-essential GTK bots.
1804
1805         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1806         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1807         (WebKitBuildbot):
1808
1809 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1810
1811         [WPE] Add WPE to bot watcher dashboard
1812         https://bugs.webkit.org/show_bug.cgi?id=174119
1813
1814         Reviewed by Alexey Proskuryakov.
1815
1816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
1817         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
1818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
1819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1821         (WebKitBuildbot):
1822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1823         (table.queue-grid tr.platform.linux-wpe img.logo):
1824
1825 2017-07-03  Lucas Forschler  <lforschler@apple.com>
1826
1827         https://bugs.webkit.org/show_bug.cgi?id=174105
1828         
1829         Reviewed by Stephanie Lewis.
1830
1831         * BuildSlaveSupport/built-product-archive:
1832         (main): Add a -minify parser option
1833         (createZip): Pass along the optional Minify argument if requested
1834         (minifySource): This will trim down archives, logic limited to Mac platform.
1835
1836 2017-07-03  Matt Rajca  <mrajca@apple.com>
1837
1838         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
1839         https://bugs.webkit.org/show_bug.cgi?id=174103
1840
1841         Reviewed by Alex Christensen.
1842
1843         Added an API test.
1844
1845         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
1846         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1847         (TEST): Added test.
1848         * TestWebKitAPI/cocoa/TestWKWebView.h:
1849         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1850         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
1851
1852 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1853
1854         Unreviewed, rolling out r219103.
1855
1856         Caused multiple build failures.
1857
1858         Reverted changeset:
1859
1860         "Remove copy of ICU headers from WebKit"
1861         https://bugs.webkit.org/show_bug.cgi?id=116407
1862         http://trac.webkit.org/changeset/219103
1863
1864 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1865
1866         Remove copy of ICU headers from WebKit
1867         https://bugs.webkit.org/show_bug.cgi?id=116407
1868
1869         Reviewed by Alex Christensen.
1870
1871         Use WTF's copy of ICU headers.
1872
1873         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1874         * TestWebKitAPI/Configurations/Base.xcconfig:
1875         * WebKitTestRunner/Configurations/Base.xcconfig:
1876
1877 2017-07-03  Brady Eidson  <beidson@apple.com>
1878
1879         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
1880         https://bugs.webkit.org/show_bug.cgi?id=174073
1881
1882         Reviewed by Andy Estes.
1883
1884         * DumpRenderTree/mac/TestRunnerMac.mm:
1885         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
1886
1887         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
1888         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
1889
1890 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1891
1892         Unreviewed, rolling out r219083.
1893
1894         The revision caused an API failure on all testing platforms.
1895
1896         Reverted changeset:
1897
1898         "[MediaStream] Protect request and web view during gUM client
1899         callback"
1900         https://bugs.webkit.org/show_bug.cgi?id=174096
1901         http://trac.webkit.org/changeset/219083
1902
1903 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
1904
1905         webkitpy: Properly number duplicated crashlogs
1906         https://bugs.webkit.org/show_bug.cgi?id=172002
1907
1908         Reviewed by Aakash Jain.
1909
1910         * Scripts/webkitpy/common/system/crashlogs.py:
1911         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
1912         an increasing integer.
1913         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1914         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
1915         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
1916         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
1917
1918 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
1919
1920         WebContent processes crash when the network process crashes with pending connection requests
1921         https://bugs.webkit.org/show_bug.cgi?id=174065
1922         <rdar://problem/30359835>
1923
1924         Reviewed by Tim Horton.
1925
1926         Add a API to ensure UI process tries to relaunch a new network process when the network process
1927         crashes with pending network connection requests.
1928
1929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1930         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
1931         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1932         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1933         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
1934
1935 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
1936
1937         [MediaStream] Protect request and web view during gUM client callback
1938         https://bugs.webkit.org/show_bug.cgi?id=174096
1939         <rdar://problem/32833102>
1940
1941         Reviewed by Youenn Fablet.
1942
1943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1944         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1945
1946 2017-07-03  Andy Estes  <aestes@apple.com>
1947
1948         [Xcode] Add an experimental setting to build with ccache
1949         https://bugs.webkit.org/show_bug.cgi?id=173875
1950
1951         Reviewed by Tim Horton.
1952
1953         On systems that already have ccache(1) installed, this patch adds experimental support for
1954         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
1955
1956         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
1957         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
1958         find the toolchain from which to run clang, and then invokes ccache with the required
1959         arguments.
1960
1961         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
1962         precompiled headers to work properly [1].
1963
1964         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
1965         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
1966         during linking.
1967         
1968         [1] https://ccache.samba.org/manual.html#_precompiled_headers
1969
1970         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
1971         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1972         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1973         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
1974         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
1975         * ccache/README.md: Added.
1976         * ccache/ccache-clang: Added.
1977         * ccache/ccache-clang++: Added.
1978         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
1979
1980 2017-07-03  Alex Christensen  <achristensen@webkit.org>
1981
1982         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
1983         https://bugs.webkit.org/show_bug.cgi?id=174051
1984
1985         Reviewed by Tim Horton.
1986
1987         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1988         (TestWebKitAPI::TEST_F):
1989
1990 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1991
1992         Unreviewed, rolling out r219024.
1993
1994         This patch cause 3 didferent test to fail.
1995
1996         Reverted changeset:
1997
1998         "REGRESSION(r215096) Queries of URLs with non-special schemes
1999         should not percent-encode single quotes"
2000         https://bugs.webkit.org/show_bug.cgi?id=174051
2001         http://trac.webkit.org/changeset/219024
2002
2003 2017-07-03  Chris Dumez  <cdumez@apple.com>
2004
2005         Drop ResourceLoadStatisticsStore's statisticsLock
2006         https://bugs.webkit.org/show_bug.cgi?id=174080
2007
2008         Reviewed by Brent Fulgham.
2009
2010         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2011
2012         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2013         (WTR::TestController::isStatisticsPrevalentResource):
2014         (WTR::TestController::isStatisticsHasHadUserInteraction):
2015         (WTR::TestController::isStatisticsGrandfathered):
2016
2017 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2018
2019         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2020         https://bugs.webkit.org/show_bug.cgi?id=174082
2021         <rdar://problem/33046992>
2022
2023         Reviewed by Tim Horton.
2024
2025         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2026
2027         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2028         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2029         (TestWebKitAPI::TEST):
2030
2031 2017-07-02  Brady Eidson  <beidson@apple.com>
2032
2033         Add API test for all parts of WebKit1 API related to favicons.
2034         https://bugs.webkit.org/show_bug.cgi?id=174069
2035
2036         Reviewed by Andy Estes.
2037
2038         These two API tests cover all WebKit1 API related to icons.
2039         
2040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2041         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2042         (mainResourceData):
2043         (defaultFaviconData):
2044         (customFaviconData):
2045         (imageFromData):
2046         (+[IconLoadingProtocol canInitWithRequest:]):
2047         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2048         (-[IconLoadingProtocol startLoading]):
2049         (-[IconLoadingProtocol stopLoading]):
2050         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2051         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2052         (TestWebKitAPI::TEST):
2053
2054 2017-07-01  Dan Bernstein  <mitz@apple.com>
2055
2056         [iOS] Remove code only needed when building for iOS 9.x
2057         https://bugs.webkit.org/show_bug.cgi?id=174068
2058
2059         Reviewed by Tim Horton.
2060
2061         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2062         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2063         (WTR::initializeWebViewConfiguration):
2064         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2065         (-[HIDEventGenerator _createIOHIDEventType:]):
2066
2067 2017-07-01  Brady Eidson  <beidson@apple.com>
2068
2069         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2070         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2071
2072         Reviewed by Alex Christensen.
2073
2074         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2075
2076 2017-07-01  Dan Bernstein  <mitz@apple.com>
2077
2078         [macOS] Remove code only needed when building for OS X Yosemite
2079         https://bugs.webkit.org/show_bug.cgi?id=174067
2080
2081         Reviewed by Tim Horton.
2082
2083         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2084         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2085         * DumpRenderTree/mac/DumpRenderTree.mm:
2086         (setDefaultsToConsistentValuesForTesting):
2087         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2088         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2089         * MiniBrowser/Configurations/Base.xcconfig:
2090         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2091         * TestWebKitAPI/Configurations/Base.xcconfig:
2092         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2093         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2094         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2095         (TestWebKitAPI::TEST_F):
2096         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2097         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2098         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2099         (TestWebKitAPI::TEST_F):
2100         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2101         (TestWebKitAPI::TEST):
2102         * WebKitTestRunner/Configurations/Base.xcconfig:
2103         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2104         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2105         (WTR::InjectedBundle::platformInitialize):
2106         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2107         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2108
2109 2017-07-01  Chris Dumez  <cdumez@apple.com>
2110
2111         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2112         https://bugs.webkit.org/show_bug.cgi?id=174060
2113
2114         Reviewed by Brent Fulgham.
2115
2116         Port WebKitTestRunner over to the new Cocoa SPI.
2117
2118         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2119         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2120         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2121         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2122         no-ops since this code runs in the WebContent process, not the
2123         UIProcess.
2124
2125         * WebKitTestRunner/TestController.cpp:
2126         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2127
2128 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2129
2130         Unreviewed mac build fix.
2131
2132         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2133         (TestWebKitAPI::TEST):
2134
2135 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2136
2137         Add API to get WKActivatedElementInfo
2138         https://bugs.webkit.org/show_bug.cgi?id=174001
2139         <rdar://problem/29165518>
2140         
2141         Tests for now SPI to get activatedElementInfo.
2142
2143         Reviewed by Tim Horton.
2144
2145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2146         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2147         (TestWebKitAPI::TEST):
2148
2149 2017-06-30  Chris Dumez  <cdumez@apple.com>
2150
2151         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2152         https://bugs.webkit.org/show_bug.cgi?id=174038
2153
2154         Reviewed by Brent Fulgham.
2155
2156         Fix typo in API name.
2157
2158         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2159         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2160         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2161         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2162         * WebKitTestRunner/TestController.cpp:
2163         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2164         * WebKitTestRunner/TestController.h:
2165         * WebKitTestRunner/TestInvocation.cpp:
2166         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2167
2168 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2169
2170         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2171         https://bugs.webkit.org/show_bug.cgi?id=174051
2172         <rdar://problem/33002846>
2173
2174         Reviewed by Tim Horton.
2175
2176         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2177         (TestWebKitAPI::TEST_F):
2178
2179 2017-06-30  Daniel Bates  <dabates@apple.com>
2180
2181         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2182         https://bugs.webkit.org/show_bug.cgi?id=165160
2183         <rdar://problem/29451999>
2184
2185         Reviewed by Brady Eidson.
2186
2187         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2188         for navigations and window creation.
2189
2190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2191         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2192         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2193         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2194         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2195         (TEST):
2196
2197 2017-06-29  Jer Noble  <jer.noble@apple.com>
2198
2199         Make Legacy EME API controlled by RuntimeEnabled setting.
2200         https://bugs.webkit.org/show_bug.cgi?id=173994
2201
2202         Reviewed by Sam Weinig.
2203
2204         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2205
2206 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2207
2208         Follow-up fix for r218996
2209
2210         Unreviewed infrastructure fix.
2211
2212         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2213
2214         * Scripts/webkitpy/port/ios_simulator.py:
2215         (IOSSimulatorPort): Memoize ios_version().
2216
2217 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2218
2219         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2220         https://bugs.webkit.org/show_bug.cgi?id=174017
2221         <rdar://problem/32959782>
2222
2223         Reviewed by Simon Fraser.
2224
2225         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2226         changes, the caret would appear outside of the iframe.
2227
2228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2229         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2230         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2231         (checkDragCaretRectIsContainedInRect):
2232         (TestWebKitAPI::TEST):
2233         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2234         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2235         (-[DataInteractionSimulator _resetSimulatedState]):
2236         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2237         (-[DataInteractionSimulator _advanceProgress]):
2238         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2239
2240 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2241
2242         Add support for different versions of iOS when loading test expectations
2243         https://bugs.webkit.org/show_bug.cgi?id=173774
2244         <rdar://problem/32951132>
2245
2246         Rubber-stamped by Aakash Jain.
2247
2248         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2249
2250         * Scripts/webkitpy/port/ios.py:
2251         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2252         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2253         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2254         * Scripts/webkitpy/port/ios_device.py:
2255         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2256         * Scripts/webkitpy/port/ios_device_unittest.py:
2257         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2258         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2259         (IOSDeviceTest.test_expectations_ordering): Ditto.
2260         * Scripts/webkitpy/port/ios_simulator.py:
2261         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2262         ask the platform.
2263
2264 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2265
2266         Fontconfig build breaks with glibc 2.15+
2267         https://bugs.webkit.org/show_bug.cgi?id=174019
2268
2269         Reviewed by Carlos Alberto Lopez Perez.
2270
2271         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2272
2273         * wpe/jhbuild.modules:
2274         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2275
2276 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2277
2278         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2279         https://bugs.webkit.org/show_bug.cgi?id=174010
2280         <rdar://problem/32597802>
2281
2282         Reviewed by Tim Horton.
2283
2284         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2285         snapshot fails for any reason.
2286
2287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2288         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2289         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2290         (TestWebKitAPI::TEST):
2291
2292 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2293
2294         AX: Cannot call setValue() on contenteditable or ARIA text controls
2295         https://bugs.webkit.org/show_bug.cgi?id=173520
2296
2297         Reviewed by Ryosuke Niwa.
2298
2299         Add setValue() method to WKTR (already existed in DRT).
2300
2301         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2302         (WTR::AccessibilityUIElement::setValue):
2303         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2304         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2305         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2306         (WTR::AccessibilityUIElement::setValue):
2307
2308 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2309
2310         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2311         https://bugs.webkit.org/show_bug.cgi?id=173841
2312         rdar://problem/32983841
2313
2314         Reviewed by Dean Jackson.
2315
2316         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2317         always did text zooming.
2318
2319         * MiniBrowser/mac/WK1BrowserWindowController.m:
2320         (-[WK1BrowserWindowController zoomIn:]):
2321         (-[WK1BrowserWindowController zoomOut:]):
2322         (-[WK1BrowserWindowController canResetZoom]):
2323         (-[WK1BrowserWindowController resetZoom:]):
2324
2325 2017-06-29  John Wilander  <wilander@apple.com>
2326
2327         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2328         https://bugs.webkit.org/show_bug.cgi?id=173940
2329         <rdar://problem/33018125>
2330
2331         Reviewed by Brent Fulgham.
2332
2333         This change allows the TestController to turn off
2334         regular resource load statistics telemetry submission
2335         and to manually control when telemetry is calculated
2336         and submitted.
2337
2338         * WebKitTestRunner/TestController.cpp:
2339         (WTR::TestController::initialize):
2340             Turns off automatic resource load statistics telemetry submission.
2341
2342 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2343
2344         Unreviewed, rolling out r218512.
2345         https://bugs.webkit.org/show_bug.cgi?id=173981
2346
2347         "It changes the behavior of the JS API's JSEvaluateScript
2348         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2349
2350         Reverted changeset:
2351
2352         "test262: Completion values for control flow do not match the
2353         spec"
2354         https://bugs.webkit.org/show_bug.cgi?id=171265
2355         http://trac.webkit.org/changeset/218512
2356
2357 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2358
2359         Add WebKitSystemInterface for iOS 11
2360         https://bugs.webkit.org/show_bug.cgi?id=173936
2361
2362         Reviewed by Lucas Forschler.
2363
2364         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2365
2366 2017-06-28  Keith Miller  <keith_miller@apple.com>
2367
2368         VMTraps has some races
2369         https://bugs.webkit.org/show_bug.cgi?id=173941
2370
2371         Reviewed by Michael Saboff.
2372
2373         Add new testing mode for testing the Watchdog with our stress
2374         tests.
2375
2376         * Scripts/run-jsc-stress-tests:
2377
2378 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2379
2380         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2381         https://bugs.webkit.org/show_bug.cgi?id=173877
2382
2383         Reviewed by Brady Eidson.
2384
2385         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2386         the next tests.
2387
2388         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2389         (testGetFavicon):
2390
2391 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2392
2393         MobileSafari was constantly using 10-15% CPU viewing a PDF
2394         https://bugs.webkit.org/show_bug.cgi?id=173944
2395         <rdar://problem/33039910>
2396
2397         Reviewed by Simon Fraser.
2398
2399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2400         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2401         Add a test that we ever call the stable presentation update callback
2402         when we have a WKPDFView up, instead of infinitely looping.
2403
2404 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2405
2406         Prevent displaying URLs with small capital letters
2407         https://bugs.webkit.org/show_bug.cgi?id=173949
2408         <rdar://problem/32952058>
2409
2410         Reviewed by Brent Fulgham.
2411
2412         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2413         (TestWebKitAPI::TEST):
2414
2415 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2416
2417         Unreviewed test fix.
2418
2419         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2420
2421         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2422
2423 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2424
2425         Teach ResourceLoadStatistics to recognize changes in the file system
2426         https://bugs.webkit.org/show_bug.cgi?id=173800
2427         <rdar://problem/32937842>
2428
2429         Reviewed by Chris Dumez.
2430
2431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2432         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2433         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2434         (TestWebKitAPI::handleFileModification):
2435         (TestWebKitAPI::handleFileDeletion):
2436         (TestWebKitAPI::resetTestState):
2437         (TestWebKitAPI::TEST_F):
2438
2439 2017-06-28  Brady Eidson  <beidson@apple.com>
2440
2441         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2442         https://bugs.webkit.org/show_bug.cgi?id=173874
2443
2444         Reviewed by Alex Christensen.
2445
2446         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2447
2448 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2449
2450         Unreviewed, adding Don Olmstead to contributors.json
2451
2452         * Scripts/webkitpy/common/config/contributors.json:
2453
2454 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2455
2456         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2457         https://bugs.webkit.org/show_bug.cgi?id=173886
2458         <rdar://problem/32543191>
2459
2460         Reviewed by Andy Estes.
2461
2462         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2463         (ParsedRange::ParsedRange):
2464         (-[TestSchemeHandler initWithVideoData:]):
2465         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2466         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2467         (TEST):
2468
2469 2017-06-27  JF Bastien  <jfbastien@apple.com>
2470
2471         WebAssembly: running out of executable memory should throw OoM
2472         https://bugs.webkit.org/show_bug.cgi?id=171537
2473         <rdar://problem/32963338>
2474
2475         Reviewed by Saam Barati.
2476
2477         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2478         tests under limited executable memory and avoids non-WebAssembly
2479         code generation so that we more reliably run out of executable
2480         memory in WebAssembly.
2481
2482 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2483
2484         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2485         https://bugs.webkit.org/show_bug.cgi?id=173854
2486         <rdar://problem/32236827>
2487
2488         Reviewed by Ryosuke Niwa and Tim Horton.
2489
2490         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2491
2492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2493         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2494         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2495         (TestWebKitAPI::TEST):
2496
2497 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2498
2499         [PAL] Add symbol export macros for PAL
2500         https://bugs.webkit.org/show_bug.cgi?id=171519
2501
2502         Reviewed by Konstantin Tokarev.
2503
2504         * DumpRenderTree/config.h:
2505         * TestWebKitAPI/CMakeLists.txt:
2506         * TestWebKitAPI/config.h:
2507         * WebKitTestRunner/config.h:
2508
2509 2017-06-27  John Wilander  <wilander@apple.com>
2510
2511         Resource Load Statistics: Add telemetry
2512         https://bugs.webkit.org/show_bug.cgi?id=173499
2513         <rdar://problem/32826094>
2514
2515         Reviewed by Brent Fulgham.
2516
2517         Adds three new testRunner functions:
2518         - installStatisticsDidRunTelemetryCallback()
2519         - statisticsFireTelemetryHandler()
2520         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2521
2522         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2523         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2524         (WTR::InjectedBundle::didReceiveMessageToPage):
2525         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2526         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2527         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2528         (WTR::TestRunner::statisticsFireTelemetryHandler):
2529         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2530         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2531         * WebKitTestRunner/TestController.cpp:
2532         (WTR::TestController::resetStateToConsistentValues):
2533         (WTR::TestController::statisticsFireTelemetryHandler):
2534         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2535         * WebKitTestRunner/TestController.h:
2536         * WebKitTestRunner/TestInvocation.cpp:
2537         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2538
2539 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
2540
2541         Add missing includes to fix compilation error on FreeBSD
2542         https://bugs.webkit.org/show_bug.cgi?id=172919
2543
2544         Reviewed by Mark Lam.
2545
2546         * ImageDiff/cairo/PlatformImageCairo.cpp:
2547
2548 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
2549
2550         Unreviewed, rolling out r218783.
2551
2552         Causing accessibility/mac/setting-attributes-is-
2553         asynchronous.html to crash consistently on mac-wk2 Debug
2554
2555         Reverted changeset:
2556
2557         "AX: Cannot call setValue() on contenteditable or ARIA text
2558         controls"
2559         https://bugs.webkit.org/show_bug.cgi?id=173520
2560         http://trac.webkit.org/changeset/218783
2561
2562 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2563
2564         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
2565         https://bugs.webkit.org/show_bug.cgi?id=173825
2566
2567         Reviewed by Saam Barati.
2568
2569         * DumpRenderTree/JavaScriptThreading.cpp:
2570         (runJavaScriptThread):
2571         (startJavaScriptThreads):
2572         * DumpRenderTree/mac/DumpRenderTree.mm:
2573         (runThread):
2574         (runPthread):
2575         (testThreadIdentifierMap):
2576
2577 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2578
2579         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
2580         <https://webkit.org/b/173837>
2581
2582         Reviewed by Geoffrey Garen.
2583
2584         The clang static analyzer can't reason about objects that are
2585         assigned to a delegate as +1 retained, and then released
2586         later in a different method when the delegate is cleared.
2587
2588         Instead, use a common idiom where the object setting the
2589         delegate retains it as an instance variable on initialization.
2590         Then the same object clears the delegate and releases its
2591         instance variable during teardown.
2592
2593         Also add EXPECT_TRUE() tests to make sure the delegate objects
2594         match before teardown.
2595
2596         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2597         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2598         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2599         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2600         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2601         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
2602
2603 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2604
2605         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
2606         <https://webkit.org/b/173836>
2607
2608         Reviewed by Brady Eidson.
2609
2610         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2611         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
2612         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
2613         objects in this test.
2614
2615 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
2616
2617         [ATK] Add support for aria-details and aria-errormessage
2618         https://bugs.webkit.org/show_bug.cgi?id=172588
2619
2620         Reviewed by Chris Fleizach.
2621
2622         Add additional methods to test ARIA properties which are exposed via
2623         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
2624         to versions which support the details and error-message relation types.
2625
2626         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2627         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2628         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2629         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2630         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2631         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2632         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2633         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2634         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2635         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2636         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2637         * gtk/jhbuild.modules:
2638
2639 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2640
2641         Unreviewed. Add libfii to GTK+ install dependencies script.
2642
2643         * gtk/install-dependencies:
2644
2645 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2646
2647         Unreviewed, rolling out r215190.
2648
2649         Broke product select element on GNOME Bugzilla
2650
2651         Reverted changeset:
2652
2653         "[GTK] Misplaced right click menu on web page due to
2654         deprecated gtk_menu_popup()"
2655         https://bugs.webkit.org/show_bug.cgi?id=170553
2656         http://trac.webkit.org/changeset/215190
2657
2658 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
2659
2660         Remove Reflect.enumerate
2661         https://bugs.webkit.org/show_bug.cgi?id=173806
2662
2663         Reviewed by Yusuke Suzuki.
2664
2665         * Scripts/run-jsc-stress-tests:
2666
2667 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
2668
2669         AX: Cannot call setValue() on contenteditable or ARIA text controls
2670         https://bugs.webkit.org/show_bug.cgi?id=173520
2671
2672         Reviewed by Ryosuke Niwa.
2673
2674         Add setValue() method to WKTR (already existed in DRT).
2675
2676         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2677         (WTR::AccessibilityUIElement::setValue):
2678         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2679         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2680         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2681         (WTR::AccessibilityUIElement::setValue):
2682
2683 2017-06-23  Keith Miller  <keith_miller@apple.com>
2684
2685         Switch VMTraps to use halt instructions rather than breakpoint instructions
2686         https://bugs.webkit.org/show_bug.cgi?id=173677
2687
2688         Reviewed by JF Bastien.
2689
2690         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2691         (TEST):
2692
2693 2017-06-23  Youenn Fablet  <youenn@apple.com>
2694
2695         Set getUserMedia permission to true by default on WTR
2696         https://bugs.webkit.org/show_bug.cgi?id=173610
2697
2698         Reviewed by Alex Christensen.
2699
2700         Adding a way to reset the getUserMedia permission to pending.
2701
2702         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2703         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2704         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
2705         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2706         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2707         (WTR::TestRunner::setUserMediaPermissionAsUnset):
2708         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2709         * WebKitTestRunner/TestController.cpp:
2710         (WTR::TestController::resetStateToConsistentValues):
2711         (WTR::TestController::setUserMediaPermissionAsUnset):
2712         * WebKitTestRunner/TestController.h:
2713         * WebKitTestRunner/TestInvocation.cpp:
2714         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2715
2716 2017-06-23  Alex Christensen  <achristensen@webkit.org>
2717
2718         Add SPI to WKURLSchemeTask for redirection
2719         https://bugs.webkit.org/show_bug.cgi?id=173730
2720
2721         Reviewed by Brady Eidson.
2722
2723         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2724         (-[SchemeHandler webView:startURLSchemeTask:]):
2725         (-[SchemeHandler webView:stopURLSchemeTask:]):
2726         (TEST):
2727         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
2728         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
2729         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
2730         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
2731         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
2732
2733 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2734
2735         [WPE] Use JSC API to send script messages from web extension in tests
2736         https://bugs.webkit.org/show_bug.cgi?id=173757
2737
2738         Reviewed by Žan Doberšek.
2739
2740         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
2741         to run postMessage().
2742
2743         Fixes: /wpe/WebKitSecurityManager/file-xhr
2744                /wpe/WebKitConsoleMessage/console-api
2745                /wpe/WebKitConsoleMessage/js-exception
2746                /wpe/WebKitConsoleMessage/network-error
2747                /wpe/WebKitConsoleMessage/security-error
2748
2749         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2750         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
2751         (beforeAll): Ditto.
2752         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2753         (testWebContextSecurityFileXHR): Ditto.
2754         (beforeAll): Ditto.
2755         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2756         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
2757         (pageCreatedCallback): Remove ifdefs.
2758
2759 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2760
2761         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
2762
2763         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
2764         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
2765         doesn't exist yet in WPE.
2766
2767         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2768         (testWebViewJavaScriptDialogs):
2769         (testWebViewWindowProperties):
2770
2771 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2772
2773         [GTK] Upgrade pixman and cairo in jhbuild
2774         https://bugs.webkit.org/show_bug.cgi?id=173710
2775
2776         Reviewed by Carlos Alberto Lopez Perez.
2777
2778         * gtk/jhbuild.modules:
2779
2780 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2781
2782         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
2783         https://bugs.webkit.org/show_bug.cgi?id=173711
2784
2785         Reviewed by Carlos Alberto Lopez Perez.
2786
2787         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
2788         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
2789
2790         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2791         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
2792
2793 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2794
2795         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
2796         <https://webkit.org/b/173721>
2797
2798         Reviewed by Joseph Pecoraro.
2799
2800         Use RetainPtr<> to create NSMutableDictionary and NSNumber
2801         objects to fix leaks and to avoid the autoreleasepool.
2802
2803         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
2804         (TEST):
2805
2806 2017-06-22  Matt Lewis  <jlewis3@apple.com>
2807
2808         Unreviewed, rolling out r218633.
2809
2810         The test is failing frequently on Sierra Debug and Windows
2811
2812         Reverted changeset:
2813
2814         "AX: Cannot call setValue() on contenteditable or ARIA text
2815         controls"
2816         https://bugs.webkit.org/show_bug.cgi?id=173520
2817         http://trac.webkit.org/changeset/218633
2818
2819 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2820
2821         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
2822         <https://webkit.org/b/173690>
2823
2824         Reviewed by Chris Dumez.
2825
2826         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
2827         ownership of malloc()-ed memory, then frees it when it's
2828         released.  These tests were passing global variables into the
2829         method, which is not malloc()-ed memory, which violates the API
2830         contract.
2831
2832         The fix is to switch to use
2833         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
2834         NO for the last argument.
2835
2836         Caught by the clang static analyzer.
2837
2838         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2839         (TEST):
2840         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2841         (TEST):
2842
2843 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2844
2845         [GTK] Upgrade Harfbuzz to version 1.4.2
2846         https://bugs.webkit.org/show_bug.cgi?id=173592
2847
2848         Reviewed by Carlos Alberto Lopez Perez.
2849
2850         * gtk/jhbuild.modules:
2851
2852 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2853
2854         [WPE] Update WPEBackend-mesa
2855         https://bugs.webkit.org/show_bug.cgi?id=173705
2856
2857         Reviewed by Carlos Alberto Lopez Perez.
2858
2859         A crash has been fixed, needed for unit tests to work.
2860
2861         * wpe/jhbuild.modules:
2862
2863 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2864
2865         Remove unused coordinated graphics C API
2866         https://bugs.webkit.org/show_bug.cgi?id=173706
2867
2868         Reviewed by Žan Doberšek.
2869
2870         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
2871         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
2872         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
2873         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
2874         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
2875         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
2876
2877 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2878
2879         [WPE] Build glib API tests
2880         https://bugs.webkit.org/show_bug.cgi?id=173702
2881
2882         Reviewed by Žan Doberšek.
2883
2884         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
2885         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
2886         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
2887         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
2888         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
2889         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
2890         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
2891         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
2892         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
2893         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
2894         and implement the missing features.
2895
2896         * CMakeLists.txt:
2897         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
2898         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2899         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2900         (testAutomationSessionRequestSession):
2901         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2902         (testWebKitWebViewSessionState):
2903         (testWebKitWebViewSessionStateWithFormData):
2904         (testWebKitWebViewNavigationAfterSessionRestore):
2905         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2906         (beforeAll):
2907         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2908         (testCookieManagerEphemeral):
2909         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2910         (testBlobDownload):
2911         (beforeAll):
2912         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2913         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2914         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2915         (testProcessPerWebView):
2916         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2917         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2918         (testWebViewCreateNavigationData):
2919         (testWebViewJavaScriptDialogs):
2920         (testWebViewWindowProperties):
2921         (testWebViewMouseTarget):
2922         (testWebViewGeolocationPermissionRequests):
2923         (testWebViewUserMediaPermissionRequests):
2924         (testWebViewAudioOnlyUserMediaPermissionRequests):
2925         (testWebViewFileChooserRequest):
2926         (beforeAll):
2927         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2928         (beforeAll):
2929         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2930         (testPrivateBrowsing):
2931         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2932         (testFindControllerHide):
2933         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2934         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2935         (testWebKitSettings):
2936         (beforeAll):
2937         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2938         (testWebViewNewWithUserContentManager):
2939         (beforeAll):
2940         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2941         (testWebContextEphemeral):
2942         (testWebContextProxySettings):
2943         (beforeAll):
2944         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2945         (testWebViewWebContext):
2946         (testWebViewWebContextLifetime):
2947         (testWebViewEphemeral):
2948         (testWebViewSettings):
2949         (testWebViewCanShowMIMEType):
2950         (testWebViewPageVisibility):
2951         (testWebViewIsPlayingAudio):
2952         (beforeAll):
2953         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2954         (testWebsiteDataEphemeral):
2955         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2956         (documentLoadedCallback):
2957         (pageCreatedCallback):
2958         (methodCallCallback):
2959         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
2960         * TestWebKitAPI/glib/CMakeLists.txt:
2961         * TestWebKitAPI/glib/PlatformGTK.cmake:
2962         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2963         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2964         (main):
2965         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2966         (Test::adoptView):
2967         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2968         (WebKitTestBus::run):
2969         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2970         (WebViewTest::~WebViewTest):
2971         (WebViewTest::initializeWebView):
2972         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
2973         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
2974         (WebViewTest::platformDestroy):
2975         (WebViewTest::platformInitializeWebView):
2976         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
2977         (WebViewTest::resizeView):
2978         (WebViewTest::hideView):
2979         (parentWindowMapped):
2980         (WebViewTest::showInWindow):
2981         (WebViewTest::showInWindowAndWaitUntilMapped):
2982         (WebViewTest::mouseMoveTo):
2983         (WebViewTest::clickMouseButton):
2984         (WebViewTest::emitPopupMenuSignal):
2985         (WebViewTest::keyStroke):
2986         (WebViewTest::doMouseButtonEvent):
2987         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
2988         (WebViewTest::platformDestroy):
2989         (WebViewTest::platformInitializeWebView):
2990         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
2991         (WebViewTest::resizeView):
2992         (WebViewTest::hideView):
2993         (WebViewTest::mouseMoveTo):
2994         (WebViewTest::clickMouseButton):
2995         (WebViewTest::keyStroke):
2996
2997 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2998
2999         [GTK] Move WebKit2 GLib API tests to glib directories
3000         https://bugs.webkit.org/show_bug.cgi?id=173642
3001
3002         Reviewed by Žan Doberšek.
3003
3004         * CMakeLists.txt:
3005         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3006         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3007         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3008         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3009         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3010         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3011         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3012         (testWebKitConsoleMessageNetworkError):
3013         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3014         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3015         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3016         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3017         (testLoadFromGResource):
3018         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3019         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3020         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3021         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3022         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3023         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3024         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3025         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3026         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3027         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3028         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3029         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3030         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3031         (testWebViewRunJavaScript):
3032         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3033         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3034         (registerGResource):
3035         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3036         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3037         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3038         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3039         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3040         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3041         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3042         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3043         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3044         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3045         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3046         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3047         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3048         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3049         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3050         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3051         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3052         (registerGResource):
3053         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3054         (Test::getResourcesDir):
3055         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
3056         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
3057         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
3058         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
3059         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
3060         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
3061
3062 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3063
3064         [WPE] Add initial web extensions API
3065         https://bugs.webkit.org/show_bug.cgi?id=173640
3066
3067         Reviewed by Žan Doberšek.
3068
3069         Add style checker exceptions for WPE web extensions API files.
3070
3071         * Scripts/webkitpy/style/checker.py:
3072
3073 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3074
3075         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3076         https://bugs.webkit.org/show_bug.cgi?id=173659
3077         <rdar://problem/32879788>
3078
3079         Reviewed by Tim Horton.
3080
3081         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3082
3083         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3084
3085         Augment this test page to log dragend and dragstart events on the drag source as well.
3086
3087         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3088         (checkStringArraysAreEqual):
3089         (TestWebKitAPI::TEST):
3090
3091 2017-06-21  Antoine Quint  <graouts@apple.com>
3092
3093         Ensure DRT always logs rAF suspension debugging code
3094         https://bugs.webkit.org/show_bug.cgi?id=173681
3095
3096         Reviewed by Tim "Mr. T" Horton.
3097
3098         * DumpRenderTree/mac/DumpRenderTree.mm:
3099         (resetWebPreferencesToConsistentValues):
3100
3101 2017-06-21  Chris Dumez  <cdumez@apple.com>
3102
3103         Allow constructing a WTF:Function from a function pointer
3104         https://bugs.webkit.org/show_bug.cgi?id=173660
3105
3106         Reviewed by Alex Christensen.
3107
3108         Add API test coverage.
3109
3110         * TestWebKitAPI/Tests/WTF/Function.cpp:
3111         (TestWebKitAPI::returnThree):
3112         (TestWebKitAPI::returnFour):
3113         (TestWebKitAPI::returnPassedValue):
3114         (TestWebKitAPI::TEST):
3115
3116 2017-06-21  Antoine Quint  <graouts@apple.com>
3117
3118         Add logging to identify when the Page suspends scripted animations
3119         https://bugs.webkit.org/show_bug.cgi?id=173626
3120
3121         Reviewed by Tim Horton.
3122
3123         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3124
3125         * DumpRenderTree/mac/DumpRenderTree.mm:
3126         (resetWebPreferencesToConsistentValues):
3127
3128 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3129
3130         AX: Cannot call setValue() on contenteditable or ARIA text controls
3131         https://bugs.webkit.org/show_bug.cgi?id=173520
3132
3133         Reviewed by Ryosuke Niwa.
3134
3135         Add setValue() method to WKTR (already existed in DRT).
3136
3137         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3138         (WTR::AccessibilityUIElement::setValue):
3139         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3140         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3141         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3142         (WTR::AccessibilityUIElement::setValue):
3143
3144 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
3145
3146         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
3147         as one of the dependencies required to build the product.
3148
3149         Rubber-stamped by Carlos Garcia Campos.
3150
3151         * gtk/install-dependencies:
3152         * wpe/install-dependencies:
3153
3154 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3155
3156         Disable font variations on macOS Sierra and iOS 10
3157         https://bugs.webkit.org/show_bug.cgi?id=173618
3158         <rdar://problem/32879164>
3159
3160         Reviewed by Jon Lee.
3161
3162         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3163
3164 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3165
3166         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
3167         https://bugs.webkit.org/show_bug.cgi?id=173578
3168         <rdar://problem/32825028>
3169
3170         Reviewed by Tim Horton.
3171
3172         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
3173         a custom popover does not cause dragging to fail when the popover is presented.
3174
3175         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3176         (-[DataInteractionSimulator _advanceProgress]):
3177
3178 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3179
3180         [WPE] Add initial implementation of glib API
3181         https://bugs.webkit.org/show_bug.cgi?id=173546
3182
3183         Reviewed by Žan Doberšek.
3184
3185         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
3186         include WPE glib API files.
3187
3188         * Scripts/webkitperl/FeatureList.pm:
3189         * Scripts/webkitpy/style/checker.py:
3190         * Scripts/webkitpy/style/checkers/cpp.py:
3191         (check_identifier_name_in_declaration):
3192
3193 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3194
3195         [GTK] Upgrade to ICU to version 57.1
3196         https://bugs.webkit.org/show_bug.cgi?id=173538
3197
3198         Reviewed by Žan Doberšek.
3199
3200         * gtk/jhbuild.modules:
3201
3202 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3203
3204         [GTK] Remove unneeded modules from the jhbuild
3205         https://bugs.webkit.org/show_bug.cgi?id=170540
3206
3207         Reviewed by Michael Catanzaro.
3208
3209         We are building libxslt and libffi that we don't really need to build from sources.
3210
3211         * gtk/jhbuild.modules:
3212
3213 2017-06-19  Frederic Wang  <fwang@igalia.com>
3214
3215         [Mac] Add an experimental feature setting for async frame scrolling
3216         https://bugs.webkit.org/show_bug.cgi?id=173359
3217
3218         Reviewed by Simon Fraser.
3219
3220         * DumpRenderTree/mac/DumpRenderTree.mm:
3221         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
3222         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
3223         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3224         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
3225
3226 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
3227
3228         Unreviewed, adding myself to contributors.json
3229
3230         * Scripts/webkitpy/common/config/contributors.json:
3231
3232 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
3233
3234         test262: Completion values for control flow do not match the spec
3235         https://bugs.webkit.org/show_bug.cgi?id=171265
3236
3237         Reviewed by Saam Barati.
3238
3239         * Scripts/run-jsc-stress-tests:
3240         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
3241
3242 2017-06-19  Zalan Bujtas  <zalan@apple.com>
3243
3244         Opening certain mails brings up a mail that grows indefinitely.
3245         https://bugs.webkit.org/show_bug.cgi?id=173562
3246         <rdar://problem/32766579>
3247
3248         Reviewed by Tim Horton.
3249
3250         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3251         (TEST):
3252
3253 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3254
3255         [iOS DnD] Support .zip archives for file uploads via drag and drop
3256         https://bugs.webkit.org/show_bug.cgi?id=173511
3257         <rdar://problem/32521025>
3258
3259         Reviewed by Tim Horton.
3260
3261         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
3262         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
3263
3264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3265         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
3266         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3267         (testZIPArchive):
3268         (TestWebKitAPI::TEST):
3269
3270 2017-06-18  Darin Adler  <darin@apple.com>
3271
3272         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
3273         https://bugs.webkit.org/show_bug.cgi?id=173526
3274
3275         Reviewed by Sam Weinig.
3276
3277         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
3278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3279
3280         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
3281         tests for assignment before destruction ones.
3282
3283         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
3284         as a function, so it can be used in WTF::Function tests.
3285
3286         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
3287         Added tests for swap and for assignment before deref.
3288
3289         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
3290         to inline everything. Also removed the unnecessary clearing of the log every time
3291         the DerivedRefLogger constructor is called.
3292         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
3293
3294         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
3295         Added tests for assignment before deref and similar for releaseNonNull.
3296
3297 2017-06-19  Sam Weinig  <sam@webkit.org>
3298
3299         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
3300         https://bugs.webkit.org/show_bug.cgi?id=173513
3301
3302         Reviewed by Alex Christensen.
3303
3304         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3305         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3306         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
3307
3308 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
3309
3310         [Win] fast/dom/assign-to-window-status.html is flaky.
3311         https://bugs.webkit.org/show_bug.cgi?id=173512
3312
3313         Reviewed by Alex Christensen.
3314
3315         We should not dump status callbacks when test is done.
3316
3317         * DumpRenderTree/win/UIDelegate.cpp:
3318         (UIDelegate::setStatusText):
3319
3320 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3321
3322         [WPE][JHBuild] Update WPEBackend-mesa
3323         https://bugs.webkit.org/show_bug.cgi?id=173433
3324
3325         Unreviewed.
3326
3327         Update WPEBackend-mesa back (like it was done originally in r218344)
3328         after fixing the issue with the DISPLAY environment variables that
3329         caused the crashes.
3330
3331         * wpe/jhbuild.modules:
3332
3333 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3334
3335         Rename unit test file after r218482
3336         https://bugs.webkit.org/show_bug.cgi?id=173483
3337
3338         Unreviewed.
3339
3340         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
3341
3342 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3343
3344         Unreviewed. Fix wrong style checker condition added in r218487.
3345
3346         * Scripts/webkitpy/style/checkers/cpp.py:
3347         (check_identifier_name_in_declaration):
3348
3349 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
3350
3351         Missing <functional> includes make builds fail with GCC 7.x
3352         https://bugs.webkit.org/show_bug.cgi?id=173544
3353
3354         Unreviewed gardening.
3355
3356         Fix compilation with GCC 7.
3357
3358         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3359         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3360
3361 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3362
3363         [GTK] Move GTK+ API files that could be shared to glib dirs
3364         https://bugs.webkit.org/show_bug.cgi?id=173545
3365
3366         Reviewed by Žan Doberšek.
3367
3368         Update paths of GTK+ API in watchlist and style checker.
3369
3370         * Scripts/webkitpy/common/config/watchlist:
3371         * Scripts/webkitpy/style/checker.py:
3372         * Scripts/webkitpy/style/checkers/cpp.py:
3373         (check_identifier_name_in_declaration):
3374
3375 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3376
3377         Port setup_environ_for_server should not set environment variables related with the driver.
3378         https://bugs.webkit.org/show_bug.cgi?id=173483
3379
3380         Reviewed by Carlos Garcia Campos.
3381
3382         The port setup_environ_for_server() should not set environment variables
3383         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
3384         This varibles should be only set on the driver setup_environ_for_test().
3385
3386         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
3387         into the test environment even when running the tests with a driver
3388         that is not the Xorg or Xvfb one.
3389
3390         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
3391         (Port.to.setup_environ_for_server):
3392         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
3393         (Driver._setup_environ_for_driver):
3394         * Scripts/webkitpy/port/driver_unittest.py:
3395         (DriverTest.test_setup_environ_for_test):
3396         (DriverTest):
3397         (DriverTest.test_setup_environ_base_vars):
3398         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
3399         (GtkPort.setup_environ_for_server):
3400         * Scripts/webkitpy/port/wayland_unittest.py: Added.
3401         (WaylandDriverTest):
3402         (WaylandDriverTest.make_driver):
3403         (WaylandDriverTest.make_environment):
3404         (WaylandDriverTest.test_checkdriver):
3405         (WaylandDriverTest.test_environment_needed_variables):
3406         (WaylandDriverTest.test_environment_forbidden_variables):
3407         (WaylandDriverTest.test_environment_optional_variables):
3408         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
3409         (WaylandDriver.check_driver):
3410         (WaylandDriver._setup_environ_for_test):
3411         * Scripts/webkitpy/port/xorgdriver.py:
3412         (XorgDriver.check_driver):
3413         (XorgDriver._setup_environ_for_test):
3414         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
3415         (XorgDriverTest):
3416         (XorgDriverTest.make_driver):
3417         (XorgDriverTest.make_environment):
3418         (XorgDriverTest.test_checkdriver):
3419         (XorgDriverTest.test_environment_needed_variables):
3420         (XorgDriverTest.test_environment_forbidden_variables):
3421         (XorgDriverTest.test_environment_optional_variables):
3422         * Scripts/webkitpy/port/xvfbdriver.py:
3423         (XvfbDriver._setup_environ_for_test):
3424         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3425         (XvfbDriverTest.assertDriverStartSuccessful):
3426
3427
3428 2017-05-14 Frederic Wang  <fwang@igalia.com>
3429
3430         Add heuristic to avoid flattening "fullscreen" iframes
3431         https://bugs.webkit.org/show_bug.cgi?id=171914
3432
3433         Reviewed by Simon Fraser.
3434
3435         * DumpRenderTree/mac/DumpRenderTree.mm:
3436         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
3437
3438 2017-06-18  Chris Dumez  <cdumez@apple.com>
3439
3440         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
3441         https://bugs.webkit.org/show_bug.cgi?id=173522
3442         <rdar://problem/31185739>
3443
3444         Reviewed by Darin Adler.
3445
3446         Add API test for re-entering Function's assignment operators.
3447
3448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3449         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
3450         (TestWebKitAPI::TestObject::TestObject):
3451         (TestWebKitAPI::TestObject::~TestObject):
3452         (TestWebKitAPI::TestObject::operator()):
3453         (TestWebKitAPI::TEST):
3454
3455 2017-06-16  Dan Bernstein  <mitz@apple.com>
3456
3457         [Cocoa] Some declarations have missing or incorrect availability attributes
3458         https://bugs.webkit.org/show_bug.cgi?id=173508
3459
3460         Reviewed by Tim Horton.
3461
3462         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3463         (TestWebKitAPI::TEST): Updated for renames.
3464
3465 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3466
3467         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3468         https://bugs.webkit.org/show_bug.cgi?id=173366
3469         <rdar://problem/32767014>
3470
3471         Reviewed by Tim Horton.
3472
3473         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
3474         change in behavior.
3475
3476         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3478         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
3479         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
3480         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
3481         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
3482         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
3483         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
3484         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
3485         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
3486         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
3487         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
3488         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
3489         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
3490         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3491         (-[MockDragDropSession initWithItems:location:window:]):
3492         (-[MockDragDropSession allowsMoveOperation]):
3493         (-[MockDragDropSession isRestrictedToDraggingApplication]):
3494         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
3495         (-[MockDragDropSession canLoadObjectsOfClass:]):
3496         (-[MockDragDropSession canLoadObjectsOfClasses:]):
3497         (-[MockDragDropSession items]):
3498         (-[MockDragDropSession setItems:]):
3499         (-[MockDragDropSession locationInView:]):
3500         (-[MockDataOperationSession initWithProviders:location:window:]):
3501         (-[MockDataOperationSession session]):
3502         (-[MockDataOperationSession isLocal]):
3503         (-[MockDataOperationSession progress]):
3504         (-[MockDataOperationSession setProgressIndicatorStyle:]):
3505         (-[MockDataOperationSession progressIndicatorStyle]):
3506         (-[MockDataOperationSession operationMask]):
3507         (-[MockDataOperationSession localDragSession]):
3508         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
3509         (-[MockDataOperationSession canCreateItemsOfClass:]):
3510         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
3511         (-[MockDataInteractionSession initWithWindow:]):
3512         (-[MockDataInteractionSession localOperationMask]):
3513         (-[MockDataInteractionSession externalOperationMask]):
3514         (-[MockDataInteractionSession session]):
3515         (-[DataInteractionSimulator _advanceProgress]):
3516
3517 2017-06-16  Alex Christensen  <achristensen@webkit.org>
3518
3519         Show punycode to user if a URL has dotless i or j followed by diacritic dot
3520         https://bugs.webkit.org/show_bug.cgi?id=173431
3521
3522         Reviewed by Darin Adler.
3523
3524         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3525         (TestWebKitAPI::TEST):
3526
3527 2017-06-16  Chris Dumez  <cdumez@apple.com>
3528
3529         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
3530         https://bugs.webkit.org/show_bug.cgi?id=173472
3531         <rdar://problem/28858817>
3532
3533         Reviewed by Brady Eidson.
3534
3535         Add API test coverage.
3536
3537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3538         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
3539         (TEST):
3540
3541 2017-06-16  Brady Eidson  <beidson@apple.com>
3542
3543         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
3544         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
3545
3546         Reviewed by Daniel Bates.
3547
3548         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
3549
3550 2017-06-16  Chris Dumez  <cdumez@apple.com>
3551
3552         DRT fails to reset page visibility between tests
3553         https://bugs.webkit.org/show_bug.cgi?id=173485
3554
3555         Reviewed by Alexey Proskuryakov.
3556
3557         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
3558         Fix this to address flakiness.
3559
3560         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
3561         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
3562         The test became flaky without the DRT change and was no longer flaky with the DRT
3563         change.
3564
3565         WebKitTestRunner already does this.
3566
3567         * DumpRenderTree/mac/DumpRenderTree.mm:
3568         (resetWebViewToConsistentStateBeforeTesting):
3569
3570 2017-06-16  Alex Christensen  <achristensen@webkit.org>
3571
3572         Implement basic authentication in MiniBrowser
3573         https://bugs.webkit.org/show_bug.cgi?id=173443
3574
3575         Reviewed by Tim Horton.
3576
3577         * MiniBrowser/mac/WK2BrowserWindowController.m:
3578         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3579
3580 2017-06-16  Jer Noble  <jer.noble@apple.com>
3581
3582         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3583         https://bugs.webkit.org/show_bug.cgi?id=173398
3584         <rdar://problem/32592961>
3585
3586         Reviewed by Eric Carlson.
3587
3588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3589         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
3590         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3591         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3592         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
3593         (TestWebKitAPI::TEST):
3594         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
3595
3596 2017-06-16  Matt Lewis  <jlewis3@apple.com>
3597
3598         Unreviewed, rolling out r218375.
3599
3600         The API test MediaStreamTrackDetached is still timing out
3601         after the patch
3602
3603         Reverted changeset:
3604
3605         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
3606         reports no recording to WebKit clients"
3607         https://bugs.webkit.org/show_bug.cgi?id=173398
3608         http://trac.webkit.org/changeset/218375
3609
3610 2017-06-15  Jer Noble  <jer.noble@apple.com>
3611
3612         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
3613       &nb