ac40dd8800e9c0c201e1224c753df03611ebbc5c
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2
3         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
4         https://bugs.webkit.org/show_bug.cgi?id=112622
5
6         Reviewed by Dirk Pranke.
7
8         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
9         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
10
11 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
12
13         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
14         https://bugs.webkit.org/show_bug.cgi?id=112619
15
16         Reviewed by Dirk Pranke.
17
18         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
19         directory and then fall back to the generic LayoutTests/platform/gtk directory.
20
21         * Scripts/webkitpy/layout_tests/port/gtk.py:
22         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
23         Port._webkit_baseline_path method.
24         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
25         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
26         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
27         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
28         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
29         that are expected based on the builder name.
30
31 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
32
33         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
34         https://bugs.webkit.org/show_bug.cgi?id=112571
35
36         Reviewed by Adam Barth.
37
38         Update function declarations for new WebFileSystemType enum. (All
39         changes are behind an #ifdef so we can sync required changes in embedders.)
40
41         * DumpRenderTree/chromium/WebViewHost.cpp:
42         (WebViewHost::openFileSystem):
43         (WebViewHost::deleteFileSystem):
44         * DumpRenderTree/chromium/WebViewHost.h:
45         (WebViewHost):
46
47 2013-03-18  Julie Parent  <jparent@chromium.org>
48
49         Cleanup: Move timeline_exporer js out of html file into js.
50         https://bugs.webkit.org/show_bug.cgi?id=112188
51
52         Reviewed by Dirk Pranke.
53         
54         Moves the javascript out of the html file and into a new js file.
55         This follows the format of flakiness_dashboard.{html|js}.
56         
57         Also moves code from dashboard_base that is used only by this one
58         dashboard, and makes it private to the dashboard.
59
60         * TestResultServer/static-dashboards/dashboard_base.js:
61         * TestResultServer/static-dashboards/timeline_explorer.html:
62         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
63         (generatePage):
64         (initCurrentBuilderTestResults):
65         (shouldShowWebKitRevisionsOnly):
66         (updateTimelineForBuilder.):
67         (updateTimelineForBuilder):
68         (selectBuild):
69         (updateBuildIndicator):
70         (.addRow):
71         (.addNumberRow):
72         (.inspectorNode.getElementsByTagName.0.onclick):
73         (.inspectorNode.getElementsByTagName.1.onclick):
74         (.inspectorNode.getElementsByTagName.2.onclick):
75         (updateBuildInspector):
76         (showResultsDelta):
77         (decompressResults.addFlakyDelta):
78         (decompressResults):
79
80 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
81
82         Unreviewed, rolling out r145272.
83         http://trac.webkit.org/changeset/145272
84         https://bugs.webkit.org/show_bug.cgi?id=111884
85
86         Turns out the ASAN build is still broken; possibly there's
87         something still setting LD_LIBRARY_PATH, or possibly there's
88         something else wrong. In the meantime, we need it to work again.
89
90         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
91
92 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
93
94         delete-stale-build-files is too aggressive
95         https://bugs.webkit.org/show_bug.cgi?id=112595
96
97         Reviewed by Tim Horton.
98
99         It appears that whitelisting file extensions to keep is not a good idea.
100         Blacklist files to delete instead, and only delete .o files for now.
101         We can add more file extensions as needed.
102
103         * BuildSlaveSupport/delete-stale-build-files:
104
105 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
106
107         Disable accessibility notifications after each test
108         https://bugs.webkit.org/show_bug.cgi?id=112579
109
110         Reviewed by Tim Horton.
111         
112         In WebKitTestRunner, if any tests triggered accessibility notifications,
113         the global notification handler would thereafter be active, and fire
114         notifications for all subsequent tests.
115         
116         Fix by implementing AccessibilityController::resetToConsistentState() for
117         Mac, and using it to clear the global notification handler.
118
119         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
120         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
121         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
122         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
123         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
124         (e.g. because of -autorelease).
125         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
126         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
127         if there is one.
128         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
129         Add -stopObserving
130         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
131         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
132         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
133         center.
134
135 2013-03-18  Dana Jansens  <danakj@chromium.org>
136
137         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
138         https://bugs.webkit.org/show_bug.cgi?id=112392
139
140         Reviewed by James Robinson.
141
142         Removes the command line flag option from DRT.
143
144         * DumpRenderTree/chromium/DumpRenderTree.cpp:
145         (main):
146
147 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
148
149         [GTK] plugins/plugin-clip-subframe.html is failing
150         https://bugs.webkit.org/show_bug.cgi?id=112570
151
152         Reviewed by Martin Robinson.
153
154         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
155
156 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
157
158         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
159         https://bugs.webkit.org/show_bug.cgi?id=112442
160
161         Reviewed by Gustavo Noronha Silva.
162
163         * GtkLauncher/main.c:
164         (reloadCb):
165         (createToolbar):
166         (createWindow):
167
168 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
169
170         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
171         https://bugs.webkit.org/show_bug.cgi?id=112205
172
173         Disable this API test until Geoff can fix it.
174
175         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
176         (TestWebKitAPI::TEST):
177
178 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
179
180         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
181         https://bugs.webkit.org/show_bug.cgi?id=112478
182
183         Reviewed by Tony Chang.
184
185         There is nothing that ensures that the log messages from the plugin
186         come in before the layout test finished loading.
187
188         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
189         (PassDifferentNPPStruct::NPP_SetWindow):
190         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
191         (NPP_SetWindow):
192
193 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
194
195         Have the mac port support per_test_timeout in webkitpy
196         https://bugs.webkit.org/show_bug.cgi?id=112466
197
198         Reviewed by Dirk Pranke.
199         
200         Both WTR and DRT handle --timeout arguments, so we can
201         have the scripts pass the timeout values down to the tools.
202
203         * Scripts/webkitpy/layout_tests/port/mac.py:
204         (MacPort.supports_per_test_timeout):
205
206 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
207
208         Remove setAsynchronousSpellCheckingEnabled from test runners
209         https://bugs.webkit.org/show_bug.cgi?id=112362
210
211         Reviewed by Tony Chang.
212
213         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
214         in internals.settings, so all ports can share it.
215
216         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
217         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
218         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
219         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
220         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
221         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
222         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
223         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
224         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
225         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
226         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
227         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
228
229 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
230
231         Fix the stupid unit tests.
232
233         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
234         (test_sample_process):
235
236 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
237
238         Collect samples for unresponsive web processes
239         https://bugs.webkit.org/show_bug.cgi?id=112409
240
241         Reviewed by Tim Horton.
242         
243         When we detect that a subprocess was unresponsive, run the 'sample'
244         tool on that process, for the Mac port.
245         
246         The sample will be linked to from the results.html page, next
247         to the crash log link.
248
249         * Scripts/webkitpy/layout_tests/controllers/manager.py:
250         (Manager._look_for_new_crash_logs): Before looking for crash logs,
251         look for samples on disk.
252         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
253         (TestResultWriter):
254         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
255         -sample.txt files, and have it copy their contents to a new file
256         next to the test that spawned them (as we do for crash logs).
257         * Scripts/webkitpy/layout_tests/port/base.py:
258         (Port.look_for_new_samples): Base class does nothing for sampling.
259         * Scripts/webkitpy/layout_tests/port/driver.py:
260         (Driver._check_for_driver_crash): Kick off a sample if we detected
261         that the subprocess was unresponsive.
262         * Scripts/webkitpy/layout_tests/port/mac.py:
263         (MacPort.sample_file_path): Utility to generate the file path
264         to the generated sample files at the top level of layout-test-results.
265         (MacPort.look_for_new_crash_logs): Fix typo
266         (MacPort.look_for_new_samples): New function to find sample files.
267         (MacPort.sample_process): Use the utility function to get the file path.
268
269 2013-03-15  Zeno Albisser  <zeno@webkit.org>
270
271         [Qt] Remove simple getters and setters from TestRunnerQt
272         https://bugs.webkit.org/show_bug.cgi?id=112343
273
274         Reviewed by Benjamin Poulain.
275
276         The removed functions and boolean members
277         are being replaced by the implementations in the
278         generic TestRunner.h.
279
280         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
281         (DumpRenderTree::dumpFrameScrollPosition):
282         (DumpRenderTree::dumpFramesAsText):
283         (DumpRenderTree::dump):
284         (DumpRenderTree::titleChanged):
285         (DumpRenderTree::dumpDatabaseQuota):
286         (DumpRenderTree::dumpApplicationCacheQuota):
287         (DumpRenderTree::statusBarMessage):
288         (DumpRenderTree::createWindow):
289         * DumpRenderTree/qt/TestRunnerQt.cpp:
290         (TestRunnerQt::reset):
291         * DumpRenderTree/qt/TestRunnerQt.h:
292         (TestRunnerQt):
293
294 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
295
296         Update the link on build.webkit.org to refer to perf.webkit.org
297         https://bugs.webkit.org/show_bug.cgi?id=112416
298
299         Reviewed by Philip Rogers.
300
301         Updated the link. Also updated the template to use HTML5 DOCTYPE.
302
303         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
304
305 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
306
307         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
308         https://bugs.webkit.org/show_bug.cgi?id=112394
309
310         Reviewed by Philippe Normand.
311
312         * GtkLauncher/main.c:
313         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
314
315 2013-03-14  Andreas Kling  <akling@apple.com>
316
317         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
318         <http://webkit.org/b/111815>
319         <rdar://problem/13380145>
320
321         Reviewed by Anders Carlsson.
322
323         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
324         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
325         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
326
327         * WebKitTestRunner/PlatformWebView.h:
328         (PlatformWebView):
329         * WebKitTestRunner/TestController.cpp:
330         (WTR::TestController::createOtherPage):
331         (WTR::TestController::createWebViewWithOptions):
332         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
333         (WTR::PlatformWebView::didInitializeClients):
334
335 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
336
337         [EFL][MiniBrowser] Add a search field to the MiniBrowser
338         https://bugs.webkit.org/show_bug.cgi?id=112122
339
340         Reviewed by Kenneth Rohde Christiansen.
341
342         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
343
344         * MiniBrowser/efl/main.c:
345         (_Browser_Window):
346         (search_box_show):
347         (search_box_hide):
348         (on_key_down):
349         (on_url_changed):
350         (on_search_field_aborted):
351         (on_search_field_activated):
352         (on_search_field_clicked):
353         (on_search_backward_button_clicked):
354         (on_search_forward_button_clicked):
355         (window_create):
356
357 2013-03-14  Julie Parent  <jparent@chromium.org>
358
359         Cleanup: Remove g_resourceLoader.
360         https://bugs.webkit.org/show_bug.cgi?id=112305
361
362         Reviewed by Dirk Pranke.
363         
364         Removing another global.
365         
366         Now, each dashboard creates its own loader, rather than having
367         a general global one.
368         
369         Remove usage of g_resourceLoader.isLoadingComplete from 
370         handleLocationChange by ensuring that handleLocationChange is
371         never called before the loader is done.  It was called in two
372         places before: 1 was from the callback when the loader is done,
373         so that was obviously true, and the other was from onhashchange,
374         where it would just return rather than running.  Instead, lets
375         only register the onhashchange handler once the loader is
376         setup, so the check is no longer necessary.
377         
378         Remove isLoadingComplete since it is now unused.
379         
380         Callback for loader is now initializeHistory, rather than just
381         handleLocationChange which will set up the hashchange handler now.
382         This will all eventually be moving to a new History object.
383
384         * TestResultServer/static-dashboards/aggregate_results.html:
385         * TestResultServer/static-dashboards/dashboard_base.js:
386         (handleLocationChange):
387         (intializeHistory):
388         (decompressResults):
389         * TestResultServer/static-dashboards/flakiness_dashboard.js:
390         (generatePage):
391         * TestResultServer/static-dashboards/loader.js:
392         (.):
393         * TestResultServer/static-dashboards/loader_unittests.js:
394         * TestResultServer/static-dashboards/timeline_explorer.html:
395         * TestResultServer/static-dashboards/treemap.html:
396
397 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
398
399         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
400         https://bugs.webkit.org/show_bug.cgi?id=109404
401
402         Reviewed by Tony Chang.
403
404         Removes all the code related to smartInsertDeleteEnabled and
405         selectTrailingWhitespaceEnabled settings as they will be managed from
406         internals from now on.
407
408         * DumpRenderTree/TestRunner.cpp:
409         (TestRunner::staticFunctions):
410         * DumpRenderTree/TestRunner.h:
411         (TestRunner):
412         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
413         (WebKit):
414         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
415         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
416         (DumpRenderTree):
417         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
418         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
419         (WebTestRunner::WebTestProxy::didStopLoading):
420         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
421         (WebTestRunner::TestRunner::TestRunner):
422         (WebTestRunner::TestRunner::reset):
423         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
424         (TestRunner):
425         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
426         (WebTestRunner::WebPreferences::applyTo): Set default values for
427         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
428         Chromium DRT default values are different from Chromium browser.
429         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
430         * DumpRenderTree/chromium/WebViewHost.cpp:
431         * DumpRenderTree/chromium/WebViewHost.h:
432         (WebViewHost):
433         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
434         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
435         * DumpRenderTree/efl/TestRunnerEfl.cpp:
436         * DumpRenderTree/gtk/DumpRenderTree.cpp:
437         (resetDefaultsToConsistentValues):
438         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
439         * DumpRenderTree/mac/DumpRenderTree.mm:
440         (resetWebViewToConsistentStateBeforeTesting):
441         * DumpRenderTree/mac/TestRunnerMac.mm:
442         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
443         (WebCore::WebPage::resetSettings):
444         * DumpRenderTree/qt/TestRunnerQt.cpp:
445         * DumpRenderTree/qt/TestRunnerQt.h:
446         (TestRunnerQt):
447         * DumpRenderTree/win/DumpRenderTree.cpp:
448         (resetWebViewToConsistentStateBeforeTesting):
449         * DumpRenderTree/win/TestRunnerWin.cpp:
450         * DumpRenderTree/wx/TestRunnerWx.cpp:
451
452 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
453
454         [Qt] Disable DRT on Windows
455
456         Reviewed by Jocelyn Turcotte.
457
458         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
459
460         * qmake/mkspecs/features/configure.prf:
461
462 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
463
464         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
465         https://bugs.webkit.org/show_bug.cgi?id=110728
466
467         Reviewed by Gyuyoung Kim.
468
469         Use the page group to create the view object.
470
471         * MiniBrowser/efl/main.c:
472         (window_create):
473
474 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
475
476         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
477
478         Reviewed by Tor Arne Vestbø.
479
480         The mock versions of these web facing features should be instantiated when
481         running in DumpRenderTree only. In order for them to work, no extra Qt modules
482         such as QtLocation are actually needed.
483
484         This patch decouples enabling device orientation/motion and geolocation from
485         the underlying Qt modules and makes them available in developer builds
486         (!production_build) and backed by mock backends when running in drt.
487
488         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
489         developers the web facing features are always enabled (although requests will
490         time out) and the mock backends are enabled inside DRT, allowing for the layout
491         tests to run with less dependencies.
492
493         In addition this also enables the mock device motion client, which was
494         previously never instantiated.
495
496         * qmake/mkspecs/features/features.prf:
497
498 2013-03-14  Zeno Albisser  <zeno@webkit.org>
499
500         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
501         https://bugs.webkit.org/show_bug.cgi?id=112340
502
503         Reviewed by Simon Hausmann.
504
505         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
506         (DumpRenderTree::dump):
507             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
508         (DumpRenderTree::dumpApplicationCacheQuota):
509         * DumpRenderTree/qt/TestRunnerQt.cpp:
510         (TestRunnerQt::reset):
511         * DumpRenderTree/qt/TestRunnerQt.h:
512         (TestRunnerQt):
513
514 2013-03-14  Zeno Albisser  <zeno@webkit.org>
515
516         [Qt] Port DRT to use TestRunner::dumpAsText()
517         https://bugs.webkit.org/show_bug.cgi?id=112260
518
519         Reviewed by Benjamin Poulain.
520
521         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
522         (WebCore::DumpRenderTree::open):
523         (WebCore::methodNameStringForFailedTest):
524             Change parameter from type TestRunnerQt* to TestRunner*.
525         (WebCore::DumpRenderTree::dump):
526             TestRunnerQt::shouldDumpPixels() always returned true in our case.
527             Instead we should rely on TestRunner::generatePixelResults().
528         * DumpRenderTree/qt/TestRunnerQt.cpp:
529         (TestRunnerQt::reset):
530         * DumpRenderTree/qt/TestRunnerQt.h:
531         (TestRunnerQt):
532
533 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
534
535         Implement FontLoader interface
536         https://bugs.webkit.org/show_bug.cgi?id=98395
537
538         Reviewed by Eric Seidel.
539
540         Enable FontLoadEvents runtime flag for TestShell.
541
542         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
543         (WebTestRunner::TestInterfaces::TestInterfaces):
544
545 2013-03-13  Julie Parent  <jparent@chromium.org>
546
547         CLeanup: remove unnecessary call to parseParameters.
548         https://bugs.webkit.org/show_bug.cgi?id=112309
549
550         Reviewed by Ojan Vafai.
551         
552         We call parseCrossDashboardParameters when the dashboard initially
553         loads to set the state required for loadBuildersList, and then we
554         call it again once we are fully done with loading, so there is no
555         reason to call it in the middle of the loading process here.
556
557         * TestResultServer/static-dashboards/loader.js:
558         (.):
559
560 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
561
562         Unreviewed. Now I'm a reviewer :)
563
564         * Scripts/webkitpy/common/config/committers.py:
565
566 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
567
568         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
569         https://bugs.webkit.org/show_bug.cgi?id=112277
570
571         Reviewed by Adam Barth.
572
573         * Scripts/webkitperl/FeatureList.pm:
574         * qmake/mkspecs/features/features.pri:
575
576 2013-03-13  Adam Barth  <abarth@webkit.org>
577
578         run-perf-tests should support content_shell
579         https://bugs.webkit.org/show_bug.cgi?id=112291
580
581         Reviewed by Eric Seidel.
582
583         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
584         (PerfTestsRunner._parse_args):
585
586 2013-03-13  Oliver Hunt  <oliver@apple.com>
587
588         Simplify Checked<> multiplication
589         https://bugs.webkit.org/show_bug.cgi?id=112286
590
591         Reviewed by James Robinson.
592
593         Add tests for multiplication by zero and max to ensure we don't
594         mess them up should we ever make changes to Checked<> in future.
595
596         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
597         (TestWebKitAPI):
598
599 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
600
601         [Qt] Unreviewed prospective Windows build fix
602
603         Do the usual thing, include the moc generated code in the .cpp file instead
604         of compiling it standalone, to ensure that config.h is included, too, and
605         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
606
607         * DumpRenderTree/qt/EventSenderQt.cpp:
608
609 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
610
611         [Qt] Port TestRunner::findString to shared interface
612         https://bugs.webkit.org/show_bug.cgi?id=112147
613
614         Reviewed by Jocelyn Turcotte.
615
616         This patch also removes DumpRenderTree and some other helper classes from
617         the WebCore namespace, to which they do not really belong.
618
619         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
620         (main):
621         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
622         (DumpRenderTree::DumpRenderTree):
623         (DumpRenderTree::~DumpRenderTree):
624         (DumpRenderTree::instance):
625         (DumpRenderTree::setShouldTimeout):
626         * DumpRenderTree/qt/DumpRenderTreeQt.h:
627         (DumpRenderTree):
628         * DumpRenderTree/qt/EventSenderQt.cpp:
629         (EventSender::contextClick):
630         (EventSender::sendEvent):
631         (EventSender::postEvent):
632         * DumpRenderTree/qt/EventSenderQt.h:
633         (EventSender::isGraphicsBased):
634         * DumpRenderTree/qt/TestRunnerQt.cpp:
635         (TestRunnerQt::TestRunnerQt):
636         (TestRunner::findString):
637         (TestRunnerQt::setMockDeviceOrientation):
638         (TestRunnerQt::setGeolocationPermission):
639         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
640         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
641         (TestRunnerQt::setMockGeolocationPosition):
642         * DumpRenderTree/qt/TestRunnerQt.h:
643         (TestRunnerQt):
644
645 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
646
647         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
648         https://bugs.webkit.org/show_bug.cgi?id=112129
649
650         Reviewed by Adam Barth.
651
652         Following Chromium
653         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
654         this is being renamed to better explain what it does.
655
656         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
657
658 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
659
660         [Qt] Unreviewed trivial typo fix
661
662         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
663         TextRunner.h. Thanks Zeno :)
664
665 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
666
667         [Qt] Prepare DRT for transition to shared TestRunner interface
668         https://bugs.webkit.org/show_bug.cgi?id=112144
669
670         Reviewed by Benjamin Poulain.
671
672         Prepare Qt's DRT for a transition from the QObject based TestRunner to
673         the JSC C API based one.
674
675         This is impplemented by instantiating the QObject based testRunner in
676         the global object, then instantiating the JSC C based TestRunner
677         separately and placing it "behind" the QObject based testRunner through
678         injection of the individual functions through proxies. (prototype
679         chaining doesn't work due to the this object and Function.prototype.bind
680         doesn't work due to the native function)
681
682         This allows for porting over method by method by removing the method
683         from the QObject TestRunnerQt and implementing it in the JSC C based
684         TestRunner.
685
686         In order for this to link and run dummy implementations of all the
687         necessary TestRunner functions are provided.
688
689         * DumpRenderTree/qt/DumpRenderTree.pro:
690         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
691         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
692         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
693         (WebCore::DumpRenderTree::initJSObjects):
694         * DumpRenderTree/qt/DumpRenderTreeQt.h:
695         (DumpRenderTree):
696         * DumpRenderTree/qt/TestRunnerQt.cpp:
697         (TestRunner::~TestRunner):
698         (TestRunner::addDisallowedURL):
699         (TestRunner::queueLoad):
700         (TestRunner::removeAllVisitedLinks):
701         (TestRunner::setAcceptsEditing):
702         (TestRunner::simulateLegacyWebNotificationClick):
703         (TestRunner::setWindowIsKey):
704         (TestRunner::setAlwaysAcceptCookies):
705         (TestRunner::addOriginAccessWhitelistEntry):
706         (TestRunner::setWebViewEditable):
707         (TestRunner::clearAllApplicationCaches):
708         (TestRunner::setTextDirection):
709         (TestRunner::notifyDone):
710         (TestRunner::numberOfPendingGeolocationPermissionRequests):
711         (TestRunner::overridePreference):
712         (TestRunner::pathToLocalResource):
713         (TestRunner::removeAllWebNotificationPermissions):
714         (TestRunner::simulateWebNotificationClick):
715         (TestRunner::closeIdleLocalStorageDatabases):
716         (TestRunner::focusWebView):
717         (TestRunner::setBackingScaleFactor):
718         (TestRunner::removeChromeInputField):
719         (TestRunner::addChromeInputField):
720         (TestRunner::originsWithLocalStorage):
721         (TestRunner::deleteAllLocalStorage):
722         (TestRunner::deleteLocalStorageForOrigin):
723         (TestRunner::observeStorageTrackerNotifications):
724         (TestRunner::syncLocalStorage):
725         (TestRunner::windowCount):
726         (TestRunner::setWaitToDump):
727         (TestRunner::waitForPolicyDelegate):
728         (TestRunner::webHistoryItemCount):
729         (TestRunner::showWebInspector):
730         (TestRunner::closeWebInspector):
731         (TestRunner::evaluateInWebInspector):
732         (TestRunner::setSerializeHTTPLoads):
733         (TestRunner::apiTestNewWindowDataLoadBaseURL):
734         (TestRunner::setCustomPolicyDelegate):
735         (TestRunner::setDatabaseQuota):
736         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
737         (TestRunner::resetPageVisibility):
738         (TestRunner::keepWebHistory):
739         (TestRunner::goBack):
740         (TestRunner::originsWithApplicationCache):
741         (TestRunner::applicationCacheDiskUsageForOrigin):
742         (TestRunner::display):
743         (TestRunner::dispatchPendingLoadRequests):
744         (TestRunner::clearPersistentUserStyleSheet):
745         (TestRunner::callShouldCloseOnWebView):
746         (TestRunner::copyDecodedHostName):
747         (TestRunner::clearBackForwardList):
748         (TestRunner::clearAllDatabases):
749         (TestRunner::clearApplicationCacheForOrigin):
750         (TestRunner::apiTestGoToCurrentBackForwardItem):
751         (TestRunner::authenticateSession):
752         (TestRunner::abortModal):
753         (TestRunner::setStorageDatabaseIdleInterval):
754         (TestRunner::setAsynchronousSpellCheckingEnabled):
755         (TestRunner::setXSSAuditorEnabled):
756         (TestRunner::setSpatialNavigationEnabled):
757         (TestRunner::setScrollbarPolicy):
758         (TestRunner::setJavaScriptCanAccessClipboard):
759         (TestRunner::setAutomaticLinkDetectionEnabled):
760         (TestRunner::setUserStyleSheetEnabled):
761         (TestRunner::setUserStyleSheetLocation):
762         (TestRunner::setUseDashboardCompatibilityMode):
763         (TestRunner::setTabKeyCyclesThroughElements):
764         (TestRunner::setSmartInsertDeleteEnabled):
765         (TestRunner::setSelectTrailingWhitespaceEnabled):
766         (TestRunner::setPrivateBrowsingEnabled):
767         (TestRunner::setPluginsEnabled):
768         (TestRunner::setPopupBlockingEnabled):
769         (TestRunner::setMockSpeechInputDumpRect):
770         (TestRunner::setPersistentUserStyleSheetLocation):
771         (TestRunner::setMockGeolocationPosition):
772         (TestRunner::setMockGeolocationPositionUnavailableError):
773         (TestRunner::setMockDeviceOrientation):
774         (TestRunner::setMainFrameIsFirstResponder):
775         (TestRunner::setIconDatabaseEnabled):
776         (TestRunner::setGeolocationPermission):
777         (TestRunner::setDefersLoading):
778         (TestRunner::setCacheModel):
779         (TestRunner::setAuthorAndUserStylesEnabled):
780         (TestRunner::setAllowFileAccessFromFileURLs):
781         (TestRunner::setAppCacheMaximumSize):
782         (TestRunner::setAllowUniversalAccessFromFileURLs):
783         (TestRunner::setApplicationCacheOriginQuota):
784         (TestRunner::denyWebNotificationPermission):
785         (TestRunner::grantWebNotificationPermission):
786         (TestRunner::setValueForUser):
787         (TestRunner::setViewModeMediaFeature):
788         (TestRunner::setPageVisibility):
789         (TestRunner::addMockSpeechInputResult):
790         (TestRunner::removeOriginAccessWhitelistEntry):
791         (TestRunner::addUserScript):
792         (TestRunner::isCommandEnabled):
793         (TestRunner::evaluateScriptInIsolatedWorld):
794         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
795         (TestRunner::copyEncodedHostName):
796         (TestRunner::addUserStyleSheet):
797         (TestRunner::findString):
798         (TestRunner::execCommand):
799         (TestRunner::localStorageDiskUsageForOrigin):
800
801 2013-03-12  Julie Parent  <jparent@chromium.org>
802
803         Cleanup: Move flatten-trie to loader.
804         https://bugs.webkit.org/show_bug.cgi?id=112196
805
806         Reviewed by Dirk Pranke.
807
808         flatten-trie is used only by the loader, so move it there and make it
809         private, rather than global in dashbaord_base. Moved the corresponding
810         unit test from flakiness_dashboard_unittests to loader_unittests.
811         
812         * TestResultServer/static-dashboards/dashboard_base.js:
813         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
814         * TestResultServer/static-dashboards/loader.js:
815         (.):
816         * TestResultServer/static-dashboards/loader_unittests.js:
817
818 2013-03-12  Oliver Hunt  <oliver@apple.com>
819
820         Unbreak api tests
821
822         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
823         (TestWebKitAPI):
824
825 2013-03-12  Tim Horton  <timothy_horton@apple.com>
826
827         Unreviewed, disabling tests for Win EWS.
828
829         win-ews obviously cannot keep up with running tests, it's >300 behind.
830         Probably doesn't help that its (likely) running tests serially.
831
832         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
833         (WinEWS):
834
835 2013-03-12  Tim Horton  <timothy_horton@apple.com>
836
837         Add a --build-directory argument to delete-stale-build-files
838         https://bugs.webkit.org/show_bug.cgi?id=112198
839
840         Reviewed by Ryosuke Niwa.
841
842         * BuildSlaveSupport/delete-stale-build-files:
843         (main): Add --build-directory argument.
844
845 2013-03-12  Oliver Hunt  <oliver@apple.com>
846
847         Appease MSVC
848
849         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
850         (TestWebKitAPI):
851
852 2013-03-12  Oliver Hunt  <oliver@apple.com>
853
854         Add more Checked<> tests
855         https://bugs.webkit.org/show_bug.cgi?id=112190
856
857         Reviewed by Geoffrey Garen.
858
859         Tests!
860
861         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
862         (TestWebKitAPI):
863
864 2013-03-12  Julie Parent  <jparent@chromium.org>
865
866         Cleanup: Move loading complete function into callback, rather than global.
867         https://bugs.webkit.org/show_bug.cgi?id=112167
868
869         Reviewed by Dirk Pranke.
870         
871         Stop calling global functions, pass in proper handler to Loader
872         constructor. Note that the callback is optional, as tests, and
873         some potential dashboards, do not need one.
874
875         * TestResultServer/static-dashboards/dashboard_base.js:
876         * TestResultServer/static-dashboards/loader.js:
877         (.):
878         * TestResultServer/static-dashboards/loader_unittests.js:
879
880 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
881
882         [EFL][WK2] Add popup menu support to MiniBrowser
883         https://bugs.webkit.org/show_bug.cgi?id=108934
884
885         Reviewed by Kenneth Rohde Christiansen.
886
887         Implement popup menu support in MiniBrowser by handling popup_menu_show
888         and popup_menu_hide smart functions on the view and using the Ewk popup
889         menu API.
890
891         * MiniBrowser/efl/main.c:
892         (_Browser_Window):
893         (on_popup_menu_discarded):
894         (on_popup_menu_item_clicked):
895         (popup_menu_populate):
896         (on_popup_menu_show):
897         (on_popup_menu_hide):
898         (window_create): Use calloc() instead of malloc() to allocate memory for
899         Browser_Window. This makes sure all the structs members are initialized
900         to 0 (such as the new elm_popup_menu pointer).
901
902 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
903
904         [GTK] Set up the libPlatformGtk.la library
905         https://bugs.webkit.org/show_bug.cgi?id=111738
906
907         Reviewed by Martin Robinson.
908
909         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
910         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
911         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
912
913 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
914
915         [GTK] Enable Web Audio in development builds
916         https://bugs.webkit.org/show_bug.cgi?id=111831
917
918         Reviewed by Philippe Normand.
919
920         Web Audio is already quite well supported on the GTK port but still has a few issues
921         that must be addressed before it is enabled by default. Despite that it should be enabled
922         in development builds just so we are up-to-date with future feature infrastructure changes.
923         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
924         that's an obvious goal before enabling the feature in release builds.
925
926         * Scripts/webkitperl/FeatureList.pm:
927
928 2013-03-11  Andreas Kling  <akling@apple.com>
929
930         [Mac][WK1] Add support for alert() in MiniBrowser.
931         <http://webkit.org/b/112090>
932
933         Reviewed by Anders Carlsson.
934
935         * MiniBrowser/mac/WK1BrowserWindowController.m:
936         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
937
938 2013-03-11  Julie Parent  <jparent@chromium.org>
939
940         Dashboard cleanup: Create ui.Errors
941         https://bugs.webkit.org/show_bug.cgi?id=111785
942
943         Reviewed by Ojan Vafai.
944         
945         Create ui.Errors for handling errors the dashboards
946         encounter. Loader now has a Error object that it can add to,
947         and individual dashboards can show errors when desired.
948         Currently, only flakiness_db shows errors, but this is 
949         generic and there is no reason why other dbs wouldn't want to
950         show errors.
951
952         * TestResultServer/static-dashboards/dashboard_base.js:
953         (resourceLoadingComplete):
954         * TestResultServer/static-dashboards/flakiness_dashboard.js:
955         (generatePage):
956         * TestResultServer/static-dashboards/loader.js:
957         (.):
958         * TestResultServer/static-dashboards/ui.js:
959         (.):
960
961 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
962
963         Some StringHasher tests are broken because of missing null termination
964         https://bugs.webkit.org/show_bug.cgi?id=111284
965
966         Reviewed by Darin Adler.
967
968         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
969         (TestWebKitAPI): Added null termination since C strings are null-terminated.
970         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
971         the bug caught by it is now fixed.
972
973 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
974
975         Unreviewed, rolling out r145200.
976         http://trac.webkit.org/changeset/145200
977         https://bugs.webkit.org/show_bug.cgi?id=112063
978
979         Broke a couple of unit tests (Requested by zdobersek on
980         #webkit).
981
982         * Scripts/webkitperl/FeatureList.pm:
983
984 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
985
986         [GTK] WebKit2-only build fails
987         https://bugs.webkit.org/show_bug.cgi?id=112033
988
989         Reviewed by Gustavo Noronha Silva.
990
991         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
992         generic part, WebKit1-specific part and WebKit2-specific part.
993         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
994         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
995         directly.
996
997 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
998
999         Adding myself to the committers list.
1000
1001         Unreviewed.
1002
1003         * Scripts/webkitpy/common/config/committers.py:
1004
1005 2013-03-11  Jeff Rogers  <jrogers@rim.com>
1006
1007         [BlackBerry] Disable MathML support
1008         https://bugs.webkit.org/show_bug.cgi?id=111929
1009
1010         Reviewed by Rob Buis.
1011
1012         * Scripts/webkitperl/FeatureList.pm:
1013
1014 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1015
1016         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
1017         https://bugs.webkit.org/show_bug.cgi?id=111970
1018
1019         Reviewed by Chris Fleizach.
1020
1021         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
1022         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
1023         undefined symbol.
1024
1025         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1026         (WTR::AccessibilityUIElement::supportedActions):
1027         (WTR):
1028
1029 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
1030
1031         [chromium] Android apk targets should depend directly on Java library targets
1032         https://bugs.webkit.org/show_bug.cgi?id=111746
1033
1034         Reviewed by Eric Seidel.
1035
1036         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1037         Make DumpRenderTree_apk depend directly on base_java and net_java.
1038         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1039         Make TestWebKitAPI_apk depend directly on base_java.
1040
1041 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
1042
1043         [chromium] remove obsolete user gesture methods from WebFrame
1044         https://bugs.webkit.org/show_bug.cgi?id=111696
1045
1046         Reviewed by Adam Barth.
1047
1048         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
1049         (WebTestRunner::TestPlugin::handleInputEvent):
1050         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1051
1052 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
1053
1054         Unreviewed, add myself to commiters.py.
1055
1056         * Scripts/webkitpy/common/config/committers.py:
1057
1058 2013-03-08  Julie Parent  <jparent@chromium.org>
1059
1060         Cleanup: Remove dead code.
1061         https://bugs.webkit.org/show_bug.cgi?id=111900
1062
1063         Reviewed by Dirk Pranke.
1064         
1065         Treemap overrides a global function that used to be in 
1066         dashboard_base, but was removed months ago in
1067         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
1068         no caller. 
1069
1070         * TestResultServer/static-dashboards/treemap.html:
1071
1072 2013-03-08  Harald Alvestrand  <hta@chromium.org>
1073
1074         Implemented new API for RTCStatsReport object.
1075         https://bugs.webkit.org/show_bug.cgi?id=110333
1076
1077         Reviewed by Adam Barth.
1078
1079         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
1080         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
1081
1082 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
1083
1084         [chromium] use custom freetype on linux asan builds again
1085         https://bugs.webkit.org/show_bug.cgi?id=111884
1086
1087         Reviewed by Tony Chang.
1088
1089         We no longer need the workaround after chromium r186540.
1090
1091         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1092
1093 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
1094
1095         Warning about the user not having edit rights on Bugzilla is confusing new contributors
1096         https://bugs.webkit.org/show_bug.cgi?id=111798
1097
1098         Reviewed by Dirk Pranke.
1099
1100         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
1101
1102         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1103
1104 2013-03-08  James Robinson  <jamesr@chromium.org>
1105
1106         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
1107         https://bugs.webkit.org/show_bug.cgi?id=111632
1108
1109         Reviewed by Adrienne Walker.
1110
1111         * DumpRenderTree/chromium/WebViewHost.cpp:
1112         (WebViewHost::initializeLayerTreeView):
1113         * DumpRenderTree/chromium/WebViewHost.h:
1114         (WebViewHost):
1115
1116 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
1117
1118         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
1119         https://bugs.webkit.org/show_bug.cgi?id=111297
1120
1121         Reviewed by Kenneth Rohde Christiansen.
1122
1123         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1124         (WTR::TestRunner::setViewModeMediaFeature):
1125
1126 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
1127
1128         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
1129         https://bugs.webkit.org/show_bug.cgi?id=111814
1130
1131         Reviewed by Ryosuke Niwa.
1132
1133         Add the needed supportedActions() attribute to WKTestRunner.
1134
1135         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1136         (WTR::AccessibilityUIElement::supportedActions):
1137         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1138         (AccessibilityUIElement):
1139         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1140         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1141         (WTR::AccessibilityUIElement::supportedActions):
1142
1143 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1144
1145         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
1146         https://bugs.webkit.org/show_bug.cgi?id=111851
1147
1148         Reviewed by Kenneth Rohde Christiansen.
1149
1150         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1151         (TestWebKitAPI::TEST):
1152
1153             Fixed WKURLRef instance leaking.
1154
1155 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1156
1157         [EFL] [WK2] Some authentication tests fail in WebKit2
1158         https://bugs.webkit.org/show_bug.cgi?id=106407
1159
1160         Reviewed by Kenneth Rohde Christiansen.
1161
1162         Add patch from upstream for libsoup 2.40 to fix several authentication
1163         test cases.
1164
1165         * efl/jhbuild.modules:
1166         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
1167
1168 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
1169
1170         [GTK] Enable Web Audio in development builds
1171         https://bugs.webkit.org/show_bug.cgi?id=111831
1172
1173         Reviewed by Philippe Normand.
1174
1175         Web Audio is already quite well supported on the GTK port but still has a few issues
1176         that must be addressed before it is enabled by default. Despite that it should be enabled
1177         in development builds just so we are up-to-date with future feature infrastructure changes.
1178         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
1179         that's an obvious goal before enabling the feature in release builds.
1180
1181         * Scripts/webkitperl/FeatureList.pm:
1182
1183 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
1184
1185         [chromium] delay clearing the TestRunners until the main view was deleted
1186         https://bugs.webkit.org/show_bug.cgi?id=111823
1187
1188         Reviewed by Eric Seidel.
1189
1190         During WebViewHost::shutdown, we navigate the WebView to about:blank.
1191         This may call into the test runners which assume that the delegate is
1192         always non-NULL.
1193
1194         * DumpRenderTree/chromium/TestShell.cpp:
1195         (TestShell::~TestShell):
1196
1197 2013-03-07  Alan Cutter  <alancutter@chromium.org>
1198
1199         Sheriffbot whois command can't search by full name
1200         https://bugs.webkit.org/show_bug.cgi?id=111825
1201
1202         Reviewed by Eric Seidel.
1203
1204         Allowed multiple arguments to Sheriffbot's whois command.
1205         Updated test expectations.
1206
1207         * Scripts/webkitpy/tool/bot/irc_command.py:
1208         (Whois.execute):
1209         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1210         (IRCCommandTest.test_whois):
1211
1212 2013-03-07  Nils Barth  <nbarth@chromium.org>
1213
1214         Add Nils Barth and Koji Hara to committers.py
1215         https://bugs.webkit.org/show_bug.cgi?id=111806
1216
1217         Reviewed by Eric Seidel.
1218
1219         * Scripts/webkitpy/common/config/committers.py:
1220
1221 2013-03-07  Glenn Adams  <glenn@skynav.com>
1222
1223         run-pert-tests should have a --test-runner-count option
1224         https://bugs.webkit.org/show_bug.cgi?id=111726
1225
1226         Reviewed by Ryosuke Niwa.
1227
1228         Add --test-runner-count option to run-perf-tests, with default value of 4.
1229         This option allows command line configuration of the number of times to invoke
1230         the test runner (serially, not in parallel) when running a specific test in
1231         a test set.
1232
1233         * Scripts/webkitpy/performance_tests/perftest.py:
1234         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
1235         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
1236         (PerfTest.run): Rename process_run_count to test_runner_count.
1237         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
1238         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
1239         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
1240         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
1241         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1242         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
1243         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
1244         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1245         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
1246         (MainTest.test_run_with_repeat):
1247         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
1248         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1249         (MainTest.test_default_args): Add test for default option argument values.
1250         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
1251
1252 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
1253
1254         Add myself to reviewers.py
1255         https://bugs.webkit.org/show_bug.cgi?id=111757
1256
1257         Reviewed by Eric Seidel.
1258
1259         * Scripts/webkitpy/common/config/committers.py:
1260
1261 2013-03-07  Glenn Adams  <glenn@skynav.com>
1262
1263         run-perf-tests should have a --repeat option
1264         https://bugs.webkit.org/show_bug.cgi?id=100030
1265
1266         Reviewed by Ryosuke Niwa.
1267
1268         Add --repeat option to run-perf-tests, with default value of 1. When greater
1269         than 1, runs test set specified number of times. Note that multiple runs are
1270         not aggregated for statistical purposes.
1271
1272         Incidentally fixed typo: s/suceeds/succeeds/.
1273
1274         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1275         (PerfTestsRunner._parse_args): Add repeat option.
1276         (PerfTestsRunner.run): Add outer repeat loop.
1277         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
1278         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
1279         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1280         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
1281         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
1282         (MainTest.test_run_with_json_output): Fix typo.
1283         (MainTest.test_run_with_description): Fix typo.
1284         (MainTest.test_run_respects_no_results): Fix typo.
1285         (MainTest.test_run_with_slave_config_json): Fix typo.
1286         (MainTest.test_run_with_multiple_repositories): Fix typo.
1287         (MainTest.test_run_with_upload_json): Fix typo.
1288         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
1289         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
1290         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1291         (MainTest.test_parse_args): Add test for repeat option parsing.
1292
1293 2013-03-07  Julie Parent  <jparent@chromium.org>
1294
1295         showAllRuns checkbox no longer works on the stats dashboard
1296         https://bugs.webkit.org/show_bug.cgi?id=111673
1297
1298         Reviewed by Ojan Vafai.
1299
1300         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
1301         so we were trying to index into an undefined object.
1302         
1303         * TestResultServer/static-dashboards/dashboard_base.js:
1304         (invalidateQueryParameters):
1305
1306 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
1307
1308         [Chromium] Update #include for WebStorageNamespace.h
1309         https://bugs.webkit.org/show_bug.cgi?id=111748
1310
1311         Reviewed by Adam Barth.
1312
1313         In anticipation of removing
1314         WK/chromium/public/WebStorageNamespace.h (once downstream
1315         references have been updated)
1316
1317         * DumpRenderTree/chromium/WebViewHost.cpp:
1318
1319 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
1320
1321         run-perf-tests fails due to svn_revision not working on a pure git clone
1322         https://bugs.webkit.org/show_bug.cgi?id=110839
1323
1324         Reviewed by Ryosuke Niwa.
1325
1326         Previously we would call git svn find-rev to look up the commit for
1327         a given revision, and that'll hang in a pure git checkout.
1328
1329         This patch changes the way we look up svn revisions in a git
1330         repository to use git log --grep 'git-svn-id', which is much faster
1331         than grepping ourselves. It also renames timestamp_of_latest_commit()
1332         to timestamp_of_revision() in order to accurately reflect what
1333         the method is doing. Note that this patch only changes the logic
1334         inside latest_revision() and svn_revision(). I'll file a separate
1335         bug to change git_commit_from_svn_revision().
1336
1337         This patch also contains some fixes to unit tests that had bit-rotted
1338         or were otherwise fragile, so that test-webkitpy --all would pass
1339         cleanly, and a fix to outputcapture so that
1340         test-webkitpy -p would work correctly again.
1341
1342         * Scripts/webkitpy/common/checkout/scm/git.py:
1343         (Git.svn_revision):
1344         (Git.timestamp_of_revision):
1345         * Scripts/webkitpy/common/checkout/scm/scm.py:
1346         (SCM.svn_revision):
1347         (SCM.timestamp_of_revision):
1348         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1349         (MockSCM.timestamp_of_revision):
1350         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1351         (_shared_test_commit_with_message):
1352         (test_commit_without_authorization):
1353         (test_timestamp_of_revision):
1354         * Scripts/webkitpy/common/checkout/scm/svn.py:
1355         (SVN.timestamp_of_revision):
1356         * Scripts/webkitpy/common/system/outputcapture.py:
1357           Importing unittest2 directly may not be safe if this module is
1358           imported before the autoinstaller gets a chance to set things up
1359           properly. We don't actually need unittest2 here.
1360         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1361         (PerfTestsRunner._generate_results_dict):
1362
1363 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1364
1365         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
1366         https://bugs.webkit.org/show_bug.cgi?id=111756
1367
1368         Reviewed by Kenneth Rohde Christiansen.
1369
1370         Bump libsoup to v2.40.3 to fix the regressions introduced by
1371         previous v2.40.0 bump.
1372
1373         * efl/jhbuild.modules:
1374
1375 2013-03-07  Roger Fong  <roger_fong@apple.com>
1376
1377         Re-enable Win EWS tests.
1378
1379         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1380         (WinEWS):
1381
1382 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
1383
1384         [nrwt] handle corrupt http server pid files cleanly
1385         https://bugs.webkit.org/show_bug.cgi?id=111628
1386
1387         Reviewed by Eric Seidel.
1388
1389         If the pid file from a previous http server is corrupt for some
1390         reason, NRWT will just raise errors and not clean it up or recover.
1391         This patch fixes that to at least delete the pid file and
1392         not throw; not that we may still have stale http servers left on
1393         the system, since there's no way to know which pid to kill if
1394         the file was corrupted.
1395
1396         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1397         (HttpServerBase.start):
1398         (HttpServerBase.stop):
1399         (HttpServerBase._remove_pid_file):
1400         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
1401         (TestHttpServerBase):
1402         (TestHttpServerBase.test_corrupt_pid_file):
1403
1404 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
1405
1406         AX: Can't activate links with VoiceOver in Safari
1407         https://bugs.webkit.org/show_bug.cgi?id=111755
1408
1409         Reviewed by Tim Horton.
1410
1411         * DumpRenderTree/AccessibilityUIElement.cpp:
1412         (supportedActionsCallback):
1413         (AccessibilityUIElement::getJSClass):
1414         * DumpRenderTree/AccessibilityUIElement.h:
1415         (AccessibilityUIElement):
1416         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1417         (AccessibilityUIElement::supportedActions):
1418
1419 2013-03-07  Roger Fong  <roger_fong@apple.com>
1420
1421         Windows debug layout tests are crashing like crazy again.
1422         Disable tests on Win EWS bots temporarily.
1423
1424         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1425         (WinEWS):
1426
1427 2013-03-07  Roger Fong  <roger_fong@apple.com>
1428
1429         Make EWS bots build and test in release.
1430
1431         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1432         (WinEWS):
1433         * Scripts/webkitpy/tool/steps/runtests.py:
1434         (RunTests.run):
1435
1436 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
1437
1438         [chromium] don't track the top loading frame if no layout test is currently running
1439         https://bugs.webkit.org/show_bug.cgi?id=111716
1440
1441         Reviewed by Kentaro Hara.
1442
1443         In DRT, we synchronously stop the test and start loading the next test
1444         URL. However, in content_shell, this happens asynchronously. It's
1445         important that the top loading frame is not changed due to stray
1446         navigation events before the next test starts.
1447
1448         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1449         (WebTestRunner::TestRunner::setTopLoadingFrame):
1450
1451 2013-03-06  Julie Parent  <jparent@chromium.org>
1452
1453         Dashboard cleanup: Move all dashboard ui related code into ui.js.
1454         https://bugs.webkit.org/show_bug.cgi?id=111621
1455
1456         Reviewed by Ojan Vafai.
1457         
1458         Creates ui.js, a package for the common UI code the various
1459         dashboards use. HTML generation is now in the ui.html namespace
1460         and popup handling is in ui.popup.
1461         Also moves the event listening for popups to ui.popup.show and
1462         removes it on ui.popup.hid rather than having listener always
1463         around.
1464
1465         * TestResultServer/static-dashboards/aggregate_results.html:
1466         * TestResultServer/static-dashboards/dashboard_base.js:
1467         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1468         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1469         (showPopupForBuild):
1470         (htmlForNavBar):
1471         (generatePageForIndividualTests.if):
1472         (generatePageForIndividualTests):
1473         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
1474         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1475         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1476         * TestResultServer/static-dashboards/run-unittests.html:
1477         * TestResultServer/static-dashboards/timeline_explorer.html:
1478         * TestResultServer/static-dashboards/treemap.html:
1479         * TestResultServer/static-dashboards/ui.js: Added.
1480         (.):
1481
1482 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
1483
1484         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
1485         https://bugs.webkit.org/show_bug.cgi?id=110584
1486
1487         Reviewed by Gyuyoung Kim.
1488
1489         Adds missing implementation of AccessibilityControllerEfl
1490         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
1491         so that it can make accessibilityController as a js object.
1492
1493         * DumpRenderTree/AccessibilityController.h:
1494         (AccessibilityController):
1495         * DumpRenderTree/AccessibilityUIElement.h:
1496         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1497         (AccessibilityController::childElementById): Moved declaration to base class.
1498         Implementation can be shared among other ports.
1499         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
1500         (AccessibilityController::focusedElement):
1501         (AccessibilityController::rootElement):
1502         (AccessibilityController::accessibleElementById):
1503         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
1504         (AccessibilityUIElement::helpText):
1505         * DumpRenderTree/efl/CMakeLists.txt:
1506         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1507         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1508         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1509         (DumpRenderTreeChrome::onWindowObjectCleared):
1510         (DumpRenderTreeChrome::accessibilityController):
1511         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1512         (DumpRenderTreeChrome):
1513         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1514
1515 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
1516
1517         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
1518         https://bugs.webkit.org/show_bug.cgi?id=42696
1519
1520         Reviewed by Andreas Kling.
1521
1522         * DumpRenderTree/TestRunner.cpp:
1523         (TestRunner::staticFunctions):
1524         * DumpRenderTree/TestRunner.h:
1525         (TestRunner):
1526         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1527         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1528         (WebTestRunner::TestRunner::TestRunner):
1529         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1530         (TestRunner):
1531         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1532         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1533         * DumpRenderTree/mac/TestRunnerMac.mm:
1534         * DumpRenderTree/qt/TestRunnerQt.cpp:
1535         * DumpRenderTree/qt/TestRunnerQt.h:
1536         (TestRunnerQt):
1537         * DumpRenderTree/win/TestRunnerWin.cpp:
1538         * DumpRenderTree/wx/TestRunnerWx.cpp:
1539
1540 2013-03-06  Roger Fong  <roger_fong@apple.com>
1541
1542         Re-enable WinEWS test and decrease iterations before clean build back to 10.
1543
1544         * EWSTools/start-queue-win.sh:
1545         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1546         (WinEWS):
1547
1548 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
1549
1550         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
1551         https://bugs.webkit.org/show_bug.cgi?id=82866
1552
1553         Reviewed by Martin Robinson.
1554
1555         * Scripts/run-gtk-tests:
1556         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
1557         it is passing now.
1558
1559 2013-03-06  Julie Parent  <jparent@chromium.org>
1560
1561         Dashboard cleanup: remove dashboard time logging.
1562         https://bugs.webkit.org/show_bug.cgi?id=111608
1563
1564         Reviewed by Dirk Pranke.
1565
1566         Remove logTime.  It was never accurate, and the dev tools
1567         have better ways to measure this if anyone cares to look
1568         into dashboard perf.
1569         
1570         * TestResultServer/static-dashboards/dashboard_base.js:
1571         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1572         (processTestRunsForBuilder):
1573         (appendHTML):
1574
1575 2013-03-06  Tony Chang  <tony@chromium.org>
1576
1577         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1578         https://bugs.webkit.org/show_bug.cgi?id=111509
1579
1580         Reviewed by Dirk Pranke.
1581
1582         Add DumpRenderTree.pak to DumpRenderTree.app again.
1583
1584         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1585
1586 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
1587
1588         [chromium] introduce WebUserGestureIndicator
1589         https://bugs.webkit.org/show_bug.cgi?id=111531
1590
1591         Reviewed by Adam Barth.
1592
1593         * DumpRenderTree/chromium/WebViewHost.cpp:
1594         (WebViewHost::createView):
1595
1596 2013-03-06  Alan Cutter  <alancutter@chromium.org>
1597
1598         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
1599         https://bugs.webkit.org/show_bug.cgi?id=73482
1600
1601         Reviewed by Ryosuke Niwa.
1602
1603         Added input checking to the UpdateChromiumDEPS step.
1604         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
1605
1606         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
1607         (RollChromiumDEPS):
1608         (RollChromiumDEPS._parse_args):
1609         (RollChromiumDEPS.execute):
1610         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
1611         (IRCCommandTest.test_roll_chromium_deps):
1612         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
1613         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
1614         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
1615         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
1616         (UpdateChromiumDEPS._fetch_last_known_good_revision):
1617         (UpdateChromiumDEPS):
1618         (UpdateChromiumDEPS._parse_revision_number):
1619         (UpdateChromiumDEPS._validate_revisions):
1620         (UpdateChromiumDEPS.run):
1621         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
1622         (UpdateChromiumDEPSTest):
1623         (UpdateChromiumDEPSTest.test_parse_revision_number):
1624         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
1625         (RollChromiumDEPS):
1626         (PostChromiumDEPSRoll):
1627
1628 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
1629
1630         [Qt][MiniBrowser] Touch mocking broken for chained getures
1631         https://bugs.webkit.org/show_bug.cgi?id=111430
1632
1633         Reviewed by Jocelyn Turcotte.
1634
1635         Make it possible again to use touch mocking to test gesture chains
1636         like pan->pinch->pan->pinch without lifting the primary "finger".
1637         For this to work we need to track the pressed mouse buttons and
1638         only synthesize touch release events when the ctrl key is released
1639         if no mouse button is pressed. Else the pressed mouse button(s)
1640         should result in a stationary touch point in a touch update event.
1641         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
1642         to check for the state of the ctrl key modifier instead of getting
1643         it from the mouse events.
1644
1645         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1646         (MiniBrowserApplication::MiniBrowserApplication):
1647         (MiniBrowserApplication::notify):
1648
1649 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1650
1651         [chromium] don't use custom freetype on linux asan for now
1652         https://bugs.webkit.org/show_bug.cgi?id=111516
1653
1654         Unreviewed, build fix.
1655
1656         Turns out the custom lib is getting picked up by other binaries
1657         on our bot, which is bad.
1658
1659         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1660
1661 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1662
1663         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1664         https://bugs.webkit.org/show_bug.cgi?id=111509
1665
1666         Unreviewed, build fix.
1667
1668         Actually comment out the flag :(.
1669
1670         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1671
1672 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1673
1674         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1675         https://bugs.webkit.org/show_bug.cgi?id=111509
1676
1677         Unreviewed, build fix.
1678
1679         r144863 appears to have broken the xcode build; I'm temporarily
1680         trying this instead, and if this doesn't work, I'll revert the
1681         other changes.
1682
1683         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1684
1685 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1686
1687         [chromium] build a DumpRenderTree.pak even on windows
1688         https://bugs.webkit.org/show_bug.cgi?id=111504
1689
1690         Reviewed by Tony Chang.
1691
1692         The Chromium Aura build uses the default theme to draw
1693         controls, and that theme requires the ui ResourceBundle
1694         to be initialized. On every other platform, we build
1695         a DumpRenderTree.pak that works for this, but on Windows we
1696         still compile the resources directly into DRT. As a first step,
1697         let's build the pak file. I will then need to land a patch
1698         in Chromium to actually load it. Then I can go back and move
1699         the resources over to just use the .pak file and no longer need
1700         the .rc's.
1701
1702         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1703
1704 2013-03-05  Julie Parent  <jparent@chromium.org>
1705         Dashboard cleanup: move string utilities into their own namespace.
1706         
1707         https://bugs.webkit.org/show_bug.cgi?id=111485
1708
1709         Reviewed by Ojan Vafai.
1710         
1711         One of many pieces to clean up dashboard_base.
1712         
1713         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
1714
1715         * TestResultServer/static-dashboards/aggregate_results.html:
1716         * TestResultServer/static-dashboards/dashboard_base.js:
1717         (isTreeMap):
1718         (isFlakinessDashboard):
1719         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1720         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1721         (determineWKPlatform):
1722         (chromiumPlatform):
1723         (platformAndBuildType):
1724         (substringList):
1725         (individualTestsForSubstringList):
1726         (filterBugs):
1727         (populateExpectationsData):
1728         (processMissingTestsWithExpectations):
1729         (processMissingAndExtraExpectations):
1730         (htmlForSingleTestRow):
1731         (.dummyNode.onload):
1732         (expectationsTitle):
1733         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1734         * TestResultServer/static-dashboards/run-unittests.html:
1735         * TestResultServer/static-dashboards/string.js: Added.
1736         * TestResultServer/static-dashboards/timeline_explorer.html:
1737         * TestResultServer/static-dashboards/treemap.html:
1738
1739 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
1740
1741         [EFL] Build break with latest EFL libraries
1742         https://bugs.webkit.org/show_bug.cgi?id=111028
1743
1744         Reviewed by Dirk Pranke.
1745
1746         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
1747         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
1748         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
1749
1750 2013-03-05  Roger Fong  <roger_fong@apple.com>
1751
1752         Increase number of WinEWS iterations to 20.
1753         Don't reboot after each iteration set.
1754         Make EWS bots just build temporarily so that the queue catches up again.
1755
1756         * EWSTools/start-queue-win.sh:
1757         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1758         (WinEWS):
1759
1760 2013-03-04  James Robinson  <jamesr@chromium.org>
1761
1762         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
1763         https://bugs.webkit.org/show_bug.cgi?id=111386
1764
1765         Reviewed by Adrienne Walker.
1766
1767         * DumpRenderTree/chromium/TestShell.cpp:
1768         (TestShell::initialize):
1769
1770 2013-03-05  Min Qin  <qinmin@chromium.org>
1771
1772         Copy dictionary to the external storage before running layout test on android
1773         https://bugs.webkit.org/show_bug.cgi?id=111480
1774
1775         Reviewed by Adam Barth.
1776
1777         TestWebKitPlatformSupport now needs to read an external dictionary file.
1778         This file does not exist on the device. We need to copy it before running layout tests.
1779
1780         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1781         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1782         (ChromiumAndroidDriver._push_platform_resources):
1783
1784 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1785
1786         [chromium] DRT crashes in an Aura/Win build
1787         https://bugs.webkit.org/show_bug.cgi?id=111394
1788
1789         Reviewed by Tony Chang.
1790
1791         When building (and running) with use_aura=1, we assume that
1792         we're using the default theme engine, but DRT creates the
1793         DRTWin theme engine and overwrites the default, leading to crashes
1794         in basically every test from the mismatch.
1795
1796         This fix gets us down to at least "lots of crashes" :).
1797
1798         * DumpRenderTree/chromium/TestShellWin.cpp:
1799         (platformInit):
1800
1801 2013-03-05  Eric Seidel  <eric@webkit.org>
1802
1803         Add html-parser-threaded perf test now that the threaded parser is enabled by default
1804         https://bugs.webkit.org/show_bug.cgi?id=111200
1805
1806         Reviewed by Ryosuke Niwa.
1807
1808         Had to teach run-perf-tests to ignore one more warning.
1809
1810         * Scripts/webkitpy/performance_tests/perftest.py:
1811         (PerfTest):
1812
1813 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1814
1815         Update list of builders for test results server
1816         https://bugs.webkit.org/show_bug.cgi?id=111166
1817
1818         Reviewed by Ojan Vafai.
1819
1820         * TestResultServer/static-dashboards/builders.jsonp:
1821
1822 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
1823
1824         [GTK] Move basic dependency installation to a script
1825         https://bugs.webkit.org/show_bug.cgi?id=110692
1826
1827         Reviewed by Gustavo Noronha Silva.
1828
1829         * gtk/install-dependencies: Added. A Script which installs all dependencies
1830         necessary for building for Debian-based distributions and Fedora.
1831
1832 2013-03-05  James Robinson  <jamesr@chromium.org>
1833
1834         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
1835         https://bugs.webkit.org/show_bug.cgi?id=111440
1836
1837         Reviewed by Adrienne Walker.
1838
1839         Remove unnecessary WebCompositorSupport::shutdown call
1840
1841         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1842         (main):
1843
1844 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
1845
1846         Unreviewed build fix.
1847
1848         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
1849
1850 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
1851
1852         [Qt][MiniBrowser] Improve the update of touch indicators
1853         https://bugs.webkit.org/show_bug.cgi?id=111429
1854
1855         Reviewed by Jocelyn Turcotte.
1856
1857         MiniBrowserApplication::sendTouchEvent sends an empty list
1858         to BrowserWindow::updateVisualMockTouchPoints if the control
1859         button is released, in which case the touch indicators should
1860         be hidden so that we never end up with a leftover indicator
1861         sticking on the screen.
1862         This patch also simplifies the lookup of the indicator items by
1863         replacing the findChild search in the item tree with a QHash
1864         that stores the touch ID's and the pointers to the corresponding
1865         indicator items.
1866
1867         * MiniBrowser/qt/BrowserWindow.cpp:
1868         (BrowserWindow::updateVisualMockTouchPoints):
1869         * MiniBrowser/qt/BrowserWindow.h:
1870         (BrowserWindow):
1871
1872 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1873
1874         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
1875         https://bugs.webkit.org/show_bug.cgi?id=81042
1876
1877         Reviewed by Enrica Casucci.
1878
1879         Add setAsynchronousSpellCheckingEnabled implementation for
1880         WebKitTestRunner to have the possibility to test asynchronous
1881         spell checking implementation from bug 109577.
1882
1883         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1884         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1885         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
1886         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1887         * WebKitTestRunner/TestController.cpp:
1888         (WTR::TestController::resetStateToConsistentValues):
1889
1890 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
1891
1892         MediaStream API: Add the getStreamById method on RTCPeerConnection
1893         https://bugs.webkit.org/show_bug.cgi?id=111311
1894
1895         Reviewed by Adam Barth.
1896
1897         Changing mocks to be more realistic.
1898
1899         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
1900         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
1901         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
1902         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
1903         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
1904
1905 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1906
1907         Add content shell bots to garden-o-matic for general failurse
1908         https://bugs.webkit.org/show_bug.cgi?id=111168
1909
1910         Reviewed by Adam Barth.
1911
1912         All but the WebKit (Content Shell) Android bot is stable enough. While
1913         they're not green yet, there must not be any non-layout test failures on
1914         them.
1915
1916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1917         (.):
1918
1919 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1920
1921         [chromium] remove deprecated WebTestRunner::setFocus API
1922         https://bugs.webkit.org/show_bug.cgi?id=111354
1923
1924         Reviewed by James Robinson.
1925
1926         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1927         (WebTestDelegate):
1928
1929 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1930
1931         Run the bindings generation tests on EWS and CQ bots
1932         https://bugs.webkit.org/show_bug.cgi?id=111358
1933
1934         Reviewed by Adam Barth.
1935
1936         The tests are super fast and not flaky.
1937
1938         * Scripts/webkitpy/common/config/ports.py:
1939         (DeprecatedPort.run_bindings_tests_command):
1940         * Scripts/webkitpy/common/config/ports_mock.py:
1941         (MockPort.run_webkit_tests_command):
1942         (MockPort):
1943         (MockPort.run_bindings_tests_command):
1944         * Scripts/webkitpy/tool/commands/download_unittest.py:
1945         * Scripts/webkitpy/tool/steps/runtests.py:
1946         (RunTests.run):
1947         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1948         (RunTestsTest.test_webkit_run_unit_tests):
1949         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1950
1951 2013-03-04  Eric Seidel  <eric@webkit.org>
1952
1953         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
1954         https://bugs.webkit.org/show_bug.cgi?id=111384
1955
1956         Reviewed by Ryosuke Niwa.
1957
1958         Sometimes I want to know why various LayoutTests are slow
1959         without having to convert them into PerformanceTests in order
1960         to use our fancy profiling.  The Driver already knows how to
1961         do the right thing, we just need to expose the options to the user.
1962
1963         Handling of these options is already unittested in the perftests_unittest.
1964
1965         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1966         (parse_args):
1967
1968 2013-03-04  Alan Cutter  <alancutter@chromium.org>
1969
1970         check-webkit-style says "Have to enable auto props in the subversion config file"
1971         https://bugs.webkit.org/show_bug.cgi?id=107724
1972
1973         Reviewed by Tony Chang.
1974
1975         Added a standard svn config file for WebKit developers to use.
1976         Updated the style and commit queue bot build scripts to load this file.
1977
1978         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1979         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1980         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1981         * svn-config: Added.
1982
1983 2013-03-04  James Robinson  <jamesr@chromium.org>
1984
1985         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
1986         https://bugs.webkit.org/show_bug.cgi?id=111285
1987
1988         Reviewed by Adrienne Walker.
1989
1990         This removes the need for WebCompositorSupport::initialize and exposes
1991         slightly fewer entry points across the repository boundary.
1992
1993         * DumpRenderTree/chromium/TestShell.cpp:
1994         (TestShell::initialize):
1995         * DumpRenderTree/chromium/TestShell.h:
1996         (TestShell::webCompositorThread):
1997         (TestShell):
1998         * DumpRenderTree/chromium/WebViewHost.cpp:
1999         (WebViewHost::initializeLayerTreeView):
2000
2001 2013-03-04  Roger Fong  <roger_fong@apple.com>
2002
2003         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
2004
2005         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2006
2007 2013-03-04  David Kilzer  <ddkilzer@apple.com>
2008
2009         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
2010
2011             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
2012                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
2013                                         ^         ~~~~~~~~~~~~~~~~~~~~~
2014             1 error generated.
2015
2016         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
2017         AccessibilityCommonMac.h.
2018
2019 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2020
2021         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
2022         https://bugs.webkit.org/show_bug.cgi?id=109828
2023
2024         Reviewed by Kenneth Rohde Christiansen.
2025
2026         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
2027         callbacks.
2028
2029         * TestWebKitAPI/CMakeLists.txt:
2030
2031             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
2032             considered.
2033
2034         * TestWebKitAPI/PlatformEfl.cmake:
2035         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
2036         (TestWebKitAPI):
2037         (TestWebKitAPI::didFinishLoadForFrame):
2038         (TestWebKitAPI::setPageLoaderClient):
2039         (TestWebKitAPI::webProcessCrashed):
2040         (TestWebKitAPI::webProcessDidRelaunch):
2041         (TestWebKitAPI::setViewClient):
2042         (TestWebKitAPI::TEST):
2043
2044 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
2045
2046         AX: Upstream iOS Accessibility DumpRenderTree changes
2047         https://bugs.webkit.org/show_bug.cgi?id=111220
2048
2049         Reviewed by David Kilzer.
2050
2051         Upstream the iOS changes for accessibility in DumpRenderTree.
2052
2053         * DumpRenderTree/AccessibilityUIElement.cpp:
2054         (headerElementAtIndexCallback):
2055         (linkedElementCallback):
2056         (elementsForRangeCallback):
2057         (increaseTextSelectionCallback):
2058         (decreaseTextSelectionCallback):
2059         (assistiveTechnologySimulatedFocusCallback):
2060         (stringForSelectionCallback):
2061         (getIPhoneLabelCallback):
2062         (getIPhoneHintCallback):
2063         (getIPhoneValueCallback):
2064         (getIPhoneIdentifierCallback):
2065         (getIPhoneTraitsCallback):
2066         (getIPhoneIsElementCallback):
2067         (getIPhoneElementTextPositionCallback):
2068         (getIPhoneElementTextLengthCallback):
2069         (AccessibilityUIElement::getJSClass):
2070         * DumpRenderTree/AccessibilityUIElement.h:
2071         (AccessibilityUIElement):
2072         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2073         * DumpRenderTree/ios: Added.
2074         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
2075         (AccessibilityController::AccessibilityController):
2076         (AccessibilityController::~AccessibilityController):
2077         (AccessibilityController::elementAtPoint):
2078         (AccessibilityController::focusedElement):
2079         (AccessibilityController::rootElement):
2080         (findAccessibleObjectById):
2081         (AccessibilityController::accessibleElementById):
2082         (AccessibilityController::setLogFocusEvents):
2083         (AccessibilityController::setLogScrollingStartEvents):
2084         (AccessibilityController::setLogValueChangeEvents):
2085         (AccessibilityController::setLogAccessibilityEvents):
2086         (AccessibilityController::addNotificationListener):
2087         (AccessibilityController::removeNotificationListener):
2088         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
2089         (AccessibilityUIElement::AccessibilityUIElement):
2090         (AccessibilityUIElement::~AccessibilityUIElement):
2091         (concatenateAttributeAndValue):
2092         (AccessibilityUIElement::iphoneLabel):
2093         (AccessibilityUIElement::iphoneHint):
2094         (AccessibilityUIElement::iphoneValue):
2095         (AccessibilityUIElement::iphoneIdentifier):
2096         (AccessibilityUIElement::iphoneTraits):
2097         (AccessibilityUIElement::iphoneIsElement):
2098         (AccessibilityUIElement::iphoneElementTextPosition):
2099         (AccessibilityUIElement::iphoneElementTextLength):
2100         (AccessibilityUIElement::url):
2101         (AccessibilityUIElement::x):
2102         (AccessibilityUIElement::y):
2103         (AccessibilityUIElement::width):
2104         (AccessibilityUIElement::height):
2105         (AccessibilityUIElement::clickPointX):
2106         (AccessibilityUIElement::clickPointY):
2107         (AccessibilityUIElement::getChildren):
2108         (AccessibilityUIElement::getChildrenWithRange):
2109         (AccessibilityUIElement::childrenCount):
2110         (AccessibilityUIElement::elementAtPoint):
2111         (AccessibilityUIElement::indexOfChild):
2112         (AccessibilityUIElement::getChildAtIndex):
2113         (AccessibilityUIElement::headerElementAtIndex):
2114         (AccessibilityUIElement::linkedElement):
2115         (AccessibilityUIElement::linkedUIElementAtIndex):
2116         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2117         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2118         (AccessibilityUIElement::disclosedRowAtIndex):
2119         (AccessibilityUIElement::selectedRowAtIndex):
2120         (AccessibilityUIElement::rowAtIndex):
2121         (AccessibilityUIElement::titleUIElement):
2122         (AccessibilityUIElement::parentElement):
2123         (AccessibilityUIElement::disclosedByRow):
2124         (AccessibilityUIElement::increaseTextSelection):
2125         (AccessibilityUIElement::decreaseTextSelection):
2126         (AccessibilityUIElement::stringForSelection):
2127         (AccessibilityUIElement::stringForRange):
2128         (AccessibilityUIElement::attributedStringForRange):
2129         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2130         (AccessibilityUIElement::elementsForRange):
2131         (AccessibilityUIElement::getLinkedUIElements):
2132         (AccessibilityUIElement::getDocumentLinks):
2133         (AccessibilityUIElement::attributesOfLinkedUIElements):
2134         (AccessibilityUIElement::attributesOfDocumentLinks):
2135         (AccessibilityUIElement::attributesOfChildren):
2136         (AccessibilityUIElement::allAttributes):
2137         (AccessibilityUIElement::stringAttributeValue):
2138         (AccessibilityUIElement::isPressActionSupported):
2139         (AccessibilityUIElement::isIncrementActionSupported):
2140         (AccessibilityUIElement::isDecrementActionSupported):
2141         (AccessibilityUIElement::boolAttributeValue):
2142         (AccessibilityUIElement::isAttributeSettable):
2143         (AccessibilityUIElement::isAttributeSupported):
2144         (AccessibilityUIElement::parameterizedAttributeNames):
2145         (AccessibilityUIElement::role):
2146         (AccessibilityUIElement::subrole):
2147         (AccessibilityUIElement::roleDescription):
2148         (AccessibilityUIElement::title):
2149         (AccessibilityUIElement::description):
2150         (AccessibilityUIElement::orientation):
2151         (AccessibilityUIElement::stringValue):
2152         (AccessibilityUIElement::language):
2153         (AccessibilityUIElement::helpText):
2154         (AccessibilityUIElement::intValue):
2155         (AccessibilityUIElement::minValue):
2156         (AccessibilityUIElement::maxValue):
2157         (AccessibilityUIElement::valueDescription):
2158         (AccessibilityUIElement::insertionPointLineNumber):
2159         (AccessibilityUIElement::isEnabled):
2160         (AccessibilityUIElement::isRequired):
2161         (AccessibilityUIElement::isFocused):
2162         (AccessibilityUIElement::isSelected):
2163         (AccessibilityUIElement::isExpanded):
2164         (AccessibilityUIElement::isChecked):
2165         (AccessibilityUIElement::hierarchicalLevel):
2166         (AccessibilityUIElement::ariaIsGrabbed):
2167         (AccessibilityUIElement::ariaDropEffects):
2168         (AccessibilityUIElement::lineForIndex):
2169         (AccessibilityUIElement::boundsForRange):
2170         (AccessibilityUIElement::attributesOfColumnHeaders):
2171         (AccessibilityUIElement::attributesOfRowHeaders):
2172         (AccessibilityUIElement::attributesOfColumns):
2173         (AccessibilityUIElement::attributesOfRows):
2174         (AccessibilityUIElement::attributesOfVisibleCells):
2175         (AccessibilityUIElement::attributesOfHeader):
2176         (AccessibilityUIElement::rowCount):
2177         (AccessibilityUIElement::columnCount):
2178         (AccessibilityUIElement::indexInTable):
2179         (AccessibilityUIElement::rowIndexRange):
2180         (AccessibilityUIElement::columnIndexRange):
2181         (AccessibilityUIElement::cellForColumnAndRow):
2182         (AccessibilityUIElement::selectedTextRange):
2183         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2184         (AccessibilityUIElement::setSelectedTextRange):
2185         (AccessibilityUIElement::increment):
2186         (AccessibilityUIElement::decrement):
2187         (AccessibilityUIElement::showMenu):
2188         (AccessibilityUIElement::press):
2189         (AccessibilityUIElement::accessibilityValue):
2190         (AccessibilityUIElement::documentEncoding):
2191         (AccessibilityUIElement::documentURI):
2192         (_accessibilityNotificationCallback):
2193         (AccessibilityUIElement::addNotificationListener):
2194         (AccessibilityUIElement::removeNotificationListener):
2195         (AccessibilityUIElement::isFocusable):
2196         (AccessibilityUIElement::isSelectable):
2197         (AccessibilityUIElement::isMultiSelectable):
2198         (AccessibilityUIElement::isSelectedOptionActive):
2199         (AccessibilityUIElement::isVisible):
2200         (AccessibilityUIElement::isOffScreen):
2201         (AccessibilityUIElement::isCollapsed):
2202         (AccessibilityUIElement::isIgnored):
2203         (AccessibilityUIElement::hasPopup):
2204         (AccessibilityUIElement::takeFocus):
2205         (AccessibilityUIElement::takeSelection):
2206         (AccessibilityUIElement::addSelection):
2207         (AccessibilityUIElement::removeSelection):
2208         (AccessibilityUIElement::uiElementForSearchPredicate):
2209         (AccessibilityUIElement::numberAttributeValue):
2210
2211 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
2212
2213         [chromium] pass all focus handling methods through the WebTestDelegate
2214         https://bugs.webkit.org/show_bug.cgi?id=111328
2215
2216         Reviewed by Nico Weber.
2217
2218         In content_shell, the focus handling is asynchronous. To allow for
2219         switching the focus synchronously between WebViews, we need to intercept
2220         didFocus and didBlur and forward it to the WebTestDelegate.
2221
2222         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2223         (WebTestDelegate):
2224         (WebTestRunner::WebTestDelegate::setFocus):
2225         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2226         (WebTestRunner::WebTestProxy::didFocus):
2227         (WebTestRunner::WebTestProxy::didBlur):
2228         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2229         (WebTestRunner::TestRunner::setWindowIsKey):
2230         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2231         (WebTestRunner::WebTestProxyBase::didFocus):
2232         (WebTestRunner):
2233         (WebTestRunner::WebTestProxyBase::didBlur):
2234         * DumpRenderTree/chromium/WebViewHost.cpp:
2235         (WebViewHost::didFocus):
2236         (WebViewHost::didBlur):
2237         (WebViewHost::setFocus):
2238         * DumpRenderTree/chromium/WebViewHost.h:
2239         (WebViewHost):
2240
2241 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
2242
2243         [GTK] No need to manually add system paths to jhbuildrc
2244         https://bugs.webkit.org/show_bug.cgi?id=110850
2245
2246         Reviewed by Gustavo Noronha Silva.
2247
2248         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
2249         already takes care of.
2250
2251 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
2252
2253         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
2254         https://bugs.webkit.org/show_bug.cgi?id=111284
2255
2256         Disabling the failing two tests on Android.
2257
2258         Reviewed by Jochen Eisinger.
2259
2260         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2261         (TestWebKitAPI):
2262         (TestWebKitAPI::TEST):
2263
2264 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2265
2266         Add build flag for FontLoader
2267         https://bugs.webkit.org/show_bug.cgi?id=111289
2268
2269         Reviewed by Benjamin Poulain.
2270
2271         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
2272
2273         * Scripts/webkitperl/FeatureList.pm:
2274         * qmake/mkspecs/features/features.pri:
2275
2276 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
2277
2278         [Mac] Get rid of a useless method from DOMHTMLInputElement
2279         https://bugs.webkit.org/show_bug.cgi?id=111279
2280
2281         Reviewed by Sam Weinig.
2282
2283         * DumpRenderTree/mac/TestRunnerMac.mm:
2284         (TestRunner::setValueForUser):
2285         The method _setValueForUser: was added for testing. This feature is already
2286         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
2287         in real use cases. Get rid of the method created for testing, use the real thing
2288         instead.
2289
2290 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2291
2292         Some perf. tests have variances that differ greatly between runs
2293         https://bugs.webkit.org/show_bug.cgi?id=97510
2294
2295         Reviewed by Benjamin Poulain.
2296
2297         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
2298         environment on test results (we run each instance after one another, not in parallel).
2299
2300         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
2301         iterations as it was done previously in single process. These values are hard-coded in perftest.py
2302         and runner.js but they are to be configurable in the future.
2303
2304         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
2305         metric now reports an array of the length 4 with each element containing an array of 5 iteration
2306         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
2307
2308         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
2309         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
2310         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
2311
2312         * Scripts/webkitpy/performance_tests/perftest.py:
2313         (PerfTestMetric.append_group): Renamed from append.
2314         (PerfTestMetric.grouped_iteration_values): Added.
2315         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
2316
2317         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
2318         This parameter is only used by SingleProcessPerfTest.
2319
2320         (PerfTest.run): Repeat tests using different driver processes.
2321         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
2322         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
2323         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
2324         (PerfTest._ensure_metrics): Added.
2325
2326         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
2327         instances of DumpRenderTree/WebKitTestRunner takes too long.
2328         (SingleProcessPerfTest.__init__):
2329
2330         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
2331
2332         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
2333
2334         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
2335         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
2336         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
2337
2338         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
2339         grouped_iteration_values.
2340
2341         (TestPerfTest._assert_results_are_correct):
2342
2343         (TestSingleProcessPerfTest): Added.
2344         (TestSingleProcessPerfTest.test_use_only_one_process):
2345         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
2346
2347         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2348         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2349
2350         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
2351         sample standard deviations since we're now running tests 4 times.
2352         (MainTest._test_run_with_json_output.mock_upload_json):
2353         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
2354
2355 2013-03-03  Alexandre Elias  <aelias@chromium.org>
2356
2357         [chromium] Remove WebLayerTreeView::setViewportSize call
2358         https://bugs.webkit.org/show_bug.cgi?id=110727
2359
2360         Reviewed by James Robinson.
2361
2362         After https://codereview.chromium.org/12328080 lands,
2363         setViewportSize is called from the Chromium side. The multiplication
2364         by deviceScaleFactor here was prone to off-by-one errors.
2365         The layoutSize() function was only used here so delete it as well.
2366
2367         DumpRenderTree WebViewHost must now call this method as well.
2368
2369         * DumpRenderTree/chromium/WebViewHost.cpp:
2370         (WebViewHost::initializeLayerTreeView):
2371         (WebViewHost::setWindowRect):
2372         (WebViewHost::setDeviceScaleFactor):
2373         (WebViewHost::updateViewportSize):
2374         * DumpRenderTree/chromium/WebViewHost.h:
2375         (WebViewHost):
2376
2377 2013-02-27  Darin Adler  <darin@apple.com>
2378
2379         StringHasher functions require alignment that call sites do not all guarantee
2380         https://bugs.webkit.org/show_bug.cgi?id=110171
2381
2382         Reviewed by Benjamin Poulain.
2383
2384         * TestWebKitAPI/CMakeLists.txt:
2385         * TestWebKitAPI/GNUmakefile.am:
2386         * TestWebKitAPI/TestWebKitAPI.gypi:
2387         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2388         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2390         * TestWebKitAPI/Tests/WTF/WTF.pro:
2391         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2392         Added the StringHasher.cpp file.
2393
2394         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
2395         for the functions in the StringHasher class.
2396
2397 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
2398
2399         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
2400         https://bugs.webkit.org/show_bug.cgi?id=109772
2401
2402         Reviewed by Andreas Kling.
2403
2404         * DumpRenderTree/TestRunner.cpp:
2405         (TestRunner::staticFunctions):
2406         * DumpRenderTree/TestRunner.h:
2407         (TestRunner):
2408         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2409         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2410         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2411         * DumpRenderTree/mac/TestRunnerMac.mm:
2412         * DumpRenderTree/qt/TestRunnerQt.cpp:
2413         * DumpRenderTree/qt/TestRunnerQt.h:
2414         (TestRunner):
2415         * DumpRenderTree/win/TestRunnerWin.cpp:
2416         * DumpRenderTree/wx/TestRunnerWx.cpp:
2417         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2418         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2419         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2420         (TestRunner):
2421
2422 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
2423
2424         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
2425         https://bugs.webkit.org/show_bug.cgi?id=110943
2426
2427         Reviewed by Yury Semikhatsky.
2428
2429         Unfortunately in many cases raw pointer may point to an object that has been deleted.
2430         There is no working solution to solve this problem in general.
2431         It could be solved only on case by case basis.
2432
2433         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2434         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2435         (TestWebKitAPI::TEST):
2436
2437 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
2438
2439         Move markerTextForListItem from TestRunner to Internals
2440         https://bugs.webkit.org/show_bug.cgi?id=110939
2441
2442         Reviewed by Benjamin Poulain.
2443
2444         * DumpRenderTree/TestRunner.cpp:
2445         (TestRunner::staticFunctions):
2446         * DumpRenderTree/TestRunner.h:
2447         (TestRunner):
2448         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2449         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2450         (WebTestRunner::TestRunner::TestRunner):
2451         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2452         (TestRunner):
2453         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2454         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2455         * DumpRenderTree/mac/TestRunnerMac.mm:
2456         * DumpRenderTree/qt/TestRunnerQt.cpp:
2457         * DumpRenderTree/qt/TestRunnerQt.h:
2458         (TestRunnerQt):
2459         * DumpRenderTree/win/TestRunnerWin.cpp:
2460         * DumpRenderTree/wx/TestRunnerWx.cpp:
2461         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2462         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2463         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2464         (TestRunner):
2465
2466 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
2467
2468         Don't use legacy test names when returning results from PerfTest.run
2469         https://bugs.webkit.org/show_bug.cgi?id=111148
2470
2471         Reviewed by Dirk Pranke.
2472
2473         * Scripts/webkitpy/performance_tests/perftest.py:
2474         (PerfTestMetric.name): Renamed from metric.
2475         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
2476         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
2477         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
2478
2479         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2480         (TestPerfTestMetric.test_init_set_time_metric):
2481         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
2482         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2483         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2484
2485         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2486         (PerfTestsRunner.__init__):
2487         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
2488         to obtain the trac URL instead of hard coding it.
2489         (PerfTestsRunner._run_tests_set):
2490
2491 2013-03-01  Roger Fong  <roger_fong@apple.com>
2492
2493         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
2494         https://bugs.webkit.org/show_bug.cgi?id=111202
2495
2496         This is useful for running VCExpress builds from command line because there is
2497         no unified solution output, only per project build logs.
2498         The project will be run as the last project in the solution.
2499
2500         * win/AssembleBuildLogs: Added.
2501         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
2502         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
2503         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
2504         * win/AssembleBuildLogs/README: Added.
2505
2506 2013-03-01  Roger Fong  <roger_fong@apple.com>
2507
2508         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
2509
2510         * EWSTools/start-queue-win.sh:
2511
2512 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
2513
2514         Don't return statistics in PerfTest.run
2515         https://bugs.webkit.org/show_bug.cgi?id=111145
2516
2517         Reviewed by Dirk Pranke.
2518
2519         Simply return a list of values obtained in each iteration from PerfTest.run.
2520         Also simplify various methods as needed.
2521
2522         * Scripts/webkitpy/performance_tests/perftest.py:
2523         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
2524         as needed from PerfTestsRunner._generate_results_dict.
2525
2526         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
2527         that we don't have to worry about the backward compatibility here.
2528
2529         (PerfTestMetric.iteration_values): Added.
2530         (PerfTestMetric.unit): Added.
2531         (PerfTestMetric.metric_to_unit):
2532         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
2533
2534         (PerfTest.run):
2535         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
2536
2537         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2538         (TestPerfTestMetric.test_init_set_missing_unit):
2539         (TestPerfTestMetric.test_init_set_time_metric): Added.
2540         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
2541         (TestPerfTestMetric.test_append):
2542         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
2543         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
2544         (TestPerfTest._assert_results_are_correct):
2545         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2546         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2547
2548         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2549         (PerfTestsRunner._generate_results_dict):
2550
2551         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2552         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
2553         (SomeParserTestData): Ditto.
2554         (MemoryTestData): Ditto.
2555
2556 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2557
2558         [Qt] Enable LINK_PREFETCH
2559         https://bugs.webkit.org/show_bug.cgi?id=111158
2560
2561         Reviewed by Simon Hausmann.
2562
2563         * qmake/mkspecs/features/features.pri:
2564
2565 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2566
2567         [Qt] Update features.pri with new features
2568         https://bugs.webkit.org/show_bug.cgi?id=111157
2569
2570         Reviewed by Jocelyn Turcotte.
2571
2572         * qmake/mkspecs/features/features.pri:
2573
2574 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
2575
2576         [chromium] put WebTestProxy::scheduleComposite back in place
2577         https://bugs.webkit.org/show_bug.cgi?id=111146
2578
2579         Reviewed by Nico Weber.
2580
2581         The call was removed in http://trac.webkit.org/changeset/144398 because
2582         DRT doesn't need it. However, content shell depends on this call.
2583
2584         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2585         (WebTestRunner::WebTestProxy::scheduleComposite):
2586
2587 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2588
2589         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
2590         https://bugs.webkit.org/show_bug.cgi?id=111142
2591
2592         Reviewed by Adam Barth.
2593
2594         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
2595
2596         Also removed _print_status since it's never used anywhere.
2597
2598         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2599         (PerfTestsRunner.run):
2600         (PerfTestsRunner._run_tests_set):
2601         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2602         (MainTest.run_test):
2603         (MainTest.test_run_test_set):
2604         (MainTest.test_run_test_set_kills_drt_per_run):
2605         (MainTest.test_run_test_set_for_parser_tests):
2606
2607 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
2608
2609         Disable window occlusion detection for WebKitTestRunner Web View on Mac
2610         https://bugs.webkit.org/show_bug.cgi?id=111116
2611
2612         Reviewed by Simon Fraser.
2613
2614         Window occlusion notifications were causing WebKitTestRunner's Web View
2615         to be detected as occluded and causing a few JavaScript timer layout
2616         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
2617         by initializing the page visibility to "visible" after creating the view.
2618         But a better solution is to disable window occlusion detection, so that
2619         not only the page but also the view is treated as visible.
2620
2621         * WebKitTestRunner/TestController.cpp:
2622         (WTR::TestController::createWebViewWithOptions): Remove call to
2623         setVisibilityState, since it is no longer necessary.
2624         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2625         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
2626         detection for the created WKView.
2627
2628 2013-02-28  Li Yin  <li.yin@intel.com>
2629
2630         [chromium] Events can't be triggered on MediaStreamTrack
2631         https://bugs.webkit.org/show_bug.cgi?id=110930
2632
2633         Reviewed by Kentaro Hara.
2634
2635         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
2636
2637         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
2638         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
2639
2640 2013-02-27  James Robinson  <jamesr@chromium.org>
2641
2642         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
2643         https://bugs.webkit.org/show_bug.cgi?id=111017
2644
2645         Reviewed by Adam Barth.
2646
2647         This decouples DumpRenderTree from WebLayerTreeViewClient.
2648
2649         * DumpRenderTree/chromium/WebViewHost.cpp:
2650         (WebViewHostDRTLayerTreeViewClient):
2651         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
2652         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
2653         (WebViewHostDRTLayerTreeViewClient::Layout):
2654         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
2655         (WebViewHost::initializeLayerTreeView):
2656         * DumpRenderTree/chromium/WebViewHost.h:
2657         (webkit_support):
2658         (WebViewHost):
2659
2660 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
2661
2662         Unreviewed, add my secondary email address to the list.
2663
2664         * Scripts/webkitpy/common/config/committers.py:
2665
2666 2013-02-28  Philip Rogers  <pdr@google.com>
2667
2668         Add Philip Rogers as a reviewer.
2669
2670         Unreviewed update of committers.py.
2671
2672         * Scripts/webkitpy/common/config/committers.py:
2673
2674 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2675
2676         Merge more methods on PerfTest
2677         https://bugs.webkit.org/show_bug.cgi?id=111030
2678
2679         Reviewed by Dirk Pranke.
2680
2681         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
2682         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
2683
2684         This makes the control flow a lot more comprehensible.
2685
2686         * Scripts/webkitpy/performance_tests/perftest.py:
2687         (PerfTest._run_with_driver):
2688         (PerfTest._should_ignore_line):
2689         (PerfTest._filter_output):
2690
2691         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2692         (TestPerfTest._assert_results_are_correct):
2693         (test_ignored_stderr_lines):
2694
2695 2013-02-28  Robert Hogan  <robert@webkit.org>
2696
2697         Update my IRC nick
2698
2699         Unreviewed.
2700
2701         * Scripts/webkitpy/common/config/committers.py:
2702
2703 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
2704
2705         [Qt] Enable thin archives before parsing the project files
2706
2707         Rubber-stamped by Simon Hausmann.
2708
2709         The targetSubDir() function can be called before default_post.prf has been
2710         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
2711         which is parsed before the main project file.
2712         This issue was revealed by r144299 and fixes the clean build.
2713
2714         * qmake/mkspecs/features/default_post.prf:
2715         * qmake/mkspecs/features/default_pre.prf:
2716
2717 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2718
2719         [Qt] Enable CANVAS_PATH flag
2720         https://bugs.webkit.org/show_bug.cgi?id=108508
2721
2722         Reviewed by Simon Hausmann.
2723
2724         Also enable CANVAS_PATH flag for Qt.
2725
2726         * qmake/mkspecs/features/features.pri:
2727
2728 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
2729
2730         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
2731
2732         Rubber-stamped by Csaba Osztrogonác.
2733
2734         Besides suppressing a warning about the non-existing function this
2735         fixes the build if there is a subdirectory (eg. debug-and-release).
2736
2737         * TestWebKitAPI/InjectedBundle.pri:
2738         * TestWebKitAPI/TestWebKitAPI.pri:
2739
2740 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2741
2742         [EFL][WTR] WTR cannot load injected bundle
2743         https://bugs.webkit.org/show_bug.cgi?id=111063
2744
2745         Reviewed by Csaba Osztrogonác.
2746
2747         WTR was not able to load injected bundle because of undefined 
2748         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
2749         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
2750         solves the problem.
2751
2752         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2753         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2754
2755 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
2756
2757         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
2758         https://bugs.webkit.org/show_bug.cgi?id=110464
2759
2760         Reviewed by Rob Buis.
2761
2762         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2763
2764 2013-02-28  Xan Lopez  <xlopez@rim.com>
2765
2766         [BlackBerry] DumpRenderTreeSupport: update the set position methods
2767         https://bugs.webkit.org/show_bug.cgi?id=110578
2768
2769         Reviewed by Rob Buis.
2770
2771         TestRunner::setMockGeolocationPosition() changed in r130416:
2772         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
2773
2774         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
2775         setMockGeolocationPositionUnavailableError() in r129444:
2776         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
2777
2778         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2779         (TestRunner::setMockGeolocationPosition):
2780         (TestRunner::setMockGeolocationPositionUnavailableError):
2781
2782 2013-02-28  Xan Lopez  <xlopez@rim.com>
2783
2784         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
2785         https://bugs.webkit.org/show_bug.cgi?id=110465
2786
2787         Reviewed by Rob Buis.
2788
2789         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
2790         (LoadItem::invoke):
2791
2792 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2793
2794         PerfTestRunner doesn't need _needs_http and _has_http_lock
2795         https://bugs.webkit.org/show_bug.cgi?id=111037
2796
2797         Reviewed by Adam Barth.
2798
2799         Delete these variables in favor of using a local variable.
2800
2801         Member variables are like global variables. They introduce implicit dependencies
2802         between member functions.
2803
2804         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2805         (PerfTestsRunner.__init__):
2806         (PerfTestsRunner._start_http_servers):
2807         (PerfTestsRunner):
2808         (PerfTestsRunner._stop_http_servers):
2809         (PerfTestsRunner.run):
2810
2811 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2812
2813         Unreviewed, rolling out r144224.
2814         http://trac.webkit.org/changeset/144224
2815         https://bugs.webkit.org/show_bug.cgi?id=111045
2816
2817         Caused plugins/pass-different-npp-struct.html to time out
2818         (Requested by abarth on #webkit).
2819
2820         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2821         (PassDifferentNPPStruct::NPP_SetWindow):
2822         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2823         (NPP_SetWindow):
2824
2825 2013-02-27  Adam Barth  <abarth@webkit.org>
2826
2827         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
2828         https://bugs.webkit.org/show_bug.cgi?id=110907
2829
2830         Reviewed by Eric Seidel.
2831
2832         This patch changes --enable-threaded-html-parser into
2833         --disable-threaded-html-parser and thereby enables the threaded HTML
2834         parser by default for the Chromium port.
2835
2836         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2837         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2838         (WebTestRunner::WebPreferences::reset):
2839         * DumpRenderTree/chromium/TestShell.cpp:
2840         (TestShell::TestShell):
2841
2842 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
2843
2844         Initialize page visibility after creating WebKitTestRunner WebView on Mac
2845         https://bugs.webkit.org/show_bug.cgi?id=111025
2846
2847         Reviewed by Simon Fraser.
2848
2849         Set page visibility to "visible" after creating WebView to override
2850         visibility state inferred from window occlusion notifications on Mac.
2851
2852         * WebKitTestRunner/TestController.cpp:
2853         (WTR::TestController::createWebViewWithOptions): Add call to
2854         setVisibilityState.
2855
2856 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2857
2858         Merge PageLoadingPerfTest into ReplayPerfTest
2859         https://bugs.webkit.org/show_bug.cgi?id=111027
2860
2861         Reviewed by Dirk Pranke.
2862
2863         Merged two classes.
2864
2865         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
2866         part of ReplayPerfTest.
2867
2868         * Scripts/webkitpy/performance_tests/perftest.py:
2869         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
2870         (ReplayPerfTest.__init__):
2871         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
2872         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
2873         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2874         (TestReplayPerfTest):
2875         (TestReplayPerfTest.test_run_single.run_test):
2876         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
2877         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
2878         TestPageLoadingPerfTest.test_run.
2879         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
2880         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
2881         TestPageLoadingPerfTest.test_run_with_memory_output
2882         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
2883         (TestReplayPerfTest.test_prepare_calls_run_single):
2884
2885 2013-02-27  Eric Seidel  <eric@webkit.org>
2886
2887         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
2888         https://bugs.webkit.org/show_bug.cgi?id=111021
2889
2890         Reviewed by Dirk Pranke.
2891
2892         The underlying code (which is shared with run-webkit-tests)
2893         already knew how to support this option, it just wasn't exposed
2894         via the run-perf-tests front-end.  This patch fixes that.
2895
2896         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2897         (PerfTestsRunner._parse_args):
2898
2899 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2900
2901         Stop uploading results to webkit-perf.appspot.com
2902         https://bugs.webkit.org/show_bug.cgi?id=110954
2903
2904         Reviewed by Benjamin Poulain.
2905
2906         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
2907
2908         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2909         (RunAndUploadPerfTests):
2910
2911 2013-02-27  James Simonsen  <simonjam@chromium.org>
2912
2913         [chromium] Lower priority of preloaded images
2914         https://bugs.webkit.org/show_bug.cgi?id=110527
2915
2916         Plumb the didChangePriority signal into DRT so it can be tested.
2917
2918         Reviewed by Nate Chapin.
2919
2920         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2921         (WebKit):
2922         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
2923         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2924         (WebTestRunner::TestRunner::TestRunner):
2925         (WebTestRunner::TestRunner::reset):
2926         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
2927         (WebTestRunner):
2928         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
2929         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2930         (TestRunner):
2931         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2932         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2933         (WebTestRunner::WebTestProxyBase::willSendRequest):
2934         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
2935         (WebTestRunner):
2936
2937 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
2938
2939         AX: Mac platform should support ability to scroll an element into visible
2940         https://bugs.webkit.org/show_bug.cgi?id=109860
2941
2942         Reviewed by Beth Dakin.
2943
2944         * DumpRenderTree/AccessibilityUIElement.cpp:
2945         (scrollToMakeVisibleCallback):
2946         (AccessibilityUIElement::getJSClass):
2947         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2948         (AccessibilityUIElement::scrollToMakeVisible):
2949         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2950         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2951         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2952         (AccessibilityUIElement):
2953         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2954         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2955         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2956         (WTR):
2957
2958 2013-02-27  John Bauman  <jbauman@chromium.org>
2959
2960         Plugin in iframe may not display
2961         https://bugs.webkit.org/show_bug.cgi?id=109879
2962
2963         Reviewed by Simon Fraser.
2964
2965         LogNPPSetWindow will be used with other ports as well.
2966
2967         * DumpRenderTree/DumpRenderTree.gypi:
2968         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2969
2970 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
2971
2972         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2973         https://bugs.webkit.org/show_bug.cgi?id=110973
2974
2975         Reviewed by Adam Barth.
2976
2977         There is nothing that ensures that the log messages from the plugin
2978         come in before the layout test finished loading.
2979
2980         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2981         (PassDifferentNPPStruct::NPP_SetWindow):
2982         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2983         (NPP_SetWindow):
2984
2985 2013-02-27  Glenn Adams  <glenn@skynav.com>
2986
2987         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
2988         https://bugs.webkit.org/show_bug.cgi?id=110944
2989
2990         Reviewed by Dean Jackson.
2991
2992         * Scripts/webkitperl/FeatureList.pm:
2993         * qmake/mkspecs/features/features.pri:
2994
2995 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
2996
2997         Unreviewed. Remove myself from watchlist.
2998
2999         * Scripts/webkitpy/common/config/watchlist:
3000
3001 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3002
3003         Switch QtWebKit to GStreamer 1.0.
3004         https://bugs.webkit.org/show_bug.cgi?id=106669.
3005
3006         Original patch by Sebastian Dröge.
3007         Reviewed by Csaba Osztrogonác.
3008
3009         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
3010         temporarily to make upgrading easy and the patch suitable for Qt5.
3011
3012         * qmake/mkspecs/features/features.prf:
3013
3014 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
3015
3016         Unreviewed. Added myself to committers.py
3017
3018         * Scripts/webkitpy/common/config/committers.py:
3019
3020 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3021
3022         Unreviewed, rolling out r144192.
3023         http://trac.webkit.org/changeset/144192
3024         https://bugs.webkit.org/show_bug.cgi?id=110984
3025
3026         Stored svn password on wrong computer (Requested by kkristof
3027         on #webkit).
3028
3029         * Scripts/webkitpy/common/config/committers.py:
3030
3031 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
3032
3033         Unreviewed. Added myself to committers.py
3034
3035         * Scripts/webkitpy/common/config/committers.py:
3036
3037 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3038
3039         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
3040
3041         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3042         (PerfTestsRunner._upload_json):
3043
3044 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3045
3046         Stop uploading results to webkit-perf.appspot.com
3047         https://bugs.webkit.org/show_bug.cgi?id=110954
3048
3049         Reviewed by Benjamin Poulain.
3050
3051         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
3052         Also, always use the new JSON format. Removed the code to generate the old format.
3053
3054         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3055         (PerfTestsRunner._generate_and_show_results):
3056         (PerfTestsRunner._generate_results_dict):
3057         (PerfTestsRunner._merge_slave_config_json):
3058         (PerfTestsRunner._generate_output_files):
3059
3060 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3061
3062         Unreviewed, rolling out r144136, r144143, and r144147.
3063         http://trac.webkit.org/changeset/144136
3064         http://trac.webkit.org/changeset/144143
3065         http://trac.webkit.org/changeset/144147
3066         https://bugs.webkit.org/show_bug.cgi?id=110950
3067
3068         Caused some timeouts and flaky crashes (Requested by abarth on
3069         #webkit).
3070
3071         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3072         (main):
3073         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3074         (WebTestRunner::WebPreferences::reset):
3075         * DumpRenderTree/chromium/TestShell.cpp:
3076         (TestShell::TestShell):
3077
3078 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3079
3080         Use perf.webkit.org JSON format in results page
3081         https://bugs.webkit.org/show_bug.cgi?id=110842
3082
3083         Reviewed by Benjamin Poulain.
3084
3085         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
3086
3087         A whole bunch of integration tests have been updated to use the new JSON format.
3088
3089         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3090         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
3091         and legacy_output_json_path respectively.
3092         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
3093         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
3094         JSON file and the results page out of perf_webkit_output instead of legacy_output.
3095
3096         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3097         (MainTest.test_run_memory_test):
3098         (MainTest._test_run_with_json_output.mock_upload_json):
3099         (MainTest):
3100         (MainTest.test_run_with_json_output):
3101         (MainTest.test_run_with_description):
3102         (MainTest.test_run_generates_json_by_default):
3103         (MainTest.test_run_merges_output_by_default):
3104         (MainTest.test_run_respects_reset_results):
3105         (MainTest.test_run_generates_and_show_results_page):
3106         (MainTest.test_run_with_slave_config_json):
3107         (MainTest.test_run_with_multiple_repositories):
3108         (MainTest.test_run_with_upload_json):
3109         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
3110
3111 2013-02-26  Adam Barth  <abarth@webkit.org>
3112
3113         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
3114         https://bugs.webkit.org/show_bug.cgi?id=110907
3115
3116         Reviewed by Eric Seidel.
3117
3118         This patch changes --enable-threaded-html-parser into
3119         --disable-threaded-html-parser and thereby enables the threaded HTML
3120         parser by default for the Chromium port.
3121
3122         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3123         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3124         (WebTestRunner::WebPreferences::reset):
3125         * DumpRenderTree/chromium/TestShell.cpp:
3126         (TestShell::TestShell):
3127
3128 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
3129
3130         [chromium] Re-enable the fixed version of freetype on linux
3131         https://bugs.webkit.org/show_bug.cgi?id=110542
3132
3133         Reviewed by Tony Chang.
3134
3135         Re-land the change in r143794 to switch to building with a fixed
3136         version of FreeType for just DumpRenderTree. This allows us to share
3137         one version of pixel baselines for both Lucid and Precise, and run the
3138         layout tests in a stock Precise install (instead of a Lucid chroot).
3139         Going forward, this approach isolates us from os-level changes to the
3140         version of FreeType. Note that Chromium itself still uses the system
3141         FreeType and is unaffected by this change.
3142         
3143         This setting can still be turned off (at compile/gyp-time) by
3144         manually setting use_custom_freetype=0.
3145
3146         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3147
3148 2013-02-26  Nico Weber  <thakis@chromium.org>
3149
3150         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
3151         https://bugs.webkit.org/show_bug.cgi?id=110890
3152
3153         Reviewed by Jochen Eisinger.
3154
3155         Several functions in webkit check that bit to change rendering
3156         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
3157         disables font smoothing in this mode. TestShell and DRT both set
3158         this flag, so content shell drt should set it too.
3159
3160         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3161         (WebTestRunner::TestInterfaces::TestInterfaces):
3162
3163 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
3164
3165         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
3166         https://bugs.webkit.org/show_bug.cgi?id=110884
3167
3168         Reviewed by Csaba Osztrogonác.
3169
3170         Adding the missing spaces before ':' in the unit test.
3171
3172         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3173
3174 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
3175
3176         new-commit-bot: Some IRC clients doesn't linkify rollout messages
3177         https://bugs.webkit.org/show_bug.cgi?id=110861
3178
3179         Reviewed by Ryosuke Niwa.
3180
3181         Adding the space before ':' in order to fix the links shown for the rollout message.
3182
3183         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3184         (NewCommitBot._summarize_commit_log):
3185
3186 2013-02-26  Joone Hur  <joone.hur@intel.com>
3187
3188         [GTK] Add Clutter to jhbuild
3189         https://bugs.webkit.org/show_bug.cgi?id=110245
3190
3191         Reviewed by Martin Robinson.
3192
3193         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
3194         This allows to build WebKitGtk+ with clutter as an acceleration backend
3195         within the jhbuild environment. 
3196
3197         * gtk/jhbuild-optional.modules:
3198
3199 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3200
3201         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
3202
3203         * Scripts/webkitpy/common/checkout/scm/svn.py:
3204         (SVN.value_from_svn_info):
3205
3206 2013-02-25  Alan Cutter  <alancutter@chromium.org>
3207
3208         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
3209         https://bugs.webkit.org/show_bug.cgi?id=110845
3210
3211         Unreviewed EWS bot fix.
3212
3213         Switch the Queue Status Server address the EWS bots use to a more direct URL that
3214         doesn't seem to be having problems from GCE like queues.webkit.org.
3215
3216         * Scripts/webkitpy/common/net/statusserver.py:
3217         (StatusServer):
3218
3219 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3220
3221         Forgot to delete a no-longer-needed unit test after r143980.
3222
3223         Unreviewed, build fix.
3224
3225         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3226         (ChromiumWinTest.test_path_to_image_diff):
3227
3228 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3229
3230         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
3231         Don't include \r at the end of svn info lines on Windows.
3232
3233         This is similar to r143839.
3234
3235         * Scripts/webkitpy/common/checkout/scm/svn.py:
3236         (SVN.value_from_svn_info):
3237
3238 2013-02-25  James Simonsen  <simonjam@chromium.org>
3239
3240         [Resource Timing] Update test suite so it can be exported to the W3C
3241         https://bugs.webkit.org/show_bug.cgi?id=107343
3242
3243         Reviewed by Tony Gentilcore.
3244
3245         * Scripts/export-w3c-performance-wg-tests: Clean up output.
3246         * Scripts/import-w3c-performance-wg-tests:
3247
3248 2013-02-25  Anders Carlsson  <andersca@apple.com>
3249
3250         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
3251         https://bugs.webkit.org/show_bug.cgi?id=110821
3252         <rdar://problem/13265303>
3253
3254         Reviewed by Beth Dakin.
3255
3256         Update for WebKit2 changes.
3257
3258         * MiniBrowser/mac/WK2BrowserWindowController.m:
3259         (-[WK2BrowserWindowController awakeFromNib]):
3260         * WebKitTestRunner/TestController.cpp:
3261         (WTR::TestController::createOtherPage):
3262         (WTR::TestController::createWebViewWithOptions):
3263         (WTR::TestController::unavailablePluginButtonClicked):
3264         * WebKitTestRunner/TestController.h:
3265         (TestController):
3266
3267 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
3268
3269         Optionally partition cache to prevent using cache for tracking
3270         https://bugs.webkit.org/show_bug.cgi?id=110269
3271
3272         Reviewed by Maciej Stachowiak.
3273
3274         Add test suite for public suffix functions on Mac.
3275
3276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3277         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
3278         (TestWebKitAPI):
3279         (TestWebKitAPI::TEST_F):
3280
3281 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3282
3283         nrwt: reenable multiple http shards on chromium win
3284         https://bugs.webkit.org/show_bug.cgi?id=110814
3285
3286         Reviewed by Tony Chang.
3287
3288         The underlying bug in DumpRenderTree that was causing us to look for a
3289         pac file and timeout under load was fixed a while ago.
3290
3291         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3292         (ChromiumWinPort.relative_test_filename):
3293
3294 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3295
3296         Make ninja the default w/ build-webkit --chromium on windows.
3297         https://bugs.webkit.org/show_bug.cgi?id=110731
3298
3299         Unreviewed - TBR'ing thakis :).
3300
3301         * Scripts/update-webkit-chromium:
3302
3303 2013-02-25  Anders Carlsson  <andersca@apple.com>
3304
3305         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
3306         https://bugs.webkit.org/show_bug.cgi?id=110793
3307         <rdar://problem/13265303>
3308
3309         Reviewed by Sam Weinig.
3310
3311         Update for WebKit2 API changes.
3312
3313         * MiniBrowser/mac/WK2BrowserWindowController.m:
3314         (-[WK2BrowserWindowController awakeFromNib]):
3315         * WebKitTestRunner/TestController.cpp:
3316         (WTR::TestController::createWebViewWithOptions):
3317
3318 2013-02-25  Nico Weber  <thakis@chromium.org>
3319
3320         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
3321         https://bugs.webkit.org/show_bug.cgi?id=110775
3322
3323         Unreviewed, basically a rebaseline.
3324
3325         * Scripts/webkitpy/common/config/watchlist:
3326
3327 2013-02-25  Nico Weber  <thakis@chromium.org>
3328
3329         [chromium] Try to get the webkit builder to use msvs again
3330         https://bugs.webkit.org/show_bug.cgi?id=110771
3331
3332         Reviewed by Eric Seidel.
3333
3334         The msvs gyp generator apparently doesn't write the sln file on every
3335         run, so check the vcxproj file instead.
3336
3337         * Scripts/webkitdirs.pm:
3338         (determineIsChromiumNinja):
3339
3340 2013-02-25  Nico Weber  <thakis@chromium.org>
3341
3342         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
3343         https://bugs.webkit.org/show_bug.cgi?id=110767
3344
3345         Reviewed by Eric Seidel.
3346
3347         The tester runs gyp, which generates out/Release/build.ninja. The bot
3348         scripts use existence (and timestamp) of that file to decide if the
3349         current build is supposed to be ninja or xcodebuild. The file exists,
3350         so the snapshot is extracted to out/Release. The snapshot doesn't
3351         contain build.ninja however due to
3352         http://trac.webkit.org/changeset/140375 , so after extracting the
3353         snapshot the scripts think that this is an xcodebuild build. So remove
3354         the part of that revision that removed ninja files from the archive,
3355         and the bots should be happy again.
3356
3357         * BuildSlaveSupport/built-product-archive:
3358         (archiveBuiltProduct):
3359
3360 2013-02-25  Nico Weber  <thakis@chromium.org>
3361
3362         Fix tests after r143910
3363         https://bugs.webkit.org/show_bug.cgi?id=110757
3364
3365         Reviewed by Andreas Kling.
3366
3367         While here, also add a test for the bug r143910 fixed.
3368
3369         * Scripts/webkitpy/common/system/executive_unittest.py:
3370         (ScriptErrorTest.test_message_with_output):
3371         (ScriptErrorTest):
3372         (ScriptErrorTest.test_message_with_tuple):
3373
3374 2013-02-25  Nico Weber  <thakis@chromium.org>
3375
3376         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
3377         https://bugs.webkit.org/show_bug.cgi?id=110755
3378
3379         Reviewed by Jochen Eisinger.
3380
3381         * BuildSlaveSupport/built-product-archive:
3382         (archiveBuiltProduct):
3383         (extractBuiltProduct):
3384
3385 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3386
3387         Unreviewed, rolling out r143895.
3388         http://trac.webkit.org/changeset/143895
3389         https://bugs.webkit.org/show_bug.cgi?id=110758
3390
3391         broke a bunch of tests (Requested by thakis__ on #webkit).
3392
3393         * Scripts/update-webkit-chromium:
3394
3395 2013-02-25  Andreas Kling  <akling@apple.com>
3396
3397         Unreviewed, fix simple mistake in r143903.
3398         <http://webkit.org/b/110746>
3399
3400         Reviewed by Andreas Kling.
3401
3402         Pass git revision, not svn revision, to git shell command.
3403
3404         * Scripts/webkitpy/common/checkout/scm/git.py:
3405         (Git.timestamp_of_latest_commit):
3406
3407 2013-02-25  Nico Weber  <thakis@chromium.org>
3408
3409         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
3410         https://bugs.webkit.org/show_bug.cgi?id=110748
3411
3412         Reviewed by Jochen Eisinger.
3413
3414         One of the mac testers runs DRT from out/ but WebKitUnitTests from
3415         xcodebuild. I'm trying to understand what's going on.
3416
3417         * BuildSlaveSupport/built-product-archive:
3418         (archiveBuiltProduct):
3419         (extractBuiltProduct):
3420
3421 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
3422
3423         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
3424         https://bugs.webkit.org/show_bug.cgi?id=110599
3425
3426         Reviewed by Yury Semikhatsky.
3427
3428         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
3429         that were given us via MemoryInstrumentation calls.
3430         So I extended client api with registerString method that pushes the strings
3431         down to the serializer.
3432
3433         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3434         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3435         (TestWebKitAPI::Helper::Helper):
3436         (Helper):
3437         (TestWebKitAPI::Helper::addNode):
3438         (TestWebKitAPI::TEST):
3439
3440 2013-02-25  Nico Weber  <thakis@chromium.org>
3441
3442         Make ScriptError not crash when args is a tuple
3443         https://bugs.webkit.org/show_bug.cgi?id=110747
3444
3445         Reviewed by Jochen Eisinger.
3446
3447         I'm trying to understand the error on
3448         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
3449         better. I'll likely have to revert the ninja switch on windows, but
3450         having error reporting code that doesn't itself crash sounds like a
3451         good thing to have anyways.
3452
3453         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
3454         tuple not a list.
3455
3456         * Scripts/run-chromium-webkit-unit-tests:
3457         * Scripts/webkitpy/common/system/executive.py:
3458         (ScriptError.__init__):
3459
3460 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
3461
3462         [EFL] Align feature defaults
3463         https://bugs.webkit.org/show_bug.cgi?id=110715
3464
3465         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
3466         OptionsEfl.cmake.
3467
3468         Reviewed by Gyuyoung Kim.
3469
3470         * Scripts/webkitperl/FeatureList.pm:
3471
3472 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3473
3474         run-perf-tests reports wrong commit time
3475         https://bugs.webkit.org/show_bug.cgi?id=110746
3476
3477         Reviewed by Andreas Kling.
3478
3479         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
3480         of when the subdirectory was last modified.
3481
3482         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
3483         insufficient since running "svn log -r <revision>" on a partial checkout only returns
3484         an empty result if the revision didn't modify the subdirectory.
3485
3486         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
3487         the interface compatible with svn.
3488
3489         * Scripts/webkitpy/common/checkout/scm/git.py:
3490         (Git.timestamp_of_latest_commit):
3491         * Scripts/webkitpy/common/checkout/scm/scm.py:
3492         (SCM.timestamp_of_latest_commit):
3493         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3494         (MockSCM.timestamp_of_latest_commit):
3495         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3496         (test_timestamp_of_latest_commit):
3497         * Scripts/webkitpy/common/checkout/scm/svn.py:
3498         (SVN.timestamp_of_latest_commit):
3499         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3500         (PerfTestsRunner._generate_results_dict):
3501
3502 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
3503
3504         [chromium] move WebRuntimeFeatures configuration to TestRunner library
3505         https://bugs.webkit.org/show_bug.cgi?id=110712
3506
3507         Reviewed by Nico Weber.
3508
3509         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3510         (WebTestRunner::TestInterfaces::TestInterfaces):
3511         * DumpRenderTree/chromium/TestShell.cpp:
3512         (TestShell::TestShell):
3513
3514 2013-02-25  Nico Weber  <thakis@chromium.org>
3515
3516         Make ninja the default build system for build-webkit --chromium on windows
3517         https://bugs.webkit.org/show_bug.cgi?id=110731
3518
3519         Reviewed by Jochen Eisinger.
3520
3521         With http://crbug.com/169945 fixed, this should now work.
3522
3523         * Scripts/update-webkit-chromium:
3524
3525 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
3526
3527         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
3528         https://bugs.webkit.org/show_bug.cgi?id=110702
3529
3530         Reviewed by Martin Robinson.
3531
3532         * GtkLauncher/main.c: include autotoolsconfig.h.
3533         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
3534         the include ordering check, since it uses autotoolsconfig.h which needs to
3535         come first.
3536
3537 2013-02-24  Hajime Morrita  <morrita@google.com>
3538
3539         [Custom Elements] Implement bare-bone document.register()
3540         https://bugs.webkit.org/show_bug.cgi?id=100229
3541
3542         Reviewed by Adam Barth.
3543
3544         Added enableCustomDOMElements flag.
3545
3546         * DumpRenderTree/chromium/TestShell.cpp:
3547         (TestShell::TestShell):
3548
3549 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
3550
3551         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
3552         https://bugs.webkit.org/show_bug.cgi?id=110606
3553
3554         Reviewed by Adam Barth.
3555
3556         Part of a larger refactoring series; see tracking bug 82948.
3557
3558         * DumpRenderTree/DumpRenderTree.gypi:
3559         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3560         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
3561         (WebKitSupportTestEnvironment::mockPlatform):
3562         (WebKitSupportTestEnvironment):
3563         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
3564         (MockPlatform::create):
3565         (MockPlatform::MockPlatform):
3566         (MockPlatform::~MockPlatform):
3567         (MockPlatform::setInterfaces):
3568         (MockPlatform::cryptographicallyRandomValues):
3569         (MockPlatform::createMediaStreamCenter):
3570         (MockPlatform::createRTCPeerConnectionHandler):
3571         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
3572         (MockPlatform):
3573         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
3574         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
3575         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3576         (WebTestDelegate):
3577         * DumpRenderTree/chromium/TestShell.cpp:
3578         (TestShell::initialize):
3579         * DumpRenderTree/chromium/TestShell.h:
3580         (TestShell):
3581
3582 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3583
3584         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
3585
3586         * Scripts/webkitpy/common/checkout/scm/svn.py:
3587         (SVN.timestamp_of_latest_commit):
3588
3589 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
3590
3591         Move setAutofilled from TestRunner to WebCore
3592         https://bugs.webkit.org/show_bug.cgi?id=110521
3593
3594         Reviewed by Benjamin Poulain.
3595
3596         * DumpRenderTree/TestRunner.cpp:
3597         (TestRunner::staticFunctions):
3598         * DumpRenderTree/TestRunner.h:
3599         (TestRunner):
3600         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3601         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3602         (WebTestRunner::TestRunner::TestRunner):
3603         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3604         (TestRunner):
3605         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3606         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3607         * DumpRenderTree/mac/TestRunnerMac.mm:
3608         * DumpRenderTree/qt/TestRunnerQt.cpp:
3609         * DumpRenderTree/qt/TestRunnerQt.h:
3610         (TestRunnerQt):
3611         * DumpRenderTree/win/TestRunnerWin.cpp:
3612         * DumpRenderTree/wx/TestRunnerWx.cpp:
3613
3614 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
3615
3616         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
3617         https://bugs.webkit.org/show_bug.cgi?id=108577
3618
3619         Reviewed by Dirk Pranke.
3620
3621         Upload results to perf.webkit.org using new JSON format as well as the host specified by
3622         --test-results-server. The new format is needed to provide extra information perf.webkit.org
3623         need such as the subversion commit time and test URLs. This is a temporarily measure until
3624         we complete the transition and the old JSON format and the code to upload results to
3625         webkit-perf.appspot.com can be deleted.
3626
3627         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
3628         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
3629         so that the app can sort performance test results based on the timestamp of the last commit.
3630
3631         It also changes the repository names returned by port objects to be properly capitalized
3632         human readable names such as WebKit instead of lowercased names such as webkit since these names
3633         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
3634         to explicitly lowercase the names.
3635
3636
3637         * Scripts/webkitpy/common/checkout/scm/git.py:
3638         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
3639         git's timestamp granularity is seconds so we're losing some information compared to using a regular
3640         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
3641         UTC so we're going to manually fiddle with timezone.
3642
3643         * Scripts/webkitpy/common/checkout/scm/scm.py:
3644         (SCM.timestamp_of_latest_commit): Added.
3645
3646         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3647         (MockSCM.timestamp_of_latest_commit): Added.
3648
3649         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3650         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
3651
3652         * Scripts/webkitpy/common/checkout/scm/svn.py:
3653         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
3654         the timestamp which is always in UTC.
3655
3656         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3657         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
3658         'chromium' needs to be substituted by 'chrome' for historical reasons.
3659
3660         * Scripts/webkitpy/layout_tests/port/base.py:
3661         (Port.repository_paths): Return WebKit instead of webkit as noted above.
3662
3663         * Scripts/webkitpy/layout_tests/port/chromium.py:
3664         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
3665
3666         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3667         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
3668         (PerfTestsRunner._collect_tests):
3669
3670         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
3671         and upload them appropriately.
3672
3673         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
3674         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
3675
3676         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
3677
3678         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
3679         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
3680         e.g. "processor" would be renamed to "builderProcessor".
3681
3682         (PerfTestsRunner._generate_output_files):
3683
3684         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
3685         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
3686         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
3687         webkit-perf.appspot.com which spits out a plaintext response.
3688
3689         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3690         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
3691         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
3692         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
3693
3694         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3695         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
3696         cases to parse JSON responses.
3697         (MainTest.test_upload_json.MockFileUploader): Refactored.
3698         (MainTest.test_upload_json.MockFileUploader.reset): Added.
3699         (MainTest.test_upload_json.MockFileUploader.__init__):
3700         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
3701
3702 2013-02-22  Roger Fong  <roger_fong@apple.com>
3703
3704         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
3705
3706         * BuildSlaveSupport/build.webkit.org-config/config.json:
3707
3708 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
3709
3710         Unreviewed, rolling out r143794.
3711         http://trac.webkit.org/changeset/143794
3712         https://bugs.webkit.org/show_bug.cgi?id=110542
3713
3714         debug linux builds broken?
3715
3716         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3717
3718 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
3719
3720         [chromium] enable the fixed version of freetype on linux
3721         https://bugs.webkit.org/show_bug.cgi?id=110542
3722
3723         Reviewed by Tony Chang.
3724
3725         Switch to building with a fixed version of FreeType for
3726         just DumpRenderTree. This allows us to share one version
3727         of pixel baselines for both Lucid and Precise, and run
3728         the layout tests in a stock Precise install (instead of a Lucid
3729         chroot). Going forward, this approach isolates us from os-level
3730         changes to the version of FreeType. Note that Chromium itself
3731         still uses the system FreeType and is unaffected by this change.
3732         
3733         This setting can still be turned off (at compile/gyp-time) by
3734         manually setting use_custom_freetype=0.
3735
3736         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3737
3738 2013-02-22  Anders Carlsson  <andersca@apple.com>
3739
3740         Move pluginLoadPolicy to the page loader client
3741         https://bugs.webkit.org/show_bug.cgi?id=110635
3742
3743         Reviewed by Sam Weinig.
3744
3745         * MiniBrowser/mac/WK2BrowserWindowController.m:
3746         (-[WK2BrowserWindowController awakeFromNib]):
3747         * WebKitTestRunner/TestController.cpp:
3748         (WTR::TestController::createOtherPage):
3749         (WTR::TestController::createWebViewWithOptions):
3750
3751 2013-02-22  Kenneth Russell  <kbr@google.com>
3752
3753         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
3754
3755         * Scripts/webkitpy/common/config/committers.py:
3756
3757 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3758
3759         [WTR] Do not dump information about empty subframes.
3760         https://bugs.webkit.org/show_bug.cgi?id=110585
3761
3762         Reviewed by Simon Fraser.
3763
3764         Follow DumpRenderTree more closely by skipping empty frames
3765         (frames which have no document). We are not really interested in
3766         showing anything about them.
3767
3768         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3769         (WTR::dumpDescendantFramesText): Do not print subframe names when they
3770         have no associated Document.
3771
3772 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3773
3774         [EFL][DRT] Do not dump empty frames.
3775         https://bugs.webkit.org/show_bug.cgi?id=110474
3776
3777         Reviewed by Kenneth Rohde Christiansen.
3778
3779         Follow the original Mac implementation more closely by skipping
3780         empty frames (frames which have no document). We are not really
3781         interested in showing anything about them.
3782
3783         * DumpRenderTree/efl/DumpRenderTree.cpp:
3784         (dumpFramesAsText):
3785
3786 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
3787
3788         [chromium] support the lucid version of freetype on precise in DRT
3789         https://bugs.webkit.org/show_bug.cgi?id=107338
3790
3791         Reviewed by Tony Chang.
3792
3793         Modify the DRT build so that we can optionally link against
3794         a fixed version of Freetype2. This allows us to share pixel test
3795         results across multiple versions of Ubuntu without having to
3796         worry about differences in font rendering.
3797
3798         At the moment this feature is off by default. Eventually it will
3799         be on by default on linux.
3800
3801         Note that this only affects DRT; the regular Chromium binary
3802         (and, for now, content_shell) will still use the system version
3803         of Freetype.
3804
3805         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3806
3807 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
3808
3809         [Chromium] Remove the word "cheher" from the list of misspelled words
3810         https://bugs.webkit.org/show_bug.cgi?id=110447
3811
3812         Reviewed by Tony Chang.
3813
3814         Other platforms do not mark "cheher" as a misspelled word in layout tests.
3815         This change is to bring Chromium platform in line with the rest of the
3816         platforms.
3817
3818         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
3819         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
3820         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
3821         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
3822
3823 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
3824
3825         [chromium] document WebTestDelegate and WebTestRunner interfaces
3826         https://bugs.webkit.org/show_bug.cgi?id=110472
3827
3828         Reviewed by Adam Barth.
3829
3830         Also remove the default implementation of the remaining WebTestDelegate
3831         methods now that all embedders provide this interface.
3832
3833         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3834         (WebTestDelegate):
3835         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3836         (WebTestRunner):
3837
3838 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
3839
3840         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
3841         https://bugs.webkit.org/show_bug.cgi?id=106059
3842
3843         Reviewed by Geoffrey Garen.
3844
3845         Added new tests for the WebKit API portion of the JSC Objective-C API.
3846
3847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3848         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
3849         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
3850         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
3851         (-[MyConsole log:]):
3852         (-[MyConsole printHelloWorld]):
3853         (-[MyConsole add:to:]):
3854         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
3855         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3856         (TestWebKitAPI):
3857         (TestWebKitAPI::TEST):
3858
3859 2013-02-21  Stephen Chenney  <schenney@chromium.org>
3860
3861         Unreviewed, add myself as a reviewer
3862
3863         * Scripts/webkitpy/common/config/committers.py:
3864
3865 2013-02-21  Jer Noble  <jer.noble@apple.com>
3866
3867         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
3868
3869         * Scripts/webkitpy/common/config/committers.py:
3870         * Scripts/webkitpy/common/config/watchlist:
3871
3872 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
3873
3874         gtk/DumpRenderTree.cpp is missing <locale.h> include
3875         https://bugs.webkit.org/show_bug.cgi?id=109386
3876
3877         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
3878         by include locale.h when we use setlocale.
3879
3880 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
3881
3882         [GTK] Move feature overriding to the configure phase
3883         https://bugs.webkit.org/show_bug.cgi?id=110293
3884
3885         Reviewed by Gustavo Noronha Silva.
3886
3887         * Scripts/webkitdirs.pm:
3888         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
3889         WebKitFeatureOverrides.txt to better match the other filenames used in
3890         the new feature processing.
3891         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
3892         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
3893         and writes WebKitFeatures.txt and WebKitFeatures.h.
3894         * gtk/override-feature-defines: Removed.
3895
3896 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3897
3898         [Qt] Remove obsolete DEPENDPATH assignment
3899
3900         Reviewed by Simon Hausmann
3901
3902         qmake now adds CONFIG+=depend_includepath by default, making manual
3903         DEPENDPATH setup unnecessary.
3904
3905         * qmake/mkspecs/features/default_post.prf:
3906
3907 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
3908
3909         Unreviewed. Changing primary email id.
3910
3911         * Scripts/webkitpy/common/config/committers.py:
3912
3913 2013-02-14  James Robinson  <jamesr@chromium.org>
3914
3915         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
3916         https://bugs.webkit.org/show_bug.cgi?id=109634
3917
3918         Reviewed by Adrienne Walker.
3919
3920         * DumpRenderTree/chromium/WebViewHost.cpp:
3921         (WebViewHost::createOutputSurface):
3922         (WebViewHost::initializeLayerTreeView):
3923
3924 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
3925
3926         [GTK] Re-enable 3D CSS transforms when using build-webkit
3927         https://bugs.webkit.org/show_bug.cgi?id=110402
3928
3929         Reviewed by Xan Lopez.
3930
3931         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
3932         when building WebKitGTK+.
3933
3934 2013-02-20  Roger Fong  <roger_fong@apple.com>
3935
3936         Get VS2010 Solution B&I ready.
3937         <rdar://problem/1322988>
3938
3939         Rubberstamped by Timothy Horton.        
3940         
3941         Add Production configurations.
3942         
3943         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3944         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3945         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
3946         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3947         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
3948         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3949         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3950         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3951         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
3952         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3953         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
3954         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3955         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3956         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
3957         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3958         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3959         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
3960         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3961         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3962         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3963         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
3964         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3965         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
3966         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3967         * win/record-memory/record-memory.vcxproj:
3968         * win/record-memory/record-memoryProduction.props: Added.
3969         * win/record-memory/record-memoryRelease.props:
3970
3971 2013-02-20  Dirk Schulze  <krit@webkit.org>
3972
3973         Enable CANVAS_PATH flag
3974         https://bugs.webkit.org/show_bug.cgi?id=108508
3975
3976         Reviewed by Simon Fraser.
3977
3978         Enable CANVAS_PATH flag on trunk.
3979
3980         * Scripts/webkitperl/FeatureList.pm:
3981
3982 2013-02-20  Tony Chang  <tony@chromium.org>
3983
3984         Parse author names with commas in ChangeLogs
3985         https://bugs.webkit.org/show_bug.cgi?id=110356
3986
3987         Reviewed by Dirk Pranke.
3988
3989         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
3990
3991         * Scripts/webkitpy/common/checkout/changelog.py:
3992         (ChangeLogEntry): Move name splitting regexp into a constant.
3993         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
3994         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
3995         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
3996         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
3997         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3998         (test_parse_authors): Test case with Paweł's name.
3999
4000 2013-02-15  Dirk Schulze  <krit@webkit.org>
4001
4002         [Chromium] Add runtime flag for CanvasPath
4003         https://bugs.webkit.org/show_bug.cgi?id=109997
4004
4005         Reviewed by Adam Barth.
4006
4007         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
4008         the constructor for Path on DOMWindow would never be activatable, since the script
4009         is running after creating the DOMWindow object.
4010
4011         * DumpRenderTree/chromium/TestShell.cpp:
4012         (TestShell::TestShell):
4013
4014 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
4015
4016         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
4017         https://bugs.webkit.org/show_bug.cgi?id=110346
4018
4019         Reviewed by Adam Barth.
4020
4021         Using an index is very brittle, as the TestRunner API does not define
4022         any ordering of windows.
4023
4024         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
4025         trigger the capturing in the browser process before generating the
4026         text dump.
4027
4028         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4029         (WebTestRunner):
4030         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
4031         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
4032         (WebTestRunner):
4033         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4034         (TestRunner):
4035         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4036         (WebTestRunner::WebTestProxyBase::captureTree):
4037         * DumpRenderTree/chromium/WebViewHost.cpp:
4038         (WebViewHost::captureHistoryForWindow):
4039         * DumpRenderTree/chromium/WebViewHost.h:
4040         (WebViewHost):
4041
4042 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
4043
4044         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
4045         https://bugs.webkit.org/show_bug.cgi?id=109220
4046
4047         Reviewed by Tony Chang.
4048
4049         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
4050         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
4051         (WebTestRunner):
4052         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
4053         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
4054         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
4055         (MockSpellCheck):
4056         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
4057         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
4058
4059 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4060
4061         [Gtk] HTML5 Media controls require a design refresh
4062         https://bugs.webkit.org/show_bug.cgi?id=83869
4063
4064         Reviewed by Philippe Normand.
4065
4066         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4067         (initializeGtkFontSettings): Added gnome as default icon theme for
4068         the DRT.
4069         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4070         (WTR::initializeGtkSettings): Added gnome as default icon theme for
4071         the WTR.
4072         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
4073         dependency.
4074
4075 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
4076
4077         [chromium] move most of the remaining mocks to TestRunner library
4078         https://bugs.webkit.org/show_bug.cgi?id=110217
4079
4080         Reviewed by Nico Weber.
4081
4082         While most of the functionality provided by these mocks is also
4083         available in the content module, there is no straight forward way to
4084         inject the mock results required for layout tests.
4085
4086         * DumpRenderTree/DumpRenderTree.gypi:
4087         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4088         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4089         (WebKit):
4090         (WebTestRunner):
4091         (WebTestRunner::WebTestProxy::geolocationClient):
4092         (WebTestRunner::WebTestProxy::speechInputController):
4093         (WebTestRunner::WebTestProxy::speechRecognizer):
4094         (WebTestRunner::WebTestProxy::deviceOrientationClient):
4095         (WebTestRunner::WebTestProxy::requestPointerLock):
4096         (WebTestRunner::WebTestProxy::requestPointerUnlock):
4097         (WebTestRunner::WebTestProxy::isPointerLocked):
4098         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
4099         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
4100         (WebTestRunner):
4101         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
4102         (WebTestRunner::MockWebSpeechInputController::setDelegate):
4103         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
4104         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
4105         (WebTestRunner::MockWebSpeechInputController::clearResults):
4106         (WebTestRunner::MockWebSpeechInputController::startRecognition):
4107         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
4108         (WebTestRunner::MockWebSpeechInputController::stopRecording):
4109         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
4110         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
4111         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
4112         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
4113         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
4114         (WebKit):
4115         (WebTestRunner):
4116         (MockWebSpeechInputController):
4117         (WebTestRunner::MockWebSpeechInputController::taskList):
4118         (SpeechTask):
4119         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
4120         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
4121         (WebTestRunner):
4122         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
4123         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
4124         (WebTestRunner::MockWebSpeechRecognizer::start):
4125         (WebTestRunner::MockWebSpeechRecognizer::stop):
4126         (WebTestRunner::MockWebSpeechRecognizer::abort):
4127         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
4128         (WebTestRunner::MockWebSpeechRecognizer::setError):
4129         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
4130         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
4131         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
4132         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
4133         (WebKit):
4134         (WebTestRunner):
4135         (MockWebSpeechRecognizer):
4136         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
4137         (WebTestRunner::MockWebSpeechRecognizer::client):
4138         (WebTestRunner::MockWebSpeechRecognizer::handle):
4139         (WebTestRunner::MockWebSpeechRecognizer::taskList):
4140         (Task):
4141         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
4142         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
4143         (StepTask):
4144         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
4145         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4146         (WebTestRunner::TestInterfaces::TestInterfaces):
4147         (WebTestRunner::TestInterfaces::windowOpened):
4148         (WebTestRunner):
4149         (WebTestRunner::TestInterfaces::windowClosed):
4150         (WebTestRunner::TestInterfaces::windowList):
4151         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4152         (TestInterfaces):
4153         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4154         (WebTestRunner::TestRunner::TestRunner):
4155         (WebTestRunner::TestRunner::reset):
4156         (WebTestRunner::TestRunner::requestPointerLock):
4157         (WebTestRunner):
4158         (WebTestRunner::TestRunner::requestPointerUnlock):
4159         (WebTestRunner::TestRunner::isPointerLocked):
4160         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
4161         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
4162         (WebTestRunner::TestRunner::didLosePointerLockInternal):
4163         (WebTestRunner::TestRunner::windowCount):
4164         (WebTestRunner::TestRunner::setMockDeviceOrientation):
4165         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
4166         (WebTestRunner::TestRunner::setGeolocationPermission):
4167         (WebTestRunner::TestRunner::setMockGeolocationPosition):
4168         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
4169         (WebTestRunner::TestRunner::addMockSpeechInputResult):
4170         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
4171         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
4172         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
4173         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
4174         (WebTestRunner::TestRunner::didAcquirePointerLock):
4175         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
4176         (WebTestRunner::TestRunner::didLosePointerLock):
4177         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
4178         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
4179         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4180         (WebTestRunner):
4181         (TestRunner):
4182         (HostMethodTask):
4183         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
4184         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
4185         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4186         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
4187         (WebTestRunner::WebTestProxyBase::setInterfaces):
4188         (WebTestRunner::WebTestProxyBase::setDelegate):
4189         (WebTestRunner::WebTestProxyBase::reset):
4190         (WebTestRunner::WebTestProxyBase::captureTree):
4191         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
4192         (WebTestRunner):
4193         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
4194         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
4195         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
4196         (WebTestRunner::WebTestProxyBase::geolocationClient):
4197         (WebTestRunner::WebTestProxyBase::speechInputController):
4198         (WebTestRunner::WebTestProxyBase::speechRecognizer):
4199         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
4200         (WebTestRunner::WebTestProxyBase::requestPointerLock):
4201         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
4202         (WebTestRunner::WebTestProxyBase::isPointerLocked):
4203         * DumpRenderTree/chromium/WebViewHost.cpp:
4204         (WebViewHost::reset):
4205         * DumpRenderTree/chromium/WebViewHost.h:
4206         (WebKit):
4207         (WebViewHost):
4208
4209 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
4210
4211         [Qt] Make debug builds possible on 32bit Linux
4212         https://bugs.webkit.org/show_bug.cgi?id=110231
4213
4214         Reviewed by Tor Arne Vestbø.
4215
4216         Use the stabs format for debug builds to make the object files
4217         a bit smaller so that they can be linked on a 32bit system.
4218
4219         * qmake/mkspecs/features/unix/default_post.prf:
4220
4221 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
4222
4223         Unreviewed. Add myself to watch lists.
4224
4225         * Scripts/webkitpy/common/config/committers.py:
4226         * Scripts/webkitpy/common/config/watchlist:
4227
4228 2013-02-19  Joshua Bell  <jsbell@chromium.org>
4229
4230         Remove warning from run-bindings-tests
4231         https://bugs.webkit.org/show_bug.cgi?id=110285
4232
4233         Reviewed by Kentaro Hara.
4234
4235         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
4236         "Unknown option: idlattributesfile". That option was removed from
4237         bindings/scripts/preprocess-idls.pl but was still being passed by
4238         the test script. Remove it.
4239
4240         * Scripts/webkitpy/bindings/main.py:
4241         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
4242
4243 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
4244
4245         Unreviewed. Add myself to watch lists.
4246
4247         * Scripts/webkitpy/common/config/committers.py:
4248         * Scripts/webkitpy/common/config/watchlist:
4249
4250 2013-02-19  Hans Muller  <hmuller@adobe.com>
4251
4252         Unreviewed, corrected primary email.
4253
4254         * Scripts/webkitpy/common/config/committers.py:
4255
4256 2013-02-19  Hans Muller  <hmuller@adobe.com>
4257
4258         Unreviewed. Adding myself as a committer.
4259
4260         * Scripts/webkitpy/common/config/committers.py:
4261
4262 2013-02-19  Pravin D  <pravind@webkit.org>
4263
4264         Unreviewed, changing primary email.
4265
4266         * Scripts/webkitpy/common/config/committers.py:
4267
4268 2013-02-19  Alan Cutter  <alancutter@chromium.org>
4269
4270         REGRESSION: Sheriffbot is failing to process rollout requests
4271         https://bugs.webkit.org/show_bug.cgi?id=106945
4272
4273         Reviewed by Adam Barth.
4274
4275         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
4276         This resolves problems when Sheriffbot attempts to perform a rollout request.
4277
4278         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
4279         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
4280         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
4281
4282 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
4283
4284         Unreviewed build fix.
4285
4286         * efl/jhbuild.modules:
4287         * gtk/jhbuild.modules:
4288
4289         Bump harfbuzz module to 0.9.7. See related bug 110145.
4290
4291 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
4292
4293         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
4294         https://bugs.webkit.org/show_bug.cgi?id=110215
4295
4296         Reviewed by Tor Arne Vestbø.
4297
4298         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
4299         continuing the build. Otherwise skip with an error message explaining which
4300         programs are missing from the build.
4301
4302         * qmake/mkspecs/features/configure.prf:
4303         * qmake/mkspecs/features/functions.prf:
4304
4305 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
4306
4307         Unreviewed, rolling out r143319.
4308         http://trac.webkit.org/changeset/143319
4309         https://bugs.webkit.org/show_bug.cgi?id=110214
4310