Source/JavaScriptCore:
[WebKit-https.git] / Tools / ChangeLog
1 2015-06-24  Doug Russell  <d_russell@apple.com>
2
3         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
4         when posting a selection notification when on the border between two accessibilityObjects
5         https://bugs.webkit.org/show_bug.cgi?id=146177
6
7         Reviewed by Darin Adler.
8
9         Add support for mapping WebCore Accessibility types into JSValueRef types
10         so they can be used in tests.
11
12         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
13         (webAccessibilityObjectWrapperClass):
14         (-[AccessibilityNotificationHandler startObserving]):
15         (makeValueRefForValue):
16         (makeArrayRefForArray):
17         (makeObjectRefForDictionary):
18         (-[AccessibilityNotificationHandler _notificationReceived:]):
19         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
20         (webAccessibilityObjectWrapperClass):
21         (-[AccessibilityNotificationHandler startObserving]):
22         (makeValueRefForValue):
23         (makeArrayRefForArray):
24         (makeObjectRefForDictionary):
25         (-[AccessibilityNotificationHandler _notificationReceived:]):
26
27 2015-06-24  Zalan Bujtas  <zalan@apple.com>
28
29         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
30         https://bugs.webkit.org/show_bug.cgi?id=146273
31         rdar://problem/18509840
32
33         Reviewed by Simon Fraser.
34
35         Due to the floating point approximate representation, we can't always produce
36         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
37         and by changing the rounding in roundToDevicePixel() from float to double.
38
39         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
40         (TestWebKitAPI::TEST):
41
42 2015-06-24  Brady Eidson  <beidson@apple.com>
43
44         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
45         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
46
47         Reviewed by Alex Christensen.
48
49         - Update WKTR to the new client structure.
50         - Update existing TestWebKitAPI tests to either use the new client structure or
51           assign the old function signature to the updated variable name.
52         - Include a new test.
53
54         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
55
56         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
57         (TestWebKitAPI::runJavaScriptAlert):
58
59         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
60         (TestWebKitAPI::TEST):
61
62         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
63         (TestWebKitAPI::analyzeDialogArguments):
64         (TestWebKitAPI::runJavaScriptAlert):
65         (TestWebKitAPI::runJavaScriptConfirm):
66         (TestWebKitAPI::runJavaScriptPrompt):
67         (TestWebKitAPI::createNewPage):
68         (TestWebKitAPI::TEST):
69
70         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
71         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
72
73         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
74         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
75
76         * WebKitTestRunner/TestController.cpp:
77         (WTR::TestController::createOtherPage):
78         (WTR::TestController::createWebViewWithOptions):
79
80 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
81
82         Refactoring benchmark runner script to follow pep8 code style.
83         https://bugs.webkit.org/show_bug.cgi?id=146264
84
85         Reviewed by Ryosuke Niwa.
86
87         Refactor benchmark runner script to follow pep8 code style.
88
89         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
90         (GenericBenchmarkBuilder.prepare):
91         (GenericBenchmarkBuilder._run_create_script):
92         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
93         (GenericBenchmarkBuilder._fetch_remote_archive):
94         (GenericBenchmarkBuilder):
95         (GenericBenchmarkBuilder._checkout_with_subversion):
96         (GenericBenchmarkBuilder._apply_patch):
97         (GenericBenchmarkBuilder.clean):
98         (GenericBenchmarkBuilder._runCreateScript): Deleted.
99         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
100         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
101         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
102         (GenericBenchmarkBuilder._applyPatch): Deleted.
103         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
104         (BenchmarkRunner.__init__):
105         (BenchmarkRunner._find_plan_file):
106         (BenchmarkRunner.execute):
107         (BenchmarkRunner._cleanup):
108         (BenchmarkRunner._dump):
109         (BenchmarkRunner._wrap):
110         (BenchmarkRunner._merge):
111         (BenchmarkRunner._show_results):
112         (BenchmarkRunner._findPlanFile): Deleted.
113         (BenchmarkRunner.cleanup): Deleted.
114         (BenchmarkRunner.dump): Deleted.
115         (BenchmarkRunner.wrap): Deleted.
116         (BenchmarkRunner.merge): Deleted.
117         (BenchmarkRunner.show_results): Deleted.
118         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
119         (BrowserDriver.prepare_env):
120         (BrowserDriver.launch_url):
121         (BrowserDriver.close_browsers):
122         (BrowserDriver.prepareEnv): Deleted.
123         (BrowserDriver.launchUrl): Deleted.
124         (BrowserDriver.closeBrowser): Deleted.
125         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
126         (OSXBrowserDriver):
127         (OSXBrowserDriver.prepare_env):
128         (OSXBrowserDriver.close_browsers):
129         (OSXBrowserDriver._launch_process):
130         (OSXBrowserDriver._terminiate_processes):
131         (OSXBrowserDriver._launch_process_with_caffinate):
132         (OSXBrowserDriver._screen_size):
133         (OSXBrowserDriver.prepareEnv): Deleted.
134         (OSXBrowserDriver.closeBrowsers): Deleted.
135         (OSXBrowserDriver.launchProcess): Deleted.
136         (OSXBrowserDriver.terminateProcesses): Deleted.
137         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
138         (OSXBrowserDriver.screenSize): Deleted.
139         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
140         (OSXChromeDriver):
141         (OSXChromeDriver.launch_url):
142         (OSXChromeCanaryDriver):
143         (OSXChromeCanaryDriver.launch_url):
144         (OSXChromeDriver.launchUrl): Deleted.
145         (OSXChromeCanaryDriver.launchUrl): Deleted.
146         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
147         (OSXFirefoxDriver):
148         (OSXFirefoxDriver.launch_url):
149         (OSXFirefoxNightlyDriver):
150         (OSXFirefoxNightlyDriver.launch_url):
151         (OSXFirefoxDriver.launchUrl): Deleted.
152         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
153         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
154         (OSXSafariDriver):
155         (OSXSafariDriver.prepare_env):
156         (OSXSafariDriver.launch_url):
157         (OSXSafariDriver.close_browsers):
158         (OSXSafariDriver._maximize_window):
159         (OSXSafariDriver.prepareEnv): Deleted.
160         (OSXSafariDriver.launchUrl): Deleted.
161         (OSXSafariDriver.closeBrowsers): Deleted.
162         (OSXSafariDriver.maximizeWindow): Deleted.
163         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
164         (HTTPServerDriver.fetch_result):
165         (HTTPServerDriver.kill_server):
166         (HTTPServerDriver.get_return_code):
167         (HTTPServerDriver.set_device_id):
168         (HTTPServerDriver.fetchResult): Deleted.
169         (HTTPServerDriver.killServer): Deleted.
170         (HTTPServerDriver.getReturnCode): Deleted.
171         (HTTPServerDriver.setDeviceID): Deleted.
172         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
173         (SimpleHTTPServerDriver.serve):
174         (SimpleHTTPServerDriver.base_url):
175         (SimpleHTTPServerDriver.fetch_result):
176         (SimpleHTTPServerDriver.kill_server):
177         (SimpleHTTPServerDriver.get_return_code):
178         (SimpleHTTPServerDriver): Deleted.
179         (SimpleHTTPServerDriver.baseUrl): Deleted.
180         (SimpleHTTPServerDriver.fetchResult): Deleted.
181         (SimpleHTTPServerDriver.killServer): Deleted.
182         (SimpleHTTPServerDriver.getReturnCode): Deleted.
183         * Scripts/webkitpy/benchmark_runner/utils.py:
184         (get_path_from_project_root):
185         (force_remove):
186         (getPathFromProjectRoot): Deleted.
187         (forceRemove): Deleted.
188
189 2015-06-23  Anders Carlsson  <andersca@apple.com>
190
191         Add operator! and copy/move constructors to WeakObjCPtr
192         https://bugs.webkit.org/show_bug.cgi?id=146255
193
194         Reviewed by Andreas Kling.
195
196         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
197         (TEST):
198
199 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
200
201         Expose some more rendering progress events, and have MiniBrowser log for each of them
202         https://bugs.webkit.org/show_bug.cgi?id=146227
203
204         Reviewed by Darin Adler.
205
206         Register for layout milestones/rendering progress events in the WK1 and WK2
207         browser window controllers, and, if logging is turned on, log when they are
208         reached.
209
210         * MiniBrowser/mac/WK1BrowserWindowController.m:
211         (-[WK1BrowserWindowController awakeFromNib]):
212         (-[WK1BrowserWindowController webView:didLayout:]):
213         * MiniBrowser/mac/WK2BrowserWindowController.m:
214         (-[WK2BrowserWindowController awakeFromNib]):
215         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
216
217 2015-06-23  Brady Eidson  <beidson@apple.com>
218
219         WKFrameInfo should have an accessor for the Frame's current security origin.
220         https://bugs.webkit.org/show_bug.cgi?id=146162
221
222         Reviewed by Dan Bernstein.
223
224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
225         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
226         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
227         (sawDialog):
228         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
229         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
230         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
231         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
232         (TEST):
233
234 2015-06-23  Tanay C  <tanay.c@samsung.com>
235
236         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
237         https://bugs.webkit.org/show_bug.cgi?id=146007
238
239         Reviewed by Darin Adler.
240
241         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
242         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
243         (pluginLogWithWindowObject):
244         (pluginLogWithArguments):
245         (pluginLog):
246         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
247         (PluginTest::executeScript):
248         (PluginTest::log):
249
250 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
251
252         [EFL] Add libhyphen-dev as dependency after r185862
253         https://bugs.webkit.org/show_bug.cgi?id=146230
254
255         Reviewed by Gyuyoung Kim.
256
257         * efl/install-dependencies:
258
259 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
260
261         [EFL] Hyphenation is not supported
262         https://bugs.webkit.org/show_bug.cgi?id=89830
263
264         Reviewed by Gyuyoung Kim.
265
266         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
267
268 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
269
270         Get rid of factory json files in benchmark_runner
271         https://bugs.webkit.org/show_bug.cgi?id=146175
272
273         Reviewed by Ryosuke Niwa.
274
275         Get rid of factory json files in benchmark_runner and refactoring the code.
276
277         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
278         (benchmark_builder_loader):
279         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
280         (BenchmarkBuilderFactory):
281         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
282         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
283         (GenericBenchmarkBuilder):
284         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
285         (BenchmarkRunner.__init__):
286         (BenchmarkRunner.execute):
287         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
288         (browser_driver_loader):
289         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
290         (BrowserDriver):
291         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
292         (BrowserDriverFactory):
293         (BrowserDriverFactory.available_platforms):
294         (BrowserDriverFactory.available_browsers):
295         (BrowserDriverFactory.add_browser_driver):
296         (BrowserDriverFactory.create):
297         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
298         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
299         (OSXBrowserDriver):
300         (OSXBrowserDriver.prepareEnv):
301         (OSXBrowserDriver.terminateProcesses):
302         (OSXBrowserDriver.screenSize):
303         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
304         (OSXChromeDriver):
305         (OSXChromeCanaryDriver):
306         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
307         (OSXFirefoxDriver):
308         (OSXFirefoxNightlyDriver):
309         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
310         (OSXSafariDriver):
311         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
312         (GenericFactory.create):
313         (GenericFactory.add):
314         (GenericFactory.iterateGetItem): Deleted.
315         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
316         (http_server_driver_loader):
317         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
318         (HTTPServerDriver):
319         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
320         (HTTPServerDriverFactory):
321         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
322         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
323         (SimpleHTTPServerDriver):
324         * Scripts/webkitpy/benchmark_runner/utils.py:
325         (is_subclass):
326         (load_subclasses):
327         (ModuleNotFoundError): Deleted.
328         (loadModule): Deleted.
329         (loadJSONFromFile): Deleted.
330
331 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
332
333         Make it possible to enable incremental rendering suppression in MiniBrowser
334         https://bugs.webkit.org/show_bug.cgi?id=146223
335         
336         Reviewed by Tim Horton.
337
338         Add a menu item to enable incremental rendering suppression to MiniBrowser.
339         
340         For WK1, this just toggles a pref, and takes effect immediately.
341         
342         For WK2, this is a WKConfiguration property, so only affects new web views.
343         
344         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
345         logging on launch.
346
347         * MiniBrowser/mac/AppDelegate.m:
348         (defaultConfiguration):
349         * MiniBrowser/mac/BrowserWindow.xib:
350         * MiniBrowser/mac/SettingsController.h:
351         * MiniBrowser/mac/SettingsController.m:
352         (-[SettingsController _populateMenu]):
353         (-[SettingsController validateMenuItem:]):
354         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
355         (-[SettingsController incrementalRenderingSuppressed]):
356         * MiniBrowser/mac/WK1BrowserWindowController.m:
357         (-[WK1BrowserWindowController didChangeSettings]):
358
359 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
360
361         Run CDjs as part of JSC stress testing
362         https://bugs.webkit.org/show_bug.cgi?id=146174
363
364         Reviewed by Geoffrey Garen.
365
366         * Scripts/run-javascriptcore-tests:
367         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
368         * Scripts/run-jsc-stress-tests:
369         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
370         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
371         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
372
373 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
374
375         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
376         https://bugs.webkit.org/show_bug.cgi?id=146121
377         rdar://problem/21395180
378
379         Reviewed by Darin Adler.
380
381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
382         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
383         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
384         (TestWebKitAPI::overrideAppleLanguages):
385         (TestWebKitAPI::languageForSystemLanguage):
386         (TestWebKitAPI::TEST):
387
388 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
389
390         [CMake] Ignore warnings from system headers when compiling Tools
391         https://bugs.webkit.org/show_bug.cgi?id=146185
392
393         Reviewed by Martin Robinson.
394
395         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
396         from system headers that we don't control.
397
398         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
399         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
400         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
401         * ImageDiff/PlatformGTK.cmake:
402         * MiniBrowser/efl/CMakeLists.txt:
403         * MiniBrowser/gtk/CMakeLists.txt:
404         * TestWebKitAPI/PlatformEfl.cmake:
405         * TestWebKitAPI/PlatformGTK.cmake:
406         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
407         * WebKitTestRunner/CMakeLists.txt:
408         * WebKitTestRunner/PlatformEfl.cmake:
409         * WebKitTestRunner/PlatformGTK.cmake:
410
411 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
412
413         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
414         https://bugs.webkit.org/show_bug.cgi?id=146186
415
416         Reviewed by Martin Robinson.
417
418         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
419         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
420
421         * MiniBrowser/gtk/CMakeLists.txt:
422
423 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
424
425         Build fix after r146125.
426
427         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
428         (OSXSafariDriver):
429         (OSXSafariDriver.prepareEnv):
430
431 2015-06-19  Brady Eidson  <beidson@apple.com>
432
433         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
434         https://bugs.webkit.org/show_bug.cgi?id=146152
435
436         Reviewed by Dan Bernstein.
437
438         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
439         * WebKitTestRunner/WebNotificationProvider.cpp:
440
441 2015-06-19  Mark Lam  <mark.lam@apple.com>
442
443         CheckedArithmetic's operator bool() and operator==() is broken.
444         https://bugs.webkit.org/show_bug.cgi?id=146129
445
446         Reviewed by Geoffrey Garen and Oliver Hunt.
447
448         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
449         and overflow scenarios in usage of the Checked arithmetic class.
450
451         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
452         (TestWebKitAPI::OverflowCrashLogger::overflowed):
453         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
454         (TestWebKitAPI::OverflowCrashLogger::crash):
455         (TestWebKitAPI::OverflowCrashLogger::reset):
456         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
457         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
458         (TestWebKitAPI::OverflowCrashLogger::didCrash):
459         - crash logger for verifying that a crash occurs when expected. 
460
461         (TestWebKitAPI::resetOverflow):
462         - convenience function for resetting a test value to an initial overflowed state
463           before a crash.  We will use this value in the overflow testing.
464
465         (TestWebKitAPI::CheckedArithmeticTester::run):
466         - Added new tests for all the comparison operators.
467
468 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
469
470         Fix the Windows build after r185721
471         https://bugs.webkit.org/show_bug.cgi?id=146146
472
473         Reviewed by Csaba Osztrogonác.
474
475         Speculative buildfix.
476
477         * DumpRenderTree/win/UIDelegate.h:
478         (UIDelegate::unused4): Added.
479         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
480
481 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
482
483         Unreviewed. Add myself as a committer.
484
485         * Scripts/webkitpy/common/config/contributors.json:
486
487 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
488
489         Remove unnecessary svn:executable flags
490         https://bugs.webkit.org/show_bug.cgi?id=146107
491
492         Reviewed by Alexey Proskuryakov.
493
494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
499         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
500         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
501         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
502         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
503         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
504         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
505         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
506         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
507         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
508
509 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
510
511         Disable tests on the WinCairo buildbot
512         https://bugs.webkit.org/show_bug.cgi?id=146106
513
514         Reviewed by Alexey Proskuryakov.
515
516         * BuildSlaveSupport/build.webkit.org-config/config.json:
517         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
518
519 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
520
521         [EFL] Fix the minibrowser after r185725
522         https://bugs.webkit.org/show_bug.cgi?id=146135
523
524         Reviewed by Gyuyoung Kim.
525
526         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
527         for the elm_config_accel_preference_set() to set the config of acceleration preference.
528
529         * MiniBrowser/efl/main.c:
530         (elm_main): Deleted the HAVE_ECORE_X guard.
531
532 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
533
534         Extend capability of run-benchmark script to support mobile device
535         https://bugs.webkit.org/show_bug.cgi?id=146125
536
537         Reviewed by Ryosuke Niwa.
538
539         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
540         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
541
542         * Scripts/run-benchmark:
543         (main): Deleted.
544         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
545         (BenchmarkRunner.__init__):
546         (BenchmarkRunner.execute):
547         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
548         (BrowserDriver.prepareEnv):
549         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
550         (OSXBrowserDriver.prepareEnv):
551         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
552         (OSXSafariDriver.prepareEnv):
553         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
554         (HTTPServerDriver.getReturnCode):
555         (HTTPServerDriver):
556         (HTTPServerDriver.setDeviceID):
557         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
558         (parse_args):
559         (start):
560         (main):
561         * Scripts/webkitpy/benchmark_runner/utils.py:
562         (getPathFromProjectRoot):
563
564 2015-06-18  Jon Lee  <jonlee@apple.com>
565
566         Unreviewed. Add Matt Daiter as a contributor.
567
568         * Scripts/webkitpy/common/config/contributors.json:
569
570 2015-06-18  Mark Lam  <mark.lam@apple.com>
571
572         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
573         https://bugs.webkit.org/show_bug.cgi?id=146103
574
575         Not reviewed.
576
577         Follow up to fix some typos not caught before original patch was landed.
578
579         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
580         (TestWebKitAPI::CheckedArithmeticTester::run):
581         (TestWebKitAPI::AllowMixedSignednessTest::run):
582         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
583
584 2015-06-18  Daniel Bates  <dabates@apple.com>
585
586         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
587         https://bugs.webkit.org/show_bug.cgi?id=146082
588
589         Reviewed by Darin Adler.
590
591         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
592         working directory after being invoked in a different Git checkout. In particular,
593         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
594         a pure Git checkout g will fail to update g.
595
596         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
597         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
598         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
599         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
600         different than the current working directory). Instead runGitUpdate() should check
601         whether the current working directory is a Git SVN checkout on each invocation.
602
603         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
604         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
605         SVN directory from isGitSVN().
606         (isGitSVN): Implemented in terms of isGitSVNDirectory().
607         * Scripts/webkitdirs.pm:
608         (runGitUpdate): Modified to use isGitSVNDirectory().
609
610 2015-06-18  Mark Lam  <mark.lam@apple.com>
611
612         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
613         https://bugs.webkit.org/show_bug.cgi?id=146103
614
615         Reviewed by Anders Carlsson.
616
617         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
618         part of a large macro.  This makes them harder to:
619
620         1. write: no editor help with indentations, have to add trailing '\'s,
621            inconvenient to add line breaks and comments.
622
623         2. read: no chroma coding / syntax highlighting.
624
625         3. debug: compile time errors are reported as being on the single line where
626            the macro is used.
627
628         Refactoring the tests to use C++ templates solves all these issues.
629
630         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
631         (TestWebKitAPI::CheckedArithmeticTester::run):
632         (TestWebKitAPI::AllowMixedSignednessTest::run):
633         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
634         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
635         (TestWebKitAPI::CoerceLiteralNop::coerce):
636
637 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
638
639         [EFL][WK2] Use Web Browser cache model in MiniBrowser
640         https://bugs.webkit.org/show_bug.cgi?id=112273
641
642         Reviewed by Laszlo Gombos.
643
644         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
645         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
646         This way we have a decent cache capacity and the page cache actually works.
647
648         * MiniBrowser/efl/main.c:
649         (elm_main):
650
651 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
652
653         Remove redundant Chromium bug keyword
654         https://bugs.webkit.org/show_bug.cgi?id=146097
655
656         Reviewed by Csaba Osztrogonác.
657
658         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
659         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
660         (TestExpectationLine._format_line): Deleted.
661
662 2015-06-17  Daniel Bates  <dabates@apple.com>
663
664         Client may receive began editing callback for already focused text field
665         https://bugs.webkit.org/show_bug.cgi?id=146074
666         <rdar://problem/21293562>
667
668         Reviewed by Darin Adler.
669
670         Add a unit test to ensure that a client receives exactly one began editing
671         callback when a text field is newly focused. In particular, dispatching
672         a DOM focus event at an already focused text field does not dispatch a
673         began editing callback to the client.
674
675         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
676         (TestWebKitAPI::TEST_F):
677
678 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
679
680         [Win]Implement layoutTestController.dispatchPendingLoadRequests. 
681         https://bugs.webkit.org/show_bug.cgi?id=26481
682
683         Reviewed by Darin Adler.
684
685         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
686
687         * DumpRenderTree/win/TestRunnerWin.cpp:
688         (TestRunner::dispatchPendingLoadRequests):
689         (TestRunner::overridePreference):
690
691 2015-06-17  Alex Christensen  <achristensen@webkit.org>
692
693         [Content Extensions] Fail to parse invalid arrays
694         https://bugs.webkit.org/show_bug.cgi?id=146079
695         rdar://problem/21422649
696
697         Reviewed by Benjamin Poulain.
698
699         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
700         (TestWebKitAPI::TEST_F):
701         Correct and add parsing tests with invalid arrays.
702
703 2015-06-17  Matt Rajca  <mrajca@apple.com>
704
705         Unreviewed. Added myself as a committer.
706
707         * Scripts/webkitpy/common/config/contributors.json:
708
709 2015-06-17  Daniel Bates  <dabates@apple.com>
710
711         Export VCSUtils::gitTreeDirectory()
712         <rdar://problem/21248901>
713
714         Rubber-stamped by Alexey Proskuryakov.
715
716         * Scripts/VCSUtils.pm:
717
718 2015-06-17  Tim Horton  <timothy_horton@apple.com>
719
720         Safari tabs still have shrunken content after coming out of fullscreen
721         https://bugs.webkit.org/show_bug.cgi?id=146037
722         <rdar://problem/21105960>
723
724         Reviewed by Simon Fraser and Darin Adler.
725
726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
727         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
728         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
729         (TEST):
730         Add a test that ensures that disabling scale-to-fit mode correctly updates
731         the page's layout.
732
733 2015-06-17  Dan Bernstein  <mitz@apple.com>
734
735         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
736         https://bugs.webkit.org/show_bug.cgi?id=145957
737
738         Reviewed by Darin Adler.
739
740         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
741         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
742
743 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
744
745         AX:  iOS accessibility tests are not running because we need WKTR support
746         https://bugs.webkit.org/show_bug.cgi?id=145991
747
748         Reviewed by Daniel Bates.
749
750         Add support for WKTR iOS accessibility.
751         Utilize the notification handling mechanisms that Mac already uses.
752         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
753
754         * DumpRenderTree/AccessibilityUIElement.cpp:
755         (stringForSelectionCallback):
756         (getIdentifierCallback):
757         (getTraitsCallback):
758         (getElementTextPositionCallback):
759         (getElementTextLengthCallback):
760         (AccessibilityUIElement::getJSClass):
761         (getIPhoneLabelCallback): Deleted.
762         (getIPhoneHintCallback): Deleted.
763         (getIPhoneValueCallback): Deleted.
764         (getIPhoneIdentifierCallback): Deleted.
765         (getIPhoneTraitsCallback): Deleted.
766         (getIPhoneIsElementCallback): Deleted.
767         (getIPhoneElementTextPositionCallback): Deleted.
768         (getIPhoneElementTextLengthCallback): Deleted.
769         * DumpRenderTree/AccessibilityUIElement.h:
770         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
771         (AccessibilityUIElement::identifier):
772         (AccessibilityUIElement::traits):
773         (AccessibilityUIElement::elementTextPosition):
774         (AccessibilityUIElement::elementTextLength):
775         (AccessibilityUIElement::description):
776         (AccessibilityUIElement::orientation):
777         (AccessibilityUIElement::stringValue):
778         (AccessibilityUIElement::language):
779         (AccessibilityUIElement::helpText):
780         (AccessibilityUIElement::intValue):
781         (AccessibilityUIElement::isSelected):
782         (AccessibilityUIElement::isExpanded):
783         (AccessibilityUIElement::documentURI):
784         (AccessibilityUIElement::addNotificationListener):
785         (AccessibilityUIElement::removeNotificationListener):
786         (AccessibilityUIElement::isFocusable):
787         (AccessibilityUIElement::isIgnored):
788         (AccessibilityUIElement::hasPopup):
789         (AccessibilityUIElement::iphoneLabel): Deleted.
790         (AccessibilityUIElement::iphoneHint): Deleted.
791         (AccessibilityUIElement::iphoneValue): Deleted.
792         (AccessibilityUIElement::iphoneIdentifier): Deleted.
793         (AccessibilityUIElement::iphoneTraits): Deleted.
794         (AccessibilityUIElement::iphoneIsElement): Deleted.
795         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
796         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
797         (_accessibilityNotificationCallback): Deleted.
798         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
799         (WTR::AccessibilityUIElement::isValid):
800         (WTR::AccessibilityUIElement::identifier):
801         (WTR::AccessibilityUIElement::traits):
802         (WTR::AccessibilityUIElement::elementTextPosition):
803         (WTR::AccessibilityUIElement::elementTextLength):
804         (WTR::AccessibilityUIElement::stringForSelection):
805         (WTR::AccessibilityUIElement::elementsForRange):
806         (WTR::AccessibilityUIElement::increaseTextSelection):
807         (WTR::AccessibilityUIElement::decreaseTextSelection):
808         (WTR::AccessibilityUIElement::linkedElement):
809         (WTR::AccessibilityUIElement::headerElementAtIndex):
810         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
811         (WTR::AccessibilityUIElement::characterAtOffset):
812         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
813         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
814         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
815         (WTR::findAccessibleObjectById):
816         (WTR::AccessibilityController::accessibleElementById):
817         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
818         (+[NSString stringWithJSStringRef:]):
819         (-[NSString createJSStringRef]):
820         (WTR::convertNSArrayToVector):
821         (WTR::concatenateAttributeAndValue):
822         (WTR::AccessibilityUIElement::AccessibilityUIElement):
823         (WTR::AccessibilityUIElement::isEqual):
824         (WTR::AccessibilityUIElement::headerElementAtIndex):
825         (WTR::AccessibilityUIElement::linkedElement):
826         (WTR::AccessibilityUIElement::getLinkedUIElements):
827         (WTR::AccessibilityUIElement::elementAtPoint):
828         (WTR::convertElementsToObjectArray):
829         (WTR::AccessibilityUIElement::elementsForRange):
830         (WTR::AccessibilityUIElement::indexOfChild):
831         (WTR::AccessibilityUIElement::stringAttributeValue):
832         (WTR::AccessibilityUIElement::description):
833         (WTR::AccessibilityUIElement::orientation):
834         (WTR::AccessibilityUIElement::stringValue):
835         (WTR::AccessibilityUIElement::language):
836         (WTR::AccessibilityUIElement::helpText):
837         (WTR::AccessibilityUIElement::x):
838         (WTR::AccessibilityUIElement::clickPointX):
839         (WTR::AccessibilityUIElement::clickPointY):
840         (WTR::AccessibilityUIElement::intValue):
841         (WTR::AccessibilityUIElement::minValue):
842         (WTR::AccessibilityUIElement::maxValue):
843         (WTR::AccessibilityUIElement::valueDescription):
844         (WTR::AccessibilityUIElement::isSelected):
845         (WTR::AccessibilityUIElement::isSelectedOptionActive):
846         (WTR::AccessibilityUIElement::stringForRange):
847         (WTR::AccessibilityUIElement::attributedStringForRange):
848         (WTR::AccessibilityUIElement::attributesOfHeader):
849         (WTR::AccessibilityUIElement::traits):
850         (WTR::AccessibilityUIElement::identifier):
851         (WTR::AccessibilityUIElement::rowCount):
852         (WTR::AccessibilityUIElement::rowIndexRange):
853         (WTR::AccessibilityUIElement::columnIndexRange):
854         (WTR::AccessibilityUIElement::cellForColumnAndRow):
855         (WTR::AccessibilityUIElement::horizontalScrollbar):
856         (WTR::AccessibilityUIElement::documentURI):
857         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
858         (WTR::AccessibilityUIElement::increaseTextSelection):
859         (WTR::AccessibilityUIElement::decreaseTextSelection):
860         (WTR::AccessibilityUIElement::stringForSelection):
861         (WTR::AccessibilityUIElement::elementTextPosition):
862         (WTR::AccessibilityUIElement::elementTextLength):
863         (WTR::AccessibilityUIElement::url):
864         (WTR::AccessibilityUIElement::addNotificationListener):
865         (WTR::AccessibilityUIElement::removeNotificationListener):
866         (WTR::AccessibilityUIElement::isFocusable):
867         (WTR::AccessibilityUIElement::isIgnored):
868         (WTR::AccessibilityUIElement::hasPopup):
869         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
870         (WTR::_CGPathEnumerationIteration):
871         (WTR::AccessibilityUIElement::pathDescription):
872         (WTR::AccessibilityUIElement::supportedActions):
873
874 2015-06-16  Mark Lam  <mark.lam@apple.com>
875
876         Use NakedPtr<Exception>& to return exception results.
877         https://bugs.webkit.org/show_bug.cgi?id=145870
878
879         Reviewed by Anders Carlsson and Filip Pizlo.
880
881         * TestWebKitAPI/CMakeLists.txt:
882         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
883         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
885         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
886         (TestWebKitAPI::TEST):
887         (TestWebKitAPI::nakedPtrFoo):
888
889 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
890
891         Unreviewed. Adding myself as a committer.
892
893         * Scripts/webkitpy/common/config/contributors.json:
894
895 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
896
897         Add test expectations for El Capitan
898         https://bugs.webkit.org/show_bug.cgi?id=146005
899
900         Rubber-stamped by Dan Bernstein.
901
902         Add appropriate tools code.
903
904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
905         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
906         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
907         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
908         Added dashboard support.
909
910         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
911         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
912         Trigger the right build queues on check-in.
913
914         * Scripts/webkitpy/common/system/platforminfo.py:
915         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
916         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
917         * Scripts/webkitpy/port/mac.py:
918         * Scripts/webkitpy/port/mac_unittest.py:
919         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
920         * TestResultServer/static-dashboards/flakiness_dashboard.js:
921         Added cases for El Capitan, and updated tests for new baseline search paths.
922
923 2015-06-15  Alex Christensen  <achristensen@webkit.org>
924
925         [Content Extensions] Make max NFA size and max rule count user defaults.
926         https://bugs.webkit.org/show_bug.cgi?id=145663
927
928         Reviewed by Benjamin Poulain.
929
930         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
931         (TestWebKitAPI::TEST_F):
932
933 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
934
935         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
936         https://bugs.webkit.org/show_bug.cgi?id=145900
937
938         Reviewed by Sam Weinig.
939
940         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
941         (TEST): Added tests.
942
943 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
944
945         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
946         https://bugs.webkit.org/show_bug.cgi?id=145969
947
948         Reviewed by Sergio Villar Senin.
949
950         Add a test case to the custom URI schemes unit test.
951
952         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
953         (testWebContextURIScheme):
954
955 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
956
957         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
958         https://bugs.webkit.org/show_bug.cgi?id=145922
959
960         Reviewed by Carlos Garcia Campos.
961
962         * gtk/jhbuild.modules:
963         * gtk/patches/glib-warning-fix.patch: Added.
964
965 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
966
967         Update springLoadingHighlight type
968         https://bugs.webkit.org/show_bug.cgi?id=145939
969         rdar://problem/20880213
970
971         Reviewed by Darin Adler.
972
973         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
974         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
975         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
976         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
977
978 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
979
980         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
981         https://bugs.webkit.org/show_bug.cgi?id=145945
982
983         Reviewed by Stephanie Lewis.
984
985         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
986         (OSXBrowserDriver.prepareEnv):
987         (OSXBrowserDriver.moveCursor): Deleted.
988         (OSXBrowserDriver): Deleted.
989         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
990         (OSXSafariDriver.prepareEnv):
991
992 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
993
994         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
995         https://bugs.webkit.org/show_bug.cgi?id=145938
996
997         Reviewed by Alexey Proskuryakov.
998
999         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
1000         LWP::UserAgent to get access to more robust HTTPS support.
1001
1002 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1003
1004         [GTK] Fix return type warning in WebViewTest.cpp
1005         https://bugs.webkit.org/show_bug.cgi?id=145914
1006
1007         Reviewed by Darin Adler.
1008
1009         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1010         (WebViewTest::isEditable):
1011
1012 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
1013
1014         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
1015         https://bugs.webkit.org/show_bug.cgi?id=145799
1016
1017         Reviewed by Carlos Garcia Campos.
1018
1019         Update header inclusions for headers that have been moved
1020         to Source/WTF/wtf/glib/.
1021
1022         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
1023         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
1024
1025         * TestWebKitAPI/PlatformGTK.cmake:
1026         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
1027         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1028         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1029         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1030         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1031         (TestWebKitAPI::GMainLoopSourceTest::finish):
1032         (TestWebKitAPI::GMainLoopSourceTest::source):
1033         (TestWebKitAPI::basicRescheduling):
1034         (TestWebKitAPI::TEST):
1035         (TestWebKitAPI::reentrantRescheduling):
1036         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1037         (TestWebKitAPI::basicDestroyCallbacks):
1038         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1039         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1040         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
1041         (log):
1042         (takeLogStr):
1043         (TestWebKitAPI::TEST):
1044         (TestWebKitAPI::returnOutChar):
1045         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1046         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1047         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
1048         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
1049         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
1050         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
1051         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
1052         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
1053         (TestWebKitAPI::basicRescheduling): Deleted.
1054         (TestWebKitAPI::TEST): Deleted.
1055         (TestWebKitAPI::reentrantRescheduling): Deleted.
1056         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
1057         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
1058         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
1059         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
1060         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
1061         (log): Deleted.
1062         (takeLogStr): Deleted.
1063         (TestWebKitAPI::TEST): Deleted.
1064         (TestWebKitAPI::returnOutChar): Deleted.
1065         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
1066         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1067         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1068         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1069         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1070         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1071         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1072         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1073         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1074         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1075         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1076         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1077         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1078         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1079         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1080         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
1081         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1082         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1083         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1084         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1085         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1086         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1087         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1088         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1089         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1090         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1091         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1092         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1093         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1094         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
1095         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1096         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
1097         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1098         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1099         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1100         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1101         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
1102         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1103         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1104         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1105         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1106         * WebKitTestRunner/PlatformGTK.cmake:
1107         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1108         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1109
1110 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1111
1112         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
1113         https://bugs.webkit.org/show_bug.cgi?id=145913
1114
1115         Reviewed by Gyuyoung Kim.
1116
1117         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1118         (TestWebKitAPI::setupGeolocationProvider):
1119         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1120         (TestWebKitAPI::setPageLoaderClient):
1121         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1122         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1123         * WebKitTestRunner/GeolocationProviderMock.cpp:
1124         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1125         * WebKitTestRunner/WebNotificationProvider.cpp:
1126         (WTR::WebNotificationProvider::provider):
1127
1128 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1129
1130         Fix the libusrsctp build with clang
1131         https://bugs.webkit.org/show_bug.cgi?id=145128
1132
1133         Reviewed by Gyuyoung Kim.
1134
1135         * efl/jhbuild.modules:
1136         * gtk/jhbuild.modules:
1137
1138 2015-06-11  Mark Lam  <mark.lam@apple.com>
1139
1140         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
1141         https://bugs.webkit.org/show_bug.cgi?id=145872
1142
1143         Reviewed by Michael Saboff.
1144
1145         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1146         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
1147         - Exercises the JSC ObjC API to call a function which throws an exception.  That
1148           exception will be returned as a JSValue instead of an Exception object.  We
1149           will use this JSValue to test WebCore::reportException() to confirm that it is
1150           able to handle an exception value which is not an Exception object.
1151
1152 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
1153
1154         Move cursor to corner and fix safari window size before running benchmark
1155         https://bugs.webkit.org/show_bug.cgi?id=145858
1156
1157         Reviewed by Ryosuke Niwa
1158
1159         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1160         (OSXBrowserDriver.prepareEnv):
1161         (OSXBrowserDriver):
1162         (OSXBrowserDriver.moveCursor):
1163         (OSXBrowserDriver.getScreenSize):
1164         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1165         (OSXChromeDriver.launchUrl):
1166         (OSXChromeCanaryDriver.launchUrl):
1167         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1168         (OSXFirefoxDriver.launchUrl):
1169         (OSXFirefoxNightlyDriver.launchUrl):
1170         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1171         (OSXSafariDriver.prepareEnv):
1172         (OSXSafariDriver):
1173         (OSXSafariDriver.maximizeWindow):
1174
1175 2015-06-11  Daniel Bates  <dabates@apple.com>
1176
1177         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
1178         https://bugs.webkit.org/show_bug.cgi?id=145319
1179
1180         Reviewed by David Kilzer.
1181
1182         Add SPI wrapper header for CoreSimulator and update the source files to reference
1183         it instead of directly referencing the CoreSimulator header.
1184
1185         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
1186         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
1187         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1188         * LayoutTestRelay/LayoutTestRelay/main.m:
1189
1190 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1191
1192         [EFL] dimmed area for popup does not cover the fullscreen mode.
1193         https://bugs.webkit.org/show_bug.cgi?id=145133
1194
1195         Reviewed by Gyuyoung Kim.
1196
1197         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
1198         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
1199
1200         * MiniBrowser/efl/main.c:
1201         (on_fullscreen_accept):
1202         (on_fullscreen_deny):
1203         (on_fullscreen_enter):
1204
1205 2015-06-10  Commit Queue  <commit-queue@webkit.org>
1206
1207         Unreviewed, rolling out r185442.
1208         https://bugs.webkit.org/show_bug.cgi?id=145871
1209
1210         seems to have broken WTF.StringOperators test (Requested by
1211         alexchristensen on #webkit).
1212
1213         Reverted changeset:
1214
1215         "[Content Extensions] Limit number of rules."
1216         https://bugs.webkit.org/show_bug.cgi?id=145663
1217         http://trac.webkit.org/changeset/185442
1218
1219 2015-06-10  Alex Christensen  <achristensen@webkit.org>
1220
1221         [Content Extensions] Make max NFA size and max rule count user defaults.
1222         https://bugs.webkit.org/show_bug.cgi?id=145663
1223         rdar://problem/21242407
1224
1225         Reviewed by Benjamin Poulain.
1226
1227         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1228         (TestWebKitAPI::TEST_F):
1229
1230 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1231
1232         [EFL] Execute Javascript method in mini browser address bar.
1233         https://bugs.webkit.org/show_bug.cgi?id=145725
1234
1235         Reviewed by Gyuyoung Kim.
1236
1237         Support 'javascript:' scheme in WebKit EFL Mini Browser.
1238
1239         * MiniBrowser/efl/main.c:
1240         (url_from_user_input):
1241         (url_load_from_user_input):
1242         (on_url_bar_activated):
1243         (elm_main):
1244
1245 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1246
1247         Implement dumpProgressFinishedCallback() for Win layoutTestController.
1248         https://bugs.webkit.org/show_bug.cgi?id=66773
1249
1250         Reviewed by Darin Adler.
1251
1252         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1253         * DumpRenderTree/win/FrameLoadDelegate.h:
1254
1255 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
1256
1257         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
1258         https://bugs.webkit.org/show_bug.cgi?id=145764
1259
1260         Reviewed by Darin Adler.
1261
1262         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
1263         JetStream and SunSpider.
1264
1265         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1266         (GenericBenchmarkBuilder):
1267         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
1268         the whole JSON as the input.
1269         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
1270         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
1271         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1272         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
1273         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
1274         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1275         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1276
1277 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1278
1279         Remove ewstool scripts used by chromium port
1280         https://bugs.webkit.org/show_bug.cgi?id=145789
1281
1282         Reviewed by Csaba Osztrogonác.
1283
1284         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
1285         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
1286         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
1287         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
1288         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
1289
1290 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1291
1292         Unreviewed, updated my list of email addresses.
1293
1294         * Scripts/webkitpy/common/config/contributors.json:
1295
1296 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1297
1298         [cmake] Fix the style issues in cmake project files
1299         https://bugs.webkit.org/show_bug.cgi?id=145755
1300
1301         Reviewed by Darin Adler.
1302
1303         * TestWebKitAPI/CMakeLists.txt:
1304         * TestWebKitAPI/PlatformEfl.cmake:
1305
1306 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1307
1308         Fix a typo in r185345.
1309
1310         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1311         (OSXSafariDriver.closeBrowsers):
1312
1313 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1314
1315         Yet another unreviewed build fix :(
1316
1317         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1318         (OSXSafariDriver):
1319         (OSXSafariDriver.launchUrl):
1320         (OSXSafariDriver.closeBrowsers):
1321
1322 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1323
1324         Unreviewed build fix. Initialize result in the case things blow up below.
1325
1326         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1327         (BenchmarkRunner.execute):
1328
1329 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1330
1331         Partially revert and fix after r185243.
1332
1333         * Scripts/benchmark_runner/benchmark_runner.py:
1334         * Scripts/run-benchmark:
1335
1336 2015-06-08  Daniel Bates  <dabates@apple.com>
1337
1338         Many LayoutTests/http tests time out in DumpRenderTree
1339         https://bugs.webkit.org/show_bug.cgi?id=145770
1340         <rdar://problem/19593910>
1341
1342         Reviewed by Alexey Proskuryakov.
1343
1344         * DumpRenderTree/ios/Info.plist: Add ATS key.
1345         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1346         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
1347         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
1348         that make use of testRunner.pathToLocalResource().
1349
1350 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
1351
1352         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
1353         https://bugs.webkit.org/show_bug.cgi?id=145759
1354
1355         Reviewed by Carlos Garcia Campos.
1356
1357         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1358         (testWebViewSave):
1359
1360 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1361
1362         [GTK] Add editor mode to MiniBrowser
1363         https://bugs.webkit.org/show_bug.cgi?id=145595
1364
1365         Reviewed by Sergio Villar Senin.
1366
1367         It loads an empty editable web view with an edit toolbar. It makes
1368         easier to test the editor, editing commands and input methods.
1369
1370         * MiniBrowser/gtk/BrowserWindow.c:
1371         (editingCommandCallback):
1372         (browserWindowSetupEditorToolbar):
1373         (browserWindowConstructed):
1374         * MiniBrowser/gtk/main.c:
1375         (createBrowserWindow):
1376
1377 2015-06-05  Zalan Bujtas  <zalan@apple.com>
1378
1379         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
1380
1381         Reviewed by Dan Bernstein.
1382
1383         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1384         (TestWebKitAPI::TEST):
1385
1386 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1387
1388         [EFL] API test has been broken since r184357
1389         https://bugs.webkit.org/show_bug.cgi?id=145635
1390
1391         Reviewed by Darin Adler.
1392
1393         r184357 suppress cmake build warning using TARGET_FILE property. However
1394         many EFL API test cases have been broken after applying it.
1395
1396         * TestWebKitAPI/CMakeLists.txt:
1397
1398 2015-06-05  Anders Carlsson  <andersca@apple.com>
1399
1400         Make the network cache directory part of WKContextConfigurationRef
1401         https://bugs.webkit.org/show_bug.cgi?id=145711
1402
1403         Reviewed by Antti Koivisto.
1404
1405         * WebKitTestRunner/TestController.cpp:
1406         (WTR::TestController::initialize):
1407
1408 2015-06-05  Anders Carlsson  <andersca@apple.com>
1409
1410         Make the application cache directory part of WKContextConfigurationRef
1411         https://bugs.webkit.org/show_bug.cgi?id=145704
1412
1413         Reviewed by Geoffrey Garen.
1414
1415         * WebKitTestRunner/TestController.cpp:
1416         (WTR::TestController::initialize):
1417
1418 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1419
1420         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
1421         https://bugs.webkit.org/show_bug.cgi?id=145680
1422
1423         Reviewed by Brent Fulgham.
1424
1425         * Scripts/webkitpy/style/checkers/cpp.py:
1426         (check_for_null):
1427         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1428         (WebKitStyleTest.test_null_false_zero):
1429
1430 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1431
1432         Make the web server more robust to timing issues..
1433
1434         Reviewed by Ryosuke Niwa.
1435
1436         Cleaned up exception handling.
1437         Test server is actually serving pages before returning.
1438         Clean up some style issues.
1439
1440         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1441         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1442         (SimpleHTTPServerDriver.__init__):
1443         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
1444         (SimpleHTTPServerDriver.baseUrl): 
1445         (SimpleHTTPServerDriver.fetchResult):
1446         (SimpleHTTPServerDriver.killServer):
1447         (SimpleHTTPServerDriver.getReturnCode):
1448
1449 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1450
1451
1452         Add errors to run-benchmark exception handling.
1453
1454         Reviewed by Ryosuke Niwa.
1455
1456         * Scripts/run-benchmark:
1457         (main):
1458         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1459         (GenericBenchmarkBuilder.prepare):
1460         (GenericBenchmarkBuilder._runCreateScript):
1461         (GenericBenchmarkBuilder._applyPatch):
1462         (GenericBenchmarkBuilder.clean):
1463         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1464         (BenchmarkRunner.__init__):
1465         (BenchmarkRunner.execute):
1466         (BenchmarkRunner):
1467         (BenchmarkRunner.cleanup):
1468         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
1469         (GenericFactory.iterateGetItem):
1470         (GenericFactory.create):
1471         * Scripts/webkitpy/benchmark_runner/utils.py:
1472         (loadModule):
1473         (loadJSONFromFile):
1474         (forceRemove):
1475
1476 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1477
1478         Streamline run-benchmark browser
1479
1480         Reviewed by Ryosuke Niwa.
1481
1482         Add Caffeinate so computer won't sleep while running.
1483         Remove calls to collect output since we were just dumping to stdout anyway.
1484         Add xpc dyld_path.
1485         Default to system safari.
1486
1487         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1488         (OSXBrowserDriver.launchProcess):
1489         (OSXBrowserDriver.terminateProcesses):
1490         (OSXBrowserDriver):
1491         (OSXBrowserDriver.launchCaffeinateForProcess):
1492         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1493         (OSXSafariDriver.launchUrl):
1494         (OSXSafariDriver.closeBrowsers):
1495
1496 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
1497
1498         Combine tiny DFAs into slightly larger ones
1499         https://bugs.webkit.org/show_bug.cgi?id=145572
1500
1501         Reviewed by Alex Christensen.
1502
1503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1504         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
1505         (TestWebKitAPI::DFACombinerTest::SetUp):
1506         (TestWebKitAPI::combine):
1507         (TestWebKitAPI::TEST_F):
1508         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
1509         (TestWebKitAPI::countLiveNodes):
1510         (TestWebKitAPI::createNFAs):
1511         (TestWebKitAPI::buildDFAFromPatterns):
1512         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1513         (TestWebKitAPI::countLiveNodes): Deleted.
1514         (TestWebKitAPI::createNFAs): Deleted.
1515         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
1516
1517 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
1518
1519         WebKitTestRunner leaks strings in generateWhitelist()
1520         https://bugs.webkit.org/show_bug.cgi?id=145665
1521
1522         Reviewed by Myles C. Maxfield.
1523
1524         * WebKitTestRunner/mac/TestControllerMac.mm:
1525         (WTR::generateWhitelist):
1526
1527 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1528
1529         Fix options in build-jsc for CMake builds
1530         https://bugs.webkit.org/show_bug.cgi?id=145636
1531
1532         Reviewed by Gyuyoung Kim.
1533
1534         CMake only accepts -DXXX=YYY style options.
1535         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
1536
1537         * Scripts/build-jsc:
1538
1539 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
1540
1541         Added a patch so that the colors displayed on the page could be toggled
1542         in case people need accessibility colors displayed in their browser.
1543         https://bugs.webkit.org/show_bug.cgi?id=145570
1544         <rdar://problem/20994468>
1545
1546         Added in CSS colors and toggle buttons for checkmarks in the page, so that
1547         the page could be rendered in a specific way for accessibility needs if needed.
1548
1549         Reviewed by Alexey Proskuryakov.
1550
1551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1552         (updateHiddenPlatforms):
1553         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
1554         (toggleAccessibilityColors): Toggle colors on and off
1555         (documentReady): Needed to make changes to the initialization
1556         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1557         (a:hover):
1558         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
1559         (div.cellButton.hide, div.accessibilityButton.hide):
1560         (div.cellButton.unhide, div.accessibilityButton.unhide):
1561         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
1562         (.popover-tracking:hover):
1563         (.accessibilityButton):
1564         (div.cellButton): Deleted.
1565         (div.cellButton.hide): Deleted.
1566         (div.cellButton.unhide): Deleted.
1567         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
1568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1569         (.status-line.neutral .bubble):
1570         (.status-line.unauthorized .bubble):
1571         (.status-line.danger .bubble.pictogram):
1572         (.status-line.bad .bubble.pictogram):
1573         (.status-line.no-bubble .message):
1574         (.status-line.bad .bubble):
1575         (.status-line.good .bubble):
1576         (.status-line.good .message):
1577         (.status-line.bad .message):
1578         (body.accessibility-colors .status-line.good .bubble):
1579         (body.accessibility-colors .status-line.bad .bubble):
1580         (body.accessibility-colors .status-line.good .message):
1581         (body.accessibility-colors .status-line.bad .message):
1582         (.status-line.danger .message):
1583         (.status-line.unauthorized .message):
1584
1585 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
1586
1587         Unreviewed build fix for Dromaeo.
1588
1589         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1590         (BenchmarkResults._aggregate_results_for_test):
1591
1592 2015-06-03  Anders Carlsson  <andersca@apple.com>
1593
1594         Fix build.
1595
1596         * DumpRenderTree/mac/TestRunnerMac.mm:
1597
1598 2015-06-03  Daniel Bates  <dabates@apple.com>
1599
1600         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
1601         https://bugs.webkit.org/show_bug.cgi?id=145616
1602
1603         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
1604         of the test. Further investigation is needed.
1605
1606         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1607         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
1608
1609 2015-06-03  Brady Eidson  <beidson@apple.com>
1610
1611         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
1612         https://bugs.webkit.org/show_bug.cgi?id=145580
1613
1614         Reviewed by Mark Lam.
1615
1616         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1617         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
1618
1619 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
1620
1621         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
1622
1623         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1624         (TestWebKitAPI::TEST): Update the syntax.
1625
1626 2015-06-02  Mark Lam  <mark.lam@apple.com>
1627
1628         build-jsc's --cloop option is broken.
1629         https://bugs.webkit.org/show_bug.cgi?id=145516
1630
1631         Reviewed by Darin Adler.
1632
1633         * Scripts/build-jsc:
1634         - Make sure to disable the JIT when --cloop is specified.
1635           Did analogous fix for --ftljit.
1636
1637 2015-06-02  Daniel Bates  <dabates@apple.com>
1638
1639         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
1640
1641         Rubber-stamped by Alexey Proskuryakov.
1642
1643         * MiniBrowser/mac/Info.plist:
1644         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1645
1646 2015-06-01  Commit Queue  <commit-queue@webkit.org>
1647
1648         Unreviewed, rolling out r185066.
1649         https://bugs.webkit.org/show_bug.cgi?id=145543
1650
1651         it breaks the FTL JIT builds with a local checkout of llvm
1652         (Requested by pizlo on #webkit).
1653
1654         Reverted changeset:
1655
1656         "build-jsc's --cloop option is broken."
1657         https://bugs.webkit.org/show_bug.cgi?id=145516
1658         http://trac.webkit.org/changeset/185066
1659
1660 2015-06-01  Daniel Bates  <dabates@apple.com>
1661
1662         Notify client that we began editing when text field is focused
1663         https://bugs.webkit.org/show_bug.cgi?id=145439
1664         <rdar://problem/21142108>
1665
1666         Reviewed by Anders Carlsson.
1667
1668         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
1669         a text field is focused and defocused.
1670
1671         * TestWebKitAPI/CMakeLists.txt:
1672         * TestWebKitAPI/PlatformEfl.cmake:
1673         * TestWebKitAPI/PlatformGTK.cmake:
1674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1675         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
1676         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
1677         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
1678         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
1679         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
1680         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
1681         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
1682         (TestWebKitAPI::TEST_F):
1683         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
1684         (TestWebKitAPI::textFieldDidBeginEditing):
1685         (TestWebKitAPI::textFieldDidEndEditing):
1686         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
1687         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
1688         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
1689
1690 2015-06-01  Alex Christensen  <achristensen@webkit.org>
1691
1692         [Content Extensions] resource-type and load-type should be independent.
1693         https://bugs.webkit.org/show_bug.cgi?id=145528
1694         rdar://problem/21190765
1695
1696         Reviewed by Benjamin Poulain.
1697
1698         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1699         (TestWebKitAPI::TEST_F):
1700
1701 2015-06-01  Daniel Bates  <dabates@apple.com>
1702
1703         Add ATS keys to WebKitTestRunnerApp
1704         https://bugs.webkit.org/show_bug.cgi?id=145519
1705
1706         Reviewed by Alexey Proskuryakov.
1707
1708         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
1709
1710         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1711
1712 2015-06-01  Brady Eidson  <beidson@apple.com>
1713
1714         Add WKTR support for "should open external URLs".
1715         https://bugs.webkit.org/show_bug.cgi?id=145505
1716
1717         Reviewed by Darin Adler.
1718
1719         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
1720           "should open external URLs" bit set.
1721         
1722         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
1723           the policy delegate, including whether or not the bit was set.
1724         
1725         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1726         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1727         (WTR::TestRunner::queueLoad):
1728         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1729         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
1730         (WTR::TestRunner::shouldDumpPolicyCallbacks):
1731         
1732         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1733         (WTR::InjectedBundle::queueLoad):
1734         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1735
1736         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1737         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1738
1739         * WebKitTestRunner/TestInvocation.cpp:
1740         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1741
1742         * WebKitTestRunner/WorkQueueManager.cpp:
1743         (WTR::WorkQueueManager::queueLoad):
1744         * WebKitTestRunner/WorkQueueManager.h:
1745
1746 2015-06-01  Mark Lam  <mark.lam@apple.com>
1747
1748         build-jsc's --cloop option is broken.
1749         https://bugs.webkit.org/show_bug.cgi?id=145516
1750
1751         Reviewed by Darin Adler.
1752
1753         * Scripts/build-jsc:
1754         - Make sure to disable the JIT when --cloop is specified.
1755           Did analogous fix for --ftljit.
1756
1757 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1758
1759         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
1760         https://bugs.webkit.org/show_bug.cgi?id=144959
1761
1762         Reviewed by Darin Adler.
1763
1764         * Scripts/webkitpy/style/checkers/cmake.py:
1765         (CMakeChecker.check): Use enumerate instead of xrange.
1766         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
1767         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1768         (CMakeCheckerTest.test_check): Update the expected results.
1769
1770 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1771
1772         Fix the webkitpy scm unittests after r174051
1773         https://bugs.webkit.org/show_bug.cgi?id=145511
1774
1775         Reviewed by Darin Adler.
1776
1777         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1778         (GitTestWithMock.make_scm):
1779
1780 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1781
1782         EWS provides misleading information for not applyable patches
1783         https://bugs.webkit.org/show_bug.cgi?id=145307
1784
1785         Reviewed by Alexey Proskuryakov.
1786
1787         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
1788
1789 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
1790
1791         Further tweak results of WebKit1.StringTruncator after r184965.
1792
1793         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1794
1795 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1796
1797         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
1798         https://bugs.webkit.org/show_bug.cgi?id=145264
1799
1800         Reviewed by Carlos Garcia Campos.
1801
1802         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
1803
1804 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1805
1806         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
1807
1808         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1809         (BenchmarkResults._lint_subtest_results):
1810         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
1811         (test_aggregate_nested_results):
1812         (test_lint_results):
1813         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
1814
1815 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
1816
1817         run-benchmark should print out the results
1818         https://bugs.webkit.org/show_bug.cgi?id=145398
1819
1820         Reviewed by Antti Koivisto.
1821
1822         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
1823         of the output to catch early errors.
1824
1825         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
1826         (BenchmarkResults): Added.
1827         (BenchmarkResults.__init__): Added.
1828         (BenchmarkResults.format): Added.
1829         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
1830         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
1831         Uses the sample standard deviation to compute the significant figures for the value.
1832         (BenchmarkResults._unit_from_metric): Added.
1833         (BenchmarkResults._aggregate_results): Added.
1834         (BenchmarkResults._aggregate_results_for_test): Added.
1835         (BenchmarkResults._flatten_list): Added.
1836         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
1837         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
1838         (BenchmarkResults._aggregate_values): Added.
1839         (BenchmarkResults._lint_results): Added.
1840         (BenchmarkResults._lint_subtest_results): Added.
1841         (BenchmarkResults._lint_aggregator_list): Added.
1842         (BenchmarkResults._lint_configuration): Added.
1843         (BenchmarkResults._lint_values): Added.
1844         (BenchmarkResults._is_numeric): Added.
1845         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
1846         (BenchmarkResultsTest):
1847         (BenchmarkResultsTest.test_init):
1848         (BenchmarkResultsTest.test_format):
1849         (test_format_values_with_large_error):
1850         (test_format_values_with_small_error):
1851         (test_format_values_with_time):
1852         (test_format_values_with_no_error):
1853         (test_format_values_with_small_difference):
1854         (test_aggregate_results):
1855         (test_aggregate_results_with_gropus):
1856         (test_aggregate_nested_results):
1857         (test_lint_results):
1858         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1859         (BenchmarkRunner.execute): Added a call to show_results
1860         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
1861         (BenchmarkRunner.show_results): Added.
1862
1863 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1864
1865         run_benchmark should have an option to specify the number of runs
1866         https://bugs.webkit.org/show_bug.cgi?id=145091
1867
1868         Reviewed by Antti Koivisto.
1869
1870         Added --count option.
1871
1872         * Scripts/run-benchmark:
1873         (main):
1874         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1875         (BenchmarkRunner.__init__):
1876
1877 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
1878
1879         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
1880
1881         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
1882
1883 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
1884
1885         Update results of WebKit1.StringTruncator after r184965.
1886
1887         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
1888
1889 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1890
1891         Unreviewed, updated my list of email addresses.
1892
1893         * Scripts/webkitpy/common/config/contributors.json:
1894
1895 2015-05-27  Dean Jackson  <dino@apple.com>
1896
1897         img.currentSrc problem in strict mode with old picturefill
1898         https://bugs.webkit.org/show_bug.cgi?id=144095
1899         <rdar://problem/21087013>
1900
1901         Reviewed by Simon Fraser.
1902
1903         Add a PICTURE_SIZES flag.
1904
1905         * Scripts/webkitperl/FeatureList.pm:
1906
1907 2015-05-26  Dana Burkart  <dburkart@apple.com>
1908
1909         Fixes compatibility issues with recent dashboard cleanup.
1910         https://bugs.webkit.org/show_bug.cgi?id=144814
1911
1912         Reviewed by Alexey Proskuryakov.
1913
1914         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1915         (BuildbotStaticAnalyzerQueueView):
1916         (BuildbotStaticAnalyzerQueueView.prototype.update):
1917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1918         (documentReady):
1919
1920 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
1921
1922         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
1923         https://bugs.webkit.org/show_bug.cgi?id=143091
1924         rdar://problem/19330328
1925
1926         Reviewed by Darin Adler and Timothy Hatcher.
1927
1928         We have many of these, which are hard to fit on the dashboard. Added a view that
1929         collapses to a single green bubble when everything is good, and expands when there
1930         are failures (or manually).
1931
1932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
1933
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1935         (Buildbot.prototype.set isAuthenticated):
1936         (Buildbot.prototype._normalizeQueueInfo):
1937         (Buildbot.prototype._normalizeQueuesInfo):
1938         (Buildbot.prototype.updateQueues):
1939         Moved queue info normalization here from BuildbitQueue. The latter is a model class
1940         that shouldn't have to know about presentation, and this lets us leep the knowledge
1941         about combined queues out if it. Later, we can refactor existing code, and move out
1942         all knowledge about headings and such.
1943
1944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1945         Added the new view. It's not quite universal, and doesn't have as helpful popovers
1946         as other views, but we can extend it when/if we use it for more than JSC.
1947
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1949         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
1950
1951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1952         (documentReady): Added support for combined queues. These are currently always ending up
1953         in Other column, but it's easy to customize in the future if we need to.
1954
1955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1956         (WebKitBuildbot): Added JSC queus.
1957
1958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1959         (.combined-queue-popover):
1960         (.combined-queue-popover .revision):
1961         Added styles for the combined view.
1962
1963 2015-05-26  Dan Bernstein  <mitz@apple.com>
1964
1965         Changed a file to use Unix line endings.
1966
1967         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1968
1969 2015-05-26  Dan Bernstein  <mitz@apple.com>
1970
1971         <rdar://problem/21104551> Update build settings
1972
1973         Reviewed by Anders Carlsson.
1974
1975         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1976         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1977         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1978         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1979         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1980         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1981         * asan/asan.xcconfig:
1982
1983 2015-05-26  Anders Carlsson  <andersca@apple.com>
1984
1985         Fix build.
1986
1987         * WebKitTestRunner/mac/EventSenderProxy.mm:
1988         (WTR::EventSenderProxy::mouseForceDown):
1989         (WTR::EventSenderProxy::mouseForceUp):
1990         (WTR::EventSenderProxy::mouseForceChanged):
1991
1992 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
1993
1994         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
1995         https://bugs.webkit.org/show_bug.cgi?id=145342
1996
1997         Reviewed by Darin Adler.
1998
1999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2000         (BuildbotIteration.prototype._parseData):
2001
2002 2015-05-26  Milan Crha  <mcrha@redhat.com>
2003
2004         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
2005         https://bugs.webkit.org/show_bug.cgi?id=138134
2006
2007         Reviewed by Žan Doberšek.
2008
2009         * gtk/generate-inspector-gresource-manifest.py:
2010         (get_filenames): Command line with expanded resources exceeds 32KB, which
2011         is a limit on Windows. It's better to expand wildcards inside the python script.
2012
2013 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2014
2015         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
2016         https://bugs.webkit.org/show_bug.cgi?id=140882
2017
2018         Reviewed by Gustavo Noronha Silva.
2019
2020         Make sure unit tests write IndexedDB databases to the temporary
2021         directory, and add a test case to check that the directory is
2022         correctly created at the expected path.
2023
2024         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2025         (testWebContextConfiguration):
2026         (serverCallback):
2027         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2028         (Test::Test):
2029
2030 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2031
2032         [GTK] Enable IndexedDB
2033         https://bugs.webkit.org/show_bug.cgi?id=98932
2034
2035         Reviewed by Žan Doberšek.
2036
2037         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2038
2039 2015-05-24  Sam Weinig  <sam@webkit.org>
2040
2041         Crash when using a removed ScriptMessageHandler
2042         <rdar://problem/20888499>
2043         https://bugs.webkit.org/show_bug.cgi?id=145359
2044
2045         Reviewed by Dan Bernstein.
2046
2047         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2048         Add tests for removing script message handlers.
2049
2050 2015-05-23  Dan Bernstein  <mitz@apple.com>
2051
2052         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
2053         https://bugs.webkit.org/show_bug.cgi?id=145345
2054
2055         Reviewed by Sam Weinig.
2056
2057         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2058         * LayoutTestRelay/Configurations/Base.xcconfig:
2059         * TestWebKitAPI/Configurations/Base.xcconfig:
2060         * WebKitTestRunner/Configurations/Base.xcconfig:
2061
2062 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2063
2064         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
2065         https://bugs.webkit.org/show_bug.cgi?id=144848
2066
2067         Reviewed by Darin Adler.
2068
2069         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
2070
2071         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2072
2073 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2074
2075         Fix one more merge error in static analyzer support.
2076
2077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2078         (BuildbotStaticAnalyzerQueueView):
2079
2080 2015-05-22  Dana Burkart  <dburkart@apple.com>
2081
2082         Fix internal dashboard breakage from recent commit.
2083         https://bugs.webkit.org/show_bug.cgi?id=144814
2084
2085         Unreviewed build fix.
2086
2087         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2088         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2089         (BuildbotStaticAnalyzerQueueView.prototype.update):
2090
2091 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2092
2093         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2094         https://bugs.webkit.org/show_bug.cgi?id=130463
2095         rdar://problem/20461342
2096
2097         Reviewed by Tim Horton.
2098
2099         This was more of a timing related flakiness than an actual OS version specific bug,
2100         we weren't getting window visibility notifications.
2101         
2102         I will look into adding this function call to DumpRenderTree separately, layout tests
2103         might actually rely on the broken behavior.
2104
2105         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2106         (TestWebKitAPI::TEST_F):
2107         * TestWebKitAPI/mac/mainMac.mm:
2108         (main):
2109
2110 2015-05-22  Dana Burkart  <dburkart@apple.com>
2111
2112         Add missing file from r184804 (mis-applied diff).
2113         https://bugs.webkit.org/show_bug.cgi?id=144814
2114
2115         Reviewed by Alexey Proskuryakov.
2116
2117         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
2118         (BuildbotStaticAnalyzerQueueView):
2119         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2120         (BuildbotStaticAnalyzerQueueView.prototype.update):
2121
2122 2015-05-22  Dana Burkart  <dburkart@apple.com>
2123
2124         Add support to the botwatchers dashboard for a static analyzer bot.
2125         https://bugs.webkit.org/show_bug.cgi?id=144814
2126
2127         Reviewed by Alexey Proskuryakov.
2128
2129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2130         scan-build should be considered a productive step.
2131
2132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2133         (BuildbotQueue):
2134         Adds support for the staticAnalyzer property
2135
2136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2137         (BuildbotTestResults.prototype._parseResults):
2138         Get bug count from the scan-build step output
2139
2140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2141         (documentReady):
2142         Rename the performance column 'Other', and merge the current 'Other' column with it.
2143
2144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2145         (WebKitBuildbot):
2146         Now that performance bots are part of the 'Other' column, give them better headings.
2147
2148 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2149
2150         Turn on autosaving of toolbar configuration in MiniBrowser
2151
2152         Rubber-stamped by Dan Bernstein.
2153
2154         * MiniBrowser/mac/BrowserWindow.xib:
2155
2156 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2157
2158         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
2159         https://bugs.webkit.org/show_bug.cgi?id=145297
2160
2161         Reviewed by Tim Horton.
2162
2163         This is a refactoring to simplify code, and to make it more logical.
2164
2165         It is up to the view to decide how to present the queues, and whether to split
2166         them into debug and release, or in some different way.
2167
2168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2169         (BuildbotBuilderQueueView.filterQueues):
2170         (BuildbotBuilderQueueView):
2171         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2172         (BuildbotLeaksQueueView):
2173         (BuildbotLeaksQueueView.prototype.update):
2174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2175         (BuildbotPerformanceQueueView):
2176         (BuildbotPerformanceQueueView.prototype.update):
2177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2178         (BuildbotQueueView):
2179         (BuildbotQueueView.prototype._updateQueues):
2180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2181         (BuildbotTesterQueueView):
2182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2183         (documentReady):
2184
2185 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2186
2187         Remove action menu support
2188         https://bugs.webkit.org/show_bug.cgi?id=145305
2189         <rdar://problem/21070771>
2190
2191         Reviewed by Anders Carlsson.
2192
2193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2194         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
2195         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
2196         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
2197         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
2198         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
2199         Remove the tests.
2200
2201 2015-05-22  Dan Bernstein  <mitz@apple.com>
2202
2203         Removed the Use Shrink To Fit button from the toolbar’s default set.
2204
2205         Rubber-stamped by Tim Horton.
2206
2207         * MiniBrowser/mac/BrowserWindow.xib:
2208
2209 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
2210
2211         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
2212         https://bugs.webkit.org/show_bug.cgi?id=128420
2213
2214         Reviewed by Chris Fleizach.
2215
2216         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2217         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
2218
2219 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
2220
2221         [EFL] Bump libsoup version to 2.50.0
2222         https://bugs.webkit.org/show_bug.cgi?id=145127
2223
2224         Reviewed by Gyuyoung Kim.
2225
2226         * efl/jhbuild.modules:
2227         * efl/patches/soup-clang-warning-fix1.patch: Removed.
2228         * efl/patches/soup-clang-warning-fix2.patch: Removed.
2229
2230 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
2231
2232         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
2233         https://bugs.webkit.org/show_bug.cgi?id=145117
2234
2235         Reviewed by Csaba Osztrogonác.
2236
2237         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
2238         Tools/TestWebKitAPI/Tests/WTF/glib/.
2239
2240         * TestWebKitAPI/PlatformGTK.cmake:
2241         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
2242         (TestWebKitAPI::TEST):
2243
2244 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
2245
2246         [EFL] fix efreet error
2247         https://bugs.webkit.org/show_bug.cgi?id=143670
2248
2249         Reviewed by Gyuyoung Kim.
2250
2251         Fix efreet error by using external variable efreet_cache_update.
2252         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
2253         efreet error for efreet_cache does not occur.
2254
2255         * MiniBrowser/efl/main.c:
2256         (elm_main):
2257
2258 2015-05-20  Michael Saboff  <msaboff@apple.com>
2259
2260         Add option to run_jsc_stress_tests to disable JIT testing
2261         https://bugs.webkit.org/show_bug.cgi?id=145233
2262
2263         Reviewed by Mark Lam.
2264
2265         Added --no-jit option.
2266
2267         * Scripts/run-jsc-stress-tests:
2268
2269 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2270
2271         Use correct String for StringView in WTF API tests
2272         https://bugs.webkit.org/show_bug.cgi?id=145226
2273         rdar://problem/20361786
2274
2275         Reviewed by Benjamin Poulain.
2276
2277         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2278         (TestWebKitAPI::TEST):
2279         Use patternHolder for pattern.
2280
2281 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2282
2283         [Content Extensions] Relax restrictions on triggers that match everything.
2284         https://bugs.webkit.org/show_bug.cgi?id=145069
2285
2286         Reviewed by Benjamin Poulain.
2287
2288         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2289         (TestWebKitAPI::TEST_F):
2290         Update and add tests for new possibilities with .*
2291
2292 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
2293
2294         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
2295         https://bugs.webkit.org/show_bug.cgi?id=144992
2296
2297         Reviewed by Gyuyoung Kim.
2298
2299         * MiniBrowser/efl/main.c:
2300         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
2301         (on_key_down):
2302         (on_fullscreen_enter):
2303         (on_fullscreen_exit):
2304         (window_create):
2305
2306 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2307
2308         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
2309         https://bugs.webkit.org/show_bug.cgi?id=145109
2310
2311         Reviewed by Darin Adler.
2312
2313         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2314         (TestWebKitAPI::TEST):
2315
2316 2015-05-19  Anders Carlsson  <andersca@apple.com>
2317
2318         Add alternate menu items for performing operations on the default data store
2319         https://bugs.webkit.org/show_bug.cgi?id=145184
2320
2321         Reviewed by Sam Weinig.
2322
2323         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
2324         associated with a data store.
2325
2326         * MiniBrowser/mac/AppDelegate.m:
2327         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
2328         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
2329         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
2330         * MiniBrowser/mac/MainMenu.xib:
2331
2332 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2333
2334         Fix tautological-compare warning in AtomicString.cpp
2335         https://bugs.webkit.org/show_bug.cgi?id=145120
2336
2337         Reviewed by Alexey Proskuryakov.
2338
2339         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2340         (TestWebKitAPI::TEST): Removed always true assert.
2341
2342 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
2343
2344         [EFL] Fix unsequenced warning in MiniBrowser's main.c
2345         https://bugs.webkit.org/show_bug.cgi?id=145123
2346
2347         Reviewed by Gyuyoung Kim.
2348
2349         * MiniBrowser/efl/main.c:
2350         (on_key_down):
2351
2352 2015-05-18  Daniel Bates  <dabates@apple.com>
2353
2354         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
2355         when staged non-empty file for commit
2356         https://bugs.webkit.org/show_bug.cgi?id=145082
2357
2358         Reviewed by Darin Adler.
2359
2360         Fixes two issues when running prepare-ChangeLog:
2361             1. The function above a deleted function is reported as changed.
2362             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
2363             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
2364             included in this patch).
2365
2366         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
2367         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
2368         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
2369         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
2370         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
2371         VCSUtil::parseChunkRange() has existing test coverage.
2372
2373         * Scripts/prepare-ChangeLog:
2374         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
2375         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
2376         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
2377         examine files that only have deletions. Currently this works as a side effect of the behavior of
2378         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
2379         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
2380         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
2381         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
2382         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2383         We return (-1, -1) when the change represents a deletion.
2384         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
2385         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2386         We return (-1, -1) when the change represents an addition.
2387         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
2388         unit tests.
2389
2390 2015-05-18  Anders Carlsson  <andersca@apple.com>
2391
2392         Add ATS keys to MiniBrowser
2393         https://bugs.webkit.org/show_bug.cgi?id=145141
2394
2395         Reviewed by Sam Weinig.
2396
2397         * MiniBrowser/mac/Info.plist:
2398
2399 2015-05-17  David Kilzer  <ddkilzer@apple.com>
2400
2401         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
2402         <http://webkit.org/b/145100>
2403
2404         Reviewed by Darin Adler.
2405
2406         * Scripts/bisect-builds:
2407         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
2408         - Switch to using PROMPT_RESPONSE_* constants when testing the
2409           value of $didReproduceBug.
2410         - Add do { } while loops to implement 'retry' mode.
2411         (promptForTest):
2412         - Switch to returning PROMPT_RESPONSE_* constants.
2413         - Add support for 'retry' response.
2414
2415 2015-05-16  Tanay C  <tanay.c@samsung.com>
2416
2417         [EFL][WK2] Minibrowser : Add search icon to search bar
2418         https://bugs.webkit.org/show_bug.cgi?id=139773
2419
2420         Reviewed by Gyuyoung Kim.
2421
2422         * MiniBrowser/efl/main.c: 
2423         (search_icon_show): Added.
2424         (search_box_show): Modified.
2425
2426 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2427
2428         run_benchmark should have an option to specify the number of runs
2429         https://bugs.webkit.org/show_bug.cgi?id=145091
2430
2431         Reviewed by Stephanie Lewis.
2432
2433         Added --count option.
2434
2435         * Scripts/run-benchmark:
2436         (main):
2437         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2438         (BenchmarkRunner.__init__):
2439
2440 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
2441
2442         Temporarily disable failing API test.
2443
2444         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2445         (TestWebKitAPI::TEST):
2446
2447 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
2448
2449         User interruption while running of run-webkit-tests should also generate results.html
2450         https://bugs.webkit.org/show_bug.cgi?id=122154
2451
2452         Reviewed by Csaba Osztrogonác.
2453
2454         Generation of results.html on execution of run-webkit-tests happens only
2455         on completion of entire layout tests run. It should be created even when
2456         the execution has been interrupted - either by user (by pressing Ctrl+C)
2457         or because of other interruptions (like exit-after-n-failures option).
2458
2459         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2460         (LayoutTestRunner.run_tests):
2461         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2462         (Manager.run):
2463         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2464         (TestRunResults.__init__):
2465         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2466         (main):
2467         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2468         (RunTest.test_keyboard_interrupt):
2469         (MainTest.test_exception_handling):
2470
2471 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
2472
2473         [buildbot] Fix the URL of the performance bots
2474         https://bugs.webkit.org/show_bug.cgi?id=145043
2475
2476         Reviewed by Ryosuke Niwa.
2477
2478         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2479
2480 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
2481
2482         Add a layout mode that scales down the view to try to fit the document
2483         https://bugs.webkit.org/show_bug.cgi?id=145022
2484         <rdar://problem/19790341>
2485
2486         Reviewed by Dean Jackson.
2487
2488         * MiniBrowser/mac/BrowserWindow.xib:
2489         * MiniBrowser/mac/BrowserWindowController.h:
2490         * MiniBrowser/mac/WK2BrowserWindowController.m:
2491         (-[WK2BrowserWindowController toggleShrinkToFit:]):
2492         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
2493         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
2494
2495 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2496
2497         [CMake] Don't read the LOCATION property of targets
2498         https://bugs.webkit.org/show_bug.cgi?id=145018
2499
2500         Reviewed by Martin Robinson.
2501
2502         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
2503         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
2504         be the same at configure-time as it is at generate-time.
2505
2506         * TestWebKitAPI/CMakeLists.txt:
2507
2508 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
2509
2510         Add String literal overloads to equalIgnoringASCIICase()
2511         https://bugs.webkit.org/show_bug.cgi?id=145008
2512
2513         Reviewed by Benjamin Poulain.
2514
2515         Test changes to WTF.
2516
2517         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2518         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
2519         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2520         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2521         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
2522         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2523
2524 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2525
2526         SharedBuffer::createWithContentsOfFile should use map file routines
2527         https://bugs.webkit.org/show_bug.cgi?id=144192
2528
2529         Reviewed by Darin Adler.
2530
2531         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
2532
2533         * TestWebKitAPI/PlatformGTK.cmake:
2534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2535         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
2536         (TestWebKitAPI::FileSystemTest::tempFilePath):
2537         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
2538         (TestWebKitAPI::TEST_F):
2539         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
2540         (TestWebKitAPI::SharedBufferTest::tempFilePath):
2541         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
2542         (TestWebKitAPI::TEST_F):
2543
2544 2015-05-13  Alex Christensen  <achristensen@webkit.org>
2545
2546         [Content Extensions] Test interactions between multiple extensions and multiple domains.
2547         https://bugs.webkit.org/show_bug.cgi?id=144967
2548
2549         Reviewed by Benjamin Poulain.
2550
2551         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2552         Xcode wanted to fix an alphabetization issue.
2553         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2554         (TestWebKitAPI::TEST_F):
2555         Test interactions that worked but were not explicitly tested before.
2556
2557 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2558
2559         Unreviewed build fix.
2560
2561         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
2562
2563         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
2564
2565 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2566
2567         Fix the previous commit, which made both bubbles green.
2568
2569         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2570         (.status-line.good .bubble):
2571         (.status-line.bad .bubble):
2572         (.status-line.good .message):
2573
2574 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2575
2576         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
2577         https://bugs.webkit.org/show_bug.cgi?id=144929
2578
2579         Reviewed by Eric Carlson.
2580
2581         Tweaked colors as I see fit.
2582
2583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2584         (.status-line.good .bubble):
2585         (.status-line.bad .bubble):
2586
2587 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
2588
2589         [Mac] Share cookie storage between UI process and secondary processes
2590         https://bugs.webkit.org/show_bug.cgi?id=144820
2591         rdar://problem/20572830
2592
2593         Reviewed by Darin Adler.
2594
2595         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2596         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
2597         for testing.
2598
2599 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
2600
2601         Fix internal build configuration issues
2602         https://bugs.webkit.org/show_bug.cgi?id=144762
2603
2604         Reviewed by David Kilzer.
2605
2606         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
2607
2608         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2609         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2610         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2611         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2612         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
2613         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2614         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2615         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2616
2617 2015-05-12  David Kilzer  <ddkilzer@apple.com>
2618
2619         Switch to launching iOS Simulator using bundle ID
2620         <rdar://problem/20916096>
2621
2622         This is required to fix the layout tests on internal bots.
2623
2624         * Scripts/webkitdirs.pm:
2625         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
2626         Simulator.  Add FIXME.
2627         (quitIOSSimulator): Add FIXME.
2628         * Scripts/webkitpy/port/ios.py:
2629         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
2630         launch iOS Simulator.  Add FIXME.
2631         (IOSSimulatorPort.check_sys_deps): Add FIXME.
2632
2633 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
2634
2635         Fix run-javascriptcore-tests step on the WinCairo bot
2636         https://bugs.webkit.org/show_bug.cgi?id=144866
2637
2638         Reviewed by Csaba Osztrogonác.
2639
2640         Catch exception when failing to create soft link, so we can fall back to copy.
2641
2642         * Scripts/run-jsc-stress-tests:
2643
2644 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
2645
2646         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
2647         https://bugs.webkit.org/show_bug.cgi?id=116971
2648
2649         Reviewed by Chris Fleizach.
2650
2651         Implement rowAtIndex for ATK.
2652
2653         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2654         (WTR::AccessibilityUIElement::rowAtIndex):
2655
2656 2015-05-11  Dan Bernstein  <mitz@apple.com>
2657
2658         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
2659
2660         Reviewed by Alexey Proskuryakov.
2661
2662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2663         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
2664         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
2665         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
2666
2667 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
2668
2669         Fix internal build configuration issues
2670         https://bugs.webkit.org/show_bug.cgi?id=144762
2671
2672         Reviewed by Darin Adler.
2673
2674         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
2675
2676         * TestWebKitAPI/Configurations/Base.xcconfig:
2677         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2678         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2679         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2680         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2681         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2682         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2683
2684 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
2685
2686         [Win] Move Windows build target to Windows 7 (or newer)
2687         https://bugs.webkit.org/show_bug.cgi?id=144890
2688         <rdar://problem/20707307>
2689
2690         Reviewed by Anders Carlsson.
2691
2692         Update linked SDK and minimal Windows level to be compatible with
2693         Windows 7 or newer.
2694
2695         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2696         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2697         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2698         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2699         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2700         * DumpRenderTree/config.h:
2701         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2702         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2703         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2704         * WinLauncher/stdafx.h:
2705
2706 2015-05-11  Commit Queue  <commit-queue@webkit.org>
2707
2708         Unreviewed, rolling out r184119.
2709         https://bugs.webkit.org/show_bug.cgi?id=144888
2710
2711         broke JSC tests on Apple Windows bots (Requested by kling on
2712         #webkit).
2713
2714         Reverted changeset:
2715
2716         "Fix run-javascriptcore-tests step on the WinCairo bot"
2717         https://bugs.webkit.org/show_bug.cgi?id=144866
2718         http://trac.webkit.org/changeset/184119
2719
2720 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2721
2722         run-benchmark should support Dromaeo
2723         https://bugs.webkit.org/show_bug.cgi?id=144849
2724
2725         Reviewed by Chris Dumez.
2726
2727         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
2728         they can take as much as 15 minutes to run each.
2729
2730         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
2731         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
2732         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
2733         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
2734
2735 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2736
2737         Build fix. jetstream has a local copy, not remote archive.
2738
2739         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2740
2741 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2742
2743         run-benchmark should support SunSpider, Kraken and Octane
2744         https://bugs.webkit.org/show_bug.cgi?id=144840
2745
2746         Reviewed by Darin Adler.
2747
2748         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
2749         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
2750         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
2751         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
2752
2753         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
2754         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
2755
2756         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
2757         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
2758
2759         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
2760         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
2761         now has the ability to run an arbitrary "create script".
2762
2763         * Scripts/run-benchmark:
2764         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
2765         This also overrides the remote archive URL specified in the plan.
2766
2767         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
2768
2769         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
2770         JetStreamBenchmarkBuilder.
2771
2772         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
2773         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
2774         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
2775         _runCreateScript and _applyPatch to clean after themselves.
2776         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
2777         JetStream, SunSpider, Kraken all use this feature.
2778         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
2779         the leaf directory name since the latter is not available when a remote ZIP file is used.
2780         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
2781         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
2782         the benchmark name in the patches.
2783
2784         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
2785
2786         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2787         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
2788         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
2789         the browser opens by planName as the plan file no longer contains that.
2790
2791         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
2792         the top directory of JetStream instead of its parent.
2793         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
2794         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
2795         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
2796         the top directory of JetStream instead of its parent.
2797         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
2798         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
2799         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
2800         done in JetStream.patch.
2801         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
2802         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
2803         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
2804         path from the top directory of JetStream as done in JetStream.patch.
2805         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
2806
2807 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
2808
2809         Fix run-javascriptcore-tests step on the WinCairo bot
2810         https://bugs.webkit.org/show_bug.cgi?id=144866
2811
2812         Reviewed by Darin Adler.
2813
2814         * Scripts/run-jsc-stress-tests:
2815
2816 2015-05-11  Alex Christensen  <achristensen@webkit.org>
2817
2818         [Content Extensions] Support domain-specific rules and exceptions.
2819         https://bugs.webkit.org/show_bug.cgi?id=144833
2820
2821         Reviewed by Darin Adler.
2822
2823         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2824         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2825         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2826         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2827         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
2828         (TestWebKitAPI::mainDocumentRequest):
2829         (TestWebKitAPI::subResourceRequest):
2830         (TestWebKitAPI::TEST_F):
2831         (TestWebKitAPI::checkCompilerError):
2832         Added tests for parsing and functionality of if-domain and unless-domain.
2833
2834 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2835
2836         run-benchmark should support Chrome Canary and Firefox Nightly
2837         https://bugs.webkit.org/show_bug.cgi?id=144850
2838
2839         Reviewed by Darin Adler.
2840
2841         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
2842
2843         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
2844
2845         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
2846         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
2847         (OSXBrowserDriver):
2848         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
2849         (OSXBrowserDriver.closeBrowsers): Ditto.
2850         (OSXBrowserDriver.launchProcess): Ditto.
2851         (OSXBrowserDriver.terminateProcesses): Ditto.
2852         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2853         (OSXChromeDriver): Removed the unused self.chromePreferences.
2854         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
2855         (OSXChromeDriver.closeBrowsers): Ditto.
2856         (OSXChromeDriver.launchUrl):
2857         (OSXChromeCanaryDriver): Added.
2858         (OSXChromeCanaryDriver.launchUrl):
2859         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
2860         (OSXFirefoxDriver): Added.
2861         (OSXFirefoxDriver.launchUrl):
2862         (OSXFirefoxNightlyDriver): Added.
2863         (OSXFirefoxNightlyDriver.launchUrl):
2864         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2865         (OSXSafariDriver):
2866         (OSXSafariDriver.closeBrowsers):
2867
2868 2015-05-11  Tim Horton  <timothy_horton@apple.com>
2869
2870         Page overlay action context override should indicate the source of the request
2871         https://bugs.webkit.org/show_bug.cgi?id=144832
2872         <rdar://problem/20562594>
2873
2874         Reviewed by Darin Adler.
2875
2876         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2877         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2878
2879 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
2880
2881         [GTK] fast/events/page-visibility-transition-test.html is timing out
2882         https://bugs.webkit.org/show_bug.cgi?id=114789
2883
2884         Reviewed by Darin Adler.
2885
2886         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2887         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
2888         requests visibility changes.
2889
2890 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2891
2892         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
2893         https://bugs.webkit.org/show_bug.cgi?id=144798
2894
2895         Reviewed by Darin Adler.
2896
2897         * efl/install-dependencies:
2898
2899 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
2900
2901         Make arguments of run-benchmark more user friendly
2902         https://bugs.webkit.org/show_bug.cgi?id=144835
2903
2904         Reviewed by Darin Adler.
2905
2906         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
2907         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
2908         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
2909         default values from --platform and --browser as they are required arguments.
2910
2911         * Scripts/run-benchmark:
2912         (main): Made --build-directory optional, and removed default values from --platform and --browser.
2913         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
2914         are not dynamically obtained via BrowserDriverFactory.
2915         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2916         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
2917         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
2918         run any benchmark in that case.
2919         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
2920         the specified file isn't a valid relative or an absolute path.
2921         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2922         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
2923         and browsers.
2924         (BrowserDriverFactory.available_browsers): Ditto.
2925         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2926         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
2927         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
2928         browserBuildPath was None.
2929         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2930         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
2931         so that we can use locally built WebKit to launch Safari.
2932
2933 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
2934
2935         Remove the PICTURE_SIZES build flag
2936         https://bugs.webkit.org/show_bug.cgi?id=144679
2937
2938         Reviewed by Benjamin Poulain.
2939
2940         Removed the PICTURE_SIZES build time flag.
2941
2942         * Scripts/webkitperl/FeatureList.pm:
2943
2944 2015-05-09  David Kilzer  <ddkilzer@apple.com>
2945
2946         Layout tests broke due to unexpected simctl output
2947
2948         * Scripts/webkitpy/xcode/simulator.py:
2949         (Simulator._parse_devices): Handle new Device Pairs header.
2950         * Scripts/webkitpy/xcode/simulator_unittest.py:
2951         (test_device_pairs): Add unit test for Device Pairs header.
2952
2953 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2954
2955         Remove convenience constructors for TextRun
2956         https://bugs.webkit.org/show_bug.cgi?id=144752
2957
2958         Reviewed by Anders Carlsson.
2959
2960         Test the StringView which takes a StringImpl*.
2961
2962         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2963         (StringView8Bit): Testing is8Bit() on StringView
2964
2965 2015-05-07  Sam Weinig  <sam@webkit.org>
2966
2967         [Content Extensions] Add simple tester that takes an extension and compiles it
2968         https://bugs.webkit.org/show_bug.cgi?id=144781
2969
2970         Reviewed by Dan Bates.
2971
2972         * ContentExtensionTester: Added.
2973         * ContentExtensionTester/Configurations: Added.
2974         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
2975         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
2976         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
2977         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
2978         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
2979         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
2980         * ContentExtensionTester/main.m: Added.
2981         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
2982
2983 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
2984
2985         Build fix.
2986
2987         Reviewed by Dan Bernstein.
2988
2989         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2990         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2991         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
2992         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2993         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2994         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2995         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
2996         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2997
2998 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
2999
3000         [GTK] Some tests fail because they do not assume the popup menu captures click events
3001         https://bugs.webkit.org/show_bug.cgi?id=40601
3002
3003         Reviewed by Carlos Garcia Campos.
3004
3005         Popdown all attached menus when moving between tests and between each new
3006         event sent to the WebView. This prevents context and popup menus from eating
3007         events.
3008
3009         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
3010         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
3011         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3012         (WTR::dispatchEvent): Popdown all menus between dispatching events.
3013         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
3014         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
3015         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3016         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
3017         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3018         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
3019         longer in the platform-independent file.
3020         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
3021
3022 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
3023
3024         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3025         https://bugs.webkit.org/show_bug.cgi?id=144746
3026
3027         Reviewed by Carlos Garcia Campos.
3028
3029         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3030
3031         * MiniBrowser/gtk/main.c:
3032         (main):
3033
3034 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3035
3036         Unreviewed, rolling out r183996.
3037         https://bugs.webkit.org/show_bug.cgi?id=144806
3038
3039         ASan detected use-after free (Requested by ap on #webkit).
3040
3041         Reverted changeset:
3042
3043         "Remove convenience constructors for TextRun"
3044         https://bugs.webkit.org/show_bug.cgi?id=144752
3045         http://trac.webkit.org/changeset/183996
3046
3047 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3048
3049         Remove convenience constructors for TextRun
3050         https://bugs.webkit.org/show_bug.cgi?id=144752
3051
3052         Reviewed by Anders Carlsson.
3053
3054         Test the StringView which takes a StringImpl*.
3055
3056         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3057         (StringView8Bit): Testing is8Bit() on StringView
3058
3059 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3060
3061         [GTK] WTR doesn't correctly handle the Escape key
3062         https://bugs.webkit.org/show_bug.cgi?id=144788
3063
3064         Reviewed by Martin Robinson.
3065
3066         Correctly handle 0x001B character code in GTK+ event sender to be
3067         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
3068         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
3069         to dismiss popup menus.
3070
3071         Fixes editing/selection/5354455-1.html.
3072
3073         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3074         (WTR::getGDKKeySymForKeyRef):
3075
3076 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3077
3078         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
3079         https://bugs.webkit.org/show_bug.cgi?id=144748
3080
3081         Reviewed by Sergio Villar Senin.
3082
3083         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3084         (testWebKitSettings): Check the new setting is correctly
3085         initialized and updated.
3086         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3087         (testWebContextSecurityFileXHR): Check XHR to local files is
3088         allowed from file URLs after changing the setting.
3089         (beforeAll): Add new test.
3090
3091 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3092
3093         Unreviewed, rolling out r183945.
3094         https://bugs.webkit.org/show_bug.cgi?id=144789
3095
3096         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
3097
3098         Reverted changeset:
3099
3100         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
3101         https://bugs.webkit.org/show_bug.cgi?id=144746
3102         http://trac.webkit.org/changeset/183945
3103
3104 2015-05-07  Anders Carlsson  <andersca@apple.com>
3105
3106         Build fixes.
3107
3108         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3109         (TestWebKitAPI::TEST):
3110         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3111         (TestWebKitAPI::TEST):
3112         Add casts.
3113
3114 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
3115
3116         GC has trouble with pathologically large array allocations
3117         https://bugs.webkit.org/show_bug.cgi?id=144609
3118
3119         Reviewed by Geoffrey Garen.
3120         
3121         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
3122         and it's a frequently requested feature.
3123         
3124         Also add the ability to run a test pretending that your system has a particular RAM size.
3125         This is useful for GC tests, and the new GC test that I added uses this.
3126
3127         * Scripts/run-javascriptcore-tests:
3128         (runJSCStressTests):
3129         * Scripts/run-jsc-stress-tests:
3130
3131 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
3132
3133         [EFL] Bump EFL version to 1.14.0
3134         https://bugs.webkit.org/show_bug.cgi?id=144743
3135
3136         Reviewed by Darin Adler.
3137
3138         Bump EFL and elementary version to 1.14.0 and removed
3139         md5sum, because it isn't used at all if hash is present.
3140
3141         * efl/jhbuild.modules:
3142
3143 2015-05-07  Saam Barati  <saambarati1@gmail.com>
3144
3145         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
3146         https://bugs.webkit.org/show_bug.cgi?id=144753
3147
3148         Reviewed by Mark Lam.
3149
3150         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3151
3152 2015-05-07  Beth Dakin  <bdakin@apple.com>
3153
3154         New force-related DOM events should fire in WK1 views
3155         https://bugs.webkit.org/show_bug.cgi?id=144663
3156         -and corresponding-
3157         rdar://problem/20281886
3158
3159         Reviewed by Sam Weinig.
3160
3161         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
3162         now. Just send nil. 
3163         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3164         (TestWebKitAPI::buildAndPerformTest):
3165
3166 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3167
3168         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3169         https://bugs.webkit.org/show_bug.cgi?id=144746
3170
3171         Reviewed by Martin Robinson.
3172
3173         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3174
3175         * MiniBrowser/gtk/main.c:
3176         (main):
3177
3178 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3179
3180         Revert "Introducing the Platform Abstraction Layer (PAL)"
3181         https://bugs.webkit.org/show_bug.cgi?id=144751
3182
3183         Unreviewed.
3184
3185         PAL should be a new target inside WebCore, rather than a top-level folder.
3186
3187         * Scripts/build-webkit: Add it to build-webkit.
3188
3189 2015-05-07  Ada Chan  <adachan@apple.com>
3190
3191         Add a test for WKPageCopySessionState() with filtering.
3192         https://bugs.webkit.org/show_bug.cgi?id=144666
3193
3194         Reviewed by Darin Adler.
3195
3196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3197         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
3198         (TestWebKitAPI::didFinishLoadForFrame):
3199         (TestWebKitAPI::setPageLoaderClient):
3200         (TestWebKitAPI::filterFirstItemCallback):
3201         (TestWebKitAPI::filterAllItemsCallback):
3202         (TestWebKitAPI::createSessionStates):
3203         (TestWebKitAPI::TEST):
3204
3205 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3206
3207         iOS build fix attempt
3208
3209         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
3210
3211         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3212
3213 2015-05-06  Matt Baker  <mattbaker@apple.com>
3214
3215         Unreviewed, updated my list of email addresses.
3216
3217         * Scripts/webkitpy/common/config/contributors.json:
3218
3219 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3220
3221         Do not link tools to WebKit2.framework
3222         https://bugs.webkit.org/show_bug.cgi?id=144699
3223
3224         Unreviewed build fix.
3225
3226         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3227         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3228         These linked to WebKit2 in two ways, eliminating the other one.
3229
3230 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3231
3232         Introducing the Platform Abstraction Layer (PAL)
3233         https://bugs.webkit.org/show_bug.cgi?id=143358
3234
3235         Reviewed by Simon Fraser.
3236
3237         * Scripts/build-webkit: Add it to build-webkit.
3238
3239 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3240
3241         Fix api tests after r183877.
3242
3243         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3244         (TestWebKitAPI::TEST_F):
3245         Generate all DFAs before compiling them.
3246
3247 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3248
3249         Do not link tools to WebKit2.framework
3250         https://bugs.webkit.org/show_bug.cgi?id=144699
3251
3252         Reviewed by Tim Horton.
3253
3254         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3256         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3257
3258 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3259
3260         [Content Extensions] Test splitting NFAs by max NFA size.
3261         https://bugs.webkit.org/show_bug.cgi?id=144659
3262
3263         Reviewed by Darin Adler.
3264
3265         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3266         (TestWebKitAPI::createNFAs):
3267         (TestWebKitAPI::TEST_F):
3268         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3269         (TestWebKitAPI::createNFAs):
3270
3271 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
3272
3273         Remove the remaining vestiges of SVG feature define
3274         https://bugs.webkit.org/show_bug.cgi?id=144655
3275
3276         Reviewed by Alexey Proskuryakov.
3277
3278         * Scripts/webkitperl/FeatureList.pm:
3279
3280 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
3281
3282         Add a layout mode for computing fixed layout size from a minimum size
3283         https://bugs.webkit.org/show_bug.cgi?id=144610
3284         <rdar://problem/19790341>
3285
3286         Reviewed by Simon Fraser.
3287
3288         * MiniBrowser/mac/BrowserWindow.xib:
3289         * MiniBrowser/mac/BrowserWindowController.h:
3290         * MiniBrowser/mac/WK1BrowserWindowController.m:
3291         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
3292         * MiniBrowser/mac/WK2BrowserWindowController.m:
3293         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
3294         Add a optional toolbar item to toggle a minimum view size of 1024x0.
3295
3296 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3297
3298         [Content Extensions] Release input NSString when finished copying it.
3299         https://bugs.webkit.org/show_bug.cgi?id=144642
3300
3301         Reviewed by Brian Weinstein.
3302
3303         * WebKitTestRunner/mac/TestControllerMac.mm:
3304         (WTR::TestController::platformConfigureViewForTest):
3305         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
3306
3307 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
3308
3309         Unreviewed test fix after r183798.
3310
3311         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3312         (convertToDRTLabel): Mimic behavior of Mac accessibility output
3313         so we can share results.
3314
3315 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3316
3317         [Content Extensions] Use less memory to store the json input.
3318         https://bugs.webkit.org/show_bug.cgi?id=144604
3319
3320         Reviewed by Benjamin Poulain.
3321
3322         * MiniBrowser/mac/ExtensionManagerWindowController.m:
3323         (-[ExtensionManagerWindowController add:]):
3324         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3325         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3326         * WebKitTestRunner/mac/TestControllerMac.mm:
3327         (WTR::TestController::platformConfigureViewForTest):
3328
3329 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3330
3331         Unreviewed. Make myself a WebKit reviewer.
3332
3333         * Scripts/webkitpy/common/config/contributors.json:
3334
3335 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
3336
3337         [GTK] r183783 breaks build
3338         https://bugs.webkit.org/show_bug.cgi?id=144632
3339
3340         Reviewed by Martin Robinson.
3341
3342         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
3343
3344         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3345         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3346
3347 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3348
3349         [Content Extensions] Combine NFAs properly and free memory as we compile.
3350         https://bugs.webkit.org/show_bug.cgi?id=144485
3351
3352         Reviewed by Benjamin Poulain.
3353
3354         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3355         (TestWebKitAPI::TEST_F):
3356         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
3357         Added tests for deep NFAs.
3358
3359 2015-05-04  Alex Christensen  <achristensen@webkit.org>
3360
3361         [Content Extensions] Use less memory when writing byte code to file
3362         https://bugs.webkit.org/show_bug.cgi?id=144602
3363
3364         Reviewed by Darin Adler.
3365
3366         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3367
3368 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3369
3370         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
3371         https://bugs.webkit.org/show_bug.cgi?id=144541
3372
3373         Reviewed by Žan Doberšek.
3374
3375         Add a test case to WorkQueue unit test, to check that sources of
3376         asynchronous IO operations running in the WorkQueue thread are
3377         dispatched by the WorkQueue main loop.
3378
3379         * TestWebKitAPI/PlatformGTK.cmake:
3380         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
3381         (TestWebKitAPI::TEST):
3382
3383 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3384
3385         Correct '--show-webview' option for Tiled Drawing tests
3386         https://bugs.webkit.org/show_bug.cgi?id=144621
3387
3388         Reviewed by Simon Fraser.
3389
3390         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
3391         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
3392
3393         * WebKitTestRunner/mac/TestControllerMac.mm:
3394         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
3395         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
3396
3397 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
3398
3399         Large array shouldn't be slow
3400         https://bugs.webkit.org/show_bug.cgi?id=144617
3401
3402         Reviewed by Geoffrey Garen.
3403         
3404         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
3405         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
3406         long-running. So, hash-map sort of belongs here.
3407
3408         * Scripts/run-jsc-benchmarks:
3409
3410 2015-05-04  Doug Russell  <d_russell@apple.com>
3411
3412         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
3413         https://bugs.webkit.org/show_bug.cgi?id=144489
3414
3415         Reviewed by Chris Fleizach.
3416
3417         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
3418         on the returned control.
3419         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
3420         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
3421         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
3422         Add support for setSelectedVisibleTextRange() in accessibility tests.
3423
3424         * DumpRenderTree/AccessibilityUIElement.cpp:
3425         (setSelectedVisibleTextRangeCallback):
3426         (AccessibilityUIElement::setSelectedVisibleTextRange):
3427         (AccessibilityUIElement::getJSClass):
3428         (AccessibilityUIElement::textMarkerForIndex): Deleted.
3429         * DumpRenderTree/AccessibilityUIElement.h:
3430         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3431         (AccessibilityUIElement::setSelectedVisibleTextRange):
3432         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3433         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3434         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
3435         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3436         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3437         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3438         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3439         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3440         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3441         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3442         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3443
3444 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3445
3446         [Win] Implement the "--show-webview" option for Windows
3447         https://bugs.webkit.org/show_bug.cgi?id=144589
3448
3449         Reviewed by Alex Christensen.
3450
3451         Add another runtime flag (--show-webview) that causes DumpRenderTree
3452         to draw its view on-screen, rather than the standard offscreen mode.
3453
3454         * DumpRenderTree/win/DumpRenderTree.cpp:
3455         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
3456         (initializeGlobalsFromCommandLineOptions): Recognize the new
3457         command-line argument, and set the global 'showWebView' state if
3458         appropriate.
3459
3460 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
3461
3462         Remove dead code from TestInvocationCairo.cpp
3463         https://bugs.webkit.org/show_bug.cgi?id=144564
3464
3465         Reviewed by Gyuyoung Kim.
3466
3467         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
3468
3469         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3470         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3471
3472 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
3473
3474         [GTK] Add libnotify in gtk install-dependencies
3475         https://bugs.webkit.org/show_bug.cgi?id=144379
3476
3477         Reviewed by Csaba Osztrogonác.
3478
3479         * gtk/install-dependencies:
3480
3481 2015-05-01  Dan Bernstein  <mitz@apple.com>
3482
3483         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
3484         https://bugs.webkit.org/show_bug.cgi?id=144501
3485
3486         Reviewed by Darin Adler.
3487
3488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3489         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
3490         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
3491         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
3492
3493 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3494
3495         check-webkit-style fails due to system pylint
3496         https://bugs.webkit.org/show_bug.cgi?id=144360
3497
3498         Reviewed by Darin Adler.
3499
3500         Make sure that the directory containing third party autoinstalled modules
3501         is at the beginning of the search path, to avoid conflicts with other
3502         versions of the same modules installed in the system (e.g. pylint).
3503
3504         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
3505         modules directory to sys.path, instead of appending it.
3506
3507 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3508
3509         Unreviewed, updated my list of email addresses.
3510
3511         * Scripts/webkitpy/common/config/contributors.json: Updated.
3512
3513 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
3514
3515         USE(...) macro should expect unprefixed variables
3516         https://bugs.webkit.org/show_bug.cgi?id=144454
3517
3518         Reviewed by Daniel Bates.
3519
3520         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
3521         * DumpRenderTree/config.h: Ditto.
3522         * TestWebKitAPI/config.h: Ditto.
3523
3524 2015-05-01  Basile Clement  <basile_clement@apple.com>
3525
3526         Unreviewed. Add myself as a commiter in contributors.json.
3527
3528         * Scripts/webkitpy/common/config/contributors.json:
3529
3530 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
3531
3532         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
3533         https://bugs.webkit.org/show_bug.cgi?id=144487
3534
3535         Reviewed by Ryosuke Niwa.
3536
3537         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3538         (BenchmarkRunner.merge): Fix bug.
3539         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
3540
3541 2015-05-01  Brady Eidson  <beidson@apple.com>
3542
3543         Add API to disable meta refreshes.
3544         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
3545
3546         Reviewed by Alexey Proskuryakov.
3547
3548         * DumpRenderTree/mac/DumpRenderTree.mm:
3549         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
3550
3551 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
3552
3553         Provide a runtime flag to run-webkit-tests that shows the test view
3554         https://bugs.webkit.org/show_bug.cgi?id=144079.
3555
3556         Unreviewed correction to r183651.
3557
3558         * WebKitTestRunner/TestController.cpp:
3559         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
3560         flag is included in the options dictionary passed to the PlatformWebView.
3561
3562 2015-05-01  Antti Koivisto  <antti@apple.com>
3563
3564         Remove network process load serialization code
3565         https://bugs.webkit.org/show_bug.cgi?id=144448
3566
3567         Reviewed by Alexey Proskuryakov.
3568
3569         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3570         (WTR::InjectedBundle::beginTesting):
3571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3572         (WTR::TestRunner::setSerializeHTTPLoads):
3573         (WTR::TestRunner::dispatchPendingLoadRequests):
3574
3575 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3576
3577         [GTK] Add libhyphen-dev to the build dependencies
3578         https://bugs.webkit.org/show_bug.cgi?id=144452
3579
3580         Reviewed by Martin Robinson.
3581
3582         * gtk/install-dependencies: Added hyphen as Fedora and Arch
3583         dependencies.
3584
3585 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
3586
3587         Provide a runtime flag to run-webkit-tests that shows the test view
3588         https://bugs.webkit.org/show_bug.cgi?id=144079.
3589
3590         Reviewed by Dean Jackson.
3591
3592         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
3593         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
3594         option:
3595         
3596         --additional-drt-flag="--show-webview"
3597
3598         * DumpRenderTree/mac/DumpRenderTree.mm:
3599         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
3600         '--show-webview' flag.
3601         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
3602         * WebKitTestRunner/Options.cpp:
3603         (WTR::Options::Options):
3604         (WTR::handleOptionShowWebView):
3605         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
3606         * WebKitTestRunner/Options.h:
3607         * WebKitTestRunner/TestController.cpp:
3608         (WTR::TestController::TestController):
3609         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
3610         * WebKitTestRunner/TestController.h:
3611         (WTR::TestController::shouldShowWebView):
3612         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3613         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
3614         options dictionary. If it is true, display the web view while running the test.
3615
3616 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
3617
3618         r183355 didn't trigger Mac tests
3619         https://bugs.webkit.org/show_bug.cgi?id=144464
3620
3621         Reviewed by Simon Fraser.
3622
3623         Update badly neglected filters and unit tests.
3624
3625         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3626         (_should_file_trigger_build):
3627         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3628         (ShouldBuildTest):
3629         (ShouldBuildTest.test_should_build):
3630
3631 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3632
3633         [GTK] Add libhyphen-dev to the build dependencies
3634         https://bugs.webkit.org/show_bug.cgi?id=144452
3635
3636         Reviewed by Martin Robinson.
3637
3638         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
3639         build dependencies.
3640
3641 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
3642
3643         [GTK] Testing dictionaries are not installed automatically
3644         https://bugs.webkit.org/show_bug.cgi?id=144460
3645
3646         Reviewed by Carlos Garcia Campos.
3647
3648         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
3649
3650 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
3651
3652         Fix return code issue, check return cod