1 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
3 run-jsc-benchmarks should only report preferred mean
4 https://bugs.webkit.org/show_bug.cgi?id=142874
6 Reviewed by Geoffrey Garen.
8 Just collect statistics for the preferred mean.
10 * Scripts/run-jsc-benchmarks:
12 2015-03-19 Alex Christensen <achristensen@webkit.org>
14 [Content Extensions] Test regular expression parse failures.
15 https://bugs.webkit.org/show_bug.cgi?id=142872
17 Reviewed by Benjamin Poulain.
19 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
20 (TestWebKitAPI::testPatternStatus):
21 (TestWebKitAPI::TEST_F):
22 Added tests for each parsing status.
24 2015-03-19 Alex Christensen <achristensen@webkit.org>
26 Fix API tests after r181754.
28 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
29 (TestWebKitAPI::testRequest):
31 2015-03-19 Brady Eidson <beidson@apple.com>
33 Part of content extensions should apply css selectors
34 https://bugs.webkit.org/show_bug.cgi?id=142604
36 Reviewed by Alex Christensen.
38 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
39 (WebCore::ContentExtensions::operator<<):
41 2015-03-19 Brent Fulgham <bfulgham@apple.com>
43 [Win] Activate tests on EWS
44 https://bugs.webkit.org/show_bug.cgi?id=142850
46 Reviewed by Alexey Proskuryakov.
48 * Scripts/webkitpy/common/config/ews.json: Add me as
49 the EWS bot watcher, and activate tests.
51 2015-03-19 Csaba Osztrogonác <ossy@webkit.org>
53 [GTK] Fix inspector userinterface related incremental build issue
54 https://bugs.webkit.org/show_bug.cgi?id=142849
56 Reviewed by Carlos Garcia Campos.
58 * Scripts/webkitdirs.pm:
59 (shouldRemoveCMakeCache):
61 2015-03-18 Alex Christensen <achristensen@webkit.org>
63 [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
64 https://bugs.webkit.org/show_bug.cgi?id=142799
66 Reviewed by Brady Eidson.
68 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
69 (TestWebKitAPI::testPattern):
70 (TestWebKitAPI::TEST_F):
71 Start testing regex failures.
73 2015-03-18 Dhi Aurrahman <diorahman@rockybars.com>
75 Fix StringView typos after r181525 and r181558
76 https://bugs.webkit.org/show_bug.cgi?id=142772
78 Reviewed by Darin Adler.
80 Add some tests in [1] to cover the StringView::startsWith,
81 StringView::startsWithIgnoringASCIICase, StringView::endsWith and
82 StringView::endsWithIgnoringASCIICase implementations.
84 * TestWebKitAPI/Tests/WTF/StringView.cpp:
85 (TestWebKitAPI::TEST):
87 2015-03-18 Dana Burkart <dburkart@apple.com>
89 Remove extraneous import to fix the build.
93 * Scripts/webkitpy/port/driver.py:
95 2015-03-18 Dana Burkart <dburkart@apple.com>
97 ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
98 https://bugs.webkit.org/show_bug.cgi?id=142547
100 Reviewed by Alexey Proskuryakov.
102 * Scripts/webkitpy/port/driver.py:
103 (Driver._setup_environ_for_driver):
105 2015-03-18 Alexey Proskuryakov <ap@apple.com>
107 Tweak how AppleSystemFontOSSubversion default is added
108 https://bugs.webkit.org/show_bug.cgi?id=142835
110 Reviewed by Dan Bernstein.
112 * DumpRenderTree/mac/DumpRenderTree.mm:
113 (setDefaultsToConsistentValuesForTesting):
115 2015-03-18 Dan Bernstein <mitz@apple.com>
117 prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
118 https://bugs.webkit.org/show_bug.cgi?id=142815
120 Reviewed by Darin Adler.
122 * Scripts/prepare-ChangeLog:
123 (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
124 quotation mark, use new variable $quotation_mark to remember what we are looking for, and
125 keep consuming the quoted text until the matching quotation mark is reached. Emit the
126 warning only if a line ends without a backslash before the matching quotation mark was found.
128 2015-03-18 Joseph Pecoraro <pecoraro@apple.com>
130 Remove unused "preprocessor" parameter to sub-CodeGenerators
131 https://bugs.webkit.org/show_bug.cgi?id=142793
133 Reviewed by Darin Adler.
135 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
138 2015-03-18 Csaba Osztrogonác <ossy@webkit.org>
140 [EFL] Bump gstreamer version to 1.4.4
141 https://bugs.webkit.org/show_bug.cgi?id=142782
143 Reviewed by Philippe Normand.
145 * efl/jhbuild.modules:
146 * efl/patches/gst-libav.patch:
147 * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
148 * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
150 2015-03-17 Tim Horton <timothy_horton@apple.com>
154 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
155 (WTR::InjectedBundle::platformInitialize):
157 2015-03-17 Dean Jackson <dino@apple.com>
159 check-webkit-style should allow "bool a : 1"
160 https://bugs.webkit.org/show_bug.cgi?id=142794
162 Reviewed by Brent Fulgham.
164 We should allow member bitfields of the form:
168 It seems that Visual Studio 8 was the last compiler that
169 wasn't happy about not using unsigned here. We already have
170 about 500 cases (in WebCore) where people were ignoring this rule.
172 * Scripts/webkitpy/style/checkers/cpp.py:
173 (check_language): Allow "bool".
174 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
175 (CppStyleTest.test_enum_bitfields):
176 (CppStyleTest.test_plain_integral_bitfields):
178 2015-03-17 Benjamin Poulain <bpoulain@apple.com>
180 Compile character ranges targeting the same state as range check in the bytecode
181 https://bugs.webkit.org/show_bug.cgi?id=142759
183 Reviewed by Alex Christensen.
185 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
186 (TestWebKitAPI::TEST_F):
188 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
190 W3C test parser and converter should use test importer host
191 https://bugs.webkit.org/show_bug.cgi?id=142729
193 Reviewed by Bem Jones-Bey.
195 When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
196 This enables adding more TestImporter unit testing.
197 This patch also ensures that the git object instantiated by TestDownloader is using the
198 same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
200 * Scripts/webkitpy/common/system/filesystem_mock.py:
201 (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
202 * Scripts/webkitpy/w3c/test_downloader.py:
203 (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
204 (TestDownloader.checkout_test_repository): Making use of the new git function.
205 * Scripts/webkitpy/w3c/test_importer.py:
206 (TestImporter.find_importable_tests): Adding host as parameter to the parser.
207 (TestImporter.import_tests): Adding host as parameter to the converter.
208 * Scripts/webkitpy/w3c/test_importer_unittest.py:
209 (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
211 (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
212 * Scripts/webkitpy/w3c/test_parser.py:
213 (TestParser.__init__): Adding host as parameter constructor.
215 2015-03-17 Carlos Garcia Campos <cgarcia@igalia.com>
217 [GTK] WebKitDOM objects leaking
218 https://bugs.webkit.org/show_bug.cgi?id=118788
220 Reviewed by Darin Adler and Sergio Villar Senin.
222 Update DOMObjectCache unit test to check that DOM objects are also
223 released when new contents are loaded in the web view, and the old
224 document is detached from the frame.
226 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
227 (testWebKitDOMObjectCache):
228 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
231 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
233 W3C test importer default import folder should be LayoutTests/imported/w3c
234 https://bugs.webkit.org/show_bug.cgi?id=142728
236 Reviewed by Bem Jones-Bey.
238 * Scripts/webkitpy/w3c/test_importer.py:
239 (parse_args): Updating the default destination option value to 'imported/w3c'.
241 2015-03-17 Philippe Normand <pnormand@igalia.com>
243 [GTK] basic OpenWebRTC build support
244 https://bugs.webkit.org/show_bug.cgi?id=142393
246 Reviewed by Carlos Garcia Campos.
248 * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
249 is not the upstream OpenWebRTC repository. This temporary fork
250 contains a few patches needed by WebKit for audio/video rendering.
252 2015-03-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
254 [CMake][EFL] Build test tools only for developer mode
255 https://bugs.webkit.org/show_bug.cgi?id=142761
257 Reviewed by Csaba Osztrogonác.
259 Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
263 2015-03-17 Joseph Pecoraro <pecoraro@apple.com>
265 Remove never used "useLayerOnTop" bindings generator argument
266 https://bugs.webkit.org/show_bug.cgi?id=142773
268 Reviewed by Darin Adler.
270 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
273 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
275 Enable ES6 classes by default
276 https://bugs.webkit.org/show_bug.cgi?id=142774
278 Reviewed by Gavin Barraclough.
280 * Scripts/webkitperl/FeatureList.pm:
282 2015-03-16 Alexey Proskuryakov <ap@apple.com>
284 Fix webkitpy tests after r181585.
286 Looks like "me" cannot be anyone's email, it's a special case.
288 * Scripts/webkitpy/common/config/contributors.json:
290 2015-03-16 Alexey Proskuryakov <ap@apple.com>
292 Add tolerance to WebAudio tests
293 https://bugs.webkit.org/show_bug.cgi?id=142676
295 Reviewed by Tim Horton.
297 * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
299 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
300 (TestResultWriter.create_audio_diff_and_write_result):
301 * Scripts/webkitpy/layout_tests/models/test_failures.py:
302 (FailureAudio.write_failure):
303 * Scripts/webkitpy/port/base.py:
304 (Port.do_audio_results_differ):
307 * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
308 tests to use real parseable WAV data, and got rid of base64, which there didn't
309 seem to have been any reason for.
311 2015-03-16 Alexey Proskuryakov <ap@apple.com>
313 [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
314 https://bugs.webkit.org/show_bug.cgi?id=142720
316 Reviewed by Myles C. Maxfield.
318 Activate system copies of Microsoft fonts for the current process, thus overriding
319 any other ones that could be preferred by the system otherwise.
321 * DumpRenderTree/mac/DumpRenderTree.mm:
322 (activateSystemCoreWebFonts):
324 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
325 (WTR::activateSystemCoreWebFonts):
326 (WTR::activateFonts):
328 2015-03-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
330 Created Streams API watchlist
331 https://bugs.webkit.org/show_bug.cgi?id=142684
333 Reviewed by Benjamin Poulain.
335 * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
336 watchlist and added Benjamin, Youenn and me to it.
338 2015-03-15 Benjamin Poulain <benjamin@webkit.org>
340 CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
341 https://bugs.webkit.org/show_bug.cgi?id=142715
343 Reviewed by Brent Fulgham.
345 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
346 (TestWebKitAPI::TEST):
348 2015-03-15 Benjamin Poulain <bpoulain@apple.com>
350 Change the exact attribute matching to be ASCII case-insensitive
351 https://bugs.webkit.org/show_bug.cgi?id=142609
353 Reviewed by Darin Adler.
355 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
356 * TestWebKitAPI/Tests/WTF/StringView.cpp:
358 2015-03-13 Youenn Fablet <youenn.fablet@crf.canon.fr>
360 WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
361 https://bugs.webkit.org/show_bug.cgi?id=134764
363 Reviewed by Ryosuke Niwa.
365 TestDownloader is introduced to download W3C tests from the official
366 W3C tests repositories (https://github.com/w3c/web-platform-tests.git
367 and https://github.com/w3c/csswg-test.git).
368 TestDownloader clones the repositories and checkouts revisions of the tests
369 defined in LayoutTests/imported/w3c/resources/TestRepositories.
371 Similarly to https://codereview.chromium.org/148173016,
372 TestDownloader copies part of the files based on the rules
373 defined in LayoutTests/imported/w3c/resources/ImportExpectations.
375 TestDownloader is used by TestImporter when no source directory is provided.
377 * Scripts/webkitpy/w3c/test_downloader.py: Added.
379 (TestDownloader.default_options):
380 (TestDownloader.load_test_repositories):
381 (TestDownloader.__init__):
382 (TestDownloader.checkout_test_repository):
383 (TestDownloader._init_paths_from_expectations):
384 (TestDownloader._add_test_suite_paths):
385 (TestDownloader._empty_directory):
386 (TestDownloader.copy_tests):
387 (TestDownloader.download_tests):
388 * Scripts/webkitpy/w3c/test_importer.py:
391 (TestImporter.__init__):
392 (TestImporter.do_import):
393 (TestImporter.test_downloader):
394 (TestImporter.find_importable_tests.should_keep_subdir):
395 (TestImporter.should_convert_test_harness_links):
396 (TestImporter.import_tests):
397 (TestImporter.write_import_log):
399 2015-03-12 Alexey Proskuryakov <ap@apple.com>
401 [Mavericks] Test snapshots are 1600x1200 on Retina devices
402 https://bugs.webkit.org/show_bug.cgi?id=142630
404 Reviewed by Tim Horton.
406 * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
407 Removed an ifdef that disabled the fix on Mavericks.
409 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
411 Remove isWK2 cruft from webkitdirs.pm after r170426
412 https://bugs.webkit.org/show_bug.cgi?id=142618
414 Reviewed by Daniel Bates.
416 * Scripts/webkitdirs.pm:
419 2015-03-12 Alexey Proskuryakov <ap@apple.com>
421 testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
422 https://bugs.webkit.org/show_bug.cgi?id=138687
424 Reviewed by Carlos Garcia Campos.
426 Always change cookie policy from UI process, as changing it from WebProcess doesn't
427 affect other processes.
429 The implementation is imperfect, because the change happens asynchronously, but I
430 don't expect it to be a problem in practice.
432 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
433 (WTR::InjectedBundle::beginTesting):
434 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
435 (WTR::TestRunner::setAlwaysAcceptCookies):
436 * WebKitTestRunner/TestInvocation.cpp:
437 (WTR::TestInvocation::invoke):
438 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
440 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
442 [EFL] Enable building EFL 1.13 with NEON support
443 https://bugs.webkit.org/show_bug.cgi?id=142619
445 Reviewed by Gyuyoung Kim.
447 * efl/jhbuild.modules:
449 2015-03-11 Alex Christensen <achristensen@webkit.org>
451 [Content Extensions] Add resource type and load type triggers.
452 https://bugs.webkit.org/show_bug.cgi?id=142422
454 Reviewed by Benjamin Poulain.
456 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
457 (TestWebKitAPI::testRequest):
458 (TestWebKitAPI::mainDocumentRequest):
459 (TestWebKitAPI::TEST_F):
460 (TestWebKitAPI::testURL): Deleted.
462 2015-03-10 Sam Weinig <sam@webkit.org>
464 Allow adding a button in input elements for auto fill related functionality
465 <rdar://problem/19782066>
466 https://bugs.webkit.org/show_bug.cgi?id=142564
468 Reviewed by Anders Carlsson.
470 * WebKitTestRunner/TestController.cpp:
471 (WTR::TestController::createOtherPage):
472 (WTR::TestController::createWebViewWithOptions):
473 Update for new callback.
475 2015-03-11 Benjamin Poulain <bpoulain@apple.com>
477 Add basic support for BOL and EOL assertions to the URL Filter parser
478 https://bugs.webkit.org/show_bug.cgi?id=142568
480 Reviewed by Alex Christensen.
482 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
483 (TestWebKitAPI::TEST_F):
485 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
487 [GTK] Add support for handling TLS errors to MiniBrowser
488 https://bugs.webkit.org/show_bug.cgi?id=142576
490 Reviewed by Sergio Villar Senin.
492 It's useful for testing TLS errors handling itself, but also to
493 allow ignoring TLS errors when testing.
495 * MiniBrowser/gtk/BrowserWindow.c:
496 (webViewLoadFailedWithTLSerrors):
497 (browserWindowConstructed):
499 2015-03-11 Myles C. Maxfield <mmaxfield@apple.com>
501 Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
502 https://bugs.webkit.org/show_bug.cgi?id=142569
504 Reviewed by David Hyatt.
506 Test Optional::valueOrCompute().
508 * TestWebKitAPI/Tests/WTF/Optional.cpp:
509 (TestWebKitAPI::TEST):
511 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
513 [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
514 https://bugs.webkit.org/show_bug.cgi?id=126688
516 Reviewed by Gustavo Noronha Silva.
518 * CMakeLists.txt: Build testing tools only for developer builds,
519 but MiniBrowser when ENABLE_MINIBROWSER option is ON.
520 * MiniBrowser/gtk/CMakeLists.txt: Only add
521 -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
522 and add a rule to install the MiniBrowser.
523 * MiniBrowser/gtk/main.c:
524 (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
527 2015-03-11 Brent Fulgham <bfulgham@apple.com>
529 Add some DateMath tests to TestWebKitAPI
530 https://bugs.webkit.org/show_bug.cgi?id=142565
532 Reviewed by Alexey Proskuryakov.
534 * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
535 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
536 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
537 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
538 * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
540 2015-03-10 Brent Fulgham <bfulgham@apple.com>
542 Regression(r181257): WTF_WorkQueue.Simple is flaky
543 https://bugs.webkit.org/show_bug.cgi?id=142560
545 Unreviewed attempt to improve test stability.
547 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
548 the WorkQueue a little later to redue flakiness.
550 2015-03-10 Myles C. Maxfield <mmaxfield@apple.com>
552 Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
553 https://bugs.webkit.org/show_bug.cgi?id=142555
555 Reviewed by Simon Fraser.
557 * DumpRenderTree/mac/DumpRenderTree.mm:
558 (setDefaultsToConsistentValuesForTesting):
559 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
560 (WTR::InjectedBundle::platformInitialize):
562 2015-03-10 Alex Christensen <achristensen@webkit.org>
564 Use unsigned for HashSet size.
565 https://bugs.webkit.org/show_bug.cgi?id=142518
567 Reviewed by Benjamin Poulain.
569 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
570 (TestWebKitAPI::TEST):
571 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
572 (TestWebKitAPI::testInitialCapacity):
573 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
574 (TestWebKitAPI::TEST):
576 2015-03-10 Daniel Bates <dabates@apple.com>
578 [iOS] Add WebKitSystemInterface for iOS 8.2
579 https://bugs.webkit.org/show_bug.cgi?id=142505
581 Rubber-stamped by Anders Carlsson.
583 Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
584 I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
585 copy-webkitlibraries-to-product-directory in r181286.
587 * Scripts/copy-webkitlibraries-to-product-directory:
589 2015-03-10 Benjamin Poulain <bpoulain@apple.com>
591 Extend URL filter's Term definition to support groups/subpatterns
592 https://bugs.webkit.org/show_bug.cgi?id=142519
594 Reviewed by Alex Christensen.
596 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
597 (TestWebKitAPI::testURL):
599 2015-03-06 Jer Noble <jer.noble@apple.com>
601 Add an option to run-webkit-tests to override the LayoutTests/ directory
602 https://bugs.webkit.org/show_bug.cgi?id=142418
604 Reviewed by David Kilzer.
606 Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
607 directory. The base port will parse the options during initialization and store the override
608 location if present. layout_tests_dir() will return this overridden location if set.
610 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
612 * Scripts/webkitpy/port/base.py:
614 (Port.layout_tests_dir):
616 2015-03-09 Martin Robinson <mrobinson@igalia.com>
618 [CMake] Enable WorkQueue tests for CMake ports
619 https://bugs.webkit.org/show_bug.cgi?id=142473
621 Reviewed by Darin Adler.
623 * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
624 the list of source files.
625 * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
626 to the list of include directories for EFL.
628 2015-03-09 David Kilzer <ddkilzer@apple.com>
630 Attempt to fix timeouts on iOS Simulator layout tests
632 * Scripts/webkitpy/port/ios.py:
633 (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
634 Simulator end after the first 50 tests time out. Some analysis
635 this past weekend shows that the 'Booted' status in the output
636 of `xcrun simctl list` is not sufficient (and watching the test
637 run shows that SpringBoard hasn't fully started to the point
638 where it's displaying icons on the home screen). The workaround
639 until we have a better fix is to add an arbitrary timeout to let
640 SpringBoard finish launching. In practice, 15 seconds is
641 probably enough, but 30 seconds should nearly always work.
643 2015-03-09 Per Arne Vollan <peavo@outlook.com>
645 Unreviewed. Add myself as a committer.
647 * Scripts/webkitpy/common/config/contributors.json:
649 2015-03-09 David Kilzer <ddkilzer@apple.com>
651 Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
653 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
654 (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
655 an expectation that will fail if we hit the race condition.
656 This test is inherently racy and will deadlock if the first job
657 for queue2 takes the mutex lock before the second job for
660 2015-03-08 Brent Fulgham <bfulgham@apple.com>
662 [Win] WTF::WorkQueue does not balance ref/deref properly
663 https://bugs.webkit.org/show_bug.cgi?id=142471
665 Reviewed by Antti Koivisto.
667 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
668 (TestWebKitAPI::TEST): Check that the refcount is correct.
670 2015-03-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
672 Do not show passing test result on output of EFL layout test
673 https://bugs.webkit.org/show_bug.cgi?id=142380
675 Reviewed by Darin Adler.
677 To show passing tests has caused inconvenience when we detect problem tests
678 in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
679 in order not to show passing tests in the output of EFL layout test.
681 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
682 (RunWebKitTests.start):
684 2015-03-08 Brent Fulgham <bfulgham@apple.com>
686 Unreviewed build fix.
688 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
689 (TestWebKitAPI::TEST): Remove two unused variables.
691 2015-03-08 Brent Fulgham <bfulgham@apple.com>
693 Add some WorkQueue tests to TestWebKitAPI
694 https://bugs.webkit.org/show_bug.cgi?id=142447
696 Reviewed by Sam Weinig.
698 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
699 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
700 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
701 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
702 (TestWebKitAPI::simpleTest):
703 (TestWebKitAPI::longTest):
704 (TestWebKitAPI::thirdTest):
705 (TestWebKitAPI::finishedTests):
706 (TestWebKitAPI::TEST):
707 (TestWebKitAPI::longTest2):
709 2015-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
711 Remove willDestroyFrame in WKBundlePageLoaderClient
712 https://bugs.webkit.org/show_bug.cgi?id=142389
714 Reviewed by Anders Carlsson.
716 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
717 (WTR::InjectedBundlePage::InjectedBundlePage):
719 2015-03-07 Brent Fulgham <bfulgham@apple.com>
721 [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
722 https://bugs.webkit.org/show_bug.cgi?id=142433
724 Reviewed by Darin Adler.
726 Include more TestWebKitAPI tests when building for Windows. Also
727 fix a build error in MetaAllocator.cpp caused by one of the
728 Microsoft headers #defining 'small'.
730 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
731 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
732 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
734 2015-03-06 Sam Weinig <sam@webkit.org>
736 [Content Extensions] Move compiling of content extensions to the UIProcess
737 https://bugs.webkit.org/show_bug.cgi?id=142402
739 Reviewed by Benjamin Poulain.
741 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
742 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
743 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
744 (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
745 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
746 (TestWebKitAPI::TEST_F):
747 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
748 Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
751 2015-03-06 Brent Fulgham <bfulgham@apple.com>
753 [Win] Correct Windows build.
755 Rubberstamped by Michael Saboff
757 * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
760 2015-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
762 [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
763 https://bugs.webkit.org/show_bug.cgi?id=142385
765 Reviewed by Sergio Villar Senin.
767 Use stack allocated GMainLoopSources to make sure they are
768 cancelled automatically if the test finishes before they have
771 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
772 (testWebViewSyncRequestOnMaxConns):
774 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
776 Remove Mountain Lion libraries since ML isn't supported
777 https://bugs.webkit.org/show_bug.cgi?id=142332
779 Reviewed by Darin Adler.
781 * Scripts/copy-webkitlibraries-to-product-directory:
783 2015-03-06 Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
785 Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
786 https://bugs.webkit.org/show_bug.cgi?id=142083
788 Reviewed by Simon Fraser.
790 Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
792 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
793 (WebPlatformTestServer._copy_webkit_test_files):
795 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
797 setup-git-clone fails due to the failure to download python-irclib-0.4.8
798 https://bugs.webkit.org/show_bug.cgi?id=141946
800 Reviewed by Ryosuke Niwa.
802 Check in ircbot.py and irclib.py to avoid network problems in the future.
804 * Scripts/webkitpy/common/net/irc/ircbot.py:
805 * Scripts/webkitpy/thirdparty/__init__.py:
806 (AutoinstallImportHook.find_module):
807 (AutoinstallImportHook._install_irc): Deleted.
808 * Scripts/webkitpy/thirdparty/__init___unittest.py:
809 (ThirdpartyTest.test_imports):
810 * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
811 * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
812 * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
814 2015-03-06 David Kilzer <ddkilzer@apple.com>
816 Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
818 See also fix to config.json in r181097.
820 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
821 (WebKitBuildbot): Add missing "WK2" to the names of the perf
824 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
826 run-jsc-stress-tests should determine the architecture from ELF binaries
827 https://bugs.webkit.org/show_bug.cgi?id=142335
829 Reviewed by Darin Adler.
831 * Scripts/run-jsc-stress-tests:
833 2015-03-05 David Kilzer <ddkilzer@apple.com>
835 [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
836 <http://webkit.org/b/142226>
838 Reviewed by Darin Adler.
840 * Scripts/webkitpy/port/ios.py:
841 (IOSSimulatorPort.default_baseline_search_path): Switch the
842 TestExpectations order of ios-simulator-wk2 from this:
843 ios-simulator-wk2, wk2, ios-simulator
845 ios-simulator-wk2, ios-simualtor, wk2
847 2015-03-05 Brent Fulgham <bfulgham@apple.com>
849 [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
850 https://bugs.webkit.org/show_bug.cgi?id=142370
852 Reviewed by Dean Jackson.
854 * Scripts/webkitdirs.pm:
855 (buildVisualStudioProject): Tell MSBuild to output log files to two separate
856 logs, one for warnings, the other for errors.
857 * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
858 into the standard BuildOutput.htm document.
860 2015-03-05 David Kilzer <ddkilzer@apple.com>
862 Dashboard has trouble parsing iOS test output
863 <http://webkit.org/b/142364>
865 Reviewed by Alex Christensen.
867 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
868 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
869 Add fallback path to build a regex using 'matchString' so that
870 it matches anywhere in the line. In practice, 'matchString' is
871 a prefix for the label following the number.
873 2015-03-05 Alex Christensen <achristensen@webkit.org>
875 Fix linker warnings in TestWebKitAPI.
876 https://bugs.webkit.org/show_bug.cgi?id=141912
878 Reviewed by David Kilzer.
880 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
881 Do not export TearDownTestCase or SetUpTestCase symbols.
883 2015-03-05 Brent Fulgham <bfulgham@apple.com>
885 [Win] Unreviewed EWS fix.
887 * Scripts/webkitdirs.pm:
888 (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
889 the EWS output more usable.
891 2015-03-05 Chris Dumez <cdumez@apple.com>
893 Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
894 https://bugs.webkit.org/show_bug.cgi?id=142350
896 Reviewed by Michael Saboff and Benjamin Poulain.
898 Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
899 crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
901 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
902 (TestWebKitAPI::TEST):
904 2015-03-05 Brent Fulgham <bfulgham@apple.com>
906 [Win] Ensure build target directory exists when launching MSBuild
907 https://bugs.webkit.org/show_bug.cgi?id=142360
909 Reviewed by Dean Jackson.
911 Create the build output directory (if it doesn't exist) before
912 launching MSBuild so that it can immediately begin writing logs.
914 * Scripts/webkitdirs.pm:
915 (buildVisualStudioProject):
917 2015-03-05 Chris Dumez <cdumez@apple.com>
919 run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
920 https://bugs.webkit.org/show_bug.cgi?id=142325
922 Reviewed by Csaba Osztrogonác.
924 run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
925 As a result, "--webkit-test-runner / -2" parameters are replaced by
926 "--dump-render-tree / -1" so developers can run DumpRenderTree rather
927 than WebKitTestRunner.
929 * BuildSlaveSupport/build.webkit.org-config/config.json:
930 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
932 (RunWebKit1Tests.start):
933 (RunWebKit1LeakTests):
934 (RunWebKit1LeakTests.start):
935 (RunAndUploadPerfTestsWebKit1):
936 (RunAndUploadPerfTestsWebKit1.start):
938 (TestWebKit1LeaksFactory):
939 (TestWebKit1LeaksFactory.__init__):
940 (TestWebKit1Factory):
941 (TestWebKit1AllButJSCFactory):
942 (TestAllButJSCFactory):
943 (BuildAndPerfTestWebKit1Factory):
944 (BuildAndPerfTestWebKit1Factory.__init__):
945 (BuildAndPerfTestFactory):
946 (BuildAndPerfTestFactory.__init__):
947 (DownloadAndPerfTestWebKit1Factory):
948 (DownloadAndPerfTestWebKit1Factory.__init__):
949 (DownloadAndPerfTestFactory):
950 (DownloadAndPerfTestFactory.__init__):
951 (RunWebKitLeakTests): Deleted.
952 (RunWebKitLeakTests.start): Deleted.
953 (RunWebKit2Tests): Deleted.
954 (RunWebKit2Tests.start): Deleted.
955 (RunAndUploadPerfTestsWebKit2): Deleted.
956 (RunAndUploadPerfTestsWebKit2.start): Deleted.
957 (TestLeaksFactory): Deleted.
958 (TestLeaksFactory.__init__): Deleted.
959 (TestWebKit2Factory): Deleted.
960 (TestWebKit2AndJSCFactory): Deleted.
961 (BuildAndPerfTestWebKit2Factory): Deleted.
962 (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
963 (DownloadAndPerfTestWebKit2Factory): Deleted.
964 (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
965 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
967 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
968 (PerfTestsRunner._parse_args):
969 * Scripts/webkitpy/port/port_testcase.py:
970 (PortTestCase.test_build_driver):
972 2015-03-05 Brent Fulgham <bfulgham@apple.com>
974 [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
975 https://bugs.webkit.org/show_bug.cgi?id=140845
977 Reviewed by David Kilzer.
979 Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
980 and generate suitable build commands to drive a full build from our
981 existing solution files.
983 * Scripts/webkitdirs.pm:
984 (msBuildInstallDir): Added.
985 (determineConfigurationForVisualStudio): Revise to use MSBuild command
986 line arguments to drive the build.
987 (setupCygwinEnv): Warn user if MSBuild cannot be located.
988 (buildVisualStudioProject): Revise to use MSBuild command line arguments
989 to specify build architecture.
990 * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
991 output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
992 bother looking for CoreUI or SafariTheme build logs.
994 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
996 [buildbot] mastercfg_unittest.py should be runnable easily
997 https://bugs.webkit.org/show_bug.cgi?id=142219
999 Reviewed by Chris Dumez.
1001 Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
1002 the last Twisted version works together with this buildbot version.
1004 * Scripts/webkitpy/common/system/autoinstall.py:
1005 (AutoInstaller): Added prepend_to_search_path argument to be able
1006 to prefer autoinstalled package to system package.
1007 (AutoInstaller.__init__):
1008 (AutoInstaller._set_up_target_dir):
1009 (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
1010 (AutoInstaller._prepare_package):
1011 (AutoInstaller._extract_targz): Renamed to _extract_tar.
1012 * Scripts/webkitpy/thirdparty/__init__.py:
1013 (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
1015 2015-03-05 Lukasz Bialek <l.bialek@samsung.com>
1017 [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
1018 https://bugs.webkit.org/show_bug.cgi?id=131162
1020 Reviewed by Gyuyoung Kim.
1022 * MiniBrowser/efl/main.c:
1023 (on_download_request):
1024 (on_download_finished):
1025 (on_download_failed):
1027 Adapt download callbacks to new callback mechanism
1029 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
1031 Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
1033 In r180927 we updated the libsoup version used by the jhbuild. In
1034 this new version the sniffer uses image/x-icon instead of
1035 image/vnd.microsoft.icon for blank.ico resource.
1037 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1038 (testWebResourceMimeType):
1040 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
1042 [SOUP] Check TLS errors as soon as they are set in the SoupMessage
1043 https://bugs.webkit.org/show_bug.cgi?id=142244
1045 Reviewed by Sergio Villar Senin.
1047 Check that the SSL server doesn't process any request in case of
1048 TLS errors when the policy is set to FAIL.
1050 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1051 (testTLSErrorsPolicy):
1052 (testTLSErrorsRedirect):
1053 (testTLSErrorsHTTPAuth):
1054 (testLoadFailedWithTLSErrors):
1055 (testSubresourceLoadFailedWithTLSErrors):
1056 (httpsServerCallback):
1058 2015-03-05 Pawel Forysiuk <p.forysiuk@samsung.com>
1060 [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
1061 https://bugs.webkit.org/show_bug.cgi?id=141154
1063 Reviewed by Jer Noble.
1065 Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
1067 For the sake of completeness WebKitTestRunner should specify temporary
1068 folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
1070 Default non legacy paths are set up in ProcessPoolConfiguration constructor.
1071 They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1072 to get data storage paths. Only Mac port has an actual implementation of it.
1073 However, WebKitTestRunner overrides them in favour of unique temporary dir
1074 which is taken from libraryPathForTesting().
1076 Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1077 is not implemented for EFL and GTK ports it returns an empty string.
1078 All default data folders besides MediaKeys are overridden in TestRunner
1079 code with unique temporary folders derived from DUMPRENDERTREE_TEMP
1082 GTK port does not enable encrypted keys by default so
1083 WebMediaKeyStorageManager::initialize() code path is never triggered.
1085 * WebKitTestRunner/TestController.cpp:
1086 (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
1089 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
1091 [buildbot] Add regression test to check which builder runs which tests
1092 https://bugs.webkit.org/show_bug.cgi?id=142166
1094 Reviewed by Alexey Proskuryakov.
1096 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1097 (BuildStepsConstructorTest.createTest):
1099 (BuildStepsTest.generateTests):
1100 (BuildStepsTest.createTest):
1101 (BuildStepsTest.createTest.doTest):
1102 (BuildStepsTest.test_unnecessary_expected_results):
1104 2015-03-04 Commit Queue <commit-queue@webkit.org>
1106 Unreviewed, rolling out r181054.
1107 https://bugs.webkit.org/show_bug.cgi?id=142320
1109 Broke the api tests (Requested by sundiamonde on #webkit).
1113 "Fix linker warnings in TestWebKitAPI."
1114 https://bugs.webkit.org/show_bug.cgi?id=141912
1115 http://trac.webkit.org/changeset/181054
1117 2015-03-04 Alex Christensen <achristensen@webkit.org>
1119 Fix linker warnings in TestWebKitAPI.
1120 https://bugs.webkit.org/show_bug.cgi?id=141912
1122 Reviewed by David Kilzer.
1124 * TestWebKitAPI/Configurations/Base.xcconfig:
1125 Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
1127 2015-03-04 Alexey Proskuryakov <ap@apple.com>
1129 [Mac] Set SystemUIFontSelect in DRT and WKTR
1130 https://bugs.webkit.org/show_bug.cgi?id=142303
1132 Reviewed by Myles C. Maxfield.
1134 * DumpRenderTree/mac/DumpRenderTree.mm:
1135 (setDefaultsToConsistentValuesForTesting):
1136 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1137 (WTR::InjectedBundle::platformInitialize):
1139 2015-03-04 Chris Dumez <cdumez@apple.com>
1141 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1142 https://bugs.webkit.org/show_bug.cgi?id=142314
1143 <rdar://problem/20046835>
1145 Reviewed by Ryosuke Niwa.
1147 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1148 to get WK2 code coverage.
1150 * BuildSlaveSupport/build.webkit.org-config/config.json:
1152 2015-03-04 Alex Christensen <achristensen@webkit.org>
1154 Move content extensions test to properly named directory.
1155 https://bugs.webkit.org/show_bug.cgi?id=142299
1157 Reviewed by Tim Horton.
1159 * WebKitTestRunner/mac/TestControllerMac.mm:
1160 (WTR::TestController::platformConfigureViewForTest):
1162 2015-03-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
1164 W3C test importer should use filesystem instead of os.walk
1165 https://bugs.webkit.org/show_bug.cgi?id=142085
1167 Reviewed by Bem Jones-Bey.
1169 Added FileSystem.dirs_under to remove the use of os.walk in test importer.
1170 Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
1171 Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
1173 Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
1174 Added a unit test to check that test importer is now black-box testable using a Mock system.
1176 * Scripts/webkitpy/common/system/filesystem.py:
1177 (FileSystem.dirs_under): Returns a list of filtered sub-directories.
1178 (FileSystem.dirs_under.filter_all):
1179 * Scripts/webkitpy/common/system/filesystem_mock.py:
1180 (MockFileSystem.dirs_under):
1181 (MockFileSystem.dirs_under.filter_all):
1182 (MockFileSystem.getsize):
1183 * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1184 (MockFileSystemTest.test_dirs_under):
1185 (MockFileSystemTest.test_dirs_under.filter_dir):
1186 * Scripts/webkitpy/common/system/filesystem_unittest.py:
1187 (RealFileSystemTest.test_sep):
1188 (RealFileSystemTest):
1189 (RealFileSystemTest.test_dirs_under):
1190 (RealFileSystemTest.test_dirs_under.filter_this_dir):
1191 * Scripts/webkitpy/w3c/test_importer.py:
1192 (TestImporter.do_import):
1193 (TestImporter.find_importable_tests.should_keep_subdir):
1194 (TestImporter.find_importable_tests):
1195 (TestImporter.should_keep_subdir): Deleted.
1196 (TestImporter.should_skip_file): Deleted.
1197 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1198 (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
1200 2015-03-04 Timothy Horton <timothy_horton@apple.com>
1202 [WebEditingTester] Add support for the find and replace bar
1203 https://bugs.webkit.org/show_bug.cgi?id=142247
1205 Reviewed by Enrica Casucci.
1207 While it's not hooked up yet in WKWebView, adding support for the
1208 find bar to WebEditingTester will help us implement that functionality.
1210 * WebEditingTester/AppDelegate.h:
1211 * WebEditingTester/AppDelegate.m:
1212 (-[WebEditingAppDelegate performTextFinderAction:]):
1213 * WebEditingTester/MainMenu.xib:
1214 Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
1216 * WebEditingTester/WK2WebDocumentController.m:
1217 (-[WK2WebDocumentController awakeFromNib]):
1218 (-[WK2WebDocumentController performTextFinderAction:]):
1219 (-[WK2WebDocumentController findBarView]):
1220 (-[WK2WebDocumentController setFindBarView:]):
1221 (-[WK2WebDocumentController isFindBarVisible]):
1222 (-[WK2WebDocumentController setFindBarVisible:]):
1223 (-[WK2WebDocumentController findBarViewDidChangeHeight]):
1224 (-[WK2WebDocumentController layout]):
1225 Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
1226 pointing at the WKWebView (currently nothing will work, but the bar will
1227 show up). Install and uninstall the bar as needed.
1229 * WebEditingTester/WebDocument.xib:
1230 Don't use a full-size content view. There's no need, and it makes find
1233 * WebEditingTester/WebDocumentController.h:
1234 * WebEditingTester/WebDocumentController.m:
1235 (-[WebDocumentController performTextFinderAction:]):
1237 2015-03-03 Sam Weinig <sam@webkit.org>
1239 [Content Extensions] Split parsing and compiling of content extensions into their own files
1240 https://bugs.webkit.org/show_bug.cgi?id=142259
1242 Reviewed by Anders Carlsson.
1244 Add basic unit test for the content filter compiler.
1246 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1247 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
1248 (WebCore::ContentExtensions::operator<<):
1249 (TestWebKitAPI::ContentFilterTest::SetUp):
1250 (TestWebKitAPI::TEST_F):
1252 2015-03-04 Matthew Mirman <mmirman@apple.com>
1254 Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
1255 https://bugs.webkit.org/show_bug.cgi?id=142230
1257 Reviewed by Csaba Osztrogonác.
1259 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1261 (TestFactory.getProduct): Added
1262 (TestFactory.__init__): moved downloader to getProduct
1263 (BuildAndTestFactory):
1264 (BuildAndTestFactory.getProduct): Added
1265 (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
1266 (BuildAndTestWebKit2Factory): Deleted. Wasn't used anywhere.
1268 2015-03-04 Debarshi Ray <debarshir@gnome.org>
1270 [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
1271 https://bugs.webkit.org/show_bug.cgi?id=142225
1273 Reviewed by Carlos Garcia Campos.
1275 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1276 (testWebViewWebContextLifetime):
1279 2015-03-03 David Kilzer <ddkilzer@apple.com>
1281 [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
1282 <http://webkit.org/b/142243>
1284 Reviewed by Alexey Proskuryakov.
1286 * WebKitTestRunner/TestController.cpp:
1287 (WTR::TestController::webProcessName):
1288 (WTR::TestController::networkProcessName):
1289 - Return the same process name on iOS and Mac because they both
1290 use the same process name for local engineering builds.
1292 2015-03-03 David Kilzer <ddkilzer@apple.com>
1294 check-webkit-style: Add exception for FrameworkSoftLink.h header order
1295 <http://webkit.org/b/141872>
1297 Reviewed by Alex Christensen.
1299 * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
1300 semi-colons in various places and fix whitespace.
1301 (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
1303 (_IncludeState.__init__): Add self._visited_soft_link_section
1304 boolean state variable.
1305 (_IncludeState.visited_soft_link_section): Getter for
1306 self._visited_soft_link_section.
1307 (_IncludeState.check_next_include_order): Update state machine
1308 for soft-link headers. Add check that soft-link headers always
1310 (_classify_include): Add check for soft-link header type.
1311 (check_include_line): Return early if there is a soft-link
1314 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1315 (OrderOfIncludesTest.test_public_primary_header): Add tests for
1316 including soft-link headers.
1317 (OrderOfIncludesTest.test_classify_include): Add test for
1318 _SOFT_LINK_HEADER type.
1320 2015-03-03 Alexey Proskuryakov <ap@apple.com>
1322 build.webkit.org/dashboard: Don't repeatedly handle each test type
1323 https://bugs.webkit.org/show_bug.cgi?id=142211
1325 Reviewed by Tim Horton and Matt Hanson.
1327 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1328 (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
1329 (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
1330 (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
1331 (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
1332 (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
1333 (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
1334 Removed functions that build a link to test step results. The buildbot provides
1335 these links in JSON.
1337 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1338 (BuildbotIteration): Put failing tests into an array, instead of named variables.
1339 (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
1340 We can easily add them to the map as needed.
1341 (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
1342 (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
1343 to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
1344 and then build a BuildbotTestResults object, which was strange.
1345 (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
1347 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1348 Corrected an unrelated assertion that was buggy, and kept firing.
1350 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1351 (BuildbotTestResults):
1352 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1353 (BuildbotTestResults.prototype._parseResults):
1354 (BuildbotTestResults.prototype.addFullLayoutTestResults):
1355 Moved the code for parsing JSON results for a single step here.
1357 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1358 (BuildbotTesterQueueView.prototype._testStepFailureDescription):
1359 (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
1360 (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1361 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
1362 (BuildbotTesterQueueView.prototype.update): Deleted.
1363 (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
1364 Updated for the new data structures. One behavior change is that we now display individual
1365 counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
1366 test failures, 3 platform api test failures".
1368 2015-03-03 Matthew Mirman <mmirman@apple.com>
1370 JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
1371 https://bugs.webkit.org/show_bug.cgi?id=142094
1373 Reviewed by Csaba Osztrogonác.
1375 * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
1376 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1378 (TestFactory.__init__): Made running of JSC tests conditional.
1379 (TestAllButJSCFactory):
1380 (TestJSCFactory): Added.
1381 (TestJSCFactory.__init__):
1382 (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
1384 2015-03-03 David Kilzer <ddkilzer@apple.com>
1386 `build-webkit --help` is wrong about how to build for the iOS simulator
1387 <http://webkit.org/b/142223>
1389 Reviewed by Csaba Osztrogonác.
1391 * Scripts/build-webkit: Fix help.
1393 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
1395 Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
1397 * gtk/jhbuild.modules:
1399 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
1401 [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
1402 https://bugs.webkit.org/show_bug.cgi?id=141508
1404 Reviewed by Sergio Villar Senin.
1406 Add a unit test to check that synchronous XHRs load even if the
1407 maximum connection limits are reached.
1409 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1410 (testWebViewSyncRequestOnMaxConns):
1413 * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
1415 2015-03-02 Alexey Proskuryakov <ap@apple.com>
1417 Update the name of ASan build step.
1419 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1421 2015-03-02 Jer Noble <jer.noble@apple.com>
1423 [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1424 https://bugs.webkit.org/show_bug.cgi?id=142121
1426 Reviewed by Simon Fraser.
1428 Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
1429 that the initial and final screen rects for the web content are as expected.
1431 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1432 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
1433 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
1434 (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1435 (runJavaScriptAlert):
1436 (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1437 (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
1438 (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
1439 (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
1440 (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
1441 (TestWebKitAPI::TEST_F):
1443 2015-03-01 David Kilzer <ddkilzer@apple.com>
1445 LayoutTestRealy: Prepend __XPC_ to the key, not the value!
1449 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1450 <http://webkit.org/b/142145>
1452 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1453 (-[LTRelayController _environmentVariables]): Fix think-o.
1455 2015-03-01 David Kilzer <ddkilzer@apple.com>
1457 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1458 <http://webkit.org/b/142145>
1460 Reviewed by Simon Fraser.
1462 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1463 (-[LTRelayController _environmentVariables]): Add.
1464 (-[LTRelayController launchApp]): Use -_environmentVariables.
1466 2015-02-28 David Kilzer <ddkilzer@apple.com>
1468 [iOS] Stop running webkit-build-directory on every layout test
1470 This was originally fixed by David Farler for Bug 135409 in
1473 * Scripts/webkitpy/port/ios.py:
1474 (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
1475 run webkit-build-directory every time it's called.
1477 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
1479 W3C importer should use filesystem instead of shutil/host
1480 https://bugs.webkit.org/show_bug.cgi?id=142012
1482 Reviewed by Bem Jones-Bey.
1484 Removed direct use of python shutil and os, except for os.walk which will require its own fix.
1486 * Scripts/webkitpy/w3c/test_importer.py:
1488 (TestImporter.do_import):
1489 (TestImporter.find_importable_tests):
1490 (TestImporter.import_tests):
1491 (TestImporter.remove_deleted_files):
1492 (TestImporter.write_import_log):
1494 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
1496 W3C test importer should use filesystem to read and write files
1497 https://bugs.webkit.org/show_bug.cgi?id=142084
1499 Reviewed by Bem Jones-Bey.
1501 Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
1503 * Scripts/webkitpy/w3c/test_importer.py:
1504 (TestImporter.import_tests):
1505 (TestImporter.remove_deleted_files):
1506 (TestImporter.write_import_log):
1508 2015-02-27 Sam Weinig <sam@webkit.org>
1510 Add WebKit2 SPI to create a DOM File object
1511 https://bugs.webkit.org/show_bug.cgi?id=142109
1513 Reviewed by Tim Horton.
1515 Add a test for WKBundleFileHandleRef.
1517 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1518 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
1519 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1520 (TestWebKitAPI::didFinishLoadForFrame):
1521 (TestWebKitAPI::TEST):
1522 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
1523 (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
1524 * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
1526 2015-02-27 Michael Saboff <msaboff@apple.com>
1528 Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
1529 https://bugs.webkit.org/show_bug.cgi?id=142112
1531 Reviewed by Filip Pizlo.
1533 Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
1534 <someDir> as the library path.
1536 * Scripts/run-jsc-benchmarks:
1538 2015-02-27 Alex Christensen <achristensen@webkit.org>
1540 [WinCairo] Unreviewed build fix.
1542 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1543 Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
1545 2015-02-27 Anders Carlsson <andersca@apple.com>
1547 Add infrastructure for handling website data in the network process
1548 https://bugs.webkit.org/show_bug.cgi?id=142092
1550 Reviewed by Andreas Kling.
1552 Add a menu item that will fetch all website data, delete the returned data records, and
1553 fetch all website data again so we can confirm that it's all empty.
1555 * MiniBrowser/mac/WK2BrowserWindowController.m:
1556 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1558 2015-02-26 Brent Fulgham <bfulgham@apple.com>
1560 [Win] Remove remaining SafariTheme cruft
1561 https://bugs.webkit.org/show_bug.cgi?id=142075
1563 Reviewed by Anders Carlsson.
1565 Remove reference to SafariTheme-switching preference.
1567 * DumpRenderTree/win/DumpRenderTree.cpp:
1568 (resetWebPreferencesToConsistentValues):
1569 (prepareConsistentTestingEnvironment):
1571 2015-02-26 Doug Russell <d_russell@apple.com>
1573 AX: Expose caret browsing preference to accessibility API
1574 https://bugs.webkit.org/show_bug.cgi?id=141862
1576 Reviewed by Chris Fleizach.
1578 Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
1579 Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
1581 * DumpRenderTree/AccessibilityUIElement.cpp:
1582 (setBoolAttributeValueCallback):
1583 (selectedTextMarkerRangeCallback):
1584 (resetSelectedTextMarkerRangeCallback):
1585 (AccessibilityUIElement::setBoolAttributeValue):
1586 (AccessibilityUIElement::selectedTextMarkerRange):
1587 (AccessibilityUIElement::resetSelectedTextMarkerRange):
1588 (AccessibilityUIElement::getJSClass):
1589 * DumpRenderTree/AccessibilityUIElement.h:
1590 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1591 (AccessibilityUIElement::setBoolAttributeValue):
1592 (AccessibilityUIElement::selectedTextMarkerRange):
1593 (AccessibilityUIElement::resetSelectedTextMarkerRange):
1594 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1595 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1596 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1597 (WTR::AccessibilityUIElement::setBoolAttributeValue):
1598 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1599 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1600 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1601 (WTR::AccessibilityUIElement::setBoolAttributeValue):
1602 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1603 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1605 2015-02-26 Brent Fulgham <bfulgham@apple.com>
1607 [Win] Remove WebKitExportGenerator project (and related)
1608 https://bugs.webkit.org/show_bug.cgi?id=142035
1610 Reviewed by Dean Jackson.
1612 * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
1613 build log from WebKitExportGenerator.
1615 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
1617 [EFL] Bump EFL version to 1.13.0
1618 https://bugs.webkit.org/show_bug.cgi?id=141708
1620 Reviewed by Gyuyoung Kim.
1622 * efl/jhbuild.modules:
1624 2015-02-26 Sam Weinig <sam@webkit.org>
1626 Check in missing WebEditingTester.xcconfig file.
1628 * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
1630 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
1632 [webkitpy] Remove skipped file related crufts
1633 https://bugs.webkit.org/show_bug.cgi?id=142046
1635 Reviewed by Ryosuke Niwa.
1637 * Scripts/webkitpy/port/base.py:
1638 (Port.skipped_layout_tests):
1639 (Port._tests_from_skipped_file_contents): Deleted.
1641 (Port._expectations_from_skipped_files): Deleted.
1642 * Scripts/webkitpy/port/mac_unittest.py:
1643 (MacTest.test_default_timeout_ms):
1645 (test_tests_from_skipped_file_contents): Deleted.
1647 2015-02-26 Brent Fulgham <bfulgham@apple.com>
1649 [Win] Unreviewed WinCairo build fix after r180653.
1651 TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
1653 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1654 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1655 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1656 * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
1657 * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
1659 2015-02-25 Brent Fulgham <bfulgham@apple.com>
1661 [Win] Use WEBCORE_EXPORT instead of Definition file
1662 https://bugs.webkit.org/show_bug.cgi?id=141734
1664 Reviewed by Alex Christensen.
1666 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1667 Use a precompiled header so we can define our export macros properly.
1668 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1669 Visual studio automatic update stuff.
1670 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1671 Set up Precompiled Header use for project..
1672 * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
1673 * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
1674 declarations for building DumpRenderTree as a client of
1677 2015-02-25 Mark Lam <mark.lam@apple.com>
1679 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
1680 <https://webkit.org/b/141672>
1682 Reviewed by Alexey Proskuryakov.
1684 ASan does not like the fact that we memcpy the stack for GC scans. So,
1685 we're working around this by using our own memcpy (asanUnsafeMemcpy)
1686 implementation that we can tell ASan to ignore.
1688 Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
1689 which isn't effective for working around this issue.
1691 * asan/webkit-asan-ignore.txt:
1693 2015-02-25 Benjamin Poulain <bpoulain@apple.com>
1695 CodeBlock crashes when dumping op_push_name_scope
1696 https://bugs.webkit.org/show_bug.cgi?id=141953
1698 Reviewed by Filip Pizlo.
1700 * Scripts/run-jsc-stress-tests:
1702 2015-02-25 Youenn Fablet <youenn.fablet@crf.canon.fr>
1704 W3C test importer should use argparse instead of optparse
1705 https://bugs.webkit.org/show_bug.cgi?id=142013
1707 Reviewed by Bem Jones-Bey.
1709 * Scripts/webkitpy/w3c/test_importer.py:
1710 (main): Updating according argparse.
1711 (parse_args): Moving from optparse to argparse.
1713 2015-02-25 Brady Eidson <beidson@apple.com>
1715 Get rid of TestInvocation::pathOrURL
1716 https://bugs.webkit.org/show_bug.cgi?id=142021
1718 Reviewed by Tim Horton.
1720 The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
1721 but most code that uses it expected an absolute path.
1723 This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
1725 * WebKitTestRunner/TestController.cpp:
1726 (WTR::TestController::updateWebViewSizeForTest):
1727 (WTR::TestController::updateWindowScaleForTest):
1728 (WTR::shouldUseFixedLayout):
1729 (WTR::TestController::updateLayoutTypeForTest):
1731 * WebKitTestRunner/TestInvocation.cpp:
1732 (WTR::TestInvocation::TestInvocation):
1733 (WTR::TestInvocation::urlContains):
1734 (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1735 (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1736 (WTR::TestInvocation::invoke):
1737 (WTR::shouldLogFrameLoadDelegates): Deleted.
1738 (WTR::shouldLogHistoryClientCallbacks): Deleted.
1739 * WebKitTestRunner/TestInvocation.h:
1740 (WTR::TestInvocation::pathOrURL): Deleted.
1742 * WebKitTestRunner/ios/TestControllerIOS.mm:
1743 (WTR::shouldMakeViewportFlexible):
1744 (WTR::TestController::platformConfigureViewForTest):
1746 * WebKitTestRunner/mac/TestControllerMac.mm:
1747 (WTR::shouldUseThreadedScrolling):
1748 (WTR::TestController::platformConfigureViewForTest):
1750 2015-02-25 Brady Eidson <beidson@apple.com>
1752 Layout test support for user content filters
1753 https://bugs.webkit.org/show_bug.cgi?id=142018
1755 Reviewed by Tim Horton.
1757 * WebKitTestRunner/TestController.cpp:
1758 (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
1760 * WebKitTestRunner/mac/TestControllerMac.mm:
1761 (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
1762 file before loading the test itself.
1764 2015-02-24 Sam Weinig <sam@webkit.org>
1766 Convert WebEditingTester to use xcconfig files
1767 https://bugs.webkit.org/show_bug.cgi?id=141879
1769 Reviewed by Darin Adler.
1771 Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
1773 * WebEditingTester/Configurations: Added.
1774 * WebEditingTester/Configurations/Base.xcconfig: Added.
1775 * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
1776 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1778 2015-02-24 Andy Estes <aestes@apple.com>
1780 Teach MiniBrowser how to disable per-window web processes
1781 https://bugs.webkit.org/show_bug.cgi?id=141988
1783 Reviewed by Darin Adler.
1785 * MiniBrowser/mac/AppDelegate.m:
1786 (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
1787 * MiniBrowser/mac/SettingsController.h:
1788 * MiniBrowser/mac/SettingsController.m:
1789 (-[SettingsController _populateMenu]): Added a new Settings menu item.
1790 (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
1791 (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
1792 (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
1794 2015-02-24 Alexey Proskuryakov <ap@apple.com>
1796 Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
1797 https://bugs.webkit.org/show_bug.cgi?id=141889
1799 Reviewed by Darin Adler.
1801 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1803 2015-02-24 Yusuke Suzuki <utatane.tea@gmail.com>
1805 REGRESSION(r179429): Can't type comments in Facebook
1806 https://bugs.webkit.org/show_bug.cgi?id=141859
1808 Reviewed by Brent Fulgham.
1810 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1812 * DumpRenderTree/mac/DumpRenderTree.mm:
1813 (resetWebPreferencesToConsistentValues):
1814 * DumpRenderTree/win/DumpRenderTree.cpp:
1815 (resetWebPreferencesToConsistentValues):
1816 * WebKitTestRunner/TestController.cpp:
1817 (WTR::TestController::resetPreferencesToConsistentValues):
1819 2015-02-24 Michael Catanzaro <mcatanzaro@igalia.com>
1821 Crash loading local file with WebPageProxy::loadAlternateHTMLString
1822 https://bugs.webkit.org/show_bug.cgi?id=141867
1824 Reviewed by Anders Carlsson.
1826 * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1827 (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
1828 be shared with the new test.
1829 (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
1830 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
1831 (testLoadAlternateHTMLForLocalPage):
1834 2015-02-24 David Kilzer <ddkilzer@apple.com>
1836 [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
1837 <http://webkit.org/b/141900>
1839 Reviewed by Myles C. Maxfield.
1841 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1842 (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
1843 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
1844 - Rename to share code with iOS.
1845 - Add USE(APPKIT) around AppKit-specific headers and code.
1846 - Fix a check-webkit-style warning.
1847 * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
1848 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1849 - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
1850 - Remove ios/ActivateFontsIOS.mm.
1851 - Fix InjectedBundle/cocoa group to represent the directory on
1852 disk. Includes a change to InjectedBundlePageCocoa.mm.
1854 2015-02-23 Commit Queue <commit-queue@webkit.org>
1856 Unreviewed, rolling out r180547 and r180550.
1857 https://bugs.webkit.org/show_bug.cgi?id=141957
1859 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1861 Reverted changesets:
1863 "REGRESSION(r179429): Can't type comments in Facebook"
1864 https://bugs.webkit.org/show_bug.cgi?id=141859
1865 http://trac.webkit.org/changeset/180547
1867 "Constructor returning null should construct an object instead
1869 https://bugs.webkit.org/show_bug.cgi?id=141640
1870 http://trac.webkit.org/changeset/180550
1872 2015-02-23 Yusuke Suzuki <utatane.tea@gmail.com>
1874 REGRESSION(r179429): Can't type comments in Facebook
1875 https://bugs.webkit.org/show_bug.cgi?id=141859
1877 Reviewed by Geoffrey Garen.
1879 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1881 * DumpRenderTree/mac/DumpRenderTree.mm:
1882 (resetWebPreferencesToConsistentValues):
1883 * WebKitTestRunner/TestController.cpp:
1884 (WTR::TestController::resetPreferencesToConsistentValues):
1886 2015-02-23 KwangHyuk Kim <hyuki.kim@samsung.com>
1889 https://bugs.webkit.org/show_bug.cgi?id=141909
1891 Reviewed by Gyuyoung Kim.
1893 Fix eo errors that occur whenever minibrowser is launched.
1894 - elm_obj_entry_text_style_user_push can only be applied for elm_entry
1895 - elm_obj_win_resize_object_add's first parameter should be elm_win
1897 * MiniBrowser/efl/main.c:
1900 2015-02-23 Ryosuke Niwa <rniwa@webkit.org>
1902 Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
1904 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1905 (TestWebKitAPI::TEST):
1907 2015-02-23 Brent Fulgham <bfulgham@apple.com>
1909 WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
1910 https://bugs.webkit.org/show_bug.cgi?id=141935
1912 Reviewed by Myles C. Maxfield.
1914 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1915 (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
1916 tests for assigning from nullptr.
1918 2015-02-23 Brent Fulgham <bfulgham@apple.com>
1920 WTF::WeakPtr should have a 'forget' method.
1921 https://bugs.webkit.org/show_bug.cgi?id=141923
1923 Reviewed by Myles C. Maxfield.
1925 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1926 (TestWebKitAPI::TEST): Added 'Forget' tests case.
1928 2015-02-23 Alexey Proskuryakov <ap@apple.com>
1930 build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
1931 https://bugs.webkit.org/show_bug.cgi?id=141920
1933 Reviewed by Tim Horton.
1935 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1936 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1937 Do the same thing as we do for regular green bubbles.
1939 2015-02-23 Alexey Proskuryakov <ap@apple.com>
1941 Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
1942 https://bugs.webkit.org/show_bug.cgi?id=141925
1944 Reviewed by Tim Horton.
1946 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1947 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1949 2015-02-23 Anders Carlsson <andersca@apple.com>
1951 Add API for fetching website data records to _WKWebsiteDataStore
1952 https://bugs.webkit.org/show_bug.cgi?id=141926
1954 Reviewed by Beth Dakin.
1956 * MiniBrowser/mac/MainMenu.xib:
1957 * MiniBrowser/mac/WK2BrowserWindowController.m:
1958 (-[WK2BrowserWindowController fetchWebsiteData:]):
1959 Add menu item to fetch and dump website data.
1961 2015-02-23 David Kilzer <ddkilzer@apple.com>
1963 [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
1964 <http://webkit.org/b/141884>
1966 Reviewed by Alexey Proskuryakov.
1968 * Scripts/webkitpy/port/leakdetector.py:
1969 (LeakDetector._callstacks_to_exclude_from_leaks): Remove
1970 snowleopard, lion and older leaks. Add known leak for
1971 mavericks, but check Port.operating_system before calling
1973 * Scripts/webkitpy/port/mac.py:
1974 (MacPort.is_snowleopard): Delete.
1975 (MacPort.is_lion): Delete.
1976 (MacPort.is_mavericks): Add.
1978 2015-02-23 Alexey Proskuryakov <ap@apple.com>
1980 build.webkit.org/dashboard should filter out commits to other branches
1981 https://bugs.webkit.org/show_bug.cgi?id=140362
1983 Reviewed by Tim Horton.
1985 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1987 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1988 (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
1989 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1990 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
1991 (BuildbotQueueView.prototype.revisionContentForIteration):
1992 (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
1993 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
1994 (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
1995 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1996 (Trac.prototype.get oldestRecordedRevisionNumber):
1997 (Trac.prototype.commitsOnBranch):
1998 (Trac.prototype._xmlTimelineURL):
1999 (Trac.prototype._convertCommitInfoElementToObject):
2000 (Trac.prototype._update):
2001 (Trac.prototype.startPeriodicUpdates):
2002 (Trac.prototype.loadMoreHistoricalData):
2003 (Trac.prototype.update): Deleted.
2005 2015-02-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
2007 Tests don't work on some bots: Failed to stop wptwk
2008 https://bugs.webkit.org/show_bug.cgi?id=141235
2010 Reviewed by Ryosuke Niwa.
2012 Logging of server subprocesses in launcher script.
2013 Killing of server subprocesses when stopping/before starting.
2014 Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
2016 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2017 (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
2018 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2019 (WebPlatformTestServer.__init__):
2020 (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
2021 (WebPlatformTestServer):
2022 (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
2023 (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
2024 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2025 (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
2026 (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
2027 (TestWebPlatformTestServer):
2028 (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
2030 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2032 [WebEditingTester] Allow dropping HTML files on the app
2033 https://bugs.webkit.org/show_bug.cgi?id=141834
2035 Reviewed by Simon Fraser.
2037 * WebEditingTester/AppDelegate.m:
2038 (-[WebEditingAppDelegate openDocument:]):
2039 (-[WebEditingAppDelegate application:openFile:]):
2040 Implement application:openFile:, factoring file loading code out of openDocument.
2042 * WebEditingTester/Info.plist:
2043 Register as an editor for HTML files.
2045 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2046 Enrica is not an organization.
2048 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2050 [WebEditingTester] Expand "WK" to "WebKit" in a few places
2051 https://bugs.webkit.org/show_bug.cgi?id=141833
2053 Reviewed by Anders Carlsson.
2055 * WebEditingTester/AppDelegate.h:
2056 * WebEditingTester/AppDelegate.m:
2057 (-[WebEditingAppDelegate newEditor:]):
2058 (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
2059 (-[WebEditingAppDelegate validateMenuItem:]):
2060 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2061 (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
2062 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2063 (-[WebEditingAppDelegate showOperations:]): Deleted.
2064 * WebEditingTester/MainMenu.xib:
2065 The WK abbreviation is unnaturally grating in menu items for some reason.
2067 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2069 [WebEditingTester] Add a custom protocol for loading canned content
2070 https://bugs.webkit.org/show_bug.cgi?id=141830
2072 Reviewed by Enrica Casucci.
2074 Add a canned:// protocol handler, which can be used to emulate behaviors
2075 in WebKit client apps (like Mail) that use custom protocol handlers,
2076 which can have important effects on editing (mostly, the URLs are only
2077 valid inside of the client application, but not when copied/dragged out).
2079 For now, we only support two canned files:
2081 canned://dice is a PNG of dice (stolen from LayoutTests/)
2082 canned://text is the string "canned text" served as text/html
2084 In the future we could support things like very large (generated) files,
2085 progressive loading, etc. to further simulate conditions in other apps.
2087 * WebEditingTester/AppDelegate.m:
2088 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2089 Register the protocol with CFNetwork, and the scheme with WebKit2.
2091 * WebEditingTester/Canned Content/dice.png: Added.
2092 * WebEditingTester/CannedContent.h: Added.
2093 * WebEditingTester/CannedContent.m: Added.
2094 (-[CannedContent initWithRequest:cachedResponse:client:]):
2095 (+[CannedContent canonicalRequestForRequest:]):
2096 (+[CannedContent canInitWithRequest:]):
2097 We only want to handle canned:// URLs.
2099 (-[CannedContent startLoading]):
2100 For now, immediately load the two files we know about.
2101 Otherwise, immediately fail the load.
2103 (-[CannedContent stopLoading]):
2104 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2106 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2108 [WebEditingTester] Implement an open panel
2109 https://bugs.webkit.org/show_bug.cgi?id=141829
2111 Reviewed by Simon Fraser.
2113 * WebEditingTester/AppDelegate.m:
2114 (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
2115 (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
2116 (-[WebEditingAppDelegate openDocument:]):
2117 Add an open panel (with radio buttons to pick which WebKit to open with).
2118 Loads the file as an HTML string.
2120 2015-02-20 Simon Fraser <simon.fraser@apple.com>
2122 [WebEditingTester] @properties, dot syntax, and remember the window position
2123 https://bugs.webkit.org/show_bug.cgi?id=141843
2125 Reviewed by Tim Horton.
2127 Modernize a bit with more dot syntax, use @property for the web views,
2128 and give the main window an Autosave name so it remembers the widow position.
2130 * WebEditingTester/WK1WebDocumentController.m:
2131 (-[WK1WebDocumentController awakeFromNib]):
2132 (-[WK1WebDocumentController loadHTMLString:]):
2133 * WebEditingTester/WK2WebDocumentController.m:
2134 (-[WK2WebDocumentController awakeFromNib]):
2135 * WebEditingTester/WebDocument.xib:
2137 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2139 [WebEditingTester] Hook up key equivalents for new window action
2140 https://bugs.webkit.org/show_bug.cgi?id=141828
2142 Reviewed by Enrica Casucci.
2144 * WebEditingTester/AppDelegate.h:
2145 * WebEditingTester/AppDelegate.m:
2146 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2147 (-[WebEditingAppDelegate newEditor:]):
2148 (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
2149 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2150 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2151 (defaultConfiguration): Deleted.
2152 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2153 Move WKWebViewConfiguration setup into WK2WebDocumentController.
2154 Remove unused application termination code.
2155 Update new-window menu item key equivalents when launching and when
2156 changing the use-WebKit2-by-default setting.
2157 Make WebDocumentController subclasses all initialized the same way,
2158 and use that to factor out alloc/init.
2159 Rename loadContent to loadHTMLString for future use.
2161 * WebEditingTester/MainMenu.xib:
2162 Add default key equivalents.
2163 Cmd-N will always make the default kind of window (controlled by the pref).
2164 Cmd-Opt-N will always make the other kind.
2165 The menu items are configured as alternates so they only show up if you
2166 press alt (just like in MiniBrowser).
2168 * WebEditingTester/WK1WebDocumentController.m:
2169 (-[WK1WebDocumentController loadHTMLString:]):
2170 (-[WK1WebDocumentController loadContent]): Deleted.
2171 * WebEditingTester/WK2WebDocumentController.h:
2172 * WebEditingTester/WK2WebDocumentController.m:
2173 (defaultConfiguration):
2174 (-[WK2WebDocumentController awakeFromNib]):
2175 (-[WK2WebDocumentController loadHTMLString:]):
2176 (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
2177 (-[WK2WebDocumentController dealloc]): Deleted.
2178 * WebEditingTester/WebDocumentController.h:
2179 * WebEditingTester/WebDocumentController.m:
2180 (-[WebDocumentController init]):
2181 (-[WebDocumentController initWithWindow:]):
2182 (+[WebDocumentController defaultEditingSource]):
2183 (-[WebDocumentController loadHTMLString:]):
2184 (-[WebDocumentController windowDidLoad]): Deleted.
2185 (-[WebDocumentController defaultEditingSource]): Deleted.
2186 (-[WebDocumentController applicationTerminating]): Deleted.
2187 (-[WebDocumentController loadContent]): Deleted.
2189 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2191 [WebEditingTester] ARC-ify WebEditingTester
2192 https://bugs.webkit.org/show_bug.cgi?id=141827
2194 Reviewed by Sam Weinig.
2196 * WebEditingTester/AppDelegate.m:
2197 (-[WebEditingAppDelegate showOperations:]):
2198 * WebEditingTester/EditingOperations.m:
2199 (editingOperations):
2200 * WebEditingTester/WK1WebDocumentController.m:
2201 (-[WK1WebDocumentController dealloc]): Deleted.
2202 * WebEditingTester/WK2WebDocumentController.m:
2203 (-[WK2WebDocumentController dealloc]): Deleted.
2204 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2205 Turn on ARC and remove a few retain/release/autorelease calls.
2206 We don't need to implement dealloc in either document controller
2207 because WebView and WKWebView's UIDelegate property does not hold a
2210 2015-02-20 Timothy Horton <timothy_horton@apple.com>
2212 [WebEditingTester] Factor out list of editing operations
2213 https://bugs.webkit.org/show_bug.cgi?id=141826
2215 Reviewed by Sam Weinig.
2217 * WebEditingTester/AppDelegate.m:
2218 (-[WebEditingAppDelegate showOperations:]):
2219 * WebEditingTester/EditingOperations.h: Added.
2220 * WebEditingTester/EditingOperations.m: Added.
2221 (editingOperations):
2222 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2223 Move EditingOperations array to its own file, and make it an NSArray
2224 instead of a C array. Adjust accordingly in showOperations:.
2226 2015-02-20 Michael Saboff <msaboff@apple.com>
2228 DFG JIT needs to check for stack overflow at the start of Program and Eval execution
2229 https://bugs.webkit.org/show_bug.cgi?id=141676
2231 Reviewed by Filip Pizlo.
2233 Set the newly added --maximumEvalCacheableSourceLength option for eager test runs. This is needed
2234 to allow the eval out of stack tests to tier up. Without this option, we don't cache the likely
2235 large string expression that we want to eval.
2237 * Scripts/run-jsc-stress-tests:
2239 2015-02-19 Daniel Bates <dabates@apple.com>
2241 REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
2242 https://bugs.webkit.org/show_bug.cgi?id=141815
2243 <rdar://problem/19893933>
2245 Reviewed by Simon Fraser.
2247 Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
2248 was booted by iOS Simulator in a previous run of run-webkit-test.
2250 * Scripts/webkitpy/port/ios.py:
2251 (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
2252 (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
2253 testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
2255 2015-02-19 David Kilzer <ddkilzer@apple.com>
2257 check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
2258 <http://webkit.org/b/141799>
2260 Reviewed by Alex Christensen.
2262 * Scripts/webkitpy/style/checkers/cpp.py:
2263 (_IncludeState.check_next_include_order): Don't emit a warning
2264 if the primary header exists and the source file name ends with
2265 "SoftLink.cpp". Add 'filename' argument to method.
2266 (check_include_line): Pass in 'filename'.
2268 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2269 (OrderOfIncludesTest.test_check_next_include_order__no_config):
2270 (OrderOfIncludesTest.test_check_next_include_order__no_self):
2271 (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
2272 (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
2273 (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
2274 - Add test filename arguments for calls to
2275 check_next_include_order().
2276 (OrderOfIncludesTest.test_primary_header): Add test for a file
2277 name ending in "SoftLink.cpp".
2279 2015-02-18 Enrica Casucci <enrica@apple.com>
2281 Add new tool to test editable Webviews.
2282 https://bugs.webkit.org/show_bug.cgi?id=141772
2284 Reviewed by Tim Horton.
2286 Adding WebEditingTester, a Cocoa application to
2287 test WK1 and Wk2 views in editable mode.
2289 * WebEditingTester: Added.
2290 * WebEditingTester/AppDelegate.h: Added.
2291 * WebEditingTester/AppDelegate.m: Added.
2292 (-[WebEditingAppDelegate init]):
2293 (defaultConfiguration):
2294 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2295 (-[WebEditingAppDelegate applicationWillTerminate:]):
2296 (-[WebEditingAppDelegate newEditor:]):
2297 (-[WebEditingAppDelegate showOperations:]):
2298 (-[WebEditingAppDelegate useWebKit2ByDefault]):
2299 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2300 (-[WebEditingAppDelegate validateMenuItem:]):
2301 * WebEditingTester/Info.plist: Added.
2302 * WebEditingTester/MainMenu.xib: Added.
2303 * WebEditingTester/WK1WebDocumentController.h: Added.
2304 * WebEditingTester/WK1WebDocumentController.m: Added.
2305 (-[WK1WebDocumentController awakeFromNib]):
2306 (-[WK1WebDocumentController loadContent]):
2307 (-[WK1WebDocumentController dealloc]):
2308 (-[WK1WebDocumentController pasteAsMarkup:]):
2309 * WebEditingTester/WK2WebDocumentController.h: Added.
2310 * WebEditingTester/WK2WebDocumentController.m: Added.
2311 (-[WK2WebDocumentController initWithConfiguration:]):
2312 (-[WK2WebDocumentController pasteAsMarkup:]):
2313 (-[WK2WebDocumentController awakeFromNib]):
2314 (-[WK2WebDocumentController dealloc]):
2315 (-[WK2WebDocumentController loadContent]):
2316 * WebEditingTester/WebDocument.xib: Added.
2317 * WebEditingTester/WebDocumentController.h: Added.
2318 * WebEditingTester/WebDocumentController.m: Added.
2319 (-[WebDocumentController initWithWindow:]):
2320 (-[WebDocumentController windowDidLoad]):
2321 (-[WebDocumentController defaultEditingSource]):
2322 (-[WebDocumentController applicationTerminating]):
2323 (-[WebDocumentController loadContent]):
2324 * WebEditingTester/WebEditingTester.xcodeproj: Added.
2325 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
2326 * WebEditingTester/main.m: Added.
2329 2015-02-18 Csaba Osztrogonác <ossy@webkit.org>
2331 Run JSC tests on ARM EFL bots
2332 https://bugs.webkit.org/show_bug.cgi?id=141165
2334 Reviewed by Alexey Proskuryakov.
2336 * BuildSlaveSupport/build.webkit.org-config/config.json:
2337 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2338 (RunJavaScriptCoreTests.countFailures):
2339 (RunRemoteJavaScriptCoreTests):
2340 (RunRemoteJavaScriptCoreTests.start):
2341 (BuildAndRemoteJSCTestsFactory):
2342 (BuildAndRemoteJSCTestsFactory.__init__):
2344 2015-02-18 Alexey Proskuryakov <ap@apple.com>
2346 Streamline unexported function build fixes
2347 https://bugs.webkit.org/show_bug.cgi?id=141761
2349 Reviewed by Alex Christensen.
2351 * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
2352 We don't need to ignore symbols that are not exported due to the .unexp file.
2354 2015-02-18 Timothy Horton <timothy_horton@apple.com>
2356 Remove more references to WebCore.exp.in
2357 https://bugs.webkit.org/show_bug.cgi?id=141747
2359 Reviewed by Alexey Proskuryakov.
2361 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2364 2015-02-17 Myles C. Maxfield <mmaxfield@apple.com>
2366 Windows test results should not fall back to mac-mountainlion after r180176
2367 https://bugs.webkit.org/show_bug.cgi?id=141719
2369 Reviewed by Brent Fulgham.
2371 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2372 (_should_file_trigger_build):
2373 * Scripts/webkitpy/port/win.py:
2374 (WinPort.default_baseline_search_path):
2375 * Scripts/webkitpy/port/win_unittest.py:
2376 (WinPortTest.test_baseline_search_path):
2378 2015-02-17 Daniel Bates <dabates@apple.com>
2380 [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
2381 https://bugs.webkit.org/show_bug.cgi?id=141718
2383 Reviewed by Alex Christensen.
2385 We should only run layout tests if simctl can successfully boot and shutdown the testing device.
2387 * Scripts/webkitpy/port/ios.py:
2388 (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
2389 Log a error and return False if we are unable to boot the simulator device so that the caller can take
2390 appropriate action, say exit(3) before running any layout tests.
2391 * Scripts/webkitpy/xcode/simulator.py:
2392 (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
2393 with the specified UDID.
2394 (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
2395 with the specified UDID can successfully boot and shut down. We make at most two attempts to
2396 boot and shut down the device, erasing the device between tries so as to restore the device
2397 to a known good state.
2399 2015-02-17 Daniel Bates <dabates@apple.com>
2401 run_webkit_tests.py should not know about iOS Simulator details
2402 https://bugs.webkit.org/show_bug.cgi?id=141711
2404 Reviewed by Alex Christensen.
2406 Run_webkit_tests.py should only parse the iOS-specific command
2407 line options --runtime and --device-type. Let the port-specific
2408 logic in ios.py validate the parsed options and instantiate
2409 internal data structures.
2411 Currently run_webkit_tests.py parses the iOS-specific command
2412 line options --runtime and --device-type, validates them, and
2413 instantiates internal data structures from the parsed strings.
2414 Instead the validation logic and instantiation of internal
2415 data structures should be handled by the iOS port object.
2417 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2418 (_set_up_derived_options): Remove logic to validate --runtime and --device-type
2419 and instantiate internal data structures for them.
2420 * Scripts/webkitpy/port/driver.py:
2421 (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
2422 and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
2424 * Scripts/webkitpy/port/ios.py: Sort the list of imports.
2425 (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
2426 object from --runtime, if specified. Otherwise, instantiates a Runtime
2427 object for the latest installed iphonesimulator SDK version.
2428 (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
2429 object from --device-type, if specified. Otherwise, instantiates
2430 a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
2431 machine, respectively.
2432 (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
2433 runtime is available to use.
2434 (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
2435 and simulator_runtime for the iOS Simulator device type and runtime, respectively.
2436 * Scripts/webkitpy/xcode/simulator.py:
2437 (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
2438 with a runtime identifier for the specified iOS version.
2440 2015-02-17 Dana Burkart <dburkart@apple.com>
2442 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
2443 https://bugs.webkit.org/show_bug.cgi?id=141672
2445 Reviewed by David Kilzer.
2447 * asan/webkit-asan-ignore.txt:
2449 2015-02-17 Alex Christensen <achristensen@webkit.org>
2451 Remove WebCore.exp.in and clean up.
2452 https://bugs.webkit.org/show_bug.cgi?id=141491
2454 Reviewed by Andreas Kling.
2456 * Scripts/sort-export-file: Removed.
2457 * Scripts/webkitpy/style/checker.py:
2460 (CheckerDispatcher._file_type):
2461 (CheckerDispatcher._create_checker):
2462 Don't check if the export files are sorted.
2463 * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
2464 * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
2466 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
2468 Unreviewed. Fix GTK+ make distcheck.
2470 Do not exclude bmalloc directory from the tarball.
2472 * gtk/manifest.txt.in:
2474 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
2476 Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
2478 I forgot to add the return of a bool function.
2480 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2481 (WebKitDOMNodeTest::testDOMCache):
2483 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
2485 [GTK] GObject DOM bindings object are cached forever
2486 https://bugs.webkit.org/show_bug.cgi?id=141558
2488 Reviewed by Sergio Villar Senin.
2490 Add checks for all DOM objects to ensure they are not leaked. Also
2491 add a dedicated test for the DOM Object Cache.
2493 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2494 (WebKitDOMNodeFilterTest::testTreeWalker):
2495 (WebKitDOMNodeFilterTest::testNodeIterator):
2496 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2497 (WebKitDOMNodeTest::testHierarchyNavigation):
2498 (WebKitDOMNodeTest::testInsertion):
2499 (WebKitDOMNodeTest::testTagNames):
2500 (WebKitDOMNodeTest::testDOMCache):
2502 * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2503 (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2504 (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2505 (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2506 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2507 (testWebKitDOMObjectCache):
2509 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2510 (documentLoadedCallback):
2512 2015-02-16 Carlos Garcia Campos <cgarcia@igalia.com>
2514 [GTK] WebKitFrame objects are never released
2515 https://bugs.webkit.org/show_bug.cgi?id=141641
2517 Reviewed by Martin Robinson.
2519 Add a way to check GObjects leaks for WebProcess tests and check
2520 WebKitFrame objects are not leaked.
2522 * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
2523 (WebKitFrameTest::testMainFrame):
2524 (WebKitFrameTest::testURI):
2525 (WebKitFrameTest::testJavaScriptContext):
2526 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2527 (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
2529 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2531 2015-02-16 Tim Horton <timothy_horton@apple.com>
2533 Fix the MiniBrowser build with newer clang
2535 * MiniBrowser/mac/SettingsController.m:
2536 (-[SettingsController _toggleBooleanDefault:]):
2537 * MiniBrowser/mac/WK1BrowserWindowController.m:
2538 (-[WK1BrowserWindowController windowWillClose:]):
2539 * MiniBrowser/mac/WK2BrowserWindowController.m:
2540 (-[WK2BrowserWindowController windowWillClose:]):
2541 NSApp is id and clang gets confused about which -delegate we're talking about.
2543 2015-02-16 Antti Koivisto <antti@apple.com>
2545 Develop/Disable Caches does not properly disable disk cache
2546 https://bugs.webkit.org/show_bug.cgi?id=141636
2548 Reviewed by Anders Carlsson.
2550 Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
2551 the network process too.
2553 This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
2555 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2556 (WTR::InjectedBundle::beginTesting):
2557 (WTR::InjectedBundle::setCacheModel):
2558 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2559 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2561 Forward to TestController.
2563 (WTR::TestRunner::setCacheModel):
2564 * WebKitTestRunner/TestInvocation.cpp:
2565 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2567 2015-02-16 Andrzej Badowski <a.badowski@samsung.com>
2569 Unreviewed. Add myself as a committer.
2571 * Scripts/webkitpy/common/config/contributors.json:
2573 2015-02-15 David Kilzer <ddkilzer@apple.com>
2575 REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
2576 <http://webkit.org/b/141607>
2578 * Scripts/check-for-weak-vtables-and-externals: Ignore weak
2579 externals in Source/WebCore/Configurations/WebCore.unexp when
2580 building with Xcode 5.x.
2581 (readXcode5SymbolsToIgnore): Add.
2583 2015-02-15 KwangHyuk Kim <hyuki.kim@samsung.com>
2585 [EFL] fix Evas GL engine error.
2586 https://bugs.webkit.org/show_bug.cgi?id=141621
2588 Reviewed by Gyuyoung Kim.
2590 As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
2592 * MiniBrowser/efl/main.c:
2595 2015-02-14 Csaba Osztrogonác <ossy@webkit.org>
2597 [buildbot] Enable run-api-tests on release Mac bots
2598 https://bugs.webkit.org/show_bug.cgi?id=141518
2600 Reviewed by Darin Adler.
2602 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2604 (BuildFactory.__init__):
2605 (TestFactory.__init__):
2606 (BuildAndTestFactory.__init__):
2607 (RunUnitTests.start): Deleted.
2608 (unitTestsSupported): Deleted.
2610 2015-02-13 Anders Carlsson <andersca@apple.com>
2612 Add a move constructor and move assignment operator to Deque
2613 https://bugs.webkit.org/show_bug.cgi?id=141571
2615 Reviewed by Andreas Kling.
2617 * TestWebKitAPI/Tests/WTF/Deque.cpp:
2618 (TestWebKitAPI::TEST):
2620 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2622 run-jsc-stress-tests --remote should skip profiler tests
2623 https://bugs.webkit.org/show_bug.cgi?id=141470
2625 Reviewed by Filip Pizlo.
2627 * Scripts/run-jsc-stress-tests:
2629 2015-02-13 Anders Carlsson <andersca@apple.com>
2631 Add an initializer list constructor to Deque
2632 https://bugs.webkit.org/show_bug.cgi?id=141565
2634 Reviewed by Andreas Kling.
2636 * TestWebKitAPI/Tests/WTF/Deque.cpp:
2637 (TestWebKitAPI::TEST):
2639 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2641 [buildbot] Remove buildJSCTool cruft from master.cfg
2642 https://bugs.webkit.org/show_bug.cgi?id=141513
2644 Reviewed by Alexey Proskuryakov.
2646 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2647 (RunJavaScriptCoreTests):
2648 (RunJavaScriptCoreTests.start):
2650 (RunWebKitTests.start):
2651 (TestFactory.__init__):
2652 (TestLeaksFactory.__init__):
2653 (RunJavaScriptCoreTests.__init__): Deleted.
2654 (RunWebKitTests.__init__): Deleted.
2656 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2658 Unreviewed, remove empty directories.
2660 * DumpRenderTree/gtk: Removed.
2661 * DumpRenderTree/gtk/fonts: Removed.
2662 * DumpRenderTree/unix: Removed.
2663 * DumpRenderTree/unix/TestNetscapePlugin: Removed.
2664 * GtkLauncher: Removed.
2665 * TestWebKitAPI/Tests/WebKitGtk: Removed.
2666 * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
2667 * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
2668 * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
2670 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2672 Remove Windows cruft from Tools/Scripts/build-webkittestrunner
2673 https://bugs.webkit.org/show_bug.cgi?id=141519
2675 Reviewed by Alexey Proskuryakov.
2677 * Scripts/build-webkittestrunner:
2679 2015-02-12 Alex Christensen <achristensen@webkit.org>
2681 Removed empty directory.
2683 * WinCELauncher: Removed.
2685 2015-02-12 Csaba Osztrogonác <ossy@webkit.org>
2687 run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
2688 https://bugs.webkit.org/show_bug.cgi?id=141202
2690 Reviewed by Darin Adler.
2692 * Scripts/run-jsc-stress-tests:
2694 2015-02-12 Brent Fulgham <bfulgham@apple.com>
2696 [Win] Test bot infrastructure should not try to find/use old Safari DLLs
2697 https://bugs.webkit.org/show_bug.cgi?id=141517
2699 Reviewed by Anders Carlsson.
2701 We do not need to locate or use the DLL's that came with Safari, so stop
2702 failing when we cannot find them. Also remove some old Qt cruft from this
2705 * BuildSlaveSupport/built-product-archive:
2706 (archiveBuiltProduct):
2707 (extractBuiltProduct):
2709 2015-02-11 Brent Fulgham <bfulgham@apple.com>
2711 [Win] [64-bit] Work around MSVC2013 Runtime Bug
2712 https://bugs.webkit.org/show_bug.cgi?id=141498
2713 <rdar://problem/19803642>
2715 Reviewed by Anders Carlsson.
2717 Disable FMA3 instruction use in the MSVC math library to
2718 work around a VS2013 runtime crash. We can remove this
2719 workaround when we switch to VS2015.
2721 * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
2722 disable FMA3 support.
2723 * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
2724 * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
2725 * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2726 * Scripts/webkitperl/httpd.pm: Ditto.
2727 * TestWebKitAPI/win/main.cpp: Ditto.
2728 * WinLauncher/Common.cpp: Ditto.
2729 * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
2731 2015-02-12 Csaba Osztrogonác <ossy@webkit.org>
2733 run-jsc-stress-tests should accept remote host config from JSON file
2734 https://bugs.webkit.org/show_bug.cgi?id=141509
2736 Reviewed by Michael Saboff.
2738 * Scripts/run-javascriptcore-tests:
2739 (runJSCStressTests):
2740 * Scripts/run-jsc-stress-tests:
2742 2015-02-12 Carlos Garcia Campos <cgarcia@igalia.com>
2744 [GTK] Add API to allow overriding the default color chooser implementation
2745 https://bugs.webkit.org/show_bug.cgi?id=98935
2747 Reviewed by Gustavo Noronha Silva.
2749 Add a color chooser implementation for MiniBrowser using
2750 GtkPopover when the GTK+ version is recent enough.
2751 And a test case to check the new color chooser API.
2753 * MiniBrowser/gtk/BrowserWindow.c:
2754 (colorChooserRGBAChanged):
2755 (popoverColorClosed):
2756 (colorChooserRequestFinished):
2757 (runColorChooserCallback):
2758 (browserWindowConstructed):
2759 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2760 (testWebViewColorChooserRequest):
2763 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
2765 Make run-jsc-stress-tests --remote work with make-based runner
2766 https://bugs.webkit.org/show_bug.cgi?id=141079
2768 Reviewed by Darin Adler.
2770 * Scripts/run-javascriptcore-tests:
2771 (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
2772 * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
2773 except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
2774 to avoid code duplication.
2776 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
2778 run-jsc-stress tests should detect the number of processors on the remote machine too
2779 https://bugs.webkit.org/show_bug.cgi?id=141196
2781 Reviewed by Darin Adler.
2783 * Scripts/run-javascriptcore-tests:
2784 (runJSCStressTests): Pass through the --child-processes argument.
2785 * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
2786 to detect the number of local and remote processors with the same algorithm.
2787 Additionally introduced $numChildProcesses to emphasize it isn't necessarily
2788 same as $numProcessors.
2790 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
2792 run-jsc-stress-tests should pass JSC_timeout to remote hosts
2793 https://bugs.webkit.org/show_bug.cgi?id=141164
2795 Reviewed by Darin Adler.
2797 Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
2799 * Scripts/run-jsc-stress-tests:
2801 2015-02-11 Carlos Garcia Campos <cgarcia@igalia.com>
2803 [GTK] Add default color chooser implementation using GtkColorChooserDialog
2804 https://bugs.webkit.org/show_bug.cgi?id=141392
2806 Reviewed by Gustavo Noronha Silva.
2808 Enable INPUT_TYPE_COLOR by default for GTK+ port.
2810 * Scripts/webkitperl/FeatureList.pm:
2812 2015-02-09 Csaba Osztrogonác <ossy@webkit.org>
2814 run-jsc-stress-tests shell test runner should run tests in fixed order
2815 https://bugs.webkit.org/show_bug.cgi?id=141383
2817 Reviewed by Darin Adler.
2819 * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2821 2015-02-08 Chris Fleizach <cfleizach@apple.com>
2823 AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
2824 https://bugs.webkit.org/show_bug.cgi?id=140485
2826 Reviewed by Anders Carlsson.
2828 Implement takeFocus() as a way to set focus through accessibility wrappers.
2830 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2831 (AccessibilityUIElement::takeFocus):
2832 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2833 (WTR::AccessibilityUIElement::takeFocus):
2835 2015-02-08 Darin Adler <darin@apple.com>
2837 Remove the SVG instance tree
2838 https://bugs.webkit.org/show_bug.cgi?id=140602
2840 Reviewed by Dean Jackson.
2842 * Scripts/check-for-global-initializers: Removed special case for
2843 SVGElementInstance.o.
2845 2015-02-07 David Kilzer <ddkilzer@apple.com>
2847 [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
2848 <http://webkit.org/b/141365>
2850 Reviewed by Daniel Bates.
2852 * Scripts/webkitpy/xcode/simulator.py:
2853 (Simulator): Add unavailable_version_re precompiled regex.
2854 (Simulator._parse_devices): Check for unavailable versions and
2855 ignore them if found when parsing the output of
2856 `xcrun simctl list`.
2857 * Scripts/webkitpy/xcode/simulator_unittest.py:
2858 (test_unavailable_devices): Add test with output from
2859 `xcrun simctl list` with unavailable runtimes that fails before
2862 2015-02-07 Chris Dumez <cdumez@apple.com>
2864 Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
2865 https://bugs.webkit.org/show_bug.cgi?id=141321
2867 Reviewed by Darin Adler.
2869 Use new Vector::removeFirstMatching() / removeAllMatching() methods.
2871 2015-02-07 David Kilzer <ddkilzer@apple.com>
2873 [iOS] Make Simulator class testable
2874 <http://webkit.org/b/141358>
2876 Rubber-stamped by Darin Adler.
2878 * Scripts/webkitpy/common/system/platforminfo.py:
2879 (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
2880 command to here from Simulator.refresh() in xcode/simulator.py
2881 so that the output of the command can be mocked.
2883 * Scripts/webkitpy/common/system/platforminfo_mock.py:
2884 (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
2886 (MockPlatformInfo.xcode_simctl_list): Add method that returns
2887 self.expected_xcode_simctl_list expectation.
2889 * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
2891 (Simulator.__init__): Add optional 'host' parameter to make it
2892 possible to pass in a mock object for testing. Set self._host
2893 to 'host' parameter or create Host() object.
2894 (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
2897 * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
2900 (SimulatorTest.setUp):
2901 (SimulatorTest._set_expected_xcrun_simctl_list):
2902 (SimulatorTest.test_simulator_device_types):
2903 (test_invalid_device_types_header):
2904 (test_invalid_runtimes_header):
2905 (test_invalid_devices_header):
2907 2015-02-07 Csaba Osztrogonác <ossy@webkit.org>
2909 run-jsc-stress-tests --remote should use the default ssh port
2910 https://bugs.webkit.org/show_bug.cgi?id=141287
2912 Reviewed by Darin Adler.
2914 * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
2916 2015-02-06 Dana Burkart <dburkart@apple.com>
2918 dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
2919 https://bugs.webkit.org/show_bug.cgi?id=141349
2921 Reviewed by Alexey Proskuryakov.
2923 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2924 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2925 (BuildbotTesterQueueView.prototype.update):
2927 2015-02-06 Alexey Proskuryakov <ap@apple.com>
2929 Report network process crashes during layout tests
2930 https://bugs.webkit.org/show_bug.cgi?id=139646
2932 Reviewed by Anders Carlsson.
2934 * WebKitTestRunner/TestController.cpp:
2935 (WTR::TestController::initialize):
2936 (WTR::TestController::networkProcessName):
2937 (WTR::TestController::networkProcessDidCrash):
2938 * WebKitTestRunner/TestController.h:
2940 2015-02-06 Csaba Osztrogonác <ossy@webkit.org>
2942 run-jsc-stress-tests --remote should create remote directory before copying the bundle
2943 https://bugs.webkit.org/show_bug.cgi?id=141329
2945 Reviewed by Michael Saboff.
2947 * Scripts/run-jsc-stress-tests:
2949 2015-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
2951 [GTK] Remove WebKitWebView::close-notification signal
2952 https://bugs.webkit.org/show_bug.cgi?id=141330
2954 Reviewed by Gustavo Noronha Silva.
2956 Update notifications unit tests according to the API changes, and
2957 add a test case to check that onclose event is fired when a
2958 notification is closed by the user.
2960 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2961 (testWebViewNotification):
2963 2015-02-05 Alexey Proskuryakov <ap@apple.com>
2965 Dashboard doesn't consider building ASan a productive step
2966 https://bugs.webkit.org/show_bug.cgi?id=141312
2968 Reviewed by Simon Fraser.
2970 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2972 2015-02-05 Daniel Bates <dabates@apple.com>
2974 [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
2975 https://bugs.webkit.org/show_bug.cgi?id=141306
2977 Reviewed by Alexey Proskuryakov.
2979 The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
2980 corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
2983 * Scripts/webkitpy/xcode/simulator.py:
2984 (Runtime.from_identifier):
2986 2015-02-05 Daniel Bates <dabates@apple.com>
2988 LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
2989 https://bugs.webkit.org/show_bug.cgi?id=139746
2990 <rdar://problem/19283658>
2992 Reviewed by Alexey Proskuryakov.
2994 Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
2995 if the simulator device is not in state Booted.
2997 Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
2998 launching/relaunching the iOS Simulator app and a simulator app can only be installed
2999 on a device that is in the Booted state. LayoutTestRelay may run before the
3000 device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
3001 We should defer executing LayoutTestRelay until the simulator device booted by
3002 iOS Simulator is in the Booted state.
3004 * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
3005 Simulator methods with the module name, simulator.
3006 (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
3007 after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
3008 before launching iOS Simulator to boot it.
3009 (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
3010 (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
3011 * Scripts/webkitpy/xcode/simulator.py:
3012 (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
3013 the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
3014 interested in the state of the device are more likely interested in the current state of the device as
3015 opposed to the state of the device when the Device object was created.
3016 (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
3017 (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
3018 from both this function and Simulator.device_state().
3019 (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
3020 (Simulator.DeviceState): Added; class of constants.
3021 (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
3022 device is in the specified state.
3023 (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
3024 (Simulator.device_directory): Added.
3025 (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
3027 2015-02-05 Alexey Proskuryakov <ap@apple.com>
3029 Disable retries on Mac debug testers
3030 https://bugs.webkit.org/show_bug.cgi?id=141296
3032 Reviewed by Simon Fraser.
3034 * BuildSlaveSupport/build.webkit.org-config/config.json:
3036 2015-02-05 Dan Bernstein <mitz@apple.com>
3038 Need a way to force $xcodeSDK in webkitdirs.pm
3039 https://bugs.webkit.org/show_bug.cgi?id=141291
3041 Reviewed by Anders Carlsson.
3043 * Scripts/webkitdirs.pm:
3044 (setXcodeSDK): Added.
3046 2015-02-05 Youenn Fablet <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
3048 [Streams API] Implement a barebone ReadableStream interface
3049 https://bugs.webkit.org/show_bug.cgi?id=141045
3051 Reviewed by Benjamin Poulain.
3053 * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
3055 2015-02-04 Joseph Pecoraro <pecoraro@apple.com>
3057 filter-build-webkit: reduce more unfiltered output
3058 https://bugs.webkit.org/show_bug.cgi?id=141282
3060 Reviewed by Daniel Bates.
3062 * Scripts/filter-build-webkit:
3063 Report CompileDTraceScript and Preprocess lines as successful.
3065 2015-02-04 Dana Burkart <dburkart@apple.com>
3067 Botwatcher's Dashboard is cramped
3068 https://bugs.webkit.org/show_bug.cgi?id=140273
3070 Reviewed by Alexey Proskuryakov.
3072 Add a heading key which will allow for arbitrary headings in builder queues.
3074 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3075 (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
3076 (BuildbotBuilderQueueView.prototype.update):
3077 (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
3078 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3079 (BuildbotIteration.prototype._parseData):
3080 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3081 (BuildbotLeaksQueueView.prototype.update):
3082 (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
3083 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
3084 (BuildbotPerformanceQueueView.prototype.update):
3085 (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
3086 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3088 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3089 (BuildbotQueueView.prototype._unauthorizedAccess):
3090 (BuildbotQueueView.prototype._appendBuild):
3091 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3092 (BuildbotTestResults):
3093 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3094 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3095 (BuildbotTesterQueueView.prototype.update):
3096 (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
3098 2015-02-04 Simon Fraser <simon.fraser@apple.com>
3100 WKTR should not use -mainScreen to pick a color profile
3101 https://bugs.webkit.org/show_bug.cgi?id=141265
3103 Reviewed by Tim Horton.
3105 -[NSScreen mainScreen] depends on the active window, so use the first screen
3106 (which is the one we put the window on anyway).
3108 Do some cleanup in DRT that makes the code look similar.
3110 * DumpRenderTree/mac/DumpRenderTree.mm:
3111 (createWebViewAndOffscreenWindow):
3112 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3113 (WTR::PlatformWebView::PlatformWebView):
3115 2015-02-04 Simon Fraser <simon.fraser@apple.com>
3117 LayoutTestHelper should set the color profile of all displays
3118 https://bugs.webkit.org/show_bug.cgi?id=141260
3120 Reviewed by Tim Horton.
3122 WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
3123 which is the screen with the active window. Make things more robust by changing
3124 the colorspace of all displays, not just the main screen, when running layout tests.
3126 * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
3127 * DumpRenderTree/mac/LayoutTestHelper.m:
3128 (originalColorProfileURLs):
3129 (colorProfileURLForDisplay):
3130 (displayUUIDStrings):
3131 (saveDisplayColorProfiles):
3132 (setDisplayColorProfile):
3133 (restoreDisplayColorProfiles):
3134 (installLayoutTestColorProfile):
3135 (restoreUserColorProfile):
3137 Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
3138 toll-free bridged, sadly). Use the map to restore all profiles on exit.
3139 Convert to use more Obj-C types.
3141 2015-02-04 Daniel Bates <dabates@apple.com>
3143 test-webkitpy fails on Mac without iphoneos SDK
3144 https://bugs.webkit.org/show_bug.cgi?id=141255
3145 <rdar://problem/19619691>
3147 I inadvertently committed the wrong exception message. Fix up the exception message
3148 to instruct a person to install the iOS SDK when it cannot be found.
3150 * Scripts/webkitpy/port/ios.py:
3151 (IOSPort.determine_full_port_name):
3153 2015-02-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
3155 W3C test importer should sort the list of files when generating the w3c-import.log
3156 https://bugs.webkit.org/show_bug.cgi?id=141156
3158 Reviewed by Bem Jones-Bey.
3160 Sort explicitly the list of imported files written in the w3c-import.log.
3161 Removed logging of the import date.
3163 * Scripts/webkitpy/w3c/test_importer.py:
3164 (TestImporter.write_import_log):
3166 2015-02-04 Daniel Bates <dabates@apple.com>
3168 test-webkitpy fails on Mac without iphoneos SDK
3169 https://bugs.webkit.org/show_bug.cgi?id=141255
3170 <rdar://problem/19619691>
3172 Reviewed by David Kilzer and Alexey Proskuryakov.
3174 Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
3175 should not require the iphoneos SDK to be installed to run the webkitpy tests.
3177 * Scripts/webkitpy/common/system/platforminfo.py:
3178 (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
3179 installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
3180 to standard output if the SDK is installed to return the empty string if the SDK is
3182 * Scripts/webkitpy/common/system/platforminfo_mock.py:
3183 (MockPlatformInfo.xcode_sdk_version): Added.
3184 * Scripts/webkitpy/port/ios.py:
3185 (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
3186 to get the version of the iphoneos SDK, if installed.
3188 2015-02-04 Alexey Proskuryakov <ap@apple.com>
3190 run-webkit-tests doesn't always capture ASan violation reports
3191 https://bugs.webkit.org/show_bug.cgi?id=141231
3193 Reviewed by Darin Adler.
3195 * Scripts/webkitpy/port/driver.py:
3196 (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
3197 by the driver already (as is the case with ASan violations, which are printed to
3199 (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
3201 (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
3202 a separate variable for reporting.
3204 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
3206 [webkitpy] Add platform specific Skipped file mechanism for performance tests
3207 https://bugs.webkit.org/show_bug.cgi?id=141152
3209 Reviewed by Csaba Osztrogonác.
3211 Support a test-expectation-like syntax in performance tests' skipped files.
3212 e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
3214 * Scripts/webkitpy/port/base.py:
3215 (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
3217 * Scripts/webkitpy/port/base_unittest.py:
3218 (PortTest.test_skipped_perf_tests): Test the new syntax.
3220 2015-02-04 Alexey Proskuryakov <ap@apple.com>
3222 When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
3223 https://bugs.webkit.org/show_bug.cgi?id=141236
3225 Reviewed by Sam Weinig.
3227 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3228 (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
3230 2015-02-04 Chris Dumez <cdumez@apple.com>
3232 Add removeFirst(value) / removeAll(value) methods to WTF::Vector
3233 https://bugs.webkit.org/show_bug.cgi?id=141192
3235 Reviewed by Benjamin Poulain.
3237 Add API tests for Vector::removeFirst(value) and
3238 Vector::removeAll(value).
3240 * TestWebKitAPI/Tests/WTF/Vector.cpp:
3241 (TestWebKitAPI::TEST):
3243 2015-02-03 Tim Horton <timothy_horton@apple.com>
3245 Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
3246 https://bugs.webkit.org/show_bug.cgi?id=141217
3248 Reviewed by Sam Weinig.
3250 * WebKitTestRunner/TestController.cpp:
3251 (WTR::copyWebCryptoMasterKey):
3252 (WTR::TestController::createOtherPage):
3253 (WTR::TestController::createWebViewWithOptions):
3254 (WTR::TestController::ensureViewSupportsOptions):
3255 (WTR::TestController::didCommitNavigation):
3256 (WTR::TestController::didFinishNavigation):
3257 (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3258 (WTR::TestController::didReceiveAuthenticationChallenge):
3259 (WTR::TestController::decidePolicyForPluginLoad):
3260 (WTR::TestController::decidePolicyForNavigationAction):
3261 (WTR::TestController::decidePolicyForNavigationResponse):
3262 (WTR::TestController::didCommitLoadForFrame): Deleted.
3263 (WTR::TestController::didFinishLoadForFrame): Deleted.
3264 * WebKitTestRunner/TestController.h:
3265 Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
3267 2015-02-03 Dhi Aurrahman <diorahman@rockybars.com>
3269 Unreviewed. Add myself as a committer.
3271 * Scripts/webkitpy/common/config/contributors.json:
3273 2015-02-03 Brent Fulgham <bfulgham@apple.com>
3275 [Win] Unreviewed test fix.
3277 * DumpRenderTree/win/PolicyDelegate.cpp:
3278 (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
3279 so was not matching expected output.
3281 2015-02-03 Youenn Fablet <youenn.fablet@crf.canon.fr>
3283 Unreviewed. Moving myself to the committer section at last.
3285 * Scripts/webkitpy/common/config/contributors.json:
3287 2015-02-03 Brent Fulgham <bfulgham@apple.com>
3289 [Win] Tests fail because DRT reports '(null)' instead of an empty string
3290 https://bugs.webkit.org/show_bug.cgi?id=141205
3292 Reviewed by Anders Carlsson.
3294 * DumpRenderTree/win/HistoryDelegate.cpp:
3295 (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
3296 properly so that we match expected DumpRenderTree output.
3298 2015-02-03 Michael Catanzaro <mcatanzaro@igalia.com>
3300 [GTK] TestWebKitAccessibility is not skipped
3301 https://bugs.webkit.org/show_bug.cgi?id=141179
3303 Reviewed by Carlos Garcia Campos.
3305 Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
3306 skipped, and it apparently works reliably on the bots.
3308 * Scripts/run-gtk-tests:
3311 2015-02-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
3313 run-perf-tests: allow to specify a wrapper command.
3314 https://bugs.webkit.org/show_bug.cgi?id=141172
3316 Reviewed by Ryosuke Niwa.
3318 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3319 (parse_args): Update text to indicate is also valid for WTR.
3320 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3321 (PerfTestsRunner._parse_args): Add wrapper command.
3323 2015-02-03 Brent Fulgham <bfulgham@apple.com>
3325 [Win] Correct version parsing warning in update-webkit
3326 https://bugs.webkit.org/show_bug.cgi?id=141200
3328 Reviewed by Anders Carlsson.
3330 * Scripts/webkitdirs.pm:
3331 (setupAppleWinEnv): Strip out any specific version build level
3332 from the Cygwin version information.
3335 2015-02-03 Brent Fulgham <bfulgham@apple.com>
3337 [Win] Attempt to improve the reliability of HTTP service
3338 https://bugs.webkit.org/show_bug.cgi?id=141191
3340 Reviewed by Darin Adler.
3342 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3343 (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
3344 (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
3345 when stopping the service doesn't do so on its own (for Windows runs).
3347 2015-02-03 Youenn Fablet <youenn.fablet@crf.canon.fr>
3349 Web platform test server should not need to create __init__.py files
3350 https://bugs.webkit.org/show_bug.cgi?id=141030
3352 Reviewed by Ryosuke Niwa.
3354 W3C TestImporter ensures that copied __init__.py files are not empty.
3355 If needed, a comment is inserted in __init__.py files.
3356 Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
3358 * Scripts/webkitpy/common/system/filesystem.py:
3359 (FileSystem.getsize):
3360 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3361 (TestWebPlatformTestServer.test_start_cmd):
3362 (TestWebPlatformTestServer):
3363 (TestWebPlatformTestServer.test_import_web_platform_test_modules):
3364 * Scripts/webkitpy/w3c/test_importer.py:
3365 (TestImporter.import_tests):
3367 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
3369 Unreviewed. Moving myself to the committer section.
3371 * Scripts/webkitpy/common/config/contributors.json:
3373 2015-02-02 Saam Barati <saambarati1@gmail.com>
3375 Create tests for JSC's Control Flow Profiler
3376 https://bugs.webkit.org/show_bug.cgi?id=141123
3378 Reviewed by Filip Pizlo.
3380 * Scripts/run-javascriptcore-tests:
3381 (runJSCStressTests):
3382 * Scripts/run-jsc-stress-tests:
3384 2015-02-02 Csaba Osztrogonác <ossy@webkit.org>
3386 Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
3387 https://bugs.webkit.org/show_bug.cgi?id=141158
3389 Reviewed by Darin Adler.
3391 * Scripts/run-jsc-stress-tests:
3393 2015-02-02 Michael Catanzaro <mcatanzaro@igalia.com>
3395 [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
3396 https://bugs.webkit.org/show_bug.cgi?id=141142
3398 Reviewed by Carlos Garcia Campos.
3400 * MiniBrowser/gtk/BrowserWindow.c:
3401 (browser_window_init): Quit on Ctrl+W or Ctrl+Q
3403 2015-02-01 Youenn Fablet <youenn.fablet@crf.canon.fr>
3405 Web platform test server is not always launching properly on Mac EWS bots
3406 https://bugs.webkit.org/show_bug.cgi?id=141141
3410 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3411 (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
3413 2015-01-31 Sam Weinig <sam@webkit.org>
3415 Remove even more Mountain Lion support
3416 https://bugs.webkit.org/show_bug.cgi?id=141124
3418 Reviewed by Alexey Proskuryakov.
3420 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3421 (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3422 * DumpRenderTree/mac/Configurations/Base.xcconfig:
3423 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3424 * DumpRenderTree/mac/DumpRenderTree.mm:
3425 (activateTestingFonts):
3426 (prepareConsistentTestingEnvironment):
3427 * DumpRenderTree/mac/EventSendingController.mm:
3428 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3429 (-[EventSendingController contextClick]):
3430 * DumpRenderTree/mac/TextInputController.m:
3431 * LayoutTestRelay/Configurations/Base.xcconfig:
3432 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3433 * MiniBrowser/Configurations/Base.xcconfig:
3434 * MiniBrowser/Configurations/DebugRelease.xcconfig:
3435 * MiniBrowser/mac/WK2BrowserWindowController.m:
3436 (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3437 (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3438 (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3439 * TestWebKitAPI/Configurations/Base.xcconfig:
3440 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3441 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3442 (-[DownloadDelegate _downloadDidFinish:]):
3443 * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3444 (TestWebKitAPI::TEST):
3445 * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3446 (TestWebKitAPI::InjectedBundleController::platformInitialize):
3447 * WebKitLauncher/Configurations/Base.xcconfig:
3448 * WebKitTestRunner/Configurations/Base.xcconfig:
3449 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3450 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3451 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3452 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3453 (WTR::activateFonts):
3454 * WebKitTestRunner/TestController.cpp:
3455 (WTR::TestController::initialize):
3456 (WTR::TestController::webProcessName):
3457 * WebKitTestRunner/mac/EventSenderProxy.mm:
3458 * asan/asan.xcconfig:
3460 2015-01-31 Commit Queue <commit-queue@webkit.org>
3462 Unreviewed, rolling out r179408.
3463 https://bugs.webkit.org/show_bug.cgi?id=141117
3465 This didn't fully fix the issue (Requested by anttik on
3470 "OSObjectPtr does not work with dispatch_data_t on Maverics"
3471 https://bugs.webkit.org/show_bug.cgi?id=141081
3472 http://trac.webkit.org/changeset/179408
3474 2015-01-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
3476 https://trac.webkit.org/changeset/179439 breaks a python test
3477 https://bugs.webkit.org/show_bug.cgi?id=141114
3481 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3482 (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.
3484 2015-01-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
3486 Import W3C web platform tests infrastructure
3487 https://bugs.webkit.org/show_bug.cgi?id=140934
3489 Reviewed by Ryosuke Niwa.
3491 Loading necessary web platform tests modules before launching server.
3492 Ensuring that some empty __init__.py files are present and create them if necessary.
3494 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3495 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3497 2015-01-30 Brent Fulgham <bfulgham@apple.com>
3499 [Win] Another unreviewed test fix.
3501 Correct copy/paste error in buildbot handling.
3503 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3504 (LayoutTestApacheHttpd.__init__):
3505 (LayoutTestApacheHttpd._get_apache_config_file_path):
3507 2015-01-30 Brent Fulgham <bfulgham@apple.com>
3509 [Win] Unreviewed test fix.
3511 Correct path handling based on failures on test bots to get things running again.
3513 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3514 (LayoutTestApacheHttpd.__init__):
3515 (LayoutTestApacheHttpd._get_apache_config_file_path):
3517 2015-01-30 Chris Dumez <cdumez@apple.com>
3519 Unreviewed. Fix Windows build after r179409.
3521 * DumpRenderTree/win/TestRunnerWin.cpp:
3522 (TestRunner::notifyDone):
3523 (TestRunner::queueLoad):
3525 2015-01-30 Chris Dumez <cdumez@apple.com>
3527 Rename shared() static member functions to singleton() for singleton classes.
3528 https://bugs.webkit.org/show_bug.cgi?id=141088
3530 Reviewed by Ryosuke Niwa and Benjamin Poulain.
3532 Rename shared() static member functions to singleton() for singleton
3533 classes as per the recent coding style change.
3535 2015-01-30 Antti Koivisto <antti@apple.com>
3537 OSObjectPtr does not work with dispatch_data_t on Maverics
3538 https://bugs.webkit.org/show_bug.cgi?id=141081
3540 Reviewed by Pratik Solanki.
3542 * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
3543 (TestWebKitAPI::TEST):
3545 2015-01-30 Brent Fulgham <bfulgham@apple.com>
3547 [Win] Switch to Apache on Windows
3548 https://bugs.webkit.org/show_bug.cgi?id=141060
3550 Reviewed by Alexey Proskuryakov.
3552 Update our scripts under Windows (and Cygwin) to locate and use
3553 the XAMPP installation of Apache for running tests.
3555 * Scripts/run-webkit-httpd:
3556 * Scripts/webkitperl/httpd.pm:
3558 (getDefaultConfigForTestDirectory):
3559 (getHTTPDConfigPathForTestDirectory):
3560 * Scripts/webkitpy/common/system/executive_unittest.py:
3561 (ExecutiveTest.serial_test_kill_process):
3562 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3563 (LayoutTestApacheHttpd.__init__):
3564 (LayoutTestApacheHttpd._get_apache_config_file_path):
3565 (LayoutTestApacheHttpd._stop_running_server):
3566 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3567 (HttpServerBase._is_server_running_on_all_ports):
3568 * Scripts/webkitpy/port/base.py:
3569 (Port._apache_config_file_name_for_platform):
3570 * Scripts/webkitpy/port/port_testcase.py:
3571 (test_apache_config_file_name_for_platform):
3572 * Scripts/webkitpy/port/win.py:
3573 (WinPort.show_results_html_file):
3574 (WinPort._uses_apache):
3576 (WinPort._path_to_apache):
3578 2015-01-29 Alexey Proskuryakov <ap@apple.com>
3580 Built result takes too long to be compressed on bots
3581 https://bugs.webkit.org/show_bug.cgi?id=141056
3583 Reviewed by Daniel Bates.
3585 Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
3587 * BuildSlaveSupport/test-result-archive: (archiveTestResults):
3589 2015-01-29 Sam Weinig <sam@webkit.org>
3591 Remove support for screen font substitution
3592 https://bugs.webkit.org/show_bug.cgi?id=141038
3594 Reviewed by Tim Horton.
3596 * DumpRenderTree/win/DumpRenderTree.cpp:
3597 (resetWebPreferencesToConsistentValues):
3598 Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
3600 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
3602 Make run-jsc-stress-tests --remote work on Linux too
3603 https://bugs.webkit.org/show_bug.cgi?id=141000
3605 Reviewed by Darin Adler.
3607 * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
3608 use bash/dash compatible signal names, use Linux/Mac compatible find options,
3609 use bash/dash compatible functions.
3610 * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
3612 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
3614 [buildbot] Simplify jscore-test buildstep
3615 https://bugs.webkit.org/show_bug.cgi?id=140821
3617 Reviewed by Alexey Proskuryakov.
3619 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3620 (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
3621 (RunJavaScriptCoreTests.countFailures): Added.
3622 (RunJavaScriptCoreTests.commandComplete): Deleted.
3623 (RunJavaScriptCoreTests.evaluateCommand): Deleted.
3624 (RunJavaScriptCoreTests.getText): Deleted.
3625 (RunJavaScriptCoreTests.getText2): Deleted.
3626 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
3627 (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3628 (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
3629 (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
3630 (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
3632 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
3634 Unreviewed, revert r179337, we don't need this dependency.
3636 * efl/install-dependencies:
3637 * gtk/install-dependencies:
3639 2015-01-28 Shivakumar JM <shiva.jm@samsung.com>
3641 Unreviewed. Moving myself to the committer section.
3643 * Scripts/webkitpy/common/config/contributors.json:
3645 2015-01-28 Csaba Osztrogonác <ossy@webkit.org>
3647 URTBF after r179326, added uuid-dev package as new dependency.
3649 * efl/install-dependencies:
3650 * gtk/install-dependencies:
3652 2015-01-28 Timothy Horton <timothy_horton@apple.com>
3654 Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
3655 https://bugs.webkit.org/show_bug.cgi?id=140673
3657 Reviewed by Sam Weinig.
3659 * Scripts/dtrace/trace-webkit2-messages.d: Added.
3660 Add a DTrace script that outputs a small blob of JSON per message.
3662 2015-01-28 Geoffrey Garen <ggaren@apple.com>
3664 Removed fastMallocForbid / fastMallocAllow
3665 https://bugs.webkit.org/show_bug.cgi?id=141012
3667 Reviewed by Mark Hahnenberg.
3669 Fixed a test bug I noticed while testing.
3671 * DumpRenderTree/JavaScriptThreading.cpp:
3672 (stopJavaScriptThreads): Lock the javaScriptThreads lock before
3673 accessing javaScriptThreads -- otherwise, you'll ASSERT.
3675 2015-01-28 Dana Burkart <dburkart@apple.com>
3677 asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
3678 https://bugs.webkit.org/show_bug.cgi?id=141015
3680 Reviewed by Alexey Proskuryakov.
3682 * asan/asan.xcconfig:
3684 2015-01-28 Sam Weinig <sam@webkit.org>
3688 * Scripts/copy-webkitlibraries-to-product-directory:
3690 2015-01-28 Lucas Forschler <lforschler@apple.com>
3692 Increase the FileUpload block size in an attempt to improve network performance.
3694 Reviewed by Alexey Proskuryakov.
3696 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3697 (UploadBuiltProduct.__init__):
3699 2015-01-28 Dana Burkart <dburkart@apple.com>
3701 Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
3702 https://bugs.webkit.org/show_bug.cgi?id=136765
3704 Reviewed by Alexey Proskuryakov.
3706 * DumpRenderTree/mac/Configurations/Base.xcconfig:
3707 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3708 * LayoutTestRelay/Configurations/Base.xcconfig:
3709 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3710 * MiniBrowser/Configurations/Base.xcconfig:
3711 * MiniBrowser/Configurations/DebugRelease.xcconfig:
3712 * TestWebKitAPI/Configurations/Base.xcconfig:
3713 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3714 * WebKitLauncher/Configurations/Base.xcconfig:
3715 * WebKitTestRunner/Configurations/Base.xcconfig:
3716 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3718 2015-01-28 Joanmarie Diggs <jdiggs@igalia.com>
3720 AX: [ATK] Implement support for new AtkRole types for MathML
3721 https://bugs.webkit.org/show_bug.cgi?id=140916
3723 Reviewed by Chris Fleizach.
3725 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
3726 * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
3728 2015-01-28 Carlos Garcia Campos <cgarcia@igalia.com>
3730 [GTK] Stop removing color marks from unit tests output
3731 https://bugs.webkit.org/show_bug.cgi?id=140996
3733 Reviewed by Philippe Normand.
3735 Since r178236 google tests use a custom simplified output without
3736 any colors, so we don't need to handle the case of non ttys to
3737 remove the color marks.
3739 * Scripts/run-gtk-tests:
3740 (TestRunner.__init__):
3741 (TestRunner._run_test_command.parse_line):
3743 2015-01-28 Carlos Garcia Campos <cgarcia@igalia.com>
3745 [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
3746 https://bugs.webkit.org/show_bug.cgi?id=131731
3748 Reviewed by Žan Doberšek.
3750 A web page loaded offscreen is in prerender state not hidden.
3752 * Scripts/run-gtk-tests:
3753 (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
3754 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3755 (testWebViewPageVisibility):
3757 2015-01-27 Alexey Proskuryakov <ap@apple.com>
3759 Partially revert r178802.
3761 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
3762 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
3764 2015-01-27 Alexey Proskuryakov <ap@apple.com>
3766 build.webkit.org/dashboard asserts on some commits
3767 https://bugs.webkit.org/show_bug.cgi?id=140926
3769 Reviewed by Tim Horton.
3771 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3772 (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
3774 2015-01-27 Alexey Proskuryakov <ap@apple.com>
3776 Make flakiness dashboard OS list actually match test_expectations.py
3777 https://bugs.webkit.org/show_bug.cgi?id=140969
3779 Reviewed by Ryosuke Niwa.
3781 * TestResultServer/static-dashboards/flakiness_dashboard.js:
3783 2015-01-27 Brent Fulgham <bfulgham@apple.com>
3785 [Win] WinLauncher crashes on eleventh site visited
3786 https://bugs.webkit.org/show_bug.cgi?id=140960
3788 Reviewed by Anders Carlsson.
3790 * WinLauncher/WinLauncher.cpp:
3791 (WinLauncher::showLastVisitedSites): Don't access off the end of
3794 2015-01-27 Alexey Proskuryakov <ap@apple.com>
3796 [Mac] Disable building Java applets by default
3797 https://bugs.webkit.org/show_bug.cgi?id=140957
3798 rdar://problem/19619529
3800 Reviewed by Anders Carlsson.
3802 It was actually already disabled unconditionally, by accident.
3804 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
3805 * Scripts/webkitpy/port/mac.py:
3806 (MacPort._check_port_build):
3807 (MacPort._build_java_test_support):
3809 2015-01-27 Daniel Bates <dabates@apple.com>
3811 [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
3812 https://bugs.webkit.org/show_bug.cgi?id=140949
3814 Reviewed by Alexey Proskuryakov.
3816 Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
3817 builders so that run-webkit-tests can lint the appropriate TestExpectation
3820 * Scripts/webkitpy/port/builders.py:
3821 * Scripts/webkitpy/port/ios.py:
3822 (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
3823 (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
3824 information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
3825 in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
3826 will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
3827 to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
3828 test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
3831 2015-01-27 Alexey Proskuryakov <ap@apple.com>
3833 Update bots on the flakiness dashboard
3834 https://bugs.webkit.org/show_bug.cgi?id=140956
3836 Reviewed by Ryosuke Niwa.
3838 * TestResultServer/static-dashboards/builders.jsonp:
3839 * TestResultServer/static-dashboards/flakiness_dashboard.js:
3841 2015-01-27 Daniel Bates <dabates@apple.com>
3843 [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
3844 https://bugs.webkit.org/show_bug.cgi?id=140942
3846 Reviewed by Alexey Proskuryakov.
3848 The directory LayoutTests/platform/wk2 contains test expectations and test results that
3849 are applicable to all WebKit2 ports. We should make use of this information when
3850 running layout tests using iOS WebKit2.
3852 Additionally, make use of the convenience function Port._wk2_port_name() for the name
3853 of the WebKit2 port instead of directly using string concatenation.
3855 * Scripts/webkitpy/port/ios.py:
3856 (IOSSimulatorPort.default_baseline_search_path):
3858 2015-01-27 Csaba Osztrogonác <ossy@webkit.org>
3860 [Win] Disable FTL stress tests
3861 https://bugs.webkit.org/show_bug.cgi?id=140932
3863 Reviewed by Brent Fulgham.
3865 * Scripts/run-javascriptcore-tests:
3867 2015-01-27 Daniel Bates <dabates@apple.com>
3869 REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
3870 https://bugs.webkit.org/show_bug.cgi?id=140939
3872 Reviewed by Eric Carlson.
3874 Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
3876 * Scripts/webkitdirs.pm:
3877 (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
3878 of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
3879 and define a function called wanted.
3881 2015-01-27 Daniel Bates <dabates@apple.com>
3883 Teach run-webkit-app --simulator how to install custom built app
3884 https://bugs.webkit.org/show_bug.cgi?id=140691
3886 Fix inadvertent omission of directory test flag in expression to check for the
3887 existence of the iOS simulator device-specific directory for user installed apps.
3889 * Scripts/webkitdirs.pm:
3890 (hasUserInstalledAppInSimulatorDevice):
3892 2015-01-26 Brent Fulgham <bfulgham@apple.com>
3894 [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
3895 https://bugs.webkit.org/show_bug.cgi?id=87426
3896 <rdar://problem/11527899>
3898 Reviewed by Darin Adler.
3900 Revise COMPtr to work better with our HashMap implementation. Use
3903 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3904 (AccessibilityController::~AccessibilityController):
3905 (AccessibilityController::winNotificationReceived):
3906 * DumpRenderTree/win/DumpRenderTree.cpp:
3907 (dumpBackForwardListForAllWindows):
3909 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
3911 [Win] Enable JSC stress tests by default
3912 https://bugs.webkit.org/show_bug.cgi?id=128307
3914 Reviewed by Brent Fulgham.
3916 * Scripts/run-javascriptcore-tests:
3918 2015-01-26 Simon Fraser <simon.fraser@apple.com>
3920 [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
3921 arguments for build and test scripts
3922 https://bugs.webkit.org/show_bug.cgi?id=139748
3924 Reviewed by Daniel Bates.
3926 There was much confusion resulting from the multitude of aliases used to build/test for
3927 the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
3930 This fixes an issue where run-api-tests and some other scripts failed when run with
3933 * Scripts/build-webkit:
3934 * Scripts/package-root:
3936 * Scripts/webkitdirs.pm:
3937 (argumentsForConfiguration):
3938 (determineXcodeSDK):
3939 * Scripts/webkitpy/port/factory.py:
3942 2015-01-26 Simon Fraser <simon.fraser@apple.com>
3944 [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
3945 https://bugs.webkit.org/show_bug.cgi?id=140203
3946 rdar://problem/19198492
3948 Reviewed by Sam Weinig.
3950 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3951 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
3954 2015-01-26 David Kilzer <ddkilzer@apple.com>
3956 Add iOS EWS to build.webkit.org/dashboard
3957 <http://webkit.org/b/140627>
3959 Reviewed by Alexey Proskuryakov.
3961 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
3962 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
3963 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3964 (BubbleQueueServer): Add ios-ews queue info.
3965 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3966 Add iOS8Device platform.
3967 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3968 (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
3971 2015-01-26 Filip Pizlo <fpizlo@apple.com>
3973 copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
3974 https://bugs.webkit.org/show_bug.cgi?id=140896
3976 Reviewed by Michael Saboff.
3978 I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
3979 makes our script do this.
3981 Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
3982 this would be harder given llvm's autoconf setup.
3984 * Scripts/copy-webkitlibraries-to-product-directory:
3986 2015-01-26 Alexey Proskuryakov <ap@apple.com>
3988 Update bot assignments.
3990 * BuildSlaveSupport/build.webkit.org-config/config.json:
3992 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
3994 Integrate WP python server into WebKit test framework
3995 https://bugs.webkit.org/show_bug.cgi?id=127094
3997 Reviewed by Ryosuke Niwa.
3999 This patch adds W3C web server (wptserver) as a new HTTP server.
4000 wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
4001 wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
4003 Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
4004 Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
4005 It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
4007 * Scripts/webkitpy/common/system/executive_mock.py:
4008 (MockProcess.communicate):
4009 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
4010 (LayoutTestRunner.__init__):
4011 (LayoutTestRunner.run_tests):
4012 (LayoutTestRunner.start_servers):
4013 (LayoutTestRunner.stop_servers):
4014 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
4015 (LayoutTestRunnerTests._run_tests):
4016 (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
4017 (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
4018 (LayoutTestRunnerTests):
4019 (LayoutTestRunnerTests.test_servers_started):
4020 * Scripts/webkitpy/layout_tests/controllers/manager.py: Updated to check whether a test is a wpt test and whether wpt server launch is needed.
4022 (Manager._is_http_test):
4023 (Manager._is_web_platform_test):
4024 (Manager._run_tests):
4025 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4026 (ManagerTest.test_needs_servers.get_wpt_doc_root):
4027 (ManagerTest.test_needs_servers.get_manager):
4028 (ManagerTest.test_needs_servers):
4029 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
4031 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
4033 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
4036 (WebPlatformTestServer):
4037 (WebPlatformTestServer.__init__):
4038 (WebPlatformTestServer._set_start_cmd):
4039 (WebPlatformTestServer._copy_webkit_test_files):
4040 (WebPlatformTestServer._clean_webkit_test_files):
4041 (WebPlatformTestServer._prepare_config):
4042 (WebPlatformTestServer._spawn_process):
4043 (WebPlatformTestServer._stop_running_server):
4044 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
4045 (TestWebPlatformTestServer):
4046 (TestWebPlatformTestServer.test_start_cmd):
4047 * Scripts/webkitpy/port/base.py:
4049 (Port.to.start_web_platform_test_server):
4051 (Port.to.web_platform_test_server_doc_root):
4052 (Port.to.web_platform_test_server_base_url):
4053 (Port.to.stop_web_platform_test_server):
4054 * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
4056 (Driver.is_web_platform_test):
4057 (Driver.test_to_uri):
4058 (Driver.uri_to_test):
4059 (Driver._command_from_driver_input):
4060 * Scripts/webkitpy/port/driver_unittest.py: Updated tests according new conversion rules.
4061 (DriverTest.test_test_to_uri):
4062 (DriverTest.test_uri_to_test):
4064 2015-01-26 Daniel Bates <dabates@apple.com>
4066 Teach run-webkit-app --simulator how to install custom built app
4067 https://bugs.webkit.org/show_bug.cgi?id=140691
4069 Reviewed by David Kilzer.
4071 We should teach run-webkit-app --simulator how to install a custom built app.
4073 Currently run-webkit-app --simulator can only run a system app or an app that
4074 was installed using the simctl command line tool. For convenience we should
4075 teach run-webkit-app --simulator how to install a custom built app.
4077 As a side effect of this change run-safari --simulator will install and run
4078 a custom built of MobileSafari (if it exists).
4080 * Scripts/webkitdirs.pm:
4081 (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
4082 Perl from the structure of the device.plist file.
4083 (plistPathFromBundle): Fix if-statement condition so that we actually perform a
4084 file system check to determine the plist path for a Mac app bundle.
4085 (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
4086 it will complain that it cannot find the file: "Domain ... does not exist".
4087 (appDisplayNameFromBundle): Ditto.
4088 (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
4089 until a simulator device is the specified state.
4090 (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
4091 (if it's open) before opening it again so as to ensure that the iOS Simulator boots
4092 the specified device.
4093 (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
4094 As implied by its name, this function will not return until the specified simulator
4095 device UDID is in the shutdown state.
4096 (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
4097 device with the specified UDID.
4098 (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
4099 before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
4100 return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
4101 expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
4102 symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
4103 /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
4104 which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
4105 (hasUserInstalledAppInSimulatorDevice): Added.
4106 (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
4108 (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
4109 switching between a system installed app and a custom built version of the same app (e.g.
4110 custom build of MobileSafari) will erase all contents and settings in the simulator device.
4111 (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
4112 as that was the only caller of this function.
4113 (bootedIOSSimulatorDevice): Deleted.
4114 (openIOSSimulator): Deleted.
4116 2015-01-26 Alexey Proskuryakov <ap@apple.com>
4118 Update bot assignments.
4120 * BuildSlaveSupport/build.webkit.org-config/config.json:
4122 2015-01-26 Alexey Proskuryakov <ap@apple.com>
4124 Leaks bot shouldn't run JSC tests
4125 https://bugs.webkit.org/show_bug.cgi?id=140877
4127 Reviewed by Darin Adler.
4129 Shaves off 48 minutes of time.
4131 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4132 (TestLeaksFactory): Slim down the leaks queue.
4134 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4135 * Scripts/webkitpy/port/ios.py:
4136 (IOSSimulatorPort.print_leaks_summary):
4137 * Scripts/webkitpy/port/mac.py:
4138 (MacPort.print_leaks_summary):
4139 Don't yell when leaks are detected.
4141 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
4143 Refactor run-javascriptcore-tests
4144 https://bugs.webkit.org/show_bug.cgi?id=140824
4146 Reviewed by Darin Adler.
4148 Separated mozilla, stress test code paths and
4149 determining skipped mozilla tests into subroutines.
4151 * Scripts/run-javascriptcore-tests:
4153 (runJSCStressTests):
4154 (defaultJsDriverArgsForMozillaTests):
4156 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
4158 [buildbot] Fix grammar of TestWithFailureCount
4159 https://bugs.webkit.org/show_bug.cgi?id=140884
4161 Reviewed by Alexey Proskuryakov.
4163 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4164 (TestWithFailureCount):
4165 (TestWithFailureCount.commandComplete):
4166 (TestWithFailureCount.getText2):
4170 (RunLLINTCLoopTests):
4172 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4173 (RunLLINTCLoopTestsTest.test_failure):
4174 (Run32bitJSCTestsTest.test_failure):
4175 (RunUnitTestsTest.assertFailures):
4177 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
4179 Unreviewed. Moving myself to the committer section.
4181 * Scripts/webkitpy/common/config/contributors.json:
4183 2015-01-26 Michael Catanzaro <mcatanzaro@igalia.com> and Carlos Garcia Campos <cgarcia@igalia.com>
4185 [GTK] gtkdoc does not appear in DevHelp
4186 https://bugs.webkit.org/show_bug.cgi?id=139369
4188 Reviewed by Philippe Normand.
4190 * gtk/generate-gtkdoc: Create the generators in the main function
4191 and use them to get the local cross renference dependencies. Also
4192 pass the generator module name to webkitdom.write_doc_files().
4193 (get_gtkdoc_module_paths): Receive a list of local cross reference
4195 (get_generator_for_config): Set the main_sgml_file property of the
4196 GtkDoc object from the configuration file.
4197 (generate_documentation): Generate the documentation for the given
4199 (generate_documentation_for_config): Deleted.
4200 * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
4202 (write_doc_files): Receive the module name used to build the
4203 -sections.txt filename.
4205 2015-01-26 Commit Queue <commit-queue@webkit.org>
4207 Unreviewed, rolling out r179107.
4208 https://bugs.webkit.org/show_bug.cgi?id=140880
4210 The GCC in the bots doesn't support the AsyncTask
4211 implementation (Requested by KaL on #webkit).
4215 "[GTK] Enable IndexedDB"
4216 https://bugs.webkit.org/show_bug.cgi?id=98932
4217 http://trac.webkit.org/changeset/179107
4219 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
4221 [EFL] Bump libseccomp version to 2.1.1
4222 https://bugs.webkit.org/show_bug.cgi?id=140357
4224 Reviewed by Gyuyoung Kim.
4226 * efl/jhbuild.modules:
4228 2015-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
4230 [GTK] Enable IndexedDB
4231 https://bugs.webkit.org/show_bug.cgi?id=98932
4233 Reviewed by Žan Doberšek.
4235 * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
4237 2015-01-25 Alexey Proskuryakov <ap@apple.com>
4239 Would like leaks bot results at build.webkit.org/dashboard
4240 https://bugs.webkit.org/show_bug.cgi?id=122657
4242 Reviewed by Darin Adler.
4244 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4245 Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
4246 than necessary, could use the ones from buildbot in more places.
4248 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4249 (BuildbotQueue): Reflect configuration option for leaks queues.
4251 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4252 Add leaks queues to performance column. First, leaks are about performance indeed,
4253 and second, this is where we have some space to spare.
4255 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4256 (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
4259 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4260 (table.queue-grid td): Moved height from queue-view - we can now have more than one
4261 queue view per cell. The heigt is needed to avoid ugly overlapping while loading
4262 results - once the results are loaded, all rows are currently higher than that.
4264 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
4265 (.leaks-popover): Added.
4267 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
4270 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
4271 Load BuildbotLeaksQueueView.js.
4273 2015-01-25 peavo@outlook.com <peavo@outlook.com>
4275 [Win] Add WebKit message loop interface.
4276 https://bugs.webkit.org/show_bug.cgi?id=140857
4278 Reviewed by Brent Fulgham.
4280 Added message loop interface which will run the message loop,
4281 and perform required tasks (like calling CFRunLoopRunInMode)
4282 on each iteration of the loop.
4284 * WinLauncher/WinMain.cpp:
4285 (wWinMain): Use new message loop interface.
4287 2015-01-24 Dan Bernstein <mitz@apple.com>
4289 update-webkit’s --internal option is unused
4290 https://bugs.webkit.org/show_bug.cgi?id=140861
4292 Reviewed by Anders Carlsson.
4294 * Scripts/update-webkit: Removed the option.
4296 2015-01-24 Brent Fulgham <bfulgham@apple.com>
4298 DumpRenderTree needs to run with Windows native controls on Windows
4299 https://bugs.webkit.org/show_bug.cgi?id=25592
4301 Reviewed by Anders Carlsson.
4303 * DumpRenderTree/win/DumpRenderTree.cpp:
4304 (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
4305 (prepareConsistentTestingEnvironment): Ditto.
4307 2015-01-23 David Kilzer <ddkilzer@apple.com>
4309 test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
4310 <http://webkit.org/b/140787>
4312 Reviewed by Daniel Bates.
4314 * Scripts/webkitpy/port/ios.py:
4315 (IOSPort.determine_full_port_name): Instead of checking the type
4316 of the current host, test if /usr/bin/xcrun exists before trying
4319 2015-01-23 Csaba Osztrogonác <ossy@webkit.org>
4321 Fix the false positive build failures on the Windows buildbots
4322 https://bugs.webkit.org/show_bug.cgi?id=140819
4324 Reviewed by Brent Fulgham.
<