Fix internal build configuration issues
[WebKit-https.git] / Tools / ChangeLog
1 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
2
3         Fix internal build configuration issues
4         https://bugs.webkit.org/show_bug.cgi?id=144762
5
6         Reviewed by David Kilzer.
7
8         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
9
10         * DumpRenderTree/mac/Configurations/Base.xcconfig:
11         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
12         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
13         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
14         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
15         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
16         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
17         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
18
19 2015-05-12  David Kilzer  <ddkilzer@apple.com>
20
21         Switch to launching iOS Simulator using bundle ID
22         <rdar://problem/20916096>
23
24         This is required to fix the layout tests on internal bots.
25
26         * Scripts/webkitdirs.pm:
27         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
28         Simulator.  Add FIXME.
29         (quitIOSSimulator): Add FIXME.
30         * Scripts/webkitpy/port/ios.py:
31         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
32         launch iOS Simulator.  Add FIXME.
33         (IOSSimulatorPort.check_sys_deps): Add FIXME.
34
35 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
36
37         Fix run-javascriptcore-tests step on the WinCairo bot
38         https://bugs.webkit.org/show_bug.cgi?id=144866
39
40         Reviewed by Csaba Osztrogonác.
41
42         Catch exception when failing to create soft link, so we can fall back to copy.
43
44         * Scripts/run-jsc-stress-tests:
45
46 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
47
48         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
49         https://bugs.webkit.org/show_bug.cgi?id=116971
50
51         Reviewed by Chris Fleizach.
52
53         Implement rowAtIndex for ATK.
54
55         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
56         (WTR::AccessibilityUIElement::rowAtIndex):
57
58 2015-05-11  Dan Bernstein  <mitz@apple.com>
59
60         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
61
62         Reviewed by Alexey Proskuryakov.
63
64         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
65         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
66         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
67         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
68
69 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
70
71         Fix internal build configuration issues
72         https://bugs.webkit.org/show_bug.cgi?id=144762
73
74         Reviewed by Darin Adler.
75
76         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
77
78         * TestWebKitAPI/Configurations/Base.xcconfig:
79         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
80         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
81         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
82         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
83         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
84         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
85
86 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
87
88         [Win] Move Windows build target to Windows 7 (or newer)
89         https://bugs.webkit.org/show_bug.cgi?id=144890
90         <rdar://problem/20707307>
91
92         Reviewed by Anders Carlsson.
93
94         Update linked SDK and minimal Windows level to be compatible with
95         Windows 7 or newer.
96
97         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
98         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
99         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
100         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
101         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
102         * DumpRenderTree/config.h:
103         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
104         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
105         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
106         * WinLauncher/stdafx.h:
107
108 2015-05-11  Commit Queue  <commit-queue@webkit.org>
109
110         Unreviewed, rolling out r184119.
111         https://bugs.webkit.org/show_bug.cgi?id=144888
112
113         broke JSC tests on Apple Windows bots (Requested by kling on
114         #webkit).
115
116         Reverted changeset:
117
118         "Fix run-javascriptcore-tests step on the WinCairo bot"
119         https://bugs.webkit.org/show_bug.cgi?id=144866
120         http://trac.webkit.org/changeset/184119
121
122 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
123
124         run-benchmark should support Dromaeo
125         https://bugs.webkit.org/show_bug.cgi?id=144849
126
127         Reviewed by Chris Dumez.
128
129         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
130         they can take as much as 15 minutes to run each.
131
132         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
133         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
134         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
135         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
136
137 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
138
139         Build fix. jetstream has a local copy, not remote archive.
140
141         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
142
143 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
144
145         run-benchmark should support SunSpider, Kraken and Octane
146         https://bugs.webkit.org/show_bug.cgi?id=144840
147
148         Reviewed by Darin Adler.
149
150         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
151         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
152         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
153         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
154
155         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
156         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
157
158         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
159         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
160
161         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
162         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
163         now has the ability to run an arbitrary "create script".
164
165         * Scripts/run-benchmark:
166         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
167         This also overrides the remote archive URL specified in the plan.
168
169         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
170
171         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
172         JetStreamBenchmarkBuilder.
173
174         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: 
175         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
176         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
177         _runCreateScript and _applyPatch to clean after themselves.
178         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
179         JetStream, SunSpider, Kraken all use this feature.
180         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
181         the leaf directory name since the latter is not available when a remote ZIP file is used.
182         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
183         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
184         the benchmark name in the patches.
185
186         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
187
188         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
189         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
190         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
191         the browser opens by planName as the plan file no longer contains that.
192
193         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
194         the top directory of JetStream instead of its parent.
195         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
196         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
197         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
198         the top directory of JetStream instead of its parent.
199         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
200         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
201         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
202         done in JetStream.patch.
203         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
204         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
205         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
206         path from the top directory of JetStream as done in JetStream.patch.
207         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
208
209 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
210
211         Fix run-javascriptcore-tests step on the WinCairo bot
212         https://bugs.webkit.org/show_bug.cgi?id=144866
213
214         Reviewed by Darin Adler.
215
216         * Scripts/run-jsc-stress-tests:
217
218 2015-05-11  Alex Christensen  <achristensen@webkit.org>
219
220         [Content Extensions] Support domain-specific rules and exceptions.
221         https://bugs.webkit.org/show_bug.cgi?id=144833
222
223         Reviewed by Darin Adler.
224
225         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
226         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
227         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
228         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
229         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
230         (TestWebKitAPI::mainDocumentRequest):
231         (TestWebKitAPI::subResourceRequest):
232         (TestWebKitAPI::TEST_F):
233         (TestWebKitAPI::checkCompilerError):
234         Added tests for parsing and functionality of if-domain and unless-domain.
235
236 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
237
238         run-benchmark should support Chrome Canary and Firefox Nightly
239         https://bugs.webkit.org/show_bug.cgi?id=144850
240
241         Reviewed by Darin Adler.
242
243         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
244
245         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
246
247         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
248         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
249         (OSXBrowserDriver):
250         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
251         (OSXBrowserDriver.closeBrowsers): Ditto.
252         (OSXBrowserDriver.launchProcess): Ditto.
253         (OSXBrowserDriver.terminateProcesses): Ditto.
254         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
255         (OSXChromeDriver): Removed the unused self.chromePreferences.
256         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
257         (OSXChromeDriver.closeBrowsers): Ditto.
258         (OSXChromeDriver.launchUrl):
259         (OSXChromeCanaryDriver): Added.
260         (OSXChromeCanaryDriver.launchUrl):
261         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
262         (OSXFirefoxDriver): Added.
263         (OSXFirefoxDriver.launchUrl):
264         (OSXFirefoxNightlyDriver): Added.
265         (OSXFirefoxNightlyDriver.launchUrl):
266         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
267         (OSXSafariDriver):
268         (OSXSafariDriver.closeBrowsers):
269
270 2015-05-11  Tim Horton  <timothy_horton@apple.com>
271
272         Page overlay action context override should indicate the source of the request
273         https://bugs.webkit.org/show_bug.cgi?id=144832
274         <rdar://problem/20562594>
275
276         Reviewed by Darin Adler.
277
278         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
279         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
280
281 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
282
283         [GTK] fast/events/page-visibility-transition-test.html is timing out
284         https://bugs.webkit.org/show_bug.cgi?id=114789
285
286         Reviewed by Darin Adler.
287
288         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
289         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
290         requests visibility changes.
291
292 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
293
294         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
295         https://bugs.webkit.org/show_bug.cgi?id=144798
296
297         Reviewed by Darin Adler.
298
299         * efl/install-dependencies:
300
301 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
302
303         Make arguments of run-benchmark more user friendly
304         https://bugs.webkit.org/show_bug.cgi?id=144835
305
306         Reviewed by Darin Adler.
307
308         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
309         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
310         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
311         default values from --platform and --browser as they are required arguments.
312
313         * Scripts/run-benchmark:
314         (main): Made --build-directory optional, and removed default values from --platform and --browser.
315         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
316         are not dynamically obtained via BrowserDriverFactory.
317         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
318         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
319         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
320         run any benchmark in that case.
321         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
322         the specified file isn't a valid relative or an absolute path.
323         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
324         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
325         and browsers.
326         (BrowserDriverFactory.available_browsers): Ditto.
327         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
328         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
329         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
330         browserBuildPath was None.
331         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
332         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
333         so that we can use locally built WebKit to launch Safari.
334
335 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
336
337         Remove the PICTURE_SIZES build flag
338         https://bugs.webkit.org/show_bug.cgi?id=144679
339
340         Reviewed by Benjamin Poulain.
341
342         Removed the PICTURE_SIZES build time flag.
343
344         * Scripts/webkitperl/FeatureList.pm:
345
346 2015-05-09  David Kilzer  <ddkilzer@apple.com>
347
348         Layout tests broke due to unexpected simctl output
349
350         * Scripts/webkitpy/xcode/simulator.py:
351         (Simulator._parse_devices): Handle new Device Pairs header.
352         * Scripts/webkitpy/xcode/simulator_unittest.py:
353         (test_device_pairs): Add unit test for Device Pairs header.
354
355 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
356
357         Remove convenience constructors for TextRun
358         https://bugs.webkit.org/show_bug.cgi?id=144752
359
360         Reviewed by Anders Carlsson.
361
362         Test the StringView which takes a StringImpl*.
363
364         * TestWebKitAPI/Tests/WTF/StringView.cpp:
365         (StringView8Bit): Testing is8Bit() on StringView
366
367 2015-05-07  Sam Weinig  <sam@webkit.org>
368
369         [Content Extensions] Add simple tester that takes an extension and compiles it
370         https://bugs.webkit.org/show_bug.cgi?id=144781
371
372         Reviewed by Dan Bates.
373
374         * ContentExtensionTester: Added.
375         * ContentExtensionTester/Configurations: Added.
376         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
377         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
378         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
379         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
380         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
381         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
382         * ContentExtensionTester/main.m: Added.
383         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
384
385 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
386
387         Build fix.
388
389         Reviewed by Dan Bernstein.
390
391         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
392         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
393         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
394         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
395         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
396         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
397         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
398         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
399
400 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
401
402         [GTK] Some tests fail because they do not assume the popup menu captures click events
403         https://bugs.webkit.org/show_bug.cgi?id=40601
404
405         Reviewed by Carlos Garcia Campos.
406
407         Popdown all attached menus when moving between tests and between each new
408         event sent to the WebView. This prevents context and popup menus from eating
409         events.
410
411         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
412         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
413         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
414         (WTR::dispatchEvent): Popdown all menus between dispatching events.
415         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
416         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
417         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
418         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
419         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
420         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
421         longer in the platform-independent file.
422         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
423
424 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
425
426         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
427         https://bugs.webkit.org/show_bug.cgi?id=144746
428
429         Reviewed by Carlos Garcia Campos.
430
431         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
432
433         * MiniBrowser/gtk/main.c:
434         (main):
435
436 2015-05-08  Commit Queue  <commit-queue@webkit.org>
437
438         Unreviewed, rolling out r183996.
439         https://bugs.webkit.org/show_bug.cgi?id=144806
440
441         ASan detected use-after free (Requested by ap on #webkit).
442
443         Reverted changeset:
444
445         "Remove convenience constructors for TextRun"
446         https://bugs.webkit.org/show_bug.cgi?id=144752
447         http://trac.webkit.org/changeset/183996
448
449 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
450
451         Remove convenience constructors for TextRun
452         https://bugs.webkit.org/show_bug.cgi?id=144752
453
454         Reviewed by Anders Carlsson.
455
456         Test the StringView which takes a StringImpl*.
457
458         * TestWebKitAPI/Tests/WTF/StringView.cpp:
459         (StringView8Bit): Testing is8Bit() on StringView
460
461 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
462
463         [GTK] WTR doesn't correctly handle the Escape key
464         https://bugs.webkit.org/show_bug.cgi?id=144788
465
466         Reviewed by Martin Robinson.
467
468         Correctly handle 0x001B character code in GTK+ event sender to be
469         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
470         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
471         to dismiss popup menus.
472
473         Fixes editing/selection/5354455-1.html.
474
475         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
476         (WTR::getGDKKeySymForKeyRef):
477
478 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
479
480         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
481         https://bugs.webkit.org/show_bug.cgi?id=144748
482
483         Reviewed by Sergio Villar Senin.
484
485         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
486         (testWebKitSettings): Check the new setting is correctly
487         initialized and updated.
488         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
489         (testWebContextSecurityFileXHR): Check XHR to local files is
490         allowed from file URLs after changing the setting.
491         (beforeAll): Add new test.
492
493 2015-05-08  Commit Queue  <commit-queue@webkit.org>
494
495         Unreviewed, rolling out r183945.
496         https://bugs.webkit.org/show_bug.cgi?id=144789
497
498         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
499
500         Reverted changeset:
501
502         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
503         https://bugs.webkit.org/show_bug.cgi?id=144746
504         http://trac.webkit.org/changeset/183945
505
506 2015-05-07  Anders Carlsson  <andersca@apple.com>
507
508         Build fixes.
509
510         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
511         (TestWebKitAPI::TEST):
512         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
513         (TestWebKitAPI::TEST):
514         Add casts.
515
516 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
517
518         GC has trouble with pathologically large array allocations
519         https://bugs.webkit.org/show_bug.cgi?id=144609
520
521         Reviewed by Geoffrey Garen.
522         
523         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
524         and it's a frequently requested feature.
525         
526         Also add the ability to run a test pretending that your system has a particular RAM size.
527         This is useful for GC tests, and the new GC test that I added uses this.
528
529         * Scripts/run-javascriptcore-tests:
530         (runJSCStressTests):
531         * Scripts/run-jsc-stress-tests:
532
533 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
534
535         [EFL] Bump EFL version to 1.14.0
536         https://bugs.webkit.org/show_bug.cgi?id=144743
537
538         Reviewed by Darin Adler.
539
540         Bump EFL and elementary version to 1.14.0 and removed
541         md5sum, because it isn't used at all if hash is present.
542
543         * efl/jhbuild.modules:
544
545 2015-05-07  Saam Barati  <saambarati1@gmail.com>
546
547         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
548         https://bugs.webkit.org/show_bug.cgi?id=144753
549
550         Reviewed by Mark Lam.
551
552         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
553
554 2015-05-07  Beth Dakin  <bdakin@apple.com>
555
556         New force-related DOM events should fire in WK1 views
557         https://bugs.webkit.org/show_bug.cgi?id=144663
558         -and corresponding-
559         rdar://problem/20281886
560
561         Reviewed by Sam Weinig.
562
563         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event 
564         now. Just send nil. 
565         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
566         (TestWebKitAPI::buildAndPerformTest):
567
568 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
569
570         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
571         https://bugs.webkit.org/show_bug.cgi?id=144746
572
573         Reviewed by Martin Robinson.
574
575         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
576
577         * MiniBrowser/gtk/main.c:
578         (main):
579
580 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
581
582         Revert "Introducing the Platform Abstraction Layer (PAL)"
583         https://bugs.webkit.org/show_bug.cgi?id=144751
584
585         Unreviewed.
586
587         PAL should be a new target inside WebCore, rather than a top-level folder.
588
589         * Scripts/build-webkit: Add it to build-webkit.
590
591 2015-05-07  Ada Chan  <adachan@apple.com>
592
593         Add a test for WKPageCopySessionState() with filtering.
594         https://bugs.webkit.org/show_bug.cgi?id=144666
595
596         Reviewed by Darin Adler.
597
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
600         (TestWebKitAPI::didFinishLoadForFrame):
601         (TestWebKitAPI::setPageLoaderClient):
602         (TestWebKitAPI::filterFirstItemCallback):
603         (TestWebKitAPI::filterAllItemsCallback):
604         (TestWebKitAPI::createSessionStates):
605         (TestWebKitAPI::TEST):
606
607 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
608
609         iOS build fix attempt
610
611         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
612
613         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
614
615 2015-05-06  Matt Baker  <mattbaker@apple.com>
616
617         Unreviewed, updated my list of email addresses.
618
619         * Scripts/webkitpy/common/config/contributors.json:
620
621 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
622
623         Do not link tools to WebKit2.framework
624         https://bugs.webkit.org/show_bug.cgi?id=144699
625
626         Unreviewed build fix.
627
628         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
629         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
630         These linked to WebKit2 in two ways, eliminating the other one.
631
632 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
633
634         Introducing the Platform Abstraction Layer (PAL)
635         https://bugs.webkit.org/show_bug.cgi?id=143358
636
637         Reviewed by Simon Fraser.
638
639         * Scripts/build-webkit: Add it to build-webkit.
640
641 2015-05-06  Alex Christensen  <achristensen@webkit.org>
642
643         Fix api tests after r183877.
644
645         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
646         (TestWebKitAPI::TEST_F):
647         Generate all DFAs before compiling them.
648
649 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
650
651         Do not link tools to WebKit2.framework
652         https://bugs.webkit.org/show_bug.cgi?id=144699
653
654         Reviewed by Tim Horton.
655
656         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
658         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
659
660 2015-05-06  Alex Christensen  <achristensen@webkit.org>
661
662         [Content Extensions] Test splitting NFAs by max NFA size.
663         https://bugs.webkit.org/show_bug.cgi?id=144659
664
665         Reviewed by Darin Adler.
666
667         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
668         (TestWebKitAPI::createNFAs):
669         (TestWebKitAPI::TEST_F):
670         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
671         (TestWebKitAPI::createNFAs):
672
673 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
674
675         Remove the remaining vestiges of SVG feature define
676         https://bugs.webkit.org/show_bug.cgi?id=144655
677
678         Reviewed by Alexey Proskuryakov.
679
680         * Scripts/webkitperl/FeatureList.pm:
681
682 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
683
684         Add a layout mode for computing fixed layout size from a minimum size
685         https://bugs.webkit.org/show_bug.cgi?id=144610
686         <rdar://problem/19790341>
687
688         Reviewed by Simon Fraser.
689
690         * MiniBrowser/mac/BrowserWindow.xib:
691         * MiniBrowser/mac/BrowserWindowController.h:
692         * MiniBrowser/mac/WK1BrowserWindowController.m:
693         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
694         * MiniBrowser/mac/WK2BrowserWindowController.m:
695         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
696         Add a optional toolbar item to toggle a minimum view size of 1024x0.
697
698 2015-05-05  Alex Christensen  <achristensen@webkit.org>
699
700         [Content Extensions] Release input NSString when finished copying it.
701         https://bugs.webkit.org/show_bug.cgi?id=144642
702
703         Reviewed by Brian Weinstein.
704
705         * WebKitTestRunner/mac/TestControllerMac.mm:
706         (WTR::TestController::platformConfigureViewForTest):
707         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
708
709 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
710
711         Unreviewed test fix after r183798.
712
713         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
714         (convertToDRTLabel): Mimic behavior of Mac accessibility output
715         so we can share results.
716
717 2015-05-05  Alex Christensen  <achristensen@webkit.org>
718
719         [Content Extensions] Use less memory to store the json input.
720         https://bugs.webkit.org/show_bug.cgi?id=144604
721
722         Reviewed by Benjamin Poulain.
723
724         * MiniBrowser/mac/ExtensionManagerWindowController.m:
725         (-[ExtensionManagerWindowController add:]):
726         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
727         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
728         * WebKitTestRunner/mac/TestControllerMac.mm:
729         (WTR::TestController::platformConfigureViewForTest):
730
731 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
732
733         Unreviewed. Make myself a WebKit reviewer.
734
735         * Scripts/webkitpy/common/config/contributors.json:
736
737 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
738
739         [GTK] r183783 breaks build
740         https://bugs.webkit.org/show_bug.cgi?id=144632
741
742         Reviewed by Martin Robinson.
743
744         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
745
746         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
747         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
748
749 2015-05-05  Alex Christensen  <achristensen@webkit.org>
750
751         [Content Extensions] Combine NFAs properly and free memory as we compile.
752         https://bugs.webkit.org/show_bug.cgi?id=144485
753
754         Reviewed by Benjamin Poulain.
755
756         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
757         (TestWebKitAPI::TEST_F):
758         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
759         Added tests for deep NFAs.
760
761 2015-05-04  Alex Christensen  <achristensen@webkit.org>
762
763         [Content Extensions] Use less memory when writing byte code to file
764         https://bugs.webkit.org/show_bug.cgi?id=144602
765
766         Reviewed by Darin Adler.
767
768         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
769
770 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
771
772         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
773         https://bugs.webkit.org/show_bug.cgi?id=144541
774
775         Reviewed by Žan Doberšek.
776
777         Add a test case to WorkQueue unit test, to check that sources of
778         asynchronous IO operations running in the WorkQueue thread are
779         dispatched by the WorkQueue main loop.
780
781         * TestWebKitAPI/PlatformGTK.cmake:
782         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
783         (TestWebKitAPI::TEST):
784
785 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
786
787         Correct '--show-webview' option for Tiled Drawing tests
788         https://bugs.webkit.org/show_bug.cgi?id=144621
789
790         Reviewed by Simon Fraser.
791
792         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
793         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
794
795         * WebKitTestRunner/mac/TestControllerMac.mm:
796         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
797         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
798
799 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
800
801         Large array shouldn't be slow
802         https://bugs.webkit.org/show_bug.cgi?id=144617
803
804         Reviewed by Geoffrey Garen.
805         
806         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
807         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
808         long-running. So, hash-map sort of belongs here.
809
810         * Scripts/run-jsc-benchmarks:
811
812 2015-05-04  Doug Russell  <d_russell@apple.com>
813
814         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
815         https://bugs.webkit.org/show_bug.cgi?id=144489
816
817         Reviewed by Chris Fleizach.
818
819         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
820         on the returned control.
821         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
822         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
823         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
824         Add support for setSelectedVisibleTextRange() in accessibility tests.
825
826         * DumpRenderTree/AccessibilityUIElement.cpp:
827         (setSelectedVisibleTextRangeCallback):
828         (AccessibilityUIElement::setSelectedVisibleTextRange):
829         (AccessibilityUIElement::getJSClass):
830         (AccessibilityUIElement::textMarkerForIndex): Deleted.
831         * DumpRenderTree/AccessibilityUIElement.h:
832         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
833         (AccessibilityUIElement::setSelectedVisibleTextRange):
834         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
835         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
836         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
837         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
838         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
839         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
840         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
841         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
842         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
843         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
844         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
845
846 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
847
848         [Win] Implement the "--show-webview" option for Windows
849         https://bugs.webkit.org/show_bug.cgi?id=144589
850
851         Reviewed by Alex Christensen.
852
853         Add another runtime flag (--show-webview) that causes DumpRenderTree
854         to draw its view on-screen, rather than the standard offscreen mode.
855
856         * DumpRenderTree/win/DumpRenderTree.cpp:
857         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
858         (initializeGlobalsFromCommandLineOptions): Recognize the new
859         command-line argument, and set the global 'showWebView' state if
860         appropriate.
861
862 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
863
864         Remove dead code from TestInvocationCairo.cpp
865         https://bugs.webkit.org/show_bug.cgi?id=144564
866
867         Reviewed by Gyuyoung Kim.
868
869         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
870
871         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
872         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
873
874 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
875
876         [GTK] Add libnotify in gtk install-dependencies
877         https://bugs.webkit.org/show_bug.cgi?id=144379
878
879         Reviewed by Csaba Osztrogonác.
880
881         * gtk/install-dependencies:
882
883 2015-05-01  Dan Bernstein  <mitz@apple.com>
884
885         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
886         https://bugs.webkit.org/show_bug.cgi?id=144501
887
888         Reviewed by Darin Adler.
889
890         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
891         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
892         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
893         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
894
895 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
896
897         check-webkit-style fails due to system pylint
898         https://bugs.webkit.org/show_bug.cgi?id=144360
899
900         Reviewed by Darin Adler.
901
902         Make sure that the directory containing third party autoinstalled modules
903         is at the beginning of the search path, to avoid conflicts with other
904         versions of the same modules installed in the system (e.g. pylint).
905
906         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
907         modules directory to sys.path, instead of appending it.
908
909 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
910
911         Unreviewed, updated my list of email addresses.
912
913         * Scripts/webkitpy/common/config/contributors.json: Updated.
914
915 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
916
917         USE(...) macro should expect unprefixed variables
918         https://bugs.webkit.org/show_bug.cgi?id=144454
919
920         Reviewed by Daniel Bates.
921
922         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
923         * DumpRenderTree/config.h: Ditto.
924         * TestWebKitAPI/config.h: Ditto.
925
926 2015-05-01  Basile Clement  <basile_clement@apple.com>
927
928         Unreviewed. Add myself as a commiter in contributors.json.
929
930         * Scripts/webkitpy/common/config/contributors.json:
931
932 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
933
934         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
935         https://bugs.webkit.org/show_bug.cgi?id=144487
936
937         Reviewed by Ryosuke Niwa.
938
939         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
940         (BenchmarkRunner.merge): Fix bug.
941         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
942
943 2015-05-01  Brady Eidson  <beidson@apple.com>
944
945         Add API to disable meta refreshes.
946         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
947
948         Reviewed by Alexey Proskuryakov.
949
950         * DumpRenderTree/mac/DumpRenderTree.mm:
951         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
952
953 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
954
955         Provide a runtime flag to run-webkit-tests that shows the test view
956         https://bugs.webkit.org/show_bug.cgi?id=144079.
957
958         Unreviewed correction to r183651.
959
960         * WebKitTestRunner/TestController.cpp:
961         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
962         flag is included in the options dictionary passed to the PlatformWebView.
963
964 2015-05-01  Antti Koivisto  <antti@apple.com>
965
966         Remove network process load serialization code
967         https://bugs.webkit.org/show_bug.cgi?id=144448
968
969         Reviewed by Alexey Proskuryakov.
970
971         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
972         (WTR::InjectedBundle::beginTesting):
973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
974         (WTR::TestRunner::setSerializeHTTPLoads):
975         (WTR::TestRunner::dispatchPendingLoadRequests):
976
977 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
978
979         [GTK] Add libhyphen-dev to the build dependencies
980         https://bugs.webkit.org/show_bug.cgi?id=144452
981
982         Reviewed by Martin Robinson.
983
984         * gtk/install-dependencies: Added hyphen as Fedora and Arch
985         dependencies.
986
987 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
988
989         Provide a runtime flag to run-webkit-tests that shows the test view
990         https://bugs.webkit.org/show_bug.cgi?id=144079.
991
992         Reviewed by Dean Jackson.
993
994         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
995         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
996         option:
997         
998         --additional-drt-flag="--show-webview"
999
1000         * DumpRenderTree/mac/DumpRenderTree.mm:
1001         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
1002         '--show-webview' flag.
1003         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
1004         * WebKitTestRunner/Options.cpp:
1005         (WTR::Options::Options):
1006         (WTR::handleOptionShowWebView):
1007         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
1008         * WebKitTestRunner/Options.h:
1009         * WebKitTestRunner/TestController.cpp:
1010         (WTR::TestController::TestController):
1011         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
1012         * WebKitTestRunner/TestController.h:
1013         (WTR::TestController::shouldShowWebView):
1014         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1015         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
1016         options dictionary. If it is true, display the web view while running the test.
1017
1018 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
1019
1020         r183355 didn't trigger Mac tests
1021         https://bugs.webkit.org/show_bug.cgi?id=144464
1022
1023         Reviewed by Simon Fraser.
1024
1025         Update badly neglected filters and unit tests.
1026
1027         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1028         (_should_file_trigger_build):
1029         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1030         (ShouldBuildTest):
1031         (ShouldBuildTest.test_should_build):
1032
1033 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1034
1035         [GTK] Add libhyphen-dev to the build dependencies
1036         https://bugs.webkit.org/show_bug.cgi?id=144452
1037
1038         Reviewed by Martin Robinson.
1039
1040         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
1041         build dependencies.
1042
1043 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
1044
1045         [GTK] Testing dictionaries are not installed automatically
1046         https://bugs.webkit.org/show_bug.cgi?id=144460
1047
1048         Reviewed by Carlos Garcia Campos.
1049
1050         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
1051
1052 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
1053
1054         Fix return code issue, check return code of safari process and dump results to log
1055         https://bugs.webkit.org/show_bug.cgi?id=144436
1056
1057         Reviewed by Ryosuke Niwa.
1058
1059         * Scripts/run-benchmark:
1060         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1061         (BenchmarkRunner.dump): Correct typo.
1062         (BenchmarkRunner.wrap): Add results to console.
1063         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
1064         (OSXSafariDriver.prepareEnv):
1065         (OSXSafariDriver.launchUrl):
1066         (OSXSafariDriver.closeBrowsers):
1067
1068 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
1069
1070         Should no longer need to worry about very old versions of Xcode
1071         https://bugs.webkit.org/show_bug.cgi?id=144437
1072
1073         Reviewed by Dan Bernstein.
1074
1075         * Scripts/check-for-exit-time-destructors:
1076         * Scripts/check-for-global-initializers:
1077         * Scripts/check-for-weak-vtables-and-externals:
1078
1079 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
1080
1081         REGRESSION(183583): [Mac] make without SDKROOT has issues
1082         https://bugs.webkit.org/show_bug.cgi?id=144431
1083
1084         Reviewed by Dan Bernstein.
1085
1086         * Makefile:
1087         * WebKitTestRunner/Makefile:
1088         Assume an empty SDKROOT means an macosx variant, so only
1089         enable settings if the SDKROOT is not empty and does not
1090         contain "macosx".
1091
1092 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
1093
1094         Expand test infrastructure to support scrolling tests
1095         https://bugs.webkit.org/show_bug.cgi?id=143684
1096         <rdar://problem/20375516>
1097
1098         Reviewed by Simon Fraser.
1099
1100         * DumpRenderTree/mac/DumpRenderTree.mm:
1101         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
1102         reset before the next test run.
1103         * WebKitTestRunner/TestController.cpp:
1104         (WTR::TestController::resetStateToConsistentValues): Ditto."
1105
1106 2015-04-29  Alex Christensen  <achristensen@webkit.org>
1107
1108         Run javascriptcore tests on Windows without cygwin
1109         https://bugs.webkit.org/show_bug.cgi?id=144419
1110
1111         Reviewed by Brent Fulgham.
1112
1113         * Scripts/run-javascriptcore-tests:
1114         (runJSCStressTests):
1115         Just call ruby, not /usr/bin/env ruby.
1116
1117 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
1118
1119         [GTK] Add --enable-shared option to LLVM to build mesa
1120         https://bugs.webkit.org/show_bug.cgi?id=144393
1121
1122         Reviewed by Martin Robinson.
1123
1124         The updated mesa requires the shared LLVM libraries.
1125         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
1126         to LLVM configure script. It will provide shared libraries in addition to static libraries.
1127
1128         * gtk/jhbuild-optional.modules:
1129
1130 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
1131
1132         [GTK] Add support for automatic hyphenation
1133         https://bugs.webkit.org/show_bug.cgi?id=44478
1134
1135         Reviewed by Carlos Garcia Campos.
1136
1137         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
1138         all systems will use the same dictionaries for testing purposes.
1139
1140 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
1141
1142         Failure when building WebKit for appletvsimulator.
1143         https://bugs.webkit.org/show_bug.cgi?id=144356
1144
1145         Reviewed by Alexey Proskuryakov.
1146
1147         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
1148         make TVOS and WatchOS behave correctly.
1149
1150         * Makefile:
1151         * WebKitTestRunner/Makefile:
1152
1153 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
1154
1155         Use-after-free when invalidating WKPageForceRepaint callback
1156         https://bugs.webkit.org/show_bug.cgi?id=144401
1157         rdar://problem/20741111
1158
1159         Reviewed by Tim Horton.
1160
1161         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
1162
1163         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
1164         Don't do anything on error, because the context may be a stale pointer now.
1165
1166 2015-04-29  David Kilzer  <ddkilzer@apple.com>
1167
1168         check-webkit-style: Don't complain about returning value from Objective-C method call in header
1169         <http://webkit.org/b/144395>
1170
1171         Reviewed by Andy Estes.
1172
1173         * Scripts/webkitpy/style/checkers/cpp.py:
1174         (check_spacing): Update regex so 'return' is ignored if it
1175         precedes the whitespace and bracket.  Change category name to
1176         'whitespace/brackets'.  Add period to error message.
1177         (CppChecker): Add 'whitespace/brackets' as a category.
1178         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1179         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
1180         'CppChecker.categories' since that's where the list lives now.
1181         (CppStyleTest.test_spacing_before_brackets): Add tests for
1182         'whitespace/brackets' issues and non-issues.
1183
1184 2015-04-29  Alex Christensen  <achristensen@webkit.org>
1185
1186         Fix WinCairo bot.
1187
1188         * Scripts/webkitdirs.pm:
1189         (determinePassedConfiguration):
1190         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
1191
1192 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
1193
1194         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
1195         https://bugs.webkit.org/show_bug.cgi?id=132159
1196
1197         Reviewed by Darin Adler.
1198
1199         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
1200         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
1201
1202         * DumpRenderTree/mac/DumpRenderTree.mm:
1203         (fontWhitelist):
1204         (adjustFonts):
1205         (createWebViewAndOffscreenWindow):
1206         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1207         (WTR::activateFonts):
1208         * WebKitTestRunner/mac/TestControllerMac.mm:
1209         (WTR::allowedFontFamilySet):
1210         (WTR::systemHiddenFontFamilySet):
1211         (WTR::generateWhitelist):
1212         (WTR::TestController::platformInitializeContext):
1213
1214 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
1215
1216         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
1217         https://bugs.webkit.org/show_bug.cgi?id=144155
1218
1219         Reviewed by Andreas Kling.
1220
1221         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
1222         Make sure that test window is "visible" before each test. While there is no concrete
1223         evidence that this is the problem indeed, the behavior is consistent with what would
1224         happen for an invisible window. Also, WKTR obviously needs to do this to protect
1225         against potential buggy tests that hide the window and don't show it.
1226
1227 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1228
1229         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
1230
1231         Latest changes in the inspector UI made this test fail. We were
1232         relying that the sidebar was always visible and the first 'li'
1233         element of the inspector was the one containing the title. This is
1234         no longer true, so better use document title that is not likely
1235         to change.
1236
1237         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1238         (openRemoteDebuggingSession):
1239
1240 2015-04-29  Andres Gomez  <agomez@igalia.com>
1241
1242         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
1243
1244         * Scripts/webkitpy/common/config/contributors.json:
1245
1246 2015-04-29  Andres Gomez  <agomez@igalia.com>
1247
1248         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
1249
1250         * Scripts/webkitpy/common/config/watchlist:
1251
1252 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
1253
1254         [EFL] Allow to run the tests on the native X display
1255         https://bugs.webkit.org/show_bug.cgi?id=144247
1256
1257         Reviewed by Gyuyoung Kim.
1258
1259         Added the USE_NATIVE_XDISPLAY option for the WTR.
1260         We can select the Xorg driver if environment variable is set up before running the tests.
1261
1262         * Scripts/webkitpy/port/efl.py:
1263         (EflPort._driver_class):
1264
1265 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
1266
1267         [GTK] Add libnotify-dev in gtk install-dependencies
1268         https://bugs.webkit.org/show_bug.cgi?id=144379
1269
1270         Reviewed by Žan Doberšek.
1271
1272         * gtk/install-dependencies:
1273
1274 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
1275
1276         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
1277         https://bugs.webkit.org/show_bug.cgi?id=143001
1278
1279         Reviewed by Gyuyoung Kim.
1280
1281         * WebKitTestRunner/TestController.cpp:
1282         (WTR::shouldUseFixedLayout):
1283
1284 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
1285
1286         Increase stablility of run-benchmark script
1287         https://bugs.webkit.org/show_bug.cgi?id=144361
1288
1289         Reviewed by Ryosuke Niwa.
1290
1291         * Scripts/run-benchmark:
1292         (main):
1293         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
1294         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1295         (GenericBenchmarkBuilder.clean):
1296         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
1297         (BenchmarkRunner.__init__):
1298         (BenchmarkRunner.execute):
1299         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1300         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
1301         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
1302         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
1303         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
1304         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
1305         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
1306         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1307         (HTTPServerDriver.fetchResult):
1308         (HTTPServerDriver):
1309         (HTTPServerDriver.killServer): Add kill server interface.
1310         (HTTPServerDriver.getReturnCode): Add get return code interface.
1311         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
1312         (SimpleHTTPServerDriver.serve):
1313         (SimpleHTTPServerDriver.fetchResult):
1314         (SimpleHTTPServerDriver):
1315         (SimpleHTTPServerDriver.killServer):
1316         (SimpleHTTPServerDriver.getReturnCode):
1317         * Scripts/webkitpy/benchmark_runner/utils.py:
1318         (forceRemove): Provide python version of 'rm -rf'.
1319
1320 2015-04-28  Sam Weinig  <sam@webkit.org>
1321
1322         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
1323         https://bugs.webkit.org/show_bug.cgi?id=144363
1324
1325         Reviewed by Alex Christensen.
1326
1327         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1328         (TestWebKitAPI::createNFAs):
1329         (TestWebKitAPI::TEST_F):
1330         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1331         (TestWebKitAPI::countLiveNodes):
1332         (TestWebKitAPI::createNFAs):
1333         (TestWebKitAPI::buildDFAFromPatterns):
1334         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
1335
1336 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1337
1338         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
1339         https://bugs.webkit.org/show_bug.cgi?id=144304
1340
1341         Reviewed by Geoffrey Garen.
1342
1343         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
1344         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
1345         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1346
1347 2015-04-28  Commit Queue  <commit-queue@webkit.org>
1348
1349         Unreviewed, rolling out r183514.
1350         https://bugs.webkit.org/show_bug.cgi?id=144359
1351
1352         It broke cloop test bots (Requested by mcatanzaro on #webkit).
1353
1354         Reverted changeset:
1355
1356         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
1357         https://bugs.webkit.org/show_bug.cgi?id=144304
1358         http://trac.webkit.org/changeset/183514
1359
1360 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1361
1362         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
1363         https://bugs.webkit.org/show_bug.cgi?id=144304
1364
1365         Reviewed by Geoffrey Garen.
1366
1367         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
1368         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
1369         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
1370         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
1371
1372 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1373
1374         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
1375         https://bugs.webkit.org/show_bug.cgi?id=144319
1376
1377         Reviewed by Csaba Osztrogonác.
1378
1379         * TestWebKitAPI/CMakeLists.txt:
1380         * TestWebKitAPI/PlatformEfl.cmake:
1381
1382 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
1383
1384         Fix common typo "targetting" => "targeting"
1385         https://bugs.webkit.org/show_bug.cgi?id=144349
1386
1387         Reviewed by Daniel Bates.
1388
1389         * Scripts/webkitdirs.pm:
1390         (execMacWebKitAppForDebugging):
1391
1392 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1393
1394         [GTK][jhbuild] Mesa build failure with llvm 3.6
1395         https://bugs.webkit.org/show_bug.cgi?id=144250
1396
1397         Reviewed by Žan Doberšek.
1398
1399         Bump the version of Mesa to 10.5.4
1400
1401         * gtk/jhbuild.modules:
1402
1403 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
1404
1405         Disable App Nap in WebKitTestRunner UI process
1406         https://bugs.webkit.org/show_bug.cgi?id=144308
1407
1408         Reviewed by Daniel Bates.
1409
1410         * WebKitTestRunner/mac/main.mm:
1411         (disableAppNapInUIProcess):
1412         (main):
1413
1414 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1415
1416         [GTK] Update JHBuild Mesa download directory
1417         https://bugs.webkit.org/show_bug.cgi?id=144318
1418
1419         Update the download directory of Mesa module since the previous one
1420         doesn't exist any more.
1421
1422         Reviewed by Žan Doberšek.
1423
1424         * gtk/jhbuild.modules:
1425
1426 2015-04-28  Commit Queue  <commit-queue@webkit.org>
1427
1428         Unreviewed, rolling out r183477.
1429         https://bugs.webkit.org/show_bug.cgi?id=144334
1430
1431         Roll back the Mesa dependency bump in fear of uncaught
1432         regressions while the testing bots are no-op. (Requested by
1433         zdobersek on #webkit).
1434
1435         Reverted changeset:
1436
1437         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
1438         https://bugs.webkit.org/show_bug.cgi?id=144250
1439         http://trac.webkit.org/changeset/183477
1440
1441 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
1442
1443         [GTK][jhbuild] Mesa build failure with llvm 3.6
1444         https://bugs.webkit.org/show_bug.cgi?id=144250
1445
1446         Reviewed by Žan Doberšek.
1447
1448         Bump the version of Mesa to 10.5.4
1449
1450         * gtk/jhbuild.modules:
1451
1452 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
1453
1454         Add '__init__.py' and fix known bug in benchmark runner.
1455         https://bugs.webkit.org/show_bug.cgi?id=144296
1456
1457         Reviewed by Ryosuke Niwa
1458
1459         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
1460         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
1461         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1462         (BenchmarkRunner.__init__):
1463         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
1464         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
1465         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
1466
1467 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1468
1469         More build fix.
1470
1471         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1472         (-[AccessibilityNotificationHandler _notificationReceived:]):
1473         Use -objectForKey:, not array subscript.
1474
1475 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1476
1477         Catch unexpected exits in DumpRenderTree
1478         https://bugs.webkit.org/show_bug.cgi?id=144288
1479
1480         Reviewed by Tim Horton.
1481
1482         * DumpRenderTree/mac/DumpRenderTree.mm:
1483         (atexitFunction):
1484         (DumpRenderTreeMain):
1485
1486 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1487
1488         Build fix
1489
1490         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1491         (-[AccessibilityNotificationHandler _notificationReceived:]):
1492         Use -objectForKey:, not array subscript.
1493
1494 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
1495
1496         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
1497         https://bugs.webkit.org/show_bug.cgi?id=144155
1498
1499         Reviewed by Tim Horton.
1500
1501         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1502         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
1503         and we clearly don't want App Nap while testing.
1504
1505 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
1506
1507         [CMake] Autogenerate cmakeconfig.h.cmake
1508         https://bugs.webkit.org/show_bug.cgi?id=143997
1509
1510         Reviewed by Csaba Osztrogonác.
1511
1512         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
1513         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
1514
1515 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
1516
1517         REGRESSION(r182879): Images and video can no longer be downloaded
1518         https://bugs.webkit.org/show_bug.cgi?id=144267
1519         <rdar://problem/20702844>
1520
1521         Reviewed by Simon Fraser.
1522
1523         Revise tests to check for proper download menu state.
1524         1. Downloading a loal image should be disabled.
1525         2. Downloading a local media file should be disabled.
1526         3. Downloading non-downloadable media should be disabled.
1527
1528         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1529         (TestWebKitAPI::TEST):
1530
1531 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1532
1533         Merge run-launcher into run-minibrowser
1534         https://bugs.webkit.org/show_bug.cgi?id=141928
1535
1536         Reviewed by Darin Adler.
1537
1538         * Scripts/run-iexploder-tests:
1539         (runSafariWithIExploder):
1540         * Scripts/run-launcher: Removed.
1541         * Scripts/run-minibrowser:
1542         * Scripts/webkitdirs.pm:
1543         (launcherPath):
1544         * Scripts/webkitpy/port/efl.py:
1545         (EflPort.show_results_html_file):
1546         * Scripts/webkitpy/port/efl_unittest.py:
1547         (EflPortTest.test_show_results_html_file):
1548         * Scripts/webkitpy/port/gtk.py:
1549         (GtkPort.print_leaks_summary):
1550         (GtkPort.show_results_html_file):
1551         (GtkPort): Deleted.
1552         * Scripts/webkitpy/port/gtk_unittest.py:
1553         (GtkPortTest.test_show_results_html_file):
1554
1555 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1556
1557         [buildbot] Fix the output of perf-test buildstep on timeout
1558         https://bugs.webkit.org/show_bug.cgi?id=144097
1559
1560         Reviewed by Ryosuke Niwa.
1561
1562         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1563         (RunAndUploadPerfTests.getText2):
1564         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1565         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
1566         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
1567
1568 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
1569
1570         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
1571         https://bugs.webkit.org/show_bug.cgi?id=143874
1572
1573         Reviewed by Gyuyoung Kim.
1574
1575         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
1576
1577 2015-04-24  Philippe Normand  <pnormand@igalia.com>
1578
1579         [JHBuild] Move to upstream OpenWebRTC
1580         https://bugs.webkit.org/show_bug.cgi?id=144145
1581
1582         Reviewed by Carlos Garcia Campos.
1583
1584         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
1585         and add a new simple patch to gst-plugins-base, required for
1586         OpenWebRTC build.
1587         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1588         * gtk/jhbuild.modules: Ditto.
1589         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
1590
1591 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1592
1593         [ES6] Implement ES6 template literals
1594         https://bugs.webkit.org/show_bug.cgi?id=142691
1595
1596         Reviewed by Darin Adler.
1597
1598         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
1599
1600         * Scripts/webkitperl/FeatureList.pm:
1601
1602 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1603
1604         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
1605         https://bugs.webkit.org/show_bug.cgi?id=144217
1606
1607         Reviewed by Darin Adler.
1608
1609         * WebKitTestRunner/PlatformEfl.cmake:
1610
1611 2015-04-26  Doug Russell  <d_russell@apple.com>
1612
1613         AX: richer text change notifications (142719)
1614         https://bugs.webkit.org/show_bug.cgi?id=142719
1615
1616         Reviewed by Darin Adler.
1617
1618         Richer accessibility value change notifications. Introduce AXTextEditType,
1619         postTextStateChangeNotification and postTextReplacementNotification to give assistive
1620         tech apps more reliable context for responding to changes in web content. Also implement
1621         a mechanism to post value changes in password form fields in coalesced ticks to thwart
1622         analyzing the cadence of changes.
1623
1624         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
1625         and an overload of postTextReplacementNotification to give assistive tech apps more
1626         reliable context for responding to changes in web content selection. Also block posting
1627         selection changes on password fields.
1628
1629         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1630         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1631         (-[AccessibilityNotificationHandler stopObserving]):
1632         (-[AccessibilityNotificationHandler _notificationReceived:]):
1633         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1634         (AccessibilityUIElement::removeNotificationListener):
1635         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1636         (-[AccessibilityNotificationHandler _notificationReceived:]):
1637         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1638         (WTR::AccessibilityUIElement::removeNotificationListener):
1639
1640 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
1641
1642         Add myself to contributors.json
1643         https://bugs.webkit.org/show_bug.cgi?id=144204
1644
1645         Reviewed by Darin Adler.
1646
1647         * Scripts/webkitpy/common/config/contributors.json:
1648
1649 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
1650
1651         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
1652         https://bugs.webkit.org/show_bug.cgi?id=144182
1653
1654         Reviewed by Simon Fraser.
1655
1656         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
1657
1658 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
1659
1660         https://bugs.webkit.org/show_bug.cgi?id=144038
1661
1662         Reviewed by Ryosuke Niwa
1663
1664         Add a script to run Speedometer and JetStream on a browser.
1665
1666         * Scripts/run-benchmark: Wrapper script to run benchmark.
1667         (main):
1668         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
1669         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
1670         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
1671         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
1672         (BenchmarkBuilderFactory):
1673         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
1674         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
1675         (GenericBenchmarkBuilder):
1676         (GenericBenchmarkBuilder.prepare):
1677         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
1678         (GenericBenchmarkBuilder._applyPatch):
1679         (GenericBenchmarkBuilder.clean):
1680         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
1681         (JetStreamBenchmarkBuilder):
1682         (JetStreamBenchmarkBuilder.prepare):
1683         (JetStreamBenchmarkBuilder._runCreateScript):
1684         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
1685         (BenchmarkRunner):
1686         (BenchmarkRunner.__init__):
1687         (BenchmarkRunner.execute):
1688         (BenchmarkRunner.dump):
1689         (BenchmarkRunner.wrap):
1690         (BenchmarkRunner.merge):
1691         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
1692         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
1693         (BrowserDriver):
1694         (BrowserDriver.prepareEnv):
1695         (BrowserDriver.launchUrl):
1696         (BrowserDriver.closeBrowser):
1697         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
1698         (BrowserDriverFactory):
1699         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
1700         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
1701         (OSXChromeDriver):
1702         (OSXChromeDriver.prepareEnv):
1703         (OSXChromeDriver.launchUrl):
1704         (OSXChromeDriver.closeBrowsers):
1705         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
1706         (OSXSafariDriver):
1707         (OSXSafariDriver.prepareEnv):
1708         (OSXSafariDriver.launchUrl):
1709         (OSXSafariDriver.closeBrowsers):
1710         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
1711         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
1712         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
1713         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
1714         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
1715         (GenericFactory):
1716         (GenericFactory.iterateGetItem):
1717         (GenericFactory.create):
1718         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
1719         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
1720         (ServerControl):
1721         (ServerControl.render_GET):
1722         (ServerControl.render_POST):
1723         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
1724         (HTTPServerDriver):
1725         (HTTPServerDriver.serve):
1726         (HTTPServerDriver.fetchResult):
1727         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
1728         (HTTPServerDriverFactory):
1729         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
1730         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
1731         (SimpleHTTPServerDriver):
1732         (SimpleHTTPServerDriver.depends):
1733         (SimpleHTTPServerDriver.__init__):
1734         (SimpleHTTPServerDriver.serve):
1735         (SimpleHTTPServerDriver.baseUrl):
1736         (SimpleHTTPServerDriver.fetchResult):
1737         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
1738         (ModuleNotFoundError):
1739         (loadModule):
1740         (getPathFromProjectRoot):
1741         (loadJSONFromFile):
1742         (TimeoutError):
1743         (timeout):
1744         (timeout.__init__):
1745         (timeout.handle_timeout):
1746         (timeout.__enter__):
1747         (timeout.__exit__):
1748
1749 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1750
1751         Unreviewed, rolling out r183303.
1752         https://bugs.webkit.org/show_bug.cgi?id=144181
1753
1754         Change was incorrect, broke builds (Requested by smfr on
1755         #webkit).
1756
1757         Reverted changeset:
1758
1759         "Fix the build."
1760         http://trac.webkit.org/changeset/183303
1761
1762 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
1763
1764         Fix the build.
1765
1766         * MiniBrowser/mac/WK2BrowserWindowController.m:
1767         (-[WK2BrowserWindowController initWithConfiguration:]):
1768
1769 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1770
1771         Disable ActionMenusPDFTest due to timeout on test bot
1772
1773         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1774         (TestWebKitAPI::TEST):
1775
1776 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1777
1778         Unreviewed, rolling out r183266.
1779         https://bugs.webkit.org/show_bug.cgi?id=144164
1780
1781         Broke 32-bit build and a test. (Requested by ap on #webkit).
1782
1783         Reverted changeset:
1784
1785         "AX: richer text change notifications (142719)"
1786         https://bugs.webkit.org/show_bug.cgi?id=142719
1787         http://trac.webkit.org/changeset/183266
1788
1789 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1790
1791         REGRESSION: WebKit2.ActionMenusTest API test fails
1792         https://bugs.webkit.org/show_bug.cgi?id=144149
1793         <rdar://problem/20677770>
1794
1795         Reviewed by Tim Horton.
1796
1797         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
1798         as the 'ActionMenusPDFTest'.
1799         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1800         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
1801         to match the hit test on the 'action-menu-target.pdf' test file.
1802
1803 2015-04-24  Daniel Bates  <dabates@apple.com>
1804
1805         Cleanup: Use @memoized for property IOSSimulator.testing_device
1806         https://bugs.webkit.org/show_bug.cgi?id=141715
1807
1808         Reviewed by Darin Adler.
1809
1810         Simplify the caching of the result of IOSSimulator.testing_device
1811         and make the code more readable by making use of the @memoized declarator
1812         instead of explicitly managing a private instance variable,
1813         IOSSimulator._testing_device, for the cached result.
1814
1815         * Scripts/webkitpy/port/ios.py:
1816         (IOSPort.determine_full_port_name):
1817         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
1818         (IOSSimulatorPort):
1819         (IOSSimulatorPort.testing_device): No need to cache the created device object in
1820         IOSSimulatorPort._testing_device since we are marking this function @memoized.
1821         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
1822         of caching in local variable since we only make use of this value exactly once in this function.
1823         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
1824         been used since being added in r178622. So, we can remove this constructor since
1825         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
1826
1827 2015-04-24  Anders Carlsson  <andersca@apple.com>
1828
1829         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
1830         https://bugs.webkit.org/show_bug.cgi?id=144158
1831
1832         Reviewed by Beth Dakin.
1833
1834         * MiniBrowser/mac/WK2BrowserWindowController.m:
1835         (-[WK2BrowserWindowController initWithConfiguration:]):
1836
1837 2015-04-24  Doug Russell  <d_russell@apple.com>
1838
1839         AX: richer text change notifications (142719)
1840         https://bugs.webkit.org/show_bug.cgi?id=142719
1841
1842         Reviewed by Darin Adler.
1843
1844         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
1845
1846         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
1847
1848         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1849         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1850         (-[AccessibilityNotificationHandler stopObserving]):
1851         (-[AccessibilityNotificationHandler _notificationReceived:]):
1852         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1853         (AccessibilityUIElement::removeNotificationListener):
1854         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1855         (-[AccessibilityNotificationHandler _notificationReceived:]):
1856         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1857         (WTR::AccessibilityUIElement::removeNotificationListener):
1858
1859 2015-04-24  Darin Adler  <darin@apple.com>
1860
1861         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
1862         https://bugs.webkit.org/show_bug.cgi?id=128007
1863
1864         Reviewed by Anders Carlsson.
1865
1866         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
1867         * DumpRenderTree/win/UIDelegate.h: Ditto.
1868
1869         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
1870         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1871
1872         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
1873
1874         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
1875         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
1876         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
1877         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
1878         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1879         (WebKitDOMDOMWindowTest::create): Ditto.
1880         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1881         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
1882         of smart pointers to DelayedSIgnal objects.
1883         (uriChangedCallback): Ditto.
1884
1885 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1886
1887         [Mac] Unreviewed test fix.
1888         https://bugs.webkit.org/show_bug.cgi?id=144149
1889
1890         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1891         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
1892         test.
1893
1894 2015-04-23  Darin Adler  <darin@apple.com>
1895
1896         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
1897         https://bugs.webkit.org/show_bug.cgi?id=144090
1898
1899         Reviewed by Anders Carlsson.
1900
1901         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
1902
1903 2015-04-23  Michael Saboff  <msaboff@apple.com>
1904
1905         lldb macro btjs sometimes can't get a frame description
1906         https://bugs.webkit.org/show_bug.cgi?id=144130
1907
1908         Reviewed by Filip Pizlo.
1909
1910         We look to execute ExecState::describeFrame().  It appears that in some contexts the
1911         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
1912         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
1913
1914         * lldb/lldb_webkit.py:
1915         (btjs):
1916
1917 2015-04-23  Alex Christensen  <achristensen@webkit.org>
1918
1919         Use less memory when compiling content extensions.
1920         https://bugs.webkit.org/show_bug.cgi?id=144051
1921
1922         Reviewed by Darin Adler and Benjamin Poulain.
1923
1924         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1925         (TestWebKitAPI::TEST_F):
1926         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1927         (TestWebKitAPI::countLiveNodes):
1928
1929 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1930
1931         [CMake] Clean up JSC JIT options
1932         https://bugs.webkit.org/show_bug.cgi?id=143998
1933
1934         Reviewed by Filip Pizlo.
1935
1936         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
1937         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
1938
1939 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
1940
1941         [Mac] Extend action menus to support PDF
1942         https://bugs.webkit.org/show_bug.cgi?id=143895
1943         <rdar://problem/19003333>
1944
1945         Reviewed by Tim Horton.
1946
1947         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
1948         of PDF content works.
1949
1950         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
1951         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
1952         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
1953         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1954         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1955         Update to support PDF tests.
1956         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
1957         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
1958
1959 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1960
1961         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
1962
1963         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1964         (beforeAll):
1965         (testWebViewAudioOnlyUserMediaPermissionRequests):
1966
1967 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1968
1969         Add myself to watchlist
1970         https://bugs.webkit.org/show_bug.cgi?id=144041
1971
1972         Reviewed by Alex Christensen.
1973
1974         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
1975
1976         * Scripts/webkitpy/common/config/watchlist:
1977
1978 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1979
1980         [GTK] MiniBrowser should use NetworkProcess by default
1981         https://bugs.webkit.org/show_bug.cgi?id=143948
1982
1983         Reviewed by Sergio Villar Senin.
1984
1985         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
1986         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
1987
1988         * MiniBrowser/gtk/main.c:
1989         (main):
1990
1991 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
1992
1993         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
1994
1995         Unreviewed build fix.
1996
1997         * Scripts/prepare-ChangeLog:
1998         (get_function_line_ranges_for_cpp):
1999         Use grep instead of any to determine if a string is an element of an array.
2000
2001 2015-04-21  Anders Carlsson  <andersca@apple.com>
2002
2003         Fix block signatures
2004         https://bugs.webkit.org/show_bug.cgi?id=144002
2005
2006         Reviewed by Andreas Kling.
2007
2008         * MiniBrowser/mac/WK2BrowserWindowController.m:
2009         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2010
2011 2015-04-21  Philippe Normand  <pnormand@igalia.com>
2012
2013         [GTK] jhbuild should not use a branch for openwebrtc
2014         https://bugs.webkit.org/show_bug.cgi?id=143981
2015
2016         Reviewed by Carlos Garcia Campos.
2017
2018         * gtk/jhbuild.modules:
2019
2020 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
2021
2022         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
2023
2024         Unreviewed build fix.
2025
2026         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
2027         However, it has been exposed by List::MoreUtils since its inception. This patch uses
2028         the any function exposed by List::MoreUtils for greater compatibility.
2029
2030         * Scripts/prepare-ChangeLog:
2031         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
2032         the any function in all of versions of Perl used by our infrastructure.
2033
2034 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2035
2036         Remove unnecessary logs when resetting tests.
2037
2038         * WebKitTestRunner/mac/TestControllerMac.mm:
2039         (WTR::TestController::platformResetPreferencesToConsistentValues):
2040         In r183020 I added some logs when compiling or removing content extensions fails.
2041         We often try to remove a content extension that does not exist, and that is not a problem.
2042
2043 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
2044
2045         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
2046         https://bugs.webkit.org/show_bug.cgi?id=143897
2047
2048         Reviewed by David Kilzer.
2049
2050         This is a speculative fix that addresses two issues:
2051
2052         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
2053         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
2054
2055         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
2056         Before: (723, 729)
2057         After: (721, 720)
2058
2059         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
2060         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
2061
2062         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
2063         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
2064
2065         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
2066
2067         2. Creating git diffs from HEAD and not origin/master by default.
2068
2069         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
2070         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
2071
2072         * Scripts/prepare-ChangeLog:
2073         (originalFile):
2074         Use HEAD instead of origin/master in default Git case.
2075
2076         (generateFunctionLists):
2077         Ensure that the end line is not less than the start line.
2078
2079         (extractLineRangeAfterChange):
2080         Set the end line to the start line if the end line is less than the start line.
2081
2082         (extractLineRangeBeforeChange):
2083         Ditto.
2084
2085 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
2086
2087         Suppress warning in prepare-ChangeLog.
2088         https://bugs.webkit.org/show_bug.cgi?id=143882
2089
2090         Reviewed by David Kilzer.
2091
2092         Prune noisy prepare-ChangeLog output by using the List::Util::any function
2093         instead of the deprecated smartmatch operator.
2094
2095         * Scripts/prepare-ChangeLog:
2096         Import the List::Util::any function.
2097
2098         (get_function_line_ranges_for_cpp):
2099         Use the any function instead of smartmatch.
2100
2101 2015-04-20  Anders Carlsson  <andersca@apple.com>
2102
2103         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
2104         https://bugs.webkit.org/show_bug.cgi?id=143966
2105
2106         Reviewed by Dan Bernstein.
2107
2108         * MiniBrowser/mac/WK2BrowserWindowController.m:
2109         (dataTypes):
2110         (-[WK2BrowserWindowController fetchWebsiteData:]):
2111         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2112         (-[WK2BrowserWindowController clearWebsiteData:]):
2113
2114 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2115
2116         Fix content extension test flakiness.
2117         https://bugs.webkit.org/show_bug.cgi?id=143950
2118
2119         Reviewed by Brady Eidson.
2120
2121         * WebKitTestRunner/mac/TestControllerMac.mm:
2122         (WTR::TestController::platformResetPreferencesToConsistentValues):
2123         Remove the TestContentExtensions if it exists.
2124         (WTR::TestController::platformConfigureViewForTest):
2125         Log errors in case there are any.
2126
2127 2015-04-20  Alex Christensen  <achristensen@webkit.org>
2128
2129         Properly report errors from _WKUserContentExtensionStore.
2130         https://bugs.webkit.org/show_bug.cgi?id=143808
2131
2132         Reviewed by Darin Adler.
2133
2134         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
2135         (TEST_F):
2136
2137 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2138
2139         Add a rule for NetworkCache to watchlist file
2140         https://bugs.webkit.org/show_bug.cgi?id=143945
2141
2142         Reviewed by Sergio Villar Senin.
2143
2144         And add myself to the list of watchers.
2145
2146         * Scripts/webkitpy/common/config/watchlist:
2147
2148 2015-04-19  Darin Adler  <darin@apple.com>
2149
2150         Update RefPtr documentation and deprecation
2151         https://bugs.webkit.org/show_bug.cgi?id=143936
2152
2153         Reviewed by Andreas Kling.
2154
2155         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
2156
2157 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2158
2159         Introduce bytecode intrinsics
2160         https://bugs.webkit.org/show_bug.cgi?id=143926
2161
2162         Reviewed by Filip Pizlo.
2163
2164         Change cpplint to accept emit_intrinsic_XXX.
2165
2166         * Scripts/webkitpy/style/checkers/cpp.py:
2167         (check_identifier_name_in_declaration):
2168
2169 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
2170
2171         Fix lldb_webkit.py to show StringImpls correctly
2172         https://bugs.webkit.org/show_bug.cgi?id=143920
2173
2174         Reviewed by Andreas Kling.
2175         
2176         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
2177
2178         * lldb/lldb_webkit.py:
2179         (WTFStringImplProvider.is_8bit):
2180
2181 2015-04-17  Daniel Bates  <dabates@apple.com>
2182
2183         Not able to build WebKit against iOS Simulator 8.3 SDK
2184         https://bugs.webkit.org/show_bug.cgi?id=143883
2185
2186         Reviewed by David Kilzer.
2187
2188         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
2189         so that Xcode uses them.
2190
2191         * Scripts/copy-webkitlibraries-to-product-directory:
2192
2193 2015-04-17  Beth Dakin  <bdakin@apple.com>
2194
2195         Force mouse events should go through normal mouse event handling code paths
2196         https://bugs.webkit.org/show_bug.cgi?id=143749
2197         -and corresponding-
2198         rdar://problem/20472895
2199
2200         Reviewed by Dean Jackson.
2201
2202         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
2203         Since there is not a way to create an NSEventTypePressure from scratch, we 
2204         subclass NSEvent and override all of the critical methods.
2205
2206         * WebKitTestRunner/EventSenderProxy.h:
2207         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2208         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2209         (WTR::EventSendingController::mouseForceDown):
2210         (WTR::EventSendingController::mouseForceUp):
2211         (WTR::EventSendingController::mouseForceChanged):
2212         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2213         * WebKitTestRunner/TestController.cpp:
2214         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2215         * WebKitTestRunner/mac/EventSenderProxy.mm:
2216         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2217         (-[EventSenderPressureEvent timestamp]):
2218         (-[EventSenderPressureEvent type]):
2219         (-[EventSenderPressureEvent locationInWindow]):
2220         (-[EventSenderPressureEvent location]):
2221         (-[EventSenderPressureEvent stage]):
2222         (-[EventSenderPressureEvent pressure]):
2223         (-[EventSenderPressureEvent phase]):
2224         (-[EventSenderPressureEvent eventNumber]):
2225         (WTR::EventSenderProxy::mouseForceDown):
2226         (WTR::EventSenderProxy::mouseForceUp):
2227         (WTR::EventSenderProxy::mouseForceChanged):
2228
2229 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
2230
2231         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
2232         https://bugs.webkit.org/show_bug.cgi?id=143885
2233
2234         Reviewed by Tim Horton.
2235
2236         Fixed a case where we have two builds with the same revision(s). An in order build
2237         is one for which the revision is strictly higher.
2238
2239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2240         (BuildbotQueue.prototype._checkForInOrderResult):
2241         (BuildbotQueue.prototype.compareIterationsByRevisions):
2242
2243 2015-04-17  Commit Queue  <commit-queue@webkit.org>
2244
2245         Unreviewed, rolling out r182912 and r182920.
2246         https://bugs.webkit.org/show_bug.cgi?id=143881
2247
2248         Build breakage in some configurations (Requested by ap on
2249         #webkit).
2250
2251         Reverted changesets:
2252
2253         "Force mouse events should go through normal mouse event
2254         handling code paths"
2255         https://bugs.webkit.org/show_bug.cgi?id=143749
2256         http://trac.webkit.org/changeset/182912
2257
2258         http://trac.webkit.org/changeset/182920
2259
2260 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
2261
2262         [GTK] One more unreviewed fix after r182882.
2263
2264         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
2265
2266 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
2267
2268         [GTK] Unreviewed speculative clean build fix after r182882.
2269
2270         TestWebKitAPI's forwarding header generator depended on WeKit2's
2271         which generated SOUP related forwarding headers too.
2272
2273         This dependency isn't necessary and was removed by r182882 to make
2274         forwarding header generators parallelizable. But in this case
2275         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
2276         should generate SOUP related forwarding headers too similar to EFL.
2277
2278         * TestWebKitAPI/PlatformGTK.cmake:
2279         * WebKitTestRunner/PlatformGTK.cmake:
2280
2281 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2282
2283         [SOUP] Redirect to non HTTP destination is broken
2284         https://bugs.webkit.org/show_bug.cgi?id=143866
2285
2286         Reviewed by Sergio Villar Senin.
2287
2288         Add a unit test to check that redirect to a data URI works.
2289
2290         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2291         (testRedirectToDataURI):
2292         (serverCallback):
2293         (beforeAll):
2294
2295 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
2296
2297         Changes method of quitting iOS Simulator to be more correct.
2298         https://bugs.webkit.org/show_bug.cgi?id=143847
2299         <rdar://problem/20530344>
2300
2301         Reviewed by Darin Adler.
2302
2303         Fixes by addressing the app by ID rather than by name.
2304
2305         * Scripts/webkitdirs.pm:
2306         (quitIOSSimulator):
2307         * Scripts/webkitpy/port/ios.py:
2308         (IOSSimulatorPort.check_sys_deps):
2309
2310 2015-04-16  Anders Carlsson  <andersca@apple.com>
2311
2312         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
2313         https://bugs.webkit.org/show_bug.cgi?id=143844
2314
2315         Reviewed by Dan Bernstein.
2316
2317         * MiniBrowser/mac/AppDelegate.m:
2318         (-[BrowserAppDelegate newPrivateWindow:]):
2319         * MiniBrowser/mac/WK2BrowserWindowController.m:
2320         (-[WK2BrowserWindowController initWithConfiguration:]):
2321         (-[WK2BrowserWindowController fetchWebsiteData:]):
2322         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2323         (-[WK2BrowserWindowController clearWebsiteData:]):
2324
2325 2015-04-16  Alex Christensen  <achristensen@webkit.org>
2326
2327         32-bit build fix.
2328
2329         * WebKitTestRunner/mac/TestControllerMac.mm:
2330         (WTR::TestController::platformResetPreferencesToConsistentValues):
2331         (WTR::TestController::platformConfigureViewForTest):
2332         Added WK_API_ENABLED.
2333
2334 2015-04-16  Alex Christensen  <achristensen@webkit.org>
2335
2336         Removed unused WKUserContentFilterRef.
2337         https://bugs.webkit.org/show_bug.cgi?id=143852
2338
2339         Reviewed by Sam Weinig.
2340
2341         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
2342         * WebKitTestRunner/mac/TestControllerMac.mm:
2343         (WTR::TestController::platformResetPreferencesToConsistentValues):
2344         (WTR::TestController::platformConfigureViewForTest):
2345
2346 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
2347
2348         Unreviewed. Adding myself as a commiter in contributers.json.
2349
2350         * Scripts/webkitpy/common/config/contributors.json:
2351
2352 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
2353
2354         It is very hard to attach a debugger to WebProcess to debug tests
2355         https://bugs.webkit.org/show_bug.cgi?id=143837
2356
2357         Reviewed by Chris Dumez.
2358
2359         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
2360         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
2361
2362         Now it disables all timeouts in tools, as is best for debugging tests.
2363
2364         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
2365         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
2366
2367         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
2368         now has the same functionality.
2369
2370 2015-04-16  Beth Dakin  <bdakin@apple.com>
2371
2372         Force mouse events should go through normal mouse event handling code paths
2373         https://bugs.webkit.org/show_bug.cgi?id=143749
2374         -and corresponding-
2375         rdar://problem/20472895
2376
2377         Reviewed by Dean Jackson.
2378
2379         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
2380         Since there is not a way to create an NSEventTypePressure from scratch, we 
2381         subclass NSEvent and override all of the critical methods.
2382
2383         * WebKitTestRunner/EventSenderProxy.h:
2384         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2385         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2386         (WTR::EventSendingController::mouseForceDown):
2387         (WTR::EventSendingController::mouseForceUp):
2388         (WTR::EventSendingController::mouseForceChanged):
2389         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2390         * WebKitTestRunner/TestController.cpp:
2391         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2392         * WebKitTestRunner/mac/EventSenderProxy.mm:
2393         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2394         (-[EventSenderPressureEvent timestamp]):
2395         (-[EventSenderPressureEvent type]):
2396         (-[EventSenderPressureEvent locationInWindow]):
2397         (-[EventSenderPressureEvent location]):
2398         (-[EventSenderPressureEvent stage]):
2399         (-[EventSenderPressureEvent pressure]):
2400         (-[EventSenderPressureEvent phase]):
2401         (-[EventSenderPressureEvent eventNumber]):
2402         (WTR::EventSenderProxy::mouseForceDown):
2403         (WTR::EventSenderProxy::mouseForceUp):
2404         (WTR::EventSenderProxy::mouseForceChanged):
2405
2406 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2407
2408         [EFL] Bump LLVM to version 3.6.0 on X86_64
2409         https://bugs.webkit.org/show_bug.cgi?id=143604
2410
2411         Reviewed by Gyuyoung Kim.
2412
2413         * efl/jhbuild.modules:
2414         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
2415         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
2416         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
2417         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
2418
2419 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2420
2421         [EFL] Remove an unnecessary workaround from jhbuildrc
2422         https://bugs.webkit.org/show_bug.cgi?id=143823
2423
2424         Reviewed by Gyuyoung Kim.
2425
2426         * efl/jhbuildrc:
2427
2428 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
2429
2430         [GTK] Run forwarding headers generator unconditionally
2431         https://bugs.webkit.org/show_bug.cgi?id=143819
2432
2433         Reviewed by Carlos Garcia Campos.
2434
2435         * TestWebKitAPI/PlatformGTK.cmake:
2436         * WebKitTestRunner/PlatformGTK.cmake:
2437
2438 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2439
2440         [EFL] Add gnutls to jhbuild.module
2441         https://bugs.webkit.org/show_bug.cgi?id=143777
2442
2443         Reviewed by Csaba Osztrogonác.
2444
2445         EFL port has required at least 3.0.0 version of gnutls since r176712.
2446         However some old linux distributions don't support 3.0.0 version. Besides
2447         other projects sometimes need to use lower version of gnutls.
2448
2449         This patch supports to download gnutls through jhbuild, and use it.
2450
2451         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
2452         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
2453
2454 2015-04-15  Mark Lam  <mark.lam@apple.com>
2455
2456         Remove obsolete VMInspector debugging tool.
2457         https://bugs.webkit.org/show_bug.cgi?id=143798
2458
2459         Reviewed by Michael Saboff.
2460
2461         * TestWebKitAPI/CMakeLists.txt:
2462         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2463         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2465         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
2466
2467 2015-04-15  Jer Noble  <jer.noble@apple.com>
2468
2469         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
2470
2471         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2472
2473 2015-04-15  Jer Noble  <jer.noble@apple.com>
2474
2475         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
2476
2477         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2478         (TestWebKitAPI::TEST_F):
2479
2480 2015-04-15  Chris Dumez  <cdumez@apple.com>
2481
2482         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
2483         https://bugs.webkit.org/show_bug.cgi?id=143779
2484
2485         Reviewed by Brent Fulgham.
2486
2487         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
2488         similarly to what is done on Mac / WK1. Without this, PageCache could
2489         stay enabled after page cache tests and cause weird behaviors.
2490
2491         * DumpRenderTree/win/DumpRenderTree.cpp:
2492         (resetWebPreferencesToConsistentValues):
2493
2494 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
2495
2496         Re-enable custom dilation for antialiased fonts
2497         https://bugs.webkit.org/show_bug.cgi?id=143738
2498
2499         Reviewed by Tim Horton.
2500         
2501         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
2502         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
2503         a private WebKit pref. This pref defaults to YES, enabling the feature by default
2504         in WK1 as we do for WK2.
2505
2506         * DumpRenderTree/mac/DumpRenderTree.mm:
2507         (resetWebPreferencesToConsistentValues):
2508         * WebKitTestRunner/TestController.cpp:
2509         (WTR::TestController::resetPreferencesToConsistentValues):
2510
2511 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
2512
2513         Correct layering violation in DumpRenderTree Build
2514         https://bugs.webkit.org/show_bug.cgi?id=143732
2515
2516         Reviewed by Simon Fraser.
2517
2518         Correct a layering violation in DumpRenderTree by calling functions on the
2519         WebCoreTestSupport library, rather than attempting to work with WebCore
2520         types directly.
2521
2522         * DumpRenderTree/mac/EventSendingController.mm:
2523         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
2524         than WebCore itself.,
2525         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
2526
2527 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
2528
2529         Add a conservative DFA minimizer for the content extension matcher
2530         https://bugs.webkit.org/show_bug.cgi?id=143501
2531
2532         Reviewed by Alex Christensen.
2533
2534         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2535         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2536
2537 2015-04-14  Daniel Bates  <dabates@apple.com>
2538
2539         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
2540         https://bugs.webkit.org/show_bug.cgi?id=143693
2541         <rdar://problem/20530316>
2542
2543         Reviewed by Tim Horton.
2544
2545         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
2546         to use the fixed layout code on iOS at this time.
2547
2548         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
2549
2550 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
2551
2552         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
2553         https://bugs.webkit.org/show_bug.cgi?id=143705
2554
2555         Unreviewed change to watchlist file.
2556
2557         * Scripts/webkitpy/common/config/watchlist:
2558
2559 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
2560
2561         [EFL] favicon wasn't updated for google.com sometimes.
2562         https://bugs.webkit.org/show_bug.cgi?id=141940
2563
2564         Reviewed by Gyuyoung Kim.
2565
2566         As elm_entry_utf8_to_markup can include additional characters, parameter for the
2567         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
2568
2569         * MiniBrowser/efl/main.c:
2570         (on_url_changed):
2571
2572 2015-04-13  Tim Horton  <timothy_horton@apple.com>
2573
2574         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
2575         https://bugs.webkit.org/show_bug.cgi?id=143560
2576         <rdar://problem/16302047>
2577
2578         Reviewed by Darin Adler.
2579
2580         * MiniBrowser/mac/BrowserWindowController.h:
2581         * MiniBrowser/mac/MainMenu.xib:
2582         * MiniBrowser/mac/WK1BrowserWindowController.m:
2583         (-[WK1BrowserWindowController setScale:]):
2584         * MiniBrowser/mac/WK2BrowserWindowController.m:
2585         (viewScaleForMenuItemTag):
2586         (-[WK2BrowserWindowController setScale:]):
2587         (-[WK2BrowserWindowController validateMenuItem:]):
2588         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
2589         When in use, we resize the window so that the view fits correctly, and
2590         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
2591         layout size will not change when scaling down (but will update appropriately
2592         when the view is resized).
2593
2594 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
2595
2596         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
2597         https://bugs.webkit.org/show_bug.cgi?id=138630
2598
2599         Reviewed by Tim Horton.
2600
2601         Make sure that we always load at least one in order productive iteration.
2602
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2604         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
2605         is done loading at least one iteration that wasn't an out of order build.
2606         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
2607         when that's needed to check for out of order builds.
2608         (BuildbotQueue.prototype.update): Ditto.
2609         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
2610         result, and if it does not, load more iterations.
2611         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
2612         an in order iteration loaded too.
2613         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
2614         corrected to always sort loaded iterations before unloaded ones.
2615
2616 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
2617
2618         Expand test infrastructure to support scrolling tests
2619         https://bugs.webkit.org/show_bug.cgi?id=143286
2620         <rdar://problem/20375516>
2621
2622         Reviewed by Simon Fraser.
2623
2624         Extend the WK1 and WK2 test programs to support two new EventSender commands:
2625         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
2626         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
2627         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
2628         relevant rubberband, scroll, and scroll-snap animations are finished.
2629
2630         * DumpRenderTree/mac/EventSendingController.mm:
2631         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
2632         and 'monitorWheelEvents'.
2633         (+[EventSendingController webScriptNameForSelector:]): Ditto.
2634         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
2635         debugging test failures.
2636         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
2637         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
2638         function, then passes it to WebCore to be called once the test deferrals have been cleared.
2639         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
2640         'callAfterScrollingCompletes' method.
2641         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
2642         and 'monitorWheelEvents'.
2643         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2644         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
2645         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
2646         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
2647         'callAfterScrollingComplates' method.
2648         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2649
2650 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
2651
2652         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
2653         https://bugs.webkit.org/show_bug.cgi?id=143656
2654
2655         Reviewed by Darin Adler.
2656
2657         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2658         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2659
2660 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
2661
2662         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
2663         https://bugs.webkit.org/show_bug.cgi?id=142387
2664
2665         Reviewed by Carlos Garcia Campos.
2666
2667         Running mixed content is blocked by default since r181134. Updated
2668         the test case to reflect the new default settings.
2669
2670         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2671         (testInsecureContent):
2672
2673 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2674
2675         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
2676         https://bugs.webkit.org/show_bug.cgi?id=143667
2677
2678         Reviewed by Csaba Osztrogonác.
2679
2680         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
2681         since r169017. Added $hardwareConcurrencySupport for it.
2682
2683         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
2684
2685         * Scripts/webkitperl/FeatureList.pm:
2686
2687 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
2688
2689         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
2690         https://bugs.webkit.org/show_bug.cgi?id=143664
2691
2692         Reviewed by Gyuyoung Kim.
2693
2694         * Scripts/webkitperl/FeatureList.pm:
2695
2696 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2697
2698         [EFL] Enable Media Source
2699         https://bugs.webkit.org/show_bug.cgi?id=143635
2700
2701         Reviewed by Csaba Osztrogonác.
2702
2703         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
2704
2705 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
2706
2707         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
2708         https://bugs.webkit.org/show_bug.cgi?id=143646
2709
2710         Reviewed by David Kilzer.
2711
2712         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2713         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2714
2715 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
2716
2717         Use en_US spell checker for tests on Mac instead of Multilingual
2718         https://bugs.webkit.org/show_bug.cgi?id=143641
2719
2720         Reviewed by Dan Bernstein.
2721
2722         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2723         While at it, override NSUserDictionaryReplacementItems, so that user replacements
2724         cannot affect tests.
2725
2726         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
2727         Made this more like WebKit1 version.
2728
2729 2015-04-10  Tim Horton  <timothy_horton@apple.com>
2730
2731         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
2732         https://bugs.webkit.org/show_bug.cgi?id=143576
2733
2734         Reviewed by Simon Fraser.
2735
2736         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
2737         (TEST):
2738         Adopt.
2739
2740 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2741
2742         Update my email address and expertise.
2743         https://bugs.webkit.org/show_bug.cgi?id=143586
2744
2745         Unreviewed, just update my info.
2746
2747         * Scripts/webkitpy/common/config/contributors.json:
2748
2749 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
2750
2751         Flakiness Dashboard not loading insecure content if loaded with https URL
2752         https://bugs.webkit.org/show_bug.cgi?id=143570
2753
2754         Reviewed by Alexey Proskuryakov.
2755
2756         * TestResultServer/app.yaml:
2757         * TestResultServer/static-dashboards/loader.js:
2758         Switch to https scheme.
2759
2760 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
2761
2762         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
2763         https://bugs.webkit.org/show_bug.cgi?id=142907
2764
2765         Reviewed by Carlos Garcia Campos.
2766
2767         * TestWebKitAPI/PlatformEfl.cmake:
2768         * TestWebKitAPI/PlatformGTK.cmake:
2769         * WebKitTestRunner/PlatformEfl.cmake:
2770         * WebKitTestRunner/PlatformGTK.cmake:
2771
2772 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2773
2774         [Mac] Unreviewed test fix after r182584
2775         https://bugs.webkit.org/show_bug.cgi?id=143452
2776
2777         Put both of these tests back to their original state now that the underlying
2778         problem is fixed.
2779
2780         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2781         (TestWebKitAPI::TEST):
2782         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2783         (TestWebKitAPI::TEST):
2784
2785 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
2786
2787         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
2788         https://bugs.webkit.org/show_bug.cgi?id=143553
2789
2790         Reviewed by Ryosuke Niwa.
2791         
2792         Remove the spurious printVMs left over from an earlier change.
2793
2794         * Scripts/run-jsc-benchmarks:
2795
2796 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2797
2798         [Mac] Unreviewed test fix after r182581
2799
2800         The behavior of control-left-click is controlled by a system preference.
2801         Our test bots have this turned off.
2802
2803         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2804         (TestWebKitAPI::TEST):
2805         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2806         (TestWebKitAPI::TEST):
2807
2808 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2809
2810         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
2811         https://bugs.webkit.org/show_bug.cgi?id=143452
2812         <rdar://problem/20437483>
2813
2814         Reviewed by Tim Horton.
2815
2816         Add a new API test to confirm that Cocoa mouse button press events are properly
2817         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
2818
2819         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
2820         some registered event handlers that the expected button press and context menu
2821         events are received.
2822
2823         The WK1 unit test creates an NSEvent with the desired button press state, and then
2824         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
2825         We check the resulting PlatformMouseEvent for proper state.
2826
2827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
2828         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
2829         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2830         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
2831         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
2832         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
2833         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2834         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2835         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
2836         mouse down events.
2837         * TestWebKitAPI/mac/PlatformWebViewMac.h:
2838
2839 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
2840
2841         [GTK] Add pango to jhbuild-optional.modules
2842         https://bugs.webkit.org/show_bug.cgi?id=143537
2843
2844         Reviewed by Martin Robinson.
2845
2846         * gtk/jhbuild-optional.modules: Add pango.
2847
2848 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2849
2850         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
2851         https://bugs.webkit.org/show_bug.cgi?id=143530
2852
2853         Reviewed by Žan Doberšek.
2854
2855         Assume that the default value for display (:0) is reserved and start checking on :1
2856         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
2857         and for X server named Xorg.bin (previous bug 1376599)
2858
2859         * Scripts/webkitpy/port/xvfbdriver.py:
2860         (XvfbDriver._next_free_display)
2861         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2862         (XvfbDriverTest.test_start_no_pixel_tests):
2863         (XvfbDriverTest.test_start_pixel_tests):
2864         (XvfbDriverTest.test_start_arbitrary_worker_number):
2865         (XvfbDriverTest.test_next_free_display):
2866         (XvfbDriverTest.test_start_next_worker):
2867 2015-04-08  Alex Christensen  <achristensen@webkit.org>
2868
2869         Block popups from content extensions.
2870         https://bugs.webkit.org/show_bug.cgi?id=143497
2871
2872         Reviewed by Brady Eidson.
2873
2874         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2875         (TestWebKitAPI::TEST_F):
2876         Added popup test.
2877
2878 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
2879
2880         Add CMake build system for WinCairo port.
2881         https://bugs.webkit.org/show_bug.cgi?id=115944
2882
2883         Reviewed by Chris Dumez.
2884
2885         * CMakeLists.txt:
2886         * WinLauncher/CMakeLists.txt: Added.
2887
2888 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2889
2890         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
2891         https://bugs.webkit.org/show_bug.cgi?id=143521
2892
2893         Reviewed by Martin Robinson.
2894
2895         Add a way to detect unexpected web process crashes to WebViewTest,
2896         and a test case to testDOMCache to trigger the crash.
2897
2898         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2899         (WebKitDOMNodeTest::testDOMCache):
2900         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2901         (testWebKitWebViewProcessCrashed):
2902         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2903         (WebViewTest::WebViewTest):
2904         (WebViewTest::webProcessCrashed):
2905         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2906
2907 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
2908
2909         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
2910         rdar://problem/20461342
2911
2912         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2913
2914 2015-04-07  Commit Queue  <commit-queue@webkit.org>
2915
2916         Unreviewed, rolling out r182511.
2917         https://bugs.webkit.org/show_bug.cgi?id=143507
2918
2919         caused debug test failures (Requested by alexchristensen on
2920         #webkit).
2921
2922         Reverted changeset:
2923
2924         "Block popups from content extensions."
2925         https://bugs.webkit.org/show_bug.cgi?id=143497
2926         http://trac.webkit.org/changeset/182511
2927
2928 2015-04-07  Alex Christensen  <achristensen@webkit.org>
2929
2930         Block popups from content extensions.
2931         https://bugs.webkit.org/show_bug.cgi?id=143497
2932
2933         Reviewed by Brady Eidson.
2934
2935         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2936         (TestWebKitAPI::TEST_F):
2937         Added popup test.
2938
2939 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
2940
2941         Get the features.json files ready for open contributions
2942         https://bugs.webkit.org/show_bug.cgi?id=143436
2943
2944         Reviewed by Darin Adler.
2945
2946         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2947         (JSONFeaturesChecker.check):
2948         Extend the syntax checking a bit, but leave everything non-mandatory
2949         very loose until we figure what fields are important.
2950
2951 2015-04-07  Tim Horton  <timothy_horton@apple.com>
2952
2953         Expose and test fixedLayoutSize via modern WebKit SPI
2954         https://bugs.webkit.org/show_bug.cgi?id=143500
2955
2956         Reviewed by Simon Fraser.
2957
2958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2959         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
2960         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
2961         (TEST):
2962         Add a test that verifies that fixedLayoutSize works at all, that
2963         it persists through a navigation, and that turning it back off reverts to
2964         laying out at the size of the view.
2965
2966 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2967
2968         Unreviewed. Add myself as a committer.
2969
2970         * Scripts/webkitpy/common/config/contributors.json:
2971
2972 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
2973
2974         [Win] Bots complain about missing /etc/catalog
2975         https://bugs.webkit.org/show_bug.cgi?id=143484
2976
2977         Reviewed by Chris Dumez.
2978
2979         The libxml2 build on Mac, iOS, and Windows does not provide the set
2980         of default catalog files. We do not actually need these for our
2981         purposes, but we get warnings and some bot flakiness because they
2982         are not present.
2983
2984         We can avoid both problems the same way the Mac and iOS ports do,
2985         by setting the XML_CATALOG_FILES environment variable to 'empty string',
2986         which avoid the warnings and bot problems.
2987
2988         * Scripts/webkitpy/port/win.py:
2989         (WinPort.setup_environ_for_server): Added.
2990
2991 2015-04-06  Sam Weinig  <sam@webkit.org>
2992
2993         Use content extensions in MiniBrowser.
2994         https://bugs.webkit.org/show_bug.cgi?id=143446
2995
2996         Reviewed by Alex Christensen.
2997
2998         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2999         * MiniBrowser/mac/AppDelegate.h:
3000         * MiniBrowser/mac/AppDelegate.m:
3001         (-[BrowserAppDelegate init]):
3002         (-[BrowserAppDelegate showExtensionsManager:]):
3003         (-[BrowserAppDelegate userContentContoller]):
3004         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
3005         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
3006         (-[ExtensionManagerWindowController init]):
3007         (-[ExtensionManagerWindowController windowDidLoad]):
3008         (-[ExtensionManagerWindowController add:]):
3009         (-[ExtensionManagerWindowController remove:]):
3010         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
3011         * MiniBrowser/mac/MainMenu.xib:
3012
3013 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3014
3015         web-platform-tests server should retrieve the modules file relatively to its docroot path
3016         https://bugs.webkit.org/show_bug.cgi?id=142742
3017
3018         Reviewed by Darin Adler.
3019
3020         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3021         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
3022
3023 2015-04-06  Commit Queue  <commit-queue@webkit.org>
3024
3025         Unreviewed, rolling out r182445.
3026         https://bugs.webkit.org/show_bug.cgi?id=143459
3027
3028         broke 32 bit build (Requested by alexchristensen on #webkit).
3029
3030         Reverted changeset:
3031
3032         "Use content extensions in MiniBrowser."
3033         https://bugs.webkit.org/show_bug.cgi?id=143446
3034         http://trac.webkit.org/changeset/182445
3035
3036 2015-04-06  Sam Weinig  <sam@webkit.org>
3037
3038         Use content extensions in MiniBrowser.
3039         https://bugs.webkit.org/show_bug.cgi?id=143446
3040
3041         Reviewed by Alex Christensen.
3042
3043         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3044         * MiniBrowser/mac/AppDelegate.h:
3045         * MiniBrowser/mac/AppDelegate.m:
3046         (-[BrowserAppDelegate init]):
3047         (-[BrowserAppDelegate showExtensionsManager:]):
3048         (-[BrowserAppDelegate userContentContoller]):
3049         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
3050         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
3051         (-[ExtensionManagerWindowController init]):
3052         (-[ExtensionManagerWindowController windowDidLoad]):
3053         (-[ExtensionManagerWindowController add:]):
3054         (-[ExtensionManagerWindowController remove:]):
3055         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
3056         * MiniBrowser/mac/MainMenu.xib:
3057
3058 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
3059
3060         [GTK] install-dependencies should prefer dnf to yum
3061         https://bugs.webkit.org/show_bug.cgi?id=143441
3062
3063         Reviewed by Martin Robinson.
3064
3065         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
3066
3067         * gtk/install-dependencies:
3068
3069 2015-04-06  Andy Estes  <aestes@apple.com>
3070
3071         [iOS] 'make clean' fails in Tools/WebKitTestRunner
3072         https://bugs.webkit.org/show_bug.cgi?id=143455
3073
3074         Reviewed by Dan Bernstein.
3075
3076         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
3077         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
3078
3079         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
3080
3081 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
3082
3083         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
3084         https://bugs.webkit.org/show_bug.cgi?id=143450
3085
3086         Reviewed by Anders Carlsson.
3087
3088         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
3089         Make sure that the view is actually closed, regardless of anything else that happens beneath.
3090         Also, removed unnecessary get() calls.
3091
3092 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
3093
3094         Reduce the dependency on Flash in regression tests
3095         https://bugs.webkit.org/show_bug.cgi?id=143391
3096
3097         Reviewed by Anders Carlsson.
3098
3099         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
3100         Only allow QuickTime and the test plug-in.
3101
3102 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3103
3104         W3C test importer should generate the modules installed dynamically to run wpt tests
3105         https://bugs.webkit.org/show_bug.cgi?id=142738
3106
3107         Reviewed by Ryosuke Niwa.
3108
3109         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
3110         The implementation is done within TestDownloader and it is activated for the WPT repository.
3111         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
3112
3113         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3114         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
3115         * Scripts/webkitpy/w3c/test_downloader.py:
3116         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
3117         (TestDownloader):
3118         (TestDownloader._git_submodules_description): Computes submodule description.
3119         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
3120         * Scripts/webkitpy/w3c/test_importer.py:
3121         (TestImporter.do_import): Added the possibility to post process the tests.
3122         (TestImporter):
3123         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
3124         (TestImporter.should_convert_test_harness_links): Updated according new options format.
3125         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3126         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
3127         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
3128         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
3129         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
3130         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
3131
3132 2015-04-05  Antti Koivisto  <antti@apple.com>
3133
3134         Bloom filter should support longer hashes
3135         https://bugs.webkit.org/show_bug.cgi?id=143419
3136
3137         Reviewed by Dan Bernstein.
3138
3139         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
3140         (TestWebKitAPI::generateRandomDigests):
3141         (TestWebKitAPI::TEST):
3142
3143 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3144
3145         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
3146         https://bugs.webkit.org/show_bug.cgi?id=143372
3147
3148         Reviewed by Darin Adler.
3149
3150         * Scripts/run-jsc-stress-tests:
3151
3152 2015-04-03  Antti Koivisto  <antti@apple.com>
3153
3154         Add non-counting bloom filter class
3155         https://bugs.webkit.org/show_bug.cgi?id=143366
3156
3157         Reviewed by Sam Weinig.
3158
3159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3160         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
3161         (TestWebKitAPI::generateRandomHashes):
3162         (TestWebKitAPI::TEST):
3163
3164 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3165
3166         FTL JIT tests should fail if LLVM library isn't available
3167         https://bugs.webkit.org/show_bug.cgi?id=143374
3168
3169         Reviewed by Mark Lam.
3170
3171         * Scripts/run-jsc-stress-tests:
3172
3173 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
3174
3175         [EFL] Speedup jhbuild with disable running autogen.sh
3176         https://bugs.webkit.org/show_bug.cgi?id=143369
3177
3178         Reviewed by Gyuyoung Kim.
3179
3180         * efl/jhbuild.modules:
3181
3182 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
3183
3184         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
3185         https://bugs.webkit.org/show_bug.cgi?id=143282
3186
3187         Reviewed by Daniel Bates.
3188
3189         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
3190
3191 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
3192
3193         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
3194         https://bugs.webkit.org/show_bug.cgi?id=143240
3195         rdar://problem/19990425
3196
3197         Reviewed by Tim Horton.
3198
3199         * DumpRenderTree/mac/LayoutTestHelper.m:
3200         (colorProfileURLForDisplay):
3201         (saveDisplayColorProfiles):
3202         Gracefully handle it when the current profile cannot be retrieved, fixing at
3203         least one case when LayoutTestHelper couldn't start.
3204
3205         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3206         (Manager._set_up_run):
3207         (Manager._force_pixel_tests_if_needed):
3208         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
3209         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
3210         Return and check an error from start_helper().
3211
3212 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
3213
3214         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
3215         https://bugs.webkit.org/show_bug.cgi?id=143321
3216
3217         Reviewed by Alexey Proskuryakov.
3218
3219         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
3220
3221 2015-04-01  Enrica Casucci  <enrica@apple.com>
3222
3223         Injected bundle messages should be at the page level.
3224         https://bugs.webkit.org/show_bug.cgi?id=143283
3225
3226         Reviewed by Alexey Proskuryakov.
3227
3228         Updating WebKitTestRunner to use the new page level messaging.
3229         The author of this patch is Tim Horton, I just finished it.
3230
3231         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3232         (WTR::EventSendingController::mouseDown):
3233         (WTR::EventSendingController::mouseUp):
3234         (WTR::EventSendingController::mouseMoveTo):
3235         (WTR::EventSendingController::leapForward):
3236         (WTR::EventSendingController::scheduleAsynchronousClick):
3237         (WTR::EventSendingController::keyDown):
3238         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3239         (WTR::EventSendingController::mouseScrollBy):
3240         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3241         (WTR::EventSendingController::continuousMouseScrollBy):
3242         (WTR::EventSendingController::addTouchPoint):
3243         (WTR::EventSendingController::updateTouchPoint):
3244         (WTR::EventSendingController::setTouchModifier):
3245         (WTR::EventSendingController::setTouchPointRadius):
3246         (WTR::EventSendingController::touchStart):
3247         (WTR::EventSendingController::touchMove):
3248         (WTR::EventSendingController::touchEnd):
3249         (WTR::EventSendingController::touchCancel):
3250         (WTR::EventSendingController::clearTouchPoints):
3251         (WTR::EventSendingController::releaseTouchPoint):
3252         (WTR::EventSendingController::cancelTouchPoint):
3253         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3254         (WTR::InjectedBundle::didReceiveMessage):
3255         (WTR::InjectedBundle::didReceiveMessageToPage):
3256         (WTR::InjectedBundle::done):
3257         (WTR::InjectedBundle::outputText):
3258         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
3259         (WTR::InjectedBundle::postAddChromeInputField):
3260         (WTR::InjectedBundle::postRemoveChromeInputField):
3261         (WTR::InjectedBundle::postFocusWebView):
3262         (WTR::InjectedBundle::postSetBackingScaleFactor):
3263         (WTR::InjectedBundle::postSetWindowIsKey):
3264         (WTR::InjectedBundle::postSimulateWebNotificationClick):
3265         (WTR::InjectedBundle::postSetAddsVisitedLinks):
3266         (WTR::InjectedBundle::setGeolocationPermission):
3267         (WTR::InjectedBundle::setMockGeolocationPosition):
3268         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
3269         (WTR::InjectedBundle::setUserMediaPermission):
3270         (WTR::InjectedBundle::setCustomPolicyDelegate):
3271         (WTR::InjectedBundle::setHidden):
3272         (WTR::InjectedBundle::setCacheModel):
3273         (WTR::InjectedBundle::shouldProcessWorkQueue):
3274         (WTR::InjectedBundle::processWorkQueue):
3275         (WTR::InjectedBundle::queueBackNavigation):
3276         (WTR::InjectedBundle::queueForwardNavigation):
3277         (WTR::InjectedBundle::queueLoad):
3278         (WTR::InjectedBundle::queueLoadHTMLString):
3279         (WTR::InjectedBundle::queueReload):
3280         (WTR::InjectedBundle::queueLoadingScript):
3281         (WTR::InjectedBundle::queueNonLoadingScript):
3282         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3283         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3284         (WTR::TestRunner::setAuthenticationUsername):
3285         (WTR::TestRunner::setAuthenticationPassword):
3286         (WTR::TestRunner::secureEventInputIsEnabled):
3287         (WTR::TestRunner::setBlockAllPlugins):
3288         * WebKitTestRunner/TestController.cpp:
3289         (WTR::TestController::createWebViewWithOptions):
3290         (WTR::TestController::resetStateToConsistentValues):
3291         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
3292         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
3293         * WebKitTestRunner/TestController.h:
3294         * WebKitTestRunner/TestInvocation.cpp:
3295         (WTR::TestInvocation::invoke):
3296         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3297
3298 2015-04-01  Commit Queue  <commit-queue@webkit.org>
3299
3300         Unreviewed, rolling out r182174 and r182177.
3301         https://bugs.webkit.org/show_bug.cgi?id=143314
3302
3303         Try to correct EWS failures (Requested by bfulgham on
3304         #webkit).
3305
3306         Reverted changesets:
3307
3308         "Python SCM should be able to retrieve untracked files"
3309         https://bugs.webkit.org/show_bug.cgi?id=143135
3310         http://trac.webkit.org/changeset/182174
3311
3312         "[buildbot] clean-build script should remove untracked files
3313         and revert local changes too"
3314         https://bugs.webkit.org/show_bug.cgi?id=142400
3315         http://trac.webkit.org/changeset/182177
3316
3317 2015-04-01  Alex Christensen  <achristensen@webkit.org>
3318
3319         [Content Extensions] Properly handle regexes that match everything.
3320         https://bugs.webkit.org/show_bug.cgi?id=143281
3321
3322         Reviewed by Benjamin Poulain.
3323
3324         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3325         (TestWebKitAPI::testRequest):
3326         (TestWebKitAPI::makeBackend):
3327         (TestWebKitAPI::TEST_F):
3328         Removed duplicate code and added test.
3329
3330 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
3331
3332         Content Extensions: split the state machines to minimize prefix states
3333         https://bugs.webkit.org/show_bug.cgi?id=143253
3334
3335         Reviewed by Alex Christensen.
3336
3337         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3338         (TestWebKitAPI::TEST_F):
3339         (TestWebKitAPI::testPatternStatus):
3340
3341 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
3342
3343         Clean up Identifier factories to clarify the meaning of StringImpl*
3344         https://bugs.webkit.org/show_bug.cgi?id=143146
3345
3346         Reviewed by Filip Pizlo.
3347
3348         Simple API tests for StringImpl are added.
3349
3350         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3351         (TestWebKitAPI::TEST):
3352
3353 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
3354
3355         [EFL] Add AArch64 builder and tester bot to build.webkit.org
3356         https://bugs.webkit.org/show_bug.cgi?id=143092
3357
3358         Reviewed by Gyuyoung Kim.
3359
3360         * BuildSlaveSupport/build.webkit.org-config/config.json:
3361         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3362         (Factory.__init__):
3363         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3364
3365 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3366
3367         [buildbot] clean-build script should remove untracked files and revert local changes too
3368         https://bugs.webkit.org/show_bug.cgi?id=142400
3369
3370         Reviewed by Ryosuke Niwa.
3371
3372         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
3373         A helper routine SCM.discard_untracked_files is added for that purpose.
3374
3375         * BuildSlaveSupport/clean-build:
3376         (main): Making call to Scripts/clean-webkit
3377         * Scripts/clean-webkit: Added.
3378         (main): Revert changes and delete untracked files.
3379         * Scripts/webkitpy/common/checkout/scm/scm.py:
3380         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
3381         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3382         (SCMTest._shared_test_discard_untracked_files):
3383         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
3384
3385 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3386
3387         Python SCM should be able to retrieve untracked files
3388         https://bugs.webkit.org/show_bug.cgi?id=143135
3389
3390         Reviewed by Ryosuke Niwa.
3391
3392         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
3393         Ignored files may be included or not in this list according boolean passed to the function.
3394
3395         * Scripts/webkitpy/common/checkout/scm/git.py:
3396         (Git.untracked_files):
3397         * Scripts/webkitpy/common/checkout/scm/scm.py:
3398         (SCM.untracked_files):
3399         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3400         (SCMTest._shared_test_untracked_files):
3401         (test_untracked_files):
3402         (GitSVNTest.test_untracked_files):
3403         * Scripts/webkitpy/common/checkout/scm/svn.py:
3404         (SVN.untracked_files):
3405
3406 2015-03-30  Alex Christensen  <achristensen@webkit.org>
3407
3408         [Content Extensions] Correctly handle regular expressions matching everything
3409         https://bugs.webkit.org/show_bug.cgi?id=143235
3410
3411         Reviewed by Benjamin Poulain.
3412
3413         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3414         (TestWebKitAPI::checkCompilerError):
3415         (TestWebKitAPI::TEST_F):
3416         Test ContentExtensionErrors.
3417
3418 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
3419
3420         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
3421         https://bugs.webkit.org/show_bug.cgi?id=143241
3422         rdar://problem/20351297
3423
3424         Reviewed by Mark Lam.
3425
3426         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3427
3428 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3429
3430         [CMake][EFL] Remove redundant library link and include path
3431         https://bugs.webkit.org/show_bug.cgi?id=143221
3432
3433         Reviewed by Csaba Osztrogonác.
3434
3435         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
3436
3437 2015-03-30  Sam Weinig  <sam@webkit.org>
3438
3439         [Content Extensions] Flesh out the UserContentExtensionStore
3440         https://bugs.webkit.org/show_bug.cgi?id=143123
3441
3442         Reviewed by Benjamin Poulain.
3443
3444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3445         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
3446         Add tests for _WKUserContentExtensionStore.
3447
3448 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3449
3450         Update install-dependencies Fedora packages after r181624
3451         https://bugs.webkit.org/show_bug.cgi?id=143215
3452
3453         Add json-glib, libv4l, openssl and pulseaudio development packages to
3454         the Fedora list providing we need them to build WebKit dependencies
3455         for this distribution.
3456
3457         Reviewed by Philippe Normand.
3458
3459         * gtk/install-dependencies:
3460
3461 2015-03-30  Commit Queue  <commit-queue@webkit.org>
3462
3463         Unreviewed, rolling out r182119.
3464         https://bugs.webkit.org/show_bug.cgi?id=143196
3465
3466         problem with syntax (Requested by youenn on #webkit).
3467
3468         Reverted changeset:
3469
3470         "[buildbot] clean-build script should remove untracked files
3471         and revert local changes too"
3472         https://bugs.webkit.org/show_bug.cgi?id=142400
3473         http://trac.webkit.org/changeset/182119
3474
3475 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
3476
3477         Start the features.json files
3478         https://bugs.webkit.org/show_bug.cgi?id=143207
3479
3480         Reviewed by Darin Adler.
3481
3482         I kept the style checking light. We'll have to figure
3483         what is the best format for each field.
3484
3485         * Scripts/webkitpy/style/checker.py:
3486         (CheckerDispatcher._create_checker):
3487         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3488         (JSONContributorsChecker.check):
3489         (JSONFeaturesChecker):
3490         (JSONFeaturesChecker.check):
3491
3492 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3493
3494         [buildbot] clean-build script should remove untracked files and revert local changes too
3495         https://bugs.webkit.org/show_bug.cgi?id=142400
3496
3497         Reviewed by Ryosuke Niwa.
3498
3499         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
3500
3501         * BuildSlaveSupport/clean-build:
3502         (main): Adding call to Tools/Scripts/clean-webkit.
3503         * Scripts/clean-webkit: Added.
3504         (main): Removes untracked and changed files.
3505         * Scripts/webkitpy/common/checkout/scm/git.py:
3506         (Git.untracked_files): Retrieves GIT untracked files.
3507         * Scripts/webkitpy/common/checkout/scm/scm.py:
3508         (SCM.untracked_files): Retrieves SVN untracked files.
3509         (SCM):
3510         (SCM.discard_untracked_files): Deletes untracked files/folders.
3511         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3512         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
3513         (test_untracked_files):
3514         (GitSVNTest.test_untracked_files):
3515         * Scripts/webkitpy/common/checkout/scm/svn.py:
3516         (SVN.untracked_files):
3517
3518 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3519
3520         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
3521         https://bugs.webkit.org/show_bug.cgi?id=143138
3522
3523         Reviewed by Csaba Osztrogonác.
3524
3525         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
3526         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
3527
3528         * ImageDiff/CMakeLists.txt:
3529         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
3530         * WebKitTestRunner/CMakeLists.txt: ditto.
3531
3532 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
3533
3534         Support building WTF on Windows without Cygwin
3535         https://bugs.webkit.org/show_bug.cgi?id=143084
3536
3537         Reviewed by Brent Fulgham.
3538
3539         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
3540         This patch also migrates to using File::Spec->catfile() for directory separators.
3541
3542         * Scripts/update-webkit-dependency:
3543         (wanted):
3544         * Scripts/update-webkit-support-libs:
3545         (wanted):
3546         (downloadExpectedVersionNumber):
3547         (zipFileVersion):
3548         (toUnixPath): Deleted.
3549         * Scripts/webkitdirs.pm:
3550         (determineSourceDir):
3551         (windowsSourceSourceDir):
3552         (windowsLibrariesDir):
3553         (windowsOutputDir):
3554         (checkInstalledTools):
3555         (buildVisualStudioProject):
3556
3557 2015-03-27  Alex Christensen  <achristensen@webkit.org>
3558
3559         Fix WinCairo bot.
3560         https://bugs.webkit.org/show_bug.cgi?id=143086
3561
3562         Reviewed by Brent Fulgham.
3563
3564         * Scripts/webkitdirs.pm:
3565         (buildVisualStudioProject):
3566         (runSvnUpdateAndResolveChangeLogs):
3567         Use ActivePerl-friendly perl.
3568
3569 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3570
3571         URTBF after r182059 to fix the EFL build.
3572
3573         * TestWebKitAPI/CMakeLists.txt:
3574
3575 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
3576
3577         Layout test results URL loads in WK1 but not WK2 minibrowser
3578         https://bugs.webkit.org/show_bug.cgi?id=143117
3579
3580         Reviewed by Tim Horton.
3581
3582         * MiniBrowser/mac/WK2BrowserWindowController.m:
3583         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
3584         everything.
3585         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
3586
3587 2015-03-26  Jer Noble  <jer.noble@apple.com>
3588
3589         Add --allowed-host support to run-webkit-tests
3590         https://bugs.webkit.org/show_bug.cgi?id=142938
3591
3592         Reviewed by Brent Fulgham.
3593
3594         Accept --allowed-host arguments from run-webkit-tests and pass them through to
3595         DumpRenderTree and WebKitTestRunner.
3596
3597         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
3598         are placed in the wrong location. The argument is compared with each tests's path, and if a
3599         relative path or a path with '..' was used, results are placed alongside the test. Take the
3600         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
3601
3602         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3603         (parse_args):
3604         * Scripts/webkitpy/port/base.py:
3605         (Port.__init__):
3606         (Port.allowed_hosts):
3607         * Scripts/webkitpy/port/driver.py:
3608         (Driver.cmd_line):
3609
3610 2015-03-26  Jer Noble  <jer.noble@apple.com>
3611
3612         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
3613         https://bugs.webkit.org/show_bug.cgi?id=142931
3614
3615         Reviewed by Brent Fulgham.
3616
3617         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
3618         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
3619         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
3620         runtime.
3621
3622         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
3623         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
3624
3625         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
3626         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
3627         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
3628         the top loading frame from the page, as we do elsewhere in this class.
3629
3630         * DumpRenderTree/TestRunner.h:
3631         (TestRunner::allowedHosts):
3632         (TestRunner::setAllowedHosts):
3633         * DumpRenderTree/mac/DumpRenderTree.mm:
3634         (initializeGlobalsFromCommandLineOptions):
3635         (runTest):
3636         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3637         (isAllowedHost):
3638         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3639         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3640         (WTR::InjectedBundle::didReceiveMessage):
3641         (WTR::InjectedBundle::isAllowedHost):
3642         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3643         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3644         (WTR::isAllowedHost):
3645         (WTR::InjectedBundlePage::willSendRequestForFrame):
3646         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3647         * WebKitTestRunner/Options.cpp:
3648         (WTR::handleOptionAllowedHost):
3649         (WTR::OptionsHandler::OptionsHandler):
3650         * WebKitTestRunner/Options.h:
3651         * WebKitTestRunner/TestController.cpp:
3652         (WTR::TestController::initialize):
3653         (WTR::TestController::resetStateToConsistentValues):
3654         * WebKitTestRunner/TestController.h:
3655
3656 2015-03-26  Brady Eidson  <beidson@apple.com>
3657
3658         Apply ContentExtension actions after redirects.
3659         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
3660