aae2b42867ec0c52dc58720bac5438af894782c9
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2
3         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
4         https://bugs.webkit.org/show_bug.cgi?id=76585
5
6         Reviewed by Martin Robinson.
7
8         This allows us to specify a minimum version of jhbuild required,
9         while also providing stability against changes done to the master
10         branch, by letting us choose what is the exact version that will
11         be used.
12
13         * gtk/run-with-jhbuild: refactored for more hackability and easier
14         reading
15         (jhbuild_installed): checks whether jhbuild is installed
16         (jhbuild_cloned): checks whether jhbuild has been cloned
17         (jhbuild_at_expected_revision): checks whether jhbuild is at the
18         expected revision
19         (update_jhbuild): brings jhbuild to the expected revision
20         (clone_jhbuild): clones jhbuild
21         (install_jhbuild): build and installs jhbuild
22         (update_webkitgtk_libs): runs update-webkitgtk-libs
23         (ensure_jhbuild): high-level logic to decide whether and which of
24         the steps above are executed
25
26 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
27
28         [WK2] DumpRenderTree converts "file:///" to a path differently
29         https://bugs.webkit.org/show_bug.cgi?id=76653
30
31         Reviewed by John Sullivan.
32
33         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
34         Do print a slash if there are no path components.
35
36 2012-01-19  Eric Seidel  <eric@webkit.org>
37
38         webkit-patch cannot rollout patches without changelog/bug number
39         https://bugs.webkit.org/show_bug.cgi?id=75962
40
41         Reviewed by Adam Barth.
42
43         * Scripts/webkitpy/tool/commands/download.py:
44         (AbstractRolloutPrepCommand._prepare_state):
45         * Scripts/webkitpy/tool/commands/download_unittest.py:
46         (AbstractRolloutPrepCommandTest.test_prepare_state):
47
48 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
49
50         [WK2] fast/url/degenerate-file-base.html fails
51         https://bugs.webkit.org/show_bug.cgi?id=76619
52
53         Reviewed by Adam Roben.
54
55         A URL generated form local path for loading had an extra slash, making document.URL
56         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
57
58         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
59
60 2012-01-18  Ojan Vafai  <ojan@chromium.org>
61
62         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
63         https://bugs.webkit.org/show_bug.cgi?id=76510
64
65         Reviewed by Adam Barth.
66
67         Unlike other style rules, if you get the syntax of the test_expectations.txt
68         file wrong, the layout tests won't run. Also, this check is simple and only
69         slows down committing if you actually modify one of the test_expectations.txt files.
70
71         * Scripts/webkitpy/style/checkers/test_expectations.py:
72         (TestExpectationsChecker.check_test_expectations):
73         (TestExpectationsChecker.check):
74         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
75         (TestExpectationsTestCase.test_check_covers_all_configurations):
76         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
77         (TestExpectationsTestCase):
78         (assert_lines_lint):
79
80 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
81
82         Build fix. Revert an unintentional change to WebKitDriver in r105443.
83
84         * Scripts/webkitpy/layout_tests/port/driver.py:
85         (DriverProxy.__init__):
86
87 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
88
89         remove the duplicated build rules from WebKit.gyp, Tools.gyp
90         https://bugs.webkit.org/show_bug.cgi?id=73384
91
92         Reviewed by Tony Chang.
93
94         This patch removes the no-longer-necessary conditional logic for
95         build_webkit_exes_from_webkit_gyp; we now always build the exes
96         from their own dedicated gyp files.
97
98         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
99
100 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
101
102         make-new-script-test should work with HTTP tests
103         https://bugs.webkit.org/show_bug.cgi?id=76603
104
105         Reviewed by Adam Roben.
106
107         * Scripts/make-new-script-test:
108         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
109         now also creates absolute paths for HTTP.
110
111 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
112
113         Some perf tests time out when ran by run-perf-tests
114         https://bugs.webkit.org/show_bug.cgi?id=76612
115
116         Reviewed by Dirk Pranke and Eric Seidel.
117
118         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
119         Otherwise some tests such as Parser/xml-parser.html will timeout.
120
121         --no-timeout option is currently supported by Chromium and Mac ports.
122
123         * Scripts/webkitpy/layout_tests/port/base.py:
124         (Port.to.create_driver):
125         * Scripts/webkitpy/layout_tests/port/chromium.py:
126         (ChromiumDriver.__init__):
127         (ChromiumDriver._wrapper_options):
128         * Scripts/webkitpy/layout_tests/port/driver.py:
129         (Driver.__init__):
130         (DriverProxy.__init__):
131         * Scripts/webkitpy/layout_tests/port/webkit.py:
132         (WebKitDriver.__init__):
133         (WebKitDriver.cmd_line):
134         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
135         (WebKitDriverTest.test_read_binary_block):
136         (WebKitDriverTest):
137         (WebKitDriverTest.test_no_timeout):
138         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
139         (get_tests_run.RecordingTestDriver.__init__):
140         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
141         (PerfTestsRunner._parse_args):
142         (PerfTestsRunner._run_tests_set):
143         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
144         (create_runner):
145
146 2012-01-19  Ben Wells  <benwells@chromium.org>
147
148         Add support for window.print to chromium DRT
149         https://bugs.webkit.org/show_bug.cgi?id=76479
150
151         When used in a test window.print goes into print mode and then
152         straight out again. This will allow the afterprint event to be
153         tested by having the afterprint event happen before the dump
154         happens.
155
156         Reviewed by Mihai Parparita.
157
158         * DumpRenderTree/chromium/WebViewHost.cpp:
159         (WebViewHost::printPage):
160         * DumpRenderTree/chromium/WebViewHost.h:
161
162 2012-01-18  Enrica Casucci  <enrica@apple.com>
163
164         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
165         https://bugs.webkit.org/show_bug.cgi?id=76588
166         <rdar://problem/9325183>
167
168         Added test.
169         
170         Reviewed by Dan Bernstein.
171
172         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
173         (TestWebKitAPI::TEST):
174
175 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
176
177         [Qt] Do full incremental builds until bots use update-webkit
178
179         Rubber-stamped by Simon Hausmann.
180
181         * Scripts/webkitdirs.pm:
182         (buildQMakeProjects):
183
184 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
185
186         Fix the Qt build
187
188         Unreviewed build fix.
189
190         * Scripts/webkitdirs.pm:
191         (buildQMakeProjects):
192
193 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
194
195         [Qt] Make build-webkit always do safe incremental builds after update-webkit
196
197         When building against Qt5 with GCC we would just run 'make' in the build dir,
198         and rely on the dependency files output by GCC (-MD) to handle dependency
199         tracking, but that fails for special-cases like adding a Q_OBJECT macro
200         to a header.
201
202         To guarantee that an incrmental build will work, we have to run 'make qmake',
203         which we now do on every build-webkit that's followed by a successful run
204         of update-webkit. The reasoning is that update-webkit can result in such
205         potential corner-cases being applied, and since we can't know for sure
206         unless we inspect the diff and account for all the corner cases we assume
207         the worst and always run 'make qmake'.
208
209         After a succesful run of build-webkit we proceed to do just 'make' for any
210         subsequent runs, since we assume that the developer knows what kind of
211         changes he/she is doing, and when a 'make qmake' is needed.
212
213         Reviewed by Simon Hausmann.
214
215         * Scripts/update-webkit:
216         * Scripts/webkitdirs.pm:
217         (determineCurrentSVNRevision):
218         (currentSVNRevision):
219         (buildQMakeProjects):
220         * qmake/mkspecs/features/default_post.prf:
221
222 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
223
224         run-perf-tests should support Skipped list
225         https://bugs.webkit.org/show_bug.cgi?id=76594
226
227         Reviewed by Adam Barth.
228
229         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
230
231         * Scripts/webkitpy/layout_tests/port/base.py:
232         (Port.perf_tests_dir):
233         (Port.skipped_perf_tests):
234         (Port.skips_perf_test):
235         (Port.relative_perf_test_filename):
236         * Scripts/webkitpy/layout_tests/port/test.py:
237         (TestPort.perf_tests_dir):
238         * Scripts/webkitpy/layout_tests/port/webkit.py:
239         (WebKitPort._expectations_from_skipped_files):
240         (WebKitPort):
241         (WebKitPort.skipped_layout_tests):
242         (WebKitPort.skipped_perf_tests):
243         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
244         (PerfTestsRunner._collect_tests):
245         (PerfTestsRunner.run):
246         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
247         (test_run_test_set_with_json_output):
248         (test_run_test_set_with_json_source):
249         (test_collect_tests_with_skipped_list):
250         (test_collect_tests_with_skipped_list.add_file):
251
252 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
253
254         Fix path to chromium_src_dir introduced in previous change.
255
256         Unreviewed, build fix.
257
258         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
259
260 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
261
262         Need infrastructure to test Content-Disposition filename encoding support
263         https://bugs.webkit.org/show_bug.cgi?id=76572
264         <rdar://problem/6421825>
265
266         Reviewed by Sam Weinig.
267
268         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
269
270         WebKitTestRunner does not have a policy delegate yet, bug 42546.
271
272         * DumpRenderTree/mac/PolicyDelegate.mm:
273         (dispositionTypeFromContentDispositionHeader):
274         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
275
276 2012-01-18  Ojan Vafai  <ojan@chromium.org>
277
278         Fix tests from http://trac.webkit.org/changeset/105332.
279
280         The code assumed that if you passed an options object with a configuration
281         attribute that it would have a valid value. A bunch of the testing mocks
282         do things like having a configuration value of None.
283
284         * Scripts/webkitpy/layout_tests/port/base.py:
285         (Port.__init__):
286
287 2012-01-18  Ojan Vafai  <ojan@chromium.org>
288
289         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
290         https://bugs.webkit.org/show_bug.cgi?id=76576
291
292         Reviewed by Adam Barth.
293
294         Avoid calling default_configuration in base.py. We don't need it for
295         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
296         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
297         from common.executive.
298
299         At some point someone should probably look into why that call is so slow
300         since it's on the critical path for run-webkit-tests and build-webkit startup.
301
302         * Scripts/webkitpy/layout_tests/port/base.py:
303         (Port.__init__):
304         * Scripts/webkitpy/style/checkers/test_expectations.py:
305         (TestExpectationsChecker._determine_port_from_exepectations_path):
306
307 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
308
309         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
310         https://bugs.webkit.org/show_bug.cgi?id=76505
311
312         Reviewed by Tony Chang.
313
314         Update chromium build script to use All.gyp instead of WebKit.gyp
315
316         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
317         * Scripts/webkitdirs.pm:
318
319 2012-01-18  Sam Weinig  <sam@webkit.org>
320
321         Don’t hardcode the path to ‘make‘.
322
323         Reviewed by Dan Bernstein.
324
325         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
326
327 2012-01-18  Joshua Bell  <jsbell@chromium.org>
328
329         Adding myself to committers.py
330         https://bugs.webkit.org/show_bug.cgi?id=76569
331
332         Unreviewed.
333
334         * Scripts/webkitpy/common/config/committers.py:
335
336 2012-01-18  Adam Barth  <abarth@webkit.org>
337
338         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
339         https://bugs.webkit.org/show_bug.cgi?id=76567
340
341         Reviewed by Eric Seidel.
342
343         Current the AppleMac port has slightly more failures than we allow on
344         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
345         which should hopefully let the mac-ews run to completion.  Once
346         AppleMac has fewer failures, we can lower the cap again.
347
348         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
349         (LayoutTestResultsReaderTest.test_layout_test_results):
350         * Scripts/webkitpy/tool/steps/runtests.py:
351         (RunTests):
352         * Scripts/webkitpy/tool/steps/steps_unittest.py:
353
354 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
355
356         Provide access to user's list of preferred languages
357         https://bugs.webkit.org/show_bug.cgi?id=76138
358
359         Reviewed by Alexey Proskuryakov.
360
361         * GNUmakefile.am: Add JSInternalsCustom.cpp.
362
363 2012-01-18  Adam Barth  <abarth@webkit.org>
364
365         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
366         configurations.
367
368         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
369         (ChromiumLinuxPort.__init__):
370
371 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
372
373         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
374         https://bugs.webkit.org/show_bug.cgi?id=73460
375
376         Reviewed by Chris Fleizach.
377
378         * DumpRenderTree/AccessibilityUIElement.h:
379         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
380         (AccessibilityUIElement::AccessibilityUIElement):
381         (AccessibilityUIElement::scrollToMakeVisibleCallback):
382         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
383         (AccessibilityUIElement::scrollToGlobalPointCallback):
384         * DumpRenderTree/chromium/AccessibilityUIElement.h:
385         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
386         (AccessibilityUIElement::scrollToMakeVisible):
387         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
388         (AccessibilityUIElement::scrollToGlobalPoint):
389         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
390         (AccessibilityUIElement::scrollToMakeVisible):
391         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
392         (AccessibilityUIElement::scrollToGlobalPoint):
393         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
394         (AccessibilityUIElement::scrollToMakeVisible):
395         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
396         (AccessibilityUIElement::scrollToGlobalPoint):
397
398 2012-01-17  Enrica Casucci  <enrica@apple.com>
399
400         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
401         https://bugs.webkit.org/show_bug.cgi?id=76490
402         <rdar://problem/9460733>
403
404         Added TestWebKitAPI test.
405         
406         Reviewed by Dan Bernstein.
407
408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
409         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
410         changeAttributes to the WebView.
411         
412 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
413
414         [Qt] Consolidate layout test crash logging
415         https://bugs.webkit.org/show_bug.cgi?id=75088
416
417         Reviewed by Simon Hausmann.
418
419         Move backtrace generating logic into WTFReportBacktrace
420         and add a way to deinstall signal handlers if we know
421         that we have already printed the backtrace.
422
423         * DumpRenderTree/qt/main.cpp:
424         (crashHandler):
425         (setupSignalHandlers):
426         (WTFCrashHook):
427         (main):
428         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
429         (WTR::crashHandler):
430         (WTR::setupSignalHandlers):
431         (WTR::crashHook):
432         (WTR::InjectedBundle::platformInitialize):
433
434 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
435
436         Unreviewed build fix after r105256.
437
438         There was a cyclic dependency between self._port and self._host assigments.
439
440         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
441         (PerfTestsRunner.__init__):
442
443 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
444
445         Add new watchlist rule for the Qt build system
446
447         Reviewed by Simon Hausmann.
448
449         * Scripts/webkitpy/common/config/watchlist:
450
451 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
452
453         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
454
455         Reviewed by Simon Hausmann.
456
457         * Tools.pro:
458
459 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
460
461         [Qt] Allow building only a subset of the WebKit sub-projects
462
463         Fixes build-jsc, broken in r104825.
464
465         We no longer need the intermediate buildQMakeQtProject(), as we're the
466         only port using qmake, and buildQMakeProject is now highly Qt specific.
467
468         <http://webkit.org/b/76179>
469
470         Reviewed by Simon Hausmann.
471
472         * Scripts/build-jsc:
473         * Scripts/build-webkit:
474         * Scripts/webkitdirs.pm:
475         (buildQMakeProjects):
476
477 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
478
479         run-perf-tests should generate a json file that summaries the result
480         https://bugs.webkit.org/show_bug.cgi?id=76504
481
482         Reviewed by Adam Barth.
483
484         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
485         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
486         another json file to be merged into the generated json file.
487
488         Also fixed a bug that --build wasn't set by default.
489
490         * Scripts/webkitpy/layout_tests/port/test.py:
491         (TestPort.webkit_base):
492         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
493         (PerfTestsRunner.__init__):
494         (PerfTestsRunner):
495         (PerfTestsRunner._parse_args):
496         (PerfTestsRunner.run):
497         (PerfTestsRunner._generate_json_if_specified):
498         (PerfTestsRunner._process_chromium_style_test_result):
499         (PerfTestsRunner._process_parser_test_result):
500         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
501         (MainTest):
502         (create_runner):
503         (test_run_test_set):
504         (test_run_test_set_for_parser_tests):
505         (test_run_test_set_with_summary_json):
506         (test_collect_tests):
507         (test_parse_args):
508
509 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
510
511         Unreviewed, rolling out r105244.
512         http://trac.webkit.org/changeset/105244
513         https://bugs.webkit.org/show_bug.cgi?id=76518
514
515         broke Chromium Mac (Requested by rolandsteiner on #webkit).
516
517         * DumpRenderTree/AccessibilityUIElement.h:
518         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
519         (AccessibilityUIElement::AccessibilityUIElement):
520         * DumpRenderTree/chromium/AccessibilityUIElement.h:
521         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
522         (AccessibilityUIElement::removeSelection):
523         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
524         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
525         (AccessibilityUIElement::removeSelection):
526
527 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
528
529         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
530         https://bugs.webkit.org/show_bug.cgi?id=73460
531
532         Reviewed by Chris Fleizach.
533
534         * DumpRenderTree/AccessibilityUIElement.h:
535         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
536         (AccessibilityUIElement::AccessibilityUIElement):
537         (AccessibilityUIElement::scrollToMakeVisibleCallback):
538         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
539         (AccessibilityUIElement::scrollToGlobalPointCallback):
540         * DumpRenderTree/chromium/AccessibilityUIElement.h:
541         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
542         (AccessibilityUIElement::scrollToMakeVisible):
543         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
544         (AccessibilityUIElement::scrollToGlobalPoint):
545         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
546         (AccessibilityUIElement::scrollToMakeVisible):
547         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
548         (AccessibilityUIElement::scrollToGlobalPoint):
549         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
550         (AccessibilityUIElement::scrollToMakeVisible):
551         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
552         (AccessibilityUIElement::scrollToGlobalPoint):
553
554 2012-01-17  Adam Barth  <abarth@webkit.org>
555
556         Enable tests on the mac-ews
557         https://bugs.webkit.org/show_bug.cgi?id=76502
558
559         Reviewed by Simon Fraser.
560
561         Apple now has five machines running the mac-ews.  Lucas Forschler has
562         asked that we try enabling tests to see if we have enough bandwidth.
563
564         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
565         (MacEWS):
566
567 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
568
569         Add a check-webkit-style exception for GDBInterface.cpp
570         https://bugs.webkit.org/show_bug.cgi?id=76187
571
572         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
573         that it does not fail the style check.
574
575         Reviewed by Martin Robinson.
576
577         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
578         readability/naming tests on
579         Source/JavaScriptCore/jit/GDBInterface.cpp.
580         * Scripts/webkitpy/style/checker_unittest.py:
581         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
582         the above exception.
583
584 2012-01-17  Hajime Morrita  <morrita@chromium.org>
585
586         https://bugs.webkit.org/show_bug.cgi?id=76245
587         [Mac][DRT] should allow query string for the file URL.
588
589         Reviewed by Tony Chang.
590
591         Taught DRT about file:// as a url instead of a file path.
592         We are now able to use a path file:///foo/bar.html?baz as a url
593         with which DRT opens "/foo/bar.html" with "baz" as a query string.
594
595         * DumpRenderTree/mac/DumpRenderTree.mm:
596         (runTest):
597
598 2012-01-17  Ojan Vafai  <ojan@chromium.org>
599
600         Check style on test_expectations.txt files before commit
601         https://bugs.webkit.org/show_bug.cgi?id=76484
602
603         Reviewed by Adam Barth.
604
605         Unlike other style rules, if you get the syntax of the test_expectations.txt
606         file wrong, the layout tests won't run. Also, this check is simple and only
607         slows down committing if you actually modify one of the test_expectations.txt files.
608
609         * Scripts/webkitpy/tool/steps/commit.py:
610         (Commit._check_test_expectations):
611         (Commit.run):
612         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
613         (CommitTest):
614         (CommitTest.test_check_test_expectations):
615
616 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
617
618         [Qt] Debug build fails with debug qt5
619         https://bugs.webkit.org/show_bug.cgi?id=76463
620
621         Reviewed by Simon Hausmann.
622
623         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
624
625         * QtTestBrowser/cookiejar.h:
626
627 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
628
629         webkitpy: fix json import on linux
630         https://bugs.webkit.org/show_bug.cgi?id=76481
631
632         Reviewed by Adam Barth.
633
634         For some reason, the version of simplejson autoinstalled on my linux
635         box seems to be broken. We should really only be using
636         simplejson if json isn't available anyway, so this change looks
637         for json first.
638
639         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
640         (JSONGeneratorTest.test_test_timings_trie):
641
642 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
643
644         Fix failures in test-webkitpy caused by r105177.
645
646         Unreviewed, build fix.
647
648         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
649         (ChromiumLinuxPort._determine_driver_path_statically):
650         (ChromiumLinuxPort._static_build_path):
651
652 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
653
654         webkitpy: make PortFactory.get() be fully data-driven
655         https://bugs.webkit.org/show_bug.cgi?id=76360
656
657         Reviewed by Eric Seidel.
658
659         Refactor PortFactory.get() to be fully data-driven.
660
661         * Scripts/webkitpy/layout_tests/port/factory.py:
662         (PortFactory):
663         (PortFactory._default_port):
664         (PortFactory.get):
665         (PortFactory.get.in):
666         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
667         (FactoryTest.assert_port):
668
669 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
670
671         webkitpy: add determine_full_port_name(), clean up port.__init__()
672         https://bugs.webkit.org/show_bug.cgi?id=76357
673
674         Reviewed by Adam Barth.
675
676         Each Port class is now required to implement a 'port_name' field
677         that will match the start of all ports constructed by this class and
678         a 'determine_full_port_name' field that will make the port
679         fully-qualified.
680
681         * Scripts/webkitpy/layout_tests/port/apple.py:
682         (ApplePort.__init__):
683         * Scripts/webkitpy/layout_tests/port/base.py:
684         (Port):
685         (Port.determine_port_name):
686         (Port.__init__):
687         * Scripts/webkitpy/layout_tests/port/chromium.py:
688         (ChromiumPort.for):
689         (ChromiumPort.__init__):
690         (ChromiumPort):
691         (ChromiumPort._chromium_base_dir):
692         (ChromiumPort.path_from_chromium_base):
693         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
694         (ChromiumGpuLinuxPort):
695         (ChromiumGpuLinuxPort.__init__):
696         (ChromiumGpuMacPort):
697         (ChromiumGpuMacPort.__init__):
698         (ChromiumGpuWinPort):
699         (ChromiumGpuWinPort.__init__):
700         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
701         (ChromiumLinuxPort):
702         (ChromiumLinuxPort.determine_port_name):
703         (ChromiumLinuxPort.__init__):
704         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
705         (ChromiumMacPort):
706         (ChromiumMacPort.determine_port_name):
707         (ChromiumMacPort.__init__):
708         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
709         (ChromiumWinPort):
710         (ChromiumWinPort.determine_port_name):
711         (ChromiumWinPort.__init__):
712         * Scripts/webkitpy/layout_tests/port/dryrun.py:
713         (DryRunPort):
714         (DryRunPort.determine_port_name):
715         (DryRunPort.__init__):
716         * Scripts/webkitpy/layout_tests/port/efl.py:
717         (EflPort):
718         * Scripts/webkitpy/layout_tests/port/factory.py:
719         (PortFactory):
720         (PortFactory._default_port):
721         (PortFactory.get):
722         (PortFactory.get.in):
723         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
724         (FactoryTest.assert_port):
725         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
726         (GoogleChromeLinux32Port):
727         (GoogleChromeLinux32Port.determine_port_name):
728         (GoogleChromeLinux64Port):
729         (GoogleChromeLinux64Port.determine_port_name):
730         (GoogleChromeMacPort):
731         (GoogleChromeMacPort.determine_port_name):
732         (GoogleChromeWinPort):
733         (GoogleChromeWinPort.determine_port_name):
734         * Scripts/webkitpy/layout_tests/port/gtk.py:
735         (GtkPort):
736         * Scripts/webkitpy/layout_tests/port/mac.py:
737         (MacPort):
738         (MacPort.determine_port_name):
739         (MacPort.__init__):
740         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
741         (test_versions):
742         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
743         (MockDRTPort):
744         (MockDRTPort.determine_port_name):
745         (MockDRTPort.__init__):
746         (MockDRT):
747         (MockDRT.determine_port_name):
748         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
749         (PortTestCase.make_port):
750         * Scripts/webkitpy/layout_tests/port/qt.py:
751         (QtPort):
752         (QtPort.determine_port_name):
753         (QtPort.__init__):
754         * Scripts/webkitpy/layout_tests/port/test.py:
755         (TestPort):
756         (TestPort.determine_port_name):
757         (TestPort.__init__):
758         * Scripts/webkitpy/layout_tests/port/webkit.py:
759         (WebKitPort.__init__):
760         * Scripts/webkitpy/layout_tests/port/win.py:
761         (WinPort):
762         (WinPort.determine_port_name):
763         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
764         (get_test_baselines.AllPlatformsPort.__init__):
765         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
766         (get_test_config.TestMacPort):
767         (get_test_config):
768
769 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
770
771         webkitpy: clean up port code in preparation for static port names
772         https://bugs.webkit.org/show_bug.cgi?id=76356
773
774         Reviewed by Adam Barth.
775
776         To fix bug 76215 and be able to determine appropriate port names
777         in webkitpy without actually constructing Port objects, we need
778         to shuffle some logic in the chromium ports to be able to figure
779         out whether we built DRT in 32 or 64-bit mode.
780
781         * Scripts/webkitpy/layout_tests/port/chromium.py:
782         (ChromiumPort):
783         (ChromiumPort._chromium_base_dir):
784         (ChromiumPort.__init__):
785         (ChromiumPort.path_from_chromium_base):
786         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
787         (ChromiumLinuxPort):
788         (ChromiumLinuxPort._determine_driver_path_statically):
789         (ChromiumLinuxPort._static_build_path):
790         (ChromiumLinuxPort._determine_architecture):
791         (ChromiumLinuxPort.__init__):
792         (ChromiumLinuxPort._build_path):
793
794 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
795
796         Do not remove pixel failures for ref tests.
797         https://bugs.webkit.org/show_bug.cgi?id=76243
798
799         Reviewed by Tony Chang.
800
801         'NRWT --no-pixel-tests' complains when reftests are expected to
802         be image mismatch.
803
804         * Scripts/webkitpy/layout_tests/controllers/manager.py:
805         (Manager._update_summary_with_result):
806         * Scripts/webkitpy/layout_tests/models/test_failures.py:
807         (is_reftest_failure):
808         (determine_result_type):
809
810 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
811
812         REGRESSION(r81225): ORWT should ignore reftests
813         https://bugs.webkit.org/show_bug.cgi?id=67936
814
815         Reviewed by Csaba Osztrogonác.
816
817         * Scripts/old-run-webkit-tests:
818         (isUsedInReftest): $filename should be the first parameter
819         (findTestsToRun): run test if it isn't reftest
820
821 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
822
823         Unreviewed. Fix python unit test I broke with r105142
824
825         * Scripts/webkitpy/common/config/ports_unittest.py:
826         (WebKitPortTest.test_gtk_port):
827
828 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
829
830         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
831
832         Qt 5 no longer has that flag.
833
834         Reviewed by Simon Hausmann.
835
836         * MiniBrowser/qt/MiniBrowserApplication.cpp:
837         (MiniBrowserApplication::notify):
838
839 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
840
841         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
842         https://bugs.webkit.org/show_bug.cgi?id=75857
843
844         Reviewed by Adam Barth.
845
846         * Scripts/webkitdirs.pm:
847         (buildAutotoolsProject): move cleaning the build to happen early,
848         and handle --update-gtk right after that
849         * Scripts/webkitpy/common/config/ports.py:
850         (GtkPort.build_webkit_command): pass --update-gtk as an option to
851         build-webkit, so that it is used in the EWS
852
853 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
854
855         [Qt] Don't add _debug postfix to targets when building debug only
856
857         Reviewed by Simon Hausmann.
858
859         * qmake/mkspecs/features/default_post.prf:
860         * qmake/mkspecs/features/functions.prf:
861
862 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
863
864         [Qt] Add more files to project-files for easier navigation in Qt Creator
865
866         Reviewed by Simon Hausmann.
867
868         * Tools.pro:
869         * qmake/config.tests/README: Added.
870
871 2012-01-17  Philippe Normand  <pnormand@igalia.com>
872
873         [GTK] fast/dom/constructed-objects-prototypes.html fails
874         https://bugs.webkit.org/show_bug.cgi?id=75432
875
876         Reviewed by Martin Robinson.
877
878         * Scripts/build-webkit: Enable video-track in GTK.
879
880 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
881
882         Add toyoshim as a committer.
883         https://bugs.webkit.org/show_bug.cgi?id=76390
884
885         Reviewed by Hajime Morita.
886
887         * Scripts/webkitpy/common/config/committers.py:
888
889 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
890
891         [WinCairo] Build fix after r104155. Several debug targets were not
892         properly including the '*Common' property sheets.
893
894         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
895         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
896         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
897         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
898         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
899
900 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
901
902         REGRESSION(r105072): It broke committers_unittest.py
903         https://bugs.webkit.org/show_bug.cgi?id=76396
904
905         Reviewed by Adam Barth.
906
907         * Scripts/webkitpy/common/config/committers_unittest.py:
908         (CommittersTest._assert_fuzz_match): It should handle more names.
909         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
910
911 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
912
913         [GTK] Include gtk+3 in the jhbuild modules
914         https://bugs.webkit.org/show_bug.cgi?id=76284
915
916         Reviewed by Philippe Normand.
917
918         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
919
920 2012-01-16  Dan Winship  <danw@gnome.org>
921
922         Add myself as a committer
923
924         Unreviewed
925
926         * Scripts/webkitpy/common/config/committers.py:
927
928 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
929
930         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
931
932         Some recent versions of a few Linux distributions have started passing
933         --as-needed and --no-copy-dt-needed-entries by default to the linker,
934         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
935         needed a few symbols from libjavascriptcore_efl.so.
936
937         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
938         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
939         libraries are searched in the right order by the linker.
940
941 2012-01-16  Philippe Normand  <pnormand@igalia.com>
942
943         [GTK] set audio resources path in NRTW
944         https://bugs.webkit.org/show_bug.cgi?id=76380
945
946         Reviewed by Martin Robinson.
947
948         * Scripts/webkitpy/layout_tests/port/gtk.py:
949         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
950         the uninstalled audio resources are used during webaudio tests.
951
952 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
953
954         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
955         https://bugs.webkit.org/show_bug.cgi?id=76369
956
957         Reviewed by Xan Lopez.
958
959         If there's an installed version of webkit and there are new
960         symbols in the build tree, gtkdoc-scanobj fails due to undefined
961         references, because the env ldflags are given before the local
962         ones.
963
964         * gtk/gtkdoc.py:
965         (GTKDoc._run_gtkdoc_scangobj):
966
967 2012-01-15  Pablo Flouret  <pablof@motorola.com>
968
969         Fix compilation errors on build-webkit --debug --no-video on mac.
970         https://bugs.webkit.org/show_bug.cgi?id=75867
971
972         Reviewed by Philippe Normand.
973
974         Add --[no-]video-track to build-webkit, since video track feature
975         depends on video.
976
977         * Scripts/build-webkit:
978
979 2012-01-14  James Robinson  <jamesr@chromium.org>
980
981         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
982         https://bugs.webkit.org/show_bug.cgi?id=76313
983
984         Reviewed by Adam Barth.
985
986         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
987
988         * Scripts/run-chromium-webkit-unit-tests:
989
990 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
991
992         Unreviewed, rolling out r105017.
993         http://trac.webkit.org/changeset/105017
994         https://bugs.webkit.org/show_bug.cgi?id=76333
995
996         broke the build (Requested by philn-tp on #webkit).
997
998         * gtk/jhbuild.modules:
999
1000 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
1001
1002         [GTK] Include gtk+3 in the jhbuild modules
1003         https://bugs.webkit.org/show_bug.cgi?id=76284
1004
1005         Reviewed by Philippe Normand.
1006
1007         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1008
1009 2012-01-13  Adam Barth  <abarth@webkit.org>
1010
1011         Remove --dry-run support from webkit-patch
1012         https://bugs.webkit.org/show_bug.cgi?id=76300
1013
1014         Reviewed by Dirk Pranke.
1015
1016         This is the rest of the patch from Bug 76300.  I landed it separtely
1017         because main.py had some stray conflict markers that I needed to clean
1018         up first.
1019
1020         * Scripts/webkitpy/test/main.py:
1021         (Tester.parse_args):
1022         (Tester._run_tests):
1023
1024 2012-01-13  Adam Barth  <abarth@webkit.org>
1025
1026         test-webkitpy does not run
1027         https://bugs.webkit.org/show_bug.cgi?id=76318
1028
1029         Unreviewed.
1030
1031         Looks like some conflict markers got left in the file.
1032
1033         * Scripts/webkitpy/test/main.py:
1034         (Tester.run):
1035
1036 2012-01-13  Adam Barth  <abarth@webkit.org>
1037
1038         Remove --dry-run support from webkit-patch
1039         https://bugs.webkit.org/show_bug.cgi?id=76300
1040
1041         Reviewed by Dirk Pranke.
1042
1043         We don't use this functionality for anything, and it doesn't really
1044         work.  Someone in #webkit tried using it and and got sad/confused.  We
1045         should just remove it.
1046
1047         * Scripts/webkitpy/common/checkout/scm/git.py:
1048         (Git.push_local_commits_to_server):
1049         * Scripts/webkitpy/common/checkout/scm/scm.py:
1050         (SCM.__init__):
1051         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1052         (_shared_test_commit_with_message):
1053         (GitSVNTest.test_commit_text_parsing):
1054         * Scripts/webkitpy/common/checkout/scm/svn.py:
1055         (SVN.commit_with_message):
1056         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1057         (Bugzilla.__init__):
1058         (Bugzilla.quips):
1059         (Bugzilla.authenticate):
1060         (Bugzilla.add_attachment_to_bug):
1061         (Bugzilla.add_patch_to_bug):
1062         (Bugzilla.create_bug):
1063         (Bugzilla.clear_attachment_flags):
1064         (Bugzilla.set_flag_on_attachment):
1065         (Bugzilla.obsolete_attachment):
1066         (Bugzilla.add_cc_to_bug):
1067         (Bugzilla.post_comment_to_bug):
1068         (Bugzilla.close_bug_as_fixed):
1069         (Bugzilla.reassign_bug):
1070         (reopen_bug):
1071         * Scripts/webkitpy/test/main.py:
1072         (Tester.parse_args):
1073         (Tester.run_tests):
1074
1075 2012-01-13  David Levin  <levin@chromium.org>
1076
1077         check-webkit-style: should encourage the use of Own* classes for Windows DC.
1078         https://bugs.webkit.org/show_bug.cgi?id=76227
1079
1080         Reviewed by Dirk Pranke.
1081
1082         * Scripts/webkitpy/style/checkers/cpp.py:
1083         (check_for_leaky_patterns): The new check.
1084         (process_line): Added a call to the new check.
1085         (CppChecker): Added the new error type.
1086         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1087         (CppStyleTestBase):
1088         (CppStyleTestBase.perform_leaky_pattern_check):
1089         The check for only leaky pattern errors.
1090         (LeakyPatternTest): Test cases.
1091
1092 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1093
1094         test-webkitpy: clean up handling of test directories, QueueStatusServer
1095         https://bugs.webkit.org/show_bug.cgi?id=76238
1096
1097         Reviewed by Adam Barth.
1098
1099         This patch cleans up a bunch of hacks related to how we find all
1100         of the python unit tests and set up the sys.path variable in
1101         test-webkitpy.
1102
1103         This patch changes how test-webkitpy works slightly in that we
1104         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
1105         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
1106         This greatly simplifies the mapping of paths to module names and
1107         appears to have no significant performance impact or other drawbacks.
1108
1109         There are other ways that we could remove all of the hacks and
1110         still have a more flexible mapping of paths to module names, but
1111         the ones I've thought of so far add a decent amount of complexity to
1112         the implementation and don't seem to buy us much.
1113         
1114         * QueueStatusServer/__init__.py:
1115         * Scripts/test-webkitpy:
1116         * Scripts/webkitpy/test/main.py:
1117         (Tester._modules_from_paths):
1118         (Tester._is_module):
1119
1120 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1121
1122         test-webkitpy: should support classes and individual test names as well as modules
1123         https://bugs.webkit.org/show_bug.cgi?id=76233
1124
1125         Reviewed by Adam Barth.
1126
1127         The default unittest.main() supports a list of individual
1128         TestCase classes or individual tests as well as modules. This
1129         change adds support for the same to test-webkitpy, so now you
1130         can say
1131
1132           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
1133
1134         and
1135
1136           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
1137
1138         in addition to
1139
1140           % test-wekbitpy webkitpy.test.cat_unittest
1141
1142         * Scripts/test-webkitpy:
1143         * Scripts/webkitpy/test/cat_unittest.py:
1144         * Scripts/webkitpy/test/main.py:
1145         (Tester.parse_args):
1146         (Tester.run):
1147         (Tester):
1148         (Tester._find_modules):
1149         (Tester._exclude):
1150         (Tester._run_tests):
1151         (Tester._is_module):
1152         (Tester._log_exception):
1153
1154 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1155
1156         test-webkitpy: add basic code coverage support
1157         https://bugs.webkit.org/show_bug.cgi?id=76201
1158
1159         Reviewed by Adam Barth.
1160
1161         This test adds basic code coverage support to test-webkitpy; if
1162         you pass the -c flag, we will generate a new coverage file. We
1163         can start simply with this and add more features as necessary.
1164
1165         This patch requires coverage to be already installed on the
1166         machine. I am not auto-installing this for now.
1167
1168         * Scripts/webkitpy/test/main.py:
1169         (Tester.parse_args):
1170         (Tester.run_tests):
1171
1172 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1173
1174         StatusBubbleTest.test_build_bubble is failing
1175         https://bugs.webkit.org/show_bug.cgi?id=76222
1176
1177         Reviewed by Adam Barth.
1178
1179         * QueueStatusServer/handlers/statusbubble_unittest.py:
1180         (StatusBubbleTest.test_build_bubble):
1181
1182 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1183
1184         nrwt should use multiple http shards
1185         https://bugs.webkit.org/show_bug.cgi?id=75958
1186
1187         Add --max-locked-shards option to the nrwt for manual set
1188         the maximum number of the locked shards
1189
1190         Reviewed by Dirk Pranke.
1191
1192         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1193         (Manager._max_locked_shards):
1194         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1195         (ShardingTests.get_shards):
1196         (ShardingTests.test_multiple_locked_shards):
1197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1198         (parse_args):
1199
1200 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1201
1202         prepare-ChangeLog: Look for a text editor in a few more variables.
1203         https://bugs.webkit.org/show_bug.cgi?id=76289
1204
1205         Reviewed by Ryosuke Niwa.
1206
1207         A text editor was looked for only in the CHANGE_LOG_EDITOR and
1208         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
1209         to the OS X-specific open(1) command.
1210
1211         As there does not seem to be a common way of looking for a text editor
1212         among the scripts in Tools/Scripts right now, just look at $VISUAL and
1213         $EDITOR (set much more often than the other variables in Unix systems)
1214         before falling back to open(1).
1215
1216         * Scripts/prepare-ChangeLog:
1217         (openChangeLogs):
1218
1219 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1220
1221         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
1222         https://bugs.webkit.org/show_bug.cgi?id=76269
1223
1224         Reviewed by Martin Robinson.
1225
1226         * gtk/gtkdoc.py:
1227         (GTKDoc._run_gtkdoc_scangobj):
1228
1229 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1230
1231         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
1232         https://bugs.webkit.org/show_bug.cgi?id=76247
1233
1234         Reviewed by Kenneth Rohde Christiansen.
1235
1236         * WebKitTestRunner/TestController.cpp:
1237         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
1238
1239 2012-01-13  Hajime Morrita  <morrita@chromium.org>
1240
1241         [Mac][DRT] Should support --no-timeout
1242         https://bugs.webkit.org/show_bug.cgi?id=76242
1243
1244         Reviewed by Darin Adler.
1245
1246         * DumpRenderTree/mac/DumpRenderTree.mm:
1247         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
1248         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
1249         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
1250         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1251         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1252         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
1253
1254 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
1255
1256         Mitigate scrollbar differences when running pixel tests
1257         https://bugs.webkit.org/show_bug.cgi?id=67217
1258
1259         Reviewed by Dan Bernstein.
1260         
1261         Enable mock scrollbars by default for tests.
1262
1263         * DumpRenderTree/mac/DumpRenderTree.mm:
1264         (resetDefaultsToConsistentValues):
1265         * WebKitTestRunner/TestController.cpp:
1266         (WTR::TestController::resetStateToConsistentValues):
1267
1268 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1269
1270         Need a script to run tests in PerformanceTests
1271         https://bugs.webkit.org/show_bug.cgi?id=76132
1272
1273         Reviewed by Adam Barth.
1274
1275         Add run-perf-tests to run performance tests using parser/resources/runner.js.
1276         Unfortunately, there isn't an easy way of telling which test uses which format
1277         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
1278
1279         All test outputs are re-formatted to match Chromium perf-bot style.
1280
1281         * Scripts/run-inspector-perf-tests.py:
1282         * Scripts/run-perf-tests: Added.
1283         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1284         (PerfTestsRunner):
1285         (PerfTestsRunner.__init__):
1286         (PerfTestsRunner._collect_tests):
1287         (PerfTestsRunner.run):
1288         (PerfTestsRunner._print_status):
1289         (PerfTestsRunner._run_tests_set):
1290         (PerfTestsRunner._process_chromium_style_test_result):
1291         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1292         (PerfTestsRunner._process_parser_test_result):
1293         (PerfTestsRunner._run_single_test):
1294         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1295         (MainTest.TestDriver.run_test):
1296         (create_runner):
1297         (run_test):
1298         (test_run_test_set):
1299         (test_run_test_set_for_parser_tests):
1300         (test_collect_tests):
1301
1302 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1303
1304         webkitpy: clean up port unit tests in preparation for making port_name mandatory
1305         https://bugs.webkit.org/show_bug.cgi?id=76123
1306
1307         Reviewed by Adam Barth.
1308
1309         This change updates the unit tests to be more consistent in how
1310         ports are created, in preparation for making port_name a
1311         mandatory parameter to the constructor and removing any version
1312         interpretation from it.
1313
1314         There should be no functional changes in this patch, but some
1315         tests that are no longer relevant have been removed or reworked.
1316
1317         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1318         (PortTest.test_get_option__default):
1319         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1320         (ChromiumLinuxPortTest):
1321         (ChromiumLinuxPortTest.assert_architecture):
1322         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1323         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1324         (ChromiumMacPortTest):
1325         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1326         (ChromiumPortTest):
1327         (ChromiumPortTest.test_all_test_configurations):
1328         (ChromiumPortTest.TestMacPort.__init__):
1329         (ChromiumPortTest.TestLinuxPort.__init__):
1330         (ChromiumPortTest.TestWinPort.__init__):
1331         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1332         (ChromiumWinTest):
1333         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1334         (EflPortTest):
1335         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1336         (GtkPortTest):
1337         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1338         (MacTest):
1339         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1340         (MockDRTPortTest):
1341         (MockDRTPortTest.make_port):
1342         * Scripts/webkitpy/layout_tests/port/qt.py:
1343         (QtPort._port_flag_for_scripts):
1344         (QtPort.__init__):
1345         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1346         (QtPortTest):
1347         (QtPortTest._assert_search_path):
1348         (QtPortTest.test_baseline_search_path):
1349         (QtPortTest.test_operating_system):
1350         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1351         (WebKitPortTest):
1352         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1353         (WinPortTest):
1354         (WinPortTest._assert_search_path):
1355         (WinPortTest.test_baseline_search_path):
1356         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1357         (get_test_config.TestMacPort.__init__):
1358
1359 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1360
1361         test-webkitpy: clean up logging and provide a real --help message
1362         https://bugs.webkit.org/show_bug.cgi?id=76142
1363
1364         Reviewed by Adam Barth.
1365
1366         This test is mostly more refactoring - it calls objects in
1367         unittest directly instead of routing through unittest.main() --
1368         in order to gain more control over the logging and to provide a
1369         correct --help message. This will also give us a better
1370         foundation for adding more feautures down the road.
1371
1372         This patch adds different levels of logging controlled by the
1373         '-s', '-q', and '-v' options (see --help for details), and
1374         removes the --verbose-logging option.
1375
1376         * Scripts/test-webkitpy:
1377         * Scripts/webkitpy/test/main.py:
1378         (Tester):
1379         (Tester.clean_packages):
1380         (Tester.__init__):
1381         (Tester.parse_args):
1382         (Tester.configure):
1383         (Tester._configure_logging):
1384         (Tester.find_modules):
1385         (Tester._exclude):
1386         (Tester._modules_from_paths):
1387         (Tester.run_tests):
1388
1389 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1390
1391         Make the new WTF module build on Qt
1392         https://bugs.webkit.org/show_bug.cgi?id=76163
1393
1394         Reviewed by Tor Arne Vestbø.
1395
1396         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
1397
1398 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1399
1400         Unreviewed, mac DumpRenderTree fix.
1401
1402         * DumpRenderTree/mac/UIDelegate.mm:
1403         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1404
1405 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1406
1407         WebKitTestRunner should not print console message line number when it is equal to zero.
1408         https://bugs.webkit.org/show_bug.cgi?id=76167
1409
1410         Reviewed by Csaba Osztrogonác.
1411
1412         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1413         (WTR::InjectedBundlePage::willAddMessageToConsole):
1414
1415 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
1416
1417         Make default console messages line numbers consistent.
1418         https://bugs.webkit.org/show_bug.cgi?id=74075
1419
1420         Reviewed by Pavel Feldman.
1421
1422         Unset line numbers are not printed to console now.
1423         Added Source/WebCore/inspector to efl DumpRenderTree include path.
1424
1425         * DumpRenderTree/chromium/WebViewHost.cpp:
1426         (WebViewHost::didAddMessageToConsole):
1427         * DumpRenderTree/efl/CMakeLists.txt:
1428         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1429         (onConsoleMessage):
1430         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1431         (webViewConsoleMessage):
1432         * DumpRenderTree/mac/UIDelegate.mm:
1433         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1434         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1435         (WebCore::WebPage::javaScriptConsoleMessage):
1436         * DumpRenderTree/win/UIDelegate.cpp:
1437         (UIDelegate::webViewAddMessageToConsole):
1438         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1439         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1440
1441 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
1442
1443         test-webkitpy: push more logic into webkitpy.test.main, clean up code
1444         https://bugs.webkit.org/show_bug.cgi?id=76021
1445
1446         Reviewed by Eric Seidel.
1447
1448         I plan to add more functionality to test-webkitpy, but it is
1449         difficult to hack on now; this patch is the first of two that
1450         brings test-webkitpy more inline with current coding style by
1451         pushing more logic into the webkitpy.test.main.Tester class (so
1452         that it will be testable itself).
1453         
1454         There should be no functional changes in this patch.
1455
1456         * Scripts/test-webkitpy:
1457         (_path_from_webkit_root):
1458         * Scripts/webkitpy/test/main.py:
1459         (Tester):
1460         (Tester.init):
1461         (Tester.configure_logging):
1462         (Tester.configure_logging.filter):
1463         (Tester.clean_packages):
1464         (Tester.run_tests):
1465
1466 2012-01-11  Wei Jia  <wjia@chromium.org>
1467
1468         implement layout tests for <video> with media stream
1469         https://bugs.webkit.org/show_bug.cgi?id=74882
1470
1471         Reviewed by Kent Tamura.
1472
1473         * DumpRenderTree/DumpRenderTree.gypi:
1474         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
1475         (WebKit::WebUserMediaClientMock::create):
1476         (WebKit::WebUserMediaClientMock::IsMockStream):
1477         (WebKit::WebUserMediaClientMock::requestUserMedia):
1478         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
1479         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
1480         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
1481         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
1482         * DumpRenderTree/chromium/WebViewHost.cpp:
1483         (WebViewHost::userMediaClient):
1484         (WebViewHost::userMediaClientMock):
1485         (WebViewHost::createMediaPlayer):
1486         (WebViewHost::mediaStreamUtil):
1487         (WebViewHost::testMediaStreamClient):
1488         * DumpRenderTree/chromium/WebViewHost.h:
1489
1490 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1491
1492         Unreviewed, build fix.
1493
1494         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
1495
1496         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1497         (ChromiumWinPort.__init__):
1498
1499 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1500
1501         Sheriffbot build fix. Don't emit empty lines on IRC.
1502
1503         * Scripts/webkitpy/tool/bot/irc_command.py:
1504         (LastGreenRevision.execute):
1505
1506 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1507
1508         last-green-revision should report the revision that succeeded on all bots
1509         https://bugs.webkit.org/show_bug.cgi?id=76109
1510
1511         Reviewed by Adam Barth.
1512
1513         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
1514         considered green by this algorithm, all matching builders must have a successful run at the revision
1515         or two consecutive successful runs before and after the revision.
1516
1517         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
1518         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
1519
1520         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1521         (BuildBot._revisions_for_builder):
1522         (BuildBot):
1523         (BuildBot._find_green_revision):
1524         (BuildBot.last_green_revision):
1525         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1526         (MockBuildBot.last_green_revision):
1527         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1528         (test_revisions_for_builder):
1529         (test_find_green_revision):
1530         (test_last_green_revision):
1531         * Scripts/webkitpy/tool/bot/irc_command.py:
1532         (LastGreenRevision.execute):
1533         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1534         (SheriffIRCBotTest.test_lgr):
1535         * Scripts/webkitpy/tool/commands/queries.py:
1536         (LastGreenRevision):
1537
1538 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1539
1540         Unreviewed, fix build bustage on win32 introduced by r104725.
1541
1542         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1543         (MockDRTPortTest.make_port):
1544         (MockChromiumDRTTest.test_pixeltest__fails):
1545
1546 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
1547
1548         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
1549         https://bugs.webkit.org/show_bug.cgi?id=75618
1550
1551         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
1552
1553         Reviewed by Tony Chang.
1554
1555         * DumpRenderTree/chromium/LayoutTestHelper.mm:
1556         (installLayoutTestColorProfile):
1557         (restoreUserColorProfile):
1558         (main):
1559
1560 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1561
1562         test-webkitpy: fix -v and eliminate some spurious warnings
1563         https://bugs.webkit.org/show_bug.cgi?id=76099
1564
1565         Reviewed by Adam Barth.
1566
1567         when we added support for --xml output, we broke the -v flag.
1568
1569         Also, fix the code to swallow a harmless warning from
1570         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
1571
1572         test-webkitpy is now silent again except for the one known
1573         logging issue.
1574
1575         * Scripts/webkitpy/common/checkout/checkout.py:
1576         (Checkout.commit_message_for_this_commit):
1577         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1578         (test_commit_message_for_this_commit):
1579         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1580         (JSONChecker.check):
1581         (JSONChecker.line_number_from_json_exception):
1582         * Scripts/webkitpy/test/main.py:
1583         (Tester.run_tests):
1584
1585 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1586
1587         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
1588         https://bugs.webkit.org/show_bug.cgi?id=76084
1589
1590         Reviewed by Adam Barth.
1591
1592         This will help make it easier to catch layering violations. This
1593         change just refactors test code; there are no changes to
1594         production code.
1595
1596         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1597         (PortTest.make_port):
1598         (PortTest.test_find_no_paths_specified):
1599         (PortTest.test_find_one_test):
1600         (PortTest.test_find_glob):
1601         (PortTest.test_find_with_skipped_directories):
1602         (PortTest.test_find_with_skipped_directories_2):
1603         (PortTest.test_parse_reftest_list):
1604         (PortTest.test_httpd_returns_error_code):
1605         (PortTest.test_virtual_methods):
1606         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1607         (ChromiumGpuTest.assert_port_works):
1608         (ChromiumGpuTest._assert_baseline_path):
1609         (ChromiumGpuTest.test_graphics_type):
1610         (ChromiumGpuTest.test_default_tests_paths.test_paths):
1611         (ChromiumGpuTest.test_test_files):
1612         (ChromiumGpuTest.test_test_files.test_paths):
1613         (ChromiumGpuTest):
1614         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1615         (ChromiumLinuxPortTest.assert_architecture):
1616         (ChromiumLinuxPortTest.test_check_illegal_port_names):
1617         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1618         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1619         (DriverTest.make_port):
1620         (DriverTest):
1621         (DriverTest.assertVirtual):
1622         (DriverTest._assert_wrapper):
1623         (DriverTest.test_virtual_driver_methods):
1624         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1625         (MockDRTPortTest.make_port):
1626         (MockDRTPortTest.test_port_name_in_constructor):
1627         (MockDRTTest.assertTest):
1628         (MockDRTTest.test_main):
1629         (MockChromiumDRTTest.test_pixeltest__fails):
1630         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1631         (QtPortTest._assert_search_path):
1632         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1633         (TestWebKitPort.__init__):
1634         (WebKitPortUnitTests.test_default_options):
1635         (test_runtime_feature_list):
1636         (test_test_expectations):
1637
1638 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1639
1640         Style skipped tests in the flakiness dashboard
1641         https://bugs.webkit.org/show_bug.cgi?id=76091
1642
1643         Reviewed by Tony Chang.
1644
1645         * TestResultServer/static-dashboards/dashboard_base.js:
1646         Removed "FLAKY" from this list since we don't ever mark individual runs
1647         as flaky. Also deleted an outdated line.
1648         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1649
1650 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1651
1652         Remove gtest normalization code from the test results server
1653         https://bugs.webkit.org/show_bug.cgi?id=76089
1654
1655         Reviewed by Tony Chang.
1656
1657         The normalization now happens on the gtest side.
1658
1659         * TestResultServer/model/jsonresults.py:
1660         (JsonResults.merge):
1661         * TestResultServer/model/jsonresults_unittest.py:
1662         (JsonResultsTest.test_gtest):
1663
1664 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1665
1666         Be more aggressive about deleting unnecessary results from the test-results-server json files
1667         https://bugs.webkit.org/show_bug.cgi?id=76086
1668
1669         Reviewed by Tony Chang.
1670
1671         Remove any tests that only contain skip/pass/nodata values whose runtime
1672         is less than 5 seconds.
1673
1674         * TestResultServer/model/jsonresults.py:
1675         (JsonResults._normalize_results_json):
1676         * TestResultServer/model/jsonresults_unittest.py:
1677         (JsonResultsTest.test_merge_remove_test):
1678         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
1679
1680 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1681
1682         last-green-revision should give us per-bot information
1683         https://bugs.webkit.org/show_bug.cgi?id=76011
1684
1685         Reviewed by Adam Barth.
1686
1687         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
1688         we report the latest green run on each bot from the last 100 runs.
1689
1690         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1691         (BuildBot._fetch_builder_page):
1692         (BuildBot):
1693         (BuildBot._green_revision_for_builder):
1694         (BuildBot.last_green_revision):
1695         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1696         (test_green_revision_for_builder):
1697         (test_last_green_revision):
1698         * Scripts/webkitpy/tool/bot/irc_command.py:
1699         (LastGreenRevision.execute):
1700         * Scripts/webkitpy/tool/commands/queries.py:
1701         (LastGreenRevision.execute):
1702
1703 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1704
1705         webkitpy: clean up version detection in webkitpy.layout_tests.port
1706         https://bugs.webkit.org/show_bug.cgi?id=76016
1707
1708         Reviewed by Adam Barth.
1709
1710         This change updates the code in webkitpy.layout_tests.port to
1711         use the new os_name and os_version fields on host.platform. This
1712         gets layout_tests.port out of the version parsing business. Most
1713         of the diffs are just cleaning up test code to accomodate the
1714         changes.
1715
1716         * Scripts/webkitpy/common/system/executive_mock.py:
1717         (MockExecutive):
1718         (MockExecutive.ignore_error):
1719         (MockExecutive2):
1720         (MockExecutive2.ignore_error):
1721         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1722         (MockPlatformInfo.is_mac):
1723         (MockPlatformInfo.is_linux):
1724         (MockPlatformInfo.is_win):
1725         * Scripts/webkitpy/common/system/systemhost_mock.py:
1726         (MockSystemHost.__init__):
1727         * Scripts/webkitpy/layout_tests/port/apple.py:
1728         (ApplePort.__init__):
1729         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1730         (ChromiumMacPort.__init__):
1731         (ChromiumMacPort.check_wdiff):
1732         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1733         (ChromiumMacPortTest):
1734         (ChromiumMacPortTest.assert_name):
1735         (ChromiumMacPortTest.test_versions):
1736         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1737         (ChromiumPortTest.test_all_test_configurations):
1738         (ChromiumPortTest.TestMacPort.__init__):
1739         (ChromiumPortTest.TestLinuxPort.__init__):
1740         (ChromiumPortTest.TestWinPort.__init__):
1741         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1742         (ChromiumWinPort.__init__):
1743         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1744         (ChromiumWinTest):
1745         (ChromiumWinTest.assert_name):
1746         (ChromiumWinTest.test_versions):
1747         (ChromiumWinTest.test_baseline_path):
1748         (ChromiumWinTest.test_build_path):
1749         * Scripts/webkitpy/layout_tests/port/factory.py:
1750         (PortFactory._port_name_from_arguments_and_options):
1751         (PortFactory.get):
1752         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1753         (FactoryTest):
1754         (FactoryTest.setUp):
1755         (FactoryTest.assert_port):
1756         (FactoryTest.test_mac):
1757         (FactoryTest.test_win):
1758         (FactoryTest.test_google_chrome):
1759         (FactoryTest.test_gtk):
1760         (FactoryTest.test_qt):
1761         (FactoryTest.test_chromium_gpu):
1762         (FactoryTest.test_chromium_gpu_linux):
1763         (FactoryTest.test_chromium_gpu_mac):
1764         (FactoryTest.test_chromium_gpu_win):
1765         (FactoryTest.test_chromium_mac):
1766         (FactoryTest.test_chromium_linux):
1767         (FactoryTest.test_chromium_win):
1768         (FactoryTest.test_unknown_specified):
1769         (FactoryTest.test_unknown_default):
1770         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1771         (TestGoogleChromePort):
1772         (TestGoogleChromePort._verify_baseline_path):
1773         (TestGoogleChromePort._verify_expectations_overrides):
1774         (TestGoogleChromePort.test_get_google_chrome_port):
1775         * Scripts/webkitpy/layout_tests/port/mac.py:
1776         (MacPort):
1777         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1778         (MacTest):
1779         (assert_name):
1780         (test_tests_for_other_platforms):
1781         (test_version):
1782         (test_versions):
1783         (test_is_version_methods):
1784         (test_setup_environ_for_server):
1785         (_assert_search_path):
1786         (test_show_results_html_file):
1787         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1788         (PortTestCase):
1789         (PortTestCase.make_port):
1790         * Scripts/webkitpy/layout_tests/port/win.py:
1791         (WinPort):
1792         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1793         (WinPortTest):
1794         (WinPortTest.test_show_results_html_file):
1795         (WinPortTest._assert_search_path):
1796         (WinPortTest._assert_version):
1797
1798 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
1799
1800         [Qt][WK2] Remove workaround introduced into bug 75470
1801         https://bugs.webkit.org/show_bug.cgi?id=75889
1802
1803         Reviewed by Tor Arne Vestbø.
1804
1805         * MiniBrowser/qt/qml/BrowserWindow.qml:
1806
1807 2012-01-10  Dmitry Lomov  <dslomov@google.com>
1808
1809         [Chromium] Remove obsolete references to WebWorker class.
1810         https://bugs.webkit.org/show_bug.cgi?id=76020
1811
1812         Reviewed by David Levin.
1813
1814         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
1815         * DumpRenderTree/chromium/WebViewHost.cpp:
1816         * DumpRenderTree/chromium/WebViewHost.h:
1817
1818 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1819
1820         [Qt] Some css3 filter tests are failing after r104698
1821         https://bugs.webkit.org/show_bug.cgi?id=76055
1822
1823         Reviewed by Simon Hausmann.
1824
1825         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1826         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
1827
1828 2012-01-11  Tony Chang  <tony@chromium.org>
1829
1830         Don't remove 0 byte files when running build-webkit --chromium
1831         https://bugs.webkit.org/show_bug.cgi?id=75997
1832
1833         Reviewed by Csaba Osztrogonác.
1834
1835         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
1836
1837         * Scripts/webkitdirs.pm:
1838         (determineIsQt):
1839
1840 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1841
1842         Add TestWebKitAPI tests for KURL
1843         <http://webkit.org/b/75774>
1844
1845         Reviewed by Adam Barth.
1846
1847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
1848         WebCore folder and KURL.cpp source file to the project.
1849         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
1850         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
1851         during setup since this test doesn't go through WebKit or
1852         WebKit2.
1853         (TestWebKitAPI::TEST_F): Add two basic tests.
1854
1855 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1856
1857         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
1858
1859         Reviewed by Adam Barth.
1860
1861         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
1862
1863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1864         WTFStringUtilities.h to the project.
1865         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
1866         WTFStringUtilities.h.
1867         * TestWebKitAPI/WTFStringUtilities.h: Added.
1868         (WTF::operator<<):
1869
1870 2012-01-10  Vincent Scheib  <scheib@chromium.org>
1871
1872         Clarify run-webkit-tests options reset-results and new-baseline
1873         https://bugs.webkit.org/show_bug.cgi?id=75993
1874
1875         Reviewed by Dirk Pranke.
1876
1877         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1878         (parse_args):
1879
1880 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
1881
1882         Disabled mock scrollbars should draw differently
1883         https://bugs.webkit.org/show_bug.cgi?id=75995
1884
1885         Reviewed by James Robinson.
1886
1887         When the scrollbar is disabled, paint the entire track of
1888         mock scrollbars with a lighter gray, and hide the thumb.
1889
1890         * DumpRenderTree/mac/DumpRenderTree.mm:
1891         (-[DRTMockScroller drawKnob]):
1892         (-[DRTMockScroller drawRect:]):
1893
1894 2012-01-10  James Robinson  <jamesr@chromium.org>
1895
1896         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
1897         https://bugs.webkit.org/show_bug.cgi?id=75988
1898
1899         Reviewed by Adam Barth.
1900
1901         * Scripts/webkitpy/common/config/ports.py:
1902         (WebKitPort.run_webkit_unit_tests_command):
1903         (WebKitPort):
1904         (ChromiumPort.run_webkit_unit_tests_command):
1905         (ChromiumPort):
1906         * Scripts/webkitpy/common/config/ports_mock.py:
1907         (MockPort.run_webkit_unit_tests_command):
1908         * Scripts/webkitpy/tool/commands/download_unittest.py:
1909         (DownloadCommandsTest.test_build_and_test):
1910         (test_land):
1911         (test_land_red_builders):
1912         * Scripts/webkitpy/tool/steps/runtests.py:
1913         (RunTests.run):
1914         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1915
1916 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
1917
1918         webkitpy: add os_name, os_version to platforminfo
1919         https://bugs.webkit.org/show_bug.cgi?id=75931
1920
1921         Reviewed by Eric Siedel.
1922
1923         As a first step in cleaning up the version parsing logic in
1924         webkitpy.layout_tests.port, this adds common routines for
1925         getting the os_name and os_version fields to the PlatformInfo
1926         class. Nothing uses them yet but I've added FIXME's to some of
1927         the code that needs to be deleted in the port files.
1928
1929         * Scripts/webkitpy/common/system/platforminfo.py:
1930         (PlatformInfo.__init__):
1931         (PlatformInfo):
1932         (PlatformInfo._determine_os_name):
1933         (PlatformInfo._determine_mac_version):
1934         (PlatformInfo._determine_linux_version):
1935         (PlatformInfo._determine_win_version):
1936         (PlatformInfo.display_name):
1937         (PlatformInfo.total_bytes_memory):
1938         (PlatformInfo._compute_bytes_from_vm_stat_output):
1939         (PlatformInfo.free_bytes_memory):
1940         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
1941         (TestPlatformInfo):
1942         (TestPlatformInfo.make_info):
1943         (TestPlatformInfo.make_info.mock_run_command):
1944         (TestPlatformInfo.setUp):
1945         (TestPlatformInfo.tearDown):
1946         (TestPlatformInfo.test_basic):
1947         (TestPlatformInfo.integration_test_basic):
1948         (TestPlatformInfo.test_display_name_mac):
1949         (TestPlatformInfo.test_display_name_win32):
1950         (TestPlatformInfo.test_memory_mac):
1951         (TestPlatformInfo.test_memory_win32):
1952         (TestPlatformInfo.test_determine_os_name):
1953         (TestPlatformInfo.test_determine_mac_version):
1954         (TestPlatformInfo.test_determine_linux_version):
1955         (TestPlatformInfo.test_determine_win_version_from_tuple):
1956         (TestPlatformInfo.test_determine_win_version_from_cmd):
1957         * Scripts/webkitpy/layout_tests/port/apple.py:
1958         (ApplePort.__init__):
1959         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1960         (ChromiumMacPort.__init__):
1961         * Scripts/webkitpy/layout_tests/port/mac.py:
1962         (MacPort):
1963         * Scripts/webkitpy/layout_tests/port/win.py:
1964         (WinPort):
1965
1966 2012-01-10  Adam Roben  <aroben@apple.com>
1967
1968         Make it possible to type data: URLs into MiniBrowser on Windows
1969
1970         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
1971         MiniBrowser on Windows
1972
1973         Reviewed by Darin Adler.
1974
1975         * MiniBrowser/win/BrowserWindow.cpp:
1976         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
1977         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
1978         does, we assume it already has a scheme and don't modify it.
1979
1980 2012-01-10  Adam Roben  <aroben@apple.com>
1981
1982         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
1983
1984         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
1985         MiniBrowser on Windows
1986
1987         Reviewed by Darin Adler.
1988
1989         * MiniBrowser/win/BrowserView.cpp:
1990         (BrowserView::goToURL): Pass the typed string through
1991         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
1992
1993 2012-01-10  Ben Wells  <benwells@chromium.org>
1994
1995         Adding myself (benwells) to committers.py
1996         https://bugs.webkit.org/show_bug.cgi?id=75971
1997
1998         Reviewed by Ojan Vafai.
1999
2000         * Scripts/webkitpy/common/config/committers.py:
2001
2002 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
2003
2004         AX: support helpText() in DumpRenderTree
2005         https://bugs.webkit.org/show_bug.cgi?id=40193
2006
2007         Reviewed by Chris Fleizach.
2008
2009         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2010         (AccessibilityUIElement::helpText): Implemented.
2011
2012 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2013
2014         Unreviewed, rolling out r104572.
2015         http://trac.webkit.org/changeset/104572
2016         https://bugs.webkit.org/show_bug.cgi?id=75967
2017
2018         It broke zillion tests (Requested by Ossy on #webkit).
2019
2020         * DumpRenderTree/qt/EventSenderQt.cpp:
2021         (EventSender::EventSender):
2022         (EventSender::sendOrQueueEvent):
2023         (EventSender::replaySavedEvents):
2024         (EventSender::eventFilter):
2025         * DumpRenderTree/qt/EventSenderQt.h:
2026
2027 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
2028
2029         [Qt] fast/events/dont-loose-last-event test fails on WK1
2030         https://bugs.webkit.org/show_bug.cgi?id=73894
2031
2032         Reviewed by Simon Hausmann.
2033
2034         Empty the entire event queue when requested besides using
2035         sendEvent instead of postEvent to make sure all events were
2036         delivered.
2037         This commit also removes not working DRT code to handle drag and drop,
2038         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
2039
2040         * DumpRenderTree/qt/EventSenderQt.cpp:
2041         (EventSender::EventSender):
2042         (EventSender::sendOrQueueEvent):
2043         (EventSender::replaySavedEvents):
2044         * DumpRenderTree/qt/EventSenderQt.h:
2045
2046 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
2047
2048         [Qt] Enable CSS_FILTERS in Qt build
2049         https://bugs.webkit.org/show_bug.cgi?id=75777
2050
2051         Add the CSS_FILTERS feature flag to Qt.
2052
2053         Reviewed by Kenneth Rohde Christiansen.
2054
2055         * qmake/mkspecs/features/features.prf:
2056
2057 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2058
2059         [Qt] Unreviewed -Werror build fix.
2060
2061         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2062         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
2063         declaration.
2064
2065 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2066
2067         [Qt] Remove dependency to uitools
2068         https://bugs.webkit.org/show_bug.cgi?id=75952
2069
2070         Reviewed by Tor Arne Vestbø.
2071
2072         QUiLoader is used for creating QLabel/QProgressBar widgets for
2073         a layout test, to verify some widget embedding feature. Unfortunately
2074         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
2075         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
2076         let's break the circular dependency.
2077
2078         * DumpRenderTree/qt/DumpRenderTree.pro:
2079         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2080         (WebCore::WebPage::createPlugin):
2081         * QtTestBrowser/QtTestBrowser.pro:
2082         * QtTestBrowser/launcherwindow.h:
2083         * QtTestBrowser/webpage.cpp:
2084         (WebPage::createPlugin):
2085         * qmake/mkspecs/features/minimal_qt.prf:
2086         * qmake/mkspecs/features/uitools.prf: Removed.
2087
2088 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
2089
2090         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
2091         https://bugs.webkit.org/show_bug.cgi?id=75894
2092
2093         Reviewed by Tor Arne Vestbø.
2094
2095         * MiniBrowser/qt/MiniBrowserApplication.h:
2096         (MiniBrowserApplication::windowOptions):
2097         * MiniBrowser/qt/main.cpp:
2098         (main):
2099
2100 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2101
2102         [Qt] DRT crashes with Qt 5
2103         https://bugs.webkit.org/show_bug.cgi?id=75951
2104
2105         Reviewed by Ossy.
2106
2107         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
2108         Qt relies on font-config to define the default font family.
2109
2110 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
2111
2112         [Qt] REGRESSION(r100130): Clean build feature is broken.
2113         https://bugs.webkit.org/show_bug.cgi?id=75863
2114
2115         Reviewed by Tor Arne Vestbø.
2116
2117         * Scripts/webkitdirs.pm:
2118         (buildQMakeProject):
2119
2120 2012-01-10  Zeno Albisser  <zeno@webkit.org>
2121
2122         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
2123         https://bugs.webkit.org/show_bug.cgi?id=75885
2124
2125         In QML events are propagated through parents. But since the
2126         WebView may consume key events, a shortcut might never reach
2127         the top QtQuickItem.
2128         Therefore an application wide event handling function in C++
2129         needs to take care of shortcuts for MiniBrowser.
2130
2131         Reviewed by Kenneth Rohde Christiansen.
2132
2133         * MiniBrowser/qt/BrowserWindow.cpp:
2134         (BrowserWindow::reload):
2135         (BrowserWindow::focusAddressBar):
2136         * MiniBrowser/qt/BrowserWindow.h:
2137         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2138         (MiniBrowserApplication::notify):
2139         * MiniBrowser/qt/qml/BrowserWindow.qml:
2140
2141 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2142
2143         Add --efl alias for --platform=efl to run-webkit-test
2144         https://bugs.webkit.org/show_bug.cgi?id=75937
2145
2146         Reviewed by Andreas Kling.
2147         
2148         * Scripts/run-webkit-tests: Add --efl alias.
2149         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
2150         (parse_args):
2151
2152 2012-01-09  Dan Bernstein  <mitz@apple.com>
2153
2154         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
2155         https://bugs.webkit.org/show_bug.cgi?id=75920
2156
2157         Reviewed by Darin Adler.
2158
2159         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2160         (TestWebKitAPI::TEST): Added a test for a range in a
2161         -webkit-user-select: none; block.
2162
2163 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2164
2165         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
2166         https://bugs.webkit.org/show_bug.cgi?id=75884
2167
2168         Reviewed by Ryosuke Niwa.
2169
2170         Fix regression introduced (revealed?) in r104340. Chromium file         
2171         url syntax is different on win32 and the test results weren't           
2172         expecting that.                                                         
2173
2174         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2175         (TestExpectations._report_errors):
2176         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2177         (test_parse_error_nonfatal):
2178         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2179         (MockDRTTest.input_line):
2180         (MockChromiumDRTTest.test_pixeltest__fails):
2181         * Scripts/webkitpy/layout_tests/port/test.py:
2182         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2183         (TestRebaseliner.make_rebaseliner):
2184         (TestRebaseliner.test_one_platform):
2185         (TestRebaseliner.test_all_platforms):
2186         (TestRebaseliner.test_png_file_with_comment):
2187         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
2188         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
2189         (TestRealMain.test_all_platforms):
2190
2191 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2192
2193         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
2194
2195         Unreviewed, build fix.
2196
2197         test-webkitpy had a built-in self-test routine to verify that
2198         deleting the .pyc files worked correctly. When I removed the
2199         python24 directory in r104482, I broke the self-test.
2200
2201         I have deleted the self-test for now. Since I am reworking
2202         test-webkitpy I will make sure the new version is adequately
2203         tested.
2204
2205         * Scripts/test-webkitpy:
2206         (configure_logging):
2207         (_clean_pyc_files):
2208         (_clean_packages):
2209         (init):
2210
2211 2012-01-09  Justin Novosad  <junov@chromium.org>
2212
2213         [Chromium] remove all references to the legacy accelerated 2d Canvas
2214         implementation
2215         https://bugs.webkit.org/show_bug.cgi?id=75108
2216
2217         Purging an old settings flag that is no longer referenced
2218
2219         Reviewed by Darin Fisher.
2220
2221         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2222         (main):
2223         * DumpRenderTree/chromium/TestShell.cpp:
2224         (TestShell::TestShell):
2225         (TestShell::resetWebSettings):
2226         * DumpRenderTree/chromium/TestShell.h:
2227         (TestShell::setAccelerated2dCanvasEnabled):
2228         * DumpRenderTree/chromium/WebPreferences.cpp:
2229         (WebPreferences::reset):
2230         (WebPreferences::applyTo):
2231         * DumpRenderTree/chromium/WebPreferences.h:
2232
2233 2012-01-09  Adam Roben  <aroben@apple.com>
2234
2235         Convert Cygwin paths to Windows paths before passing them to DRT
2236
2237         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
2238         NRWT
2239
2240         I couldn't find a way to test this because I couldn't figure out how to override the
2241         cygpath function as it is used by WebKitDriver.
2242
2243         Reviewed by Dirk Pranke.
2244
2245         * Scripts/webkitpy/layout_tests/port/webkit.py:
2246         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
2247         Windows-style path before passing it to DRT.
2248
2249 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
2250
2251         webkitpy: revamp version checking
2252         https://bugs.webkit.org/show_bug.cgi?id=75765
2253
2254         Reviewed by Adam Barth.
2255
2256         The version-checking code in webkitpy/python24/versioning seems really
2257         awkward and overdesigned, especially since we don't support python 2.4
2258         any more.
2259
2260         In addition, I am tired of getting warnings about Python 2.6 being "a
2261         newer release than what is supported" :).
2262
2263         I'm taking a page from the depot_tools python code and just creating a
2264         new webkitpy.common.version_check module that will print a message on
2265         stderr and call sys.exit() if we're running an unsupported version.
2266
2267         * Scripts/check-webkit-style:
2268         * Scripts/new-run-webkit-httpd:
2269         * Scripts/new-run-webkit-tests:
2270         * Scripts/rebaseline-chromium-webkit-tests:
2271         * Scripts/test-webkitpy:
2272         (configure_logging):
2273         (init):
2274         * Scripts/webkit-patch:
2275         (main):
2276         * Scripts/webkitpy/common/system/executive.py:
2277         (Executive._child_process_encoding):
2278         (Executive._should_encode_child_process_arguments):
2279         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
2280         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2281         * Scripts/webkitpy/python24/__init__.py: Removed.
2282         * Scripts/webkitpy/python24/versioning.py: Removed.
2283         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
2284
2285 2012-01-09  Adam Barth  <abarth@webkit.org>
2286
2287         Remove Chromium Mac CG from the flakiness dashboard
2288         https://bugs.webkit.org/show_bug.cgi?id=75873
2289
2290         Reviewed by Ojan Vafai.
2291
2292         This configuration no longer exists.
2293
2294         * TestResultServer/static-dashboards/builders.js:
2295         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2296         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2297         (testOverrideJustBuildType):
2298         (testPlatformAndBuildType):
2299
2300 2012-01-06  Adam Roben  <aroben@apple.com>
2301
2302         Print an error message when NRWT can't run Apache
2303
2304         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
2305
2306         Reviewed by Dirk Pranke.
2307
2308         * Scripts/webkitpy/layout_tests/port/base.py:
2309         (Port.check_httpd): Print an error message when Apache returns an error code instead of
2310         failing silently.
2311
2312         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2313         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
2314         run Apache.
2315         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
2316         fails.
2317
2318 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
2319
2320         [Gtk][ARM] Cross compiler buildbot is failing after r103040
2321         https://bugs.webkit.org/show_bug.cgi?id=75846
2322
2323         Reviewed by Philippe Normand.
2324
2325         * Scripts/webkitdirs.pm:
2326         (runAutogenForAutotoolsProjectIfNecessary):
2327
2328 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
2329
2330         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
2331         https://bugs.webkit.org/show_bug.cgi?id=75807
2332
2333         This patch adds a new icon to navigationbar of the Qt MiniBrowser
2334         which allows you to dynamically toggle whether touch mocking is
2335         enabled or disabled.
2336
2337         Reviewed by Tor Arne Vestbø.
2338
2339         * MiniBrowser/qt/MiniBrowser.qrc:
2340         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2341         (MiniBrowserApplication::notify):
2342         * MiniBrowser/qt/MiniBrowserApplication.h:
2343         (WindowOptions::WindowOptions):
2344         (WindowOptions::touchMockingEnabled):
2345         (WindowOptions::setTouchMockingEnabled):
2346         * MiniBrowser/qt/icons/touch.png: Added.
2347         * MiniBrowser/qt/qml/BrowserWindow.qml:
2348
2349 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2350
2351         Unreviewed. Fix make distcheck issues.
2352
2353         * MiniBrowser/gtk/GNUmakefile.am:
2354
2355 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2356
2357         Unreviewed, rolling out r104421.
2358         http://trac.webkit.org/changeset/104421
2359         https://bugs.webkit.org/show_bug.cgi?id=75816
2360
2361         Need to rebaseline some tests on Linux (Requested by noamr on
2362         #webkit).
2363
2364         * qmake/mkspecs/features/features.prf:
2365
2366 2012-01-08  Adam Barth  <abarth@webkit.org>
2367
2368         Remove support for Chromium Mac CG from garden-o-matic
2369         https://bugs.webkit.org/show_bug.cgi?id=75814
2370
2371         Reviewed by Eric Seidel.
2372
2373         This configuration no longer exists.  This patch is mostly a matter of
2374         updating config.js and removing the examples from the unit tests.
2375
2376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2381
2382 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2383
2384         [Qt] Enable CSS_FILTERS in Qt build
2385         https://bugs.webkit.org/show_bug.cgi?id=75777
2386
2387         Add the CSS_FILTERS feature flag to Qt.
2388
2389         Reviewed by Kenneth Rohde Christiansen.
2390
2391         * qmake/mkspecs/features/features.prf:
2392
2393 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2394
2395         Categorize bots by ports instead of core/non-core separation
2396         https://bugs.webkit.org/show_bug.cgi?id=75766
2397
2398         Reviewed by Eric Seidel.
2399
2400         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
2401         (Chromium still comes before GTK and Qt).
2402
2403         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2404         (loadBuilderConfig):
2405         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2406
2407 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2408
2409         Remove the concept of core builders from webkitpy
2410         https://bugs.webkit.org/show_bug.cgi?id=75809
2411
2412         Reviewed by Ryosuke Niwa.
2413
2414         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
2415         and remove the relevant code.
2416
2417         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2418         (BuildBot.__init__):
2419         (BuildBot._matches_regexps):
2420         (BuildBot._builder_statuses_with_names_matching_regexps):
2421         (BuildBot.builder_statuses):
2422         (BuildBot.failure_map):
2423         (BuildBot._latest_builds_from_builders):
2424         (BuildBot.last_green_revision):
2425         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2426         (MockBuildBot.builder_statuses):
2427         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2428         (test_status_parsing):
2429         (test_last_green_revision):
2430         (test_last_green_revision.mock_builds_from_builders):
2431
2432 2012-01-08  Adam Barth  <abarth@webkit.org>
2433
2434         Remove Chromium Mac CG concept from webkitpy
2435         https://bugs.webkit.org/show_bug.cgi?id=75810
2436
2437         Reviewed by Ryosuke Niwa.
2438
2439         This configuration no longer exists.  We can remove all the supporting
2440         code from webkitpy.
2441
2442         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2443         (BaselineOptimizerTest.test_move_baselines):
2444         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
2445         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
2446         (BaselineOptimizerTest.test_common_directory_includes_root):
2447         (BaselineOptimizerTest.test_complex_shadowing):
2448         * Scripts/webkitpy/common/config/build.py:
2449         (_should_file_trigger_build):
2450         * Scripts/webkitpy/common/config/build_unittest.py:
2451         (ShouldBuildTest):
2452         * Scripts/webkitpy/layout_tests/port/builders.py:
2453         * Scripts/webkitpy/layout_tests/port/chromium.py:
2454         (ChromiumPort):
2455         (ChromiumPort._generate_all_test_configurations):
2456         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2457         (_default_tests_paths):
2458         (ChromiumGpuLinuxPort.tests):
2459         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2460         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
2461         (ChromiumGpuTest.assert_port_works):
2462         (ChromiumGpuTest.test_baseline_paths):
2463         (ChromiumGpuTest.test_graphics_type):
2464         (ChromiumGpuTest.test_default_tests_paths):
2465         (ChromiumGpuTest.test_test_files):
2466         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2467         (ChromiumMacPort):
2468         (ChromiumMacPort.__init__):
2469         (ChromiumMacPort.baseline_search_path):
2470         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2471         (ChromiumMacPortTest.test_graphics_type):
2472         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2473         (ChromiumPortTest.test_all_test_configurations):
2474         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2475         * Scripts/webkitpy/layout_tests/port/factory.py:
2476         (PortFactory._port_name_from_arguments_and_options):
2477         (PortFactory.get):
2478         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2479         (FactoryTest.test_chromium_gpu_mac):
2480         (FactoryTest.test_chromium_mac):
2481         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2482         (GetGoogleChromePortTest._verify_expectations_overrides):
2483         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2484         (MockChromiumDRTTest.test_chromium_parse_options):
2485         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2486         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2487         (test_url_fetcher):
2488         (test_zip_factory):
2489         (test_archive):
2490         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2491         (TestRebaseline.test_rebaseline_expectations):
2492
2493 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2494
2495         Categorize bots by ports instead of core/non-core separation
2496         https://bugs.webkit.org/show_bug.cgi?id=75766
2497
2498         Reviewed by Adam Barth.
2499
2500         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
2501
2502         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2503         (loadBuilderConfig):
2504         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2505
2506 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2507
2508         Unreviewed, rolling out r104403.
2509         http://trac.webkit.org/changeset/104403
2510         https://bugs.webkit.org/show_bug.cgi?id=75803
2511
2512         It broke all tests on Qt5 (Requested by Ossy_weekend on
2513         #webkit).
2514
2515         * qmake/mkspecs/features/features.prf:
2516
2517 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2518
2519         [Qt] Enable CSS_FILTERS in Qt build
2520         https://bugs.webkit.org/show_bug.cgi?id=75777
2521
2522         Add the CSS_FILTERS feature flag to Qt.
2523
2524         Reviewed by Kenneth Rohde Christiansen.
2525
2526         * qmake/mkspecs/features/features.prf:
2527
2528 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2529
2530         Rewrite the CSS parser of prepare-ChangeLog with unittests.
2531         https://bugs.webkit.org/show_bug.cgi?id=75202
2532
2533         Reviewed by David Kilzer.
2534
2535         The current CSS parser can just parse simple CSSes like
2536
2537             foo bar baz {
2538                 property1: value;
2539                 property2: value;
2540             }
2541
2542         , and cannot parse comments nor a CSS in which a selector and {
2543         appears in different lines. This patch rewrites the CSS parser
2544         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
2545         shown in css_unittests.css.
2546
2547         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
2548
2549         * Scripts/prepare-ChangeLog:
2550         (get_selector_line_ranges_for_css):
2551         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2552         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
2553         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
2554         (element1):
2555         (element2):
2556         (element3):
2557         (element4.p):
2558         (element5.p.q.r.s):
2559         (element6#p):
2560         (element7 element8):
2561         (element9.p element10.q):
2562         (element11#p element12#q):
2563         (element13, element14):
2564         (.p):
2565         (#p):
2566         (.p element15 #q element16.r element17#s):
2567         (element18:target):
2568         (element19):
2569         (element20):
2570         (element21):
2571         (element22):
2572
2573 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2574
2575         The Perl parser of prepare-ChangeLog can parse here-documents
2576         https://bugs.webkit.org/show_bug.cgi?id=73208
2577
2578         Reviewed by David Kilzer.
2579
2580         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
2581         which results in wrong subroutine names in ChangeLogs.
2582         With this patch, prepare-ChangeLog can judge whether the line of "}"
2583         is the end of a subroutine or a line inside a here-document.
2584
2585         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
2586
2587         * Scripts/prepare-ChangeLog:
2588         (get_function_line_ranges_for_perl):
2589         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2590         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2591         Added test cases for here-documents.
2592         (func7):
2593         (func8):
2594         (func9):
2595         (func10):
2596         (func11):
2597         (func12):
2598         (func13):
2599         (func14):
2600         (func15):
2601         (func16):
2602
2603 2012-01-08  Kentaro Hara  <haraken@chromium.org>
2604
2605         Add unittests for the JavaScript parser of prepare-ChangeLog
2606         https://bugs.webkit.org/show_bug.cgi?id=75201
2607
2608         Reviewed by David Kilzer.
2609
2610         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
2611         of prepare-ChangeLog.
2612
2613         * Scripts/prepare-ChangeLog:
2614         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
2615         omitted from parsing. Thus,
2616
2617             str = "foo"
2618             function func() {
2619             }
2620
2621         was recognized as equivalent to
2622
2623             str = function func() {
2624             }
2625
2626         This patch replaces a string with a dummy identifier 'string_appeared_here'
2627         to tell the parser that a string appeared there.
2628
2629         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2630         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
2631         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
2632         (func1):
2633         (func2):
2634         (func3):
2635         (func4):
2636         (func5):
2637         (func6):
2638         (func7):
2639         (func8):
2640         (func9):
2641         (func10):
2642         (func11):
2643         (func12):
2644         (funcOverloaded):
2645         (Func1.prototype.get x1):
2646         (Func1.prototype.get x2):
2647         (Func1.prototype.set x1):
2648         (Func1.prototype.set x3):
2649         (Func2.prototype.func13):
2650         (Func2.prototype.func14):
2651         (Func2.prototype.func15):
2652         (func16.func17):
2653         (func16.func18):
2654         (func16.func19):
2655         (func16):
2656
2657 2012-01-08  David Levin  <levin@chromium.org>
2658
2659         [chromium] Add layout test support for autosize code in FrameView.
2660         https://bugs.webkit.org/show_bug.cgi?id=73631
2661
2662         Reviewed by Dmitry Titov.
2663
2664         * DumpRenderTree/chromium/LayoutTestController.cpp:
2665         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
2666         (LayoutTestController::reset): Set the autoresize mode back to false.
2667         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
2668         * DumpRenderTree/chromium/LayoutTestController.h:
2669         * DumpRenderTree/chromium/WebViewHost.cpp:
2670         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
2671         * DumpRenderTree/chromium/WebViewHost.h:
2672
2673 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2674
2675         [WK2][GTK] Each test takes roughly half a second to load
2676         https://bugs.webkit.org/show_bug.cgi?id=70699
2677
2678         Reviewed by Martin Robinson.
2679
2680         Set the XDG_CACHE_HOME environment variable when testing with
2681         WebKitTestRunner. This way the testing is started with a non-existing
2682         application cache. If the cache exists and is not empty, the emptying
2683         and vacuuming that is performed before every test can consume a lot of
2684         time.
2685
2686         This is just a temporary workaround until it becomes possible to set
2687         a desired directory to be used as the application cache location through
2688         WebKitWebContext.
2689
2690         * Scripts/webkitpy/layout_tests/port/gtk.py:
2691         (GtkPort.setup_environ_for_server):
2692
2693 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2694
2695         [GTK] Enable requestAnimationFrame in build-webkit
2696         https://bugs.webkit.org/show_bug.cgi?id=75773
2697
2698         Reviewed by Martin Robinson.
2699
2700         Enable requestAnimationFrame for the Gtk port.
2701
2702         * Scripts/build-webkit:
2703
2704 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
2705
2706         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
2707
2708         * Scripts/webkitdirs.pm:
2709         (buildChromium):
2710         Missing parentheses.
2711
2712 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2713
2714         Fix DRT build on case-sensitive file systems.
2715
2716         Fix case of include of WebDynamicScrollBarsView.h
2717         
2718         * DumpRenderTree/mac/DumpRenderTree.mm:
2719
2720 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2721
2722         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
2723         https://bugs.webkit.org/show_bug.cgi?id=75662
2724
2725         Reviewed by Dan Bernstein.
2726         
2727         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
2728         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
2729         test window uses the main display's color space, so that the pixel values in the bitmap
2730         that gets checksummed are identical to the CSS colors.
2731         
2732         Removed the code that switches the display profile in DRT, since that is no longer required.
2733
2734         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
2735         * DumpRenderTree/mac/DumpRenderTree.mm:
2736         (crashHandler): Remove code that switches display profiles.
2737         (prepareConsistentTestingEnvironment): Ditto.
2738         (dumpRenderTree): Ditto.
2739         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
2740         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
2741         (createBitmapContextFromWebView): Add comment about the colorspace handling.
2742         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2743         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
2744         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
2745         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2746         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
2747         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
2748
2749 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2750
2751         run-api-tests: specify individual suites and tests on the command-line
2752
2753         Reviewed by Adam Roben.
2754
2755         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2756
2757         The run-api-tests script will now accept a list of arguments on
2758         the command-line that are used as prefix filters.  To run all
2759         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
2760         use:
2761
2762             $ run-api-tests WTF
2763
2764         To run only the tests in the "WTF" suite, not the "WTF_Vector"
2765         suite, use:
2766
2767             $ run-api-tests WTF.
2768
2769         * Scripts/run-api-tests: Filter tests if any prefix arguments
2770         are passed on the command-line.
2771
2772 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2773
2774         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
2775
2776         Reviewed by Adam Roben.
2777
2778         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2779
2780         * Scripts/run-api-tests:
2781         (dumpTestsBySuite): Update to accept array of tests instead of
2782         hash data structure.
2783         (runTestsBySuite): Ditto.
2784         (listAllTests): Rename from populateTests().  Update to return
2785         an array of tests instad of the hash data structure.
2786
2787 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2788
2789         webkitpy: clean up test/uri conversion routines
2790         https://bugs.webkit.org/show_bug.cgi?id=75648
2791
2792         Reviewed by Eric Seidel.
2793
2794         This change moves test_to_uri and uri_to_test from the Port
2795         class to the Driver class (the routines were only being
2796         called by the drivers), and removes a bunch of stale and/or
2797         busted logic.
2798
2799         * Scripts/webkitpy/layout_tests/port/base.py:
2800         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2801         * Scripts/webkitpy/layout_tests/port/chromium.py:
2802         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2803         * Scripts/webkitpy/layout_tests/port/driver.py:
2804         (is_http_test):
2805         (test_to_uri):
2806         (uri_to_test):
2807         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2808         (run_one_test):
2809         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2810         (MockDRTTest.input_line):
2811         (input_line):
2812         (expected_output):
2813         * Scripts/webkitpy/layout_tests/port/test.py:
2814         * Scripts/webkitpy/layout_tests/port/webkit.py:
2815         (_command_from_driver_input):
2816
2817 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2818
2819         Mitigate scrollbar differences when running pixel tests
2820         https://bugs.webkit.org/show_bug.cgi?id=67217
2821
2822         Reviewed by Dan Bernstein.
2823         
2824         Add an NSScroller subclass that draws mock scrollbars identically
2825         to the WebCore mock scrollbar theme, and register it with the
2826         WebDynamicScrollbarsView.
2827
2828         * DumpRenderTree/mac/DumpRenderTree.mm:
2829         (-[DRTMockScroller rectForPart:]):
2830         (-[DRTMockScroller drawKnob]):
2831         (-[DRTMockScroller drawRect:]):
2832         (registerMockScrollbars):
2833         (prepareConsistentTestingEnvironment):
2834
2835 2012-01-05  Jon Lee  <jonlee@apple.com>
2836
2837         Update DRT on Mac to draw resize handles on text areas.
2838
2839         Reviewed by John Sullivan.
2840
2841         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
2842         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
2843
2844         * DumpRenderTree/mac/DumpRenderTree.mm:
2845         (resetDefaultsToConsistentValues):
2846
2847 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2848
2849         [Qt] Move listing of include paths and libs to pri files in sources
2850
2851         Includepaths are sometimes modified by non-Qt contributors so keeping
2852         them in files inside Sources makes it more likely that they are updated
2853         along with project files for the other ports.
2854
2855         Using pri files instead of prf files for this also has the benefit that
2856         the include() from the main target file can be parsed and followed by
2857         Qt Creator -- something that does not work with load().
2858
2859         Dependency from a target to a library through the WEBKIT variable are
2860         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
2861         set the source root of the module and include the right pri file.
2862
2863         Ideally we'd use the variant of include() that takes an optional
2864         namespace to read the variables into, or the fromfile() function,
2865         but both of these add an overhead of about 40% on the total qmake
2866         runtime, due to making a deep copy of all the variables in the
2867         project or re-reading all the prf files from scratch.
2868
2869         Reviewed by Simon Hausmann.
2870         Reviewed by Ossy.
2871
2872         * qmake/mkspecs/features/default_post.prf:
2873         * qmake/mkspecs/modules/javascriptcore.prf: Added.
2874         * qmake/mkspecs/modules/webcore.prf: Added.
2875         * qmake/mkspecs/modules/webkit2.prf: Added.
2876         * qmake/mkspecs/modules/wtf.prf: Added.
2877
2878 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
2879
2880         [EFL] Add pre-render handling code in EWebLauncher.
2881         https://bugs.webkit.org/show_bug.cgi?id=73430
2882
2883         Reviewed by Zoltan Herczeg.
2884
2885         Add pre-render handling code by pressing Insert key.
2886
2887         * EWebLauncher/main.c:
2888         (on_key_down):
2889
2890 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
2891
2892         NRWT should use test_expectation.txt on wk2 platforms
2893         https://bugs.webkit.org/show_bug.cgi?id=75417
2894
2895         Reviewed by Dirk Pranke.
2896
2897         * Scripts/webkitpy/layout_tests/port/webkit.py:
2898         (path_to_test_expectations_file):
2899         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2900         (test_path_to_test_expectations_file):
2901
2902 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2903
2904         Don't hardcode expected file URIs in as they depend on the platform
2905         https://bugs.webkit.org/show_bug.cgi?id=75666
2906
2907         Reviewed by Dirk Pranke.
2908
2909         * Scripts/webkitpy/layout_tests/port/win.py:
2910         (WinPort.show_results_html_file):
2911         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2912         (MainTest.test_unexpected_failures):
2913         (MainTest.test_results_directory_default):
2914         (MainTest.test_results_directory_relative):
2915
2916 2012-01-05  Anders Carlsson  <andersca@apple.com>
2917
2918         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
2919         https://bugs.webkit.org/show_bug.cgi?id=75667
2920         <rdar://problem/10389454>
2921
2922         Reviewed by Kevin Decker.
2923
2924         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
2925
2926         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2927         (PluginTest::executeScript):
2928         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2929         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
2930         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
2931         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
2932         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2933
2934 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2935
2936         webkitpy: clean up port factory methods
2937         https://bugs.webkit.org/show_bug.cgi?id=75590
2938
2939         Reviewed by Eric Seidel.
2940
2941         This change consolidates much of the "factory method" logic
2942         of determining which port objects to create for a given set
2943         of configurations by merging the separate factory methods in
2944         chromium_gpu and google_chrome into PortFactory so that at least
2945         all of the logic is in one place.
2946
2947         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2948         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2949         * Scripts/webkitpy/layout_tests/port/factory.py:
2950         (_port_name_from_arguments_and_options):
2951         (get):
2952         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2953         (test_google_chrome):
2954         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2955         (GoogleChromeLinux32Port):
2956         (GoogleChromeLinux32Port.baseline_search_path):
2957         (test_expectations_overrides):
2958         (architecture):
2959         (GoogleChromeLinux64Port):
2960         (GoogleChromeLinux64Port.baseline_search_path):
2961         (GoogleChromeMacPort):
2962         (GoogleChromeMacPort.baseline_search_path):
2963         (GoogleChromeWinPort):
2964         (GoogleChromeWinPort.baseline_search_path):
2965         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2966         (_verify_baseline_path):
2967
2968 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2969
2970         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
2971         https://bugs.webkit.org/show_bug.cgi?id=75617
2972
2973         Reviewed by Dirk Pranke.
2974
2975         * Scripts/webkitpy/common/system/filesystem.py:
2976         (FileSystem.exists):
2977         * Scripts/webkitpy/common/system/filesystem_mock.py:
2978         (MockFileSystem.exists):
2979         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2980         (GenericFileSystemTests.teardown_generic_test_dir):
2981         * Scripts/webkitpy/layout_tests/port/base.py:
2982         (Port.to.show_results_html_file):
2983         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2984         (MainTest.test_results_directory_absolute):
2985
2986 2012-01-05  Adam Roben  <aroben@apple.com>
2987
2988         Remove some unnecessary code from old-run-webkit-tests
2989
2990         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
2991         WebKitTestRunner.
2992
2993         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
2994         Windows
2995
2996         Reviewed by Eric Seidel.
2997
2998         * Scripts/old-run-webkit-tests:
2999         (top level):
3000         (openDumpTool):
3001         Removed calls to setPathForRunningWebKitApp.
3002
3003 2012-01-05  Adam Roben  <aroben@apple.com>
3004
3005         Teach NRWT to use run-safari to open results.html on Apple's Windows port
3006
3007         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
3008         better, since we always want to open results.html using the user's build of WebKit, not
3009         whatever their default browser is.
3010
3011         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
3012         for Apple's Windows port
3013
3014         Reviewed by Eric Seidel.
3015
3016         * Scripts/webkitpy/layout_tests/port/win.py:
3017         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
3018         an obsolete comment.
3019
3020         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3021         (WinPortTest.test_show_results_html_file): Updated expected results.
3022
3023 2012-01-05  Adam Roben  <aroben@apple.com>
3024
3025         Prepend Safari.exe's path to the command-line passed to CreateProcess
3026
3027         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
3028         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
3029         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
3030         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
3031         first argument that WebKitLauncherWin was trying to pass to it.
3032
3033         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
3034
3035         Reviewed by Steve Falkenburg.
3036
3037         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3038         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
3039         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
3040
3041 2012-01-05  Adam Roben  <aroben@apple.com>
3042
3043         Stop using explicit memory management in WebKitLauncherWin
3044
3045         We now use stack-allocated STL objects instead.
3046
3047         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
3048         Safari
3049
3050         Reviewed by Steve Falkenburg.
3051
3052         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3053         (getStringValue):
3054         (applePathFromRegistry):
3055         (safariInstallDir):
3056         (safariBrowserExe):
3057         (_tWinMain):
3058         Changed to use stack-allocated STL objects instead of malloc/free.
3059
3060 2012-01-05  Adam Roben  <aroben@apple.com>
3061
3062         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
3063
3064         This allows us to add the Safari and Apple Application Support directories to PATH before
3065         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3066
3067         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3068         Windows port of DumpRenderTree/WebKitTestRunner
3069
3070         Reviewed by Steve Falkenburg.
3071
3072         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
3073         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
3074
3075         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3076         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3077         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
3078
3079         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
3080         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
3081         the stub launcher.
3082
3083         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
3084         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
3085         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
3086         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
3087         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
3088         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
3089         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
3090
3091         * WebKitTestRunner/win/main.cpp:
3092         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3093
3094 2012-01-05  Adam Roben  <aroben@apple.com>
3095
3096         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
3097
3098         This allows us to add the Safari and Apple Application Support directories to PATH before
3099         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3100
3101         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3102         Windows port of DumpRenderTree/WebKitTestRunner
3103
3104         Reviewed by Steve Falkenburg.
3105
3106         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
3107         which I forgot to add to this .sln when that project was created.
3108
3109         * DumpRenderTree/win/DumpRenderTree.cpp:
3110         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3111
3112         * DumpRenderTree/win/DumpRenderTree.vcproj:
3113         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3114         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
3115
3116         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
3117         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
3118         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
3119         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
3120         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
3121         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
3122         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
3123         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
3124
3125         * win/DLLLauncher/DLLLauncherMain.cpp:
3126         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
3127         Safari's directory to PATH so that SafariTheme.dll can be found.
3128
3129         (main):
3130         (wWinMain):
3131         Changed to use the new modifyPath function.
3132
3133 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3134
3135         [Qt] Never enable FontConfig on Mac OS X
3136         https://bugs.webkit.org/show_bug.cgi?id=75616
3137
3138         Reviewed by Tor Arne Vestbø.
3139
3140         * qmake/mkspecs/features/features.prf:
3141
3142 2012-01-05  Alpha Lam  <hclam@chromium.org>
3143
3144         Unreviewed, rolling out r104159.
3145         http://trac.webkit.org/changeset/104159
3146         https://bugs.webkit.org/show_bug.cgi?id=75590
3147
3148         Chromium port GPU tests cannot be executed.
3149
3150         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3151         (get):
3152         (_default_tests_paths):
3153         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3154         (ChromiumGpuTest.assert_port_works):
3155         * Scripts/webkitpy/layout_tests/port/factory.py:
3156         (PortFactory._port_name_from_arguments_and_options):
3157         (PortFactory):
3158         (PortFactory._get_kwargs):
3159         (PortFactory.get):
3160         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3161         (FactoryTest.test_google_chrome.names):
3162         (FactoryTest.test_google_chrome):
3163         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3164         (GetGoogleChromePort):
3165         (GetGoogleChromePort.GoogleChromeLinux32Port):
3166         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
3167         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
3168         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
3169         (GetGoogleChromePort.GoogleChromeLinux64Port):
3170         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
3171         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
3172         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
3173         (GetGoogleChromePort.GoogleChromeMacPort):
3174         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
3175         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
3176         (GetGoogleChromePort.GoogleChromeWinPort):
3177         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
3178         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
3179         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3180         (GetGoogleChromePortTest._verify_baseline_path):
3181         (GetGoogleChromePortTest._verify_expectations_overrides):
3182
3183 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3184
3185         webkitpy: clean up port factory methods
3186         https://bugs.webkit.org/show_bug.cgi?id=75590
3187
3188         Reviewed by Eric Seidel.
3189
3190         This change consolidates much of the "factory method" logic
3191         of determining which port objects to create for a given set
3192         of configurations by merging the separate factory methods in
3193         chromium_gpu and google_chrome into PortFactory so that at least
3194         all of the logic is in one place.
3195
3196         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3197         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3198         * Scripts/webkitpy/layout_tests/port/factory.py:
3199         (_port_name_from_arguments_and_options):
3200         (get):
3201         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3202         (test_google_chrome):
3203         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3204         (GoogleChromeLinux32Port):
3205         (GoogleChromeLinux32Port.baseline_search_path):
3206         (test_expectations_overrides):
3207         (architecture):
3208         (GoogleChromeLinux64Port):
3209         (GoogleChromeLinux64Port.baseline_search_path):
3210         (GoogleChromeMacPort):
3211         (GoogleChromeMacPort.baseline_search_path):
3212         (GoogleChromeWinPort):
3213         (GoogleChromeWinPort.baseline_search_path):
3214         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3215         (_verify_baseline_path):
3216
3217 2012-01-04  Adam Roben  <aroben@apple.com>
3218
3219         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
3220
3221         This allows us to add the Apple Application Support directory to PATH before trying to load
3222         WebKit so that CoreGraphics.dll and friends can be found.
3223
3224         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
3225
3226         Reviewed by Anders Carlsson.
3227
3228         * DumpRenderTree/win/ImageDiff.vcproj:
3229         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3230         Changed to build ImageDiff.dll instead of ImageDiff.exe.
3231
3232         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
3233         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
3234
3235         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
3236         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
3237         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
3238         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
3239         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
3240         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
3241         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
3242
3243         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
3244         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
3245         to main.
3246
3247         * win/DLLLauncher/DLLLauncherMain.cpp:
3248         (main):
3249         (wWinMain):
3250         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
3251         stub launcher acts as a console program and calls a console version of
3252         dllLauncherEntryPoint.
3253
3254 2012-01-04  Adam Roben  <aroben@apple.com>
3255
3256         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
3257
3258         This allows us to add the Apple Application Support directory to PATH before trying to load
3259         WebKit so that CoreGraphics.dll and friends can be found.
3260
3261         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
3262         double-clicked
3263
3264         Reviewed by Anders Carlsson.
3265
3266         * MiniBrowser/MiniBrowser.vcproj:
3267         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3268         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
3269
3270         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
3271         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
3272         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
3273         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
3274         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
3275         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
3276         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
3277
3278         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
3279         but changed to build the stub launcher.
3280
3281         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
3282         it needs to be compiled into the .exe instead of the .dll.
3283         (DllMain): Added. We use this to store the DLL's HINSTANCE.
3284         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
3285         DLLLauncherMain code.
3286
3287         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
3288         to here.
3289
3290 2012-01-04  Adam Roben  <aroben@apple.com>
3291
3292         Make WinLauncher's window frame respond to clicks/drags again
3293
3294         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
3295         bar when Aero is disabled
3296
3297         Reviewed by Brent Fulgham.
3298
3299         * WinLauncher/WinLauncher.cpp:
3300         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
3301         Also removed an unnecessary "break" keyword.
3302
3303 2012-01-04  Adam Roben  <aroben@apple.com>
3304
3305         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
3306
3307         This allows us to add the Apple Application Support directory to PATH before trying to load
3308         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
3309         should use this mechanism.
3310
3311         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
3312         double-clicked
3313
3314         Reviewed by Anders Carlsson.
3315
3316         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
3317         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
3318         done by the now-removed InitInstance function.
3319         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
3320         calls. Merged code from InitInstance into this function, and change to use the global hInst
3321         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
3322         function, which corresponds to WinLauncher.exe.
3323
3324         * WinLauncher/WinLauncher.vcproj:
3325         * WinLauncher/WinLauncherCommon.vsprops:
3326         Changed to build WinLauncher.dll instead of WinLauncher.exe.
3327
3328         * WinLauncher/WinLauncherLauncher.rc: Added.
3329         * WinLauncher/WinLauncherLauncherResource.h: Added.
3330         This just references the WinLauncher.ico file to set the application icon (though it looks
3331         like that's a default icon).
3332
3333         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
3334         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
3335
3336         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
3337         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
3338         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
3339         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
3340         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
3341         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
3342         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
3343
3344         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
3345         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
3346         program if it detects heap corruption.
3347         (getStringValue): Helper function to read a string value from the registry.
3348         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
3349         application from the registry.
3350         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
3351         Application Support directory.
3352         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
3353         (prependPath): Helper function to prepend a directory to the PATH.
3354         (fatalError): Helper function to display an error to the user.
3355         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
3356         dllLauncherEntryPoint function.
3357
3358 2012-01-05  Kentaro Hara  <haraken@chromium.org>
3359
3360         prepare-ChangeLog cannot parse python code that nests classes and defs
3361         https://bugs.webkit.org/show_bug.cgi?id=75524
3362
3363         Reviewed by Ryosuke Niwa.
3364
3365         This patch fixes the python parser of prepare-ChangeLog so that it can parse
3366         python code that nests classes and defs, like this:
3367
3368         class C:
3369             pass
3370             def f():
3371                 pass
3372             pass
3373
3374         Also, this patch fixes the python parser so that it inserts a dummy line
3375         at the end of the file to pop out all popped scopes.
3376
3377         * Scripts/prepare-ChangeLog:
3378         (get_function_line_ranges_for_python):
3379
3380         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
3381         Added test cases that nest classes and defs.
3382         (func7):
3383         (func7.func8):
3384         (func7.func8.func9):
3385         (Class2):
3386         (Class2.Class3):
3387         (Class2.Class3.Class4):
3388         (Class5):
3389         (Class5.func10):
3390         (Class5.func11):
3391         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
3392
3393 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3394
3395         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
3396         https://bugs.webkit.org/show_bug.cgi?id=75433
3397
3398         Reviewed by Martin Robinson.
3399
3400         * MiniBrowser/gtk/BrowserWindow.c:
3401         (webViewLoadFailed): Reset the progress bar when load fails.
3402         (browserWindowConstructed): Connect to load-failed signal.
3403
3404 2012-01-04  Dan Bernstein  <mitz@apple.com>
3405
3406         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
3407         start WebProcess under gdb and WebProcess will then run the client executable.
3408
3409         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
3410
3411         Reviewed by Anders Carlsson.
3412
3413         * Scripts/webkitdirs.pm:
3414         (shouldTargetWebProcess): Added.
3415         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
3416         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
3417         app using the -client-executable option if targeting the web process.
3418
3419 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3420
3421         Adding myself to committers list.
3422
3423         Unreviewed.
3424
3425         * Scripts/webkitpy/common/config/committers.py:
3426
3427 2012-01-04  David Kilzer  <ddkilzer@apple.com>
3428
3429         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
3430
3431         This reverts commit r103546.
3432
3433         * TestWebKitAPI/TestsController.cpp:
3434         (TestWebKitAPI::TestsController::TestsController):
3435
3436 2012-01-04  James Robinson  <jamesr@chromium.org>
3437
3438         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
3439         https://bugs.webkit.org/show_bug.cgi?id=74583
3440
3441         Reviewed by Darin Fisher.
3442
3443         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
3444
3445         * Scripts/webkitpy/style/checkers/cpp.py:
3446         (check_function_definition):
3447
3448 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3449
3450         [Qt] Fix link order of static libraries and unbreak QtWin32
3451
3452         We were keeping the correct static link order between the intermediate
3453         WebKit libraries, but not the internal dependencies for each of those
3454         libraries. The load() will in some instances mess with LIBS, so we need
3455         to ensure that the dependent libraries are added after the library we
3456         are linking against.
3457
3458         Reviewed by Simon Hausmann.
3459
3460         * qmake/mkspecs/features/default_post.prf:
3461
3462 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3463
3464         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
3465
3466         The custom qmake variable 'WEBKIT' is used for signaling that a
3467         target depends in some way on other subproject of the WebKit
3468         project. For now this is limited to the set of intermediate
3469         libraries: wtf, javascriptcore, webcore, and webkit2.
3470
3471         This replaces the previous convension of using load(foo) for
3472         just include paths, and CONFIG += foo to also link against foo.
3473
3474         Adding a dependency results in additional include paths being
3475         available, and potentially linking to the library. This is
3476         decided by the build system based on conditions such as what
3477         kind of target is being built and the general build config.
3478
3479         An advantage to his approach is that it simplifies the individual
3480         foo.prf files, for example by allowing us to use INCLUDEPATH +=
3481         and LIBS += as normal instead of prepending.
3482
3483         Reviewed by Simon Hausmann.
3484
3485         * DumpRenderTree/qt/DumpRenderTree.pro:
3486         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3487         * QtTestBrowser/QtTestBrowser.pro:
3488         * WebKitTestRunner/InjectedBundle/Target.pri:
3489         * WebKitTestRunner/Target.pri:
3490         * qmake/README:
3491         * qmake/mkspecs/features/default_post.prf:
3492         * qmake/mkspecs/features/functions.prf:
3493         * qmake/mkspecs/features/javascriptcore.prf:
3494         * qmake/mkspecs/features/qtwebkit.prf:
3495         * qmake/mkspecs/features/webcore.prf:
3496         * qmake/mkspecs/features/webkit2.prf:
3497         * qmake/mkspecs/features/wtf.prf:
3498
3499 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
3500
3501         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
3502         https://bugs.webkit.org/show_bug.cgi?id=75488
3503
3504         Reviewed by Tor Arne Vestbø.
3505
3506         * MiniBrowser/qt/MiniBrowser.qrc:
3507         * MiniBrowser/qt/qml/BrowserWindow.qml:
3508         * MiniBrowser/qt/qml/Dialog.qml:
3509         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3510         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3511
3512 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3513
3514         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
3515
3516         It wasn't really a problem at runtime since the right QtWebKit was
3517         already loaded as a dependency of the web process, but the ldd output
3518         would still be busted.
3519
3520         Reviewed by Simon Hausmann.
3521
3522         * WebKitTestRunner/InjectedBundle/Target.pri:
3523
3524 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3525
3526         [Qt] Move use of $$qtLibraryTarget() to a single place
3527
3528         Reviewed by Kenneth Rohde Christiansen.
3529
3530         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3531         * WebKitTestRunner/InjectedBundle/Target.pri:
3532         * qmake/mkspecs/features/default_post.prf:
3533         * qmake/mkspecs/features/webcore.prf:
3534
3535 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
3536
3537         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
3538         https://bugs.webkit.org/show_bug.cgi?id=75238
3539
3540         Reviewed by Antonio Gomes.
3541
3542         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
3543         it could initiate download directly if it has the download attribute in the link 
3544         and doesn't need to open new blank page for the target="_blank". Enabling this 
3545         feature in the BlackBerry porting also prepares for later blob feature implementation.
3546
3547         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
3548         for the BlackBerry porting.
3549
3550 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3551
3552         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
3553         https://bugs.webkit.org/show_bug.cgi?id=75475
3554
3555         Reviewed by Martin Robinson.
3556
3557         The problem is that the property blurb contains <a ping> and tree
3558         view uses gtk_tooltip_set_markup() internally, so we need to
3559         escape the text.
3560
3561         * MiniBrowser/gtk/BrowserSettingsDialog.c:
3562         (browserSettingsDialogConstructed): Escape property blurb before
3563         storing it in the GtkTreeModel.
3564
3565 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
3566
3567         When showing results.html pass a correct URL to webbrowser.open
3568         https://bugs.webkit.org/show_bug.cgi?id=75438
3569
3570         Reviewed by Adam Barth.
3571
3572         * Scripts/webkitpy/common/system/filesystem.py:
3573         (file_path_as_url):
3574         * Scripts/webkitpy/common/system/filesystem_mock.py:
3575         (file_path_as_url):
3576         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3577         (test_file_path_as_url):
3578         * Scripts/webkitpy/layout_tests/port/base.py:
3579         (show_results_html_file):
3580         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3581         (test_show_results_html_file):
3582         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3583         (test_results_directory_relative):
3584
3585 2012-01-03  Ojan Vafai  <ojan@chromium.org>
3586
3587         shrink the header on the flakiness dashboard
3588         https://bugs.webkit.org/show_bug.cgi?id=65153
3589
3590         Reviewed by Adam Roben.
3591
3592         Move some of the "show" links to be to the right of the header
3593         instead of below the header when they content they're showing
3594         is hidden. That way we don't waste vertical space on them.
3595
3596         No new tests. This code is covered by existing tests.
3597
3598         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3599
3600 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3601
3602         Add a tool to analyze change logs
3603         https://bugs.webkit.org/show_bug.cgi?id=72243
3604
3605         Reviewed by Eric Seidel.
3606
3607         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3608         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3609         for visualizing json files.
3610
3611         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3612         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3613         generates json files, and N is the number of changelogs to parse.
3614
3615         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3616         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3617         * Scripts/webkitpy/tool/commands/__init__.py:
3618         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3619         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3620         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3621         * Scripts/webkitpy/tool/steps/options.py:
3622
3623 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3624
3625         Add a tool to analyze change logs
3626         https://bugs.webkit.org/show_bug.cgi?id=72243
3627
3628         Reviewed by Eric Seidel.
3629
3630         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3631         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3632         for visualizing json files.
3633
3634         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3635         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3636         generates json files, and N is the number of changelogs to parse.
3637
3638         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3639         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3640         * Scripts/webkitpy/tool/commands/__init__.py:
3641         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3642         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3643         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3644         * Scripts/webkitpy/tool/steps/options.py:
3645
3646 2012-01-03  Adam Roben  <aroben@apple.com>
3647
3648         Make Port subclasses override the operating_system method rather than setting an attribute
3649
3650         Without this patch, any use of Port.operating_system() within a port's __init__ method would
3651         return the default value ("mac"). This was confusing the version-checking logic inside
3652         ApplePort.__init__ on Windows.
3653
3654         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
3655         crashes on launch on Windows 7 SP1
3656
3657         Reviewed by Eric Seidel.
3658
3659         * Scripts/webkitpy/layout_tests/port/apple.py:
3660         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
3661
3662         * Scripts/webkitpy/layout_tests/port/base.py:
3663         (Port.__init__): Removed code that set the self._operating_system attribute.