aad0a953f3845f193c0dfe5cbd5c2bb9276ad997
[WebKit-https.git] / Tools / ChangeLog
1 2014-11-29  Anders Carlsson  <andersca@apple.com>
2
3         Crash when calling WKPageClose on the originated page from within createNewPage callback
4         https://bugs.webkit.org/show_bug.cgi?id=139099
5         <rdar://problem/19052564>
6
7         Reviewed by Sam Weinig.
8
9         Add a test.
10
11         * TestWebKitAPI/PlatformWebView.h:
12         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
14         (TestWebKitAPI::runJavaScriptAlert):
15         (TestWebKitAPI::createNewPage):
16         (TestWebKitAPI::TEST):
17         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
18         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
19         (TestWebKitAPI::PlatformWebView::PlatformWebView):
20
21 2014-11-28  Commit Queue  <commit-queue@webkit.org>
22
23         Unreviewed, rolling out r176564.
24         https://bugs.webkit.org/show_bug.cgi?id=139093
25
26         massive failures on release test bot (Requested by philn on
27         #webkit).
28
29         Reverted changeset:
30
31         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
32         https://bugs.webkit.org/show_bug.cgi?id=138866
33         http://trac.webkit.org/changeset/176564
34
35 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
36
37         [GTK] Use GMainLoopSource in WebKitTestRunner
38         https://bugs.webkit.org/show_bug.cgi?id=138831
39
40         Reviewed by Sergio Villar Senin.
41
42         * WebKitTestRunner/InjectedBundle/TestRunner.h:
43         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
44         (WTR::TestRunner::platformInitialize):
45         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
46         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
47         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
48         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
49         (WTR::TestController::notifyDone):
50         (WTR::TestController::platformRunUntil):
51         (WTR::cancelTimeout): Deleted.
52
53 2014-11-24  Philippe Normand  <pnormand@igalia.com>
54
55         [GStreamer] Bump internal jhbuild versions to 1.4.4
56         https://bugs.webkit.org/show_bug.cgi?id=138866
57
58         Reviewed by Carlos Garcia Campos.
59
60         * gtk/jhbuild.modules:
61         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
62         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
63         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
64
65 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
66
67         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
68         https://bugs.webkit.org/show_bug.cgi?id=138834
69
70         Reviewed by Sergio Villar Senin.
71
72         It makes everyting simpler and the tests run faster too, since we
73         don't need to spawn the private bus and wait until the DBus name
74         is registered. The web extension registers a new JavaSCript class
75         with a status method to run the tests, similar to the DBus
76         method. In the UI process side, tests use webkit_web_view_run_java_script()
77         instead of sending a DBus message.
78
79         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
80         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
81         (WebKitDOMNodeFilterTest::create):
82         (WebKitDOMNodeFilterTest::testTreeWalker):
83         (WebKitDOMNodeFilterTest::testNodeIterator):
84         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
85         (WebKitDOMNodeFilterTest::runTest): Deleted.
86         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
87         (WebKitDOMNodeTest::create):
88         (WebKitDOMNodeTest::testHierarchyNavigation):
89         (WebKitDOMNodeTest::testInsertion):
90         (WebKitDOMNodeTest::testTagNames):
91         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
92         (WebKitDOMNodeTest::runTest): Deleted.
93         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
94         (WebKitDOMXPathNSResolverTest::create):
95         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
96         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
97         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
98         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
99         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
100         (WebKitFrameTest::create):
101         (WebKitFrameTest::testMainFrame):
102         (WebKitFrameTest::testURI):
103         (WebKitFrameTest::testJavaScriptContext):
104         (WebKitFrameTest::webPageFromArgs): Deleted.
105         (WebKitFrameTest::runTest): Deleted.
106         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
107         (testWebKitDOMNodeHierarchyNavigation):
108         (testWebKitDOMNodeInsertion):
109         (testWebKitDOMNodeTagNames):
110         (beforeAll):
111         (afterAll):
112         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
113         (runTest):
114         (beforeAll):
115         (afterAll):
116         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
117         (testWebKitDOMXPathNSResolverNative):
118         (testWebKitDOMXPathNSResolverCustom):
119         (beforeAll):
120         (afterAll):
121         (runTest): Deleted.
122         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
123         (webkitFrameTestRun):
124         (beforeAll):
125         (afterAll):
126         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
127         (testsMap):
128         (WebProcessTest::add):
129         (WebProcessTest::create):
130         (runTest):
131         (windowObjectClearedCallback):
132         (webkit_web_extension_initialize):
133         (methodCallCallback): Deleted.
134         (webkit_web_extension_initialize_with_user_data): Deleted.
135         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
136         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
137         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
138         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
139         (WebViewTest::runWebProcessTest):
140         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
141
142 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
143
144         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
145         https://bugs.webkit.org/show_bug.cgi?id=139086
146
147         Reviewed by Gyuyoung Kim.
148
149         * efl/jhbuild.modules:
150         * efl/patches/libseccomp-pick-up-CC.patch: Added.
151
152 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
153
154         [EFL] Add warning if CMake version is too old for building with ninja.
155         https://bugs.webkit.org/show_bug.cgi?id=139055
156
157         Reviewed by Gyuyoung Kim.
158
159         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
160         that version in their repositories.
161
162         * efl/install-dependencies:
163
164 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
165
166         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
167         https://bugs.webkit.org/show_bug.cgi?id=139044
168
169         Reviewed by Chris Fleizach.
170
171         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
172         The proposed solution will enable the use of this method for the object table.
173         Existing test shows the result.
174
175         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
176         (WTR::AccessibilityUIElement::columnHeaders):
177
178 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
179
180         [EFL] Remove E_Dbus dependency
181         https://bugs.webkit.org/show_bug.cgi?id=136355
182
183         Reviewed by Gyuyoung Kim.
184
185         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
186
187 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
188
189         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
190         https://bugs.webkit.org/show_bug.cgi?id=139047
191
192         Reviewed by Carlos Garcia Campos.
193
194         * efl/jhbuild.modules:
195         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
196         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
197         * gtk/jhbuild-optional.modules:
198         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
199         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
200
201 2014-11-25  Tanay C  <tanay.c@samsung.com>
202
203         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
204         https://bugs.webkit.org/show_bug.cgi?id=138090
205
206         Reviewed by Carlos Garcia Campos.
207
208         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
209         (browserWindowZoomIn): Added.
210         (browserWindowZoomOut): Added.
211         (scrollEventCallback): Added.
212         (zoomInCallback): Modified.
213         (zoomOutCallback): Modified.
214         (browserWindowConstructed): Modified.
215
216 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
217
218         [EFL] REGRESSION(r176514): It made performance tests fail
219         https://bugs.webkit.org/show_bug.cgi?id=139037
220
221         Reviewed by Gyuyoung Kim.
222
223         * Scripts/webkitpy/port/efl.py:
224         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
225         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
226         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
227
228 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
229
230         [GTK] update-webkitgtk-libs fails to build fontconfig
231         https://bugs.webkit.org/show_bug.cgi?id=139032
232
233         Reviewed by Martin Robinson.
234
235         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
236         fontconfig will try to generate documentation and fail.
237
238         * gtk/install-dependencies:
239
240 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
241
242         Unreviewed. Fix GTK+ make distcheck.
243
244         * gtk/manifest.txt: Remove deleted files.
245
246 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
247
248         [EFL] Utilize Eail library to support accessibility in EFL
249         https://bugs.webkit.org/show_bug.cgi?id=137742
250
251         Reviewed by Gyuyoung Kim.
252
253         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
254
255         * efl/jhbuild-optional.modules: Added.
256         * efl/jhbuild.modules:
257
258 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
259
260         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
261         https://bugs.webkit.org/show_bug.cgi?id=139023
262
263         Reviewed by Sergio Villar Senin.
264
265         Rename WebKitWebView/default-context as WebKitWebView/web-context
266         and check we are always using the right context for new web views.
267
268         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
269         (testWebViewWebContext):
270         (beforeAll):
271         (testWebViewDefaultContext): Deleted.
272
273 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
274
275         [GTK] Add API to override the default local storage directory
276         https://bugs.webkit.org/show_bug.cgi?id=138828
277
278         Reviewed by Gustavo Noronha Silva.
279
280         Add test to check that the local storage directory is created at
281         the path given on construction.
282
283         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
284         (testWebContextConfiguration):
285         (beforeAll):
286         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
287         (Test::Test):
288         (Test::~Test): Deleted.
289
290 2014-11-21  Zalan Bujtas  <zalan@apple.com>
291
292         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
293         https://bugs.webkit.org/show_bug.cgi?id=138981
294
295         Reviewed by Simon Fraser.
296
297         * MiniBrowser/mac/SettingsController.h:
298         * MiniBrowser/mac/SettingsController.m:
299         (-[SettingsController _populateMenu]):
300         (-[SettingsController validateMenuItem:]):
301         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
302         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
303         * MiniBrowser/mac/WK1BrowserWindowController.m:
304         (-[WK1BrowserWindowController didChangeSettings]):
305         * MiniBrowser/mac/WK2BrowserWindowController.m:
306         (-[WK2BrowserWindowController didChangeSettings]):
307
308 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
309
310         Remove http lock code from webkitperl
311         https://bugs.webkit.org/show_bug.cgi?id=138959
312
313         Reviewed by Alexey Proskuryakov.
314
315         * Scripts/webkitperl/httpd.pm:
316         (cleanUp):
317         (extractLockNumber): Deleted.
318         (getLockFiles): Deleted.
319         (getNextAvailableLockNumber): Deleted.
320         (getLockNumberForCurrentRunning): Deleted.
321         (waitForHTTPDLock): Deleted.
322         (scheduleHttpTesting): Deleted.
323         (getWaitTime): Deleted.
324
325 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
326
327         [EFL] The option value of fixed layout is false in MiniBrowser
328         https://bugs.webkit.org/show_bug.cgi?id=138830
329
330         Reviewed by Gyuyoung Kim.
331
332         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
333
334         * MiniBrowser/efl/main.c:
335
336 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
337
338         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
339         https://bugs.webkit.org/show_bug.cgi?id=138871
340
341         Reviewed by Carlos Garcia Campos.
342
343         Add a test case for the convenience API for posting user messages
344         added to the DOM bindings.
345
346         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
347         (testUserContentManagerMessageFromConvenienceDOMBindings):
348         (beforeAll):
349         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
350         (documentLoadedCallback):
351
352 2014-11-19  Dana Burkart  <dburkart@apple.com>
353
354         Work around the fact that different masters may have different names for their codebases.
355         https://bugs.webkit.org/show_bug.cgi?id=138878
356
357         Reviewed by Mark Rowe.
358
359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
360         (parseRevisionProperty): Changed.
361         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
362         opensource / internal codebase naming convention.
363
364 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
365
366         AX: Screen braille input doesn't work on forms.
367         https://bugs.webkit.org/show_bug.cgi?id=138804
368
369         Unreviewed build fix.
370
371         * DumpRenderTree/AccessibilityUIElement.cpp:
372         (AccessibilityUIElement::setValue):
373
374 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
375
376         AX: Screen braille input doesn't work on forms.
377         https://bugs.webkit.org/show_bug.cgi?id=138804
378
379         Reviewed by Mario Sanchez Prada.
380
381         Add a method to setValue through the AX API in DRT.
382
383         * DumpRenderTree/AccessibilityUIElement.cpp:
384         (setValueCallback):
385         (AccessibilityUIElement::getJSClass):
386         * DumpRenderTree/AccessibilityUIElement.h:
387         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
388         (AccessibilityUIElement::setValue):
389         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
390         (AccessibilityUIElement::setValue):
391
392 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
393
394         Remove the WinCairo buildbot
395         https://bugs.webkit.org/show_bug.cgi?id=138805
396
397         Reviewed by Alex Christensen.
398
399         * BuildSlaveSupport/build.webkit.org-config/config.json:
400         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
401         (appendCustomBuildFlags):
402         * BuildSlaveSupport/test-result-archive:
403         (archiveTestResults):
404
405 2014-11-18  Daniel Bates  <dabates@apple.com>
406
407         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
408         SPI are not available in public SDK
409         https://bugs.webkit.org/show_bug.cgi?id=138802
410
411         Reviewed by David Kilzer.
412
413         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
414
415         * DumpRenderTree/mac/CheckedMalloc.cpp:
416
417 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
418
419         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
420
421         Forgot to fix this test before landing.
422
423         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
424         (testWebViewDefaultContext):
425
426 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
427
428         [GTK] Add API to create a WebKitWebContext
429         https://bugs.webkit.org/show_bug.cgi?id=138826
430
431         Reviewed by Gustavo Noronha Silva.
432
433         Use a different WebKitWebContext for every test to ensure test
434         cases are independent to each other. Tests using DBus to
435         communicate with the injected bundle extension now use a unique
436         name for the well known DBus name.
437
438         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
439         (beforeAll): Remove comment about the order of the tests and
440         move the success test before the failed one now that tests don't
441         depend on each others.
442         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
443         (beforeAll): Remove call to set the web extensions directory,
444         since this is now done for all test in the Test constructor.
445         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
446         (beforeAll): Do not create a temporary directory, a temporary data
447         directory is now created for all tests.
448         (afterAll):
449         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
450         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
451         to the web process test runner.
452         (testWebKitDOMNodeInsertion): Ditto.
453         (testWebKitDOMNodeTagNames): Ditto.
454         (beforeAll): Remove call to set the web extensions directory.
455         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
456         (runTest): Pass the web extension ID to the web process test runner.
457         (beforeAll): Remove call to set the web extensions directory.
458         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
459         (runTest): Pass the web extension ID to the web process test runner.
460         (beforeAll): Remove call to set the web extensions directory.
461         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
462         (createFileAtDestination): Use Test::dataDirectory() as base dir
463         for temporary files.
464         (beforeAll): Do not create a temporary directory.
465         (afterAll):
466         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
467         (webkitFrameTestRun): Pass the web extension ID to the web process
468         test runner.
469         (beforeAll): Remove call to set the web extensions directory.
470         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
471         (beforeAll): Remove call to set the web extensions directory.
472         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
473         (testProcessPerWebView): Use local member instead of global variable.
474         (testMultiprocessWebViewCreateReadyClose): Ditto.
475         (beforeAll): Do not connect to initialize-web-extensions, Test now
476         connects to the signal for all tests and calls a virtual method
477         that test can override.
478         (afterAll):
479         (initializeWebExtensions): Deleted.
480         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
481         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
482         for temporary files.
483         (beforeAll): Do not create a temporary directory.
484         (afterAll):
485         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
486         (beforeAll): Remove call to set the web extensions directory.
487         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
488         (beforeAll): Remove comment about the tests order.
489         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
490         (testWebExtensionGetTitle): Build the DBus service name using the
491         web extension ID.
492         (testDocumentLoadedSignal): Ditto.
493         (testWebKitWebViewProcessCrashed): Ditto.
494         (testWebExtensionIsolatedWorld): Ditto.
495         (beforeAll): Remove initialization-user-data test, since now all
496         tests are passing user data to the web extension.
497         (testWebExtensionInitializationUserData): Deleted.
498         (initializeWebExtensions): Deleted.
499         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
500         (testSetDirectory): Use the web context member inherited from Test.
501         (testClearDatabase): Ditto.
502         (testGetFaviconURI): Ditto.
503         (beforeAll): Do not create a temporary directory.
504         (afterAll):
505         (webkitFaviconDatabaseFinalizedCallback): Deleted.
506         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
507         (UserContentManagerTest::UserContentManagerTest):
508         (beforeAll): Remove call to set the web extensions directory.
509         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
510         (testWebContextDefault): Check also that a newly create web
511         context is not the default web context.
512         (testWebContextSpellChecker): Use the web context member inherited
513         from Test.
514         (testWebContextLanguages): Ditto.
515         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
516         (methodCallCallback): Remove GetInitializationUserData method.
517         (webkit_web_extension_initialize_with_user_data): Always create
518         the DBus name using the user data provided.
519         (makeBusName): Deleted.
520         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
521         (webkit_web_extension_initialize_with_user_data): Create the DBus
522         name using the user data provided.
523         (webkit_web_extension_initialize): Deleted.
524         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
525         (Test::dataDirectory): Return the temporary data directory.
526         (removeNonEmptyDirectory): Also remove directories recursively.
527         (main): Remove the disk cache directory initialization, since this
528         is now done in the Test constructor.
529         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
530         (Test::initializeWebExtensionsCallback): Call the virtual method
531         initializeWebExtensions()
532         (Test::Test): Create a new WebKitWebContext and initialize it.
533         (Test::~Test): Disconnect initialize-web-extensions signal.
534         (Test::initializeWebExtensions): Set the web extensions directory
535         and user data.
536         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
537         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
538         (WebProcessTestRunner::runTest): Build the DBus proxy using a
539         unique name created with the Test web extension ID.
540         (WebProcessTestRunner::proxy): Deleted.
541         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
542         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
543         (WebViewTest::WebViewTest): Create the web view with the Test web
544         context.
545         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
546         content manager parameter to the constructor.
547
548 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
549
550         [GTK] Mesa build fails over llvm-3.5
551         https://bugs.webkit.org/show_bug.cgi?id=138825
552
553         Reviewed by Gustavo Noronha Silva.
554
555         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
556
557         * gtk/jhbuild.modules:
558         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
559
560 2014-11-17  Daniel Bates  <dabates@apple.com>
561
562         Unreviewed, rolling out r176232.
563
564         Broke the Mac build. Will investigate offline.
565
566         Reverted changeset:
567
568         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
569         MobileGestalt"
570         https://bugs.webkit.org/show_bug.cgi?id=138802
571         http://trac.webkit.org/changeset/176232
572
573 2014-11-17  Daniel Bates  <dabates@apple.com>
574
575         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
576         SPI are not available in public SDK
577         https://bugs.webkit.org/show_bug.cgi?id=138802
578
579         Reviewed by David Kilzer.
580
581         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
582
583         * DumpRenderTree/mac/CheckedMalloc.cpp:
584
585 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
586
587         Having 30+ flaky failures breaks EWS
588         https://bugs.webkit.org/show_bug.cgi?id=138743
589
590         Reviewed by Alexey Proskuryakov.
591
592         Adds tests to ensure that the problem has been solved.
593         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
594         (test_first_failure_limit):
595         (test_first_failure_limit_with_some_tree_redness):
596         (test_second_failure_limit):
597         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
598         (test_first_and_second_failure_limit):
599         (test_first_and_clean_failure_limit):
600         (test_first_second_and_clean_failure_limit):
601         (test_very_red_tree_retry): Deleted.
602         Really this was renamed to test_first_second_and_clean_failure_limit.
603         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
604         Makes the appropriate changes to PatchAnalysisTask to make sure that
605         even when the first test run hits the failure limit, it will still try
606         a second run.
607         (PatchAnalysisTask._results_failed_different_tests):
608         (PatchAnalysisTask._test_patch):
609         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
610
611 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
612
613         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
614         https://bugs.webkit.org/show_bug.cgi?id=136018
615
616         Reviewed by Carlos Garcia Campos.
617
618         It is possible that the order of -L arguments in the output of
619         pkg-config is wrong, which causes the linker to find the wrong
620         version (usually older version) of libraries when running
621         gtkdoc-scangobj.
622
623         * gtk/gtkdoc.py:
624         (GTKDoc._run_gtkdoc_scangobj):
625
626 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
627
628         Bump EFL version to 1.12.0
629         https://bugs.webkit.org/show_bug.cgi?id=138733
630
631         Reviewed by Gyuyoung Kim.
632
633         * efl/jhbuild.modules:
634
635 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
636
637         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
638         https://bugs.webkit.org/show_bug.cgi?id=138771
639
640         Reviewed by Chris Fleizach.
641
642         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
643
644         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
645
646 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
647
648         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
649         https://bugs.webkit.org/show_bug.cgi?id=138767
650
651         Reviewed by Chris Fleizach.
652
653         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
654
655         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
656
657 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
658
659         Add shortcut macros to Mac TestExpectations
660         https://bugs.webkit.org/show_bug.cgi?id=138729
661
662         Reviewed by Simon Fraser.
663
664         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
665         Add version macros for current OS versions.
666
667 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
668
669         https://bugs.webkit.org/show_bug.cgi?id=138628
670         A patch that doesn't apply is stuck in commit queue
671
672         Rubber-stamped by David Kilzer.
673
674         This also hopefully fixes other issues:
675         - a patch that has cq+ flag set by a non-committer kills commit queue;
676         - EWS never reports failing tests, and keeps spinning instead.
677
678         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
679         (Bugzilla.set_flag_on_attachment):
680         (Bugzilla.obsolete_attachment):
681         Apply the fix from r174797 to more places.
682
683 2014-11-13  Dan Bernstein  <mitz@apple.com>
684
685         Policy client not called for navigations through the page cache
686         https://bugs.webkit.org/show_bug.cgi?id=138703
687
688         Reviewed by Alexey Proskuryakov.
689
690         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
691         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
692         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
693
694 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
695
696         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
697         https://bugs.webkit.org/show_bug.cgi?id=137867
698
699         Reviewed by Chris Fleizach.
700
701         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
702         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
703         able to test for the presence of ATK_ROLE_INVALID.
704
705         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
706         (WTR::AccessibilityUIElement::role):
707
708 2014-11-13  Juergen Ributzka  <juergen@apple.com>
709
710         Update the "combineModules" script to handel more LLVM metadata.
711         https://bugs.webkit.org/show_bug.cgi?id=138514
712
713         Reviewed by Filip Pizlo.
714
715         * ReducedFTL/combineModules.rb:
716
717 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
718
719         Allow constructing a base PassRef with a derived Ref
720         https://bugs.webkit.org/show_bug.cgi?id=138701
721
722         Reviewed by Andreas Kling
723
724         * TestWebKitAPI/Tests/WTF/Ref.cpp:
725         (TestWebKitAPI::passWithPassRef):
726         (TestWebKitAPI::passWithPassRefPtr):
727         (TestWebKitAPI::TEST):
728
729 2014-11-05  Ada Chan  <adachan@apple.com>
730
731         Implement new plug-in API for muting plug-ins
732         https://bugs.webkit.org/show_bug.cgi?id=138105
733
734         Reviewed by Anders Carlsson.
735
736         Add a new plug-in test for the mute API.
737
738         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
739         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
740         (SetMuted::SetMuted):
741         (SetMuted::isMuted):
742         (SetMuted::cachedIsMuted):
743         (SetMuted::ScriptableObject::hasProperty):
744         (SetMuted::ScriptableObject::getProperty):
745         (SetMuted::ScriptableObject::pluginTest):
746         (SetMuted::NPP_New):
747         (SetMuted::NPP_GetValue):
748         (SetMuted::NPP_SetValue):
749
750 2014-11-12  Philippe Normand  <pnormand@igalia.com>
751
752         Unreviewed, GTK gardening.
753
754         * Scripts/run-gtk-tests:
755         (TestRunner): Skip the UserMediaBasic test because it depends on
756         constraints validation which is going to be fixed in bug #136449.
757
758 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
759
760         [GTK] Expose user script messages to GObject DOM bindings
761         https://bugs.webkit.org/show_bug.cgi?id=138411
762
763         Reviewed by Philippe Normand.
764
765         Add a test case to check that user script messages sent using the
766         DOM bindings API are also received in the UI process.
767
768         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
769         (UserScriptMessageTest::waitUntilMessageReceived):
770         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
771         (testUserContentManagerScriptMessageFromDOMBindings):
772         (beforeAll):
773         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
774         (documentLoadedCallback):
775
776 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
777
778         Unreviewed. Fix GTK+ clean build after r175930.
779
780         Partial rollout of r175930 to not build the new unit test that
781         broke clean builds in GTK+ port.
782
783         * TestWebKitAPI/PlatformGTK.cmake:
784
785 2014-09-01  Philippe Normand  <pnormand@igalia.com>
786
787         [WK2] UserMediaClient support
788         https://bugs.webkit.org/show_bug.cgi?id=123158
789
790         Reviewed by Benjamin Poulain.
791
792         Simple API test for the UserMedia permission request API. The
793         required test infrastructure is also added, inspired by the
794         Geolocation infrastructure.
795
796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
797         Permission request.
798         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
799         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
800         (TestWebKitAPI::TEST):
801         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
802         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
803         helper method to set the permission request result without user interaction.
804         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
805         (WTR::InjectedBundle::setUserMediaPermission):
806         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
807         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
808         (WTR::TestRunner::setUserMediaPermission):
809         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
810         * WebKitTestRunner/TestController.cpp:
811         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
812         request handler.
813         (WTR::TestController::createOtherPage): Enable the new UserMedia
814         permission request handler.
815         (WTR::TestController::createWebViewWithOptions): Ditto.
816         (WTR::TestController::resetPreferencesToConsistentValues): Enable
817         MediaStream support, this is needed for getUserMedia.
818         (WTR::TestController::resetStateToConsistentValues): clear
819         UserMedia permissions list and flags.
820         (WTR::TestController::setUserMediaPermission): Set permission
821         request result and distpatch it.
822         (WTR::TestController::handleUserMediaPermissionRequest): Save
823         request and dispatch it.
824         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
825         Dispatch cached permission requests.
826         * WebKitTestRunner/TestController.h:
827         * WebKitTestRunner/TestInvocation.cpp:
828         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
829
830 2014-11-11  David Kilzer  <ddkilzer@apple.com>
831
832         webkit-patch --suggest-reviewers is broken with newer versions of git
833         <http://webkit.org/b/138627>
834
835         Reviewed by Michael Saboff with feedback from Daniel Bates.
836
837         * Scripts/webkitpy/common/checkout/scm/git.py:
838         (Git._changes_files_for_commit): Strip blank lines instead of
839         assuming there is always a blank line at the beginning of the
840         list.
841
842 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
843
844         DRT and WKTR touch disk cache
845         https://bugs.webkit.org/show_bug.cgi?id=138622
846
847         Reviewed by Geoffrey Garen.
848
849         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
850         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
851         because this function uses the shared cache.
852
853         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
854         Create an empty shared cache to prevent a default one from being created on disk.
855
856 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
857
858         [CSS Grid Layout] Limit the size of explicit/implicit grid
859         https://bugs.webkit.org/show_bug.cgi?id=136217
860
861         Reviewed by Andreas Kling.
862
863         Added a new unit test for the CSS parser. Right now it only checks
864         that we properly clamp the maximum number of tracks on a grid to a
865         maximum of 1 million.
866
867         * TestWebKitAPI/CMakeLists.txt:
868         * TestWebKitAPI/PlatformEfl.cmake:
869         * TestWebKitAPI/PlatformGTK.cmake:
870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
871         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
872         (TestWebKitAPI::computeNumberOfTracks): Helper function.
873         (TestWebKitAPI::TEST): Added a
874         CSSPropertyParserTest.GridTrackLimits test case.
875
876 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
877
878         webkitpy test fix after r175867
879         https://bugs.webkit.org/show_bug.cgi?id=138607
880
881         Reviewed by Philippe Normand.
882
883         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
884         (GDBCrashLogGeneratorTest.test_generate_crash_log):
885
886 2014-11-10  Philippe Normand  <pnormand@igalia.com>
887
888         webkitpy: demangle C++ symbols from crash log stderr
889         https://bugs.webkit.org/show_bug.cgi?id=138565
890
891         Reviewed by Alexey Proskuryakov.
892
893         * Scripts/webkitpy/port/linux_get_crash_log.py:
894         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
895         with c++filt.
896
897 2014-11-10  Philippe Normand  <pnormand@igalia.com>
898
899         [GTK] fix up the GDB backtrace report tool
900         https://bugs.webkit.org/show_bug.cgi?id=138564
901
902         Reviewed by Carlos Garcia Campos.
903
904         * Scripts/webkitpy/port/gtk.py:
905         (GtkPort._get_crash_log): Match the process name reported by the
906         driver with the GTK port WebProcess executable filename.
907         * Scripts/webkitpy/port/linux_get_crash_log.py:
908         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
909         program.
910         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
911         pattern to workaround the 16 characters size limit of %e.
912
913 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
914
915         Unreviewed, moved myself to the list of committers.
916
917         * Scripts/webkitpy/common/config/contributors.json:
918
919 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
920
921         [EFL] Fix the test font path after r175555.
922
923         Reviewed by Csaba Osztrogonác.
924
925         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
926
927 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
928
929         Fix the exception fuzz helper to generate targets in the correct range
930         https://bugs.webkit.org/show_bug.cgi?id=138544
931
932         Reviewed by Filip Pizlo.
933
934         Currently, the script generates exception fuzz targets in the range of
935         0..($checkCount-1). However, target 0 is never hit, while target 1 is
936         always outside of the outermost try block of the tests, which therefore
937         prints unexpected output and results in false failures when fired at.
938         Additionally, target $checkCount is never generated.
939
940         This patch fixes the script to generate targets in the range of
941         2..$checkCount.
942
943         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
944
945 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
946
947         make-passwords-json.py should generarate everything needed for testing
948         https://bugs.webkit.org/show_bug.cgi?id=138503
949
950         Reviewed by Ryosuke Niwa.
951
952         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
953         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
954         Additionally generate auth.json, credentials.cfg and committers.cfg too.
955         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
956         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
957         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
958         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
959
960 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
961
962         [GTK] generate-gtkdoc should ignore invalid files
963         https://bugs.webkit.org/show_bug.cgi?id=138542
964
965         Reviewed by Darin Adler.
966
967         * gtk/generate-gtkdoc:
968         (files_to_ignore.file_should_be_ignored): Return True to ignore
969         invalid files.
970
971 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
972
973         Delete cookies between tests
974         https://bugs.webkit.org/show_bug.cgi?id=138528
975
976         Reviewed by Sam Weinig.
977
978         * DumpRenderTree/mac/DumpRenderTree.mm:
979         (resetWebPreferencesToConsistentValues):
980         * WebKitTestRunner/TestController.cpp:
981         (WTR::TestController::resetPreferencesToConsistentValues):
982         Do it.
983
984         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
985         (WTR::InjectedBundle::beginTesting):
986         Added a FIXME.
987
988 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
989
990         [GTK] Run layout tests using the network process
991         https://bugs.webkit.org/show_bug.cgi?id=138428
992
993         Reviewed by Martin Robinson.
994
995         Shared secondary process is the default in the GTK+ port, but we
996         should run the tests using the network process to ensure
997         everything works with the network process. In the future, the
998         shared secondary process model might be a special case of multiple
999         processes with 1 as maximum number of processes, but always using
1000         the network process.
1001
1002         * WebKitTestRunner/TestController.cpp:
1003         (WTR::TestController::initialize):
1004
1005 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1006
1007         [GTK] Allow to create a view with a related page in WTR
1008         https://bugs.webkit.org/show_bug.cgi?id=138501
1009
1010         Reviewed by Martin Robinson.
1011
1012         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1013         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
1014         related page to WKViewCreate.
1015         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1016         (WTR::PlatformWebView::PlatformWebView): Pass the given related
1017         page to WKViewCreate.
1018
1019 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1020
1021         WTR crashes after running a test when NetworkProcess enabled
1022         https://bugs.webkit.org/show_bug.cgi?id=138500
1023
1024         Reviewed by Alexey Proskuryakov.
1025
1026         WebNotificationProvider destructor is calling
1027         WKNotificationManagerSetProvider, but m_notificationManager is
1028         null because removeNotificationManager was already called.
1029
1030         * WebKitTestRunner/WebNotificationProvider.cpp:
1031         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
1032         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
1033
1034 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
1035
1036         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
1037         regarding incorrect call to PatchAnalysisTask.report_failure
1038         https://bugs.webkit.org/show_bug.cgi?id=138229
1039
1040         Reviewed by Daniel Bates.
1041
1042         * Scripts/webkitpy/common/net/layouttestresults.py:
1043         Makes sure test_results returns a list.
1044         (LayoutTestResults.test_results):
1045         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1046         Makes unit tests also check to make sure
1047         task.results_from_patch_test_run() and
1048         task.results_from_test_run_without_patch return instances of
1049         LayoutTestResults.
1050         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1051         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1052         Condenses duplicate code into _should_defer_patch_or_throw, and
1053         removes the now-unused _clean_tree_results member.
1054         (PatchAnalysisTask.__init__):
1055         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1056         (PatchAnalysisTask._should_defer_patch_or_throw):
1057         (PatchAnalysisTask._test_patch):
1058         (PatchAnalysisTask.results_from_patch_test_run):
1059         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
1060         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1061         Removes needless call to results_from_test_run_without_patch
1062         (AbstractEarlyWarningSystem._failing_tests_message):
1063         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1064         Changes order of test failure messages to be in the order that they
1065         appear.
1066         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1067         * Scripts/webkitpy/tool/commands/queues.py:
1068         Removes needless call to results_from_test_run_without_patch.
1069         (CommitQueue._failing_tests_message):
1070         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1071         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
1072
1073 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
1074
1075         Unreviewed. Reorder my e-mail addresses in contributors.json
1076
1077         * Scripts/webkitpy/common/config/contributors.json:
1078
1079 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
1080
1081         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
1082         https://bugs.webkit.org/show_bug.cgi?id=138475
1083
1084         Reviewed by Ryosuke Niwa.
1085
1086         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
1087         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
1088         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
1089         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
1090
1091         * Scripts/webkitpy/common/checkout/scm/git.py:
1092         (Git._run_git_svn_find_rev):
1093         Add comment mentioning that svn_revisions need to begin with 'r'.
1094         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
1095         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
1096         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
1097
1098 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1099
1100         [GTK] Add context menu API to Web Process Extensions
1101         https://bugs.webkit.org/show_bug.cgi?id=138311
1102
1103         Reviewed by Gustavo Noronha Silva.
1104
1105         Add tests cases for WebKitWebPage::context-menu signal.
1106
1107         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1108         (testContextMenuWebExtensionMenu):
1109         (testContextMenuWebExtensionNode):
1110         (beforeAll):
1111         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1112         (serializeContextMenu):
1113         (serializeNode):
1114         (contextMenuCallback):
1115         (pageCreatedCallback):
1116
1117 2014-11-06  Commit Queue  <commit-queue@webkit.org>
1118
1119         Unreviewed, rolling out r175690.
1120         https://bugs.webkit.org/show_bug.cgi?id=138460
1121
1122         We are not ready to run layout tests using the network process
1123         yet (Requested by KaL on #webkit).
1124
1125         Reverted changeset:
1126
1127         "[GTK] Run layout tests using the network process"
1128         https://bugs.webkit.org/show_bug.cgi?id=138428
1129         http://trac.webkit.org/changeset/175690
1130
1131 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1132
1133         [GTK] Run layout tests using the network process
1134         https://bugs.webkit.org/show_bug.cgi?id=138428
1135
1136         Reviewed by Martin Robinson.
1137
1138         Shared secondary process is the default in the GTK+ port, but we
1139         should run the tests using the network process to ensure
1140         everything works with the network process. In the future, the
1141         shared secondary process model might be a special case of multiple
1142         processes with 1 as maximum number of processes, but always using
1143         the network process.
1144
1145         * WebKitTestRunner/TestController.cpp:
1146         (WTR::TestController::initialize):
1147
1148 2014-11-05  Dan Bernstein  <mitz@apple.com>
1149
1150         Remove the unused deletion UI feature
1151         https://bugs.webkit.org/show_bug.cgi?id=138442
1152
1153         Rubber-stamped by Alexey Proskuryakov.
1154
1155         * DumpRenderTree/mac/EditingDelegate.mm:
1156         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
1157         delegate method that’s been removed.
1158
1159 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1160
1161         fast/dom/remove-body-during-body-replacement2.html fails on WK2
1162         https://bugs.webkit.org/show_bug.cgi?id=138334
1163
1164         Reviewed by Anders Carlsson.
1165
1166         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
1167         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
1168         -makeFirstResponder calls, which may or may not be needed for other reasons, but
1169         it also needs to reset internal focus explicitly.
1170
1171         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
1172         WebKit behavior appears wrong, but it matches Firefox.
1173
1174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1175         (WTR::InjectedBundlePage::resetAfterTest):
1176
1177 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1178
1179         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1180         https://bugs.webkit.org/show_bug.cgi?id=137862
1181
1182         Reviewed by Gustavo Noronha Silva.
1183
1184         Add a test case to check that WebKitWebResource::failed-with-tls-errors
1185         is emitted when a subresource load fails due to TLS errors.
1186
1187         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1188         (TLSSubresourceTest::resourceLoadStartedCallback):
1189         (TLSSubresourceTest::TLSSubresourceTest):
1190         (TLSSubresourceTest::subresourceFailedCallback):
1191         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1192         (TLSSubresourceTest::subresourceLoadStarted):
1193         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1194         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1195         (testSubresourceLoadFailedWithTLSErrors):
1196         (httpsServerCallback):
1197         (httpServerCallback):
1198         (beforeAll):
1199
1200 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1201
1202         Build fix for some compiler versions.
1203
1204         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1205         unhappy because this is a getter, and these shouldn't have side effects.
1206
1207 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1208
1209         Add a method for performing cherrypick-merges.
1210         https://bugs.webkit.org/show_bug.cgi?id=138375
1211
1212         Reviewed by Ryosuke Niwa.
1213
1214         Adds support for cherrypick-merges.
1215
1216         * Scripts/webkitpy/common/checkout/scm/git.py:
1217         (Git.cherrypick_merge): Added.
1218
1219 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1220
1221         Add a way to ascertain the SVN URL associated with a Git branch.
1222         https://bugs.webkit.org/show_bug.cgi?id=138374
1223
1224         Reviewed by Ryosuke Niwa.
1225
1226         The svn_url method returns the SVN URL associated with the current Git branch.
1227
1228         * Scripts/webkitpy/common/checkout/scm/git.py:
1229         (Git.svn_url): Added.
1230
1231 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1232
1233         Add the ability to search for modifications that are staged for commit.
1234         https://bugs.webkit.org/show_bug.cgi?id=138373
1235
1236         Reviewed by Ryosuke Niwa and Daniel Bates.
1237
1238         This makes is easy to do identify files that require merge post-processing,
1239         in addition to stand-alone utility.
1240
1241         * Scripts/webkitpy/common/checkout/scm/git.py:
1242         (Git.modifications_staged_for_commit): Added.
1243
1244 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1245
1246         Add a branch keyword argument to _run_git_svn_find_rev.
1247         https://bugs.webkit.org/show_bug.cgi?id=138372
1248
1249         Reviewed by Ryosuke Niwa.
1250
1251         The addition of this keyword argument allows clients to determine the Git hash
1252         of commits made on an SVN branch, provided that branch has been fetched locally.
1253
1254         * Scripts/webkitpy/common/checkout/scm/git.py:
1255         (Git._run_git_svn_find_rev):
1256         Add a branch keyword argument that is added to the end of the command, if present.
1257
1258 2014-11-04  Chris Dumez  <cdumez@apple.com>
1259
1260         Add ptr() method to Ref class
1261         https://bugs.webkit.org/show_bug.cgi?id=138361
1262
1263         Reviewed by Darin Adler.
1264
1265         Use the new Ref::ptr() method.
1266
1267         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1268         (TestWebKitAPI::TEST):
1269
1270 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1271
1272         [jhbuild] Make it possible to build GTK/EFL in same repository
1273         https://bugs.webkit.org/show_bug.cgi?id=137448
1274
1275         Reviewed by Martin Robinson.
1276
1277         * Scripts/webkitdirs.pm:
1278         (getJhbuildPath):
1279         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
1280         (getPlatformFontsPath):
1281         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1282         (WTR::getFontsPath):
1283         * jhbuild/jhbuild-wrapper:
1284         (determine_platform):
1285         (install_jhbuild):
1286         * jhbuild/jhbuildrc_common.py:
1287         (init):
1288
1289 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1290
1291         [EFL] Bump LLVM to version 3.5.0
1292         https://bugs.webkit.org/show_bug.cgi?id=138312
1293
1294         Reviewed by Csaba Osztrogonác.
1295
1296         * efl/jhbuild.modules:
1297         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
1298         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
1299
1300 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
1301
1302         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
1303         https://bugs.webkit.org/show_bug.cgi?id=138257
1304
1305         Reviewed by Tim Horton.
1306         
1307         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
1308         the user to toggle region page overlays on and off. Two overlays are available,
1309         for the non-fast scrollable region, and the region of element with wheel
1310         event handlers.
1311
1312         * MiniBrowser/mac/SettingsController.h:
1313         * MiniBrowser/mac/SettingsController.m:
1314         (-[SettingsController _populateMenu]):
1315         (-[SettingsController validateMenuItem:]):
1316         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
1317         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
1318         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
1319         (-[SettingsController toggleDebugOverlay:]):
1320         (-[SettingsController debugOverlayVisible:]):
1321         * MiniBrowser/mac/WK2BrowserWindowController.m:
1322         (-[WK2BrowserWindowController didChangeSettings]):
1323
1324 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
1325
1326         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
1327         https://bugs.webkit.org/show_bug.cgi?id=138323
1328
1329         Reviewed by Zalan Bujtas.
1330
1331         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
1332
1333 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1334
1335         [ninja] Don't remove response files for verbose builds
1336         https://bugs.webkit.org/show_bug.cgi?id=137816
1337
1338         Reviewed by Csaba Osztrogonác.
1339
1340         * Scripts/webkitdirs.pm:
1341         (determineNinjaVersion):
1342         (buildCMakeGeneratedProject):
1343
1344 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
1345
1346         [GTK] Fix the build of FTL JIT
1347         https://bugs.webkit.org/show_bug.cgi?id=138298
1348
1349         Reviewed by Carlos Garcia Campos.
1350
1351         * gtk/jhbuild-optional.modules:
1352         Bump up LLVM version to 3.5.0 release and apply patches.
1353         * gtk/patches/llvm-elf-add-stackmaps.patch:
1354         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
1355         trunk.
1356         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
1357         Added. Ensures that PC-relative relocations in EH frames are not
1358         truncated to 32 bits on x86_64.
1359
1360 2014-10-31  Michael Saboff  <msaboff@apple.com>
1361
1362         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
1363         https://bugs.webkit.org/show_bug.cgi?id=138268
1364
1365         Reviewed by Andreas Kling.
1366
1367         Added a --arch and --os option to set or override the values that are
1368         normally computed based on examining the JavaScriptCore we want to test.
1369
1370         * Scripts/run-jsc-stress-tests:
1371
1372 2014-10-31  Dan Bernstein  <mitz@apple.com>
1373
1374         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
1375         https://bugs.webkit.org/show_bug.cgi?id=138259
1376
1377         Reviewed by Geoff Garen.
1378
1379         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
1380         going to be empty to silence the warning.
1381
1382 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
1383
1384         [GTK] Support script message handlers WebKitUserContentManager
1385         https://bugs.webkit.org/show_bug.cgi?id=133730
1386
1387         Reviewed by Carlos Garcia Campos.
1388
1389         Support user script message handlers in WebKitUserContentManager.
1390         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
1391         an option is added to the CMake build files. The option is disabled
1392         globally by default, and the WebKitGTK port enables it. On the API
1393         level, two new methods to register and unregister names are provided
1394         in the "window.webkit" namespace, and on message reception the
1395         "WebKitUserContentManager::script-message-received" signal is
1396         emitted, using the registered names as signal detail.
1397
1398         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1399         Add test case for user script message handlers.
1400         (scriptMessageReceived):
1401         (testUserContentManagerScriptMessageReceived):
1402         (beforeAll):
1403
1404 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1405
1406         bisect-builds should support WebKit clients other than Safari
1407         https://bugs.webkit.org/show_bug.cgi?id=138225
1408
1409         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
1410
1411         The -a / --application optional argument allows the user to specify which application (or application bundle)
1412         should be run against the WebKit nightly builds.
1413
1414         Reviewed by David Kilzer.
1415
1416         * Scripts/bisect-builds:
1417         Swap out $safariPath for the more general $applicationPath
1418         Leave --safari-path as a commandline option for backwards compatibility
1419         (mountAndRunNightly):
1420         Use File::Spec->cat correctly (one directory per argument)
1421         Use open --wait-apps instead of running the target application directly
1422
1423 2014-10-30  Dana Burkart  <dburkart@apple.com>
1424
1425         <rdar://problem/18821260> Perpare for the mysterious future
1426
1427         Reviewed by Lucas Forschler.
1428
1429         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1430         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1431         * LayoutTestRelay/Configurations/Base.xcconfig:
1432         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1433         * MiniBrowser/Configurations/Base.xcconfig:
1434         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1435         * TestWebKitAPI/Configurations/Base.xcconfig:
1436         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1437         * WebKitLauncher/Configurations/Base.xcconfig:
1438         * WebKitTestRunner/Configurations/Base.xcconfig:
1439         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1440
1441 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1442
1443         Update safariVersion to safariVersionString
1444         https://bugs.webkit.org/show_bug.cgi?id=138193
1445
1446         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
1447         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
1448
1449         Rubber-stamped by David Kilzer.
1450
1451         * Scripts/bisect-builds:
1452         (makeNightlyList):
1453         Compare safariVersionString to a string literal, instead of safariVersion.
1454
1455 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
1456
1457         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
1458         https://bugs.webkit.org/show_bug.cgi?id=137775
1459
1460         Reviewed by Carlos Garcia Campos.
1461
1462         * MiniBrowser/gtk/BrowserWindow.c:
1463         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
1464         (browser_window_init):
1465
1466 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
1467
1468         CommitQueue and EWS should reject any patches that result in consistent test
1469         failures that aren't present on the tree.
1470         https://bugs.webkit.org/show_bug.cgi?id=138184
1471
1472         Reviewed by Alexey Proskuryakov.
1473
1474         * Scripts/webkitpy/layout_tests/models/test_results.py:
1475         Adds a simple hashing function to allow for set operations to handle
1476         TestResult objects properly.
1477         (TestResult.__hash__):
1478         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1479         Adds one unit test, and modifies others to agree with the notion that
1480         patches that introduce new test failures (but also have flakyness)
1481         should be rejected rather than spin.
1482         (MockCommitQueue.report_flaky_tests):
1483         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1484         (test_double_flaky_test_failure):
1485         (test_two_flaky_tests):
1486         (test_very_flaky_patch):
1487         (test_very_flaky_patch_with_some_tree_redness):
1488         (test_different_test_failures):
1489         (test_different_test_failures_with_some_tree_redness):
1490         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
1491         (test_mildly_flaky_patch):
1492         (test_mildly_flaky_patch_with_some_tree_redness):
1493         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1494         Makes PatchAnalysisTask reject said patches.
1495         (PatchAnalysisTask._test_patch):
1496
1497 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1498
1499         WinCairoRequirements.zip cannot be downloaded from dropbox
1500         https://bugs.webkit.org/show_bug.cgi?id=138113
1501
1502         Reviewed by Alexey Proskuryakov.
1503
1504         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
1505
1506 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
1507
1508         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
1509         https://bugs.webkit.org/show_bug.cgi?id=138193
1510
1511         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
1512         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
1513
1514         It also does a bit of refactoring, including distinguishing between versions and version strings and
1515         saving versions to local variables instead of using eval in each conditional.
1516
1517         Reviewed by David Kilzer.
1518
1519         * Scripts/bisect-builds:
1520         (makeNightlyList):
1521         Restrict the set of nightlies to r174650 and above when running Yosemite.
1522         Restrict the set of nightlies to r157846 and above when running Mavericks.
1523         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
1524
1525 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1526
1527         [EFL] build-webkit should try harder to avoid re-running cmake
1528         https://bugs.webkit.org/show_bug.cgi?id=137949
1529
1530         Reviewed by Martin Robinson.
1531
1532         * Scripts/webkitdirs.pm:
1533         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
1534         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
1535
1536 2014-10-28  Daniel Bates  <dabates@apple.com>
1537
1538         Unify logic in RunTests.run() to run the Python unit tests
1539         https://bugs.webkit.org/show_bug.cgi?id=138160
1540
1541         Reviewed by Martin Robinson.
1542
1543         Unify the interactive and non-interactive code path for running the Python unit tests
1544         in step RunTests so as to remove duplicate code to compute the the path to the script
1545         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
1546
1547         No new tests since no functionality was changed.
1548
1549         * Scripts/webkitpy/port/base.py:
1550         (Port.python_unittest_results_directory):
1551         * Scripts/webkitpy/tool/steps/runtests.py:
1552         (RunTests.run):
1553
1554 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
1555
1556         Make runtest.py call test-webkitpy with the --json flag when in
1557         non-interactive mode.
1558         https://bugs.webkit.org/show_bug.cgi?id=137667
1559
1560         Reviewed by Daniel Bates.
1561
1562         * Scripts/webkitpy/port/base.py:
1563         Adds the python_unittest_results_directory method.
1564         (Port.python_unittest_results_directory):
1565         * Scripts/webkitpy/tool/steps/runtests.py:
1566         Changes RunTests to call test-webkitpy with the --json flag if the
1567         --non-interactive flag is set.
1568         (RunTests):
1569         (RunTests.run):
1570
1571 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
1572
1573         import-w3c-tests should use re.escape() wherever it's handling file paths
1574         https://bugs.webkit.org/show_bug.cgi?id=137934
1575
1576         This patch adds re.escape() to a few places where we're doing string
1577         conversions. This prevents errors when attribute values coincidentally
1578         have character sequences that can be interpreted as regular expressions.
1579
1580         Reviewed by Bem Jones-Bey.
1581
1582         * Scripts/webkitpy/w3c/test_converter.py:
1583         (_W3CTestConverter.convert_attributes_if_needed):
1584
1585 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1586
1587         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
1588         https://bugs.webkit.org/show_bug.cgi?id=138130
1589
1590         Reviewed by Csaba Osztrogonác.
1591
1592         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1593
1594 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
1595
1596         Fix link to Arch Linux Wiki
1597         https://bugs.webkit.org/show_bug.cgi?id=138010
1598
1599         Reviewed by Benjamin Poulain.
1600
1601         * gtk/install-dependencies:
1602
1603 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
1604
1605         Test regressions are not detected when image result is missing
1606         https://bugs.webkit.org/show_bug.cgi?id=138070
1607
1608         Reviewed by Simon Fraser.
1609
1610         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1611         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1612         Count these as regressions, not as flaky tests.
1613
1614         * Scripts/webkitpy/port/test.py:
1615         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1616         Test it.
1617
1618 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
1619
1620         Add Conrad Shultz to the contributors list.
1621
1622         * Scripts/webkitpy/common/config/contributors.json:
1623
1624 2014-10-24  Dan Bernstein  <mitz@apple.com>
1625
1626         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
1627         https://bugs.webkit.org/show_bug.cgi?id=138046
1628
1629         Reviewed by Alexey Proskuryakov.
1630
1631         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1632         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
1633         401. Otherwise, we’ll retry normally in 45 seconds.
1634
1635 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1636
1637         [GTK] Implement is_selected method on WebKitHitTestResult
1638         https://bugs.webkit.org/show_bug.cgi?id=137110
1639
1640         Reviewed by Tim Horton.
1641
1642         Add tests for new context SELECTION on WebKitHitTestResult.
1643
1644         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1645         (testContextMenuDefaultMenu):
1646         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1647         (testWebViewMouseTarget):
1648
1649 2014-10-23  Roger Fong  <roger_fong@apple.com>
1650
1651         [Win] Skip failing JSC tests following r175078
1652         https://bugs.webkit.org/show_bug.cgi?id=130967.
1653
1654         * Scripts/run-javascriptcore-tests:
1655
1656 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1657
1658         commitqueuetask_unittest.py should be made more concise.
1659         https://bugs.webkit.org/show_bug.cgi?id=137985
1660
1661         Reviewed by Alexey Proskuryakov.
1662
1663         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1664         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
1665         (MockCommitQueue.__init__):
1666         (MockCommitQueue.report_flaky_tests):
1667         (MockCommitQueue):
1668         (MockCommitQueue.get_reported_flaky_tests):
1669         (MockSimpleTestPlanCommitQueue.__init__):
1670         (MockSimpleTestPlanCommitQueue.run_command):
1671         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
1672         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1673         (test_land_failure):
1674         (test_failed_archive):
1675         (test_double_flaky_test_failure):
1676         (test_test_failure):
1677         (test_red_test_failure):
1678         (test_very_red_tree_retry):
1679         (test_red_tree_patch_rejection):
1680         (test_one_flaky_test):
1681         (test_tree_more_red_than_patch):
1682         (MockCommitQueue.test_results): Deleted.
1683         (test_simple_flaky_test_failure): Deleted.
1684         (_expect_validate): Deleted.
1685         (_expect_validate.MockDelegate): Deleted.
1686         (_expect_validate.MockDelegate.refetch_patch): Deleted.
1687         (_expect_validate.MockDelegate.expected_failures): Deleted.
1688         (_mock_patch): Deleted.
1689         (test_validate): Deleted.
1690         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1691         Fixes a bug that slipped through the cracks prior to this change.
1692         (PatchAnalysisTask._test_patch):
1693
1694 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
1695
1696         Flakiness dashboard should support OS X Yosemite
1697         https://bugs.webkit.org/show_bug.cgi?id=137986
1698
1699         Reviewed by Ryosuke Niwa.
1700
1701         * TestResultServer/app.yaml:
1702         * TestResultServer/static-dashboards/builders.jsonp:
1703         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1704
1705 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1706
1707         commitqueuetask should include more tests to ensure that the behavior
1708         of PatchAnalysisTask._test_patch() is well defined
1709         https://bugs.webkit.org/show_bug.cgi?id=137977
1710
1711         Reviewed by Alexey Proskuryakov.
1712
1713         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1714         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
1715         and more readable to define tests that are meant to test the behaviour
1716         of PatchAnalysisTask._test_patch(), and adds several unit tests.
1717         (FailingTestCommitQueue.test_results):
1718         (PatchAnalysisResult):
1719         (MockSimpleTestPlanCommitQueue):
1720         (MockSimpleTestPlanCommitQueue.__init__):
1721         (MockSimpleTestPlanCommitQueue.run_command):
1722         (MockSimpleTestPlanCommitQueue._mock_test_result):
1723         (MockSimpleTestPlanCommitQueue.test_results):
1724         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1725         (test_flaky_test_failure):
1726         (test_failed_archive):
1727         (test_two_flaky_tests):
1728         (test_one_flaky_test):
1729         (test_very_flaky_patch):
1730         (test_very_flaky_patch_with_some_tree_redness):
1731         (test_different_test_failures):
1732         (test_different_test_failures_with_some_tree_redness):
1733         (test_mildly_flaky_patch):
1734         (test_mildly_flaky_patch_with_some_tree_redness):
1735         (test_tree_more_red_than_patch):
1736
1737 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
1738
1739         PatchAnalysisTask._test_patch() needs refactoring
1740         https://bugs.webkit.org/show_bug.cgi?id=137904
1741
1742         Reviewed by Alexey Proskuryakov.
1743
1744         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1745         Fixes several small bugs, and makes minor changes to accomodate the
1746         changes in PatchAnalysisTask.
1747         (MockCommitQueue.refetch_patch):
1748         (MockCommitQueue.test_results):
1749         (test_flaky_test_failure):
1750         (test_failed_archive):
1751         (test_very_red_tree_retry):
1752         (_expect_validate.MockDelegate.refetch_patch):
1753         (MockCommitQueue.expected_failures): Deleted.
1754         (_expect_validate.MockDelegate.expected_failures): Deleted.
1755         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
1756         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
1757         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1758         Removes the unexpected_failures member, adds the _clean_tree_results
1759         member, adds a helper function for _test_patch, and refactors
1760         _test_patch to be more readable.
1761         (PatchAnalysisTask.__init__):
1762         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1763         (PatchAnalysisTask._test_patch):
1764         (PatchAnalysisTask.results_from_test_run_without_patch):
1765         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1766         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
1767         (AbstractEarlyWarningSystem.begin_work_queue):
1768         (AbstractEarlyWarningSystem._failing_tests_message):
1769         (AbstractEarlyWarningSystem.command_failed):
1770         (AbstractEarlyWarningSystem.expected_failures): Deleted.
1771         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1772         Makes changes to accomodate the changes made to PatchAnalysisTask.
1773         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1774         * Scripts/webkitpy/tool/commands/perfalizer.py:
1775         Removes Perfalizer's dependancy on ExpectedFailures. 
1776         (PerfalizerTask.refetch_patch):
1777         (PerfalizerTask.expected_failures): Deleted.
1778         * Scripts/webkitpy/tool/commands/queues.py:
1779         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
1780         initializer to allow for mock injection.
1781         (CommitQueue.__init__):
1782         (CommitQueue.begin_work_queue):
1783         (CommitQueue.process_work_item):
1784         (CommitQueue._failing_tests_message):
1785         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1786         Removes dependancy on ExpectedFailures, and instead uses mock
1787         injection.
1788         (MockCommitQueueTask):
1789         (MockCommitQueueTask.results_from_patch_test_run):
1790         (MockCommitQueueTask.results_from_test_run_without_patch):
1791         (mock_run_webkit_patch):
1792
1793 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
1794
1795         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
1796         https://bugs.webkit.org/show_bug.cgi?id=136736
1797
1798         Reviewed by Gyuyoung Kim.
1799
1800         * MiniBrowser/efl/main.c:
1801         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
1802         (window_create):
1803
1804 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1805
1806         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
1807         https://bugs.webkit.org/show_bug.cgi?id=137884
1808
1809         Reviewed by Gustavo Noronha Silva.
1810
1811         Move InputMethodFilter test from WebCore tests to WebKit2 tests
1812         and adapt it to use the new InputMethodFilter WebKit class. Instead
1813         of having virtual methods just for testing, it has a testing mode
1814         that logs the events.
1815
1816         * TestWebKitAPI/PlatformGTK.cmake:
1817         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
1818         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
1819         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
1820         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
1821         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
1822         (TestWebKitAPI::TEST):
1823         (TestWebKitAPI::temporaryGetPreeditStringOverride):
1824         (TestWebKitAPI::temporaryResetOverride):
1825         (TestWebKitAPI::verifyCanceledComposition):
1826
1827 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
1828
1829         build.webkit.org/dashboard: Cannot click on green tester bubbles
1830         https://bugs.webkit.org/show_bug.cgi?id=137909
1831
1832         Reviewed by Darin Adler.
1833
1834         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1835         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1836
1837 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
1838
1839         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
1840         https://bugs.webkit.org/show_bug.cgi?id=137932
1841
1842         Reviewed by Simon Fraser.
1843
1844         This is the first step in moving over to native Windows rendering for our layout tests.
1845         Once this change lands, approximately 300 tests will start failing on Windows. I will
1846         rebaseline these changes against our test hardware and update this bug with the
1847         commits related to that work.
1848
1849         * DumpRenderTree/win/DumpRenderTree.cpp:
1850         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
1851         we use native Windows drawing style.
1852
1853 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1854
1855         Fix FTL Native Inlining for EFL
1856         https://bugs.webkit.org/show_bug.cgi?id=137774
1857
1858         Reviewed by Michael Saboff.
1859
1860         Added Clang as an optional module to jhbuild.
1861
1862         * efl/jhbuild.modules:
1863
1864 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1865
1866         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
1867         https://bugs.webkit.org/show_bug.cgi?id=137832
1868
1869         Reviewed by Carlos Garcia Campos.
1870
1871         Ensure each test sets the TLS errors policy that it really needs.
1872         Have each test except testTLSErrorsPolicy stash and restore the original
1873         TLS errors policy. Update testTLSErrorsPolicy to account for the new
1874         default policy.
1875
1876         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1877         (testSSL):
1878         (testInsecureContent):
1879         (testTLSErrorsPolicy):
1880         (testTLSErrorsRedirect):
1881         (testTLSErrorsHTTPAuth):
1882         (testLoadFailedWithTLSErrors):
1883         (beforeAll):
1884
1885 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1886
1887         Unreviewed. Unskip inspector server unit tests.
1888
1889         They should pass now.
1890
1891         * Scripts/run-gtk-tests:
1892         (TestRunner):
1893
1894 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1895
1896         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
1897         https://bugs.webkit.org/show_bug.cgi?id=132044
1898
1899         Reviewed by Brian Burg.
1900
1901         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1902         (openRemoteDebuggingSession): Remove trailing slash when
1903         concatenating base inspector URL with the page, because the
1904         inspector returns the relative paths with a leading slash.
1905
1906 2014-10-20  Tanay C  <tanay.c@samsung.com>
1907
1908         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
1909         https://bugs.webkit.org/show_bug.cgi?id=137023
1910
1911         Reviewed by Gyuyoung Kim.
1912
1913         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
1914         (search_box_show): Modified.
1915         (search_box_hide): Modified.
1916         (on_search_field_activated): Modified.
1917         (on_search_backward_button_clicked): Modified.
1918         (on_search_forward_button_clicked): Modified.
1919         (on_search_case_option_changed): Added.
1920         (on_search_word_start_option_changed): Added.
1921         (window_create): Modified.
1922
1923 2014-10-20  Tanay C  <tanay.c@samsung.com>
1924
1925         [GTK][Minibrowser] Escape key does not hide the search box
1926         https://bugs.webkit.org/show_bug.cgi?id=137734
1927
1928         Reviewed by Philippe Normand.
1929
1930         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
1931         (stopPageLoad): Modified.
1932
1933 2014-10-18  Antti Koivisto  <antti@apple.com>
1934
1935         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
1936         https://bugs.webkit.org/show_bug.cgi?id=137855
1937
1938         Reviewed by Dan Bernstein.
1939
1940         Test and warn if the dumped response mime type differs from the platform response mime type.
1941
1942         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1943         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1944         (WTR::InjectedBundlePage::platformResponseMimeType):
1945         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1946         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1947         (WTR::InjectedBundlePage::platformResponseMimeType):
1948
1949 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
1950
1951         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
1952         https://bugs.webkit.org/show_bug.cgi?id=137835
1953
1954         Reviewed by Andreas Kling.
1955
1956         * Scripts/run-inspector-perf-tests.py: Removed.
1957         This script is stale, as PerformanceTests/inspector no longer exists.
1958
1959 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1960
1961         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
1962
1963         * Scripts/webkitpy/port/ios.py:
1964         (IOSSimulatorPort.default_baseline_search_path):
1965
1966 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
1967
1968         [iOS] Simplify test fallback paths for iOS Simulator testing
1969         https://bugs.webkit.org/show_bug.cgi?id=137830
1970
1971         Reviewed by Zalan Bujtas.
1972         
1973         Make the fallback paths be:
1974             ios-simulator -> generic
1975             ios-simulator-wk2->ios-simulator -> generic
1976         
1977         so don't include mac in the fallback path. Also remove the
1978         version handling for simplicity.
1979
1980         * Scripts/webkitpy/port/ios.py:
1981         (IOSSimulatorPort):
1982         (IOSSimulatorPort.default_baseline_search_path):
1983
1984 2014-10-17  Dana Burkart  <dburkart@apple.com>
1985
1986         Fix typos in the dashboard config file.
1987
1988         Unreviewed.
1989
1990         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1991         (WebKitBuildbot):
1992
1993 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
1994
1995         [Win] Allow WinLauncher to specify Custom User Agent strings
1996         https://bugs.webkit.org/show_bug.cgi?id=137828
1997
1998         Reviewed by Dean Jackson.
1999
2000         * WinLauncher/Common.cpp: Add support for custom user agent strings.
2001         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
2002         and set the user agent strings.
2003         * WinLauncher/WinLauncher.h:
2004         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
2005         resources and dialog for setting custom User Agent strings.
2006         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2007
2008 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
2009
2010         [iOS] Turn off font autosizing for iOS WebKitTestRunner
2011         https://bugs.webkit.org/show_bug.cgi?id=137806
2012
2013         Reviewed by Sam Weinig.
2014
2015         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
2016         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
2017         to disable font autosizing.
2018         
2019         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
2020         test controller to set platform-specific prefs.
2021
2022         * WebKitTestRunner/TestController.cpp:
2023         (WTR::TestController::resetPreferencesToConsistentValues):
2024         (WTR::TestController::platformResetPreferencesToConsistentValues):
2025         * WebKitTestRunner/TestController.h:
2026         * WebKitTestRunner/ios/TestControllerIOS.mm:
2027         (WTR::TestController::platformResetPreferencesToConsistentValues):
2028         * WebKitTestRunner/mac/TestControllerMac.mm:
2029         (WTR::TestController::platformResetPreferencesToConsistentValues):
2030
2031 2014-10-16  Dan Bernstein  <mitz@apple.com>
2032
2033         OSObjectPtr is missing leakRef()
2034         https://bugs.webkit.org/show_bug.cgi?id=137798
2035
2036         Reviewed by Sam Weinig.
2037
2038         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2039         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
2040
2041 2014-10-16  Lucas Forschler  <lforschler@apple.com>
2042
2043         Update target platform to remove Leopard, Snow Leopard, Lion.
2044         Add Yosemite. 
2045         
2046         Unreviewed.
2047
2048         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2049         (_should_file_trigger_build):
2050
2051 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2052
2053         commit-queue: fails to replace OO-PS! with reviewer name
2054         <http://webkit.org/b/137795>
2055
2056         Reviewed by Alexey Proskuryakov.
2057
2058         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2059         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
2060         email addresses to unauthenticated page loads, so we must always
2061         authenticate before getting bug data so we get full email
2062         addresses.
2063
2064 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2065
2066         commit-queue: fails to close bugs after successfully landing patches
2067         <http://webkit.org/b/137794>
2068
2069         Reviewed by Alexey Proskuryakov.
2070
2071         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2072         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
2073         tell Mechanize to use the second <textarea> on the page with
2074         name="comment".
2075
2076 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
2077
2078         [Win] Update DRT to match Mac Logic
2079         https://bugs.webkit.org/show_bug.cgi?id=137787
2080
2081         Reviewed by Dean Jackson.
2082
2083         * DumpRenderTree/win/DumpRenderTree.cpp:
2084         (initialize): 0 -> nullptr
2085         (runTest): Initialize MSG structure before using.
2086         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
2087         Also, cleanly shut down COM when exiting.
2088         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2089         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
2090         header and add printf to match Mac.
2091         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
2092         * DumpRenderTree/win/FrameLoadDelegate.h:
2093         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
2094         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
2095         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2096         (isLocalhost): Added.
2097         (hostIsUsedBySomeTestsToGenerateError): Added.
2098         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
2099         of certain error and redirect host names.
2100         * DumpRenderTree/win/UIDelegate.cpp:
2101         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
2102         anything should be output to the console. This modifies behavior to match the Mac.
2103         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2104         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2105         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2106         (UIDelegate::webViewAddMessageToConsole): Ditto.
2107         * WinLauncher/PageLoadTestClient.cpp:
2108         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
2109         added last week.
2110
2111 2014-10-16  Commit Queue  <commit-queue@webkit.org>
2112
2113         Unreviewed, rolling out r174754.
2114         https://bugs.webkit.org/show_bug.cgi?id=137789
2115
2116         Speculative fix for Windows test was ineffective. (Requested
2117         by rfong on #webkit).
2118
2119         Reverted changeset:
2120
2121         "[Windows] Add some more logging to debug Windows test
2122         issues."
2123         http://trac.webkit.org/changeset/174754
2124
2125 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2126
2127         Unreviewed, add myself to CoordinatedGraphics watchers.
2128
2129         * Scripts/webkitpy/common/config/watchlist:
2130
2131 2014-10-15  Roger Fong  <roger_fong@apple.com>
2132
2133         [Windows] Speculative Windows test fix.
2134
2135         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
2136
2137 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
2138
2139         import-w3c-test rewrites relative src paths in ref files incorrectly
2140         https://bugs.webkit.org/show_bug.cgi?id=137586
2141
2142         This patch fixes a bug in test_converter.py where src paths were getting 
2143         rewritten as ../../some-path instead of <script src="../../some-path>". 
2144         It also adds support for rewriting src paths in style  elements, which was 
2145         missing before and it adds tests for this case.
2146
2147         Reviewed by Bem Jones-Bey.
2148
2149         * Scripts/webkitpy/w3c/test_converter.py:
2150         (_W3CTestConverter.convert_attributes_if_needed):
2151         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2152         (test_convert_attributes_if_needed):
2153         (verify_reference_relative_paths):
2154
2155 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
2156
2157         Add --json flag to test-webkitpy to emit JSON formatted test results
2158         to stdout
2159         https://bugs.webkit.org/show_bug.cgi?id=137353
2160
2161         Reviewed by Daniel Bates.
2162
2163         * Scripts/webkitpy/port/server_process_unittest.py:
2164         Adds the read method to MockFile to allow the stdout of test_webkitpy
2165         to be redirected without causing erroneous test failures.
2166         In particular,
2167         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
2168         and
2169         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
2170         because when redirecting to a file, the
2171         _wait_for_data_and_update_buffers_using_select method in 
2172         server_process.py will find that there is a read file descriptor in
2173         its call to select.select, which eventually leads to it calling read()
2174         on the MockFile object.
2175         (MockFile.read):
2176         * Scripts/webkitpy/test/main.py:
2177         Adds the _print_results_as_json method and the --json flag which
2178         determines whether _print_results_as_json will get called.
2179         (Tester._parse_args):
2180         (Tester._print_results_as_json):
2181         (Tester._print_results_as_json.result_dict_from_tuple):
2182         (Tester._run_tests):
2183
2184 2014-10-13  David Farler  <dfarler@apple.com>
2185
2186         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2187         https://bugs.webkit.org/show_bug.cgi?id=137662
2188
2189         Reviewed by Darin Adler.
2190
2191         The layout test harness can close LayoutTestRelay's subprocess
2192         stdout and stderr in the case of a timeout or if a run is
2193         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2194         finds that no one is listening to its stdout/stderr (broken
2195         pipe), then just exit(1), there is nothing to report.
2196
2197         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2198         (-[LTRelayController didReceiveStdoutData:]):
2199         Add @try/@catch for NSFileHandleOperationException.
2200         (-[LTRelayController didReceiveStderrData:]):
2201         Add @try/@catch for NSFileHandleOperationException.
2202
2203 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
2204
2205         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2206         https://bugs.webkit.org/show_bug.cgi?id=137060
2207
2208         Reviewed by Philippe Normand.
2209
2210         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2211
2212         * MiniBrowser/gtk/BrowserWindow.c:
2213         (zoomInCallback):
2214         (zoomOutCallback):
2215         (defaultZoomCallback): Callback for default zoom keyboard support.
2216         (browser_window_init):
2217
2218 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
2219
2220         [Mac] DRT stderr logging after the test completes gets attributed to the next test
2221
2222         Reviewed by Alexey Proskuryakov.
2223         
2224         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
2225         logging to stderr to get associated with the next test.
2226         
2227         Fix by logging #EOF to stderr later, after we've completely finished with this test.
2228
2229         * DumpRenderTree/mac/DumpRenderTree.mm:
2230         (dumpTestResults):
2231         (runTest):
2232
2233 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
2234
2235         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
2236
2237         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
2238
2239 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2240
2241         [cmake] Fix the make build after r174683
2242         https://bugs.webkit.org/show_bug.cgi?id=137703
2243
2244         Reviewed by Martin Robinson.
2245
2246         * Scripts/webkitdirs.pm:
2247         (buildCMakeGeneratedProject):
2248
2249 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2250
2251         Adding myself to the watchlist to CachedFont
2252
2253         Unreviewed.
2254
2255         * Scripts/webkitpy/common/config/watchlist:
2256
2257 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2258
2259         [EFL][GTK] Make it possible to get verbose output with ninja
2260         https://bugs.webkit.org/show_bug.cgi?id=137606
2261
2262         Reviewed by Csaba Osztrogonác.
2263
2264         * Scripts/webkitdirs.pm:
2265         (buildCMakeGeneratedProject):
2266
2267 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2268
2269         [EFL] Make it possible to use ninja for EFL build too
2270         https://bugs.webkit.org/show_bug.cgi?id=137605
2271
2272         Reviewed by Csaba Osztrogonác.
2273
2274         * Scripts/webkitdirs.pm:
2275         (generateBuildSystemFromCMakeProject):
2276         * efl/install-dependencies:
2277
2278 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
2279
2280         [GTK] Minibrowser : Add home buton and keyboard support for home page load
2281         https://bugs.webkit.org/show_bug.cgi?id=137486
2282
2283         Reviewed by Philippe Normand.
2284
2285         * MiniBrowser/gtk/BrowserWindow.c:
2286         (loadHomePage): Callback for home page load.
2287         (browser_window_init):
2288         * MiniBrowser/gtk/BrowserWindow.h:
2289         * MiniBrowser/gtk/main.c:
2290         (main):
2291
2292 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
2293
2294         import-w3c-tests doesn't prefix property values
2295         https://bugs.webkit.org/show_bug.cgi?id=137600
2296
2297         Reviewed by Bem Jones-Bey.
2298
2299         Some property values are prefixed in WebKit. Modified the W3C import
2300         script in order to prefix property values and not only properties.
2301         The patch re-uses most of the already existent logic to prefix
2302         properties.
2303
2304         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
2305         from CSSValueKeywords.in and adapt converter to modify both properties
2306         and property values.
2307         (convert_for_webkit):
2308         (_W3CTestConverter.__init__):
2309         (_W3CTestConverter.output):
2310         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2311         (_W3CTestConverter):
2312         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
2313         (_W3CTestConverter.add_webkit_prefix_following_regex):
2314         (_W3CTestConverter.convert_reference_relpaths):
2315         (_W3CTestConverter.convert_style_data):
2316         (_W3CTestConverter.convert_attributes_if_needed):
2317         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
2318         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
2319         include checks for property values too.
2320         (W3CTestConverterTest.test_read_prefixed_property_list):
2321         (verify_no_conversion_happened):
2322         (verify_prefixed_properties):
2323         (verify_prefixed_property_values):
2324         (generate_test_content_properties_and_values):
2325         (generate_test_content):
2326         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
2327         prefixed property values and inform about them.
2328         (TestImporter.import_tests):
2329         (TestImporter.write_import_log):
2330
2331 2014-10-13  Jer Noble  <jer.noble@apple.com>
2332
2333         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2334         https://bugs.webkit.org/show_bug.cgi?id=137533
2335
2336         Reviewed by Andy Estes.
2337
2338         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
2339
2340         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2341         (TestWebKitAPI::isMSEEnabledCallback):
2342         (TestWebKitAPI::TEST):
2343
2344 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
2345
2346         [Win] Implement a page load profiling tool
2347         https://bugs.webkit.org/show_bug.cgi?id=137673
2348
2349         Reviewed by Dean Jackson.
2350
2351         Add a tool to capture and summarize page load statistics.
2352
2353         * WinLauncher/Common.cpp:
2354         (parseCommandLine): Move from WinMain.cpp so that it can
2355         be shared with internal tools.
2356         * WinLauncher/PageLoadTestClient.cpp: Added.
2357         (PageLoadTestClient::PageLoadTestClient):
2358         (PageLoadTestClient::pageLoadStartedAtTime):
2359         (PageLoadTestClient::didStartProvisionalLoad):
2360         (PageLoadTestClient::didCommitLoad):
2361         (PageLoadTestClient::didFirstLayoutForMainFrame):
2362         (PageLoadTestClient::didHandleOnLoadEvents):
2363         (PageLoadTestClient::didFinishLoad):
2364         (PageLoadTestClient::didFailLoad):
2365         (PageLoadTestClient::didInitiateResourceLoad):
2366         (PageLoadTestClient::didEndResourceLoad):
2367         (PageLoadTestClient::pageLoadEndedAtTime):
2368         (PageLoadTestClient::endPageLoad):
2369         (PageLoadTestClient::clearPageLoadState):
2370         (PageLoadTestClient::shouldConsiderPageLoadEnded):
2371         (PageLoadTestClient::maybeEndPageLoadSoon):
2372         (PageLoadTestClient::setPageURL):
2373         (PageLoadTestClient::dumpRunStatistics):
2374         * WinLauncher/PrintWebUIDelegate.cpp:
2375         (PrintWebUIDelegate::createWebViewWithRequest): Handle
2376         nullptr URL properly.
2377         * WinLauncher/ResourceLoadDelegate.cpp: Added.
2378         (ResourceLoadDelegate::QueryInterface):
2379         (ResourceLoadDelegate::AddRef):
2380         (ResourceLoadDelegate::Release):
2381         (ResourceLoadDelegate::identifierForInitialRequest):
2382         (ResourceLoadDelegate::willSendRequest):
2383         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2384         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
2385         (ResourceLoadDelegate::didReceiveResponse):
2386         (ResourceLoadDelegate::didReceiveContentLength):
2387         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2388         (ResourceLoadDelegate::didFailLoadingWithError):
2389         (ResourceLoadDelegate::plugInFailedWithError):
2390         * WinLauncher/ResourceLoadDelegate.h: Added.
2391         (ResourceLoadDelegate::ResourceLoadDelegate):
2392         * WinLauncher/WinLauncher.cpp:
2393         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
2394         page loading statistics.
2395         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
2396         and set private load delegate state.
2397         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
2398         that sets the view's resource load delegate.
2399         (WinLauncher::loadURL): If no URL is passed, load the test document.
2400         * WinLauncher/WinLauncher.h:
2401         (WinLauncher::pageLoadTestClient):
2402         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
2403         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
2404         * WinLauncher/WinLauncherWebHost.cpp:
2405         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
2406         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
2407         it could be used from other source files.
2408         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
2409         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
2410         (WinLauncherWebHost::didFailLoadWithError): Ditto.
2411         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
2412         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
2413         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
2414         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2415         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2416         * WinLauncher/WinLauncherWebHost.h:
2417         * WinLauncher/WinMain.cpp:
2418         (wWinMain): Create and use new delegates for gathering page load data.
2419         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
2420
2421 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2422
2423         Improve the test image diffs page
2424         https://bugs.webkit.org/show_bug.cgi?id=137674
2425
2426         Reviewed by Alexey Proskuryakov.
2427         
2428         Don't treat the input file as a format string, otherwise we have to escape special
2429         characters. Just do a couple of replaces.
2430
2431         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2432         (TestResultWriter.write_image_diff_files):
2433
2434 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2435
2436         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
2437         https://bugs.webkit.org/show_bug.cgi?id=137659
2438
2439         Reviewed by Martin Robinson.
2440
2441         * Scripts/webkitpy/port/xvfbdriver.py:
2442         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
2443
2444 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
2445
2446         Add more detailed wait time information to EWS metrics
2447         https://bugs.webkit.org/show_bug.cgi?id=137649
2448
2449         Reviewed by Daniel Bates.
2450
2451         Added average and worst time (we used to only have median), and also a percentage
2452         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
2453
2454         There is always some wait due to the polling nature of the queues, which is well understood
2455         and doesn't need to be measured. What needs to be measured is whether there is enough
2456         bot machines to process patches as soon as they are submitted.
2457
2458         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2459         (Analyzer.prototype._analyzeBubblePerformance):
2460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2461         (MetricsBubbleView.prototype._update):
2462
2463 2014-10-11  Jer Noble  <jer.noble@apple.com>
2464
2465         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2466         https://bugs.webkit.org/show_bug.cgi?id=137533
2467
2468         Reviewed by Darin Adler.
2469
2470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2471         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2472         (TestWebKitAPI::TEST):
2473         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
2474         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
2475
2476 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2477
2478         iOS DRT snapshots are limited to the page visible area
2479         https://bugs.webkit.org/show_bug.cgi?id=137650
2480
2481         Reviewed by Daniel Bates.
2482         
2483         LegacyTileCache drawing was limited to the window's visible area, found by
2484         crawling up the layer hierarchy to the root layer. This caused test snapshots to
2485         be missing non-composited content outside the iPhone visible area, which hinders
2486         testing.
2487         
2488         Fix by adding a test-only mode where the window visible area is the entire window.
2489         
2490         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2491         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
2492         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2493         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
2494         for the DRT window.
2495         
2496
2497 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
2498
2499         Page not fully rendered in iOS DRT snapshots
2500         https://bugs.webkit.org/show_bug.cgi?id=137638
2501
2502         Reviewed by Tim Horton.
2503         
2504         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
2505         to ensure that the page has laid out and is rendered by the time we take
2506         the snapshot.
2507
2508         * DumpRenderTree/mac/DumpRenderTree.mm:
2509         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
2510         (-[DumpRenderTree _webThreadInvoked]): Moved.
2511         (-[DumpRenderTree _waitForWebThreadThenDump]):
2512         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
2513         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
2514         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
2515         relies on dispatch_async too, and the inner block won't complete until the outer block
2516         has completed.
2517         (dumpTestResults): Move the guts of dump() here.
2518         (runTest): Whitespace.
2519
2520 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
2521
2522         Adding svn:ignore so that .pyc files don't show up as new.
2523
2524         * Scripts/webkitpy/xcode: Added property svn:ignore.
2525
2526 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
2527
2528         [EFL] Introduce EWebKit_Extension
2529         https://bugs.webkit.org/show_bug.cgi?id=134921
2530
2531         Reviewed by Gyuyoung Kim.
2532
2533         * MiniBrowser/efl/main.c: Added x option to test extension path.
2534         (window_create):
2535         (elm_main):
2536         * Scripts/webkitpy/common/config/watchlist:
2537         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
2538         * Scripts/webkitpy/style/checker.py:
2539         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
2540
2541 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
2542
2543         After r174628 we send the test process a SIGTERM before the SIGKILL.
2544
2545         * Scripts/webkitpy/common/system/executive_unittest.py:
2546         (ExecutiveTest.serial_test_kill_process):
2547
2548 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
2549
2550         [EFL] Enable WebP support.
2551         https://bugs.webkit.org/show_bug.cgi?id=136156
2552
2553         Reviewed by Gyuyoung Kim.
2554
2555         Include libwebp-dev package to support WebP for WK2 Efl.
2556
2557         * efl/install-dependencies:
2558
2559 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2560
2561         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
2562         https://bugs.webkit.org/show_bug.cgi?id=137485
2563
2564         Reviewed by Sergio Villar Senin.
2565
2566         Update GMainLoopSource tests. Most of the tests are now run twice,
2567         first with a GMainLoopSource and then with a
2568         GThreadSafeMainLoopSource, since both should have the same
2569         behaviour. The threading test uses GThreadSafeMainLoopSource and
2570         the delete on destroy test uses GMainLoopSource. The tests
2571         themselves haven't changed, since there's no change in behaviour.
2572
2573         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2574         (TestWebKitAPI::GMainLoopSourceTest::source):
2575         (TestWebKitAPI::basicRescheduling):
2576         (TestWebKitAPI::TEST):
2577         (TestWebKitAPI::reentrantRescheduling):
2578         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
2579         (TestWebKitAPI::basicDestroyCallbacks):
2580         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
2581         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
2582
2583 2014-10-10  Dana Burkart  <dburkart@apple.com>
2584
2585         Fix fat-fingered function name in git-add-reviewer.
2586
2587         Unreviewed.
2588
2589         * Scripts/git-add-reviewer:
2590         (getConfigValue):
2591
2592 2014-10-10  David Farler  <dfarler@apple.com>
2593
2594         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
2595         https://bugs.webkit.org/show_bug.cgi?id=137528
2596
2597         Reviewed by Simon Fraser.
2598
2599         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
2600         and SIGKILL the paired simulator app before exiting cleanly.
2601
2602         webkitpy only uses SIGKILL to kill processes which you cannot
2603         catch. Send SIGTERM to the process and give it chance to do
2604         its thing before sending SIGKILL. Sending a SIGKILL to an already
2605         dead PID is safe.
2606
2607         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2608         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2609         (-[LTRelayController finish]):
2610         * LayoutTestRelay/LayoutTestRelay/main.m:
2611         (receivedSignal):
2612         (main):
2613
2614 2014-10-10  David Farler  <dfarler@apple.com>
2615
2616         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
2617         https://bugs.webkit.org/show_bug.cgi?id=137527
2618
2619         Reviewed by Simon Fraser.
2620
2621         NSFileHandle doesn't notify of EOF in its readability handler.
2622         Use a dispatch_source_t and an event handler that is called when reading is possible.
2623         In the handler block, do a run-of-the-mill read(2) from standard input and
2624         detect EOF in the usual way by checking that zero bytes were read.
2625
2626         Once an EOF is received, the FIFOs are disconnected, the simulator app
2627         is killed, and the relay exits with status 0.
2628
2629         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2630         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
2631         (-[LTRelayController didDisconnect]):
2632         (-[LTRelayController didConnect]):
2633         (-[LTRelayController launchApp]):
2634         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
2635         confusion with this new dispatch source, called "standardInputDispatchSource".
2636         (-[LTRelayController finish]): Added.
2637         (-[LTRelayController readFileHandle:]): Deleted.
2638
2639 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
2640
2641         [EFL] Crash on facebook.com
2642         https://bugs.webkit.org/show_bug.cgi?id=137562
2643
2644         Reviewed by Chris Dumez.
2645
2646         Crash occurs on the facebook.com when the webview is resized
2647         after the <select> item is clicked but no item is chosen.
2648         This crash is just caused by the reference of invalidated variable.
2649         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
2650         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
2651         on MiniBrowser is called.
2652         As a result, just set ewk_menu to NULL in order to prevent crash condition.
2653
2654         * MiniBrowser/efl/main.c:
2655         (on_popup_menu_hide):
2656
2657 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2658
2659         A small wording change for clarity.
2660
2661         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
2662         (MetricsBubbleView.prototype._update):
2663
2664 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2665
2666         Dashboard metrics page should have EWS statistics
2667         https://bugs.webkit.org/show_bug.cgi?id=137626
2668
2669         Reviewed by Ryosuke Niwa.
2670
2671         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2672         (BubbleQueue): Put shortName in the object, so that it's actually useful.
2673
2674         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2675         (BubbleQueueServer): Re-ordered queues to match bubble order.
2676         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
2677         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
2678
2679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2680         Added analysis for bubble queues.
2681
2682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
2683
2684         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2685         (buildBubbleQueuesTable): Build the UI.
2686
2687         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
2688         Added JS sources to load.
2689
2690         * QueueStatusServer/app.yaml: To update app version.
2691
2692         * QueueStatusServer/handlers/processingtimesjson.py: Added.
2693
2694         * QueueStatusServer/main.py: Added a handler for processing-times-json.
2695
2696 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
2697
2698         REGRESSION: Commit queue doesn't process rollouts
2699         https://bugs.webkit.org/show_bug.cgi?id=137623
2700
2701         Reviewed by Tim Horton.
2702
2703         * QueueStatusServer/app.yaml:
2704         * QueueStatusServer/handlers/updateworkitems.py:
2705         (UpdateWorkItems._work_items_from_request):
2706
2707 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
2708
2709         Fix syntax error after r174601.
2710
2711         * Scripts/run-javascriptcore-tests:
2712
2713 2014-10-10  Michael Saboff  <msaboff@apple.com>
2714
2715         Add ability to select tarfile name in run-jsc-stress-tests
2716         https://bugs.webkit.org/show_bug.cgi?id=137614
2717
2718         Reviewed by Mark Hahnenberg.
2719
2720         Added optional file name argument to the --tarball option.  
2721
2722         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
2723         extra test given after the options wont be used for the optional tarball file name.
2724         * Scripts/run-jsc-stress-tests:
2725
2726 2014-10-10  Chris Dumez  <cdumez@apple.com>
2727
2728         Unreviewed, update my information in contributors.json
2729
2730         Use my preferred first name and update my expertise areas.
2731
2732         * Scripts/webkitpy/common/config/contributors.json:
2733
2734 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
2735
2736         Fix perl scripts to run with env on Linux
2737         https://bugs.webkit.org/show_bug.cgi?id=137601
2738
2739         Reviewed by Csaba Osztrogonác.
2740
2741         Use of arguments in #! is nonstandard and does not behave the same on
2742         different systems. Linux would look for an executable named "perl -w" 
2743         "use warnings;" does the same things in a more portable way.
2744
2745         * Scripts/commit-log-editor:
2746         * Scripts/num-cpus:
2747         * Scripts/prepare-ChangeLog:
2748         * Scripts/run-launcher:
2749         * Scripts/svn-create-patch:
2750
2751 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2752
2753         [jhbuild] We should be able to disable wiping on configuration change
2754         https://bugs.webkit.org/show_bug.cgi?id=137446
2755
2756         Reviewed by Csaba Osztrogonác.
2757
2758         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
2759         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
2760         or passing --no-wipe-on-change command line option.
2761
2762         * Scripts/update-webkit-libs-jhbuild:
2763
2764 2014-10-09  Andy Estes  <aestes@apple.com>
2765
2766         Teach webkitpy about OS X Yosemite
2767         https://bugs.webkit.org/show_bug.cgi?id=137585
2768
2769         Reviewed by Simon Fraser.
2770
2771         * Scripts/webkitpy/common/system/platforminfo.py:
2772         (PlatformInfo._determine_mac_version):
2773         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2774         (TestPlatformInfo.test_os_version):
2775         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2776         (TestExpectationParser):
2777         * Scripts/webkitpy/port/builders.py:
2778         * Scripts/webkitpy/port/mac.py:
2779         (MacPort):
2780         * Scripts/webkitpy/port/mac_unittest.py:
2781         (test_versions):
2782         (test_baseline_search_path):
2783         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2784         (TestRebaselineTest.test_baseline_directory):
2785         (TestRebaselineExpectations.test_rebaseline_expectations):
2786
2787 2014-10-09  Dana Burkart  <dburkart@apple.com>
2788
2789         Add Mac OS Yosemite dashboard support.
2790
2791         Rubber-stamped by Lucas Forschler.
2792
2793         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
2794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
2795         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2796         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2798
2799 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
2800
2801         Add Babak to contributors.json and add historical email addresses for some contributors
2802         https://bugs.webkit.org/show_bug.cgi?id=137546
2803
2804         Reviewed by Christophe Dumez.
2805
2806         contributors.json is used to analyze historical commit data and change logs.
2807
2808         Add back historical email addresses for some contributors and also add Babak (Shafiei).
2809
2810         * Scripts/webkitpy/common/config/contributors.json:
2811
2812 2014-10-09  Lucas Forschler  <lforschler@apple.com>
2813
2814         Add Mac OS Yosemite webkit build infrastructure.
2815         
2816         This patch adds 15 bots to our build.webkit.org configuration.
2817         We are matching the current Mavericks machines 1:1.
2818         
2819         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
2820         
2821         Reviewed by Matt Hanson.
2822
2823         * BuildSlaveSupport/build.webkit.org-config/config.json:
2824
2825 2014-10-09  Dana Burkart  <dburkart@apple.com>
2826
2827         Don't use backticks when running commands, as we run into sh-related
2828         interpolation issues. Also, fix our usage of system() to properly
2829         retrieve the status code.
2830         https://bugs.webkit.org/show_bug.cgi?id=137541
2831
2832         Reviewed by Darin Adler.
2833
2834         * Scripts/git-add-reviewer:
2835         (interactive):
2836         (nonInteractive):
2837         (requireCleanWorkTree):
2838         (cherryPick):
2839         (commit):
2840         (addReviewerToFile):
2841         (head):
2842         (isAncestor):
2843         (toCommit):
2844         (changeLogsForCommit):
2845         (resetToCommit):
2846         (getConfigValue):
2847         (runCommandWithOutput):
2848
2849 2014-10-09  Tim Horton  <timothy_horton@apple.com>
2850
2851         Add a WebKit1 preference for selection services
2852         https://bugs.webkit.org/show_bug.cgi?id=137498
2853         <rdar://problem/18572699>
2854
2855         Reviewed by Simon Fraser.
2856
2857         * MiniBrowser/mac/WK1BrowserWindowController.m:
2858         (-[WK1BrowserWindowController awakeFromNib]):
2859         Turn on image and selection services in the Legacy WebKit MiniBrowser.
2860
2861 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
2862
2863         Get the patch scripts running on Haiku
2864         https://bugs.webkit.org/show_bug.cgi?id=137559
2865
2866         Reviewed by Benjamin Poulain.
2867
2868         Use /usr/bin/env instead of hardcoding path to perl.
2869         Declare haiku platform in platforminfo.py to avoid check-webkit-style
2870         failure.
2871
2872         * Scripts/commit-log-editor:
2873         * Scripts/num-cpus:
2874         * Scripts/prepare-ChangeLog:
2875         * Scripts/run-launcher:
2876         * Scripts/svn-create-patch:
2877         * Scripts/webkitpy/common/system/platforminfo.py:
2878         (PlatformInfo._determine_os_name):
2879
2880 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
2881
2882         StyleQueue should throw a PatchIsNotValid exception to achieve
2883         consistency with CommitQueue and EWS
2884         https://bugs.webkit.org/show_bug.cgi?id=137500
2885
2886         Reviewed by Alexey Proskuryakov.
2887
2888         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2889         Adds a call to validate() in run().
2890         (StyleQueueTask.run):
2891         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2892         Adds a return False in the patch is not valid exception statement.
2893         (AbstractEarlyWarningSystem.review_patch):
2894         * Scripts/webkitpy/tool/commands/queues.py:
2895         Adds a return False in the patch is not valid exception statement in
2896         commit queue, and adds an except statement to catch PatchIsNotValid
2897         exceptions in style queue.
2898         (CommitQueue.process_work_item):
2899         (StyleQueue.review_patch):
2900
2901 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2902
2903         Race condition with WebKitWebView:is-loading after starting page load
2904         https://bugs.webkit.org/show_bug.cgi?id=136692
2905
2906         Reviewed by Gustavo Noronha Silva.
2907
2908         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2909         (loadChangedCallback): Only check is-loading is false when load
2910         has finished if the load didn't fail due to a cancellation.
2911         (loadFailedCallback): Only check is-loading is false if the load
2912         didn't fail due to a cancellation.
2913         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2914         (WebViewTest::loadURI): Check is-loading is true and active URI is
2915         the requested one rigth after requesting the load.
2916         (WebViewTest::loadHtml): Ditto.
2917         (WebViewTest::loadPlainText): Ditto.
2918         (WebViewTest::loadBytes): Ditto.
2919         (WebViewTest::loadRequest): Ditto.
2920         (WebViewTest::loadAlternateHTML): Ditto.
2921         (WebViewTest::goBack): Ditto.
2922         (WebViewTest::goForward): Ditto.
2923         (WebViewTest::goToBackForwardListItem): Ditto.
2924
2925 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
2926
2927         [Win] Resolve various static analyzer warnings in Tools.
2928         https://bugs.webkit.org/show_bug.cgi?id=137534
2929
2930         Reviewed by Dean Jackson.
2931
2932         * DumpRenderTree/cg/ImageDiffCG.cpp:
2933         (main): User proper printf specifiers.
2934         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2935         (AccessibilityUIElement::childrenCount): Handle possibility that
2936         gcc_accChildCount returns with an error.
2937         (accessibilityState): Ditto for gcc_accState.
2938         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2939         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
2940         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
2941         be treated as such.
2942         * DumpRenderTree/win/DumpRenderTree.cpp:
2943         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
2944         by comparing an unsigned value as being greater-than zero.
2945         * DumpRenderTree/win/EditingDelegate.cpp:
2946         (dump): Pass proper character pointer type to printf.
2947         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
2948         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
2949         (EditingDelegate::shouldInsertNode): Ditto.
2950         (EditingDelegate::shouldInsertText): Ditto.
2951         (EditingDelegate::shouldDeleteDOMRange): Ditto.
2952         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
2953         (EditingDelegate::shouldApplyStyle): Ditto.
2954         * DumpRenderTree/win/EventSender.cpp:
2955         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
2956         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
2957         system headers.
2958         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
2959         from CreateDIBSection.
2960         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
2961         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
2962         older versions of MSVC we no longer support.
2963         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
2964         for 64-bit builds.
2965         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
2966         * TestWebKitAPI/TestsController.h: Ditto.
2967         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
2968         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
2969         performing bitwise | before the comparison is done.
2970
2971 2014-10-08  Ada Chan  <adachan@apple.com>
2972
2973         Add a test for WKPageIsPlayingAudio().
2974         https://bugs.webkit.org/show_bug.cgi?id=137048
2975
2976         Reviewed by Darin Adler.
2977
2978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2979         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
2980         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
2981         (TestWebKitAPI::nullJavaScriptCallback):
2982         (TestWebKitAPI::didFinishLoadForFrame):
2983         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
2984         (TestWebKitAPI::setUpClients):
2985         (TestWebKitAPI::TEST):
2986         This test loads a page with a video in it. When the page is loaded, we first check that
2987         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
2988         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
2989         now returns true for the page.
2990         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
2991         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
2992         This is a video copied from LayoutTests/media/content.
2993
2994 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
2995
2996         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
2997         https://bugs.webkit.org/show_bug.cgi?id=137516
2998
2999         Reviewed by Alexey Proskuryakov.
3000
3001         * Scripts/webkitpy/thirdparty/__init__.py:
3002         (AutoinstallImportHook._install_irc):
3003
3004 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3005
3006         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
3007         https://bugs.webkit.org/show_bug.cgi?id=137520
3008
3009         Reviewed by Philippe Normand.
3010
3011         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
3012         For other distributions, we are already installing libjpeg-turbo.
3013         So, do the same for Debian and derivatives.
3014
3015         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
3016
3017 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3018
3019         [webkitpy] Add back the workaround to replace ZipFile.extractall()
3020         https://bugs.webkit.org/show_bug.cgi?id=137519
3021
3022         Reviewed by Csaba Osztrogonác.
3023
3024         It was removed by <http://trac.webkit.org/changeset/174266>,
3025         because the comment stated it is a workaround for buggy python
3026         2.6.1 which shipped on Snow Leopard. But it turned out the bug
3027         is still valid with python 2.7 shipped on the latest Ubuntu
3028         (12.04 and 14.04) and OS X 10.9.
3029
3030         * Scripts/webkitpy/common/system/autoinstall.py:
3031         (AutoInstaller):
3032         (AutoInstaller._extract_all):
3033         (AutoInstaller._unzip):
3034
3035 2014-10-08  Commit Queue  <commit-queue@webkit.org>
3036
3037         Unreviewed, rolling out r174335.
3038         https://bugs.webkit.org/show_bug.cgi?id=137515
3039
3040         It broke EFL layout test totally (Requested by gyuyoung on
3041         #webkit).
3042
3043         Reverted changeset:
3044
3045         "[EFL] Introduce EWebKit_Extension"
3046         https://bugs.webkit.org/show_bug.cgi?id=134921
3047         http://trac.webkit.org/changeset/174335
3048
3049 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3050
3051         [GTK] Make forwarding headers generation depend on source code
3052         https://bugs.webkit.org/show_bug.cgi?id=137394
3053
3054         Reviewed by Philippe Normand.
3055
3056         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
3057         * TestWebKitAPI/PlatformGTK.cmake: Only run
3058         generate-forwarding-headers.pl when source code changes.
3059         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3060
3061 2014-10-07  Tanay C  <tanay.c@samsung.com>
3062
3063         Remove build warnings in Hashmap API tests
3064         https://bugs.webkit.org/show_bug.cgi?id=137484
3065
3066         Reviewed by Darin Adler.
3067
3068         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3069         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
3070
3071 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
3072
3073         Commit queue doesn't drop obsolete patches sometimes
3074         https://bugs.webkit.org/show_bug.cgi?id=137460
3075
3076         Reviewed by Alexey Proskuryakov.
3077
3078         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3079         Adds another test patch for use in queues_unittest.py.
3080         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3081         (MockBugzilla):
3082         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3083         Raises a PatchIsNotValid exception in the case of validate() returning
3084         false.
3085         (CommitQueueTask.run):
3086         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3087         Raises a PatchIsNotValid exception in the case of validate() returning
3088         false.
3089         (EarlyWarningSystemTask.run):
3090         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3091         Defines PatchIsNotValid exception. 
3092         (PatchIsNotValid):
3093         (PatchIsNotValid.__init__):
3094         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3095         Remove call to validate() and instead catches the PatchIsNotValid
3096         exception.
3097         (AbstractEarlyWarningSystem.review_patch):
3098         * Scripts/webkitpy/tool/commands/queues.py:
3099         Adds logic to catch the PatchIsNotValid exception.
3100         (CommitQueue.process_work_item):
3101         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3102         Adds the test_non_valid_patch test to ensure that invalid patches are
3103         handled properly, and don't just result in indefinite spinning.
3104         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3105         (test_non_valid_patch):
3106
3107 2014-10-07  Daniel Bates  <dabates@apple.com>
3108
3109         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
3110         https://bugs.webkit.org/show_bug.cgi?id=137499
3111
3112         Reviewed by Simon Fraser.
3113
3114         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
3115         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
3116         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
3117         bit simulator builds of iOS WebKit.
3118
3119         * Scripts/webkitpy/port/ios.py:
3120         (IOSSimulatorPort._generate_all_test_configurations):
3121
3122 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3123
3124         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
3125         https://bugs.webkit.org/show_bug.cgi?id=137482
3126
3127         Reviewed by Martin Robinson.
3128
3129         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
3130
3131 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3132
3133         [SOUP] TLS errors should take precedence over HTTP authentication
3134         https://bugs.webkit.org/show_bug.cgi?id=137300
3135
3136         Reviewed by Sergio Villar Senin.
3137
3138         Add a test case to check that authenticate signal is not emitted
3139         in case of TLS errors, and the load fails instead.
3140
3141         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3142         (webViewAuthenticationCallback):
3143         (testTLSErrorsHTTPAuth):
3144         (httpsServerCallback):
3145         (beforeAll):
3146
3147 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
3148
3149         Make webkit-patch find-users useful
3150         https://bugs.webkit.org/show_bug.cgi?id=137475
3151
3152         Reviewed by Alexey Proskuryakov.
3153
3154         Make find-users use the CommitterList instead of accessing Bugzilla.
3155
3156         This essentially exposes the same functionality as webkitbot's whois command.
3157
3158         * Scripts/webkitpy/tool/commands/findusers.py:
3159         (FindUsers.execute):
3160
3161 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
3162
3163         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
3164         https://bugs.webkit.org/show_bug.cgi?id=137289
3165
3166         Unreviewed build fix.
3167
3168         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3169         (AccessibilityUIElement::getChildrenWithRange):
3170
3171 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3172
3173         build.webkit.org/dashboard: Add commit queue
3174         https://bugs.webkit.org/show_bug.cgi?id=137462
3175
3176         Reviewed by Tim Horton.
3177
3178         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
3179         Style queue is still invisible, as it doesn't have an associated platform, and also
3180         we never have problems with it anyway, so it's not worth watching.
3181
3182         The UI now allows for adding more bots to the Other column (such as leaks bot).
3183         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
3184         sources of data in a cell.
3185
3186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
3187         (BubbleQueue):
3188         (BubbleQueue.prototype.get statusPageURL):
3189         (BubbleQueue.prototype.update):
3190         (BubbleQueue.prototype.loadDetailedStatus):
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
3192         (BubbleQueueServer):
3193         (BubbleQueueServer.prototype.jsonQueueLengthURL):
3194         (BubbleQueueServer.prototype.jsonQueueStatusURL):
3195         (BubbleQueueServer.prototype.queueStatusURL):
3196         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
3197         (BubbleQueueView):
3198         (BubbleQueueView.prototype.update.appendQueue):
3199         (BubbleQueueView.prototype.update):
3200         (BubbleQueueView.prototype._addQueueHeadingToPopover):
3201         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
3202         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
3203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
3204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
3205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
3206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3209         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
3210         (.bubble-server-popover .latest-status-no-link):
3211         (.bubble-server-popover .bot-status-description):
3212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3213
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3215         (buildAggregateTable):
3216         (buildQueuesTable):
3217         Removed dysfunctional support for EWS for now. It will be different.
3218
3219 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3220
3221         One more case of incorrect comparison in recordpatchevent.py
3222         https://bugs.webkit.org/show_bug.cgi?id=137459
3223
3224         Reviewed by Tim Horton.
3225
3226         * QueueStatusServer/app.yaml:
3227         * QueueStatusServer/loggers/recordpatchevent.py:
3228         (RecordPatchEvent.started):
3229
3230 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3231
3232         webkit-queues PatchLog is incorrect for patches that took less than a second
3233         https://bugs.webkit.org/show_bug.cgi?id=137453
3234
3235         Reviewed by Tim Horton.
3236
3237         * QueueStatusServer/app.yaml: Updated app version.
3238
3239         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
3240         Don't bail out for patches that took 0 seconds to process (as frequently happens
3241         when a patch is obsolete).
3242
3243 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
3244
3245         EWS bubble hover shows wrong timestamps
3246         https://bugs.webkit.org/show_bug.cgi?id=137252
3247
3248         Reviewed by Alexey Proskuryakov.
3249
3250         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
3251
3252         * QueueStatusServer/handlers/queuestatusjson.py:
3253         (QueueStatusJSON.get):
3254         * QueueStatusServer/handlers/statusbubble.py:
3255         (StatusBubble._iso_time):
3256
3257 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
3258
3259         Unreviewed, updated list of email addresses in contributors.json
3260
3261         * Scripts/webkitpy/common/config/contributors.json: Added my former
3262         email address in Igalia, for the sake of completeness.
3263
3264 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3265
3266         Unreviewed, moved myself to the list of committers.
3267
3268         * Scripts/webkitpy/common/config/contributors.json:
3269
3270 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
3271
3272         [EFL] Introduce EWebKit_Extension
3273         https://bugs.webkit.org/show_bug.cgi?id=134921
3274
3275         Reviewed by Gyuyoung Kim.
3276
3277         * MiniBrowser/efl/main.c: Added x option to test extension path.
3278         (window_create):
3279         (elm_main):
3280         * Scripts/webkitpy/common/config/watchlist:
3281         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3282         * Scripts/webkitpy/style/checker.py:
3283         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3284
3285 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
3286
3287         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
3288         https://bugs.webkit.org/show_bug.cgi?id=137390
3289
3290         Reviewed by Carlos Garcia Campos.
3291
3292         * Scripts/update-webkit-libs-jhbuild:
3293
3294 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3295
3296         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
3297         https://bugs.webkit.org/show_bug.cgi?id=137391
3298
3299         Reviewed by Martin Robinson.
3300
3301         Add a custom command to only re-generate
3302         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
3303
3304         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3305
3306 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3307
3308         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
3309         https://bugs.webkit.org/show_bug.cgi?id=135502
3310
3311         Reviewed by Martin Robinson.
3312
3313         When writing to stdout/stderr fails due to a UnicodeDecodeError
3314         exception, try again without encoding the output.
3315
3316         * gtk/gtkdoc.py:
3317         (GTKDoc._run_command):
3318
3319 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3320
3321         Bugzilla status bubble displays an exception showing attachment 175738
3322         https://bugs.webkit.org/show_bug.cgi?id=137410
3323
3324         Reviewed by Tim Horton.
3325
3326         * QueueStatusServer/app.yaml: Update version.
3327
3328         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
3329         Don't fail even if expected status message is missing.
3330
3331         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
3332         the field in the same way it's defined in QueueStatus table.
3333
3334 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3335
3336         Record latest message in PatchLog for quick access
3337         https://bugs.webkit.org/show_bug.cgi?id=137405
3338
3339         Fixing a typo.
3340
3341         * QueueStatusServer/app.yaml:
3342         * QueueStatusServer/handlers/releasepatch.py:
3343
3344 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
3345
3346         Record latest message in PatchLog for quick access
3347         https://bugs.webkit.org/show_bug.cgi?id=137405
3348
3349         Reviewed by Ryosuke Niwa.
3350
3351         It's no SQL...
3352
3353         * QueueStatusServer/handlers/releasepatch.py:
3354         * QueueStatusServer/handlers/updatestatus.py:
3355         * QueueStatusServer/loggers/recordpatchevent.py:
3356         * QueueStatusServer/model/patchlog.py:
3357
3358 2014-10-02  David Farler  <dfarler@apple.com>
3359
3360         -asan-blacklist option also renamed to generic -fsanitize-blacklist
3361         https://bugs.webkit.org/show_bug.cgi?id=137377
3362
3363         Reviewed by Daniel Bates.
3364
3365         * asan/asan.xcconfig:
3366         -asan-blacklist -> -fsanitize-blacklist
3367
3368         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3369
3370 2014-10-03  Roger Fong  <roger_fong@apple.com>
3371
3372         [Windows] Include batch size argument to layout tests on Windows.
3373
3374         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3375         (RunWebKitTests.start): 
3376         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
3377         These crashes seem to happen on random tests though generally in a spread out fashion.
3378         It seems possible that the DRT instance is being clobbered somehow after running too many
3379         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
3380
3381 2014-10-03  Roger Fong  <roger_fong@apple.com>
3382
3383         [Windows] Settle for 2 chid processes running NRWT on Windows.
3384
3385         * Scripts/webkitpy/port/win.py:
3386         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
3387
3388 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
3389
3390         [GTK] Bump up and patch dependencies to allow building for aarch64
3391         https://bugs.webkit.org/show_bug.cgi?id=137147
3392
3393         Reviewed by Martin Robinson.
3394
3395         The currently used versions of pixman, libffi, librsvg, glib,
3396         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
3397         and/or build for aarch64, so they are bumped up and patched where
3398         necessary. Wherever possible, the same versions and patches were used as
3399         for the EFL port bump-up
3400         (https://bugs.webkit.org/show_bug.cgi?id=135885).
3401
3402         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
3403         regression by crashing http/tests/media/video-redirect.html . A patch
3404         already in upstream fixes that bug.
3405
3406         This change does not touch xserver, which also needs bumping up, but 
3407         will be dealt with later.
3408
3409         * gtk/jhbuild.modules:
3410         Specified versions and patches necessary to correctly build for aarch64.
3411         * gtk/patches/gst-events-arent-gstobjects.patch:
3412         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
3413         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
3414         Added. Patches gst-plugins-base to configure correctly for aarch64.
3415         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
3416         Added. Bumps up config.guess and config.sub in librsvg to recognize
3417         aarch64.
3418         * gtk/patches/libxml2-2.9.0-dtd.patch:
3419         Removed. Not necessary for libxml2 v2.9.1 anymore.
3420
3421 2014-09-28  Sam Weinig  <sam@webkit.org>
3422
3423         Remove RefPtrHashMap
3424         https://bugs.webkit.org/show_bug.cgi?id=137200
3425
3426         Reviewed by Darin Adler.
3427
3428         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3429         (TestWebKitAPI::TEST):
3430         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
3431         a minimum of refcount churn occurs.
3432
3433 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3434
3435         Remove workarounds for versions of Python before 2.7
3436         https://bugs.webkit.org/show_bug.cgi?id=137338
3437
3438         Reviewed by Csaba Osztrogonác.
3439
3440         * Scripts/webkitpy/common/system/autoinstall.py:
3441         (AutoInstaller._extract_targz):
3442         (AutoInstaller._unzip):
3443         (AutoInstaller): Deleted.
3444         (AutoInstaller._extract_all): Deleted.
3445         * Scripts/webkitpy/common/webkitunittest.py:
3446         (TestCase.setUp): Deleted.
3447         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3448         (TestConfigurationConverter.collapse_macros):
3449         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3450         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3451         (TestConfigurationConverter):
3452         (TestConfigurationConverter.combinations): Deleted.
3453         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3454         * Scripts/webkitpy/port/base.py:
3455
3456 2014-10-03  Commit Queue  <commit-queue@webkit.org>
3457
3458         Unreviewed, rolling out r174264.
3459         https://bugs.webkit.org/show_bug.cgi?id=137392
3460
3461         It broke run-webkit-tests (Requested by ebalazsfalvi on
3462         #webkit).
3463
3464         Reverted changeset:
3465
3466         "Remove workarounds for versions of Python before 2.7"
3467         https://bugs.webkit.org/show_bug.cgi?id=137338
3468         http://trac.webkit.org/changeset/174264
3469
3470 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3471
3472         Remove workarounds for versions of Python before 2.7
3473         https://bugs.webkit.org/show_bug.cgi?id=137338
3474
3475         Reviewed by Csaba Osztrogonác.
3476
3477         * Scripts/webkitpy/common/system/autoinstall.py:
3478         (AutoInstaller._extract_targz):
3479         (AutoInstaller._unzip):
3480         (AutoInstaller): Deleted.
3481         (AutoInstaller._extract_all): Deleted.
3482         * Scripts/webkitpy/common/webkitunittest.py:
3483         (TestCase.setUp): Deleted.
3484         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3485         (TestConfigurationConverter.collapse_macros):
3486         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
3487         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
3488         (TestConfigurationConverter):
3489         (TestConfigurationConverter.combinations): Deleted.
3490         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3491         * Scripts/webkitpy/port/base.py:
3492         * Scripts/webkitpy/port/driver.py:
3493         (ContentBlock.__init__):
3494         * Scripts/webkitpy/port/server_process.py:
3495         (ServerProcess._reset):
3496
3497 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3498
3499         Remove autoinstaller workaround for python 2.6
3500         https://bugs.webkit.org/show_bug.cgi?id=137343
3501
3502         Reviewed by Daniel Bates.
3503
3504         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
3505         2.6, nor Snow Leopard is supported anymore, so the workaround is not
3506         needed anymore.
3507
3508         * Scripts/webkitpy/common/system/autoinstall.py:
3509         (AutoInstaller.install):
3510         * Scripts/webkitpy/test/main.py:
3511         (Tester._run_tests):
3512         * Scripts/webkitpy/thirdparty/__init__.py:
3513         (AutoinstallImportHook._install_mechanize):
3514         (AutoinstallImportHook._install_pep8):
3515         (AutoinstallImportHook._install_pylint):
3516         (AutoinstallImportHook._install_buildbot):
3517         (AutoinstallImportHook._install_coverage):
3518         (AutoinstallImportHook._install_eliza):
3519         (AutoinstallImportHook._install_irc):
3520         (AutoinstallImportHook._install):
3521         (autoinstall_everything):
3522
3523 2014-10-02  Daniel Bates  <dabates@apple.com>
3524
3525         Use version number 101000 instead of 10100 for OS X Yosemite
3526         https://bugs.webkit.org/show_bug.cgi?id=137372
3527
3528         Reviewed by Mark Rowe.
3529
3530         The version number for OS X Yosemite is 101000.
3531
3532         * DumpRenderTree/mac/TextInputController.m:
3533
3534 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
3535
3536         update-work-items should never delete items
3537         https://bugs.webkit.org/show_bug.cgi?id=137366
3538
3539         Reviewed by Ryosuke Niwa.
3540
3541         As we don't just replace the whole list any more, indicate which items are high
3542         priority, and which are not. Hight priority ones will be prepended to the queue,
3543         others will be appended.
3544
3545         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
3546         But hopefully we will never have many rollouts competing like that.
3547
3548         * QueueStatusServer/app.yaml: Update version.
3549
3550         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
3551         priority and regular items separately. Removed some error handling that used to
3552         end up in returning status 500 - an uncaught exception does that automatically.
3553
3554         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
3555
3556         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
3557
3558         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
3559         priority items.
3560
3561         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3562         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
3563         line that complicated testing.
3564
3565         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
3566
3567         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
3568         priority items into separate lists.
3569
3570         * Scripts/webkitpy/common/net/statusserver_mock.py:
3571         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3572         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3573         Updated tests.
3574
3575 2014-10-02  Brendan Long  <b.long@cablelabs.com>
3576
3577         Annoying build warnings in WTFString API tests
3578         https://bugs.webkit.org/show_bug.cgi?id=137360
3579
3580         Reviewed by Darin Adler.
3581
3582         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3583         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
3584
3585 2014-10-02  Roger Fong  <roger_fong@apple.com>
3586
3587         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
3588
3589         * Scripts/webkitpy/port/win.py:
3590         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
3591
3592 2014-10-02  David Farler  <dfarler@apple.com>
3593
3594         Move ASan arguments from LLVM (-mllvm) to the frontend
3595         https://bugs.webkit.org/show_bug.cgi?id=137365
3596
3597         Reviewed by David Kilzer.
3598
3599         * asan/asan.xcconfig:
3600         Remove the -mllvm prefix to the asan-blacklist argument, moving it
3601         to the clang frontend.
3602
3603         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
3604
3605 2014-10-02  Commit Queue  <commit-queue@webkit.org>
3606
3607         Unreviewed, rolling out r174120.
3608         https://bugs.webkit.org/show_bug.cgi?id=137350
3609
3610         While number of failures is reasonable with 2 processes, test
3611         results seem to be inconsistent between runs (Requested by
3612         rfong on #webkit).
3613
3614         Reverted changeset:
3615
3616         "[Windows] Back to 2 child processes for NRWT on Windows."
3617         http://trac.webkit.org/changeset/174120
3618
3619 2014-10-02  Jeff Miller  <jeffm@apple.com>
3620
3621         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
3622         https://bugs.webkit.org/show_bug.cgi?id=137347
3623
3624         Reviewed by Dan Bernstein.
3625
3626         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3627         Use WebKitSystemInterfaceYosemite on OS X 10.10.
3628
3629         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3630         Ditto.
3631
3632 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3633
3634         [GTK] [JHBuild] Switch sourceware.org mirror to http.
3635
3636         Unreviewed.
3637
3638         The ftp access is recently failing to work as expected, and the
3639         bots fail to download the file.
3640         The same mirror is available via http and seems to work better.
3641
3642         * gtk/jhbuild.modules:
3643
3644 2014-10-01  Commit Queue  <commit-queue@webkit.org>
3645
3646         Unreviewed, rolling out r174185.
3647         https://bugs.webkit.org/show_bug.cgi?id=137334
3648
3649         Patch that adds logging causes webkitpy failures (Requested by
3650         rfong on #webkit).
3651
3652         Reverted changeset:
3653
3654         "commitqueuetasks_unittest references a non-existent member
3655         variable"
3656         https://bugs.webkit.org/show_bug.cgi?id=137303
3657         http://trac.webkit.org/changeset/174185
3658
3659 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3660
3661         EWS and Commit Queue should know better than to spew 500 failed
3662         results in the case of extremely red patches.
3663         https://bugs.webkit.org/show_bug.cgi?id=137324
3664
3665         Reviewed by Alexey Proskuryakov.
3666
3667         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3668         Adds a check for did_exceed_test_failure_limit.
3669         (AbstractEarlyWarningSystem._failing_tests_message):
3670         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3671         Alters the task mock to respond properly to
3672         results_from_patch_test_run(patch)
3673         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3674         * Scripts/webkitpy/tool/commands/queues.py:
3675         Adds a check for did_exceed_test_failure_limit.
3676         (CommitQueue._failing_tests_message):
3677
3678 2014-10-01  Daniel Bates  <dabates@apple.com>
3679
3680         Unreviewed, rolling out r174192.
3681
3682         Revert the unit test fix in r174192 since we reverted r174187
3683         in r174194 due to correctness issues. See
3684         <http://webkit.org/b/137329> for more details.
3685
3686         Reverted changeset:
3687
3688         "Test fix after r174187"
3689         http://trac.webkit.org/changeset/174192
3690
3691 2014-10-01  Mark Rowe  <mrowe@apple.com>
3692
3693         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
3694
3695         Reviewed by Dan Bernstein.
3696
3697         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
3698         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
3699         for the LLVM components when on Yosemite.
3700
3701 2014-10-01  Commit Queue  <commit-queue@webkit.org>
3702
3703         Unreviewed, rolling out r174187.
3704         https://bugs.webkit.org/show_bug.cgi?id=137329
3705
3706         webkitpy failures, and thorton says the patch is wrong
3707         (Requested by dethbakin on #webkit).
3708
3709         Reverted changeset:
3710
3711         "[Windows] Increase layout test timeout for Windows following
3712         r174162."
3713         http://trac.webkit.org/changeset/174187
3714
3715 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
3716
3717         Test fix after r174187
3718
3719         * Scripts/webkitpy/port/win_unittest.py:
3720         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
3721
3722 2014-10-01  Roger Fong  <roger_fong@apple.com>
3723
3724         [Windows] Increase layout test timeout for Windows following r174162.
3725
3726         * Scripts/webkitpy/port/win.py:
3727         (WinPort.default_timeout_ms):
3728
3729 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3730
3731         commitqueuetasks_unittest references a non-existent member variable
3732         when mock-reporting flaky tests.
3733         https://bugs.webkit.org/show_bug.cgi?id=137303
3734
3735         Reviewed by Daniel Bates.
3736
3737         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3738         (MockCommitQueue.report_flaky_tests):
3739         Makes the appropriate name change.
3740         (test_simple_flaky_test_failure):
3741         Adds a unit test to make sure that the code is excercised.
3742
3743 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3744
3745         EWS is inconclusively spinning forever on a patch that breaks 500+
3746         tests
3747         https://bugs.webkit.org/show_bug.cgi?id=137223
3748
3749         Reviewed by Tim Horton.
3750
3751         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3752         Checks to see whether the tests have exceeded the failure limit, and
3753         only spins off another test if they have not exceeded the limit.
3754         (PatchAnalysisTask._test_patch):
3755
3756 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
3757
3758         Unreviewed, add Katie Madonna as a contributor.
3759
3760         * Scripts/webkitpy/common/config/contributors.json:
3761
3762 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
3763
3764         commitqueuetasks_unittest does not construct FailingTestCommitQueue
3765         objects properly in its test cases.
3766         https://bugs.webkit.org/show_bug.cgi?id=137281
3767
3768         Reviewed by Daniel Bates.
3769
3770         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3771         (FailingTestCommitQueue.test_results):
3772         Adds an assert to make FailingTestCommitQueue harder to mis-use.
3773         (test_double_flaky_test_failure):
3774         Nests the intended test failure strings into one-length lists.
3775         (test_red_test_failure):
3776         Nests the intended test failure strings into one-length lists.
3777
3778 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
3779
3780         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
3781         https://bugs.webkit.org/show_bug.cgi?id=136987
3782
3783         Reviewed by Daniel Bates.
3784
3785         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
3786         Specify the default encoding for all WebKit developers to get consistent results.
3787
3788 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
3789
3790         EWS is too eager to say that a patch does not apply to trunk of repository
3791         https://bugs.webkit.org/show_bug.cgi?id=137290
3792
3793         Reviewed by Ryosuke Niwa.
3794
3795         * QueueStatusServer/app.yaml: Updated app version.
3796
3797         * QueueStatusServer/handlers/statusbubble.py:
3798         (StatusBubble._build_bubble):
3799         (StatusBubble._build_bubbles_for_attachment):
3800         Rewrote to make more sense.
3801
3802 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3803
3804         Remove thirdparty/unittest2 from webkitpy
3805         https://bugs.webkit.org/show_bug.cgi?id=137251
3806
3807         Reviewed by Brent Fulgham.
3808
3809         Additionally ordered imports in related webkitpy files and
3810         removed unnecessary shebangs from unittest files.
3811
3812         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
3813         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3814         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3815         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3816         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3817         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3818         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3819         * Scripts/webkitpy/common/config/committers_unittest.py:
3820         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3821         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
3822         * Scripts/webkitpy/common/config/ports_unittest.py:
3823         * Scripts/webkitpy/common/config/urls_unittest.py:
3824         * Scripts/webkitpy/common/editdistance_unittest.py:
3825         * Scripts/webkitpy/common/find_files_unittest.py:
3826         * Scripts/webkitpy/common/lru_cache_unittest.py:
3827         * Scripts/webkitpy/common/memoized_unittest.py:
3828         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
3829         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3830         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3831         * Scripts/webkitpy/common/net/credentials_unittest.py:
3832         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3833         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3834         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3835         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3836         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
3837         * Scripts/webkitpy/common/net/statusserver_unittest.py:
3838         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
3839         * Scripts/webkitpy/common/newstringio_unittest.py:
3840         * Scripts/webkitpy/common/prettypatch_unittest.py:
3841         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
3842         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3843         * Scripts/webkitpy/common/system/environment_unittest.py:
3844         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
3845         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
3846         * Scripts/webkitpy/common/system/executive_unittest.py:
3847         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
3848         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3849         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3850         * Scripts/webkitpy/common/system/logtesting.py:
3851         * Scripts/webkitpy/common/system/logutils_unittest.py:
3852         * Scripts/webkitpy/common/system/outputcapture.py:
3853         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
3854         * Scripts/webkitpy/common/system/outputtee_unittest.py:
3855         * Scripts/webkitpy/common/system/path_unittest.py:
3856         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3857         * Scripts/webkitpy/common/system/profiler_unittest.py:
3858         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
3859         * Scripts/webkitpy/common/system/user_unittest.py:
3860         * Scripts/webkitpy/common/system/workspace_unittest.py:
3861         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
3862         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
3863         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3864         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
3865         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
3866         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
3867         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
3868         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
3869         * Scripts/webkitpy/common/webkitunittest.py:
3870         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3871         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3872         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3873         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3874         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3875         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3876         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3877         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
3878         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
3879         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3880         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3881         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3882         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
3883         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3884         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3885         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
3886         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3887         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3888         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3889         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3890         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3891         * Scripts/webkitpy/port/base_unittest.py:
3892         * Scripts/webkitpy/port/builders_unittest.py:
3893         * Scripts/webkitpy/port/config_unittest.py:
3894         * Scripts/webkitpy/port/driver_unittest.py:
3895         * Scripts/webkitpy/port/efl_unittest.py:
3896         * Scripts/webkitpy/port/factory_unittest.py:
3897         * Scripts/webkitpy/port/gtk_unittest.py:
3898         * Scripts/webkitpy/port/http_lock_unittest.py:
3899         * Scripts/webkitpy/port/image_diff_unittest.py:
3900         * Scripts/webkitpy/port/leakdetector_unittest.py:
3901         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
3902         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
3903         * Scripts/webkitpy/port/mock_drt_unittest.py:
3904         * Scripts/webkitpy/port/port_testcase.py:
3905         * Scripts/webkitpy/port/server_process_unittest.py:
3906         * Scripts/webkitpy/port/westondriver_unittest.py:
3907         * Scripts/webkitpy/port/win_unittest.py:
3908         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3909         * Scripts/webkitpy/style/checker_unittest.py:
3910         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3911         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
3912         * Scripts/webkitpy/style/checkers/common_unittest.py:
3913         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3914         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
3915         * Scripts/webkitpy/style/checkers/js_unittest.py:
3916         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
3917         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
3918         * Scripts/webkitpy/style/checkers/png_unittest.py:
3919         * Scripts/webkitpy/style/checkers/python_unittest.py:
3920         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3921         * Scripts/webkitpy/style/checkers/text_unittest.py:
3922         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
3923         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
3924         * Scripts/webkitpy/style/checkers/xml_unittest.py:
3925         * Scripts/webkitpy/style/error_handlers_unittest.py:
3926         * Scripts/webkitpy/style/filereader_unittest.py:
3927         * Scripts/webkitpy/style/filter_unittest.py:
3928         * Scripts/webkitpy/style/main_unittest.py:
3929         * Scripts/webkitpy/style/optparser_unittest.py:
3930         * Scripts/webkitpy/style/patchreader_unittest.py:
3931         * Scripts/webkitpy/test/finder_unittest.py:
3932         * Scripts/webkitpy/test/main.py: Ordered imports.
3933         * Scripts/webkitpy/test/main_unittest.py:
3934         * Scripts/webkitpy/test/printer.py: Ordered imports.
3935         (Printer.configure):
3936         * Scripts/webkitpy/test/runner_unittest.py:
3937         * Scripts/webkitpy/test/skip_unittest.py:
3938         * Scripts/webkitpy/thirdparty/__init__.py:
3939         (AutoinstallImportHook._install_irc):
3940         (AutoinstallImportHook._install_unittest2): Deleted.
3941         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3942         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
3943         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
3944         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3945         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3946         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
3947         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3948         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3949         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3950         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3951         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3952         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3953         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3954         * Scripts/webkitpy/tool/commands/download_unittest.py:
3955         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3956         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
3957         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3958         * Scripts/webkitpy/tool/commands/queuestest.py:
3959         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3960         * Scripts/webkitpy/tool/grammar_unittest.py:
3961         * Scripts/webkitpy/tool/mocktool_unittest.py:
3962         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3963         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3964         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3965         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
3966         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
3967         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
3968         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
3969         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3970         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3971         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
3972         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3973         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3974         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3975         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3976         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3977         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
3978         * Scripts/webkitpy/tool/steps/update_unittest.py:
3979         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3980         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3981         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3982         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3983         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3984
3985 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
3986
3987         LayoutTestResults and ExpectedFailures should know about the
3988         interrupted flag from the json results file
3989         https://bugs.webkit.org/show_bug.cgi?id=137229
3990
3991         Reviewed by Daniel Bates.
3992
3993         Changes LayoutTestResults to use the interrupted flag instead of
3994         counting failures.
3995
3996         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3997         (BuilderTest._install_fetch_build._mock_fetch_build):
3998         (BuilderTest.test_latest_layout_test_results):
3999         * Scripts/webkitpy/common/net/layouttestresults.py:
4000         Removes notion of failure_limit_count, and adds
4001         did_exceed_test_failure_limit.
4002
4003         (LayoutTestResults.results_from_string):
4004         (LayoutTestResults.__init__):
4005         (LayoutTestResults.did_exceed_test_failure_limit):
4006         (LayoutTestResults): Deleted.
4007         (LayoutTestResults.set_failure_limit_count): Deleted.
4008         (LayoutTestResults.failure_limit_count): Deleted.
4009         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4010         Removes unit test for failure_limit_count logic.
4011
4012         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
4013         * Scripts/webkitpy/common/net/resultsjsonparser.py:
4014         Instead of providing a class method that returns a list of
4015         TestResults objects, resultsjsonparser now provides a class
4016         ParsedJSONResults that serves as an interface between the results.json
4017         file and the rest of webkitpy.
4018
4019         (ParsedJSONResults):
4020         (ParsedJSONResults.__init__):
4021         (ParsedJSONResults.did_exceed_test_failure_limit):
4022         (ParsedJSONResults.test_results):
4023         (ResultsJSONParser): Deleted.
4024         (ResultsJSONParser.parse_results_json): Deleted.
4025         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
4026         Updates the unit test so that it can test the new ResultsJSONParser
4027         class.
4028
4029         (ParsedJSONResultsTest):
4030         (test_basic):
4031         (ResultsJSONParserTest): Deleted.
4032         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4033         Updates the unit test to instantiate ResultsJSONParser objects rather
4034         than simple lists of TestResult objects.
4035
4036         (MockCommitQueue.test_results):
4037         (FailingTestCommitQueue.test_results):
4038         (test_flaky_test_failure):
4039         (test_failed_archive):
4040         * Scripts/webkitpy/tool/bot/expectedfailures.py:
4041         Updates ExpectedFailures to use the did_exceed_test_failure_limit
4042         method rather than counting the number of failed tests.
4043
4044         (ExpectedFailures._should_trust):
4045         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
4046         Updates MockResults to more closely resemble the updated
4047         LayoutTestResults class.
4048
4049         (MockResults.__init__):
4050         (MockResults.did_exceed_test_failure_limit):
4051         (ExpectedFailuresTest.test_can_trust_results):
4052         (ExpectedFailuresTest.test_unexpected_failures_observed):
4053         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
4054         (MockResults.failure_limit_count): Deleted.
4055         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
4056         Removes a FIXME regarding the use of the
4057         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
4058
4059         (LayoutTestResultsReader.results):
4060         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4061         Updates test to not check the now-nonexistant failure_count_limit
4062         method.
4063
4064         (test_missing_unit_test_results_path):
4065         (test_layout_test_results):
4066         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
4067         Accounts for name change: ResultsJSONParserTest ->
4068         ParsedJSONParserTest.
4069
4070         (RebaselineTestTest.test_gather_baselines):
4071
4072 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4073
4074         [EFL] Rename TEST_THEME_DIR macro
4075         https://bugs.webkit.org/show_bug.cgi?id=137244
4076
4077         Reviewed by Csaba Osztrogonác.
4078
4079         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
4080         DEFAULT_THEME_DIR is better than it.
4081
4082         * MiniBrowser/efl/main.c:
4083         (window_create):
4084         * TestWebKitAPI/efl/PlatformWebView.cpp:
4085         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4086         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4087         (WTR::PlatformWebView::PlatformWebView):
4088
4089 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
4090
4091         Windows EWS went purple when it failed to build
4092         https://bugs.webkit.org/show_bug.cgi?id=137267
4093
4094         Reviewed by Ryosuke Niwa.
4095
4096         * QueueStatusServer/app.yaml: Update the version.
4097
4098         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
4099         Make it work for style and win-ews queues.
4100
4101 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
4102
4103         It should be fun and easy to run every possible JavaScript benchmark from the command line
4104         https://bugs.webkit.org/show_bug.cgi?id=137245
4105
4106         Reviewed by Oliver Hunt.
4107         
4108         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
4109         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
4110         having their own private scripts for doing benchmark runs, and didn't share them in the open
4111         source community, because of fears about the shady licensing of the benchmarks suites that
4112         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
4113         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
4114         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
4115         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
4116         but some of them are. The non-public tests are exclusively those that were not made by any
4117         WebKit contributor, but which JSC/WebKit devs found useful for testing.
4118
4119         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
4120         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
4121         checked into WebKit svn at all) can be run by passing the path to them via a configuration
4122         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
4123         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
4124         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
4125         probably never be checked in because there is no license text anywhere in that benchmark.
4126         A valid ~/.run-jsc-benchmarks file will just be something like:
4127         
4128             {
4129                 "OctanePath": "/path/to/Octane2",
4130                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
4131             }
4132         
4133         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
4134         run-jsc-benchmarks will just gracefully avoid running that test suite.
4135         
4136         Finally, a word about policy: it is understood that different organizations that do
4137         development on JSC may find themselves having internal benchmarks that they cannot share
4138         because of weird licensing. It happens - usually because the organization doing JSC
4139         development found some test in the wild that is owned by someone else and therefore cannot
4140         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
4141         that add support for some new kind of benchmark suite even if the suite is not made public
4142         as part of the same patch - so long as the patch isn't too invasive. An example of
4143         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
4144         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
4145         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
4146         completely open-sourced and committed to the WebKit repo - but the reality is that this
4147         can't always be done safely.
4148
4149         * Scripts/bencher: Removed.
4150         * Scripts/run-jsc-benchmarks: Added.
4151
4152 2014-09-30  Roger Fong  <roger_fong@apple.com>
4153
4154         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
4155
4156         * Scripts/webkitpy/port/drdiver.py:
4157         (Driver.stop):
4158         * Scripts/webkitpy/port/server_process.py:
4159         (ServerProcess.stop):
4160
4161 2014-09-30  Roger Fong  <roger_fong@apple.com>
4162
4163         [Windows] Back to 2 child processes for NRWT on Windows.
4164
4165         * Scripts/webkitpy/port/win.py:
4166         (WinPort.default_child_processes):
4167         Changing the number of processes to 1 did not have an effect on the layout test results. 
4168         It does introduce an issue with one of the workers hanging indefinitely and causing the 
4169         layout tests to timeout as a whole occasionally, but we should just fix that.
4170
4171 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
4172
4173         Remove an accidentally committed line..
4174
4175         * QueueStatusServer/handlers/statusbubble.py:
4176         (StatusBubble._build_bubble):
4177
4178 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
4179
4180         build.webkit.org/dashboard: Switch EWS view to using actual retry count
4181         https://bugs.webkit.org/show_bug.cgi?id=137240
4182
4183         Reviewed by Ryosuke Niwa.
4184
4185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
4186         (EWSQueue.prototype.loadDetailedStatus):
4187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
4188         (EWSQueueView.prototype._popoverContentForEWSQueue):
4189         Use the new retry_count data member from JSON.
4190
4191         * QueueStatusServer/app.yaml: Updating the version.
4192
4193         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
4194         Instead of message_count, produce retry_count.
4195
4196 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
4197
4198         EWS doesn't need to show all the bubbles when a patch fails to apply
4199         https://bugs.webkit.org/show_bug.cgi?id=137256
4200
4201         Reviewed by Ryosuke Niwa.
4202
4203         * QueueStatusServer/app.yaml: Updated app version.
4204
4205         * QueueStatusServer/handlers/statusbubble.py:
4206         (StatusBubble._build_bubble):
4207         (StatusBubble._build_bubbles_for_attachment):
4208         (StatusBubble.get):
4209         * QueueStatusServer/templates/statusbubble.html:
4210         When some queues fail to apply, and no queues had meaningful output (meaning that
4211         they will almost certainly fail to apply later), we can show a single bubble
4212         telling the user just that.
4213
4214 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
4215
4216         [EFL] Bump EFL version to 1.11.2
4217         https://bugs.webkit.org/show_bug.cgi?id=137118
4218
4219         Reviewed by Gyuyoung Kim.
4220
4221         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
4222         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
4223
4224         * efl/jhbuild.modules:
4225         * efl/patches/ecore.patch: Removed.
4226
4227 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4228
4229         REGRESSION(r173929): [GTK] TestInspector fails after r173929
4230         https://bugs.webkit.org/show_bug.cgi?id=137247
4231
4232         Reviewed by Philippe Normand.
4233
4234         Wait until can-attach property changes before trying to attach the
4235         inspector after resizing the view.
4236
4237         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
4238         (testInspectorDefault):
4239
4240 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4241
4242         Require Python 2.7 version
4243         https://bugs.webkit.org/show_bug.cgi?id=137112
4244
4245         Reviewed by Csaba Osztrogonác.
4246
4247         * Scripts/ensure-valid-python:
4248         (checkPythonVersion):
4249         * Scripts/webkitpy/common/version_check.py:
4250
4251 2014-09-30  Martin Hock  <mhock@apple.com>
4252
4253         Skip a JSC test after r174036.
4254         https://bugs.webkit.org/show_bug.cgi?id=137236
4255
4256         Reviewed by Csaba Osztrogonác.
4257
4258         * Scripts/run-javascriptcore-tests:
4259
4260 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4261
4262         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
4263         https://bugs.webkit.org/show_bug.cgi?id=137212
4264
4265         This moves TestNetscapePlugin to a new folder (lib/plugins).
4266         We should not use the same directory for TestNetscapePlugin and
4267         the other libraries, because we end up scanning all the .so in the
4268         lib dir for every test.
4269
4270         Reviewed by Carlos Garcia Campos.
4271
4272         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
4273         * Scripts/webkitpy/port/efl.py:
4274         (EflPort.setup_environ_for_server): Update plugin path.
4275         * Scripts/webkitpy/port/gtk.py: