[LFC][IFC] Add intrinsic width support for basic inline containers
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC][IFC] Add intrinsic width support for basic inline containers
4         https://bugs.webkit.org/show_bug.cgi?id=194473
5
6         Reviewed by Antti Koivisto.
7
8         Expand tests coverage (11 new tests -> 798)
9
10         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
11
12 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
13
14         Fix MiniBrowser's entitlements
15         https://bugs.webkit.org/show_bug.cgi?id=192431
16
17         Reviewed by Joseph Pecoraro.
18
19         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
20         files, making it impossible to load any extension.
21
22         * MiniBrowser/MiniBrowser.entitlements:
23
24 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
25
26         [Cocoa] Ask platform for generic font family mappings
27         https://bugs.webkit.org/show_bug.cgi?id=187723
28         <rdar://problem/41892438>
29
30         Reviewed by Brent Fulgham.
31
32         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
33
34         * DumpRenderTree/mac/DumpRenderTree.mm:
35         (allowedFontFamilySet):
36         * WebKitTestRunner/mac/TestControllerMac.mm:
37         (WTR::allowedFontFamilySet):
38
39 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
40
41         [GTK] Implement back/forward touchpad gesture
42         https://bugs.webkit.org/show_bug.cgi?id=193919
43
44         Reviewed by Michael Catanzaro.
45
46         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
47         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
48
49 2019-02-08  Alex Christensen  <achristensen@webkit.org>
50
51         Add SPI to use networking daemon instead of XPC service
52         https://bugs.webkit.org/show_bug.cgi?id=194427
53
54         Reviewed by Geoffrey Garen
55
56         * MiniBrowser/MiniBrowser.entitlements:
57
58 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
59
60         [ews-build] Ensure that every builder in config.json has short name
61         https://bugs.webkit.org/show_bug.cgi?id=194461
62
63         Reviewed by Lucas Forschler.
64
65         * BuildSlaveSupport/ews-build/loadConfig.py:
66         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
67
68 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
69
70         [ews-build] Add short name to config.json
71         https://bugs.webkit.org/show_bug.cgi?id=194456
72
73         Reviewed by Lucas Forschler.
74
75         * BuildSlaveSupport/ews-build/config.json: Added short name.
76         * BuildSlaveSupport/ews-build/loadConfig.py:
77         (loadBuilderConfig): Set the short name as the builder description.
78
79 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
80
81         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
82         https://bugs.webkit.org/show_bug.cgi?id=194418
83
84         Reviewed by Lucas Forschler.
85
86         Do not include errors trying when finding crashlogs at the end of
87         a run-webkit-tests run since we don't process those errors.
88
89         * Scripts/webkitpy/port/darwin.py:
90         (DarwinPort._look_for_all_crash_logs_in_log_dir):
91         * Scripts/webkitpy/port/ios_device.py:
92         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
93         * Scripts/webkitpy/port/watch_device.py:
94         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
95
96 2019-02-08  Beth Dakin  <bdakin@apple.com>
97
98         Add afterScreenUpdates to WKSnapshotConfiguration
99         https://bugs.webkit.org/show_bug.cgi?id=194362
100         -and corresponding-
101         <rdar://problem/40655528> Please add an "after screen updates" property to 
102         WKSnapshotConfiguration (to solve blank snapshots)
103
104         Reviewed by Tim Horton.
105
106         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
107         (TEST):
108
109 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
110
111         clampTo(): do not convert the input to double when dealing with integers
112         https://bugs.webkit.org/show_bug.cgi?id=194263
113         <rdar://problem/47692312>
114
115         Reviewed by Darin Adler.
116
117         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
118         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
119         (TestWebKitAPI::testClampFloatingPointToInteger):
120         (TestWebKitAPI::testClampSameSignIntegers):
121         (TestWebKitAPI::testClampUnsignedToSigned):
122         (TestWebKitAPI::testClampSignedToUnsigned):
123
124 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
125
126         webkitpy: Respect --dedicated-simulators flag
127         https://bugs.webkit.org/show_bug.cgi?id=194416
128         <rdar://problem/47894722>
129
130         Reviewed by Lucas Forschler.
131
132         * Scripts/webkitpy/port/device_port.py:
133         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
134         available devices can be safely ignored.
135
136 2019-02-07  Keith Rollin  <krollin@apple.com>
137
138         Remove extra copy of 100x100-red.tga
139         https://bugs.webkit.org/show_bug.cgi?id=194371
140         <rdar://problem/47873465>
141
142         Reviewed by Said Abou-Hallawa.
143
144         In order to help it pass its tests, Bug 194190 added a second copy of
145         the file 100x100-red.tga. However, it turns out that this additional
146         file wasn't actually needed, and that that sole previous copy was
147         sufficient. At the same time, this second copy -- which was copied to
148         the same location in the build output as the first copy -- now caused
149         XCBuild to complain because there were two production rules for the
150         same output file. Address this by removing the newly-added extra copy.
151
152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
153         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
154
155 2019-02-07  Alex Christensen  <achristensen@webkit.org>
156
157         Deprecate WKBundlePageSetDefersLoading
158         https://bugs.webkit.org/show_bug.cgi?id=191394
159
160         Reviewed by Dean Jackson.
161
162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
163         (WTR::TestRunner::setDefersLoading):
164
165 2019-02-07  Zalan Bujtas  <zalan@apple.com>
166
167         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
168         https://bugs.webkit.org/show_bug.cgi?id=194391
169
170         Reviewed by Antti Koivisto.
171
172         * LayoutReloaded/misc/LFC-passing-tests.txt:
173
174 2019-02-06  Keith Rollin  <krollin@apple.com>
175
176         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
177         https://bugs.webkit.org/show_bug.cgi?id=193975
178         <rdar://problem/47643306>
179
180         Reviewed by Tim Horton.
181
182         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
183         the Info.plist file into the bundle. This step is not necessary as the
184         implicit "bundle up all the build products into a framework" build
185         phase does this already. Having the Copy Bundle Resources phase do
186         this causes a conflict under XCBuild, which objects to two build
187         phases producing the same file (Info.plist). Address this by removing
188         Info.plist from the Copy Bundle Resources phase.
189
190         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
191
192 2019-02-06  Keith Rollin  <krollin@apple.com>
193
194         Really enable the automatic checking and regenerations of .xcfilelists during builds
195         https://bugs.webkit.org/show_bug.cgi?id=194357
196         <rdar://problem/47861231>
197
198         Reviewed by Chris Dumez.
199
200         Bug 194124 was supposed to enable the automatic checking and
201         regenerating of .xcfilelist files during the build. While related
202         changes were included in that patch, the change to actually enable the
203         operation somehow was omitted. This patch actually enables the
204         operation. The check-xcfilelist.sh scripts now check
205         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
206         from the checking.
207
208         * DumpRenderTree/Scripts/check-xcfilelists.sh:
209         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
210
211 2019-02-06  David Kilzer  <ddkilzer@apple.com>
212
213         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
214         <https://webkit.org/b/194286>
215         <rdar://problem/47815558>
216
217         Reviewed by Alexey Proskuryakov.
218
219         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
220         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
221         WKRetainPtr<> to avoid leaking the WKDataRef.
222
223 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
224
225         Unreviewed, fix a typo
226
227         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
228
229 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
230
231         [GTK][WPE] force libpsl build to use ICU in jhbuild
232         https://bugs.webkit.org/show_bug.cgi?id=194288
233
234         Reviewed by Carlos Garcia Campos.
235
236         * gtk/jhbuild.modules:
237         Require ICU for libpsl build in jhbuild, like done in WPE.
238
239 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
240
241         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
242         https://bugs.webkit.org/show_bug.cgi?id=194209
243
244         Reviewed by Carlos Garcia Campos.
245
246         Enhance TestCookieManager to ensure this doesn't happen again.
247
248         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
249         (testCookieManagerPersistentStorage):
250         (beforeAll):
251
252 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
253
254         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
255         https://bugs.webkit.org/show_bug.cgi?id=194324
256
257         Reviewed by Andy Estes.
258
259         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
260         part of the name is already implicit, since this is in testing code in TestOptions.
261
262         * WebKitTestRunner/TestController.cpp:
263         (WTR::TestController::generateContextConfiguration const):
264         (WTR::updateTestOptionsFromTestHeader):
265         * WebKitTestRunner/TestOptions.h:
266         (WTR::TestOptions::hasSameInitializationOptions const):
267
268 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
269
270         [ews-build] Allow * as platform for builders and workers
271         https://bugs.webkit.org/show_bug.cgi?id=188533
272
273         Reviewed by Lucas Forschler.
274
275         * BuildSlaveSupport/ews-build/loadConfig.py:
276         (checkWorkersAndBuildersForConsistency):
277
278 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
279
280         [ews-build] Add few bots to config.json
281         https://bugs.webkit.org/show_bug.cgi?id=194304
282
283         Reviewed by Lucas Forschler.
284
285         * BuildSlaveSupport/ews-build/config.json:
286
287 2019-02-05  Keith Rollin  <krollin@apple.com>
288
289         Enable the automatic checking and regenerations of .xcfilelists during builds
290         https://bugs.webkit.org/show_bug.cgi?id=194124
291         <rdar://problem/47721277>
292
293         Reviewed by Tim Horton.
294
295         Bug 193790 add a facility for checking -- during build time -- that
296         any needed .xcfilelist files are up-to-date and for updating them if
297         they are not. This facility was initially opt-in by setting
298         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
299         the process seemed robust. Its now time to enable this facility and
300         make it opt-out. If there is a need to disable this facility, set and
301         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
302         running `make` or `build-webkit`, or before running Xcode from the
303         command line.
304
305         Additionally, remove the step that generates a list of source files
306         going into the UnifiedSources build step. It's only necessarily to
307         specify Sources.txt and SourcesCocoa.txt as inputs.
308
309         * Scripts/generate-xcfilelists:
310
311 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
312
313         [GTK][WPE] force libpsl build to use ICU in jhbuild
314         https://bugs.webkit.org/show_bug.cgi?id=194288
315
316         Reviewed by Philippe Normand.
317
318         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
319         This can cause build failures if libidn is detected but libunistring is not available.
320
321         Make sure that ICU is used for runtime and builtin PSL data.
322
323         * gtk/jhbuild.modules:
324         * wpe/jhbuild.modules:
325
326 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
327
328         [ews-app] Modified timestamp should be updated on updating data
329         https://bugs.webkit.org/show_bug.cgi?id=194295
330
331         Reviewed by Lucas Forschler.
332
333         * BuildSlaveSupport/ews-app/ews/models/build.py:
334         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
335         * BuildSlaveSupport/ews-app/ews/models/step.py:
336
337 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
338
339         Unreviewed, rolling out r240742.
340
341         Causes crashes on iOS simulator.
342
343         Reverted changeset:
344
345         "[iOS] Keyups for non-modifier keys identified as "Dead" when
346         not focused in a content-editable element"
347         https://bugs.webkit.org/show_bug.cgi?id=192824
348         https://trac.webkit.org/changeset/240742
349
350 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
351
352         run-webkit-tests emits message "...running None" when running tests
353         https://bugs.webkit.org/show_bug.cgi?id=194133
354         <rdar://problem/47724738>
355
356         Reviewed by Lucas Forschler.
357
358         * Scripts/webkitpy/xcode/device_type.py:
359         (DeviceType.__str__): Use both version mapping tables and use just the variant
360         name if no version name is available.
361         * Scripts/webkitpy/xcode/device_type_unittest.py:
362         (DeviceTypeTest):
363         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
364         an associated named.
365
366 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
367
368         [WPE] require python3-setuptools for meson build in jhbuild
369         https://bugs.webkit.org/show_bug.cgi?id=194287
370
371         Reviewed by Philippe Normand.
372
373         python3-setuptools is needed to build meson in jhbuild.
374         It is already required by the GTK port.
375
376         * wpe/install-dependencies:
377
378 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
379
380         [ews-app] Add method to save BuilderMapping to database
381         https://bugs.webkit.org/show_bug.cgi?id=194264
382
383         Reviewed by Lucas Forschler.
384
385         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
386         (BuilderMapping.__str__):
387         (BuilderMapping):
388         (BuilderMapping.save_mapping):
389         (BuilderMapping.update_mapping):
390         (BuilderMapping.get_existing_mapping):
391         (BuilderMapping.is_valid_mapping):
392
393 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
394
395         [ews-app] Add timestamp fields for BuilderMappings
396         https://bugs.webkit.org/show_bug.cgi?id=194266
397
398         Reviewed by Lucas Forschler.
399
400         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
401         (BuilderMapping):
402
403 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
404
405         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
406         https://bugs.webkit.org/show_bug.cgi?id=174816
407
408         Reviewed by Michael Catanzaro.
409
410         Add tests for webkit_uri_for_display().
411
412         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
413         (testURIForDisplayUnaffected):
414         (testURIForDisplayAffected):
415         (beforeAll):
416         (afterAll):
417         * TestWebKitAPI/glib/CMakeLists.txt:
418
419 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
420
421         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
422         https://bugs.webkit.org/show_bug.cgi?id=194158
423         <rdar://problem/47737268>
424
425         Rubber-stamped by Aakash Jain.
426
427         * Scripts/webkitpy/port/device_port.py:
428         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
429
430 2019-02-04  Said Abou-Hallawa  <said@apple.com>
431
432         [CG] Enable setAdditionalSupportedImageTypes for WK1
433         https://bugs.webkit.org/show_bug.cgi?id=194190
434
435         Reviewed by Tim Horton.
436
437         Add a test similar to the one under WebKit Cocoa but make it create a
438         WebView instead of a WKWebView.
439
440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
441         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
442         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
443         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
444         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
445         (TestWebKitAPI::runTest):
446         (TestWebKitAPI::TEST):
447
448 2019-02-04  Zalan Bujtas  <zalan@apple.com>
449
450         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
451         https://bugs.webkit.org/show_bug.cgi?id=194168
452
453         Reviewed by Simon Fraser.
454
455         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
456
457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
458         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
459         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
460         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
461         (TEST):
462         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
463         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
464
465 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
466
467         REGRESSION (r237269): webkit-patch what-broke is broken 
468         https://bugs.webkit.org/show_bug.cgi?id=193025
469
470         Reviewed by Aakash Jain.
471
472         * Scripts/webkitpy/common/host.py:
473         (Host.buildbot):
474         (Host.bugzilla): Renamed to 'buildbot'.
475
476 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
477
478         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
479         https://bugs.webkit.org/show_bug.cgi?id=194207
480
481         Reviewed by Tim Horton.
482
483         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
484         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
485         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
486         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
487         start and delete forwards to remove the original attachment.
488
489         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
490         (TestWebKitAPI::TEST):
491
492 2019-02-04  Youenn Fablet  <youenn@apple.com>
493
494         Capture state should be managed consistently when doing process swapping
495         https://bugs.webkit.org/show_bug.cgi?id=194122
496         <rdar://problem/47609293>
497
498         Reviewed by Eric Carlson.
499
500         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
501         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
502         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
503         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
504         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
505         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
506         (WTR::TestRunner::isDoingMediaCapture const):
507         * WebKitTestRunner/InjectedBundle/TestRunner.h:
508         * WebKitTestRunner/TestController.cpp:
509         (WTR::TestController::isDoingMediaCapture const):
510         * WebKitTestRunner/TestController.h:
511         * WebKitTestRunner/TestInvocation.cpp:
512         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
513         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
514         (WTR::TestController::isDoingMediaCapture const):
515
516 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
517
518         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
519         https://bugs.webkit.org/show_bug.cgi?id=194142
520
521         Reviewed by Ross Kirsling.
522
523         There three 'separator' variables in TestController.cpp. Renamed
524         it 'pathSeparator', and unified them.
525
526         * WebKitTestRunner/TestController.cpp:
527         (WTR::TestController::generateContextConfiguration const):
528         (WTR::createTestURL):
529         (WTR::TestController::platformAdjustContext):
530
531 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
532
533         Make setNeedsLayout on the root more explicitly about triggering its side-effects
534         https://bugs.webkit.org/show_bug.cgi?id=194198
535
536         Reviewed by Antti Koivisto.
537
538         No need to set the banner heights on navigation now, since Page stores them.
539
540         * MiniBrowser/mac/WK2BrowserWindowController.m:
541         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
542
543 2019-02-03  John Wilander  <wilander@apple.com>
544
545         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
546         https://bugs.webkit.org/show_bug.cgi?id=194104
547         <rdar://problem/47649991>
548
549         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
550
551         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
552         (TestWebKitAPI::TEST):
553             Changed numeric types from unsigned short to uint32_t.
554
555 2019-02-02  David Kilzer  <ddkilzer@apple.com>
556
557         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
558         <https://webkit.org/b/194178>
559         <rdar://problem/47753473>
560
561         Reviewed by Alexey Proskuryakov.
562
563         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
564         (WTR::uninstallFakeHelvetica): Pass nullptr into
565         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
566
567 2019-02-02  Zalan Bujtas  <zalan@apple.com>
568
569         [LFC] Initialize ICB's style with fixed width/height.
570         https://bugs.webkit.org/show_bug.cgi?id=194188
571
572         Reviewed by Antti Koivisto.
573
574         * LayoutReloaded/misc/LFC-passing-tests.txt:
575
576 2019-02-02  Zalan Bujtas  <zalan@apple.com>
577
578         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
579         https://bugs.webkit.org/show_bug.cgi?id=194185
580
581         Reviewed by Antti Koivisto.
582
583         * LayoutReloaded/misc/LFC-passing-tests.txt:
584
585 2018-12-16  Darin Adler  <darin@apple.com>
586
587         Convert additional String::format clients to alternative approaches
588         https://bugs.webkit.org/show_bug.cgi?id=192746
589
590         Reviewed by Alexey Proskuryakov.
591
592         * WebKitTestRunner/TestController.cpp:
593         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
594         as an intermediate in code that ultimately constructs a WTF::String.
595         (WTR::userMediaOriginHash): Use makeString.
596         (WTR::TestController::didNavigateWithNavigationData): More of the same.
597         (WTR::TestController::didPerformClientRedirect): Ditto.
598         (WTR::TestController::didPerformServerRedirect): Ditto.
599         (WTR::TestController::didUpdateHistoryTitle): Ditto.
600
601 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
602
603         [ews-build] Add unit test to verify builder keys
604         https://bugs.webkit.org/show_bug.cgi?id=194152
605
606         Reviewed by Lucas Forschler.
607
608         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
609         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
610
611 2019-02-01  Zalan Bujtas  <zalan@apple.com>
612
613         [LFC] Expand tests coverage (12 new tests -> 787)
614
615         Unreviewed test gardening.
616
617         * LayoutReloaded/misc/LFC-passing-tests.txt:
618
619 2019-02-01  Zalan Bujtas  <zalan@apple.com>
620
621         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
622         https://bugs.webkit.org/show_bug.cgi?id=194163
623
624         Reviewed by Simon Fraser.
625
626         775
627
628         * LayoutReloaded/misc/LFC-passing-tests.txt:
629
630 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
631
632         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
633         https://bugs.webkit.org/show_bug.cgi?id=194140
634         <rdar://problem/47728098>
635
636         Reviewed by Tim Horton.
637
638         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
639         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
640         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
641
642         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
643         test to induce an IPC deadlock when presenting a modal alert during touch start.
644
645         * WebKitTestRunner/InjectedBundle/TestRunner.h:
646         * WebKitTestRunner/TestController.cpp:
647         (WTR::runJavaScriptAlert):
648
649         Add a client callback function for running JavaScript alerts.
650
651         (WTR::TestController::createOtherPage):
652         (WTR::TestController::generateContextConfiguration const):
653
654         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
655         the fix in this patch.
656
657         (WTR::TestController::createWebViewWithOptions):
658
659         Plumb TestOptions to generateContextConfiguration.
660
661         (WTR::TestController::resetPreferencesToConsistentValues):
662         (WTR::TestController::resetStateToConsistentValues):
663         (WTR::updateTestOptionsFromTestHeader):
664         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
665         (WTR::TestController::handleJavaScriptAlert):
666         * WebKitTestRunner/TestController.h:
667         * WebKitTestRunner/TestInvocation.cpp:
668         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
669         * WebKitTestRunner/TestOptions.h:
670         (WTR::TestOptions::hasSameInitializationOptions const):
671
672 2019-02-01  Chris Dumez  <cdumez@apple.com>
673
674         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
675         https://bugs.webkit.org/show_bug.cgi?id=193740
676         <rdar://problem/47527267>
677
678         Reviewed by Alex Christensen.
679
680         Add API test coverage.
681
682         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
683
684 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
685
686         [ews-app] Add display name field to BuilderMapping model
687         https://bugs.webkit.org/show_bug.cgi?id=194153
688
689         Reviewed by Lucas Forschler.
690
691         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
692         (BuilderMapping):
693
694 2019-02-01  Youenn Fablet  <youenn@apple.com>
695
696         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
697         https://bugs.webkit.org/show_bug.cgi?id=194155
698
699         Reviewed by Eric Carlson.
700
701         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
702         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
703         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
704
705 2019-02-01  Zalan Bujtas  <zalan@apple.com>
706
707         [LFC] Adjust replaced element's intrinsic ratio
708         https://bugs.webkit.org/show_bug.cgi?id=194154
709
710         Reviewed by Antti Koivisto.
711
712         761
713
714         * LayoutReloaded/misc/LFC-passing-tests.txt:
715
716 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
717
718         [WPE] Show test results in minibrowser
719         https://bugs.webkit.org/show_bug.cgi?id=194150
720
721         Reviewed by Žan Doberšek.
722
723         * Scripts/webkitpy/port/wpe.py:
724         (WPEPort.show_results_html_file):
725
726 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
727
728         [WPE] MiniBrowser: add ky bindings for back/forward navigation
729         https://bugs.webkit.org/show_bug.cgi?id=194151
730
731         Reviewed by Žan Doberšek.
732
733         ALT + <- go back
734         ALT + -> go forward
735
736         * MiniBrowser/wpe/main.cpp:
737         (main):
738
739 2019-02-01  Zalan Bujtas  <zalan@apple.com>
740
741         [LFC] Set intrinsic size on Layout::Replaced
742         https://bugs.webkit.org/show_bug.cgi?id=194139
743
744         Reviewed by Antti Koivisto.
745
746         744
747
748         * LayoutReloaded/misc/LFC-passing-tests.txt:
749
750 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
751
752         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
753         https://bugs.webkit.org/show_bug.cgi?id=194146
754
755         Reviewed by Xabier Rodriguez-Calvar.
756
757         It allows to open relative paths.
758
759         * MiniBrowser/wpe/main.cpp:
760         (main):
761
762 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
763
764         Update flakiness dashboard configuration after recent queue changes
765         https://bugs.webkit.org/show_bug.cgi?id=194127
766
767         Rubber-stamped by Aakash Jain.
768
769         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
770
771         * TestResultServer/static-dashboards/builders.jsonp:
772
773 2019-01-31  Youenn Fablet  <youenn@apple.com>
774
775         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
776         https://bugs.webkit.org/show_bug.cgi?id=194106
777         <rdar://problem/47676333>
778
779         Reviewed by Ryosuke Niwa.
780
781         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
782         (TestWebKitAPI::didFinishNavigation):
783         (TestWebKitAPI::TEST):
784         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
785
786 2019-01-31  Chris Dumez  <cdumez@apple.com>
787
788         Page zoom level is lost after a process swap or a crash
789         https://bugs.webkit.org/show_bug.cgi?id=194105
790         <rdar://problem/47610781>
791
792         Reviewed by Alex Christensen.
793
794         Add API test coverage.
795
796         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
797         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
798
799 2019-01-31  Alex Christensen  <achristensen@webkit.org>
800
801         Revert r238819 which is unneeded and caused a performance regression.
802         https://bugs.webkit.org/show_bug.cgi?id=192272
803         <rdar://problem/46664625>
804
805         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
806         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
807         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
808
809 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
810
811         Formalize WebKitAdditions mechanism of LoadOptimizer
812         https://bugs.webkit.org/show_bug.cgi?id=193886
813         <rdar://problem/47696809>
814
815         Reviewed by Brent Fulgham.
816
817         * MiniBrowser/MiniBrowser.entitlements:
818         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
819
820 2019-01-31  Zalan Bujtas  <zalan@apple.com>
821
822         [LFC] Margin before/after/start/end initial value is 0 and not auto.
823         https://bugs.webkit.org/show_bug.cgi?id=194090
824
825         Reviewed by Antti Koivisto.
826
827         * LayoutReloaded/misc/LFC-passing-tests.txt:
828
829 2019-01-31  Zalan Bujtas  <zalan@apple.com>
830
831         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
832         https://bugs.webkit.org/show_bug.cgi?id=194074
833
834         Reviewed by Antti Koivisto.
835
836         * LayoutReloaded/misc/LFC-passing-tests.txt:
837
838 2019-01-31  Zalan Bujtas  <zalan@apple.com>
839
840         [LFC][BFC] Add support for block level replaced box.
841         https://bugs.webkit.org/show_bug.cgi?id=194071
842
843         Reviewed by Antti Koivisto.
844
845         * LayoutReloaded/misc/LFC-passing-tests.txt:
846
847 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
848
849         Fix WebKitTestRunner's testPath with Windows full paths
850         https://bugs.webkit.org/show_bug.cgi?id=194012
851
852         Reviewed by Alex Christensen.
853
854         updateTestOptionsFromTestHeader failed to open test files because
855         testPath returned wrong file paths. It returned a path "/C:/..."
856         if a URL "file:///C:/..." was given.
857
858         * WebKitTestRunner/TestController.cpp:
859         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
860
861 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
862
863         [WPE] Bump font related dependencies to match the GTK+ port
864         https://bugs.webkit.org/show_bug.cgi?id=194017
865
866         Reviewed by Žan Doberšek.
867
868         * wpe/jhbuild.modules:
869         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
870         * wpe/patches/icudata-stdlibs.patch: Added.
871
872 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
873
874         Enable swipe tests on iOS
875         https://bugs.webkit.org/show_bug.cgi?id=194076
876
877         Reviewed by Geoffrey Garen.
878
879         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
880         it causes a debug assertion failure in runUIScript.
881
882         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
883         (WTR::UIScriptController::beginBackSwipe):
884         (WTR::UIScriptController::completeBackSwipe):
885
886 2019-01-30  Keith Rollin  <krollin@apple.com>
887
888         Use correct printf format specifier
889         https://bugs.webkit.org/show_bug.cgi?id=194062
890         <rdar://problem/47686167>
891
892         Reviewed by Alexey Proskuryakov.
893
894         LayoutTestSpellChecker.mm is trying to format a variable of type
895         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
896         actually an unsigned long long. Fix this by formatting with %llu.
897
898         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
899         (-[LayoutTestTextCheckingResult description]):
900
901 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
902
903         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
904         https://bugs.webkit.org/show_bug.cgi?id=193979
905
906         Reviewed by Wenson Hsieh.
907
908         Fix the test for iOS. Make the test work with iOS UA string.
909
910         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
911
912 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
913
914         Replace High Sierra LLINT CLoop bot due to hardware failure
915         https://bugs.webkit.org/show_bug.cgi?id=194066
916
917         Reviewed by Aakash Jain.
918
919         * BuildSlaveSupport/build.webkit.org-config/config.json:
920
921 2019-01-30  Keith Rollin  <krollin@apple.com>
922
923         [NSDragItem init] is unavailable
924         https://bugs.webkit.org/show_bug.cgi?id=194059
925         <rdar://problem/47685715>
926
927         Reviewed by Wenson Hsieh.
928
929         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
930         DumpRenderTree and TestWebKitAPI, which both try to create an
931         NSDragItem in a manner that invokes this method. Address this by using
932         -initWithPasteboardWriter instead.
933
934         Note that the parameter passed to initWithPasteboardWriter is likely
935         incorrect. In both cases, the object passed does not conform to
936         NSPasteboardWriting. However, with this fix, we're no worse off than
937         before, and can now perform builds with newer compilers and SDKs until
938         a real fix can be crafted. That work is tracked in
939         https://bugs.webkit.org/show_bug.cgi?id=194060
940
941         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
942         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
943         * TestWebKitAPI/mac/TestDraggingInfo.mm:
944         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
945
946 2019-01-30  Daniel Bates  <dabates@apple.com>
947
948         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
949         https://bugs.webkit.org/show_bug.cgi?id=192824
950         <rdar://problem/47100332>
951
952         Reviewed by Wenson Hsieh.
953
954         Fix a bug where the wrong usage code was used for F13 thru F24.
955
956         * WebKitTestRunner/ios/HIDEventGenerator.mm:
957         (keyCodeForDOMFunctionKey):
958
959 2019-01-30  Chris Dumez  <cdumez@apple.com>
960
961         Regression(PSON) Load hang can occur on history navigation
962         https://bugs.webkit.org/show_bug.cgi?id=194030
963         <rdar://problem/47656939>
964
965         Reviewed by Antti Koivisto.
966
967         Add API test coverage.
968
969         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
970
971 2019-01-30  Zalan Bujtas  <zalan@apple.com>
972
973         [LFC] Expand tests coverage.
974
975         Unreviewed test gardening.
976
977         * LayoutReloaded/misc/LFC-passing-tests.txt:
978
979 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
980
981         [Flatpak] Add openjpeg support
982         https://bugs.webkit.org/show_bug.cgi?id=194019
983
984         Reviewed by Michael Catanzaro.
985
986         * flatpak/org.webkit.CommonModules.yaml:
987
988 2019-01-30  Commit Queue  <commit-queue@webkit.org>
989
990         Unreviewed, rolling out r240708.
991         https://bugs.webkit.org/show_bug.cgi?id=194022
992
993         It broke WPE build (Requested by KaL on #webkit).
994
995         Reverted changeset:
996
997         "[WPE] Bump font related dependencies to match the GTK+ port"
998         https://bugs.webkit.org/show_bug.cgi?id=194017
999         https://trac.webkit.org/changeset/240708
1000
1001 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1002
1003         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1004         https://bugs.webkit.org/show_bug.cgi?id=194001
1005
1006         Reviewed by Antti Koivisto.
1007
1008         * LayoutReloaded/misc/LFC-passing-tests.txt:
1009
1010 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1011
1012         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1013         https://bugs.webkit.org/show_bug.cgi?id=194020
1014
1015         Reviewed by Antti Koivisto.
1016
1017         * LayoutReloaded/misc/LFC-passing-tests.txt:
1018
1019 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1020
1021         AX: Support color well on iOS
1022         https://bugs.webkit.org/show_bug.cgi?id=194010
1023
1024         Reviewed by Joanmarie Diggs.
1025
1026         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1027         (WTR::AccessibilityUIElement::stringAttributeValue):
1028
1029 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1030
1031         [WPE] Bump font related dependencies to match the GTK+ port
1032         https://bugs.webkit.org/show_bug.cgi?id=194017
1033
1034         Reviewed by Žan Doberšek.
1035
1036         * wpe/jhbuild.modules:
1037         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1038         * wpe/patches/icudata-stdlibs.patch: Added.
1039
1040 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1041
1042         [Mac] Update window scale API usage
1043         https://bugs.webkit.org/show_bug.cgi?id=193991
1044         rdar://problem/47614795
1045
1046         Reviewed by Tim Horton.
1047
1048         * DumpRenderTree/mac/DumpRenderTree.mm:
1049         (changeWindowScaleIfNeeded):
1050         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1051         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1052         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1053
1054 2019-01-29  Chris Dumez  <cdumez@apple.com>
1055
1056         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1057         https://bugs.webkit.org/show_bug.cgi?id=193977
1058         <rdar://problem/47643716>
1059
1060         Reviewed by Geoff Garen.
1061
1062         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1063         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1064         to the previous provisional committing *before* we make the last load. 
1065
1066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1067
1068 2019-01-29  Youenn Fablet  <youenn@apple.com>
1069
1070         Adopt new SPI to evaluate server certificate trust
1071         https://bugs.webkit.org/show_bug.cgi?id=193355
1072
1073         Reviewed by Alex Christensen.
1074
1075         Add infrastructure to handle HTTPS server trust evaluation testing.
1076
1077         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1078         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1079         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1080         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1081         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1082         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1083         * WebKitTestRunner/TestController.cpp:
1084         (WTR::TestController::resetPreferencesToConsistentValues):
1085         (WTR::TestController::didReceiveAuthenticationChallenge):
1086         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1087         * WebKitTestRunner/TestController.h:
1088         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1089         * WebKitTestRunner/TestInvocation.cpp:
1090         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1091         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1092         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1093
1094 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1095
1096         [ews-build] Add build step to print bot Configuration
1097         https://bugs.webkit.org/show_bug.cgi?id=193887
1098
1099         Reviewed by Lucas Forschler.
1100
1101         * BuildSlaveSupport/ews-build/steps.py:
1102         (PrintConfiguration): Build step to print configuration.
1103         * BuildSlaveSupport/ews-build/factories.py:
1104
1105 2019-01-29  Chris Dumez  <cdumez@apple.com>
1106
1107         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1108         https://bugs.webkit.org/show_bug.cgi?id=193967
1109         <rdar://problem/47635348>
1110
1111         Reviewed by Alex Christensen.
1112
1113         Add API test coverage.
1114
1115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1116         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1117
1118 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1119
1120         [ews-app] Handle incoming results data
1121         https://bugs.webkit.org/show_bug.cgi?id=193973
1122
1123         Reviewed by Lucas Forschler.
1124
1125         * BuildSlaveSupport/ews-app/ews/views/results.py:
1126
1127 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1128
1129         [ews-app] Make the results url generic
1130         https://bugs.webkit.org/show_bug.cgi?id=193928
1131
1132         Reviewed by Lucas Forschler.
1133
1134         * BuildSlaveSupport/ews-app/ews/urls.py:
1135
1136 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1137
1138         [ews-build] Configure buildbot to send events to ews-app
1139         https://bugs.webkit.org/show_bug.cgi?id=193968
1140
1141         Reviewed by Lucas Forschler.
1142
1143         * BuildSlaveSupport/ews-build/events.py: Added.
1144         * BuildSlaveSupport/ews-build/master.cfg:
1145
1146 2019-01-29  Keith Rollin  <krollin@apple.com>
1147
1148         Add .xcfilelists to Run Script build phases
1149         https://bugs.webkit.org/show_bug.cgi?id=193792
1150         <rdar://problem/47201785>
1151
1152         Reviewed by Alex Christensen.
1153
1154         As part of supporting XCBuild, update the necessary Run Script build
1155         phases in their Xcode projects to refer to their associated
1156         .xcfilelist files.
1157
1158         Note that the addition of these files bumps the Xcode project version
1159         number to something that's Xcode 10 compatible. This change means that
1160         older versions of the Xcode IDE can't read these projects. Nor can it
1161         fully load workspaces that refer to these projects (the updated
1162         projects are shown as non-expandable placeholders). `xcodebuild` can
1163         still build these projects; it's just that the IDE can't open them.
1164
1165         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1166         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1167
1168 2019-01-29  John Wilander  <wilander@apple.com>
1169
1170         Add data abstraction and validation for Ad Click Attribution
1171         https://bugs.webkit.org/show_bug.cgi?id=193916
1172         <rdar://problem/47603481>
1173
1174         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1175
1176         Ad click attribution has two steps. First, the storage of an ad
1177         campaign ID for a click that takes the user to a destination
1178         site. Second, a conversion on the destination site that can be
1179         attributed to the ad click.
1180
1181         This patch adds a class that represents a request for ad click
1182         attribution. Validation makes sure that the bits of entropy
1183         reported through this mechanism is limited.
1184
1185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1186         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1187         (TestWebKitAPI::TEST):
1188
1189 2019-01-29  Chris Dumez  <cdumez@apple.com>
1190
1191         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1192         https://bugs.webkit.org/show_bug.cgi?id=193932
1193         <rdar://problem/47598947>
1194
1195         Reviewed by Brady Eidson.
1196
1197         Add API test coverage.
1198
1199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1200
1201 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1202
1203         Adding new passing LFC tests.
1204
1205         Unreviewed test gardening.
1206
1207         * LayoutReloaded/misc/LFC-passing-tests.txt:
1208
1209 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1210
1211         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1212         https://bugs.webkit.org/show_bug.cgi?id=193964
1213
1214         Reviewed by Antti Koivisto.
1215
1216         * LayoutReloaded/misc/LFC-passing-tests.txt:
1217
1218 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1219
1220         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1221         https://bugs.webkit.org/show_bug.cgi?id=193954
1222
1223         Reviewed by Antti Koivisto.
1224
1225         * LayoutReloaded/misc/LFC-passing-tests.txt:
1226
1227 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1228
1229         WebDriver: add support for running subtests
1230         https://bugs.webkit.org/show_bug.cgi?id=193904
1231
1232         Reviewed by Michael Catanzaro.
1233
1234         pytest already supports it by passing test.py::subtest, so we can do the same.
1235
1236         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1237         (get_item_name): Made this global.
1238         (CollectRecorder.__init__): Receive the parameter to ignore.
1239         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1240         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1241         (collect): Add parameter to ignore.
1242         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1243         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1244         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1245         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1246         (WebDriverTestRunnerSelenium.run): Ditto.
1247         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1248         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1249         (WebDriverTestRunnerW3C.run): Ditto.
1250
1251 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1252
1253         User agent string override for navigator.userAgent should be site specific quirks
1254         https://bugs.webkit.org/show_bug.cgi?id=193950
1255
1256         Reviewed by Brent Fulgham.
1257
1258         Updated per the _WKWebsitePolicies rename.
1259
1260         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1261         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1262
1263 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1264
1265         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1266         https://bugs.webkit.org/show_bug.cgi?id=193941
1267
1268         Reviewed by Alex Christensen.
1269
1270         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1271         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1272         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1273         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1274         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1275         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1276         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1277         * TestWebKitAPI/Tests/WTF/Time.cpp:
1278         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1279         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1280         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1281         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1282
1283 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1284
1285         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1286
1287         * Scripts/webkitpy/common/config/contributors.json:
1288
1289 2019-01-28  Andy Estes  <aestes@apple.com>
1290
1291         [watchOS] Enable Parental Controls content filtering
1292         https://bugs.webkit.org/show_bug.cgi?id=193939
1293         <rdar://problem/46641912>
1294
1295         Reviewed by Ryosuke Niwa.
1296
1297         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1298
1299 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1300
1301         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1302         <https://webkit.org/b/193884>
1303
1304         Reviewed by Jiewen Tan.
1305
1306         * Scripts/webkitpy/style/checkers/cpp.py:
1307         (check_language): Add LocalAuthentication to
1308         `frameworks_with_soft_links`.
1309
1310 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1311
1312         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1313         https://bugs.webkit.org/show_bug.cgi?id=193891
1314
1315         Reviewed by Ross Kirsling.
1316
1317         There were three problems in window sizes of WebView and the host window.
1318         1. The sizes of pixel image output were incorrect.
1319         2. The host window is going to appear after window.resize was invoked.
1320         3. window.resize resized only the host window, not WebView.
1321
1322         This change solves them with a following approach.
1323         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1324         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1325            as well as DumpRenderTree in order to match the client area and the window area.
1326         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1327         d. PlatformWebView::setWindowFrame changes both window sizes.
1328         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1329
1330         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1331         (WTR::PlatformWebView::PlatformWebView): Create the host window
1332         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1333         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1334         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1335
1336 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1337
1338         [ews-app] Add method to save Step data to database
1339         https://bugs.webkit.org/show_bug.cgi?id=193890
1340
1341         Reviewed by Lucas Forschler.
1342
1343         * BuildSlaveSupport/ews-app/ews/models/step.py:
1344         (Step.save_step): Method to save step data.
1345         (Step.update_step): Method to update step data.
1346         (Step.get_existing_step): Method to fetch existing step from database.
1347         (Step.is_valid_result): Method to validate valid step result.
1348
1349 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1350
1351         [ews-app] Add method to save Build data to database
1352         https://bugs.webkit.org/show_bug.cgi?id=193735
1353
1354         Reviewed by Lucas Forschler.
1355
1356         * BuildSlaveSupport/ews-app/ews/models/build.py:
1357         (Build.save_build): Method to save build information to database.
1358         (Build.get_existing_build): Method to fetch existing build from database.
1359         (Build.is_valid_result): Method to validate build result.
1360         * BuildSlaveSupport/ews-app/ews/common/util.py:
1361         (is_valid_int_id): Method to validate valid id.
1362
1363 2019-01-28  Chris Dumez  <cdumez@apple.com>
1364
1365         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1366         https://bugs.webkit.org/show_bug.cgi?id=193915
1367         <rdar://problem/47560907>
1368
1369         Reviewed by Alex Christensen.
1370
1371         Add API test coverage.
1372
1373         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1374
1375 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1376
1377         [ews-app] Rename id variables
1378         https://bugs.webkit.org/show_bug.cgi?id=193883
1379
1380         Reviewed by Lucas Forschler.
1381
1382         * BuildSlaveSupport/ews-app/ews/models/build.py:
1383         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1384         * BuildSlaveSupport/ews-app/ews/models/step.py:
1385         * BuildSlaveSupport/ews-app/ews/urls.py:
1386         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1387         * BuildSlaveSupport/ews-app/ews/views/results.py:
1388         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1389
1390 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1391
1392         [ews-app] Allow certain fields to be empty
1393         https://bugs.webkit.org/show_bug.cgi?id=193892
1394
1395         Reviewed by Lucas Forschler.
1396
1397         * BuildSlaveSupport/ews-app/ews/models/build.py:
1398         * BuildSlaveSupport/ews-app/ews/models/step.py:
1399
1400 2019-01-28  Rob Buis  <rbuis@igalia.com>
1401
1402         Update MIME type parser
1403         https://bugs.webkit.org/show_bug.cgi?id=180526
1404
1405         Reviewed by Frédéric Wang.
1406
1407         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1408         (TestWebKitAPI::TEST):
1409
1410 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1411
1412         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1413         https://bugs.webkit.org/show_bug.cgi?id=193896
1414
1415         Reviewed by Antti Koivisto.
1416
1417         * LayoutReloaded/misc/LFC-passing-tests.txt:
1418
1419 2018-12-15  Darin Adler  <darin@apple.com>
1420
1421         Replace many uses of String::format with more type-safe alternatives
1422         https://bugs.webkit.org/show_bug.cgi?id=192742
1423
1424         Reviewed by Mark Lam.
1425
1426         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1427         (WTR::cacheTestRunnerCallback): Use makeString.
1428         * WebKitTestRunner/TestController.cpp:
1429         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1430         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1431
1432 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1433
1434         Use a load optimizer for some sites
1435         https://bugs.webkit.org/show_bug.cgi?id=193881
1436         <rdar://problem/46325455>
1437
1438         Reviewed by Brent Fulgham.
1439
1440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1441         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1442
1443 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1444
1445         AX: Introduce a static accessibility tree
1446         https://bugs.webkit.org/show_bug.cgi?id=193348
1447         <rdar://problem/47203295>
1448
1449         Reviewed by Ryosuke Niwa.
1450
1451         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1452
1453 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1454
1455         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1456         https://bugs.webkit.org/show_bug.cgi?id=193867
1457
1458         Reviewed by Antti Koivisto.
1459
1460         * LayoutReloaded/misc/LFC-passing-tests.txt:
1461
1462 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1463
1464         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1465         https://bugs.webkit.org/show_bug.cgi?id=193865
1466
1467         Reviewed by Antti Koivisto.
1468
1469         * LayoutReloaded/misc/LFC-passing-tests.txt:
1470
1471 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1472
1473         Need a mechanism to override navigator.userAgent
1474         https://bugs.webkit.org/show_bug.cgi?id=193762
1475         <rdar://problem/47504939>
1476
1477         Reviewed by Brent Fulgham.
1478
1479         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1480
1481         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1482         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1483         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1484
1485 2019-01-25  Dean Jackson  <dino@apple.com>
1486
1487         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1488         https://bugs.webkit.org/show_bug.cgi?id=193831
1489         <rdar://problem/47399263>
1490
1491         Reviewed by Chris Dumez.
1492
1493         Two new tests that exercise cross-origin and same-origin System
1494         Previews.
1495
1496         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1497
1498 2019-01-25  Keith Rollin  <krollin@apple.com>
1499
1500         Update Xcode projects with "Check .xcfilelists" build phase
1501         https://bugs.webkit.org/show_bug.cgi?id=193790
1502         <rdar://problem/47201374>
1503
1504         Reviewed by Alex Christensen.
1505
1506         Support for XCBuild includes specifying inputs and outputs to various
1507         Run Script build phases. These inputs and outputs are specified as
1508         .xcfilelist files. Once created, these .xcfilelist files need to be
1509         kept up-to-date. In order to check that they are up-to-date or not,
1510         add an Xcode build step that invokes an external script that performs
1511         the checking. If the .xcfilelists are found to be out-of-date, update
1512         them, halt the build, and instruct the developer to restart the build
1513         with up-to-date files.
1514
1515         At this time, the checking and regenerating is performed only if the
1516         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1517         who want to use this facility can set this variable and test out the
1518         checking/regenerating. Once it seems like there are no egregious
1519         issues that upset a developer's workflow, we'll unconditionally enable
1520         this facility.
1521
1522         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1523         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1524         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1525         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1526
1527 2019-01-25  Keith Rollin  <krollin@apple.com>
1528
1529         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1530         https://bugs.webkit.org/show_bug.cgi?id=193781
1531         <rdar://problem/47201153>
1532
1533         Reviewed by Alex Christensen.
1534
1535         Part of generating the .xcfilelists used as part of adopting XCBuild
1536         includes running `make DerivedSources.make` from a standalone script.
1537         It’s important for this invocation to have the same environment as
1538         when the actual build invokes `make DerivedSources.make`. If the
1539         environments are different, then the two invocations will provide
1540         different results. In order to get the same environment in the
1541         standalone script, have the script launch xcodebuild targeting the
1542         "Apply Configuration to XCFileLists" build target, which will then
1543         re-invoke our standalone script. The script is now running again, this
1544         time in an environment with all workspace, project, target, xcconfig
1545         and other environment variables established.
1546
1547         The "Apply Configuration to XCFileLists" build target accomplishes
1548         this task via a small embedded shell script that consists only of:
1549
1550             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1551
1552         The process that invokes "Apply Configuration to XCFileLists" first
1553         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1554         evaluated and exports it into the shell environment. When xcodebuild
1555         is invoked, it inherits the value of this variable and can `eval` the
1556         contents of that variable. Our external standalone script can then set
1557         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1558         of command-line parameters needed to restart itself in the appropriate
1559         state.
1560
1561         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1562         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1563
1564 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1565
1566         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1567         https://bugs.webkit.org/show_bug.cgi?id=193802
1568         <rdar://problem/46010580>
1569
1570         Reviewed by Andy Estes.
1571
1572         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1573         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1574         (TEST):
1575
1576 2019-01-25  Daniel Bates  <dabates@apple.com>
1577
1578         [iOS] uiController.keyDown() does not translate Control modified key
1579         https://bugs.webkit.org/show_bug.cgi?id=192898
1580
1581         Reviewed by Wenson Hsieh.
1582
1583         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1584         key translation, as applicable. Among other cases, key translation occurs when performing
1585         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1586         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1587         human pressing down and releasing key(s) using a hardware keyboard.
1588
1589         * WebKitTestRunner/ios/HIDEventGenerator.h:
1590         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1591         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1592
1593         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1594         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1595         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1596         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1597         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1598         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1599         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1600         (-[HIDEventGenerator longPress:completionBlock:]):
1601         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1602         Update code for above renaming.
1603
1604         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1605         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1606
1607         (-[HIDEventGenerator keyDown:]): Added.
1608         (-[HIDEventGenerator keyUp:]): Added.
1609         (-[HIDEventGenerator keyPress:completionBlock:]):
1610         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1611         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1612         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1613         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1614         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1615         (WTR::parseModifier): Deleted.
1616
1617 2019-01-25  Keith Rollin  <krollin@apple.com>
1618
1619         Complete the implementation of generate-xcfilelists
1620         https://bugs.webkit.org/show_bug.cgi?id=193782
1621
1622         Reviewed by Alex Christensen.
1623
1624         A preliminary version of generate-xcfilelists was added in r238008.
1625         This patch updates that script in order to:
1626
1627         - Support checking of .xcfilelists
1628         - Perform better execution of `make DerivedSources.make` by
1629           relaunching generate-xcfilelists under xcodebuild
1630         - Support incremental generation and checking of .xcfilelists
1631         - Support supplementary .xcfilelists files from WebKitAdditions
1632         - Support being wrapped by parallel version of generate-xcfilelists in
1633           Internal that adds support for (re)generating WebKit projects in
1634           that repo.
1635         - Support builds that have been performed in WebKitBuild as well as
1636           ~/Library/Developer/code/DerivedData
1637         - Increase robustness and debugging facilities.
1638
1639         * Scripts/generate-xcfilelists:
1640
1641 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1642
1643         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1644         https://bugs.webkit.org/show_bug.cgi?id=193297
1645         <rdar://problem/47158841>
1646
1647         Unreviewed test case fix.
1648
1649         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1650         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1651
1652         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1653         (TEST):
1654
1655 2019-01-25  Keith Rollin  <krollin@apple.com>
1656
1657         Update existing .xcfilelists
1658         https://bugs.webkit.org/show_bug.cgi?id=193791
1659         <rdar://problem/47201706>
1660
1661         Reviewed by Alex Christensen.
1662
1663         Many .xcfilelist files were added in r238824 in order to support
1664         XCBuild. Update these with recent changes to the set of build files
1665         and with the current generate-xcfilelist script.
1666
1667         * DumpRenderTree/DerivedSources-input.xcfilelist:
1668         * DumpRenderTree/DerivedSources-output.xcfilelist:
1669         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1670         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1671
1672 2019-01-25  Keith Rollin  <krollin@apple.com>
1673
1674         Fix missing dependencies in extract-dependencies-from-makefile
1675         https://bugs.webkit.org/show_bug.cgi?id=193783
1676         <rdar://problem/47201571>
1677
1678         Reviewed by Alex Christensen.
1679
1680         The extract-dependencies-from-makefile script generates .xcfilelists
1681         for XCBuild by invoking a makefile in --debug mode, parsing the
1682         dependency information in the output, and extracting information
1683         regarding targets and dependents. However, the way `make` emits this
1684         dependency information is not rigorous, and so we need to determine
1685         what lines to look for and parse by trial and error. This approach
1686         didn't coriginally atch all the information we needed to collect, so
1687         update the script to look for the additional lines we now know to look
1688         for.
1689
1690         * Scripts/extract-dependencies-from-makefile:
1691         (Parser):
1692         (Parser.addTarget):
1693         (Parser.addPrereq):
1694         (Parser.doParse):
1695
1696 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1697
1698         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1699         https://bugs.webkit.org/show_bug.cgi?id=193297
1700         <rdar://problem/47158841>
1701
1702         Reviewed by Alex Christensen.
1703
1704         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1705             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1706         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1707         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1708         activating the message used to trigger the callback when it is set.
1709
1710 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1711
1712         WKWebView.goBack should reload if there is a safe browsing warning
1713         https://bugs.webkit.org/show_bug.cgi?id=193805
1714         <rdar://problem/46908216>
1715
1716         Reviewed by Geoff Garen.
1717
1718         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1719         (+[Simple3LookupContext sharedLookupContext]):
1720         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1721         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1722         (TEST):
1723
1724 2019-01-25  Chris Dumez  <cdumez@apple.com>
1725
1726         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1727         https://bugs.webkit.org/show_bug.cgi?id=193788
1728         <rdar://problem/47531231>
1729
1730         Reviewed by Alex Christensen.
1731
1732         Add API test coverage.
1733
1734         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1735         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1736
1737 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1738
1739         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1740         https://bugs.webkit.org/show_bug.cgi?id=193771
1741
1742         Unreviewed infrastructure fix.
1743
1744         * Scripts/webkitpy/port/darwin.py:
1745         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1746
1747 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1748
1749         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1750
1751 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1752
1753         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1754
1755         * Scripts/webkitpy/common/config/contributors.json:
1756
1757 2019-01-25  Chris Dumez  <cdumez@apple.com>
1758
1759         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1760         https://bugs.webkit.org/show_bug.cgi?id=193779
1761         <rdar://problem/46170903>
1762
1763         Reviewed by Antti Koivisto.
1764
1765         Add API test that quickly navigates forward to a previous process without waiting for it to
1766         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1767         the process' previous page when reconnecting the it for the forward navigation.
1768
1769         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1770
1771 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1772
1773         Need a way for JavaScript (or bundle) code to participate in undo
1774         https://bugs.webkit.org/show_bug.cgi?id=190009
1775         <rdar://problem/44807048>
1776
1777         Reviewed by Ryosuke Niwa.
1778
1779         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1780         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1781
1782         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1783         (WTR::UIScriptController::lastUndoLabel const):
1784         (WTR::UIScriptController::firstRedoLabel const):
1785         (WTR::UIScriptController::platformUndoManager const):
1786         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1787         (WTR::UIScriptController::lastUndoLabel const):
1788         (WTR::UIScriptController::firstRedoLabel const):
1789         (WTR::UIScriptController::platformUndoManager const):
1790         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1791         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1792         (WTR::UIScriptController::lastUndoLabel const):
1793         (WTR::UIScriptController::firstRedoLabel const):
1794         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1795         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1796         (WTR::UIScriptController::lastUndoLabel const):
1797         (WTR::UIScriptController::firstRedoLabel const):
1798         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1799         (WTR::UIScriptController::platformUndoManager const):
1800         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1801         (WTR::UIScriptController::platformUndoManager const):
1802
1803 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1804
1805         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1806         https://bugs.webkit.org/show_bug.cgi?id=193824
1807
1808         Reviewed by Antti Koivisto.
1809
1810         * LayoutReloaded/misc/LFC-passing-tests.txt:
1811
1812 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1813
1814         Update macOS JSC bot configurations
1815         https://bugs.webkit.org/show_bug.cgi?id=193739
1816
1817         Reviewed by Alexey Proskuryakov.
1818
1819         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1821         (BubbleQueueServer): Move JSC EWS to Mojave section.
1822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1823         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1824         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1825
1826 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1827
1828         [Win][WebKitTestRunner] Implement EventSenderProxy
1829         https://bugs.webkit.org/show_bug.cgi?id=193755
1830
1831         Reviewed by Don Olmstead.
1832
1833         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1834         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1835         (WTR::EventSenderProxy::dispatchMessage):
1836         (WTR::EventSenderProxy::EventSenderProxy):
1837         (WTR::EventSenderProxy::mouseDown):
1838         (WTR::EventSenderProxy::mouseUp):
1839         (WTR::EventSenderProxy::mouseMoveTo):
1840         (WTR::EventSenderProxy::mouseScrollBy):
1841         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1842
1843 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1844
1845         Unreviewed fix for API test failure after r240437.
1846
1847         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1848
1849         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1850
1851 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1852
1853         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1854         https://bugs.webkit.org/show_bug.cgi?id=193787
1855         <rdar://problem/47497634>
1856
1857         Reviewed by Alexey Proskuryakov.
1858
1859         * Scripts/webkitdirs.pm:
1860         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1861
1862 2019-01-24  Truitt Savell  <tsavell@apple.com>
1863
1864         Unreviewed, rolling out r240446.
1865
1866         Casued 5 API failures
1867
1868         Reverted changeset:
1869
1870         "Activate the WebResourceLoadStatisticsStore in the
1871         NetworkProcess and deactivate it in the UIProcess."
1872         https://bugs.webkit.org/show_bug.cgi?id=193297
1873         https://trac.webkit.org/changeset/240446
1874
1875 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1876
1877         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1878         https://bugs.webkit.org/show_bug.cgi?id=193741
1879         <rdar://problem/47135030>
1880
1881         Reviewed by Antti Koivisto and Simon Fraser.
1882
1883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1884         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1885         (TestWebKitAPI::TEST):
1886
1887 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1888
1889         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1890         https://bugs.webkit.org/show_bug.cgi?id=193297
1891         <rdar://problem/47158841>
1892
1893         Reviewed by Alex Christensen.
1894
1895         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1896         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1897         activating the message used to trigger the callback when it is set.
1898
1899 2019-01-24  John Wilander  <wilander@apple.com>
1900
1901         Add Ad Click Attribution as an internal/experimental feature
1902         https://bugs.webkit.org/show_bug.cgi?id=193685
1903         <rdar://problem/47450399>
1904
1905         Reviewed by Brent Fulgham.
1906
1907         Added test option adClickAttributionEnabled.
1908
1909         * DumpRenderTree/TestOptions.cpp:
1910         (TestOptions::TestOptions):
1911         * DumpRenderTree/TestOptions.h:
1912         * DumpRenderTree/mac/DumpRenderTree.mm:
1913         (setWebPreferencesForTestOptions):
1914
1915 2019-01-24  Antti Koivisto  <antti@apple.com>
1916
1917         [PSON] Flash on back navigation on Mac
1918         https://bugs.webkit.org/show_bug.cgi?id=193716
1919         <rdar://problem/47148458>
1920
1921         Reviewed by Chris Dumez.
1922
1923         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1924
1925         Closing of the previous page is delayed so waiting for didFinishNavigation is
1926         not sufficient to guarantee we have received all the messages. Wait for them.
1927
1928 2019-01-24  Chris Dumez  <cdumez@apple.com>
1929
1930         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1931         https://bugs.webkit.org/show_bug.cgi?id=193761
1932         <rdar://problem/47456405>
1933
1934         Reviewed by Alex Christensen.
1935
1936         Add API test coverage.
1937
1938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1939
1940 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1941
1942         webkitpy: Missing PID in crashlog name should not be fatal
1943         https://bugs.webkit.org/show_bug.cgi?id=193771
1944
1945         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1946         of raising an exception.
1947
1948         Reviewed by Lucas Forschler.
1949
1950         * Scripts/webkitpy/port/darwin.py:
1951         (DarwinPort._merge_crash_logs):
1952
1953 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1954
1955         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1956         https://bugs.webkit.org/show_bug.cgi?id=193746
1957
1958         Reviewed by Youenn Fablet.
1959
1960         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1961         so we'd best just not call it.
1962
1963         * Scripts/webkitpy/w3c/test_exporter.py:
1964         (WebPlatformTestExporter.create_branch_with_patch):
1965
1966 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1967
1968         Move FileSystem to WTF
1969         https://bugs.webkit.org/show_bug.cgi?id=193602
1970
1971         Reviewed by Yusuke Suzuki.
1972
1973         * DumpRenderTree/win/DumpRenderTree.cpp:
1974         * TestWebKitAPI/CMakeLists.txt:
1975         * TestWebKitAPI/PlatformGTK.cmake:
1976         * TestWebKitAPI/PlatformJSCOnly.cmake:
1977         * TestWebKitAPI/PlatformPlayStation.cmake:
1978         * TestWebKitAPI/PlatformWPE.cmake:
1979         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1980         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1981         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1982         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1983         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1984         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1985         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1986         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1987         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1988         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1989
1990 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1991
1992         [WPE] Remove hard dependency on subprocess32 for the API tests
1993
1994         Rubber-stamped by Carlos Garcia Campos.
1995
1996         * glib/api_test_runner.py:
1997         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1998         its presence only when running WPEQt tests.
1999
2000 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2001
2002         [GLIB] Expose JavaScriptCore options in GLib public API
2003         https://bugs.webkit.org/show_bug.cgi?id=188742
2004
2005         Reviewed by Michael Catanzaro.
2006
2007         Add a test for the new API.
2008
2009         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2010         (testsJSCOptions):
2011         (main):
2012
2013 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2014
2015         [GTK][WPE] Support JPEG 2000 images
2016         https://bugs.webkit.org/show_bug.cgi?id=186272
2017
2018         Reviewed by Žan Doberšek.
2019
2020         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2021
2022         * gtk/jhbuild.modules:
2023         * wpe/jhbuild.modules:
2024
2025 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2026
2027         check-webkit-style should warn when using soft-linking macros in a header
2028         <https://webkit.org/b/193750>
2029
2030         Reviewed by Darin Adler.
2031
2032         * Scripts/webkitpy/style/checkers/cpp.py:
2033         (check_language): Add softlink/header check by refactoring the
2034         softlink/framework check.
2035         (CppChecker): Enable softlink/header check by default.
2036         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2037         (CppStyleTest.test_softlink_framework): Rename from
2038         CppStyleTest.test_softlink() and change test framework name in
2039         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2040         files. Set file_name for macros that only appear in headers.
2041         (CppStyleTest.test_softlink_header): Add tests for using
2042         soft-link macros in headers.
2043
2044 2019-01-23  Chris Dumez  <cdumez@apple.com>
2045
2046         Deprecate API to limit the maximum number of WebProcesses
2047         https://bugs.webkit.org/show_bug.cgi?id=193725
2048         <rdar://problem/47464879>
2049
2050         Reviewed by Geoff Garen.
2051
2052         Update existing API tests to stop using deprecated API.
2053
2054         * MiniBrowser/mac/AppDelegate.m:
2055         (defaultConfiguration):
2056         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2057         (TestWebKitAPI::TEST):
2058         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2059         (TestWebKitAPI::TEST):
2060         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2061         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2062         (TEST):
2063         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2064         (TEST):
2065
2066 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2067
2068         [ews-app] Rename ews model buildermappings to buildermapping
2069         https://bugs.webkit.org/show_bug.cgi?id=193729
2070
2071         Reviewed by Lucas Forschler.
2072
2073         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2074         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2075         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2076
2077 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2078
2079         [ews-app] Rename ews model steps to step
2080         https://bugs.webkit.org/show_bug.cgi?id=193697
2081
2082         Reviewed by Lucas Forschler.
2083
2084         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2085         (Step): Renamed Steps to Step.
2086
2087 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2088
2089         Clean up IndexedDB files between tests
2090         https://bugs.webkit.org/show_bug.cgi?id=192796
2091         <rdar://problem/46824999>
2092
2093         Reviewed by Geoffrey Garen.
2094
2095         * DumpRenderTree/mac/DumpRenderTree.mm:
2096         (runTest):
2097         * WebKitTestRunner/TestController.cpp:
2098         (WTR::TestController::resetStateToConsistentValues):
2099         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2100         (WTR::RemoveAllIndexedDatabasesCallback):
2101         (WTR::TestController::ClearIndexedDatabases):
2102         * WebKitTestRunner/TestController.h:
2103         * WebKitTestRunner/TestInvocation.cpp:
2104         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2105
2106 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2107
2108         [ews-app] Rename ews model Builds to Build
2109         https://bugs.webkit.org/show_bug.cgi?id=193695
2110
2111         Reviewed by Lucas Forschler.
2112
2113         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2114         (Build): Renamed Builds to Build.
2115
2116 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2117
2118         webkitpy: Wait longer when launching WebKitTestRunner
2119         https://bugs.webkit.org/show_bug.cgi?id=193734
2120
2121         Reviewed by Aakash Jain.
2122
2123         * Scripts/webkitpy/port/simulator_process.py:
2124         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2125
2126 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2127
2128         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2129         https://bugs.webkit.org/show_bug.cgi?id=193182
2130         <rdar://problem/47452154>
2131
2132         Reviewed by Tim Horton.
2133
2134         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2135         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2136         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2137
2138         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2139         preventing later tests from recognizing gestures.
2140
2141         * WebKitTestRunner/ios/TestControllerIOS.mm:
2142         (WTR::TestController::platformResetStateToConsistentValues):
2143
2144         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2145
2146 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2147
2148         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2149         https://bugs.webkit.org/show_bug.cgi?id=193722
2150         <rdar://problem/47481475>
2151
2152         Reviewed by Lucas Forschler.
2153
2154         iPhone and iPad ports should both use the iOS config.
2155
2156         * Scripts/webkitpy/port/ios_simulator.py:
2157         (IPhoneSimulatorPort.__init__):
2158         (IPadSimulatorPort.__init__):
2159
2160 2019-01-23  Rob Buis  <rbuis@igalia.com>
2161
2162         Update MIME type parser
2163         https://bugs.webkit.org/show_bug.cgi?id=180526
2164
2165         Reviewed by Frédéric Wang.
2166
2167         Add unit tests for both parse modes of ParsedContentType.
2168
2169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2170         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2171         (TestWebKitAPI::TEST):
2172
2173 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2174
2175         [ews-app] fetch loop should not stop on network issues
2176         https://bugs.webkit.org/show_bug.cgi?id=193666
2177
2178         Reviewed by Lucas Forschler.
2179
2180         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2181         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2182
2183 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2184
2185         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2186         https://bugs.webkit.org/show_bug.cgi?id=189165
2187         <rdar://problem/47433765>
2188
2189         Reviewed by Tim Horton.
2190
2191         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2192         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2193         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2194         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2195         would make its way to the UI process by the time the layer tree commit is finished.
2196
2197         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2198         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2199         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2200         will fail because it asks for -_autofillContext too early.
2201
2202         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2203         is handled in the UI process.
2204
2205         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2206
2207         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2208         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2209         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2210         input session.
2211
2212         (-[AutofillTestView textInputHasAutofillContext]):
2213
2214         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2215
2216         * TestWebKitAPI/cocoa/TestWKWebView.h:
2217         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2218         (nextInputSessionChangeCount):
2219
2220         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2221         This includes changing the focused element from one to another.
2222
2223         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2224         (-[TestWKWebView didStartFormControlInteraction]):
2225         (-[TestWKWebView didEndFormControlInteraction]):
2226         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2227
2228         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2229         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2230         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2231         that doesn't require an input session to one that doesn't.
2232
2233 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2234
2235         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2236         <https://webkit.org/b/193676>
2237
2238         Reviewed by Alexey Proskuryakov.
2239
2240         * Scripts/webkitpy/style/checkers/cpp.py:
2241         (check_member_initialization_list):
2242         - Don't report missing whitespace around colon if the colon at
2243           the start of the line is formatted correctly.
2244         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2245         (WebKitStyleTest.test_member_initialization_list):
2246         - Add a test for a missing permutation of existing tests.
2247         - Add a test this false-positive.
2248         - Add blank lines between subtests to make them easier to read.
2249
2250 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2251
2252         [build.webkit.org] Unit-test failure after r237113
2253         https://bugs.webkit.org/show_bug.cgi?id=193669
2254
2255         Reviewed by Michael Catanzaro.
2256
2257         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2258         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2259         multiple or zero flags.
2260
2261 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2262
2263         Cache bytecode to disk
2264         https://bugs.webkit.org/show_bug.cgi?id=192782
2265         <rdar://problem/46084932>
2266
2267         Reviewed by Keith Miller.
2268
2269         Add test helper to execute bytecode-cache tests: it executes each test
2270         twice, the first with JSC_diskCachePath set to a temporary directory
2271         and second with JSC_forceDiskCache=true (in addition to the cache path)
2272         to guarantee that only the disk cache is being used and no new
2273         UnlinkedCodeBlocks are being created.
2274
2275         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2276         * Scripts/run-jsc-stress-tests:
2277
2278 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2279
2280         [css-logical] Implement flow-relative margin, padding and border shorthands
2281         https://bugs.webkit.org/show_bug.cgi?id=188697
2282
2283         Reviewed by Simon Fraser and Antti Koivisto.
2284
2285         * DumpRenderTree/TestOptions.cpp:
2286         (TestOptions::TestOptions):
2287         * DumpRenderTree/TestOptions.h:
2288         * DumpRenderTree/mac/DumpRenderTree.mm:
2289         (setWebPreferencesForTestOptions):
2290         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2291
2292         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2293         (JSONCSSPropertiesChecker.check_codegen_properties):
2294         Allow CSS property definitions to have a 'runtime-flag' parameter which
2295         disables the property when the specified runtime flag is disabled.
2296
2297 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2298
2299         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2300         https://bugs.webkit.org/show_bug.cgi?id=193643
2301
2302         Reviewed by Michael Catanzaro.
2303
2304         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2305         * wpe/jhbuild.modules: Ditto.
2306
2307 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2308
2309         [LFC][Floats] Take float top position into account when computing containing block height.
2310         https://bugs.webkit.org/show_bug.cgi?id=193655
2311
2312         Reviewed by Antti Koivisto.
2313
2314         * LayoutReloaded/misc/LFC-passing-tests.txt:
2315
2316 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2317
2318         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2319         <https://webkit.org/b/193645>
2320         <rdar://problem/47421574>
2321
2322         Reviewed by Alex Christensen.
2323
2324         - Now checks for local soft-linking of all frameworks that have
2325           their own *SoftLinking.{cpp,h,mm} files.
2326         - Changes softlink/uikit warning to softlink/framework.
2327
2328         * Scripts/webkitpy/style/checkers/cpp.py:
2329         (check_language):
2330         (CppChecker):
2331         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2332         (CppStyleTest):
2333
2334 2019-01-20  Saam Barati  <sbarati@apple.com>
2335
2336         Rollout r240210: It broke tests on iOS
2337         https://bugs.webkit.org/show_bug.cgi?id=193640
2338
2339         Unreviewed.
2340
2341         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2342         * Scripts/run-jsc-stress-tests:
2343
2344 2019-01-20  chris fleizach  <cfleizach@apple.com>
2345
2346         AX: Support returning relative frames for accessibility
2347         https://bugs.webkit.org/show_bug.cgi?id=193414
2348         <rdar://problem/47268501>
2349
2350         Reviewed by Zalan Bujtas.
2351
2352         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2353         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2354         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2355         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2356         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2357         (WTR::attributesOfElement):
2358         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2359
2360 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2361
2362         Unreviewed, add my new email address
2363
2364         * Scripts/webkitpy/common/config/contributors.json:
2365
2366 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2367
2368         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2369         https://bugs.webkit.org/show_bug.cgi?id=193617
2370
2371         Reviewed by Antti Koivisto.
2372
2373         * LayoutReloaded/misc/LFC-passing-tests.txt:
2374
2375 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2376
2377         Unreviewed, rolling out r240209.
2378
2379         Broke GTK/WPE injected bundle
2380
2381         Reverted changeset:
2382
2383         "AX: Support returning relative frames for accessibility"
2384         https://bugs.webkit.org/show_bug.cgi?id=193414
2385         https://trac.webkit.org/changeset/240209
2386
2387 2019-01-12  Dan Bernstein  <mitz@apple.com>
2388
2389         [Cocoa] Avoid importing directly from subumbrella frameworks
2390         https://bugs.webkit.org/show_bug.cgi?id=186016
2391         <rdar://problem/40591038>
2392
2393         Reviewed by Sam Weinig.
2394
2395         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2396           LaunchServices header.
2397         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2398           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2399         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2400           when using SDKs earlier than 10.13.
2401         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2402           and OTHER_CPLUSPLUSFLAGS.
2403         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2404           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2405         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2406           LaunchServices header.
2407
2408 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2409
2410         Cache bytecode to disk
2411         https://bugs.webkit.org/show_bug.cgi?id=192782
2412         <rdar://problem/46084932>
2413
2414         Reviewed by Keith Miller.
2415
2416         Add test helper to execute bytecode-cache tests: it executes each test
2417         twice, the first with JSC_diskCachePath set to a temporary directory
2418         and second with JSC_forceDiskCache=true (in addition to the cache path)
2419         to guarantee that only the disk cache is being used and no new
2420         UnlinkedCodeBlocks are being created.
2421
2422         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2423         * Scripts/run-jsc-stress-tests:
2424
2425 2019-01-20  chris fleizach  <cfleizach@apple.com>
2426
2427         AX: Support returning relative frames for accessibility
2428         https://bugs.webkit.org/show_bug.cgi?id=193414
2429         <rdar://problem/47268501>
2430
2431         Reviewed by Zalan Bujtas.
2432
2433         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2434         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2435         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2436         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2437         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2438         (WTR::attributesOfElement):
2439         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2440
2441 2019-01-20  Antoine Quint  <graouts@apple.com>
2442
2443         Add a POINTER_EVENTS feature flag
2444         https://bugs.webkit.org/show_bug.cgi?id=193577
2445         <rdar://problem/47408511>
2446
2447         Unreviewed. Also enable Pointer Events for iosmac.
2448
2449         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2450
2451 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2452
2453         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2454         https://bugs.webkit.org/show_bug.cgi?id=193613
2455
2456         Reviewed by Antti Koivisto.
2457
2458         * LayoutReloaded/misc/LFC-passing-tests.txt:
2459
2460 2019-01-19  Antoine Quint  <graouts@apple.com>
2461
2462         Add a POINTER_EVENTS feature flag
2463         https://bugs.webkit.org/show_bug.cgi?id=193577
2464
2465         Reviewed by Dean Jackson.
2466
2467         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2468
2469 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2470
2471         Disable the run-jsc-stress-test remote host key check [second round].
2472         https://bugs.webkit.org/show_bug.cgi?id=192988
2473
2474         Reviewed by Dewei Zhu.
2475
2476         * Scripts/run-jsc-stress-tests:
2477
2478 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2479
2480         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2481         https://bugs.webkit.org/show_bug.cgi?id=193597
2482
2483         Reviewed by Lucas Forschler.
2484
2485         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2486
2487 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2488
2489         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2490         https://bugs.webkit.org/show_bug.cgi?id=193595
2491
2492         Reviewed by Lucas Forschler.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2495         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2496         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2497
2498 2019-01-18  Chris Dumez  <cdumez@apple.com>
2499
2500         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2501         https://bugs.webkit.org/show_bug.cgi?id=193588
2502         <rdar://problem/47131566>
2503
2504         Reviewed by Alex Christensen.
2505
2506         Add layout test coverage.
2507
2508         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2509
2510 2019-01-18  Jer Noble  <jer.noble@apple.com>
2511
2512         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2513         https://bugs.webkit.org/show_bug.cgi?id=189553
2514
2515         Reviewed by Tim Horton.
2516
2517         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2518
2519         * ContentExtensionTester/Configurations/Base.xcconfig:
2520         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2521         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2522         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2523         * ImageDiff/cg/Configurations/Base.xcconfig:
2524         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2525         * MiniBrowser/Configurations/Base.xcconfig:
2526         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2527         * MobileMiniBrowser/Configurations/Base.xcconfig:
2528         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2529         * Scripts/webkitpy/style/checker.py:
2530         (_all_categories):
2531         (FileType):
2532         (CheckerDispatcher._file_type):
2533         (CheckerDispatcher._create_checker):
2534         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2535         (SDKVariantChecker):
2536         (SDKVariantChecker.__init__):
2537         (SDKVariantChecker.check):
2538         * TestWebKitAPI/Configurations/Base.xcconfig:
2539         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2540         * WebEditingTester/Configurations/Base.xcconfig:
2541         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2542         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2543         * WebKitTestRunner/Configurations/Base.xcconfig:
2544         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2545         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2546         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2547
2548 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2549
2550         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2551         <https://webkit.org/b/193568>
2552         <rdar://problem/47381130>
2553
2554         Reviewed by Alex Christensen.
2555
2556         Make sure no one re-introduces UIKit soft-linking by adding a
2557         style rule.
2558
2559         * Scripts/webkitpy/style/checkers/cpp.py:
2560         (check_language): Add softlink/uikit check.
2561         (CppChecker): Enable softlink/uikit check.
2562         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2563         (CppStyleTest): Add test for softlink/uikit.
2564
2565 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2566
2567         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2568         https://bugs.webkit.org/show_bug.cgi?id=193584
2569
2570         Change "-dev" to "-devel".
2571
2572         Reviewed by Michael Catanzaro.
2573
2574         * gtk/install-dependencies:
2575
2576 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2577
2578         webkitpy: Add iPhone and iPad ports
2579         https://bugs.webkit.org/show_bug.cgi?id=193537
2580         <rdar://problem/47353390>
2581
2582         Reviewed by Lucas Forschler.
2583
2584         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2585         ports. Note that this separation is optional, the --ios-simulator command remains.
2586
2587         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2588         (RunTest.test_device_type_test_division): Drive-by fix.
2589         (RunTest.test_device_type_specific_listing): Ditto.
2590         (RunTest.test_ipad_test_division):
2591         (RunTest):
2592         (RunTest.test_ipad_listing):
2593         * Scripts/webkitpy/port/factory.py:
2594         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2595         (PortFactory):
2596         * Scripts/webkitpy/port/ios_simulator.py:
2597         (IPhoneSimulatorPort):
2598         (IPadSimulatorPort):
2599
2600 2019-01-18  Chris Dumez  <cdumez@apple.com>
2601
2602         Regression(PSON) Scroll position is not always restored properly when navigating back
2603         https://bugs.webkit.org/show_bug.cgi?id=193578
2604         <rdar://problem/47386331>
2605
2606         Reviewed by Tim Horton.
2607
2608         Add API test coverage.
2609
2610         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2611
2612 2019-01-18  Youenn Fablet  <youenn@apple.com>
2613
2614         Add a new SPI to request for cache storage quota increase
2615         https://bugs.webkit.org/show_bug.cgi?id=193323
2616
2617         Reviewed by Alex Christensen.
2618
2619         Implement WebsiteDataStore quota delegate to handle quota requests.
2620         By default, do not update quota.
2621         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2622
2623         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2624         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2625         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2626         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2627         * WebKitTestRunner/TestController.cpp:
2628         (WTR::TestController::allowCacheStorageQuotaIncrease):
2629         * WebKitTestRunner/TestController.h:
2630         * WebKitTestRunner/TestInvocation.cpp:
2631         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2632         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2633         (-[CacheStorageQuotaManager init]):
2634         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2635         (WTR::initializeWebViewConfiguration):
2636         (WTR::TestController::cocoaResetStateToConsistentValues):
2637         (WTR::TestController::allowCacheStorageQuotaIncrease):
2638
2639 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2640
2641         [ews-build] Pass owner to the triggered builds
2642         https://bugs.webkit.org/show_bug.cgi?id=193574
2643
2644         Reviewed by Lucas Forschler.
2645
2646         * BuildSlaveSupport/ews-build/factories.py:
2647         (BuildFactory.propertiesToPassToTriggers):
2648
2649 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2650
2651         [ews-app] Send patch author as a build property
2652         https://bugs.webkit.org/show_bug.cgi?id=193560
2653
2654         Reviewed by Lucas Forschler.
2655
2656         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2657         (BugzillaPatchFetcher.fetch):
2658
2659 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2660
2661         webkitpy: Implement device type specific expected results (Follow-up fix)
2662         https://bugs.webkit.org/show_bug.cgi?id=192162
2663         <rdar://problem/46345449>
2664
2665         Unreviewed infrastructure fix.
2666
2667         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2668         (Manager.run): Don't boot a device if no tests are available to run on it.
2669
2670 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2671
2672         webkitpy: Implement device type specific expected results (Follow-up fix)
2673         https://bugs.webkit.org/show_bug.cgi?id=192162
2674         <rdar://problem/46345449>
2675
2676         Unreviewed infrastructure fix.
2677
2678         * Scripts/webkitpy/api_tests/manager.py:
2679         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2680
2681 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2682
2683         webkitpy: Implement device type specific expected results (Part 2)
2684         https://bugs.webkit.org/show_bug.cgi?id=192162
2685         <rdar://problem/46345449>
2686
2687         Rubber-stamped by Aakash Jain.
2688
2689         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2690         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2691         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2692
2693         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2694         (LayoutTestFinder.find_tests): Pass device_type through.
2695         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2696         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2697         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2698         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2699         (Manager._collect_tests): Pass device type to test finder.
2700         (Manager._needs_web_platform_test):
2701         (Manager._prepare_lists): Index _expectations by device type.
2702         (Manager._test_input_for_file):
2703         (Manager._test_is_slow): Ditto.
2704         (Manager._test_should_dump_jsconsolelog_in_stderr):
2705         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2706         (Manager._get_test_inputs):
2707         (Manager._update_worker_count):
2708         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2709         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2710         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2711         the one which runs the test.
2712         (Manager._run_test_subset):
2713         (Manager._run_tests): Index _expectations by current_device_type.
2714         (Manager._print_expectation_line_for_test): Ditto.
2715         (Manager._print_expectations_for_subset): Ditto.
2716         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2717         Unlike run, this function will behave the same regardless of what devices are available.
2718         (Manager._custom_device_for_test): Deleted.
2719         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2720         (ManagerTest.test_uses_custom_device): Deleted.
2721         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2722         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2723         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2724         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2725         all of the expectations.
2726         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2727         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2728         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2729         (TestExpectations.__init__): Allow device_type to be passed through.
2730         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2731         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2732         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2733         (summarize_results):
2734         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2735         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2736         a test ran with, one must check all expectations to find the first non-skip expectation.
2737         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2738         (RunTest.test_device_type_test_division):
2739         (RunTest):
2740         (RunTest.test_device_type_specific_listing):
2741         * Scripts/webkitpy/port/base.py:
2742         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2743         (Port.supported_device_types): The result of this function will change based on what devices are available.
2744         * Scripts/webkitpy/port/device_port.py:
2745         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2746         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2747         can be used.
2748         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2749         any, or the DEFAULT_DEVICE_TYPES of the port.
2750         * Scripts/webkitpy/port/ios.py:
2751         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2752         * Scripts/webkitpy/port/ios_simulator.py:
2753         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2754         * Scripts/webkitpy/port/watch.py:
2755         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2756         * Scripts/webkitpy/port/watch_simulator.py:
2757         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2758         * Scripts/webkitpy/xcode/device_type.py:
2759         (DeviceType):
2760         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2761
2762 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2763
2764         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2765         https://bugs.webkit.org/show_bug.cgi?id=193575
2766
2767         Reviewed by Michael Catanzaro.
2768
2769         Allow the script to run without explicit port argument because
2770         it's specific to the WPE port anyway.
2771
2772         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2773         and simplify the rest of the code accordingly.
2774
2775 2019-01-18  Charlie Turner  <cturner@igalia.com>
2776
2777         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2778         https://bugs.webkit.org/show_bug.cgi?id=192229
2779
2780         Reviewed by Xabier Rodriguez-Calvar.
2781
2782         * MiniBrowser/wpe/main.cpp:
2783         (main): Enable encrypted-media by default.
2784
2785 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2786
2787         [Flatpak] Missing KeyboardInterrupt exception handler
2788         https://bugs.webkit.org/show_bug.cgi?id=193570
2789
2790         Reviewed by Michael Catanzaro.
2791
2792         * flatpak/flatpakutils.py:
2793         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2794
2795 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2796
2797         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2798         https://bugs.webkit.org/show_bug.cgi?id=193564
2799
2800         Reviewed by Antti Koivisto.
2801
2802         * LayoutReloaded/misc/LFC-passing-tests.txt:
2803
2804 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2805
2806         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2807         https://bugs.webkit.org/show_bug.cgi?id=193562
2808
2809         Reviewed by Antti Koivisto.
2810
2811         * LayoutReloaded/misc/LFC-passing-tests.txt:
2812
2813 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2814
2815         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2816         https://bugs.webkit.org/show_bug.cgi?id=193555
2817
2818         Reviewed by Antti Koivisto.
2819
2820         * LayoutReloaded/misc/LFC-passing-tests.txt:
2821
2822 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2823
2824         [WPE] Add Qt extension
2825         https://bugs.webkit.org/show_bug.cgi?id=191464
2826
2827         Reviewed by Carlos Garcia Campos.
2828
2829         MiniBrowser and API tests for the WPE Qt API. To run the
2830         MiniBrowser a new script is introduced. Example invocation:
2831
2832         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2833
2834         Also note-worthy is the introduction of the python2-subprocess32
2835         dependency to run the GLib API tests.
2836
2837         * MiniBrowser/wpe/CMakeLists.txt:
2838         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2839         * MiniBrowser/wpe/qt/main.cpp: Added.
2840         (main):
2841         * MiniBrowser/wpe/qt/main.qml: Added.
2842         * MiniBrowser/wpe/qt/qml.qrc: Added.
2843         * Scripts/run-gtk-tests:
2844         (GtkTestRunner.is_google_test):
2845         (GtkTestRunner):
2846         (GtkTestRunner.is_qt_test):
2847         * Scripts/run-qt-wpe-minibrowser: Added.
2848         * Scripts/run-wpe-tests:
2849         (WPETestRunner):
2850         (WPETestRunner.is_google_test):
2851         (WPETestRunner.is_qt_test):
2852         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2853         (TestLoad::main):
2854         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2855         (TestLoadHtml::main):
2856         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2857         (TestLoadRequest::main):
2858         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2859         (TestRunJavaScript::main):
2860         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2861         (waitForSignal):
2862         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2863         (LoadSpy::LoadSpy):
2864         (LoadSpy::~LoadSpy):
2865         (LoadSpy::onLoadingChanged):
2866         (LoadStartedCatcher::LoadStartedCatcher):
2867         (LoadStartedCatcher::~LoadStartedCatcher):
2868         (LoadStartedCatcher::onLoadingChanged):
2869         (waitForLoadSucceeded):
2870         (waitForLoadFailed):
2871         * TestWebKitAPI/glib/CMakeLists.txt:
2872         * flatpak/flatpakutils.py:
2873         (WebkitFlatpak.load_from_args):
2874         (WebkitFlatpak.__init__):
2875         (WebkitFlatpak.clean_args):
2876         (WebkitFlatpak.run_in_sandbox):
2877         * flatpak/org.webkit.CommonModules.yaml:
2878         * flatpak/org.webkit.WPE.yaml:
2879         * flatpak/org.webkit.WPEModules.yaml:
2880         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2881         * flatpak/org.webkit.WebKit.yaml:
2882         * glib/api_test_runner.py:
2883         (TestRunner._run_test_qt):
2884         (TestRunner.is_qt_test):
2885         (TestRunner._run_test):
2886
2887 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2888
2889         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2890         https://bugs.webkit.org/show_bug.cgi?id=193494
2891         <rdar://problem/46859627>
2892
2893         Reviewed by Simon Fraser and Tim Horton.
2894
2895         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2896         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2897
2898         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2899         (WTR::UIScriptController::contentOffsetX const):
2900         (WTR::UIScriptController::contentOffsetY const):
2901         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2902         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2903         (WTR::UIScriptController::contentOffsetX const):
2904         (WTR::UIScriptController::contentOffsetY const):
2905         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2906
2907         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2908
2909         * WebKitTestRunner/TestController.cpp:
2910         (WTR::updateTestOptionsFromTestHeader):
2911         * WebKitTestRunner/TestOptions.h:
2912         (WTR::TestOptions::hasSameInitializationOptions const):
2913         * WebKitTestRunner/ios/TestControllerIOS.mm:
2914         (WTR::TestController::platformResetStateToConsistentValues):
2915         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2916         (WTR::UIScriptController::contentOffsetX const):
2917         (WTR::UIScriptController::contentOffsetY const):
2918
2919 2019-01-17  Truitt Savell  <tsavell@apple.com>
2920
2921         Unreviewed, rolling out r240124.
2922
2923         This commit broke an internal build.
2924
2925         Reverted changeset:
2926
2927         "SDK_VARIANT build destinations should be separate from non-
2928         SDK_VARIANT builds"
2929         https://bugs.webkit.org/show_bug.cgi?id=189553
2930         https://trac.webkit.org/changeset/240124
2931
2932 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2933
2934         Fix string concatenation API test after r239920
2935         https://bugs.webkit.org/show_bug.cgi?id=193551
2936         <rdar://problem/47359304>
2937
2938         Reviewed by Youenn Fablet.
2939
2940         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2941         (TestWebKitAPI::TEST):
2942         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2943         in WebKit's build configuration like it apparently is on Linux.
2944
2945 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2946
2947         [ews-build] validate-patch should handle the case when bug_id is None
2948         https://bugs.webkit.org/show_bug.cgi?id=193547
2949
2950         Reviewed by Lucas Forschler.
2951
2952         * BuildSlaveSupport/ews-build/steps.py:
2953         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2954         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2955
2956 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2957
2958         [ews-build] Add patch author information in build
2959         https://bugs.webkit.org/show_bug.cgi?id=193465
2960
2961         Reviewed by Lucas Forschler.
2962
2963         * BuildSlaveSupport/ews-build/steps.py:
2964         (ValidatePatch._is_patch_obsolete):
2965
2966 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2967
2968         [ews-build] Pass bug_id to the triggered builds
2969         https://bugs.webkit.org/show_bug.cgi?id=193548
2970
2971         Reviewed by Lucas Forschler.
2972
2973         * BuildSlaveSupport/ews-build/factories.py:
2974         (BuildFactory.propertiesToPassToTriggers):
2975
2976 2019-01-17  Jer Noble  <jer.noble@apple.com>
2977
2978         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2979         https://bugs.webkit.org/show_bug.cgi?id=189553
2980
2981         Reviewed by Tim Horton.
2982
2983         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2984
2985         * ContentExtensionTester/Configurations/Base.xcconfig:
2986         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2987         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2988         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2989         * ImageDiff/cg/Configurations/Base.xcconfig:
2990         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2991         * MiniBrowser/Configurations/Base.xcconfig:
2992         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2993         * MobileMiniBrowser/Configurations/Base.xcconfig:
2994         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2995         * Scripts/webkitpy/style/checker.py:
2996         (_all_categories):
2997         (FileType):
2998         (CheckerDispatcher._file_type):
2999         (CheckerDispatcher._create_checker):
3000         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3001         (SDKVariantChecker):
3002         (SDKVariantChecker.__init__):
3003         (SDKVariantChecker.check):
3004         * TestWebKitAPI/Configurations/Base.xcconfig:
3005         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3006         * WebEditingTester/Configurations/Base.xcconfig:
3007         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3008         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3009         * WebKitTestRunner/Configurations/Base.xcconfig:
3010         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3011         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3012         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3013
3014 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3015
3016         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3017         https://bugs.webkit.org/show_bug.cgi?id=193534
3018
3019         Reviewed by Antti Koivisto.
3020
3021         * LayoutReloaded/misc/LFC-passing-tests.txt:
3022
3023 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3024
3025         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3026         https://bugs.webkit.org/show_bug.cgi?id=193528
3027
3028         Reviewed by Antti Koivisto.
3029
3030         * LayoutReloaded/misc/LFC-passing-tests.txt:
3031
3032 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3033
3034         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3035         https://bugs.webkit.org/show_bug.cgi?id=193520
3036
3037         Reviewed by Antti Koivisto.
3038
3039         * LayoutReloaded/misc/LFC-passing-tests.txt:
3040
3041 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3042
3043         [ews-build] unapply-patch step should not update source
3044         https://bugs.webkit.org/show_bug.cgi?id=193234
3045
3046         Reviewed by Lucas Forschler.
3047
3048         * BuildSlaveSupport/ews-build/steps.py:
3049         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3050         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3051
3052 2019-01-16  Youenn Fablet  <youenn@apple.com>
3053
3054         Add a new SPI for controlling getUserMedia
3055         https://bugs.webkit.org/show_bug.cgi?id=192793
3056
3057         Reviewed by Eric Carlson.
3058
3059         * MiniBrowser/mac/WK2BrowserWindowController.m:
3060         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3061         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3062         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3063         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3064         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3065         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3066         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3067         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3068         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3069         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3070         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3071         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3072         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3073         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3074
3075 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3076
3077         [LFC][BFC] Inflow non-replaced used width should not be negative.
3078         https://bugs.webkit.org/show_bug.cgi?id=193495
3079
3080         Reviewed by Antti Koivisto.
3081
3082         * LayoutReloaded/misc/LFC-passing-tests.txt:
3083
3084 2019-01-16  Chris Dumez  <cdumez@apple.com>
3085
3086         Regression(PSON) View becomes blank after click a cross-site download link
3087         https://bugs.webkit.org/show_bug.cgi?id=193361
3088         <rdar://problem/47099573>
3089
3090         Reviewed by Geoffrey Garen.
3091
3092         Add API test coverage.
3093
3094         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3095         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3096
3097 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3098
3099         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3100         https://bugs.webkit.org/show_bug.cgi?id=193470
3101
3102         Reviewed by Antti Koivisto.
3103
3104         * LayoutReloaded/misc/LFC-passing-tests.txt:
3105
3106 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3107
3108         [LFC] Adjust margin box verification.
3109         https://bugs.webkit.org/show_bug.cgi?id=193482
3110
3111         Reviewed by Antti Koivisto.
3112
3113         * LayoutReloaded/misc/LFC-passing-tests.txt:
3114
3115 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3116
3117         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3118         https://bugs.webkit.org/show_bug.cgi?id=193451
3119
3120         Reviewed by Geoffrey Garen.
3121
3122         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3123         (TEST):
3124         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3125         (runWebsiteDataStoreCustomPaths):
3126
3127 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3128
3129         webkitpy: Support boolean simctl isAvailable
3130         https://bugs.webkit.org/show_bug.cgi?id=193472
3131         <rdar://problem/47296150>
3132
3133         Reviewed by Ryosuke Niwa.
3134
3135         * Scripts/webkitpy/xcode/simulated_device.py:
3136         (SimulatedDeviceManager._create_runtimes):
3137         (SimulatedDeviceManager._create_device_with_runtime):
3138
3139 2019-01-15  Chris Dumez  <cdumez@apple.com>
3140
3141         Unreviewed, rolling out r239993, r239995, r239997, and
3142         r239999.
3143
3144         Caused assertions under
3145         ViewGestureController::disconnectFromProcess()
3146
3147         Reverted changesets:
3148
3149         "Regression(PSON) View becomes blank after click a cross-site
3150         download link"
3151         https://bugs.webkit.org/show_bug.cgi?id=193361
3152         https://trac.webkit.org/changeset/239993
3153
3154         "Unreviewed iOS build fix after r239993."
3155         https://trac.webkit.org/changeset/239995
3156
3157         "Fix iOS build after r239993"
3158         https://bugs.webkit.org/show_bug.cgi?id=193361
3159         https://trac.webkit.org/changeset/239997
3160
3161         "Unreviewed, revert part of r239997 as it is not needed to fix
3162         the build."
3163         https://trac.webkit.org/changeset/239999
3164
3165 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3166
3167         Cannot tab out of WKWebView on macOS
3168         https://bugs.webkit.org/show_bug.cgi?id=161448
3169         <rdar://problem/28100085>
3170
3171         Reviewed by Dean Jackson.
3172
3173         Add a test that tabbing into and out of WKWebView works correctly.
3174
3175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3176         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3177         (WebKit2_CommandBackForwardTest::SetUp):
3178         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3179         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3180         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3181         (-[FocusableView canBecomeKeyView]):
3182         (TEST):
3183         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3184         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3185         (-[OffscreenWindow initWithSize:]):
3186         (-[OffscreenWindow isKeyWindow]):
3187         (-[OffscreenWindow isVisible]):
3188         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3189         (TestWebKitAPI::PlatformWebView::initialize):
3190         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3191         (-[ActiveOffscreenWindow isVisible]): Deleted.
3192         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3193
3194 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3195
3196         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3197         https://bugs.webkit.org/show_bug.cgi?id=193459
3198
3199         Reviewed by Mark Lam.
3200
3201         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3202         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3203
3204 2019-01-15  Chris Dumez  <cdumez@apple.com>
3205
3206         Regression(PSON) View becomes blank after click a cross-site download link
3207         https://bugs.webkit.org/show_bug.cgi?id=193361
3208         <rdar://problem/47099573>
3209
3210         Reviewed by Geoff Garen.
3211
3212         Add API test coverage.
3213
3214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3215         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3216
3217 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3218
3219         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3220         https://bugs.webkit.org/show_bug.cgi?id=193448
3221
3222         Reviewed by Antti Koivisto.
3223
3224         * LayoutReloaded/misc/LFC-passing-tests.txt:
3225
3226 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3227
3228         webkitpy: Implement device type specific expected results (Part 1)
3229         https://bugs.webkit.org/show_bug.cgi?id=192162
3230
3231         Reviewed by Lucas Forschler.
3232
3233         Device type specific expected results covers two related ideas. The first (covered by this change)
3234         is where to search for -expected.* files. The second is which tests to run based on the
3235         TestExpectations.txt file.
3236
3237         After this change, the baseline search path will be determined by the type of device running a
3238         test. Device type will be passed into any function which picks a file based on the baseline search
3239         path.
3240
3241         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3242         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3243         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3244         (Manager.run): Print baseline search path for each round of devices.
3245         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3246         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3247         (SingleTestRunner._expected_driver_output): Ditto.
3248         (SingleTestRunner._driver_input): Ditto.
3249         * Scripts/webkitpy/layout_tests/views/printing.py:
3250         (Printer.print_config): Move printing of baseline search path to a separate function.
3251         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3252         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3253         (Testprinter.test_print_config):
3254         (Testprinter.test_print_baseline_search_path):
3255         * Scripts/webkitpy/port/base.py:
3256         (Port.baseline_search_path): Pass device_type through.
3257         (Port._expected_baselines_for_suffixes): Ditto.
3258         (Port.expected_baselines): Ditto.
3259         (Port.expected_filename): Ditto.
3260         (Port.expected_checksum): Ditto.
3261         (Port.expected_image): Ditto.
3262         (Port.expected_audio): Ditto.
3263         (Port.expected_text): Ditto.
3264         (Port.reference_files): Ditto.
3265         (Port.tests): Ditto.
3266         (Port._expanded_paths): Ditto.
3267         (Port.skipped_layout_tests): Ditto.
3268         (Port.expectations_dict): Ditto.
3269         (Port._port_specific_expectations_files): Ditto.
3270         (Port.expectations_files): Ditto.
3271         (Port.test_search_path): Ditto.
3272         (Port._tests_for_other_platforms): Ditto.
3273         * Scripts/webkitpy/port/base_unittest.py:
3274         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3275         (PortTest.test_nonexistant_expectations): Ditto.
3276         (test_ref_tests_platform_directory): Ditto.
3277         * Scripts/webkitpy/port/darwin.py:
3278         (DarwinPort._port_specific_expectations_files): Accept device_type.
3279         * Scripts/webkitpy/port/driver.py:
3280         (DriverProxy):
3281         (DriverProxy.host): Expose _target_host for device_type information.
3282         * Scripts/webkitpy/port/gtk.py:
3283         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3284         * Scripts/webkitpy/port/ios.py:
3285         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3286         * Scripts/webkitpy/port/mac.py:
3287         (MacPort. default_baseline_search_path): Ditto.
3288         * Scripts/webkitpy/port/port_testcase.py:
3289         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3290         * Scripts/webkitpy/port/test.py:
3291         * Scripts/webkitpy/port/watch.py:
3292         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3293         * Scripts/webkitpy/port/win.py:
3294         (WinPort.test_search_path): Accept, but do not use, device_type.
3295         * Scripts/webkitpy/port/wpe.py:
3296         (WPEPort._port_specific_expectations_files): Ditto.
3297         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3298         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3299
3300 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3301
3302         [LFC] Use the containing block's padding box to position out-of-flow elements.
3303         https://bugs.webkit.org/show_bug.cgi?id=193431
3304
3305         Reviewed by Antti Koivisto.
3306
3307         * LayoutReloaded/misc/LFC-passing-tests.txt:
3308
3309 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3310
3311         Move a test implementation file that got misplaced in the Xcode project
3312
3313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3314
3315 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3316
3317         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3318         r239913, and r239914.
3319         https://bugs.webkit.org/show_bug.cgi?id=193407
3320
3321         These revisions caused an internal failure (Requested by
3322         Truitt on #webkit).
3323
3324         Reverted changesets:
3325
3326         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3327         https://bugs.webkit.org/show_bug.cgi?id=186016
3328         https://trac.webkit.org/changeset/239901
3329
3330         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3331         https://trac.webkit.org/changeset/239909
3332
3333         "Tried to fix the build."
3334         https://trac.webkit.org/changeset/239910
3335
3336         "Fixed iOS builds after r239910."
3337         https://trac.webkit.org/changeset/239912
3338
3339         "More build fixing."
3340         https://trac.webkit.org/changeset/239913
3341
3342         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3343         https://trac.webkit.org/changeset/239914
3344
3345 2019-01-14  Mark Lam  <mark.lam@apple.com>
3346
3347         Re-enable ability to build --cloop builds.
3348         https://bugs.webkit.org/show_bug.cgi?id=192955
3349         <rdar://problem/46882363>
3350
3351         Reviewed by Saam barati and Keith Miller.
3352
3353         The --cloop build option was being ignored this whole time since r236381.
3354         This patch makes it possible to build CLoop builds again.
3355
3356         * Scripts/build-jsc:
3357         * Scripts/webkitperl/FeatureList.pm:
3358         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3359
3360 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3361
3362         webkitpy: Expose device_type from host-like objects
3363         https://bugs.webkit.org/show_bug.cgi?id=193406
3364         <rdar://problem/47262305>
3365
3366         Reviewed by Lucas Forschler.
3367
3368         Devices should expose device_type. As a result, all host objects should
3369         provide a device_type property, even if they do not yet define a device_type.
3370
3371         * Scripts/webkitpy/common/system/systemhost.py:
3372         (SystemHost):
3373         (SystemHost.device_type):
3374         * Scripts/webkitpy/common/system/systemhost_mock.py:
3375         (MockSystemHost):
3376         (MockSystemHost.device_type):
3377         * Scripts/webkitpy/port/device.py:
3378         (Device):
3379         (Device.device_type):
3380         * Scripts/webkitpy/xcode/simulated_device.py:
3381         (SimulatedDeviceManager._find_exisiting_device_for_request):
3382         (SimulatedDeviceManager._disambiguate_device_type):
3383         (SimulatedDeviceManager._does_fulfill_request):
3384         (SimulatedDeviceManager.device_count_for_type):
3385         (SimulatedDeviceManager.initialize_devices):
3386         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3387         (test_available_devices):
3388         (test_swapping_devices):
3389
3390 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3391
3392         webkitpy: Support alternate simctl device list output (Follow-up fix)
3393         https://bugs.webkit.org/show_bug.cgi?id=193362
3394         <rdar://problem/47122965>
3395
3396         Rubber-stamped by Lucas Forschler.
3397
3398         * Scripts/webkitpy/xcode/simulated_device.py:
3399         (SimulatedDeviceManager.populate_available_devices):
3400
3401 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3402
3403         [iOS] Expose SPI to access the current sentence boundary and selection state
3404         https://bugs.webkit.org/show_bug.cgi?id=193398
3405         <rdar://problem/45893108>
3406
3407         Reviewed by Dean Jackson.
3408
3409         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3410         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3411         expected.
3412
3413         * TestWebKitAPI/EditingTestHarness.h:
3414         * TestWebKitAPI/EditingTestHarness.mm:
3415         (-[EditingTestHarness moveBackward]):
3416         (-[EditingTestHarness moveForward]):
3417         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3418
3419         Add a couple of new helper methods on EditingTestHarness.
3420
3421         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3422         (-[SelectionChangeObserver initWithWebView:]):
3423         (-[SelectionChangeObserver webView]):
3424         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3425         (-[SelectionChangeObserver currentSelectionAttributes]):
3426
3427 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3428
3429         [LFC][BFC] Add basic box-sizing support.
3430         https://bugs.webkit.org/show_bug.cgi?id=193392
3431
3432         Reviewed by Antti Koivisto.
3433
3434         * LayoutReloaded/misc/LFC-passing-tests.txt:
3435
3436 2019-01-14  Charlie Turner  <cturner@igalia.com>
3437
3438         [WPE] API test gardening
3439         https://bugs.webkit.org/show_bug.cgi?id=193319
3440
3441         Reviewed by Michael Catanzaro.
3442
3443         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3444         passing tests.
3445
3446 2019-01-14  Charlie Turner  <cturner@igalia.com>
3447
3448         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3449         https://bugs.webkit.org/show_bug.cgi?id=192977
3450
3451         Reviewed by Carlos Garcia Campos.
3452
3453         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3454         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3455         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3456         (TestWebKitAPI::GStreamerTest::SetUp):
3457         (TestWebKitAPI::GStreamerTest::TearDown):
3458         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3459         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3460         (TestWebKitAPI::TEST_F):
3461
3462 2019-01-14  Charlie Turner  <cturner@igalia.com>
3463
3464         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3465         https://bugs.webkit.org/show_bug.cgi?id=193332
3466
3467         Reviewed by Michael Catanzaro.
3468
3469         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3470         defined as a char16_t, which changed in ICU 59, the
3471         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3472         unsigned short. This test is relying on the behaviour that
3473         UChar=unsigned short, which doesn't hold across platforms and ICU
3474         library versions. The full fix would be a special syntax for
3475         literal characters so that these ambiguities do not arise. That
3476         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3477         (TestWebKitAPI::TEST):
3478
3479 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3480
3481         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3482
3483         * Scripts/make-dist:
3484         (Distcheck.configure):
3485
3486 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3487
3488         [ews-build] Update macOS queue configurations
3489         https://bugs.webkit.org/show_bug.cgi?id=193365
3490         <rdar://problem/47221073>
3491
3492         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3493
3494         * BuildSlaveSupport/ews-build/config.json:
3495
3496 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3497
3498         [LFC] Adjust assert for statically positioned fixed elements
3499         https://bugs.webkit.org/show_bug.cgi?id=193385
3500
3501         Reviewed by Antti Koivisto.
3502
3503         * LayoutReloaded/misc/LFC-passing-tests.txt:
3504
3505 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3506
3507         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3508         https://bugs.webkit.org/show_bug.cgi?id=193387
3509
3510         Reviewed by Carlos Garcia Campos.
3511
3512         * MiniBrowser/wpe/main.cpp:
3513         (main):
3514
3515 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3516
3517         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3518         https://bugs.webkit.org/show_bug.cgi?id=191655
3519         rdar://problem/46074680
3520
3521         Reviewed by Megan Gardner.
3522
3523         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3524         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3525
3526 2019-01-12  Dan Bernstein  <mitz@apple.com>
3527
3528         [Cocoa] Avoid importing directly from subumbrella frameworks
3529         https://bugs.webkit.org/show_bug.cgi?id=186016
3530         <rdar://problem/40591038>
3531
3532         Reviewed by Sam Weinig.
3533
3534         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3535           LaunchServices header.
3536         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3537           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3538         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3539           when using SDKs earlier than 10.13.
3540         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3541           and OTHER_CPLUSPLUSFLAGS.
3542         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3543           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3544         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3545           LaunchServices header.
3546
3547 2019-01-11  John Wilander  <wilander@apple.com>
3548
3549         Compile out Web API Statistics Collection
3550         https://bugs.webkit.org/show_bug.cgi?id=193370
3551         <rdar://problem/45388584>
3552
3553         Reviewed by Brent Fulgham.
3554
3555         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3556             Defined ENABLE_WEB_API_STATISTICS, off by default.
3557
3558 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3559
3560         [WPE] Add gtk-doc
3561         https://bugs.webkit.org/show_bug.cgi?id=178900
3562
3563         Reviewed by Michael Catanzaro.
3564
3565         Add Tools/gtkdoc to manifest.txt.in files.
3566         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3567
3568         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3569         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3570
3571 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3572
3573         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3574         https://bugs.webkit.org/show_bug.cgi?id=193364
3575         <rdar://problem/47214117>
3576
3577         Reviewed by Tim Horton.
3578
3579         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3580         precise, whereas dragging near the middle of the textarea does.
3581
3582         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3583         (TestWebKitAPI::TEST):
3584
3585 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3586
3587         webkitpy: Support alternate simctl device list output
3588         https://bugs.webkit.org/show_bug.cgi?id=193362
3589         <rdar://problem/47122965>
3590
3591         Reviewed by Lucas Forschler.
3592
3593         * Scripts/webkitpy/xcode/simulated_device.py:
3594         (SimulatedDeviceManager.populate_available_devices):
3595
3596 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3597
3598         [ews-build] Update macOS queue configurations
3599         https://bugs.webkit.org/show_bug.cgi?id=193365
3600
3601         Reviewed by Lucas Forschler.
3602
3603         * BuildSlaveSupport/ews-build/config.json:
3604
3605 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3606
3607         webkitpy: Incorporate device type into baseline search path
3608         https://bugs.webkit.org/show_bug.cgi?id=193356
3609         <rdar://problem/47215515>
3610
3611         Reviewed by Lucas Forschler.
3612
3613         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3614
3615         * Scripts/webkitpy/port/base.py:
3616         (Port.default_baseline_search_path): Allow device type to be passed in.
3617         * Scripts/webkitpy/port/gtk.py:
3618         (GtkPort.default_baseline_search_path): Ignore device type.
3619         * Scripts/webkitpy/port/ios.py:
3620         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3621         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3622         * Scripts/webkitpy/port/ios_device_unittest.py:
3623         (IOSDeviceTest):
3624         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3625         (IOSSimulatorTest):
3626         * Scripts/webkitpy/port/mac.py:
3627         (MacPort.default_baseline_search_path): Ignore device type.
3628         * Scripts/webkitpy/port/watch.py:
3629         (WatchPort.default_baseline_search_path): Ditto.
3630         * Scripts/webkitpy/port/win.py:
3631         (WinPort.default_baseline_search_path): Ditto.
3632         (WinCairoPort.default_baseline_search_path): Ditto.
3633         * Scripts/webkitpy/port/wpe.py:
3634         (WPEPort.default_baseline_search_path): Ditto.
3635
3636 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3637
3638         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3639         https://bugs.webkit.org/show_bug.cgi?id=193352
3640         <rdar://problem/47210736>
3641
3642         Reviewed by Lucas Forschler.
3643
3644         * Scripts/webkitpy/layout_tests/views/printing.py:
3645         (Printer.print_config): Print list on only baseline search paths which exist. 
3646         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3647         (Testprinter.test_print_config):
3648
3649 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3650
3651         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3652         https://bugs.webkit.org/show_bug.cgi?id=193340
3653
3654         Reviewed by David Kilzer.
3655
3656         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3657         (WTR::InjectedBundle::didReceiveMessageToPage):
3658         Pull the strings out into a WKRetainPtr.
3659
3660         * WebKitTestRunner/WebNotificationProvider.cpp:
3661         (WTR::WebNotificationProvider::closeWebNotification):
3662         Adopt the created value into the WKRetainPtr.
3663
3664         * WebKitTestRunner/mac/TestControllerMac.mm:
3665         (WTR::generateWhitelist):
3666         Immediately adopt a created value to avoid potential mistakes.
3667
3668 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3669
3670         Enable DFG on ARM/Linux again
3671         https://bugs.webkit.org/show_bug.cgi?id=192496
3672
3673         Reviewed by Yusuke Suzuki.
3674
3675         After changing the bytecode format DFG was disabled on all 32-bit
3676         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3677         on ARM by default.