aab5e3a9ff6c8772ac06bac6cce14f174b521700
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
2
3         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
4         https://bugs.webkit.org/show_bug.cgi?id=167693
5
6         Reviewed by Sergio Villar Senin.
7
8         * Scripts/webkitperl/FeatureList.pm:
9         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
10         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
11         (TestWebKitAPI::computeNumberOfTracks):
12         (TestWebKitAPI::TEST):
13         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp:
14         (TestWebKitAPI::TEST):
15
16 2017-02-19  Commit Queue  <commit-queue@webkit.org>
17
18         Unreviewed, rolling out r212466.
19         https://bugs.webkit.org/show_bug.cgi?id=168577
20
21         causes crashes on AArch64 on linux, maybe it's causing crashes
22         on iOS too (Requested by pizlo on #webkit).
23
24         Reverted changeset:
25
26         "The collector thread should only start when the mutator
27         doesn't have heap access"
28         https://bugs.webkit.org/show_bug.cgi?id=167737
29         http://trac.webkit.org/changeset/212466
30
31 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
32
33         Fix failure from r212579.
34
35         Unreviewed build-fix.
36
37         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
38         (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
39
40 2017-02-17  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
41
42         EWS should run JavaScriptCore tests
43         https://bugs.webkit.org/show_bug.cgi?id=162458
44
45         Reviewed by Alexey Proskuryakov.
46
47         * QueueStatusServer/config/queues.py: Add jsc-ews queue.
48         * QueueStatusServer/model/queuestatus.py:
49         (QueueStatus.did_skip): Returns whether patch was skipped, based on status.
50         * QueueStatusServer/handlers/statusbubble.py:
51         (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc.
52         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
53         (MockSCM.__init__): Add _mockChangedFiles variable.
54         (MockSCM.changed_files): Change to use _mockChangedFiles variables.
55         * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS.
56         * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port.
57         (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command.
58         (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit).
59         (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests.
60         (MacPort.run_webkit_tests_command): Check for JSC.
61         * Scripts/webkitpy/common/config/ports_mock.py:
62         (MockPort.run_javascriptcore_tests_command): Add build_style argument.
63         * Scripts/webkitpy/common/config/ports_unittest.py:
64         (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command.
65         * Scripts/webkitpy/common/net/abstracttestresults.py: Added.
66         (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults.
67         (AbstractTestResults.test_results): Stub.
68         (AbstractTestResults.failing_tests): Stub.
69         (AbstractTestResults.did_exceed_test_failure_limit): Stub.
70         * Scripts/webkitpy/common/net/jsctestresults.py: Added.
71         (JSCTestResults): Added.
72         (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects.
73         (JSCTestResults.results_from_string): Use json library to parse results.
74         (JSCTestResults.__init__): Initialize members.
75         (JSCTestResults.equals): This enables unit testing.
76         (JSCTestResults.is_subset): Checks if one set of failures is a subset of another.
77         (JSCTestResults.all_passed): Getter.
78         (JSCTestResults.failing_tests): Getter.
79         (JSCTestResults.did_exceed_test_failure_limit): Getter.
80         * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added.
81         (JSCTestResultsTest): Class to test JSCTestResults.
82         (JSCTestResultsTest.test_results_from_string): Tests parsing.
83         (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method.
84         (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method.
85         (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method.
86         * Scripts/webkitpy/port/base.py:
87         (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file.
88         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
89         (EarlyWarningSystemTask.run): Add check_patch_relevance step.
90         * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added.
91         (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands.
92         (MockPatchAnalysisTask.__init__): Sets attributes.
93         (MockPatchAnalysisTask._test): Override to not run command.
94         (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command.
95         (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic.
96         (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic.
97         (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results.
98         (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc.
99         (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader.
100         (JSCEarlyWarningSystemTest): Class to test retry logic in below situations.
101         (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code.
102         (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True.
103         (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
104         (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree.
105         (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness.
106         (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree.
107         (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures.
108         (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree.
109         (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable.
110         (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run.
111         (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable.
112         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures.
113         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures.
114         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests.
115         (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake.
116         * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added.
117         (JSCTestResultsReader): Reads results file.
118         (JSCTestResultsReader.__init__): Sets attributes.
119         (JSCTestResultsReader._read_file_contents): Reads file.
120         (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object.
121         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
122         (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes.
123         (PatchAnalysisTask._check_patch_relevance): Added.
124         (PatchAnalysisTask._build): Check for JSC.
125         (PatchAnalysisTask._build_without_patch): Check for JSC.
126         (PatchAnalysisTask._test): Check for JSC.
127         (PatchAnalysisTask._build_and_test_without_patch): Check for JSC.
128         (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS.
129         (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS.
130         (PatchAnalysisTask._test_patch): Add retry logic for JSC.
131         * Scripts/webkitpy/tool/commands/download.py:
132         (CheckPatchRelevance): Add check-patch-relevance command.
133         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
134         (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking.
135         (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS.
136         (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable.
137         (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader.
138         (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader.
139         (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC).
140         (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking.
141         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
142         (TestEWS): Sample layout test EWS class used for unit testing.
143         (TestJSCEWS): Sample JSC EWS class used for unit testing.
144         (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group.
145         (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message.
146         (AbstractEarlyWarningSystemTest): Add _group variable.
147         (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group.
148         (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs().
149         (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive.
150         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added.
151         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result.
152         (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added.
153         (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask).
154         * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import.
155         * Scripts/webkitpy/tool/steps/build.py:
156         (Build.options): Check for JSC.
157         (Build.build): Check for JSC.
158         (Build.run): Check for JSC.
159         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added.
160         (CheckPatchRelevance): Added.
161         (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching.
162         (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders.
163         * Scripts/webkitpy/tool/steps/options.py:
164         (Options): Add --group command line option.
165         * Scripts/webkitpy/tool/steps/runtests.py:
166         (RunTests.options): Add group.
167         (RunTests.run): Check for JSC.
168         (RunTests._run_webkit_tests): Check for JSC.
169         (RunTests): Add _group attribute.
170         (RunTests._run_javascriptcore_tests): New.
171         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
172
173 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
174
175         Fix tools that were broken by Efl removal
176         https://bugs.webkit.org/show_bug.cgi?id=168496
177
178         Reviewed by Alexey Proskuryakov.
179
180         * QueueStatusServer/config/queues.py:
181         * Scripts/webkitpy/common/config/ews.json:
182         * TestResultServer/static-dashboards/builders.jsonp:
183         * TestResultServer/static-dashboards/flakiness_dashboard.js:
184         * TestResultServer/static-dashboards/loader_unittests.js:
185
186 2017-02-16  Lucas Forschler  <lforschler@apple.com>
187
188         https://bugs.webkit.org/show_bug.cgi?id=168442
189         Move the SVN checkout from http -> https.
190         Update unit tests.
191
192         Reviewed by Alexey Proskuryakov.
193
194         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
195         (CheckOutSource.__init__):
196         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
197         (SVNMirrorTest.get_SVNMirrorFromConfig):
198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
199
200 2017-02-16  Commit Queue  <commit-queue@webkit.org>
201
202         Unreviewed, rolling out r212514.
203         https://bugs.webkit.org/show_bug.cgi?id=168489
204
205         broke test runner (Requested by alexchristensen on #webkit).
206
207         Reverted changeset:
208
209         "Remove EFL-specific files in Tools."
210         http://trac.webkit.org/changeset/212514
211
212 2017-02-16  Alex Christensen  <achristensen@webkit.org>
213
214         Remove EFL-specific files in Tools.
215
216         Rubber-stamped by Anders Carlsson.
217
218         * ImageDiff/efl: Removed.
219         * ImageDiff/efl/ImageDiff.cpp: Removed.
220         * MiniBrowser/efl: Removed.
221         * MiniBrowser/efl/CMakeLists.txt: Removed.
222         * MiniBrowser/efl/main.c: Removed.
223         * Scripts/run-efl-tests: Removed.
224         * Scripts/update-webkitefl-libs: Removed.
225         * Scripts/webkitpy/port/efl.py: Removed.
226         * Scripts/webkitpy/port/efl_unittest.py: Removed.
227         * TestWebKitAPI/Tests/WebKit2/efl: Removed.
228         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
229         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
230         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
231         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
232         * TestWebKitAPI/efl: Removed.
233         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
234         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
235         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
236         * TestWebKitAPI/efl/main.cpp: Removed.
237         * WebKitTestRunner/InjectedBundle/efl: Removed.
238         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
239         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
240         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
241         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
242         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
243         * WebKitTestRunner/efl: Removed.
244         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
245         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
246         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
247         * WebKitTestRunner/efl/main.cpp: Removed.
248         * efl: Removed.
249         * efl/install-dependencies: Removed.
250         * efl/jhbuild-optional.modules: Removed.
251         * efl/jhbuild.modules: Removed.
252         * efl/jhbuildrc: Removed.
253         * efl/patches: Removed.
254         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
255         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
256         * efl/patches/gst-libav.patch: Removed.
257         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
258         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
259         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
260         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
261
262 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
263
264         font-weight in @font-face can cause a font to be downloaded even when it's not used
265         https://bugs.webkit.org/show_bug.cgi?id=168114
266         <rdar://problem/30301317>
267
268         Reviewed by Darin Adler.
269
270         LastResort needs to be usable in tests.
271
272         * DumpRenderTree/mac/DumpRenderTree.mm:
273         (allowedFontFamilySet):
274         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
275         (WTR::allowedFontFamilySet):
276         * WebKitTestRunner/mac/TestControllerMac.mm:
277         (WTR::allowedFontFamilySet):
278
279 2017-02-16  Alex Christensen  <achristensen@webkit.org>
280
281         Remove old URL parser
282         https://bugs.webkit.org/show_bug.cgi?id=168483
283
284         Reviewed by Tim Horton.
285
286         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
287         (TestWebKitAPI::checkURL):
288         (TestWebKitAPI::checkRelativeURL):
289         (TestWebKitAPI::checkURLDifferences):
290         (TestWebKitAPI::checkRelativeURLDifferences):
291
292 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
293
294         [WK2] Add additional test infrastructure and unit tests for data interaction
295         https://bugs.webkit.org/show_bug.cgi?id=168439
296         <rdar://problem/30557942>
297
298         Reviewed by Tim Horton.
299
300         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
301         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
302         support data interaction from  See per-method descriptions below for more details.
303
304         * Configurations/TestWebKitAPI.xcconfig:
305
306         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
307
308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
309
310         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
311         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
312
313         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
314         (-[TestWKWebView editorContainsImageElement]):
315         (-[TestWKWebView editorValue]):
316
317         New helper methods for querying information from the "editor" element in a test page.
318
319         (TestWebKitAPI::TEST):
320         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
321
322         Moves logic for capturing events during a simulated data interaction run from the test file to
323         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
324
325         * TestWebKitAPI/cocoa/TestWKWebView.h:
326         * TestWebKitAPI/cocoa/TestWKWebView.mm:
327         (-[TestMessageHandler removeMessage:]):
328         (-[TestWKWebView clearMessageHandlers:]):
329
330         Add the ability to clear message handlers from the TestWKWebView.
331
332         * TestWebKitAPI/ios/DataInteractionSimulator.h:
333         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
334         (dataInteractionEventNames):
335         (-[DataInteractionSimulator initWithWebView:]):
336         (-[DataInteractionSimulator _resetSimulatedState]):
337
338         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
339         simulating data interaction.
340
341         (-[DataInteractionSimulator observedEventNames]):
342
343         Returns a list of the names of events relevant to data interaction that were observed over the course of the
344         most recent run.
345
346         (-[DataInteractionSimulator runFrom:to:]):
347
348         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
349         to run the same data interaction for multiple simulated gestures.
350
351         (-[DataInteractionSimulator _advanceProgress]):
352         (-[DataInteractionSimulator _finishDataInteraction]):
353         (-[DataInteractionSimulator externalItemProvider]):
354         (-[DataInteractionSimulator setExternalItemProvider:]):
355
356         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
357         phase of a test run.
358
359         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
360         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
361         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
362         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
363
364         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
365         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
366         wherein the the web process might take longer than usual to process the request to start data interaction, and
367         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
368         the web process is received, which then causes no simulated delegate methods to be fired.
369
370         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
371         (-[DataInteractionSimulator run]): Deleted.
372
373 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
374
375         Remove unused test pages in TestWebKitAPI
376         https://bugs.webkit.org/show_bug.cgi?id=168462
377
378         Reviewed by Anders Carlsson.
379
380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
381         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
382         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
383         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
384         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
385         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
386
387 2017-02-16  Alex Christensen  <achristensen@webkit.org>
388
389         Special URLs without a host are invalid
390         https://bugs.webkit.org/show_bug.cgi?id=168461
391
392         Reviewed by Tim Horton.
393
394         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
395         (TestWebKitAPI::TEST_F):
396
397 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
398
399         The collector thread should only start when the mutator doesn't have heap access
400         https://bugs.webkit.org/show_bug.cgi?id=167737
401
402         Reviewed by Keith Miller.
403         
404         Make more tests collect continuously.
405
406         * Scripts/run-jsc-stress-tests:
407
408 2017-02-16  Tim Horton  <timothy_horton@apple.com>
409
410         WKWebView inside a UICollectionView flashes when items are inserted above it
411         https://bugs.webkit.org/show_bug.cgi?id=168376
412         <rdar://problem/29322051>
413
414         Reviewed by Simon Fraser.
415
416         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
417         (-[TestRunnerWKWebView _setStableStateOverride:]):
418         Update the one external caller of this internal method...
419
420         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
421         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
422         * DumpRenderTree/mac/UIScriptControllerMac.mm:
423         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
424         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
425         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
426         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
427         * TestRunnerShared/UIScriptContext/UIScriptController.h:
428         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
429         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
430         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
431         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
432         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
433         back after we dispatch a visible content rect update from the UI process
434         to the Web Content process, so any messages sent from the block will arrive
435         after the visible content rect update.
436
437 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
438
439         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
440         https://bugs.webkit.org/show_bug.cgi?id=168321
441
442         This bots should be added to the trunk build scheduler.
443         Unreviewed fix after r212429.
444
445         * BuildSlaveSupport/build.webkit.org-config/config.json:
446
447 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
448
449         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
450         https://bugs.webkit.org/show_bug.cgi?id=168321
451
452         Reviewed by Michael Catanzaro.
453
454         The additionalArgument --default-cmake-features is used both to
455         skip the JHBuild (InstallGtkDependencies) build step and to build
456         with the default features from the CMake config.
457
458         * BuildSlaveSupport/build.webkit.org-config/config.json:
459         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
460         (Factory.__init__):
461         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
462
463 2017-02-15  Lucas Forschler  <lforschler@apple.com>
464
465         https://bugs.webkit.org/show_bug.cgi?id=168386
466         Remove EFL from build.webkit.org
467
468         Reviewed by Alex Christensen
469
470         * BuildSlaveSupport/build.webkit.org-config/config.json:
471         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
472         (DeleteStaleBuildFiles.start):
473         (appendCustomBuildFlags):
474         (RunWebKitTests.start):
475         (RunBuiltinsTests):
476         (Factory.__init__):
477         (TestFactory.__init__):
478         (loadBuilderConfig):
479         (InstallEflDependencies): Deleted.
480         (RunEflAPITests): Deleted.
481         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
484         (BubbleQueueServer):
485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
486         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
487         (Analyzer.prototype._triggeringQueue):
488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
489         (WebKitBuildbot):
490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
491         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
492         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
493         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
494         (_should_file_trigger_build):
495
496 2017-02-15  Alex Christensen  <achristensen@webkit.org>
497
498         Unreviewed, rolling out r212169.
499
500         Broke iOS WebInspector
501
502         Reverted changeset:
503
504         "WebInspector: refactor RemoteInspector to move cocoa specific
505         code to their own files"
506         https://bugs.webkit.org/show_bug.cgi?id=166681
507         http://trac.webkit.org/changeset/212169
508
509 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
510
511         webkitpy: Fix DarwinPort._get_crash_log()
512         https://bugs.webkit.org/show_bug.cgi?id=168372
513         <rdar://problem/30535156>
514
515         Reviewed by Daniel Bates.
516
517         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
518         DarwinPort should return the expected return value for _get_crash_log.
519
520         * Scripts/webkitpy/port/darwin.py:
521         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
522
523 2017-02-15  Chris Dumez  <cdumez@apple.com>
524
525         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
526         https://bugs.webkit.org/show_bug.cgi?id=168291
527         <rdar://problem/30508593>
528
529         Reviewed by Tim Horton.
530
531         Drop overridePreference() implementation in iOS's UIScriptController
532         as it was only used for the minimum font size setting and this setting
533         is not exposed on iOS.
534
535         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
536         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
537         (WTR::UIScriptController::overridePreference):
538         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
539
540 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
541
542         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
543         https://bugs.webkit.org/show_bug.cgi?id=168329
544         <rdar://problem/30518832>
545
546         Reviewed by Daniel Bates.
547
548         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
549         never change given the same input arguments.  Memoize function for efficiency.
550
551         * Scripts/webkitpy/port/darwin.py: Add memoized import.
552         (DarwinPort):
553         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
554         
555
556 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
557
558         webkitpy: Remove unused import from darwin.py
559         https://bugs.webkit.org/show_bug.cgi?id=168371
560
561         Reviewed by Alex Christensen.
562
563         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
564
565 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
566
567         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
568         https://bugs.webkit.org/show_bug.cgi?id=168364
569
570         Reviewed by Michael Catanzaro.
571
572         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
573         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
574         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
575
576         Fixes: http/tests/security/credentials-from-different-domains.html
577                http/tests/xmlhttprequest/cross-origin-no-authorization.html
578
579         * gtk/jhbuild.modules:
580         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
581         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
582
583 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
584
585         [GTK] Update cookie manager API to properly work with ephemeral sessions
586         https://bugs.webkit.org/show_bug.cgi?id=168230
587
588         Reviewed by Michael Catanzaro.
589
590         Update unit tests and add new cases for the new API.
591
592         * MiniBrowser/gtk/main.c:
593         (gotWebsiteDataCallback):
594         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
595         (testCookieManagerEphemeral):
596         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
597         (testWebContextEphemeral):
598         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
599         (testWebViewEphemeral):
600         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
601         (serverCallback):
602         (testWebsiteDataEphemeral):
603         (testWebsiteDataCookies):
604         (beforeAll):
605
606 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
607
608         [WK2] Support data interaction on links
609         https://bugs.webkit.org/show_bug.cgi?id=168331
610         <rdar://problem/30200837>
611
612         Reviewed by Tim Horton.
613
614         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
615         editable area results in the link URL being inserted.
616
617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
618         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
619         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
620         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
621         (TestWebKitAPI::TEST):
622
623 2017-02-14  Jason Rinn  <jrinn@apple.com>
624
625         Add a test for new WebKit Cocoa API, _getContentsAsString.
626         https://bugs.webkit.org/show_bug.cgi?id=168147
627         <rdar://problem/30502539>
628
629         Reviewed by Tim Horton.
630
631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
632         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
633         (TEST):
634
635 2017-02-14  Matt Rajca  <mrajca@apple.com>
636
637         Website policies: iframes should respect the autoplay policy of the top-level document
638         https://bugs.webkit.org/show_bug.cgi?id=168333
639
640         Reviewed by Alex Christensen.
641
642         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
643         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
644         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
645         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
646         (TEST):
647
648 2017-02-14  Chris Dumez  <cdumez@apple.com>
649
650         HTML Form Validation bubble should take minimum font size setting into consideration
651         https://bugs.webkit.org/show_bug.cgi?id=168271
652         <rdar://problem/29869869>
653
654         Reviewed by Simon Fraser.
655
656         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
657         font size of the validation bubble.
658
659         Add an overridePreference() method to UIScriptController. This is currently
660         used to override the value of the minimumFontSize setting. testRunner's
661         overridePreference() is not usable on WK2 because it does not update the
662         value of the preference on the UIProcess side.
663
664         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
665         (WTR::UIScriptController::overridePreference):
666         * DumpRenderTree/mac/UIScriptControllerMac.mm:
667         (WTR::UIScriptController::overridePreference):
668         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
669         * TestRunnerShared/UIScriptContext/UIScriptController.h:
670         * WebKitTestRunner/TestController.cpp:
671         (WTR::TestController::resetPreferencesToConsistentValues):
672         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
673         (WTR::UIScriptController::overridePreference):
674         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
675         (WTR::UIScriptController::contentsOfUserInterfaceItem):
676         (WTR::UIScriptController::overridePreference):
677
678 2017-02-14  Florian Bruhin  <git@the-compiler.org>
679
680         Use a set instead of a list for tests when parsing expectations
681         https://bugs.webkit.org/show_bug.cgi?id=168304
682
683         In _collect_matching_tests, a lot of membership tests are done on a giant list
684         of strings. By making it a set instead, we can make those much faster, and
685         there's no reason for it to be a list.
686
687         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
688         to 3s on my machine.
689
690         Reviewed by Ryosuke Niwa.
691
692         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
693         (TestExpectationParser.__init__):
694         (TestExpectationParser._collect_matching_tests):
695
696 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
697
698         Unreviewed build-fix after r212297.
699
700         * Scripts/webkitpy/port/simulator_process.py:
701         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
702
703 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
704
705         [CMake] build-webkit should allow building with the default cmake configuration
706         https://bugs.webkit.org/show_bug.cgi?id=168323
707
708         Reviewed by Michael Catanzaro.
709
710         Add a --default-cmake-features switch that makes the script pass
711         no value for any of the features defined by build-webkit, that
712         way the default values from the port cmake config will be used.
713
714         * Scripts/build-webkit:
715         (cMakeArgsFromFeatures):
716
717 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
718
719         Unreviewed build-fix after r212297.
720
721         * Scripts/webkitpy/port/simulator_process.py:
722         (SimulatorProcess.stop): Handle case where there is no process to kill.
723
724 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
725
726         [CMake] build-webkit should print the cmake command executed
727         https://bugs.webkit.org/show_bug.cgi?id=168318
728
729         Reviewed by Michael Catanzaro.
730
731         Run the cmake commands to configure or start the build through
732         a wrapper that prints the command before executing it.
733
734         * Scripts/webkitdirs.pm:
735         (systemVerbose):
736         (generateBuildSystemFromCMakeProject):
737         (buildCMakeGeneratedProject):
738         (cleanCMakeGeneratedProject):
739
740 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
741
742         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
743         https://bugs.webkit.org/show_bug.cgi?id=168150
744
745         Reviewed by Alexey Proskuryakov.
746
747         * Scripts/webkitpy/port/simulator_process.py:
748         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
749         (SimulatorProcess._kill): Move closing of app into stop().
750         * Scripts/webkitpy/xcode/simulator.py:
751         (Device.launch_app):
752         (Device.terminate_app): Deleted.
753
754 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
755
756         REGRESSION(r212192): [GTK] Broke downloads API tests
757         https://bugs.webkit.org/show_bug.cgi?id=168193
758
759         Unreviewed. Update test expectations after r212192.
760
761         The suggested filename now includes a file extensions if the MIME type is known.
762
763         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
764         (testDownloadRemoteFile):
765         (testDownloadMIMEType):
766
767 2017-02-14  Commit Queue  <commit-queue@webkit.org>
768
769         Unreviewed, rolling out r212237.
770         https://bugs.webkit.org/show_bug.cgi?id=168298
771
772         This was a wrong fix (Requested by rniwa on #webkit).
773
774         Reverted changeset:
775
776         "Nwtr unexpectedly passes mismatch ref test if the hashes
777         doesn't match but no diff"
778         https://bugs.webkit.org/show_bug.cgi?id=168221
779         http://trac.webkit.org/changeset/212237
780
781 2017-02-13  Alex Christensen  <achristensen@webkit.org>
782
783         URLs with an invalid IPv4 address should be invalid
784         https://bugs.webkit.org/show_bug.cgi?id=168260
785
786         Reviewed by Tim Horton.
787
788         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
789         (TestWebKitAPI::TEST_F):
790         Update tests to reflect new correct behavior.
791
792 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
793
794         [WinCairo] Add Build Slave
795         https://bugs.webkit.org/show_bug.cgi?id=168263
796
797         Reviewed by Lucas Forschler.
798
799         * BuildSlaveSupport/build.webkit.org-config/config.json:
800
801 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
802
803         Fix the build after r212254
804
805         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
806         (-[DataInteractionSimulator _currentLocation]):
807
808 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
809
810         [WK2] Add test infrastructure and unit tests for data interaction
811         https://bugs.webkit.org/show_bug.cgi?id=168159
812         <rdar://problem/30477634>
813
814         Reviewed by Tim Horton.
815
816         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
817         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
818         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
819         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
820         gesture has already been recognized) at regular intervals over the course of the test.
821
822         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
823         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
824         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
825         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
826
827         New test pages for data interaction.
828
829         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
830         (TestWebKitAPI::runTestsExpectingToObserveEvents):
831         (TestWebKitAPI::TEST):
832         * TestWebKitAPI/cocoa/TestWKWebView.mm:
833         (-[TestWKWebView stringByEvaluatingJavaScript:]):
834         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
835         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
836         (-[MockLongPressGestureRecognizer initWithWindow:]):
837         (-[MockLongPressGestureRecognizer locationInView:]):
838         (-[MockLongPressGestureRecognizer state]):
839         (-[MockLongPressGestureRecognizer numberOfTouches]):
840         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
841         (-[DataInteractionSimulator dealloc]):
842         (-[DataInteractionSimulator run]):
843
844         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
845         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
846         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
847
848         (-[DataInteractionSimulator _advanceProgress]):
849
850         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
851         completed, and calls _finishDataInteraction when progress is at 1.
852
853         (-[DataInteractionSimulator _finishDataInteraction]):
854         (-[DataInteractionSimulator _currentLocation]):
855         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
856         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
857         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
858         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
859         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
860
861 2017-02-13  Alex Christensen  <achristensen@webkit.org>
862
863         Percent should be allowed in non-special URL hosts
864         https://bugs.webkit.org/show_bug.cgi?id=168255
865
866         Reviewed by Tim Horton.
867
868         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
869         (TestWebKitAPI::TEST_F):
870
871 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
872
873         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
874         https://bugs.webkit.org/show_bug.cgi?id=168221
875
876         Reviewed by Ryosuke Niwa.
877
878         There is a logic error in comparing mismatch ref test images. In
879         mismatch ref tests, it should be failed if two images has no diff.
880         But, if the hashes are different, nwtr unexpectedly pass the
881         mismatch ref test.
882
883         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
884         (SingleTestRunner._compare_output_with_reference): Fail the
885         mismatch ref test if hashes of two images are equal. Invoke
886         ImageDiff if the hashes don't match.
887
888 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
889
890         Update custom line breaking iterators to the latest version of Unicode
891         https://bugs.webkit.org/show_bug.cgi?id=168182
892
893         Reviewed by Zalan Bujtas.
894
895         Treat the system's ICU as the source of truth to compare breaking positions against.
896
897         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
898         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
899         (generateJavaScriptForTest):
900         (breakingLocationsFromICU):
901         (testAFewStrings):
902         (TEST):
903         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
904         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
905
906 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
907
908         [GTK] Several failing WebViewEditor API tests
909         https://bugs.webkit.org/show_bug.cgi?id=161608
910
911         Reviewed by Carlos Garcia Campos.
912
913         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
914         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
915         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
916         except the first one, which is still broken due to unrelated bug #151654.
917
918         * Scripts/run-gtk-tests:
919         (TestRunner):
920         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
921
922 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
923
924         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
925
926         * Scripts/run-gtk-tests:
927         (TestRunner):
928
929 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
930
931         Unreviewed, skip flaky form-controls-associated-signal test
932
933         * Scripts/run-gtk-tests:
934         (TestRunner):
935
936 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
937
938         [GTK] Handle caps lock indicator in event modifiers
939         https://bugs.webkit.org/show_bug.cgi?id=168186
940
941         Reviewed by Michael Catanzaro.
942
943         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
944         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
945
946 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
947
948         MiniBrowser WK1 fails to update URL for within-page navigations
949         https://bugs.webkit.org/show_bug.cgi?id=168173
950
951         Reviewed by Tim Horton.
952         
953         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
954         anchors updates the URL field.
955
956         * MiniBrowser/mac/WK1BrowserWindowController.m:
957         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
958
959 2017-02-10  John Wilander  <wilander@apple.com>
960
961         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
962         https://bugs.webkit.org/show_bug.cgi?id=167474
963         <rdar://problem/24681808>
964         <rdar://problem/24703286>
965         <rdar://problem/30290270>
966
967         This patch adds test infrastructure to allow testing 
968         of the various rules in place for data records removal.
969
970         Reviewed by Andy Estes.
971
972         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
973         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
974         (WTR::InjectedBundle::didReceiveMessageToPage):
975             Callback mechanism to tell pages that a website data store
976             scan has happened.
977         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
978         (WTR::TestRunner::setStatisticsPrevalentResource):
979         (WTR::TestRunner::isStatisticsPrevalentResource):
980         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
981         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
982         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
983         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
984         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
985         (WTR::TestRunner::statisticsFireDataModificationHandler):
986         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
987         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
988         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
989         (WTR::TestRunner::statisticsResetToConsistentState):
990         * WebKitTestRunner/InjectedBundle/TestRunner.h:
991         * WebKitTestRunner/TestController.cpp:
992         (WTR::TestController::setStatisticsPrevalentResource):
993         (WTR::TestController::isStatisticsPrevalentResource):
994         (WTR::TestController::setStatisticsHasHadUserInteraction):
995         (WTR::TestController::isStatisticsHasHadUserInteraction):
996         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
997         (WTR::TestController::statisticsFireDataModificationHandler):
998         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
999         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1000         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1001         (WTR::TestController::statisticsResetToConsistentState):
1002         * WebKitTestRunner/TestController.h:
1003             These are all configuration and test functions.
1004         * WebKitTestRunner/TestInvocation.cpp:
1005         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1006
1007 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1008
1009         REGRESSION(r182916) run-perf-tests never timeouts
1010         https://bugs.webkit.org/show_bug.cgi?id=167626
1011
1012         Reviewed by Ryosuke Niwa.
1013
1014         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
1015         was beeing ignored because the driver was created with no_timeout=True
1016         unconditionally.
1017         This adds a new parameter --no-timeout (disabled by default), that
1018         allows to use the driver with the expected timeout values.
1019         It also passes --no-timeout to DRT/WTR to ensure that timeouts
1020         are always controlled by the Python Driver.
1021
1022         * Scripts/webkitpy/performance_tests/perftest.py:
1023         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
1024         (PerfTest.run): Disabling timeout should be done when the Driver is created.
1025         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1026         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
1027         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
1028         (_run_tests_set): Pass the no-timeout parameter.
1029         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1030         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
1031         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
1032         (MainTest.test_parse_args): Test that the argument no-timeout.
1033
1034 2017-02-10  Daniel Bates  <dabates@apple.com>
1035
1036         Detach frame from document when entering page cache
1037         https://bugs.webkit.org/show_bug.cgi?id=166774
1038         <rdar://problem/29904368>
1039
1040         Reviewed by Chris Dumez.
1041
1042         * DumpRenderTree/mac/DumpRenderTree.mm:
1043         (resetWebPreferencesToConsistentValues):
1044         * DumpRenderTree/win/DumpRenderTree.cpp:
1045         (resetWebPreferencesToConsistentValues):
1046         * WebKitTestRunner/TestController.cpp:
1047         (WTR::TestController::resetPreferencesToConsistentValues):
1048
1049 2017-02-10  Tim Horton  <timothy_horton@apple.com>
1050
1051         Infinite UI process hang under ensurePositionInformationIsUpToDate
1052         https://bugs.webkit.org/show_bug.cgi?id=168154
1053         <rdar://problem/30428673>
1054
1055         Reviewed by Simon Fraser.
1056
1057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1058         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
1059         (recursiveFindHighlightLongPressRecognizer):
1060         (TEST):
1061         Add a somewhat nasty test that does an async interaction information update, but
1062         kills the Web process before it arrives, and then does a sync interaction
1063         information update, which will wait for the oustanding async interaction
1064         information update if we still think it's coming. Before the patch, this
1065         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
1066
1067 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
1068
1069         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
1070         https://bugs.webkit.org/show_bug.cgi?id=168127
1071         rdar://problem/30467120
1072
1073         Reviewed by Tim Horton.
1074
1075         Reparent the web view before we try to fetch it via:
1076             [[[window contentView] subviews] objectAtIndex:0];
1077         which would throw an exception if the test unparented it.
1078
1079         * DumpRenderTree/mac/DumpRenderTree.mm:
1080         (resetWebViewToConsistentStateBeforeTesting):
1081         (runTest):
1082
1083 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1084
1085         [Resource Timing] Enable Resource Timing by default in Tests
1086         https://bugs.webkit.org/show_bug.cgi?id=168145
1087
1088         Reviewed by Ryosuke Niwa.
1089
1090         * DumpRenderTree/mac/DumpRenderTree.mm:
1091         (resetWebPreferencesToConsistentValues):
1092         * DumpRenderTree/win/DumpRenderTree.cpp:
1093         (resetWebPreferencesToConsistentValues):
1094         * WebKitTestRunner/TestController.cpp:
1095         (WTR::TestController::resetPreferencesToConsistentValues):
1096
1097 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
1098
1099         Removing LayoutTestRelay
1100         https://bugs.webkit.org/show_bug.cgi?id=165927
1101
1102         Reviewed by Daniel Bates.
1103         Part 2
1104
1105         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1106         simulators through simctl (iOS 10 and later), use this functionality instead.
1107
1108         * BuildSlaveSupport/built-product-archive:
1109         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
1110         Added a FIXME that we will need to implement similar archiving machinery once we build
1111         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
1112         * BuildSlaveSupport/kill-old-processes:
1113         (main): Remove LayoutTestRelay from list of processes.
1114         * LayoutTestRelay: Removed LayoutTestRelay.
1115         * Makefile:
1116         * Scripts/build-layouttestrelay: Removed.
1117         * Scripts/build-webkit: Removed LayoutTestRelay references.
1118
1119 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
1120
1121         [WebCrypto] Add WebCryptoAPI to watchlist
1122         https://bugs.webkit.org/show_bug.cgi?id=168138
1123
1124         Reviewed by Youenn Fablet.
1125
1126         * Scripts/webkitpy/common/config/watchlist:
1127
1128 2017-02-10  Brady Eidson  <beidson@apple.com>
1129
1130         Replace all WebKit Library Version checks in WK2 with SDK version checks.
1131         https://bugs.webkit.org/show_bug.cgi?id=168124
1132
1133         Reviewed by Geoffrey Garen.
1134
1135         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
1136         
1137         * MiniBrowser/mac/main.m:
1138         (main):
1139         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1140         (main):
1141         * TestWebKitAPI/ios/mainIOS.mm:
1142         (main):
1143         * TestWebKitAPI/mac/mainMac.mm:
1144         (main):
1145         * WebKitTestRunner/ios/mainIOS.mm:
1146         (main):
1147         * WebKitTestRunner/mac/main.mm:
1148         (setDefaultsToConsistentValuesForTesting):
1149
1150 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1151
1152         Fix El Capitan build.
1153
1154         * Scripts/build-webkit:
1155         Don't build libwebrtc anywhere for now.
1156
1157 2017-02-10  Andy Estes  <aestes@apple.com>
1158
1159         Move two MiniBrowserBundle settings out of the .pbxproj
1160         https://bugs.webkit.org/show_bug.cgi?id=168106
1161
1162         Reviewed by Tim Horton.
1163
1164         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
1165         the project file. This removes the project file override.
1166
1167         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
1168
1169         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
1170         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1171
1172 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1173
1174         Fix 32-and-64-bit build on El Capitan.
1175
1176         * Scripts/build-webkit:
1177         Somebody's building with something like this:
1178         build-webkit ARCHS="i386 x86_64"
1179         We want this to also not build libwebrtc for now.
1180
1181 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1182
1183         Fix 32-bit build on El Capitan.
1184
1185         * Scripts/build-webkit:
1186         The bot uses ARCHS=i386 instead of --32-bit.
1187         This is a hack, but it should fix the bot until I can do a better fix in the morning.
1188
1189 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1190
1191         Fix 32-bit build on El Capitan.
1192
1193         * Scripts/build-webkit:
1194         Don't build i386 libwebrtc.
1195
1196 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1197
1198         Unreviewed, rolling out r212040.
1199
1200         Broke build.  I'm not surprised
1201
1202         Reverted changeset:
1203
1204         "[WebRTC][Mac] Activate libwebrtc"
1205         https://bugs.webkit.org/show_bug.cgi?id=167293
1206         http://trac.webkit.org/changeset/212040
1207
1208 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1209
1210         Build libwebrtc on bots without using it yet
1211         https://bugs.webkit.org/show_bug.cgi?id=168062
1212
1213         Reviewed by Brent Fulgham.
1214
1215         * Scripts/build-webkit:
1216
1217 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1218
1219         Don't build libwebrtc.
1220
1221         * Scripts/build-webkit:
1222         Not ready yet.  It broke El Capitan and iOS.
1223
1224 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1225
1226         Build libwebrtc on bots without using it yet
1227         https://bugs.webkit.org/show_bug.cgi?id=168062
1228
1229         Reviewed by Brent Fulgham.
1230
1231         * Scripts/build-webkit:
1232
1233 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1234
1235         Rename isAppleMacWebKit to isAppleCocoaWebKit
1236         https://bugs.webkit.org/show_bug.cgi?id=168075
1237
1238         Reviewed by Geoffrey Garen.
1239
1240         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
1241
1242         * Scripts/build-api-tests:
1243         * Scripts/build-dumprendertree:
1244         * Scripts/build-jsc:
1245         (buildMyProject):
1246         * Scripts/build-layouttestrelay:
1247         * Scripts/build-webkit:
1248         * Scripts/build-webkittestrunner:
1249         * Scripts/run-api-tests:
1250         (isSupportedPlatform):
1251         (runTest):
1252         (listAllTests):
1253         (prepareEnvironmentForRunningTestTool):
1254         * Scripts/run-content-extension-tester:
1255         * Scripts/run-javascriptcore-tests:
1256         * Scripts/run-minibrowser:
1257         * Scripts/show-pretty-diff:
1258         * Scripts/webkitdirs.pm:
1259         (determineBaseProductDir):
1260         (determineArchitecture):
1261         (determinePassedArchitecture):
1262         (safariPath):
1263         (builtDylibPathForName):
1264         (checkFrameworks):
1265         (isAppleWebKit):
1266         (isAppleCocoaWebKit):
1267         (determineNmPath):
1268         (launcherName):
1269         (wrapperPrefixIfNeeded):
1270         (isCMakeBuild):
1271         (mobileSafariBundle):
1272         (debugSafari):
1273         (runSafari):
1274         (runMiniBrowser):
1275         (debugMiniBrowser):
1276         (runWebKitTestRunner):
1277         (debugWebKitTestRunner):
1278         (isAppleMacWebKit): Deleted.
1279         * Scripts/webkitperl/FeatureList.pm:
1280
1281 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1282
1283         Revert r211991
1284         https://bugs.webkit.org/show_bug.cgi?id=168062
1285
1286         * Scripts/build-webkit:
1287         Not quite ready yet.
1288
1289 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1290
1291         Build libwebrtc on bots without using it yet
1292         https://bugs.webkit.org/show_bug.cgi?id=168062
1293
1294         Reviewed by Brent Fulgham.
1295
1296         * Scripts/build-webkit:
1297         Build libwebrtc on Mac when we build ANGLE.
1298
1299 2017-02-09  Youenn Fablet  <youenn@apple.com>
1300
1301         Improve W3C importer command line options
1302         https://bugs.webkit.org/show_bug.cgi?id=167448
1303
1304         Reviewed by Ryosuke Niwa.
1305
1306         Making the list of test paths to import the main arguments of the script.
1307         Allow passing the source directory to import as a -s option.
1308         Adding a warning when given test paths are skipped by default in ImportExpectations.
1309
1310         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1311         Link conversion rules do not change when imported tests are downloaded by the script.
1312
1313         * Scripts/webkitpy/w3c/test_importer.py:
1314         (main):
1315         (parse_args):
1316         (TestImporter.__init__):
1317         (TestImporter.do_import):
1318         (TestImporter):
1319         (TestImporter.check_imported_expectations):
1320
1321 2017-02-08  Chris Dumez  <cdumez@apple.com>
1322
1323         Update web-platform-tests resources
1324         https://bugs.webkit.org/show_bug.cgi?id=168026
1325
1326         Reviewed by Youenn Fablet.
1327
1328         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1329
1330         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1331         (WebPlatformTestServer._copy_webkit_test_files):
1332
1333 2017-02-08  Andy Estes  <aestes@apple.com>
1334
1335         Custom protocols should not continue loading after a network process crash
1336         https://bugs.webkit.org/show_bug.cgi?id=168028
1337         <rdar://problem/27607520>
1338
1339         Reviewed by Brady Eidson.
1340
1341         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1342         (processGroup):
1343         (-[CloseWhileStartingProtocol startLoading]):
1344         (-[CloseWhileStartingProtocol stopLoading]):
1345         (TestWebKitAPI::runTest):
1346         (TestWebKitAPI::TEST):
1347
1348 2017-02-08  Dan Bernstein  <mitz@apple.com>
1349
1350         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1351         https://bugs.webkit.org/show_bug.cgi?id=168031
1352
1353         Reviewed by Tim Horton.
1354
1355         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1356         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1357         (TEST):
1358         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1359         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1360
1361 2017-02-08  Chris Dumez  <cdumez@apple.com>
1362
1363         Use smaller tiles in windows that are not active to facilitate App Napping
1364         https://bugs.webkit.org/show_bug.cgi?id=167997
1365         <rdar://problem/30358835>
1366
1367         Reviewed by Simon Fraser.
1368
1369         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1370         (WTR::PlatformWebView::setWindowIsKey):
1371         Actually update windowIsKey state of NSWindow so the WebView
1372         properly updates its activity state.
1373
1374 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1375
1376         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1377         https://bugs.webkit.org/show_bug.cgi?id=167942
1378         <rdar://problem/30315079>
1379
1380         Reviewed by Tim Horton.
1381
1382         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1383         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1384         contenteditable in these cases.
1385
1386         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1387         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1388         performDragOperation:) directly.
1389
1390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1391         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1392         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1393         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1394         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1395         (-[DragSource draggingSourceOperationMaskForLocal:]):
1396         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1397         (-[DragInfo lastMousePosition]):
1398         (-[DragInfo setLastMousePosition:]):
1399         (-[DragInfo draggingDestinationWindow]):
1400         (-[DragInfo draggingSourceOperationMask]):
1401         (-[DragInfo draggingLocation]):
1402         (-[DragInfo draggedImageLocation]):
1403         (-[DragInfo draggedImage]):
1404         (-[DragInfo draggingPasteboard]):
1405         (-[DragInfo draggingSource]):
1406         (-[DragInfo draggingSequenceNumber]):
1407         (-[DragInfo slideDraggedImageTo:]):
1408         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1409         (-[DragInfo draggingFormation]):
1410         (-[DragInfo setDraggingFormation:]):
1411         (-[DragInfo animatesToDestination]):
1412         (-[DragInfo setAnimatesToDestination:]):
1413         (-[DragInfo numberOfValidItemsForDrop]):
1414         (-[DragInfo setNumberOfValidItemsForDrop:]):
1415         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1416         (-[DragInfo springLoadingHighlight]):
1417         (-[DragInfo resetSpringLoading]):
1418         (TestWebKitAPI::getTestImage):
1419         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1420         (TestWebKitAPI::TEST):
1421         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1422
1423 2017-02-08  Jer Noble  <jer.noble@apple.com>
1424
1425         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1426         https://bugs.webkit.org/show_bug.cgi?id=168007
1427
1428         Reviewed by Alex Christensen.
1429
1430         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1431         (didFinishLoadForFrame):
1432         (TestWebKitAPI::TEST):
1433
1434 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1435
1436         Unreviewed, rolling out r211873.
1437         https://bugs.webkit.org/show_bug.cgi?id=168001
1438
1439         It's in jhbuild for consistent layout tests (Requested by
1440         mcatanzaro on #webkit).
1441
1442         Reverted changeset:
1443
1444         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1445         https://bugs.webkit.org/show_bug.cgi?id=167993
1446         http://trac.webkit.org/changeset/211873
1447
1448 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1449
1450         [GTK] Add icu packages to Tools/gtk/install-dependencies
1451         https://bugs.webkit.org/show_bug.cgi?id=167993
1452
1453         Reviewed by Michael Catanzaro.
1454
1455         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1456         depending in the GNU/Linux distribution)
1457
1458 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1459
1460         Update flakiness dashboard configuration.
1461         https://bugs.webkit.org/show_bug.cgi?id=167957
1462
1463         Reviewed by Alexey Proskuryakov.
1464
1465         * TestResultServer/static-dashboards/builders.jsonp:
1466
1467 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1468
1469         Replace a bot that has an incorrect configuration.
1470         https://bugs.webkit.org/show_bug.cgi?id=167747
1471
1472         Rubber-stamped by Alexey Proskuryakov.
1473
1474         * BuildSlaveSupport/build.webkit.org-config/config.json:
1475
1476 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1477
1478         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1479         https://bugs.webkit.org/show_bug.cgi?id=167927
1480
1481         Reviewed by Brent Fulgham.
1482
1483         Enable ComplexTextController API tests on the Win and GTK ports.
1484
1485         * TestWebKitAPI/PlatformGTK.cmake:
1486         * TestWebKitAPI/PlatformWin.cmake:
1487
1488 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1489
1490         File index appended to previous file in svn-create-patch with SVN 1.9
1491         https://bugs.webkit.org/show_bug.cgi?id=167903
1492         <rdar://problem/30387395>
1493
1494         Reviewed by Daniel Bates.
1495
1496         * Scripts/VCSUtils.pm:
1497         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1498         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1499         trailing newline character from the expected result before comparing it to the actual result.
1500
1501 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1502
1503         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1504         https://bugs.webkit.org/show_bug.cgi?id=167936
1505
1506         Reviewed by Michael Catanzaro.
1507
1508         * Scripts/webkitdirs.pm:
1509         (determineArchitecture):
1510         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1511         since r195083.
1512
1513 2017-02-07  Youenn Fablet  <youenn@apple.com>
1514
1515         Use a JSON file to define which WPT files/folders to import
1516         https://bugs.webkit.org/show_bug.cgi?id=167923
1517
1518         Reviewed by Alex Christensen.
1519
1520         * Scripts/webkitpy/w3c/test_downloader.py:
1521         (TestDownloader.__init__):
1522         (TestDownloader._init_paths_from_expectations):
1523         * Scripts/webkitpy/w3c/test_importer.py:
1524         (parse_args):
1525         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1526
1527 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1528
1529         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1530         https://bugs.webkit.org/show_bug.cgi?id=167916
1531
1532         Reviewed by Carlos Garcia Campos.
1533
1534         URL of mesa-11.0.6.tar.xz has been moved.
1535
1536         * gtk/jhbuild.modules: Fix the module path.
1537
1538 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1539
1540         Static Analyzer: Address some leaks in MiniBrowser
1541         https://bugs.webkit.org/show_bug.cgi?id=167897
1542
1543         Reviewed by Alexey Proskuryakov.
1544
1545         * MiniBrowser/mac/BrowserWindowController.m:
1546         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1547         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1548         (-[ExtensionManagerWindowController add:]):
1549         (-[ExtensionManagerWindowController remove:]):
1550         * MiniBrowser/mac/SettingsController.m:
1551         (-[SettingsController _populateMenu]):
1552         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1553         Address obvious leaks caught by the static analyzer.
1554
1555 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1556
1557         Migrate ComplexTextController to use platform-independent types
1558         https://bugs.webkit.org/show_bug.cgi?id=167833
1559
1560         Reviewed by Brent Fulgham.
1561
1562         Migrate tests away from platform-dependent types.
1563
1564         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1565         (TestWebKitAPI::TEST_F):
1566
1567 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1568
1569         Correct File Path Handling in SecurityOrigin and FileSystem
1570         https://bugs.webkit.org/show_bug.cgi?id=167894
1571         <rdar://problem/30380080>
1572
1573         Reviewed by Alexey Proskuryakov.
1574
1575         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1576         and perform same-volume checks using filesystem-compatible paths.        
1577         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1578         filesystem paths, and perform validation of same-volume checks.
1579         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1580         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1581         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1582         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1583
1584 2017-02-06  Jer Noble  <jer.noble@apple.com>
1585
1586         Playback stalls when a SourceBuffer append causes frame eviction
1587         https://bugs.webkit.org/show_bug.cgi?id=167834
1588
1589         Reviewed by Eric Carlson.
1590
1591         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1592         for the WTF::MediaTime class.
1593
1594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1595         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1596         (TestWebKitAPI::TEST):
1597         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1598         (WTF::operator<<):
1599         (TestWebKitAPI::TestSample::create):
1600         (TestWebKitAPI::TestSample::TestSample):
1601         (TestWebKitAPI::TEST_F):
1602
1603 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1604
1605         Change capitalization in platform name after r211735.
1606
1607         Unreviewed dashboard fix.
1608
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1610         (WebKitBuildbot):
1611
1612 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1613
1614         Move the Leaks bot to Sierra
1615         https://bugs.webkit.org/show_bug.cgi?id=167886
1616
1617         Reviewed by Daniel Bates.
1618
1619         * BuildSlaveSupport/build.webkit.org-config/config.json:
1620         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1621         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1622         (LeaksViewer._displayURLPrompt):
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1624         (WebKitBuildbot):
1625
1626 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1627
1628         Prevent app crash on launch during simctl install workaround
1629         https://bugs.webkit.org/show_bug.cgi?id=167685
1630
1631         Reviewed by Daniel Bates.
1632
1633         * Scripts/webkitpy/port/simulator_process.py:
1634         (SimulatorProcess.__init__): Pass environment to install.
1635         * Scripts/webkitpy/xcode/simulator.py:
1636         (Device.install_app): Accept environment, pass environment to launch.
1637
1638 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1639
1640         Rebase API tests after r211638
1641         https://bugs.webkit.org/show_bug.cgi?id=167779
1642
1643         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1644         (TestWebKitAPI::TEST_F):
1645         URLs with non-special schemes and characters like % in the host now fail to parse,
1646         more like their special counterparts and according to spec.
1647
1648 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1649
1650         Unreviewed trivial fix after r211697.
1651         https://bugs.webkit.org/show_bug.cgi?id=167863
1652
1653         * Scripts/run-javascriptcore-tests:
1654         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1655
1656 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1657
1658         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1659         https://bugs.webkit.org/show_bug.cgi?id=167850
1660
1661         Reviewed by Tim Horton.
1662
1663         * DumpRenderTree/TestRunner.cpp:
1664         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1665
1666 2017-02-04  Andreas Kling  <akling@apple.com>
1667
1668         Plug some leaks in TestController and UIScriptContext.
1669         <https://webkit.org/b/167839>
1670
1671         Reviewed by Alexey Proskuryakov.
1672
1673         Fix a couple of the leaks seen on the leaks bot.
1674
1675         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1676         (UIScriptContext::runUIScript):
1677         * WebKitTestRunner/TestController.cpp:
1678         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1679         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1680
1681 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1682
1683         WK1 mouse events are missing movementX and movementY for pointerlock.
1684         https://bugs.webkit.org/show_bug.cgi?id=167775
1685         rdar://problem/30343810
1686
1687         Reviewed by Alexey Proskuryakov.
1688
1689         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1690
1691         * DumpRenderTree/mac/EventSendingController.mm:
1692         (-[EventSendingController mouseMoveToX:Y:]):
1693         * WebKitTestRunner/mac/EventSenderProxy.mm:
1694         (WTR::EventSenderProxy::mouseMoveTo):
1695
1696 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1697
1698         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1699         https://bugs.webkit.org/show_bug.cgi?id=167774
1700
1701         Reviewed by Tim Horton.
1702
1703         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1704         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1705         web process are async, so the callback fires after the web process gets the new state.
1706
1707         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1708         (WTR::UIScriptController::removeViewFromWindow):
1709         (WTR::UIScriptController::addViewToWindow):
1710         * DumpRenderTree/mac/DumpRenderTree.mm:
1711         (createWebViewAndOffscreenWindow):
1712         (resetWebViewToConsistentStateBeforeTesting):
1713         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1714         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1715         (WTR::UIScriptController::removeViewFromWindow):
1716         (WTR::UIScriptController::addViewToWindow):
1717         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1718         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1719         (WTR::UIScriptController::removeViewFromWindow):
1720         (WTR::UIScriptController::addViewToWindow):
1721         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1722         * WebKitTestRunner/PlatformWebView.h:
1723         * WebKitTestRunner/TestController.cpp:
1724         (WTR::TestController::resetStateToConsistentValues):
1725         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1726         (WTR::PlatformWebView::removeFromWindow):
1727         (WTR::PlatformWebView::addToWindow):
1728         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1729         (WTR::UIScriptController::removeViewFromWindow):
1730         (WTR::UIScriptController::addViewToWindow):
1731         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1732         (WTR::PlatformWebView::removeFromWindow):
1733         (WTR::PlatformWebView::addToWindow):
1734         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1735         (WTR::UIScriptController::removeViewFromWindow):
1736         (WTR::UIScriptController::addViewToWindow):
1737
1738 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1739
1740         Remove check for SkipSafariExecutableEntitlementChecks
1741         https://bugs.webkit.org/show_bug.cgi?id=167762
1742
1743         Reviewed by Dan Bernstein.
1744
1745         Follow-up fix: don't break internal behavior.
1746
1747         * Scripts/webkitdirs.pm:
1748         (safariPath):
1749         (executableHasEntitlements): Deleted.
1750         (safariPathFromSafariBundle): Deleted.
1751         (installedSafariPath): Deleted.
1752
1753 2017-02-03  Daniel Bates  <dabates@apple.com>
1754
1755         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1756         https://bugs.webkit.org/show_bug.cgi?id=167810
1757         <rdar://problem/30102568>
1758
1759         Reviewed by Anders Carlsson.
1760
1761         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1762
1763         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1764         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1765         (TEST):
1766         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1767         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1768         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1769         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1770
1771 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1772
1773         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1774         https://bugs.webkit.org/show_bug.cgi?id=167773
1775         <rdar://problem/30221102>
1776
1777         Reviewed by Ryosuke Niwa.
1778
1779         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1780         (TestWebKitAPI::TEST_F):
1781
1782 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1783
1784         Remove check for SkipSafariExecutableEntitlementChecks
1785         https://bugs.webkit.org/show_bug.cgi?id=167762
1786         rdar://problem/22480673
1787
1788         Reviewed by Dan Bernstein.
1789
1790         * Scripts/webkitdirs.pm:
1791         (safariPathFromSafariBundle):
1792         (skipSafariExecutableEntitlementChecks): Deleted.
1793
1794 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1795
1796         Undefined subroutine in svn-create-patch
1797         https://bugs.webkit.org/show_bug.cgi?id=167742
1798
1799         Unreviewed build-fix after r211543.
1800
1801         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1802
1803 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1804
1805         Unreviewed. Fix jhbuild dependencies build.
1806
1807         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1808         Patch updated.
1809
1810 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1811
1812         [EME][GStreamer] Fixed decryptor selection
1813         https://bugs.webkit.org/show_bug.cgi?id=167588
1814
1815         Reviewed by Žan Doberšek.
1816
1817         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1818
1819         * gtk/jhbuild.modules: Added patches to gstreamer and
1820         gst-plugins-good packages.
1821         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1822         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1823
1824 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1825
1826         Make run-benchmark script supports 'config' key in test plan.
1827         https://bugs.webkit.org/show_bug.cgi?id=167715
1828
1829         Reviewed by Ryosuke Niwa.
1830
1831         Add support for 'config' key in test paln.
1832         'config' key is a dictionary that specifies environment configurations while test is running.
1833         Specifies orientation to be portrait in MotionMark benchmark.
1834
1835         * Scripts/webkitpy/benchmark_runner/README.md:
1836         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1837         (BenchmarkRunner.__init__):
1838         (BenchmarkRunner._run_benchmark):
1839         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1840         (BrowserDriver.prepare_env):
1841         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1842         (LinuxBrowserDriver.prepare_env):
1843         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1844         (OSXBrowserDriver.prepare_env):
1845         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1846         (OSXSafariDriver.prepare_env):
1847         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1848
1849 2017-02-01  Daniel Bates  <dabates@apple.com>
1850
1851         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1852         https://bugs.webkit.org/show_bug.cgi?id=167169
1853
1854         Reviewed by David Kilzer.
1855
1856         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1857         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1858         header from the output of "svn diff" on a file that was copied or moved.
1859
1860         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1861         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1862         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1863         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1864         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1865         of a file with only a property change also does not contain any chunk range lines. Therefore
1866         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1867         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1868         we should directly test for the presence of a leading SVN diff header with an empty body and
1869         remove such lines from the diff.
1870
1871         * Scripts/VCSUtils.pm:
1872         (fixSVNPatchForAdditionWithHistory): Added.
1873         * Scripts/svn-create-patch:
1874         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1875         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1876         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1877
1878 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1879
1880         [Mac] Update CARingBuffer class
1881         https://bugs.webkit.org/show_bug.cgi?id=167656
1882
1883         Reviewed by Jer Noble.
1884
1885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1886         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1887         (TestWebKitAPI::CARingBufferTest::SetUp):
1888         (TestWebKitAPI::CARingBufferTest::setup):
1889         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1890         (TestWebKitAPI::CARingBufferTest::description):
1891         (TestWebKitAPI::CARingBufferTest::bufferList):
1892         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1893         (TestWebKitAPI::CARingBufferTest::capacity):
1894         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1895         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1896         (TestWebKitAPI::TEST_F):
1897         (TestWebKitAPI::MixingTest::run):
1898
1899 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1900
1901         [Mac] TestWebKitAPI includes system frameworks incorrectly
1902         https://bugs.webkit.org/show_bug.cgi?id=167703
1903         rdar://problem/30301498
1904
1905         Reviewed by Ryosuke Niwa.
1906
1907         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1908         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1909
1910         Also, reduced the number of subframework search paths, looks like we only need one now.
1911
1912         * TestWebKitAPI/Configurations/Base.xcconfig:
1913
1914 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1915
1916         Correct "filesHaveSameVolume" predicate
1917         https://bugs.webkit.org/show_bug.cgi?id=167696
1918         <rdar://problem/30298722>
1919
1920         Reviewed by David Kilzer.
1921
1922         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1923         percent-escaped path inputs.
1924
1925         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1926         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1927         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1928         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1929         (TestWebKitAPI::TEST_F):
1930
1931 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1932
1933         Unreviewed. Fix coding style in MiniBrowser
1934
1935         * MiniBrowser/gtk/BrowserWindow.c:
1936         (editingCommandCallback):
1937         (insertImageCommandCallback):
1938         (insertLinkCommandCallback):
1939
1940 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1941
1942         [GTK] Add an API to add a custom tab into the print dialog
1943         https://bugs.webkit.org/show_bug.cgi?id=151998
1944
1945         Reviewed by Carlos Garcia Campos.
1946
1947         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1948         that is testing a newly added API.
1949
1950         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1951         (testPrintCustomWidget):
1952         (beforeAll):
1953
1954 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1955
1956         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1957         https://bugs.webkit.org/show_bug.cgi?id=166529
1958
1959         Reviewed by Xabier Rodriguez-Calvar.
1960
1961         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1962         New patch version accepted in GStreamer upstream.
1963
1964 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1965
1966         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1967         https://bugs.webkit.org/show_bug.cgi?id=167498
1968
1969         Reviewed by Carlos Garcia Campos.
1970
1971         Depending on the distro version you can need either libxfont1-dev
1972         or libfont-dev to build with jhbuild.
1973
1974         * gtk/install-dependencies:
1975
1976 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1977
1978         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1979         https://bugs.webkit.org/show_bug.cgi?id=167594
1980
1981         Unreviewed test gardening.
1982
1983         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1984
1985         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1986         (TEST):
1987
1988 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1989
1990         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1991         https://bugs.webkit.org/show_bug.cgi?id=167676
1992
1993         Reviewed by Saam Barati.
1994
1995         * Scripts/run-javascriptcore-tests:
1996         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1997
1998 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1999
2000         Make Dump Render Tree not crash
2001         https://bugs.webkit.org/show_bug.cgi?id=167667
2002
2003         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
2004         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
2005         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
2006         This does not fix any tests, it just fixes the crash.
2007         
2008         Reviewed by Simon Fraser.
2009
2010         * DumpRenderTree/TestRunner.cpp:
2011         (TestRunner::callUIScriptCallback):
2012
2013 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2014
2015         Workaround for simctl install failing to report install failure
2016         https://bugs.webkit.org/show_bug.cgi?id=167654
2017
2018         Reviewed by Daniel Bates.
2019
2020         simctl install will sometimes report success even though install has failed.
2021         To workaround this bug, we attempt an app launch after install to ensure
2022         install has succeeded.
2023
2024         * Scripts/webkitpy/xcode/simulator.py:
2025         (Device.install_app): Attempt app launch after install, retry install if launch fails.
2026         (Device.launch_app): Correct comment.
2027
2028 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2029
2030         Unreviewed webkitpy fix after r211405.
2031
2032         * Scripts/webkitpy/xcode/simulator.py:
2033         (Device.launch_app): Remove @staticmethod on _log_debug_error.
2034
2035 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2036
2037         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
2038
2039         * gtk/manifest.txt.in:
2040
2041 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
2042
2043         AX: enable search predication for iOS
2044         https://bugs.webkit.org/show_bug.cgi?id=167558
2045         <rdar://problem/30251367>
2046
2047         Reviewed by Joanmarie Diggs.
2048
2049         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2050         (AccessibilityUIElement::uiElementForSearchPredicate):
2051         * DumpRenderTree/mac/AccessibilityCommonMac.h:
2052         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2053         (searchPredicateParameterizedAttributeForSearchCriteria):
2054         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2055         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2056         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2057         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2058         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2059         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2060         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2061         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2062         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2063         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2064         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2065
2066 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2067
2068         Workaround for simctl launch bug
2069         https://bugs.webkit.org/show_bug.cgi?id=167613
2070
2071         Reviewed by Daniel Bates.
2072
2073         simctl launch will sometimes fail because of a race condition when many
2074         simulators are being run simultaneously. These failures will always have
2075         an exit code of 1. This change attempts to launch an app multiple times
2076         before reporting a failure to workaround this bug.
2077
2078         * Scripts/webkitpy/xcode/simulator.py:
2079         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
2080
2081 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
2082
2083         Commit queue fails to look at real name aliases for the reviewer
2084         https://bugs.webkit.org/show_bug.cgi?id=167422
2085
2086         Reviewed by Joseph Pecoraro.
2087
2088         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2089         (test_has_valid_reviewer): Added tests.
2090
2091         * Scripts/webkitpy/common/config/committers.py:
2092         (CommitterList._name_to_contributor_map):
2093         Made _name_to_contributor_map include alias names.
2094
2095         * Scripts/webkitpy/common/config/committers_unittest.py:
2096         (CommittersTest.test_contributors_by_fuzzy_match):
2097         Removed subtests that are now obsolete, as these matches are strict. It is not
2098         obvious if distance based fuzzy matching for names is useful at all, but we can
2099         look into that some other time.
2100
2101 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
2102
2103         QueueStatusServer should have an explicit timeout for _fetch_url
2104         https://bugs.webkit.org/show_bug.cgi?id=167467
2105
2106         Reviewed by Alexey Proskuryakov.
2107
2108         * Scripts/webkitpy/common/net/statusserver.py:
2109         (StatusServer._fetch_url): Add an explicit timeout of 300s.
2110
2111 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
2112
2113         Add support for Trac instances that host multiple projects.
2114         https://bugs.webkit.org/show_bug.cgi?id=167524
2115
2116         Reviewed by Alexey Proskuryakov.
2117
2118         When multiple projects are hosted on a single Trac instance, the current
2119         behavior will retrieve changesets from all tracked projects.
2120         This patch teaches Trac.js to get project-specific changesets from Trac.
2121         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
2122         when querying the Trac timeline.
2123
2124         To tell Trac to be aware of multi-project instances we leverage the 
2125         `options` parameter when creating a new instance: 
2126
2127             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
2128
2129         If this option is not provided, the original behaviour will prevail.
2130         Additionally, add corresponding tests.
2131
2132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2133         (Trac): Reason about new optional parameter 'projectIdentifier'.
2134         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
2135         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
2136         replace default parameter `changeset=on` with `repo-projectname=on`.
2137         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
2138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2139         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
2140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2141         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
2142         Add the following tests:
2143             test("revisionURL")
2144             test("revisionURL with Trac Identifier")
2145             test("_xmlTimelineURL")
2146             test("_xmlTimelineURL with Trac Identifier")
2147         (this.view._latestProductiveIteration): Fix missing ';'.
2148
2149 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
2150
2151         Correct spacing regression on inter-element complex path shaping on some fonts
2152         https://bugs.webkit.org/show_bug.cgi?id=166013
2153
2154         Reviewed by Simon Fraser.
2155
2156         Unskip existing tests and make some new tests:
2157         - Testing complex text with no origins
2158         - Testing initial expansions
2159         - Testing the sign of vertical advances
2160
2161         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2162         (TestWebKitAPI::TEST_F):
2163
2164 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2165
2166         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
2167         https://bugs.webkit.org/show_bug.cgi?id=167596
2168
2169         Reviewed by Daniel Bates.
2170
2171         We avoid needing a thin directory by invoking the zip program with
2172         the list of directories from the build directory to be zipped,
2173         and by using the zip feature to exclude files matching a pattern.
2174
2175         * BuildSlaveSupport/built-product-archive:
2176         (copyBuildFiles):
2177         (createZipFromList):
2178         (archiveBuiltProduct):
2179
2180 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2181
2182         Use simctl instead of LayoutTestRelay
2183         https://bugs.webkit.org/show_bug.cgi?id=165927
2184
2185         Reviewed by Daniel Bates.
2186
2187         Part 1
2188
2189         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
2190         simulators through simctl (iOS 10 and later), use this functionality instead.
2191
2192         * Scripts/webkitpy/port/base.py:
2193         (Port.__init__): Added _test_runner_process_constructor.
2194         * Scripts/webkitpy/port/darwin.py:
2195         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
2196         * Scripts/webkitpy/port/driver.py:
2197         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
2198         (IOSSimulatorDriver): Deleted.
2199         * Scripts/webkitpy/port/driver_unittest.py:
2200         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
2201         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
2202         (DriverTest.test_start_actually_starts): Ditto.
2203         * Scripts/webkitpy/port/ios.py:
2204         (IOSSimulatorPort): Remove relay_name.
2205         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
2206         (IOSSimulatorPort._create_simulators): Formatting change.
2207         (IOSSimulatorPort.relay_path): Deleted.
2208         (IOSSimulatorPort._check_relay): Deleted.
2209         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
2210         (IOSSimulatorPort._build_relay): Deleted.
2211         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
2212         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
2213         * Scripts/webkitpy/port/ios_unittest.py:
2214         (iosTest.test_32bit): Update test.
2215         (iosTest.test_64bit): Update test.
2216         * Scripts/webkitpy/port/server_process.py:
2217         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
2218         (ServerProcess._set_file_nonblocking): Added to share common code.
2219         * Scripts/webkitpy/port/server_process_mock.py:
2220         (MockServerProcess.__init__): Added argument worker_number.
2221         * Scripts/webkitpy/port/simulator_process.py: Added.
2222         (SimulatorProcess): Added.
2223         (SimulatorProcess.Popen): Added.
2224         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
2225         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
2226         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
2227         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
2228         (SimulatorProcess._reset): Added. Unlink fifos.
2229         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
2230         (SimulatorProcess._kill): Added. Shutdown app on simulator.
2231         * Scripts/webkitpy/xcode/simulator.py:
2232         (Device.__init__): Accept host to run install/launch/terminate.
2233         (Device.install_app): Install app to target Device.
2234         (Device.launch_app): Launch app on target Device.
2235         (Device.terminate_app): Shutdown app on target Device.
2236         (Simulator._parse_devices): Pass host to Device.
2237
2238 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2239
2240         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
2241         https://bugs.webkit.org/show_bug.cgi?id=167411
2242
2243         Reviewed by Michael Catanzaro.
2244
2245         Disable the ARM iwMMXt fast path for pixman, because it triggers
2246         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
2247
2248         * gtk/jhbuild.modules:
2249
2250 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2251
2252         [GTK] Add API to handle the accelerated compositing policy
2253         https://bugs.webkit.org/show_bug.cgi?id=167509
2254
2255         Reviewed by Michael Catanzaro.
2256
2257         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
2258         as a special case. Also add test cases to the get/set API.
2259
2260         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2261         (hardwareAccelerationPolicyToString):
2262         (stringToHardwareAccelerationPolicy):
2263         (cellRendererChanged):
2264         (browserSettingsDialogConstructed):
2265         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2266         (testWebKitSettings):
2267
2268 2017-01-29  Andy Estes  <aestes@apple.com>
2269
2270         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2271         https://bugs.webkit.org/show_bug.cgi?id=167563
2272         <rdar://problem/30253207>
2273
2274         Reviewed by Andreas Kling.
2275
2276         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2277         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2278         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2279         (runTest):
2280         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2281         (TEST):
2282
2283 2017-01-29  Dan Bernstein  <mitz@apple.com>
2284
2285         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2286         https://bugs.webkit.org/show_bug.cgi?id=167565
2287
2288         Reviewed by Sam Weinig.
2289
2290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2291         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2292         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2293         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2294         (TEST):
2295         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2296         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2297         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2298         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2299
2300 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2301
2302         Add Link Preload as an off-by-default experimental feature menu item.
2303         https://bugs.webkit.org/show_bug.cgi?id=167201
2304
2305         Reviewed by Ryosuke Niwa.
2306
2307         * DumpRenderTree/mac/DumpRenderTree.mm:
2308         (resetWebPreferencesToConsistentValues):
2309         * DumpRenderTree/win/DumpRenderTree.cpp:
2310         (resetWebPreferencesToConsistentValues):
2311
2312 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2313
2314         Add User Timing Experimental Feature
2315         https://bugs.webkit.org/show_bug.cgi?id=167542
2316         <rdar://problem/22746307>
2317
2318         Reviewed by Ryosuke Niwa.
2319
2320         * DumpRenderTree/mac/DumpRenderTree.mm:
2321         (enableExperimentalFeatures):
2322         (resetWebPreferencesToConsistentValues):
2323         * DumpRenderTree/win/DumpRenderTree.cpp:
2324         (enableExperimentalFeatures):
2325
2326 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2327
2328         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2329         https://bugs.webkit.org/show_bug.cgi?id=167519
2330
2331         Reviewed by Ryosuke Niwa.
2332
2333         * QueueStatusServer/templates/statusbubble.html:
2334         To measure the bubbleContainer's width, it must not be wrapping based
2335         on its parent container. So when measuring the width temporarily set
2336         the parent to a very large width so as to not artificially wrap us.
2337         Restore the parent's width after measuring.
2338
2339 2017-01-27  Andy Estes  <aestes@apple.com>
2340
2341         [iOS] Add a test for _WKNSFileManagerExtras
2342         https://bugs.webkit.org/show_bug.cgi?id=167478
2343
2344         Reviewed by Andreas Kling.
2345
2346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2347         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2348         (expectAttributes):
2349         (TEST):
2350
2351 2017-01-27  Keith Miller  <keith_miller@apple.com>
2352
2353         run-benchmarks should make sure it passes the test url to the right application
2354         https://bugs.webkit.org/show_bug.cgi?id=167533
2355
2356         Reviewed by Joseph Pecoraro.
2357
2358         This fixes an issue when trying to run-benchmark script with the
2359         system default browser set to STP. Previously, it would run
2360         the test in STP rather than the provided build. Now, it should run
2361         in the provided build.
2362
2363         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2364         (OSXSafariDriver.launch_url):
2365
2366 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2367
2368         [Cocoa] Prepare ComplexTextController for unit testing
2369         https://bugs.webkit.org/show_bug.cgi?id=167493
2370
2371         Reviewed by Simon Fraser.
2372
2373         Addressing post-review comments from Simon Fraser.
2374
2375         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2376         (TestWebKitAPI::TEST_F):
2377
2378 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2379
2380         [Cocoa] Prepare ComplexTextController for unit testing
2381         https://bugs.webkit.org/show_bug.cgi?id=167493
2382
2383         Reviewed by Dean Jackson.
2384
2385         Create four unit tests.
2386
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2389         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2390         (TestWebKitAPI::TEST_F):
2391
2392 2017-01-26  Chris Dumez  <cdumez@apple.com>
2393
2394         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2395         https://bugs.webkit.org/show_bug.cgi?id=167421
2396         <rdar://problem/30188490>
2397
2398         Reviewed by Darin Adler.
2399
2400         Add a new setting allowing layout tests to enable PageCache in a window
2401         that has an opener, for convenience.
2402
2403         * DumpRenderTree/mac/DumpRenderTree.mm:
2404         (resetWebPreferencesToConsistentValues):
2405         * DumpRenderTree/win/DumpRenderTree.cpp:
2406         (resetWebPreferencesToConsistentValues):
2407         * WebKitTestRunner/TestController.cpp:
2408         (WTR::TestController::resetPreferencesToConsistentValues):
2409
2410 2017-01-26  Keith Miller  <keith_miller@apple.com>
2411
2412         classInfo should take a VM so it is not materialized from the object on each call
2413         https://bugs.webkit.org/show_bug.cgi?id=167424
2414
2415         Rubber Stamped by Michael Saboff.
2416
2417         Previously, classInfo() would get the VM from the target's
2418         MarkedBlock.  Most callers already have a VM on hand, so it is
2419         wasteful to compute the VM from the marked block every time. This
2420         patch refactors some of the most common callers of classInfo(),
2421         jsDynamicCast and inherits to take a VM as well.
2422
2423         * DumpRenderTree/TestRunner.cpp:
2424         (setAudioResultCallback):
2425
2426 2017-01-26  Jer Noble  <jer.noble@apple.com>
2427
2428         Autoplay muted videos stop playback of any streaming app in the background
2429         https://bugs.webkit.org/show_bug.cgi?id=163993
2430         <rdar://problem/29020431>
2431
2432         Reviewed by Eric Carlson.
2433
2434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2435         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2436         (TestWebKitAPI::TEST):
2437         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2438
2439 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2440
2441         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2442         https://bugs.webkit.org/show_bug.cgi?id=167466
2443
2444         Unreviewed test gardening.
2445
2446         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2447         (TEST):
2448
2449 2017-01-26  Matt Rajca  <mrajca@apple.com>
2450
2451         Notify clients when the user plays media otherwise prevented from autoplaying
2452         https://bugs.webkit.org/show_bug.cgi?id=167390
2453
2454         Reviewed by Alex Christensen.
2455
2456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2457         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2458         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2459         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2460         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2461         (TEST):
2462         * TestWebKitAPI/cocoa/TestWKWebView.h:
2463         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2464         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2465         (-[TestWKWebView waitForLoad]):
2466         (-[TestWKWebView mouseUpAtPoint:]):
2467         * WebKitTestRunner/TestController.cpp:
2468         (WTR::TestController::createOtherPage):
2469         (WTR::TestController::createWebViewWithOptions):
2470
2471 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2472
2473         Crash when setting custom scale factor.
2474         https://bugs.webkit.org/show_bug.cgi?id=167369
2475
2476         Reviewed by Sam Weinig.
2477
2478         Added API test.
2479
2480         * TestWebKitAPI/PlatformWin.cmake:
2481         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2482         (TestWebKitAPI::WebKitCreateInstance):
2483         (TestWebKitAPI::ScaleWebView::SetUp):
2484         (TestWebKitAPI::ScaleWebView::TearDown):
2485         (TestWebKitAPI::TEST_F):
2486
2487 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2488
2489         run-benchmark nests MotionMark results by the suite name twice
2490         https://bugs.webkit.org/show_bug.cgi?id=164948
2491
2492         Reviewed by Said Abou-Hallawa.
2493
2494         Use a single level MotionMark now that this is the name of the benchmark,
2495         and we no longer have tests that aren't part of the MotionMark suite.
2496
2497         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2498
2499 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2500
2501         Unreviewed, rolling out r211193.
2502
2503         This change broke internal builds.
2504
2505         Reverted changeset:
2506
2507         "Notify clients when the user plays media otherwise prevented
2508         from autoplaying"
2509         https://bugs.webkit.org/show_bug.cgi?id=167390
2510         http://trac.webkit.org/changeset/211193
2511
2512 2017-01-25  Matt Rajca  <mrajca@apple.com>
2513
2514         Notify clients when the user plays media otherwise prevented from autoplaying
2515         https://bugs.webkit.org/show_bug.cgi?id=167390
2516
2517         Reviewed by Alex Christensen.
2518
2519         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2520         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2521         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2522         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2523         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2524         (TEST):
2525         * TestWebKitAPI/cocoa/TestWKWebView.h:
2526         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2527         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2528         (-[TestWKWebView waitForLoad]):
2529         (-[TestWKWebView mouseUpAtPoint:]):
2530         * WebKitTestRunner/TestController.cpp:
2531         (WTR::TestController::createOtherPage):
2532         (WTR::TestController::createWebViewWithOptions):
2533
2534 2017-01-25  Matt Rajca  <mrajca@apple.com>
2535
2536         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2537         https://bugs.webkit.org/show_bug.cgi?id=167385
2538
2539         Reviewed by Alex Christensen.
2540
2541         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2542         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2543         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2544         (TEST): Allow inline (rather than full screen) media playback on iOS.
2545
2546 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2547
2548         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2549         https://bugs.webkit.org/show_bug.cgi?id=167414
2550
2551         Reviewed by Michael Catanzaro.
2552
2553         Add a test case to check ephemeral web views don't write favicons to the database.
2554
2555         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2556         (ephemeralViewLoadChanged):
2557         (testPrivateBrowsing):
2558         (testFaviconDatabase):
2559
2560 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2561
2562         [GTK] Add a private browsing mode to MiniBrowser
2563         https://bugs.webkit.org/show_bug.cgi?id=167413
2564
2565         Reviewed by Michael Catanzaro.
2566
2567         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2568         private windows, even on non-private instances.
2569
2570         * MiniBrowser/gtk/BrowserWindow.c:
2571         (webViewTitleChanged): Add [Private] to title window for private windows.
2572         (webViewCreate): Pass web context to browser_window_new.
2573         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2574         (browserWindowFinalize): Disconnect web context signal handlers.
2575         (browser_window_init): Add shortcut for opening private window.
2576         (browser_window_new): It now receives the context and connect to download-started here.
2577         (browser_window_get_web_context): Return the context.
2578         * MiniBrowser/gtk/BrowserWindow.h:
2579         * MiniBrowser/gtk/main.c:
2580         (createBrowserTab): Create the web view for the window web context.
2581         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2582         (aboutDataHandleRequest): Ditto.
2583         (aboutURISchemeRequestCallback): Ditto.
2584         (main): Create ephemeral web context if private command line option is used.
2585
2586 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2587
2588         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2589         https://bugs.webkit.org/show_bug.cgi?id=167409
2590
2591         Reviewed by Antti Koivisto.
2592
2593         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2594         as well as tests for the newly added matchingElementInFlatTree.
2595
2596         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2597         (TestWebKitAPI::runJavaScriptAlert):
2598         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2599         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2600         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2601
2602 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2603
2604         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2605         https://bugs.webkit.org/show_bug.cgi?id=167370
2606
2607         Reviewed by Michael Catanzaro.
2608
2609         Add several test cases of ephemeral web views.
2610
2611         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2612         (testWebViewAuthenticationStorage):
2613         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2614         (ephemeralViewloadChanged):
2615         (testCookieManagerEphemeral):
2616         (beforeAll):
2617         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2618         (testWebKitSettings):
2619         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2620         (testWebContextEphemeral):
2621         (ephemeralViewloadChanged):
2622         (testWebContextProxySettings):
2623         (beforeAll):
2624         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2625         (ephemeralViewloadChanged):
2626         (testWebViewEphemeral):
2627         (beforeAll):
2628         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2629         (ephemeralViewloadChanged):
2630         (testWebsiteDataEphemeral):
2631         (beforeAll):
2632
2633 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2634
2635         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2636         https://bugs.webkit.org/show_bug.cgi?id=167402
2637
2638         Reviewed by Ryosuke Niwa.
2639
2640         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2641         (TestWebKitAPI::TEST):
2642
2643 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2644
2645         Add simple line layout toggle to MiniBrowser
2646         https://bugs.webkit.org/show_bug.cgi?id=167405
2647
2648         Reviewed by Andreas Kling.
2649
2650         * MiniBrowser/mac/SettingsController.h:
2651         * MiniBrowser/mac/SettingsController.m:
2652         (-[SettingsController _populateMenu]):
2653         (-[SettingsController validateMenuItem:]):
2654         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2655         (-[SettingsController simpleLineLayoutEnabled]):
2656         * MiniBrowser/mac/WK1BrowserWindowController.m:
2657         (-[WK1BrowserWindowController didChangeSettings]):
2658         * MiniBrowser/mac/WK2BrowserWindowController.m:
2659         (-[WK2BrowserWindowController didChangeSettings]):
2660
2661 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2662
2663         WKR does not include my nick when commit-queue lands my patch
2664         https://bugs.webkit.org/show_bug.cgi?id=167388
2665
2666         Reviewed by Ryosuke Niwa.
2667
2668         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2669         (NewCommitBot._summarize_commit_log):
2670         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2671         Perform nickname insertion before grabbing "Patch by" details.
2672         This way we can include the nickname with the full name.
2673
2674 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2675
2676         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2677         https://bugs.webkit.org/show_bug.cgi?id=167394
2678
2679         Reviewed by Ryosuke Niwa.
2680
2681         * Scripts/webkitperl/FeatureList.pm:
2682         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2683
2684 2017-01-24  Youenn Fablet  <youenn@apple.com>
2685
2686         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2687         https://bugs.webkit.org/show_bug.cgi?id=167353
2688
2689         Reviewed by Alex Christensen.
2690
2691         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2692         (CMakeGenerator.initialize_targets):
2693
2694 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2695
2696         WKR should not confuse Miguel Gomez with Andres Gomez
2697         https://bugs.webkit.org/show_bug.cgi?id=167389
2698
2699         Reviewed by Lucas Forschler.
2700
2701         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2702         "mAndres Gomez". Fix this.
2703
2704         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2705         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2706         space on each side of the email address, so expect both spaces to be there before
2707         considering the email for replacement.
2708         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2709
2710 2017-01-24  Matt Rajca  <mrajca@apple.com>
2711
2712         Pass down website autoplay policies to media elements
2713         https://bugs.webkit.org/show_bug.cgi?id=167355
2714
2715         Reviewed by Alex Christensen.
2716
2717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2718         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2719         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2720         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2721         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2722         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2723         (TEST):
2724
2725 2017-01-24  Nan Wang  <n_wang@apple.com>
2726
2727         AX: Speak Selection does not work in an iframe
2728         https://bugs.webkit.org/show_bug.cgi?id=166794
2729         <rdar://problem/29913013>
2730
2731         Reviewed by Chris Fleizach.
2732
2733         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2734         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2735         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2736         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2737         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2738         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2739         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2740         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2741         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2742         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2743         (-[TestRunnerWKWebView dealloc]):
2744         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2745         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2746         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2747         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2748         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2749
2750 2017-01-24  Daniel Bates  <dabates@apple.com>
2751
2752         StringView.split() should use an iterator design pattern instead of allocating a Vector
2753         https://bugs.webkit.org/show_bug.cgi?id=163225
2754
2755         Reviewed by Darin Adler.
2756
2757         Add unit tests for StringView.split().
2758
2759         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2760         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2761         used in the StringView.split() unit tests.
2762         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2763         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2764         object to a Vector of String objects.
2765         (TestWebKitAPI::TEST): Added the following tests:
2766             - WTF.StringViewSplitEmptyAndNullStrings
2767             - WTF.StringViewSplitBasic
2768             - WTF.StringViewSplitWithConsecutiveSeparators
2769
2770 2017-01-23  Anders Carlsson  <andersca@apple.com>
2771
2772         The Score Esports crashes on launch
2773         https://bugs.webkit.org/show_bug.cgi?id=167338
2774         rdar://problem/29948645
2775
2776         Reviewed by Dan Bernstein.
2777
2778         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2779         (TestWebKitAPI::TEST):
2780         Add a test.
2781
2782 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2783
2784         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2785         https://bugs.webkit.org/show_bug.cgi?id=146589
2786
2787         Reviewed by Michael Catanzaro.
2788
2789         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2790         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2791
2792         * MiniBrowser/gtk/BrowserWindow.c:
2793         (webViewDecidePolicy):
2794         (newTabCallback):
2795         * MiniBrowser/gtk/main.c:
2796         (createBrowserTab):
2797         (aboutDataRequestFree):
2798         (aboutDataRequestNew):
2799         (aboutDataRequestForView):
2800         (websiteDataRemovedCallback):
2801         (websiteDataClearedCallback):
2802         (aboutDataScriptMessageReceivedCallback):
2803         (domainListFree):
2804         (aboutDataFillTable):
2805         (gotWebsiteDataCallback):
2806         (aboutDataHandleRequest):
2807         (aboutURISchemeRequestCallback):
2808         (main):
2809         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2810         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2811         (serverCallback):
2812         (beforeAll):
2813         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2814         (serverCallback):
2815         (WebsiteDataTest::WebsiteDataTest):
2816         (WebsiteDataTest::~WebsiteDataTest):
2817         (WebsiteDataTest::fetch):
2818         (WebsiteDataTest::remove):
2819         (WebsiteDataTest::clear):
2820         (testWebsiteDataConfiguration):
2821         (testWebsiteDataCache):
2822         (testWebsiteDataStorage):
2823         (testWebsiteDataDatabases):
2824         (testWebsiteDataAppcache):
2825         (beforeAll):
2826         (afterAll):
2827
2828 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2829
2830         Unreviewed, rolling out r211062.
2831         https://bugs.webkit.org/show_bug.cgi?id=167354
2832
2833         broke API tests (Requested by alexchristensen on #webkit).
2834
2835         Reverted changeset:
2836
2837         "Pass down website autoplay policies to media elements"
2838         https://bugs.webkit.org/show_bug.cgi?id=167132
2839         http://trac.webkit.org/changeset/211062
2840
2841 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2842
2843         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2844         https://bugs.webkit.org/show_bug.cgi?id=167330
2845
2846         Reviewed by Tim Horton.
2847
2848         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2849         (TestWebKitAPI::TEST_F):
2850
2851 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2852
2853         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2854         https://bugs.webkit.org/show_bug.cgi?id=167317
2855
2856         Reviewed by Sam Weinig.
2857
2858         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2859         (TestWebKitAPI::TEST_F):
2860
2861 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2862
2863         svn-create-patch should emit properties when files are moved or copied
2864         https://bugs.webkit.org/show_bug.cgi?id=167264
2865
2866         Reviewed by Daniel Bates.
2867
2868         * Scripts/svn-create-patch:
2869         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2870
2871 2017-01-23  Youenn Fablet  <youenn@apple.com>
2872
2873         [WebRTC] Filter libwebrtc link flags
2874         https://bugs.webkit.org/show_bug.cgi?id=167287
2875
2876         Reviewed by Alex Christensen.
2877
2878         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2879         (CMakeGenerator._compute_link_flags):
2880         (CMakeGenerator._compute_link_flags.keep_flag):
2881         (CMakeGenerator._generate_compile_target_options):
2882
2883 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2884
2885         [WebRTC] Make VP8 optional in libwebrtc
2886         https://bugs.webkit.org/show_bug.cgi?id=167257
2887
2888         Reviewed by Darin Adler.
2889
2890         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2891         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2892
2893 2017-01-23  Jer Noble  <jer.noble@apple.com>
2894
2895         Video details does not apear and missing scrubber in Control Center
2896         https://bugs.webkit.org/show_bug.cgi?id=167233
2897
2898         Reviewed by Alex Christensen.
2899
2900         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2901         NowPlayingControlTests for iOS.
2902
2903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2904         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2905         (-[NowPlayingTestWebView setWindowVisible:]):
2906         (TestWebKitAPI::TEST):
2907         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2908         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2909         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2910         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2911         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2912         (SOFT_LINK_CLASS):
2913         (-[TestMessageHandler addMessage:withHandler:]):
2914         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2915         (__simulated_forceClickAssociatedEventsMask):
2916         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2917         (-[TestWKWebViewHostWindow isKeyWindow]):
2918         (-[TestWKWebViewHostWindow makeKeyWindow]):
2919         (-[TestWKWebViewHostWindow resignKeyWindow]):
2920         (-[TestWKWebView initWithFrame:]):
2921         (-[TestWKWebView initWithFrame:configuration:]):
2922         (-[TestWKWebView _setUpTestWindow:]):
2923         (-[TestWKWebView performAfterReceivingMessage:action:]):
2924         (-[TestWKWebView loadTestPageNamed:]):
2925         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2926         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2927         (-[TestWKWebView waitForMessage:]):
2928         (-[TestWKWebView performAfterLoading:]):
2929         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2930         (-[TestWKWebView typeCharacter:]):
2931
2932 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2933
2934         Unreviewed. Bring back gtk-doc error messages after r209981.
2935
2936         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2937         impossible to know what's wrong.
2938
2939         * gtk/gtkdoc.py:
2940         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2941
2942 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2943
2944         [WebRTC] Update build system to make G711 optional in libwebrtc
2945         https://bugs.webkit.org/show_bug.cgi?id=167256
2946
2947         Reviewed by Alex Christensen.
2948
2949         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2950         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2951
2952 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2953
2954         Cleanup RuntimeEnabledFeatures
2955         https://bugs.webkit.org/show_bug.cgi?id=167228
2956
2957         Reviewed by Simon Fraser.
2958
2959         * DumpRenderTree/mac/DumpRenderTree.mm:
2960         (enableExperimentalFeatures):
2961         (resetWebPreferencesToConsistentValues):
2962         (setWebPreferencesForTestOptions):
2963         (resetWebViewToConsistentStateBeforeTesting):
2964         * DumpRenderTree/win/DumpRenderTree.cpp:
2965         (enableExperimentalFeatures):
2966         (resetWebPreferencesToConsistentValues):
2967         More closely match WebKitTestRunner initialization of preferences
2968         for experimental features.
2969
2970 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2971
2972         Build Fix for Windows DumpRenderTree after r210976
2973         https://bugs.webkit.org/show_bug.cgi?id=167115
2974
2975         * DumpRenderTree/win/DumpRenderTree.cpp:
2976         (resetWebPreferencesToConsistentValues):
2977
2978 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2979
2980         Remove outdated ENABLE(CSP_NEXT) build flag
2981         https://bugs.webkit.org/show_bug.cgi?id=167252
2982
2983         Reviewed by Brent Fulgham.
2984
2985         * Scripts/webkitperl/FeatureList.pm:
2986         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2987
2988 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2989
2990         Build Fix for Windows DumpRenderTree after r210976
2991
2992         * DumpRenderTree/win/DumpRenderTree.cpp:
2993         (resetWebPreferencesToConsistentValues):
2994
2995 2017-01-20  Antoine Quint  <graouts@apple.com>
2996
2997         Web Animations should be off by default and enabled as an experimental feature
2998         https://bugs.webkit.org/show_bug.cgi?id=167115
2999         <rdar://problem/30048963>
3000
3001         Reviewed by Joseph Pecoraro.
3002
3003         Turn Web Animations on in DRT.
3004
3005         * DumpRenderTree/mac/DumpRenderTree.mm:
3006         (resetWebPreferencesToConsistentValues):
3007         * DumpRenderTree/win/DumpRenderTree.cpp:
3008         (resetWebPreferencesToConsistentValues):
3009
3010 2017-01-20  Youenn Fablet  <youenn@apple.com>
3011
3012         [WebRTC] Add libwebrtc build infrastructure
3013         https://bugs.webkit.org/show_bug.cgi?id=167207
3014
3015         Reviewed by Alex Christensen.
3016
3017         Adding a script doing the libwebrtc project json to CMake file conversion.
3018
3019         * Scripts/generate-libwebrtc-cmake: Added.
3020         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
3021         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
3022
3023 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3024
3025         Mini Browser: Show tooltip for Experimental Features
3026         https://bugs.webkit.org/show_bug.cgi?id=167225
3027
3028         Reviewed by Alex Christensen.
3029
3030         * MiniBrowser/mac/SettingsController.m:
3031         (-[SettingsController _populateMenu]):
3032         Include the full details string as a tooltip.
3033
3034 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
3035
3036         [Win] Test output results should not be written twice.
3037         https://bugs.webkit.org/show_bug.cgi?id=167197
3038
3039         Reviewed by Brent Fulgham.
3040
3041         Prevent test output from being written twice by returning early from
3042         the dump() function, if it already has been called.
3043         This patch also adds a missing newline to a test output line. 
3044         
3045         * DumpRenderTree/win/DumpRenderTree.cpp:
3046         (dump):
3047
3048 2017-01-20  Antoine Quint  <graouts@apple.com>
3049
3050         [Modern Media Controls] Turn modern media controls on by default
3051         https://bugs.webkit.org/show_bug.cgi?id=165668
3052
3053         Reviewed by Dean Jackson.
3054
3055         Enabled modern media controls by default in test runners.
3056
3057         * DumpRenderTree/TestOptions.h:
3058         * WebKitTestRunner/TestOptions.h:
3059
3060 2017-01-19  Chris Dumez  <cdumez@apple.com>
3061
3062         iterable<> should be enabled on WK1
3063         https://bugs.webkit.org/show_bug.cgi?id=167221
3064         <rdar://problem/30108531>
3065
3066         Reviewed by Youenn Fablet.
3067
3068         * DumpRenderTree/mac/DumpRenderTree.mm:
3069         (resetWebPreferencesToConsistentValues):
3070         * DumpRenderTree/win/DumpRenderTree.cpp:
3071         (resetWebPreferencesToConsistentValues):
3072         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3073         (WTR::InjectedBundle::beginTesting):
3074         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3075         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
3076         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3077
3078 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
3079
3080         Ensure status server logs go to log file
3081         https://bugs.webkit.org/show_bug.cgi?id=167210
3082
3083         Reviewed by Alexey Proskuryakov.
3084
3085         * Scripts/webkitpy/common/net/statusserver.py:
3086         (StatusServer.next_work_item): Change log level from debug to info in
3087         order to facilitate deubgging issues.
3088         (StatusServer.update_work_items): Same.
3089
3090 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
3091
3092         Additional selection tests and interpolation fix
3093         https://bugs.webkit.org/show_bug.cgi?id=167171
3094
3095         Reviewed by Simon Fraser.
3096
3097         We weren't adding the final event when interpolating event streams.
3098
3099         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3100         (-[HIDEventGenerator interpolatedEvents:]):
3101
3102 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
3103
3104         [Cocoa] Variation fonts are erroneously disabled on iOS
3105         https://bugs.webkit.org/show_bug.cgi?id=167172
3106
3107         Reviewed by Simon Fraser.
3108
3109         OpenSource builders don't seem to understand sdk=embedded*.
3110
3111         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3112
3113 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3114
3115         Unreviewed. Fix GTK+ unit tests failing since r210531.
3116
3117         Avoid using paths to files that don't actually exist.
3118
3119         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3120         (testWebKitConsoleMessageNetworkError):
3121         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3122         (testContextMenuDefaultMenu):
3123         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
3124         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
3125         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
3126
3127 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3128
3129         [GTK] Provide API to set proxy settings
3130         https://bugs.webkit.org/show_bug.cgi?id=128674
3131
3132         Reviewed by Michael Catanzaro.
3133
3134         Add tests for new proxy settings API.
3135
3136         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3137         (serverCallback):
3138         (ProxyTest::ProxyTest):
3139         (ProxyTest::~ProxyTest):
3140         (ProxyTest::loadURIAndGetMainResourceData):
3141         (ProxyTest::proxyServerPortAsString):
3142         (testWebContextProxySettings):
3143         (beforeAll):
3144
3145 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3146
3147         Add back my old email address so old commits will still match it.
3148
3149         * Scripts/webkitpy/common/config/contributors.json:
3150
3151 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3152
3153         Remove my old email address from contributors.json and watchlist.
3154
3155         * Scripts/validate-committer-lists:
3156         (CommitterListFromGit): Change the mapping to the correct email.
3157         * Scripts/webkitpy/common/config/contributors.json:
3158         * Scripts/webkitpy/common/config/watchlist:
3159
3160 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3161
3162         Unreviewed, rolling out r210848.
3163
3164         This change introduced media-related LayoutTest failures and
3165         crashes on macOS.
3166
3167         Reverted changeset:
3168
3169         "[Modern Media Controls] Turn modern media controls on by
3170         default"
3171         https://bugs.webkit.org/show_bug.cgi?id=165668
3172         http://trac.webkit.org/changeset/210848
3173
3174 2017-01-18  Andreas Kling  <akling@apple.com>
3175
3176         Document::securityOrigin() should return a reference.
3177         <https://webkit.org/b/167124>
3178
3179         Reviewed by Sam Weinig.
3180
3181         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3182         (TestWebKitAPI::TEST_F):
3183
3184 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
3185
3186         [Win] Clipboard tests are flaky.
3187         https://bugs.webkit.org/show_bug.cgi?id=167088
3188
3189         Reviewed by Brent Fulgham.
3190
3191         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
3192         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
3193
3194         * DumpRenderTree/win/DumpRenderTree.cpp:
3195         (main):
3196
3197 2017-01-18  Antoine Quint  <graouts@apple.com>
3198
3199         [Modern Media Controls] Turn modern media controls on by default
3200         https://bugs.webkit.org/show_bug.cgi?id=165668
3201
3202         Reviewed by Dean Jackson.
3203
3204         Enabled modern media controls by default in test runners. 
3205
3206         * DumpRenderTree/TestOptions.h:
3207         * WebKitTestRunner/TestOptions.h:
3208
3209 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3210
3211         Unreviewed, rolling out r210834
3212         https://bugs.webkit.org/show_bug.cgi?id=165668
3213
3214         It introduced dozens of test timeouts.
3215
3216         Reverted changeset:
3217         "[Modern Media Controls] Turn modern media controls on by default"
3218         https://bugs.webkit.org/show_bug.cgi?id=165668
3219         http://trac.webkit.org/changeset/210834
3220
3221 2017-01-17  Antoine Quint  <graouts@apple.com>
3222
3223         [Modern Media Controls] Turn modern media controls on by default
3224         https://bugs.webkit.org/show_bug.cgi?id=165668
3225
3226         Reviewed by Dean Jackson.
3227
3228         Enabled modern media controls by default in test runners. 
3229
3230         * DumpRenderTree/TestOptions.h:
3231         * WebKitTestRunner/TestOptions.h:
3232
3233 2017-01-17  Chris Dumez  <cdumez@apple.com>
3234
3235         Document title changed twice when setting document.title
3236         https://bugs.webkit.org/show_bug.cgi?id=167065
3237
3238         Reviewed by Darin Adler.
3239
3240         Add WebKit2GTK API test that was written by Michael Catanzaro.
3241
3242         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3243         (testWebViewTitleChange):
3244         (beforeAll):
3245
3246 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3247
3248         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3249         https://bugs.webkit.org/show_bug.cgi?id=116551
3250         <rdar://problem/13949830>
3251
3252         Reviewed by Alex Christensen.
3253
3254         * Scripts/webkitperl/FeatureList.pm:
3255         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
3256         that is part of the existing WEB_TIMING feature.
3257
3258         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3259
3260 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
3261
3262         'webkit-patch post' no longer works with moved/copied files
3263         https://bugs.webkit.org/show_bug.cgi?id=166914
3264         <rdar://problem/29979707>
3265
3266         Reviewed by Daniel Bates.
3267
3268         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
3269         file outputs only the "Index:" line with an empty body.  This workaround
3270         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
3271         public email list tracking this bug is below.
3272         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
3273         
3274
3275         * Scripts/svn-create-patch:
3276         (generateDiff): Ignore an "Index:" line with an empty body.
3277
3278 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3279
3280         Remove the REQUEST_ANIMATION_FRAME flag
3281         https://bugs.webkit.org/show_bug.cgi?id=156980
3282         <rdar://problem/25906849>
3283
3284         Reviewed by Simon Fraser.
3285
3286         * Scripts/webkitperl/FeatureList.pm:
3287         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3288
3289 2017-01-15  Sam Weinig  <sam@webkit.org>
3290
3291         Add the ability to use numbers in makeString()
3292         https://bugs.webkit.org/show_bug.cgi?id=167087
3293
3294         Reviewed by Darin Adler.
3295
3296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3297         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
3298         Add tests for StringConcatenate, focusing on new numeric additions.
3299
3300 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3301
3302         Unreviewed, remove stale comment.
3303
3304         This test was fixed by r163173.
3305
3306         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3307
3308 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3309
3310         Annotate large string tests with largeHeap
3311         https://bugs.webkit.org/show_bug.cgi?id=167054
3312
3313         Reviewed by Filip Pizlo.
3314
3315         * Scripts/run-javascriptcore-tests:
3316         * Scripts/run-jsc-stress-tests:
3317
3318 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3319
3320         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3321         https://bugs.webkit.org/show_bug.cgi?id=167043
3322
3323         Reviewed by Darin Adler.
3324
3325         * Scripts/webkitperl/FeatureList.pm:
3326
3327 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3328
3329         Remove ENABLE(DETAILS_ELEMENT) guards
3330         https://bugs.webkit.org/show_bug.cgi?id=167042
3331
3332         Reviewed by Alex Christensen.
3333
3334         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3335
3336 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
3337
3338         26 MotionMark performance tests failing
3339         https://bugs.webkit.org/show_bug.cgi?id=166854
3340
3341         Reviewed by Ryosuke Niwa.
3342
3343         Unrelated change. This is the last place that we need to rename Animometer
3344         to MotionMark.
3345
3346         * Scripts/webkitpy/common/config/watchlist:
3347
3348 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
3349
3350         run-jsc-benchmarks' echo should have -e option
3351         https://bugs.webkit.org/show_bug.cgi?id=167009
3352
3353         Reviewed by Sam Weinig.
3354
3355         echo requires `-e` option to use escape sequence.
3356         Without it, in some environment (in my Fedora 25), the escape sequence is not
3357         recognized and just dumped as `\c` etc.
3358
3359         * Scripts/run-jsc-benchmarks:
3360
3361 2017-01-12  Chris Dumez  <cdumez@apple.com>
3362
3363         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3364         https://bugs.webkit.org/show_bug.cgi?id=166995
3365
3366         Reviewed by Jer Noble.
3367
3368         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3369         as some people are having trouble building without it.
3370
3371         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3372
3373 2017-01-12  Sam Weinig  <sam@webkit.org>
3374
3375         Add the ability to filter the set of bindings tests you want to run
3376         https://bugs.webkit.org/show_bug.cgi?id=166977
3377
3378         Reviewed by Tim Horton.
3379
3380         Allows doing things like:
3381             run-bindings-tests TestObj* TestCEReactions*
3382         
3383         to run only those tests that match the patterns.
3384
3385         * Scripts/run-bindings-tests:
3386         (main):
3387         Switch to using optparse and pass the remaining args as the filters.
3388
3389         * Scripts/webkitpy/bindings/main.py:
3390         (BindingsTests.__init__):
3391         Store the pattens.
3392
3393         (BindingsTests.test_matches_patterns):
3394         Add helper predicate to determine if a test should be run. When no
3395         patterns are present, all tests should run.
3396
3397         (BindingsTests.run_tests):
3398         Filter tests using the passed in patterns.
3399
3400 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
3401
3402         Followup fix after r210503.
3403         https://bugs.webkit.org/show_bug.cgi?id=166887
3404
3405         Reviewed by Alex Christensen.
3406
3407         After <http://trac.webkit.org/changeset/210503>, test results are written to a
3408         duplicated file handle on Windows. This patch fixes the remaining call sites.
3409
3410         * DumpRenderTree/PixelDumpSupport.cpp:
3411         * DumpRenderTree/TestRunner.cpp:
3412         (TestRunner::waitToDumpWatchdogTimerFired):
3413         * DumpRenderTree/TestRunner.h:
3414         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3415         * DumpRenderTree/win/DumpRenderTree.cpp:
3416         * DumpRenderTree/win/DumpRenderTreeWin.h:
3417         * DumpRenderTree/win/TestRunnerWin.cpp:
3418         (TestRunner::setSpellCheckerLoggingEnabled):
3419
3420 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
3421
3422         Add committer status for Megan
3423         https://bugs.webkit.org/show_bug.cgi?id=166954
3424
3425         Reviewed by Tim Horton.
3426
3427         Add committer status for Megan Gardner
3428
3429         * Scripts/webkitpy/common/config/contributors.json:
3430
3431 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3432
3433         Unreviewed test fix after r210599.
3434
3435         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3436         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
3437
3438 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3439
3440         Unreviewed build fix after r210599.
3441
3442         Add missing files.
3443
3444         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3445         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3446
3447 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3448
3449         File scheme should not allow access of a resource on a different volume.
3450         https://bugs.webkit.org/show_bug.cgi?id=158552
3451         <rdar://problem/15307582>
3452
3453         Reviewed by Alex Christensen.
3454
3455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3456         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3457         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3458
3459 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3460
3461         Unreviewed, rolling out r210571.
3462
3463         This change broke the 32-bit macOS build and caused LayoutTest
3464         failures.
3465
3466         Reverted changeset:
3467
3468         "File scheme should not allow access of a resource on a
3469         different volume."
3470         https://bugs.webkit.org/show_bug.cgi?id=158552
3471         http://trac.webkit.org/changeset/210571
3472
3473 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3474
3475         [GTK] install-dependencies script misses gdb
3476         https://bugs.webkit.org/show_bug.cgi?id=166917
3477
3478         Reviewed by Michael Catanzaro.
3479
3480         gdb is needed for generating the crash logs.
3481
3482         * gtk/install-dependencies:
3483
3484 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3485
3486         [GTK] No way for applications to set notification permissions without waiting for permission request
3487         https://bugs.webkit.org/show_bug.cgi?id=163366
3488
3489         Reviewed by Carlos Garcia Campos.
3490
3491         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3492         (testWebViewNotification):
3493         (setInitialNotificationPermissionsAllowedCallback):
3494         (setInitialNotificationPermissionsDisallowedCallback):
3495         (testWebViewNotificationInitialPermissionAllowed):
3496         (testWebViewNotificationInitialPermissionDisallowed):
3497         (beforeAll):
3498         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3499         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3500         (WebViewTest::WebViewTest):
3501         (WebViewTest::initializeWebView):
3502         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3503
3504 2017-01-10  Tim Horton  <timothy_horton@apple.com>
3505
3506         MobileMiniBrowser tests don't work by default
3507         https://bugs.webkit.org/show_bug.cgi?id=166910
3508
3509         Reviewed by Alex Christensen.
3510
3511         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
3512         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
3513
3514 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
3515
3516         File scheme should not allow access of a resource on a different volume.
3517         https://bugs.webkit.org/show_bug.cgi?id=158552
3518         <rdar://problem/15307582>
3519
3520         Reviewed by Alex Christensen.
3521
3522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3523         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3524         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3525
3526 2017-01-10  Mark Lam  <mark.lam@apple.com>
3527
3528         Reverting run-jsc-stress-tests' $buildType to use string values.
3529         https://bugs.webkit.org/show_bug.cgi?id=166912
3530
3531         Rubber stamped by Filip Pizlo.
3532
3533         This is so that we can test for it in the tests e.g.
3534         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
3535
3536         * Scripts/run-jsc-stress-tests:
3537
3538 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3539
3540         Temporarily add back the file removed in r210463 to unbreak internal bots.
3541
3542         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3543
3544 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
3545
3546         svn-apply failed to apply a patch (deleting file with svn property)
3547         https://bugs.webkit.org/show_bug.cgi?id=165953
3548
3549         Reviewed by Daniel Bates.
3550
3551         * Scripts/VCSUtils.pm:
3552         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
3553         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
3554
3555 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3556
3557         Update flakiness dashboard configuration.
3558         https://bugs.webkit.org/show_bug.cgi?id=166869
3559
3560         Reviewed by Alexey Proskuryakov.
3561
3562         * TestResultServer/static-dashboards/builders.jsonp:
3563         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3564
3565 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3566
3567         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
3568         https://bugs.webkit.org/show_bug.cgi?id=165232
3569
3570         Unreviewed follow-up patch after r210539 and r210523.
3571
3572         Instead of using that environment variable, the argument
3573         --display-server=xorg should be passed now.
3574
3575         The GTK+ performance bot was the only bot using this, and is
3576         already passing --display-server=xorg after r210539.
3577
3578         * Scripts/webkitpy/port/gtk.py:
3579         (GtkPort._driver_class):
3580
3581 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3582
3583         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
3584         https://bugs.webkit.org/show_bug.cgi?id=166872
3585
3586         Reviewed by Michael Catanzaro.
3587
3588         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
3589         Define the required "--display-server=driver" in the bot additionalArguments config entry.
3590         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
3591         The step RunWebKitTests already has support for it.
3592
3593         * BuildSlaveSupport/build.webkit.org-config/config.json:
3594         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3595         (RunGtkAPITests.start):
3596         (RunAndUploadPerfTests.start):
3597         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3598
3599 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
3600
3601         Unreviewed, rolling out r210531.
3602
3603         This change broke the 32-bit macOS build and caused LayoutTest
3604         failures.
3605
3606         Reverted changeset:
3607
3608         "File scheme should not allow access of a resource on a
3609         different volume."
3610         https://bugs.webkit.org/show_bug.cgi?id=158552
3611         http://trac.webkit.org/changeset/210531
3612
3613 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
3614
3615         File scheme should not allow access of a resource on a different volume.
3616         https://bugs.webkit.org/show_bug.cgi?id=158552
3617         <rdar://problem/15307582>
3618
3619         Reviewed by Alex Christensen.
3620
3621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3622         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3623         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3624
3625 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3626
3627         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
3628         https://bugs.webkit.org/show_bug.cgi?id=165232
3629
3630         Reviewed by Michael Catanzaro.
3631
3632         Add a new WaylandDriver to run the tests in the user current wayland session.
3633
3634         Also merge all the configuration options for selecting the display server inside one
3635         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
3636
3637         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
3638
3639         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
3640         (TestRunner._create_driver):
3641         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3642         (parse_args):
3643         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3644         (PerfTestsRunner._parse_args):
3645         * Scripts/webkitpy/port/gtk.py:
3646         (GtkPort.__init__):
3