[ews-app] Add methods to update Patch fields
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-28  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Add methods to update Patch fields
4         https://bugs.webkit.org/show_bug.cgi?id=191931
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/models/patch.py:
9         (Patch.set_sent_to_buildbot):
10         (Patch.set_bug_id):
11         (Patch.set_obsolete):
12
13 2018-11-28  Yongjun Zhang  <yongjun_zhang@apple.com>
14
15         Allow WebKit clients to specify a minimum effective width for layout.
16         https://bugs.webkit.org/show_bug.cgi?id=191499
17         <rdar://problem/45362678>
18
19         Reviewed by Wenson Hsieh.
20
21         Allow UIScriptController to set WKWebView's minimum effective width with a new `setMinimumEffectiveWidth` method.
22
23         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
24         (WTR::UIScriptController::setMinimumEffectiveWidth):
25         * DumpRenderTree/mac/UIScriptControllerMac.mm:
26         (WTR::UIScriptController::setViewScale):
27         (WTR::UIScriptController::setMinimumEffectiveWidth):
28         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
29         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
30         (WTR::UIScriptController::setMinimumEffectiveWidth):
31         * TestRunnerShared/UIScriptContext/UIScriptController.h:
32         * WebKitTestRunner/UIScriptControllerCocoa.mm:
33         (WTR::UIScriptController::setMinimumEffectiveWidth):
34         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
35         (WTR::TestController::cocoaResetStateToConsistentValues):
36
37 2018-11-28  Lucas Forschler  <lforschler@apple.com>
38
39         Fix webkitbot hi command.
40         https://bugs.webkit.org/show_bug.cgi?id=192080
41
42         Reviewed by Alexey Proskuryakov.
43
44         * Scripts/webkitpy/tool/bot/irc_command.py:
45         (Hi.execute):
46
47 2018-11-28  Zalan Bujtas  <zalan@apple.com>
48
49         [LFC][Quirk] Use non-collapsed vertical margin values when the container is stretched to the size of the ICB.
50         https://bugs.webkit.org/show_bug.cgi?id=192078
51
52         Reviewed by Antti Koivisto.
53
54         * LayoutReloaded/misc/LFC-passing-tests.txt:
55
56 2018-11-28  Zalan Bujtas  <zalan@apple.com>
57
58         [LFC] Add support for quirk container's collapsing top margin in quirks mode.
59         https://bugs.webkit.org/show_bug.cgi?id=192070
60
61         Reviewed by Antti Koivisto.
62
63         * LayoutReloaded/misc/LFC-passing-tests.txt:
64
65 2018-11-28  Thibault Saunier  <tsaunier@igalia.com>
66
67         [WebRTC][GStreamer] Make sure to have the default microphone on the top of the list
68         https://bugs.webkit.org/show_bug.cgi?id=192026
69
70         Reviewed by Philippe Normand.
71
72         Otherwise we might end up picking a useless one in some applications
73         (not sure what those application do though).
74
75         GStreamer patch proposed as https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/merge_requests/34/diffs
76
77         * flatpak/org.webkit.CommonModules.yaml:
78         * gstreamer/jhbuild.modules:
79         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Added.
80
81 2018-11-28  Tomas Popela  <tpopela@redhat.com>
82
83         [GTK] Silence compilation warnings in glib unittests
84         https://bugs.webkit.org/show_bug.cgi?id=192009
85
86         Reviewed by Michael Catanzaro.
87
88         Mark the destructor as virtual.
89
90         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
91         (Test::~Test):
92
93 2018-11-27  Mark Lam  <mark.lam@apple.com>
94
95         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
96         https://bugs.webkit.org/show_bug.cgi?id=192055
97         <rdar://problem/46288783>
98
99         Reviewed by Saam Barati.
100
101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
102
103 2018-11-27  Alex Christensen  <achristensen@webkit.org>
104
105         Make synchronous IPC introduced in r237267 asynchronous
106         https://bugs.webkit.org/show_bug.cgi?id=190757
107
108         Reviewed by Chris Dumez.
109
110         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
111
112 2018-11-27  Jonathan Bedard  <jbedard@apple.com>
113
114         webkitpy: Add watchOS ports
115         https://bugs.webkit.org/show_bug.cgi?id=191974
116         <rdar://problem/46251051>
117
118         Reviewed by Aakash Jain.
119
120         * Scripts/webkitpy/port/factory.py:
121         (PortFactory): Add WatchDevice and WatchSimulator ports.
122         * Scripts/webkitpy/port/watch.py: Added.
123         (WatchPort): Base class for watchOS ports.
124         * Scripts/webkitpy/port/watch_device.py: Added.
125         (WatchDevicePort): Class for running layout tests on a watchOS device.
126         * Scripts/webkitpy/port/watch_simulator.py: Added.
127         (WatchSimulatorPort): Class for running layout tests on a watchOS simulator.
128         * Scripts/webkitpy/port/watch_simulator_unittest.py: Added.
129         (WatchSimulatorTest):
130         * Scripts/webkitpy/port/watch_testcase.py: Added.
131         (WatchTest):
132
133 2018-11-27  Alex Christensen  <achristensen@webkit.org>
134
135         Safe browsing warning text needs to be visible on High Sierra
136         https://bugs.webkit.org/show_bug.cgi?id=192022
137
138         Reviewed by Tim Horton.
139
140         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
141         (TEST):
142
143 2018-11-27  Wenson Hsieh  <wenson_hsieh@apple.com>
144
145         Unreviewed, fix the watchOS engineering build
146
147         Disable a newly added API test, since DDScannerResult is unavailable on watchOS.
148
149         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
150
151 2018-11-27  Chris Dumez  <cdumez@apple.com>
152
153         Regression(PSON) crash under WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame()
154         https://bugs.webkit.org/show_bug.cgi?id=191983
155         <rdar://problem/46246863>
156
157         Reviewed by Geoffrey Garen.
158
159         Add API test coverage.
160
161         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
162
163 2018-11-27  Aakash Jain  <aakash_jain@apple.com>
164
165         [ews-app] Add support to communicate with Buildbot (Follow-up fix)
166         https://bugs.webkit.org/show_bug.cgi?id=191935
167         <rdar://problem/46262314>
168
169         Unreviewed infrastructure fix.
170
171         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
172         (Buildbot.send_patch_to_buildbot):
173
174 2018-11-26  Wenson Hsieh  <wenson_hsieh@apple.com>
175
176         [Cocoa] No way for clients to tell whether the content view is in the responder chain when the web view is
177         https://bugs.webkit.org/show_bug.cgi?id=169212
178         <rdar://problem/30899656>
179
180         Reviewed by Tim Horton.
181
182         Add an API test to exercise the behavior of `-_contentViewIsFirstResponder` when an embedded text input becomes
183         and resigns first responder.
184
185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
186         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFirstResponderTests.mm: Added.
187         (-[FirstResponderTestingView initWithFrame:]):
188         (-[FirstResponderTestingView inputField]):
189         (TestWebKitAPI::TEST):
190
191 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
192
193         [CMake] Remove ENABLE_ACCESSIBILITY CMake variable
194         https://bugs.webkit.org/show_bug.cgi?id=191831
195
196         Reviewed by Michael Catanzaro.
197
198         * WebKitTestRunner/CMakeLists.txt:
199
200 2018-11-26  Tim Horton  <timothy_horton@apple.com>
201
202         Insert <attachment> elements under editable images to make their backing data accessible
203         https://bugs.webkit.org/show_bug.cgi?id=191844
204         <rdar://problem/30900149>
205
206         Reviewed by Simon Fraser.
207
208         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
209         (WTR::UIScriptController::attachmentInfo):
210         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
211         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
212         (WTR::UIScriptController::attachmentInfo):
213         * TestRunnerShared/UIScriptContext/UIScriptController.h:
214         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
215         (WTR::UIScriptController::attachmentInfo):
216         Add a UIScriptController mechanism to retrieve information about
217         a given attachment.
218
219 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
220
221         [ews-app] Add support to communicate with Buildbot
222         https://bugs.webkit.org/show_bug.cgi?id=191935
223
224         Reviewed by Lucas Forschler.
225
226         * BuildSlaveSupport/ews-app/ews/common/__init__.py: Added.
227         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Added.
228
229 2018-11-26  Jonathan Bedard  <jbedard@apple.com>
230
231         webkitpy: Race condition in ServerProcess tests
232         https://bugs.webkit.org/show_bug.cgi?id=191989
233         <rdar://problem/45536844>
234
235         Reviewed by Lucas Forschler.
236
237         Serializing these tests to prevent the race conditions.
238
239         * Scripts/webkitpy/port/server_process_unittest.py:
240         (TestServerProcess.serial_test_basic):
241         (TestServerProcess.serial_test_read_after_process_exits):
242         (TestServerProcess.serial_test_process_crashing):
243         (TestServerProcess.serial_test_process_crashing_no_data):
244         (TestServerProcess.test_basic): Deleted.
245         (TestServerProcess.test_read_after_process_exits): Deleted.
246         (TestServerProcess.test_process_crashing): Deleted.
247         (TestServerProcess.test_process_crashing_no_data): Deleted.
248
249 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
250
251         [ews-app] Add field in Patch object to indicate if it has been sent to Buildbot
252         https://bugs.webkit.org/show_bug.cgi?id=191929
253
254         Reviewed by Lucas Forschler.
255
256         * BuildSlaveSupport/ews-app/ews/models/patch.py:
257         (Patch): Added sent_to_buildbot field.
258         (Patch.is_patch_sent_to_buildbot): Checks if the patch has been sent to Buildbot.
259
260 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
261
262         [ews-app] Add a config file
263         https://bugs.webkit.org/show_bug.cgi?id=191933
264
265         Reviewed by Lucas Forschler.
266
267         * BuildSlaveSupport/ews-app/ews/config.py: Added.
268
269 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
270
271         [ews-app] Add methods to save patch to database
272         https://bugs.webkit.org/show_bug.cgi?id=191928
273
274         Reviewed by Lucas Forschler.
275
276         * BuildSlaveSupport/ews-app/ews/models/patch.py:
277         (Patch.save_patch): Method to save the patch to database.
278         (Patch.save_patches): Method to save multiple patches to database.
279         (Patch.is_valid_patch_id): Checks if the patch id is valid.
280         (Patch.is_existing_patch_id): Checks if the patch id already exists in database.
281
282 2018-11-26  Alex Christensen  <achristensen@webkit.org>
283
284         Rename WKWebView._safeBrowsingWarningForTesting to _safeBrowsingWarning to use it for more than testing
285         https://bugs.webkit.org/show_bug.cgi?id=191981
286
287         Reviewed by Tim Horton.
288
289         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
290         (TEST):
291         (safeBrowsingView):
292
293 2018-11-26  Daniel Bates  <dabates@apple.com>
294
295         REGRESSION (r237738): Command Down Arrow doesn't scroll to the end of a page anymore
296         https://bugs.webkit.org/show_bug.cgi?id=191967
297         <rdar://problem/45976390>
298
299         Reviewed by Tim Horton.
300
301         Add more test infrastructure to dispatch key up events.
302
303         * WebKitTestRunner/ios/HIDEventGenerator.h:
304         * WebKitTestRunner/ios/HIDEventGenerator.mm:
305         (createHIDKeyEvent): Renamed from createHIDKeyDownEvent() and modified to take a boolean as
306         to whether to create an event for a key down or key up.
307         (createHIDKeyDownEvent): Deleted; renamed to createHIDKeyEvent().
308         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
309         (WTR::createUIPhysicalKeyboardEvent): Added. Convenience function to create a UIPhysicalKeyboardEvent.
310         (WTR::UIScriptController::keyDown): Modified to dispatch a key up event in addition to dispatching
311         a key down event.
312
313 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
314
315         [ews-app] Set Foreign Keys in EWS Django app models
316         https://bugs.webkit.org/show_bug.cgi?id=191790
317
318         Reviewed by Lucas Forschler.
319
320         * BuildSlaveSupport/ews-app/ews/models/builds.py: Set Foreign Key.
321         * BuildSlaveSupport/ews-app/ews/models/steps.py: Ditto.
322
323 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
324
325         [ews-app] Do not store patch content in database
326         https://bugs.webkit.org/show_bug.cgi?id=191788
327
328         Reviewed by Lucas Forschler.
329
330         * BuildSlaveSupport/ews-app/ews/models/patch.py: Removed content field.
331
332 2018-11-26  Jonathan Bedard  <jbedard@apple.com>
333
334         webkitpy: Retry app installation on watchOS simulators (Follow-up fix)
335         https://bugs.webkit.org/show_bug.cgi?id=191769
336         <rdar://problem/46139850>
337
338         Unreviewed infrastructure fix.
339
340         * Scripts/webkitpy/xcode/simulated_device.py:
341         (SimulatedDevice): Increase retry attempts.
342
343 2018-11-26  Daniel Bates  <dabates@apple.com>
344
345         Move testRunner.toggleCapsLock() to uiController
346         https://bugs.webkit.org/show_bug.cgi?id=191972
347
348         Reviewed by Tim Horton.
349
350         Move testRunner.toggleCapsLock() to uiController as uiController is the preferred JavaScript
351         object for UI test functions. Having this functionality be on uiController makes it an
352         asynchronous function naturally and complements use of onkeydown, onkeyup listeners to know
353         when the Caps Lock key event is dispatched. It also facilitates its use directly as part of
354         scripts with other uiController functions invocations that are passed in a single invocation
355         of testRunner.runUIScript().
356
357         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
358         (WTR::UIScriptController::toggleCapsLock):
359         * DumpRenderTree/mac/UIScriptControllerMac.mm:
360         (WTR::UIScriptController::toggleCapsLock):
361         Added stub functions that invoke the callback. We do not support toggling caps lock in Legacy
362         WebKit at the moment. Legacy WebKit reads the caps lock key state directly from the OS. Modern
363         WebKit caches the caps lock state in the WebProcess as a natural side effect of the fact that
364         the UIProcess is the only process capable of querying the caps lock key state from the OS and
365         hence the UIProcess must send over this state to the WebProcess.
366
367         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Add IDL for new function.
368         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
369         (WTR::UIScriptController::toggleCapsLock): Added empty implementation for ports non-Cocoa ports.
370         * TestRunnerShared/UIScriptContext/UIScriptController.h:
371
372         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
373         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
374         (WTR::TestRunner::toggleCapsLock): Deleted.
375         * WebKitTestRunner/InjectedBundle/TestRunner.h:
376         * WebKitTestRunner/TestController.h:
377         * WebKitTestRunner/TestInvocation.cpp:
378         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
379         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
380         (WTR::TestController::toggleCapsLock): Deleted; moved to UIScriptController::toggleCapsLock().
381         Removed logic to handle testRunner.toggleCapsLock().
382
383         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
384         (WTR::UIScriptController::toggleCapsLock): Add stub function that invokes the callback
385         and a FIXME comment that explains that we will implement this function in <https://bugs.webkit.org/show_bug.cgi?id=191815>.
386         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
387         (WTR::UIScriptController::toggleCapsLock): Moved the implementation from TestController::toggleCapsLock().
388
389 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
390
391         [Win] Reduce the use of WKSI library calls: CoreAnimation
392         https://bugs.webkit.org/show_bug.cgi?id=191777
393         <rdar://problem/46140542>
394
395         Reviewed by Zalan Bujtas.
396
397         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
398         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
399         directives for WebKitSystemInterface.lib.
400
401         * TestWebKitAPI/PlatformWin.cmake:
402
403 2018-11-25  Zalan Bujtas  <zalan@apple.com>
404
405         [LFC][IFC] Use float box's margin box to adjust the line constraints.
406         https://bugs.webkit.org/show_bug.cgi?id=191961
407
408         Reviewed by Antti Koivisto.
409
410         * LayoutReloaded/misc/LFC-passing-tests.txt:
411
412 2018-11-25  Zalan Bujtas  <zalan@apple.com>
413
414         Unreviewed test fix after r238467.
415
416         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
417         (TestWebKitAPI::TEST):
418
419 2018-11-25  Wenson Hsieh  <wenson_hsieh@apple.com>
420
421         Unreviewed, fix the internal iOS 12 build after r238471
422
423         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
424         (TEST):
425
426 2018-11-25  Tim Horton  <timothy_horton@apple.com>
427
428         Make it possible to insert editable images with a gesture
429         https://bugs.webkit.org/show_bug.cgi?id=191937
430
431         Reviewed by Wenson Hsieh.
432
433         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
434         (WTR::UIScriptController::drawSquareInEditableImage):
435         If the canvas already has a drawing, draw a new stroke on top of it
436         instead of removing the existing stroke.
437
438 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
439
440         [Cocoa] Add WKWebView SPI to trigger and remove data detection
441         https://bugs.webkit.org/show_bug.cgi?id=191918
442         <rdar://problem/36185051>
443
444         Reviewed by Tim Horton.
445
446         Add an API test to exercise the new WebKit SPI.
447
448         * TestWebKitAPI/DataDetectorsCoreSPI.h: Added.
449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
450         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
451         (-[WKWebView synchronouslyDetectDataWithTypes:]):
452         (-[WKWebView synchronouslyRemoveDataDetectedLinks]):
453         (TEST):
454         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
455         (TestWebKitAPI::TEST):
456         (-[TestWKWebView tagsInBody]): Deleted.
457         (-[TestWKWebView expectElementTagsInOrder:]): Deleted.
458         (-[TestWKWebView expectElementCount:tagName:]): Deleted.
459         (-[TestWKWebView expectElementTag:toComeBefore:]): Deleted.
460
461         Rename this from `-expectElementCount:tagName:` to `-expectElementCount:querySelector:`.
462
463         * TestWebKitAPI/Tests/WebKitCocoa/data-detectors.html: Added.
464
465         Add a new test page containing some content that can be data detected.
466
467         * TestWebKitAPI/cocoa/TestWKWebView.h:
468         * TestWebKitAPI/cocoa/TestWKWebView.mm:
469         (-[WKWebView tagsInBody]):
470         (-[WKWebView expectElementTagsInOrder:]):
471         (-[WKWebView expectElementCount:querySelector:]):
472         (-[WKWebView expectElementTag:toComeBefore:]):
473
474         Move some testing helper functions from WKAttachmentTests to a testing category on WKWebView. This allows us to
475         use `-expectElementCount:querySelector:` in tests outside of WKAttachmentTests.
476
477         (-[WKWebView objectByEvaluatingJavaScript:]):
478         (-[WKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
479         (-[WKWebView stringByEvaluatingJavaScript:]):
480
481         Move some common helper functions from TestWKWebView to a testing category on WKWebView.
482
483         (-[TestWKWebView objectByEvaluatingJavaScript:]): Deleted.
484         (-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]): Deleted.
485         (-[TestWKWebView stringByEvaluatingJavaScript:]): Deleted.
486
487 2018-11-23  Sam Weinig  <sam@webkit.org>
488
489         Add raw pointer overloads to ListHashSet via SmartPtr specialized functions
490         https://bugs.webkit.org/show_bug.cgi?id=191936
491
492         Reviewed by Zalan Bujtas.
493
494         Adds tests for raw pointer overloads in ListHashSet.
495
496         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
497         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
498
499 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
500
501         Enable drag and drop support for iOSMac
502         https://bugs.webkit.org/show_bug.cgi?id=191818
503         <rdar://problem/43907454>
504
505         Reviewed by Dean Jackson.
506
507         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
508
509 2018-11-23  Zalan Bujtas  <zalan@apple.com>
510
511         [LFC][IFC] Add support for variable height runs.
512         https://bugs.webkit.org/show_bug.cgi?id=191925
513
514         Reviewed by Antti Koivisto.
515
516         * LayoutReloaded/misc/LFC-passing-tests.txt:
517
518 2018-11-23  Alberto Garcia  <berto@igalia.com>
519
520         [GTK] [WPE] Tools/Platform{GTK,WPE}.cmake files missing from the tarballs
521         https://bugs.webkit.org/show_bug.cgi?id=191923
522
523         Add Tools/PlatformGTK.cmake and Tools/PlatformWPE.cmake to their
524         respective tarballs.
525
526         Reviewed by Carlos Garcia Campos.
527
528         * gtk/manifest.txt.in:
529         * wpe/manifest.txt.in:
530
531 2018-11-22  Chris Dumez  <cdumez@apple.com>
532
533         Regression(r238353) Load sometimes hangs when navigating back after a cross-site navigation
534         https://bugs.webkit.org/show_bug.cgi?id=191914
535
536         Reviewed by Ryosuke Niwa.
537
538         Add API test coverage.
539
540         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
541
542 2018-11-22  Zalan Bujtas  <zalan@apple.com>
543
544         [LFC][IFC] Offset formatting context root runs with horizontal margins.
545         https://bugs.webkit.org/show_bug.cgi?id=191900
546
547         Reviewed by Antti Koivisto.
548
549         * LayoutReloaded/misc/LFC-passing-tests.txt:
550
551 2018-11-22  Philippe Normand  <pnormand@igalia.com>
552
553         [GTK] Remove unmaintained bots
554         https://bugs.webkit.org/show_bug.cgi?id=191467
555
556         Reviewed by Alex Christensen.
557
558         The Linux 32-bits and ARM build-slaves are no longer maintained
559         and have been failing for months, so get rid of them.
560
561         * BuildSlaveSupport/build.webkit.org-config/config.json:
562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
563         (WebKitBuildbot):
564         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
565
566 2018-11-22  Thibault Saunier  <tsaunier@igalia.com>
567
568         [Flatpak] Do not disable signals when running "usual" commands
569         https://bugs.webkit.org/show_bug.cgi?id=190679
570
571         Reviewed by Philippe Normand.
572
573         Otherwise <ctr>c doesn't work while compiling. It is not the best fix
574         as there are cases we want to let only children receive signals, but
575         it is not clear how to determine when (when running gdb, we still
576         disable those).
577
578         * flatpak/flatpakutils.py:
579         (WebkitFlatpak.run_in_sandbox):
580
581 2018-11-21  Wenson Hsieh  <wenson_hsieh@apple.com>
582
583         [Cocoa] [WebKit2] Add support for replacing find-in-page text matches
584         https://bugs.webkit.org/show_bug.cgi?id=191786
585         <rdar://problem/45813871>
586
587         Reviewed by Ryosuke Niwa.
588
589         * MiniBrowser/mac/WK2BrowserWindowController.m:
590         (-[WK2BrowserWindowController setFindBarView:]):
591
592         Fix a bug in MiniBrowser that prevents AppKit from displaying the "All" button in the find bar after checking
593         the "Replace" option.
594
595         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
596
597         Add an API test to exercise find-and-replace API using WKWebView.
598
599         (replaceMatches):
600         (TEST):
601         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
602         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
603         (WTR::findOptionsFromArray):
604         (WTR::TestRunner::findString):
605         (WTR::TestRunner::findStringMatchesInPage):
606         (WTR::TestRunner::replaceFindMatchesAtIndices):
607
608         Add TestRunner hooks to simulate find-in-page and replace.
609
610         * WebKitTestRunner/InjectedBundle/TestRunner.h:
611
612 2018-11-21  Zalan Bujtas  <zalan@apple.com>
613
614         [LFC][IFC] Horizontal margins should be considered as non-breakable space
615         https://bugs.webkit.org/show_bug.cgi?id=191894
616
617         Reviewed by Antti Koivisto.
618
619         * LayoutReloaded/misc/LFC-passing-tests.txt:
620
621 2018-11-21  Zalan Bujtas  <zalan@apple.com>
622
623         [LFC][IFC] Border should be considered as non-breakable space
624         https://bugs.webkit.org/show_bug.cgi?id=191891
625
626         Reviewed by Antti Koivisto.
627
628         * LayoutReloaded/misc/LFC-passing-tests.txt:
629
630 2018-11-21  Zalan Bujtas  <zalan@apple.com>
631
632         [LFC][IFC] Take nonBreakableStart/End into use.
633         https://bugs.webkit.org/show_bug.cgi?id=191873
634
635         Reviewed by Antti Koivisto.
636
637         * LayoutReloaded/misc/LFC-passing-tests.txt:
638
639 2018-11-20  Jeff Miller  <jeffm@apple.com>
640
641         Return nullptr immediately if the key doesn't exist in the HashMap.
642         https://bugs.webkit.org/show_bug.cgi?id=191841
643
644         Reviewed by Chris Dumez.
645         
646         Add a test that would crash prior to the fix for this bug.
647
648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649         * TestWebKitAPI/Tests/WebKitCocoa/WKNSDictionaryEmptyDictionaryCrash.mm: Added.
650         (TestWebKitAPI::TEST):
651
652 2018-11-19  Alex Christensen  <achristensen@webkit.org>
653
654         Add SPI to disable JIT in a WKWebView
655         https://bugs.webkit.org/show_bug.cgi?id=191822
656         <rdar://problem/28119360>
657
658         Reviewed by Geoffrey Garen.
659
660         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
661         * TestWebKitAPI/Tests/WebKitCocoa/DisableJIT.mm: Added.
662         (TEST):
663
664 2018-11-19  Basuke Suzuki  <basuke.suzuki@sony.com>
665
666         [Curl] Add API for CertificateInfo.
667         https://bugs.webkit.org/show_bug.cgi?id=191647
668
669         Reviewed by Alex Christensen.
670
671         Added test for new WKCertificateInfo API.
672
673         * TestWebKitAPI/PlatformWin.cmake:
674         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Added.
675         (TestWebKitAPI::Curl::makeCertificateInfo):
676         (TestWebKitAPI::Curl::isSamePEM):
677         (TestWebKitAPI::Curl::TEST):
678
679 2018-11-19  Wenson Hsieh  <wenson_hsieh@apple.com>
680
681         Unreviewed, fix the internal iOS debug build after r238380
682
683         UICalloutBar should only be declared when the public (non-internal) SDK is used to build WebKit; otherwise, we
684         end up with duplicate declarations of UICalloutBar.
685
686         * TestWebKitAPI/ios/UIKitSPI.h:
687
688 2018-11-19  David Quesada  <david_quesada@apple.com>
689
690         EXC_BAD_ACCESS when invoking a DownloadProxy's destination decision handler after the download has been canceled
691         https://bugs.webkit.org/show_bug.cgi?id=191762
692         rdar://problem/46151509
693
694         Reviewed by Dean Jackson.
695
696         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
697             Enable the Download API test on iOS, since the platform supports downloads. All the
698             tests pass already, except for one which was written using AppKit-specific code:
699         TEST(_WKDownload, RedirectedDownload):
700             Use a more platform-agnostic approach to starting the download in this API test.
701             Instead of manually triggering an NSMenu item to download a file from a link, the
702             test will simulate a user-initiated click on the link, and the navigation delegate
703             will direct the web view to start a download based on the link's navigation action.
704             Additionally, remove the manual creation of a new NSWindow. TestWKWebView makes its
705             own UI/NSWindow.
706         TEST(_WKDownload, DownloadCanceledWhileDecidingDestination):
707             Add an API test _WKDownload.DownloadCanceledWhileDecidingDestination to simulate the
708             conditions that would trigger this crash - handling a download's -decideDestination…
709             delegate call by canceling the download, waiting for the UI process to be notified
710             that the download has been canceled, and calling the decision handler. This should
711             not crash.
712         (-[CancelDownloadWhileDecidingDestinationDelegate _downloadDidFinish:]):
713         (-[CancelDownloadWhileDecidingDestinationDelegate _download:didFailWithError:]):
714         (-[CancelDownloadWhileDecidingDestinationDelegate _downloadDidCancel:]):
715         (-[CancelDownloadWhileDecidingDestinationDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
716         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]): Deleted.
717         * TestWebKitAPI/cocoa/TestWKWebView.h:
718         * TestWebKitAPI/cocoa/TestWKWebView.mm:
719         (-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
720             Add a user-initated version of -objectByEvaluatingJavaScript:. This is needed in
721             order to maintain the behavior of the RedirectedDownload test, which verifies the
722             state of the _WKDownload.wasUserInitiated property.
723
724 2018-11-19  Wenson Hsieh  <wenson_hsieh@apple.com>
725
726         [iOS Debug] Assertion failure in NSComparisonResult UIContentSizeCategoryCompareToCategory()
727         https://bugs.webkit.org/show_bug.cgi?id=190401
728         <rdar://problem/45195285>
729
730         Reviewed by Dean Jackson.
731
732         Work around sporadic UIKit assertions when running API tests that may present a UICalloutBar. Currently, UIKit
733         asks for the `UIApp`’s `-preferredContentSizeCategory` when showing or laying out the callout bar. However,
734         TestWebKitAPI lacks a UIApp altogether, and forcing one to be initialized via `UIApplicationInstantiateSingleton`
735         causes numerous other UIKit and WebKit assertions to be hit.
736
737         In lieu of TestWebKitAPI becoming a real UI application (see https://webkit.org/b/175204), simply don't allow
738         the callout bar to be initialized in TestWKWebView-based API tests. This encompasses all API tests which
739         have some chance of causing the callout bar to be shown by making a ranged text selections during the test.
740
741         * TestWebKitAPI/cocoa/TestWKWebView.mm:
742         (suppressUICalloutBar):
743         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
744         * TestWebKitAPI/ios/UIKitSPI.h:
745
746 2018-11-19  Fujii Hironori  <Hironori.Fujii@sony.com>
747
748         REGRESSION(r238016)[GTK][TestWebKitAPI][Ninja] TestJSC can't compile "Bytecodes.h: No such file or directory"
749         https://bugs.webkit.org/show_bug.cgi?id=191692
750
751         Reviewed by Michael Catanzaro.
752
753         r238016 added a new #include, and requires JSC's derived headers
754         to be copied into the forwarding header directory.
755
756         WEBKIT_MAKE_FORWARDING_HEADERS is using POST_BUILD event to copy
757         derived headers to the forwarding header directory. This is done
758         after linking JSC library.
759
760         GTK port has TestJSC which has a dependency to JSC static library.
761         And, this dependency is a link time dependency which means
762         compiling source files of TestJSC starts before the POST_BUILD
763         event of JSC. Thus, required header can't be found.
764
765         Add an intermediate target between TestJSC and JavaScriptCore to
766         ensure derived headers are copied into the forwarding header
767         directory.
768
769         * TestWebKitAPI/PlatformGTK.cmake: Added a new custom target pre-TestJSC.
770         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
771
772 2018-11-19  Alejandro G. Castro  <alex@igalia.com>
773
774         [GTK][WPE] Solve some issues in the enumerateDevices code
775         https://bugs.webkit.org/show_bug.cgi?id=191832
776
777         Reviewed by Carlos Garcia Campos.
778
779         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
780         (serverCallback): Make all the Strings with HTML code static.
781         (testWebsiteDataDeviceIdHashSalt): Change the webView settings in
782         the test.
783         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
784         (WebViewTest::initializeWebView): Remove the initialization of the
785         webView settings, we now do it in the specific test.
786
787 2018-11-18  Chris Dumez  <cdumez@apple.com>
788
789         [PSON] Received an invalid message "WebPageProxy.DidPerformClientRedirect" from the web process
790         https://bugs.webkit.org/show_bug.cgi?id=191828
791
792         Reviewed by Antti Koivisto.
793
794         Add API test coverage.
795
796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
798         * TestWebKitAPI/Tests/WebKitCocoa/client-side-redirect.html: Added.
799
800 2018-11-17  Wenson Hsieh  <wenson_hsieh@apple.com>
801
802         [iOS] Remove all usages of UIItemProvider, UIItemProviderReading, and related classes
803         https://bugs.webkit.org/show_bug.cgi?id=191819
804
805         Reviewed by Dan Bernstein.
806
807         Replace UIItemProvider (and related classes) with NSItemProvider.
808
809         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
810         (platformCopyPNG):
811         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
812         (-[NSItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
813
814         Replace usages of this deprecated method with `-registerDataRepresentationForTypeIdentifier:visibility:loadHandler:`.
815
816         (checkEstimatedSize):
817         (checkSuggestedNameAndEstimatedSize):
818         (TestWebKitAPI::TEST):
819         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]): Deleted.
820         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
821         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
822         (-[MockDragDropSession canLoadObjectsOfClass:]):
823         (-[MockDragDropSession canLoadObjectsOfClasses:]):
824         (-[MockDropSession initWithProviders:location:window:allowMove:]):
825         (-[MockDropSession canCreateItemsOfClass:]):
826         (-[DragAndDropSimulator _advanceProgress]):
827         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
828         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
829         * TestWebKitAPI/ios/UIKitSPI.h:
830
831 2018-11-17  Chris Dumez  <cdumez@apple.com>
832
833         ASSERTION FAILED: m_messageReceivers.contains(...) under ViewGestureController removeMessageReceiver
834         https://bugs.webkit.org/show_bug.cgi?id=191734
835         <rdar://problem/46151497>
836
837         Reviewed by Ryosuke Niwa.
838
839         Add API test coverage.
840
841         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
842
843 2018-11-17  Zalan Bujtas  <zalan@apple.com>
844
845         [LFC][IFC] InlineFormattingState::addDetachingRule should accumulate rules.
846         https://bugs.webkit.org/show_bug.cgi?id=191801
847
848         Reviewed by Antti Koivisto.
849
850         * LayoutReloaded/misc/LFC-passing-tests.txt:
851
852 2018-11-17  Jer Noble  <jer.noble@apple.com>
853
854         Regression(r233865): Causes synchronous IPC in the middle of layout
855         https://bugs.webkit.org/show_bug.cgi?id=188307
856         <rdar://problem/42807306>
857
858         Reviewed by Eric Carlson.
859
860         Follow-up test fix for r238322:
861
862         In ExitFullscreenOnEnterPiP.ElementFullScreen, explicitly make the video
863         element in element fullscreen the "main content" by playing the video during
864         a user gesture; only "main content" videos will cause fullscreen mode to exit
865         when that element is taken into PiP.
866
867         In FullscreenZoomInitialFrame.WebKit, the WebView is not visible, so the Page
868         is considered hidden, and fullscreen is not allowed when the WebView is hidden.
869         Make the WebView visible by ordering the test window on-screen.
870
871         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html:
872         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
873         (TestWebKitAPI::TEST):
874         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
875         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
876
877 2018-11-16  Alex Christensen  <achristensen@webkit.org>
878
879         Tweak _showSafeBrowsingWarningWithTitle SPI
880         https://bugs.webkit.org/show_bug.cgi?id=191799
881
882         Reviewed by Wenson Hsieh.
883
884         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
885         (TEST):
886
887 2018-11-16  Ryosuke Niwa  <rniwa@webkit.org>
888
889         REGRESSION (r238294): TestWebKitAPI.WKNavigation.ProcessCrashDuringCallback failing on iOS
890         https://bugs.webkit.org/show_bug.cgi?id=191783
891
892         Reviewed by Chris Dumez.
893
894         Allow either WKErrorWebContentProcessTerminated or WKErrorWebViewInvalidated since the test
895         is closing WebView, thereby invalidating the view, which is racing with the process termination.
896
897         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
898         (TEST):
899
900 2018-11-16  Chris Dumez  <cdumez@apple.com>
901
902         ProcessSwap.DisableForInspector API test is failing
903         https://bugs.webkit.org/show_bug.cgi?id=191798
904
905         Reviewed by Joseph Pecoraro.
906
907         We support process swapping when Web Inspector is shown now so update the
908         API test accordingly.
909
910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
911
912 2018-11-16  Ryan Haddad  <ryanhaddad@apple.com>
913
914         Update buildbot dashboard after Windows 7/10 updates
915         https://bugs.webkit.org/show_bug.cgi?id=191219
916
917         Reviewed by Alexey Proskuryakov.
918
919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
920         (BubbleQueueServer):
921         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
922         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
923         (WebKitBuildbot):
924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
925         (table.queue-grid tr.platform td.logo::before):
926         (table.queue-grid tr.platform.windows-10 td.logo::before):
927         (table.queue-grid tr.platform.wincairo-windows-10 td.logo::before):
928         (table.queue-grid tr.platform.windows-7 td.logo::before):
929         (table.queue-grid tr.platform.wincairo-windows-10 img.logo):
930
931 2018-11-16  Chris Dumez  <cdumez@apple.com>
932
933         Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
934         https://bugs.webkit.org/show_bug.cgi?id=191789
935
936         Reviewed by Alex Christensen.
937
938         Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
939         SPI no longer works with PSON / Process prewarming.
940
941         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
942         (TestWebKitAPI::TEST):
943
944 2018-11-16  Jonathan Bedard  <jbedard@apple.com>
945
946         webkitpy: Retry app installation on watchOS simulators
947         https://bugs.webkit.org/show_bug.cgi?id=191769
948         <rdar://problem/46139850>
949
950         Reviewed by Aakash Jain.
951
952         * Scripts/webkitpy/xcode/simulated_device.py:
953         (SimulatedDevice.install_app): Retry app installations.
954
955 2018-11-16  Zalan Bujtas  <zalan@apple.com>
956
957         Add DidFirstMeaningfulPaint milestone.
958         https://bugs.webkit.org/show_bug.cgi?id=191754
959
960         Reviewed by Simon Fraser.
961
962         * TestWebKitAPI/CMakeLists.txt:
963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
964         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp: Added.
965         (TestWebKitAPI::didReachMilestone):
966         (TestWebKitAPI::setPageLoaderClient):
967         (TestWebKitAPI::TEST):
968         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone_Bundle.cpp: Copied from Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h.
969         (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::FirstMeaningfulPaintMilestoneTest):
970         (TestWebKitAPI::FirstMeaningfulPaintMilestoneTest::didCreatePage):
971
972 2018-11-16  Takashi Komori  <Takashi.Komori@sony.com>
973
974         [WinCairo][WebKitTestRunner] Test contents window is displayed while testing.
975         https://bugs.webkit.org/show_bug.cgi?id=191593
976
977         Reviewed by Alex Christensen.
978
979         Hide TestRunner window and taskbar button.
980
981         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
982         (WTR::PlatformWebView::PlatformWebView):
983         (WTR::PlatformWebView::windowSnapshotImage):
984
985 2018-11-16  Alex Christensen  <achristensen@webkit.org>
986
987         Add API to disable safe browsing checks
988         https://bugs.webkit.org/show_bug.cgi?id=191610
989
990         Reviewed by Dean Jackson.
991
992         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
993         (resourceURL):
994         (TEST):
995         (safeBrowsingView):
996         (simpleURL): Deleted.
997
998 2018-11-16  Zalan Bujtas  <zalan@apple.com>
999
1000         [LFC][IFC] Add support for out-of-flow positioned boxes
1001         https://bugs.webkit.org/show_bug.cgi?id=191726
1002
1003         Reviewed by Antti Koivisto.
1004
1005         * LayoutReloaded/misc/LFC-passing-tests.txt:
1006
1007 2018-11-15  Myles C. Maxfield  <mmaxfield@apple.com>
1008
1009         WKPreferencesSetFontSmoothingLevel doesn't actually do anything
1010         https://bugs.webkit.org/show_bug.cgi?id=191708
1011
1012         Reviewed by Simon Fraser.
1013
1014         Delete the symbol because no one calls it and it doesn't do anything
1015
1016         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1017         (TestWebKitAPI::TEST):
1018         * WebKitTestRunner/TestController.cpp:
1019         (WTR::TestController::resetPreferencesToConsistentValues):
1020
1021 2018-11-15  Truitt Savell  <tsavell@apple.com>
1022
1023         Unreviewed, rolling out r238244.
1024
1025         Caused High Sierra test runs to fail early with 50 crashes and
1026         casued 25 API failures.
1027
1028         Reverted changeset:
1029
1030         "[css-logical] Implement flow-relative margin, padding and
1031         border shorthands"
1032         https://bugs.webkit.org/show_bug.cgi?id=188697
1033         https://trac.webkit.org/changeset/238244
1034
1035 2018-11-15  Aakash Jain  <aakash_jain@apple.com>
1036
1037         Increase EWS lock timeout to 3 hours
1038         https://bugs.webkit.org/show_bug.cgi?id=191705
1039
1040         Reviewed by Alexey Proskuryakov.
1041
1042         * QueueStatusServer/config/queues.py: Increased EWS lock timeout to 3 hours.
1043
1044 2018-11-15  Chris Dumez  <cdumez@apple.com>
1045
1046         IndexedDB.IndexedDBTempFileSize API test times out with process prewarming enabled
1047         https://bugs.webkit.org/show_bug.cgi?id=191671
1048         <rdar://problem/46086062>
1049
1050         Reviewed by Alex Christensen.
1051
1052         Add API test coverage.
1053
1054         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1055         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1056         (TEST):
1057
1058 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1059
1060         [css-logical] Implement flow-relative margin, padding and border shorthands
1061         https://bugs.webkit.org/show_bug.cgi?id=188697
1062
1063         Reviewed by Simon Fraser and Antti Koivisto.
1064
1065         * DumpRenderTree/TestOptions.cpp:
1066         (TestOptions::TestOptions):
1067         * DumpRenderTree/TestOptions.h:
1068         * DumpRenderTree/mac/DumpRenderTree.mm:
1069         (setWebPreferencesForTestOptions):
1070         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1071
1072         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1073         (JSONCSSPropertiesChecker.check_codegen_properties):
1074         Allow CSS property definitions to have a 'runtime-flag' parameter which
1075         disables the property when the specified runtime flag is disabled.
1076
1077 2018-11-15  Timothy Hatcher  <timothy@apple.com>
1078
1079         REGRESSION (r238212): WebKit.BackgroundColor* API test failures.
1080         https://bugs.webkit.org/show_bug.cgi?id=191697
1081         rdar://problem/46098570
1082
1083         Reviewed by Dean Jackson.
1084
1085         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
1086         (TestWebKitAPI::TEST): Updated for new default background color.
1087
1088 2018-11-15  Jonathan Bedard  <jbedard@apple.com>
1089
1090         webkitpy: Check for specific process instead of using data migrator (Follow-up fix)
1091         https://bugs.webkit.org/show_bug.cgi?id=191551
1092         <rdar://problem/45993156>
1093
1094         Reviewed by Aakash Jain.
1095
1096         * Scripts/webkitpy/xcode/simulated_device.py:
1097         (SimulatedDevice.is_usable): Use software_variant instead of software_version for watchOS.
1098
1099 2018-11-15  Daniel Bates  <dabates@apple.com>
1100
1101         [iOS] Shift + Tab does not focus previous field
1102         https://bugs.webkit.org/show_bug.cgi?id=191596
1103         <rdar://problem/45892053>
1104
1105         Reviewed by Wenson Hsieh.
1106
1107         Add infrastructure to support testing a key down event with modifiers by creating
1108         and dispatching a UIEvent. This infrastructure replaces the previous mechanism in
1109         Tools/WebKitTestRunner/ios/HIDEventGenerator.mm to generate a IOHIDEvent for a
1110         keydown as it did not support creating an event with modifier key state that would
1111         be recognized by UIKit.
1112
1113         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1114         (WTR::UIScriptController::keyDown):
1115         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
1116         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
1117         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1118         Add function uiController.keyDown() that takes a character that represents a keyboard key
1119         and an array of modifier keys. The behavior of this function is analogous to eventSender.keyDown().
1120         Remove functions uiController.keyDownUsingHardwareKeyboard() and uiController.keyUpUsingHardwareKeyboard()
1121         as the former is replaced by uiController.keyDown() and the latter was never used.
1122
1123         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1124         (WTR::UIScriptController::keyDown): Added.
1125         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
1126         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
1127         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1128         * WebKitTestRunner/ios/HIDEventGenerator.h:
1129         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1130         (createHIDKeyDownEvent): Added.
1131         (-[HIDEventGenerator keyDown:completionBlock:]): Deleted.
1132         (-[HIDEventGenerator keyUp:completionBlock:]): Deleted.
1133         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1134         (WTR::arrayLength): Added.
1135         (WTR::parseModifier): Added.
1136         (WTR::parseModifierArray): Added.
1137         (WTR::UIScriptController::keyDown):
1138         (WTR::UIScriptController::keyDownUsingHardwareKeyboard): Deleted.
1139         (WTR::UIScriptController::keyUpUsingHardwareKeyboard): Deleted.
1140
1141 2018-11-15  Keith Rollin  <krollin@apple.com>
1142
1143         Delete old .xcfilelist files
1144         https://bugs.webkit.org/show_bug.cgi?id=191669
1145         <rdar://problem/46081994>
1146
1147         Reviewed by Chris Dumez.
1148
1149         .xcfilelist files were created and added to the Xcode project files in
1150         https://trac.webkit.org/changeset/238008/webkit. However, they caused
1151         build issues and they were removed from the Xcode projects in
1152         https://trac.webkit.org/changeset/238055/webkit. This check-in removes
1153         the files from the repository altogether. They'll ultimately be
1154         replaced with new files with names that indicate whether the
1155         associated files are inputs to the Run Script phase or are files
1156         created by the Run Script phase.
1157
1158         * DumpRenderTree/DerivedSources.xcfilelist: Removed.
1159         * WebKitTestRunner/DerivedSources.xcfilelist: Removed.
1160
1161 2018-11-14  Zalan Butjas  <zalan@apple.com>
1162
1163         [LFC][IFC] Add support for in-flow positioned inline boxes.
1164         https://bugs.webkit.org/show_bug.cgi?id=191672
1165
1166         Reviewed by Antti Koivisto.
1167
1168         * LayoutReloaded/misc/LFC-passing-tests.txt:
1169
1170 2018-11-14  Keith Rollin  <krollin@apple.com>
1171
1172         Move scripts for Derived and Unified Sources to external files
1173         https://bugs.webkit.org/show_bug.cgi?id=191670
1174         <rdar://problem/46082278>
1175
1176         Reviewed by Keith Miller.
1177
1178         Move the scripts in the Generate Derived Sources and Generate Unified
1179         Sources Run Script phases from the Xcode projects to external shell
1180         script files. Then invoke those scripts from the Run Script phases.
1181         This refactoring is being performed to support later work that will
1182         invoke these scripts in other contexts.
1183
1184         The scripts were maintained as-is when making the move. I did a little
1185         reformatting and added 'set -e' to the top of each file, but that's
1186         it.
1187
1188         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1189         * DumpRenderTree/Scripts/generate-derived-sources.sh: Added.
1190         * WebKitTestRunner/Scripts/generate-derived-sources.sh: Added.
1191         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1192
1193 2018-11-14  Chris Dumez  <cdumez@apple.com>
1194
1195         WebKit.DecidePolicyForNavigationActionForHyperlinkThatRedirects API fails when PSON is enabled
1196         https://bugs.webkit.org/show_bug.cgi?id=191640
1197
1198         Reviewed by Alex Christensen.
1199
1200         Add API test coverage.
1201
1202         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1203         (runDecidePolicyForNavigationActionForHyperlinkThatRedirects):
1204         (TEST):
1205
1206 2018-11-14  Chris Dumez  <cdumez@apple.com>
1207
1208         REGRESSION (r238115): [iOS] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is failing
1209         https://bugs.webkit.org/show_bug.cgi?id=191660
1210
1211         Reviewed by Ryosuke Niwa.
1212
1213         The test tries to navigate to an invalid URL and makes sure that we do not process swap
1214         for such load. The test was inherently racing because it was doing:
1215         <body onload="setTimeout(() => alert('DONE'), 0); location.href = 'http://A=a%B=b'">
1216
1217         Its load event handler tries to navigate to 'http://A=a%B=b' and sets a 0 timer to
1218         log an alert, which causes the API test to keep going and check that we did not swap
1219         process. The issue is that a 0 timer may not be sufficient to trigger the load, as
1220         the policy decision is asynchronous and relies on the UIProcess responding to it.
1221
1222         To address the issue, the test now waits for the next policy decision, spins the
1223         run loop and then makes sure we did not swap process. It no longer relies on a message
1224         from the page.
1225
1226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1227         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1228
1229 2018-11-14  Chris Dumez  <cdumez@apple.com>
1230
1231         WebKit.WebsiteDataStoreCustomPaths API test is failing when enabling process prewarming
1232         https://bugs.webkit.org/show_bug.cgi?id=191638
1233
1234         Reviewed by Alex Christensen.
1235
1236         Add API test coverage.
1237
1238         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1239         (runWebsiteDataStoreCustomPaths):
1240         (TEST):
1241
1242 2018-11-14  Alex Christensen  <achristensen@webkit.org>
1243
1244         Add SPI to show a safe browsing warning
1245         https://bugs.webkit.org/show_bug.cgi?id=191604
1246
1247         Reviewed by Andy Estes.
1248
1249         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1250         (TEST):
1251
1252 2018-11-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1253
1254         [iOS] A few drag and drop tests are crashing after r238146
1255         https://bugs.webkit.org/show_bug.cgi?id=191617
1256
1257         Reviewed by Dean Jackson.
1258
1259         Augment these crashing tests to verify that selection commands are suppressed during drop over editable elements
1260         via more robust means. These tests currently hit an assertion when revealing the callout bar too early, because
1261         TestWebKitAPI is not a UI application (see <https://webkit.org/b/190401>).
1262
1263         Instead of relying on this other bug, directly ask the text input whether it is suppressing selection commands
1264         during a drop, and remember the answer via DragAndDropSimulator.
1265
1266         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1267         (TestWebKitAPI::TEST):
1268
1269         Add to the existing tests that started failing after r238146.
1270
1271         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1272         * TestWebKitAPI/cocoa/TestWKWebView.h:
1273         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1274         (-[TestWKWebView textInputContentView]):
1275         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1276         (-[DragAndDropSimulator _resetSimulatedState]):
1277         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1278         * TestWebKitAPI/ios/UIKitSPI.h:
1279
1280 2018-11-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1281
1282         [Cocoa] [WebKit2] Hook up some more editing actions (-pasteAndMatchStyle:, -makeTextWritingDirectionNatural:)
1283         https://bugs.webkit.org/show_bug.cgi?id=191605
1284         <rdar://problem/45813991>
1285
1286         Reviewed by Dean Jackson.
1287
1288         Adds two new API tests to exercise -_pasteAndMatchStyle: and -makeTextWritingDirectionNatural:.
1289
1290         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1291         (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]): Deleted.
1292         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1293         (TestWebKitAPI::TEST):
1294         * TestWebKitAPI/cocoa/TestWKWebView.h:
1295         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1296
1297         Pull `-_synchronouslyExecuteEditCommand:argument:` out of WKAttachmentTests and into shared code, in a new
1298         category on WKWebView declared in TestWKWebView. Also, fix an unrelated typo in a nearby category.
1299
1300         (-[WKWebView _synchronouslyExecuteEditCommand:argument:]):
1301         * TestWebKitAPI/ios/UIKitSPI.h:
1302
1303 2018-11-14  Chris Dumez  <cdumez@apple.com>
1304
1305         WebKit.ApplicationManifestBasic API test is failing when enabling PSON
1306         https://bugs.webkit.org/show_bug.cgi?id=191602
1307
1308         Reviewed by Alex Christensen.
1309
1310         Add API test coverage.
1311
1312         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1313
1314 2018-11-14  Jonathan Bedard  <jbedard@apple.com>
1315
1316         webkitpy: Refactor port code for devices
1317         https://bugs.webkit.org/show_bug.cgi?id=191568
1318         <rdar://problem/46005821>
1319
1320         Reviewed by Alex Christensen.
1321
1322         watchOS and iOS device ports share many characteristics in testing, mostly due
1323         to the fact that both are devices.
1324
1325         * Scripts/webkitpy/port/device_port.py: Added.
1326         (DevicePort): Add base class that all simulated/physical device ports share.
1327         (DevicePort.__init__):
1328         (DevicePort.driver_cmd_line_for_logging): Moved from iOS port.
1329         (DevicePort._generate_all_test_configurations): Ditto.
1330         (DevicePort.child_processes): Ditto.
1331         (DevicePort.driver_name): Ditto.
1332         (DevicePort.target_host): Generalize worker access to attached devices and
1333         simulated devices based on the device manager.
1334         (DevicePort.devices): Return a list of all devices associated with this port.
1335         (DevicePort._create_devices):
1336         (DevicePort._build_driver_flags): Moved from iOSSimulatorPort/iOSDevicePort.
1337         (DevicePort._install): Moved from iOS port.
1338         (DevicePort.setup_test_run): Ditto.
1339         (DevicePort.clean_up_test_run): Ditto.
1340         (DevicePort.did_spawn_worker): Ditto.
1341         (DevicePort.setup_environ_for_server): Ditto.
1342         * Scripts/webkitpy/port/ios.py:
1343         (IOSPort):
1344         (IOSPort._device_for_worker_number_map): Replaced by DevicePort.devices().
1345         (IOSPort.driver_cmd_line_for_logging): Moved to DevicePort.
1346         (IOSPort.driver_name): Ditto.
1347         (IOSPort._generate_all_test_configurations): Ditto.
1348         (IOSPort.child_processes): Ditto.
1349         (IOSPort._testing_device): Ditto.
1350         (IOSPort.target_host): Ditto.
1351         (IOSPort._create_devices): Ditto.
1352         (IOSPort.setup_test_run): Ditto.
1353         (IOSPort.clean_up_test_run): Ditto.
1354         (IOSPort.did_spawn_worker): Ditto.
1355         * Scripts/webkitpy/port/ios_device.py:
1356         (IOSDevicePort): IOSDevicePort uses a device manager from apple_additions.
1357         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Use DevicePort.devices().
1358         (IOSDevicePort._get_crash_log): Ditto.
1359         (IOSDevicePort.ios_version): Ditto.
1360         (IOSDevicePort._create_devices): Ditto.
1361         (IOSDevicePort._device_for_worker_number_map): Replaced by DevicePort.devices().
1362         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
1363         * Scripts/webkitpy/port/ios_device_unittest.py:
1364         (IOSDeviceTest.test_get_crash_log):
1365         * Scripts/webkitpy/port/ios_simulator.py:
1366         (IOSSimulatorPort): IOSSimulatorPort uses the SimulatedDeviceManager.
1367         (IOSSimulatorPort._create_devices): Clean up logging statement.
1368         (IOSSimulatorPort.setup_environ_for_server): Some of environment set-up is shared
1369         across all devices.
1370         (IOSSimulatorPort._device_for_worker_number_map): Replaced by DevicePort.devices().
1371         (IOSSimulatorPort._build_driver_flags): Moved to DevicePort.
1372         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1373         (IOSSimulatorTest.test_32bit):
1374         (IOSSimulatorTest.test_64bit):
1375
1376 2018-11-14  Chris Dumez  <cdumez@apple.com>
1377
1378         WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
1379         https://bugs.webkit.org/show_bug.cgi?id=191624
1380
1381         Reviewed by Alex Christensen.
1382
1383         Add API test coverage.
1384
1385         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1386         (runWKHTTPCookieStoreWithoutProcessPool):
1387         (TEST):
1388
1389 2018-11-13  Jiewen Tan  <jiewen_tan@apple.com>
1390
1391         [WebAuthN] Support CTAP HID authenticators on macOS
1392         https://bugs.webkit.org/show_bug.cgi?id=188623
1393         <rdar://problem/43353777>
1394
1395         Reviewed by Brent Fulgham and Chris Dumez.
1396
1397         This patch adds support for the mock testing and entitlements to allow minibrowser to talk
1398         to hid devices.
1399
1400         * MiniBrowser/MiniBrowser.entitlements:
1401         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1402         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1403
1404 2018-11-13  Ryosuke Niwa  <rniwa@webkit.org>
1405
1406         WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
1407         https://bugs.webkit.org/show_bug.cgi?id=191616
1408
1409         Reviewed by Chris Dumez.
1410
1411         The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
1412         GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
1413         resulting in the use-after-free.
1414
1415         Made the tests more robust by clearing geolocation provider before exiting each test
1416         since we can't really prevent WKView from entering an autorelease pool.
1417
1418         Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
1419         instead of simply the end of the navigation so that the test would continue to work
1420         even if a web content process was created for the second web view (lowAccuracyWebView)
1421
1422         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1423         (TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
1424         (TestWebKitAPI::clearGeolocationProvider): Added.
1425         (TestWebKitAPI::runJavaScriptAlert): Added.
1426         (TestWebKitAPI::didFinishNavigation): Deleted.
1427         * TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
1428
1429 2018-11-13  Chris Dumez  <cdumez@apple.com>
1430
1431         WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
1432         https://bugs.webkit.org/show_bug.cgi?id=191618
1433
1434         Reviewed by Ryosuke Niwa.
1435
1436         Update API test to explicitly disable automatic process prewarning since it is testing
1437         manual prewarming.
1438
1439         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1440         (TEST):
1441
1442 2018-11-13  Chris Dumez  <cdumez@apple.com>
1443
1444         Several Service Worker API tests are failing when enabling PSON
1445         https://bugs.webkit.org/show_bug.cgi?id=191619
1446
1447         Reviewed by Youenn Fablet.
1448
1449         Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
1450         not impacted by process prewarming.
1451
1452         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1453
1454 2018-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1455
1456         [iOS] Do not show selection UI for editable elements with opacity near zero
1457         https://bugs.webkit.org/show_bug.cgi?id=191442
1458         <rdar://problem/45958625>
1459
1460         Reviewed by Simon Fraser.
1461
1462         Add a couple of new testing helpers to UIScriptController.
1463
1464         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1465         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1466         (WTR::UIScriptController::textSelectionRangeRects const):
1467         (WTR::UIScriptController::selectionCaretViewRect const):
1468         (WTR::UIScriptController::selectionRangeViewRects const):
1469         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1470         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1471         (WTR::UIScriptController::textSelectionRangeRects const):
1472
1473         Rename `selectionRangeViewRects` to `textSelectionRangeRects`. This allows us to draw a distinction between
1474         `textSelectionRangeRects`/`textSelectionCaretRect`, which retrieve information about selection rects known
1475         to the text interaction assistant, and `selectionCaretViewRect`/`selectionRangeViewRects`, which retrieve the
1476         actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
1477         new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).
1478
1479         Also, drive-by fix a leaked `NSMutableArray`.
1480
1481         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1482         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1483         (WTR::UIScriptController::selectionCaretViewRect const):
1484         (WTR::UIScriptController::selectionRangeViewRects const):
1485
1486         Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
1487         rects are also clamped to WKContentView bounds.
1488
1489 2018-11-13  Daniel Bates  <dabates@apple.com>
1490
1491         Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
1492         https://bugs.webkit.org/show_bug.cgi?id=173341
1493         <rdar://problem/32752890>
1494
1495         Reviewed by Simon Fraser.
1496
1497         There is little value to making a distinction between forward declarations
1498         of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
1499         the contents of these two headers can conflict with each other following
1500         r218275 as DumpRenderTree includes both headers. Instead we should remove
1501         UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.
1502
1503         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1504         * DumpRenderTree/mac/DumpRenderTree.mm:
1505         * TestRunnerShared/spi/UIKitTestSPI.h: Removed.
1506         * WebKitTestRunner/Configurations/Base.xcconfig:
1507         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1508         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1509         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1510         * WebKitTestRunner/ios/HIDEventGenerator.h:
1511         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1512         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1513         * WebKitTestRunner/ios/TestControllerIOS.mm:
1514         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1515         * WebKitTestRunner/ios/mainIOS.mm:
1516
1517 2018-11-13  Takashi Komori  <Takashi.Komori@sony.com>
1518
1519         Remove WebKitTestRunnerLib's build warnings.
1520         https://bugs.webkit.org/show_bug.cgi?id=191580
1521
1522         Reviewed by Fujii Hironori.
1523
1524         Include cmakeconfig.h in precompiled header.
1525
1526         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1527
1528 2018-11-12  Darshan Kadu  <darsh7807@gmail.com>
1529
1530         Implement Cache API support for WPE/GTK
1531         https://bugs.webkit.org/show_bug.cgi?id=178316
1532
1533         Reviewed by Michael Catanzaro.
1534
1535         Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
1536         on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm
1537
1538         * WebKitTestRunner/TestController.cpp:
1539         (WTR::TestController::generatePageConfiguration):
1540         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1541         (WTR::initializeWebViewConfiguration):
1542
1543 2018-11-12  Christopher Reid  <chris.reid@sony.com>
1544
1545         [Curl] Reject entire cookie if the domain fails a tailmatch.
1546         https://bugs.webkit.org/show_bug.cgi?id=191406
1547
1548         Reviewed by Youenn Fablet.
1549
1550         Added unittests for Curl cookie implementation.
1551
1552         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1553         (TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):
1554
1555 2018-11-12  Alex Christensen  <achristensen@webkit.org>
1556
1557         [iOS] Implement safe browsing in WebKit
1558         https://bugs.webkit.org/show_bug.cgi?id=191441
1559
1560         Reviewed by Tim Horton.
1561
1562         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1563         (checkTitleAndClick):
1564         (TEST):
1565
1566 2018-11-12  Basuke Suzuki  <basuke.suzuki@sony.com>
1567
1568         [Curl] Add API Test for Curl cookie backend.
1569         https://bugs.webkit.org/show_bug.cgi?id=191493
1570
1571         Reviewed by Youenn Fablet.
1572
1573         Add unit test to TestWebCore.
1574
1575         * TestWebKitAPI/PlatformWin.cmake:
1576         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
1577
1578 2018-11-12  Tim Horton  <timothy_horton@apple.com>
1579
1580         Make it possible to edit images inline
1581         https://bugs.webkit.org/show_bug.cgi?id=191352
1582         <rdar://problem/30107985>
1583
1584         Reviewed by Dean Jackson.
1585
1586         * WebKitTestRunner/TestController.cpp:
1587         (WTR::updateTestOptionsFromTestHeader):
1588         * WebKitTestRunner/TestOptions.h:
1589         (WTR::TestOptions::hasSameInitializationOptions const):
1590         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1591         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1592         (WTR::TestController::platformCreateWebView):
1593         Add a test option to enable editable images.
1594
1595         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1596         (WTR::UIScriptController::drawSquareInEditableImage):
1597         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1598         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1599         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1600         (WTR::UIScriptController::drawSquareInEditableImage):
1601         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1602         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1603         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
1604         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1605         (WTR::findEditableImageCanvas):
1606         (WTR::UIScriptController::drawSquareInEditableImage):
1607         (WTR::UIScriptController::numberOfStrokesInEditableImage):
1608         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
1609         and also to retrieve the number of strokes currently on the PKCanvasView.
1610         Currently this just takes the first canvas; we might need to make it
1611         take an identifier or something in the future if we need tests with multiple
1612         canvases. The indirect testing mechanism is required because PKCanvasView
1613         can currently not actually paint its strokes in the Simulator.
1614
1615 2018-11-12  Ryan Haddad  <ryanhaddad@apple.com>
1616
1617         [MediaStream] Screen capture should be an experimental feature on OSX only
1618         https://bugs.webkit.org/show_bug.cgi?id=191552
1619
1620         Unreviewed test gardening.
1621
1622         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
1623
1624 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1625
1626         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1627         https://bugs.webkit.org/show_bug.cgi?id=189230
1628         <rdar://problem/44050379>
1629
1630         Reviewed by Joseph Pecoraro.
1631
1632         Runs all png images through zopflipng. This results in a smaller file
1633         size and takes care of this issue as a byproduct.
1634
1635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
1636         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
1637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
1638         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png:
1639         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
1640         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png:
1641         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
1642         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png:
1643         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
1644         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10@2x.png:
1645         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
1646         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator@2x.png:
1647         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
1648         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png:
1649         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
1650         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png:
1651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png:
1653         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
1654         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png:
1655         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
1656         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png:
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
1658         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png:
1659         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
1660         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png:
1661         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
1662         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator@2x.png:
1663         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
1664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png:
1665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
1666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png:
1667         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
1668         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
1669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
1670         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png:
1671         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1672         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1673         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
1674         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png:
1675         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10@2x.png:
1677         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
1678         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png:
1679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
1680         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png:
1681         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
1682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png:
1683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
1684         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png:
1685
1686 2018-11-12  Tim Horton  <timothy_horton@apple.com>
1687
1688         Modernize WebKit Tools Xcode projects for localization's sake
1689         https://bugs.webkit.org/show_bug.cgi?id=191495
1690
1691         Reviewed by Alexey Proskuryakov.
1692
1693         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
1694         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1695         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
1696         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1697         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1698         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1699         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1701         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1702         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1703         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1704         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
1705         These are less important because they're not localized, but since
1706         I made the style checker complain, it now complains any time anyone
1707         touches any of these projects... so upgrade them.
1708
1709 2018-11-12  Jonathan Bedard  <jbedard@apple.com>
1710
1711         webkitpy: Check for specific process instead of using data migrator
1712         https://bugs.webkit.org/show_bug.cgi?id=191551
1713         <rdar://problem/45993156>
1714
1715         Rubber-stamped by Aakash Jain.
1716
1717         It's possible for the data migrator process to be stuck, but for a simulator to be
1718         usable. Use device-specific processes to detect when a device is usable.
1719
1720         * Scripts/webkitpy/xcode/simulated_device.py:
1721         (SimulatedDeviceManager._wait_until_device_is_usable):
1722         (SimulatedDeviceManager):
1723         (SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
1724         since this implies that a device is booted.
1725         (SimulatedDeviceManager.swap): Ditto.
1726         (SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
1727         process indicating the device is usable can be found.
1728         (SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.
1729         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that
1730         it triggers the logic in is_usable()
1731
1732 2018-11-12  Takashi Komori  <Takashi.Komori@sony.com>
1733
1734         Resurrect WebKitTestRunner for Windows port
1735         https://bugs.webkit.org/show_bug.cgi?id=189257
1736
1737         Reviewed by Fujii Hironori.
1738
1739         Implement WebKitTestRunner for WinCairo.
1740
1741         * PlatformWin.cmake:
1742         * Scripts/build-webkittestrunner:
1743         * WebKitTestRunner/CMakeLists.txt:
1744         * WebKitTestRunner/EventSenderProxy.h:
1745         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1746         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1747         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1748         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1749         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1750         (WTR::rangeToStr):
1751         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1752         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1753         (WTR::TestRunner::TestRunner):
1754         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1755         * WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.
1756         (WTR::AccessibilityController::resetToConsistentState):
1757         (WTR::AccessibilityController::accessibleElementById):
1758         (WTR::AccessibilityController::platformName):
1759         (WTR::AccessibilityController::rootElement):
1760         (WTR::AccessibilityController::focusedElement):
1761         (WTR::AccessibilityController::addNotificationListener):
1762         (WTR::AccessibilityController::removeNotificationListener):
1763         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.
1764         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1765         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1766         (WTR::AccessibilityUIElement::isEqual):
1767         (WTR::AccessibilityUIElement::getChildren):
1768         (WTR::AccessibilityUIElement::getChildrenWithRange):
1769         (WTR::AccessibilityUIElement::childrenCount):
1770         (WTR::AccessibilityUIElement::elementAtPoint):
1771         (WTR::AccessibilityUIElement::indexOfChild):
1772         (WTR::AccessibilityUIElement::childAtIndex):
1773         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1774         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1775         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1776         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1777         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1778         (WTR::AccessibilityUIElement::rowAtIndex):
1779         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
1780         (WTR::AccessibilityUIElement::selectedChildrenCount const):
1781         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1782         (WTR::AccessibilityUIElement::titleUIElement):
1783         (WTR::AccessibilityUIElement::parentElement):
1784         (WTR::AccessibilityUIElement::disclosedByRow):
1785         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1786         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1787         (WTR::AccessibilityUIElement::attributesOfChildren):
1788         (WTR::AccessibilityUIElement::allAttributes):
1789         (WTR::AccessibilityUIElement::stringAttributeValue):
1790         (WTR::AccessibilityUIElement::numberAttributeValue):
1791         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1792         (WTR::AccessibilityUIElement::rowHeaders const):
1793         (WTR::AccessibilityUIElement::columnHeaders const):
1794         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
1795         (WTR::AccessibilityUIElement::boolAttributeValue):
1796         (WTR::AccessibilityUIElement::isAttributeSettable):
1797         (WTR::AccessibilityUIElement::isAttributeSupported):
1798         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1799         (WTR::AccessibilityUIElement::role):
1800         (WTR::AccessibilityUIElement::subrole):
1801         (WTR::AccessibilityUIElement::roleDescription):
1802         (WTR::AccessibilityUIElement::computedRoleString):
1803         (WTR::AccessibilityUIElement::title):
1804         (WTR::AccessibilityUIElement::description):
1805         (WTR::AccessibilityUIElement::orientation const):
1806         (WTR::AccessibilityUIElement::stringValue):
1807         (WTR::AccessibilityUIElement::language):
1808         (WTR::AccessibilityUIElement::helpText const):
1809         (WTR::AccessibilityUIElement::x):
1810         (WTR::AccessibilityUIElement::y):
1811         (WTR::AccessibilityUIElement::width):
1812         (WTR::AccessibilityUIElement::height):
1813         (WTR::AccessibilityUIElement::clickPointX):
1814         (WTR::AccessibilityUIElement::clickPointY):
1815         (WTR::AccessibilityUIElement::intValue const):
1816         (WTR::AccessibilityUIElement::minValue):
1817         (WTR::AccessibilityUIElement::maxValue):
1818         (WTR::AccessibilityUIElement::valueDescription):
1819         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1820         (WTR::AccessibilityUIElement::isPressActionSupported):
1821         (WTR::AccessibilityUIElement::isIncrementActionSupported):
1822         (WTR::AccessibilityUIElement::isDecrementActionSupported):
1823         (WTR::AccessibilityUIElement::isEnabled):
1824         (WTR::AccessibilityUIElement::isRequired const):
1825         (WTR::AccessibilityUIElement::isFocused const):
1826         (WTR::AccessibilityUIElement::isSelected const):
1827         (WTR::AccessibilityUIElement::isSelectedOptionActive const):
1828         (WTR::AccessibilityUIElement::isExpanded const):
1829         (WTR::AccessibilityUIElement::isChecked const):
1830         (WTR::AccessibilityUIElement::isIndeterminate const):
1831         (WTR::AccessibilityUIElement::hierarchicalLevel const):
1832         (WTR::AccessibilityUIElement::speakAs):
1833         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
1834         (WTR::AccessibilityUIElement::ariaDropEffects const):
1835         (WTR::AccessibilityUIElement::lineForIndex):
1836         (WTR::AccessibilityUIElement::rangeForLine):
1837         (WTR::AccessibilityUIElement::rangeForPosition):
1838         (WTR::AccessibilityUIElement::boundsForRange):
1839         (WTR::AccessibilityUIElement::stringForRange):
1840         (WTR::AccessibilityUIElement::attributedStringForRange):
1841         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1842         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1843         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1844         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1845         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1846         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1847         (WTR::AccessibilityUIElement::attributesOfColumns):
1848         (WTR::AccessibilityUIElement::attributesOfRows):
1849         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1850         (WTR::AccessibilityUIElement::attributesOfHeader):
1851         (WTR::AccessibilityUIElement::rowCount):
1852         (WTR::AccessibilityUIElement::columnCount):
1853         (WTR::AccessibilityUIElement::indexInTable):
1854         (WTR::AccessibilityUIElement::rowIndexRange):
1855         (WTR::AccessibilityUIElement::columnIndexRange):
1856         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1857         (WTR::AccessibilityUIElement::horizontalScrollbar const):
1858         (WTR::AccessibilityUIElement::verticalScrollbar const):
1859         (WTR::AccessibilityUIElement::selectedTextRange):
1860         (WTR::AccessibilityUIElement::setSelectedTextRange):
1861         (WTR::AccessibilityUIElement::increment):
1862         (WTR::AccessibilityUIElement::decrement):
1863         (WTR::AccessibilityUIElement::showMenu):
1864         (WTR::AccessibilityUIElement::press):
1865         (WTR::AccessibilityUIElement::setSelectedChild const):
1866         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
1867         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
1868         (WTR::AccessibilityUIElement::clearSelectedChildren const):
1869         (WTR::AccessibilityUIElement::accessibilityValue const):
1870         (WTR::AccessibilityUIElement::documentEncoding):
1871         (WTR::AccessibilityUIElement::documentURI):
1872         (WTR::AccessibilityUIElement::url):
1873         (WTR::AccessibilityUIElement::addNotificationListener):
1874         (WTR::AccessibilityUIElement::removeNotificationListener):
1875         (WTR::AccessibilityUIElement::isFocusable const):
1876         (WTR::AccessibilityUIElement::isSelectable const):
1877         (WTR::AccessibilityUIElement::isMultiSelectable const):
1878         (WTR::AccessibilityUIElement::isVisible const):
1879         (WTR::AccessibilityUIElement::isOffScreen const):
1880         (WTR::AccessibilityUIElement::isCollapsed const):
1881         (WTR::AccessibilityUIElement::isIgnored const):
1882         (WTR::AccessibilityUIElement::isSingleLine const):
1883         (WTR::AccessibilityUIElement::isMultiLine const):
1884         (WTR::AccessibilityUIElement::hasPopup const):
1885         (WTR::AccessibilityUIElement::takeFocus):
1886         (WTR::AccessibilityUIElement::takeSelection):
1887         (WTR::AccessibilityUIElement::addSelection):
1888         (WTR::AccessibilityUIElement::removeSelection):
1889         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1890         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1891         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1892         (WTR::AccessibilityUIElement::previousTextMarker):
1893         (WTR::AccessibilityUIElement::nextTextMarker):
1894         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1895         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1896         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1897         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1898         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
1899         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
1900         (WTR::AccessibilityUIElement::textMarkerForPoint):
1901         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1902         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
1903         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
1904         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1905         (WTR::AccessibilityUIElement::indexForTextMarker):
1906         (WTR::AccessibilityUIElement::isTextMarkerValid):
1907         (WTR::AccessibilityUIElement::textMarkerForIndex):
1908         (WTR::AccessibilityUIElement::startTextMarker):
1909         (WTR::AccessibilityUIElement::endTextMarker):
1910         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
1911         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1912         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1913         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1914         (WTR::AccessibilityUIElement::supportedActions const):
1915         (WTR::AccessibilityUIElement::pathDescription const):
1916         (WTR::AccessibilityUIElement::mathPostscriptsDescription const):
1917         (WTR::AccessibilityUIElement::mathPrescriptsDescription const):
1918         (WTR::AccessibilityUIElement::classList const):
1919         (WTR::AccessibilityUIElement::characterAtOffset):
1920         (WTR::AccessibilityUIElement::wordAtOffset):
1921         (WTR::AccessibilityUIElement::lineAtOffset):
1922         (WTR::AccessibilityUIElement::sentenceAtOffset):
1923         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1924         (WTR::activateFonts):
1925         (WTR::installFakeHelvetica):
1926         (WTR::uninstallFakeHelvetica):
1927         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1928         (WTR::InjectedBundle::platformInitialize):
1929         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
1930         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1931         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
1932         (WTR::TestRunner::pathToLocalResource):
1933         (WTR::TestRunner::inspectorTestStubURL):
1934         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1935         (WTR::TestRunner::platformInitialize):
1936         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1937         (WTR::TestRunner::installFakeHelvetica):
1938         * WebKitTestRunner/PlatformWebView.h:
1939         * WebKitTestRunner/PlatformWin.cmake: Added.
1940         * WebKitTestRunner/TestController.cpp:
1941         (WTR::TestController::resetStateToConsistentValues):
1942         (WTR::createTestURL):
1943         * WebKitTestRunner/TestInvocation.cpp:
1944         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1945         * WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.
1946         (WTR::EventSenderProxy::EventSenderProxy):
1947         (WTR::EventSenderProxy::~EventSenderProxy):
1948         (WTR::EventSenderProxy::mouseDown):
1949         (WTR::EventSenderProxy::mouseUp):
1950         (WTR::EventSenderProxy::mouseMoveTo):
1951         (WTR::EventSenderProxy::mouseScrollBy):
1952         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1953         (WTR::EventSenderProxy::continuousMouseScrollBy):
1954         (WTR::EventSenderProxy::leapForward):
1955         (WTR::EventSenderProxy::keyDown):
1956         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
1957         (WTR::registerWindowClass):
1958         (WTR::PlatformWebView::PlatformWebView):
1959         (WTR::PlatformWebView::~PlatformWebView):
1960         (WTR::PlatformWebView::resizeTo):
1961         (WTR::PlatformWebView::page):
1962         (WTR::PlatformWebView::focus):
1963         (WTR::PlatformWebView::windowFrame):
1964         (WTR::PlatformWebView::setWindowFrame):
1965         (WTR::PlatformWebView::didInitializeClients):
1966         (WTR::PlatformWebView::addChromeInputField):
1967         (WTR::PlatformWebView::removeChromeInputField):
1968         (WTR::PlatformWebView::addToWindow):
1969         (WTR::PlatformWebView::removeFromWindow):
1970         (WTR::PlatformWebView::setWindowIsKey):
1971         (WTR::PlatformWebView::makeWebViewFirstResponder):
1972         (WTR::generateCairoSurfaceFromBitmap):
1973         (WTR::PlatformWebView::windowSnapshotImage):
1974         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1975         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1976         (WTR::PlatformWebView::forceWindowFramesChanged):
1977         (WTR::PlatformWebView::drawsBackground const):
1978         (WTR::PlatformWebView::setDrawsBackground):
1979         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
1980         (WTR::exceptionFilter):
1981         (WTR::runRunLoopUntil):
1982         (WTR::TestController::notifyDone):
1983         (WTR::TestController::setHidden):
1984         (WTR::TestController::platformInitialize):
1985         (WTR::TestController::platformPreferences):
1986         (WTR::TestController::platformDestroy):
1987         (WTR::toWK):
1988         (WTR::TestController::platformInitializeContext):
1989         (WTR::TestController::platformRunUntil):
1990         (WTR::TestController::platformDidCommitLoadForFrame):
1991         (WTR::TestController::initializeInjectedBundlePath):
1992         (WTR::TestController::initializeTestPluginDirectory):
1993         (WTR::TestController::runModal):
1994         (WTR::TestController::platformContext):
1995         (WTR::TestController::platformLibraryPathForTesting):
1996         (WTR::TestController::platformConfigureViewForTest):
1997         (WTR::TestController::platformResetPreferencesToConsistentValues):
1998         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
1999         * WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
2000         * WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
2001         (dllLauncherEntryPoint):
2002
2003 2018-11-12  Alicia Boya García  <aboya@igalia.com>
2004
2005         [MSE][GStreamer] Introduce AbortableTaskQueue
2006         https://bugs.webkit.org/show_bug.cgi?id=190902
2007
2008         Reviewed by Xabier Rodriguez-Calvar.
2009
2010         Tests for AbortableTaskQueue are included.
2011
2012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2013         * TestWebKitAPI/PlatformGTK.cmake:
2014         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
2015         (TestWebKitAPI::TEST):
2016         (TestWebKitAPI::FancyResponse::FancyResponse):
2017         (TestWebKitAPI::FancyResponse::operator=):
2018         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
2019         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
2020         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
2021         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
2022
2023 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2024
2025         run-bindings-tests is timing out in some WinCairo bots
2026         https://bugs.webkit.org/show_bug.cgi?id=191348
2027
2028         Reviewed by Alex Christensen.
2029
2030         BuildBot kills run-bindings-tests if it outputs nothing for 20
2031         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
2032         and it takes more than 30 minutes to finish. And, Windows Python
2033         buffers the progress output.
2034
2035         * Scripts/webkitpy/bindings/main.py:
2036         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
2037         test case result is output.
2038
2039 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2040
2041         Implement a new edit command to change the enclosing list type
2042         https://bugs.webkit.org/show_bug.cgi?id=191487
2043         <rdar://problem/45955922>
2044
2045         Reviewed by Ryosuke Niwa.
2046
2047         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
2048         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
2049
2050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2051         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2052         (-[TestWKWebView setPosition:offset:]):
2053         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
2054         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
2055         (TestWebKitAPI::TEST):
2056         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
2057
2058 2018-11-11  Dan Bernstein  <mitz@apple.com>
2059
2060         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
2061         https://bugs.webkit.org/show_bug.cgi?id=191514
2062
2063         Reviewed by Geoffrey Garen.
2064
2065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2066         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
2067         (TEST):
2068
2069 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2070
2071         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2072         https://bugs.webkit.org/show_bug.cgi?id=191492
2073
2074         Reviewed by Alex Christensen.
2075
2076         Update file name.
2077
2078         * DumpRenderTree/mac/DumpRenderTree.mm:
2079         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2080         * WebKitTestRunner/mac/TestControllerMac.mm:
2081
2082 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2083
2084         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2085         https://bugs.webkit.org/show_bug.cgi?id=191492
2086
2087         Reviewed by Alex Christensen.
2088
2089         * DumpRenderTree/mac/DumpRenderTree.mm:
2090         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2091         * WebKitTestRunner/mac/TestControllerMac.mm:
2092
2093 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
2094
2095         Unreviewed, rolling out r238065.
2096
2097         Breaks internal builds.
2098
2099         Reverted changeset:
2100
2101         "Make it possible to edit images inline"
2102         https://bugs.webkit.org/show_bug.cgi?id=191352
2103         https://trac.webkit.org/changeset/238065
2104
2105 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2106
2107         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
2108         https://bugs.webkit.org/show_bug.cgi?id=191221
2109
2110         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
2111         that it is disabled, but we're testing that it is enabled, because I failed to update this
2112         line.
2113
2114         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2115         (testWebKitSettings):
2116
2117 2018-11-10  Tim Horton  <timothy_horton@apple.com>
2118
2119         Make it possible to edit images inline
2120         https://bugs.webkit.org/show_bug.cgi?id=191352
2121         <rdar://problem/30107985>
2122
2123         Reviewed by Dean Jackson.
2124
2125         * WebKitTestRunner/TestController.cpp:
2126         (WTR::updateTestOptionsFromTestHeader):
2127         * WebKitTestRunner/TestOptions.h:
2128         (WTR::TestOptions::hasSameInitializationOptions const):
2129         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2130         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2131         (WTR::TestController::platformCreateWebView):
2132         Add a test option to enable editable images.
2133
2134         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2135         (WTR::UIScriptController::drawSquareInEditableImage):
2136         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2137         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2138         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2139         (WTR::UIScriptController::drawSquareInEditableImage):
2140         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2141         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2142         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
2143         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2144         (WTR::findEditableImageCanvas):
2145         (WTR::UIScriptController::drawSquareInEditableImage):
2146         (WTR::UIScriptController::numberOfStrokesInEditableImage):
2147         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
2148         and also to retrieve the number of strokes currently on the PKCanvasView.
2149         Currently this just takes the first canvas; we might need to make it
2150         take an identifier or something in the future if we need tests with multiple
2151         canvases. The indirect testing mechanism is required because PKCanvasView
2152         can currently not actually paint its strokes in the Simulator.
2153
2154 2018-11-09  Chris Dumez  <cdumez@apple.com>
2155
2156         Suspended page persists even after back/forward list item is gone
2157         https://bugs.webkit.org/show_bug.cgi?id=191488
2158         <rdar://problem/45953006>
2159
2160         Reviewed by Geoffrey Garen.
2161
2162         Add API test coverage.
2163
2164         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2165
2166 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2167
2168         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
2169         https://bugs.webkit.org/show_bug.cgi?id=191471
2170         <rdar://problem/45952472>
2171
2172         Reviewed by Tim Horton.
2173
2174         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
2175
2176         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2177         (TestWebKitAPI::webViewForEditActionTesting):
2178         (TestWebKitAPI::TEST):
2179
2180 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
2181
2182         [Curl][WebKit] Implement Proxy configuration API.
2183         https://bugs.webkit.org/show_bug.cgi?id=189053
2184
2185         Reviewed by Youenn Fablet.
2186
2187         Added Proxy Settings dialog to call newly added API.
2188
2189         * MiniBrowser/win/BrowserWindow.h:
2190         * MiniBrowser/win/Common.cpp:
2191         (askProxySettings):
2192         (askCredential):
2193         (authDialogProc): Deleted.
2194         * MiniBrowser/win/Common.h:
2195         * MiniBrowser/win/DialogHelper.h: Added.
2196         (Dialog::run):
2197         (Dialog::doalogProc):
2198         (Dialog::handle):
2199         (Dialog::setup):
2200         (Dialog::update):
2201         (Dialog::validate):
2202         (Dialog::updateOkButton):
2203         (Dialog::command):
2204         (Dialog::ok):
2205         (Dialog::cancel):
2206         (Dialog::close):
2207         (Dialog::hDlg):
2208         (Dialog::item):
2209         (Dialog::setEnabled):
2210         (Dialog::setText):
2211         (Dialog::getText):
2212         (Dialog::getTextLength):
2213         (Dialog::RadioGroup::RadioGroup):
2214         (Dialog::RadioGroup::set):
2215         (Dialog::RadioGroup::get):
2216         (Dialog::radioGroup):
2217         * MiniBrowser/win/MainWindow.cpp:
2218         (MainWindow::WndProc):
2219         * MiniBrowser/win/MiniBrowserLib.rc:
2220         * MiniBrowser/win/MiniBrowserLibResource.h:
2221         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2222         (createWKURL):
2223         (WebKitBrowserWindow::WebKitBrowserWindow):
2224         (WebKitBrowserWindow::updateProxySettings):
2225         (WebKitBrowserWindow::loadURL):
2226         (WebKitBrowserWindow::loadHTMLString):
2227         (WebKitBrowserWindow::openProxySettings):
2228         * MiniBrowser/win/WebKitBrowserWindow.h:
2229         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2230         (WebKitLegacyBrowserWindow::openProxySettings):
2231         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2232
2233 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2234
2235         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
2236         https://bugs.webkit.org/show_bug.cgi?id=191410
2237         <rdar://problem/45898610>
2238
2239         Reviewed by Dean Jackson.
2240
2241         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
2242         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
2243         hooked up to their respective editing commands.
2244
2245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2246         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
2247         (-[TestWKWebView querySelectorExists:]):
2248         (-[TestWKWebView insertString:]):
2249
2250         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
2251         invoking the WKWebView directly on macOS and calling on the content view on iOS.
2252
2253         (TestWebKitAPI::webViewForEditActionTesting):
2254         (TestWebKitAPI::TEST):
2255
2256 2018-11-09  Philippe Normand  <pnormand@igalia.com>
2257
2258         [Flatpak] Refactoring and drive-by fixes
2259         https://bugs.webkit.org/show_bug.cgi?id=191421
2260
2261         Reviewed by Michael Catanzaro.
2262
2263         * Scripts/webkitdirs.pm:
2264         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
2265         the sandbox, so rely on this.
2266         * flatpak/flatpakutils.py:
2267         (expand_manifest): Pass explicit keywords to load_manifest() and
2268         remove unused local variable.
2269         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
2270         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
2271         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
2272         build_type handling a bit.
2273         * flatpak/org.webkit.CommonModules.yaml: Added.
2274         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
2275         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
2276         declaration to CommonModules, so it can be reused later when we
2277         add support for building extra libraries depending on WPE.
2278
2279 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
2280
2281 onal supported image formats
2282         https://bugs.webkit.org/show_bug.cgi?id=190454
2283
2284         Reviewed by Simon Fraser.
2285
2286         Test opening a TGA image in WebView which is not allowed by default. The
2287         TGA format will be allowed through WKWebViewConfiguration.
2288
2289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2290         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
2291         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
2292         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
2293         (runTest):
2294         (TEST):
2295
2296 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
2297
2298         Unreviewed, a proper build fix for r237983
2299
2300         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
2301
2302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2303         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
2304         (TestWebKitAPI::TEST):
2305         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
2306         (TestWebKitAPI::getTestCorruptedSignResponse):
2307         (TestWebKitAPI::getTestCredentialRawIdBytes):
2308         (TestWebKitAPI::convertToVector):
2309         (TestWebKitAPI::TEST):
2310
2311 2018-11-08  Keith Rollin  <krollin@apple.com>
2312
2313         Create .xcfilelist files
2314         https://bugs.webkit.org/show_bug.cgi?id=191324
2315         <rdar://problem/45852819>
2316
2317         Reviewed by Alex Christensen.
2318
2319         As part of preparing for enabling XCBuild, create and use .xcfilelist
2320         files. These files are using during Run Script build phases in an
2321         Xcode project. If a Run Script build phase produces new files that are
2322         used later as inputs to subsequent build phases, XCBuild needs to know
2323         about these files. These files can be either specified in an "output
2324         files" section of the Run Script phase editor, or in .xcfilelist files
2325         that are associated with the Run Script build phase.
2326
2327         This patch takes the second approach. It consists of three sets of changes:
2328
2329         - Modify the DerivedSources.make files to have a
2330           'print_all_generated_files" target that produces a list of the files
2331           they create.
2332
2333         - Create a shell script that produces .xcfilelist files from the
2334           output of the previous step, as well as for the files created in the
2335           Generate Unified Sources build steps.
2336
2337         - Add the new .xcfilelist files to the associated projects.
2338
2339         Note that, with these changes, the Xcode workspace and projects can no
2340         longer be fully loaded into Xcode 9. Xcode will attempt to load the
2341         projects that have .xcfilelist files associated with them, but will
2342         fail and display a placeholder for those projects instead. It's
2343         expected that all developers are using Xcode 10 by now and that not
2344         being able to load into Xcode 9 is not a practical issue. Keep in mind
2345         that this is strictly an IDE issue, and that the projects can still be
2346         built with `xcodebuild`.
2347
2348         Also note that the shell script that creates the .xcfilelist files can
2349         also be used to verify that the set of files that's currently checked
2350         in is up-to-date. This checking can be used as part of a check-in hook
2351         or part of check-webkit-style to sooner catch cases where the
2352         .xcfilelist files need to be regenerated.
2353
2354         * DumpRenderTree/DerivedSources.make:
2355         * DumpRenderTree/DerivedSources.xcfilelist: Added.
2356         * Scripts/generate-xcfilelists: Added.
2357         * WebKitTestRunner/DerivedSources.make:
2358         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
2359
2360 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
2361
2362         Unreviewed, a quick build fix for r237983
2363
2364         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
2365
2366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
2367         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
2368         (TestWebKitAPI::TEST):
2369         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
2370         (TestWebKitAPI::getTestCorruptedSignResponse):
2371         (TestWebKitAPI::getTestCredentialRawIdBytes):
2372         (TestWebKitAPI::convertToVector):
2373         (TestWebKitAPI::TEST):
2374
2375 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
2376
2377         Fix steps_unittest.py failures related to recent Win10/Win7 changes
2378         https://bugs.webkit.org/show_bug.cgi?id=191290
2379
2380         Reviewed by Alexey Proskuryakov.
2381
2382         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
2383
2384 2018-11-08  Dean Jackson  <dino@apple.com>
2385
2386         Add a String literal that returns a String
2387         https://bugs.webkit.org/show_bug.cgi?id=191425
2388         <rdar://problem/45914556>
2389
2390         Reviewed by Sam Weinig.
2391
2392         Test _str.
2393
2394         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2395         (TestWebKitAPI::TEST):
2396
2397 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
2398
2399         webkitpy: Generalize trailing SDK specifier (Part 2)
2400         https://bugs.webkit.org/show_bug.cgi?id=191275
2401         <rdar://problem/45703660>
2402
2403         Rubber-stamped by Aakash Jain.
2404
2405         Re-landing this change, configuration issues have been resolved.
2406
2407         * Scripts/webkitpy/port/ios_device.py:
2408         (IOSDevicePort): Use normalized SDK.
2409         * Scripts/webkitpy/port/ios_simulator.py:
2410         (IOSSimulatorPort): Use normalized SDK.
2411         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
2412
2413 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
2414
2415         [WebAuthN] Import CTAP device request/response converters from Chromium
2416         https://bugs.webkit.org/show_bug.cgi?id=190784
2417         <rdar://problem/45460333>
2418
2419         Reviewed by Brent Fulgham.
2420
2421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2422         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
2423         (TestWebKitAPI::TEST):
2424         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
2425         (TestWebKitAPI::TEST):
2426         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
2427         (TestWebKitAPI::getTestCorruptedSignResponse):
2428         (TestWebKitAPI::getTestCredentialRawIdBytes):
2429         (TestWebKitAPI::convertToVector):
2430         (TestWebKitAPI::TEST):
2431         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
2432
2433 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
2434
2435         [BigInt] Add support to BigInt into ValueAdd
2436         https://bugs.webkit.org/show_bug.cgi?id=186177
2437
2438         Reviewed by Keith Miller.
2439
2440         * Scripts/run-jsc-benchmarks:
2441
2442 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
2443
2444         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
2445         https://bugs.webkit.org/show_bug.cgi?id=191326
2446         <rdar://problem/45769269>
2447
2448         Reviewed by Geoffrey Garen.
2449
2450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2451         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
2452         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
2453         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
2454         (TEST):
2455
2456 2018-11-07  Daniel Bates  <dabates@apple.com>
2457
2458         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
2459         https://bugs.webkit.org/show_bug.cgi?id=190141
2460
2461         Reviewed by Darin Adler.
2462
2463         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
2464         runs deterministic regardless of whether a hardware keyboard is attached.
2465
2466         * DumpRenderTree/mac/DumpRenderTree.mm:
2467         (overrideIsInHardwareKeyboardMode): Added.
2468         (prepareConsistentTestingEnvironment):
2469         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
2470         * WebKitTestRunner/ios/TestControllerIOS.mm:
2471         (overrideIsInHardwareKeyboardMode): Added.
2472         (WTR::TestController::platformInitialize):
2473
2474 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
2475
2476         Unreviewed, rolling out r237913.
2477
2478         Breaks running tests on Mac without iOS SDK installed
2479
2480         Reverted changeset:
2481
2482         "webkitpy: Generalize trailing SDK specifier (Part 2)"
2483         https://bugs.webkit.org/show_bug.cgi?id=191275
2484         https://trac.webkit.org/changeset/237913
2485
2486 2018-11-07  Zamiul Haque  <zhaque@apple.com>
2487
2488         Force a gregorian calendar to show for credit card expiration date inputs
2489         (autocomplete='cc-exp'*) regardless of default system settings.
2490         https://bugs.webkit.org/show_bug.cgi?id=191096
2491         rdar://problem/42640256
2492
2493         Reviewed by Tim Horton.
2494
2495         Implemented simulateForeignDefaultCalendar and calendarType to be used
2496         for changing the default calendar returned by the system (ie. [NSCalendar
2497         currentCalendar]) and getting the calendar type identifier of a presented date
2498         picker.
2499
2500         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2501         (WTR::UIScriptController::isShowingDataListSuggestions const):
2502         (WTR::UIScriptController::calendarType const):
2503         (WTR::UIScriptController::setDefaultCalendarType):
2504         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2505         (WTR::UIScriptController::calendarType const):
2506         (WTR::UIScriptController::setDefaultCalendarType):
2507         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2508         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2509         (WTR::UIScriptController::calendarType const): Deleted.
2510         * WebKitTestRunner/TestController.cpp:
2511         * WebKitTestRunner/TestController.h:
2512         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2513         (WTR::UIScriptController::calendarType const):
2514         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2515         (WTR::swizzledCalendar):
2516         (WTR::TestController::getOverriddenCalendarIdentifier const):
2517         (WTR::TestController::setDefaultCalendarType):
2518         (WTR::TestController::cocoaResetStateToConsistentValues):
2519         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2520         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2521         (WTR::UIScriptController::calendarType const): Deleted.
2522
2523 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
2524
2525         webkitpy: Boot a single worker for custom devices
2526         https://bugs.webkit.org/show_bug.cgi?id=191312
2527         <rdar://problem/45848717>
2528
2529         Rubber-stamped by Aakash Jain.
2530
2531         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2532         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
2533         simulators is expensive and unneeded for these tests.
2534         * Scripts/webkitpy/port/ios.py:
2535         (IOSPort. child_processes): No reason to memoize this call, and it prevents
2536         overriding the number of child processes when booting custom devices.
2537
2538 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
2539
2540         webkitpy: Generalize trailing SDK specifier (Part 2)
2541         https://bugs.webkit.org/show_bug.cgi?id=191275
2542         <rdar://problem/45703660>
2543
2544         Reviewed by Aakash Jain.
2545
2546         * Scripts/webkitpy/port/ios_device.py:
2547         (IOSDevicePort): Use normalized SDK.
2548         * Scripts/webkitpy/port/ios_simulator.py:
2549         (IOSSimulatorPort): Use normalized SDK.
2550         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
2551
2552 2018-11-06  Justin Fan  <justin_fan@apple.com>
2553
2554         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2555         https://bugs.webkit.org/show_bug.cgi?id=191291
2556
2557         Reviewed by Myles Maxfield.
2558
2559         Properly disable WEBGPU on all non-Metal platforms for now.
2560
2561         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2562
2563 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2564
2565         [ews-app] Add URL configuration for OpenSource EWS Django app
2566         https://bugs.webkit.org/show_bug.cgi?id=191132
2567
2568         Rubber-stamped by Lucas Forschler.
2569
2570         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
2571         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
2572
2573 2018-11-06  Youenn Fablet  <youenn@apple.com>
2574
2575         Make mDNS ICE Candidate an experimental flag again
2576         https://bugs.webkit.org/show_bug.cgi?id=191262
2577
2578         Reviewed by Dean Jackson.
2579
2580         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2581         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2582         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2583         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
2584         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2585
2586 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2587
2588         [ews-app] Add views for OpenSource EWS Django app
2589         https://bugs.webkit.org/show_bug.cgi?id=191131
2590
2591         Rubber-stamped by Lucas Forschler.
2592
2593         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
2594         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2595         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
2596         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
2597
2598 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2599
2600         [ews-app] Add models for OpenSource EWS Django app
2601         https://bugs.webkit.org/show_bug.cgi?id=191123
2602
2603         Reviewed by Lucas Forschler.
2604
2605         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2606         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
2607         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
2608         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2609         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
2610
2611 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2612
2613         [ews-app] Fix Invalid HTTP_HOST header
2614         https://bugs.webkit.org/show_bug.cgi?id=191325
2615
2616         Reviewed by Lucas Forschler.
2617
2618         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
2619
2620         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2621
2622 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2623
2624         [ews-app] Rename EWS_app to ews-app - part 2
2625         https://bugs.webkit.org/show_bug.cgi?id=191317
2626
2627         Reviewed by Lucas Forschler.
2628
2629         * BuildSlaveSupport/ews-app/EWS_app: Removed.
2630         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
2631         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2632         * BuildSlaveSupport/ews-app/ews-app/urls.py:
2633         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
2634         * BuildSlaveSupport/ews-app/manage.py:
2635
2636 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
2637
2638         [ews-app] Rename EWS_app to ews-app - part 1
2639         https://bugs.webkit.org/show_bug.cgi?id=191317
2640
2641         Reviewed by Lucas Forschler.
2642
2643         * BuildSlaveSupport/EWS_app: Removed.
2644         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
2645
2646 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
2647
2648         Spelling dots are drawn in the wrong place
2649         https://bugs.webkit.org/show_bug.cgi?id=190764
2650
2651         Reviewed by Dean Jackson.
2652
2653         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
2654         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
2655         dots to be drawn.
2656
2657         * WebKitTestRunner/TestController.cpp:
2658         (WTR::TestController::resetStateToConsistentValues):
2659         (WTR::updateTestOptionsFromTestHeader):
2660         (WTR::TestController::platformResetStateToConsistentValues):
2661         * WebKitTestRunner/TestController.h:
2662         * WebKitTestRunner/TestOptions.h:
2663         (WTR::TestOptions::hasSameInitializationOptions const):
2664         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2665         (WTR::TestController::cocoaResetStateToConsistentValues):
2666         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2667         * WebKitTestRunner/ios/TestControllerIOS.mm:
2668         (WTR::TestController::platformResetStateToConsistentValues):
2669         * WebKitTestRunner/mac/TestControllerMac.mm:
2670         (WTR::TestController::platformResetStateToConsistentValues):
2671
2672 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
2673
2674         Feature flags not present for Visual Studio when using build-webkit
2675         https://bugs.webkit.org/show_bug.cgi?id=191288
2676
2677         Reviewed by Fujii Hironori.
2678
2679         Passes feature flags to Visual studio builds within build-webkit.
2680         Removes cmakeBasedPortArguments as it is no longer in use.
2681
2682         * Scripts/build-jsc:
2683         * Scripts/build-webkit:
2684         * Scripts/webkitdirs.pm:
2685         (cmakeBasedPortArguments): Deleted.
2686
2687 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
2688
2689         REGRESSION (r230523): Caps lock indicator not shown in password field
2690         https://bugs.webkit.org/show_bug.cgi?id=190056
2691
2692         Reviewed by Ryosuke Niwa.
2693
2694         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2695         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2696         (WTR::TestRunner::toggleCapsLock):
2697         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2698         * WebKitTestRunner/TestController.h:
2699         * WebKitTestRunner/TestInvocation.cpp:
2700         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2701         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2702         (WTR::TestController::toggleCapsLock):
2703
2704 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
2705
2706         IndexedDB: WAL file keeps growing
2707         https://bugs.webkit.org/show_bug.cgi?id=191294
2708         <rdar://problem/41333493>
2709
2710         Reviewed by Chris Dumez.
2711
2712         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2713         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
2714         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
2715         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
2716         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
2717         (TEST):
2718
2719 2018-11-06  Alex Christensen  <achristensen@webkit.org>
2720
2721         Fix tests after r237863
2722         https://bugs.webkit.org/show_bug.cgi?id=191315
2723
2724         Reviewed by Chris Dumez.
2725
2726         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2727         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
2728         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
2729         to verify that main2.html eventually loads, making this test less timing dependent.
2730
2731 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
2732
2733         Unreviewed, rolling out r237834.
2734
2735         Tests for this change crash on iOS Simulator
2736
2737         Reverted changeset:
2738
2739         "Spelling dots are drawn in the wrong place"
2740         https://bugs.webkit.org/show_bug.cgi?id=190764
2741         https://trac.webkit.org/changeset/237834
2742
2743 2018-11-05  Alex Christensen  <achristensen@webkit.org>
2744
2745         [Mac] Implement safe browsing in WebKit
2746         https://bugs.webkit.org/show_bug.cgi?id=188871
2747
2748         Reviewed by Tim Horton.
2749
2750         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2751         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
2752         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
2753         (-[TestLookupContext lookUpURL:completionHandler:]):
2754         (simpleURL):
2755         (safeBrowsingView):
2756         (TEST):
2757         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
2758         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
2759         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
2760         * TestWebKitAPI/Utilities.h:
2761
2762 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
2763
2764         webkitpy: Generalize trailing SDK specifier (Part 1)
2765         https://bugs.webkit.org/show_bug.cgi?id=191275
2766         <rdar://problem/45703660>
2767
2768         Reviewed by Lucas Forschler.
2769
2770         * Scripts/webkitpy/common/system/platforminfo.py:
2771         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
2772         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2773         (TestPlatformInfo):
2774         (TestPlatformInfo.test_available_sdks):
2775
2776 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
2777
2778         Spelling dots are drawn in the wrong place
2779         https://bugs.webkit.org/show_bug.cgi?id=190764
2780
2781         Reviewed by Dean Jackson.
2782
2783         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
2784         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
2785         dots to be drawn.
2786
2787         * WebKitTestRunner/TestController.cpp:
2788         (WTR::TestController::resetStateToConsistentValues):
2789         (WTR::updateTestOptionsFromTestHeader):
2790         (WTR::TestController::platformResetStateToConsistentValues):
2791         * WebKitTestRunner/TestController.h:
2792         * WebKitTestRunner/TestOptions.h:
2793         (WTR::TestOptions::hasSameInitializationOptions const):
2794         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2795         (WTR::TestController::cocoaResetStateToConsistentValues):
2796         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2797         * WebKitTestRunner/ios/TestControllerIOS.mm:
2798         (WTR::TestController::platformResetStateToConsistentValues):
2799         * WebKitTestRunner/mac/TestControllerMac.mm:
2800         (WTR::TestController::platformResetStateToConsistentValues):
2801
2802 2018-11-05  Chris Dumez  <cdumez@apple.com>
2803
2804         Use same limit for page cache and suspended pages
2805         https://bugs.webkit.org/show_bug.cgi?id=191266
2806
2807         Reviewed by Geoffrey Garen.
2808
2809         Update API tests accordingly.
2810
2811         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2812
2813 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2814
2815         [style] Exclude style check for auto generated files.
2816         https://bugs.webkit.org/show_bug.cgi?id=191118
2817
2818         Reviewed by Eric Carlson.
2819
2820         Some files checked in to the repository are generated by other tools. In this patch,
2821         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
2822         VisualStudio.
2823
2824         There's no need to check these files because it's not practical to fix the style errors
2825         or it's hard to maintain those fixes.
2826
2827         * Scripts/webkitpy/style/checkers/cpp.py:
2828         (is_generated_file):
2829         (CppChecker.check):
2830
2831 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
2832
2833         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
2834         https://bugs.webkit.org/show_bug.cgi?id=190680
2835
2836         Reviewed by Philippe Normand.
2837
2838         * flatpak/org.webkit.WebKit.yaml:
2839
2840 2018-11-05  Daniel Bates  <dabates@apple.com>
2841
2842         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
2843         https://bugs.webkit.org/show_bug.cgi?id=191094
2844
2845         Reviewed by Andy Estes.
2846
2847         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
2848         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
2849         Document summary and add closing brace '}' to both Frame and Document summary strings to make
2850         them look pretty.
2851
2852         * lldb/lldb_webkit.py:
2853         (WebCoreFrame_SummaryProvider):
2854         (WebCoreDocument_SummaryProvider):
2855
2856 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2857
2858         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
2859         https://bugs.webkit.org/show_bug.cgi?id=191240
2860         <rdar://problem/44872806>
2861
2862         Reviewed by Tim Horton.
2863
2864         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
2865         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
2866         overriding `-[WKWebView inputAssistantItem]`.
2867
2868         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2869         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
2870         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
2871         (+[InputAssistantItemTestingWebView barButtonIcon]):
2872         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
2873         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
2874         (-[InputAssistantItemTestingWebView inputAssistantItem]):
2875         (TestWebKitAPI::TEST):
2876
2877 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2878
2879         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
2880         https://bugs.webkit.org/show_bug.cgi?id=191226
2881         <rdar://problem/45781765>
2882
2883         Reviewed by Tim Horton.
2884
2885         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
2886         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
2887
2888         * WebKitTestRunner/TestOptions.h:
2889         (WTR::TestOptions::hasSameInitializationOptions const):
2890
2891 2018-11-05  Commit Queue  <commit-queue@webkit.org>
2892
2893         Unreviewed, rolling out r237784 and r237788.
2894         https://bugs.webkit.org/show_bug.cgi?id=191270
2895
2896         Caused mediastream layout test failures (Requested by
2897         ryanhaddad on #webkit).
2898
2899         Reverted changesets:
2900
2901         "[MediaStream] User should not be prompted again after denying
2902         getDisplayMedia request"
2903         https://bugs.webkit.org/show_bug.cgi?id=191227
2904         https://trac.webkit.org/changeset/237784
2905
2906         "[MediaStream] User should not be prompted again after denying
2907         getDisplayMedia request"
2908         https://bugs.webkit.org/show_bug.cgi?id=191227
2909         https://trac.webkit.org/changeset/237788
2910
2911 2018-11-05  Lucas Forschler  <lforschler@apple.com>
2912
2913         https://bugs.webkit.org/show_bug.cgi?id=191268
2914         Remove unused bots.
2915
2916         rubber-stamped by Alexey Proskuryakov.
2917
2918         * BuildSlaveSupport/build.webkit.org-config/config.json:
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2920         (WebKitBuildbot):
2921
2922 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2923
2924         [WPE][GTK] API test runner fails to respect default build type
2925         https://bugs.webkit.org/show_bug.cgi?id=190247
2926
2927         Reviewed by Carlos Garcia Campos.
2928
2929         Problem is it's looking for a release build, even though I've run set-webkit-configuration
2930         --debug. It should look for a debug build unless I explicitly pass --release.
2931
2932         * glib/api_test_runner.py:
2933         (TestRunner.__init__):
2934
2935 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
2936
2937         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
2938         https://bugs.webkit.org/show_bug.cgi?id=190674
2939
2940         Reviewed by Philippe Normand.
2941
2942         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
2943         it can use to implement encoding for different formats exposing a trimmed down unified API.
2944
2945         It also adds proper handling of H264 profiles.
2946
2947         The added files follow GStreamer coding style as we aim at upstreaming the element
2948         in the future.
2949
2950         Reviewed by Philippe Normand.
2951
2952         * Scripts/webkitpy/style/checker.py:
2953
2954 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2955
2956         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
2957         https://bugs.webkit.org/show_bug.cgi?id=191221
2958
2959         Reviewed by Carlos Garcia Campos.
2960
2961         This test ensures that MSE is disabled by default, but we now enable it by default, so
2962         reverse the semantics of the test.
2963
2964         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2965         (testWebKitSettings):
2966
2967 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
2968
2969         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
2970         https://bugs.webkit.org/show_bug.cgi?id=191225
2971
2972         Reviewed by Alejandro G. Castro.
2973
2974         Fix a memory leak causing this test to fail.
2975
2976         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2977         (WebViewTest::initializeWebView):
2978
2979 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
2980
2981         [webkitpy] Support WPE in the run-web-platform-tests script
2982         https://bugs.webkit.org/show_bug.cgi?id=191183
2983
2984         Reviewed by Alex Christensen.
2985
2986         * Scripts/webkitpy/w3c/wpt_runner.py:
2987         (parse_args): Support `--wpe` as an argument that specifies WPE as the
2988         target port. Additionally, the `--display-server` flag now accepts
2989         `headless` as a valid value, enabling the WPE WebDriver to run in
2990         headless mode.
2991
2992 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
2993
2994         [Win] Use C++14, not C++17
2995         https://bugs.webkit.org/show_bug.cgi?id=191101
2996
2997         Reviewed by Alex Christensen.
2998
2999         std::basic_string::data() returns a read-only const buffer in
3000         C++14.
3001
3002         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3003         (createString): Use std::vector instead of std::wstring.
3004         (createUTF8String): Use std::vector instead of std::string.
3005
3006 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3007
3008         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
3009         https://bugs.webkit.org/show_bug.cgi?id=191231
3010
3011         Reviewed by Simon Fraser.
3012
3013         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
3014         it can be shared between iOS-family and macOS platforms. See below for more details.
3015
3016         No change in behavior.
3017
3018         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3019         (WTR::UIScriptController::overridePreference):
3020
3021         Add a method stub for DumpRenderTree.
3022
3023         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3024         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3025         (WTR::UIScriptController::doAsyncTask):
3026         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3027
3028         Unify these method implementations.
3029
3030         (WTR::UIScriptController::removeViewFromWindow):
3031         (WTR::UIScriptController::addViewToWindow):
3032
3033         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
3034         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
3035         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
3036         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
3037
3038         (WTR::UIScriptController::overridePreference):
3039         (WTR::UIScriptController::findString):
3040         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
3041
3042         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
3043
3044         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3045         (WTR::UIScriptController::doAsyncTask): Deleted.
3046         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
3047         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
3048         (WTR::UIScriptController::findString): Deleted.
3049         (WTR::UIScriptController::removeViewFromWindow): Deleted.
3050         (WTR::UIScriptController::addViewToWindow): Deleted.
3051         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3052         (WTR::UIScriptController::doAsyncTask): Deleted.
3053         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
3054         (WTR::UIScriptController::overridePreference): Deleted.
3055         (WTR::UIScriptController::findString): Deleted.
3056         (WTR::UIScriptController::removeViewFromWindow): Deleted.
3057         (WTR::UIScriptController::addViewToWindow): Deleted.
3058         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
3059
3060 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
3061
3062         [MediaStream] User should not be prompted again after denying getDisplayMedia request
3063         https://bugs.webkit.org/show_bug.cgi?id=191227
3064         <rdar://problem/45784512>
3065
3066         Reviewed by Youenn Fablet.
3067
3068         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
3069         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3070         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
3071         (TestWebKitAPI::TEST_F):
3072
3073 2018-11-04  Zalan Bujtas  <zalan@apple.com>
3074
3075         [LFC][BFC] Add support for percentage height in quirks mode.
3076         https://bugs.webkit.org/show_bug.cgi?id=191232
3077
3078         Reviewed by Antti Koivisto.
3079
3080         * LayoutReloaded/misc/LFC-passing-tests.txt:
3081
3082 2018-11-04  Zalan Bujtas  <zalan@apple.com>
3083
3084         [LFC][BCF] Add support for block level non-replaced inflow height percentage
3085         https://bugs.webkit.org/show_bug.cgi?id=191229
3086
3087         Reviewed by Antti Koivisto.
3088
3089         * LayoutReloaded/misc/LFC-passing-tests.txt:
3090
3091 2018-11-02  Zalan Bujtas  <zalan@apple.com>
3092
3093         [LFC][BFC] Resolve percentage height values.
3094         https://bugs.webkit.org/show_bug.cgi?id=191224
3095
3096         Reviewed by Antti Koivisto.
3097
3098         * LayoutReloaded/misc/LFC-passing-tests.txt:
3099
3100 2018-11-03  Alex Christensen  <achristensen@webkit.org>
3101
3102         Mac production builds should sign the network process xpc service with entitlements
3103         https://bugs.webkit.org/show_bug.cgi?id=191209
3104         <rdar://problem/45377609>
3105
3106         Reviewed by Geoff Garen.
3107
3108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3109         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
3110         (TEST):
3111
3112 2018-11-02  Alex Christensen  <achristensen@webkit.org>
3113
3114         Unreviewed, rolling out r237761.
3115
3116         Makes most API tests timeout and WK2 tests crash
3117
3118         Reverted changeset:
3119
3120         "Mac production builds should sign the network process xpc
3121         service with entitlements"
3122         https://bugs.webkit.org/show_bug.cgi?id=191209
3123         https://trac.webkit.org/changeset/237761
3124
3125 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3126
3127         Unreviewed API test gardening
3128
3129         * TestWebKitAPI/glib/TestExpectations.json:
3130
3131 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
3132
3133         Add new global object and preliminary Worklets support for CSS painting api
3134         https://bugs.webkit.org/show_bug.cgi?id=190979
3135
3136         Reviewed by Chris Dumez.
3137
3138         * Scripts/webkitpy/bindings/main.py:
3139         (BindingsTests.generate_supplemental_dependency):
3140         (BindingsTests.main):
3141
3142 2018-11-02  Alex Christensen  <achristensen@webkit.org>
3143
3144         Mac production builds should sign the network process xpc service with entitlements
3145         https://bugs.webkit.org/show_bug.cgi?id=191209
3146         <rdar://problem/45377609>
3147
3148         Reviewed by Geoff Garen.
3149
3150         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3151         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
3152         (TEST):
3153
3154 2018-11-02  Lucas Forschler  <lforschler@apple.com>
3155
3156         Add Windows 10 archive bots
3157         https://bugs.webkit.org/show_bug.cgi?id=190964
3158         
3159         This Change updates the Apple Windows Buildbot configuration.
3160         - Add Windows 10 specific builders and testers for release and debug.
3161         - Refactor Windows -> Windows 7.
3162         - Remove Windows 7 Debug.
3163
3164         Reviewed by Aakash Jain.
3165
3166         * BuildSlaveSupport/build.webkit.org-config/config.json:
3167
3168 2018-11-02  Philippe Normand  <pnormand@igalia.com>
3169
3170         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
3171
3172         Rubber-stamped by Michael Catanzaro.
3173
3174         This variable is useful to get rid of shell color escapes in tests stderr files.
3175
3176         * Scripts/webkitpy/port/gtk.py:
3177         (GtkPort.setup_environ_for_server):
3178         * Scripts/webkitpy/port/wpe.py:
3179         (WPEPort.setup_environ_for_server):
3180
3181 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
3182
3183         Add Basic Django web app for OpenSource EWS
3184         https://bugs.webkit.org/show_bug.cgi?id=191091
3185
3186         Reviewed by Lucas Forschler.
3187
3188         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
3189         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
3190         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
3191         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
3192         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
3193         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
3194         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
3195         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
3196         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
3197         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
3198         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
3199         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
3200         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
3201         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
3202
3203 2018-11-02  Daniel Bates  <dabates@apple.com>
3204
3205         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
3206         https://bugs.webkit.org/show_bug.cgi?id=190487
3207
3208         Reviewed by Tim Horton.
3209
3210         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
3211         match my observations when using the simulator to simulate iOS 12 and add support for testing
3212         right-hand side modifiers.
3213
3214         * DumpRenderTree/mac/EventSendingController.mm:
3215         (modifierFlags):
3216         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3217         (-[EventSendingController setTouchModifier:value:]):
3218         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3219         (hidUsageCodeForCharacter):
3220
3221 2018-11-02  Chris Dumez  <cdumez@apple.com>
3222
3223         [PSON] Reuse SuspendedPages' process when possible, for performance
3224         https://bugs.webkit.org/show_bug.cgi?id=191166
3225
3226         Reviewed by Geoffrey Garen.
3227
3228         Add API test coverage.
3229
3230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3231
3232 2018-11-02  Zalan Bujtas  <zalan@apple.com>
3233
3234         [LFC][IFC] Add support for intrinsic width calculation
3235         https://bugs.webkit.org/show_bug.cgi?id=191144
3236
3237         Reviewed by Antti Koivisto.
3238
3239         * LayoutReloaded/misc/LFC-passing-tests.txt:
3240
3241 2018-11-01  Philippe Normand  <pnormand@igalia.com>
3242
3243         [Apache] Self-signed SSL certificate RSA key is considered too weak
3244         https://bugs.webkit.org/show_bug.cgi?id=191156
3245
3246         Reviewed by Michael Catanzaro.
3247
3248         * Scripts/webkitpy/common/system/pemfile.py:
3249
3250 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
3251
3252         Unreviewed follow-up to r237678.
3253
3254         * wpe/jhbuild.modules: The patch element apparently has to be a child
3255         of the branch in order for Jhbuild to properly detect and apply the
3256         patch file.
3257
3258 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
3259
3260         build-jsc --wincairo should update WinCairo libraries
3261         https://bugs.webkit.org/show_bug.cgi?id=191170
3262
3263         Reviewed by Fujii Hironori.
3264
3265         * Scripts/build-jsc:
3266
3267 2018-11-01  John Wilander  <wilander@apple.com>
3268
3269         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
3270         https://bugs.webkit.org/show_bug.cgi?id=191119
3271         <rdar://problem/44176965>
3272
3273         Reviewed by Chris Dumez.
3274
3275         This is an API test for a WebKitLegacy WebView that is first closed and then
3276         JavaScript is handed a keyboard event.
3277
3278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3279         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
3280         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
3281         (-[KeyboardEventListener handleEvent:]):
3282         (TestWebKitAPI::TEST):
3283
3284 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
3285
3286         Add a storage limit for IndexedDB
3287         https://bugs.webkit.org/show_bug.cgi?id=190598
3288         <rdar://problem/44654715>
3289
3290         Reviewed by Chris Dumez.
3291
3292         Add API for testing.
3293
3294         * DumpRenderTree/TestRunner.cpp:
3295         (setIDBPerOriginQuotaCallback):
3296         (TestRunner::staticFunctions):
3297         * DumpRenderTree/TestRunner.h:
3298         * DumpRenderTree/mac/TestRunnerMac.mm:
3299         (TestRunner::setIDBPerOriginQuota):
3300         * DumpRenderTree/win/TestRunnerWin.cpp:
3301         (TestRunner::setIDBPerOriginQuota):
3302         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3303         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3304         (WTR::TestRunner::setIDBPerOriginQuota):
3305         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3306         * WebKitTestRunner/TestController.cpp:
3307         (WTR::TestController::setIDBPerOriginQuota):
3308         * WebKitTestRunner/TestController.h:
3309         * WebKitTestRunner/TestInvocation.cpp:
3310         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3311
3312 2018-11-01  Chris Dumez  <cdumez@apple.com>
3313
3314         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
3315         https://bugs.webkit.org/show_bug.cgi?id=191076
3316
3317         Reviewed by Geoffrey Garen.
3318
3319         Add API test coverage.
3320
3321         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3322         (-[PSONNavigationDelegate init]):
3323         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3324
3325 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
3326
3327         Fix build with VIDEO and WEB_AUDIO disabled
3328         https://bugs.webkit.org/show_bug.cgi?id=191147
3329         <rdar://problem/45726710>
3330
3331         Unreviewed build fix.
3332
3333         This adds the missing compilation guards in the WPE MiniBrowser.
3334
3335         * MiniBrowser/wpe/main.cpp:
3336         (main): Condition GST includes and calls.
3337
3338 2018-10-31  Zalan Bujtas  <zalan@apple.com>
3339
3340         [LFC][IFC] Add support for inline-block elements.
3341         https://bugs.webkit.org/show_bug.cgi?id=191143
3342
3343         Reviewed by Antti Koivisto.
3344
3345         * LayoutReloaded/misc/LFC-passing-tests.txt:
3346
3347 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
3348
3349         [WPE] Add missing libsoup patch to jhbuild
3350         https://bugs.webkit.org/show_bug.cgi?id=191149
3351
3352         Reviewed by Žan Doberšek.
3353
3354         * wpe/jhbuild.modules:
3355         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
3356
3357 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
3358
3359         Fix build with VIDEO and WEB_AUDIO disabled
3360         https://bugs.webkit.org/show_bug.cgi?id=191147
3361
3362         Reviewed by Philippe Normand.
3363
3364         * MiniBrowser/gtk/main.c:
3365         (main): Condition GST includes and calls
3366
3367 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
3368
3369         Add Justin Michaud to the list of WebKit Committers
3370         https://bugs.webkit.org/show_bug.cgi?id=191142
3371
3372         * Scripts/webkitpy/common/config/contributors.json:
3373
3374 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
3375
3376         Don't run JIT tests on 32-bit platforms
3377         https://bugs.webkit.org/show_bug.cgi?id=191074
3378
3379         Reviewed by Michael Catanzaro.
3380
3381         * Scripts/run-jsc-stress-tests:
3382
3383 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3384
3385         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
3386         https://bugs.webkit.org/show_bug.cgi?id=190530
3387         <rdar://problem/45232149>
3388
3389         Reviewed by Tim Horton.
3390
3391         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
3392         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
3393         is equivalent to the original file wrappers used to insert attachments in the first web view.
3394
3395         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
3396         is still backed by the same NSFileWrapper instance.
3397
3398         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3399         (TestWebKitAPI::TEST):
3400
3401 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3402
3403         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
3404         https://bugs.webkit.org/show_bug.cgi?id=190949
3405
3406         Reviewed by Alex Christensen.
3407
3408         Visual Studio 2017 Community is the alternative.
3409
3410         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
3411         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
3412         (buildVisualStudioProject): Ditto.
3413         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
3414         (usingVisualStudioExpress): Deleted.
3415
3416 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3417
3418         [Win][Direct2D] Support building DumpRenderTree for Direct2D
3419         https://bugs.webkit.org/show_bug.cgi?id=191093
3420         <rdar://problem/45685706>
3421
3422         Unreviewed build fix.
3423
3424         error C2065: 'renderTarget': undeclared identifier
3425
3426         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3427         (createBitmapContextFromWebView): Restored the previous implementation.
3428
3429 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
3430
3431         [PlayStation] Enable JavaScriptCore
3432         https://bugs.webkit.org/show_bug.cgi?id=191072
3433
3434         Reviewed by Brent Fulgham.
3435
3436         Add platform scripts for building the PlayStation port.
3437         perl Tools/Scripts/build-webkit --playstation
3438
3439         * Scripts/build-webkit:
3440         * Scripts/build-webkittestrunner:
3441         * Scripts/webkitdirs.pm:
3442         (argumentsForConfiguration):
3443         (determineConfigurationProductDir):
3444         (isPlayStation): Added.
3445         (getMSBuildPlatformArgument): Added.
3446         (buildVisualStudioProject):
3447         (wrapperPrefixIfNeeded):
3448         (generateBuildSystemFromCMakeProject):
3449         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
3450
3451 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
3452
3453         [Win][Direct2D] Support building DumpRenderTree for Direct2D
3454         https://bugs.webkit.org/show_bug.cgi?id=191093
3455         <rdar://problem/45685706>
3456
3457         Reviewed by Alex Christensen.
3458
3459         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
3460         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
3461         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
3462         (pixelDumpSystemFactory): Added.
3463         (printPNG): Create stub.
3464         (computeMD5HashStringForBitmapContext): Ditto.
3465         (dumpBitmap): Ditto.
3466         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
3467         (BitmapContext::createByAdoptingBitmapAndContext):
3468         (BitmapContext::~BitmapContext):
3469         (BitmapContext::platformContext const):
3470         (BitmapContext::BitmapContext):
3471         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3472         (createBitmapContextFromWebView): Update to support Direct2D.
3473         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
3474         logo is no longer available at this location. Switch to the new logo.
3475
3476 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
3477
3478         webkitpy: Support alternate simctl list outputs
3479         https://bugs.webkit.org/show_bug.cgi?id=191090
3480         <rdar://problem/45684255>
3481
3482         Rubber-stamped by Aakash Jain.
3483
3484         * Scripts/webkitpy/xcode/simulated_device.py:
3485         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
3486         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
3487         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3488         (test_available_devices): Add iOS 12 with alternative availability format.
3489
3490 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
3491
3492         Clean up some obsolete MAX_ALLOWED macros
3493         https://bugs.webkit.org/show_bug.cgi?id=190916
3494
3495         Reviewed by Tim Horton.
3496
3497         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
3498         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3499         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3500
3501 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
3502
3503         [GTK][WPE] Fixes to the PublicSuffix implementation
3504         https://bugs.webkit.org/show_bug.cgi?id=191031
3505
3506         Reviewed by Michael Catanzaro.
3507
3508         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
3509         (TestWebKitAPI::TEST_F): Remove a test for a domain
3510         that is not registrable and shouldn't be tested there.
3511
3512 2018-10-29  Tim Horton  <timothy_horton@apple.com>
3513
3514         Modernize WebKit nibs and lprojs for localization's sake
3515         https://bugs.webkit.org/show_bug.cgi?id=190911
3516         <rdar://problem/45349466>
3517
3518         Reviewed by Dan Bernstein.
3519
3520         * Scripts/check-inspector-strings:
3521         * Scripts/update-webkit-localizable-strings:
3522         * gtk/manifest.txt.in:
3523         * wpe/manifest.txt.in:
3524         English->en
3525
3526 2018-10-29  Daniel Bates  <dabates@apple.com>
3527
3528         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
3529         https://bugs.webkit.org/show_bug.cgi?id=191036
3530
3531         Reviewed by Andy Estes.
3532
3533         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
3534         by an enum that contains two or more enumerators with the same value. For example, suppose
3535         you have the following enum:
3536
3537         enum Flag {
3538             A = 1 << 0,
3539             AAlias = A,
3540         };
3541
3542         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
3543         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
3544         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
3545         tend to be used in bounds checks as opposed to code that adds to a set.
3546
3547         * lldb/lldbWebKitTester/main.cpp:
3548         (testSummaryProviders):
3549         * lldb/lldb_webkit.py:
3550         (WTFOptionSetProvider.update):
3551         * lldb/lldb_webkit_unittest.py:
3552         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
3553         (TestSummaryProviders):
3554         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
3555
3556 2018-10-29  Daniel Bates  <dabates@apple.com>
3557
3558         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
3559         https://bugs.webkit.org/show_bug.cgi?id=191033
3560
3561         Reviewed by Andy Estes.
3562
3563         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
3564         We display the same details in the summary for a Frame because its Document tends to be the most
3565         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
3566         and whether the origin has universal access.
3567
3568         * lldb/lldb_webkit.py:
3569         (__lldb_init_module):
3570         Register new summary providers.
3571
3572         (WebCoreSecurityOrigin_SummaryProvider):
3573         (WebCoreFrame_SummaryProvider):
3574         (WebCoreDocument_SummaryProvider):
3575         Add new summary providers.
3576
3577         (StdOptionalWrapper):
3578         (StdOptionalWrapper.__init__):
3579         (StdOptionalWrapper.has_value):
3580         (StdOptionalWrapper.value):
3581         Convenience data type that provides access to the fields of a std::optional<>.
3582         
3583         (WebCoreSecurityOriginProvider):
3584         (WebCoreSecurityOriginProvider.__init__):
3585         (WebCoreSecurityOriginProvider.is_unique):
3586         (WebCoreSecurityOriginProvider.scheme):
3587         (WebCoreSecurityOriginProvider.host):
3588         (WebCoreSecurityOriginProvider.port):
3589         (WebCoreSecurityOriginProvider.domain):
3590         (WebCoreSecurityOriginProvider.has_universal_access):
3591         (WebCoreSecurityOriginProvider.to_string):
3592         (WebCoreFrameProvider):
3593         (WebCoreFrameProvider.__init__):
3594         (WebCoreFrameProvider.is_main_frame):
3595         (WebCoreFrameProvider.document):
3596         (WebCoreDocumentProvider):
3597         (WebCoreDocumentProvider.__init__):
3598         (WebCoreDocumentProvider.url):
3599         (WebCoreDocumentProvider.origin):
3600         (WebCoreDocumentProvider.page_cache_state):
3601         (WebCoreDocumentProvider.frame):
3602
3603 2018-10-29  Chris Dumez  <cdumez@apple.com>
3604
3605         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
3606         https://bugs.webkit.org/show_bug.cgi?id=190975
3607         <rdar://problem/45059256>
3608
3609         Reviewed by Antti Koivisto.
3610
3611         Add API test coverage.
3612
3613         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3614
3615 2018-10-29  Zalan Bujtas  <zalan@apple.com>
3616
3617         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
3618         https://bugs.webkit.org/show_bug.cgi?id=191018
3619
3620         Reviewed by Antti Koivisto.
3621
3622         * LayoutReloaded/misc/LFC-passing-tests.txt:
3623
3624 2018-10-29  Zalan Bujtas  <zalan@apple.com>
3625
3626         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
3627         https://bugs.webkit.org/show_bug.cgi?id=191011
3628