REGRESSION(r263625): [WPE][GTK] MiniBrowser output no longer includes stderr and...
[WebKit-https.git] / Tools / ChangeLog
1 2020-06-29  Philippe Normand  <pnormand@igalia.com>
2
3         REGRESSION(r263625): [WPE][GTK] MiniBrowser output no longer includes stderr and stdout
4         https://bugs.webkit.org/show_bug.cgi?id=213696
5
6         Reviewed by Žan Doberšek.
7
8         This patch adds a new optional argument to Executive.run_command() to control stdout output.
9         By default the subprocess.PIPE value is used, to keep backward compatibility. Set the stdout
10         argument to None to display the output on the terminal tty.
11
12         The GTK and WPE run_minibrowser() implementations now use this new argument, along with
13         setting return_stderr to False to indicate we also want stderr displayed on the terminal
14         tty.
15
16         * Scripts/webkitpy/common/system/abstractexecutive.py:
17         (AbstractExecutive.run_command):
18         * Scripts/webkitpy/common/system/executive.py:
19         (Executive.run_command):
20         * Scripts/webkitpy/common/system/executive_mock.py:
21         (MockExecutive.run_command):
22         * Scripts/webkitpy/port/gtk.py:
23         (GtkPort.run_minibrowser):
24         * Scripts/webkitpy/port/wpe.py:
25         (WPEPort.run_minibrowser):
26
27 2020-06-29  Philippe Normand  <pnormand@igalia.com>
28
29         REGRESSION(r263625): run-minibrowser --debug/--release options gone
30         https://bugs.webkit.org/show_bug.cgi?id=213697
31
32         Reviewed by Žan Doberšek.
33
34         * Scripts/webkitpy/minibrowser/run_webkit_app.py:
35         (main): Explicitely skip the --target option. Previous code was also skipping --release and
36         --debug options because their `dest` is the same as with the --target option.
37
38 2020-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
39
40         [GTK][WPE] Add webkit_authentication_request_get_security_origin
41         https://bugs.webkit.org/show_bug.cgi?id=213596
42
43         Reviewed by Michael Catanzaro.
44
45         Update the unit tests to check the new API.
46
47         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
48         (testWebViewAuthenticationRequest):
49         (testWebViewAuthenticationProxy):
50         (testWebViewAuthenticationProxyHTTPS):
51
52 2020-06-28  Geoffrey Garen  <ggaren@apple.com>
53
54         Rename initializeThreading to initialize
55         https://bugs.webkit.org/show_bug.cgi?id=213674
56
57         Reviewed by Mark Lam.
58
59         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
60         (ApplicationManifestParserTest::SetUp):
61         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
62         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
63         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
64         (TestWebKitAPI::ContentExtensionTest::SetUp):
65         * TestWebKitAPI/Tests/WebCore/StringUtilities.mm:
66         (TestWebKitAPI::TEST):
67         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
68         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
69         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
70         (WebKitTestServer::WebKitTestServer):
71         * WebKitTestRunner/TestController.cpp:
72         (WTR::TestController::initialize):
73
74 2020-06-27  Daniel Bates  <dabates@apple.com>
75
76         Revert r262654 because it caused <rdar://problem/64664156>.
77         Moreover it is no longer necessary as the embedding client
78         changes selection through a different SPI after focusing.
79
80         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
81         (TestWebKitAPI::TEST):
82
83 2020-06-27  Keith Miller  <keith_miller@apple.com>
84
85         compare-results should be able to parse multiple JSONs at once by merging them
86         https://bugs.webkit.org/show_bug.cgi?id=213685
87
88         Reviewed by Saam Barati.
89
90         This patch improves the compare-results script to enable it to
91         merge JSON output files. This is handy when running scripts by
92         hand where you'll get many a and b JSONs.  To do the merging this
93         patch moves the logic of merge-result-jsons into a shared library.
94
95         compare-results can take multiple files sequentally or by passing
96         the '-a'/'-b' flags multiple times. e.g. `/compare-results -a
97         OG-1.json -a OG-2.json -a OG-3.json -a OG-4.json -b MC-1.json
98         MC-2.json MC-3.json MC-4.json` will behave as you'd expect;
99         combining all the OG JSONs and the MC JSONs before computing the
100         result.
101
102         Lastly, the benchmark_results script now can handle duplicates of
103         an aggregator in the aggregator list. This is useful because
104         otherwise the logic of merging JSONs is significantly more
105         complicated.
106
107         * Scripts/compare-results:
108         (getOptions):
109         (main):
110         * Scripts/merge-result-jsons:
111         (readJSONFile):
112         (deepAppend): Deleted.
113         (mergeJSONs): Deleted.
114         * Scripts/webkitpy/benchmark_runner/benchmark_json_merge.py: Copied from Tools/Scripts/merge-result-jsons.
115         (deepAppend):
116         (mergeJSONs):
117         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
118         (BenchmarkResults._aggregate_results_for_test):
119         (BenchmarkResults._lint_subtest_results):
120         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
121
122 2020-06-27  Jer Noble  <jer.noble@apple.com>
123
124         iOS Safari incorrectly reports "AppleCoreMedia" as UA string
125         https://bugs.webkit.org/show_bug.cgi?id=213245
126         <rdar://problem/64471582>
127
128         Reviewed by Youenn Fablet.
129
130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
131         * TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm: Added.
132         (TestWebKitAPI::parseUserAgent):
133         (TestWebKitAPI::TEST):
134
135 2020-06-27  Philippe Normand  <pnormand@igalia.com>
136
137         Migrate run-minibrowser to webkitpy
138         https://bugs.webkit.org/show_bug.cgi?id=213431
139
140         Reviewed by Jonathan Bedard.
141
142         The perl version was renamed to old-run-minibrowser and remains used by the Mac ports.
143         run-minibrowser is now a Python script hooking into webkitpy and the Port infrastructure.
144         Both WPE and GTK ports will now use the pure python implementation.
145
146         * Scripts/old-run-minibrowser: Copied from Tools/Scripts/run-minibrowser.
147         * Scripts/run-minibrowser:
148         * Scripts/webkitpy/minibrowser/run_minibrowser.py: Added.
149         (main):
150         (parse_args):
151         * Scripts/webkitpy/port/base.py:
152         (Port.run_minibrowser_arguments):
153         (Port):
154         (Port.run_minibrowser):
155         * Scripts/webkitpy/port/darwin.py:
156         (DarwinPort.environment_for_api_tests):
157         (DarwinPort):
158         (DarwinPort.run_minibrowser_arguments):
159         * Scripts/webkitpy/port/gtk.py:
160         (GtkPort.show_results_html_file):
161         (GtkPort.configuration_for_upload):
162         (GtkPort):
163         (GtkPort.run_minibrowser):
164         * Scripts/webkitpy/port/wpe.py:
165         (WPEPort.show_results_html_file):
166         (WPEPort.configuration_for_upload):
167         (WPEPort):
168         (WPEPort.run_minibrowser):
169
170 2020-06-27  Stephan Szabo  <stephan.szabo@sony.com>
171
172         [PlayStation] Update test runner for changes to Options and signing
173         https://bugs.webkit.org/show_bug.cgi?id=213650
174
175         Reviewed by Don Olmstead.
176
177         * Scripts/webkitdirs.pm: Update extension for PlayStation binary
178
179 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
180
181         [webkitpy] Allow callers to override the reported model (Part 1)
182         https://bugs.webkit.org/show_bug.cgi?id=213677
183         <rdar://problem/64834043>
184
185         Reviewed by Dewei Zhu.
186
187         * Scripts/webkitpy/port/base.py:
188         (Port.configuration_for_upload): Set the model based on --model.
189         * Scripts/webkitpy/port/factory.py:
190         (configuration_options): Add --model option, drive-by fix for --architecture.
191         * Scripts/webkitpy/port/mac.py:
192         (MacPort.configuration_for_upload): --model overrides detected model.
193
194 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
195
196         [webkitpy] Automatically detect hw architecture for supporting Apple Silicon
197         https://bugs.webkit.org/show_bug.cgi?id=213653
198         <rdar://problem/64817656>
199
200         Rubber-stamped by Aakash Jain.
201
202         * Scripts/webkitpy/common/config/ews.json: iOS has the correct defaults, no need to override them.
203         * Scripts/webkitpy/common/system/platforminfo.py:
204         (PlatformInfo):
205         (PlatformInfo.architecture): Retrieve the current system's architecture.
206         * Scripts/webkitpy/common/system/platforminfo_mock.py:
207         (MockPlatformInfo.__init__):
208         (MockPlatformInfo.architecture):
209         * Scripts/webkitpy/port/base.py:
210         (Port.__init__): Remove 'did_override_architecture', should be implied by architecture compared with DEFAULT_ARCHITECTURE.
211         (Port.architecture): Return the architecture specified by the user, if it exists.
212         (Port.set_architecture): Remove 'did_override_architecture'.
213         * Scripts/webkitpy/port/factory.py:
214         (configuration_options): Add --arm and --architecture flags.
215         * Scripts/webkitpy/port/mac.py:
216         (MacPort): Add arm64 to supported architectures.
217         (MacPort.architecture): Convert arm64e to arm64, check the host's architecture.
218         (MacPort._build_driver_flags): Always specify the build architecture since it may be x86_64 or arm64.
219         * Scripts/webkitpy/port/mac_unittest.py:
220         (MacTest.test_64bit):
221         (MacTest):
222         (MacTest.test_arm):
223         (MacTest.test_default):
224         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
225         (AbstractEarlyWarningSystem.run_command): Remove did_override_architecture.
226
227 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
228
229         [Big Sur] Handle baseline search path (Follow-up fix)
230         https://bugs.webkit.org/show_bug.cgi?id=213639
231         <rdar://problem/64789480>
232
233         Unreviewed follow-up fix.
234
235         * Scripts/webkitpy/port/mac.py:
236         (MacPort.default_baseline_search_path): Copy reference version by value, not by reference.
237
238 2020-06-26  Geoffrey Garen  <ggaren@apple.com>
239
240         Initializing the main thread should initialize the main run loop
241         https://bugs.webkit.org/show_bug.cgi?id=213637
242
243         Reviewed by Anders Carlsson.
244
245         Updated TestWebKitAPI to stop using RunLoop::initializeMain directly.
246
247         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
248         (TestWebKitAPI::TEST):
249         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
250         (TestWebKitAPI::TEST):
251         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
252         (TestWebKitAPI::TEST):
253         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
254         (ApplicationManifestParserTest::SetUp):
255         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
256         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
257         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
258         (TestWebKitAPI::ContentExtensionTest::SetUp):
259         * TestWebKitAPI/Tests/WebCore/DNS.cpp:
260         (TestWebKitAPI::TEST):
261         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
262         (TestWebKitAPI::TEST_F):
263         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
264         (initializeInAppBrowserPrivacyTestSettings):
265         * TestWebKitAPI/TestsController.cpp:
266         (TestWebKitAPI::TestsController::TestsController):
267         * WebKitTestRunner/TestController.cpp:
268         (TestController::initialize):
269
270 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
271
272         run-javascriptcore-tests: Support Apple Silicon running x86 processes
273         https://bugs.webkit.org/show_bug.cgi?id=213487
274         <rdar://problem/64606667>
275
276         Reviewed by Saam Barati.
277
278         * Scripts/run-javascriptcore-tests:
279         (configurationForUpload): Add --architecture flag.
280         (runTest): Run test suite with specific architecture.
281         (runJSCStressTests): Pass architecture to run-jsc-stress-tests.
282         * Scripts/run-jsc-stress-tests: Add --force-architecture flag.
283         * Scripts/webkitdirs.pm:
284         (determineNativeArchitecture): Add function to determine machine's native architecture.
285         (determineArchitecture): Leverage the nativeArchitecture instead of hard-coding simulator
286         architectures.
287         (architecturesForProducts): Determine the architectures supported by a given build.
288         (nativeArchitecture): Return nativeArchitecture.
289
290 2020-06-26  Sihui Liu  <sihui_liu@apple.com>
291
292         Text manipulation should observe adjacent elements with new renderer together
293         https://bugs.webkit.org/show_bug.cgi?id=213333
294
295         Reviewed by Geoffrey Garen.
296
297         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
298         (TestWebKitAPI::TEST):
299
300 2020-06-26  Jonathan Bedard  <jbedard@apple.com>
301
302         [Big Sur] Handle baseline search path
303         https://bugs.webkit.org/show_bug.cgi?id=213639
304         <rdar://problem/64789480>
305
306         Rubber-stamped by Aakash Jain.
307
308         * Scripts/webkitpy/port/mac.py:
309         (MacPort):
310         (MacPort.default_baseline_search_path): Break infinite loop for major version bump.
311         * Scripts/webkitpy/port/mac_unittest.py:
312         (MacTest.test_big_sur_baseline_search_path): Test Big Sur baseline search path.
313
314 2020-06-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
315
316         generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
317         https://bugs.webkit.org/show_bug.cgi?id=213615
318
319         Reviewed by Žan Doberšek.
320
321         Raise an exception if the parameter passed as remote-config-file is not a file.
322
323         * Scripts/generate-jsc-bundle:
324         (main):
325
326 2020-06-26  Takashi Komori  <takashi.komori@sony.com>
327
328         Add myself to contributors.json
329
330         Unreviewed.
331
332         * Scripts/webkitpy/common/config/contributors.json:
333
334 2020-06-25  Ryan Haddad  <ryanhaddad@apple.com>
335
336         [Big Sur] Regression tests fail to run due to failed assert: self._os_version.major == 10
337         https://bugs.webkit.org/show_bug.cgi?id=213639
338
339         Reviewed by Jonathan Bedard.
340
341         * Scripts/webkitpy/port/mac.py:
342         (MacPort.__init__): Remove the assert since it is no longer valid.
343
344 2020-06-25  Commit Queue  <commit-queue@webkit.org>
345
346         Unreviewed, reverting r263537.
347         https://bugs.webkit.org/show_bug.cgi?id=213640
348
349         Broke watchOS and tvOS builds
350
351         Reverted changeset:
352
353         "iOS Safari incorrectly reports "AppleCoreMedia" as UA string"
354         https://bugs.webkit.org/show_bug.cgi?id=213245
355         https://trac.webkit.org/changeset/263537
356
357 2020-06-25  Alex Christensen  <achristensen@webkit.org>
358
359         REGRESSION(r256166, r260596) WKNavigationAction.request.allHTTPHeaderFields needs to contain User-Agent and Accept
360         https://bugs.webkit.org/show_bug.cgi?id=213626
361         <rdar://problem/62374208>
362
363         Reviewed by Darin Adler.
364
365         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
366         (TEST):
367
368 2020-06-25  Jer Noble  <jer.noble@apple.com>
369
370         iOS Safari incorrectly reports "AppleCoreMedia" as UA string
371         https://bugs.webkit.org/show_bug.cgi?id=213245
372         <rdar://problem/64471582>
373
374         Reviewed by Youenn Fablet.
375
376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
377         * TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm: Added.
378         (TestWebKitAPI::parseUserAgent):
379         (TestWebKitAPI::TEST):
380
381 2020-06-25  Daniel Bates  <dabates@apple.com>
382
383         [iOS] -_requestTextInputContextsInRect cannot find empty Quip spreadsheet title
384         https://bugs.webkit.org/show_bug.cgi?id=213564
385         <rdar://problem/59355847>
386
387         Reviewed by Simon Fraser.
388
389         Add some tests.
390
391         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
392         (TestWebKitAPI::TEST):
393
394 2020-06-25  Sam Weinig  <weinig@apple.com>
395
396         Add a new templated string type to help write more idiomatic parsing code
397         https://bugs.webkit.org/show_bug.cgi?id=213588
398
399         Reviewed by Darin Adler.
400
401         * TestWebKitAPI/CMakeLists.txt:
402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
403         * TestWebKitAPI/Tests/WTF/StringParsingBuffer.cpp: Added.
404         (TestWebKitAPI::TEST):
405         Added new tests for new class.
406
407 2020-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
408
409         Text manipulation should exclude text rendered using icon-only fonts
410         https://bugs.webkit.org/show_bug.cgi?id=213446
411         <rdar://problem/63734298>
412
413         Reviewed by Myles Maxfield.
414
415         Add a new API test.
416
417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
418         * TestWebKitAPI/Tests/WebKitCocoa/Ahem.ttf: Added.
419         * TestWebKitAPI/Tests/WebKitCocoa/SpaceOnly.otf: Added.
420         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
421         (TestWebKitAPI::TEST):
422
423 2020-06-25  Aakash Jain  <aakash_jain@apple.com>
424
425         [ews] Share more bots between EWS builder and testers
426         https://bugs.webkit.org/show_bug.cgi?id=213521
427
428         Reviewed by Jonathan Bedard.
429
430         * BuildSlaveSupport/ews-build/config.json:
431
432 2020-06-25  Aakash Jain  <aakash_jain@apple.com>
433
434         [ews] Improve handling of invalid changelog
435         https://bugs.webkit.org/show_bug.cgi?id=213609
436
437         Reviewed by Jonathan Bedard.
438
439         * Scripts/webkitpy/tool/steps/validatereviewer.py:
440         (ValidateReviewer.run):
441
442 2020-06-24  Alexey Proskuryakov  <ap@apple.com>
443
444         macOS Big Sur build fix.
445
446         Remove long obsolete checks for Mac OS X 10.6 that didn't respect the major version.
447
448         * MiniBrowser/Makefile:
449         * TestWebKitAPI/Makefile:
450         * WebKitTestRunner/Makefile:
451
452 2020-06-24  Alex Christensen  <achristensen@webkit.org>
453
454         REGRESSION(r262341) Use UTF-8 to decode CFURLRefs from IPC
455         https://bugs.webkit.org/show_bug.cgi?id=213565
456         <rdar://problem/64408924>
457
458         Reviewed by Darin Adler.
459
460         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
461         (TestWebKitAPI::TEST):
462
463 2020-06-24  Umar Iqbal  <uiqbal@apple.com>
464
465         We should resurrect the older patch that collects some statistics of web API calls
466         https://bugs.webkit.org/show_bug.cgi?id=213319
467
468         Reviewed by Brent Fulgham.
469         
470         + Enabled ENABLE_WEB_API_STATISTICS flag.
471         
472         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
473
474 2020-06-24  Andy Estes  <aestes@apple.com>
475
476         [iOS] Open element actions sometimes result in a hover instead of a click
477         https://bugs.webkit.org/show_bug.cgi?id=213530
478         <rdar://problem/64176707>
479
480         Reviewed by Darin Adler.
481
482         Added an API test.
483
484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
485         * TestWebKitAPI/Tests/ios/ElementActionTests.mm: Added.
486         * TestWebKitAPI/Tests/ios/link-with-hover-menu.html: Added.
487
488 2020-06-24  Caitlin Potter  <caitp@igalia.com>
489
490         [JSC] add microbenchmark for op_get_private_name
491         https://bugs.webkit.org/show_bug.cgi?id=213544
492
493         Reviewed by Yusuke Suzuki.
494
495         Add machinery to add --usePrivateClassFields flag in a family of
496         microbenchmarks.
497  
498         * Scripts/run-jsc-benchmarks:
499
500 2020-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
501
502         [GTK][WPE] Add API to allow applications to handle the HTTP authentication credential storage
503         https://bugs.webkit.org/show_bug.cgi?id=213177
504
505         Reviewed by Michael Catanzaro.
506
507         Update the authentication tests to check the new API.
508
509         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
510         (testWebViewAuthenticationCancel):
511         (testWebViewAuthenticationLoadCancelled):
512         (testWebViewAuthenticationFailure):
513         (testWebViewAuthenticationNoCredential):
514         (testWebViewAuthenticationEphemeral):
515         (testWebViewAuthenticationStorage):
516         (testWebViewAuthenticationSuccess):
517         (testWebViewAuthenticationEmptyRealm):
518         (serverCallback):
519         (beforeAll):
520
521 2020-06-23  Alex Christensen  <achristensen@webkit.org>
522
523         Make HTTP/3 experimental feature work on iOS and only create storage directory if enabled
524         https://bugs.webkit.org/show_bug.cgi?id=213527
525
526         Reviewed by Geoffrey Garen.
527
528         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
529         (TEST):
530
531 2020-06-23  Jonathan Bedard  <jbedard@apple.com>
532
533         [Big Sur] Add 11.0 version to scripts
534         https://bugs.webkit.org/show_bug.cgi?id=213532
535         <rdar://problem/64663032>
536
537         Reviewed by Tim Horton.
538
539         * Scripts/run-javascriptcore-tests:
540         (configurationForUpload): Make version checks more explicit, add Big Sur.
541         * Scripts/webkitpy/common/version_name_map.py:
542         (VersionNameMap.__init__): Add Big Sur.
543         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
544         (TestExpectationParser): Ditto.
545
546 2020-06-23  Wenson Hsieh  <wenson_hsieh@apple.com>
547
548         REGRESSION (r244633): Mail flashes when copying text in an email
549         https://bugs.webkit.org/show_bug.cgi?id=213529
550         <rdar://problem/55025522>
551
552         Reviewed by Tim Horton.
553
554         Add an API test to verify that temporarily changing the height of the document before restoring it to the
555         original value does not cause intrinsic content size to be invalidated.
556
557         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
558         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
559         (-[AutoLayoutWKWebView setInvalidatedIntrinsicContentSizeBlock:]):
560         (-[AutoLayoutWKWebView invalidatedIntrinsicContentSizeBlock]):
561
562 2020-06-23  Diego Pino Garcia  <dpino@igalia.com>
563
564         [ews] Allow archiving 'jsc' product
565         https://bugs.webkit.org/show_bug.cgi?id=213518
566
567         Reviewed by Aakash Jain.
568
569         * BuildSlaveSupport/built-product-archive:
570         (archiveBuiltProduct):
571
572 2020-06-23  Alex Christensen  <achristensen@webkit.org>
573
574         Expose already-available WKNavigationAction.request.HTTPBody through the API
575         https://bugs.webkit.org/show_bug.cgi?id=179077
576
577         Reviewed by Brady Eidson.
578
579         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
580         (TEST):
581
582 2020-06-23  Alicia Boya García  <aboya@igalia.com>
583
584         [GStreamer] Add GStreamer patch to fix EWS glupload racy crash
585         https://bugs.webkit.org/show_bug.cgi?id=210498
586
587         Reviewed by Philippe Normand.
588
589         This WebKit patch backports a patch from GStreamer 1.17 that prevents
590         the crashes in the attached bug to our flatpak build.
591
592         * buildstream/elements/sdk/gst-plugins-base.bst:
593         * buildstream/patches/gst-plugins-base-0003-glbasefilter-add-support-for-changing-the-display.patch: Added.
594
595 2020-06-23  Alicia Boya García  <aboya@igalia.com>
596
597         [flatpak] Ensure en_US.UTF-8 locale
598         https://bugs.webkit.org/show_bug.cgi?id=212459
599
600         Reviewed by Philippe Normand.
601
602         When developing WebKit we want as few system differences as possible
603         to make tests reproducible.
604
605         en_US.UTF-8 is indeed the only locale installed in our development
606         flatpak, but our scripts were not correctly clearing most locale
607         environment variables, which resulted in warnings when running some
608         tools (notably perl) when the user OS has a different locale.
609
610         This patch ensures all locale environment variables are cleared and
611         LANG is set to en_US.UTF-8. It also removes now redundant code from
612         flatpakutils.py.
613
614         * flatpak/flatpakutils.py:
615         (WebkitFlatpak.run_in_sandbox):
616         * flatpak/webkit-bwrap:
617
618 2020-06-23  Simon Fraser  <simon.fraser@apple.com>
619
620         [ Catalina Debug WK2 ] fast/events/platform-wheelevent-in-scrolling-div.html is a flaky failure
621         https://bugs.webkit.org/show_bug.cgi?id=213351
622         <rdar://problem/64502429>
623
624         Reviewed by Tim Horton.
625
626         The variadic CGEventCreateScrollWheelEvent() seems to have an issue that causes the resulting event
627         to rarely put the x value into the deltaY. Change to the non-variadic CGEventCreateScrollWheelEvent2()
628         to avoid this.
629
630         * DumpRenderTree/mac/EventSendingController.mm:
631         (-[EventSendingController mouseScrollByX:andY:continuously:]):
632         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
633         * WebKitTestRunner/mac/EventSenderProxy.mm:
634         (WTR::EventSenderProxy::mouseScrollBy):
635         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
636
637 2020-06-23  Diego Pino Garcia  <dpino@igalia.com>
638
639         [ews] Rename 'JSCTestsFactory' to 'JSCBuildAndTestsFactory'
640         https://bugs.webkit.org/show_bug.cgi?id=213503
641
642         Reviewed by Aakash Jain.
643
644         * BuildSlaveSupport/ews-build/config.json:
645         * BuildSlaveSupport/ews-build/factories.py:
646         (JSCBuildAndTestsFactory):
647         (JSCTestsFactory): Deleted.
648         (JSCTestsFactory.__init__): Deleted.
649         * BuildSlaveSupport/ews-build/loadConfig.py:
650
651 2020-06-23  Aakash Jain  <aakash_jain@apple.com>
652
653         [ews] Add JSC-Only builders for MIPS and ARMv7 architectures (follow-up fix)
654         https://bugs.webkit.org/show_bug.cgi?id=213366
655
656         Unreviewed follow-up fix.
657
658         Remove unused runTests parameter.
659         * BuildSlaveSupport/ews-build/factories.py:
660
661 2020-06-23  Philippe Normand  <pnormand@igalia.com>
662
663         [Flatpak SDK] relax restriction on build-webkit script name
664         https://bugs.webkit.org/show_bug.cgi?id=213432
665
666         Reviewed by Žan Doberšek.
667
668         * flatpak/flatpakutils.py:
669         (WebkitFlatpak.run_in_sandbox): Match the build-webkit string in the whole command-line
670         argument and thus allow alternative implementations of build-webkit. Also let the
671         MAX_CPU_LOAD env var in the sandbox.
672
673 2020-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
674
675         [GTK] MiniBrowser: set a base directory for website data and cache
676         https://bugs.webkit.org/show_bug.cgi?id=213368
677
678         Reviewed by Michael Catanzaro.
679
680         Stop using the default ones.
681
682         * MiniBrowser/gtk/main.c:
683         (activate):
684
685 2020-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
686
687         [GTK][WPE] Add API to configure and handle DOM cache to WebKitWebsiteDataManager
688         https://bugs.webkit.org/show_bug.cgi?id=213337
689
690         Reviewed by Adrian Perez de Castro.
691
692         Handle new website data in MiniBrowser and add a unit test.
693
694         * MiniBrowser/gtk/main.c:
695         (gotWebsiteDataCallback):
696         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
697         (testWebsiteDataConfiguration):
698         (testWebsiteDataDOMCache):
699         (beforeAll):
700         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
701         (Test::Test):
702
703 2020-06-22  Diego Pino Garcia  <dpino@igalia.com>
704
705         [ews] Add JSC-Only builders for MIPS and ARMv7 architectures
706         https://bugs.webkit.org/show_bug.cgi?id=213366
707
708         Reviewed by Aakash Jain.
709
710         In a follow-up patch the built product of these bots will be consumed
711         by the EWS JSC-Only testing bots.
712
713         * BuildSlaveSupport/ews-build/config.json:
714         * BuildSlaveSupport/ews-build/factories.py:
715         (JSCBuildFactory):
716         (JSCBuildFactory.__init__):
717         * BuildSlaveSupport/ews-build/factories_unittest.py:
718         (TestBuildFactory):
719         (TestBuildFactory.test_jsc_mipsel_factory):
720         (TestBuildFactory.test_jsc_armv7_factory):
721         * BuildSlaveSupport/ews-build/loadConfig.py:
722
723 2020-06-22  Fujii Hironori  <Hironori.Fujii@sony.com>
724
725         [Win] fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html is failing
726         https://bugs.webkit.org/show_bug.cgi?id=213452
727
728         Reviewed by Yusuke Suzuki.
729
730         If window.alert() was given an invalid UTF-16 sequence, Windows
731         DumpRenderTree output it without any conversions. It should output
732         "(null)" to match with WebKitTestRunner behavior.
733
734         * DumpRenderTree/win/UIDelegate.cpp:
735         (toMessage): Added
736         (UIDelegate::runJavaScriptAlertPanelWithMessage):
737         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
738         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
739         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
740         (UIDelegate::setStatusText):
741
742 2020-06-22  Jer Noble  <jer.noble@apple.com>
743
744         [ macOS iOS ] (r263321): TestWebKitAPI.SleepDisabler.Load & TestWebKitAPI.SleepDisabler.Reload are constant failures
745         https://bugs.webkit.org/show_bug.cgi?id=213475
746         <rdar://problem/64603555>
747
748         Reviewed by Eric Carlson.
749
750         Looks like the SleepDisabler can come and go while the TestWebKitAPI process is spinning, so make the
751         Reload and Load tests more deterministic by only checking SleepDisabler after getting a "playing" message
752         from the WebContent process.
753
754         * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
755         (SleepDisabler::runAndWaitUntilPlaying):
756         (SleepDisabler::loadPlayingPage):
757         (TEST_F):
758
759 2020-06-22  Jonathan Bedard  <jbedard@apple.com>
760
761         resultsdbpy: Make architecture differences explicit
762         https://bugs.webkit.org/show_bug.cgi?id=213473
763         <rdar://problem/64602736>
764
765         Rubber-stamped by Aakash Jain.
766
767         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
768         (Configuration.prototype.toString):
769
770 2020-06-22  Tim Horton  <timothy_horton@apple.com>
771
772         Update macOS version macros
773         https://bugs.webkit.org/show_bug.cgi?id=213484
774
775         Reviewed by Alexey Proskuryakov.
776
777         * ContentExtensionTester/Configurations/Base.xcconfig:
778         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
779         * DumpRenderTree/mac/Configurations/Base.xcconfig:
780         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
781         * ImageDiff/cg/Configurations/Base.xcconfig:
782         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
783         * MiniBrowser/Configurations/Base.xcconfig:
784         * MiniBrowser/Configurations/DebugRelease.xcconfig:
785         * TestWebKitAPI/Configurations/Base.xcconfig:
786         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
787         * WebEditingTester/Configurations/Base.xcconfig:
788         * WebEditingTester/Configurations/DebugRelease.xcconfig:
789         * WebKitTestRunner/Configurations/Base.xcconfig:
790         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
791         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
792         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
793
794 2020-06-22  Tim Horton  <timothy_horton@apple.com>
795
796         API Test WeakLinking.WeakImport fails on arm64
797         https://bugs.webkit.org/show_bug.cgi?id=213477
798
799         Reviewed by Alexey Proskuryakov.
800
801         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:
802         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd:
803         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd:
804         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd:
805         Add this architecture to the TBD files.
806
807 2020-06-22  Jonathan Bedard  <jbedard@apple.com>
808
809         Bring up watchOS/tvOS on build.webkit.org (Follow-up fix x3)
810         https://bugs.webkit.org/show_bug.cgi?id=213402
811         <rdar://problem/64542588>
812
813         Reviewed by Alexey Proskuryakov.
814
815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
816         (WebKitBuildbot): 64 bit is more correct for watchOS embedded builds.
817
818 2020-06-22  Aakash Jain  <aakash_jain@apple.com>
819
820         [ews] Switch contributors.json url from trac to svn server
821         https://bugs.webkit.org/show_bug.cgi?id=213457
822
823         Reviewed by Jonathan Bedard.
824
825         * BuildSlaveSupport/ews-build/steps.py:
826         (ValidateCommiterAndReviewer):
827         (ValidateCommiterAndReviewer.load_contributors_from_trac):
828
829 2020-06-22  Philippe Normand  <pnormand@igalia.com>
830
831         [Flatpak SDK] Persist sccache auth token across flatpak updates
832         https://bugs.webkit.org/show_bug.cgi?id=213427
833
834         Reviewed by Žan Doberšek.
835
836         After a successful flatpak update check if an sccache auth token exists and reuse it when
837         updating the sccache config file.
838
839         * flatpak/flatpakutils.py:
840         (WebkitFlatpak.save_config):
841
842 2020-06-21  Yusuke Suzuki  <ysuzuki@apple.com>
843
844         [WTF] URL should support dataLog
845         https://bugs.webkit.org/show_bug.cgi?id=213450
846
847         Reviewed by Mark Lam.
848
849         Add test for URL::dump.
850
851         * TestWebKitAPI/Tests/WTF/URL.cpp:
852         (TestWebKitAPI::TEST_F):
853
854 2020-06-21  Philippe Normand  <pnormand@igalia.com>
855
856         [Flatpak] Nightly runner fails to extract zip files
857         https://bugs.webkit.org/show_bug.cgi?id=213445
858
859         Reviewed by Darin Adler.
860
861         * Scripts/webkit-flatpak-run-nightly: Ensure the buffered zip data is written to disk before
862         extraction.
863
864 2020-06-21  Jer Noble  <jer.noble@apple.com>
865
866         WebKit fails to leave audio routing arbitration during navigation, closing.
867         https://bugs.webkit.org/show_bug.cgi?id=213426
868         <rdar://problem/64395051>
869
870         Reviewed by Eric Carlson.
871
872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
873         * TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: Added.
874         (AudioRoutingArbitration::statusShouldBecomeEqualTo):
875         (TEST_F):
876
877 2020-06-20  Jer Noble  <jer.noble@apple.com>
878
879         REGRESSION(r259219): Sleep assertion remains active if WKWebView is closed or WebContent process crashes
880         https://bugs.webkit.org/show_bug.cgi?id=213434
881         <rdar://problem/57541662>
882
883         Reviewed by Eric Carlson.
884
885         * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
886         (SleepDisabler::loadPlayingPage):
887         (SleepDisabler::hasSleepDisablerShouldBecomeEqualTo):
888         (TEST_F):
889
890 2020-06-20  Jonathan Bedard  <jbedard@apple.com>
891
892         Bring up watchOS/tvOS on build.webkit.org (Follow-up fix x2)
893         https://bugs.webkit.org/show_bug.cgi?id=213402
894         <rdar://problem/64542588>
895
896         Unreviewed test fix.
897
898         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Native Macs never
899         use 32 bit tool binaries.
900
901 2020-06-19  Jonathan Bedard  <jbedard@apple.com>
902
903         Bring up watchOS/tvOS on build.webkit.org (Follow-up fix)
904         https://bugs.webkit.org/show_bug.cgi?id=213402
905         <rdar://problem/64542588>
906
907         Unreviewed build-fix.
908
909         * BuildSlaveSupport/build.webkit.org-config/config.json: Use arm64_32 to build watchOS device.
910         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
911         (WebKitBuildbot): watchOS device should be considered 32 bit.
912         * Scripts/configure-xcode-for-embedded-development: Force-copy MediaAccessibility.framework.
913         * Scripts/webkitdirs.pm:
914         (extractNonMacOSHostConfiguration): Native Macs never use 32 bit tool binaries.
915
916 2020-06-19  Aakash Jain  <aakash_jain@apple.com>
917
918         Delete dead code for old ews api tests
919         https://bugs.webkit.org/show_bug.cgi?id=213421
920
921         Rubber-stamped by Alexey Proskuryakov.
922
923         * Scripts/webkitpy/common/config/ports.py:
924         (DeprecatedPort.run_api_tests_command): Deleted.
925         * Scripts/webkitpy/common/net/apitestresults.py: Removed.
926         * Scripts/webkitpy/common/net/apitestresults_unittest.py: Removed.
927         * Scripts/webkitpy/port/base.py:
928         (Port.bindings_results_directory):
929         (Port.api_results_directory): Deleted.
930         * Scripts/webkitpy/tool/bot/apitestresultsreader.py: Removed.
931         * Scripts/webkitpy/tool/steps/runtests.py:
932         (RunTests._run_api_tests): Deleted.
933         * Scripts/webkitpy/tool/steps/steps_unittest.py:
934         (test_runtests_api_debug): Deleted.
935
936 2020-06-19  Jonathan Bedard  <jbedard@apple.com>
937
938         Bring up watchOS/tvOS on build.webkit.org
939         https://bugs.webkit.org/show_bug.cgi?id=213402
940         <rdar://problem/64542588>
941
942         Unreviewed infrastructure fix.
943
944         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
945         (_should_file_trigger_build): Add tvOS and watchOS.
946         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
947         (ShouldBuildTest):
948         (ShouldBuildTest.test_should_build):
949
950 2020-06-19  Jiewen Tan  <jiewen_tan@apple.com>
951
952         [WebAuthn] Provide a _WKWebAuthenticationPanelUpdatePINInvalid update to UI clients if the returned PIN from the client is not valid
953         https://bugs.webkit.org/show_bug.cgi?id=213404
954         <rdar://problem/64543894>
955
956         Reviewed by Brent Fulgham.
957
958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
959         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
960         (TestWebKitAPI::TEST):
961         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-fake-pin-invalid-error-retry.html: Added.
962
963 2020-06-19  Jonathan Bedard  <jbedard@apple.com>
964
965         Bring up watchOS/tvOS on build.webkit.org
966         https://bugs.webkit.org/show_bug.cgi?id=213402
967         <rdar://problem/64542588>
968
969         Reviewed by Aakash Jain.
970
971         * BuildSlaveSupport/build.webkit.org-config/config.json: Add AppleTV and watchOS builders.
972         * BuildSlaveSupport/build.webkit.org-config/factories.py:
973         (BuildFactory.__init__): Support AppleTV and watchOS.
974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13.png: Added.
975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13@2x.png: Added.
976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13Simulator.png: Added.
977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13Simulator@2x.png: Added.
978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS6.png: Added.
979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS6@2x.png: Added.
980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator6.png: Added.
981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator6@2x.png: Added.
982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
985         * BuildSlaveSupport/build.webkit.org-config/steps.py:
986         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
987
988 2020-06-19  Saam Barati  <sbarati@apple.com>
989
990         Have a memory monitor thread in jsc shell when running tests using --memory-limited
991         https://bugs.webkit.org/show_bug.cgi?id=213389
992
993         Reviewed by Mark Lam.
994
995         * Scripts/run-jsc-stress-tests:
996         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
997         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
998
999 2020-06-19  Chris Fleizach  <cfleizach@apple.com>
1000
1001         AX: Make isolated tree enablement status dependent on client preference
1002         https://bugs.webkit.org/show_bug.cgi?id=213355
1003         <rdar://problem/64506577>
1004
1005         Reviewed by Zalan Bujtas.
1006
1007         * MiniBrowser/mac/AppDelegate.m:
1008         (-[BrowserAppDelegate defaultConfiguration]):
1009
1010 2020-06-19  Aakash Jain  <aakash_jain@apple.com>
1011
1012         Improve handling of trac downtime by commit-queue
1013         https://bugs.webkit.org/show_bug.cgi?id=213377
1014
1015         Reviewed by Jonathan Bedard.
1016
1017         * BuildSlaveSupport/ews-build/steps.py: Load contributors.json from disk when loading from trac fails.
1018         (ValidateCommiterAndReviewer.load_contributors_from_disk):
1019         (ValidateCommiterAndReviewer.load_contributors_from_trac):
1020         (ValidateCommiterAndReviewer.load_contributors):
1021         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test
1022
1023 2020-06-19  Lauro Moura  <lmoura@igalia.com>
1024
1025         [WPE] Warn potential issues when creating WindowViewBackend
1026         https://bugs.webkit.org/show_bug.cgi?id=213326
1027
1028         Reviewed by Philippe Normand.
1029
1030         Make it easier to debug eventual GL issues when starting up MiniBrowser in
1031         windowed mode.
1032
1033         * wpe/backends/WindowViewBackend.cpp:
1034         (WPEToolingBackends::WaylandEGLConnection::singleton):
1035         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1036
1037 2020-06-19  Lauro Moura  <lmoura@igalia.com>
1038
1039         [webkitpy][WPE] Default to headless if _display_server is xfvb
1040         https://bugs.webkit.org/show_bug.cgi?id=213327
1041
1042         Reviewed by Philippe Normand.
1043
1044         Xvfb is used as the default display server for some scripts, and the
1045         equivalent for WPE is the headless one.
1046
1047         WTR and the API tests already create only HeadlessViewBackends, but the
1048         WebDriver tests create them through MiniBrowser, which requires the
1049         '--headless' parameter.
1050
1051         * Scripts/run-webdriver-tests: Do not override _display_server
1052         * Scripts/webkitpy/port/base.py:
1053         (Port.__init__): Define _display_server for all ports to avoid
1054         eventually needing to override it.
1055         * Scripts/webkitpy/port/wpe.py:
1056         (WPEPort.__init__): Default to 'headless' if _display_server is 'xvfb'
1057         * Scripts/webkitpy/w3c/wpt_runner.py:
1058         (main): Dot not override _display_server
1059
1060 2020-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1061
1062         Add support for fetching registrable domains with resource load statistics
1063         https://bugs.webkit.org/show_bug.cgi?id=213291
1064
1065         Reviewed by Adrian Perez de Castro.
1066
1067         Update GLib ITP unit test to check also fetch and remove.
1068
1069         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1070         (testWebsiteDataITP):
1071
1072 2020-06-19  Tomoki Imai  <Tomoki.Imai@sony.com>
1073
1074         Change my (Tomoki Imai's) status to committer
1075
1076         Unreviewed, just updating contributors.json for myself.
1077
1078         * Scripts/webkitpy/common/config/contributors.json:
1079
1080 2020-06-18  Jonathan Bedard  <jbedard@apple.com>
1081
1082         Add SPI to preconnect to a server (Follow-up fix)
1083         https://bugs.webkit.org/show_bug.cgi?id=213109
1084         <rdar://problem/64184412>
1085
1086         Unreviewed build-fix.
1087
1088         * TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm: HTTPServer does not exist if HAVE(NETWORK_FRAMEWORK) is false.
1089
1090 2020-06-18  Jonathan Bedard  <jbedard@apple.com>
1091
1092         [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions (build-fix)
1093         https://bugs.webkit.org/show_bug.cgi?id=213183
1094         <rdar://problem/64273483>
1095
1096         Unreviewed build fix.
1097
1098         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1099         (webViewWithAutofocusedInput): bool may not be the same type as BOOL.
1100
1101 2020-06-18  Saam Barati  <sbarati@apple.com>
1102
1103         call skip when skipping JetStream2 wasm test
1104         https://bugs.webkit.org/show_bug.cgi?id=213354
1105
1106         Reviewed by Yusuke Suzuki.
1107
1108         So we can see the logging that we're skipping.
1109
1110         * Scripts/run-jsc-stress-tests:
1111
1112 2020-06-18  Joonghun Park  <jh718.park@samsung.com>
1113
1114     Unreviewed. Remove the build warning below since r262971.
1115     warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
1116
1117         * WebKitTestRunner/TestController.cpp:
1118         (WTR::getAllStorageAccessEntriesCallback):
1119
1120 2020-06-18  Ross Kirsling  <ross.kirsling@sony.com>
1121
1122         [Intl] Enable RelativeTimeFormat and Locale by default
1123         https://bugs.webkit.org/show_bug.cgi?id=213324
1124
1125         Reviewed by Yusuke Suzuki.
1126
1127         * Scripts/run-jsc-stress-tests:
1128         Remove feature flags.
1129
1130 2020-06-18  Andy Estes  <aestes@apple.com>
1131
1132         Unreviewed build fix after r263194
1133
1134         * WebKitTestRunner/ios/TestControllerIOS.mm:
1135         (WTR::TestController::platformResetStateToConsistentValues): Guarded code that mentions
1136         UIContextMenuInteraction with USE(UICONTEXTMENU).
1137
1138 2020-06-18  Ryan Haddad  <ryanhaddad@apple.com>
1139
1140         Unreviewed infrastructure fix, temporarily remove ews116 due to hardware failure tracked with rdar://64424245
1141
1142         * BuildSlaveSupport/ews-build/config.json:
1143
1144 2020-06-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1145
1146         [GTK][WPE] Add API to configure and handle service worker registrations to WebKitWebsiteDataManager
1147         https://bugs.webkit.org/show_bug.cgi?id=213290
1148
1149         Reviewed by Michael Catanzaro.
1150
1151         Handle new website data in MiniBrowser and add a unit test.
1152
1153         * MiniBrowser/gtk/main.c:
1154         (gotWebsiteDataCallback):
1155         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1156         (serverCallback):
1157         (testWebsiteDataConfiguration):
1158         (testWebsiteDataEphemeral):
1159         (testWebsiteDataITP):
1160         (testWebsiteDataServiceWorkerRegistrations):
1161         (beforeAll):
1162         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1163         (Test::Test):
1164
1165 2020-06-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1166
1167         RebaselineServer: "Rebaseline queue" button is placed behind the footer
1168         https://bugs.webkit.org/show_bug.cgi?id=213258
1169
1170         Reviewed by Zalan Bujtas.
1171
1172         * Scripts/webkitpy/tool/servers/data/rebaselineserver/index.html: Moved 'log' and 'queue' elements after 'footer' element.
1173         * Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
1174         (#queue): Changed 'bottom' property from 3em to 4em.
1175
1176 2020-06-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1177
1178         [macOS] Shift-tab in a bullet list in Mail Compose jumps back to Subject field
1179         https://bugs.webkit.org/show_bug.cgi?id=213320
1180         <rdar://problem/63831962>
1181
1182         Reviewed by Tim Horton.
1183
1184         Add a new API test to verify that preventing the "keypress" event for shift+tab in an SPI-editable web view
1185         causes us to avoid relinquishing focus.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1188
1189 2020-06-17  Andy Estes  <aestes@apple.com>
1190
1191         REGRESSION (r258092): fast/forms/ios/file-upload-panel.html fails when HAVE(UICONTEXTMENU_LOCATION)
1192         https://bugs.webkit.org/show_bug.cgi?id=213314
1193         <rdar://problem/60339129>
1194
1195         Reviewed by Maciej Stachowiak.
1196
1197         fast/forms/ios/file-upload-panel.html sets the shouldHandleRunOpenPanel and
1198         shouldPresentPopovers test options to false so that WKTR will (a) not register a
1199         runOpenPanel UI delegate callback, causing WebKit to create a WKFileUploadPanel instead, and
1200         (b) swizzle two UIKit view controller presentation methods to prevent the document picker
1201         menu from being presented. The test merely wants the WKFileUploadPanel instance to exist in
1202         order to query its available actions, not for it to show UI.
1203
1204         In r258092, WKFileUploadPanel now sometimes uses a UIContextMenuInteraction instance to
1205         present the document picker menu, but -[UIContextMenuInteraction _presentMenuAtLocation:]
1206         fails due to WKTR's above-mentioned swizzling. When this failure occurs,
1207         UIContextMenuInteraction calls -contextMenuInteraction:willEndForConfiguration:animator: on
1208         its delegate (the WKFileUploadPanel), which dismisses the open panel before the test has had
1209         a chance to query the available actions.
1210
1211         Fixed this by swizzling -[UIContextMenuInteraction _presentMenuAtLocation:] when the
1212         shouldPresentPopovers test option is false.
1213
1214         * WebKitTestRunner/ios/TestControllerIOS.mm:
1215         (overridePresentMenuOrPopoverOrViewController): Renamed from
1216         overridePresentViewControllerOrPopover.
1217         (WTR::TestController::platformResetStateToConsistentValues): Swizzled
1218         -[UIContextMenuInteraction _presentMenuAtLocation:] with
1219         overridePresentMenuOrPopoverOrViewController when the shouldPresentPopovers test option is
1220         false.
1221         (overridePresentViewControllerOrPopover): Renamed to
1222         overridePresentMenuOrPopoverOrViewController.
1223
1224 2020-06-17  Sihui Liu  <sihui_liu@apple.com>
1225
1226         REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure
1227         https://bugs.webkit.org/show_bug.cgi?id=213311
1228         <rdar://problem/64456413>
1229
1230         Reviewed by Wenson Hsieh.
1231
1232         TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem does not wait long 
1233         enough to make sure TextManipulationController gets notified about the insertion and starts observing.
1234
1235         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1236         (TestWebKitAPI::TEST):
1237
1238 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1239
1240         Delete code for old ews bindings queue
1241         https://bugs.webkit.org/show_bug.cgi?id=213315
1242
1243         Rubber-stamped by Alexey Proskuryakov.
1244
1245         * Scripts/webkitpy/common/config/ews.json:
1246         * Scripts/webkitpy/common/config/ports.py:
1247         (DeprecatedPort.run_bindings_tests_command): Deleted.
1248         (WinPort.run_bindings_tests_command): Deleted.
1249         * Scripts/webkitpy/common/config/ports_mock.py:
1250         (MockPort.run_bindings_tests_command): Deleted.
1251         * Scripts/webkitpy/common/net/generictestresults.py: Removed.
1252         * Scripts/webkitpy/common/net/generictestresults_unittest.py: Removed.
1253         * Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Removed.
1254         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1255         (PatchAnalysisTask._retry_bindings_tests): Deleted.
1256         * Scripts/webkitpy/tool/bot/retrylogic_unittest.py:
1257         (MockBindingsEarlyWarningSystem): Deleted.
1258         (MockBindingsEarlyWarningSystem.__init__): Deleted.
1259         (MockBindingsEarlyWarningSystem.test_results): Deleted.
1260         (BindingsEarlyWarningSystemTest): Deleted.
1261         (BindingsEarlyWarningSystemTest._results_indicate_all_passed): Deleted.
1262         (BindingsEarlyWarningSystemTest._create_task): Deleted.
1263         (BindingsEarlyWarningSystemTest.test_success_case): Deleted.
1264         (BindingsEarlyWarningSystemTest.test_test_failure): Deleted.
1265         (BindingsEarlyWarningSystemTest.test_fix): Deleted.
1266         (BindingsEarlyWarningSystemTest.test_ineffective_patch): Deleted.
1267         (BindingsEarlyWarningSystemTest.test_partially_effective_patch): Deleted.
1268         (BindingsEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Deleted.
1269         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1270         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1271         (TestBindingsEWS): Deleted.
1272         (AbstractEarlyWarningSystemTest.test_failing_bindings_tests_message): Deleted.
1273         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1274         * Scripts/webkitpy/tool/steps/runtests.py:
1275         (RunTests._run_bindings_tests): Deleted.
1276         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1277         (test_patch_relevant_bindings): Deleted.
1278         (test_runtests_api): Deleted.
1279
1280 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1281
1282         Delete code for old ews style queue
1283         https://bugs.webkit.org/show_bug.cgi?id=213297
1284
1285         Rubber-stamped by Alexey Proskuryakov.
1286
1287         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Removed.
1288         * Scripts/webkitpy/tool/commands/queues.py:
1289         (StyleQueue): Deleted.
1290         (StyleQueue.__init__): Deleted.
1291         (StyleQueue.review_patch): Deleted.
1292         (StyleQueue.run_command): Deleted.
1293         (StyleQueue.expected_failures): Deleted.
1294         (StyleQueue.refetch_patch): Deleted.
1295         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1296         (TestReviewQueue): Deleted.
1297
1298 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1299
1300         Delete code for old ews webkitpy queue
1301         https://bugs.webkit.org/show_bug.cgi?id=213299
1302
1303         Reviewed by Jonathan Bedard.
1304
1305         * Scripts/webkitpy/common/config/ews.json:
1306         * Scripts/webkitpy/common/net/generictestresults.py:
1307         (WebkitpyTestResults): Deleted.
1308         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1309         * Scripts/webkitpy/tool/bot/webkitpytestresultsreader.py: Removed.
1310         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1311         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1312         (TestWebkitpyEWS): Deleted.
1313         (AbstractEarlyWarningSystemTest.test_failing_webkitpy_tests_message): Deleted.
1314         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1315         * Scripts/webkitpy/tool/steps/runtests.py:
1316         (RunTests._run_webkitpy_tests): Deleted.
1317         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1318         (test_runtests_webkitpy): Deleted.
1319         (test_patch_not_relevant_bindings): Deleted.
1320         (test_runtests_api_debug): Deleted.
1321
1322 2020-06-17  Keith Miller  <keith_miller@apple.com>
1323
1324         WebKitTestRunner should not crash on alert with invalid utf16 strings
1325         https://bugs.webkit.org/show_bug.cgi?id=213269
1326
1327         Reviewed by Simon Fraser.
1328
1329         * WebKitTestRunner/StringFunctions.h:
1330         (WTR::toWTFString):
1331
1332 2020-06-17  Aakash Jain  <aakash_jain@apple.com>
1333
1334         Delete old ews client side code - part 2
1335         https://bugs.webkit.org/show_bug.cgi?id=213262
1336
1337         Reviewed by Alexey Proskuryakov.
1338
1339         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1340         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1341         (PatchAnalysisTaskDelegate.command_passed): Deleted.
1342         (PatchAnalysisTaskDelegate.command_failed): Deleted.
1343         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1344         (AbstractEarlyWarningSystem.command_passed): Deleted.
1345         (AbstractEarlyWarningSystem.command_failed): Deleted.
1346         * Scripts/webkitpy/tool/commands/perfalizer.py:
1347         (PerfalizerTask.command_passed): Deleted.
1348         (PerfalizerTask.command_failed): Deleted.
1349         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
1350         * Scripts/webkitpy/tool/commands/queues.py:
1351         (AbstractPatchQueue._next_patch): Deleted.
1352         (AbstractPatchQueue._did_error): Deleted.
1353         (AbstractPatchQueue._did_skip): Deleted.
1354         (AbstractPatchQueue._unlock_patch): Deleted.
1355         (StyleQueue.command_passed): Deleted.
1356         (StyleQueue.command_failed): Deleted.
1357
1358 2020-06-17  Paulo Matos  <pmatos@igalia.com>
1359
1360         Add new Igalia EWS workers for ARM/MIPS
1361         https://bugs.webkit.org/show_bug.cgi?id=212803
1362
1363         Reviewed by Aakash Jain.
1364
1365         * BuildSlaveSupport/ews-build/config.json:
1366
1367 2020-06-16  Mark Lam  <mark.lam@apple.com>
1368
1369         TestWebKitAPI.WebCore.WildcardStringMatching needs to initialize Options before accessing them.
1370         https://bugs.webkit.org/show_bug.cgi?id=213270
1371         <rdar://problem/64427499>
1372
1373         Reviewed by Yusuke Suzuki.
1374
1375         * TestWebKitAPI/Tests/WebCore/StringUtilities.mm:
1376         (TestWebKitAPI::TEST):
1377
1378 2020-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1379
1380         Text manipulation should not re-extract elements whose children have been manipulated
1381         https://bugs.webkit.org/show_bug.cgi?id=213276
1382         <rdar://problem/64193446>
1383
1384         Reviewed by Tim Horton.
1385
1386         Add a new API test where we start and complete text manipulation, and then hide and show the manipulated
1387         element. This test verifies that the new item callbacks are *not* called after element is shown again.
1388
1389         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1390         (TestWebKitAPI::TEST):
1391
1392 2020-06-16  Saam Barati  <sbarati@apple.com>
1393
1394         Fix two typos "signifcant" and "signficance". Should be "significant" and "significance"
1395
1396         * Scripts/compare-results:
1397         (displayStr):
1398         (computeMultipleHypothesesSignificance):
1399         (dumpBreakdowns):
1400         (writeCSV):
1401         (computeMultipleHypothesesSignficance): Deleted.
1402
1403 2020-06-16  Andres Gonzalez  <andresg_22@apple.com>
1404
1405         Fix for accessibility/textarea-selected-text-range.html in isolated tree mode.
1406         https://bugs.webkit.org/show_bug.cgi?id=213257
1407
1408         Reviewed by Chris Fleizach.
1409
1410         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1411         (WTR::setAttributeValue):
1412         (WTR::AccessibilityUIElement::selectedTextRange): Dispatch call into
1413         WebAccessibilityWrapper onto AX secondary thread to simulate isolated
1414         tree mode.
1415
1416 2020-06-16  Saam Barati  <sbarati@apple.com>
1417
1418         Multiple hypothesis testing should use False Discovery Rate instead of Bonferroni
1419         https://bugs.webkit.org/show_bug.cgi?id=213219
1420
1421         Reviewed by Mark Lam.
1422
1423         My previous patch here used Bonferroni to do multiple hypotheses correction.
1424         Bonferroni does a good job at reducing false positive rate (type I error,
1425         saying something is significant when it's not, e.g, rejecting the null
1426         hypothesis when we shouldn't), but at the expense of also having a high
1427         false negative rate (type II error, saying something is not significant when
1428         it is, e.g, not rejecting the null hypothesis when we should).
1429         
1430         After doing a bit more reading, it seems like using a technique called False
1431         Discovery Rate (FDR) is better. It still does a good job at controlling type
1432         I error rate, but without sacrificing a high type II error rate. FDR is based
1433         on a technique for "estimating the proportion of wrongly rejected null hypotheses" [2].
1434         
1435         This patch uses Benjamini and Hochberg estimation of FDR, which relies
1436         on hypotheses being independent. We know subtests in a benchmark aren't
1437         fully independent variables, but it's a good enough approximation.
1438         
1439         You can read more about FDR:
1440         1. https://www.stat.berkeley.edu/~mgoldman/Section0402.pdf
1441         2. https://besjournals.onlinelibrary.wiley.com/doi/10.1111/j.2041-210X.2010.00061.x
1442         3. https://en.wikipedia.org/wiki/False_discovery_rate
1443
1444         * Scripts/compare-results:
1445         (displayStr):
1446         (computeMultipleHypothesesSignficance):
1447         (dumpBreakdowns):
1448         (writeCSV):
1449
1450 2020-06-16  David Kilzer  <ddkilzer@apple.com>
1451
1452         REGRESSION (r262994): Web Inspector is killed when context-clicking anywhere
1453         <https://webkit.org/b/213224>
1454         <rdar://problem/64383320>
1455
1456         Reviewed by Darin Adler.
1457
1458         * TestWebKitAPI/CMakeLists.txt:
1459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1460         - Add ContextMenuAction.cpp to build systems.
1461         * TestWebKitAPI/Tests/WebCore/ContextMenuAction.cpp: Add.
1462         (TestWebKitAPI::TEST):
1463         - Add TestWebKitAPI.WebCore.ContextMenuAction_IsValidEnum.
1464
1465 2020-06-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1466
1467         [Win] Mouse dragging tests are failing because WebKitTestRunner dispatches WM_MOUSELEAVE to the hidden WebView
1468         https://bugs.webkit.org/show_bug.cgi?id=213239
1469
1470         Reviewed by Don Olmstead.
1471
1472         There are two problems:
1473         1. Windows EventSenderProxy::mouseMoveTo doesn't set WPARAM of WM_MOUSEMOVE
1474         2. Unexpected WM_MOUSELEAVE discontinues the mouse dragging events
1475
1476         WPARAM of WM_MOUSEMOVE should represent pressed mouse buttons while dragging.
1477
1478         WM_MOUSELEAVE is unexpectedly dispatched because the mouse cursor
1479         is always out of the hidden WebView. The unexpected WM_MOUSELEAVE
1480         discontinues dragging events. WM_MOUSELEAVE shouldn't be
1481         dispatched in WebKitTestRunner. Ignore it.
1482
1483         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1484         (WTR::EventSenderProxy::mouseDown):
1485         (WTR::EventSenderProxy::mouseUp):
1486         (WTR::EventSenderProxy::mouseMoveTo): Set MK_LBUTTON to WPARAM of
1487         WM_MOUSEMOVE while dragging.
1488         * WebKitTestRunner/win/TestControllerWin.cpp:
1489         (WTR::runRunLoopUntil): Ignore WM_MOUSELEAVE.
1490
1491 2020-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1492
1493         Text manipulation should handle nested item boundary elements
1494         https://bugs.webkit.org/show_bug.cgi?id=213251
1495         <rdar://problem/63371514>
1496
1497         Reviewed by Sihui Liu.
1498
1499         Add a new API test to exercise this scenario.
1500
1501         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1502
1503 2020-06-16  Charlie Turner  <cturner@igalia.com>
1504
1505         [GTK] Disable video autoplay
1506         https://bugs.webkit.org/show_bug.cgi?id=184845
1507
1508         Reviewed by Carlos Garcia Campos.
1509
1510         Update the various callsites for constructing a view to take into
1511         account the default policies. I chose the default as autoplay
1512         allow without sound, which is in keeping with WebCore's choice.
1513
1514         * MiniBrowser/gtk/BrowserWindow.c:
1515         (webViewDecidePolicy):
1516         (newTabCallback):
1517         (openPrivateWindow):
1518         (browser_window_get_or_create_web_view_for_automation):
1519         (browser_window_create_web_view_in_new_tab_for_automation):
1520         * MiniBrowser/gtk/main.c:
1521         (createBrowserTab):
1522         (main):
1523         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Add
1524         autoplay policy tests, and use modern class initializers.
1525         (testAutoplayPolicy):
1526         (beforeAll):
1527
1528 2020-06-16  Philippe Normand  <pnormand@igalia.com>
1529
1530         [Flatpak SDK] Subversion perl bindings unusable
1531         https://bugs.webkit.org/show_bug.cgi?id=213241
1532
1533         Reviewed by Sergio Villar Senin.
1534
1535         * buildstream/elements/sdk/subversion.bst: The svn swig perl library wasn't correctly
1536         installed, leading to undefined symbols when importing it from the bindings. A new
1537         integration command now tests this.
1538
1539 2020-06-16  Philippe Normand  <pnormand@igalia.com>
1540
1541         [Flatpak SDK] Update to Qt 5.15
1542         https://bugs.webkit.org/show_bug.cgi?id=213192
1543
1544         Reviewed by Sergio Villar Senin.
1545
1546         The new patch comes from the upstream KDE SDK: https://github.com/KDE/flatpak-kde-runtime/tree/qt5.15lts/patch
1547         
1548         * buildstream/elements/qt5/qtbase.bst:
1549         * buildstream/elements/qt5/qtdeclarative.bst:
1550         * buildstream/elements/qt5/qtquickcontrols.bst:
1551         * buildstream/elements/qt5/qtquickcontrols2.bst:
1552         * buildstream/elements/qt5/qtwayland.bst:
1553         * buildstream/elements/qt5/qtx11extras.bst:
1554         * buildstream/patches/qtbase-make-sure-to-correctly-construct-base-platform-theme.patch: Added.
1555         * buildstream/patches/qtwayland-use-gnome-platform-theme-on-gnome-based-desktops.patch: Removed.
1556         * buildstream/project.conf:
1557
1558 2020-06-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1559
1560         [GTK][WPE] Add API to configure and enable resource load statistics
1561         https://bugs.webkit.org/show_bug.cgi?id=177943
1562
1563         Reviewed by Michael Catanzaro.
1564
1565         Add --enable-itp command line version to MiniBrowser and unit tests to check the new API.
1566
1567         * MiniBrowser/gtk/main.c:
1568         (gotWebsiteDataCallback):
1569         (activate):
1570         * MiniBrowser/wpe/main.cpp:
1571         (main):
1572         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1573         (serverCallback):
1574         (testWebsiteDataConfiguration):
1575         (testWebsiteDataEphemeral):
1576         (testWebsiteDataITP):
1577         (beforeAll):
1578         * TestWebKitAPI/glib/TestExpectations.json:
1579         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1580         (Test::Test):
1581         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1582         (directoryChangedCallback):
1583         (WebViewTest::waitUntilFileChanged):
1584         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1585
1586 2020-06-16  Philippe Normand  <pnormand@igalia.com>
1587
1588         REGRESSION(r263029): [Flatpak SDK] Broke initial SDK installation
1589
1590         Rubber-stamped by Žan Doberšek.
1591
1592         * flatpak/flatpakutils.py:
1593         (FlatpakObject.version): Gracefully return an empty version when the flatpak info command
1594         fails. This usually means the app has not been installed yet.
1595
1596 2020-06-15  Megan Gardner  <megan_gardner@apple.com>
1597
1598         Text form controls can scroll by 1px when value is the same length as size. No scrolling should happen.
1599         https://bugs.webkit.org/show_bug.cgi?id=212856
1600         <rdar://problem/63541707>
1601
1602         Reviewed by Zalan Bujtas.
1603
1604         Rebased to reflect new sizes.
1605
1606         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1607         (TEST):
1608         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1609         (TestWebKitAPI::TEST):
1610
1611 2020-06-15  Jonathan Bedard  <jbedard@apple.com>
1612
1613         Follow-up fix: Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
1614         https://bugs.webkit.org/show_bug.cgi?id=213144
1615         <rdar://problem/64316743>
1616
1617         Unreviewed build fix.
1618
1619         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Guard didFinishNavigation declaration with HAVE(NETWORK_FRAMEWORK).
1620
1621 2020-06-15  Alex Christensen  <achristensen@webkit.org>
1622
1623         Provide alternatively-named SPI for user style sheets and scripts
1624         https://bugs.webkit.org/show_bug.cgi?id=213206
1625
1626         Reviewed by Brady Eidson.
1627
1628         * DumpRenderTree/mac/DumpRenderTree.mm:
1629         (fontAllowList):
1630         (createWebViewAndOffscreenWindow):
1631         (resetWebViewToConsistentStateBeforeTesting):
1632         (fontWhitelist): Deleted.
1633         * DumpRenderTree/mac/TestRunnerMac.mm:
1634         (TestRunner::addOriginAccessWhitelistEntry):
1635         (TestRunner::removeOriginAccessWhitelistEntry):
1636         (TestRunner::addUserScript):
1637         (TestRunner::addUserStyleSheet):
1638         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1639         (TEST):
1640         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
1641         (TEST):
1642         * WebKitTestRunner/mac/TestControllerMac.mm:
1643         (WTR::generateFontAllowList):
1644         (WTR::TestController::platformInitializeContext):
1645         (WTR::generateWhitelist): Deleted.
1646
1647 2020-06-15  Alex Christensen  <achristensen@webkit.org>
1648
1649         Add SPI to preconnect to a server
1650         https://bugs.webkit.org/show_bug.cgi?id=213109
1651         <rdar://problem/64184412>
1652
1653         Reviewed by Geoff Garen.
1654
1655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1656
1657 2020-06-15  Keith Miller  <keith_miller@apple.com>
1658
1659         Signal handlers should have a two phase installation.
1660         https://bugs.webkit.org/show_bug.cgi?id=213160
1661
1662         Reviewed by Mark Lam.
1663
1664         * TestWebKitAPI/Tests/WTF/Signals.cpp:
1665         (TEST):
1666
1667 2020-06-15  Sihui Liu  <sihui_liu@apple.com>
1668
1669         Text manipulation does not observe newly displayed element inside previously observed content
1670         https://bugs.webkit.org/show_bug.cgi?id=213156
1671
1672         Reviewed by Darin Adler.
1673
1674         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1675         (TestWebKitAPI::TEST):
1676
1677 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1678
1679         [Flatpak SDK] Bump Subversion and enable Perl bindings
1680         https://bugs.webkit.org/show_bug.cgi?id=213189
1681
1682         Reviewed by Žan Doberšek.
1683
1684         * buildstream/elements/sdk-build-depends/swig.bst: Added.
1685         * buildstream/elements/sdk/subversion.bst: Enable Perl bindings so that git svn can be used within the sandbox.
1686
1687 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1688
1689         [Flatpak SDK] flatpak update still not displayed
1690         https://bugs.webkit.org/show_bug.cgi?id=213180
1691
1692         Reviewed by Žan Doberšek.
1693
1694         Added a new --version option to the script. We no longer gather the flatpak update command
1695         output to know if something was updated or not. Instead we get the version of the SDK prior
1696         to the update operation and compare that with the version after the update.
1697
1698         * flatpak/flatpakutils.py:
1699         (FlatpakObject.version):
1700         (WebkitFlatpak.load_from_args):
1701         (WebkitFlatpak.main):
1702
1703 2020-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1704
1705         [GTK][WPE] Add API to expose UIClient::requestStorageAccessConfirm
1706         https://bugs.webkit.org/show_bug.cgi?id=210422
1707
1708         Reviewed by Michael Catanzaro.
1709
1710         Handle WebKitWebsiteDataAccessPermissionRequest in MiniBrowser.
1711
1712         * MiniBrowser/gtk/BrowserTab.c:
1713         (decidePermissionRequest):
1714
1715 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1716
1717         [Flatpak SDK] Add libavif
1718         https://bugs.webkit.org/show_bug.cgi?id=212964
1719         <rdar://problem/64291035>
1720
1721         Reviewed by Žan Doberšek.
1722
1723         Because of the ABI bump of dav1d, which ffmpeg depends on, ffmpeg needs to be rebuilt. So
1724         this is a good opportunity to include it in the SDK and not rely on the ffmpeg-full
1725         extension anymore, because it doesn't provide debug symbols.
1726
1727         * buildstream/elements/flatpak/platform.bst:
1728         * buildstream/elements/flatpak/sdk.bst:
1729         * buildstream/elements/freedesktop-sdk.bst:
1730         * buildstream/elements/sdk-platform.bst:
1731         * buildstream/elements/sdk/ffmpeg.bst: Added.
1732         * buildstream/elements/sdk/gst-libav.bst:
1733         * buildstream/elements/sdk/libavif.bst: Added.
1734         * buildstream/elements/sdk/ruby-highline.bst: Remove the spec source, un-needed.
1735         * buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Added.
1736         * buildstream/patches/fdo/0001-ffmpeg-Add-MS-MPEG-DivX-variants.patch: Removed.
1737         * buildstream/patches/fdo/0002-ffmpeg-Add-VP6-and-Sorenson-Spark-video-codecs.patch: Removed.
1738         * buildstream/patches/fdo/0003-ffmpeg-Add-Intel-Indeo-and-Cinepak-video-support.patch: Removed.
1739         * buildstream/patches/fdo/0004-ffmpeg-Add-MPEG-2-video-decoder.patch: Removed.
1740         * buildstream/patches/fdo/0005-ffmpeg-Add-msmpeg4v3-support.patch: Removed.
1741         * buildstream/project.conf:
1742         * flatpak/flatpakutils.py:
1743         (WebkitFlatpak._get_packages):
1744
1745 2020-06-15  Philippe Normand  <pnormand@igalia.com>
1746
1747         [Flatpak SDK] Remove webkit-build-directory dependency from flatpakutils
1748         https://bugs.webkit.org/show_bug.cgi?id=213179
1749
1750         Reviewed by Žan Doberšek.
1751
1752         This makes webkit-flatpak usable without installing additional perl modules (version) on the host OS.
1753
1754         * flatpak/flatpakutils.py:
1755         (WebkitFlatpak.load_from_args): Make --release and --debug mutually exclusive, and default to Release builds.
1756         (WebkitFlatpak.__init__):
1757         (WebkitFlatpak.clean_args): No need to pull in webkitpy which pulls webkitdirs.pm only to
1758         determine the default configuration. Assume we use Release by default.
1759
1760 2020-06-15  Paulo Matos  <pmatos@igalia.com>
1761
1762         Properly propagate TZ to the remote test devices
1763         https://bugs.webkit.org/show_bug.cgi?id=212816
1764
1765         Reviewed by Philippe Normand.
1766
1767         * Scripts/run-jsc-stress-tests:
1768
1769 2020-06-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1770
1771         [iOS] Two KeyboardInputTests are failing on recent iOS SDK versions
1772         https://bugs.webkit.org/show_bug.cgi?id=213183
1773         <rdar://problem/64273483>
1774
1775         Reviewed by Tim Horton.
1776
1777         On recent versions of the iOS SDK, iOS simulators that are not shown on-screen are treated as if the hardware
1778         keyboard is not available (that is, `+[UIIKeyboard isInHardwareKeyboardMode]` returns `NO`). When running API
1779         tests while `Simulator.app` is already launched, an iOS simulator is presented on-screen, whereas the simulator
1780         is not visible when running API tests without launching `Simulator.app` beforehand.
1781
1782         This discrepancy causes two iOS API tests to fail (i.e. `CaretSelectionRectAfterRestoringFirstResponder` and
1783         `RangedSelectionRectAfterRestoringFirstResponder`), due to the fact that `-[WKWebView becomeFirstResponder]` no
1784         longer causes an input session to begin.
1785
1786         Interestingly, these tests already attempt to circumvent this by using `webViewWithAutofocusedInput()`, which
1787         creates and loads a `WKWebView` with a single autofocusing input element, with a `_WKInputDelegate` that
1788         unconditionally allows input sessions to begin. However, this doesn't work as intended in these tests, because
1789         nothing keeps the delegate (a `TestInputDelegate`) alive past the scope of the call to
1790         `webViewWithAutofocusedInput()`. Since `[WKWebView _inputDelegate]` is a weak property, the input delegate
1791         simply disappears after we finish waiting for the load to finish (and the autofocused input element begins its
1792         input session). This causes us to erroneously fall back to default behavior (i.e.
1793         `_WKFocusStartsInputSessionPolicyAuto`) for subsequent calls to show the keyboard for the focused element, as is
1794         the case when these two API tests call `-becomeFirstResponder`. The end result is that the keyboard doesn't
1795         appear and text selection views are not created and laid out, but only when API tests are run without having
1796         launched the Simulator app beforehand.
1797
1798         To fix this, refactor `webViewWithAutofocusedInput()` into `webViewAndInputDelegateWithAutofocusedInput()`,
1799         which returns both the new `WKWebView` as well as the `TestInputDelegate` of the web view. The call site is then
1800         responsible for keeping the input delegate around for as long as it needs.
1801
1802         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1803         (webViewWithAutofocusedInput):
1804
1805         Drive-by fix: fix a potential stack smasher by using an Objective-C block when setting the input delegate's
1806         policy handler, and by using `__block` for the `doneWaiting` boolean flag. This is now a problem becuase this
1807         block may be invoked multiple times.
1808
1809         (webViewAndInputDelegateWithAutofocusedInput):
1810
1811 2020-06-13  Saam Barati  <sbarati@apple.com>
1812
1813         compare-results should have an option to print a breakdown and to save the breakdown as csv file
1814         https://bugs.webkit.org/show_bug.cgi?id=213140
1815
1816         Reviewed by Filip Pizlo.
1817
1818         In this patch, compare-results has a new --breakdown feature which will
1819         break down the results for -a and -b per subtest. It will also show you
1820         p values with a significance threshold determined using the Bonferroni
1821         correction for testing multiple hypotheses:
1822         https://en.wikipedia.org/wiki/Bonferroni_correction
1823         
1824         And there is also now a --csv option to generate a csv file containing
1825         the same per subtest breakdown.
1826         
1827         --breakdown will print out results like:
1828         
1829         ------------------------------------------------------------------------------------------------------------
1830         |               subtest                |     ms       |     ms       |  b / a   | pValue, alpha = 0.003125 |
1831         ------------------------------------------------------------------------------------------------------------
1832         | Elm-TodoMVC                          |616.625000    |583.625000    |0.946483  | 0.065002                 |
1833         | VueJS-TodoMVC                        |89.425000     |83.225000     |0.930668  | 0.039102                 |
1834         | EmberJS-TodoMVC                      |695.875000    |664.000000    |0.954194  | 0.088901                 |
1835         | Flight-TodoMVC                       |263.600000    |257.600000    |0.977238  | 0.249259                 |
1836         | BackboneJS-TodoMVC                   |213.025000    |201.550000    |0.946133  | 0.000636 (significant)   |
1837         | Preact-TodoMVC                       |48.800000     |47.550000     |0.974385  | 0.502768                 |
1838         | AngularJS-TodoMVC                    |745.300000    |704.275000    |0.944955  | 0.011779                 |
1839         | Inferno-TodoMVC                      |607.900000    |354.800000    |0.583649  | 0.000000 (significant)   |
1840         | Vanilla-ES2015-TodoMVC               |214.950000    |200.575000    |0.933124  | 0.005018                 |
1841         | Angular2-TypeScript-TodoMVC          |191.575000    |187.025000    |0.976250  | 0.542229                 |
1842         | VanillaJS-TodoMVC                    |162.075000    |160.375000    |0.989511  | 0.747186                 |
1843         | jQuery-TodoMVC                       |855.275000    |833.825000    |0.974920  | 0.103439                 |
1844         | EmberJS-Debug-TodoMVC                |2056.250000   |1952.050000   |0.949325  | 0.000003 (significant)   |
1845         | React-TodoMVC                        |475.225000    |428.950000    |0.902625  | 0.007566                 |
1846         | React-Redux-TodoMVC                  |791.100000    |736.675000    |0.931203  | 0.066091                 |
1847         | Vanilla-ES2015-Babel-Webpack-TodoMVC |208.050000    |202.000000    |0.970920  | 0.152470                 |
1848         ------------------------------------------------------------------------------------------------------------
1849
1850         * Scripts/compare-results:
1851         (readJSONFile):
1852         (speedometer2Breakdown):
1853         (jetStream2Breakdown):
1854         (motionMarkBreakdown):
1855         (plt5Breakdown):
1856         (displayStr):
1857         (dumpBreakdowns):
1858         (writeCSV):
1859         (detectMotionMark1_1):
1860         (detectMotionMark1_1_1):
1861         (motionMarkResults):
1862         (detectBenchmark):
1863         (getOptions):
1864         (main):
1865         (motionMark1_1Results): Deleted.
1866
1867 2020-06-13  Sam Weinig  <weinig@apple.com>
1868
1869         Extended Color: Experiment with strongly typed ColorComponents
1870         https://bugs.webkit.org/show_bug.cgi?id=212396
1871
1872         Reviewed by Darin Adler.
1873
1874         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
1875         (TestWebKitAPI::TEST):
1876         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
1877         (TestWebKitAPI::TEST):
1878         Update for changed names (e.g. toSRGBAComponentsLossy() -> toSRGBALossy())
1879         and use of explicit types.
1880
1881 2020-06-13  Diego Pino Garcia  <dpino@igalia.com>
1882
1883         Unreviewed, fix configuration setting of WPE Debug (Tests JS) bot
1884         https://bugs.webkit.org/show_bug.cgi?id=213164
1885
1886         The bot was meant to run as Debug.
1887
1888         * BuildSlaveSupport/build.webkit.org-config/config.json:
1889
1890 2020-06-12  Keith Miller  <keith_miller@apple.com>
1891
1892         Tests expecting a crash should use a signal handler in the JSC CLI process
1893         https://bugs.webkit.org/show_bug.cgi?id=212479
1894
1895         Reviewed by Yusuke Suzuki.
1896
1897         Crashing tests should now exit with status zero.
1898
1899         * Scripts/run-jsc-stress-tests:
1900         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
1901         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
1902         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
1903
1904 2020-06-12  Alex Christensen  <achristensen@webkit.org>
1905
1906         Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
1907         https://bugs.webkit.org/show_bug.cgi?id=213144
1908
1909         Reviewed by Geofferey Garen.
1910
1911         Most changes are straightforward moving to HTTPServer, which is more tolerant of different numbers of connections except these two:
1912
1913         The ResourceLoadDelegate.Challenge API test was checking the output of _WKResourceLoadDelegate.didReceiveChallenge
1914         by using a server trust challenge.  Now that preconnecting happens, the server trust evaluation would happen with a
1915         PreconnectTask, not the main resource load.  The WKNavigationDelegate still gets the challenge and there is no problem
1916         here, but in order to continue to test _WKResourceLoadDelegate.didReceiveChallenge I use a basic authentication challenge
1917         instead of a server trust evaluation.
1918
1919         The WebKit.FastServerTrust API test now has two failed attempts (one from the preconnect attempt, one from the main resource load attempt),
1920         but only when _strictTrustEvaluate is not available.
1921
1922         * TestWebKitAPI/TCPServer.cpp:
1923         (TestWebKitAPI::TCPServer::TCPServer):
1924         * TestWebKitAPI/TCPServer.h:
1925         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1926         (TEST):
1927         (TestWebKitAPI::TEST):
1928         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1929         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1930         * TestWebKitAPI/cocoa/HTTPServer.h:
1931         * TestWebKitAPI/cocoa/HTTPServer.mm:
1932         (TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
1933
1934 2020-06-12  Diego Pino Garcia  <dpino@igalia.com>
1935
1936         [buildbot] [GTK][WPE] Move WebDriver test to own bot
1937         https://bugs.webkit.org/show_bug.cgi?id=212527
1938
1939         Reviewed by Carlos Alberto Lopez Perez.
1940
1941         Move 'webdriver-test' step from GTK Release and GTK Debug test bots
1942         to separated bots.
1943
1944         For bots that require a Wayland display (WPE and GTK Wayland),
1945         'webdriver-test' step is run on the corresponding general test bot,
1946         since it's not possible at the moment to run tests that require a 
1947         Wayland display in a bot set as a container.
1948
1949         * BuildSlaveSupport/build.webkit.org-config/config.json:
1950         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1951         (TestFactory.__init__):
1952         (TestWebDriverFactory):
1953         (TestWebDriverFactory.__init__):
1954         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1955
1956 2020-06-12  Takashi Komori  <Takashi.Komori@sony.com>
1957
1958         [Curl] Implement functions to use ResourceLoadStatistics.
1959         https://bugs.webkit.org/show_bug.cgi?id=207692
1960
1961         Reviewed by Don Olmstead.
1962
1963         Implement functions which are required to implement ResourceLoadStatistics for Curl port.
1964
1965         Tests: http/tests/resourceLoadStatistics/
1966
1967         * WebKitTestRunner/TestController.cpp:
1968         (WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext):
1969         (WTR::getAllStorageAccessEntriesCallback):
1970         (WTR::TestController::getAllStorageAccessEntries):
1971
1972 2020-06-12  Jonathan Bedard  <jbedard@apple.com>
1973
1974         Support building test runners for watchOS and tvOS
1975         https://bugs.webkit.org/show_bug.cgi?id=213128
1976         <rdar://problem/64298006>
1977
1978         Reviewed by Tim Horton.
1979
1980         * DumpRenderTree/mac/Configurations/Base.xcconfig: Link against framework stubs.
1981         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Apply iOS rules to all embedded sdks.
1982         * WebKitTestRunner/Configurations/Base.xcconfig: Link against framework stubs.
1983         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Apply iOS rules to all embedded sdks.
1984         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Use watchOS entitlements for tvOS.
1985
1986 2020-06-12  Jonathan Bedard  <jbedard@apple.com>
1987
1988         TestWebKitAPI: Build for watchOS and tvOS
1989         https://bugs.webkit.org/show_bug.cgi?id=213127
1990         <rdar://problem/64297979>
1991
1992         Reviewed by Tim Horton.
1993
1994         * TestWebKitAPI/Configurations/Base.xcconfig: Link against framework stubs.
1995         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Apply iOS rules to all embedded sdks.
1996         * TestWebKitAPI/Configurations/TestWTF.xcconfig: Ditto.
1997         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Link against framework stubs.
1998         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Apply iOS rules to all embedded sdks.
1999         * TestWebKitAPI/config.h: WatchOS uses SSL.
2000
2001 2020-06-12  Commit Queue  <commit-queue@webkit.org>
2002
2003         Unreviewed, reverting r262942.
2004         https://bugs.webkit.org/show_bug.cgi?id=213132
2005
2006         Broke gst-libav due to dav1d ABI bump
2007
2008         Reverted changeset:
2009
2010         "[Flatpak SDK] Add libavif"
2011         https://bugs.webkit.org/show_bug.cgi?id=212964
2012         https://trac.webkit.org/changeset/262942
2013
2014 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2015
2016         Unreviewed. Fix GTK WebDriver tests after r262938
2017
2018         Ensure a valid title for backforward items in MiniBrowser, using the URL when the title is empty.
2019
2020         * MiniBrowser/gtk/BrowserWindow.c:
2021         (browserWindowCreateBackForwardMenu):
2022
2023 2020-06-12  Philippe Normand  <pnormand@igalia.com>
2024
2025         [Flatpak SDK] Update GTK4 to 3.98.5
2026
2027         Rubber-stamped by Carlos Alberto Lopez Perez.
2028
2029         * buildstream/elements/sdk/gtk.bst:
2030
2031 2020-06-12  Philippe Normand  <pnormand@igalia.com>
2032
2033         [Flatpak SDK] Add libavif
2034         https://bugs.webkit.org/show_bug.cgi?id=212964
2035
2036         Reviewed by Carlos Alberto Lopez Perez.
2037
2038         * buildstream/elements/freedesktop-sdk.bst:
2039         * buildstream/elements/sdk-platform.bst:
2040         * buildstream/elements/sdk/libavif.bst: Added.
2041         * buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Added.
2042
2043 2020-06-12  Philippe Normand  <pnormand@igalia.com>
2044
2045         [Flatpak SDK] Add libkate
2046         https://bugs.webkit.org/show_bug.cgi?id=212865
2047
2048         Reviewed by Carlos Alberto Lopez Perez.
2049
2050         The GStreamer kate decoder is required for some media/track tests being re-enabled in bug
2051         120665.
2052
2053         * buildstream/elements/sdk-platform.bst:
2054         * buildstream/elements/sdk/gst-plugins-bad.bst:
2055         * buildstream/elements/sdk/libkate.bst: Added.
2056
2057 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2058
2059         [GTK4] Get MiniBrowser ready for GTK4
2060         https://bugs.webkit.org/show_bug.cgi?id=210276
2061
2062         Reviewed by Adrian Perez de Castro.
2063
2064         Port MiniBrowser to GTK4. BrowserSearchBar has been renamed as BrowserSearchBox, because in GTK GtkSearchBar is
2065         final class, so we derive from GtkBox and to be used as contents of a GtkSearchBar.
2066
2067         * MiniBrowser/gtk/BrowserCellRendererVariant.c:
2068         (browserCellRendererVariantCellRendererSnapshot):
2069         (browser_cell_renderer_variant_class_init):
2070         * MiniBrowser/gtk/BrowserCellRendererVariant.h:
2071         * MiniBrowser/gtk/BrowserSearchBar.c: Removed.
2072         * MiniBrowser/gtk/BrowserSearchBox.c: Added.
2073         (setFailedStyleForEntry):
2074         (doSearch):
2075         (searchNext):
2076         (searchPrevious):
2077         (searchEntryMenuIconPressedCallback):
2078         (searchEntryClearIconReleasedCallback):
2079         (searchEntryChangedCallback):
2080         (searchEntryActivatedCallback):
2081         (searchPreviousButtonCallback):
2082         (searchNextButtonCallback):
2083         (searchMenuCheckButtonToggledCallback):
2084         (findControllerFailedToFindTextCallback):
2085         (findControllerFoundTextCallback):
2086         (browserSearchBoxFinalize):
2087         (browserSearchBoxDispose):
2088         (browserSearchBoxSizeAllocate):
2089         (browser_search_box_class_init):
2090         (browser_search_box_new):
2091         (browser_search_box_get_entry):
2092         * MiniBrowser/gtk/BrowserSearchBox.h: Renamed from Tools/MiniBrowser/gtk/BrowserSearchBar.h.
2093         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2094         (browser_settings_dialog_init):
2095         (browser_settings_dialog_new):
2096         * MiniBrowser/gtk/BrowserSettingsDialog.h:
2097         * MiniBrowser/gtk/BrowserTab.c:
2098         (loadChanged):
2099         (createInfoBarQuestionMessage):
2100         (tlsErrorsDialogResponse):
2101         (loadFailedWithTLSerrors):
2102         (permissionRequestDialogResponse):
2103         (decidePermissionRequest):
2104         (colorChooserRequestFinished):
2105         (runColorChooserCallback):
2106         (tabCloseClicked):
2107         (browserTabConstructed):
2108         (browserTabIsSearchBarOpen):
2109         (browser_tab_start_search):
2110         (browser_tab_stop_search):
2111         (browser_tab_enter_fullscreen):
2112         (browser_tab_leave_fullscreen):
2113         * MiniBrowser/gtk/BrowserWindow.c:
2114         (settingsCallback):
2115         (resetEntryProgress):
2116         (webViewLoadProgressChanged):
2117         (browserWindowCreateBackForwardMenu):
2118         (browserWindowUpdateNavigationMenu):
2119         (navigationButtonPressed):
2120         (navigationButtonPressCallback):
2121         (scrollEventCallback):
2122         (webViewIsLoadingChanged):
2123         (searchCallback):
2124         (insertImageDialogResponse):
2125         (insertImageCommandCallback):
2126         (insertLinkDialogResponse):
2127         (insertLinkCommandCallback):
2128         (typingAttributesChanged):
2129         (browserWindowSaveSession):
2130         (browserWindowFinalize):
2131         (browserWindowDispose):
2132         (addToolbarButton):
2133         (browserWindowSwitchTab):
2134         (browserWindowTabAddedOrRemoved):
2135         (browserWindowBuildPopoverMenu):
2136         (browserWindowCloseRequest):
2137         (browserWindowDeleteEvent):
2138         (browser_window_class_init):
2139         (browser_window_append_view):
2140         (browser_window_set_background_color):
2141         * MiniBrowser/gtk/CMakeLists.txt:
2142
2143 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2144
2145         [GTK] MiniBrowser: stop using GtkToolbar
2146         https://bugs.webkit.org/show_bug.cgi?id=212898
2147
2148         Reviewed by Adrian Perez de Castro.
2149
2150         GtkToolbar iss no longer available in GTK4, use a GtkBox with buttons instead. Also use symbolic icons and move
2151         some of the actions to a gear menu.
2152
2153         * MiniBrowser/gtk/BrowserWindow.c:
2154         (browserWindowHistoryItemActivated):
2155         (browserWindowCreateBackForwardMenu):
2156         (browserWindowUpdateNavigationMenu):
2157         (navigationButtonPressCallback):
2158         (browserWindowCanZoomDefault):
2159         (browserWindowUpdateZoomActions):
2160         (webViewIsLoadingChanged):
2161         (addToolbarButton):
2162         (browserWindowBuildPopoverMenu):
2163         (resetStatusText): Deleted.
2164         (browserWindowHistoryItemSelected): Deleted.
2165         (browserWindowSetupEditorToolbarItem): Deleted.
2166
2167 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2168
2169         [GTK] MiniBrowser: stop using GtkToolbar for the search bar
2170         https://bugs.webkit.org/show_bug.cgi?id=212817
2171
2172         Reviewed by Adrian Perez de Castro.
2173
2174         Use a GtkSearchBar instead, because GtkToolbar is no longer available in GTK4. Also use a GtkPopover for the
2175         options menu instead of the GtkMenu.
2176
2177         * MiniBrowser/gtk/BrowserSearchBar.c:
2178         (setFailedStyleForEntry):
2179         (doSearch):
2180         (searchEntryMenuIconPressedCallback):
2181         (searchEntryChangedCallback):
2182         (searchMenuCheckButtonToggledCallback):
2183         (browserSearchBarFinalize):
2184         (browser_search_bar_new):
2185         (browser_search_bar_open):
2186         (browser_search_bar_close):
2187         (browser_search_bar_is_open):
2188         (searchCloseButtonClickedCallback): Deleted.
2189         (searchEntryClearIconReleasedCallback): Deleted.
2190         * MiniBrowser/gtk/BrowserSearchBar.h:
2191         * MiniBrowser/gtk/BrowserTab.c:
2192         (browser_tab_start_search):
2193         (browser_tab_stop_search):
2194
2195 2020-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2196
2197         [GTK4] Make WebDriver work
2198         https://bugs.webkit.org/show_bug.cgi?id=212316
2199
2200         Reviewed by Adrian Perez de Castro.
2201
2202         Stop connecting to WebKitWebView::close signal twice for newaly created windows.
2203
2204         * MiniBrowser/gtk/BrowserWindow.c:
2205         (webViewCreate):
2206
2207 2020-06-11  Saam Barati  <sbarati@apple.com>
2208
2209         Skip wasm-js2 test on memory limited devices
2210         https://bugs.webkit.org/show_bug.cgi?id=213099
2211
2212         Reviewed by Yusuke Suzuki.
2213
2214         * Scripts/run-jsc-stress-tests:
2215
2216 2020-06-11  Alex Christensen  <achristensen@webkit.org>
2217
2218         Re-enable download resume tests
2219         https://bugs.webkit.org/show_bug.cgi?id=213098
2220         <rdar://problem/63512518>
2221
2222         Reviewed by Geoffrey Garen.
2223
2224         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2225
2226 2020-06-11  Commit Queue  <commit-queue@webkit.org>
2227
2228         Unreviewed, reverting r262696.
2229         https://bugs.webkit.org/show_bug.cgi?id=213097
2230
2231         It broke running JSC tests on watchOS
2232
2233         Reverted changeset:
2234
2235         "Allow run-jsc-stress-tests still run if some of the remote
2236         hosts are not available"
2237         https://bugs.webkit.org/show_bug.cgi?id=201426
2238         https://trac.webkit.org/changeset/262696
2239
2240 2020-06-11  Sihui Liu  <sihui_liu@apple.com>
2241
2242         REGRESSION (r262879): 3 TestWebKitAPI.TextManipulation tests are failing
2243         https://bugs.webkit.org/show_bug.cgi?id=213079
2244         <rdar://problem/64256870>
2245
2246         Reviewed by Wenson Hsieh.
2247
2248         Update a few tests after behavior change in r262879. From r262879, we no longer use visible positions of element
2249         to calculate range to observe. Instead, we use the first and end position in the element to decide the range. In
2250         previous implementation, the range can be extended to outside of the element, like some visible positon before 
2251         or after the element.
2252
2253         TextManipulation.StartTextManipulationFindNewlyDisplayedParagraph: Different elements would make separate ranges 
2254         because we create range with the boundaries of element. We can consider merging adjacent ranges later.
2255         TextManipulation.StartTextManipulationFindSameParagraphWithNewContent: The newly observing range only includes
2256         the newly inserted element now.
2257         TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem: The p element
2258         is not manipulated as it is the common ancestor of manipulated elements. And we want to make sure the newly
2259         inserted element is child of a manipulated element.
2260
2261         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2262         (TestWebKitAPI::TEST):
2263
2264 2020-06-11  Andy Estes  <aestes@apple.com>
2265
2266         [iOS] nullptr deref in FileInputType::iconLoaded when the input's type attribute is modified by a change event listener
2267         https://bugs.webkit.org/show_bug.cgi?id=208244
2268         <rdar://problem/41855350>
2269
2270         Reviewed by Wenson Hsieh.
2271
2272         * DumpRenderTree/TestRunner.cpp:
2273         (SetOpenPanelFilesMediaIconCallback):
2274         (TestRunner::staticFunctions):
2275         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2276         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2277
2278 2020-06-11  Sergio Villar Senin  <svillar@igalia.com>
2279
2280         Unreviewed, updated libsoup dependency in jhbuild.
2281
2282         * wpe/jhbuild.modules:
2283
2284 2020-06-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2285
2286         [macOS]: The File Picker of the <input> file element should show the selection filter
2287         https://bugs.webkit.org/show_bug.cgi?id=212485
2288
2289         Reviewed by Darin Adler.
2290
2291         Create a view with an NSPopupButton for the file extensions filter. Set
2292         this view as the AccessoryView of the OpenPanel. Create a customized target
2293         for the NSPopupButton to respond to changing its selection.
2294
2295         * MiniBrowser/mac/WK2BrowserWindowController.m:
2296         (-[FileExtensionsPopupTarget initWithOpenPanel:allowedFileExtensions:]):
2297         (-[FileExtensionsPopupTarget popupAction:]):
2298         (-[FileExtensionsPopupTarget dealloc]):
2299         (-[WK2BrowserWindowController dealloc]):
2300         (-[WK2BrowserWindowController createFilterView:popupTarget:]):
2301         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2302
2303 2020-06-10  Jonathan Bedard  <jbedard@apple.com>
2304
2305         Generalize configure-xcode-for-ios-development (Part 2)
2306         https://bugs.webkit.org/show_bug.cgi?id=207043
2307         <rdar://problem/63946933>
2308
2309         Reviewed by Darin Adler.
2310
2311         * EWSTools/start-queue-mac.sh: Use configure-xcode-for-embedded-development over configure-xcode-for-ios-development.
2312         * Scripts/configure-xcode-for-ios-development: Removed.
2313
2314 2020-06-10  Sihui Liu  <sihui_liu@apple.com>
2315
2316         Text manipulation does not observe inserted elements that are invisible
2317         https://bugs.webkit.org/show_bug.cgi?id=213057
2318         <rdar://problem/63768253>
2319
2320         Reviewed by Wenson Hsieh.
2321
2322         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2323         (TestWebKitAPI::TEST):
2324
2325 2020-06-10  Geoffrey Garen  <ggaren@apple.com>
2326
2327         Some style improvements to main thread code
2328         https://bugs.webkit.org/show_bug.cgi?id=213051
2329
2330         Reviewed by Darin Adler.
2331
2332         Updated for rename.
2333         
2334         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2335         (TestWebKitAPI::TEST):
2336         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2337         (TestWebKitAPI::TEST):
2338         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2339         (TestWebKitAPI::TEST):
2340         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2341         (ApplicationManifestParserTest::SetUp):
2342         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2343         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2344         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2345         (TestWebKitAPI::ContentExtensionTest::SetUp):
2346         * TestWebKitAPI/Tests/WebCore/DNS.cpp:
2347         (TestWebKitAPI::TEST):
2348         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2349         (TestWebKitAPI::TEST_F):
2350         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2351         (initializeInAppBrowserPrivacyTestSettings):
2352         * WebKitTestRunner/TestController.cpp:
2353         (WTR::TestController::initialize):
2354
2355 2020-06-10  Jonathan Bedard  <jbedard@apple.com>
2356
2357         results.webkit.org: Health check should access redis and Cassandra
2358         https://bugs.webkit.org/show_bug.cgi?id=212899
2359         <rdar://problem/64118077>
2360
2361         Reviewed by Stephanie Lewis.
2362
2363         * resultsdbpy/resultsdbpy/example/main.py:
2364         (health): Check the health status of the model.
2365         * resultsdbpy/resultsdbpy/model/model.py:
2366         (Model.HealthTable):
2367         (Model.__init__): Construct a Cassandra table used to check the health of our Cassandra connection.
2368         (Model.healthy): Make both a read and write connection to our two database dependencies so that if
2369         our connection to those databases fails, an instance will be forced to restart.
2370         * resultsdbpy/resultsdbpy/model/model_unittest.py: Added.
2371         (ModelTest):
2372         (ModelTest.init_database):
2373         (ModelTest.test_health):
2374
2375 2020-06-10  Keith Miller  <keith_miller@apple.com>
2376
2377         run-jsc-stress-tests should skip tests marked as slow in quick mode.
2378         https://bugs.webkit.org/show_bug.cgi?id=213042
2379
2380         Reviewed by Yusuke Suzuki.
2381
2382         * Scripts/run-jsc-stress-tests:
2383
2384 2020-06-10  Antoine Quint  <graouts@webkit.org>
2385
2386         Subframes should not autosize independently
2387         https://bugs.webkit.org/show_bug.cgi?id=212984
2388         <rdar://problem/64175493>
2389
2390         Reviewed by Simon Fraser.
2391
2392         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2393         (TEST): Added test for <object>.
2394
2395 2020-06-09  Ryan Haddad  <ryanhaddad@apple.com>
2396
2397         [Mojave] Flaky API Test: TestWebKitAPI.WebKitLegacy.CrossPartitionFileSchemeAccess
2398         https://bugs.webkit.org/show_bug.cgi?id=206956
2399
2400         Unreviewed test gardening.
2401
2402         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Disable this test for Mojave.
2403
2404 2020-06-10  Alex Christensen  <achristensen@webkit.org>
2405
2406         Revert r259770
2407         https://bugs.webkit.org/show_bug.cgi?id=210097
2408         <rdar://problem/64175992>
2409
2410         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2411         (TEST):
2412
2413 2020-06-10  Commit Queue  <commit-queue@webkit.org>
2414
2415         Unreviewed, reverting r262807.
2416         https://bugs.webkit.org/show_bug.cgi?id=213019
2417
2418         It is breaking JSC queues (Requested by caiolima on #webkit).
2419
2420         Reverted changeset:
2421
2422         "Add a timeout monitor for JSC stress test"
2423         https://bugs.webkit.org/show_bug.cgi?id=211978
2424         https://trac.webkit.org/changeset/262807
2425
2426 2020-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2427
2428         Unreviewed, reverting r262791.
2429
2430         WinCairo WebKit1 is crashing.
2431
2432         Reverted changeset:
2433
2434         "[Curl] Implement functions to use ResourceLoadStatistics."
2435         https://bugs.webkit.org/show_bug.cgi?id=207692
2436         https://trac.webkit.org/changeset/262791
2437
2438 2020-06-09  Zhifei Fang  <zhifei_fang@apple.com>
2439
2440         Add a timeout monitor for JSC stress test
2441         https://bugs.webkit.org/show_bug.cgi?id=211978
2442
2443         Reviewed by Jonathan Bedard.
2444
2445         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Add timeout monitor inside the jsc stress test runner, it will kill the process in case of jsc timeout handler not working
2446
2447 2020-06-09  Tim Horton  <timothy_horton@apple.com>
2448
2449         WebKit.ShrinkToFit is failing on some bots
2450         https://bugs.webkit.org/show_bug.cgi?id=212932
2451         <rdar://problem/60972407>
2452
2453         Reviewed by Simon Fraser.
2454
2455         TestWebKitAPI was failing to stabilize the overlay scrollbar preference,
2456         because the only stabilization attempt was in the injected bundle 
2457         initialization code, and most tests (including ShrinkToFit) do not have
2458         an injected bundle.
2459
2460         Because this preference is manually propagated to the Web Content process,
2461         we can set the default in the volatile domain in the UI process at startup.
2462
2463         We can't move other preferences yet, because they are not manually propagated,
2464         and WebKit's NSUserDefault synchronization mechanism ignores defaults in the
2465         volatile domain (and the initial preference load reads from disk, not
2466         from the UI process, so it wouldn't find them anyway).
2467
2468         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2469         (TEST):
2470         Explain why the final value of the test is different than the starting value.
2471
2472         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2473         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2474         Leave a FIXME for future generations.
2475
2476         * TestWebKitAPI/mac/mainMac.mm:
2477         (main):
2478         Override overlay scrollbar preferences in the UI process, so it affects all tests.
2479
2480         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2481         This test is also affected by using non-overlay scrollbars; we now have less space, so take up more pages.
2482
2483 2020-06-09  Youenn Fablet  <youenn@apple.com>
2484
2485         BaseAudioSharedUnit should unmute its clients in case of suspension even if not having any audio unit
2486         https://bugs.webkit.org/show_bug.cgi?id=212970
2487
2488         Reviewed by Eric Carlson.
2489
2490         Add an option to capture in UI process so that the same test can run on both MacOS and iOS.
2491         This eases the testing infra to be able to get audio capture unit state in WebProcess as is the case in iOS.
2492
2493         * WebKitTestRunner/TestController.cpp:
2494         (WTR::TestController::resetPreferencesToConsistentValues):
2495         (WTR::updateTestOptionsFromTestHeader):
2496         * WebKitTestRunner/TestOptions.h:
2497         (WTR::TestOptions::hasSameInitializationOptions const):
2498
2499 2020-06-09  Takashi Komori  <Takashi.Komori@sony.com>
2500
2501         [Curl] Implement functions to use ResourceLoadStatistics.
2502         https://bugs.webkit.org/show_bug.cgi?id=207692
2503
2504         Implement functions which are required to implement ResourceLoadStatistics for Curl port.
2505
2506         Tests: http/tests/resourceLoadStatistics/
2507
2508         Reviewed by Don Olmstead.
2509
2510         * WebKitTestRunner/TestController.cpp:
2511         (WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext):
2512         (WTR::getAllStorageAccessEntriesCallback):
2513         (WTR::TestController::getAllStorageAccessEntries):
2514
2515 2020-06-09  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2516
2517         [Flatpak][GStreamer] enhance GST_ environment variable passing
2518         https://bugs.webkit.org/show_bug.cgi?id=212905
2519
2520         Reviewed by Philippe Normand.
2521
2522         Handle the passing of several GST environment variables,
2523         particularly GST_DEBUG, which, when using * symbol, python adds
2524         quotes, but they break the parsing in GStreamer.
2525
2526         Also the variables are handled by gst-env.py when using
2527         GST_BUILD_PATH, so they are filtered out when it's exported,
2528         avoiding duplication. But it GST_BUILD_PATH is not defined, the
2529         variables are passed to flatpak.
2530
2531         * flatpak/flatpakutils.py:
2532         (WebkitFlatpak.setup_gstbuild):
2533         (WebkitFlatpak.run_in_sandbox):
2534
2535 2020-06-09  Sihui Liu  <sihui_liu@apple.com>
2536
2537         TextManipulationController range of paragraph may be wrong after r262601
2538         https://bugs.webkit.org/show_bug.cgi?id=212874
2539
2540         Reviewed by Wenson Hsieh.
2541
2542         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2543         (TestWebKitAPI::TEST):
2544
2545 2020-06-08  Sihui Liu  <sihui_liu@apple.com>
2546
2547         TextManipulation should only convert text from Node's text content to tokens
2548         https://bugs.webkit.org/show_bug.cgi?id=212928
2549
2550         Reviewed by Wenson Hsieh.
2551
2552         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2553         (TestWebKitAPI::TEST):
2554
2555 2020-06-08  Diego Pino Garcia  <dpino@igalia.com>
2556
2557         [webkitpy] Check 'bug-search' returns a non null result before parsing
2558         https://bugs.webkit.org/show_bug.cgi?id=212906
2559
2560         Reviewed by Jonathan Bedard.
2561
2562         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2563         (BugzillaQueries._parse_result_count): Check quick-search query
2564         response is non-null and a non-empty text.
2565
2566 2020-06-08  Sam Weinig  <weinig@apple.com>
2567
2568         Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()
2569         https://bugs.webkit.org/show_bug.cgi?id=212917
2570
2571         Reviewed by Darin Adler.
2572
2573         Addresses feedback from Darin.
2574
2575         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2576         (TestWebKitAPI::TEST):
2577
2578 2020-06-08  Sam Weinig  <weinig@apple.com>
2579
2580         Fix test results after r262733.
2581
2582         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2583         (TestWebKitAPI::TEST):
2584
2585 2020-06-08  David Kilzer  <ddkilzer@apple.com>
2586
2587         [IPC] Adopt enum class for DragOperation
2588         <https://webkit.org/b/212870>
2589         <rdar://problem/64069940>
2590
2591         Reviewed by Darin Adler.
2592
2593         * Scripts/do-webcore-rename:
2594         - Do DragOperation renames.
2595
2596 2020-06-08  Commit Queue  <commit-queue@webkit.org>
2597
2598         Unreviewed, reverting r262685.
2599         https://bugs.webkit.org/show_bug.cgi?id=212914
2600
2601         caused flakey crashes in an iOS test
2602
2603         Reverted changeset:
2604
2605         "Clear WebPageProxy event state between tests"
2606         https://bugs.webkit.org/show_bug.cgi?id=212864
2607         https://trac.webkit.org/changeset/262685
2608
2609 2020-06-08  Sam Weinig  <weinig@apple.com>
2610
2611         Extended Color: Unify rounding / clamping conversions between 0-1 float components and 0-255 byte components
2612         https://bugs.webkit.org/show_bug.cgi?id=212871
2613
2614         Reviewed by Simon Fraser.
2615
2616         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2617         (TestWebKitAPI::TEST):
2618         Switch to using makeSimpleColor(hslToSRGB(...)) directly.
2619
2620 2020-06-08  Sam Weinig  <weinig@apple.com>
2621
2622         Extended Color: Replace uses of differenceSquared() with luminance based computations
2623         https://bugs.webkit.org/show_bug.cgi?id=212872
2624
2625         Reviewed by Darin Adler.
2626
2627         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
2628         (TestWebKitAPI::TEST):
2629         Add basic tests for Color::luminance(), ensuring white == 1, black == 0, and 
2630         darken() and lighten() creat colors with less than / greater than luminance.
2631
2632 2020-06-08  Per Arne Vollan  <pvollan@apple.com>
2633
2634         [Cocoa] CFPrefs synchronization does not always work for global preference changes
2635         https://bugs.webkit.org/show_bug.cgi?id=212783
2636
2637         Reviewed by Tim Horton.
2638
2639         Add API test, and add some synchronization to avoid flakiness.
2640
2641         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
2642         (-[WKTestPreferenceObserver preferenceDidChange:key:encodedValue:]):
2643         (TEST):
2644         (sharedInstanceMethodOverride):
2645
2646 2020-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2647
2648         [iOS] Hit-testing on icloud.com is offset after closing a tab
2649         https://bugs.webkit.org/show_bug.cgi?id=212890
2650         <rdar://problem/58775297>
2651
2652         Reviewed by Simon Fraser.
2653
2654         Add a new API test to verify that the scroll position doesn't get stuck at -30px after shifting both the top
2655         content inset and top obscured inset by 30px. See WebKit ChangeLog for more details.
2656
2657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2658         * TestWebKitAPI/Tests/WebKitCocoa/overflow-hidden.html: Added.
2659         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2660         (-[ScrollViewDelegate scrollViewDidScroll:]):
2661         (TestWebKitAPI::TEST):
2662         * TestWebKitAPI/ios/UIKitSPI.h:
2663
2664 2020-06-08  Philippe Normand  <pnormand@igalia.com>
2665
2666         [Flatpak SDK] Add flatpak-run-nightly
2667         https://bugs.webkit.org/show_bug.cgi?id=212882
2668
2669         Reviewed by Carlos Alberto Lopez Perez.
2670
2671         This new script is able to download WPE and GTK builds from the Igalia servers and run the
2672         corresponding binaries (like MiniBrowser, jsc) within the Flatpak SDK.
2673
2674         Unzipped builds will be saved in /tmp and can be reused in further runs (by providing the
2675         path with the -p argument).
2676
2677         Example:
2678         $ webkit-flatpak-run-nightly --wpe MiniBrowser https://webkit.org
2679         <SDK installs to ~/.cache/wk-nightly>
2680         Downloading build release_r262699_b33885.zip from https://wpewebkit-release.igalia.com/built-products/
2681         Extracting build to /tmp/wpewebkit-release-b33885
2682         <MiniBrowser starts>
2683
2684         $ webkit-flatpak-run-nightly --wpe -p /tmp/wpewebkit-release-b33885 jsc
2685         Looking for updates…
2686         Nothing to do.
2687         >>> 2+2
2688         4
2689
2690         * Scripts/webkit-flatpak-run-nightly: Added.
2691
2692 2020-06-08  Diego Pino Garcia  <dpino@igalia.com>
2693
2694         [webkitpy] Make 'webkit-path rebaseline' to not update expectations file by default
2695         https://bugs.webkit.org/show_bug.cgi?id=212835
2696
2697         Reviewed by Carlos Alberto Lopez Perez.
2698
2699         `webkit-patch rebaseline` let us add or update a test baseline
2700         from a test bot. By default, the command also updates the
2701         corresponding expectations file. This update is actually a brand-new
2702         generation of an expectations file based on the results of the bot,
2703         which in most cases messes up the current contents of the file.
2704
2705         This patch makes the default to not update the expectations file and
2706         adds a new option '--update-expectations' to explicitly request an
2707         update.
2708
2709         * Scripts/webkitpy/tool/commands/rebaseline.py:
2710         (AbstractRebaseliningCommand):
2711         (RebaselineTest.__init__):
2712         (RebaselineTest._rebaseline_tests):
2713         (RebaselineTest.execute):
2714         (AbstractParallelRebaselineCommand._rebaseline_commands):
2715         (RebaselineExpectations.__init__):
2716         (RebaselineExpectations.execute):
2717         (Rebaseline.__init__):
2718         (RebaselineTest._rebaseline_test_and_update_expectations): Deleted.
2719         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2720         (TestRebaselineTest.setUp):
2721
2722 2020-06-08  Youenn Fablet  <youenn@apple.com>
2723
2724         File URLs with hostnames are misleading
2725         https://bugs.webkit.org/show_bug.cgi?id=212739
2726         <rdar://problem/63754917>
2727
2728         Reviewed by Alex Christensen.
2729
2730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2731         * TestWebKitAPI/Tests/WebKit/open-window-with-file-url-with-host.html: Added.
2732         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2733         (TEST):
2734
2735 2020-06-07  Caio Lima  <ticaiolima@gmail.com>
2736
2737         Allow run-jsc-stress-tests still run if some of the remote hosts are not available
2738         https://bugs.webkit.org/show_bug.cgi?id=201426
2739
2740         Reviewed by Saam Barati.
2741
2742         This patch allows run-jsc-stress-tests to keep on running if some of
2743         the remote hosts are not available. To do this, we created a new
2744         function `checkAndPrepareRemoteHosts` that is responsible to check the
2745         connection and read/write permissions of given remote hosts list. It
2746         filters out every unavailable remote host.
2747         These checks and filter happen in the beginning of the script and is
2748         excuted only once, in the beggining of the script. It means that if
2749         some remote device becomes unavailable after the check and preparation
2750         is done, the script execution will be interupted.
2751
2752         * Scripts/run-jsc-stress-tests:
2753
2754 2020-06-07  Philippe Normand  <pnormand@igalia.com>
2755
2756         Remove ENABLE_VIDEO_TRACK ifdef guards
2757         https://bugs.webkit.org/show_bug.cgi?id=212568
2758
2759         Reviewed by Youenn Fablet.
2760
2761         * Scripts/webkitperl/FeatureList.pm:
2762         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2763
2764 2020-06-06  Simon Fraser  <simon.fraser@apple.com>
2765
2766         Clear WebPageProxy event state between tests
2767         https://bugs.webkit.org/show_bug.cgi?id=212864
2768
2769         Reviewed by Anders Carlsson.
2770
2771         Make sure that event state doesn't leak between tests via events queued in WebPageProxy.
2772
2773         * WebKitTestRunner/TestController.cpp:
2774         (WTR::TestController::resetStateToConsistentValues):
2775
2776 2020-06-06  Peng Liu  <peng.liu6@apple.com>
2777
2778         REGRESSION (r262456): [iOS Debug] TestWebKitAPI.WKWebViewCloseAllMediaPresentations.PictureInPicture is frequently timing out
2779         https://bugs.webkit.org/show_bug.cgi?id=212777
2780
2781         Unreviewed test gardening.
2782
2783         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2784         Disable the PictureInPicture test for old iOS devices.
2785
2786 2020-06-05  Ryan Haddad  <ryanhaddad@apple.com>
2787
2788         [iOS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2789         https://bugs.webkit.org/show_bug.cgi?id=208451
2790
2791         Unreviewed test gardening.
2792
2793         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable this test again because it is still failing on certain bots.
2794
2795 2020-06-05  Daniel Bates  <dabates@apple.com>
2796
2797         -_focusTextInputContext should reposition the caret if called for an already focused text input context
2798         https://bugs.webkit.org/show_bug.cgi?id=212830
2799         <rdar://problem/64032956>
2800
2801         Reviewed by Wenson Hsieh.
2802
2803         Re-purpose some existing tests to check for the new behavior.
2804
2805         In TextInteraction_FocusingAssistedElementShouldScrollToReveal, keep in mind that the caret position is
2806         changing: on iOS, calling input.focus() places the caret at the end of the field's content.
2807
2808         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2809         (TestWebKitAPI::TEST):
2810
2811 2020-06-05  Jonathan Bedard  <jbedard@apple.com>
2812
2813         Generalize configure-xcode-for-ios-development (Part 1)
2814         https://bugs.webkit.org/show_bug.cgi?id=207043
2815
2816         Rubber-stamped by David Kilzer.
2817
2818         Patch by Keith Rollin and Jonathan Bedard.
2819
2820         Replace configure-xcode-for-ios-development with a Python script that works for iOS,
2821         watchOS and tvOS.
2822
2823         * Scripts/configure-xcode-for-embedded-development: Added.
2824
2825 2020-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2826
2827         Text manipulation should exclude characters outside of the unicode private use area
2828         https://bugs.webkit.org/show_bug.cgi?id=212800
2829         <rdar://problem/63736417>
2830
2831         Reviewed by Sihui Liu.
2832
2833         Add a new API test to verify the new behavior when extracting PUA characters.
2834
2835         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2836         (TestWebKitAPI::TEST):
2837
2838 2020-06-05  Dean Jackson  <dino@apple.com>
2839
2840         REGRESSION (r262366): [ Mac wk1 ] webgl/webgl-backing-store-size-update.html is failing
2841         https://bugs.webkit.org/show_bug.cgi?id=212647
2842         <rdar://problem/63882960>
2843
2844         Reviewed by Eric Carlson.
2845
2846         Drive-by comment from Simon. Remove some useless braces.
2847
2848         * TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm:
2849
2850 2020-06-05  Saam Barati  <sbarati@apple.com>
2851
2852         Try to reduce jetsams further on iOS devices running jsc stress tests
2853         https://bugs.webkit.org/show_bug.cgi?id=212786
2854
2855         Reviewed by Mark Lam.
2856
2857         * Scripts/run-jsc-stress-tests:
2858
2859 2020-06-05  Peng Liu  <peng.liu6@apple.com>
2860
2861         REGRESSION (r262456?): [macOS] media/picture-in-picture/picture-in-picture-api tests are flaky timeouts
2862         https://bugs.webkit.org/show_bug.cgi?id=212762
2863
2864         Reviewed by Eric Carlson.
2865
2866         Skip the Picture-in-Picture test if Picture-in-Picture is not supported and add playsinline attribute
2867         to the video element.
2868
2869         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2870         (TEST):
2871
2872 2020-06-05  Andy Estes  <aestes@apple.com>
2873
2874         [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
2875         https://bugs.webkit.org/show_bug.cgi?id=212541
2876         <rdar://problem/63781452>
2877
2878         Reviewed by Darin Adler.
2879
2880         APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
2881
2882         * Scripts/webkitperl/FeatureList.pm:
2883         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2884
2885 2020-06-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2886
2887         [GTK] MiniBrowser: use GAction API for actions and shortcuts in preparation for GTK4
2888         https://bugs.webkit.org/show_bug.cgi?id=212740
2889
2890         Reviewed by Adrian Perez de Castro.
2891
2892         Make MiniBrowser a GtkApplication and BrowserWindow a GtkApplicationWindow to easily install actions and shortcuts.
2893
2894         * MiniBrowser/gtk/BrowserMain.c: Removed.
2895         * MiniBrowser/gtk/BrowserMain.h: Removed.
2896         * MiniBrowser/gtk/BrowserSearchBar.c:
2897         (searchPreviousButtonCallback):
2898         (searchNextButtonCallback):
2899         * MiniBrowser/gtk/BrowserSearchBar.h:
2900         * MiniBrowser/gtk/BrowserTab.c:
2901         * MiniBrowser/gtk/BrowserTab.h:
2902         * MiniBrowser/gtk/BrowserWindow.c:
2903         (reloadOrStopCallback):
2904         (goBackCallback):
2905         (goForwardCallback):
2906         (settingsCallback):
2907         (browserWindowUpdateNavigationMenu):
2908         (browserWindowTryCloseCurrentWebView):
2909         (browserWindowTryClose):
2910         (webViewCreate):
2911         (browserWindowUpdateZoomActions):
2912         (webViewZoomLevelChanged):
2913         (zoomInCallback):
2914         (zoomOutCallback):
2915         (defaultZoomCallback):
2916         (searchCallback):
2917         (newTabCallback):
2918         (toggleWebInspector):
2919         (openPrivateWindow):
2920         (focusLocationBar):
2921         (reloadPage):
2922         (reloadPageIgnoringCache):
2923         (stopPageLoad):
2924         (loadHomePage):
2925         (toggleFullScreen):
2926         (printPage):
2927         (editingActionCallback):
2928         (typingAttributesChanged):
2929         (browserWindowFinalize):
2930         (browserWindowSetupEditorToolbarItem):
2931         (browserWindowSetupToolbarItem):
2932         (browserWindowDeleteEvent):
2933         (browser_window_new):
2934         (browser_window_append_view):
2935         (browser_window_get_or_create_web_view_for_automation):
2936         (browser_window_create_web_view_in_new_tab_for_automation):
2937         * MiniBrowser/gtk/BrowserWindow.h:
2938         * MiniBrowser/gtk/CMakeLists.txt:
2939         * MiniBrowser/gtk/main.c:
2940         (createWebViewForAutomationInWindowCallback):
2941         (createWebViewForAutomationInTabCallback):
2942         (automationStartedCallback):
2943         (startup):
2944         (activate):
2945         (main):
2946
2947 2020-06-04  Sihui Liu  <sihui_liu@apple.com>
2948
2949         Text manipulation: first and last unit in a paragraph should not contain only excluded tokens
2950         https://bugs.webkit.org/show_bug.cgi?id=212759
2951
2952         Reviewed by Wenson Hsieh.
2953
2954         Modify existing test for changed behavior that leading and trailing excluded units are not included in paragraph
2955         now.
2956
2957         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2958         (TestWebKitAPI::TEST):
2959
2960 2020-06-04  Chris Dumez  <cdumez@apple.com>
2961
2962         UIProcess may crash after its prewarmed WebProcess gets terminated
2963         https://bugs.webkit.org/show_bug.cgi?id=212790
2964         <rdar://problem/63696191>
2965
2966         Reviewed by Geoffrey Garen.
2967
2968         Add API test coverage.
2969
2970         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2971         (TEST):
2972
2973 2020-06-04  Sihui Liu  <sihui_liu@apple.com>
2974
2975         REGRESSION: (r262398) Text manipulation crashes when content is added
2976         https://bugs.webkit.org/show_bug.cgi?id=212785
2977
2978         Reviewed by Ryosuke Niwa.
2979
2980         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2981         (TestWebKitAPI::TEST):
2982
2983 2020-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2984
2985         Improve watchlist logic for comments on patches touching imported WPT tests.
2986         https://bugs.webkit.org/show_bug.cgi?id=212597
2987
2988         Reviewed by Youenn Fablet.
2989
2990         On r262295 I added a watchlist comment for patches touching the imported WPT tests.
2991         However, this is commenting on patches that are importing WPT tests.
2992
2993         To avoid this situations, this patch adds a new rule to detect if the changes modify
2994         any of the w3c-import.log files, and then changes the logic to make the comment only
2995         for patches that modify the WPT imported tests but not the w3c-import.log files.
2996
2997         In order to support this new logic, watchlist rule parsing is improved to support
2998         the "and" and "not" operators. Previously it only supported the "or" operator.
2999
3000         * Scripts/webkitpy/common/config/watchlist:
3001         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
3002         (WatchListParser._rule_definitions_as_set):
3003         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
3004         (WatchListParserTest.test_cc_rule_with_undefined_defintion_with_suggestion):
3005         (WatchListParserTest):
3006         (WatchListParserTest.test_cc_rule_with_complex_logic):
3007         * Scripts/webkitpy/common/watchlist/watchlistrule.py:
3008         (WatchListRule.__init__):
3009         (WatchListRule._match_test_definitions):
3010         (WatchListRule.match):
3011         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
3012         (WatchListRuleTest.test_complex_definition_or):
3013         (WatchListRuleTest):
3014         (WatchListRuleTest.test_complex_definition_and):
3015         (WatchListRuleTest.test_complex_definition_not):
3016         (WatchListRuleTest.test_complex_definition_combined):
3017
3018 2020-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3019
3020         svn-apply command is too slow with big patches
3021         https://bugs.webkit.org/show_bug.cgi?id=212766
3022
3023         Reviewed by Darin Adler.
3024
3025         The script svn-apply was calling a "git add" or "svn add" command
3026         after adding each new file. This caused the git or svn command to
3027         re-check the internal SCM database each time they were called, and
3028         this was really slow when lot of new files are added.
3029         Instead of doing this, we queue the list of new files in memory,
3030         and at the end we call "git add" or "svn add" once (or a few times).
3031
3032         On top of that, another optimization is added for the case of git,
3033         to avoid calling scmKnowsOfFile() inside addDirectoriesIfNeeded(),
3034         which is a slow operation and gets called a lot (once per file).
3035         Doing that for git is totally unneeded, as the only thing we have
3036         to take care about, is of ensuring that the directory is created.
3037         See: https://wkb.ug/86973
3038
3039         This reduces the time spent in the large test patch that caused
3040         this issue (see bug):
3041          - Git: 8 hours (before) -> 8 minutes (now).
3042          - SVN: 25 minutes (before) -> 5 minutes (now).
3043
3044         * Scripts/svn-apply:
3045         (addDirectoriesIfNeeded):
3046         (handleBinaryChange):
3047         (handleGitBinaryChange):
3048         (patch):
3049         (scmRemove):
3050         (scmAddQueued):
3051         (scmCommitQueueAdded):
3052         (scmToggleExecutableBitQueued):
3053         (scmCommitQueueToggledExecutableBit):
3054
3055 2020-06-04  Jonathan Bedard  <jbedard@apple.com>
3056
3057         Add watchOS and tvOS to build-webkit
3058         https://bugs.webkit.org/show_bug.cgi?id=212719
3059         <rdar://problem/63951600>
3060
3061         Reviewed by Tim Horton.
3062
3063         * Scripts/build-webkit: Add tvOS and watchOS flags, generalize embedded if statements.
3064         * Scripts/webkitdirs.pm:
3065         (determineArchitecture): Add tvOS and watchOS architectures.
3066         (argumentsForConfiguration): Add tvOS and watchOS flags.
3067         (extractNonMacOSHostConfiguration): Ditto.
3068
3069 2020-06-04  Tim Horton  <timothy_horton@apple.com>
3070
3071         Work around broken system version macro
3072         https://bugs.webkit.org/show_bug.cgi?id=212726
3073
3074         Reviewed by Dan Bernstein.
3075
3076         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3077         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3078         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
3079         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3080         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3081         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3082         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3083         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
3084
3085 2020-06-04  Andy Estes  <aestes@apple.com>
3086
3087         [watchOS] Re-enable content filtering in the simulator build
3088         https://bugs.webkit.org/show_bug.cgi?id=212711
3089         <rdar://problem/63938350>
3090
3091         Reviewed by Wenson Hsieh.
3092
3093         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3094
3095 2020-06-04  Philippe Normand  <pnormand@igalia.com>
3096
3097         [Flatpak SDK] Update definitions
3098         https://bugs.webkit.org/show_bug.cgi?id=212698
3099
3100         Reviewed by Žan Doberšek.
3101
3102         * buildstream/elements/freedesktop-sdk.bst: Update to FDO 19.08.11
3103         * buildstream/elements/sdk/gtk.bst: Update GTK4
3104         * buildstream/patches/fdo/0001-Pango-Bump-to-1.45-master.patch: Added. Needed for GTK4
3105         * buildstream/patches/fdo/0001-Add-Jack.patch: Removed. This will be used when we update to the 20.08 FDO SDK.
3106         * buildstream/patches/fdo/0001-components-xdg-desktop-portal.bst-Update-to-1.6.0.patch: Removed. Ditto.
3107         * buildstream/patches/fdo/0002-Update-PipeWire-to-0.3.1.patch: Removed. Ditto.
3108
3109 2020-06-03  Tadeu Zagallo  <tzagallo@apple.com>
3110
3111         Disable B3 hoistLoopInvariantValues by default
3112         https://bugs.webkit.org/show_bug.cgi?id=212511
3113         <rdar://problem/63813245>
3114
3115         Reviewed by Mark Lam.
3116
3117         Enable the B3 hoistLoopInvariantValues pass in one of our existing configurations to
3118         avoid bit rot since we'd like to re-enable it eventually.
3119
3120         * Scripts/run-jsc-stress-tests:
3121
3122 2020-06-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3123
3124         [Text manipulation] Extract the value attribute in inputs of type "text" and "search"
3125         https://bugs.webkit.org/show_bug.cgi?id=212706
3126         <rdar://problem/63876969>
3127
3128         Reviewed by Tim Horton.
3129
3130         Add a new test case (similar to the existing test `StartTextManipulationExtractsValuesFromButtonInputs`) to
3131         verify that we extract text from the `value` of inputs of type "text" and "search".
3132
3133         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3134         (TestWebKitAPI::TEST):
3135
3136 2020-06-03  Michael Saboff  <msaboff@apple.com>
3137
3138         [iOS] TestWTF.WTF_Lock.ContendedShortSection is consistently timing out on debug simulator builds
3139         https://bugs.webkit.org/show_bug.cgi?id=211650
3140
3141         Reviewed by Saam Barati.
3142
3143         The prior change to disable this test for Debug actually enabled it
3144         only for Debug IOS builds of any type, simulator or real HW.
3145
3146         This test has intermittently failed or timed out on Debug simulator
3147         builds for for almost a year.  We want to test Release builds as well as
3148         hardware builds. Therefore we should disable Debug simulator builds,
3149         and test all other variants.
3150
3151         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3152
3153 2020-06-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3154
3155         dataTransfer.types is empty when handling the "dragstart" event
3156         https://bugs.webkit.org/show_bug.cgi?id=212685
3157         <rdar://problem/61368402>
3158
3159         Reviewed by Andy Estes.
3160
3161         Adds new API tests and test infrastructure to verify that DataTransfer types and data are accessible during
3162         the "dragstart" event. See below for more details.
3163
3164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3165         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3166         (-[TestWKWebView selectElementWithID:]):
3167         (-[DragAndDropSimulator dragFromElementWithID:to:]):
3168
3169         Add a few (very specialized) helper methods to assist with simulating drags over the various elements in the new
3170         drag and drop test harness page below (dragstart-data.html).
3171
3172         (runDragStartDataTestCase):
3173
3174         Test the following scenarios (split between three API tests) by dumping the resulting DataTransfer types and
3175         their data strings, and observing the results:
3176
3177         - Dragging a normal text selection.
3178         - Dragging a normal text selection, and then adding a URL string.
3179         - Dragging a normal text selection, and then adding a custom pasteboard type.
3180         - Dragging a normal text selection, but then replacing the data with just a URL string.
3181         - Dragging a normal text selection, but then replacing the data with just a custom data type.
3182         - Dragging an image element.
3183         - Dragging an image element, and then overriding the plain text data.
3184         - Dragging a link (anchor element).
3185         - Dragging a link, and then adding a custom type.
3186
3187         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-data.html: Added.
3188
3189         Add a new test harness to help test DataTransfer types when starting a drag. This test page can also be used as
3190         a manual test harness, by simply opening the test page, starting drags on the various elements and observing the
3191         output in the textarea.
3192
3193         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
3194
3195         Tweak this test page to replace the DataTransfer with custom data (rather than simply append it) by calling
3196         `DataTransfer.clearData()` prior to writing the custom types.
3197
3198         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3199         * TestWebKitAPI/cocoa/TestWKWebView.h:
3200         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3201         (-[TestWKWebViewHostWindow initWithWebView:contentRect:styleMask:backing:defer:]):
3202
3203         Add a `__weak` reference on TestWKWebViewHostWindow back to the TestWKWebView, so that we can consult
3204         `-eventTimestamp` when synthesizing mouse events on macOS during API tests.
3205
3206         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
3207         (-[TestWKWebViewHostWindow _mouseUpAtPoint:clickCount:]):
3208         (-[TestWKWebViewHostWindow initWithWebView:frame:]):
3209         (-[TestWKWebView _setUpTestWindow:]):
3210         (-[TestWKWebView setEventTimestampOffset:]):
3211         (-[TestWKWebView eventTimestamp]):
3212
3213         Add a mechanism to offset synthetic event timestamps by a given time interval (i.e. the event timestamp offset).
3214
3215         (-[TestWKWebView mouseMoveToPoint:withFlags:]):
3216         (-[TestWKWebView _mouseEventWithType:atLocation:]):
3217         (-[TestWKWebView typeCharacter:]):
3218         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3219         (-[DragAndDropSimulator runFrom:to:]):
3220
3221         While simulating drag and drop on macOS, use `-setEventTimestampOffset:` to "leap forward" in time, so that the
3222         150 millisecond delay when dragging a text selection doesn't prevent drags from beginning.
3223
3224 2020-06-03  Sihui Liu  <sihui_liu@apple.com>
3225
3226         Text manipulation sometimes fails to replace text in attributes
3227         https://bugs.webkit.org/show_bug.cgi?id=212701
3228
3229         Reviewed by Wenson Hsieh.
3230
3231         Modify TextManipulation.CompleteTextManipulationShouldReplaceTextContentWithMultipleTokens to cover text 
3232         manipulation for attributes.
3233
3234         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3235         (TestWebKitAPI::TEST):
3236
3237 2020-06-03  Diego Pino Garcia  <dpino@igalia.com>
3238
3239         [WPE] lint-test-expectations doesn't work when platform is WPE
3240         https://bugs.webkit.org/show_bug.cgi?id=212700
3241
3242         Reviewed by Carlos Alberto Lopez Perez.
3243
3244         When passing arguments '--wpe' or '--platform=wpe*',
3245         lint-test-expectations does nothing for WPE, despite currently 
3246         there are many lint errors in WPE's TestExpectations file.
3247
3248         As a side-effect of this patch, now `Tools/Scripts/webkit-path
3249         rebaseline` lists the WPE Release and Debug bots.
3250
3251         * Scripts/webkitpy/port/builders.py: Add WPE to the list of
3252         exact_matches and fuzzy_matches.
3253         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3254
3255 2020-06-03  Jonathan Bedard  <jbedard@apple.com>
3256
3257         Allow using web processes for service workers even though they loaded about URLs (Follow-up fix)
3258         https://bugs.webkit.org/show_bug.cgi?id=212464
3259
3260         Unreviewed build fix.
3261
3262         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: didFinishNavigation is now used unconditionally.
3263
3264 2020-06-02  Keith Rollin  <krollin@apple.com>
3265
3266         Revert FEATURES_DEFINES related changes
3267         https://bugs.webkit.org/show_bug.cgi?id=212664
3268         <rdar://problem/63893033>
3269
3270         Reviewed by Andy Estes.
3271
3272         Bug 262310, Bug 262311, Bug 262318, and Bug 262331 involve changes to
3273         FEATURE_DEFINES and how the values there relate to those found in the
3274         Platform*.h files. Those changes break XCBuild (by removing the
3275         .xcfilelist related to UnifiedSources and the process for generating
3276         them), and so are being reverted.
3277
3278         * Scripts/webkitperl/FeatureList.pm:
3279         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3280         (WebCoreGenerator):
3281         (WebCoreGenerator._get_generate_unified_sources_script):
3282         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3283
3284 2020-06-02  Peng Liu  <peng.liu6@apple.com>
3285
3286         Stressing webkitSetPresentationMode leads to wrong inline video dimensions
3287         https://bugs.webkit.org/show_bug.cgi?id=202425
3288
3289         Reviewed by Eric Carlson.
3290
3291         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
3292         (TEST):
3293
3294 2020-06-02  Youenn Fablet  <youenn@apple.com>
3295
3296         Allow using web processes for service workers even though they loaded about URLs
3297         https://bugs.webkit.org/show_bug.cgi?id=212464
3298
3299         Reviewed by Chris Dumez.
3300
3301         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3302
3303 2020-06-02  Diego Pino Garcia  <dpino@igalia.com>
3304
3305         [buildbot] [GTK][WPE] Move JavaScript related tests to own bot
3306         https://bugs.webkit.org/show_bug.cgi?id=212481
3307
3308         Reviewed by Carlos Alberto Lopez Perez.
3309
3310         Currently GTK and WPE tests bots run too many tests. This makes
3311         the total running time for each build very long.
3312
3313         This patch moves JavaScript related tests (jscore-test and
3314         test262-test) to a separated bot which will be triggered by the
3315         corresponding build bot of each platform.
3316
3317         * BuildSlaveSupport/build.webkit.org-config/config.json:
3318         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3319         (TestFactory.__init__):
3320         (TestJSFactory):
3321         (TestJSFactory.__init__):
3322         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3323
3324 2020-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3325
3326         [GTK4] Make popup menus work
3327         https://bugs.webkit.org/show_bug.cgi?id=211178
3328
3329         Reviewed by Adrian Perez de Castro.
3330
3331         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3332         (WTR::PlatformWebView::dismissAllPopupMenus):
3333
3334 2020-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3335
3336         [GTK4] Make it possible to run layout tests
3337         https://bugs.webkit.org/show_bug.cgi?id=212328
3338
3339         Reviewed by Carlos Alberto Lopez Perez.
3340
3341         Build WTR with GTK4.
3342
3343         * PlatformGTK.cmake:
3344         * Scripts/webkitdirs.pm:
3345         (builtDylibPathForName): Try with both 4 and 5 API versions.
3346         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3347         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3348         (WTR::PlatformWebView::PlatformWebView):
3349         (WTR::PlatformWebView::~PlatformWebView):
3350         (WTR::PlatformWebView::setWindowIsKey):
3351         (WTR::PlatformWebView::windowFrame):
3352         (WTR::PlatformWebView::setWindowFrame):
3353         (WTR::PlatformWebView::addToWindow):
3354         (WTR::PlatformWebView::removeFromWindow):
3355         (WTR::PlatformWebView::windowSnapshotImage):
3356         (WTR::PlatformWebView::dismissAllPopupMenus):
3357         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
3358         (WTR::UIScriptControllerGtk::copyText):
3359
3360 2020-06-01  Noam Rosenthal  <noam@webkit.org>
3361
3362         Make unicode-bidi:isolate the default for an element with a dir attribute (instead of unicode-bidi:embed)
3363         https://bugs.webkit.org/show_bug.cgi?id=134630
3364
3365         Reviewed by Simon Fraser.
3366
3367         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
3368         (TEST):
3369                 Test was expecting unicode-bidi:embed, changed expectation.
3370
3371 2020-06-01  Sihui Liu  <sihui_liu@apple.com>
3372
3373         TextManipulationController should put one Node in only one paragraph
3374         https://bugs.webkit.org/show_bug.cgi?id=212548
3375
3376         Reviewed by Wenson Hsieh.
3377
3378         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3379         (TestWebKitAPI::TEST):
3380
3381 2020-06-01  Alex Christensen  <achristensen@webkit.org>
3382
3383         Make CustomDisplayName and DefaultDisplayName API tests fail instead of timing out when something changes
3384         https://bugs.webkit.org/show_bug.cgi?id=212480
3385
3386         This saves time when debugging and running all the tests.
3387
3388         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:
3389         (TestWebKitAPI::checkUntilDisplayNameIs):
3390
3391 2020-06-01  Philippe Normand  <pnormand@igalia.com>
3392
3393         [Flatpak SDK] Install and update don't provide any terminal output
3394         https://bugs.webkit.org/show_bug.cgi?id=212579
3395
3396         Reviewed by Žan Doberšek.
3397
3398         The `show_output` option was removed from the process execution routines. We now assume the
3399         output will be displayed, unless the call-site asks `gather_output`. This change makes
3400         webkit-flatpak more chatty, which is nice during install/update operations.
3401
3402         * flatpak/flatpakutils.py:
3403         (run_sanitized):
3404         (FlatpakObject.flatpak):
3405         (FlatpakPackage.install):
3406         (FlatpakPackage.update):
3407         (WebkitFlatpak.setup_builddir):
3408         (WebkitFlatpak.run_in_sandbox):
3409
3410 2020-06-01  Chris Dumez  <cdumez@apple.com>
3411
3412         ASSERTION FAILURE (r220931): !m_function in ~CompletionHandler() after switch tabs
3413         https://bugs.webkit.org/show_bug.cgi?id=212537
3414         <rdar://problem/63766838>
3415
3416         Reviewed by Alex Christensen.
3417
3418         Add API test coverage.
3419
3420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspension.mm: Added.
3422         (TEST):
3423
3424 2020-06-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3425
3426         [EWS] Add a special case for running the layout test step without aborting in case of many failures for WPT tests
3427         https://bugs.webkit.org/show_bug.cgi?id=212381
3428
3429         Reviewed by Jonathan Bedard.
3430
3431         Add a special case for patches uploaded by the bugzilla user that would be used
3432         for prototyping a bot that helps automating the import of WPT tests. For patches
3433         uploaded by this user don't pass the parameters that make the step abort early in
3434         case of many errors, and only run the layout tests inside the WPT import directory.
3435
3436         * BuildSlaveSupport/ews-build/steps.py:
3437         (RunWebKitTests):
3438         (RunWebKitTests.start):
3439         * BuildSlaveSupport/ews-build/steps_unittest.py:
3440         (test_success):
3441         (test_warnings):
3442         (test_parse_results_json_regression):
3443         (test_parse_results_json_flakes):
3444         (test_parse_results_json_flakes_and_regressions):
3445         (test_parse_results_json_with_newlines):
3446         (test_unexpected_error):
3447         (test_failure):
3448         (test_success_wpt_import_bot):
3449         (TestRunWebKitTestsWithoutPatch.test_success):
3450         (TestRunWebKitTestsWithoutPatch.test_failure):
3451         (TestRunWebKit1Tests.test_success):
3452         (TestRunWebKit1Tests.test_failure):
3453
3454 2020-06-01  Sam Weinig  <weinig@apple.com>
3455
3456         Extended Color: Replace Color constructors taking numeric values with type specific factory functions
3457         https://bugs.webkit.org/show_bug.cgi?id=212576
3458
3459         Reviewed by Tim Horton.
3460
3461         Replaces all remaining implicit and explicit uses of the Color constructors taking numeric
3462         values with explicit calls to makeSimpleColor/makeSimpleColorFromFloats/makeExtendedColor,
3463         giving us a consistent way to create colors. Also addes use constexpr SimpleColors where possible.
3464
3465         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
3466         (TestWebKitAPI::TEST):
3467         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
3468         (TestWebKitAPI::TEST):
3469         (TestWebKitAPI::makeColor):
3470         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
3471         (TestWebKitAPI::TEST):
3472         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
3473         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
3474
3475 2020-05-31  Dean Jackson  <dino@apple.com>
3476
3477         AutoTrader crashed while browsing search results
3478         https://bugs.webkit.org/show_bug.cgi?id=212461
3479         rdar://60733185
3480
3481         Reviewed by Sam Weinig.
3482
3483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3484         * TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm: Added.
3485         (-[WebGLPrepareDisplayOnWebThreadDelegate webViewDidFinishLoad:]):
3486         (-[WebGLPrepareDisplayOnWebThreadDelegate webView:shouldStartLoadWithRequest:navigationType:]):
3487         (TestWebKitAPI::TEST):
3488         * TestWebKitAPI/Tests/WebKitLegacy/ios/webgl.html: Added.
3489
3490 2020-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3491
3492         Unreviewed. Fix GTK4 build with current GTK
3493
3494         * MiniBrowser/gtk/BrowserTab.c:
3495         (audioMutedChanged):
3496
3497 2020-05-30  Sam Weinig  <weinig@apple.com>
3498
3499         Extended Color: Additional color cleanups
3500         https://bugs.webkit.org/show_bug.cgi?id=212567
3501
3502         Reviewed by Simon Fraser.
3503
3504         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
3505         (TestWebKitAPI::TEST):
3506         Update for rename from ExtendedColor::channels() to ExtendedColor::components()
3507
3508 2020-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3509
3510         [GTK] WebDriver: stop using GdkEvent API in preparation for GTK4
3511         https://bugs.webkit.org/show_bug.cgi?id=212465
3512
3513         Reviewed by Adrian Perez de Castro.
3514
3515         Update to the new webkitWebViewBaseSynthesizeKeyEvent() API.
3516
3517         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3518         (WTR::EventSenderProxy::keyDown):
3519
3520 2020-05-29  Alex Christensen  <achristensen@webkit.org>
3521
3522         Use correct encoding when converting a WTF::URL to CFURLRef
3523         https://bugs.webkit.org/show_bug.cgi?id=212486
3524
3525         Reviewed by Darin Adler.
3526
3527         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3528         (TestWebKitAPI::TEST):
3529
3530 2020-05-29  Andy Estes  <aestes@apple.com>
3531
3532         [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
3533         https://bugs.webkit.org/show_bug.cgi?id=212541
3534
3535         Reviewed by Darin Adler.
3536
3537         APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
3538
3539         * Scripts/webkitperl/FeatureList.pm:
3540         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3541
3542 2020-05-29  Jan-Michael Brummer  <jan.brummer@tabos.org>
3543
3544         [GTK][WPE] API for WebView audio mute support
3545         https://bugs.webkit.org/show_bug.cgi?id=176119
3546
3547         Reviewed by Michael Catanzaro.
3548
3549         * MiniBrowser/gtk/BrowserTab.c:
3550         (audioClicked):
3551         (audioMutedChanged):
3552         (browserTabConstructed):
3553         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3554         (testWebViewIsAudioMuted):
3555         (beforeAll):
3556
3557 2020-05-29  Darin Adler  <darin@apple.com>
3558
3559         Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h
3560         https://bugs.webkit.org/show_bug.cgi?id=212418
3561
3562         Rubber-stamped by Simon Fraser.
3563
3564         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Add back ENABLE_CSS_CONIC_GRADIENTS,
3565         removed by accident.
3566
3567 2020-05-29  Pavel  <pavel.feldman@gmail.com>
3568
3569         [Win] Allow compiling with the TOUCH_EVENTS enabled
3570         https://bugs.webkit.org/show_bug.cgi?id=212528
3571
3572         Reviewed by Fujii Hironori.
3573
3574         Aligning Win with GTK, adding missing EventSenderProxy stubs.
3575         This allows compiling Win with TOUCH_EVENTS and unlocks event
3576         injection / processing by the automation drivers
3577
3578         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3579         (WTR::EventSenderProxy::addTouchPoint):
3580         (WTR::EventSenderProxy::updateTouchPoint):
3581         (WTR::EventSenderProxy::setTouchModifier):
3582         (WTR::EventSenderProxy::setTouchPointRadius):
3583         (WTR::EventSenderProxy::touchStart):
3584         (WTR::EventSenderProxy::touchMove):
3585         (WTR::EventSenderProxy::touchEnd):
3586         (WTR::EventSenderProxy::touchCancel):
3587         (WTR::EventSenderProxy::clearTouchPoints):
3588         (WTR::EventSenderProxy::releaseTouchPoint):
3589         (WTR::EventSenderProxy::cancelTouchPoint):
3590
3591 2020-05-27  Darin Adler  <darin@apple.com>
3592
3593         Remove things from FeatureDefines.xcconfig that are covered by PlatformEnableCocoa.h
3594         https://bugs.webkit.org/show_bug.cgi?id=212418
3595
3596         Reviewed by Andy Estes.
3597
3598         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Removed 83 of the 119 things
3599         defined in this file. There are 36 more that are slightly more complex that we can
3600         remove carefully later.
3601
3602 2020-05-29  Darin Adler  <darin@apple.com>
3603
3604         Make generate-unified-sources.sh not depend on features being listed in FEATURE_DEFINES environment variable
3605         https://bugs.webkit.org/show_bug.cgi?id=212420
3606
3607         Reviewed by Andy Estes.
3608
3609         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
3610         (WebCoreGenerator._get_generate_derived_sources_script): Removed the code
3611         to generate UnifiedSources-output.xcfilelist.
3612
3613 2020-05-29  Keith Rollin  <krollin@apple.com>
3614
3615         Revert switch to XCBuild
3616         https://bugs.webkit.org/show_bug.cgi?id=212530
3617         <rdar://problem/63764632>
3618
3619         Unreviewed build fix.
3620
3621         Bug 209890 enabled the use of XCBuild by default. Since then, some
3622         build issues have shown up. While addressing them, temporarily turn
3623         off the use of XCBuild by default.
3624
3625         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3626         * Scripts/build-webkit:
3627         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3628
3629 2020-05-29  Philippe Normand  <pnormand@igalia.com>
3630
3631         [Flatpak][GStreamer] all commands, except webkit-build, fails if GST_BUILD_PATH is set
3632         https://bugs.webkit.org/show_bug.cgi?id=212408
3633
3634         Reviewed by Žan Doberšek.
3635
3636         Don't run gst-env.py in the sandbox because that can lead to command-line options clashing
3637         with build-webkit and other WebKit scripts. So instead we now parse the output of the
3638         environment variables gst-build requires and we forward those to the sandbox.
3639
3640         * flatpak/flatpakutils.py:
3641         (run_sanitized):
3642         (check_flatpak):
3643         (FlatpakObject.flatpak):
3644         (WebkitFlatpak.execute_command):
3645         (WebkitFlatpak.setup_gstbuild):
3646         (WebkitFlatpak.run_in_sandbox):
3647         (flatpak_run_sanitized): Deleted.
3648