Support the TailBench9000 benchmark in run-jsc-benchmarks
[WebKit-https.git] / Tools / ChangeLog
1 2017-10-25  Robin Morisset  <rmorisset@apple.com>
2
3         Support the TailBench9000 benchmark in run-jsc-benchmarks
4         https://bugs.webkit.org/show_bug.cgi?id=178451
5
6         Reviewed by Saam Barati.
7
8         * Scripts/run-jsc-benchmarks:
9
10 2017-10-25  Adrian Perez de Castro  <aperez@igalia.com>
11
12         [WPE] Remove GLib API functions which use Cairo
13         https://bugs.webkit.org/show_bug.cgi?id=178205
14
15         Reviewed by Michael Catanzaro.
16
17         Add PLATFORM(GTK) guards for the API tests (or parts of them) which use cairo_surface_t (web
18         page snapshots and favicons) which are not available in the WPE version of the GLib API.
19
20         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
21         (testNotInitialized):
22         (testPrivateBrowsing):
23         (testFaviconDatabase):
24         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
25         (testFindControllerHide):
26         (beforeAll):
27         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
28         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
29
30 2017-10-25  Zan Dobersek  <zdobersek@igalia.com>
31
32         Make SERVICE_WORKER feature buildable on GTK, WPE
33         https://bugs.webkit.org/show_bug.cgi?id=178574
34
35         Reviewed by Carlos Garcia Campos.
36
37         * Scripts/webkitperl/FeatureList.pm: Add the --service-worker option
38         that enables the SERVICE_WORKER feature flag. For now it's enabled
39         on Apple's Cocoa ports (even when build-webkit isn't used for those
40         builds, the flag is enabled here for consistency).
41
42 2017-10-24  Michael Catanzaro  <mcatanzaro@igalia.com>
43
44         Unreviewed, fix name of Perl LibXML package on Fedora
45         https://bugs.webkit.org/show_bug.cgi?id=178206
46         <rdar://problem/35028586>
47
48         * gtk/install-dependencies:
49         * wpe/install-dependencies:
50
51 2017-10-24  Alex Christensen  <achristensen@webkit.org>
52
53         Selecting and right-clicking URL-like strings with IDNA-disallowed characters in host or authority causes rendering engine crash
54         https://bugs.webkit.org/show_bug.cgi?id=174267
55
56         Reviewed by Tim Horton.
57
58         * TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp:
59         (TestWebKitAPI::runTest):
60
61 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
62
63         Web Inspector: Enable WebKit logging configuration and display
64         https://bugs.webkit.org/show_bug.cgi?id=177027
65         <rdar://problem/33964767>
66
67         Reviewed by Joseph Pecoraro.
68
69         Allow new 'dumpJSConsoleLogInStdErr' test header to redirect log console output to stderr.
70
71         * DumpRenderTree/TestOptions.h:
72         * DumpRenderTree/TestOptions.mm:
73         (TestOptions::TestOptions):
74         * DumpRenderTree/mac/DumpRenderTree.mm:
75         (runTest):
76         * WebKitTestRunner/TestController.cpp:
77         (WTR::updateTestOptionsFromTestHeader):
78         (WTR::TestController::runTest):
79         * WebKitTestRunner/TestOptions.h:
80         (WTR::TestOptions::hasSameInitializationOptions const):
81
82 2017-10-24  Alex Christensen  <achristensen@webkit.org>
83
84         Apply custom header fields from WebsitePolicies to same-domain requests
85         https://bugs.webkit.org/show_bug.cgi?id=178356
86
87         Reviewed by Brady Eidson.
88
89         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
90         (expectHeaders):
91
92 2017-10-24  Stephan Szabo  <stephan.szabo@sony.com>
93
94         [Win][JSCOnly] Make jsconly build testapi and dlls and copy dlls when running tests
95         https://bugs.webkit.org/show_bug.cgi?id=177279
96
97         Reviewed by Yusuke Suzuki.
98
99         * Scripts/build-jsc:
100         * Scripts/run-jsc-stress-tests:
101
102 2017-10-23  Lucas Forschler  <lforschler@apple.com>
103
104         <rdar://problem/35045445>
105         Update README to reference WebKit build archives, instead of 'nightly'
106
107         Reviewed by Aakash Jain.
108
109         * WebKitArchiveSupport/README:
110
111 2017-10-21  Tim Horton  <timothy_horton@apple.com>
112
113         Turn on ccache for Mac cmake builds by default
114         https://bugs.webkit.org/show_bug.cgi?id=177059
115
116         Reviewed by Sam Weinig.
117
118         * ccache/ccache-clang:
119         * ccache/ccache-wrapper: Added.
120         Add a pass-through ccache wrapper to be used with CMake, in addition
121         to the existing faux-clang wrappers.
122
123         * Scripts/build-webkit:
124         Add --use-ccache and --no-use-ccache option, which will define
125         WK_USE_CCACHE to YES or NO, respectively, which the underlying
126         build systems respect. We do not define WK_USE_CCACHE if the option
127         is not specified, because the underlying build systems have different
128         default values.
129
130 2017-10-20  Aakash Jain  <aakash_jain@apple.com>
131
132         Do not run binding tests on multiple EWSes
133         https://bugs.webkit.org/show_bug.cgi?id=178599
134
135         Reviewed by Alexey Proskuryakov. 
136
137         Remove old code which runs bindings tests and ignore it's result. We now have
138         a dedicated bindings test EWS.
139
140         * Scripts/webkitpy/tool/steps/runtests.py:
141         (RunTests.run): Removed bindings tests code.
142         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Updated unit-tests.
143         (RunTestsTest.test_webkit_run_unit_tests): Ditto.
144         * Scripts/webkitpy/tool/steps/steps_unittest.py: Ditto.
145         * Scripts/webkitpy/tool/commands/download_unittest.py: Ditto.
146
147 2017-10-20  Youenn Fablet  <youenn@apple.com>
148
149         WebsiteDataStoreCustomPaths.mm is failing after r223718
150         https://bugs.webkit.org/show_bug.cgi?id=178596
151
152         Unreviewed.
153
154         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
155         (TEST): Making default web site data store creation expected at the end of the test.
156         We should probably not need need to create it.
157         This should be fixed as a follow-up.
158
159 2017-10-20  Antoine Quint  <graouts@apple.com>
160
161         [Web Animations] Provide basic timeline and animation interfaces
162         https://bugs.webkit.org/show_bug.cgi?id=178526
163
164         Reviewed by Dean Jackson.
165
166         Remove the WEB_ANIMATIONS compile-time flag.
167
168         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
169
170 2017-10-20  Tomas Popela  <tpopela@redhat.com>
171
172         Missing some perl packages in install-dependencies
173         https://bugs.webkit.org/show_bug.cgi?id=178571
174
175         Reviewed by Žan Doberšek.
176
177         Install per-version and perl-Time-HiRes so we can use build-webkit
178         script. Also add missing backlashes.
179
180         * wpe/install-dependencies:
181
182 2017-10-20  Commit Queue  <commit-queue@webkit.org>
183
184         Unreviewed, rolling out r222709 and r223572.
185         https://bugs.webkit.org/show_bug.cgi?id=178587
186
187         Still getting mac-wk2 EWS bots stuck (Requested by ap on
188         #webkit).
189
190         Reverted changesets:
191
192         "Log stack-trace for run-webkit-tests when interrupted"
193         https://bugs.webkit.org/show_bug.cgi?id=176393
194         https://trac.webkit.org/changeset/222709
195
196         "webkitpy: Hang when workers write to the same stack trace
197         file"
198         https://bugs.webkit.org/show_bug.cgi?id=178402
199         https://trac.webkit.org/changeset/223572
200
201 2017-10-19  Nan Wang  <n_wang@apple.com>
202
203         AX: Provide a way for Accessibility to cache the selection while retrieving rects for speak selection
204         https://bugs.webkit.org/show_bug.cgi?id=176247
205         <rdar://problem/34217143>
206
207         Reviewed by Ryosuke Niwa.
208
209         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
210         (TestWebKitAPI::TEST):
211
212 2017-10-19  Sam Weinig  <sam@webkit.org>
213
214         [Settings] Move global settings into their own file
215         https://bugs.webkit.org/show_bug.cgi?id=178512
216
217         Reviewed by Darin Adler.
218
219         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
220         (TestWebKitAPI::TEST):
221
222 2017-10-19  Andy Estes  <aestes@apple.com>
223
224         [iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
225         https://bugs.webkit.org/show_bug.cgi?id=178181
226         <rdar://problem/33660282>
227
228         Reviewed by Dan Bernstein.
229
230         * WebKitTestRunner/TestController.cpp:
231         (WTR::TestController::databaseProcessName):
232
233 2017-10-19  Saam Barati  <sbarati@apple.com>
234
235         Turn poly proto back on by default and remove the option
236         https://bugs.webkit.org/show_bug.cgi?id=178525
237
238         Reviewed by Mark Lam.
239
240         * Scripts/run-jsc-stress-tests:
241
242 2017-10-18  Ryosuke Niwa  <rniwa@webkit.org>
243
244         Don't expose raw HTML in pasteboard to the web content
245         https://bugs.webkit.org/show_bug.cgi?id=178422
246
247         Reviewed by Wenson Hsieh.
248
249         Added a test case for sanitizing web archive in the system pasteboard to strip privacy sensitive information
250         such as local file paths and potentially harmful scripts like event handlers serialized by WebKit prior to r223462.
251
252         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
253         (PasteWebArchive.SanitizesHTML):
254
255 2017-10-18  Youenn Fablet  <youenn@apple.com>
256
257         TestController should clear all fetch caches when resetting its state
258         https://bugs.webkit.org/show_bug.cgi?id=178486
259
260         Reviewed by Chris Dumez.
261
262         Adding clearDOMCaches test runner method.
263         Using that method when resetting state.
264
265         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
266         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
267         (WTR::TestRunner::clearDOMCaches):
268         * WebKitTestRunner/InjectedBundle/TestRunner.h:
269         * WebKitTestRunner/TestInvocation.cpp:
270         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
271
272 2017-10-18  Chelsea Pugh  <cpugh@apple.com>
273
274         [iOS] Use new class name from UIKit when checking UITextSuggestion type
275         https://bugs.webkit.org/show_bug.cgi?id=178416
276
277         Reviewed by Tim Horton.
278
279         This updates our test using/mocking out UITextAutofillSuggestion instead of UIKeyboardLoginCredentialsSuggestion.
280
281         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
282         (-[UITextAutofillSuggestion initWithUsername:password:]): Copied from UIKit's implementation. This will serve as
283         a mock of this method for builds not containingit.
284         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Ditto.
285         (TestWebKitAPI::TEST): Use +[UITextAutofillSuggestion autofillSuggestionWithUsername:password:] inline instead of
286         helper function for creating a new suggestion.
287         (newUIKeyboardLoginCredentialsSuggestion): Deleted.
288
289         * TestWebKitAPI/ios/UIKitSPI.h:
290
291 2017-10-18  Fujii Hironori  <Hironori.Fujii@sony.com>
292
293         update-webkit-auxiliary-libs can't download WebKitAuxiliaryLibrary.zip due to 403 Forbidden
294         https://bugs.webkit.org/show_bug.cgi?id=178381
295
296         Reviewed by Alexey Proskuryakov.
297
298         The web server developer.apple.com seems to reject HTTP requests
299         without Accept header field.
300
301         * Scripts/update-webkit-dependency: Add 'Accept' header field to requests.
302
303 2017-10-18  Aakash Jain  <aakash_jain@apple.com>
304
305         webkitpy tests should have --json-output option
306         https://bugs.webkit.org/show_bug.cgi?id=178481
307
308         Reviewed by Alexey Proskuryakov.
309
310         * Scripts/webkitpy/test/main.py:
311         (Tester._parse_args): Added json-output argument.
312         (Tester._run_tests): Write output to json file.
313
314 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
315
316         Unreviewed, rolling out r223291.
317
318         See WebCore ChangeLog for more detail.
319
320         Reverted changeset:
321
322         "Remove Editor::simplifyMarkup"
323         https://bugs.webkit.org/show_bug.cgi?id=178271
324         https://trac.webkit.org/changeset/223291
325
326 2017-10-18  Chris Dumez  <cdumez@apple.com>
327
328         Add an efficient data structure for WebCore to query if there is a Service Worker registered for a given origin
329         https://bugs.webkit.org/show_bug.cgi?id=177876
330         <rdar://problem/34813129>
331
332         Reviewed by Ryosuke Niwa.
333
334         Clear service worker registrations between test runs to avoid flakiness.
335
336         * WebKitTestRunner/TestController.cpp:
337         (WTR::TestController::resetStateToConsistentValues):
338
339 2017-10-18  Zan Dobersek  <zdobersek@igalia.com>
340
341         Remove remnants of OpenWebRTC
342         https://bugs.webkit.org/show_bug.cgi?id=178437
343
344         Reviewed by Alejandro G. Castro.
345
346         Drop OpenWebRTC packages from the GTK's Jhbuild modules file. Relevant
347         patches are also removed.
348
349         * gtk/jhbuild.modules:
350         * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Removed.
351         * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Removed.
352         * gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Removed.
353         * gtk/patches/udpsrc-improve-timeouts.patch: Removed.
354
355 2017-10-17  Jonathan Bedard  <jbedard@apple.com>
356
357         webkitpy: Hang when workers write to the same stack trace file
358         https://bugs.webkit.org/show_bug.cgi?id=178402
359         <rdar://problem/35033432>
360
361         Reviewed by Aakash Jain.
362
363         Workers can hang if they all write to the same stack trace file when receiving
364         a SIGTERM. Attach the pid to the stack trace file name so that each worker
365         writes to a different file.
366
367         * Scripts/webkitpy/common/interupt_debugging.py:
368         (log_stack_trace_on_term.handler): Name stack trace file path/<pid>-filename.
369         (log_stack_trace_on_cntrl_c.handler): Ditto.
370
371 2017-10-17  John Wilander  <wilander@apple.com>
372
373         Add and remove cookie partition accordingly in intermediary redirect requests
374         https://bugs.webkit.org/show_bug.cgi?id=178369
375         <rdar://problem/34467603>
376
377         Reviewed by Brent Fulgham.
378
379         Adds the function statisticsNotifyObserver().
380
381         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
382         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
383         (WTR::InjectedBundle::statisticsNotifyObserver):
384         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
385         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
386         (WTR::TestRunner::statisticsNotifyObserver):
387         * WebKitTestRunner/InjectedBundle/TestRunner.h:
388
389 2017-10-17  Youenn Fablet  <youenn@apple.com>
390
391         Cache API implementation should be able to compute storage size for WebKit client applications.
392         https://bugs.webkit.org/show_bug.cgi?id=178350
393
394         Reviewed by Chris Dumez.
395
396         Adding support for a domCacheSize getter.
397
398         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
399         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
400         (WTR::TestRunner::domCacheSize):
401         * WebKitTestRunner/InjectedBundle/TestRunner.h:
402         * WebKitTestRunner/TestController.cpp:
403         (WTR::FetchCacheSizeForOriginCallbackContext::FetchCacheSizeForOriginCallbackContext):
404         (WTR::fetchCacheSizeForOriginCallback):
405         (WTR::TestController::domCacheSize):
406         * WebKitTestRunner/TestController.h:
407         * WebKitTestRunner/TestInvocation.cpp:
408         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
409
410 2017-10-17  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
411
412         [GStreamer][GTK][WPE] update-webkit-libs-jhbuild fails to detect changes in included moduleset files
413         https://bugs.webkit.org/show_bug.cgi?id=178206
414
415         Reviewed by Michael Catanzaro.
416
417         The update-webkit-libs-jhbuild scripts computes MD5 sum of GTK/WPE jhbuild configuration files to check if it
418         needs to rebuild the dependencies libraries. This patch fixes a bug when main GTK/WPE jhbuild modules
419         configuration file includes additional files (for example GStreamer module). It parses jhbuild.modules file to
420         check if additional files are included. If any, it computes MD5 sum for each of these included files.
421
422         * Scripts/update-webkit-libs-jhbuild:
423         (getJhbuildIncludedFilePaths): New function that returns included files in jhbuild.modules
424         (jhbuildConfigurationCheckFile): New function to check if MD5 sum file changes.
425         (jhbuildConfigurationChanged): Add MD5 sum check for included files.
426         (saveMd5File): New function to save MD5 sum of a file.
427         (saveJhbuildMd5): Add saving included files MD5 sum.
428         (deleteJhbuildMd5): Delete included files MD5 sum
429         * gtk/install-dependencies: Add perl-libXML lib that is used to parse jhbuild file.
430         * wpe/install-dependencies: Ditto.
431
432 2017-10-17  Tomas Popela  <tpopela@redhat.com>
433
434         Undefined WK_API_ENABLED warning when compiling COCOA content on WebKitGTK+
435         https://bugs.webkit.org/show_bug.cgi?id=178208
436
437         Check whether we are on COCOA platform before checking for
438         WK_API_ENABLED.
439
440         Reviewed by Ryosuke Niwa.
441
442         * WebKitTestRunner/TestController.cpp:
443         (WTR::TestController::clearDOMCache):
444
445 2017-10-17  Keith Miller  <keith_miller@apple.com>
446
447         Change WebCore sources to work with unified source builds
448         https://bugs.webkit.org/show_bug.cgi?id=178229
449
450         Rubber stamped by Tim Horton.
451
452         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
453
454 2017-10-16  Christopher Reid  <chris.reid@sony.com>
455
456         [Win] Webkit should still be able to build when unable to check if libraries are up to date
457         https://bugs.webkit.org/show_bug.cgi?id=178367
458
459         Adding a option to skip the check to see if windows libraries are up to date.
460         This option is useful when testing modified libraries. This option also allows
461         building webkit when GitHub blocks requests to verify the latest library version.
462
463
464         Reviewed by Per Arne Vollan.
465
466         * Scripts/build-webkit:
467
468 2017-10-12  Matt Rajca  <mrajca@apple.com>
469
470         Add API support for quirk that lets an arbitrary click allow auto-play.
471         https://bugs.webkit.org/show_bug.cgi?id=178227
472
473         Reviewed by Alex Christensen.
474
475         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
476         (TEST): Added API test.
477
478 2017-10-16  Maureen Daum  <mdaum@apple.com>
479
480         If an origin doesn't have databases in the Databases table we should still remove its information from disk in DatabaseTracker::deleteOrigin()
481         https://bugs.webkit.org/show_bug.cgi?id=178281
482         <rdar://problem/34576132>
483
484         Reviewed by Brent Fulgham.
485
486         Verify that if there is an entry in the Origins table but no entries in the Databases
487         table that we still remove the directory for the origin, and that we remove the
488         entry from the Origins table.
489
490         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
491         (TestWebKitAPI::TEST):
492
493 2017-10-15  Ryosuke Niwa  <rniwa@webkit.org>
494
495         Cannot access images included in the content pasted from Microsoft Word
496         https://bugs.webkit.org/show_bug.cgi?id=124391
497         <rdar://problem/26862741>
498
499         Reviewed by Antti Koivisto.
500
501         Added tests for sanitizing HTML contents for copy & paste and drag & drop.
502
503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
504         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm: Added.
505         (readHTMLFromPasteboard): Added.
506         (createWebViewWithCustomPasteboardDataEnabled): Added.
507         (CopyHTML.Sanitizes): Added.
508
509         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
510         (createWebViewWithCustomPasteboardDataEnabled): Added to enable more tests on bots.
511
512         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
513         (writeRTFToPasteboard): Added.
514         (createWebViewWithCustomPasteboardDataEnabled): Added.
515         (createHelloWorldString): Added.
516         (PasteRTF.ExposesHTMLTypeInDataTransfer): Added.
517         (PasteRTFD.ExposesHTMLTypeInDataTransfer): Added.
518         (PasteRTFD.ImageElementUsesBlobURLInHTML): Added.
519
520         * TestWebKitAPI/Tests/WebKitCocoa/copy-html.html: Added.
521         * TestWebKitAPI/Tests/WebKitCocoa/paste-rtfd.html: Store the clipboardData contents for
522         PasteRTF.ExposesHTMLTypeInDataTransfer and PasteRTFD.ExposesHTMLTypeInDataTransfer.
523
524         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
525         (DataInteractionTests.DataTransferSanitizeHTML):
526
527 2017-10-16  Youenn Fablet  <youenn@apple.com>
528
529         Activate Cache API by default
530         https://bugs.webkit.org/show_bug.cgi?id=178186
531
532         Reviewed by Chris Dumez.
533
534         Removing explicit activation of cache api.
535
536         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
537         (WTR::InjectedBundle::beginTesting):
538         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
539         (WTR::TestRunner::setCacheAPIEnabled): Deleted.
540         * WebKitTestRunner/InjectedBundle/TestRunner.h:
541
542 2017-10-16  Ross Kirsling  <ross.kirsling@sony.com>
543
544         run-webkit-tests help text should mention arguments too
545         https://bugs.webkit.org/show_bug.cgi?id=178352
546
547         Reviewed by Tim Horton.
548
549         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
550         (parse_args):
551
552 2017-10-16  Maureen Daum  <mdaum@apple.com>
553
554         If we fail to delete any database file, don't remove its information from the tracker database
555         <rdar://problem/34576132> and https://bugs.webkit.org/show_bug.cgi?id=178251
556
557         Reviewed by Brady Eidson.
558
559         Add tests that verify we correctly delete databases and remove their information from
560         the tracker database, even if the database doesn't exist. Verify that if we fail to
561         delete a database, we don't remove its information from the tracker database.
562
563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
564         Move DatabaseTrackerTest.cpp to DatabaseTrackerTest.mm so that we can use the cocoa
565         method for creating a temporary directory in the tests.
566         * TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp: Removed.
567         The existing test was copied to DatabaseTrackerTest.mm.
568         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm: Added.
569         (TestWebKitAPI::TEST):
570         (TestWebKitAPI::addToDatabasesTable):
571         (TestWebKitAPI::removeDirectoryAndAllContents):
572         (TestWebKitAPI::createFileAtPath):
573
574 2017-10-16  Ryan Haddad  <ryanhaddad@apple.com>
575
576         Unreviewed, rolling out r223422.
577
578         These tests are for a change that was rolled out in r223420
579
580         Reverted changeset:
581
582         "If we fail to delete any database file, don't remove its
583         information from the tracker database"
584         https://bugs.webkit.org/show_bug.cgi?id=178251
585         https://trac.webkit.org/changeset/223422
586
587 2017-10-16  Maureen Daum  <mdaum@apple.com>
588
589         If we fail to delete any database file, don't remove its information from the tracker database
590         <rdar://problem/34576132> and https://bugs.webkit.org/show_bug.cgi?id=178251
591
592         Reviewed by Brady Eidson.
593
594         Add tests that verify we correctly delete databases and remove their information from
595         the tracker database, even if the database doesn't exist. Verify that if we fail to
596         delete a database, we don't remove its information from the tracker database.
597
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         Move DatabaseTrackerTest.cpp to DatabaseTrackerTest.mm so that we can use the cocoa
600         method for creating a temporary directory in the tests.
601         * TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp: Removed.
602         The existing test was copied to DatabaseTrackerTest.mm.
603         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm: Added.
604         (TestWebKitAPI::TEST):
605         (TestWebKitAPI::addToDatabasesTable):
606         (TestWebKitAPI::removeDirectoryAndAllContents):
607         (TestWebKitAPI::createFileAtPath):
608
609 2017-10-16  David Kilzer  <ddkilzer@apple.com>
610
611         Add RELEASE_ASSERT_WITH_SECURITY_IMPLICATION() macro
612         <https://webkit.org/b/178269>
613
614         Reviewed by Alex Christensen.
615
616         * Scripts/webkitpy/style/checkers/cpp.py:
617         (check_language): Add checker to warn about using
618         ASSERT_WITH_SECURITY_IMPLICATION().
619         (CppChecker.categories): Add 'security/assertion' to list of
620         enabled checkers.
621         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
622         (CppStyleTest.test_debug_security_assertion): Add tests for
623         new checker.
624
625 2017-10-16  Chris Dumez  <cdumez@apple.com>
626
627         Clicks on Link with download attribute causes all (other) links to trigger download when clicked
628         https://bugs.webkit.org/show_bug.cgi?id=178267
629         <rdar://problem/34985016>
630
631         Reviewed by Darin Adler.
632
633         Use PassThrough policy in WKTR's InjectedBundle's decidePolicyForNewWindowAction so that the
634         request is sent to the UIProcess. This gets WKTR's closer to Safari behavior and helps
635         reproduce the bug. Without this change, I would not be able to write a regression test for
636         this bug that is very easily reproducible in Safari.
637
638         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
639         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
640
641 2017-10-16  Emilio Cobos Álvarez  <emilio@crisal.io>
642
643         Add Emilio Cobos Álvarez to the contributors list.
644         https://bugs.webkit.org/show_bug.cgi?id=178334
645
646         Reviewed by Antti Koivisto.
647
648         * Scripts/webkitpy/common/config/contributors.json:
649
650 2017-10-07  Maciej Stachowiak  <mjs@apple.com>
651
652         Improve --help documentation and add --list-plans to show available benchmarks.
653         https://bugs.webkit.org/show_bug.cgi?id=178059
654
655         Reviewed by Ryosuke Niwa.
656
657         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
658         (BenchmarkRunner.available_plans): New function that returns the list of available plans.
659         (BenchmarkRunner.plan_directory): New method to centralize knowledge of where the plan files live.
660         (BenchmarkRunner._find_plan_file): Updated to use BenchmarkRunner.plan_directory
661
662         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
663         
664         (parse_args): Help cleanup: Reordered options to put more common
665         ones at the top. Fixed wording. Added help for each
666         option. Explained default for each option that has one.
667
668         New option: --list-plans which tells you the available benchmarks.
669         
670         Code cleanup: Removed use of dest where redundant, made variable
671         names conforming to Python coding style.
672         
673         (run_benchmark_plan): Adapted for new variable names.
674         (list_benchmark_plans): New helper for --list-plans option.
675         (start): Account for --list-plans. Also use
676         BechmarkRunner.available_plans and use
677         BenchmarkRunner.plan_directory instead of duplicating
678         code/knowledge here.
679
680 2017-10-16  Wenson Hsieh  <wenson_hsieh@apple.com>
681
682         On ToT, event.dataTransfer.getData("text/uri-list") returns an empty string when dragging an image
683         https://bugs.webkit.org/show_bug.cgi?id=178301
684         <rdar://problem/34990050>
685
686         Reviewed by Darin Adler.
687
688         Fixes issues in DumpRenderTree's LocalPasteboard to ensure that drag-drop-href-as-url.html exposes files, and
689         also adds a new iOS drag and drop API test.
690
691         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
692         (-[LocalPasteboard addTypes:owner:]):
693         (-[LocalPasteboard setData:forType:]):
694
695         Fixes LocalPasteboard's implementation of changeCount to incremement when the pasteboard owner changes, rather
696         than every time data is changed. This is consistent with NSPasteboard behavior.
697
698         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
699         (TestWebKitAPI::TEST):
700
701         Adds a new API test to verify that an image and HTTP URL written by the platform is correctly web exposed.
702
703 2017-10-15  Darin Adler  <darin@apple.com>
704
705         UTF-8 decoding produces one replacement character per byte; Encoding standard requires one replacement character per illegal sequence instead
706         https://bugs.webkit.org/show_bug.cgi?id=178207
707
708         Reviewed by Sam Weinig.
709
710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added test.
711         * TestWebKitAPI/Tests/WebCore/TextCodec.cpp: Added.
712         (TestWebKitAPI::decodeHexTestBytes): Decodes a string so we can write readable tests.
713         (TestWebKitAPI::escapeNonPrintableASCIICharacters): Encodes a string so we can write readable tests.
714         (TestWebKitAPI::TEST): Added some UTF-8 tests and UTF-8 invalid sequences tests.
715         Would be smart to add more tests for other cases, exercising the fast ASCII loop for example, and
716         other encodings.
717
718 2017-10-14  Adrian Perez de Castro  <aperez@igalia.com>
719
720         [WPE] JHBuild build directory DependenciesWPE/Build is not removed by update-webkit-libs-jhbuild
721         https://bugs.webkit.org/show_bug.cgi?id=178212
722
723         Reviewed by Michael Catanzaro.
724
725         * Scripts/update-webkit-libs-jhbuild:
726         (cleanJhbuild): The WPE JHBuild also uses a separate "Build" subdirectory, so do not skip
727         cleaning it when "--wpe" is passed to the script.
728
729 2017-10-13  Adrian Perez de Castro  <aperez@igalia.com>
730
731         [WPE] Fontconfig fails build in JHBuild with “error: conflicting types for ‘FcObjectTypeHash’”
732         https://bugs.webkit.org/show_bug.cgi?id=178283
733
734         Reviewed by Žan Doberšek.
735
736         * wpe/jhbuild.modules: Flag Fontconfig to be built inside the source directory, otherwise
737         compilation fails. While at it, pass "--disable-docs" to cut a bit on build time.
738
739 2017-10-13  Youenn Fablet  <youenn@apple.com>
740
741         Implement listing origins for which CacheStorage is storing data
742         https://bugs.webkit.org/show_bug.cgi?id=178236
743
744         Reviewed by Chris Dumez.
745
746         Adding hasDOMCache API for checking whether origin is storing data through Cache API.
747
748         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
749         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
750         (WTR::TestRunner::hasDOMCache):
751         * WebKitTestRunner/InjectedBundle/TestRunner.h:
752         * WebKitTestRunner/TestController.cpp:
753         (WTR::FetchCacheOriginsCallbackContext::FetchCacheOriginsCallbackContext):
754         (WTR::fetchCacheOriginsCallback):
755         (WTR::TestController::hasDOMCache):
756         * WebKitTestRunner/TestController.h:
757         * WebKitTestRunner/TestInvocation.cpp:
758         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
759
760 2017-10-13  Alex Christensen  <achristensen@webkit.org>
761
762         Remove Editor::simplifyMarkup
763         https://bugs.webkit.org/show_bug.cgi?id=178271
764
765         Reviewed by Wenson Hsieh.
766
767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
768         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Removed.
769
770 2017-10-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
771
772         [GLib] WebKitNavigationAction should tell whether it is a redirect
773         https://bugs.webkit.org/show_bug.cgi?id=178178
774
775         Test that WebKitNavigationAction properly reports being a redirect.
776
777         Reviewed by Carlos Garcia Campos.
778
779         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
780         (testNavigationPolicy): test that loading /redirect leads to a redirect WebKitNavigationAction.
781         (serverCallback): add a /redirect path to the server, which causes a redirect.
782
783 2017-10-13  Chris Dumez  <cdumez@apple.com>
784
785         Unreviewed, fix webkitpy failure after r223273
786
787         * Scripts/webkitpy/w3c/test_importer_unittest.py:
788         (TestImporterTest.test_harnesslinks_conversion):
789
790 2017-10-12  Chris Dumez  <cdumez@apple.com>
791
792         import-w3c-tests modifies test sources and sometimes causes them to fail
793         https://bugs.webkit.org/show_bug.cgi?id=178234
794
795         Reviewed by Ryosuke Niwa.
796
797         Update import-w3c-tests to stop rewriting tests as this is causing some tests
798         to fail unexpectedly.
799
800         * Scripts/webkitpy/w3c/test_importer.py:
801         (TestImporter.import_tests):
802
803 2017-10-12  Youenn Fablet  <youenn@apple.com>
804
805         Layout Test http/tests/cache-storage/cache-clearing.https.html is failing
806         https://bugs.webkit.org/show_bug.cgi?id=178200
807
808         Reviewed by Chris Dumez.
809
810         Making clearDOMCache wait for removal completion to exit.
811         This removes the risk to interact with the cache while deleting it which will end up be racy in tests.
812
813         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
814         (WTR::TestRunner::clearDOMCache):
815         * WebKitTestRunner/TestController.cpp:
816         (WTR::ClearDOMCacheCallbackContext::ClearDOMCacheCallbackContext):
817         (WTR::clearDOMCacheCallback):
818         (WTR::TestController::clearDOMCache):
819         * WebKitTestRunner/TestInvocation.cpp:
820         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
821         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
822
823 2017-10-12  John Wilander  <wilander@apple.com>
824
825         ResourceLoadObserver::logFrameNavigation() should use redirectResponse.url()
826         https://bugs.webkit.org/show_bug.cgi?id=175257
827         <rdar://problem/33359866>
828
829         Reviewed by Brent Fulgham.
830
831         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
832         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
833         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
834         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
835         * WebKitTestRunner/InjectedBundle/TestRunner.h:
836         * WebKitTestRunner/TestController.cpp:
837         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
838             Not implemented.
839         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
840             Not implemented.
841         * WebKitTestRunner/TestController.h:
842         * WebKitTestRunner/TestInvocation.cpp:
843         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
844         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
845         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
846             Implemented platform-specific.
847         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
848             Implemented platform-specific.
849
850 2017-10-12  Andy Estes  <aestes@apple.com>
851
852         [iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
853         https://bugs.webkit.org/show_bug.cgi?id=178181
854         <rdar://problem/33660282>
855
856         Reviewed by Dan Bernstein.
857
858         * WebKitTestRunner/TestController.cpp:
859         (WTR::TestController::databaseProcessName):
860
861 2017-10-12  Myles C. Maxfield  <mmaxfield@apple.com>
862
863         Emit SPIR-V from WSL compiler (Part 1)
864         https://bugs.webkit.org/show_bug.cgi?id=177998
865
866         Reviewed by Filip Pizlo.
867
868         This patch implements the first half of a SPIR-V codegen phase for WSL.
869         This includes all the operations which aren't actually emitting the contents
870         of functions themselves. For example, this includes things like representing
871         WSL types with SPIR-V types, and declaring shaders' inputs and outputs. A
872         future patch will actually emit the contents of functions.
873
874         There are two helper visitors here: SPIRVTypeAnalyzer which generates SPIR-V
875         types from WSL types, and SPIRVPrimitiveVariableAnalyzer which identifies
876         input and output variables from a shader (and assigns location values to
877         each one).
878
879         This patch is currently pursuing the "logical mode" detailed in
880         https://bugs.webkit.org/show_bug.cgi?id=176967. In this mode, each pointer and
881         array reference operation can be statically traced to the variable or array it
882         is operating on.
883
884         This has the interesting property where accessing a pointer inside an array is
885         forbidden, because the array index may be computed at runtime, so the compiler
886         can't know at compile time which variable the pointer operation will be
887         accessing. However, this isn't true for structs; the program must statically
888         state which struct member it is accessing. Therefore, pointers or array
889         references must not transitively appear within an array, but they may appear
890         within a struct. The same logic applies to array references; those get lowered
891         to just two indexes in SPIR-V (a lower bound and an upper bound).
892
893         So, outside of an array, SPIR-V types don't need to include any pointers because
894         any operation with the pointer doesn't need access to the runtime value of the
895         pointer. Inside of an array, pointers are forbidden. Therefore, SPIR-V types
896         will never include any pointers.
897
898         This means that, for example, WSL can represent a linked list in logical mode.
899         However, a WSL program cannot iterate across the list, because that would require
900         assigning to a pointer. So instead, a program using a linked list could only say
901         something like "list.ptr->ptr->ptr->value".
902
903         * WebGPUShadingLanguageRI/LateChecker.js:
904         (LateChecker.prototype._checkShaderType):
905         * WebGPUShadingLanguageRI/SPIR-V.js:
906         (SPIRV.OperandChecker.prototype._isStar):
907         (SPIRV.OperandChecker.prototype.nextComparisonType):
908         (SPIRV.OperandChecker.prototype.finalize):
909         (SPIRV.OperandChecker):
910         * WebGPUShadingLanguageRI/SPIRV.html:
911         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Added.
912         (findEntryPoints):
913         (emitTypes.doEmitTypes):
914         (emitTypes):
915         (ConstantFinder.prototype.visitGenericLiteralType):
916         (ConstantFinder):
917         (generateSPIRV):
918         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Added.
919         (SPIRVTypeAnalyzer):
920         (SPIRVTypeAnalyzer.prototype.get program):
921         (SPIRVTypeAnalyzer.prototype.get typeMap):
922         (SPIRVTypeAnalyzer.prototype.get currentId):
923         (SPIRVTypeAnalyzer.prototype.get stack):
924         (SPIRVTypeAnalyzer.prototype.visitTypeRef):
925         (SPIRVTypeAnalyzer.prototype._encounterType):
926         (SPIRVTypeAnalyzer.prototype.visitNullType):
927         (SPIRVTypeAnalyzer.prototype.visitGenericLiteralType):
928         (SPIRVTypeAnalyzer.prototype.visitNativeType):
929         (SPIRVTypeAnalyzer.prototype.visitEnumType):
930         (SPIRVTypeAnalyzer.prototype.visitPtrType):
931         (SPIRVTypeAnalyzer.prototype.visitArrayRefType):
932         (SPIRVTypeAnalyzer.prototype.visitArrayType):
933         (SPIRVTypeAnalyzer.prototype.visitStructType):
934         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Added.
935         (SPIRVPrimitiveVariableAnalyzer):
936         (SPIRVPrimitiveVariableAnalyzer.prototype.get program):
937         (SPIRVPrimitiveVariableAnalyzer.prototype.get typeMap):
938         (SPIRVPrimitiveVariableAnalyzer.prototype.get currentId):
939         (SPIRVPrimitiveVariableAnalyzer.prototype.get currentLocation):
940         (SPIRVPrimitiveVariableAnalyzer.prototype.get nameComponents):
941         (SPIRVPrimitiveVariableAnalyzer.prototype.get result):
942         (SPIRVPrimitiveVariableAnalyzer.prototype.visitTypeRef):
943         (SPIRVPrimitiveVariableAnalyzer.prototype.visitNullType):
944         (SPIRVPrimitiveVariableAnalyzer.prototype.visitGenericLiteralType):
945         (SPIRVPrimitiveVariableAnalyzer.prototype.visitNativeType):
946         (SPIRVPrimitiveVariableAnalyzer.prototype.visitEnumType):
947         (SPIRVPrimitiveVariableAnalyzer.prototype.visitPtrType):
948         (SPIRVPrimitiveVariableAnalyzer.prototype.visitArrayRefType):
949         (SPIRVPrimitiveVariableAnalyzer.prototype.visitArrayType):
950         (SPIRVPrimitiveVariableAnalyzer.prototype.visitStructType):
951         * WebGPUShadingLanguageRI/WSL.md:
952         * WebGPUShadingLanguageRI/index.html:
953
954 2017-09-29  Filip Pizlo  <fpizlo@apple.com>
955
956         Enable gigacage on iOS
957         https://bugs.webkit.org/show_bug.cgi?id=177586
958
959         Reviewed by JF Bastien.
960         
961         Add a mode to test disabling Gigacage.
962
963         * Scripts/run-jsc-stress-tests:
964         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
965
966 2017-10-11  Sam Weinig  <sam@webkit.org>
967
968         Remove out-parameter variants of copyToVector
969         https://bugs.webkit.org/show_bug.cgi?id=178155
970
971         Reviewed by Tim Horton.
972
973         * DumpRenderTree/JavaScriptThreading.cpp:
974         (stopJavaScriptThreads):
975
976 2017-10-12  Sam Weinig  <sam@webkit.org>
977
978         It should be possible to iterate just the values (and not the counts) of a HashCountedSet
979         https://bugs.webkit.org/show_bug.cgi?id=178169
980
981         Reviewed by Daniel Bates.
982
983         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
984         (TestWebKitAPI::TEST):
985         Add test for HashCountedSet's new values() range.
986
987 2017-10-11  Frederic Wang  <fwang@igalia.com>
988
989         run-safari --ios-simulator is no longer working with Xcode 9
990         https://bugs.webkit.org/show_bug.cgi?id=177595
991
992         Reviewed by Daniel Bates.
993
994         In Xcode 9, the path of the simulator application is now in a new CoreSimulator subdirectory
995         of the iphoneOS SDK platform. This patch updates webkitdirs.pm to use the new path in
996         Xcode 9 or higher so that it is possible to run Safari on the iOS simulator again. It also
997         does some minor code refactoring to improve code reuse.
998
999         * Scripts/configure-xcode-for-ios-development: Move sdkDirectory() and sdkPlatformDirectory()
1000         into webkitdirs.
1001         (sdkDirectory): Deleted.
1002         (sdkPlatformDirectory): Deleted.
1003         * Scripts/webkitdirs.pm: Expose new sdkDirectory() and sdkPlatformDirectory().
1004         (sdkDirectory): Moved from configure-xcode-for-ios-development.
1005         (sdkPlatformDirectory): Ditto.
1006         (XcodeSDKPath): Rely on sdkDirectory() to implement this function.
1007         (iosSimulatorApplicationsPath): In Xcode 9 or higher use the new path. It is calculated
1008         by relying on sdkPlatformDirectory().
1009
1010 2017-10-11  Dewei Zhu  <dewei_zhu@apple.com>
1011
1012         run-benchmark script should set '__XPC_DYLD_FRAMEWORK_PATH' while launching local-built Safari on Mac.
1013         https://bugs.webkit.org/show_bug.cgi?id=178199
1014
1015         Reviewed by Saam Barati.
1016
1017         '__XPC_DYLD_FRAMEWORK_PATH' should be set while launching Safari on run-benchmark script.
1018         'force_remove' function should support both file and directory.
1019
1020         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1021         (OSXSafariDriver.launch_url):
1022         * Scripts/webkitpy/benchmark_runner/utils.py:
1023         (force_remove):
1024
1025 2017-10-11  Saam Barati  <sbarati@apple.com>
1026
1027         Runtime disable poly proto because it may be a 3-4% Speedometer regression
1028         https://bugs.webkit.org/show_bug.cgi?id=178192
1029
1030         Reviewed by JF Bastien.
1031
1032         * Scripts/run-jsc-stress-tests:
1033
1034 2017-10-11  Youenn Fablet  <youenn@apple.com>
1035
1036         Add API to clean CacheStorage data
1037         https://bugs.webkit.org/show_bug.cgi?id=178034
1038
1039         Reviewed by Chris Dumez.
1040
1041         Adding internals API to trigger deleting all or origin-persistent cache storage persistent data. 
1042
1043         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1044         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1045         (WTR::TestRunner::clearDOMCache):
1046         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1047         * WebKitTestRunner/TestController.cpp:
1048         (WTR::TestController::clearDOMCache):
1049         * WebKitTestRunner/TestController.h:
1050         * WebKitTestRunner/TestInvocation.cpp:
1051         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1052
1053 2017-10-11  Chris Dumez  <cdumez@apple.com>
1054
1055         [Geolocation] Expose Coordinates.floorLevel
1056         https://bugs.webkit.org/show_bug.cgi?id=178173
1057         <rdar://problem/34918936>
1058
1059         Reviewed by Ryosuke Niwa.
1060
1061         Add test infrastructure for testing Coordinates.floorLevel.
1062
1063         * DumpRenderTree/TestRunner.cpp:
1064         (setMockGeolocationPositionCallback):
1065         * DumpRenderTree/TestRunner.h:
1066         * DumpRenderTree/mac/TestRunnerMac.mm:
1067         (TestRunner::setMockGeolocationPosition):
1068         * DumpRenderTree/win/TestRunnerWin.cpp:
1069         (TestRunner::setMockGeolocationPosition):
1070         * WebKitTestRunner/GeolocationProviderMock.cpp:
1071         (WTR::GeolocationProviderMock::setPosition):
1072         * WebKitTestRunner/GeolocationProviderMock.h:
1073         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1074         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1075         (WTR::InjectedBundle::setMockGeolocationPosition):
1076         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1077         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1078         (WTR::TestRunner::setMockGeolocationPosition):
1079         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1080         * WebKitTestRunner/TestController.cpp:
1081         (WTR::TestController::setMockGeolocationPosition):
1082         * WebKitTestRunner/TestController.h:
1083         * WebKitTestRunner/TestInvocation.cpp:
1084         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1085
1086 2017-10-11  Youenn Fablet  <youenn@apple.com>
1087
1088         Bump default cache storage quota to 20MB
1089         https://bugs.webkit.org/show_bug.cgi?id=178132
1090
1091         Reviewed by Alex Christensen.
1092
1093         * WebKitTestRunner/TestController.cpp:
1094         (WTR::TestController::generateContextConfiguration const):
1095         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1096         (WTR::initializeWebViewConfiguration): Setting quota to 400kb
1097
1098 2017-10-11  Commit Queue  <commit-queue@webkit.org>
1099
1100         Unreviewed, rolling out r223113 and r223121.
1101         https://bugs.webkit.org/show_bug.cgi?id=178182
1102
1103         Reintroduced 20% regression on Kraken (Requested by rniwa on
1104         #webkit).
1105
1106         Reverted changesets:
1107
1108         "Enable gigacage on iOS"
1109         https://bugs.webkit.org/show_bug.cgi?id=177586
1110         https://trac.webkit.org/changeset/223113
1111
1112         "Use one virtual allocation for all gigacages and their
1113         runways"
1114         https://bugs.webkit.org/show_bug.cgi?id=178050
1115         https://trac.webkit.org/changeset/223121
1116
1117 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1118
1119         Sanitize URL in pasteboard for other applications and cross origin content
1120         https://bugs.webkit.org/show_bug.cgi?id=178060
1121         <rdar://problem/34874518>
1122
1123         Reviewed by Wenson Hsieh.
1124
1125         Added API tests for sanitizing URLs copied from web content, and that the original URL is exposed to the web content.
1126
1127         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1128         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm: Added.
1129         (readURLFromPasteboard): A helper function.
1130         * TestWebKitAPI/Tests/WebKitCocoa/copy-url.html: Added.
1131         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1132         (DataInteractionTests.DataTransferGetDataWhenDroppingCustomData): Rebaselined. https://www.apple.com is no longer
1133         normalized to https://www.apple.com/ by NSURL / UIPasteboard as expected.
1134         (DataInteractionTests.DataTransferSetDataValidURL): Added.
1135         (DataInteractionTests.DataTransferSetDataUnescapedURL): Added.
1136         (DataInteractionTests.qDataTransferSetDataInvalidURL): Added.
1137
1138 2017-10-11  Chris Dumez  <cdumez@apple.com>
1139
1140         Modernize Geolocation code
1141         https://bugs.webkit.org/show_bug.cgi?id=178148
1142
1143         Reviewed by Ryosuke Niwa.
1144
1145         * DumpRenderTree/mac/TestRunnerMac.mm:
1146         (TestRunner::setMockGeolocationPosition):
1147
1148 2017-10-11  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1149
1150         [GStreamer] Many media source tests crashing with GStreamer-CRITICAL **: _gst_util_uint64_scale: assertion 'denom != 0' failed in gst_qtdemux_configure_stream()
1151         https://bugs.webkit.org/show_bug.cgi?id=176804
1152
1153         Reviewed by Michael Catanzaro.
1154
1155         Add patch to fix assert in qtdemux.
1156
1157         * gstreamer/jhbuild.modules:
1158         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Added.
1159
1160 2017-10-11  Tomas Popela  <tpopela@redhat.com>
1161
1162         Use https for trac changeset and browser links
1163         https://bugs.webkit.org/show_bug.cgi?id=178167
1164
1165         Reviewed by Alexey Proskuryakov.
1166
1167         Switch the http://trac.webkit.org/changeset and
1168         http://trac.webkit.org/browser links that are printed by webkitpy to
1169         https. Also update the test expectations.
1170
1171         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1172         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1173         (CommitterValidatorTest.test_flag_permission_rejection_message):
1174         * Scripts/webkitpy/common/config/urls.py:
1175         (view_source_url):
1176         (view_revision_url):
1177         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1178         (BugTest.test_commit_revision):
1179         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1180         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1181         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1182         (MainTest):
1183         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1184         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1185         (ChangeLogCheckerTest.test_missing_bug_number):
1186         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1187         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1188         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1189         (IRCBotTest.test_rollout):
1190         (IRCBotTest.test_revert):
1191         (IRCBotTest.test_multi_rollout):
1192         (IRCBotTest.test_rollout_with_r_in_svn_revision):
1193         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
1194         (IRCBotTest.test_rollout_invalidate_reason):
1195         (test_multi_rollout_invalidate_reason):
1196         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1197         * Scripts/webkitpy/tool/commands/download_unittest.py:
1198         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1199         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1200         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1201         (SuggestNominations._count_commit):
1202         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1203         * Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js:
1204         (getTracUrl):
1205         (getSortedKeys):
1206         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
1207         (CloseBugForLandDiffTest.test_empty_state):
1208         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1209         (CommitTest._test_check_test_expectations):
1210         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1211         (UpdateChangeLogsForRevertTest):
1212
1213 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1214
1215         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1216         https://bugs.webkit.org/show_bug.cgi?id=178154
1217
1218         Reviewed by Wenson Hsieh.
1219
1220         Fixed the bug that LocalPasteboard would fail to load the promise type if data is set after declaring types
1221         by delaying the call to provideDataForType until when dataForType is called.
1222
1223         Without this fix, fast/events/dropzone-002.html would start failing after enabling custom pasteboard data.
1224         With this fix, fast/events/dropzone-005.html also starts passing.
1225
1226         * DumpRenderTree/mac/DumpRenderTree.mm:
1227         (resetWebPreferencesToConsistentValues):
1228         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
1229         (-[LocalPasteboard addTypes:owner:]):
1230         (-[LocalPasteboard dataForType:]):
1231         * WebKitTestRunner/TestController.cpp:
1232         (WTR::TestController::resetPreferencesToConsistentValues):
1233
1234 2017-10-10  Joanmarie Diggs  <jdiggs@igalia.com>
1235
1236         AX: [ATK] ARIA form role should be mapped to ATK_ROLE_LANDMARK; not ATK_ROLE_FORM
1237         https://bugs.webkit.org/show_bug.cgi?id=178137
1238
1239         Reviewed by Chris Fleizach.
1240
1241         Add handling for ATK_ROLE_LANDMARK resulting from the ARIA form role.
1242
1243         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1244
1245 2017-10-10  Jonathan Bedard  <jbedard@apple.com>
1246
1247         run-webkit-tests: upload test results to multiple servers
1248         https://bugs.webkit.org/show_bug.cgi?id=178012
1249         <rdar://problem/34856501>
1250
1251         Reviewed by Lucas Forschler.
1252
1253         Allowing uploading of results to multiple servers makes developing new results
1254         databases much easier, and does not complicate uploading logic.
1255
1256         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1257         (Manager.upload_results): Iterate through the list of results server hosts and
1258         send results to each one.
1259         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1260         (JSONLayoutResultsGenerator.__init__): Accept a list of test results servers.
1261         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1262         (JSONResultsGenerator.__init__): Accept a list of test results servers.
1263         (JSONResultsGenerator.get_json): Pick which server to download from by index.
1264         (JSONResultsGenerator.upload_json_files): Upload the JSON to each results server.
1265         (JSONResultsGenerator._get_archived_json_results): Pick which server to download from.
1266         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1267         (parse_args): Allow multiple test-results-servers and results-server-hosts to be
1268         passed to run-webkit-tests. 
1269
1270 2017-10-09  Youenn Fablet  <youenn@apple.com>
1271
1272         Vector should be able to easily create from a list of movable only items
1273         https://bugs.webkit.org/show_bug.cgi?id=176432
1274
1275         Reviewed by Darin Adler.
1276
1277         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1278         (TestWebKitAPI::TEST):
1279
1280 2017-09-29  Filip Pizlo  <fpizlo@apple.com>
1281
1282         Enable gigacage on iOS
1283         https://bugs.webkit.org/show_bug.cgi?id=177586
1284
1285         Reviewed by JF Bastien.
1286         
1287         Add a mode to test disabling Gigacage.
1288
1289         * Scripts/run-jsc-stress-tests:
1290         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
1291
1292 2017-10-09  Commit Queue  <commit-queue@webkit.org>
1293
1294         Unreviewed, rolling out r223015 and r223025.
1295         https://bugs.webkit.org/show_bug.cgi?id=178093
1296
1297         Regressed Kraken on iOS by 20% (Requested by keith_mi_ on
1298         #webkit).
1299
1300         Reverted changesets:
1301
1302         "Enable gigacage on iOS"
1303         https://bugs.webkit.org/show_bug.cgi?id=177586
1304         http://trac.webkit.org/changeset/223015
1305
1306         "Unreviewed, disable Gigacage on ARM64 Linux"
1307         https://bugs.webkit.org/show_bug.cgi?id=177586
1308         http://trac.webkit.org/changeset/223025
1309
1310 2017-10-09  Sam Weinig  <sam@webkit.org>
1311
1312         Make HashMap::keys() and HashMap::values() work with WTF::map/WTF::copyToVector
1313         https://bugs.webkit.org/show_bug.cgi?id=178072
1314
1315         Reviewed by Darin Adler.
1316
1317         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1318         (TestWebKitAPI::TEST):
1319         
1320             Add tests for HashMap::keys() and HashMap::values() working with copyToVector.
1321
1322 2017-10-05  Frederic Wang  <fwang@igalia.com>
1323
1324         Remove WOFF2 from Source/ThirdParty.
1325         https://bugs.webkit.org/show_bug.cgi?id=177862
1326
1327         Reviewed by Michael Catanzaro.
1328
1329         * Scripts/webkitpy/style/checker.py: Remove woff2.
1330         * gtk/jhbuild.modules: Add new jhbuild module for woff2.
1331
1332 2017-10-08  Sam Weinig  <sam@webkit.org>
1333
1334         It should be possible to create a ListHashSet with a std::initializer_list.
1335         https://bugs.webkit.org/show_bug.cgi?id=178070
1336
1337         Reviewed by Darin Adler.
1338
1339         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1340         (TestWebKitAPI::TEST):
1341         Add a test for using std::initializer_list with ListHashSet.
1342
1343 2017-10-08  Sam Weinig  <sam@webkit.org>
1344
1345         There should be a version of copyToVector that returns a Vector, rather than using an out parameter
1346         https://bugs.webkit.org/show_bug.cgi?id=177732
1347
1348         Reviewed by Saam Barati.
1349
1350         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1351         (TestWebKitAPI::TEST):
1352         Add tests for the new copyToVector and copyToVectorOf functions.
1353
1354 2017-10-08  Darin Adler  <darin@apple.com>
1355
1356         Fix bugs related to setting reflected floating point DOM attributes
1357         https://bugs.webkit.org/show_bug.cgi?id=178061
1358
1359         Reviewed by Sam Weinig.
1360
1361         * TestWebKitAPI/Tests/WTF/AtomicString.cpp: Added a test of the
1362         AtomicString::number function, based on the test cases we already
1363         had for String::numberToStringECMAScript, and with some additional
1364         cases with powers of 10 that check handling of trailng zeroes.
1365
1366         * TestWebKitAPI/Tests/WTF/WTFString.cpp: Added test cases to the
1367         existing tests of the String::numberToStringECMAScript function
1368         as above. Also added tests for String::number and for
1369         String::numberToStringFixedWidth. Also changed the tests to all use
1370         EXPECT instead of ASSERT macros since these are all non-fatal.
1371
1372         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1373         (WTR::dumpFrameScrollPosition): Use StringBuilder::appendECMAScriptNumber
1374         instead of String::number.
1375
1376 2017-10-08  Dean Jackson  <dino@apple.com>
1377
1378         Make sort-Xcode-project file handle UnifiedSources
1379         https://bugs.webkit.org/show_bug.cgi?id=178042
1380
1381         Reviewed by Sam Weinig.
1382
1383         Sort the UnifiedSource(\d+) files by number rather
1384         than alphabetically.
1385
1386         * Scripts/sort-Xcode-project-file:
1387         (sortChildrenByFileName):
1388         (sortFilesByFileName):
1389
1390 2017-09-29  Filip Pizlo  <fpizlo@apple.com>
1391
1392         Enable gigacage on iOS
1393         https://bugs.webkit.org/show_bug.cgi?id=177586
1394
1395         Reviewed by JF Bastien.
1396         
1397         Add a mode to test disabling Gigacage.
1398
1399         * Scripts/run-jsc-stress-tests:
1400         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
1401
1402 2017-10-06  Aishwarya Nirmal  <anirmal@apple.com>
1403
1404         [iOS] Respect the "caret-color" CSS property when editing
1405         https://bugs.webkit.org/show_bug.cgi?id=177489
1406         <rdar://problem/34600419>
1407
1408         Reviewed by Tim Horton.
1409
1410         Adds test for iOS caret color support.
1411
1412         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1413         (TestWebKitAPI::TEST):
1414         * TestWebKitAPI/ios/UIKitSPI.h:
1415
1416 2017-10-06  Alex Christensen  <achristensen@webkit.org>
1417
1418         Add more infrastructure to apply custom header fields to same-origin requests
1419         https://bugs.webkit.org/show_bug.cgi?id=177629
1420
1421         Reviewed by Ryosuke Niwa.
1422
1423         * TestWebKitAPI/Tests/WebCore/HTTPHeaderField.cpp:
1424         (canonicalizeHTTPHeader):
1425         (shouldRemainUnchanged):
1426         (shouldBeInvalid):
1427         (shouldBecome):
1428         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1429         (TEST):
1430         (expectHeaders):
1431         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1432         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
1433         (-[CustomHeaderFieldsDelegate webView:stopURLSchemeTask:]):
1434
1435         Test main resource requests, subresource requests, and cross-origin requests.
1436
1437 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1438
1439         [iOS] Tweak support for classifying form controls (followup to r222487)
1440         https://bugs.webkit.org/show_bug.cgi?id=177917
1441         <rdar://problem/34820122>
1442
1443         Reviewed by Dean Jackson.
1444
1445         Minor cleanup around autofill API tests added in r222487. Additionally, augments some of these API tests to
1446         verify that after blurring the focused element, the content view no longer accepts autofill credentials (see
1447         WebKit ChangeLog for more details). Also augments tests to verify that the URL in the autofill context matches
1448         the document URL.
1449
1450         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1451
1452         Remove the USE(APPLE_INTERNAL_SDK) guard for these API tests.
1453
1454         (newUIKeyboardLoginCredentialsSuggestion):
1455
1456         Add a stub implementation of UIKeyboardLoginCredentialsSuggestion. This allows
1457         [UIKeyboardLoginCredentialsSuggestion new] to return a nonnull object, which allows these API tests to verify
1458         that the credential filling codepath works as intended without any additional UIKit changes. Currently, tests
1459         for the value of username and password fields are passing even though the fields are not being populated because
1460         the expected string values are null, and the observed value is an empty string. We instead check the literal
1461         string values here instead of credentialSuggestion's properties, so that tests verifying the behavior of
1462         -insertTextSuggestion: will require username and password inputs to be populated.
1463
1464         (-[TestInputDelegate _webView:focusShouldStartInputSession:]):
1465         (-[AutofillTestView initWithFrame:]):
1466         (-[AutofillTestView _autofillInputView]):
1467         (-[AutofillTestView textInputHasAutofillContext]):
1468         (TestWebKitAPI::TEST):
1469
1470         Add an additional API test to verify that programmatic focus without user interaction (and also without testing
1471         overrides) does not activate autofill.
1472
1473         (createUIKeyboardLoginCredentialsSuggestion): Deleted.
1474         (-[WKWebView _privateTextInput]): Deleted.
1475         * TestWebKitAPI/ios/UIKitSPI.h:
1476
1477         Minor gardening to remove iOS version >= 11 guards that are now unnecessary. Additionally, add some more private
1478         header imports (with corresponding interface definitions for building and running with the public SDK).
1479
1480 2017-10-06  Antti Koivisto  <antti@apple.com>
1481
1482         Minor WeakPtr improvements
1483         https://bugs.webkit.org/show_bug.cgi?id=177958
1484
1485         Reviewed by Sam Weinig.
1486
1487         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1488         (TestWebKitAPI::TEST):
1489         (TestWebKitAPI::Base::createWeakPtr): Deleted.
1490
1491 2017-10-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1492
1493         Unreviewed. Fix parsing of GTK unit tests output in bot configuration.
1494
1495         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1496         (RunGtkAPITests.commandComplete): Remove trailing ':' from the regular expression.
1497
1498 2017-10-06  Charles Turner  <cturner@igalia.com>
1499
1500         Disable bmalloc when running Valgrind
1501         https://bugs.webkit.org/show_bug.cgi?id=177923
1502
1503         Reviewed by Carlos Alberto Lopez Perez.
1504
1505         * Scripts/webkitpy/port/gtk.py:
1506         (GtkPort.setup_environ_for_server):
1507
1508 2017-10-06  Zan Dobersek  <zdobersek@igalia.com>
1509
1510         Implement TestController::platformContext() for WPE, returning the
1511         m_context pointer as the GTK+ port does. This fixes the crashes on
1512         the WPE testers.
1513
1514         Rubber-stamped by Carlos Garcia Campos.
1515
1516         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
1517         (WTR::TestController::platformContext):
1518
1519 2017-10-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1520
1521         [GTK][WPE] Add API to configure and enable resource load statistics
1522         https://bugs.webkit.org/show_bug.cgi?id=177943
1523
1524         Reviewed by Michael Catanzaro.
1525
1526         Add a command line option to enable intelligent tracking prevention to MiniBrowser and tests cases to check the
1527         new API.
1528
1529         * MiniBrowser/gtk/main.c:
1530         (main):
1531         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1532         (serverCallback):
1533         (testWebsiteDataConfiguration):
1534         (testWebsiteDataEphemeral):
1535         (testWebsiteDataResourceLoadStats):
1536         (beforeAll):
1537         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1538         (Test::Test):
1539         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1540         (directoryChangedCallback):
1541         (WebViewTest::waitUntilFileExists):
1542         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1543
1544 2017-10-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1545
1546         [GTK][WPE] All resource load statistics tests added in r212183 crash in GTK bots, timeout in GTK and WPE bots since r219049
1547         https://bugs.webkit.org/show_bug.cgi?id=168171
1548
1549         Reviewed by Chris Dumez.
1550
1551         Implement all resource load statistics functions in TestController using the C API. Also enable the FileMonitor
1552         unit test. This test requires a platform implementation of Util::run(), so I've added UtilitiesGLib.cpp with an
1553         iplementation common to glib based ports using WTF RunLoop abstraction.
1554
1555         * TestWebKitAPI/PlatformGTK.cmake:
1556         * TestWebKitAPI/PlatformWPE.cmake:
1557         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1558         * TestWebKitAPI/glib/UtilitiesGLib.cpp: Copied from Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h.
1559         (TestWebKitAPI::Util::run):
1560         (TestWebKitAPI::Util::spinRunLoop):
1561         (TestWebKitAPI::Util::sleep):
1562         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1563         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp:
1564         * WebKitTestRunner/TestController.cpp:
1565         (WTR::TestController::platformAdjustContext):
1566         (WTR::TestController::setStatisticsLastSeen):
1567         (WTR::TestController::setStatisticsPrevalentResource):
1568         (WTR::ResourceStatisticsCallbackContext::ResourceStatisticsCallbackContext):
1569         (WTR::resourceStatisticsCallback):
1570         (WTR::TestController::isStatisticsPrevalentResource):
1571         (WTR::TestController::setStatisticsHasHadUserInteraction):
1572         (WTR::TestController::isStatisticsHasHadUserInteraction):
1573         (WTR::TestController::setStatisticsGrandfathered):
1574         (WTR::TestController::isStatisticsGrandfathered):
1575         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
1576         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
1577         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
1578         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1579         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
1580         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1581         (WTR::TestController::statisticsUpdateCookiePartitioning):
1582         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1583         (WTR::TestController::statisticsSubmitTelemetry):
1584         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1585         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1586         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1587         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1588         (WTR::TestController::setStatisticsGrandfatheringTime):
1589         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1590         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1591         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1592         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1593         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
1594         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1595         (WTR::TestController::statisticsResetToConsistentState):
1596         * WebKitTestRunner/TestController.h:
1597
1598 2017-10-05  Jer Noble  <jer.noble@apple.com>
1599
1600         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1601         https://bugs.webkit.org/show_bug.cgi?id=177261
1602
1603         Reviewed by Eric Carlson.
1604
1605         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1606
1607 2017-10-05  Alex Christensen  <achristensen@webkit.org>
1608
1609         Add ObjC equivalent of WKPageNavigationClient.didChangeBackForwardList
1610         https://bugs.webkit.org/show_bug.cgi?id=177966
1611         <rdar://problem/22387135>
1612
1613         Reviewed by Tim Horton.
1614
1615         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1616         (-[ListItemDelegate _webView:backForwardListItemAdded:removed:]):
1617         (-[ListItemDelegate webView:didFinishNavigation:]):
1618         (TEST):
1619
1620 2017-10-04  Megan Gardner  <megan_gardner@apple.com>
1621
1622         check-webkit-style erroneously requires a space between the carrot and brace in obj-c blocks.
1623         https://bugs.webkit.org/show_bug.cgi?id=177897
1624
1625         Reviewed by Dan Bernstein and Jonathan Bedard.
1626
1627         Remove the check for a space between ^ and {, 
1628         as this is valid and expected Obj-C. Now check to make sure there is
1629         no space at all between ^ and {, and also that there is a space between
1630         the end of an argument list and the {.
1631
1632         * Scripts/webkitpy/style/checkers/cpp.py:
1633         (regex_for_lambdas_and_blocks):
1634
1635 2017-10-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1636
1637         Unreviewed. Run WebKit2 C API tests in GTK+ bots again after the last WebKit2 -> WebKit rename.
1638
1639         * Scripts/run-gtk-tests:
1640         (TestRunner):
1641         (TestRunner._run_test):
1642
1643 2017-10-05  Darin Adler  <darin@apple.com>
1644
1645         Remove additional WebKitSystemInterface remnants
1646         https://bugs.webkit.org/show_bug.cgi?id=177948
1647
1648         Reviewed by Andy Estes.
1649
1650         * DumpRenderTree/PlatformMac.cmake: Removed code to link the
1651         WebKitSystemInterface library. Left in code that points to
1652         the WebKitLibraries directory, but maybe that can be removed by
1653         someone who is more certain it's no longer needed.
1654
1655         * Scripts/copy-webkitlibraries-to-product-directory: Removed code
1656         to copy and delete WebKitSystemInterface libraries and headers.
1657
1658         * WebKitTestRunner/PlatformMac.cmake: Removed code to link the
1659         WebKitSystemInterface library. Left in code that points to
1660         the WebKitLibraries directory, but maybe that can be removed by
1661         someone who is more certain it's no longer needed.
1662
1663 2017-10-05  Saam Barati  <sbarati@apple.com>
1664
1665         Unreviewed. Try to make debug type profiler tests stop timing out.
1666
1667         * Scripts/run-jsc-stress-tests:
1668
1669 2017-10-03  Frederic Wang  <fwang@igalia.com>
1670
1671         Remove Brotli from Source/ThirdParty
1672         https://bugs.webkit.org/show_bug.cgi?id=177804
1673
1674         Reviewed by Michael Catanzaro.
1675
1676         * gtk/jhbuild.modules: Build brotli 1.0.1 from the official github repository.
1677         * Scripts/webkitpy/style/checker.py: Remove brotli.
1678
1679 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1680
1681         Stop linking with WebKitSystemInterface
1682         https://bugs.webkit.org/show_bug.cgi?id=177915
1683
1684         Reviewed by Antti Koivisto.
1685
1686         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1687         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1688         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1689         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1690         * WebKitTestRunner/Configurations/Base.xcconfig:
1691         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1692         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1693         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1694         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1695
1696 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1697
1698         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1699         https://bugs.webkit.org/show_bug.cgi?id=177912
1700
1701         Reviewed by Saam Barati.
1702
1703         * DumpRenderTree/mac/DumpRenderTree.mm:
1704
1705 2017-10-04  Megan Gardner  <megan_gardner@apple.com>
1706
1707         Break out new touch debugging code into seperate file
1708         https://bugs.webkit.org/show_bug.cgi?id=177796
1709
1710         Reviewed by Simon Fraser.
1711
1712         Encapsulate the new debug touch code into it's own file.
1713         This allows for cleaner code and a better way to show the touches
1714         in a completely separate window, which should also be in screen
1715         coordinates, and not subject to any transforms that get put on the
1716         WebViews.
1717
1718         * TestRunnerShared/spi/UIKitTestSPI.h:
1719         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1720         * WebKitTestRunner/ios/HIDDebugTouchWindow.h: Added.
1721         * WebKitTestRunner/ios/HIDDebugTouchWindow.mm: Added.
1722         (+[HIDDebugTouchWindow sharedHIDDebugTouchWindow]):
1723         (-[HIDDebugTouchWindow init]):
1724         (-[HIDDebugTouchWindow dealloc]):
1725         (-[HIDDebugTouchWindow updateDebugIndicatorForTouch:withPointInWindowCoordinates:isTouching:]):
1726         (-[HIDDebugTouchWindow initDebugViewsIfNeeded]):
1727         * WebKitTestRunner/ios/HIDEventGenerator.h:
1728         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1729         (-[HIDEventGenerator init]):
1730         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
1731         (-[HIDEventGenerator _createIOHIDEventType:]):
1732         (-[HIDEventGenerator _updateTouchPoints:count:]):
1733         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
1734         (-[HIDEventGenerator touchDown:touchCount:]):
1735         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
1736         (-[HIDEventGenerator liftUp:touchCount:]):
1737         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1738         (-[HIDEventGenerator initDebugViewsIfNeeded]): Deleted.
1739         (-[HIDEventGenerator updateDebugIndicatorForTouch:withPoint:isTouching:]): Deleted.
1740         * WebKitTestRunner/ios/TestControllerIOS.mm:
1741         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
1742
1743 2017-10-04  JF Bastien  <jfbastien@apple.com>
1744
1745         WTF: Update std::expected to match current proposal
1746         https://bugs.webkit.org/show_bug.cgi?id=177881
1747
1748         Reviewed by Mark Lam.
1749
1750         The proposal is likely to be in C++20 and I've been asked to help co-champion
1751         it. I'm therefore updating our implementation to more closely match the current
1752         proposal, and to make sure it'll work for us if standardized.
1753
1754          - Rename UnexpectedType to Unexpected to match the proposal.
1755          - Remove relational operators, only equality / inequality remains.
1756          - Fix minor type signatures.
1757          - Add UnexpectedType typedef.
1758          - Uncomment rebind implementation.
1759          - Add in-place construction tag, as well as explicit error construction tag.
1760          - Add template unexpected constructor.
1761          - Note that make_unexpected isn't in the proposal anymore, but we keep it because we don't have C++17 deduction guides.
1762          - Remove hashing, which isn't in the proposal anymore.
1763
1764         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1765         (WTF::operator<<):
1766         (TestWebKitAPI::TEST):
1767
1768 2017-10-04  Lucas Forschler  <lforschler@apple.com>
1769
1770         https://bugs.webkit.org/show_bug.cgi?id=177888
1771         WebKitArchiveSupport - add API Gateway to source control
1772         This is a swagger configuration export via AWS API Gateway console.
1773
1774         Rubber-stamped by Alexey Proskuryakov.
1775
1776         * WebKitArchiveSupport/AWS-APIGateway: Added.
1777         * WebKitArchiveSupport/AWS-APIGateway/stage-v2.json: Added.
1778
1779 2017-10-04  Mark Lam  <mark.lam@apple.com>
1780
1781         Add support for using Probe DFG OSR Exit behind a runtime flag.
1782         https://bugs.webkit.org/show_bug.cgi?id=177844
1783         <rdar://problem/34801425>
1784
1785         Reviewed by Saam Barati.
1786
1787         Enable --useProbeOSrExit=true for dfg-eager and ftl-no-cjit-validate-sampling-profiler
1788         test configurations.
1789
1790         * Scripts/run-jsc-stress-tests:
1791
1792 2017-10-04  Jonathan Bedard  <jbedard@apple.com>
1793
1794         webkitpy.tool.steps.steps_unittest.StepsTest.test_runtests_api is flakey
1795         https://bugs.webkit.org/show_bug.cgi?id=177751
1796         <rdar://problem/34769470>
1797
1798         Reviewed by Daniel Bates.
1799
1800         Port._build_path() calls Tools/Scripts/webkit-build-directory and caches this
1801         result. When capturing output from the MockExecutive, the first invocation of
1802         Port._build_path() will log the running of Tools/Scripts/webkit-build-directory
1803         but subsequent invocations will not.
1804
1805         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1806         (StepsTest):
1807         (StepsTest.setUp): Cache the build path before running tests.
1808
1809 2017-10-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1810
1811         [JHBuild][GTK][WKE] Circular dependency between harfbuzz and freetype6
1812         https://bugs.webkit.org/show_bug.cgi?id=177865
1813
1814         Reviewed by Michael Catanzaro.
1815
1816         Build freetype6 without harfbuzz support.
1817         This seems to be what distros like Fedora, Debian or OpenEmbedded do.
1818         Also explicitly enable support for freetype and fontconfig on harfbuzz.
1819
1820         * gtk/jhbuild.modules: Enable also support for icu.
1821         * wpe/jhbuild.modules:
1822
1823 2017-10-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1824
1825         [Test262] Update Test262 to Oct 4 version
1826         https://bugs.webkit.org/show_bug.cgi?id=177859
1827
1828         Reviewed by Sam Weinig.
1829
1830         * Scripts/import-test262-tests:
1831
1832 2017-10-04  Ryosuke Niwa  <rniwa@webkit.org>
1833
1834         Use blob URL when pasting RTFD instead of overriding DocumentLoader
1835         https://bugs.webkit.org/show_bug.cgi?id=177801
1836         <rdar://problem/34542270>
1837
1838         Reviewed by Wenson Hsieh.
1839
1840         Added a regression test for an assertion failure when pasting an empty RTFD as well as a test for pasting
1841         RTFD with an image, which should result in an image element with a blob URL.
1842
1843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1844         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1845         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
1846         * TestWebKitAPI/Tests/WebKitCocoa/paste-rtfd.html:
1847
1848 2017-10-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1849
1850         [GLib] Let WebCore know of low power situations
1851         https://bugs.webkit.org/show_bug.cgi?id=177810
1852
1853         Reviewed by Carlos Garcia Campos.
1854
1855         * gtk/install-dependencies: add upower-glib dev packages for Debian, Arch and Fedora.
1856
1857 2017-10-03  Saam Barati  <sbarati@apple.com>
1858
1859         Implement polymorphic prototypes
1860         https://bugs.webkit.org/show_bug.cgi?id=176391
1861
1862         Reviewed by Filip Pizlo.
1863
1864         * Scripts/run-jsc-stress-tests:
1865
1866 2017-10-03  Myles C. Maxfield  <mmaxfield@apple.com> 
1867
1868         Create a SPIR-V assembler 
1869         https://bugs.webkit.org/show_bug.cgi?id=177726 
1870
1871         Reviewed by Filip Pizlo. 
1872
1873         Khronos has released a json file containing every SPIR-V opcode and operand at 
1874         https://github.com/KhronosGroup/SPIRV-Headers/blob/master/include/spirv/1.2/spirv.core.grammar.json 
1875         This patch creates a function which loads this file (via the fetch API), parses it, and creates
1876         an object which holds two things: 
1877         - For each opcode, a class which accepts the appropriate operands 
1878         - For each enum type, an object which holds each enum value 
1879         The constructor for each opcode is smart enough to do some basic type-checking of the argument, 
1880         according to the types listed in Khronos's json file. 
1881
1882         This patch also includes an example .html file which outputs a dummy SPIR-V program, 
1883         which happens to be compatible with the SPIR-V demo at 
1884         https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/blob/master/demos/cube.cpp 
1885         If you modify this demo to use the generated SPIR-V program, you can see the result in 
1886         action.
1887
1888         This patch also commits a copy of Khronos's json file mentioned above. This isn't the first 
1889         Khronos file we've committed into our repository with this license, so there shouldn't be any 
1890         problems there. 
1891
1892         * WebGPUShadingLanguageRI/SPIR-V.js: Added. 
1893         (SPIRV.): 
1894         (SPIRVAssembler): 
1895         (SPIRVAssembler.prototype.append): 
1896         (SPIRVAssembler.prototype.get size): 
1897         (SPIRVAssembler.prototype.get storage): 
1898         (SPIRVAssembler.prototype.get result): 
1899         * WebGPUShadingLanguageRI/SPIRV.html: Added. 
1900         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Added. 
1901
1902 2017-10-03  Chris Dumez  <cdumez@apple.com>
1903
1904         SharedStringHashStore should support removing hashes
1905         https://bugs.webkit.org/show_bug.cgi?id=177770
1906
1907         Reviewed by Alex Christensen.
1908
1909         Add API test coverage.
1910
1911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1912         * TestWebKitAPI/Tests/WebKitCocoa/VisitedLinkStore.mm: Added.
1913         (TestWebKitAPI::TEST):
1914
1915 2017-10-03  Dewei Zhu  <dewei_zhu@apple.com>
1916
1917         Fix missing import for BenchmarkRunner.
1918         https://bugs.webkit.org/show_bug.cgi?id=177842
1919
1920         Reviewed by Ryosuke Niwa.
1921
1922         'show_results' requires BenchmarkRunner.
1923
1924         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1925
1926 2017-10-03  Olivier Blin  <olivier.blin@softathome.com>
1927
1928         [WPE] Bump deps to add support for xdg-shell-unstable-v6 protocol
1929         https://bugs.webkit.org/show_bug.cgi?id=177820
1930
1931         Reviewed by Žan Doberšek.
1932
1933         gnome-shell does not advertize the xdg-shell protocol anymore, but xdg-shell-unstable-v6 instead.
1934         Support has been added in WPEBackend-mesa, we need to update the requirements.
1935         wayland-1.10 is needed for wl_proxy_get_version(), used in the generated headers.
1936
1937         * wpe/jhbuild.modules:
1938
1939 2017-10-03  Alex Christensen  <achristensen@webkit.org>
1940
1941         Add ObjC SPI equivalent to WKPageLoaderClient.willGoToBackForwardListItem
1942         https://bugs.webkit.org/show_bug.cgi?id=177825
1943         <rdar://problem/22387505>
1944
1945         Reviewed by Tim Horton.
1946
1947         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1948         (-[BackForwardDelegate _webView:willGoToBackForwardListItem:inPageCache:]):
1949         (-[BackForwardDelegate webView:didFinishNavigation:]):
1950         (TEST):
1951
1952 2017-10-03  Antti Koivisto  <antti@apple.com>
1953
1954         Allow assigning WeakPtr<Derived> to WeakPtr<Base>
1955         https://bugs.webkit.org/show_bug.cgi?id=177817
1956
1957         Reviewed by Geoff Garen.
1958
1959         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1960         (TestWebKitAPI::Base::weakPtrFactory):
1961         (TestWebKitAPI::TEST):
1962
1963 2017-10-03  Youenn Fablet  <youenn@apple.com>
1964
1965         Remove no longer needed WebRTC build infrastructure
1966         https://bugs.webkit.org/show_bug.cgi?id=177756
1967
1968         Reviewed by Alejandro G. Castro.
1969
1970         * Scripts/generate-libwebrtc-cmake: Removed.
1971         * Scripts/webkitpy/libwebrtc/__init__.py: Removed.
1972         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Removed.
1973
1974 2017-10-03  Joanmarie Diggs  <jdiggs@igalia.com>
1975
1976         AX: [ATK] ARIA drag-and-drop attribute values should be exposed via AtkObject attributes
1977         https://bugs.webkit.org/show_bug.cgi?id=177763
1978
1979         Reviewed by Chris Fleizach.
1980
1981         Implement ariaIsGrabbed() and ariaDropEffects() for ATK.
1982
1983         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1984         (WTR::AccessibilityUIElement::ariaIsGrabbed const):
1985         (WTR::AccessibilityUIElement::ariaDropEffects const):
1986
1987 2017-10-02  Myles C. Maxfield  <mmaxfield@apple.com>
1988
1989         Make WSL demo compatible with Microsoft Edge
1990         https://bugs.webkit.org/show_bug.cgi?id=177643
1991
1992         Reviewed by Saam Barati.
1993
1994         This patch does two things. The first is it migrates a loop over ParentNode.children to a legacy style loop
1995         because Microsoft Edge throws an exception when trying to use a for...of loop with it. This patch also hides
1996         the compilation behind a setTimeout(0) so there is some indication that something is happening during a
1997         compile.
1998
1999
2000         * Tools/WebGPUShadingLanguageRI/index.html:
2001
2002 2017-10-02  Joanmarie Diggs  <jdiggs@igalia.com>
2003
2004         AX: [ATK] The value of aria-level is not exposed on non-heading roles
2005         https://bugs.webkit.org/show_bug.cgi?id=177775
2006
2007         Reviewed by Chris Fleizach.
2008
2009         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2010         (WTR::AccessibilityUIElement::hierarchicalLevel const):
2011
2012 2017-10-02  Geoffrey Garen  <ggaren@apple.com>
2013
2014         WeakPtr should have a move constructor
2015         https://bugs.webkit.org/show_bug.cgi?id=177789
2016
2017         Reviewed by Chris Dumez.
2018
2019         Chris made me write an API test. It wasn't that painful.
2020
2021         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2022         (TestWebKitAPI::TEST):
2023
2024 2017-10-02  Filip Pizlo  <fpizlo@apple.com>
2025
2026         WSL ^ should be *
2027         https://bugs.webkit.org/show_bug.cgi?id=177705
2028
2029         Rubber stamped by Keith Miller.
2030         
2031         When I first wrote the prototype, I thought it would be cool to use ^ for pointers. Nobody agrees. I've
2032         gotten so much feedback to use *. This changes pointers to use *.
2033
2034         * WebGPUShadingLanguageRI/DereferenceExpression.js:
2035         (DereferenceExpression.prototype.toString):
2036         (DereferenceExpression):
2037         * WebGPUShadingLanguageRI/Intrinsics.js:
2038         (Intrinsics):
2039         * WebGPUShadingLanguageRI/Parse.js:
2040         (parseType):
2041         (parsePossiblePrefix):
2042         * WebGPUShadingLanguageRI/PtrType.js:
2043         (PtrType.prototype.toString):
2044         (PtrType):
2045         * WebGPUShadingLanguageRI/StandardLibrary.js:
2046         * WebGPUShadingLanguageRI/Test.js:
2047         (tests.simpleDereference):
2048         (tests.dereferenceStore):
2049         (tests.simpleMakePtr):
2050         (tests.loadNull):
2051         (tests.storeNull):
2052         (tests.returnNull):
2053         (tests.dereferenceDefaultNull):
2054         (tests.defaultInitializedNull):
2055         (tests.passNullToPtrMonomorphic):
2056         (tests.passNullToPtrPolymorphic):
2057         (tests.passNullAndNotNull):
2058         (tests.passNullAndNotNullFullPoly):
2059         (tests.passNullAndNotNullFullPolyReverse):
2060         (tests.chainGeneric):
2061         (tests.chainStruct):
2062         (tests.chainStructNewlyValid):
2063         (tests.chainStructDevice):
2064         (tests.paramChainStructDevice):
2065         (tests.simpleProtocolExtends):
2066         (tests.protocolExtendsTwo):
2067         (tests.overrideSubscriptStruct):
2068         (tests.overrideSubscriptStructAndDoStores):
2069         (tests.overrideSubscriptStructAndUsePointers):
2070         (tests.overrideSubscriptStructAndUsePointersIncorrectly):
2071         (tests.makeArrayRefFromPointer):
2072         (tests.nonArrayRefArrayLengthFail):
2073         (tests.constexprIsNotLValuePtr):
2074         (tests.genericAccessors):
2075         (tests.nestedSubscriptLValueEmulationSimple):
2076         (tests.nestedSubscriptLValueEmulationGeneric):
2077         (tests.shaderTypes):
2078         (tests.enumPtrBase):
2079         (tests.mutuallyRecursiveStructWithPointersBroken):
2080         (tests.mutuallyRecursiveStructWithPointers):
2081         (tests.linkedList):
2082         (tests.pointerToPointer):
2083         (tests.pointerGetter):
2084         (tests.operatorCastWithTypeVariableInferredFromReturnType):
2085         (tests.loneSetterPointer):
2086         (tests.anderWithNothingWrong):
2087         (tests.anderWithWrongNumberOfArguments):
2088         (tests.anderDoesntReturnPointer):
2089         (tests.anderDoesntTakeReference):
2090         (tests.anderWithArrayRef):
2091         (tests.pointerIndexGetter):
2092         (tests.loneIndexSetterPointer):
2093         (tests.indexAnderWithNothingWrong):
2094         (tests.indexAnderWithWrongNumberOfArguments):
2095         (tests.indexAnderDoesntReturnPointer):
2096         (tests.indexAnderDoesntTakeReference):
2097         (tests.indexAnderWithArrayRef):
2098         (tests.devicePtrPtr):
2099         (tests.threadgroupPtrPtr):
2100         (tests.constantPtrPtr):
2101         (tests.pointerIndexGetterInProtocol):
2102         (tests.loneIndexSetterPointerInProtocol):
2103         (tests.indexAnderWithNothingWrongInProtocol):
2104         (tests.indexAnderWithWrongNumberOfArgumentsInProtocol):
2105         (tests.indexAnderDoesntReturnPointerInProtocol):
2106         (tests.indexAnderDoesntTakeReferenceInProtocol):
2107         (tests.indexAnderWithArrayRefInProtocol):
2108         (tests.andReturnedArrayRef):
2109
2110 2017-10-02  Filip Pizlo  <fpizlo@apple.com>
2111
2112         WSL should be fine with &foo()[i] if foo() returns a []
2113         https://bugs.webkit.org/show_bug.cgi?id=177704
2114
2115         Reviewed by Saam Barati.
2116         
2117         Previously, we'd determine if a property access expression (base.field or base[index]) was an lvalue by
2118         asking if its base was an lvalue. This is right in all cases except if the base is of type []. Then, the
2119         property access expression is an lvalue so long as there is a setter or ander.
2120         
2121         This fixes the issue and adds a test.
2122         
2123         Also, this makes error messages in the case that something is not an lvalue a lot better. If something
2124         is not an lvalue because we could not find anders or setters, then we will tell you why we could not
2125         find them.
2126
2127         * WebGPUShadingLanguageRI/Checker.js:
2128         (Checker.prototype.visitAssignment):
2129         (Checker.prototype.visitReadModifyWriteExpression):
2130         (Checker.prototype.visitMakePtrExpression):
2131         (Checker.prototype._finishVisitingPropertyAccess):
2132         * WebGPUShadingLanguageRI/DotExpression.js:
2133         (DotExpression.prototype.get fieldName):
2134         (DotExpression.prototype.get isLValue): Deleted.
2135         (DotExpression.prototype.get addressSpace): Deleted.
2136         * WebGPUShadingLanguageRI/IndexExpression.js:
2137         (IndexExpression.prototype.get index):
2138         (IndexExpression.prototype.get isLValue): Deleted.
2139         (IndexExpression.prototype.get addressSpace): Deleted.
2140         * WebGPUShadingLanguageRI/PropertyAccessExpression.js:
2141         (PropertyAccessExpression):
2142         (PropertyAccessExpression.prototype.get isLValue):
2143         (PropertyAccessExpression.prototype.set isLValue):
2144         * WebGPUShadingLanguageRI/PropertyResolver.js:
2145         (PropertyResolver.prototype._visitRValuesWithinLValue.RValueFinder.prototype.visitMakeArrayRefExpression):
2146         (PropertyResolver.prototype._visitRValuesWithinLValue.RValueFinder):
2147         (PropertyResolver.prototype._visitRValuesWithinLValue):
2148         * WebGPUShadingLanguageRI/Test.js:
2149         (tests.storeNullArrayRef):
2150         (tests.andReturnedArrayRef):
2151
2152 2017-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2153
2154         Guard iOS webkitGetAsEntry API tests on older iOS versions
2155
2156         Unreviewed test gardening. After r222688, these tests require custom pasteboard data to be enabled by default,
2157         so don't run them against shipping iOS.
2158
2159         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2160
2161 2017-10-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2162
2163         [WPE][GTK] Crash in webkit_web_resource_get_data_finish()
2164         https://bugs.webkit.org/show_bug.cgi?id=177107
2165
2166         Reviewed by Michael Catanzaro.
2167
2168         Add a test case to check we handle errors when webkit_web_resource_get_data() fails.
2169
2170         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2171         (webViewloadChanged):
2172         (testWebResourceGetDataError):
2173         (beforeAll):
2174
2175 2017-10-02  Alex Christensen  <achristensen@webkit.org>
2176
2177         Fix build after r222715
2178         https://bugs.webkit.org/show_bug.cgi?id=177697
2179
2180         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2181         (TEST):
2182         Use the public API instead of the removed SPI.
2183
2184 2017-10-02  Alex Christensen  <achristensen@webkit.org>
2185
2186         REGRESSION(r214201): WebProcess hangs during policy decisions
2187         https://bugs.webkit.org/show_bug.cgi?id=177590
2188         <rdar://problem/33362929>
2189
2190         Reviewed by Andy Estes.
2191
2192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2193         * TestWebKitAPI/Tests/WebKitCocoa/JavaScriptDuringNavigation.mm: Added.
2194         (-[JSNavigationDelegate webView:didFinishNavigation:]):
2195         (-[JSNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2196         (-[JSNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2197         (-[JSNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2198         (TEST):
2199
2200 2017-10-02  Jonathan Bedard  <jbedard@apple.com>
2201
2202         Log stack-trace for run-webkit-tests when interrupted
2203         https://bugs.webkit.org/show_bug.cgi?id=176393
2204         <rdar://problem/34262310>
2205
2206         Reviewed by Darin Adler.
2207
2208         When run-webkit-tests is stuck, it is difficult to immediately tell
2209         why. Saving a stack-trace when run-webkit-tests is terminated
2210         or stopped with CNTRL-C will make such issues easier to debug.
2211
2212         * Scripts/webkitpy/common/interupt_debugging.py: Added.
2213         (log_stack_trace): Given a Python frame object, log a stack trace to
2214         the provided file.
2215         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a
2216         stack-trace can be logged when a program is terminated.
2217         (log_stack_trace_on_cntrl_c): Attach a listener to SIGINT so that a
2218         stack-trace can be logged when a program is CNTRL-Ced. 
2219         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2220         (main): Set handlers to log stack trace on interruption.
2221
2222 2017-10-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2223
2224         Remove ENABLE_CSS_REGIONS
2225         https://bugs.webkit.org/show_bug.cgi?id=177689
2226
2227         Reviewed by Darin Adler.
2228
2229         * Scripts/webkitperl/FeatureList.pm:
2230
2231 2017-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2232
2233         Unreviewed. Upgrade webkitgtk-test-fonts to version 0.0.7.
2234
2235         This version upgrades liberation fonts to version 2, that has a wider glyph coverage.
2236
2237         * gtk/jhbuild.modules:
2238
2239 2017-09-29  Alex Christensen  <achristensen@webkit.org>
2240
2241         Expose WebPreferences::webGLEnabled through WKPreferences
2242         https://bugs.webkit.org/show_bug.cgi?id=177692
2243         <rdar://problem/24110556>
2244
2245         Reviewed by Andy Estes.
2246
2247         * TestWebKitAPI/Tests/WebKitCocoa/Preferences.mm:
2248         (-[AlertSaver alert]):
2249         (-[AlertSaver webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2250         (TEST):
2251
2252 2017-09-29  Alex Christensen  <achristensen@webkit.org>
2253
2254         Fix WKWebViewConfigurationPrivate after r222663
2255         https://bugs.webkit.org/show_bug.cgi?id=177644
2256
2257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2258         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm: Added.
2259         (TEST):
2260
2261 2017-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2262
2263         Image pasting is not working on tineye.com / gmail.com / GitHub.com due to lack of support for DataTransfer.items
2264         https://bugs.webkit.org/show_bug.cgi?id=170449
2265         <rdar://problem/31432525>
2266
2267         Reviewed by Wenson Hsieh.
2268
2269         Added an API test to paste an image from pasteboard. The test is shared between iOS and macOS.
2270
2271         The tests to paste image files are only enabled on macOS since putting files into pasteboard isn't a thing on iOS.
2272
2273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2274         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm: Added.
2275         (writeImageDataToPasteboard):
2276         (writeBundleFileToPasteboard):
2277         * TestWebKitAPI/Tests/WebKitCocoa/paste-image.html: Added.
2278         * TestWebKitAPI/Tests/WebKitCocoa/sunset-in-cupertino-100px.tiff: Added.
2279         * TestWebKitAPI/Tests/WebKitCocoa/sunset-in-cupertino-200px.png: Added.
2280         * TestWebKitAPI/Tests/WebKitCocoa/sunset-in-cupertino-400px.gif: Added.
2281         * TestWebKitAPI/Tests/WebKitCocoa/sunset-in-cupertino-600px.jpg: Added.
2282         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Rebaselined the test now that types contain "Files".
2283
2284 2017-09-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2285
2286         [iOS WK2] Implement -[WKContentView hasText] for compatibility with the UITextInput protocol
2287         https://bugs.webkit.org/show_bug.cgi?id=177662
2288         <rdar://problem/33410373>
2289
2290         Reviewed by Tim Horton.
2291
2292         Add EditorState API tests to check that the value of -[WKContentView hasText] is correct when editing both plain
2293         and rich text areas.
2294
2295         * TestWebKitAPI/EditingTestHarness.h:
2296         * TestWebKitAPI/EditingTestHarness.mm:
2297         (-[EditingTestHarness insertParagraph]):
2298         (-[EditingTestHarness insertText:]):
2299         (-[EditingTestHarness insertHTML:]):
2300         (-[EditingTestHarness selectAll]):
2301         (-[EditingTestHarness deleteBackwards]):
2302         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2303
2304         Add versions of EditingTestHarness helpers that don't require us to expect any editor state after executing the
2305         edit command.
2306
2307         (TestWebKitAPI::checkContentViewHasTextWithFailureDescription):
2308         (TestWebKitAPI::TEST):
2309         * TestWebKitAPI/cocoa/TestWKWebView.h:
2310         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2311         (-[TestWKWebView textInputContentView]):
2312
2313 2017-09-29  Charles Turner  <cturner@igalia.com>
2314
2315         Update my status.
2316
2317         Unreviewed.
2318
2319         * Scripts/webkitpy/common/config/contributors.json:
2320
2321 2017-09-28  Commit Queue  <commit-queue@webkit.org>
2322
2323         Unreviewed, rolling out r222639.
2324         https://bugs.webkit.org/show_bug.cgi?id=177630
2325
2326         Breaks AppleWin build (Requested by dolmstead on #webkit).
2327
2328         Reverted changeset:
2329
2330         "[WinCairo][MiniBrowser] Add ca-bundle to display secure
2331         pages."
2332         https://bugs.webkit.org/show_bug.cgi?id=168486
2333         http://trac.webkit.org/changeset/222639
2334
2335 2017-09-28  Joanmarie Diggs  <jdiggs@igalia.com>
2336
2337         AX: [ATK] object:state-changed notifications missing for multiple ARIA attributes
2338         https://bugs.webkit.org/show_bug.cgi?id=177542
2339
2340         Add platform support for the notifications. Also add support for getting the
2341         boolean argument indicating whether the state has been set or unset.
2342
2343         Reviewed by Chris Fleizach.
2344
2345         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2346
2347 2017-09-28  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2348
2349         [WinCairo][MiniBrowser] Add ca-bundle to display secure pages.
2350         Copy cacert.pem file into bundle directory.
2351         https://bugs.webkit.org/show_bug.cgi?id=168486
2352
2353         Reviewed by Brent Fulgham.
2354
2355         * MiniBrowser/win/CMakeLists.txt:
2356
2357 2017-09-28  Lucas Forschler  <lforschler@apple.com>
2358
2359         check in AWS Lambda code used for WebKitArchiveSupport
2360         https://bugs.webkit.org/show_bug.cgi?id=177614
2361         
2362         Rubber-stamped by Alexey Proskuryakov.
2363
2364         * WebKitArchiveSupport/lambda: Added.
2365         * WebKitArchiveSupport/lambda/delete-minified-s3-archive-from-dynamodb.py: Added.
2366         (lambda_handler):
2367         * WebKitArchiveSupport/lambda/delete-s3-archive-from-dynamodb.py: Added.
2368         (lambda_handler):
2369         * WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py: Added.
2370         (lambda_handler):
2371         * WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py: Added.
2372         (lambda_handler):
2373
2374 2017-09-28  Jiewen Tan  <jiewen_tan@apple.com>
2375
2376         WeakPtrFactory should allow downcasting
2377         https://bugs.webkit.org/show_bug.cgi?id=177389
2378         <rdar://problem/34604174>
2379
2380         Reviewed by Geoffrey Garen.
2381
2382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2383         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2384         (TestWebKitAPI::Base::foo):
2385         (TestWebKitAPI::Base::createWeakPtr):
2386         (TestWebKitAPI::Derived::foo):
2387         (TestWebKitAPI::TEST):
2388
2389 2017-09-28  Megan Gardner  <megan_gardner@apple.com>
2390
2391         Add debug flag to WebKitTestRunner to show where touches are being generated
2392         https://bugs.webkit.org/show_bug.cgi?id=177583
2393
2394         Reviewed by Tim Horton and Wenson Hsieh.
2395
2396         Add a flag, and the ability to paint a dot where the HIDEventGenerator is creating fake touches to
2397         send through UIKit. This will help in debugging touch tests, because it will be easier to see if
2398         one is actually sending the touches at the locations that they expect. This will help differentiate between
2399         problems in the locations of the touches, and other problems that can come up when writing tests.
2400
2401         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2402         (parse_args):
2403         * Scripts/webkitpy/port/driver.py:
2404         (Driver.cmd_line):
2405         * WebKitTestRunner/Options.cpp:
2406         (WTR::Options::Options):
2407         (WTR::handleOptionShowTouches):
2408         (WTR::OptionsHandler::OptionsHandler):
2409         * WebKitTestRunner/Options.h:
2410         * WebKitTestRunner/TestController.cpp:
2411         (WTR::TestController::initialize):
2412         * WebKitTestRunner/TestController.h:
2413         (WTR::TestController::shouldShowTouches const):
2414         * WebKitTestRunner/TestOptions.h:
2415         * WebKitTestRunner/ios/HIDEventGenerator.h:
2416         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2417         (-[DebugTouchView pointInside:withEvent:]):
2418         (-[HIDEventGenerator setShouldShowTouches:]):
2419         (-[HIDEventGenerator initDebugViews]):
2420         (-[HIDEventGenerator updateDebugUI:withPoint:isTouching:]):
2421         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
2422         (-[HIDEventGenerator _createIOHIDEventType:]):
2423         (-[HIDEventGenerator _updateTouchPoints:count:]):
2424         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2425         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2426         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2427         (-[HIDEventGenerator markerEventReceived:]):
2428         * WebKitTestRunner/ios/TestControllerIOS.mm:
2429         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
2430         * WebKitTestRunner/ios/mainIOS.mm:
2431         (-[WebKitTestRunnerApp _runTestController]):
2432
2433 2017-09-28  Mark Lam  <mark.lam@apple.com>
2434
2435         [Re-landing] Turn on exception scope verification for JSC tests.
2436         https://bugs.webkit.org/show_bug.cgi?id=162351
2437         <rdar://problem/29563911>
2438
2439         Reviewed by Saam Barati.
2440
2441         Update: I'm re-landing this patch now that test262 exception check validation
2442         failures have been fixed in r222617.  testapi still has some validation failures,
2443         but this patch does not affect testapi.
2444
2445         Added the option to --validateExceptionChecks=true option to BASE_OPTIONS in
2446         run-jsc-stress-tests.  This turns on exception scope verification on JSC test
2447         runs (which currently does not include testapi).
2448
2449         Some stats on time to run JSC stress and mozilla tests:
2450         1. Release build w/o --validateExceptionChecks=true: real 16m22.544s, user 156m24.080s, sys 123m3.649s
2451         2. Debug build w/o --validateExceptionChecks=true: real 78m34.206s, user 1661m57.008s, sys 73m21.177s
2452         3. Debug build w/ --validateExceptionChecks=true: real 77m41.106s, user 1656m13.924s, sys 73m42.309s
2453         4. Debug build w/ --validateExceptionChecks=true --dumpSimulatedThrows=true: real 92m56.918s, user 2012m56.441s, sys 75m14.174s
2454
2455         The stats shows that (2) and (3) has effectively no time difference.  Hence, the
2456         cost of enabling --validateExceptionChecks=true is not significant.
2457
2458         It would be nice to enable --dumpSimulatedThrows=true as well, but (4) is about
2459         21% slower than (3).  To avoid making debug test runs a lot slower, we'll leave
2460         --dumpSimulatedThrows=true off.  We can manually add that when we see a regression
2461         and need to debug the issue.  Otherwise, we wont pay the price for it.
2462
2463         * Scripts/run-jsc-stress-tests:
2464
2465 2017-09-27  Alex Christensen  <achristensen@webkit.org>
2466
2467         Add WKContentRuleList notify action type
2468         https://bugs.webkit.org/show_bug.cgi?id=177013
2469         <rdar://problem/31073936>
2470
2471         Reviewed by Darin Adler.
2472
2473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2474         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2475         (WebCore::ContentExtensions::operator<<):
2476         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2477         (TestWebKitAPI::InMemoryCompiledContentExtension::data):
2478         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2479         (TestWebKitAPI::makeBackend):
2480         (TestWebKitAPI::TEST_F):
2481         (TestWebKitAPI::actionsEqual):
2482         (TestWebKitAPI::sequenceInstances):
2483         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter): Deleted.
2484         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension): Deleted.
2485         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm: Added.
2486         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2487         (-[ContentRuleListNotificationDelegate webView:startURLSchemeTask:]):
2488         (-[ContentRuleListNotificationDelegate webView:stopURLSchemeTask:]):
2489         (-[ContentRuleListNotificationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2490         (makeWarnContentRuleList):
2491         (TEST):
2492
2493 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2494
2495         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2496         https://bugs.webkit.org/show_bug.cgi?id=172526
2497         <rdar://problem/32396081>
2498
2499         Reviewed by Ryosuke Niwa.
2500
2501         Adds new API tests on iOS to cover various cases of using DataTransfer.setData, DataTransfer.getData, and
2502         DataTransfer.types, as well as their interaction with platform objects (source NSItemProviders in the case of
2503         drag and drop, and the general UIPasteboard for copy and paste).
2504
2505         * TestWebKitAPI/PlatformUtilities.h:
2506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2507         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html: Added.
2508
2509         Introduce a new API test harness that both drag-and-drop and copy-and-paste tests use to dump DataTransfer's
2510         web-exposed types and values.
2511
2512         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2513         (checkFirstTypeIsPresentAndSecondTypeIsMissing):
2514         (checkJSONWithLogging):
2515         (TestWebKitAPI::TEST):
2516         (checkTypeIdentifierAndIsNotOtherTypeIdentifier): Deleted.
2517         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2518         (TestWebKitAPI::checkJSONWithLogging):
2519         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2520         (TestWebKitAPI::TEST):
2521         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
2522         (TestWebKitAPI::Util::jsonMatchesExpectedValues):
2523
2524 2017-09-27  Lucas Forschler  <lforschler@apple.com>
2525
2526         Add macOS High Sierra and iOS Simulator 11 support to bisect-builds.
2527         https://bugs.webkit.org/show_bug.cgi?id=177578
2528
2529         Reviewed by Alexey Proskuryakov.
2530
2531         * Scripts/bisect-builds:
2532         (minified_platforms):
2533         (unminified_platforms):
2534
2535 2017-09-27  Ryan Haddad  <ryanhaddad@apple.com>
2536
2537         Update TestResultsServer for High Sierra queues.
2538         https://bugs.webkit.org/show_bug.cgi?id=177500
2539
2540         Reviewed by Alexey Proskuryakov.
2541
2542         * TestResultServer/static-dashboards/builders.jsonp:
2543
2544 2017-09-27  Lucas Forschler  <lforschler@apple.com>
2545
2546         bisect-builds:add a README to the archive.
2547         https://bugs.webkit.org/show_bug.cgi?id=177376
2548
2549         Reviewed by Alexey Proskuryakov & Jon Davis.
2550
2551         * BuildSlaveSupport/built-product-archive:
2552         (addFilesToArchive): refactor function (was previously addLauncherToArchive)
2553         (createZip): Teach function to add the README
2554         (addLauncherToArchive): Deleted. (refactored to addFilesToArchive)
2555         * BuildSlaveSupport/run-webkit-archive: Deleted. (Moved to WebKitArchiveSupport)
2556         * WebKitArchiveSupport: Added.
2557         * WebKitArchiveSupport/README: Added. README which will be packaged up with the archive.
2558         * WebKitArchiveSupport/run-webkit-archive: Added. (Moved from BuildSlaveSupport)
2559
2560 2017-09-26  Tim Horton  <timothy_horton@apple.com>
2561
2562         Mac CMake bot should provide verbose build output
2563         https://bugs.webkit.org/show_bug.cgi?id=177512
2564
2565         Reviewed by Alexey Proskuryakov.
2566
2567         * BuildSlaveSupport/build.webkit.org-config/config.json:
2568         It's hard to diagnose weird bot-only build problems without the
2569         full verbose build output, so turn that on. The Xcode builders
2570         do it too, so why not CMake!
2571
2572 2017-09-26  Tim Horton  <timothy_horton@apple.com>
2573
2574         Make it possible to easily get verbose ninja output from build-webkit
2575         https://bugs.webkit.org/show_bug.cgi?id=177511
2576
2577         Reviewed by Sam Weinig.
2578
2579         * Scripts/build-webkit:
2580         Add a -v/--verbose argument to build-webkit, which sets the environment
2581         variable VERBOSE=1, which buildCMakeGeneratedProject already checks.
2582
2583         * Scripts/webkitdirs.pm:
2584         (buildCMakeGeneratedProject):
2585         Add ninja verbosity arguments to @makeArgs, which are appended
2586         after the -- and thus handed to ninja; the previous implementation
2587         (appending to @args) would only work if @makeArgs was non-empty and thus
2588         the -- was included.
2589
2590 2017-09-26  Said Abou-Hallawa  <sabouhallawa@apple.com>
2591
2592         Followup (r222427): SynchronizedFixedQueue should not have a public constructor
2593         https://bugs.webkit.org/show_bug.cgi?id=177458
2594
2595         Reviewed by Tim Horton.
2596
2597         Fix the definition and the creation of SynchronizedFixedQueue.
2598
2599         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
2600         (TestWebKitAPI::ToUpperConverter::ToUpperConverter):
2601         (TestWebKitAPI::ToUpperConverter::startProducing):
2602         (TestWebKitAPI::ToUpperConverter::startConsuming):
2603         (TestWebKitAPI::ToUpperConverter::stopProducing):
2604         (TestWebKitAPI::ToUpperConverter::stopConsuming):
2605         (TestWebKitAPI::ToUpperConverter::enqueueLower):
2606
2607 2017-09-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2608
2609         [ios-simulator] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing
2610         https://bugs.webkit.org/show_bug.cgi?id=177271
2611
2612         Reviewed by Tim Horton and Megan Gardner.
2613
2614         Rebaseline a failing API test.
2615
2616         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2617         (TestWebKitAPI::TEST):
2618
2619 2017-09-26  Per Arne Vollan  <pvollan@apple.com>
2620
2621         Set LF eol-style on Windows shell script, because the script failed on one of the EWS
2622         bots, when it had the 'native' style.
2623
2624         Unreviewed Windows EWS fix. 
2625
2626         * EWSTools/start-queue-win.sh: Modified property svn:eol-style.
2627
2628 2017-09-26  Jonathan Bedard  <jbedard@apple.com>
2629
2630         webkitpy: Notify parent process when a worker is spawned
2631         https://bugs.webkit.org/show_bug.cgi?id=177467
2632         <rdar://problem/34660194>
2633
2634         Reviewed by Daniel Bates.
2635
2636         When we fork the parent process, there may be resources in that process
2637         which workers will take ownership of. Notify ports when a new worker is created
2638         so that these resources can be correctly managed.
2639
2640         * Scripts/webkitpy/common/message_pool.py:
2641         (_MessagePool._start_workers): After all workers are started, notify the caller
2642         that a worker has been created, unless we are running inline, in which case the
2643         parent process is still the worker.
2644         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2645         (LayoutTestRunner._handle_did_spawn_worker): Notify the port that a worker process
2646         has been created.
2647         * Scripts/webkitpy/port/base.py:
2648         (Port.did_spawn_worker): Add function so that ports may manage any
2649         resources created on the parent process but managed by the provided worker.
2650         * Scripts/webkitpy/port/device.py:
2651         (Device.release_worker_resources): Call release_worker_resources on the
2652         platform_device if such a function is defined.
2653         * Scripts/webkitpy/port/ios.py:
2654         (IOSPort.did_spawn_worker): Release any worker resources on the iOS
2655         device object associated with the spawned worker.
2656         * Scripts/webkitpy/test/runner.py:
2657         (Runner.handle): Ignore the did_spawn_worker message during testing.
2658
2659 2017-09-26  Jer Noble  <jer.noble@apple.com>
2660
2661         Thrown ObjC exception when right clicking on <img> containing mp4 link
2662         https://bugs.webkit.org/show_bug.cgi?id=177370
2663
2664         Reviewed by Darin Adler.
2665
2666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2667         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.html: Added.
2668         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm: Added.
2669         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
2670         (TestWebKitAPI::TEST):
2671
2672 2017-09-26  Per Arne Vollan  <pvollan@apple.com>
2673
2674         [Win] 'webkit-patch clean' is failing on bot.
2675         https://bugs.webkit.org/show_bug.cgi?id=177488
2676
2677         Reviewed by Brent Fulgham.
2678
2679         If 'os.remove' throws an exception, catch it.
2680
2681         * Scripts/webkitpy/common/checkout/scm/svn.py:
2682         (SVN.discard_working_directory_changes):
2683
2684 2017-09-25  Frederik Riedel  <riedel@apple.com>
2685
2686         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2687         https://bugs.webkit.org/show_bug.cgi?id=174394
2688         <rdar://problem/33183504>
2689
2690         Reviewed by Ryosuke Niwa.
2691
2692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2693         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm: Added.
2694         (-[WKWebView _privateTextInput]): Testing helpers.
2695         (TestWebKitAPI::TEST): Added test cases to test AutoFill for web views.
2696         * TestWebKitAPI/ios/UIKitSPI.h:
2697
2698 2017-09-25  Frederic Wang  <fwang@igalia.com>
2699
2700         Change my status to reviewer and reformat with validate-committer-lists
2701
2702         Unreviewed.
2703
2704         * Scripts/webkitpy/common/config/contributors.json:
2705
2706 2017-09-25  Ryan Haddad  <ryanhaddad@apple.com>
2707
2708         Add High Sierra bots to buildbot and dashboard.
2709         https://bugs.webkit.org/show_bug.cgi?id=177437
2710
2711         Reviewed by Alexey Proskuryakov.
2712
2713         * BuildSlaveSupport/build.webkit.org-config/config.json: Add High Sierra queues, move Leaks and JSC queues over from Sierra.
2714         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update expected results.
2715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Add High Sierra.
2716         (WebKitBuildbot):
2717
2718 2017-09-25  Chris Dumez  <cdumez@apple.com>
2719
2720         [WK2] Add API to query if a download was user-initiated
2721         https://bugs.webkit.org/show_bug.cgi?id=177435
2722         <rdar://problem/34498422>
2723
2724         Reviewed by Alex Christensen.
2725
2726         Add API test coverage.
2727
2728         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2729         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
2730         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2731         (-[DownloadDelegate _downloadDidStart:]):
2732         (-[DownloadDelegate _downloadDidFinish:]):
2733         (runTest):
2734         (TEST):
2735         (-[BlobDownloadDelegate _downloadDidStart:]):
2736         (-[BlobDownloadDelegate _downloadDidFinish:]):
2737         (-[RedirectedDownloadDelegate _downloadDidStart:]):
2738         (-[RedirectedDownloadDelegate _downloadDidFinish:]):
2739
2740 2017-09-25  Commit Queue  <commit-queue@webkit.org>
2741
2742         Unreviewed, rolling out r222455.
2743         https://bugs.webkit.org/show_bug.cgi?id=177460
2744
2745         broke iOS build (Requested by alexchristensen on #webkit).
2746
2747         Reverted changeset:
2748
2749         "Add WKContentRuleList notify action type"
2750         https://bugs.webkit.org/show_bug.cgi?id=177013
2751         http://trac.webkit.org/changeset/222455
2752
2753 2017-09-25  Per Arne Vollan  <pvollan@apple.com>
2754
2755         [Win] run-api-tests is failing.
2756         https://bugs.webkit.org/show_bug.cgi?id=177454
2757
2758         Reviewed by Brent Fulgham.
2759
2760         TestWebKit.exe has changed name to TestWebKitLegacy.exe.
2761
2762         * Scripts/run-api-tests:
2763         (testToolPaths):
2764
2765 2017-09-25  Per Arne Vollan  <pvollan@apple.com>
2766
2767         [Win] Cygwin 64-bit EWS process cannot find Visual Studio installation.
2768         https://bugs.webkit.org/show_bug.cgi?id=177244
2769
2770         Reviewed by Alex Christensen.
2771
2772         The 64-bit EWS shell process should try to find Visual Studio in the 32-bit program files folder.
2773
2774         * EWSTools/start-queue-win.sh:
2775
2776 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2777
2778         Add WKContentRuleList notify action type
2779         https://bugs.webkit.org/show_bug.cgi?id=177013
2780         <rdar://problem/31073936>
2781
2782         Reviewed by Darin Adler.
2783
2784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2785         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2786         (WebCore::ContentExtensions::operator<<):
2787         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2788         (TestWebKitAPI::InMemoryCompiledContentExtension::data):
2789         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2790         (TestWebKitAPI::makeBackend):
2791         (TestWebKitAPI::TEST_F):
2792         (TestWebKitAPI::actionsEqual):
2793         (TestWebKitAPI::sequenceInstances):
2794         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter): Deleted.
2795         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension): Deleted.
2796         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm: Added.
2797         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2798         (-[ContentRuleListNotificationDelegate webView:startURLSchemeTask:]):
2799         (-[ContentRuleListNotificationDelegate webView:stopURLSchemeTask:]):
2800         (-[ContentRuleListNotificationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2801         (makeWarnContentRuleList):
2802         (TEST):
2803
2804 2017-09-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2805
2806         REGRESSION(r222160) [GTK] [Debug] Internal compiler error on the buildbot (huge memory usage by GCC)
2807         https://bugs.webkit.org/show_bug.cgi?id=177223
2808
2809         Reviewed by Carlos Garcia Campos.
2810
2811         When the user environment sets the variable NUMBER_OF_PROCESSORS
2812         this should be passed down to the build system (ninja or make) always.
2813
2814         Playing with the number of this variable is needed when using icecc
2815         (as you usually want to launch more parallel build process than your
2816         number of cores), or when you want to limit the number of parallel
2817         build process for hardware capacity reasons.
2818
2819         * Scripts/build-webkit:
2820
2821 2017-09-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2822
2823         [GTK] Incremental builds fail every time Web Inspector icons are removed
2824         https://bugs.webkit.org/show_bug.cgi?id=177349
2825
2826         Reviewed by Carlos Garcia Campos.
2827
2828         Removing GTK WebInspector image files always breaks the GTK and
2829         WPE ports incremental builds.
2830
2831         * Scripts/webkitdirs.pm:
2832         (shouldRemoveCMakeCache): Check the timestamp of
2833         Source/WebInspectorUI/UserInterface/Images/gtk directory if
2834         isGtk() or isWPE().
2835
2836 2017-09-24  Joanmarie Diggs  <jdiggs@igalia.com>
2837
2838         [ATK] Object attributes are missing for ARIA live region roles
2839         https://bugs.webkit.org/show_bug.cgi?id=171174
2840
2841         Reviewed by Chris Fleizach.
2842
2843         Add support for testing property values for AXARIALive, AXARIAAtomic, and
2844         AXARIARelevant. Also add handling for testing whether AXElementBusy is
2845         "supported" (in ATK, busy is a state and is supported on all elements
2846         regardless of whether the state is present or absent from the state set).
2847
2848         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2849         (WTR::AccessibilityUIElement::boolAttributeValue):
2850         (WTR::AccessibilityUIElement::isAttributeSupported):
2851
2852 2017-09-23  Michael Catanzaro  <mcatanzaro@igalia.com>
2853
2854         Unreviewed Mac CMake build fixup after r222194
2855
2856         * DumpRenderTree/PlatformMac.cmake:
2857
2858 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2859
2860         WeakPtrFactory should populate m_ref lazily.
2861         https://bugs.webkit.org/show_bug.cgi?id=177375
2862
2863         Reviewed by Geoffrey Garen.
2864
2865         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2866         (TestWebKitAPI::TEST):
2867
2868 2017-09-22  Filip Pizlo  <fpizlo@apple.com>
2869
2870         WSL should report an error if you try to create an operator overload that will never be called
2871         https://bugs.webkit.org/show_bug.cgi?id=177092
2872
2873         Reviewed by JF Bastien.
2874         
2875         This adds all kinds of checks to ensure that your operator overloads make sense. This adds all
2876         kinds of tests for those checks.
2877         
2878         In the process of writing those tests, I hit an awesome bug: function instantiation was
2879         instantiating all types, which meant that if that instantiated function needed to resolve calls
2880         to protocol functions, we'd fail because we would have cloned top-level struct types. We need
2881         to preserve the uninstantiated argument types, type arguments, and return type (for casts) in
2882         order to be able to resolve protocol calls. But we also need the instantiated version of the
2883         type arguments for execution. So, this adds some more stuff to the CallExpression class.
2884         
2885         * WebGPUShadingLanguageRI/All.js:
2886         * WebGPUShadingLanguageRI/ArrayRefType.js:
2887         (ArrayRefType.prototype.unifyImpl):
2888         * WebGPUShadingLanguageRI/ArrayType.js:
2889         (ArrayType.prototype.get isArray):
2890         * WebGPUShadingLanguageRI/CallExpression.js:
2891         (CallExpression.resolve):
2892         (CallExpression.prototype.resolve):
2893         (CallExpression.prototype.resolveToOverload):
2894         * WebGPUShadingLanguageRI/Checker.js:
2895         (Checker.prototype._checkOperatorOverload):
2896         (Checker.prototype.visitFuncDef):
2897         (Checker.prototype.visitProtocolDecl):
2898         (Checker.prototype.visitMakeArrayRefExpression):
2899         * WebGPUShadingLanguageRI/EBufferBuilder.js:
2900         (EBufferBuilder.prototype._createEPtr):
2901         * WebGPUShadingLanguageRI/EPtr.js:
2902         (EPtr):
2903         * WebGPUShadingLanguageRI/Evaluator.js:
2904         (Evaluator.prototype._snapshot):
2905         (Evaluator.prototype._runBody):
2906         (Evaluator.prototype.visitFunctionLikeBlock):
2907         (Evaluator.prototype.visitCallExpression):
2908         (Evaluator):
2909         (Evaluator.prototype.runFunc): Deleted.
2910         * WebGPUShadingLanguageRI/ExternalOrigin.js: Added.
2911         * WebGPUShadingLanguageRI/Func.js:
2912         (Func.prototype.toDeclString):
2913         * WebGPUShadingLanguageRI/FuncInstantiator.js:
2914         (FuncInstantiator.prototype.getUnique.InstantiationSubstitution.prototype.visitCallExpression):
2915         (FuncInstantiator.prototype.getUnique.InstantiationSubstitution):
2916         (FuncInstantiator.prototype.getUnique.InstantiationInstantiateImmediates.prototype.visitCallExpression):
2917         (FuncInstantiator.prototype.getUnique.InstantiationInstantiateImmediates):
2918         (FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitFuncDef):
2919         * WebGPUShadingLanguageRI/Intrinsics.js:
2920         (Intrinsics):
2921         * WebGPUShadingLanguageRI/LateChecker.js:
2922         (LateChecker.prototype.visitReferenceType):
2923         (LateChecker.prototype._checkShaderType):
2924         * WebGPUShadingLanguageRI/Lexer.js:
2925         (Lexer._textIsIdentifierImpl):
2926         (Lexer.textIsIdentifier):
2927         (Lexer.prototype.next):
2928         (Lexer):
2929         * WebGPUShadingLanguageRI/NameResolver.js:
2930         (NameResolver.prototype.visitProtocolDecl):
2931         * WebGPUShadingLanguageRI/Parse.js:
2932         (parseType.getAddressSpace):
2933         (parseType):
2934         * WebGPUShadingLanguageRI/Prepare.js:
2935         (let.prepare):
2936         * WebGPUShadingLanguageRI/PtrType.js:
2937         (PtrType.prototype.unifyImpl):
2938         * WebGPUShadingLanguageRI/ReferenceType.js:
2939         (ReferenceType):
2940         * WebGPUShadingLanguageRI/Rewriter.js:
2941         (Rewriter.prototype.visitReferenceType):
2942         (Rewriter.prototype.processDerivedCallData):
2943         * WebGPUShadingLanguageRI/StandardLibrary.js:
2944         (intToString):
2945         * WebGPUShadingLanguageRI/StatementCloner.js:
2946         (StatementCloner.prototype.visitFuncDef):
2947         * WebGPUShadingLanguageRI/StructLayoutBuilder.js:
2948         (StructLayoutBuilder.prototype.visitCallExpression):
2949         (StructLayoutBuilder):
2950         * WebGPUShadingLanguageRI/Substitution.js:
2951         (Substitution.prototype.visitTypeRef):
2952         * WebGPUShadingLanguageRI/Test.html:
2953         * WebGPUShadingLanguageRI/Test.js:
2954         (checkNumber):
2955         (set target):
2956         (tests.literalBool):
2957         (tests.identityBool):
2958         (tests.intSimpleMath):
2959         (tests.uintSimpleMath):
2960         (tests.uint8SimpleMath):
2961         (tests.equality):
2962         (tests.logicalNegation):
2963         (tests.notEquality):
2964         (tests.equalityTypeFailure):
2965         (tests.generalNegation):
2966         (tests.add1):
2967         (tests.simpleGeneric):
2968         (tests.nameResolutionFailure):
2969         (tests.simpleVariable):
2970         (tests.simpleAssignment):
2971         (tests.simpleDefault):
2972         (tests.simpleDereference):
2973         (tests.dereferenceStore):
2974         (tests.simpleMakePtr):
2975         (tests.threadArrayLoad):
2976         (tests.threadArrayLoadIntLiteral):
2977         (tests.deviceArrayLoad):
2978         (tests.threadArrayStore):
2979         (tests.deviceArrayStore):
2980         (tests.deviceArrayStoreIntLiteral):
2981         (tests.simpleProtocol):
2982         (tests.typeMismatchReturn):
2983         (tests.typeMismatchVariableDecl):
2984         (tests.typeMismatchAssignment):
2985         (tests.typeMismatchReturnParam):
2986         (tests.badAdd):
2987         (tests.lexerKeyword):
2988         (tests.simpleNoReturn):
2989         (tests.simpleUnreachableCode):
2990         (tests.simpleStruct):
2991         (tests.genericStructInstance):
2992         (tests.doubleGenericCallsDoubleGeneric):
2993         (tests.doubleGenericCallsSingleGeneric):
2994         (tests.loadNull):
2995         (tests.storeNull):
2996         (tests.returnNull):
2997         (tests.dereferenceDefaultNull):
2998         (tests.defaultInitializedNull):
2999         (tests.passNullToPtrMonomorphic):
3000         (tests.passNullToPtrPolymorphic):
3001         (tests.passNullToPolymorphic):
3002         (tests.loadNullArrayRef):
3003         (tests.storeNullArrayRef):
3004         (tests.returnNullArrayRef):
3005         (tests.dereferenceDefaultNullArrayRef):
3006         (tests.defaultInitializedNullArrayRef):
3007         (tests.defaultInitializedNullArrayRefIntLiteral):
3008         (tests.passNullToPtrMonomorphicArrayRef):
3009         (tests.passNullToPtrPolymorphicArrayRef):
3010         (tests.returnIntLiteralUint):
3011         (tests.returnIntLiteralDouble):
3012         (tests.badIntLiteralForInt):
3013         (tests.badIntLiteralForUint):
3014         (tests.badIntLiteralForDouble):
3015         (tests.passNullAndNotNull):
3016         (tests.passNullAndNotNullFullPoly):
3017         (tests.passNullAndNotNullFullPolyReverse):
3018         (tests.nullTypeVariableUnify):
3019         (tests.doubleNot):
3020         (tests.simpleRecursion):
3021         (tests.protocolMonoSigPolyDef):
3022         (tests.protocolPolySigPolyDef):
3023         (tests.protocolDoublePolySigDoublePolyDef):
3024         (tests.protocolDoublePolySigDoublePolyDefExplicit):
3025         (tests.variableShadowing):
3026         (tests.ifStatement):
3027         (tests.ifElseStatement):
3028         (tests.ifElseIfStatement):
3029         (tests.ifElseIfElseStatement):
3030         (tests.returnIf):
3031         (tests.simpleWhile):
3032         (tests.protocolMonoPolySigDoublePolyDefExplicit):
3033         (tests.ambiguousOverloadSimple):
3034         (tests.ambiguousOverloadOverlapping):
3035         (tests.ambiguousOverloadTieBreak):
3036         (tests.intOverloadResolution):
3037         (tests.intOverloadResolutionReverseOrder):
3038         (tests.intOverloadResolutionGeneric):
3039         (tests.intLiteralGeneric):
3040         (tests.intLiteralGenericWithProtocols):
3041         (tests.uintLiteralGeneric):
3042         (tests.uintLiteralGenericWithProtocols):
3043         (tests.intLiteralGenericSpecific):
3044         (tests.simpleConstexpr):
3045         (tests.break):
3046         (tests.continue):
3047         (tests.doWhile):
3048         (tests.forLoop):
3049         (tests.chainConstexpr):
3050         (tests.chainGeneric):
3051         (tests.chainStruct):
3052         (tests.chainStructNewlyValid):
3053         (tests.chainStructDevice):
3054         (tests.paramChainStructDevice):
3055         (tests.simpleProtocolExtends):
3056         (tests.protocolExtendsTwo):
3057         (tests.prefixPlusPlus):
3058         (tests.prefixPlusPlusResult):
3059         (tests.postfixPlusPlus):
3060         (tests.postfixPlusPlusResult):
3061         (tests.prefixMinusMinus):
3062         (tests.prefixMinusMinusResult):
3063         (tests.postfixMinusMinus):
3064         (tests.postfixMinusMinusResult):
3065         (tests.plusEquals):
3066         (tests.plusEqualsResult):
3067         (tests.minusEquals):
3068         (tests.minusEqualsResult):
3069         (tests.timesEquals):
3070         (tests.timesEqualsResult):
3071         (tests.divideEquals):
3072         (tests.divideEqualsResult):
3073         (tests.twoIntLiterals):
3074         (tests.unifyDifferentLiterals):
3075         (tests.unifyDifferentLiteralsBackwards):
3076         (tests.unifyVeryDifferentLiterals):
3077         (tests.unifyVeryDifferentLiteralsBackwards):
3078         (tests.assignUintToInt):
3079         (tests.buildArrayThenSumIt):
3080         (tests.buildArrayThenSumItUsingArrayReference):
3081         (tests.overrideSubscriptStruct):
3082         (tests.overrideSubscriptStructAndDoStores):
3083         (tests.overrideSubscriptStructAndUsePointers):
3084         (tests.overrideSubscriptStructAndUsePointersIncorrectly):
3085         (tests.makeArrayRefFromLocal):
3086         (tests.makeArrayRefFromPointer):
3087         (tests.makeArrayRefFromArrayRef):
3088         (tests.simpleLength):
3089         (tests.nonArrayRefArrayLengthSucceed):
3090         (tests.nonArrayRefArrayLengthFail):
3091         (tests.constexprIsNotLValuePtr):
3092         (tests.constexprIsNotLValueAssign):
3093         (tests.constexprIsNotLValueRMW):
3094         (tests.assignLength):
3095         (tests.assignLengthHelper):
3096         (tests.simpleGetter):
3097         (tests.simpleSetter):
3098         (tests.genericAccessors):
3099         (tests.bitSubscriptAccessor):
3100         (tests.nestedSubscriptLValueEmulationSimple):
3101         (tests.nestedSubscriptLValueEmulationGeneric):
3102         (tests.boolBitAnd):
3103         (tests.boolBitOr):
3104         (tests.boolBitXor):
3105         (tests.boolBitNot):
3106         (tests.intBitAnd):
3107         (tests.intBitOr):
3108         (tests.intBitXor):
3109         (tests.intBitNot):
3110         (tests.intLShift):
3111         (tests.intRShift):
3112         (tests.uintBitAnd):
3113         (tests.uintBitOr):
3114         (tests.uintBitXor):
3115         (tests.uintBitNot):
3116         (tests.uintLShift):
3117         (tests.uintRShift):
3118         (tests.uint8BitAnd):
3119         (tests.uint8BitOr):
3120         (tests.uint8BitXor):
3121         (tests.uint8BitNot):
3122         (tests.uint8LShift):
3123         (tests.uint8RShift):
3124         (tests.floatMath):
3125         (tests.genericCastInfer):
3126         (tests.booleanMath):
3127         (tests.typedefArray):
3128         (tests.shaderTypes):
3129         (tests.builtinVectors):
3130         (tests.instantiateStructInStruct):
3131         (tests.instantiateStructInStructWithInt2):
3132         (tests.simpleEnum):
3133         (tests.enumWithManualValues):
3134         (tests.enumWithoutZero):
3135         (tests.enumDuplicates):
3136         (tests.enumWithSomeManualValues):
3137         (tests.enumConstexprGenericFunction):
3138         (tests.enumConstexprGenericStruct):
3139         (tests.trap):
3140         (tests.swizzle):
3141         (tests.enumWithExplicitIntBase):
3142         (tests.enumWithUintBase):
3143         (tests.enumFloatBase):
3144         (tests.enumPtrBase):
3145         (tests.enumArrayRefBase):
3146         (tests.emptyStruct):
3147         (tests.enumStructBase):
3148         (tests.enumNoMembers):
3149         (tests.simpleSwitch):
3150         (tests.exhaustiveUint8Switch):
3151         (tests.notQuiteExhaustiveUint8Switch):
3152         (tests.notQuiteExhaustiveUint8SwitchWithDefault):
3153         (tests.switchFallThrough):
3154         (tests.switchBreak):
3155         (tests.enumSwitchBreakExhaustive):
3156         (tests.enumSwitchBreakNotQuiteExhaustive):
3157         (tests.enumSwitchBreakNotQuiteExhaustiveWithDefault):
3158         (tests.simpleRecursiveStruct):
3159         (tests.mutuallyRecursiveStruct):
3160         (tests.mutuallyRecursiveStructWithPointersBroken):
3161         (tests.mutuallyRecursiveStructWithPointers):
3162         (tests.linkedList):
3163         (tests.pointerToPointer):
3164         (tests.arrayRefToArrayRef):
3165         (tests.pointerGetter):
3166         (tests.loneSetter):
3167         (tests.setterWithMismatchedType):
3168         (tests.setterWithMatchedType):
3169         (tests.operatorWithUninferrableTypeVariable):
3170         (tests.operatorWithoutUninferrableTypeVariable):
3171         (tests.operatorCastWithUninferrableTypeVariable):
3172         (tests.operatorCastWithTypeVariableInferredFromReturnType):
3173         (tests.incWrongArgumentLength):
3174         (tests.decWrongArgumentLength):
3175         (tests.incWrongTypes):
3176         (tests.decWrongTypes):
3177         (tests.plusWrongArgumentLength):
3178         (tests.minusWrongArgumentLength):
3179         (tests.timesWrongArgumentLength):
3180         (tests.divideWrongArgumentLength):
3181         (tests.moduloWrongArgumentLength):
3182         (tests.bitAndWrongArgumentLength):
3183         (tests.bitOrWrongArgumentLength):
3184         (tests.bitXorWrongArgumentLength):
3185         (tests.lShiftWrongArgumentLength):
3186         (tests.rShiftWrongArgumentLength):
3187         (tests.bitNotWrongArgumentLength):
3188         (tests.equalsWrongArgumentLength):
3189         (tests.lessThanWrongArgumentLength):
3190         (tests.lessEqualWrongArgumentLength):
3191         (tests.greaterWrongArgumentLength):
3192         (tests.greaterEqualWrongArgumentLength):
3193         (tests.equalsWrongReturnType):
3194         (tests.notEqualsOverload):
3195         (tests.lessThanWrongReturnType):
3196         (tests.lessEqualWrongReturnType):
3197         (tests.greaterThanWrongReturnType):
3198         (tests.greaterEqualWrongReturnType):
3199         (tests.dotOperatorWrongArgumentLength):
3200         (tests.dotOperatorSetterWrongArgumentLength):
3201         (tests.loneSetterPointer):
3202         (tests.setterWithNoGetterOverload):
3203         (tests.setterWithNoGetterOverloadFixed):
3204         (tests.anderWithNothingWrong):
3205         (tests.anderWithWrongNumberOfArguments):
3206         (tests.anderDoesntReturnPointer):
3207         (tests.anderDoesntTakeReference):
3208         (tests.anderWithArrayRef):
3209         (tests.pointerIndexGetter):
3210         (tests.loneIndexSetter):
3211         (tests.notLoneIndexSetter):
3212         (tests.indexSetterWithMismatchedType):
3213         (tests.indexOperatorWrongArgumentLength):
3214         (tests.indexOperatorSetterWrongArgumentLength):
3215         (tests.loneIndexSetterPointer):
3216         (tests.indexSetterWithNoGetterOverload):
3217         (tests.indexSetterWithNoGetterOverloadFixed):
3218         (tests.indexAnderWithNothingWrong):
3219         (tests.indexAnderWithWrongNumberOfArguments):
3220         (tests.indexAnderDoesntReturnPointer):
3221         (tests.indexAnderDoesntTakeReference):
3222         (tests.indexAnderWithArrayRef):
3223         (tests.devicePtrPtr):
3224         (tests.threadgroupPtrPtr):
3225         (tests.constantPtrPtr):
3226         (tests.pointerIndexGetterInProtocol):
3227         (tests.loneIndexSetterInProtocol):
3228         (tests.notLoneIndexSetterInProtocol):
3229         (tests.indexSetterWithMismatchedTypeInProtocol):
3230         (tests.indexOperatorWrongArgumentLengthInProtocol):
3231         (tests.indexOperatorSetterWrongArgumentLengthInProtocol):
3232         (tests.loneIndexSetterPointerInProtocol):
3233         (tests.indexSetterWithNoGetterOverloadInProtocol):
3234         (tests.indexSetterWithNoGetterOverloadFixedInProtocol):
3235         (tests.indexAnderWithNothingWrongInProtocol):
3236         (tests.indexAnderWithWrongNumberOfArgumentsInProtocol):
3237         (tests.indexAnderDoesntReturnPointerInProtocol):
3238         (tests.indexAnderDoesntTakeReferenceInProtocol):
3239         (tests.indexAnderWithArrayRefInProtocol):
3240         (doTest):
3241         (this.window.let._.of.doTest):
3242         (TEST_literalBool): Deleted.
3243         (TEST_identityBool): Deleted.
3244         (TEST_intSimpleMath): Deleted.
3245         (TEST_uintSimpleMath): Deleted.
3246         (TEST_uint8SimpleMath): Deleted.
3247         (TEST_equality): Deleted.
3248         (TEST_logicalNegation): Deleted.
3249         (TEST_notEquality): Deleted.
3250         (TEST_equalityTypeFailure): Deleted.
3251         (): Deleted.
3252         (TEST_add1): Deleted.
3253         (TEST_simpleGeneric): Deleted.
3254         (TEST_nameResolutionFailure): Deleted.
3255         (TEST_simpleAssignment): Deleted.
3256         (TEST_simpleDefault): Deleted.
3257         (TEST_simpleDereference): Deleted.
3258         (TEST_dereferenceStore): Deleted.
3259         (TEST_simpleMakePtr): Deleted.
3260         (TEST_threadArrayLoad): Deleted.
3261         (TEST_threadArrayLoadIntLiteral): Deleted.
3262         (TEST_deviceArrayLoad): Deleted.
3263         (TEST_threadArrayStore): Deleted.
3264         (TEST_deviceArrayStore): Deleted.
3265         (TEST_deviceArrayStoreIntLiteral): Deleted.
3266         (TEST_simpleProtocol): Deleted.
3267         (TEST_typeMismatchReturn): Deleted.
3268         (TEST_simpleNoReturn): Deleted.
3269         (TEST_genericStructInstance): Deleted.
3270         (TEST_doubleGenericCallsDoubleGeneric): Deleted.
3271         (TEST_doubleGenericCallsSingleGeneric): Deleted.
3272         (TEST_dereferenceDefaultNull): Deleted.
3273         (TEST_dereferenceDefaultNullArrayRef): Deleted.
3274         (TEST_returnIntLiteralDouble): Deleted.
3275         (TEST_badIntLiteralForInt): Deleted.
3276         (TEST_passNullAndNotNullFullPoly): Deleted.
3277         (TEST_passNullAndNotNullFullPolyReverse): Deleted.
3278         (TEST_nullTypeVariableUnify.recurse): Deleted.
3279         (TEST_nullTypeVariableUnify.everyOrder): Deleted.
3280         (TEST_nullTypeVariableUnify.everyPair): Deleted.
3281         (TEST_nullTypeVariableUnify): Deleted.
3282         (TEST_simpleRecursion): Deleted.
3283         (TEST_protocolPolySigPolyDef): Deleted.
3284         (TEST_protocolDoublePolySigDoublePolyDef): Deleted.
3285         (TEST_protocolDoublePolySigDoublePolyDefExplicit): Deleted.
3286         (TEST_variableShadowing): Deleted.
3287         (TEST_ifStatement): Deleted.
3288         (TEST_ifElseStatement): Deleted.
3289         (TEST_ifElseIfStatement): Deleted.
3290         (TEST_ifElseIfElseStatement): Deleted.
3291         (TEST_returnIf): Deleted.
3292         (TEST_simpleWhile): Deleted.
3293         (TEST_protocolMonoPolySigDoublePolyDefExplicit): Deleted.
3294         (TEST_intOverloadResolution): Deleted.
3295         (TEST_intOverloadResolutionReverseOrder): Deleted.
3296         (TEST_intOverloadResolutionGeneric): Deleted.
3297         (TEST_intLiteralGeneric): Deleted.
3298         (TEST_intLiteralGenericWithProtocols): Deleted.
3299         (TEST_uintLiteralGeneric): Deleted.
3300         (TEST_uintLiteralGenericWithProtocols): Deleted.
3301         (TEST_intLiteralGenericSpecific): Deleted.
3302         (TEST_simpleConstexpr): Deleted.
3303         (TEST_break): Deleted.
3304         (TEST_forLoop): Deleted.
3305         (TEST_chainConstexpr): Deleted.
3306         (TEST_chainGeneric): Deleted.
3307         (TEST_chainStruct): Deleted.
3308         (TEST_chainStructNewlyValid): Deleted.
3309         (TEST_chainStructDevice): Deleted.
3310         (TEST_paramChainStructDevice): Deleted.
3311         (TEST_simpleProtocolExtends): Deleted.
3312         (TEST_protocolExtendsTwo): Deleted.
3313         (TEST_prefixPlusPlus): Deleted.
3314         (TEST_prefixPlusPlusResult): Deleted.
3315         (TEST_postfixPlusPlus): Deleted.
3316         (TEST_postfixPlusPlusResult): Deleted.
3317         (TEST_prefixMinusMinus): Deleted.
3318         (TEST_prefixMinusMinusResult): Deleted.
3319         (TEST_postfixMinusMinus): Deleted.
3320         (TEST_postfixMinusMinusResult): Deleted.
3321         (TEST_plusEquals): Deleted.
3322         (TEST_plusEqualsResult): Deleted.
3323         (TEST_minusEquals): Deleted.
3324         (TEST_minusEqualsResult): Deleted.
3325         (TEST_timesEquals): Deleted.
3326         (TEST_timesEqualsResult): Deleted.
3327         (TEST_divideEquals): Deleted.
3328         (TEST_divideEqualsResult): Deleted.
3329         (TEST_twoIntLiterals): Deleted.
3330         (TEST_unifyDifferentLiterals): Deleted.
3331         (TEST_buildArrayThenSumItUsingArrayReference): Deleted.
3332         (TEST_overrideSubscriptStruct): Deleted.
3333         (TEST_overrideSubscriptStructAndDoStores): Deleted.
3334         (TEST_overrideSubscriptStructAndUsePointers): Deleted.
3335         (TEST_overrideSubscriptStructAndUsePointersIncorrectly): Deleted.
3336         (TEST_makeArrayRefFromPointer): Deleted.
3337         (TEST_makeArrayRefFromArrayRef): Deleted.
3338         (TEST_nonArrayRefArrayLengthSucceed): Deleted.
3339         (TEST_nonArrayRefArrayLengthFail): Deleted.
3340         (TEST_simpleSetter): Deleted.
3341         (TEST_genericAccessors): Deleted.
3342         (TEST_bitSubscriptAccessor): Deleted.
3343         (TEST_nestedSubscriptLValueEmulationSimple): Deleted.
3344         (TEST_nestedSubscriptLValueEmulationGeneric): Deleted.
3345         (TEST_boolBitAnd): Deleted.
3346         (TEST_boolBitOr): Deleted.
3347         (TEST_boolBitXor): Deleted.
3348         (TEST_boolBitNot): Deleted.
3349         (TEST_intBitAnd): Deleted.
3350         (TEST_intBitOr): Deleted.
3351         (TEST_intBitXor): Deleted.
3352         (TEST_intBitNot): Deleted.
3353         (TEST_intLShift): Deleted.
3354         (TEST_intRShift): Deleted.
3355         (TEST_uintBitAnd): Deleted.
3356         (TEST_uintBitOr): Deleted.
3357         (TEST_uintBitXor): Deleted.
3358         (TEST_uintBitNot): Deleted.
3359         (TEST_uintLShift): Deleted.
3360         (TEST_uintRShift): Deleted.
3361         (TEST_uint8BitAnd): Deleted.
3362         (TEST_uint8BitOr): Deleted.
3363         (TEST_uint8BitXor): Deleted.
3364         (TEST_uint8BitNot): Deleted.
3365         (TEST_uint8LShift): Deleted.
3366         (TEST_uint8RShift): Deleted.
3367         (TEST_floatMath): Deleted.
3368         (TEST_booleanMath): Deleted.
3369         (TEST_typedefArray): Deleted.
3370         (TEST_shaderTypes): Deleted.
3371         (TEST_instantiateStructInStruct): Deleted.
3372         (TEST_instantiateStructInStructWithInt2): Deleted.
3373         (TEST_simpleEnum): Deleted.
3374         (TEST_enumWithManualValues): Deleted.
3375         (TEST_enumWithoutZero): Deleted.
3376         (TEST_enumConstexprGenericFunction): Deleted.
3377         (TEST_enumConstexprGenericStruct): Deleted.
3378         (TEST_trap): Deleted.
3379         (TEST_enumWithExplicitIntBase): Deleted.
3380         (TEST_enumWithUintBase): Deleted.
3381         (TEST_enumFloatBase): Deleted.
3382         (TEST_enumStructBase): Deleted.
3383         (TEST_simpleSwitch): Deleted.
3384         (TEST_exhaustiveUint8Switch): Deleted.
3385         (TEST_notQuiteExhaustiveUint8Switch): Deleted.
3386         (TEST_switchFallThrough): Deleted.
3387         (TEST_switchBreak): Deleted.
3388         (TEST_enumSwitchBreakExhaustive): Deleted.
3389         (TEST_enumSwitchBreakNotQuiteExhaustive): Deleted.
3390         (TEST_simpleRecursiveStruct): Deleted.
3391         (TEST_linkedList): Deleted.
3392         * WebGPUShadingLanguageRI/Type.js:
3393         (Type.prototype.get isArray):
3394         * WebGPUShadingLanguageRI/TypeRef.js:
3395         (TypeRef.wrap):
3396         * WebGPUShadingLanguageRI/TypeVariableTracker.js:
3397         (TypeVariableTracker.prototype.set get return):
3398         (TypeVariableTracker.prototype.visitVariableRef):
3399         (TypeVariableTracker):
3400         * WebGPUShadingLanguageRI/Visitor.js:
3401         (Visitor.prototype.visitProtocolDecl):
3402         * WebGPUShadingLanguageRI/index.html:
3403
3404 2017-09-22  Matt Lewis  <jlewis3@apple.com>
3405
3406         Unreviewed, rolling out r222394.
3407
3408         This broke the Windows Debug Build.
3409
3410         Reverted changeset:
3411
3412         "Remove build-webkit's notion of feature flags having a
3413         default value"
3414         https://bugs.webkit.org/show_bug.cgi?id=177338
3415         http://trac.webkit.org/changeset/222394
3416
3417 2017-09-22  Tim Horton <timothy_horton@apple.com> and Michael Catanzaro <mcatanzaro@igalia.com>
3418
3419         Remove build-webkit's notion of feature flags having a default value
3420         https://bugs.webkit.org/show_bug.cgi?id=177338
3421
3422         Reviewed by Alex Christensen.
3423
3424         Delegate feature flag default values to the build system.
3425         (FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake and Options*.cmake for CMake, and FeatureDefines.h for everyone)
3426
3427         * BuildSlaveSupport/build.webkit.org-config/config.json:
3428         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3429         (Factory.__init__):
3430         Update GTK and WPE buildbot configuration to use --no-experimental-features on old stable
3431         bots instead of --default-cmake-features.
3432
3433         * Scripts/build-webkit:
3434         (cMakeArgsFromFeatures):
3435         Default feature values to 'undef'.
3436         Remove the --default-cmake-features argument; it is now the default.
3437         Add --no-experimental-features to replace it.
3438         Stop printing the default feature flag value in the help.
3439         Avoid propagating undefined values to the build system;
3440         only mention flags that are overridden on the command line.
3441
3442         This has the nice side effect of using the default CMake features
3443         for CMake builds, but still allowing toggling of them using the
3444         prettier --FEATURE and --no-FEATURE arguments.
3445
3446         * Scripts/webkitdirs.pm:
3447         (generateBuildSystemFromCMakeProject):
3448         No longer need to suppress CMake warnings about unused arguments.
3449
3450         * Scripts/webkitperl/FeatureList.pm:
3451         Remove the default values from the feature list.
3452
3453 2017-09-21  Joseph Pecoraro  <pecoraro@apple.com>
3454
3455         Unreviewed, add the ability to skip a test262 test.
3456
3457         * Scripts/run-jsc-stress-tests:
3458         Other handlers have :skip but a few didn't.
3459
3460 2017-09-21  Ryan Haddad  <ryanhaddad@apple.com>
3461
3462         Change architecture for ios-ews queue to arm64.
3463         https://bugs.webkit.org/show_bug.cgi?id=177332
3464
3465         Reviewed by Alexey Proskuryakov.
3466
3467         * Scripts/webkitpy/common/config/ews.json:
3468
3469 2017-09-21  Tim Horton  <timothy_horton@apple.com>
3470
3471         Use 'ninja' from the SDK if it exists
3472         https://bugs.webkit.org/show_bug.cgi?id=177330
3473
3474         Reviewed by Alex Christensen.
3475
3476         * Scripts/webkitdirs.pm:
3477         (canUseNinja):
3478         Check for ninja with xcrun in addition to commandExists() for Cocoa platforms.
3479
3480         (generateBuildSystemFromCMakeProject):
3481         (canUseNinjaGenerator): Deleted.
3482         Remove canUseNinjaGenerator; as noted in bug 177057, the Ninja generator
3483         is available in all versions of CMake supported by WebKit.
3484
3485 2017-09-21  Chris Dumez  <cdumez@apple.com>
3486
3487         Regression(r222308): new API tests are failing for !NETWORK_SESSION
3488         https://bugs.webkit.org/show_bug.cgi?id=177321
3489
3490         Reviewed by Alex Christensen.
3491
3492         Unskip API tests now that they pass everywhere.
3493
3494         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3495         (TEST):
3496
3497 2017-09-21  Filip Pizlo  <fpizlo@apple.com>
3498
3499         Unreviewed, fix ability to run tests in browser.
3500
3501         * WebGPUShadingLanguageRI/Test.html:
3502         * WebGPUShadingLanguageRI/index.html:
3503
3504 2017-09-21  Jonathan Bedard  <jbedard@apple.com>
3505
3506         webkitpy: Ignore failure to get updated selenium version
3507         https://bugs.webkit.org/show_bug.cgi?id=177205
3508         <rdar://problem/34531669>
3509
3510         Reviewed by Lucas Forschler.
3511
3512         Sometime asking PyPI for the latest version of Selenium fails. We should try and
3513         fallback to, at a minimum, version 3.5.0 or a newer installed version.
3514
3515         * Scripts/webkitpy/thirdparty/__init__.py:
3516         (AutoinstallImportHook.greater_than_equal_to_version): Return true if the second
3517         version string is greater than or equal to the first version string.
3518         (AutoinstallImportHook._install_selenium): If we can't get the latest PyPI url,
3519         fallback to version 3.5.0 or a newer installed version.
3520
3521 2017-09-21  Filip Pizlo  <fpizlo@apple.com>
3522
3523         WSL should have some post-instantiation type checking
3524         https://bugs.webkit.org/show_bug.cgi?id=177303
3525
3526         Reviewed by Keith Miller.
3527         
3528         This patch removes the Primitive protocol! Yay!
3529         
3530         The Primitive protocol was an attempt to handle the fact that Metal wouldn't allow us to point a
3531         non-thread pointer at data structures that have pointers. This type checking rule interacts badly with
3532         generics. I was able to get it to mostly work by making Primitive into a dynamic protocol - a type
3533         belongs to it if it happens to be isPrimitive.
3534         
3535         But that was a mistake, since it makes it hard to create pointers that are generic over address space.
3536         Also, it's not an appropriate rule for targeting SPIR-V logical mode. That rule will be different, and
3537         possibly more complicated.
3538         
3539         All of these kinds of rules are easier to implement of we run them after instantiation, since then they
3540         don't get in the way of generics. That's what this patch does.
3541         
3542         This means that we get all of the same type checking power as before, and we still can catch the errors
3543         that Metal requires us to check for. It's easier to do those checks now.
3544         
3545         Finally, this removes the shader type checker's incomplete reimplementation of isPrimitive (which was
3546         called NonNumericSearcher). The shader type checker calls isPrimitive now.
3547
3548         * WebGPUShadingLanguageRI/AddressSpace.js:
3549         (needsPrimitiveProtocol): Deleted.
3550         (protocolSuffix): Deleted.
3551         * WebGPUShadingLanguageRI/All.js:
3552         * WebGPUShadingLanguageRI/Checker.js:
3553         (Checker.prototype._checkShaderType):
3554         (Checker.prototype._checkShaderType.NonNumericSearcher): Deleted.
3555         (Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitArrayRefType): Deleted.
3556         (Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitPtrType): Deleted.
3557         (Checker.prototype.visitReferenceType): Deleted.
3558         * WebGPUShadingLanguageRI/FuncInstantiator.js:
3559         (FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitFuncDef):
3560         * WebGPUShadingLanguageRI/Inline.js:
3561         (_inlineFunction):
3562         * WebGPUShadingLanguageRI/Intrinsics.js:
3563         (Intrinsics):
3564         * WebGPUShadingLanguageRI/LateChecker.js: Added.
3565         (LateChecker):
3566         (LateChecker.prototype.visitReferenceType):
3567         (LateChecker.prototype._checkShaderType):
3568         (LateChecker.prototype.visitFuncDef):
3569         * WebGPUShadingLanguageRI/LexerToken.js:
3570         (LexerToken.prototype.get isInternal): Deleted.
3571         * WebGPUShadingLanguageRI/NativeType.js:
3572         (NativeType):
3573         (NativeType.prototype.get name):
3574         (NativeType.prototype.get isPrimitive):
3575         (NativeType.prototype.set isPrimitive):
3576         (NativeType.prototype.toString):
3577         * WebGPUShadingLanguageRI/Parse.js:
3578         (parseNative):
3579         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:
3580         (programWithUnnecessaryThingsRemoved):
3581         * WebGPUShadingLanguageRI/ProtocolDecl.js:
3582         * WebGPUShadingLanguageRI/ReferenceType.js:
3583         (ReferenceType.prototype.get elementType):
3584         (ReferenceType.prototype.get isPrimitive): Deleted.
3585         * WebGPUShadingLanguageRI/StandardLibrary.js:
3586         * WebGPUShadingLanguageRI/StatementCloner.js:
3587         (StatementCloner.prototype.visitNativeType):
3588         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
3589         (synthesizeStructAccessors):
3590         * WebGPUShadingLanguageRI/Test.js:
3591         (TEST_passNullAndNotNullFullPoly):
3592         (TEST_passNullAndNotNullFullPolyReverse):
3593         (TEST_nullTypeVariableUnify):
3594         (TEST_chainStructNewlyValid):
3595         (TEST_chainStructDevice):
3596         (TEST_chainStructInvalid): Deleted.
3597         * WebGPUShadingLanguageRI/Type.js:
3598         (Type.prototype.get isPrimitive):
3599
3600 2017-09-21  Chris Dumez  <cdumez@apple.com>
3601
3602         Unreviewed, temporarily disable new API tests introduced in r222308 until they pass on El Capitan
3603
3604         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3605         (TEST):
3606
3607 2017-09-21  Commit Queue  <commit-queue@webkit.org>
3608
3609         Unreviewed, rolling out r222272.
3610         https://bugs.webkit.org/show_bug.cgi?id=177316
3611
3612         This patch broke builds on some Win EWS bots. (Requested by
3613         perarne on #webkit).
3614
3615         Reverted changeset:
3616
3617         "[Win] Cygwin 64-bit EWS process cannot find Visual Studio
3618         installation."
3619         https://bugs.webkit.org/show_bug.cgi?id=177244
3620         http://trac.webkit.org/changeset/222272
3621
3622 2017-09-21  Filip Pizlo  <fpizlo@apple.com>
3623
3624         Unreviewed, fix a bug in the interactive app that was introduced by bad merging.