a91dd2c246b604c8f53371098f29dc8136a568b6
[WebKit-https.git] / Tools / ChangeLog
1 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [SOUP] WebSockets must use system proxy settings
4         https://bugs.webkit.org/show_bug.cgi?id=126384
5
6         Reviewed by Michael Catanzaro.
7
8         Check also WebSockets in /webkit2/WebKitWebContext/proxy.
9
10         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
11         (ProxyTest::webSocketProxyServerCallback):
12         (ProxyTest::ProxyTest):
13         (ProxyTest::webSocketConnected):
14         (ProxyTest::createWebSocketAndWaitUntilConnected):
15         (webSocketServerCallback):
16         (testWebContextProxySettings):
17         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
18         (WebKitTestServer::~WebKitTestServer):
19         (WebKitTestServer::addWebSocketHandler):
20         (WebKitTestServer::removeWebSocketHandler):
21         (WebKitTestServer::getWebSocketURIForPath const):
22         (WebKitTestServer::getURIForPath const):
23         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
24         (WebKitTestServer::baseURI const):
25         (WebKitTestServer::baseWebSocketURI const):
26
27 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
28
29         Add a way to check if a host is an IP address
30         https://bugs.webkit.org/show_bug.cgi?id=182427
31
32         Reviewed by Alex Christensen.
33
34         Add unit test for URL::hostIsIPAddress().
35
36         * TestWebKitAPI/Tests/WebCore/URL.cpp:
37         (TestWebKitAPI::TEST_F):
38
39 2018-02-03  Charlie Turner  <cturner@igalia.com>
40
41         Add libmount to WPE dependencies
42         https://bugs.webkit.org/show_bug.cgi?id=182345
43
44         Reviewed by Michael Catanzaro.
45
46         * wpe/install-dependencies:
47
48 2018-02-02  Youenn Fablet  <youenn@apple.com>
49
50         W3C test exporter should allow exporting newly added files
51         https://bugs.webkit.org/show_bug.cgi?id=182369
52
53         Reviewed by Ryosuke Niwa.
54
55         * Scripts/webkitpy/common/checkout/scm/git.py:
56         (Git.apply_mail_patch):
57
58 2018-02-02  David Quesada  <david_quesada@apple.com>
59
60         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
61         https://bugs.webkit.org/show_bug.cgi?id=182363
62         rdar://problem/37093498
63
64         Reviewed by Ryosuke Niwa.
65
66         Updated ApplicationManifestParserTests to account for the new default scope behavior.
67
68         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
69         (assertManifestHasDefaultValues):
70         (TEST_F):
71
72 2018-02-02  Youenn Fablet  <youenn@apple.com>
73
74         Clearing all service worker registrations should wait for importing service worker registration to finish
75         https://bugs.webkit.org/show_bug.cgi?id=182407
76
77         Reviewed by Chris Dumez.
78
79         Make sure we finish clearing service worker registrations before running tests.
80
81         * WebKitTestRunner/TestController.cpp:
82         (WTR::TestController::resetStateToConsistentValues):
83         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
84         (WTR::clearServiceWorkerRegistrationsCallback):
85         (WTR::TestController::clearServiceWorkerRegistrations):
86         * WebKitTestRunner/TestController.h:
87
88 2018-02-02  Youenn Fablet  <youenn@apple.com>
89
90         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
91         https://bugs.webkit.org/show_bug.cgi?id=182403
92
93         Reviewed by Alex Christensen.
94
95         * WebKitTestRunner/TestController.cpp:
96         (WTR::TestController::generateContextConfiguration const):
97         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
98         (WTR::initializeWebViewConfiguration):
99
100 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
101
102         [GTK] WebDriver: tests step always times out in the bot
103         https://bugs.webkit.org/show_bug.cgi?id=182437
104
105         Reviewed by Carlos Alberto Lopez Perez.
106
107         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
108         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
109
110         * Scripts/run-webdriver-tests: Call teardown() after run().
111         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
112         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
113         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
114         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
115         the display driver once and pass it to the test runners.
116         (WebDriverTestRunner.teardown): Stop the display server.
117         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
118         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
119         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
120         (WebDriverTestRunnerSelenium.run): Ditto.
121         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
122         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
123         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
124         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
125         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
126
127 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
128
129         Unreviewed, rolling out r227999.
130
131         It didn't fix the problem
132
133         Reverted changeset:
134
135         "Unreviewed. Try to avoid webdriver tests step timing out in
136         the bots."
137         https://trac.webkit.org/changeset/227999
138
139 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
140
141         Start timeout for the run-buildbot-test script is too aggressive
142         https://bugs.webkit.org/show_bug.cgi?id=182429
143
144         Reviewed by Carlos Garcia Campos.
145
146         15 seconds is not enough waiting for the update database process
147         to complete on a system backed with rotational HDDs. Raise it to 60.
148
149         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
150         (wait_for_master_ready):
151
152 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
153
154         re-add ARM JSCOnly bots on buildbot waterfall
155         https://bugs.webkit.org/show_bug.cgi?id=182428
156
157         Reviewed by Csaba Osztrogonác.
158
159         * BuildSlaveSupport/build.webkit.org-config/config.json:
160         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
161
162 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
163
164         Remove ARM JSCOnly bots from buildbot waterfall
165         https://bugs.webkit.org/show_bug.cgi?id=182398
166
167         Reviewed by Alexey Proskuryakov.
168
169         * BuildSlaveSupport/build.webkit.org-config/config.json:
170         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
171
172 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
173
174         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
175
176         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
177         workaround for a bug in python2.7 when using multiprocess module.
178
179         * Scripts/run-webdriver-tests:
180
181 2018-02-01  Youenn Fablet  <youenn@apple.com>
182
183         Delay service worker process creation until actually needed by SWServer
184         https://bugs.webkit.org/show_bug.cgi?id=182301
185
186         Reviewed by Chris Dumez.
187
188         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
189         (function):
190
191 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
192
193         Bubbles intermittently disappear from bot watchers dashboard
194         https://bugs.webkit.org/show_bug.cgi?id=182085
195
196         Reviewed by Alexey Proskuryakov.
197
198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
199         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
200         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
201         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
202
203 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
204
205         [GTK] Problem with Washington Post images
206         https://bugs.webkit.org/show_bug.cgi?id=181421
207
208         Reviewed by Carlos Alberto Lopez Perez.
209
210         Add test case for the new user agent quirk.
211
212         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
213         (TestWebKitAPI::TEST):
214
215 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
216
217         [GTK] MiniBrowser settings are just a list of names
218         https://bugs.webkit.org/show_bug.cgi?id=182005
219
220         Reviewed by Sergio Villar Senin.
221
222         The default size we are using is too small to show the values column, and the window is not resizable because
223         GObjectClass::constructed() is not called in the parent class.
224
225         * MiniBrowser/gtk/BrowserSettingsDialog.c:
226         (browser_settings_dialog_init): Use 600x400 as default size.
227         (browserSettingsDialogConstructed): Chain up to parent constructed.
228
229 2018-01-31  Andres Gomez  <agomez@igalia.com>
230
231         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
232
233         * Scripts/webkitpy/common/config/watchlist:
234
235 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
236
237         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
238         https://bugs.webkit.org/show_bug.cgi?id=181204
239         <rdar://problem/36256274>
240
241         Reviewed by Ryosuke Niwa.
242
243         Implement 'testRunner.forceImmediateCompletion()' for WK1.
244
245         * DumpRenderTree/TestRunner.cpp:
246         (forceImmediateCompletionCallback):
247         (TestRunner::staticFunctions):
248
249 2018-01-31  Alex Christensen  <achristensen@webkit.org>
250
251         Unreviewed, rolling out r227942.
252
253         r227875 should not have been rolled out.
254
255         Reverted changeset:
256
257         "Unreviewed, rolling out r227875."
258         https://bugs.webkit.org/show_bug.cgi?id=182357
259         https://trac.webkit.org/changeset/227942
260
261 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
262
263         Unreviewed, rolling out r227875.
264         https://bugs.webkit.org/show_bug.cgi?id=182357
265
266         Missing cross-platform TestController implementation
267
268         Reverted changeset:
269
270         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
271         https://bugs.webkit.org/show_bug.cgi?id=181958
272         https://trac.webkit.org/changeset/227875
273
274         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
275         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
276         (WTR::InjectedBundle::didReceiveMessageToPage):
277         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
278         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
279         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
280         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
281         * WebKitTestRunner/InjectedBundle/TestRunner.h:
282         * WebKitTestRunner/TestInvocation.cpp:
283         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
284         * WebKitTestRunner/TestInvocation.h:
285         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
286         (WTR::TestController::statisticsUpdateCookiePartitioning):
287         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
288
289 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
290
291         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
292         https://bugs.webkit.org/show_bug.cgi?id=182222
293
294         Reviewed by Alex Christensen.
295
296         Use the new API to notify when resource load statistics deletion is complete.
297
298         * WebKitTestRunner/TestController.cpp:
299         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
300         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
301         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
302
303 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
304
305         Add the support for running StyleBench to run-benchmark
306         https://bugs.webkit.org/show_bug.cgi?id=182323
307
308         Reviewed by Antti Koivisto.
309
310         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
311
312         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
313         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
314
315 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
316
317         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
318         https://bugs.webkit.org/show_bug.cgi?id=182339
319         <rdar://problem/36041396>
320
321         Reviewed by Andy Estes.
322
323         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
324         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
325         check against the length of the data written.
326
327         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
328         (testIconImageData):
329         (runTestWithTemporaryFolder):
330         (TestWebKitAPI::TEST):
331
332 2018-01-31  Dan Bernstein  <mitz@apple.com>
333
334         [macOS] MiniBrowser isn’t app-sandboxed
335         https://bugs.webkit.org/show_bug.cgi?id=182147
336
337         Reviewed by Sam Weinig.
338
339         Enable App Sandbox and add a temporary exception allowing read access to all files.
340
341         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
342         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
343         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
344           and read access from /.
345         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
346
347 2018-01-31  Philippe Normand  <pnormand@igalia.com>
348
349         [JHBuild] Add gstreamer-vaapi in moduleset
350         https://bugs.webkit.org/show_bug.cgi?id=182283
351
352         Reviewed by Carlos Alberto Lopez Perez.
353
354         GStreamer-VAAPI is required for hardware-accelerated video
355         playback support on Intel and AMD (using radeosi driver)
356         platforms.
357
358         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
359         * gtk/install-dependencies: Install libva.
360         * wpe/install-dependencies: Ditto.
361         * Scripts/webkitpy/port/gtk.py:
362         (GtkPort.setup_environ_for_server): Disable va-api support when
363         testing because it's incompatible with Mesa's softGL driver.
364
365 2018-01-31  Charlie Turner  <cturner@igalia.com>
366
367         [WPE] Update jhbuild dependencies
368         https://bugs.webkit.org/show_bug.cgi?id=182286
369
370         This upgrades the following packages,
371         glib 2.44.1 -> 2.54.3
372         glib-networking 2.42.0 -> 2.54.1
373         libsoup 2.48.0 -> 2.60.3
374
375         The initial reason for performing these upgrades was that when
376         visiting https://youtube.com, WPE was getting TLS certificate
377         errors. After upgrading glib-networking, these were fixed, but the
378         upgrade introduced dependencies on newer versions of the other
379         packages upgraded in this commit.
380
381         The upgrade to glib caused a linking error in gstreamer, the
382         following errors were being logged during linking,
383
384         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
385         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
386         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
387
388         This was fixed by adding the glib package built in the jhbuild to
389         harfbuzz.
390
391         Finally, the upgrade of glib caused the glib-warning-fix.patch to
392         no longer apply, so this patch was removed.
393
394         Reviewed by Michael Catanzaro.
395
396         * wpe/jhbuild.modules: Added dependecies.
397         * wpe/patches/glib-warning-fix.patch: Removed.
398
399 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
400
401         Unreviewed, rolling out r227782.
402
403         It didn't fix the problem
404
405         Reverted changeset:
406
407         "Unreviewed. Try to avoid webdriver tests step timing out in
408         the bots."
409         https://trac.webkit.org/changeset/227782
410
411 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
412
413         WebDriver: add domains to server config in w3c tests
414         https://bugs.webkit.org/show_bug.cgi?id=182294
415
416         Reviewed by Carlos Alberto Lopez Perez.
417
418         Several cookie tests expect server_config to have a domains key.
419
420         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
421                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
422
423         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
424         (WebDriverW3CExecutor.__init__):
425
426 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
427
428         Unreviewed. Update W3C WebDriver imported tests.
429
430         Show full pytest failure logs.
431
432         pytest truncates long lists when printing a failed assertion.
433         This is not great for debugging and arguably it should be the
434         default to show the full diff when comparing lists.
435
436         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
437         (run):
438
439 2018-01-30  John Wilander  <wilander@apple.com>
440
441         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
442         https://bugs.webkit.org/show_bug.cgi?id=181958
443         https://bugs.webkit.org/show_bug.cgi?id=182072
444         <rdar://problem/36801804>
445         <rdar://problem/36845795>
446
447         Reviewed by Brent Fulgham.
448
449         Because of the asynchronous nature of XPC and cookies,
450         we need callbacks in these TestRunner functions so that
451         the layout tests can wait for state changes to finish
452         before checking test conditions.
453
454         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
455         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
456         (WTR::InjectedBundle::didReceiveMessageToPage):
457         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
458         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
459         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
460         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
461         * WebKitTestRunner/InjectedBundle/TestRunner.h:
462         * WebKitTestRunner/TestInvocation.cpp:
463         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
464         * WebKitTestRunner/TestInvocation.h:
465         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
466         (WTR::TestController::statisticsUpdateCookiePartitioning):
467         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
468
469 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
470
471         [webkitpy] Config file for apache is copied twice.
472         https://bugs.webkit.org/show_bug.cgi?id=182131
473
474         Reviewed by Daniel Bates.
475
476         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
477         (LayoutTestApacheHttpd.__init__):
478         (LayoutTestApacheHttpd._copy_apache_config_file):
479         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
480
481 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
482
483         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
484         https://bugs.webkit.org/show_bug.cgi?id=182312
485
486         Reviewed by Michael Catanzaro.
487
488         * DumpRenderTree/config.h:
489         * TestWebKitAPI/config.h:
490         * WebKitTestRunner/config.h:
491
492 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
493
494         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
495         https://bugs.webkit.org/show_bug.cgi?id=182307
496         <rdar://problem/36041485>
497
498         Reviewed by Ryosuke Niwa.
499
500         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
501         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
502         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
503         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
504
505         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
506         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
507         (TestWebKitAPI::TEST):
508
509 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
510
511         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
512         https://bugs.webkit.org/show_bug.cgi?id=182284
513
514         Reviewed by Michael Catanzaro.
515
516         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
517         * wpe/manifest.txt.in: Ditto.
518
519 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
520
521         Unreviewed, try to fix JSCOnly build
522         https://bugs.webkit.org/show_bug.cgi?id=177202
523
524         * CMakeLists.txt:
525
526 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
527
528         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
529
530         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
531         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
532         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
533         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
534
535         * Scripts/run-webdriver-tests:
536         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
537         (WebDriverTestRunner.dump_results_to_json_file):
538
539 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
540
541         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
542         https://bugs.webkit.org/show_bug.cgi?id=177202
543
544         Reviewed by Alex Christensen.
545
546         * CMakeLists.txt:
547
548 2018-01-29  Alex Christensen  <achristensen@webkit.org>
549
550         Clean up API after bugs 178240 and 176474
551         https://bugs.webkit.org/show_bug.cgi?id=182259
552
553         Reviewed by Dan Bernstein.
554
555         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
556         (TEST):
557         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
558
559 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
560
561         [WebAuthN] Add a compile-time feature flag
562         https://bugs.webkit.org/show_bug.cgi?id=182211
563         <rdar://problem/36936365>
564
565         Reviewed by Brent Fulgham.
566
567         * Scripts/webkitperl/FeatureList.pm:
568         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
569
570 2018-01-29  Brady Eidson  <beidson@apple.com>
571
572         Make the API test added in r227737 be Mac-only.
573
574         Unreviewed gardening.
575
576         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
577
578 2018-01-29  Matt Lewis  <jlewis3@apple.com>
579
580         Unreviewed, rolling out r227731.
581
582         This caused and assertion failure in API tests.
583
584         Reverted changeset:
585
586         "Layout Test fast/events/beforeunload-dom-manipulation-
587         crash.html is crashing"
588         https://bugs.webkit.org/show_bug.cgi?id=181204
589         https://trac.webkit.org/changeset/227731
590
591 2018-01-29  Youenn Fablet  <youenn@apple.com>
592
593         WPT test exporter should add WebKit export in its PR description
594         https://bugs.webkit.org/show_bug.cgi?id=182246
595
596         Reviewed by Chris Dumez.
597
598         Updating PR description body to contain the words 'WebKit export'.
599         That way, WPT PR bot will mark the PR as reviewed downstream.
600
601         * Scripts/webkitpy/w3c/test_exporter.py:
602         (TestExporter.__init__):
603         (TestExporter.make_pull_request):
604         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
605         (TestExporterTest.test_export):
606
607 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
608
609         Add the support for running Speedometer 2.0 to run-benchmark
610         https://bugs.webkit.org/show_bug.cgi?id=182231
611
612         Reviewed by Antti Koivisto.
613
614         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
615         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
616         requires aggregating the geometric mean out of total time spent in each suite.
617
618         Also added --show-iteration-values to show individual measured values in each iteration.
619
620         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
621         (BenchmarkResults.format): Added show_iteration_values as an option.
622         (BenchmarkResults._format_tests): Ditto.
623         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
624         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
625         is easily parsable as a JSON array.
626         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
627         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
628         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
629         had exactly one aggregator.
630         (BenchmarkResults._lint_results):
631         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
632         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
633         parent_aggregator_list.
634         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
635         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
636         (BenchmarkResults._lint_configuration):
637         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
638         (test_format_values_with_no_unit_scaling): Added.
639         (test_format_values_with_iteration_values): Added.
640         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
641         (test_aggregate_results_from_another_aggregator): Added.
642         (test_lint_results): Added a test case.
643         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
644         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
645         (BenchmarkRunner._run_benchmark): Ditto.
646         (BenchmarkRunner.show_results): Ditto.
647         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
648         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
649         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
650         (parse_args): Added --show-iteration-values as a boolean argument.
651         (run_benchmark_plan): Ditto.
652         (start): Ditto.
653         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
654         (WebServerBenchmarkRunner.__init__): Ditto.
655
656 2018-01-29  Brady Eidson  <beidson@apple.com>
657
658         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
659         https://bugs.webkit.org/show_bug.cgi?id=182229
660
661         Reviewed by Chris Dumez.
662
663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
664         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
665
666 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
667
668         WebDriver: properly recover w3c tests after a webdriver server crash
669         https://bugs.webkit.org/show_bug.cgi?id=182242
670
671         Reviewed by Carlos Alberto Lopez Perez.
672
673         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
674         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
675         relaunching the server after every test failure, because other failures, even when not crashing the server,
676         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
677         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
678
679         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
680         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
681         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
682         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
683         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
684         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
685         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
686         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
687
688 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
689
690         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
691         https://bugs.webkit.org/show_bug.cgi?id=181204
692         <rdar://problem/36256274>
693
694         Reviewed by Ryosuke Niwa.
695
696         Implement 'testRunner.forceImmediateCompletion()' for WK1.
697
698         * DumpRenderTree/TestRunner.cpp:
699         (forceImmediateCompletionCallback):
700         (TestRunner::staticFunctions):
701
702 2018-01-29  Frederic Wang  <fwang@igalia.com>
703
704         Unreviewed, add myself to some watch lists.
705
706         * Scripts/webkitpy/common/config/watchlist:
707
708 2018-01-27  Dan Bernstein  <mitz@apple.com>
709
710         HaveInternalSDK includes should be "#include?"
711         https://bugs.webkit.org/show_bug.cgi?id=179670
712
713         * DumpRenderTree/mac/Configurations/Base.xcconfig:
714
715 2018-01-26  Chris Dumez  <cdumez@apple.com>
716
717         Make sure service worker code does not launch a StorageProcess unnecessarily
718         https://bugs.webkit.org/show_bug.cgi?id=182192
719         <rdar://problem/36927427>
720
721         Reviewed by Geoffrey Garen.
722
723         Add API test coverage.
724
725         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
726
727 2018-01-26  Chris Dumez  <cdumez@apple.com>
728
729         Offlined content does not work for apps on home screen
730         https://bugs.webkit.org/show_bug.cgi?id=182070
731         <rdar://problem/36843906>
732
733         Reviewed by Youenn Fablet.
734
735         Add API test coverage to make sure an already registered service worker is able to intercept
736         the very first load.
737
738         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
739         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
740
741 2018-01-26  Chris Nardi  <cnardi@chromium.org>
742
743         Addressing post-review comments after r226614
744         https://bugs.webkit.org/show_bug.cgi?id=182151
745
746         Reviewed by Myles C. Maxfield.
747
748         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
749         (TestWebKitAPI::TEST):
750
751 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
752
753         Unreviewed, rolling out r224920.
754
755         Some Win EWS bots are not coming back up after starting reboot.
756
757         * EWSTools/start-queue-win.sh:
758
759 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
760
761         WebDriver: simplify the tests json report
762         https://bugs.webkit.org/show_bug.cgi?id=182171
763
764         Reviewed by Carlos Alberto Lopez Perez.
765
766         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
767         form the subtest name. We should do the same for simplicity and compatibility with WPT.
768
769         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
770         (WebDriverTestRunner.dump_results_to_json_file):
771
772 2018-01-25  Alex Christensen  <achristensen@webkit.org>
773
774         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
775         https://bugs.webkit.org/show_bug.cgi?id=182152
776
777         Reviewed by Joseph Pecoraro.
778
779         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
780         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
781         (TEST):
782
783 2018-01-25  Youenn Fablet  <youenn@apple.com>
784
785         WebPluginInfoProvider should handle null host queries
786         https://bugs.webkit.org/show_bug.cgi?id=182112
787
788         Reviewed by Chris Dumez.
789
790         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
791         (TEST):
792
793 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
794
795         [webkitpy] Stop modifying path information only when running on Cygwin
796         https://bugs.webkit.org/show_bug.cgi?id=182136
797
798         On LayoutTestApacheHttpd, some path configuration is modified when platform
799         is Windows. This modification is only required for AppleWin running on Cygwin.
800         WinCairo uses native Windows environment, so the condition should be changed.
801
802         Reviewed by Per Arne Vollan.
803
804         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
805         (LayoutTestApacheHttpd.__init__):
806         (LayoutTestApacheHttpd._get_apache_config_file_path):
807
808 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
809
810         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
811         https://bugs.webkit.org/show_bug.cgi?id=182038
812         <rdar://problem/36812083>
813
814         Reviewed by Jer Noble.
815
816         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
817         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
818
819 2018-01-24  Daniel Bates  <dabates@apple.com>
820
821         webkit-patch upload emits irrelevant simulator warnings
822         https://bugs.webkit.org/show_bug.cgi?id=181702
823         <rdar://problem/36556359>
824
825         Reviewed by Aakash Jain.
826
827         Remove warning when a person explicitly passes --child-processes with a value greater than
828         the default number of simulator instances webkitpy would have used had --child-processes
829         been omitted. Moreover, the placement of the warning logic to support printing such a message
830         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
831
832         By default, webkitpy will parallelize running tests using the maximum number of simulator
833         instances that can be supported based on available system resources at the time run-webkit-tests
834         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
835         by specifying --child-processes knows what they are doing. The effects of picking a large
836         value be obvious, the system may become sluggish.
837
838         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
839         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
840
841         * Scripts/webkitpy/port/ios_simulator.py:
842         (IOSSimulatorPort.__init__):
843
844 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
845
846         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
847         https://bugs.webkit.org/show_bug.cgi?id=182102
848
849         Reviewed by Carlos Garcia Campos.
850
851         * MiniBrowser/gtk/main.c:
852         (main): Removed the call to set_enable_webvr().
853
854 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
855
856         WebDriver: add support for slow tests
857         https://bugs.webkit.org/show_bug.cgi?id=182095
858
859         Reviewed by Carlos Alberto Lopez Perez.
860
861         Add timeout mark to slow tests.
862
863         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
864         (TestExpectationsMarker.__init__): Save the timeout.
865         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
866         (run): Pass timeout to TestExpectationsMarker constructor.
867
868 2018-01-24  Alex Christensen  <achristensen@webkit.org>
869
870         Gracefully recover from NetworkProcess crashes in private browsing
871         https://bugs.webkit.org/show_bug.cgi?id=182073
872         <rdar://problem/36572023>
873
874         Reviewed by Geoff Garen.
875
876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
877         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
878         (-[CrashDelegate webView:didFinishNavigation:]):
879         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
880         (-[CrashDelegate webView:didFailNavigation:withError:]):
881         (TEST):
882
883 2018-01-24  Ali Juma  <ajuma@chromium.org>
884
885         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
886         https://bugs.webkit.org/show_bug.cgi?id=182052
887
888         Reviewed by Simon Fraser.
889
890         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
891         immediately.
892
893         Test: fast/visual-viewport/viewport-dimensions.html
894
895         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
896         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
897
898 2018-01-24  Alex Christensen  <achristensen@webkit.org>
899
900         Remove pre-Sierra-OS-specific code in Tools
901         https://bugs.webkit.org/show_bug.cgi?id=182034
902
903         Reviewed by Tim Horton.
904
905         * DumpRenderTree/mac/DumpRenderTree.mm:
906         (setDefaultsToConsistentValuesForTesting):
907         * MiniBrowser/mac/BrowserWindowController.m:
908         (-[BrowserWindowController windowDidLoad]):
909         (-[BrowserWindowController share:]):
910         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
911         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
912         (-[EventStreamPlayer playbackTimerFired:]):
913         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
914         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
915         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
916         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
917         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
918         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
919         (WTR::InjectedBundle::platformInitialize):
920         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
921         (WTR::initializeWebViewConfiguration):
922
923 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
924
925         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
926         https://bugs.webkit.org/show_bug.cgi?id=181400
927         <rdar://problem/36358768>
928
929         Reviewed by Joseph Pecoraro.
930
931         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
932
933         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
934         Always disable poisoning when running with --leaks, as this should work locally,
935         not just on bots.
936
937 2018-01-24  Daniel Bates  <dabates@apple.com>
938
939         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
940         https://bugs.webkit.org/show_bug.cgi?id=181993
941         <rdar://problem/36421080>
942
943         Reviewed by David Hyatt.
944
945         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
946         as we no longer support this strategy.
947
948         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
949
950 2018-01-24  David Kilzer  <ddkilzer@apple.com>
951
952         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
953         <https://webkit.org/b/182015>
954         <rdar://problem/36449728>
955
956         Reviewed by Tim Horton.
957
958         * Scripts/webkitpy/style/checkers/cpp.py:
959         (regex_for_lambdas_and_blocks): Update regex to include
960         optional return type for block argument in Objective-C.
961         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
962         (WebKitStyleTest.test_braces): Add test.
963
964 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
965
966         WPE-focused test gardening.
967         https://bugs.webkit.org/show_bug.cgi?id=182051
968
969         Unreviewed test gardening.
970
971         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
972
973 2018-01-23  Mark Lam  <mark.lam@apple.com>
974
975         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
976         https://bugs.webkit.org/show_bug.cgi?id=182017
977         <rdar://problem/36795513>
978
979         Reviewed by Filip Pizlo and JF Bastien.
980
981         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
982         (TestWebKitAPI::TEST):
983         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
984         (TestWebKitAPI::TEST):
985         (TestWebKitAPI::passWithRef):
986         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
987         (TestWebKitAPI::TEST):
988         (TestWebKitAPI::f1):
989         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
990         (TestWebKitAPI::TEST):
991         (TestWebKitAPI::poisonedPtrFoo):
992         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
993         (TestWebKitAPI::TEST):
994         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
995         (TestWebKitAPI::TEST):
996
997 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
998
999         [WebVR] Add OpenVR to the tree and to the build
1000         https://bugs.webkit.org/show_bug.cgi?id=177298
1001
1002         Reviewed by Žan Doberšek.
1003
1004         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
1005         with reduced style checks.
1006
1007 2018-01-24  Chris Nardi  <cnardi@chromium.org>
1008
1009         Add Chris Nardi to contributors list
1010         https://bugs.webkit.org/show_bug.cgi?id=182029
1011
1012         Reviewed by Antti Koivisto.
1013
1014         * Scripts/webkitpy/common/config/contributors.json:
1015
1016 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1017
1018         Mac Sierra perf bots have been failing due to CG errors
1019         https://bugs.webkit.org/show_bug.cgi?id=181955
1020
1021         Reviewed by Antti Koivisto.
1022
1023         Ignore the CoreGraphics error messages on macOS Sierra.
1024
1025         Also added tests for ignoring lines in stdout and stderr.
1026
1027         * Scripts/webkitpy/performance_tests/perftest.py:
1028         (PerfTest.run_failed): Refactored for clarity.
1029         (PerfTest):
1030         (PerfTest.filter_ignored_lines): Added.
1031         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
1032         are now used to ignore lines in other kinds of tests than parser tests.
1033         (PerfTest._errors_to_ignore_in_sierra): Added.
1034         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
1035         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1036         (test_parse_output_with_ignored_stdout): Added.
1037         (test_parse_output_with_ignored_stderr): Added.
1038         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
1039
1040 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
1041
1042         Resign NowPlaying status when no media element is eligible
1043         https://bugs.webkit.org/show_bug.cgi?id=181914
1044         <rdar://problem/35294116>
1045
1046         Reviewed by Jer Noble.
1047
1048         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1049         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1050         (TestWebKitAPI::TEST):
1051         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1052
1053 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1054
1055         [WinCairo] Use 64-bit toolset
1056         https://bugs.webkit.org/show_bug.cgi?id=181979
1057
1058         Reviewed by Alex Christensen.
1059
1060         Use 64-bit toolset for 64-bit build in order to improve build time. 
1061
1062         * Scripts/webkitdirs.pm:
1063         (generateBuildSystemFromCMakeProject):
1064
1065 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
1066
1067         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
1068         https://bugs.webkit.org/show_bug.cgi?id=181741
1069         rdar://problem/36593581
1070
1071         Reviewed by Tim Horton.
1072         
1073         If zoomToScale:animated: is called with the current zoom level, call the callback
1074         rather than doing nothing.
1075
1076         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1077         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1078
1079 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1080
1081         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
1082         https://bugs.webkit.org/show_bug.cgi?id=180820
1083
1084         Reviewed by David Kilzer.
1085
1086         * Scripts/webkitpy/common/checkout/scm/git.py:
1087         (Git.in_working_directory):
1088         (Git.clone):
1089         (Git.read_git_config):
1090         (Git.apply_reverse_diff):
1091         * Scripts/webkitpy/common/checkout/scm/scm.py:
1092         (SCM.run):
1093         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1094         * Scripts/webkitpy/common/checkout/scm/svn.py:
1095         (SVNRepository.has_authorization_for_realm):
1096         * Scripts/webkitpy/common/net/credentials_unittest.py:
1097         * Scripts/webkitpy/common/system/abstractexecutive.py:
1098         (AbstractExecutive.run_command):
1099         * Scripts/webkitpy/common/system/executive.py:
1100         (Executive.kill_process.is):
1101         (Executive.running_pids):
1102         (Executive.kill_all):
1103         (Executive.run_command):
1104         * Scripts/webkitpy/common/system/executive_mock.py:
1105         (MockExecutive.run_command):
1106         (MockExecutive2.run_command):
1107         * Scripts/webkitpy/common/system/executive_unittest.py:
1108         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
1109         * Scripts/webkitpy/common/system/platforminfo.py:
1110         (PlatformInfo.xcode_sdk_version):
1111         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1112         (Lighttpd._check_and_kill):
1113         * Scripts/webkitpy/port/base.py:
1114         (Port._symbols_string):
1115         * Scripts/webkitpy/port/gtk.py:
1116         (GtkPort.setup_environ_for_server):
1117         * Scripts/webkitpy/port/win.py:
1118         (WinPort._runtime_feature_list):
1119         (WinPort.read_registry_value):
1120         * Scripts/webkitpy/port/win_unittest.py:
1121         (WinPortTest.test_runtime_feature_list):
1122         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1123         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
1124
1125 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1126
1127         Unreviewed, rolling out r227279 and r227373.
1128         https://bugs.webkit.org/show_bug.cgi?id=181988
1129
1130         The LayoutTest crash fix introduced an API test failure.
1131         (Requested by ryanhaddad on #webkit).
1132
1133         Reverted changesets:
1134
1135         "Resign NowPlaying status when no media element is eligible"
1136         https://bugs.webkit.org/show_bug.cgi?id=181914
1137         https://trac.webkit.org/changeset/227279
1138
1139         "Resign NowPlaying status when no media element is eligible"
1140         https://bugs.webkit.org/show_bug.cgi?id=181914
1141         https://trac.webkit.org/changeset/227373
1142
1143 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1144
1145         Unreviewed. Add test case for slow in test_expectations.py.
1146
1147         I forgot to also check slow tests in test_expectations.py unit tests.
1148
1149         * Scripts/webkitpy/common/test_expectations_unittest.py:
1150         (assert_slow):
1151         (test_build_type):
1152         (test_slow):
1153
1154 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1155
1156         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
1157
1158         * TestWebKitAPI/glib/TestExpectations.json:
1159
1160 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1161
1162         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
1163         https://bugs.webkit.org/show_bug.cgi?id=181616
1164         <rdar://problem/36484908>
1165
1166         Reviewed by Wenson Hsieh.
1167
1168         Added tests to make sure we sanitize plain HTML, not just web archives,
1169         when and only when custom pasteboard data is enabled.
1170
1171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1172         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
1173         (writeHTMLToPasteboard): Added.
1174         (createWebViewWithCustomPasteboardDataSetting): Added.
1175
1176 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
1177
1178         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
1179         https://bugs.webkit.org/show_bug.cgi?id=181400
1180         rdar://problem/36358768
1181
1182         Reviewed by JF Bastien.
1183
1184         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
1185
1186 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1187
1188         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
1189         https://bugs.webkit.org/show_bug.cgi?id=181929
1190
1191         Reviewed by Michael Catanzaro.
1192
1193         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
1194         the website data completion callback is not called immediately, and a new file is created when the operation
1195         finishes. We need to check that the file was removing after calling clear.
1196
1197         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1198         (fileChangedCallback):
1199         (testWebsiteDataResourceLoadStatistics):
1200
1201 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1202
1203         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
1204
1205         * TestWebKitAPI/glib/TestExpectations.json:
1206
1207 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1208
1209         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
1210
1211         Partially revert r226782, the fix was wrong for the GLib version we currently use.
1212
1213         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1214         (testWebKitConsoleMessageNetworkError):
1215
1216 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1217
1218         Unreviewed. Remove unused verbose mode from GLib API tests runner.
1219
1220         * glib/api_test_runner.py:
1221         (add_options):
1222
1223 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1224
1225         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1226         https://bugs.webkit.org/show_bug.cgi?id=181918
1227
1228         Reviewed by Tim Horton.
1229
1230         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1231
1232         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1233
1234 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
1235
1236         Resign NowPlaying status when no media element is eligible
1237         https://bugs.webkit.org/show_bug.cgi?id=181914
1238         <rdar://problem/35294116>
1239
1240         Reviewed by Jer Noble.
1241
1242         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1243         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1244         (TestWebKitAPI::TEST):
1245         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1246
1247 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
1248
1249         Fix broken unit-tests after r227192
1250         https://bugs.webkit.org/show_bug.cgi?id=181909
1251
1252         Reviewed by Carlos Garcia Campos.
1253
1254         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1255
1256 2018-01-20  Chris Dumez  <cdumez@apple.com>
1257
1258         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
1259         https://bugs.webkit.org/show_bug.cgi?id=174984
1260         <rdar://problem/33665676>
1261
1262         Reviewed by Alexey Proskuryakov.
1263
1264         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
1265
1266         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
1267         (TEST):
1268
1269 2018-01-20  Brian Burg  <bburg@apple.com>
1270
1271         WebDriver: fix some nits that prevent running W3C tests on Mac
1272         https://bugs.webkit.org/show_bug.cgi?id=181864
1273
1274         Reviewed by Carlos Garcia Campos.
1275
1276         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1277         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
1278         as we assume that the property exists later.
1279
1280         (WebDriverW3CWebServer.stop): If the temporary file doesn't
1281         exist for some reason, the remove call will raise and exception.
1282         Gracefully handle the case where the file isn't created due to
1283         a problem/exception that happened elsewhere.
1284
1285 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
1286
1287         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
1288         https://bugs.webkit.org/show_bug.cgi?id=181881
1289
1290         Reviewed by Alexey Proskuryakov.
1291
1292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1293         (BubbleQueueServer):
1294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1295         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1296         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
1297
1298 2018-01-19  Youenn Fablet  <youenn@apple.com>
1299
1300         Do not go to the storage process when registering a service worker client if there is no service worker registered
1301         https://bugs.webkit.org/show_bug.cgi?id=181740
1302         <rdar://problem/36650400>
1303
1304         Reviewed by Chris Dumez.
1305
1306         Add support for internals inside API tests.
1307
1308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1309         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
1310         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
1311         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
1312         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
1313         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
1314         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1315         (setConfigurationInjectedBundlePath):
1316         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
1317
1318 2018-01-19  John Wilander  <wilander@apple.com>
1319
1320         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
1321         https://bugs.webkit.org/show_bug.cgi?id=181822
1322         https://bugs.webkit.org/show_bug.cgi?id=175263
1323         https://bugs.webkit.org/show_bug.cgi?id=178536
1324         https://bugs.webkit.org/show_bug.cgi?id=181223
1325         https://bugs.webkit.org/show_bug.cgi?id=181482
1326         <rdar://problem/33491222>
1327         <rdar://problem/33805293>
1328         <rdar://problem/36332683>
1329         <rdar://problem/36549026>
1330
1331         Reviewed by Alex Christensen.
1332
1333         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1334         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1335         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1336         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1337         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1338         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1339         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1340         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1341
1342 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
1343
1344         run-webkit-tests fails when there is a curly brace in Xcode build output
1345         https://bugs.webkit.org/show_bug.cgi?id=181254
1346         <rdar://problem/36453374>
1347
1348         Reviewed by Daniel Bates.
1349
1350         * Scripts/webkitpy/port/base.py:
1351         (Port._run_script): Encode script output before logging it.
1352
1353 2018-01-19  Chris Dumez  <cdumez@apple.com>
1354
1355         Service worker registrations restored from disk may not be reused when the JS calls register() again
1356         https://bugs.webkit.org/show_bug.cgi?id=181810
1357         <rdar://problem/36591711>
1358
1359         Reviewed by Youenn Fablet.
1360
1361         Add API test coverage.
1362
1363         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1364         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
1365         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
1366
1367 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
1368
1369         Remove El Capitan queues from flakiness dashboard
1370         https://bugs.webkit.org/show_bug.cgi?id=181860
1371
1372         Reviewed by Aakash Jain.
1373
1374         * TestResultServer/static-dashboards/builders.jsonp:
1375
1376 2018-01-19  Keith Miller  <keith_miller@apple.com>
1377
1378         HaveInternalSDK includes should be "#include?"
1379         https://bugs.webkit.org/show_bug.cgi?id=179670
1380
1381         Reviewed by Dan Bernstein.
1382
1383         * MiniBrowser/Configurations/Base.xcconfig:
1384         * MobileMiniBrowser/Configurations/Base.xcconfig:
1385         * TestWebKitAPI/Configurations/Base.xcconfig:
1386         * WebKitTestRunner/Configurations/Base.xcconfig:
1387
1388 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1389
1390         WebDriver: driver environment not passed to pytest when running w3c tests
1391         https://bugs.webkit.org/show_bug.cgi?id=181852
1392
1393         Reviewed by Carlos Alberto Lopez Perez.
1394
1395         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
1396
1397         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1398         (WebDriverW3CExecutor.run):
1399
1400 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1401
1402         [GTK] WebDriver: wayland display no used in wayland bot
1403         https://bugs.webkit.org/show_bug.cgi?id=181851
1404
1405         Reviewed by Carlos Alberto Lopez Perez.
1406
1407         We need to handle the additionalArguments property in the WebDriverTests step.
1408
1409         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1410         (RunWebDriverTests.start):
1411
1412 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1413
1414         [GTK] TERM environment variable is not passed to the test driver.
1415         https://bugs.webkit.org/show_bug.cgi?id=181847
1416
1417         Rubber-stamped by by Carlos Garcia Campos.
1418
1419         * Scripts/webkitpy/port/base.py:
1420         (Port.to.setup_environ_for_server):
1421
1422 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1423
1424         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
1425         https://bugs.webkit.org/show_bug.cgi?id=181844
1426
1427         Reviewed by Carlos Alberto Lopez Perez.
1428
1429         We always try to create the directory where to store the json file, but when the filename is given directly,
1430         like in the bots, the current dir is used.
1431
1432         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1433         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
1434         empty string.
1435
1436 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1437
1438         [GTK] WebDriver tests are running outside the jhbuild env
1439         https://bugs.webkit.org/show_bug.cgi?id=181842
1440
1441         Reviewed by Žan Doberšek.
1442
1443         We need to enter jhbuild env in run-webdriver-tests.
1444
1445         * Scripts/run-webdriver-tests:
1446
1447 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1448
1449         [GTK] Run WebDriver tests in the bots
1450         https://bugs.webkit.org/show_bug.cgi?id=181787
1451
1452         Reviewed by Michael Catanzaro.
1453
1454         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
1455         factory for the GTK port for now.
1456
1457         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1458         (TestFactory.__init__):
1459         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1460         (RunWebDriverTests):
1461         (RunWebDriverTests.start):
1462         (RunWebDriverTests.commandComplete):
1463         (RunWebDriverTests.evaluateCommand):
1464         (RunWebDriverTests.getText):
1465         (RunWebDriverTests.getText2):
1466
1467 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1468
1469         [WinCairo] Pass correct url for http test to test driver.
1470         https://bugs.webkit.org/show_bug.cgi?id=181814
1471
1472         Reviewed by Alex Christensen.
1473
1474         * Scripts/webkitpy/port/driver.py:
1475         (Driver):
1476         (Driver.http_test_path_to_uri):
1477         (Driver.is_secure_path):
1478         (Driver.http_base_url):
1479         (Driver.uri_to_test):
1480
1481 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1482
1483         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
1484
1485         * BuildSlaveSupport/build.webkit.org-config/config.json:
1486
1487 2018-01-18  Dan Bernstein  <mitz@apple.com>
1488
1489         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1490         https://bugs.webkit.org/show_bug.cgi?id=181803
1491
1492         Reviewed by Tim Horton.
1493
1494         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
1495         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
1496         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
1497         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
1498         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
1499         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
1500         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1501         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
1502         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
1503           helpers.
1504         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
1505           settings useful for defining settings that depend on the target macOS version.
1506         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
1507         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
1508
1509 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
1510
1511         Remove Opensource El Capitan queues from buildbot
1512         https://bugs.webkit.org/show_bug.cgi?id=181712
1513
1514         Reviewed by Aakash Jain.
1515
1516         * BuildSlaveSupport/build.webkit.org-config/config.json:
1517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1518         (WebKitBuildbot):
1519         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1520
1521 2018-01-18  Chris Dumez  <cdumez@apple.com>
1522
1523         Service Workers restored from persistent storage have 'redundant' state
1524         https://bugs.webkit.org/show_bug.cgi?id=181749
1525         <rdar://problem/36556486>
1526
1527         Reviewed by Youenn Fablet.
1528
1529         Add API test coverage.
1530
1531         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1532         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
1533
1534 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1535
1536         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
1537         https://bugs.webkit.org/show_bug.cgi?id=176796
1538
1539         Reviewed by Chris Fleizach.
1540
1541         Add sanity check that we have a URL before calling g_strstr_len().
1542
1543         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1544         (WTR::AccessibilityUIElement::url):
1545
1546 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1547
1548         Add triggers for Sierra test262 and perf queues
1549         https://bugs.webkit.org/show_bug.cgi?id=181799
1550
1551         Reviewed by Aakash Jain.
1552
1553         * BuildSlaveSupport/build.webkit.org-config/config.json:
1554
1555 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1556
1557         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
1558         https://bugs.webkit.org/show_bug.cgi?id=181783
1559         <rdar://problem/35785445>
1560
1561         Reviewed by Ryosuke Niwa.
1562
1563         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
1564         copying an image contains a relevant title.
1565
1566         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1567         (TestWebKitAPI::TEST):
1568         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1569         * TestWebKitAPI/ios/UIKitSPI.h:
1570
1571 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1572
1573         WebDriver: ignore the driver in selenium test names when getting expectations
1574         https://bugs.webkit.org/show_bug.cgi?id=181738
1575
1576         Reviewed by Carlos Alberto Lopez Perez.
1577
1578         In selenium tests, the driver is added as a parameter to every test which results in tests names like
1579         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
1580         driver name in the test expectations file, so we need to remove it when querying the expectations.
1581
1582         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1583         (TestExpectationsMarker.__init__): Save the param to ignore.
1584         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
1585         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
1586         (run): Pass param to ignore to TestExpectationsMarker().
1587         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1588         (WebDriverSeleniumExecutor.__init__): Save the driver name.
1589         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
1590
1591 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1592
1593         [GTK][WPE] Show unit tests unexpectedly passing in the bots
1594         https://bugs.webkit.org/show_bug.cgi?id=181726
1595
1596         Reviewed by Michael Catanzaro.
1597
1598         Now that we have the info, let's show it also in the bots.
1599
1600         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1601         (RunGLibAPITests.commandComplete):
1602
1603 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
1604
1605         Fix broken unittest after r227048
1606         https://bugs.webkit.org/show_bug.cgi?id=181760
1607
1608         Reviewed by Aakash Jain.
1609
1610
1611 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1612
1613         WEBKIT_FRAMEWORK should not modify file-global include directories
1614         https://bugs.webkit.org/show_bug.cgi?id=181656
1615
1616         Reviewed by Konstantin Tokarev.
1617
1618         * TestWebKitAPI/PlatformWPE.cmake:
1619         * TestWebKitAPI/glib/CMakeLists.txt:
1620
1621 2018-01-17  Alicia Boya García  <aboya@igalia.com>
1622
1623         Unreviewed, mark Alicia as committer in contributors.json
1624
1625         * Scripts/webkitpy/common/config/contributors.json:
1626
1627 2018-01-17  Youenn Fablet  <youenn@apple.com>
1628
1629         Put fetch Request.keepalive behind a runtime flag
1630         https://bugs.webkit.org/show_bug.cgi?id=181592
1631
1632         Reviewed by Chris Dumez.
1633
1634         * DumpRenderTree/mac/DumpRenderTree.mm:
1635         (enableExperimentalFeatures):
1636         * DumpRenderTree/win/DumpRenderTree.cpp:
1637         (enableExperimentalFeatures):
1638         * WebKitTestRunner/TestController.cpp:
1639         (WTR::TestController::resetPreferencesToConsistentValues):
1640
1641 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1642
1643         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1644         https://bugs.webkit.org/show_bug.cgi?id=181637
1645         <rdar://problem/36508471>
1646
1647         Reviewed by Tim Horton.
1648
1649         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
1650         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
1651
1652         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1653         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1654         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
1655
1656         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
1657         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
1658
1659         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1660         (webViewForTestingAttachments):
1661         (-[TestWKWebView tagsInBody]):
1662         (-[TestWKWebView expectElementTagsInOrder:]):
1663         (-[TestWKWebView expectElementTag:toComeBefore:]):
1664
1665         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
1666         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
1667
1668         (TestWebKitAPI::TEST):
1669         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1670         (WTR::InjectedBundlePage::InjectedBundlePage):
1671
1672 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1673
1674         WebDriver: add support for test expectations
1675         https://bugs.webkit.org/show_bug.cgi?id=180420
1676
1677         Reviewed by Carlos Alberto Lopez Perez.
1678
1679         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
1680
1681         * Scripts/run-webdriver-tests: Get the retval from process_results().
1682         * Scripts/webkitpy/thirdparty/__init__.py:
1683         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
1684         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1685         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
1686         (TestExpectationsMarker.__init__): Initialize expectations.
1687         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
1688         (run): Create and use TestExpectationsMarker plugin.
1689         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1690         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
1691         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1692         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
1693         (WebDriverTestRunner.run): Do not count results here.
1694         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
1695         amount of failures. Printing the test summary while processing results will be made optional in a follow up
1696         patch.
1697         (WebDriverTestRunner.process_results.report): Return the amount of failures.
1698         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1699         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
1700         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
1701         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
1702         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1703         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
1704         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
1705         (WebDriverTestRunnerW3C._scan_directory): Ditto.
1706         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
1707         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1708         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
1709
1710 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1711
1712         Unreviewed WPE gardening. Mark some known unit test failures.
1713
1714         * TestWebKitAPI/glib/TestExpectations.json:
1715
1716 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1717
1718         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
1719         https://bugs.webkit.org/show_bug.cgi?id=181724
1720
1721         Reviewed by Philippe Normand.
1722
1723         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
1724         reason to use different names. This way we can refer to the same test names for both and we can share the
1725         expectations in the TestExpectations.json file.
1726
1727         * TestWebKitAPI/glib/TestExpectations.json:
1728         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
1729
1730 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1731
1732         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
1733
1734         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
1735         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
1736
1737         * glib/api_test_runner.py:
1738         (TestRunner._run_test_glib):
1739         (TestRunner._run_google_test):
1740
1741 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1742
1743         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
1744         https://bugs.webkit.org/show_bug.cgi?id=179914
1745
1746         Reviewed by Žan Doberšek.
1747
1748         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
1749         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
1750         all symbols listed in the script are present in the library.
1751
1752         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
1753         (bss_symbols):
1754         * Scripts/check-for-invalid-symbols-in-version-script: Added.
1755         (script_symbols):
1756         * Scripts/make-dist:
1757         (Distcheck.build):
1758         (Distcheck):
1759         (Distcheck.check_symbols):
1760         (Distcheck.check):
1761
1762 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1763
1764         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
1765         https://bugs.webkit.org/show_bug.cgi?id=181722
1766
1767         Reviewed by Žan Doberšek.
1768
1769         I forgot to pass the parameters to run() when restarting.
1770
1771         * glib/glib_test_runner.py:
1772         (GLibTestRunner.run):
1773
1774 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1775
1776         [CMake] Remove WebCoreDerivedSources library target
1777         https://bugs.webkit.org/show_bug.cgi?id=181664
1778
1779         Reviewed by Carlos Garcia Campos.
1780
1781         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
1782         * TestWebKitAPI/PlatformWin.cmake: Ditto.
1783
1784 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
1785
1786         Move Debug Test262, Release Test262 and Performance queues to Sierra
1787         https://bugs.webkit.org/show_bug.cgi?id=181692
1788
1789         Unreviewed
1790
1791 2018-01-16  Zach Li  <zachli@apple.com>
1792
1793         Add pop-up policy support in website policies.
1794         https://bugs.webkit.org/show_bug.cgi?id=181544.
1795         rdar://problem/30521400.
1796
1797         Reviewed by Alex Christensen.
1798
1799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1800         Added pop-up-check.html.
1801
1802         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
1803
1804         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1805         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1806         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1807         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1808         (TEST):
1809
1810 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1811
1812         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
1813         https://bugs.webkit.org/show_bug.cgi?id=181638
1814         <rdar://problem/36508702>
1815
1816         Reviewed by Dan Bernstein.
1817
1818         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
1819         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
1820
1821         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1822         (-[AttachmentUpdateObserver init]):
1823         (-[AttachmentUpdateObserver sourceForIdentifier:]):
1824         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
1825         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
1826         (TestWebKitAPI::TEST):
1827         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
1828
1829 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1830
1831         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
1832
1833         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
1834
1835         * glib/api_test_runner.py:
1836         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
1837         * glib/glib_test_runner.py:
1838         (GLibTestRunner.run): Use given env.
1839
1840 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1841
1842         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
1843         https://bugs.webkit.org/show_bug.cgi?id=181676
1844
1845         Reviewed by Carlos Alberto Lopez Perez.
1846
1847         The option was removed in r226967.
1848
1849         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1850         (RunGtkAPITests):
1851         (RunWPEAPITests):
1852
1853 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1854
1855         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
1856
1857         The bots are still passing that option and the step is failing because it was removed in r226967.
1858
1859         * glib/api_test_runner.py:
1860         (add_options):
1861
1862 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1863
1864         [GTK][WPE] Improve the way glib tests are run
1865         https://bugs.webkit.org/show_bug.cgi?id=181674
1866
1867         Reviewed by Žan Doberšek.
1868
1869         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
1870         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
1871         tests failing due to an expected assert in the test and unexpected crashes.
1872         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
1873         not showing the subtest name in stdout in case of timeouts.
1874         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
1875         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
1876         of every test case.
1877
1878         * glib/api_test_runner.py:
1879         (TestRunner._run_test_glib): Use GLibTestRunner.
1880         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
1881         (add_options):
1882         * glib/glib_test_runner.py: Added.
1883         (TestTimeout):
1884         (Message):
1885         (Message.__init__):
1886         (Message.create):
1887         (Message.create.read_unsigned):
1888         (Message.create.read_double):
1889         (Message.create.read_string):
1890         (GLibTestRunner):
1891         (GLibTestRunner.__init__):
1892         (GLibTestRunner._process_data):
1893         (GLibTestRunner._process_message):
1894         (GLibTestRunner._read_from_pipe):
1895         (GLibTestRunner._read_from_stderr):
1896         (GLibTestRunner._start_timeout):
1897         (GLibTestRunner._start_timeout._alarm_handler):
1898         (GLibTestRunner._stop_timeout):
1899         (GLibTestRunner._subtest_start):
1900         (GLibTestRunner._subtest_message):
1901         (GLibTestRunner._subtest_stderr):
1902         (GLibTestRunner._subtest_end):
1903         (GLibTestRunner.run):
1904
1905 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1906
1907         Unreviewed, add Thibault to contributors.json
1908
1909         It's a bit weird to add someone here before their first contribution, but this affects
1910         Bugzilla autocomplete, and that is serious business.
1911
1912         * Scripts/webkitpy/common/config/contributors.json:
1913
1914 2018-01-15  JF Bastien  <jfbastien@apple.com>
1915
1916         Remove makePoisonedUnique
1917         https://bugs.webkit.org/show_bug.cgi?id=181630
1918         <rdar://problem/36498623>
1919
1920         Reviewed by Mark Lam.
1921
1922         Update tests.
1923
1924         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1925         (TestWebKitAPI::TEST):
1926         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1927         (TestWebKitAPI::TEST):
1928
1929 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
1930
1931         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
1932         https://bugs.webkit.org/show_bug.cgi?id=181476
1933
1934         Reviewed by Michael Catanzaro.
1935
1936         Update to xorg-server 1.19.6 which depends on libxfont2, and change
1937         the lists of packages to install libxfont2-devel (or equivalent).
1938
1939         * gtk/install-dependencies:
1940         * gtk/jhbuild.modules:
1941
1942 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1943
1944         [GTK][WPE] Add support for unit test expectations
1945         https://bugs.webkit.org/show_bug.cgi?id=181589
1946
1947         Reviewed by Michael Catanzaro.
1948
1949         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
1950         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
1951         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
1952         script itself is not a good idea either.
1953
1954         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
1955         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
1956         convenient methods to query them.
1957
1958         * Scripts/run-gtk-tests:
1959         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
1960         * Scripts/run-wpe-tests:
1961         (WPETestRunner): Ditto.
1962         * Scripts/webkitpy/common/test_expectations.py: Added.
1963         (TestExpectations):
1964         (TestExpectations.__init__):
1965         (TestExpectations._port_name_for_expected):
1966         (TestExpectations._expected_value):
1967         (TestExpectations.skipped_tests):
1968         (TestExpectations.skipped_subtests):
1969         (TestExpectations._expectation_value):
1970         (TestExpectations.is_slow):
1971         (TestExpectations.get_expectation):
1972         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
1973         (MockTestExpectations):
1974         (MockTestExpectations.__init__):
1975         (MockTestExpectations.is_skip):
1976         (ExpectationsTest):
1977         (assert_exp):
1978         (assert_not_exp):
1979         (assert_bad_exp):
1980         (assert_skip):
1981         (test_basic):
1982         (test_skip):
1983         (test_flaky):
1984         (test_build_type):
1985         * TestWebKitAPI/glib/TestExpectations.json: Added.
1986         * glib/api_test_runner.py:
1987         (TestRunner): Remove SkippedTest implementation.
1988         (TestRunner.__init__): Create a TestExpectations.
1989         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
1990         (TestRunner._should_run_test_program): Ditto.
1991         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
1992         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
1993         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
1994         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
1995         (TestRunner.run_tests.report): Helper to write report to stdout.
1996
1997 2018-01-13  Mark Lam  <mark.lam@apple.com>
1998
1999         Replace all use of ConstExprPoisoned with Poisoned.
2000         https://bugs.webkit.org/show_bug.cgi?id=181542
2001         <rdar://problem/36442138>
2002
2003         Reviewed by JF Bastien.
2004
2005         1. Converted tests to using new uintptr_t& poison type.
2006         2. Added tests for Poisoned comparison operators.
2007
2008         * TestWebKitAPI/CMakeLists.txt:
2009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2010         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
2011         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2012         (TestWebKitAPI::TEST):
2013         (TestWebKitAPI::initializeTestPoison): Deleted.
2014         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2015         (TestWebKitAPI::TEST):
2016         (TestWebKitAPI::passWithRef):
2017         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2018         (TestWebKitAPI::TEST):
2019         (TestWebKitAPI::f1):
2020         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2021         (TestWebKitAPI::TEST):
2022         (TestWebKitAPI::poisonedPtrFoo):
2023         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2024         (TestWebKitAPI::TEST):
2025         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2026         (TestWebKitAPI::TEST):
2027
2028 2018-01-13  David Kilzer  <ddkilzer@apple.com>
2029
2030         check-webkit-style: false positive for [whitespace/braces] with os_log format string
2031         <https://webkit.org/b/181606>
2032
2033         Reviewed by Darin Adler.
2034
2035         * Scripts/webkitpy/style/checkers/cpp.py:
2036         (check_spacing): Modify regular expression to ignore
2037         os_log format strings like '%{public}'.
2038         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2039         (CppStyleTest.test_spacing_before_braces): Add os_log
2040         format string test.
2041
2042 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2043
2044         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
2045         https://bugs.webkit.org/show_bug.cgi?id=181626
2046
2047         Reviewed by Joseph Pecoraro.
2048
2049         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
2050         Additionally, write a new API test covering the change in r226915.
2051
2052         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2053         (webViewForTestingAttachments):
2054         (TestWebKitAPI::TEST):
2055
2056 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2057
2058         History state should be updated during client redirects with asynchronous policy decisions
2059         https://bugs.webkit.org/show_bug.cgi?id=181358
2060         <rdar://problem/35547689>
2061
2062         Reviewed by Andy Estes.
2063
2064         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2065         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
2066         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2067         (TEST):
2068
2069 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
2070
2071         webkitpy: Refactor simulator code (Part 4)
2072         https://bugs.webkit.org/show_bug.cgi?id=180555
2073         <rdar://problem/36131381>
2074
2075         Reviewed by Aakash Jain.
2076
2077         Move new_simulated_device.py to simulated_device.py.
2078
2079         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
2080         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
2081         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
2082         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
2083         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
2084
2085 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2086
2087         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
2088         https://bugs.webkit.org/show_bug.cgi?id=181595
2089
2090         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
2091         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
2092         I change the < and > to $ to make this test pass and continue to test what it used to.
2093
2094         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
2095         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2096         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2097
2098 2018-01-11  Keith Miller  <keith_miller@apple.com>
2099
2100         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
2101         https://bugs.webkit.org/show_bug.cgi?id=181573
2102
2103         Reviewed by Simon Fraser.
2104
2105         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2106
2107 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
2108
2109         [WebAuthN] Import a CBOR coder from Chromium
2110         https://bugs.webkit.org/show_bug.cgi?id=181522
2111         <rdar://problem/36055729>
2112
2113         Reviewed by Brent Fulgham.
2114
2115         This patch also imports all unit tests into our API tests to ensure all
2116         workarounds and modification against the original codebase doesn't change
2117         any original functionalities.
2118
2119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2120         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
2121         (TestWebKitAPI::TEST):
2122         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
2123         (TestWebKitAPI::TEST):
2124         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
2125         (TestWebKitAPI::eq):
2126         Workarounds applied.
2127         (TestWebKitAPI::TEST):
2128
2129 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2130
2131         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
2132         https://bugs.webkit.org/show_bug.cgi?id=181538
2133         <rdar://problem/36440580>
2134
2135         Reviewed by Aakash Jain.
2136
2137         When disambiguating a device type, it is possible that the provided device type is sufficiently
2138         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
2139         will result in a failure to disambiguate the type.
2140
2141         * Scripts/webkitpy/xcode/new_simulated_device.py:
2142         (SimulatedDeviceManager._disambiguate_device_type):
2143
2144 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
2145
2146         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
2147         https://bugs.webkit.org/show_bug.cgi?id=181136
2148         <rdar://problem/36116604>
2149
2150         Reviewed by Chris Dumez.
2151
2152         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
2153         browsing sessions.
2154
2155         * Scripts/run-gtk-tests:
2156         (GtkTestRunner): Unskip test now that it passes.
2157         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2158         (TEST): Add new WebsiteDataStoreEphemeral test.
2159
2160 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2161
2162         Unreviewed, rolling out r226816.
2163
2164         This change broke LayoutTests on the bots.
2165
2166         Reverted changeset:
2167
2168         "run-webkit-tests fails when there is a curly brace in Xcode
2169         build output"
2170         https://bugs.webkit.org/show_bug.cgi?id=181254
2171         https://trac.webkit.org/changeset/226816
2172
2173 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2174
2175         webkitpy: Fix flakey webserver tests
2176         https://bugs.webkit.org/show_bug.cgi?id=181555
2177         <rdar://problem/36448273>
2178
2179         Reviewed by Aakash Jain.
2180
2181         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2182         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
2183         determine if a specific server is running.
2184
2185 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2186
2187         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
2188         https://bugs.webkit.org/show_bug.cgi?id=181561
2189         <rdar://problem/36452652>
2190
2191         Reviewed by Aakash Jain.
2192
2193         BeautifulSoup.find may return None, this case should be gracefully handled.
2194
2195         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2196         (BugzillaQueries._parse_result_count):
2197         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
2198
2199 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
2200
2201         run-webkit-tests fails when there is a curly brace in Xcode build output
2202         https://bugs.webkit.org/show_bug.cgi?id=181254
2203
2204         Reviewed by Daniel Bates.
2205
2206         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2207         (MeteredStream.write):
2208
2209 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2210
2211         webkitpy: Reimplement simulator code (Part 3)
2212         https://bugs.webkit.org/show_bug.cgi?id=180555
2213         <rdar://problem/36131381>
2214
2215         Reviewed by Aakash Jain.
2216
2217         Remove old simulator code.
2218
2219         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
2220         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
2221         * Scripts/webkitpy/xcode/simulator.py: Removed.
2222         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
2223
2224 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2225
2226         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
2227         https://bugs.webkit.org/show_bug.cgi?id=181337
2228         <rdar://problem/36324813>
2229
2230         Reviewed by Tim Horton.
2231
2232         Add 3 new API tests for attachment element dragging.
2233
2234         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2235         (-[TestWKWebView expectElementTag:toComeBefore:]):
2236         (-[NSItemProvider expectType:withData:]):
2237         (TestWebKitAPI::TEST):
2238
2239 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2240
2241         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
2242         https://bugs.webkit.org/show_bug.cgi?id=179621
2243         <rdar://problem/35589585>
2244
2245         Unreviewed infrastructure fix.
2246
2247         * Scripts/webkitpy/port/mac.py:
2248         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
2249         list if we are the VERSION_MAX, which usually corresponds with future.
2250
2251 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
2252
2253         CodeBlocks should be in IsoSubspaces
2254         https://bugs.webkit.org/show_bug.cgi?id=180884
2255
2256         Reviewed by Saam Barati.
2257         
2258         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
2259         shouldn't take a long time due to benchmarks we don't optimize for.
2260         
2261         * Scripts/run-jsc-benchmarks:
2262
2263 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
2264
2265         Test gardening for GTK.
2266         https://bugs.webkit.org/show_bug.cgi?id=181477
2267
2268         Unreviewed test gardening.
2269
2270         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
2271         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
2272
2273 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2274
2275         Add the new JSCOnly bot to the scheduler.
2276         https://bugs.webkit.org/show_bug.cgi?id=181487
2277
2278         Unreviewed follow-up patch after r226729
2279
2280         On r226729 I missed to add the new JSCOnly bot the default scheduler.
2281         This is needed to make the bot automatically pick each commit for testing.
2282
2283         * BuildSlaveSupport/build.webkit.org-config/config.json:
2284
2285 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2286
2287         [Attachment Support] Support dragging attachment elements out as files on iOS
2288         https://bugs.webkit.org/show_bug.cgi?id=181199
2289         <rdar://problem/36299316>
2290
2291         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
2292
2293         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
2294         attachment API tests.
2295
2296         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2297         (-[NSItemProvider expectType:withData:]):
2298         (TestWebKitAPI::TEST):
2299
2300         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
2301         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
2302         -expectType:withData: helper to inspect the item providers created from the drag source.
2303
2304         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2305         (TestWebKitAPI::TEST):
2306         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2307         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2308         (-[MockDragSession localContext]):
2309         (-[MockDragSession setLocalContext:]):
2310         (-[DataInteractionSimulator _resetSimulatedState]):
2311         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
2312         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2313         (-[DataInteractionSimulator _advanceProgress]):
2314         (-[DataInteractionSimulator endDataTransfer]):
2315
2316         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
2317         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
2318         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
2319         MockDragSession to hold on to a localContext.
2320
2321 2018-01-11  Ali Juma  <ajuma@chromium.org>
2322
2323         Unreviewed. Add Ali Juma as contributor
2324
2325         * Scripts/webkitpy/common/config/contributors.json:
2326
2327 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2328
2329         Unreviewed. Update Selenium WebDriver imported tests.
2330
2331         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
2332         environment variables.
2333
2334         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2335         (collect): Reorder the arguments to make pytest happy.
2336         (run): Ditto.
2337         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2338         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
2339
2340 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
2341
2342         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
2343         https://bugs.webkit.org/show_bug.cgi?id=181492
2344         <rdar://problem/36359679>
2345
2346         Reviewed by Alexey Proskuryakov. 
2347
2348 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
2349
2350         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
2351         https://bugs.webkit.org/show_bug.cgi?id=181475
2352
2353         Reviewed by Michael Catanzaro.
2354
2355         * gtk/install-dependencies: Update package list for Arch Linux, extend
2356         message shown at end of installation with additional tips.
2357
2358 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2359
2360         REGRESSION(r222507): Composition highlight doesn't render when using IME
2361         https://bugs.webkit.org/show_bug.cgi?id=181485
2362         <rdar://problem/35896516>
2363
2364         Reviewed by Ryosuke Niwa.
2365
2366         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
2367         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
2368         allow rendering composition backgrounds (see InlineTextBox::paint).
2369
2370         * DumpRenderTree/ios/TextInputControllerIOS.m:
2371         (+[TextInputController isSelectorExcludedFromWebScript:]):
2372         (+[TextInputController webScriptNameForSelector:]):
2373         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
2374         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
2375         * DumpRenderTree/mac/TextInputControllerMac.m:
2376         (+[TextInputController isSelectorExcludedFromWebScript:]):
2377         (+[TextInputController webScriptNameForSelector:]):
2378         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
2379         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
2380         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
2381         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
2382         (WTR::TextInputController::setMarkedText):
2383         * WebKitTestRunner/InjectedBundle/TextInputController.h:
2384
2385 2018-01-10  JF Bastien  <jfbastien@apple.com>
2386
2387         Poison small JSObject derivatives which only contain pointers
2388         https://bugs.webkit.org/show_bug.cgi?id=181483
2389         <rdar://problem/36407127>
2390
2391         Reviewed by Mark Lam.
2392
2393         Test the new move-assign and move-copy from unique_ptr, as well as
2394         nullptr_t ctors.
2395
2396         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2397         (TestWebKitAPI::TEST):
2398         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2399         (TestWebKitAPI::TEST):
2400         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2401         (TestWebKitAPI::TEST):
2402
2403 2018-01-10  Chris Dumez  <cdumez@apple.com>
2404
2405         Multiple http/wpt/beacon/contentextensions/ test are flaky.
2406         https://bugs.webkit.org/show_bug.cgi?id=179256
2407         <rdar://problem/35401978>
2408
2409         Reviewed by Alex Christensen.
2410
2411         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
2412         instance gets its own folder to avoid conflicts and flakiness.
2413
2414         * WebKitTestRunner/mac/TestControllerMac.mm:
2415         (WTR::TestController::platformConfigureViewForTest):
2416
2417 2018-01-10  Tim Horton  <timothy_horton@apple.com>
2418
2419         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
2420         https://bugs.webkit.org/show_bug.cgi?id=181269
2421         <rdar://problem/35110344>
2422
2423         Reviewed by Simon Fraser.
2424
2425         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2426         (WTR::UIScriptController::beginBackSwipe):
2427         (WTR::UIScriptController::completeBackSwipe):
2428         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2429         (WTR::UIScriptController::beginBackSwipe):
2430         (WTR::UIScriptController::completeBackSwipe):
2431         (WTR::UIScriptController::overridePreference):
2432         (WTR::UIScriptController::replaceTextAtRange):
2433         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2434         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2435         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2436         (WTR::UIScriptController::beginBackSwipe):
2437         (WTR::UIScriptController::completeBackSwipe):
2438         Implement beginBackSwipe and completeBackSwipe on iOS (they already
2439         exist on Mac) in terms of the new WKWebView testing SPI.
2440
2441 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2442
2443         REGRESSION (r226715): ignore WARNING output in linter tests
2444         https://bugs.webkit.org/show_bug.cgi?id=181486
2445         <rdar://problem/36408847>
2446
2447         Reviewed by Aakash Jain.
2448
2449         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
2450
2451         * Scripts/webkitpy/common/system/outputcapture.py:
2452         (OutputCapture.__init__): Pass logging level to be captured.
2453         * Scripts/webkitpy/style/main_unittest.py:
2454         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
2455         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
2456         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
2457         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
2458         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
2459         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
2460         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
2461         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
2462
2463 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2464
2465         Add a JSCOnly MIPS buildbot
2466         https://bugs.webkit.org/show_bug.cgi?id=181487
2467
2468         Reviewed by Michael Catanzaro.
2469
2470         Add the new bot configs definitions for the master and update the unit tests.
2471
2472         * BuildSlaveSupport/build.webkit.org-config/config.json:
2473         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2474
2475 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2476
2477         REGRESSION (r226715): don't re-check number of simulators in child processes
2478         https://bugs.webkit.org/show_bug.cgi?id=181484
2479         <rdar://problem/36407151>
2480
2481         Reviewed by Aakash Jain.
2482
2483         * Scripts/webkitpy/port/ios_simulator.py:
2484         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
2485         are already initialized.
2486
2487 2018-01-10  Commit Queue  <commit-queue@webkit.org>
2488
2489         Unreviewed, rolling out r226667 and r226673.
2490         https://bugs.webkit.org/show_bug.cgi?id=181488
2491
2492         This caused a flaky crash. (Requested by mlewis13 on #webkit).
2493
2494         Reverted changesets:
2495
2496         "CodeBlocks should be in IsoSubspaces"
2497         https://bugs.webkit.org/show_bug.cgi?id=180884
2498         https://trac.webkit.org/changeset/226667
2499
2500         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
2501         https://bugs.webkit.org/show_bug.cgi?id=180884
2502         https://trac.webkit.org/changeset/226673
2503
2504 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2505
2506         Follow-up fix to r226715
2507         https://bugs.webkit.org/show_bug.cgi?id=180555
2508         <rdar://problem/36131381>
2509
2510         Unreviewed infrastructure fix.
2511
2512         * Scripts/webkitpy/xcode/new_simulated_device.py:
2513         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
2514         of delete.
2515
2516 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
2517
2518         webkitpy: Refactor simulator code (Part 2)
2519         https://bugs.webkit.org/show_bug.cgi?id=180555
2520         <rdar://problem/36131381>
2521
2522         Reviewed by Aakash Jain.
2523
2524         The patch leverages the SimulatedDeviceManager when running layout tests.
2525         This patch is primarily code removal, since much of the IOSSimulatorPort
2526         was dedicated to managing simulators. The removed code is either now owned by the
2527         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
2528         boot multiple simulators which was made obsolete in Xcode 9.
2529
2530         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2531         (Manager._custom_device_for_test.in): Device names now have spaces in them,
2532         strip those spaces.
2533         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2534         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
2535         * Scripts/webkitpy/port/ios.py:
2536         (IOSPort.__init__): The _current_device idiom is no longer required since the
2537         SimulatedDeviceManager keeps track of any previously booted devices.
2538         (IOSPort.target_host): Even when only a single device is used, it will be accessed
2539         through the array of managed devices.
2540         (IOSPort.using_multiple_devices): Deleted.
2541         * Scripts/webkitpy/port/ios_device.py:
2542         (IOSDevicePort.using_multiple_devices): Deleted.
2543         * Scripts/webkitpy/port/ios_simulator.py:
2544         (IOSSimulatorPort): Remove constants required to manage simulators, change device
2545         class strings so they can be parsed by the DeviceType class.
2546         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
2547         the number of simulators currently booted, the number of child processes specified
2548         and the maximum number of simulators supported by this system.
2549         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
2550         devices owned by the SimulatedDeviceManager.
2551         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
2552         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
2553         the maximum number of supported simulators on this system.
2554         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
2555         request for each child process and send this list to the SimulatedDeviceManager to
2556         initialize the devices.
2557         (IOSSimulatorPort.clean_up_test_run):
2558         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
2559         specified version of iOS.
2560         (IOSSimulatorPort.reset_preferences):
2561         (IOSSimulatorPort.simulator_runtime): Deleted.
2562         (IOSSimulatorPort.simulator_device_type): Deleted.
2563         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
2564         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
2565         (IOSSimulatorPort._create_simulators): Deleted.
2566         (IOSSimulatorPort._quit_ios_simulator): Deleted.
2567         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
2568         (IOSSimulatorPort.using_multiple_devices): Deleted.
2569         (IOSSimulatorPort._create_device): Deleted.
2570         (IOSSimulatorPort.get_simulator_path): Deleted.
2571         (IOSSimulatorPort._createSimulatorApps): Deleted.
2572         (IOSSimulatorPort._createSimulatorApp): Deleted.
2573         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2574         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
2575         maximum number of simulators run on this system.
2576         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
2577         * Scripts/webkitpy/xcode/new_simulated_device.py:
2578         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
2579
2580 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2581
2582         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
2583         https://bugs.webkit.org/show_bug.cgi?id=181474
2584
2585         Reviewed by Carlos Alberto Lopez Perez.
2586
2587         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
2588         name as the name.
2589
2590         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2591         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
2592         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
2593
2594 2018-01-09  Andy Estes  <aestes@apple.com>
2595
2596         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
2597         https://bugs.webkit.org/show_bug.cgi?id=181459
2598
2599         Reviewed by Dan Bernstein.
2600
2601         * ImageDiff/cg/Configurations/Base.xcconfig:
2602
2603 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
2604
2605         font-display:fallback can cause a visual flash (which is supposed to be impossible)
2606         https://bugs.webkit.org/show_bug.cgi?id=181374
2607
2608         Reviewed by Simon Fraser.
2609
2610         The test requires Palatino.
2611
2612         * DumpRenderTree/mac/DumpRenderTree.mm:
2613         (allowedFontFamilySet):
2614         * WebKitTestRunner/mac/TestControllerMac.mm:
2615         (WTR::allowedFontFamilySet):
2616
2617 2018-01-09  Saam Barati  <sbarati@apple.com>
2618
2619         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
2620         https://bugs.webkit.org/show_bug.cgi?id=181449
2621
2622         Reviewed by JF Bastien.
2623
2624         This allows me to Cmd+f in my terminal to search for things without
2625         having the results become misaligned.
2626
2627         * Scripts/display-profiler-output:
2628
2629 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2630
2631         [webkitpy] PlatformInfo should have default argument for casual use
2632         https://bugs.webkit.org/show_bug.cgi?id=180827
2633
2634         Reviewed by David Kilzer.
2635
2636         PlatformInfo should be the only way to check platform specific thing instead
2637         of sys.platform or other various checks. If there is something you want to check,
2638         it should be placed in PlatformInfo.
2639
2640         Currently to instantiate PlatformInfo, it requires arguments, which is usually
2641         sys, platform and Executive(). They are straight forward and should be handled
2642         by default arguments. Then we can instantiate PlatformInfo more casual.
2643
2644         * Scripts/webkitpy/common/system/platforminfo.py:
2645         (PlatformInfo): Use relative module path import
2646         (PlatformInfo.__init__):
2647         (PlatformInfo.executive): Lazy instantiation of Executive()
2648         (PlatformInfo.total_bytes_memory): Accessing via above property
2649         (PlatformInfo.xcode_sdk_version): Ditto
2650         (PlatformInfo.xcode_simctl_list): Ditto
2651         (PlatformInfo.xcode_version): Ditto
2652         (PlatformInfo._win_version_str): Ditto
2653         * Scripts/webkitpy/common/system/systemhost.py:
2654         (SystemHost.__init__):
2655         * Scripts/webkitpy/common/system/user.py:
2656         (User.__init__):
2657
2658 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2659
2660         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
2661         https://bugs.webkit.org/show_bug.cgi?id=176443
2662
2663         Reviewed by Darin Adler.
2664
2665         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
2666         (TEST):
2667
2668 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
2669
2670         check-webkit-style: Verify syntax for WK_API_AVAILABLE
2671         https://bugs.webkit.org/show_bug.cgi?id=181394
2672
2673         Reviewed by Darin Adler.
2674
2675         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
2676         as the second parameter instead of ios(WK_IOS_TBA). This generally
2677         builds for iOS on EWS but not when using the public SDK. See r224057,
2678         r223207 and r226211 for example. This patch adds a basic style check
2679         for that macro to prevent this kind of mistake.
2680
2681         * Scripts/webkitpy/style/checkers/cpp.py:
2682         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
2683         (check_style): Run new style check.
2684         (CppChecker): Add build type for the new style check.
2685         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2686         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
2687
2688 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2689
2690         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
2691         https://bugs.webkit.org/show_bug.cgi?id=181420
2692         <rdar://problem/36365827>
2693
2694         Reviewed by Alex Christensen.
2695
2696         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
2697         of corresponding _WKAttachments.
2698
2699         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2700         (TestWebKitAPI::TEST):
2701
2702 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2703
2704         Add WKNavigationDelegate SPI exposing WebProcess crash reason
2705         https://bugs.webkit.org/show_bug.cgi?id=181410
2706         <rdar://problem/36167199>
2707
2708         Reviewed by Wenson Hsieh.
2709
2710         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2711         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
2712         (TEST):
2713
2714 2018-01-08  Alex Christensen  <achristensen@webkit.org>
2715
2716         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
2717         https://bugs.webkit.org/show_bug.cgi?id=181408
2718         <rdar://problem/35884960>
2719
2720         Reviewed by Tim Horton.
2721
2722         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
2723         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2724
2725 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2726
2727         [Attachment Support] Expose file name and content type of WKAttachment
2728         https://bugs.webkit.org/show_bug.cgi?id=181390
2729         <rdar://problem/36336837>
2730
2731         Reviewed by Tim Horton.
2732
2733         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
2734
2735         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2736         (-[_WKAttachment synchronouslyRequestInfo:]):
2737         (-[_WKAttachment synchronouslyRequestData:]):
2738
2739         Reimplement this in terms of -synchronouslyRequestInfo:.
2740
2741         (-[_WKAttachment expectRequestedDataToBe:]):
2742         (TestWebKitAPI::TEST):
2743
2744 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2745
2746         Copying, pasting, and then deleting an attachment element breaks attachment data requests
2747         https://bugs.webkit.org/show_bug.cgi?id=181365
2748         <rdar://problem/36340647>
2749
2750         Reviewed by Tim Horton.
2751
2752         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
2753         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
2754         detail.
2755
2756         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2757         (TestWebKitAPI::TEST):
2758
2759 2018-01-08  Youenn Fablet  <youenn@apple.com>
2760
2761         navigator.onLine does not work inside service workers
2762         https://bugs.webkit.org/show_bug.cgi?id=181079
2763         <rdar://problem/36178606>
2764
2765         Reviewed by Darin Adler.
2766
2767         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2768         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
2769
2770 2018-01-07  Saam Barati  <sbarati@apple.com>
2771
2772         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
2773         https://bugs.webkit.org/show_bug.cgi?id=181372
2774
2775         Reviewed by Filip Pizlo.
2776
2777         Adding these sorting modes makes it easier to analyze functions
2778         that recompile a lot and exit a lot.
2779
2780         * Scripts/display-profiler-output:
2781
2782 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
2783
2784         Unreviewed, remove my Cisco email from contributors.json
2785
2786         * Scripts/webkitpy/common/config/contributors.json:
2787
2788 2018-01-05  JF Bastien  <jfbastien@apple.com>
2789
2790         WebAssembly: poison JS object's secrets
2791         https://bugs.webkit.org/show_bug.cgi?id=181339
2792         <rdar://problem/36325001>
2793
2794         Reviewed by Mark Lam.
2795
2796         Update tests for swap(Poisoned<k, T>, T*)
2797
2798         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
2799         (TestWebKitAPI::TEST):
2800         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2801         (TestWebKitAPI::TEST):
2802         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2803         (TestWebKitAPI::TEST):
2804
2805 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2806
2807         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
2808         https://bugs.webkit.org/show_bug.cgi?id=181359
2809
2810         Reviewed by Tim Horton.
2811
2812         Ensure that these tests still pass using older SDKs.
2813
2814         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2815         (TestWebKitAPI::TEST):
2816
2817 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2818
2819         Rebase API test after r226469
2820         https://bugs.webkit.org/show_bug.cgi?id=181308
2821
2822         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
2823         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2824         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
2825
2826 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2827
2828         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
2829         https://bugs.webkit.org/show_bug.cgi?id=181217
2830
2831         Reviewed by Tim Horton.
2832
2833         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2834         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2835         (TEST):
2836
2837 2018-01-05  Alex Christensen  <achristensen@webkit.org>
2838
2839         Add WKBundleFrameCreateFrameHandle
2840         https://bugs.webkit.org/show_bug.cgi?id=181232
2841         <rdar://problem/35926696>
2842
2843         Reviewed by Tim Horton.
2844
2845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2846         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
2847         (mouseDidMoveOverElement):
2848         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
2849         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2850         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
2851         (TEST):
2852
2853 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
2854
2855         iOS: Build fix after r226432.
2856         
2857         Unreviewed. Stop duplicating speakAs symbols for iOS.
2858
2859         * DumpRenderTree/AccessibilityUIElement.cpp:
2860         (AccessibilityUIElement::speakAs):
2861
2862 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
2863
2864         Unreviewed, added myself as WebKit reviewer
2865
2866         * Scripts/webkitpy/common/config/contributors.json:
2867
2868 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
2869
2870         WPE: Build fix after r226432.
2871
2872         Unreviewed. Rename ::speak() to ::speakAs().
2873         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2874         (WTR::AccessibilityUIElement::speakAs):
2875         (WTR::AccessibilityUIElement::speak): Deleted.
2876
2877 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
2878
2879         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
2880         https://bugs.webkit.org/show_bug.cgi?id=180361
2881
2882         Reviewed by Zalan Bujtas.
2883
2884         * DumpRenderTree/AccessibilityUIElement.cpp:
2885         (speakAsCallback):
2886         (AccessibilityUIElement::speakAs):
2887         (AccessibilityUIElement::getJSClass):
2888         (speakCallback): Deleted.
2889         (AccessibilityUIElement::speak): Deleted.
2890         * DumpRenderTree/AccessibilityUIElement.h:
2891         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2892         (AccessibilityUIElement::speakAs):
2893         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2894         (AccessibilityUIElement::speakAs):
2895         (AccessibilityUIElement::speak): Deleted.
2896         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2897         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2898         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2899         (WTR::AccessibilityUIElement::speakAs):
2900         (WTR::AccessibilityUIElement::speak): Deleted.
2901         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2902         (WTR::AccessibilityUIElement::speakAs):
2903         (WTR::AccessibilityUIElement::speak): Deleted.
2904
2905 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
2906
2907         REGRESSION (r226395): test-webkitperl test expectations incorrect
2908         https://bugs.webkit.org/show_bug.cgi?id=181307
2909         <rdar://problem/36306558>
2910
2911         Rubber-stamped by Aakash Jain.
2912
2913         r226395 added two lines towards the beginning of
2914         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
2915         numbers in the test expectations need to update.
2916
2917         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2918
2919 2018-01-04  Tim Horton  <timothy_horton@apple.com>
2920
2921         WKWebView loses minimum layout size overrides that happen while the process is terminated
2922         https://bugs.webkit.org/show_bug.cgi?id=181306
2923         <rdar://problem/34398288>
2924
2925         Reviewed by Dan Bernstein.
2926
2927         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2928         (TEST):
2929         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
2930         while the process is terminated results in the page getting the correct
2931         minimum layout size.
2932
2933 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
2934
2935         [MediaStream] Add Mock screen capture source
2936         https://bugs.webkit.org/show_bug.cgi?id=181291
2937         <rdar://problem/36298164>
2938
2939         Reviewed by Dean Jackson.
2940
2941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
2942         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2943         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
2944
2945 2018-01-04  Lucas Forschler  <lforschler@apple.com>
2946
2947         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
2948
2949         Reviewed by Ling Ho.
2950
2951         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2952
2953 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2954
2955         [Attachment Support] Create attachment elements when dropping files on iOS
2956         https://bugs.webkit.org/show_bug.cgi?id=181192
2957         <rdar://problem/36280945>
2958
2959         Reviewed by Tim Horton.
2960
2961         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
2962         switch is enabled. See below for more details.
2963
2964         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2965         (-[NSItemProvider registerData:type:]):
2966         (platformCopyPNG):
2967         (TestWebKitAPI::TEST):
2968         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2969
2970         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
2971         source item provider when dragging rich text *without* attachments, so this should have been a check for just
2972         kUTTypeRTF instead.
2973
2974         (TestWebKitAPI::TEST):
2975
2976         Tests a few cases of inserting attachment elements via drop:
2977         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
2978             Instead of inserting the contents as inline web content, this should generate attachment elements.
2979         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
2980             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
2981             back to inserting the content as an attachment.
2982         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
2983             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
2984             or at the end).
2985
2986         * TestWebKitAPI/cocoa/TestWKWebView.h:
2987         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2988         (-[TestWKWebView objectByEvaluatingJavaScript:]):
2989
2990         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
2991         -stringByEvaluatingJavaScript to just turn around and call this.
2992
2993         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2994
2995 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
2996
2997         Replace hard-coded paths in shebangs with #!/usr/bin/env
2998         https://bugs.webkit.org/show_bug.cgi?id=181040
2999
3000         Reviewed by Alex Christensen.
3001
3002         * BuildSlaveSupport/build-launcher-app:
3003         * BuildSlaveSupport/build-launcher-dmg:
3004         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3005         * BuildSlaveSupport/built-product-archive:
3006         * BuildSlaveSupport/clean-build:
3007         * BuildSlaveSupport/delete-stale-build-files:
3008         * BuildSlaveSupport/download-built-product:
3009         * BuildSlaveSupport/gtk/buildbot/log/run:
3010         * BuildSlaveSupport/gtk/buildbot/run:
3011         * BuildSlaveSupport/gtk/pulseaudio/run:
3012         * BuildSlaveSupport/kill-old-processes:
3013         * BuildSlaveSupport/test-result-archive:
3014         * BuildSlaveSupport/win/kill-old-processes:
3015         * Scripts/SpacingHeuristics.pm:
3016         * Scripts/add-include:
3017         * Scripts/build-api-tests:
3018         * Scripts/build-dumprendertree:
3019         * Scripts/build-imagediff:
3020         * Scripts/build-jsc:
3021         * Scripts/build-webkit:
3022         * Scripts/build-webkittestrunner:
3023         * Scripts/check-Xcode-source-file-types:
3024         * Scripts/check-dom-results:
3025         * Scripts/check-for-exit-time-destructors:
3026         * Scripts/check-for-global-initializers:
3027         * Scripts/check-for-inappropriate-objc-class-names:
3028         * Scripts/check-for-weak-vtables-and-externals:
3029         * Scripts/clean-header-guards:
3030         * Scripts/compare-timing-files:
3031         * Scripts/configure-xcode-for-ios-development:
3032         * Scripts/copy-webkitlibraries-to-product-directory:
3033         * Scripts/create-exports:
3034         * Scripts/debug-minibrowser:
3035         * Scripts/debug-safari:
3036         * Scripts/debug-test-runner:
3037         * Scripts/do-file-rename:
3038         * Scripts/do-webcore-rename:
3039         * Scripts/dump-webkit-tests-run:
3040         * Scripts/ensure-valid-python:
3041         * Scripts/execAppWithEnv:
3042         * Scripts/extract-localizable-js-strings:
3043         * Scripts/filter-build-webkit:
3044         * Scripts/find-extra-includes:
3045         * Scripts/fix-blink-patch:
3046         * Scripts/generate-coverage-data:
3047         * Scripts/git-add-reviewer:
3048         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3049         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
3050         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
3051         * Scripts/make-new-script-test:
3052         * Scripts/make-script-test-wrappers:
3053         * Scripts/package-root:
3054         * Scripts/parse-malloc-history:
3055         * Scripts/report-include-statistics:
3056         * Scripts/resolve-ChangeLogs:
3057         * Scripts/run-api-tests:
3058         * Scripts/run-bindings-tests:
3059         * Scripts/run-content-extension-tester:
3060         * Scripts/run-iexploder-tests:
3061         * Scripts/run-javascriptcore-tests:
3062         * Scripts/run-jsc:
3063         * Scripts/run-leaks:
3064         * Scripts/run-mangleme-tests:
3065         * Scripts/run-minibrowser:
3066         * Scripts/run-pageloadtest:
3067         * Scripts/run-regexp-tests:
3068         * Scripts/run-safari:
3069         * Scripts/run-sunspider:
3070         * Scripts/run-test-runner:
3071         * Scripts/run-webkit-app:
3072         * Scripts/run-webkit-httpd:
3073         * Scripts/run-webkit-websocketserver:
3074         * Scripts/set-webkit-configuration:
3075         * Scripts/show-pretty-diff:
3076         * Scripts/sort-Xcode-project-file:
3077         * Scripts/split-file-by-class:
3078         * Scripts/sunspider-compare-results:
3079         * Scripts/svn-apply:
3080         * Scripts/svn-unapply:
3081         * Scripts/test-webkit-scripts:
3082         * Scripts/test-webkitperl:
3083         * Scripts/update-iexploder-cssproperties:
3084         * Scripts/update-javascriptcore-test-results:
3085         * Scripts/update-webkit:
3086         * Scripts/update-webkit-auxiliary-libs:
3087         * Scripts/update-webkit-dependency:
3088         * Scripts/update-webkit-libs-jhbuild:
3089         * Scripts/update-webkit-localizable-strings:
3090         * Scripts/update-webkit-support-libs:
3091         * Scripts/update-webkitgtk-libs:
3092         * Scripts/update-webkitwpe-libs:
3093         * Scripts/webkit-build-directory:
3094         * Scripts/webkitperl/LoadAsModule.pm:
3095         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
3096         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3097         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
3098         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
3099         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
3100         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
3101         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3102         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3103         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3104         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3105         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
3106         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
3107         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
3108         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3109         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3110         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3111         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3112         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
3113         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
3114         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
3115         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
3116         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
3117         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
3118         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
3119         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
3120         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3121         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
3122         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
3123         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
3124         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3125         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
3126         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
3127         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
3128         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
3129         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
3130         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3131         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3132         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
3133         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
3134         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
3135         * ccache/ccache-clang:
3136         * ccache/ccache-clang++:
3137         * ccache/ccache-wrapper:
3138         * gtk/install-dependencies:
3139         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
3140         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
3141         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
3142         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
3143         * iExploder/iexploder-1.3.2/tools/showtest.rb:
3144         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
3145         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
3146         * iExploder/iexploder-1.7.2/src/webserver.rb:
3147         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
3148         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
3149         * wpe/install-dependencies:
3150
3151 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
3152
3153         filter-build-webkit filters out useful compiler error lines
3154         https://bugs.webkit.org/show_bug.cgi?id=179864
3155
3156         Reviewed by Tim Horton.
3157
3158         Don't filter out lines that contain information about build errors by always showing lines
3159         after a line that contains "note:" or "error:".
3160
3161         * Scripts/filter-build-webkit:
3162         (shouldShowSubsequentLine):
3163         (shouldIgnoreLine):
3164
3165 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3166
3167         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
3168         https://bugs.webkit.org/show_bug.cgi?id=173915
3169
3170         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
3171         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
3172         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
3173         empty string in this case.
3174
3175         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3176         (emitFormSubmissionEvent):
3177
3178 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3179
3180         [GTK] Add web process API to detect when form is submitted via JavaScript
3181         https://bugs.webkit.org/show_bug.cgi?id=173915
3182
3183         Reviewed by Carlos Garcia Campos.
3184
3185         Test it.
3186
3187         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3188         (FormSubmissionTest::FormSubmissionTest):
3189         (FormSubmissionTest::~FormSubmissionTest):
3190         (FormSubmissionTest::testFormSubmissionResult):
3191         (FormSubmissionTest::willSendDOMEventCallback):
3192         (FormSubmissionTest::willCompleteCallback):
3193         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
3194         (testWebExtensionFormSubmissionSteps):
3195         (beforeAll):
3196         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3197         (DelayedSignal::DelayedSignal):
3198         (emitFormSubmissionEvent):
3199         (handleFormSubmissionCallback):
3200         (willSubmitFormCallback):
3201         (pageCreatedCallback):
3202
3203 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3204
3205         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
3206         https://bugs.webkit.org/show_bug.cgi?id=181251
3207
3208         * Scripts/run-gtk-tests:
3209         (GtkTestRunner):
3210
3211 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3212
3213         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
3214         https://bugs.webkit.org/show_bug.cgi?id=181136
3215
3216         * Scripts/run-gtk-tests:
3217         (GtkTestRunner):
3218
3219 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
3220
3221         [macOS, iOS] Adopt new secure coding APIs in WebKit
3222         https://bugs.webkit.org/show_bug.cgi?id=181085
3223         <rdar://problem/34837397>
3224
3225         Reviewed by Tim Horton.
3226
3227         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
3228         capable of supporting NSSecureCoding, so pass through the current coding routines.
3229
3230         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
3231         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
3232         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
3233         routines if necessary.
3234         (TEST): Updated for NSSecureCoding.
3235         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
3236         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
3237
3238 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
3239
3240         Remove std::chrono completely
3241         https://bugs.webkit.org/show_bug.cgi?id=181186
3242
3243         Reviewed by Alex Christensen.
3244
3245         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3246         (WTR::TestController::platformRunUntil):
3247
3248 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3249
3250         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
3251         https://bugs.webkit.org/show_bug.cgi?id=181231
3252
3253         Reviewed by Alex Christensen.
3254
3255         Implement TestController APIs needed by ResourceLoadStatistics tests.
3256
3257         * WebKitTestRunner/TestController.cpp:
3258         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
3259         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
3260
3261 2018-01-02  Tim Horton  <timothy_horton@apple.com>
3262
3263         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
3264         https://bugs.webkit.org/show_bug.cgi?id=181219
3265
3266         Reviewed by Wenson Hsieh.
3267
3268         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3269
3270 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
3271
3272         Add a WebAuthentication runtime feature flag
3273         https://bugs.webkit.org/show_bug.cgi?id=181220
3274         <rdar://problem/36055305>
3275
3276         Reviewed by Brent Fulgham.
3277
3278         Renames the CredentialManagement runtime feature flag into WebAuthentication.
3279
3280         * DumpRenderTree/TestOptions.h:
3281         * DumpRenderTree/TestOptions.mm:
3282         (TestOptions::TestOptions):
3283         * DumpRenderTree/mac/DumpRenderTree.mm:
3284         (enableExperimentalFeatures):
3285         (setWebPreferencesForTestOptions):
3286         * WebKitTestRunner/TestController.cpp:
3287         (WTR::TestController::resetPreferencesToConsistentValues):
3288         (WTR::updateTestOptionsFromTestHeader):
3289         * WebKitTestRunner/TestOptions.h:
3290         (WTR::TestOptions::hasSameInitializationOptions const):
3291
3292 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3293
3294         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
3295         https://bugs.webkit.org/show_bug.cgi?id=181143
3296         <rdar://problem/36200381>
3297
3298         Reviewed by Tim Horton.
3299
3300         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
3301         attachment elements are enabled.
3302
3303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3304         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3305         (TestWebKitAPI::TEST):
3306
3307 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
3308
3309         Update Credential Management API for WebAuthentication
3310         https://bugs.webkit.org/show_bug.cgi?id=181082
3311         <rdar://problem/36055239>
3312
3313         Reviewed by Brent Fulgham.
3314
3315         Enable Credential Management API for testing.
3316
3317         * DumpRenderTree/TestOptions.h:
3318         * WebKitTestRunner/TestOptions.h:
3319
3320 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3321
3322         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
3323         https://bugs.webkit.org/show_bug.cgi?id=168194
3324
3325         Reviewed by Carlos Garcia Campos.
3326
3327         Fix an assertion and unskip the test. The order that form controls are associated is not
3328         guaranteed.
3329
3330         * Scripts/run-gtk-tests:
3331         (GtkTestRunner):
3332         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3333         (didAssociateFormControlsCallback):
3334
3335 2018-01-02  Alex Christensen  <achristensen@webkit.org>
3336
3337         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
3338         https://bugs.webkit.org/show_bug.cgi?id=180897
3339         <rdar://problem/35535328>
3340
3341         Reviewed by Brent Fulgham.
3342
3343         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
3344
3345         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3346         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3347         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
3348         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3349         (websiteDataStoreTestWebView):
3350         (TEST):
3351
3352 == Rolled over to ChangeLog-2018-01-01 ==