a8cecf7342905c6161f4edc6ad26310eae54374f
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
2
3         Remove Mavericks from the flakiness dashboard
4         https://bugs.webkit.org/show_bug.cgi?id=153521
5
6         Reviewed by Dan Bernstein.
7
8         * TestResultServer/static-dashboards/builders.jsonp:
9         * TestResultServer/static-dashboards/flakiness_dashboard.js:
10
11 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
12
13         Remove ENABLE_CURRENTSRC
14         https://bugs.webkit.org/show_bug.cgi?id=153545
15
16         Reviewed by Simon Fraser.
17
18         * Scripts/webkitperl/FeatureList.pm:
19
20 2016-01-26  Jason Marcell  <jmarcell@apple.com>
21
22         Sort incoming commits via date instead of revision number.
23         https://bugs.webkit.org/show_bug.cgi?id=153467
24
25         Reviewed by Alexey Proskuryakov.
26
27         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
28         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
29
30         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
31         (Trac.prototype._loaded): Sort via date instead of revision number.
32         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
33         (MockTrac): Fix up the mock data to look more like real-world data.
34         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
35         Fake RSS feed that adds three more commits.
36         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
37         Trac._loaded().
38
39 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
40
41         Add a test for WebKit::stringMatchesWildcardString.
42         https://bugs.webkit.org/show_bug.cgi?id=153090
43
44         Reviewed by Darin Adler.
45
46         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
47         Add the file to the project.
48
49         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
50         (TestWebKitAPI::TEST):
51         Test that a string matches another string that may contain wildcard characters.
52
53 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
54
55         [webkitdirs] Removed check for bison, gperf, and flex.
56         https://bugs.webkit.org/show_bug.cgi?id=153496
57
58         Reviewed by Alex Christensen.
59
60         This prerequisites are checked in WebKitCommon.cmake and don't
61         have to be in $PATH.
62
63         * Scripts/webkitdirs.pm:
64         (checkRequiredSystemConfig):
65
66 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
67
68         [webkitdirs] isCMakeBuild should be true by default
69         https://bugs.webkit.org/show_bug.cgi?id=153497
70
71         Reviewed by Michael Catanzaro.
72
73         * Scripts/webkitdirs.pm:
74         (isCMakeBuild):
75
76 2016-01-26  Daniel Bates  <dabates@apple.com>
77
78         Add WebKitSystemInterface for iOS 9.2
79         https://bugs.webkit.org/show_bug.cgi?id=153355
80
81         Rubber-stamped by David Kilzer.
82
83         * Scripts/copy-webkitlibraries-to-product-directory:
84
85 2016-01-26  Daniel Bates  <dabates@apple.com>
86
87         WebKitTestRunner: Credential cache is not cleared between tests
88         https://bugs.webkit.org/show_bug.cgi?id=153407
89         <rdar://problem/24280834>
90
91         Reviewed by Alexey Proskuryakov.
92
93         * WebKitTestRunner/TestController.cpp:
94         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
95         to clear cached credentials.
96
97 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
98
99         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
100         https://bugs.webkit.org/show_bug.cgi?id=153483
101
102         Reviewed by Csaba Osztrogonác.
103
104         * BuildSlaveSupport/kill-old-processes:
105         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
106
107 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
108
109         Give the layout test results file a <title> showing the date and time the tests were run
110         https://bugs.webkit.org/show_bug.cgi?id=153187
111
112         Reviewed by Darin Adler.
113         
114         Include a 'date' property in the JSON with the date and time the tests completed.
115
116         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
117         (summarize_results):
118
119 2016-01-25  Commit Queue  <commit-queue@webkit.org>
120
121         Unreviewed, rolling out r195543.
122         https://bugs.webkit.org/show_bug.cgi?id=153451
123
124         regressed performance of test bots by ~6% (Requested by dydz
125         on #webkit).
126
127         Reverted changeset:
128
129         "WebKitTestRunner: Credential cache is not cleared between
130         tests"
131         https://bugs.webkit.org/show_bug.cgi?id=153407
132         http://trac.webkit.org/changeset/195543
133
134 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
135
136         Failing to upload to flakiness dashboard should not be a hard error
137         https://bugs.webkit.org/show_bug.cgi?id=153444
138         <rdar://problem/22146294>
139
140         Reviewed by Alexey Proskuryakov.
141
142         * Scripts/webkitpy/layout_tests/controllers/manager.py:
143         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
144
145 2016-01-25  Daniel Bates  <dabates@apple.com>
146
147         WebKitTestRunner: Credential cache is not cleared between tests
148         https://bugs.webkit.org/show_bug.cgi?id=153407
149         <rdar://problem/24280834>
150
151         Reviewed by Brady Eidson.
152
153         * WebKitTestRunner/TestController.cpp:
154         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
155         to clear cached credentials.
156
157 2016-01-24  Dan Bernstein  <mitz@apple.com>
158
159         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
160
161         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
162
163 2016-01-22  Enrica Casucci  <enrica@apple.com>
164
165         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
166
167         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
168         (WTR::TestController::platformCreateWebView):
169
170 2016-01-22  Tim Horton  <timothy_horton@apple.com>
171
172         Add a test for iOS arrow-key repeat
173         https://bugs.webkit.org/show_bug.cgi?id=152857
174         <rdar://problem/24017380>
175
176         Reviewed by Darin Adler.
177
178         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
179         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
180         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
181         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
182         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
183         * WebKitTestRunner/ios/HIDEventGenerator.h:
184         * WebKitTestRunner/ios/HIDEventGenerator.mm:
185         (-[HIDEventGenerator keyPress:completionBlock:]):
186         (-[HIDEventGenerator keyDown:completionBlock:]):
187         (-[HIDEventGenerator keyUp:completionBlock:]):
188         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
189         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
190         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
191         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
192         Make it possible to independently send keyUp/keyDown, instead of just paired.
193
194 2016-01-22  Tim Horton  <timothy_horton@apple.com>
195
196         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
197         https://bugs.webkit.org/show_bug.cgi?id=153193
198         <rdar://problem/24222034>
199
200         Reviewed by Darin Adler.
201
202         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
203         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
204         (TEST):
205         Add a test that exhibits the problems we're fixing here.
206         Before, it would both log and assert in debug, and crash in release.
207         Now it runs happily to completion.
208
209 2016-01-22  Enrica Casucci  <enrica@apple.com>
210
211         Add support for testing data detection.
212         https://bugs.webkit.org/show_bug.cgi?id=153360
213
214         Reviewed by Tim Horton.
215
216         Adding a new testing option (useDataDetection) to turn on
217         data detection when running the a test.
218
219         * WebKitTestRunner/TestController.cpp:
220         (WTR::updateTestOptionsFromTestHeader):
221         * WebKitTestRunner/TestOptions.h:
222         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
223         (WTR::TestController::platformCreateWebView):
224
225 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
226
227         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
228         https://bugs.webkit.org/show_bug.cgi?id=153334
229
230         Reviewed by Zalan Bujtas.
231         
232         Evaluating expressions in the LayoutUnit summary provider seems to cause
233         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
234         denominator to 64.
235
236         * lldb/lldb_webkit.py:
237         (WebCoreLayoutUnitProvider.to_string):
238
239 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
240
241         display-profiler-output should be able to display code blocks sorted by machine counts
242         https://bugs.webkit.org/show_bug.cgi?id=153298
243
244         Reviewed by Oliver Hunt.
245
246         * Scripts/display-profiler-output:
247
248 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
249
250         Ensure to use compatible liborc version with wanted gstreamer version
251         https://bugs.webkit.org/show_bug.cgi?id=153276
252
253         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
254         The user may have a very recent liborc installed on his system.
255
256         Reviewed by Philippe Normand.
257
258         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
259         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
260
261 2016-01-21  Nan Wang  <n_wang@apple.com>
262
263         AX: [IOS] Implement next/previous text marker functions using TextIterator
264         https://bugs.webkit.org/show_bug.cgi?id=153292
265         <rdar://problem/24268243>
266
267         Reviewed by Chris Fleizach.
268
269         Made text marker tests available on iOS.
270
271         * DumpRenderTree/AccessibilityTextMarker.h:
272         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
273         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
274         (AccessibilityTextMarker::AccessibilityTextMarker):
275         (AccessibilityTextMarker::~AccessibilityTextMarker):
276         (AccessibilityTextMarker::isEqual):
277         (AccessibilityTextMarker::platformTextMarker):
278         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
279         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
280         (AccessibilityTextMarkerRange::isEqual):
281         (AccessibilityTextMarkerRange::platformTextMarkerRange):
282         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
283         (AccessibilityUIElement::pathDescription):
284         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
285         (AccessibilityUIElement::textMarkerRangeForElement):
286         (AccessibilityUIElement::selectedTextMarkerRange):
287         (AccessibilityUIElement::resetSelectedTextMarkerRange):
288         (AccessibilityUIElement::textMarkerRangeLength):
289         (AccessibilityUIElement::textMarkerRangeForMarkers):
290         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
291         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
292         (AccessibilityUIElement::accessibilityElementForTextMarker):
293         (AccessibilityUIElement::endTextMarkerForBounds):
294         (AccessibilityUIElement::startTextMarkerForBounds):
295         (AccessibilityUIElement::textMarkerForPoint):
296         (AccessibilityUIElement::previousTextMarker):
297         (AccessibilityUIElement::nextTextMarker):
298         (AccessibilityUIElement::stringForTextMarkerRange):
299         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
300         (AccessibilityUIElement::indexForTextMarker):
301         (AccessibilityUIElement::isTextMarkerValid):
302         (AccessibilityUIElement::textMarkerForIndex):
303         (AccessibilityUIElement::startTextMarker):
304         (AccessibilityUIElement::endTextMarker):
305         (AccessibilityUIElement::setSelectedVisibleTextRange):
306         (AccessibilityUIElement::getLinkedUIElements):
307         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
308         (AccessibilityTextMarkerRange::platformTextMarkerRange):
309         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
310         (AccessibilityUIElement::removeSelection):
311         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
312         (AccessibilityUIElement::setSelectedVisibleTextRange):
313         (AccessibilityUIElement::supportedActions):
314         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
315         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
316         (WTR::AccessibilityUIElement::textMarkerRangeLength):
317         (WTR::AccessibilityUIElement::previousTextMarker):
318         (WTR::AccessibilityUIElement::nextTextMarker):
319         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
320         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
321         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
322         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
323         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
324         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
325         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
326
327 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
328
329         Unreviewed, revert accidental unreviewed commit.
330
331         * Scripts/display-profiler-output:
332
333 2016-01-20  Jason Marcell  <jmarcell@apple.com>
334
335         Refactor compareIterations to remove duplicate code.
336         https://bugs.webkit.org/show_bug.cgi?id=152913
337
338         Reviewed by Daniel Bates.
339
340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
341         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
342         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
344         the same behavior before and after refactor.
345
346 2016-01-20  Dana Burkart  <dburkart@apple.com>
347
348         Botwatcher's dashboard should show an 'X' when the build is broken
349         https://bugs.webkit.org/show_bug.cgi?id=152507
350
351         Reviewed by David Kilzer.
352
353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
354         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
355         (BuildbotStaticAnalyzerQueueView.prototype.update):
356
357 2016-01-19  Jason Marcell  <jmarcell@apple.com>
358
359         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
360         https://bugs.webkit.org/show_bug.cgi?id=153262
361
362         Reviewed by Alexey Proskuryakov.
363
364         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
365         such cases this revisionContentForIteration method does not have any content to return, thus the
366         assertion fails.
367
368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
369         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
370
371 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
372
373         [GTK] Runtime critical warnings when loading a URL after a session restore
374         https://bugs.webkit.org/show_bug.cgi?id=153233
375
376         Reviewed by Michael Catanzaro.
377
378         Add new test case.
379
380         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
381         (viewLoadChanged):
382         (testWebKitWebViewNavigationAfterSessionRestore):
383         (beforeAll):
384
385 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
386
387         [GTK] Remove jhbuild-optional.modules
388         https://bugs.webkit.org/show_bug.cgi?id=152964
389
390         Reviewed by Alex Christensen.
391
392         * gtk/jhbuild-optional.modules: Removed.
393         * gtk/jhbuild.modules:
394
395 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
396
397         [GTK] Add support to load/save session in MiniBrowser
398         https://bugs.webkit.org/show_bug.cgi?id=153201
399
400         Reviewed by Michael Catanzaro.
401
402         It makes it easier to test the new WebView session API.
403
404         * MiniBrowser/gtk/BrowserWindow.c:
405         (browserWindowFinalize): Free the session file path.
406         (browserWindowSaveSession): Save the current WebView session if
407         there's a session file path.
408         (browserWindowDeleteEvent): Call browserWindowSaveSession().
409         (browser_window_load_session): Try to load the session from the
410         given file path, otherwise fall back to homepage and keep the
411         session file to save the session on window close.
412         * MiniBrowser/gtk/BrowserWindow.h:
413         * MiniBrowser/gtk/main.c:
414         (createBrowserWindow): Pass the given session file path when
415         shouldLoadSession is TRUE.
416         (main): Only allow to restore/save session when MiniBrowser is
417         launched without URL arguments.
418
419 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
420
421         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
422
423         Geolocation is no longer allowed for unique origins after r195075.
424
425         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
426         (testWebViewGeolocationPermissionRequests):
427
428 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
429
430         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
431         https://bugs.webkit.org/show_bug.cgi?id=153216
432
433         Reviewed by Michael Catanzaro.
434
435         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
436         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
437
438 2016-01-18  Nan Wang  <n_wang@apple.com>
439
440         AX: [Mac] Implement next/previous text marker functions using TextIterator
441         https://bugs.webkit.org/show_bug.cgi?id=152728
442
443         Reviewed by Chris Fleizach.
444
445         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
446         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
447
448 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
449
450         [cmake] Add testair to the build system
451         https://bugs.webkit.org/show_bug.cgi?id=153126
452
453         Reviewed by Michael Catanzaro.
454
455         * Scripts/build-jsc:
456
457 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
458
459         Remove TextRun::allowsRoundingHacks()
460         https://bugs.webkit.org/show_bug.cgi?id=153185
461
462         Reviewed by Simon Fraser.
463
464         * DumpRenderTree/mac/DumpRenderTree.mm:
465         (resetWebViewToConsistentStateBeforeTesting): Deleted.
466
467 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
468
469         [webkitdirs] Avoid list form of open because it broke WinCairo
470         https://bugs.webkit.org/show_bug.cgi?id=153106
471
472         Reviewed by Alex Christensen.
473
474         * Scripts/webkitdirs.pm:
475         (determineArchitecture):
476
477 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
478
479         Add kdebug_trace signposts for a few WebCore operations
480         https://bugs.webkit.org/show_bug.cgi?id=153136
481         rdar://problem/24208487
482
483         Reviewed by Sam Weinig.
484         
485         Plist used by kdebug_trace() viewing tools.
486
487         * Tracing/SystemTracePoints.plist: Added.
488
489 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
490
491         [webkitdirs] Replaced grep invocation with perl code
492         https://bugs.webkit.org/show_bug.cgi?id=153106
493
494         Reviewed by Alex Christensen.
495
496         * Scripts/webkitdirs.pm:
497         (determineArchitecture):
498
499 2016-01-14  Brian Burg  <bburg@apple.com>
500
501         prepare-changelog does not read paths containing spaces properly
502         https://bugs.webkit.org/show_bug.cgi?id=137982
503
504         Reviewed by Joseph Pecoraro.
505
506         Escape whitespace in filenames before passing the file path to other functions.
507
508         * Scripts/prepare-ChangeLog:
509         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
510
511 2016-01-14  Jason Marcell  <jmarcell@apple.com>
512
513         Standardize the usage of "branch" vs. "branchName".
514         https://bugs.webkit.org/show_bug.cgi?id=152982
515
516         Reviewed by Daniel Bates.
517
518         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
519         "branchName" implies that the variable or property in question is simply a string.
520
521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
522         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
523         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
524         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
526         (Trac.prototype.commitsOnBranch): Change branch to branchName.
527         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
528         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
529         (MockTrac): Ditto.
530
531 2016-01-14  Jason Marcell  <jmarcell@apple.com>
532
533         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
534         https://bugs.webkit.org/show_bug.cgi?id=152910
535
536         Reviewed by Daniel Bates.
537
538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
539         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
541         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
542         the need to talk to a real Buildbot server.
543         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
544         without the need to talk to a real Buildbot server.
545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
546         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
547         server.
548         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
549         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
550         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
551         trying to talk to Trac.
552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
553         QUnit unit tests.
554         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
555
556 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
557
558         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
559         https://bugs.webkit.org/show_bug.cgi?id=132599
560
561         Reviewed by Michael Catanzaro.
562
563         Check if cmake Ninja generators are installed.
564
565         * Scripts/webkitdirs.pm:
566         (canUseNinjaGenerator):
567         (canUseEclipseNinjaGenerator):
568         (generateBuildSystemFromCMakeProject):
569         (canUseEclipse): Deleted.
570
571 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
572
573         [Cocoa] Testing with font family name "System Font" is unused
574         https://bugs.webkit.org/show_bug.cgi?id=153073
575         <rdar://problem/24091683>
576
577         Reviewed by Brent Fulgham.
578
579         * DumpRenderTree/mac/DumpRenderTree.mm:
580         (allowedFontFamilySet): Deleted.
581         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
582         (WTR::allowedFontFamilySet): Deleted.
583         * WebKitTestRunner/mac/TestControllerMac.mm:
584         (WTR::allowedFontFamilySet): Deleted.
585
586 2016-01-13  Daniel Bates  <dabates@apple.com>
587
588         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
589         https://bugs.webkit.org/show_bug.cgi?id=152871
590
591         Reviewed by Brent Fulgham.
592
593         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
594         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
595
596         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
597
598 2016-01-08  Andy Estes  <aestes@apple.com>
599
600         [Content Filtering] Lazily load platform frameworks
601         https://bugs.webkit.org/show_bug.cgi?id=152881
602         rdar://problem/23270886
603
604         Reviewed by Brady Eidson.
605
606         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
607         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
608         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
609         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
610         is loaded after an HTTPS request.
611
612         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
613         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
614         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
615         also re-enabled on iOS after mistakenly being disabled by r188892.
616
617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
618         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
619         (TestWebKitAPI::TEST):
620         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
621         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
622         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
623         (TEST):
624         (downloadTest):
625         (-[LazilyLoadPlatformFrameworksController init]):
626         (-[LazilyLoadPlatformFrameworksController webView]):
627         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
628         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
629         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
630         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
631         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
632         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
633         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
634         (TestWebKitAPI::TEST):
635         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
636         (TestWebKitAPI::TEST): Deleted.
637         * TestWebKitAPI/cocoa/TestProtocol.h:
638         * TestWebKitAPI/cocoa/TestProtocol.mm:
639         (+[TestProtocol registerWithScheme:]):
640         (+[TestProtocol unregister]):
641
642 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
643
644         Fix the Sunpider converage in slow device.
645         https://bugs.webkit.org/show_bug.cgi?id=152938
646         <rdar://problem/22511411>
647
648         Reviewed by Ryosuke Niwa.
649
650         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
651
652         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
653
654 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
655
656         Add a build flag for custom element
657         https://bugs.webkit.org/show_bug.cgi?id=153005
658
659         Reviewed by Alex Christensen.
660
661         Added --custom-elements option to enable custom elements support.
662
663         * Scripts/webkitperl/FeatureList.pm:
664
665 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
666
667         [JSC] Add a help message when run-jsc-stress-tests fails
668         https://bugs.webkit.org/show_bug.cgi?id=153014
669
670         Reviewed by Csaba Osztrogonác.
671
672         * Scripts/run-jsc-stress-tests:
673
674 2016-01-11  Saam barati  <sbarati@apple.com>
675
676         run-jsc-stress-tests should try to figure out a JSC path
677         https://bugs.webkit.org/show_bug.cgi?id=152971
678
679         Reviewed by Yusuke Suzuki.
680
681         This patch now allows run-jsc-stress-tests to be run
682         without a "--jsc <jsc-path>" argument. It tries
683         to take its best guess at a <jsc-path> automagically.
684         
685         This makes it much easier to just run run-jsc-stress-tests
686         with a directory or a yaml file as an argument.
687         You now just do this:
688         `run-jsc-stress-tests <path-to-yaml>`
689         or
690         `run-jsc-stress-tests <path-to-directory-of-js-files>`
691         
692         I wrote this patch because I'd often find myself hacking the 
693         run-javascriptcore-tests file just to run a particular subset of tests.
694         Because I always forget the arguments to run-jsc-stress-tests (which means
695         I always forgot to provide a --jsc argument), I always found it easier to 
696         just hack on that file instead of calling run-jsc-stress-tests directly.
697         No longer is this true!
698
699         * Scripts/run-jsc-stress-tests:
700
701 2016-01-09  Andy Estes  <aestes@apple.com>
702
703         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
704         https://bugs.webkit.org/show_bug.cgi?id=152950
705         rdar://problem/24066652
706
707         Reviewed by Tim Horton.
708
709         Added an API test.
710
711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
712         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
713         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
714         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
715         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
716         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
717         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
718         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
719         (TEST):
720
721 2016-01-11  Commit Queue  <commit-queue@webkit.org>
722
723         Unreviewed, rolling out r194866.
724         https://bugs.webkit.org/show_bug.cgi?id=152986
725
726         This change broke the mac build (Requested by ryanhaddad on
727         #webkit).
728
729         Reverted changeset:
730
731         "[Cocoa] Add SPI to opt out a URL scheme from the memory
732         cache"
733         https://bugs.webkit.org/show_bug.cgi?id=152950
734         http://trac.webkit.org/changeset/194866
735
736 2016-01-11  Andy Estes  <aestes@apple.com>
737
738         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
739         https://bugs.webkit.org/show_bug.cgi?id=152950
740         rdar://problem/24066652
741
742         Reviewed by Tim Horton.
743
744         Added an API test.
745
746         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
747         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
748         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
749         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
750         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
751         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
752         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
753         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
754         (TEST):
755
756 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
757
758         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
759         https://bugs.webkit.org/show_bug.cgi?id=152959
760
761         Reviewed by Brent Fulgham.
762
763         * Scripts/webkitdirs.pm:
764         (determineArchitecture):
765
766 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
767
768         [GTK] W3C CSS2.1 anonymous table tests are failing
769         https://bugs.webkit.org/show_bug.cgi?id=152455
770
771         Reviewed by Mario Sanchez Prada.
772
773         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
774         tests. Add upstream patches to fix detection of XHTML files.
775
776         * gtk/jhbuild.modules:
777         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
778         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
779
780 2016-01-10  Saam barati  <sbarati@apple.com>
781
782         Implement a sampling profiler
783         https://bugs.webkit.org/show_bug.cgi?id=151713
784
785         Reviewed by Filip Pizlo.
786
787         * Scripts/run-jsc-stress-tests:
788
789 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
790
791         [webkitdirs] Try arch and uname commands on non-windows OS
792         https://bugs.webkit.org/show_bug.cgi?id=152958
793
794         Reviewed by Michael Catanzaro.
795
796         Right now, determineArchitecture()  uses `arch` and `uname -m`
797         commands to determine architecture in case of condition (isGtk() ||
798         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
799         instead, because this code is applicable to any non-windows OS WebKit
800         supports (even Haiku which once was supported is moderately
801         POSIX-compliant and has uname command).
802
803         * Scripts/webkitdirs.pm:
804         (determineArchitecture):
805
806 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
807
808         run-webkit-tests mis-counts totals when there are other crashes
809         https://bugs.webkit.org/show_bug.cgi?id=152894
810         <rdar://problem/24098697>
811
812         Reviewed by Alexey Proskuryakov.
813
814         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
815         (TestRunResults.add): Do not update result counters for other crashes.
816
817 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
818
819         webkit-patch build-and-test should have an option to iterate over new tests
820         https://bugs.webkit.org/show_bug.cgi?id=143093
821
822         Reviewed by Michael Catanzaro.
823
824         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
825         It allows running run-webkit-tests on modified or new paths in LayoutTests.
826         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
827         It implements the translation of -expected.* paths to their related tests.
828         It also implements the removal of skipped tests.
829
830         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
831         (LayoutTestFinder.find_touched_tests):
832         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
833         (MockPort):
834         (MockPort.__init__):
835         (MockPort.tests):
836         (LayoutTestFinderTests):
837         (LayoutTestFinderTests.touched_files):
838         (LayoutTestFinderTests.test_touched_test):
839         (LayoutTestFinderTests.test_expected_touched_test):
840         (LayoutTestFinderTests.test_platform_expected_touched_test):
841         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
842         (LayoutTestFinderTests.test_touched_but_skipped_test):
843         * Scripts/webkitpy/port/base.py:
844         (Port.potential_test_names_from_expected_file):
845         * Scripts/webkitpy/tool/commands/download_unittest.py:
846         (DownloadCommandsTest._default_options):
847         * Scripts/webkitpy/tool/steps/options.py:
848         (Options):
849         * Scripts/webkitpy/tool/steps/runtests.py:
850         (RunTests.options):
851         (RunTests.run):
852         (RunTests):
853         (RunTests._new_or_modified_tests):
854         (RunTests._run_webkit_tests):
855         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
856         (RunTestsTest.test_webkit_run_unit_tests):
857         * Scripts/webkitpy/tool/steps/steps_unittest.py:
858         (StepsTest._step_options):
859
860 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
861
862         prepare-ChangeLog should include radar number
863         https://bugs.webkit.org/show_bug.cgi?id=152839
864         <rdar://problem/24093563>
865
866         Reviewed by Daniel Bates.
867
868         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
869         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
870         in the ChangeLog description after the bug URL.
871
872         * Scripts/prepare-ChangeLog:
873         (main): Update signatures.
874         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
875         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
876         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
877         (generateNewChangeLogs): Include radar URL if we found one.
878
879         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
880         Tests for the radar URL extraction.
881
882 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
883
884         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
885         https://bugs.webkit.org/show_bug.cgi?id=152390
886         <rdar://problem/23948321>
887
888         Reviewed by Simon Fraser.
889
890         Fix two use-after-frees.
891
892         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
893         but we may have already progressed to another test by the time the callback fires,
894         having destroyed the TestInvocation.
895         2. UIScriptController is a RefCounted object, but it has a raw pointer to
896         UIScriptContext which has the same lifetime as a TestInvocation.
897         As a result, completion blocks of UIScriptController actions would use a destroyed
898         TestInvocation.
899
900         * WebKitTestRunner/TestInvocation.cpp:
901         (WTR::TestInvocation::~TestInvocation):
902         (WTR::TestInvocation::url):
903         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
904         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
905         (WTR::TestInvocation::runUISideScript):
906         * WebKitTestRunner/TestInvocation.h:
907         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
908         (UIScriptContext::UIScriptContext):
909         (UIScriptContext::~UIScriptContext):
910         (UIScriptContext::runUIScript):
911         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
912         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
913         (WTR::UIScriptController::UIScriptController):
914         (WTR::UIScriptController::contextDestroyed):
915         (WTR::UIScriptController::makeWindowObject):
916         (WTR::UIScriptController::setWillBeginZoomingCallback):
917         (WTR::UIScriptController::willBeginZoomingCallback):
918         (WTR::UIScriptController::setDidEndZoomingCallback):
919         (WTR::UIScriptController::didEndZoomingCallback):
920         (WTR::UIScriptController::setDidEndScrollingCallback):
921         (WTR::UIScriptController::didEndScrollingCallback):
922         (WTR::UIScriptController::setDidShowKeyboardCallback):
923         (WTR::UIScriptController::didShowKeyboardCallback):
924         (WTR::UIScriptController::setDidHideKeyboardCallback):
925         (WTR::UIScriptController::didHideKeyboardCallback):
926         (WTR::UIScriptController::uiScriptComplete):
927         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
928         (WTR::UIScriptController::create):
929         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
930         (WTR::UIScriptController::doAsyncTask):
931         (WTR::UIScriptController::zoomToScale):
932         (WTR::UIScriptController::singleTapAtPoint):
933         (WTR::UIScriptController::doubleTapAtPoint):
934         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
935         (WTR::UIScriptController::contentVisibleRect):
936         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
937         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
938         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
939         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
940         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
941         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
942         (WTR::UIScriptController::doAsyncTask):
943
944 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
945
946         [buildbot] clean-build script should remove untracked files and revert local changes too
947         https://bugs.webkit.org/show_bug.cgi?id=142400
948
949         Reviewed by Ryosuke Niwa.
950
951         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
952         A helper routine SCM.discard_untracked_files is added for that purpose.
953
954         * BuildSlaveSupport/clean-build:
955         (main): Making call to Scripts/clean-webkit
956         * Scripts/clean-webkit: Added.
957         (main): Revert changes and delete untracked files.
958         * Scripts/webkitpy/common/checkout/scm/scm.py:
959         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
960         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
961         (SCMTest._shared_test_discard_untracked_files):
962         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
963
964 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
965
966         Add a setting and preferences to enable display-list drawing. Does nothing yet.
967         https://bugs.webkit.org/show_bug.cgi?id=152807
968
969         Reviewed by Zalan Bujtas.
970         
971         Add an item to the Settings menu to toggle display-list drawing.
972
973         * MiniBrowser/mac/SettingsController.h:
974         * MiniBrowser/mac/SettingsController.m:
975         (-[SettingsController _populateMenu]):
976         (-[SettingsController validateMenuItem:]):
977         (-[SettingsController toggleDisplayListDrawingEnabled:]):
978         (-[SettingsController displayListDrawingEnabled]):
979         * MiniBrowser/mac/WK2BrowserWindowController.m:
980         (-[WK2BrowserWindowController didChangeSettings]):
981
982 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
983
984         Python SCM should be able to retrieve untracked files - Add GIT support
985         https://bugs.webkit.org/show_bug.cgi?id=143135
986
987         Reviewed by Michael Catanzaro.
988
989         * Scripts/webkitpy/common/checkout/scm/git.py:
990         (Git.untracked_files): Adding support for git.
991         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
992         (GitTest.setUp):
993         (GitTest.test_untracked_files): Adding test.
994
995 2016-01-05  Mark Lam  <mark.lam@apple.com>
996
997         Rename badly named JSC_timeout env var to JSCTEST_timeout.
998         https://bugs.webkit.org/show_bug.cgi?id=152748
999
1000         Reviewed by Geoffrey Garen.
1001
1002         Now that we validate JSC options, the badly named JSC_timeout env var causes the
1003         bots to have a bad time.
1004
1005         * Scripts/run-javascriptcore-tests:
1006         * Scripts/run-jsc-stress-tests:
1007
1008 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1009
1010         [GTK] Allow to save and restore session
1011         https://bugs.webkit.org/show_bug.cgi?id=115600
1012
1013         Reviewed by Michael Catanzaro.
1014
1015         Add test case to check the new session API.
1016
1017         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1018         (testWebKitWebViewSessionState):
1019         (testWebKitWebViewSessionStateWithFormData):
1020         (beforeAll):
1021
1022 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
1023
1024         [EFL] Bump EFL version to 1.16.1
1025         https://bugs.webkit.org/show_bug.cgi?id=152688
1026
1027         Reviewed by Gyuyoung Kim.
1028
1029         * efl/jhbuild.modules:
1030
1031 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
1032
1033         error running layout tests on iOS simulator on latest build
1034         https://bugs.webkit.org/show_bug.cgi?id=152719
1035         <rdar://problem/24009549>
1036
1037         Reviewed by Alexey Proskuryakov.
1038
1039         * Scripts/webkitpy/xcode/simulator.py:
1040         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
1041           before running simctl spawn command.
1042
1043 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1044
1045         Unreviewed, move Frédéric Wang to committers list
1046
1047         He seems to be on the contributors list by accident. He has been landing his own commits for
1048         about two years now.
1049
1050         * Scripts/webkitpy/common/config/contributors.json:
1051
1052 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1053
1054         Unreviewed, move Sebastian Dröge to committers list harder
1055
1056         He accidentally added himself to the reviewers list because the file is confusing. Then I
1057         accidentially moved him to the contributors list because the file is confusing, even though
1058         I knew the contributors list existed in this file and was attempting to add him to the
1059         committers list. Really move him to the committers list now.
1060
1061         * Scripts/webkitpy/common/config/contributors.json:
1062
1063 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1064
1065         Python SCM should be able to retrieve untracked files - Add SVN support
1066         https://bugs.webkit.org/show_bug.cgi?id=152546
1067
1068         Reviewed by Michael Catanzaro.
1069
1070         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1071         (test_untracked_files): Activating test for SVN.
1072         * Scripts/webkitpy/common/checkout/scm/svn.py:
1073         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
1074
1075 2015-12-31  Andy Estes  <aestes@apple.com>
1076
1077         Replace WTF::move with WTFMove
1078         https://bugs.webkit.org/show_bug.cgi?id=152601
1079
1080         Reviewed by Brady Eidson.
1081
1082         * DumpRenderTree/TestRunner.h:
1083         (TestRunner::setAllowedHosts):
1084         * DumpRenderTree/win/DRTDataObject.cpp:
1085         (DRTDataObject::SetData):
1086         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1087         (TestWebKitAPI::TEST):
1088         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1089         (TestWebKitAPI::TEST):
1090         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1091         (TestWebKitAPI::TEST):
1092         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1093         (TestWebKitAPI::TEST):
1094         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1095         (TestWebKitAPI::passWithRef):
1096         (TestWebKitAPI::TEST):
1097         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1098         (TestWebKitAPI::TEST):
1099         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1100         (TestWebKitAPI::TEST):
1101         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1102         (TestWebKitAPI::TEST):
1103         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1104         (TestWebKitAPI::TEST):
1105         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1106         (TestWebKitAPI::createTestValue):
1107         (TestWebKitAPI::TEST):
1108         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1109         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1110         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1111         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1112         (TestWebKitAPI::createNFAs):
1113         (TestWebKitAPI::TEST_F):
1114         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
1115         (TestWebKitAPI::combine):
1116         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
1117         (TestWebKitAPI::createNFAs):
1118         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
1119         (TEST):
1120         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1121         (WebProcessTest::add):
1122
1123 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
1124
1125         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
1126         https://bugs.webkit.org/show_bug.cgi?id=152634
1127
1128         Reviewed by Carlos Garcia Campos.
1129
1130         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1131         (testLoadFromGResource): Added test.
1132         (beforeAll):
1133         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1134         (registerGResource): Added.
1135         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
1136         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
1137         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
1138
1139 2015-12-31  David Kilzer  <ddkilzer@apple.com>
1140
1141         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
1142         <https://bugs.webkit.org/show_bug.cgi?id=152601>
1143
1144         Ignore unknown pragmas on older clangs.  Fixes the following
1145         build failure:
1146
1147             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
1148             #pragma clang diagnostic ignored "-Wself-move"
1149                                              ^
1150             1 error generated.
1151
1152         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1153         (TestWebKitAPI::TEST):
1154         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1155         (TestWebKitAPI::TEST):
1156
1157 2015-12-31  Andy Estes  <aestes@apple.com>
1158
1159         Update the style checker to advise using WTFMove() instead of WTF::move()
1160         https://bugs.webkit.org/show_bug.cgi?id=152601
1161
1162         Reviewed by Daniel Bates.
1163
1164         * Scripts/webkitpy/style/checkers/cpp.py:
1165         (check_wtf_move):
1166         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1167         (WebKitStyleTest.test_wtf_move):
1168
1169 2015-12-31  Andy Estes  <aestes@apple.com>
1170
1171         Fix warnings uncovered by migrating to WTF_MOVE
1172         https://bugs.webkit.org/show_bug.cgi?id=152601
1173
1174         Reviewed by Daniel Bates.
1175
1176         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
1177         self-move, even if doing so would trigger a warning.
1178
1179         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1180         (TestWebKitAPI::TEST):
1181         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1182         (TestWebKitAPI::TEST):
1183
1184 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
1185
1186         [GTK] The install-dependencies script has a syntax error
1187         https://bugs.webkit.org/show_bug.cgi?id=152613
1188
1189         Reviewed by Michael Catanzaro.
1190
1191         * gtk/install-dependencies: Add the missing 'then.'
1192
1193 2015-12-30  Philippe Normand  <pnormand@igalia.com>
1194
1195         [Mac][GTK] Jhbuild support for OSX
1196         https://bugs.webkit.org/show_bug.cgi?id=150799
1197
1198         Reviewed by Michael Catanzaro.
1199
1200         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
1201         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
1202         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
1203         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
1204
1205 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1206
1207         Unreviewed, move Sebastian Dröge to committers list
1208
1209         He accidentally added himself to the reviewers list because the file is confusing.
1210
1211         * Scripts/webkitpy/common/config/contributors.json:
1212
1213 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
1214
1215         Remove the unused #define _USE_MATH_DEFINES
1216         https://bugs.webkit.org/show_bug.cgi?id=152034
1217
1218         Reviewed by Tim Horton.
1219         
1220         Update this test to use piDouble from MathExtras.h, and
1221         std::numeric_limits<>.
1222
1223         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1224
1225 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1226
1227         Python SCM should be able to retrieve untracked files - Generic changes
1228         https://bugs.webkit.org/show_bug.cgi?id=152536
1229
1230         Reviewed by Brent Fulgham.
1231
1232         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1233         No support is yet added to GIT and SVN specific implementations.
1234
1235         * Scripts/webkitpy/common/checkout/scm/scm.py:
1236         (SCM.untracked_files):
1237         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1238         (SCMTest._shared_test_untracked_files):
1239
1240 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
1241
1242         SVN checkout used by RunBenchmark should be non-interactive
1243         https://bugs.webkit.org/show_bug.cgi?id=152542
1244
1245         Reviewed by Ryosuke Niwa.
1246
1247         RunBenchmark should not require user interaction while running.
1248
1249         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1250         (BenchmarkBuilder._checkout_with_subversion):
1251
1252 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1253
1254         Web Inspector: add support for running protocol-test.js tests on Windows
1255         https://bugs.webkit.org/show_bug.cgi?id=148037
1256         <rdar://problem/22292237>
1257
1258         Reviewed by Simon Fraser.
1259
1260         * DumpRenderTree/win/TestRunnerWin.cpp:
1261         (TestRunner::inspectorTestStubURL): Provide implementation.
1262
1263 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
1264
1265         [MediaStream] MediaDeviceInfo.label must be empty in some situations
1266         https://bugs.webkit.org/show_bug.cgi?id=152000
1267
1268         Reviewed by Brent Fulgham.
1269
1270         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1271         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1272         (WTR::InjectedBundle::setUserMediaPermission):
1273         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1274         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1275
1276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1277         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1278         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1279
1280         * WebKitTestRunner/TestController.cpp:
1281         (WTR::TestController::setUserMediaPermissionForOrigin):
1282         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1283         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
1284           persistent permission for origin, that can be done from script now.
1285         * WebKitTestRunner/TestController.h:
1286
1287         * WebKitTestRunner/TestInvocation.cpp:
1288         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1289           SetUserMediaPermissionForOrigin.
1290
1291 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1292
1293         [Win] Unreviewed build fix: Recognize Windows 10 variants.
1294
1295         * Scripts/webkitpy/common/system/platforminfo.py:
1296         (PlatformInfo._determine_win_version):
1297
1298 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1299
1300         Content blockers should be able to promote http to https
1301         https://bugs.webkit.org/show_bug.cgi?id=148966
1302
1303         Reviewed by Benjamin Poulain.
1304
1305         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1306         (WebCore::ContentExtensions::operator<<):
1307         (TestWebKitAPI::TEST_F):
1308
1309 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1310
1311         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1312         https://bugs.webkit.org/show_bug.cgi?id=152516
1313
1314         Reviewed by Gyuyoung Kim.
1315
1316         * MiniBrowser/efl/main.c:
1317
1318 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
1319
1320         Unreviewed: Add John Wilander as a contributor.
1321
1322         * Scripts/webkitpy/common/config/contributors.json:
1323
1324 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
1325
1326         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1327         https://bugs.webkit.org/show_bug.cgi?id=152482
1328
1329         Reviewed by Brent Fulgham.
1330
1331         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1332         for the same property. On WK2, the element returned will not be valid, but is still present and
1333         that can lead to looping.
1334
1335         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1336         (AccessibilityUIElement::horizontalScrollbar):
1337         (AccessibilityUIElement::verticalScrollbar):
1338         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1339         (WTR::AccessibilityUIElement::horizontalScrollbar):
1340         (WTR::AccessibilityUIElement::verticalScrollbar):
1341
1342 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1343
1344         Unreviewed.
1345
1346         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1347
1348 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1349
1350         [EFL] test_ewk2_context failed after r192808
1351         https://bugs.webkit.org/show_bug.cgi?id=151846
1352
1353         Reviewed by Gyuyoung Kim.
1354
1355         Used the added ewk_context_web_process_count_limit_set api
1356         instead of the deprecated ewk_context_process_model_set.
1357
1358         * MiniBrowser/efl/main.c:
1359         (elm_main):
1360
1361 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1362
1363         Unreviewed, move myself to reviewer list.
1364
1365         * Scripts/webkitpy/common/config/contributors.json:
1366
1367 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1368
1369         Unreviewed, add myself to the committers list.
1370
1371         * Scripts/webkitpy/common/config/contributors.json:
1372
1373 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1374
1375         [GTK] jquery.min.js violates DFSG
1376         https://bugs.webkit.org/show_bug.cgi?id=152428
1377
1378         Reviewed by Joseph Pecoraro.
1379
1380         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1381         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1382
1383         * gtk/manifest.txt.in:
1384
1385 2015-12-19  Dan Bernstein  <mitz@apple.com>
1386
1387         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1388         https://bugs.webkit.org/show_bug.cgi?id=152462
1389
1390         Reviewed by Alexey Proskuryakov.
1391
1392         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1393           OS X 10.9:
1394
1395         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1396         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1397         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1398         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1399         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1400
1401         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1402           never getting compiled:
1403
1404         * DumpRenderTree/mac/TextInputController.m:
1405         * MiniBrowser/mac/BrowserWindowController.m:
1406         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1407         * WebKitTestRunner/mac/EventSenderProxy.mm:
1408
1409 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1410
1411         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1412
1413         This is to make it easy to CC it on Bugzilla.
1414
1415         * Scripts/webkitpy/common/config/contributors.json:
1416
1417 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1418
1419         Pasteboard get messed up after running kill-old-processes
1420         https://bugs.webkit.org/show_bug.cgi?id=152426
1421
1422         Reviewed by Alexey Proskuryakov.
1423
1424         * BuildSlaveSupport/kill-old-processes:
1425         (main): Do not kill pasteboard anymore.
1426
1427 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1428
1429         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1430         https://bugs.webkit.org/show_bug.cgi?id=152157
1431         <rdar://problem/23851817>
1432
1433         Reviewed by Alexey Proskuryakov.
1434
1435         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1436         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1437         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1438         (Manager._get_test_inputs): Common method to calculate test_inputs.
1439         (Manager._update_worker_count): Calculate and update required number of workers.
1440
1441 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1442
1443         run-webkit-tests fails to delete Simulator device during cleanup
1444         https://bugs.webkit.org/show_bug.cgi?id=152363
1445
1446         Reviewed by Alexey Proskuryakov.
1447
1448         * Scripts/webkitpy/xcode/simulator.py:
1449         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1450
1451 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1452
1453         [mac-wk2] fast/events force click tests crashing
1454         https://bugs.webkit.org/show_bug.cgi?id=152339
1455
1456         Reviewed by Beth Dakin.
1457
1458         * WebKitTestRunner/mac/EventSenderProxy.mm:
1459         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1460         Set the NSEvent's _type member in addition to overriding -type,
1461         because there are assertions in touch event handling code that depend on it.
1462
1463 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1464
1465         Enforce temporarily bots to sync WebKit and WPT testharness.js
1466         https://bugs.webkit.org/show_bug.cgi?id=152334
1467
1468         Reviewed by Darin Adler.
1469
1470         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1471         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1472
1473 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1474
1475         [Fetch API] Add fetch API compile time flag
1476         https://bugs.webkit.org/show_bug.cgi?id=152254
1477
1478         Reviewed by Darin Adler.
1479
1480         * Scripts/webkitperl/FeatureList.pm:
1481
1482 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1483
1484         Unreviewed.
1485
1486         Added files that have impact in building Streams API to the watchlist.
1487
1488         * Scripts/webkitpy/common/config/watchlist:
1489
1490 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1491
1492         Unreviewed.
1493
1494         Added imported tests to Streams API watchlist.
1495
1496         * Scripts/webkitpy/common/config/watchlist:
1497
1498 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1499
1500         Remove default copy of wpt testharness.js when launching wpt server
1501         https://bugs.webkit.org/show_bug.cgi?id=152298
1502
1503         Reviewed by Darin Adler.
1504
1505         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1506         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1507
1508 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1509
1510         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1511         <http://webkit.org/b/152314>
1512
1513         Reviewed by Daniel Bates.
1514
1515         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1516         code path to exit immediately when calling main().
1517         Unfortunately, DumpRenderTreeMain.mm was used for both
1518         DumpRenderTree command-line binary and DumpRenderTree.app, which
1519         meant that the app would exit immediately with no error code
1520         when run!
1521
1522         The workaround is to introduce a separate source file called
1523         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1524         already does.
1525
1526         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1527         DumpRenderTreeAppMain.mm to the project.  Make it the only
1528         compiled source for the DumpRenderTree.app target.
1529         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1530         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1531         case someone tries mistakenly to use the app.
1532         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1533         Link to JavaScriptCore.framework on iOS for the assert.
1534         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1535         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1536         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1537         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1538         (main): Add assert for iOS so that a crash occurs if someone
1539         tries to run the wrong command.
1540
1541 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1542
1543         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1544         https://bugs.webkit.org/show_bug.cgi?id=152266
1545         <rdar://problem/22092676>
1546
1547         Reviewed by Simon Fraser.
1548
1549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1550         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1551         Add a test that crashed before this change, and doesn't crash after.
1552
1553 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1554
1555         AX: iOS: Text field variations do not have the correct traits
1556         https://bugs.webkit.org/show_bug.cgi?id=152237
1557
1558         Reviewed by Mario Sanchez Prada.
1559
1560         Add iOS calls for determing if an object is a search field or a text area.
1561
1562         * DumpRenderTree/AccessibilityUIElement.cpp:
1563         (getIsSearchFieldCallback):
1564         (getIsTextAreaCallback):
1565         (stringForSelectionCallback):
1566         (AccessibilityUIElement::getJSClass):
1567         * DumpRenderTree/AccessibilityUIElement.h:
1568         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1569         (AccessibilityUIElement::identifier):
1570         (AccessibilityUIElement::isTextArea):
1571         (AccessibilityUIElement::isSearchField):
1572         (AccessibilityUIElement::traits):
1573         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1574         (WTR::AccessibilityUIElement::scrollPageRight):
1575         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1576         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1577         (WTR::AccessibilityUIElement::isSearchField):
1578         (WTR::AccessibilityUIElement::isTextArea):
1579         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1580         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1581         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1582         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1583         (WTR::AccessibilityUIElement::isTextArea):
1584         (WTR::AccessibilityUIElement::isSearchField):
1585         (WTR::AccessibilityUIElement::rowCount):
1586
1587 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1588
1589         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1590         https://bugs.webkit.org/show_bug.cgi?id=152252
1591
1592         Reviewed by Sergio Villar Senin.
1593
1594         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1595         for building the JHBuild on Debian systems.
1596
1597 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1598
1599         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1600         https://bugs.webkit.org/show_bug.cgi?id=152156
1601
1602         Reviewed by Dan Bernstein.
1603
1604         Our frameworks should appropriately prefix all ObjC classes,
1605         not just external symbols.
1606
1607         * Scripts/check-for-inappropriate-objc-class-names:
1608         Remove the -g switch to check all ObjC class names.
1609
1610 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1611
1612         [MediaStream] Expose media capture devices persistent permissions to WebCore
1613         https://bugs.webkit.org/show_bug.cgi?id=152087
1614
1615         Add support for the new user media permission checker page UI client method.
1616
1617         Reviewed by Chris Dumez.
1618
1619         * WebKitTestRunner/TestController.cpp:
1620         (WTR::decidePolicyForUserMediaPermissionRequest):
1621         (WTR::checkUserMediaPermissionForOrigin):
1622         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1623         (WTR::TestController::createWebViewWithOptions): Ditto.
1624         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1625         (WTR::originUserVisibleName): New, create a string for the origin.
1626         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1627           according to the state of the origin permission map.
1628         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1629           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1630         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1631           origin permission map.
1632         * WebKitTestRunner/TestController.h:
1633
1634 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1635
1636         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1637         https://bugs.webkit.org/show_bug.cgi?id=152022
1638         rdar://problem/23763584
1639
1640         Reviewed by Darin Adler.
1641
1642         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1643         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1644         (WTR::InjectedBundlePage::willSendRequestForFrame):
1645         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1646         (WTR::TestRunner::setWillSendRequestReturnsNull):
1647         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1648         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1649         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1650         (WTR::TestRunner::willSendRequestHTTPBody):
1651         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1652
1653 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1654
1655         Remove additional simulator checks before running layout-tests
1656         https://bugs.webkit.org/show_bug.cgi?id=152146
1657
1658         Reviewed by Darin Adler.
1659
1660         * Scripts/webkitpy/port/ios.py:
1661         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1662         * Scripts/webkitpy/xcode/simulator.py:
1663         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1664         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1665
1666 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1667
1668         Run atleast one simulator even if max process limit is low
1669         https://bugs.webkit.org/show_bug.cgi?id=152081
1670         <rdar://problem/23819694>
1671
1672         Reviewed by Alexey Proskuryakov.
1673
1674 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1675
1676         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1677         https://bugs.webkit.org/show_bug.cgi?id=144262
1678
1679         Reviewed by Carlos Garcia Campos.
1680
1681         Added new unit test to check the additional scenarios we now
1682         handle for custom URI schemes.
1683
1684         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1685         (generateHTMLContent): New helper function to generate big enough content.
1686         (testWebContextURIScheme): New unit test.
1687
1688 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1689
1690         [EFL] Fix unhandled web process message when launching MiniBrowser
1691         https://bugs.webkit.org/show_bug.cgi?id=152048
1692
1693         Reviewed by Gyuyoung Kim.
1694
1695         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1696         (TestWebKitAPI::TEST):
1697
1698 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1699
1700         [GTK] Add API to handle beforeunload events
1701         https://bugs.webkit.org/show_bug.cgi?id=139090
1702
1703         Reviewed by Gustavo Noronha Silva.
1704
1705         * MiniBrowser/gtk/BrowserWindow.c:
1706         (browserWindowConstructed):
1707         (browserWindowDeleteEvent):
1708         (browser_window_class_init):
1709         Handle delete-event to prevent the window from being closed when
1710         the page has beforeunload handlers. Use
1711         webkit_web_view_try_close() when the window is requested to be
1712         closed.
1713         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1714         (testWebViewJavaScriptDialogs):
1715         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1716         script dialog type.
1717
1718 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1719
1720         Refactored initialization code in LoadTrackingTest.
1721
1722         Rubber-stamped by Carlos Garcia Campos.
1723
1724         Small refactoring to make sure that the state of a LoadTrackingTest
1725         gets properly reset before loading new web content.
1726
1727         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1728         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1729         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1730         functions and reset the remaining local variables.
1731         (LoadTrackingTest::loadURI): Call reset();
1732         (LoadTrackingTest::loadHtml): Ditto.
1733         (LoadTrackingTest::loadPlainText): Ditto.
1734         (LoadTrackingTest::loadBytes): Ditto.
1735         (LoadTrackingTest::loadRequest): Ditto.
1736         (LoadTrackingTest::reload): Ditto.
1737         (LoadTrackingTest::goBack): Ditto.
1738         (LoadTrackingTest::goForward): Ditto.
1739
1740 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1741
1742         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1743         https://bugs.webkit.org/show_bug.cgi?id=151942
1744
1745         Reviewed by Darin Adler.
1746
1747         * MiniBrowser/efl/main.c:
1748         (window_create): Enable offline web application cache feature on MiniBrowser.
1749         (elm_main):
1750
1751 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1752
1753         https://bugs.webkit.org/show_bug.cgi?id=151243
1754         <rdar://problem/22955197>
1755
1756         Reviewed by Alexey Proskuryakov.
1757
1758         * LayoutTestRelay/LayoutTestRelay/main.m:
1759         (getTestingSimDevice): Use separate testing device for each worker.
1760         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1761         (Manager.run): Perform cleanup even if setup fails.
1762         * Scripts/webkitpy/port/ios.py:
1763         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1764         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1765         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1766         (IOSSimulatorPort._quit_ios_simulator): Same
1767         (IOSSimulatorPort.clean_up_test_run): Same
1768         (IOSSimulatorPort.check_sys_deps): Same
1769         (IOSSimulatorPort.testing_device): Same
1770         (IOSSimulatorPort.reset_preferences): Same
1771         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1772         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1773         * Scripts/webkitpy/xcode/simulator.py:
1774         (Device.delete): Delete the simulator device.
1775         (Simulator.delete_device): Same
1776         (Simulator.wait_until_device_is_booted): Wait for device booting.
1777
1778 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1779
1780         [EFL] Add API to provide preferences before creating ewk_view
1781         https://bugs.webkit.org/show_bug.cgi?id=151587
1782
1783         Reviewed by Gyuyoung Kim.
1784
1785         * MiniBrowser/efl/main.c:
1786         (on_key_down):
1787         (quit):
1788         (window_create):
1789         Moved settings related code to configuration() not to update settings
1790         whenever ewk_view is created.
1791         (configuration):
1792         (elm_main):
1793
1794 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1795
1796         Unreviewed. Fix GTK+ API tests after r193639.
1797
1798         The new jhbuild version needs some more variables ot be present in
1799         the builtin dict, even if they are set to None.
1800
1801         * jhbuild/jhbuildutils.py:
1802         (enter_jhbuild_environment_if_available):
1803
1804 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1805
1806         [GTK] Notify WebCore when notification is clicked
1807         https://bugs.webkit.org/show_bug.cgi?id=151951
1808
1809         Reviewed by Carlos Garcia Campos.
1810
1811         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1812         (testWebViewNotification): test the new API.
1813
1814 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1815
1816         'jhbuild build' should fail immediately when building any module fails
1817         https://bugs.webkit.org/show_bug.cgi?id=145697
1818
1819         Reviewed by Carlos Garcia Campos.
1820
1821         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1822         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1823         Everything is placed under lib instead of lib64 now.
1824         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1825         --exit-on-error when running 'jhbuild build'.
1826         * jhbuild/jhbuildrc_common.py:
1827         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1828         jhbuild should be able to handle these for us without breaking things....
1829
1830 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1831
1832         Add support to import w3c tests from a repository with a different root that the main repo dir
1833         https://bugs.webkit.org/show_bug.cgi?id=151751
1834
1835         Reviewed by Ryosuke Niwa and Youenn Fablet.
1836
1837         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1838         in a different directory than the repository root.
1839
1840         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1841         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1842         requires having the copy_path lists including tuples of origin and destination directories.
1843
1844         * Scripts/webkitpy/w3c/test_downloader.py:
1845         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1846         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1847         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1848         (TestImporterTest.test_tests_directory): Test.
1849
1850 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1851
1852         Mock TestRepositories in W3C importer tests
1853         https://bugs.webkit.org/show_bug.cgi?id=151938
1854
1855         Reviewed by Youenn Fablet.
1856
1857         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1858         is because the test repository method reading the file was using the filesystem directly instead of taking the
1859         host one. This patch changes that.
1860
1861         * Scripts/webkitpy/w3c/test_downloader.py:
1862         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1863         default one.
1864         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1865         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1866         (TestImporterTest.test_harnesslinks_conversion):
1867         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1868
1869 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1870
1871         TestNetscapePlugIn: Address review comment on 193607
1872         <http://webkit.org/b/151881>
1873
1874         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1875         (testSetStatus): Initializing std::unique_ptr<char[]> with
1876         nullptr is redundant.
1877
1878 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1879
1880         [GTK] Add webkit_uri_request_get_http_method
1881         https://bugs.webkit.org/show_bug.cgi?id=151601
1882
1883         Reviewed by Martin Robinson.
1884
1885         Add test case to check HTTP method of WebKitURIRequest.
1886
1887         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1888         (testURIRequestHTTPMethod):
1889         (serverCallback):
1890         (beforeAll):
1891         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1892         (sendRequestCallback):
1893
1894 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1895
1896         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1897         https://bugs.webkit.org/show_bug.cgi?id=79918
1898
1899         Reviewed by Gustavo Noronha Silva.
1900
1901         Add unit tests to check the different console messages.
1902
1903         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1904         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1905         (ConsoleMessageTest::ConsoleMessage::operator==):
1906         (ConsoleMessageTest::consoleMessageReceivedCallback):
1907         (ConsoleMessageTest::ConsoleMessageTest):
1908         (ConsoleMessageTest::~ConsoleMessageTest):
1909         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1910         (testWebKitConsoleMessageConsoleAPI):
1911         (testWebKitConsoleMessageJavaScriptException):
1912         (testWebKitConsoleMessageNetworkError):
1913         (testWebKitConsoleMessageSecurityError):
1914         (beforeAll):
1915         (afterAll):
1916         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1917         (consoleMessageSentCallback):
1918         (pageCreatedCallback):
1919
1920 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1921
1922         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1923         https://bugs.webkit.org/show_bug.cgi?id=151934
1924
1925         Reviewed by Csaba Osztrogonác.
1926
1927         * MiniBrowser/efl/main.c:
1928         (on_window_deletion): Revert the changes of r192767.
1929
1930 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1931
1932         [GTK] update-webkitgtk-libs cannot build mesa
1933         https://bugs.webkit.org/show_bug.cgi?id=151535
1934
1935         Reviewed by Martin Robinson.
1936
1937         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1938         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1939         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1940         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1941         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1942         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1943
1944         * gtk/jhbuild.modules:
1945
1946 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1947
1948         [GTK][Mac] libWebExtensionTest link error
1949         https://bugs.webkit.org/show_bug.cgi?id=150802
1950
1951         Reviewed by Carlos Garcia Campos.
1952
1953         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1954
1955 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1956
1957         TestNetscapePlugIn: Fix leaks found by static analyzer
1958         <http://webkit.org/b/151881>
1959
1960         Reviewed by Darin Adler.
1961
1962         Fixes the following leaks found by the static analyzer:
1963             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1964                     return false;
1965                            ^~~~~
1966             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1967                     return false;
1968                            ^~~~~
1969             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1970                     return false;
1971                            ^~~~~
1972
1973         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1974         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1975         early return if allocation fails.
1976         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1977         Make sure to call fclose() on filehandle, even for an early
1978         return.
1979         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1980
1981 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1982
1983         prepare-ChangeLog: Fix some warning messages when using svn
1984         <http://webkit.org/b/151914>
1985
1986         Reviewed by Daniel Bates.
1987
1988         * Scripts/prepare-ChangeLog:
1989         (generateFunctionLists): Simplify logic so that we never call
1990         normalizePath() with an undefined value.
1991         (attributeCommand): Quote $subPath for the shell so that we
1992         don't try to run "svn propget" on invalid paths.
1993
1994 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1995
1996         TestNetscapePlugIn: Fix remaining static analyzer warnings
1997         <http://webkit.org/b/151888>
1998
1999         Reviewed by Alexey Proskuryakov.
2000
2001         Fixes the following static analyzer warnings:
2002             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
2003                     CRASH();
2004                     ^~~~~~~
2005             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
2006                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
2007                 ^~~~~~~~~~~~~~~~
2008             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
2009                 return obj->pluginTest->NPP_SetWindow(window);
2010                        ^~~~~~~~~~~~~~~
2011             2 warnings generated.
2012
2013         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2014         (CRASH): Use __builtin_trap() for gcc/clang.
2015         (NPP_SetWindow): Add early return if obj is nullptr.
2016
2017 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2018
2019         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
2020         https://bugs.webkit.org/show_bug.cgi?id=151797
2021
2022         Reviewed by Martin Robinson.
2023
2024         Since we switched to use the network process to run the unit tests
2025         the test /webkit2/WebKitWebResource/get-data sometimes fails and
2026         sometimes passes. We are now also getting the notification for the
2027         css image. Since we wait for 3 resources, sometimes the css image
2028         is loaded before and then checkResourceData is called for it, but
2029         not handled. When the css image is the last one loaded the test
2030         passes. So, we just need to wait for the 4 resources.
2031
2032         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2033         (testWebResourceGetData):
2034
2035 2015-12-03  David Kilzer  <ddkilzer@apple.com>
2036
2037         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
2038         <http://webkit.org/b/151845>
2039
2040         Reviewed by Simon Fraser.
2041
2042         Fixes the following static analyzer warning:
2043             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
2044                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
2045                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2046
2047         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2048         (createBitmapContext): Free 'buffer' after using it in logging
2049         to fix the use-after-free.  Assign a value of nullptr to buffer
2050         so we don't return with it set to a freed address.
2051
2052 2015-12-03  Jer Noble  <jer.noble@apple.com>
2053
2054         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
2055         https://bugs.webkit.org/show_bug.cgi?id=151830
2056
2057         Reviewed by Anders Carlsson.
2058
2059         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
2060
2061         * DumpRenderTree/mac/DumpRenderTree.mm:
2062         (resetWebPreferencesToConsistentValues):
2063         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2064         (WTR::initializeWebViewConfiguration):
2065
2066 2015-12-03  Anders Carlsson  <andersca@apple.com>
2067
2068         Remove Objective-C GC support
2069         https://bugs.webkit.org/show_bug.cgi?id=151819
2070         rdar://problem/23746991
2071
2072         Reviewed by Dan Bernstein.
2073
2074         * asan/asan.xcconfig:
2075
2076 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2077
2078         Allow nil for unspecified benchmark pathes
2079         https://bugs.webkit.org/show_bug.cgi?id=151784
2080
2081         Reviewed by Filip Pizlo.
2082
2083         `Pathname.new(nil)` will raise an error.
2084         Only generate Pathname if the benchmark path is specified.
2085
2086         * Scripts/run-jsc-benchmarks:
2087
2088 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
2089
2090         [Win] Run non-http tests without Cygwin
2091         https://bugs.webkit.org/show_bug.cgi?id=151721
2092
2093         Reviewed by Andy Estes.
2094
2095         Support native 32-bit and 64-bit Python (and Perl) builds
2096         for running tests:
2097
2098         1. Use "startswith('win')", rather than "== 'win32'" to support
2099         various Windows build types.
2100         2. Supply full path for some native Windows utilities, since the
2101         path environment does not always have the specified, and they are
2102         guaranteed to exist in those specific locations.
2103         3. Make sure native Windows Python test runs pass proper environment
2104         variables to run programs.
2105         4. Append 'exe' suffix when running Windows executables.
2106         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
2107         command doesn't exist.
2108         
2109         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
2110         the current Perl executable, rather than requiring a new path search.
2111         * Scripts/webkitpy/common/find_files_unittest.py:
2112         (TestWinNormalize.test_win): Use startswith('win').
2113         * Scripts/webkitpy/common/prettypatch_unittest.py:
2114         (test_pretty_diff_encodings): Ditto.
2115         * Scripts/webkitpy/common/system/executive.py:
2116         (Executive._should_close_fds): Ditto.
2117         (Executive.shell_command_for_script): Use startswith('win').
2118         (Executive.kill_process): Use full path to killall executable.
2119         (Executive.check_running_pid): Use startswith('win').
2120         (Executive.running_pids): Ditto.
2121         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
2122         running under native Windows Python.
2123         (Executive._child_process_encoding): Use startswith('win').
2124         (Executive._should_encode_child_process_arguments): Ditto.
2125         (Executive.popen): Recognize proper script engine on Windows, since it
2126         does not support the shebang syntax.
2127         (Executive.run_in_parallel): Use startswith('win').
2128         * Scripts/webkitpy/common/system/executive_unittest.py:
2129         (never_ending_command): Ditto.
2130         (ExecutiveTest.test_run_command_with_unicode): Ditto.
2131         (ExecutiveTest.serial_test_kill_process): Ditto.
2132         (ExecutiveTest.serial_test_kill_all): Ditto.
2133         (ExecutiveTest.serial_test_check_running_pid): Ditto.
2134         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
2135         (main): Ditto.
2136         * Scripts/webkitpy/common/system/file_lock.py:
2137         (FileLock._create_lock): Ditto.
2138         (FileLock._remove_lock): Ditto.
2139         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2140         (RealFileSystemTest.test_chdir): Ditto.
2141         (RealFileSystemTest.test_chdir__notexists): Ditto.
2142         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
2143         * Scripts/webkitpy/common/system/path_unittest.py:
2144         (AbspathTest.test_abspath_to_uri_win): Ditto.
2145         * Scripts/webkitpy/common/system/platforminfo.py:
2146         (PlatformInfo._determine_os_name): Ditto.
2147         * Scripts/webkitpy/common/system/user.py: Ditto.
2148         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2149         (ManagerTest.integration_test_needs_servers): Ditto.
2150         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2151         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
2152         driver letters.
2153         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
2154         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2155         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
2156         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2157         (HttpServerBase._check_that_all_ports_are_available): Ditto.
2158         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2159         (TestHttpServer.test_start_cmd): Ditto.
2160         * Scripts/webkitpy/port/base.py:
2161         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
2162         and 'SYSTEMROOT' in environment passed to test runners.
2163         (Port._apache_config_file_name_for_platform): Use startswith('win').
2164         (Port._build_path): Ditto.
2165         (Port._path_to_driver): Include 'exe' suffix when running under native
2166         Windows.
2167         * Scripts/webkitpy/port/driver.py:
2168         (Driver._setup_environ_for_driver): Explicitly make some environment
2169         variables strings.
2170         * Scripts/webkitpy/port/server_process.py:
2171         (ServerProcess.__init__): Use startswith('win').
2172         * Scripts/webkitpy/port/win.py:
2173         (WinPort): Use the win32 registry utilities on Windows, and appropriate
2174         registry key formats.
2175         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
2176         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
2177         and regtool on Cygwin.
2178         (WinPort.write_registry_value): Ditto.
2179         (WinPort.setup_crash_log_saving): Ditto.
2180         (WinPort.restore_crash_log_saving): Ditto.
2181         (WinPort.prevent_error_dialogs): Ditto.
2182         (WinPort.allow_error_dialogs): Ditto.
2183         (WinPort.find_system_pid): Revise to use Windows management
2184         infrastructure on native Windows, continue using 'ps' on Cygwin.
2185         (WinPort.read_registry_string): Deleted.
2186         (WinPort.write_registry_string): Deleted.
2187         * Scripts/webkitpy/test/main.py:
2188         (main): Use startswith('win').
2189         (Tester._parse_args): Ditto.
2190
2191 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2192
2193         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2194         https://bugs.webkit.org/show_bug.cgi?id=150792
2195
2196         Reviewed by Saam Barati.
2197
2198         * Scripts/webkitperl/FeatureList.pm:
2199
2200 2015-12-01  Commit Queue  <commit-queue@webkit.org>
2201
2202         Unreviewed, rolling out r192914.
2203         https://bugs.webkit.org/show_bug.cgi?id=151734
2204
2205         JSC tests for this change are failing on 32 and 64-bit bots
2206         (Requested by ryanhaddad on #webkit).
2207
2208         Reverted changeset:
2209
2210         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
2211         enable this feature"
2212         https://bugs.webkit.org/show_bug.cgi?id=150792
2213         http://trac.webkit.org/changeset/192914
2214
2215 2015-12-01  David Kilzer  <ddkilzer@apple.com>
2216
2217         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
2218         <http://webkit.org/b/151726>
2219
2220         Reviewed by Simon Fraser.
2221
2222         * WebKitTestRunner/mac/EventSenderProxy.mm:
2223         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2224         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
2225
2226 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
2227
2228         Give String and AtomicString an existingHash() function
2229         https://bugs.webkit.org/show_bug.cgi?id=151717
2230
2231         Reviewed by Andreas Kling.
2232
2233         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2234         (TestWebKitAPI::TEST):
2235         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2236         (TestWebKitAPI::TEST):
2237
2238 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2239
2240         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2241         https://bugs.webkit.org/show_bug.cgi?id=150792
2242
2243         Reviewed by Saam Barati.
2244
2245         * Scripts/webkitperl/FeatureList.pm:
2246
2247 2015-12-01  Sam Weinig  <sam@webkit.org>
2248
2249         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2250         <rdar://problem/23320863>
2251         https://bugs.webkit.org/show_bug.cgi?id=151708
2252
2253         Reviewed by Anders Carlsson.
2254
2255         * WebKitTestRunner/TestController.cpp:
2256         (WTR::TestController::createOtherPage):
2257         (WTR::TestController::createWebViewWithOptions):
2258         Update for new WKPageUIClient.
2259
2260 2015-12-01  Anders Carlsson  <andersca@apple.com>
2261
2262         Remove WebKit2.framework
2263         https://bugs.webkit.org/show_bug.cgi?id=151715
2264
2265         Reviewed by Dan Bernstein.
2266
2267         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2268         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2269         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2270         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2271         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2272         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2273         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2274
2275 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2276
2277         Unreviewed common typo fix "occurance" => "occurrence".
2278
2279         * Scripts/webkitpy/tool/commands/queries.py:
2280         (FindFlakyTests._print_statistics):
2281
2282 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2283
2284         Make ProcessModel always MultipleSecondaryProcesses
2285         https://bugs.webkit.org/show_bug.cgi?id=151662
2286
2287         Reviewed by Antti Koivisto.
2288
2289         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2290         (TestWebKitAPI::TEST):
2291         * WebKitTestRunner/TestController.cpp:
2292         (WTR::TestController::generatePageConfiguration):
2293
2294 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2295
2296         Make usesNetworkProcess always true
2297         https://bugs.webkit.org/show_bug.cgi?id=151580
2298
2299         Reviewed by Darin Adler.
2300
2301         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2302         (TestWebKitAPI::TEST):
2303         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2304         (TestWebKitAPI::TEST):
2305         * WebKitTestRunner/TestController.cpp:
2306         (WTR::TestController::generatePageConfiguration):
2307
2308 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2309
2310         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2311
2312         Add a way to skip unit tests only for Debug or Release builds and
2313         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2314
2315         * Scripts/run-gtk-tests:
2316         (SkippedTest):
2317         (SkippedTest.__init__):
2318         (SkippedTest.__str__):
2319         (SkippedTest.skip_entire_suite):
2320         (SkippedTest.skip_for_build_type):
2321         (TestRunner):
2322         (TestRunner.__init__):
2323
2324 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2325
2326         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2327
2328         It's an assert hit because we are reloading a view loaded with
2329         HTML data which is not supported. Use loadURI instead.
2330
2331         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2332         (testWebViewCustomCharset):
2333
2334 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2335
2336         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2337         https://bugs.webkit.org/show_bug.cgi?id=151633
2338
2339         Reviewed by Csaba Osztrogonác.
2340
2341         * TestWebKitAPI/PlatformGTK.cmake:
2342         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2343
2344 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2345
2346         [GTK] Remove the remaining uses of GMainLoopSource
2347         https://bugs.webkit.org/show_bug.cgi?id=151632
2348
2349         Reviewed by Žan Doberšek.
2350
2351         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2352         (testWebViewSyncRequestOnMaxConns):
2353         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2354         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2355         (WTR::TestRunner::TestRunner):
2356         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2357         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2358         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2359         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2360         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2361         (WTR::timeoutSource):
2362         (WTR::TestController::notifyDone):
2363         (WTR::TestController::platformRunUntil):
2364
2365 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2366
2367         [cmake] Add testb3 to the build system
2368         https://bugs.webkit.org/show_bug.cgi?id=151619
2369
2370         Reviewed by Gyuyoung Kim.
2371
2372         * Scripts/build-jsc:
2373
2374 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2375
2376         [jhbuild] Fix pixman build with clang
2377         https://bugs.webkit.org/show_bug.cgi?id=151441
2378
2379         Reviewed by Carlos Garcia Campos.
2380
2381         * efl/jhbuild.modules:
2382         * gtk/jhbuild.modules:
2383
2384 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2385
2386         Extract prependToEnvironmentVariableList
2387         <http://webkit.org/b/151536>
2388
2389         Reviewed by Daniel Bates.
2390
2391         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2392                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2393
2394         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2395         and prependToEnvironmentVariableList.
2396         (appendToEnvironmentVariableList): Simplify variable name.
2397         Switch to use $Config{path_sep}.
2398         (prependToEnvironmentVariableList): Add new method.
2399         (setupMacWebKitEnvironment): Switch to use
2400         prependToEnvironmentVariableList().
2401         (setupIOSWebKitEnvironment): Ditto.
2402
2403         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2404         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2405
2406 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2407
2408         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2409         https://bugs.webkit.org/show_bug.cgi?id=151567
2410
2411         Reviewed by Darin Adler.
2412
2413         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2414         (on_window_deletion):
2415
2416 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2417
2418         [GTK] Use the network process unconditionally
2419         https://bugs.webkit.org/show_bug.cgi?id=151541
2420
2421         Reviewed by Alex Christensen.
2422
2423         Fix TestInspectorServer test. Do not assume we already have the
2424         title we want when the page has been loaded, since the title is
2425         changed afterwards. So, check if the title has already been set,
2426         and if not wait for it.
2427
2428         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2429         (openRemoteDebuggingSession):
2430
2431 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2432
2433         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2434         https://bugs.webkit.org/show_bug.cgi?id=151532
2435
2436         Reviewed by Benjamin Poulain.
2437
2438         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2439         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2440         (TestWebKitAPI::TEST):
2441         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2442         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2443         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2444         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2445         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2446         so it was calling a function on a test object that had gone out of scope.
2447         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2448         but that will become the default soon and that call will be removed.
2449
2450 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2451
2452         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2453         <http://webkit.org/b/151542>
2454
2455         Reviewed by Daniel Bates.
2456
2457         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2458         (base_url): Use the Port object (already passed in) to give us
2459         the path to the LayoutTests directory, which already checks for a
2460         --layout-tests-directory command-line switch.
2461         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2462         argument since we can get this from the Port object already
2463         passed in via Port.results_directory().  Also switch to use
2464         Port.layout_tests_dir() to get the LayoutTests directory.
2465
2466         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2467         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2468         Add test case for custom LayoutTests directory.
2469         (TestWebPlatformTestServer.test_previously_spawned_instance):
2470         Update Port object to set mock results directory as if it was
2471         set on the command-line.  Remove unneeded argument from
2472         WebPlatformTestServer constructor.
2473         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2474
2475         * Scripts/webkitpy/port/base.py:
2476         (Port.to.start_web_platform_test_server): Remove unneeded
2477         argument from WebPlatformTestServer constuctor.
2478
2479 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2480
2481         [GTK] Some unit tests fail when using the network process
2482         https://bugs.webkit.org/show_bug.cgi?id=151490
2483
2484         Reviewed by Martin Robinson.
2485
2486         Run the soup server in a separate thread in TestResources test to
2487         avoid deadlocks.
2488
2489         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2490         /webkit2/WebKitWebResource/get-data when using the network process.
2491
2492         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2493         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2494         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2495         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2496         present, create a WorkQueue to run the server.
2497         (WebKitTestServer::run): Run the server in the work queue if it
2498         has been created.
2499         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2500         type into server options as flags.
2501
2502 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2503
2504         [GTK] ImageDiff should normalize the diff image
2505         https://bugs.webkit.org/show_bug.cgi?id=151261
2506
2507         Reviewed by Sergio Villar Senin.
2508
2509         * ImageDiff/gtk/ImageDiff.cpp:
2510         (readPixbufFromStdin): Fix memory leak.
2511         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2512         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2513
2514 == Rolled over to ChangeLog-2015-11-21 ==