a8bf5854bcb9c3c2a2c5b9b0165761369e3bc5fa
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
2
3         Support new TestExpectations format alongside old one
4         https://bugs.webkit.org/show_bug.cgi?id=96588
5
6         Reviewed by Ojan Vafai.
7
8         This patch adds support for actually reading in lines formatted
9         in the new style, and when we re-serialize/write out the file,
10         all lines will be written in the new style. Note that reading in
11         the old style is still supported, and no updates are being made
12         to the actual TestExpectations files as part of this change.
13
14         This change updates most but not all of the unit tests to use
15         the new syntax. I will update the rest when (or before where
16         possible) I drop support for the old format.
17
18         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
19         (TestExpectationParser):
20         (TestExpectationParser._tokenize_line):
21         (TestExpectationParser._tokenize_line_using_new_format):
22         (TestExpectationLine.to_string):
23         (TestExpectationLine._format_line):
24         (TestExpectations):
25         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
26         (test_parse_warning):
27         (SkippedTests.test_skipped_entry_dont_exist):
28         (NewExpectationSyntaxTests.test_warnings):
29         (RemoveConfigurationsTest.test_remove):
30         (test_remove_line):
31         (RebaseliningTest.test_remove):
32         (RebaseliningTest.test_no_get_rebaselining_failures):
33         (TestExpectationParserTests.test_tokenize_blank):
34         (TestExpectationParserTests.test_tokenize_extra_colon):
35         (TestExpectationParserTests.test_tokenize_missing_equal):
36         (TestExpectationParserTests.test_tokenize_extra_equal):
37         (TestExpectationSerializationTests.test_unparsed_to_string):
38         (TestExpectationSerializationTests.test_unparsed_list_to_string):
39         (TestExpectationSerializationTests.test_parsed_to_string):
40         (TestExpectationSerializationTests.test_format_line):
41         (TestExpectationSerializationTests.test_string_roundtrip):
42         (TestExpectationSerializationTests.test_list_roundtrip):
43         (TestExpectationSerializationTests.test_reconstitute_only_these):
44         (TestExpectationSerializationTests.test_string_whitespace_stripping):
45         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
46         (LintTest.test_lint_test_files__errors):
47         * Scripts/webkitpy/tool/commands/queries_unittest.py:
48         (PrintExpectationsTest.test_basic):
49         (PrintExpectationsTest.test_multiple):
50         (PrintExpectationsTest.test_full):
51         (PrintExpectationsTest.test_exclude):
52         * Scripts/webkitpy/tool/commands/rebaseline.py:
53         (RebaselineExpectations.execute):
54         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
55         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
56         (test_rebaseline_updates_expectations_file):
57         (test_rebaseline_does_not_include_overrides):
58         (test_rebaseline_expectations_noop):
59         (test_overrides_are_included_correctly):
60
61 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
62
63         implement first part of support for the new TestExpectations syntax
64         https://bugs.webkit.org/show_bug.cgi?id=96569
65
66         Reviewed by Ryosuke Niwa.
67
68         This patch implements support for parsing a line of the new
69         format for the TestExpectations file and converting it back into
70         the old format for compatibility. This routine is not yet used
71         by anything.
72
73         The new format is documented at:
74           http://trac.webkit.org/wiki/TestExpectations
75
76         but, in short:
77
78           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
79
80         - Comments are indicated with "#" instead of "//"
81         - If no expectations are specified we default to Skip for
82           compatibility with the Skipped files (these two changes make
83           Skipped files a subset of TestExpectations files)
84
85         - All of the tokens are now CamelCase instead of ALLCAPS.
86         - FAIL -> Failure
87         - IMAGE -> ImageOnlyFailure
88         - WONTFIX -> WontFix
89         - modifiers refer to just the platforms and configurations
90           (release/debug) that the line applies to.
91         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
92           expectations
93         - expectations will typically be written out in lexicographic order
94         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
95           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
96
97         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
98         (TestExpectationParser):
99         (TestExpectationParser._tokenize_line_using_new_format):
100         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
101         (NewExpectationSyntaxTests):
102         (NewExpectationSyntaxTests.assert_exp):
103         (NewExpectationSyntaxTests.test_bare_name):
104         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
105         (NewExpectationSyntaxTests.test_comments):
106         (NewExpectationSyntaxTests.test_config_modifiers):
107         (NewExpectationSyntaxTests.test_unknown_config):
108         (NewExpectationSyntaxTests.test_unknown_expectation):
109         (NewExpectationSyntaxTests.test_skip):
110         (NewExpectationSyntaxTests.test_slow):
111         (NewExpectationSyntaxTests.test_wontfix):
112         (NewExpectationSyntaxTests.test_blank_line):
113         (NewExpectationSyntaxTests.test_warnings):
114
115 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
116
117         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
118         https://bugs.webkit.org/show_bug.cgi?id=96845
119
120         Reviewed by Ojan Vafai.
121
122         In preparation for the new TestExpectations syntax, we replace
123         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
124         make switching to the new syntax lossless (i.e., we lose
125         information now, not then).
126
127         Note that we can still parse in results.json files that have the
128         old data for backwards compatibility.
129         
130
131         * Scripts/webkitpy/common/net/resultsjsonparser.py:
132         (JSONTestResult._failure_types_from_actual_result):
133         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
134         (ResultsJSONParserTest):
135         (test_basic):
136         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
137         (ResultSummaryTest.test_summarized_results_wontfix):
138         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
139         (JSONLayoutResultsGenerator):
140         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
141         (TestExpectations):
142         (TestExpectations.remove_pixel_failures):
143         (TestExpectations.has_pixel_failures):
144         (TestExpectations.suffixes_for_expectations):
145         (TestExpectations.get_rebaselining_failures):
146         (TestExpectations.remove_configuration_from_test):
147         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
148         (assert_bad_expectations):
149         (BasicTests):
150         (BasicTests.test_basic):
151         (MiscTests):
152         (MiscTests.test_multiple_results):
153         (MiscTests.test_result_was_expected):
154         (MiscTests.test_remove_pixel_failures):
155         (MiscTests.test_suffixes_for_expectations):
156         (test_get_expectations_string):
157         (test_parse_warning):
158         (test_error_on_different_platform):
159         (test_error_on_different_build_type):
160         (test_overrides):
161         (test_overrides__directory):
162         (test_overrides__duplicate):
163         (test_pixel_tests_flag):
164         (test_more_specific_override_resets_skip):
165         (SkippedTests.test_skipped_file_overrides_expectations):
166         (SkippedTests.test_skipped_dir_overrides_expectations):
167         (SkippedTests.test_skipped_file_overrides_overrides):
168         (SkippedTests.test_skipped_dir_overrides_overrides):
169         (ExpectationSyntaxTests.test_missing_colon):
170         (ExpectationSyntaxTests.test_too_many_equals_signs):
171         (SemanticTests.test_bug_format):
172         (SemanticTests.test_bad_bugid):
173         (SemanticTests.test_missing_bugid):
174         (SemanticTests.test_rebaseline):
175         (test_missing_file):
176         (test_more_modifiers):
177         (test_order_in_file):
178         (test_macro_overrides):
179         (RemoveConfigurationsTest.test_remove):
180         (test_remove_line):
181         (RebaseliningTest.test_remove):
182         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
183         * Scripts/webkitpy/layout_tests/models/test_failures.py:
184         (determine_result_type):
185         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
186         (test_test_expectations):
187         * Scripts/webkitpy/layout_tests/port/test.py:
188         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
189         (MainTest.test_missing_and_unexpected_results):
190         (MainTest.test_retrying_and_flaky_tests):
191         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
192         (TestExpectationsTestCase.test_valid_expectations):
193         * Scripts/webkitpy/tool/commands/queries_unittest.py:
194         (PrintExpectationsTest.test_basic):
195         (PrintExpectationsTest.test_multiple):
196         (PrintExpectationsTest.test_full):
197         (PrintExpectationsTest.test_exclude):
198         (PrintExpectationsTest.test_csv):
199         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
200         (test_rebaseline_does_not_include_overrides):
201         (test_overrides_are_included_correctly):
202
203 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
204
205         AX: A few control types are returning the wrong answer for isReadOnly
206         https://bugs.webkit.org/show_bug.cgi?id=96735
207
208         Reviewed by Chris Fleizach.
209
210         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
211
212         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
213         (AccessibilityUIElement::AccessibilityUIElement):
214         (AccessibilityUIElement::isReadOnlyGetterCallback):
215         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
216         (AccessibilityUIElement):
217
218 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
219
220         [WTR] Memory leaks in TestRunner::deliverWebIntent()
221         https://bugs.webkit.org/show_bug.cgi?id=97111
222
223         Reviewed by Kenneth Rohde Christiansen.
224
225         Fix memory leaks in deliverWebIntent() by adopting strings
226         created with WKStringCreateWithUTF8CString().
227
228         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
229         (WTR::TestRunner::deliverWebIntent):
230
231 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
232
233         [Qt] Fix incremental builds with all-in-one-files and gccdepends
234
235         Reviewed by Tor Arne Vestbø.
236
237         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
238         are not only created for header files but also for .cpp files. AllInOne.cpp files
239         include other .cpp files, and when those are removed we need those dummy rules to
240         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
241
242         * qmake/config.tests/gccdepends/empty.cpp:
243         (main):
244         * qmake/config.tests/gccdepends/gccdepends.pro:
245         * qmake/mkspecs/features/default_pre.prf:
246
247 2012-09-19  Rick Byers  <rbyers@chromium.org>
248
249         Do touch adjustment on GestureTapDown
250         https://bugs.webkit.org/show_bug.cgi?id=96677
251
252         Reviewed by Antonio Gomes.
253
254         Allow radius to be set for GestureTapDown events.
255         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
256         (EventSender::gestureEvent):
257
258 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
259
260         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
261         https://bugs.webkit.org/show_bug.cgi?id=97100
262
263         Reviewed by Gyuyoung Kim.
264
265         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
266         preference, in order to match WebKitTestRunner functionality.
267
268         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
269         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
270         * DumpRenderTree/efl/TestRunnerEfl.cpp:
271         (TestRunner::overridePreference):
272
273 2012-09-18  Kangil Han  <kangil.han@samsung.com>
274
275         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
276         https://bugs.webkit.org/show_bug.cgi?id=96181
277
278         Reviewed by Daniel Bates.
279
280         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
281
282         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
283         (new):
284         (_parseLicenseBlock):
285         (_parseLicenseBlockFromFile):
286         (_defaultLicenseBlock):
287         (_licenseBlock):
288         (_generateHeaderFile):
289         (_generateImplementationFile):
290
291 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
292
293         Title string should be changed when document.title is set to ''.
294         https://bugs.webkit.org/show_bug.cgi?id=96793
295
296         Reviewed by Kenneth Rohde Christiansen.
297
298         Change dump format of dumpTitleChanges more understandable.
299         Uses single quotation marks for the title string.
300
301         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
302         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
303         * DumpRenderTree/chromium/WebViewHost.cpp:
304         (WebViewHost::didReceiveTitle):
305         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
306         (DumpRenderTreeChrome::onFrameTitleChanged):
307         * DumpRenderTree/gtk/DumpRenderTree.cpp:
308         (webViewTitleChanged):
309         * DumpRenderTree/mac/FrameLoadDelegate.mm:
310         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
311         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
312         (WebCore::DumpRenderTree::titleChanged):
313         * DumpRenderTree/win/FrameLoadDelegate.cpp:
314         (FrameLoadDelegate::didReceiveTitle):
315         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
316         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
317         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
318         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
319
320 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
321
322         EWS shouldn't sleep if there are new patches in its queue
323         https://bugs.webkit.org/show_bug.cgi?id=83038
324
325         Reviewed by Eric Seidel.
326
327         EWS tries to process a security patch. Of course it can't, because the EWS isn't
328         the member of the security group. But the problem is that after it can't process
329         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
330         and push the security patch to the end of the queue.
331         Now it stays in the loop until it finds a patch or the queue gets empty.
332
333         * Scripts/webkitpy/tool/commands/queues.py:
334         (AbstractPatchQueue._next_patch):
335         * Scripts/webkitpy/tool/commands/queues_unittest.py:
336         (AbstractPatchQueueTest.test_next_patch):
337
338 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
339
340         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
341         https://bugs.webkit.org/show_bug.cgi?id=97014
342
343         Reviewed by Kenneth Rohde Christiansen.
344
345         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
346         be used for literals rather than WTF::StringBuilder::append().
347
348         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
349         (WTR::InjectedBundle::booleanForKey):
350
351 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
352
353         Update my e-mail address.
354
355         * Scripts/webkitpy/common/config/committers.py:
356
357 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
358
359         Update my e-mail address.
360
361         Unreviewed.
362
363         * Scripts/webkitpy/common/config/committers.py:
364
365 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
366
367         [Qt] qt_webkit.pri should not be listed in Tools.pro
368
369         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
370
371         Since r128751 the module pri file is auto-generated
372         but it was still listed in OTHER_FILES.
373
374         * Tools.pro: Remove unneeded line.
375
376 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
377
378         [Qt] Fix build with some versions of the gold linker
379
380         Reviewed by Tor Arne Vestbø.
381
382         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
383         Instead run a compile/link test first to see if it works.
384
385         * qmake/config.tests/gnuld/gnuld.pro: Added.
386         * qmake/config.tests/gnuld/main.cpp: Added.
387         (main):
388         * qmake/mkspecs/features/unix/default_post.prf:
389
390 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
391
392         [Qt] Remove forced use of gold.
393
394         Reviewed by Tor Arne Vestbø.
395
396         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
397         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
398         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
399
400         * qmake/mkspecs/features/unix/default_post.prf:
401
402 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
403
404         [Qt] Prospective Qt/Windows cross-compiling fix
405
406         Reviewed by Tor Arne Vestbø.
407
408         The win32 scope is not set when cross-compiling from Linux to Windows.
409
410         * qmake/mkspecs/features/functions.prf:
411
412 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
413
414         [EFL] Remove background view on EWebLauncher and MiniBrowser
415         https://bugs.webkit.org/show_bug.cgi?id=96905
416
417         Reviewed by Gyuyoung Kim.
418
419         The size of webview was changed after adding url bar.
420         And the background view is not necessary anymore, since it was used for debugging back in the day.
421
422         * EWebLauncher/main.c:
423         (_ELauncher):
424         (on_ecore_evas_resize):
425         (browserCreate):
426         * MiniBrowser/efl/main.c:
427         (_MiniBrowser):
428         (on_ecore_evas_resize):
429         (browserCreate):
430
431 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
432
433         [GTK] run-webkit-tests unable to find TestExpectations for WK2
434         https://bugs.webkit.org/show_bug.cgi?id=96998
435
436         Reviewed by Philippe Normand.
437
438         We should look for TestExpectations files in all the locations where
439         we currently look for Skipped files. This will allow
440         run-webkit-tests to look for TestExpectations files in
441         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
442
443         * Scripts/webkitpy/layout_tests/port/gtk.py:
444         (GtkPort.expectations_files):
445
446 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
447
448         [Qt] Fix build without the QtQuick module
449
450         Reviewed by Simon Hausmann.
451
452         * qmake/mkspecs/features/features.prf:
453
454 2012-09-18  Stephanie Lewis  <slewis@apple.com>
455
456         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
457
458         Unreviewed.
459
460         * DumpRenderTree/mac/DumpRenderTree.mm:
461         (poseAsClass):
462
463 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
464
465         Unreviewed update of email addresses for Berlin QtWebKit office.
466
467         * Scripts/webkitpy/common/config/committers.py:
468
469 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
470
471         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
472         https://bugs.webkit.org/show_bug.cgi?id=96899
473
474         Reviewed by Martin Robinson.
475
476         When overriding the 'WebKitDisplayImageKey' preference, use the
477         'auto-load-images' property of WebKitWebSettings as the property which
478         should be updated with the corresponding preference value.
479
480         * DumpRenderTree/gtk/DumpRenderTree.cpp:
481         (resetDefaultsToConsistentValues):
482         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
483         (TestRunner::overridePreference):
484
485 2012-09-17  Pratik Solanki  <psolanki@apple.com>
486
487         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
488         https://bugs.webkit.org/show_bug.cgi?id=96973
489
490         Reviewed by Dan Bernstein.
491
492         * DumpRenderTree/mac/Configurations/Base.xcconfig:
493         * WebKitTestRunner/Configurations/Base.xcconfig:
494         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
495
496 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
497
498         nrwt: remove "unexpected EOF" warnings
499         https://bugs.webkit.org/show_bug.cgi?id=96970
500
501         Reviewed by Ojan Vafai.
502
503         After debugging this a bit, it looks like there aren't any cases
504         that I can reproduce where a read() of zero indicates something
505         actually wrong; either it is a prelude to a crash, or a false
506         negative. So, I'm removing these warnings and adding a comment.
507
508         * Scripts/webkitpy/layout_tests/port/server_process.py:
509         (ServerProcess._wait_for_data_and_update_buffers_using_select):
510
511 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
512
513         [chromium] ASAN bot is crashing at the end of the run
514         https://bugs.webkit.org/show_bug.cgi?id=96967
515
516         Reviewed by Abhishek Arya.
517
518         The ASAN bot is crashing attempting to decode some output into
519         UTF-8; there's no reason to do this, so let's not do this and
520         see if something else is going on as well.
521
522         * Scripts/webkitpy/layout_tests/port/chromium.py:
523         (ChromiumPort._get_crash_log):
524
525 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
526
527         nrwt: --results-directory isn't getting printed properly
528         https://bugs.webkit.org/show_bug.cgi?id=96965
529
530         Reviewed by Ojan Vafai.
531
532         options.results_directory isn't actually initialized with the
533         default values until after we call print_config(), so this
534         changes things to print the value directly.
535
536         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
537         (run):
538         * Scripts/webkitpy/layout_tests/views/printing.py:
539         (Printer.print_config):
540         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
541         (Testprinter.test_print_config):
542
543 2012-09-17  Rob Buis  <rbuis@rim.com>
544
545         [BlackBerry] Enable VIDEO_TRACK
546         https://bugs.webkit.org/show_bug.cgi?id=96949
547
548         Reviewed by Antonio Gomes.
549
550         * Scripts/webkitperl/FeatureList.pm:
551
552 2012-09-17  Rick Byers  <rbyers@chromium.org>
553
554         Add handling of new GestureTapCancel in DRT
555
556         https://bugs.webkit.org/show_bug.cgi?id=96183
557
558         Reviewed by Antonio Gomes.
559
560         * DumpRenderTree/chromium/TestWebPlugin.cpp:
561         (TestWebPlugin::handleInputEvent):
562         * DumpRenderTree/chromium/EventSender.cpp:
563         (EventSender::gestureTapCancel):
564
565 2012-09-17  Philip Rogers  <pdr@google.com>
566
567         Teach style checker about preprocessor directive indentation rules
568         https://bugs.webkit.org/show_bug.cgi?id=96874
569
570         Reviewed by Adam Barth.
571
572         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
573         This is not explicit in our style guide but is generally followed in our code.
574         Searching for violations in our codebase shows these are rarely indented:
575             #include - indented in 6 files
576             #ifdef - indented in 0 files
577             #ifndef - indented in 1 file
578             #define - indented in 11 files
579             #if - indented in 7 files
580
581         * Scripts/webkitpy/style/checkers/cpp.py:
582         (check_directive_indentation):
583
584             This is the simple test where we look for spaces followed by a #.
585
586         (check_style):
587         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
588
589             A few tests needed to be modified because they had unintentionally indented
590             preprocessor directives.
591
592         (CppStyleTest.test_build_class.Foo):
593         (CppStyleTest.test_build_class):
594         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
595         (WebKitStyleTest.test_line_breaking):
596         (WebKitStyleTest.test_directive_indentation):
597
598 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
599
600         [Qt] Auto-generate the module pri file for QtWebKit
601
602         Reviewed by Simon Hausmann.
603
604         * qmake/qt_webkit.pri: Removed.
605
606 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
607
608         nrwt: --additional-platform-dir is broken on chromium ports
609         https://bugs.webkit.org/show_bug.cgi?id=96840
610
611         Reviewed by Ojan Vafai.
612
613         Looks like I broke this when cleaning things up as part of
614         adding ML support. Fixing and adding a test.
615
616         * Scripts/webkitpy/layout_tests/port/chromium.py:
617         (ChromiumPort.default_baseline_search_path):
618         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
619         (ChromiumAndroidPort.default_baseline_search_path):
620         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
621         (ChromiumLinuxPort.default_baseline_search_path):
622         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
623         (ChromiumMacPort.__init__):
624         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
625         (ChromiumWinPort.setup_environ_for_server):
626         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
627         (test_check_build):
628         (test_additional_platform_directory):
629
630 2012-09-13  Stephanie Lewis  <slewis@apple.com>
631
632         mac-future ignores previous platform TestExpectations.
633         https://bugs.webkit.org/show_bug.cgi?id=96718.
634
635         Reviewed by Dirk Pranke.
636
637         TestExpectations match an expectation's configuraton against a list of configurations that are 
638         valid for that port.  That list does not contain mac-future so none of the expectations can be
639         applied.
640
641         * Scripts/webkitpy/layout_tests/port/apple.py:
642         (ApplePort._generate_all_test_configurations):
643
644 2012-09-14  Adam Barth  <abarth@webkit.org>
645
646         Remove webkitPostMessage
647         https://bugs.webkit.org/show_bug.cgi?id=96577
648
649         Reviewed by Ojan Vafai.
650
651         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
652
653         * Scripts/webkitperl/FeatureList.pm:
654         * qmake/mkspecs/features/features.pri:
655
656 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
657
658         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
659         https://bugs.webkit.org/show_bug.cgi?id=96817
660
661         Reviewed by Kenneth Rohde Christiansen.
662
663         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
664         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
665         got overlooked when adding logging elsewhere.
666
667 2012-09-14  Peter Beverloo  <peter@chromium.org>
668
669         [Chromium] Build fix for DumpRenderTree following r128628
670         https://bugs.webkit.org/show_bug.cgi?id=96808
671
672         Reviewed by Tony Chang.
673
674         When building DumpRenderTree from the Chromium project, a compile error
675         shows up because including the header ForwardIOStreamsAndroid.h cannot
676         be located. TestWebKitAPI does this correctly.
677
678         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
679
680 2012-09-14  Dana Jansens  <danakj@chromium.org>
681
682         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
683         https://bugs.webkit.org/show_bug.cgi?id=96805
684
685         Reviewed by Dirk Pranke.
686
687         * Scripts/webkitpy/common/config/committers.py:
688         * Scripts/webkitpy/common/config/watchlist:
689
690 2012-09-14  Peter Beverloo  <peter@chromium.org>
691
692         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
693         https://bugs.webkit.org/show_bug.cgi?id=96687
694
695         Reviewed by Tony Chang.
696
697         Android's DumpRenderTree currently supports these arguments, implemented
698         as part of TestShellAndroid:
699         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
700
701         They're used by the layout test runner to get the STDOUT and STDERR while
702         a layout test run is in process, which is a safer alternative to parsing
703         all the logcat output manually. The implementation can be seen here:
704         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
705
706         This patch generalizes parsing of and applying the effects of these arguments
707         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
708         After this patch, this will make it possible to pull out the output-reading
709         code from Android's layout test port and generalize it so it can be re-used
710         in the new test-runner for the other two test suites.
711
712         This has no effect when compiling and running these tests as part of Chromium
713         code, which has a much more advanced test-runner that does parse complete log
714         output, but also directly depends on code licensed under Apache 2.
715
716         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
717         * DumpRenderTree/chromium/TestShellAndroid.cpp:
718         (platformInit):
719         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
720
721 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
722
723         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
724         https://bugs.webkit.org/show_bug.cgi?id=96656
725
726         Reviewed by Adam Barth.
727
728         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
729         macros in 1 line.
730
731         * Scripts/webkitpy/style/checkers/cpp.py:
732         (check_style.definitions):
733         (check_style): Add rule.
734         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
735         (WebKitStyleTest.test_line_breaking): Add unittest.
736
737 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
738
739         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
740         https://bugs.webkit.org/show_bug.cgi?id=57570
741
742         Reviewed by Kenneth Rohde Christiansen.
743
744         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
745         and dump the information expected by the test cases.
746
747         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
748         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
749         (WTR::InjectedBundle::beginTesting): Explicitly set the default
750         database quota.
751         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
752         (WTR::securityOriginToStr): New convenience function to convert
753         a security origin to the string expected in test results.
754         (WTR):
755         (WTR::InjectedBundlePage::InjectedBundlePage):
756         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
757         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
758         refactoring to share code with didExceedDatabaseQuota.
759         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
760         (InjectedBundlePage):
761         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
762         (WTR::TestRunner::TestRunner):
763         * WebKitTestRunner/InjectedBundle/TestRunner.h:
764         (WTR::TestRunner::dumpDatabaseCallbacks):
765         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
766         (TestRunner):
767
768 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
769
770         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
771
772         Rubber-stamped by Simon Hausmann.
773
774         * qmake/mkspecs/features/default_post.prf:
775
776 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
777
778         [Qt] Remove old cruft from the qmake build system
779
780         Rubber-stamped by Simon Hausmann.
781
782         * DumpRenderTree/qt/DumpRenderTree.pro:
783         * qmake/mkspecs/features/default_post.prf:
784
785 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
786
787         [Qt] Enable force_static_libs_as_shared for development
788
789         Not enabled for buildbots or production-builds (part of Qt5)
790
791         Reviewed by Simon Hausmann.
792
793         * qmake/mkspecs/features/default_post.prf:
794
795 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
796
797         [Qt] Make force_static_libs_as_shared work on Mac OS
798
799         We had to move a few LIBS += around that were in the wrong place,
800         and not caught when everything was just linked into the final
801         QtWebKit library.
802
803         Reviewed by Simon Hausmann.
804
805         * qmake/mkspecs/features/default_post.prf:
806         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
807
808 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
809
810         [Qt] Fix build of WTR on Windows
811
812         Reviewed by Tor Arne Vestbø.
813
814         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
815         With qmake's unix makefile generator as well as with the MingW generator,
816         the directory where the pro file lives (WTR/) is automatically added to
817         the include search path, but not so with MSVC. Instead of relying on qmake's
818         implicit feature here, add WTR/ explicitly to the include search path.
819
820         * WebKitTestRunner/Target.pri:
821
822 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
823
824         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
825         https://bugs.webkit.org/show_bug.cgi?id=42691
826
827         Reviewed by Kenneth Rohde Christiansen.
828
829         Add implementation for testrunner.setStopProvisionalFrameLoads()
830         in WebKitTestRunner.
831
832         Original patch by Alexey Proskuryakov.
833
834         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
835         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
836         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
837         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
838         (WTR::TestRunner::TestRunner):
839         * WebKitTestRunner/InjectedBundle/TestRunner.h:
840         (TestRunner):
841         (WTR::TestRunner::setStopProvisionalFrameLoads):
842         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
843
844 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
845
846         [Qt] Fix handling of debug/release/debug_and_release/build_all
847
848         We now pick up the defaults from Qt, in default_pre (CONFIG already
849         contains the appropriate values for debug and release). We then let
850         the command line arguments to qmake, or the project files themselves,
851         override the configuration, and finally we sanitize the configuration
852         in default_post.
853
854         Reviewed by Simon Hausmann.
855
856         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
857         * Scripts/webkitdirs.pm:
858         (buildQMakeProjects):
859         * qmake/mkspecs/features/default_post.prf:
860         * qmake/mkspecs/features/default_pre.prf:
861         * qmake/mkspecs/features/mac/default_pre.prf:
862
863 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
864
865         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
866         https://bugs.webkit.org/show_bug.cgi?id=42687
867
868         Reviewed by Kenneth Rohde Christiansen.
869
870         Implement testRunner.setTabKeyCyclesThroughElements for
871         WebKitTestRunner.
872
873         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
874         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
875         (WTR::InjectedBundle::beginTesting):
876         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
877         (WTR::TestRunner::setTabKeyCyclesThroughElements):
878         (WTR):
879         * WebKitTestRunner/InjectedBundle/TestRunner.h:
880         (TestRunner):
881
882 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
883
884         EventSendingController::keyDown does not support non-array modifier arguments
885         https://bugs.webkit.org/show_bug.cgi?id=96727
886
887         Reviewed by Kenneth Rohde Christiansen.
888
889         Add support for handling a string as modifier argument to
890         EventSendingController::keyDown.
891
892         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
893         (WTR::parseModifierArray):
894
895 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
896
897         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
898         https://bugs.webkit.org/show_bug.cgi?id=42546
899
900         Reviewed by Kenneth Rohde Christiansen.
901
902         Exported TestRunner::setCustomPolicyDelegate() method.
903         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
904
905         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
906         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
907         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
908
909 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
910
911         [GTK] Clear application cache between tests in DumpRenderTree
912         https://bugs.webkit.org/show_bug.cgi?id=96543
913
914         Reviewed by Philippe Normand.
915
916         Call the new DumpRenderTreeSupportGtk method to clear application cache
917         after each test in DumpRenderTree.
918
919         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
920         as well. It's now being set in XvfbDriver._start so that each driver is assigned
921         a cache directory that's constructed out of the driver's name and its worker
922         number. These directories are located in the layout tests results directory.
923         At least on the builders this ensures a driver-specific empty cache directory
924         with each test run.
925
926         * DumpRenderTree/gtk/DumpRenderTree.cpp:
927         (runTest):
928         * Scripts/webkitpy/layout_tests/port/gtk.py:
929         (GtkPort.setup_environ_for_server):
930         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
931         (XvfbDriver._start):
932
933 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
934
935         [Qt] Fix linking on Windows
936
937         Reviewed by Tor Arne Vestbø.
938
939         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
940         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
941         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
942         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
943
944         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
945         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
946         after the module. Therefore QT did never contain webkit anymore and we always passed
947         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
948
949         This patch introduces a creating_module configuration that is used to
950         scope the qt/pkgconfig sanitization.
951
952         * qmake/mkspecs/features/default_post.prf:
953
954 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
955
956         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
957         https://bugs.webkit.org/show_bug.cgi?id=96740
958
959         Reviewed by Kenneth Rohde Christiansen.
960
961         Dump information expected by the test cases about the following
962         frame load callbacks:
963         "didDisplayInsecureContentForFrame"
964         "didRunInsecureContentForFrame"
965         "didDetectXSSForFrame"
966
967         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
968         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
969         as expected by test results by calling pathSuitableForTestResult() instead
970         of printing raw URL.
971         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
972         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
973         (WTR::InjectedBundlePage::didDetectXSSForFrame):
974
975 2012-09-14  Peter Beverloo  <peter@chromium.org>
976
977         The runtime/unsigned category should be valid in the cpp style-checker.
978         https://bugs.webkit.org/show_bug.cgi?id=96748
979
980         Reviewed by Csaba Osztrogonác.
981
982         This is causing the webkitpy tests to fail because it's not listed in the
983         category array. Furthermore, change an "int" to "long" because it's
984         throwing a double error in one of the earlier asserts.
985
986         * Scripts/webkitpy/style/checkers/cpp.py:
987         (CppChecker):
988         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
989         (WebKitStyleTest.test_names):
990
991 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
992
993         Evas_Object* is a ref'ed structure, so tread it as such
994         https://bugs.webkit.org/show_bug.cgi?id=96659
995
996         Reviewed by Adam Barth.
997
998         Replace OwnPtr<Evas_Object> with RefPtr.
999
1000         * DumpRenderTree/efl/ImageDiff.cpp:
1001         (calculateDifference):
1002         (printImageDifferences):
1003         (readImageFromStdin):
1004         (main):
1005
1006 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1007
1008         Unreviewed, rolling out r128507.
1009         http://trac.webkit.org/changeset/128507
1010         https://bugs.webkit.org/show_bug.cgi?id=96659
1011
1012         Revert. r128507 makes too many crashes in EFL layout test bots.
1013
1014         * DumpRenderTree/efl/ImageDiff.cpp:
1015         (calculateDifference):
1016         (printImageDifferences):
1017         (readImageFromStdin):
1018         (main):
1019
1020 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
1021
1022         Make compile with both OS(WINCE) and PLATFORM(QT) support
1023         https://bugs.webkit.org/show_bug.cgi?id=95536
1024
1025         Reviewed by Simon Hausmann.
1026
1027         Fix wince support in qmake files
1028
1029         * Tools.pro:
1030         * qmake/mkspecs/features/configure.prf:
1031         * qmake/mkspecs/features/default_post.prf:
1032         * qmake/mkspecs/features/features.prf:
1033         * qmake/mkspecs/features/functions.prf:
1034
1035 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
1036
1037         [WK2] Add color picker API support for WebKit2
1038         https://bugs.webkit.org/show_bug.cgi?id=95058
1039
1040         Reviewed by Gyuyoung Kim.
1041
1042         Initialization code for color picker callbacks in UI client.
1043
1044         * MiniBrowser/mac/BrowserWindowController.m:
1045         (-[BrowserWindowController awakeFromNib]):
1046         * MiniBrowser/win/BrowserView.cpp:
1047         (BrowserView::create):
1048         * WebKitTestRunner/TestController.cpp:
1049         (WTR::TestController::createOtherPage):
1050         (WTR::TestController::initialize):
1051
1052 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
1053
1054         Upgrade yutak to reviewer
1055         https://bugs.webkit.org/show_bug.cgi?id=96721
1056
1057         Reviewed by Kent Tamura.
1058
1059         * Scripts/webkitpy/common/config/committers.py:
1060
1061 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1062
1063         Make the style checker report usage of "unsigned int"
1064         https://bugs.webkit.org/show_bug.cgi?id=96693
1065
1066         Reviewed by Dirk Pranke.
1067
1068         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
1069
1070         * Scripts/webkitpy/style/checkers/cpp.py:
1071         (check_language):
1072
1073 2012-09-13  Philip Rogers  <pdr@google.com>
1074
1075         Add gender-neutral form of webkit-patch land-cowboy
1076         https://bugs.webkit.org/show_bug.cgi?id=96709
1077
1078         Reviewed by Adam Barth.
1079
1080         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
1081
1082         * Scripts/webkitpy/tool/commands/download.py:
1083         (LandCowhand):
1084
1085 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
1086
1087         [EFL] Remove some parameters in browserCreate()
1088         https://bugs.webkit.org/show_bug.cgi?id=96499
1089
1090         Reviewed by Kenneth Rohde Christiansen.
1091
1092         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
1093         And I have moved some parameters into User_Arguments.
1094
1095         * EWebLauncher/main.c:
1096         (_User_Arguments):
1097         (_ELauncher):
1098         (on_key_down):
1099         (browserCreate):
1100         (findThemePath):
1101         (parseUserArguments):
1102         (main):
1103
1104 2012-09-13  Mark Lam  <mark.lam@apple.com>
1105
1106         Unreviewed. Adding myself to the committers list.
1107
1108         * Scripts/webkitpy/common/config/committers.py:
1109
1110 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1111
1112         run-perf-tests output cryptic error when the config file is missing.
1113         https://bugs.webkit.org/show_bug.cgi?id=96453
1114
1115         Reviewed by Tony Chang.
1116
1117         Add a special error message when a configuration file is missing.
1118
1119         Also update the help message of --source-json-path to signify the fact it specifies
1120         the configuration file on performance tests bots.
1121
1122         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1123         (PerfTestsRunner._parse_args):
1124         (PerfTestsRunner._generate_and_show_results):
1125         (PerfTestsRunner._merge_slave_config_json):
1126         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1127         (_test_run_with_json_output): Make upload to fail by default and assert the result
1128         in the function so that we can return logs instead.
1129         (_test_run_with_json_output.mock_upload_json):
1130         (test_run_with_json_output):
1131         (test_run_with_description):
1132         (test_run_respects_no_results):
1133         (test_run_with_slave_config_json):
1134         (test_run_with_bad_slave_config_json):
1135         (test_run_with_multiple_repositories):
1136
1137 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1138
1139         Evas_Object* is a ref'ed structure, so tread it as such
1140         https://bugs.webkit.org/show_bug.cgi?id=96659
1141
1142         Reviewed by Adam Barth.
1143
1144         Replace OwnPtr<Evas_Object> with RefPtr.
1145
1146         * DumpRenderTree/efl/ImageDiff.cpp:
1147         (calculateDifference):
1148         (printImageDifferences):
1149         (readImageFromStdin):
1150         (main):
1151
1152 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1153
1154         One more unreviewed trivial fix after r128399.
1155
1156         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
1157
1158 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1159
1160         Unreviewed trivial fix after r128399.
1161
1162         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
1163         (getLatestSVNRevision):
1164         (waitForSVNRevision):
1165
1166 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1167
1168         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
1169         https://bugs.webkit.org/show_bug.cgi?id=96366
1170
1171         Reviewed by Anders Carlsson.
1172
1173         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
1174         by calling shouldClose() on the FrameLoader.
1175
1176         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1178         (WTR::TestRunner::callShouldCloseOnWebView):
1179         (WTR):
1180         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1181         (TestRunner):
1182
1183 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1184
1185         Unreviewed, rolling out r128453.
1186         http://trac.webkit.org/changeset/128453
1187         https://bugs.webkit.org/show_bug.cgi?id=96681
1188
1189         Having tests use the same appcache directory leads to timeouts
1190         (Requested by zdobersek on #webkit).
1191
1192         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1193         (runTest):
1194         * Scripts/webkitpy/layout_tests/port/gtk.py:
1195         (GtkPort.setup_environ_for_server):
1196
1197 2012-09-13  James Robinson  <jamesr@chromium.org>
1198
1199         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
1200         https://bugs.webkit.org/show_bug.cgi?id=96678
1201
1202         Reviewed by Dirk Pranke.
1203
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1205         (.):
1206
1207 2012-09-13  Rob Buis  <rbuis@rim.com>
1208
1209         Unreviewed changes to watchlist.
1210
1211         - Add myself to BlackBerry bugs
1212
1213         * Scripts/webkitpy/common/config/watchlist:
1214
1215 2012-09-13  Stephen Chenney  <schenney@chromium.org>
1216
1217         Add an SVG entry to the watchlist
1218
1219         Unreviewed config change.
1220
1221         * Scripts/webkitpy/common/config/watchlist:
1222         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
1223         - Added myself and pdr as watchers
1224
1225 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1226
1227         [Qt] Make WebKit2 work on Windows with Qt 5
1228         https://bugs.webkit.org/show_bug.cgi?id=76776
1229
1230         Reviewed by Tor Arne Vestbø.
1231
1232         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
1233         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
1234         that for the GL TextureMapper (it's only built when that feature is set).
1235
1236         * qmake/mkspecs/features/configure.prf:
1237
1238 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1239
1240         [Qt] Ensure that QT is finalized before loading qt_module.prf
1241
1242         As qt_module.prf does dependency tracking based on the content of the
1243         QT variable. The intermediate WebKit modules modify the variable in
1244         their .pri files, so we have to ensure we've loaded all the modules
1245         before loading qt_module.
1246
1247         Reviewed by Tor Arne Vestbø.
1248         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
1249
1250         * qmake/mkspecs/features/default_post.prf:
1251         * qmake/mkspecs/features/webkit_modules.prf: Added.
1252
1253 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1254
1255         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
1256         https://bugs.webkit.org/show_bug.cgi?id=96633
1257
1258         Reviewed by Csaba Osztrogonác.
1259
1260         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1261         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1262         It's the usual problem and the usual solution is to rename one of the conflicting files.
1263         This patch chooses to rename DRT instead of WTR and MBR.
1264
1265         Fixed include order at the same time to match style guide.
1266
1267         * DumpRenderTree/qt/DumpRenderTree.pro:
1268         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1269         (messageHandler):
1270         (isOption):
1271         (takeOptionValue):
1272         (printUsage):
1273         (main):
1274
1275 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1276
1277         The Script run-launcher should support -2 in combination with --efl
1278         https://bugs.webkit.org/show_bug.cgi?id=96639
1279
1280         Reviewed by Simon Hausmann.
1281
1282         Support running the MiniBrowser then supplied -2 as argument.
1283
1284         * Scripts/run-launcher:
1285
1286 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1287
1288         Unreviewed, add my Intel email address to the list.
1289
1290         * Scripts/webkitpy/common/config/committers.py:
1291
1292 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1293
1294         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1295
1296         Reviewed by Ossy.
1297
1298         * qmake/mkspecs/features/default_post.prf:
1299
1300 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1301
1302         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1303         https://bugs.webkit.org/show_bug.cgi?id=82294
1304
1305         Reviewed by Gyuyoung Kim.
1306
1307         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1308
1309         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1310         (TestRunner::layerTreeAsText):
1311
1312 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1313
1314         [GTK] Clear application cache between tests in DumpRenderTree
1315         https://bugs.webkit.org/show_bug.cgi?id=96543
1316
1317         Reviewed by Philippe Normand.
1318
1319         Call the new DumpRenderTreeSupportGtk method to clear application cache
1320         after each test.
1321
1322         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1323         as well. Currently it points to a subdirectory in the layout tests results
1324         directory. At least on the builders this ensures an empty cache directory
1325         with each test run.
1326
1327         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1328         (runTest):
1329         * Scripts/webkitpy/layout_tests/port/gtk.py:
1330         (GtkPort.setup_environ_for_server):
1331
1332 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1333
1334         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1335
1336         Unless it's actually a dependency of the public QtWebKit API.
1337
1338         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1339         files with their _PRIVATE equivivalent, but that's likely to break when
1340         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1341         clean up the variables in default_post.
1342
1343         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1344         longer needed, as it was a workaround for the intermediate libraries ending
1345         up in the prl file. And, since CONFIG -= staticlib was there to support
1346         the explicitlib option, we can remove that too (as well as the exception
1347         for gprof, since it would be empty). If gprof needs tweaks to always link
1348         statically they should go in gprof.prf.
1349
1350         Reviewed by Simon Hausmann.
1351
1352         * qmake/mkspecs/features/default_post.prf:
1353         * qmake/mkspecs/features/functions.prf:
1354
1355 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1356
1357         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1358         https://bugs.webkit.org/show_bug.cgi?id=96632
1359
1360         Reviewed by Carlos Garcia Campos.
1361
1362         Fix this by using atk_object_get_n_accessible_children instead of
1363         calling getChildren() from childCount.
1364
1365         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1366         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1367         loop by using atk_object_get_n_accessible_children().
1368
1369 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1370
1371         [Qt][Win] Enable USE(3D_GRAPHICS)
1372         https://bugs.webkit.org/show_bug.cgi?id=90879
1373
1374         Reviewed by Kenneth Rohde Christiansen.
1375
1376         Enable it on Windows as well as on QNX (bug fixed).
1377
1378         * qmake/mkspecs/features/features.prf:
1379
1380 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1381
1382         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1383         https://bugs.webkit.org/show_bug.cgi?id=96359
1384
1385         Reviewed by Tor Arne Vestbø.
1386
1387         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1388         lexer. The only viable alternative I could find on Windows that provides
1389         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1390         so let's use that one instead.
1391
1392         * Scripts/webkitdirs.pm:
1393         (checkRequiredSystemConfig):
1394         * qmake/mkspecs/features/default_pre.prf:
1395
1396 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1397
1398         [Qt] Add configuration for production builds
1399         https://bugs.webkit.org/show_bug.cgi?id=96607
1400
1401         Reviewed by Kenneth Rohde Christiansen.
1402
1403         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1404         and enable all-in-one-files optimizations.
1405
1406         * qmake/mkspecs/features/production_build.prf: Added.
1407
1408 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1409
1410         [Qt] GStreamer detection does not work when cross-compiling
1411         https://bugs.webkit.org/show_bug.cgi?id=96608
1412
1413         Reviewed by Kenneth Rohde Christiansen.
1414
1415         When cross-compiling it is not safe to just use system(pkg-config),
1416         because there is a high probability that it will find packages in the
1417         host system instead of in the target one. Instead use qmake's new
1418         packagesExist() function that takes care of this delicate aspect of
1419         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1420         PKG_CONFIG_LIBDIR accordingly.
1421
1422         * qmake/mkspecs/features/features.prf:
1423
1424 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1425
1426         [WK2][WTR] More efficient string handling in InjectedBundlePage
1427         https://bugs.webkit.org/show_bug.cgi?id=96609
1428
1429         Reviewed by Kenneth Rohde Christiansen.
1430
1431         Update StringBuilder usage in InjectedBundlePage to follow
1432         the latest recommandations for efficient string handling:
1433         http://trac.webkit.org/wiki/EfficientStrings
1434
1435         This involves using appendLiteral() or appendNumber()
1436         instead of append() whenever possible.
1437
1438         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1439         (WTR::dumpPath):
1440         (WTR::rangeToStr):
1441         (WTR::styleDecToStr):
1442         (WTR::frameToStr):
1443         (WTR::dumpResourceURL):
1444         (WTR):
1445         (WTR::dumpFrameDescriptionSuitableForTestResult):
1446         (WTR::dumpRequestDescriptionSuitableForTestResult):
1447         (WTR::dumpResponseDescriptionSuitableForTestResult):
1448         (WTR::dumpErrorDescriptionSuitableForTestResult):
1449         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1450         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1451         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1452         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1453         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1454         (WTR::InjectedBundlePage::didFinishProgress):
1455         (WTR::dumpFrameScrollPosition):
1456         (WTR::dumpFrameText):
1457         (WTR::dumpDescendantFramesText):
1458         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1459         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1460         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1461         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1462         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1463         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1464         (WTR::InjectedBundlePage::willSendRequestForFrame):
1465         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1466         (WTR::InjectedBundlePage::didFinishLoadForResource):
1467         (WTR::InjectedBundlePage::didFailLoadForResource):
1468         (WTR::InjectedBundlePage::shouldCacheResponse):
1469         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1470         (WTR::InjectedBundlePage::willAddMessageToConsole):
1471         (WTR::InjectedBundlePage::willSetStatusbarText):
1472         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1473         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1474         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1475         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1476         (WTR::InjectedBundlePage::shouldBeginEditing):
1477         (WTR::InjectedBundlePage::shouldEndEditing):
1478         (WTR::InjectedBundlePage::shouldInsertNode):
1479         (WTR::InjectedBundlePage::shouldInsertText):
1480         (WTR::InjectedBundlePage::shouldDeleteRange):
1481         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1482         (WTR::InjectedBundlePage::shouldApplyStyle):
1483         (WTR::InjectedBundlePage::didBeginEditing):
1484         (WTR::InjectedBundlePage::didEndEditing):
1485         (WTR::InjectedBundlePage::didChange):
1486         (WTR::InjectedBundlePage::didChangeSelection):
1487         (WTR::InjectedBundlePage::supportsFullScreen):
1488         (WTR::InjectedBundlePage::enterFullScreenForElement):
1489         (WTR::InjectedBundlePage::exitFullScreenForElement):
1490         (WTR::InjectedBundlePage::beganEnterFullScreen):
1491         (WTR::InjectedBundlePage::beganExitFullScreen):
1492         (WTR::InjectedBundlePage::closeFullScreen):
1493         (WTR::dumpBackForwardListItem):
1494         (WTR::InjectedBundlePage::dumpBackForwardList):
1495
1496 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1497
1498         [Qt][WK2] Memory leaks in Qt's TestRunner
1499         https://bugs.webkit.org/show_bug.cgi?id=96603
1500
1501         Reviewed by Csaba Osztrogonác.
1502
1503         Fix memory leaks in Qt's TestRunner code by adopting WKString
1504         created with WKStringCreateWithUTF8CString().
1505
1506         * WebKitTestRunner/qt/TestControllerQt.cpp:
1507         (WTR::TestController::initializeInjectedBundlePath):
1508         (WTR::TestController::initializeTestPluginDirectory):
1509
1510 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1511
1512         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1513         https://bugs.webkit.org/show_bug.cgi?id=96506
1514
1515         Reviewed by Dirk Pranke.
1516
1517         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1518         for debug configuration. These are the same values the Chromium port uses.
1519
1520         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1521         the layout tests under WebKit2 generally) requires more attention and gardening
1522         than what the current effort produces.
1523
1524         The unit test is updated as well to test these changes.
1525
1526         * Scripts/webkitpy/layout_tests/port/gtk.py:
1527         (GtkPort.default_timeout_ms):
1528         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1529         (GtkPortTest.test_default_timeout_ms):
1530         (GtkPortTest.assertLinesEqual):
1531
1532 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1533
1534         Add SVN mirror handling feature to build.webkit.org
1535         https://bugs.webkit.org/show_bug.cgi?id=85887
1536
1537         Reviewed by Dirk Pranke.
1538
1539         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1540         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1541         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1542         (ConfigureBuild.start):
1543         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1544         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1545         (Factory.__init__):
1546         (BuildFactory.__init__):
1547         (TestFactory.__init__):
1548         (BuildAndTestFactory.__init__):
1549         (BuildAndPerfTestFactory.__init__):
1550         (BuildAndPerfTestWebKit2Factory.__init__):
1551         (DownloadAndPerfTestFactory.__init__):
1552         (DownloadAndPerfTestWebKit2Factory.__init__):
1553         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1554         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1555         (SVNMirrorTest):
1556         (SVNMirrorTest.setUp): Load config.json once at startup.
1557         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1558         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1559         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1560         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1561         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1562                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1563
1564 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1565
1566         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1567         https://bugs.webkit.org/show_bug.cgi?id=81606
1568
1569         Reviewed by Tim Horton.
1570
1571         6 seconds is harsh for some jquery test cases.
1572         Therefore, adjust the value to match DumpRenderTree.
1573
1574         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1575         (WTR):
1576
1577 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1578
1579         [EFL] Support download attribute feature
1580         https://bugs.webkit.org/show_bug.cgi?id=96462
1581
1582         Reviewed by Gyuyoung Kim.
1583
1584         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1585         and add "download,request" callback to the DumpRenderTree for EFL.
1586
1587         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1588         (DumpRenderTreeChrome::createView):
1589         (DumpRenderTreeChrome::onDownloadRequest):
1590         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1591         (DumpRenderTreeChrome):
1592         * Scripts/webkitperl/FeatureList.pm:
1593
1594 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1595
1596         Reduce parallism on the wk2 testers.
1597         https://bugs.webkit.org/show_bug.cgi?id=95906
1598
1599         Reviewed by Dirk Pranke.
1600
1601         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1602         resource contention.  Reducing the number of processes alleviates the issue.  
1603
1604         Starting by reducing 25%.
1605
1606         * Scripts/webkitpy/layout_tests/port/mac.py:
1607         (MacPort.default_child_processes):
1608
1609 2012-09-12  Brady Eidson  <beidson@apple.com>
1610
1611         Assert in NetscapePlugin::destroy() with async plugin init
1612         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1613
1614         Reviewed by Anders Carlsson.
1615
1616         Expose NPN_Invoke to plug-in tests:
1617         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1618         (PluginTest::NPN_Invoke):
1619         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1620         (PluginTest):
1621
1622         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1623         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1624         (InvokeDestroysPluginWithinNPP_New):
1625         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1626         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1627         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1628
1629 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1630
1631         refactor TestExpectations tokenization slightly in preparation for the new syntax
1632         https://bugs.webkit.org/show_bug.cgi?id=96564
1633
1634         Reviewed by Ojan Vafai.
1635
1636         This change changes how we will tokenize/lex the
1637         TestExpectations files, in preparation for supporting both the
1638         old syntax and the new one. This change by itself should be a
1639         no-op.
1640
1641         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1642         (TestExpectationParser._tokenize_line):
1643         (TestExpectationParser):
1644         (TestExpectationParser._tokenize_line_using_old_format):
1645         (TestExpectationParser._tokenize_line_using_new_format):
1646
1647 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1648
1649         remove unused testexpectations editing code from webkitpy, garden-o-matic
1650         https://bugs.webkit.org/show_bug.cgi?id=96562
1651
1652         Reviewed by Adam Barth.
1653
1654         This code was prototyped but never fully realized. Removing
1655         until it reanimates :).
1656
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1658         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1659         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1660         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1661         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1662         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1663         (GardeningHTTPRequestHandler._run_webkit_patch):
1664         (GardeningHTTPRequestHandler.ping):
1665         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1666         (BuildCoverageExtrapolatorTest.test_extrapolate):
1667         (GardeningServerTest.test_rebaseline_new_port):
1668
1669 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1670
1671         Remove unused bot, apple-xserve-1.
1672         https://bugs.webkit.org/show_bug.cgi?id=96570
1673         
1674         Reviewed by Stephanie Lewis.
1675
1676         * BuildSlaveSupport/build.webkit.org-config/config.json:
1677
1678 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1679
1680         [GTK] We attempt to rebase documentation even if it's not present
1681         https://bugs.webkit.org/show_bug.cgi?id=96553
1682
1683         Reviewed by Martin Robinson.
1684
1685         Do not make the documentation rebase step fatal. This allows make
1686         install to succeed when there's no documentation generated.
1687
1688         * gtk/generate-gtkdoc:
1689
1690 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1691
1692         Respect WEBKITOUTPUTDIR when running EFL tests
1693         https://bugs.webkit.org/show_bug.cgi?id=96528
1694
1695         Reviewed by Dirk Pranke.
1696
1697         Expose user set WEBKITOUTPUTDIR to the web process.
1698
1699         * Scripts/webkitpy/layout_tests/port/driver.py:
1700         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1701         of the web process and its potential jhbuild wrapper.
1702
1703 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1704
1705         webkitdirs: fix uname version handling for cygwin
1706         https://bugs.webkit.org/show_bug.cgi?id=96436
1707
1708         Reviewed by Jon Honeycutt.
1709
1710         Newer versions of cygwin embed an additional version string
1711         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1712         Update the code to handle that.
1713
1714         * Scripts/webkitdirs.pm:
1715         (setupAppleWinEnv):
1716
1717 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1718
1719         Regression(r128338): Broke Windows build
1720         https://bugs.webkit.org/show_bug.cgi?id=96537
1721
1722         Unreviewed build fix.
1723
1724         Fix Apple-Win build by allocating array dynamically
1725         since its size is not constant.
1726
1727         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1728         (WTR::stringArrayToJS):
1729
1730 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1731
1732         [chromium] Add a virtual test suite for fast/hidpi
1733         https://bugs.webkit.org/show_bug.cgi?id=90192
1734
1735         Reviewed by Dirk Pranke.
1736
1737         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1738         on the hardware accelerated path as the software path.
1739
1740         * DumpRenderTree/chromium/WebPreferences.cpp:
1741         (WebPreferences::applyTo):
1742         * Scripts/webkitpy/layout_tests/port/chromium.py:
1743         (ChromiumPort.virtual_test_suites):
1744
1745 2012-09-12  Adam Klein  <adamk@chromium.org>
1746
1747         [chromium] Add content_browsertests to the flakiness dashboard
1748         https://bugs.webkit.org/show_bug.cgi?id=96535
1749
1750         Reviewed by Ojan Vafai.
1751
1752         * TestResultServer/static-dashboards/dashboard_base.js:
1753
1754 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1755
1756         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1757         https://bugs.webkit.org/show_bug.cgi?id=96496
1758
1759         Reviewed by Kenneth Rohde Christiansen.
1760
1761         Add implementation for originsWithApplicationCache to
1762         WebKitTestRunner.
1763
1764         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1765         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1766         (WTR::stringArrayToJS):
1767         (WTR):
1768         (WTR::TestRunner::originsWithApplicationCache):
1769         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1770         (TestRunner):
1771
1772 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1773
1774         Fix Qt/Windows build with Python3
1775         https://bugs.webkit.org/show_bug.cgi?id=96473
1776
1777         Reviewed by Csaba Osztrogonác.
1778
1779         In Python 3 print is a real function, so we must use parentheses around
1780         the function parameters. This is backwards compatible with Python 2.
1781
1782         * Scripts/generate-win32-export-forwards:
1783
1784 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1785
1786         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1787
1788         As pointed out by Kevin, we should inject the "set PATH=..." statement
1789         to add the GnuWin32 directory only if that directory actually exists.
1790
1791         * qmake/mkspecs/features/default_post.prf:
1792
1793 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1794
1795         [EFL] [WK2] Memory leaks in TestControllerEfl
1796         https://bugs.webkit.org/show_bug.cgi?id=96525
1797
1798         Reviewed by Kenneth Rohde Christiansen.
1799
1800         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1801         of WKString created with WKStringCreateWithUTF8CString().
1802
1803         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1804         (WTR::TestController::initializeInjectedBundlePath):
1805         (WTR::TestController::initializeTestPluginDirectory):
1806
1807 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1808
1809         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1810         https://bugs.webkit.org/show_bug.cgi?id=96374
1811
1812         Reviewed by Kenneth Rohde Christiansen.
1813
1814         Implement support for dumpApplicationCacheDelegateCallbacks
1815         and disallowIncreaseForApplicationCacheQuota in
1816         WebKitTestRunner and properly dump the information
1817         expected by the tests.
1818
1819         If the application cache quota is reached for a given
1820         security origin, WebKitTestRunner will reset the quota
1821         to its default value, unless intructed not to via
1822         disallowIncreaseForApplicationCacheQuota().
1823
1824         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1825         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1826         (WTR::InjectedBundlePage::InjectedBundlePage):
1827         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1828         (WTR):
1829         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1830         (InjectedBundlePage):
1831         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1832         (WTR::TestRunner::TestRunner):
1833         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1834         (WTR):
1835         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1836         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1837         (TestRunner):
1838         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1839         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1840
1841 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1842
1843         [chromium] remove deprecated and unused sets import from chromium_android driver
1844         https://bugs.webkit.org/show_bug.cgi?id=96485
1845
1846         Reviewed by Dirk Pranke.
1847
1848         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1849
1850 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1851
1852         Flakiness dashboard doesn't recognize new Chromium Android test builder
1853         https://bugs.webkit.org/show_bug.cgi?id=96523
1854
1855         Reviewed by Ojan Vafai.
1856
1857         Properly return 'ANDROID' as the Chromium platform for Android builders.
1858
1859         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1860         (chromiumPlatform):
1861         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1862         (test):
1863
1864 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1865
1866         [Qt] Build on Windows requires bison/flex in PATH
1867         https://bugs.webkit.org/show_bug.cgi?id=96358
1868
1869         Reviewed by Tor Arne Vestbø.
1870
1871         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1872         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1873         a separate installation of various GNU tools is required as the operating system doesn't come with
1874         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1875         the gnuwin32 directory of the qt5.git top-level repository.
1876
1877         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1878
1879         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1880         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1881         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1882         updated with the new tool.
1883
1884         * Scripts/webkitdirs.pm:
1885         (checkRequiredSystemConfig):
1886         * qmake/mkspecs/features/default_post.prf:
1887
1888 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1889
1890         [Qt] Update build-jsc after r128174
1891
1892         Reviewed by Ossy.
1893
1894         * Scripts/build-jsc:
1895
1896 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1897
1898         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1899
1900         By hard-coding the names of the targets we defined we ended up just
1901         redefining the previous target when using addStrictSubdirOrderBetween
1902         more than once in a single project file.
1903
1904         We now embed the two base targets into the target names.
1905
1906         Reviewed by Simon Hausmann.
1907
1908         * qmake/mkspecs/features/functions.prf:
1909
1910 2012-09-12  Philippe Liard  <pliard@google.com>
1911
1912         Depend on {base,net} GYP targets rather than {base,net}_java.
1913         https://bugs.webkit.org/show_bug.cgi?id=95690
1914
1915         Reviewed by Adam Barth.
1916
1917         {base,net}_java became 'private' targets on the Chromium side that
1918         clients should not depend on (see
1919         https://chromiumcodereview.appspot.com/10913083/).
1920         This removes a bunch of trailing white spaces additionally in
1921         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1922
1923         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1924         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1925
1926 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1927
1928         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1929         https://bugs.webkit.org/show_bug.cgi?id=96494
1930
1931         Reviewed by Tor Arne Vestbø.
1932
1933         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1934         plugin process feature if we don't have NPAPI.
1935
1936         * qmake/mkspecs/features/features.prf:
1937
1938 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1939
1940         Unreviewed, rolling out r128280.
1941         http://trac.webkit.org/changeset/128280
1942         https://bugs.webkit.org/show_bug.cgi?id=96498
1943
1944         it broke compilation on windows debug bot (Requested by loislo
1945         on #webkit).
1946
1947         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1948         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1949         (WTR::InjectedBundlePage::InjectedBundlePage):
1950         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1951         (InjectedBundlePage):
1952         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1953         (WTR::TestRunner::TestRunner):
1954         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1955         (TestRunner):
1956
1957 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1958
1959         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1960         https://bugs.webkit.org/show_bug.cgi?id=96488
1961
1962         Reviewed by Tor Arne Vestbø.
1963
1964         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1965         because there are no such targets. We want the generated sources to be independent from release
1966         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1967         redirect to the same general-purpose target (first) of creating the derived sources.
1968
1969         * qmake/mkspecs/features/default_post.prf:
1970
1971 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1972
1973         [EFL] Make DumpRenderTree smarter at finding the fonts
1974         http://webkit.org/b/96281
1975
1976         Reviewed by Gyuyoung Kim.
1977
1978         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1979         Use CString consistently.
1980
1981         * DumpRenderTree/efl/FontManagement.cpp:
1982         (buildPath):
1983         (getCoreFontFiles):
1984         (addFontDirectory):
1985         (addFontFiles):
1986         (getCustomBuildDir):
1987         (getPlatformFontsPath):
1988         (addFontsToEnvironment):
1989
1990 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1991
1992         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1993         https://bugs.webkit.org/show_bug.cgi?id=96374
1994
1995         Reviewed by Kenneth Rohde Christiansen.
1996
1997         Implement support for dumpApplicationCacheDelegateCallbacks
1998         and disallowIncreaseForApplicationCacheQuota in
1999         WebKitTestRunner and properly dump the information
2000         expected by the tests.
2001
2002         If the application cache quota is reached for a given
2003         security origin, WebKitTestRunner will reset the quota
2004         to its default value, unless intructed not to via
2005         disallowIncreaseForApplicationCacheQuota().
2006
2007         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2008         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2009         (WTR::InjectedBundlePage::InjectedBundlePage):
2010         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2011         (WTR):
2012         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2013         (InjectedBundlePage):
2014         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2015         (WTR::TestRunner::TestRunner):
2016         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2017         (WTR):
2018         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2019         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2020         (TestRunner):
2021         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2022         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2023
2024 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2025
2026         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
2027         https://bugs.webkit.org/show_bug.cgi?id=96388
2028
2029         Reviewed by Kenneth Rohde Christiansen.
2030
2031         Exported TestRunner.workerThreadCount as readonly attribute.
2032
2033         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2034         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
2035         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
2036         (WTR):
2037         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
2038         (TestRunner):
2039
2040 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2041
2042         [chromium] Consume a user gesture when creating a new view.
2043         https://bugs.webkit.org/show_bug.cgi?id=96373
2044
2045         Reviewed by Adam Barth.
2046
2047         * DumpRenderTree/chromium/WebViewHost.cpp:
2048         (WebViewHost::createView):
2049
2050 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2051
2052         [WK2][WTR] Some of TestRunner special options are not reset before testing
2053         https://bugs.webkit.org/show_bug.cgi?id=96384
2054
2055         Reviewed by Kenneth Rohde Christiansen.
2056
2057         Now values of the following special options are reset:
2058         void setAcceptsEditing(in boolean value);
2059         void setCloseRemainingWindowsWhenComplete(in boolean value);
2060         void setXSSAuditorEnabled(in boolean value);
2061         void setAllowFileAccessFromFileURLs(in boolean value);
2062         void setPluginsEnabled(in boolean value);
2063         void setPopupBlockingEnabled(in boolean value);
2064
2065         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2066         (WTR::InjectedBundle::beginTesting):
2067
2068 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
2069
2070         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
2071         https://bugs.webkit.org/show_bug.cgi?id=96273
2072
2073         Reviewed by Gyuyoung Kim.
2074
2075         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
2076         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
2077
2078         * WebKitTestRunner/CMakeLists.txt:
2079
2080 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
2081
2082         [chromium] rename webkit_resources
2083         https://bugs.webkit.org/show_bug.cgi?id=95874
2084
2085         Reviewed by James Robinson.
2086
2087         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2088
2089 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
2090
2091         [chromium] don't include content shell builders in the garden-o-matic view
2092         https://bugs.webkit.org/show_bug.cgi?id=96418
2093
2094         Reviewed by James Robinson.
2095
2096         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2097
2098 2012-09-11  Adam Klein  <adamk@chromium.org>
2099
2100         Garden-o-matic should ignore a wider variety of warnings in buildbot json
2101         https://bugs.webkit.org/show_bug.cgi?id=96411
2102
2103         Reviewed by Adam Barth.
2104
2105         Previously only the exact string "warning" was treated as a warning
2106         result. This patch treats any string with "warning" as a substring
2107         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
2108
2109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2110         (.):
2111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2112
2113 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
2114
2115         Restore original value of mock scrollbars enabled in InternalSettings
2116         https://bugs.webkit.org/show_bug.cgi?id=87680
2117
2118         Reviewed by Adam Barth.
2119
2120         Added backup support for mock scrollbars state in
2121         InternalSettings::Backup, and removed support for these
2122         from Qt's DumpRenderTree.
2123
2124         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2125         (WebCore::WebPage::resetSettings):
2126         * DumpRenderTree/qt/TestRunnerQt.cpp:
2127         (TestRunner::setFrameFlatteningEnabled):
2128         * DumpRenderTree/qt/TestRunnerQt.h:
2129         (TestRunner):
2130
2131 2012-09-11  Dan Bernstein  <mitz@apple.com>
2132
2133         Fixed a bug where kill-old-processes failed to kill clang++.
2134
2135         Rubber-stamped by Alexey Proskuryakov.
2136
2137         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
2138         where it is passed as a regular expression to killall.
2139
2140 2012-09-11  Philippe Liard  <pliard@google.com>
2141
2142         Make sure that md5sum is not setup on non-Chromium Android platforms.
2143         https://bugs.webkit.org/show_bug.cgi?id=96393
2144
2145         Reviewed by Adam Barth.
2146
2147         Previously md5sum was setup in ChromiumAndroidDriver's constructor
2148         which is also invoked on non-Chromium Android platforms. The following patch
2149         moves this logic to _startup_test() which is guaranteed to be invoked
2150         only on Android.
2151
2152         This also updates the prompt unit test in chromium_android_unittest.py.
2153
2154         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2155         (ChromiumAndroidDriver.__init__):
2156         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2157         (ChromiumAndroidDriver._setup_test):
2158
2159 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
2160
2161         [EFL] Rewrite the EFL-related Find modules
2162         https://bugs.webkit.org/show_bug.cgi?id=95237
2163
2164         Reviewed by Kenneth Rohde Christiansen.
2165
2166         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
2167         property and include all the Enlightenment Foundation Libraries
2168         required by the target.
2169         * EWebLauncher/CMakeLists.txt: Ditto.
2170         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2171         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
2172         now that they are not added implicitly.
2173         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
2174         property.
2175         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
2176         property and include all the Enlightenment Foundation Libraries
2177         required by the target.
2178
2179 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2180
2181         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
2182         https://bugs.webkit.org/show_bug.cgi?id=96379
2183
2184         Reviewed by Kenneth Rohde Christiansen.
2185
2186         Add implementation for setApplicationCacheOriginQuota
2187         to WebKitTestRunner.
2188
2189         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2190         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2191         (WTR::TestRunner::setApplicationCacheOriginQuota):
2192         (WTR):
2193         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2194         (TestRunner):
2195
2196 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
2197
2198         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
2199         https://bugs.webkit.org/show_bug.cgi?id=91988
2200
2201         Reviewed by Kenneth Rohde Christiansen.
2202
2203         Regular key events generated by Qt for the tab key fill both
2204         keyCode and keyText, so we should do the same for our fake events.
2205
2206         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2207         (WTR::EventSenderProxy::keyDown):
2208
2209 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2210
2211         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
2212         https://bugs.webkit.org/show_bug.cgi?id=96269
2213
2214         Reviewed by Kenneth Rohde Christiansen.
2215
2216         Exported missing testRunner.setSpatialNavigationEnabled() method.
2217
2218         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2219         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2220         (WTR::InjectedBundle::beginTesting):
2221         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2222         (WTR::TestRunner::setSpatialNavigationEnabled):
2223         (WTR):
2224         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2225         (TestRunner):
2226
2227 2012-09-11  Philippe Liard  <pliard@chromium.org>
2228
2229         Support LayoutTests on non-rooted devices for Chromium Android.
2230         https://bugs.webkit.org/show_bug.cgi?id=95346
2231
2232         Reviewed by Dirk Pranke.
2233
2234         We were requiring root permissions to sync resource files with the
2235         device by comparing host and device files' timestamp after we
2236         synchronized the device and host clocks.
2237         We now rely on md5sum provided by Chromium to handle data files
2238         synchronization.
2239
2240         * Scripts/webkitpy/layout_tests/port/chromium.py:
2241         (ChromiumPort._check_driver_build_up_to_date):
2242         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2243         (ChromiumAndroidDriver.__init__):
2244         (ChromiumAndroidDriver._setup_test):
2245         (ChromiumAndroidDriver._push_executable):
2246         (ChromiumAndroidDriver._push_test_resources):
2247         (ChromiumAndroidDriver._read_prompt):
2248
2249 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2250
2251         [Qt] Fix output paths on Windows
2252
2253         Reviewed by Tor Arne Vestbø.
2254
2255         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
2256         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2257         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2258         incorrect here and instead for the calculation we should use forward slashes.
2259
2260         * qmake/mkspecs/features/default_pre.prf:
2261
2262 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2263
2264         [Qt] Fix passing of defines from the build system
2265
2266         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2267         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2268         will add it's own defaults if the features are not defined.
2269
2270         At some point we might want to run a configure-test to inspect what
2271         Platform.h will do, so we can sync up the build system's view of
2272         the feature-defines with the compile-time situation.
2273
2274         Reviewed by Simon Hausmann.
2275
2276         * qmake/mkspecs/features/functions.prf:
2277
2278 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2279
2280         [Qt] Fix --qt option to build-webkit
2281
2282         Reviewed by Ossy.
2283
2284         * Scripts/webkitdirs.pm:
2285         (buildQMakeProjects):
2286
2287 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2288
2289         [Qt] Add a configure step to the Qt build system
2290
2291         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2292         the build-webkit script is still supported, and will add slightly more
2293         logic to the build, such as detecting the need for clean or incremental
2294         builds.
2295
2296         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2297         all things related to configuring the build, such as use/have/enable flags,
2298         and these are translated to defines in default_post. Project files should
2299         no longer check contains(DEFINES,...) to detect features, but use the new
2300         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2301         options have been translated into WEBKIT_CONFIG options as well, and can
2302         be checked using build?().
2303
2304         Reviewed by Simon Hausmann.
2305
2306         * DumpRenderTree/qt/DumpRenderTree.pro:
2307         * MiniBrowser/qt/MiniBrowser.pro:
2308         * QtTestBrowser/QtTestBrowser.pro:
2309         * Scripts/build-webkit:
2310         * Scripts/webkitdirs.pm:
2311         (qtFeatureDefaults):
2312         (buildQMakeProjects):
2313         * Tools.pro:
2314         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2315         * WebKitTestRunner/InjectedBundle/Target.pri:
2316         * WebKitTestRunner/Target.pri:
2317         * qmake/.qmake.cache: Added.
2318         * qmake/configure.pri: Removed.
2319         * qmake/configure.pro: Removed.
2320         * qmake/dump-features: Added.
2321         * qmake/mkspecs/features/configure.prf: Added.
2322         * qmake/mkspecs/features/default_post.prf:
2323         * qmake/mkspecs/features/default_pre.prf:
2324         * qmake/mkspecs/features/features.prf:
2325         * qmake/mkspecs/features/features.pri:
2326         * qmake/mkspecs/features/functions.prf:
2327         * qmake/mkspecs/features/gprof.prf:
2328         * qmake/mkspecs/features/mac/default_pre.prf:
2329         * qmake/mkspecs/features/win32/default_pre.prf:
2330
2331 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2332
2333         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2334         https://bugs.webkit.org/show_bug.cgi?id=96372
2335
2336         Reviewed by Kenneth Rohde Christiansen.
2337
2338         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2339
2340         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2341         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2342         (WTR::TestRunner::clearApplicationCacheForOrigin):
2343         (WTR):
2344         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2345         (TestRunner):
2346
2347 2012-09-11  Peter Beverloo  <peter@chromium.org>
2348
2349         Don't ignore .pak files when making an archive for Android
2350         https://bugs.webkit.org/show_bug.cgi?id=96375
2351
2352         Reviewed by Jochen Eisinger.
2353
2354         The .pak files do need to be pushed to the device, which is currently
2355         preventing the layout test runner from correctly pushing all files.
2356
2357         * BuildSlaveSupport/built-product-archive:
2358         (archiveBuiltProduct):
2359
2360 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2361
2362         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2363         https://bugs.webkit.org/show_bug.cgi?id=96256
2364
2365         Reviewed by Kenneth Rohde Christiansen.
2366
2367         Exported TestRunner::setMinimumTimerInterval() method.
2368
2369         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2370         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2371         (WTR::InjectedBundle::beginTesting):
2372         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2373         (WTR::TestRunner::setMinimumTimerInterval):
2374         (WTR):
2375         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2376         (TestRunner):
2377
2378 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2379
2380         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2381         https://bugs.webkit.org/show_bug.cgi?id=96097
2382
2383         Reviewed by Adam Barth.
2384
2385         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2386         (MockWebRTCPeerConnectionHandler::addStream):
2387         (MockWebRTCPeerConnectionHandler::removeStream):
2388
2389 2012-09-11  Peter Beverloo  <peter@chromium.org>
2390
2391         Recognize the "--chromium-android" argument in run-webkit-tests
2392         https://bugs.webkit.org/show_bug.cgi?id=96369
2393
2394         Reviewed by Jochen Eisinger.
2395
2396         Chromium for the Android platform cannot determine the platform based on
2397         the host itself, so we'll use the --chromium-android argument as the build
2398         master passes to run-webkit-tests. Make sure the layout test runner
2399         can pick the right port when doing so.
2400
2401         * Scripts/run-webkit-tests:
2402         * Scripts/webkitpy/layout_tests/port/factory.py:
2403         (port_options):
2404
2405 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2406
2407         [QT] Fix build with newer qmake from Qt 5
2408
2409         Rubber-stamped by Tor Arne Vestbø.
2410
2411         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2412         it with the use of QT_HOST_DATA/mkspecs.
2413         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2414
2415         * Scripts/webkitdirs.pm:
2416         (builtDylibPathForName):
2417         (qtMakeCommand):
2418
2419 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2420
2421         [Qt] Remove Qt 4 syncqt, no longer needed
2422
2423         Reviewed by Simon Hausmann.
2424
2425         * qmake/syncqt-4.8: Removed.
2426
2427 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2428
2429         [Qt][WK2] Fix the build with recent Qt5
2430         https://bugs.webkit.org/show_bug.cgi?id=96283
2431
2432         Reviewed by Simon Hausmann.
2433
2434         We should not use deprecated Qt API because doing that results
2435         in build failure since all the deprecated API was disabled
2436         in qtbase (https://codereview.qt-project.org/#change,24890).
2437
2438         * DumpRenderTree/qt/main.cpp:
2439         (main):
2440         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2441         (MiniBrowserApplication::notify):
2442         * MiniBrowser/qt/raw/View.cpp:
2443         (View::exposeEvent):
2444         (main):
2445
2446 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2447
2448         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2449         https://bugs.webkit.org/show_bug.cgi?id=87188
2450
2451         Reviewed by Kenneth Rohde Christiansen.
2452
2453         Add implementation for applicationCacheDiskUsageForOrigin()
2454         in WebKitTestRunner.
2455
2456         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2457         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2458         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2459         (WTR):
2460         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2461         (TestRunner):
2462
2463 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2464
2465         Properly expose <legend> elements to ATs
2466         https://bugs.webkit.org/show_bug.cgi?id=84137
2467
2468         Reviewed by Chris Fleizach.
2469
2470         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2471         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2472         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2473
2474         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2475         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2476
2477 2012-09-10  Jer Noble  <jer.noble@apple.com>
2478
2479         Unreviewed; rolling out r128081.
2480         http://trac.webkit.org/changeset/128081
2481         https://bugs.webkit.org/show_bug.cgi?id=96134
2482
2483         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2484
2485         * DumpRenderTree/TestRunner.cpp:
2486         (TestRunner::TestRunner):
2487         (TestRunner::staticFunctions):
2488         * DumpRenderTree/TestRunner.h:
2489         (TestRunner):
2490         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2491         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2492         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2493         (WTR::InjectedBundlePage::InjectedBundlePage):
2494         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2495         (InjectedBundlePage):
2496         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2497         (WTR::TestRunner::TestRunner):
2498         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2499         (TestRunner):
2500
2501 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2502
2503         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2504         https://bugs.webkit.org/show_bug.cgi?id=96205
2505
2506         Reviewed by Tony Chang.
2507
2508         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2509         internally, which means that it would support only 1 TestExpectations file per port. This
2510         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2511         and efl-wk1 -> efl).
2512
2513         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2514         instead so that all the ports TestExpectations are recognized. The ports are also
2515         constructed twice, with "webkit_test_runner" option set to True and False so that we
2516         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2517
2518         * Scripts/webkitpy/style/checkers/test_expectations.py:
2519         (TestExpectationsChecker._determine_port_from_expectations_path):
2520         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2521         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2522
2523 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2524
2525         [WTR] Generated source files should include config.h
2526         https://bugs.webkit.org/show_bug.cgi?id=96254
2527
2528         Reviewed by Benjamin Poulain.
2529
2530         Current coding style has encouraged to include config.h at the first position,
2531         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2532         this rule.
2533         Therefore, this patch added it.
2534
2535         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2536         (_generateImplementationFile):
2537
2538 2012-09-10  Rick Byers  <rbyers@chromium.org>
2539
2540         Add handling of new GestureTapCancel in DRT
2541         
2542         https://bugs.webkit.org/show_bug.cgi?id=96183
2543
2544         Reviewed by Adam Barth.
2545
2546         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2547         (TestWebPlugin::handleInputEvent):
2548
2549 2012-09-10  Brady Eidson  <beidson@apple.com>
2550
2551         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2552         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2553
2554         Reviewed by Geoff Garen.
2555
2556         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2557
2558         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2559         (PluginObject):
2560         (SlowNPPNew::PluginObject::PluginObject):
2561         (SlowNPPNew::PluginObject::~PluginObject):
2562         (SlowNPPNew::PluginObject::hasProperty):
2563         (SlowNPPNew::PluginObject::getProperty):
2564         (SlowNPPNew::NPP_GetValue):
2565         (SlowNPPNew):
2566
2567 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2568
2569         WKTR often reports an unresponsive WebProcess on Mac bots
2570         https://bugs.webkit.org/show_bug.cgi?id=95906
2571
2572         Reviewed by Dan Bernstein.
2573
2574         Attempt to work around resource contention issues by increasing the NRWT
2575         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2576
2577         * Scripts/webkitpy/layout_tests/port/base.py:
2578         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2579         * WebKitTestRunner/TestController.cpp:
2580         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2581
2582 2012-09-07  Jer Noble  <jer.noble@apple.com>
2583
2584         <audio> and <video> should send Do Not Track when appropriate
2585         https://bugs.webkit.org/show_bug.cgi?id=96134
2586
2587         Reviewed by Eric Carlson.
2588
2589         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2590         WTR. Add FrameLoaderClient client methods for retrieving that value.
2591
2592         * DumpRenderTree/TestRunner.cpp:
2593         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2594         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2595         * DumpRenderTree/TestRunner.h:
2596         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2597         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2598         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2599         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2600             Pass the question on to the TestRunner.
2601         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2602         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2603         (WTR::InjectedBundlePage::InjectedBundlePage):
2604             Add the setShouldSendDoNotTrackHTTPHeader client function.
2605         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2606             Pass the question on to the TestRunner.
2607         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2608         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2609         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2610         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2611         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2612
2613 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2614
2615         Make EFL bots work on the flakiness dashboard
2616         https://bugs.webkit.org/show_bug.cgi?id=96164
2617
2618         Reviewed by Tony Chang.
2619
2620         Also, update outdated unittests that had started failing.
2621
2622         * TestResultServer/static-dashboards/builders.js:
2623         (isWebkitTestRunner):
2624         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2625         (nonChromiumPlatform):
2626         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2627         (test):
2628
2629 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
2630
2631         [chromium] MediaStream API: Remove the Descriptor postfix
2632         https://bugs.webkit.org/show_bug.cgi?id=96268
2633
2634         Reviewed by Adam Barth.
2635
2636         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
2637         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
2638
2639         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2640         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2641         (MockWebRTCPeerConnectionHandler::createOffer):
2642         (MockWebRTCPeerConnectionHandler::createAnswer):
2643         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2644         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2645         (MockWebRTCPeerConnectionHandler::localDescription):
2646         (MockWebRTCPeerConnectionHandler::remoteDescription):
2647         (MockWebRTCPeerConnectionHandler::addICECandidate):
2648         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2649         (MockWebRTCPeerConnectionHandler):
2650
2651 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2652
2653         [Gtk] failure to build jhbuild dependencies with cups 1.6
2654         https://bugs.webkit.org/show_bug.cgi?id=95991
2655
2656         Reviewed by Gustavo Noronha Silva.
2657
2658         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2659         building with cups >= 1.6 [GNOME #670373].
2660
2661         * gtk/jhbuild.modules:
2662
2663 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2664
2665         [EFL][DRT] Encoding issue in printed console messages
2666         https://bugs.webkit.org/show_bug.cgi?id=96263
2667
2668         Reviewed by Kenneth Rohde Christiansen.
2669
2670         Correctly handle CONSOLE messages that contain non-ascii
2671         characters in EFL's DRT. We need to use String::fromUTF8()
2672         to construct a WTF::String from a raw string.
2673
2674         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2675         (onConsoleMessage):
2676
2677 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2678
2679         [WK2][WTR] User style sheet location should be reset before each test
2680         https://bugs.webkit.org/show_bug.cgi?id=96262
2681
2682         Reviewed by Kenneth Rohde Christiansen.
2683
2684         User style sheet location is reset before each test now.
2685
2686         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2687         (WTR::InjectedBundle::beginTesting):
2688
2689 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2690
2691         Fix build of WTR with Qt on Windows
2692         https://bugs.webkit.org/show_bug.cgi?id=96249
2693
2694         Reviewed by Kenneth Rohde Christiansen.
2695
2696         Windows loves to define min and max as macros, which beautifully
2697         clashes in many places where min and max are used as variable or method
2698         names. It can be convinced not to do this when min and max are already
2699         define as macros (expanding to themselves). We have this kind of
2700         workaround in config.h files all over WebKit and as it turns out when
2701         building WTR with Qt on Windows we do end up with such a clash. Therefore
2702         we need the same workaround.
2703
2704         * WebKitTestRunner/config.h:
2705
2706 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2707
2708         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2709         https://bugs.webkit.org/show_bug.cgi?id=95936
2710
2711         Reviewed by Kenneth Rohde Christiansen.
2712
2713         Enable interactive form validation setting in WebKitTestRunner as
2714         we are currently doing in DumpRenderTree. This is needed for some
2715         tests to pass.
2716
2717         * WebKitTestRunner/TestController.cpp:
2718         (WTR::TestController::resetStateToConsistentValues):
2719
2720 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2721
2722         Clean up the code in XvfbDriver
2723         https://bugs.webkit.org/show_bug.cgi?id=96202
2724
2725         Reviewed by Philippe Normand.
2726
2727         Changes:
2728         - Remove unneeded imports,
2729         - assign the _lock_file member variable when the display number is determined,
2730         - no need for parentheses around a single string format argument,
2731         - use FileSystem.exists method when checking if lock file is present as it
2732         makes the intention much more clearer.
2733
2734         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2735         (XvfbDriver._start):
2736         (XvfbDriver.stop):
2737
2738 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2739
2740         Make the String initialization on the function side of String::number()
2741         https://bugs.webkit.org/show_bug.cgi?id=95940
2742
2743         Reviewed by Benjamin Poulain.
2744
2745         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2746         (testBoundaries):
2747         (testNumbers):
2748
2749 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2750
2751         [WK2] expose element rect for color input type
2752         https://bugs.webkit.org/show_bug.cgi?id=91664
2753
2754         Reviewed by Simon Hausmann.
2755
2756         Update the QML logic in MiniBrowser to take advantage of this.
2757         The picker size is now hardcoded and we try to place it below the
2758         input element if possible.
2759
2760         * MiniBrowser/qt/qml/ColorChooser.qml:
2761
2762 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2763
2764         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2765         https://bugs.webkit.org/show_bug.cgi?id=95329
2766
2767         Reviewed by Kenneth Rohde Christiansen.
2768
2769         Explicitely disable TabToLinks setting in WebKitTestRunner.
2770         Tests override the "WebKitTabToLinksPreferenceKey" preference
2771         to enable it.
2772
2773         * WebKitTestRunner/TestController.cpp:
2774         (WTR::TestController::resetStateToConsistentValues):
2775
2776 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2777
2778         webkit.py gdb pretty printer can't print CString
2779         https://bugs.webkit.org/show_bug.cgi?id=96068
2780
2781         Reviewed by Tony Chang.
2782
2783         Update WTFCStringPrinter to follow r126191.
2784
2785         * gdb/webkit.py:
2786         (WTFCStringPrinter.to_string):
2787
2788 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2789
2790         Rename the ustring() accessor to string()
2791         https://bugs.webkit.org/show_bug.cgi?id=95919
2792
2793         Reviewed by Geoffrey Garen.
2794
2795         Update EFL's DRT.
2796
2797         Fix some string conversion that have been made useless
2798         with recent changes.
2799
2800         * DumpRenderTree/efl/EventSender.cpp:
2801         (keyPadNameFromJSValue):
2802         (keyNameFromJSValue):
2803         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2804         (TestRunner::queueLoad):
2805         (TestRunner::addOriginAccessWhitelistEntry):
2806         (TestRunner::removeOriginAccessWhitelistEntry):
2807         (TestRunner::setUserStyleSheetLocation):
2808         (TestRunner::setValueForUser):
2809         (TestRunner::elementDoesAutoCompleteForElementWithId):
2810         (TestRunner::execCommand):
2811         (TestRunner::findString):
2812         (TestRunner::isCommandEnabled):
2813         (TestRunner::clearApplicationCacheForOrigin):
2814         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2815         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2816         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2817         (toInt):
2818         (TestRunner::overridePreference):
2819         (TestRunner::addUserScript):
2820         (TestRunner::addUserStyleSheet):
2821         (TestRunner::evaluateInWebInspector):
2822         (TestRunner::evaluateScriptInIsolatedWorld):
2823         (TestRunner::setTextDirection):
2824         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2825         (LoadItem::invoke):
2826         (LoadHTMLStringItem::invoke):
2827         (ScriptItem::invoke):
2828
2829 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2830
2831         Extend third-party storage blocking API to optionally allow blocking all storage
2832         https://bugs.webkit.org/show_bug.cgi?id=95915
2833
2834         Reviewed by Brady Eidson.
2835
2836         Modified API test to use new revised API.
2837
2838         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2839         (TestWebKitAPI::TEST):
2840
2841 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2842
2843         AX: WebCore accessibility roles should be cross-platform
2844         https://bugs.webkit.org/show_bug.cgi?id=94870
2845
2846         Reviewed by Chris Fleizach.
2847
2848         Add debug strings to Chromium for new accessibility roles.
2849
2850         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2851         (roleToString):
2852
2853 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2854
2855         AX: Chromium needs access to canvasHasFallbackContent
2856         https://bugs.webkit.org/show_bug.cgi?id=96124
2857
2858         Reviewed by Chris Fleizach.
2859
2860         Distinguish between canvas roles with and without fallback
2861         content on Chromium.
2862
2863         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2864         (getRole):
2865
2866 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2867
2868         Handle non-existant TestExpectations files gracefully
2869         https://bugs.webkit.org/show_bug.cgi?id=96149
2870
2871         Reviewed by Eric Seidel.
2872
2873         Even when we get rid of Skipped files, we shouldn't have each port
2874         require a TestExpectations file for each platform if it doesn't
2875         need one.
2876
2877         * Scripts/webkitpy/layout_tests/port/base.py:
2878         (Port.expectations_dict):
2879         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2880         (PortTest.test_nonexistant_expectations):
2881
2882 2012-09-07  Tony Chang  <tony@chromium.org>
2883
2884         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2885         https://bugs.webkit.org/show_bug.cgi?id=96136
2886
2887         Reviewed by Ojan Vafai.
2888
2889         When we renamed the file to TestExpectations, it was no longer considered a text file so
2890         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2891         from the port object, so I've removed that from the check. I'm not sure what it was
2892         supposed to do.
2893
2894         * Scripts/webkitpy/style/checker.py:
2895         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2896         * Scripts/webkitpy/style/checkers/test_expectations.py:
2897         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2898         (TestExpectationsChecker.check): Remove overrides param.
2899         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2900         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2901
2902 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2903
2904         [EFL] Use same default minimum logical font size in DRT and WTR
2905         https://bugs.webkit.org/show_bug.cgi?id=96116
2906
2907         Reviewed by Martin Robinson.
2908
2909         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2910         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2911         logical font size to 9 to match the value used in WTR.
2912         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2913         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2914         logical font size to 9 (default value in WK2)
2915
2916 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2917
2918         MediaStream API: add RTCPeerConnection::createAnswer
2919         https://bugs.webkit.org/show_bug.cgi?id=96092
2920
2921         Reviewed by Adam Barth.
2922
2923         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2924
2925         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2926         (MockWebRTCPeerConnectionHandler::createOffer):
2927         (MockWebRTCPeerConnectionHandler::createAnswer):
2928         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2929         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2930         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2931         (MockWebRTCPeerConnectionHandler):
2932
2933 2012-09-07  Dean Jackson  <dino@apple.com>
2934
2935         Unreviewed changes to watchlist.
2936
2937         - Add new WebGL and Filters definitions
2938         - Add myself to OpenGL bugs
2939
2940         * Scripts/webkitpy/common/config/watchlist:
2941
2942 2012-09-07  Peter Beverloo  <peter@chromium.org>
2943
2944         Actually trigger the Android Tester
2945         https://bugs.webkit.org/show_bug.cgi?id=96118
2946
2947         Reviewed by Adam Barth.
2948
2949         * BuildSlaveSupport/build.webkit.org-config/config.json:
2950
2951 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2952
2953         New time input needs accessibility
2954         https://bugs.webkit.org/show_bug.cgi?id=96032
2955
2956         Reviewed by Chris Fleizach.
2957
2958         Add support for valueDescription for testing.
2959
2960         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2961         (getValueDescription):
2962         (AccessibilityUIElement::AccessibilityUIElement):
2963         (AccessibilityUIElement::valueDescriptionGetterCallback):
2964         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2965         (AccessibilityUIElement):
2966
2967 2012-09-07  Peter Beverloo  <peter@chromium.org>
2968
2969         Add the google-android-tests build slave to the master's config
2970         https://bugs.webkit.org/show_bug.cgi?id=96113
2971
2972         Reviewed by Csaba Osztrogonác.
2973
2974         * BuildSlaveSupport/build.webkit.org-config/config.json:
2975
2976 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2977
2978         [WK2] [EFL] Set theme for WebKit2 API test runner
2979         https://bugs.webkit.org/show_bug.cgi?id=96100
2980
2981         Reviewed by Kenneth Rohde Christiansen.
2982
2983         Set the theme generated by the build for the WebKit2 API test runner.
2984
2985         * TestWebKitAPI/PlatformEfl.cmake:
2986         * TestWebKitAPI/efl/PlatformWebView.cpp:
2987         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2988
2989 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2990
2991         Unreviewed. Add Gábor Ballabás as contributor.
2992
2993         * Scripts/webkitpy/common/config/committers.py:
2994
2995 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2996
2997         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2998         https://bugs.webkit.org/show_bug.cgi?id=96078
2999
3000         Reviewed by Tor Arne Vestbø.
3001
3002         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
3003
3004         * qmake/mkspecs/features/default_pre.prf:
3005
3006 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3007
3008         [EFL] Add TestExpectations file for efl-wk1
3009         https://bugs.webkit.org/show_bug.cgi?id=96019
3010
3011         Reviewed by Gyuyoung Kim.
3012
3013         Update TestExpectations cascading for EFL port
3014         so that we use efl-wk1 -> efl search paths
3015         for WebKit1 EFL.
3016
3017         * Scripts/webkitpy/layout_tests/port/efl.py:
3018         (EflPort._search_paths):
3019
3020 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
3021
3022         [NRWT] XvfbDriver should stop the Xvfb more aggressively
3023         https://bugs.webkit.org/show_bug.cgi?id=95097
3024
3025         Reviewed by Dirk Pranke.
3026
3027         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
3028         terminating the process does not always work as expected, leading to timeouts
3029         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
3030         as it's not removed by the killed Xvfb process.
3031
3032         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
3033         is tested in different circumstances - whether pixel tests are enabled or not,
3034         with an arbitrary worker number or with an Xorg process already running on the system.
3035         The stopping of the driver is tested by checking that the Xvfb process is truly killed
3036         and then set to None.
3037
3038         * BuildSlaveSupport/kill-old-processes:
3039         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
3040         is left running, potentially clogging up a display at a certain position.
3041         * Scripts/webkitpy/common/system/executive_mock.py:
3042         (MockExecutive.__init__):
3043         The _running_pids is now a dictionary with process names as keys and pids
3044         as values.
3045         (MockExecutive.check_running_pid):
3046         Check whether the passed-in pid is in the _running_pids dictionary's values.
3047         (MockExecutive):
3048         (MockExecutive.running_pids):
3049         This method returns the list of all the process pids of which the name passes
3050         through the process_name_filter.
3051         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3052         Use the Executive object of the port's host to check for running pids and open
3053         new subprocesses or kill them throughout the class.
3054         (XvfbDriver._start):
3055         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
3056         start the server process after it's created.
3057         (XvfbDriver.stop):
3058         Now kills the Xvfb process instead of terminating it and waiting for it to close.
3059         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
3060         (XvfbDriverTest):
3061         (XvfbDriverTest.make_driver):
3062         (XvfbDriverTest.assertDriverStartSuccessful):
3063         (XvfbDriverTest.test_start_no_pixel_tests):
3064         (XvfbDriverTest.test_start_pixel_tests):
3065         (XvfbDriverTest.test_start_arbitrary_worker_number):
3066         (XvfbDriverTest.test_start_existing_xorg_process):
3067         (XvfbDriverTest.test_stop):
3068         (XvfbDriverTest.test_stop.FakeXvfbProcess):
3069
3070 2012-09-06  Peter Beverloo  <peter@chromium.org>
3071
3072         Introduce the Chromium Android Release (Tests) bot
3073         https://bugs.webkit.org/show_bug.cgi?id=95980
3074
3075         Reviewed by Adam Barth.
3076
3077         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
3078         which will be running layout tests on actual Android devices. Right now,
3079         four Galaxy Nexus phones are attached.
3080
3081         * BuildSlaveSupport/build.webkit.org-config/config.json:
3082
3083 2012-09-06  James Robinson  <jamesr@chromium.org>
3084
3085         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
3086         https://bugs.webkit.org/show_bug.cgi?id=96007
3087
3088         Reviewed by Adrienne Walker.
3089
3090         Fixes initialization / settings code to use WebCompositorSupport.
3091
3092         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3093         (main):
3094         * DumpRenderTree/chromium/TestShell.cpp:
3095         (TestShell::initialize):
3096         (TestShell::setPerTilePaintingEnabled):
3097
3098 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3099
3100         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
3101         https://bugs.webkit.org/show_bug.cgi?id=95995
3102
3103         Reviewed by Kenneth Rohde Christiansen.
3104
3105         Provide proper implementation for PlatformWebView::windowFrame()
3106         in EFL's WebKitTestRunner.
3107
3108         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3109         (WTR::PlatformWebView::windowFrame):
3110
3111 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
3112
3113         Fix WTF.Lrint on 32-bit platforms
3114         https://bugs.webkit.org/show_bug.cgi?id=96003
3115
3116         Reviewed by Benjamin Poulain.
3117
3118         Fixed failing WTF.Lrint test on 32-bit platforms.
3119
3120         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3121         (TestWebKitAPI::TEST):
3122
3123 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
3124
3125         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3126         https://bugs.webkit.org/show_bug.cgi?id=95839
3127
3128         Reviewed by Adam Barth.
3129
3130         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3131         up the task definitions a bit. There was no need to have them in the header file.
3132
3133         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3134         (RTCSessionDescriptionRequestSuccededTask):
3135         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3136         (RTCSessionDescriptionRequestFailedTask):
3137         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3138         (RTCVoidRequestTask):
3139         (RTCVoidRequestTask::RTCVoidRequestTask):
3140         (MockWebRTCPeerConnectionHandler::createOffer):
3141         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3142         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3143         (MockWebRTCPeerConnectionHandler::localDescription):
3144         (MockWebRTCPeerConnectionHandler::remoteDescription):
3145         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3146         (MockWebRTCPeerConnectionHandler):
3147
3148 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3149
3150         [Qt] Fix build on Mac OS X 10.6
3151         https://bugs.webkit.org/show_bug.cgi?id=95200
3152
3153         Reviewed by Tor Arne Vestbø.
3154
3155         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
3156         10.7 and newer.
3157
3158         * qmake/mkspecs/features/features.prf:
3159
3160 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3161
3162         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
3163         https://bugs.webkit.org/show_bug.cgi?id=95973
3164
3165         Reviewed by Kenneth Rohde Christiansen.
3166
3167         Correctly map "addSelectionKey" to "Control" modifier
3168         in WKTR's EventSender on other OSes than Mac OS X,
3169         instead of mapping it to the "Meta" modifier.
3170
3171         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3172         (WTR::parseModifier):
3173
3174 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
3175
3176         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
3177         https://bugs.webkit.org/show_bug.cgi?id=95710
3178
3179         Reviewed by Dirk Pranke.
3180
3181         The stdout / stderr output can be None so make sure
3182         we won't raise an exception in this case.
3183
3184         * Scripts/webkitpy/layout_tests/port/driver.py:
3185         (Driver.run_test):
3186
3187 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3188
3189         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
3190         https://bugs.webkit.org/show_bug.cgi?id=95849
3191
3192         Reviewed by Kenneth Rohde Christiansen.
3193
3194         Sanitize URLs passed by the user as program
3195         argument or typed in the URL bar in order to
3196         be more tolerant.
3197
3198         * EWebLauncher/CMakeLists.txt:
3199         * EWebLauncher/main.c:
3200         (main):
3201         * EWebLauncher/url_bar.c:
3202         (_url_bar_url_get_with_protocol):
3203         (on_urlbar_key_down):
3204         * EWebLauncher/url_utils.c: Added.
3205         (has_scheme):
3206         (url_from_user_input): Add utility function to construct a
3207         URL from user input.
3208         * EWebLauncher/url_utils.h: Added.
3209         * MiniBrowser/efl/CMakeLists.txt:
3210         * MiniBrowser/efl/main.c:
3211         (main):
3212
3213 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3214
3215         [Qt] Various small Windows / MSVC build fixes
3216         https://bugs.webkit.org/show_bug.cgi?id=95934
3217
3218         Reviewed by Kenneth Rohde Christiansen.
3219
3220         setFocus takes a boolean as argument: Don't try to implicitly convert
3221         an enum to a boolean, MSVC doesn't like that. The intent here is to
3222         enable focus, so just pass true.
3223
3224         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3225         (WTR::PlatformWebView::focus):
3226
3227 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3228
3229         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
3230         https://bugs.webkit.org/show_bug.cgi?id=95965
3231
3232         Reviewed by Tor Arne Vestbø.
3233
3234         Add ANGLE as a static library module to the Qt WebKit build system.
3235
3236         * qmake/mkspecs/features/default_post.prf:
3237         * qmake/mkspecs/modules/angle.prf: Added.
3238
3239 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
3240
3241         [WK2] Make [Qt]ViewportHandler cross platform
3242         https://bugs.webkit.org/show_bug.cgi?id=91257
3243
3244         Reviewed by Kenneth Rohde Christiansen.
3245
3246         Remove initial scale from viewport info item since it is
3247         set to -1 after applied thus it does not hold any valuable
3248         information.
3249
3250         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3251
3252 2012-09-05  Tony Chang  <tony@chromium.org>
3253
3254         [chromium] Remove dependency on webkit_user_agent
3255         https://bugs.webkit.org/show_bug.cgi?id=95886
3256
3257         Reviewed by Adam Barth.
3258
3259         The code isn't used by DumpRenderTree.
3260
3261         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3262
3263 2012-09-05  Rick Byers  <rbyers@chromium.org>
3264
3265         Update chromium DumpRenderTree for new WebGestureEvent fields
3266         https://bugs.webkit.org/show_bug.cgi?id=95573
3267
3268         Reviewed by James Robinson.
3269
3270         Update EventSender to write gesture details into the appropriate
3271         type-specific WebGestureEvent fields.
3272         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3273         (EventSender::gestureEvent):
3274         (EventSender::gestureFlingStart):
3275
3276 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
3277
3278         NRWT lies about the number of tests that it's skipping when used with --repeat-each
3279         https://bugs.webkit.org/show_bug.cgi?id=95789
3280
3281         Reviewed by Ojan Vafai.
3282
3283         Fix miscalculation in log message.
3284
3285         * Scripts/webkitpy/layout_tests/views/printing.py:
3286         (Printer.print_found):
3287
3288 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
3289
3290         Unreviewed, rolling out r127612, r127660, and r127664.
3291         http://trac.webkit.org/changeset/127612
3292         http://trac.webkit.org/changeset/127660
3293         http://trac.webkit.org/changeset/127664
3294         https://bugs.webkit.org/show_bug.cgi?id=95920
3295
3296         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3297         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3298         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3299         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3300         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3301         (MockWebRTCPeerConnectionHandler::createOffer):
3302         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3303         (MockWebRTCPeerConnectionHandler):
3304         (SuccessCallbackTask):
3305         (FailureCallbackTask):
3306
3307 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3308
3309         Ignore-metrics includes scroll offsets.
3310         https://bugs.webkit.org/show_bug.cgi?id=95845
3311
3312         Reviewed by Dirk Pranke.
3313
3314         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
3315
3316         * Scripts/old-run-webkit-tests:
3317         (stripMetrics):
3318         * Scripts/webkitpy/layout_tests/port/driver.py:
3319         (DriverOutput):
3320
3321 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
3322
3323         Unreviewed test fix.
3324
3325         Including a plugin source file into the build that was added in r127595.
3326
3327         * GNUmakefile.am:
3328
3329 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
3330
3331         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3332         https://bugs.webkit.org/show_bug.cgi?id=95839
3333
3334         Reviewed by Adam Barth.
3335
3336         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3337         up the task definitions a bit. There was no need to have them in the header file.
3338
3339         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3340         (RTCSessionDescriptionRequestSuccededTask):
3341         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3342         (RTCSessionDescriptionRequestFailedTask):
3343         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3344         (RTCVoidRequestTask):
3345         (RTCVoidRequestTask::RTCVoidRequestTask):
3346         (MockWebRTCPeerConnectionHandler::createOffer):
3347         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3348         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3349         (MockWebRTCPeerConnectionHandler::localDescription):
3350         (MockWebRTCPeerConnectionHandler::remoteDescription):
3351         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3352         (MockWebRTCPeerConnectionHandler):
3353
3354 2012-09-05  Kangil Han  <kangil.han@samsung.com>
3355
3356         [EFL] Remove '+=' usage in String
3357         https://bugs.webkit.org/show_bug.cgi?id=95808
3358
3359         Reviewed by Benjamin Poulain.
3360
3361         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
3362
3363         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3364         (descriptionSuitableForTestResult):
3365
3366 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3367
3368         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
3369         https://bugs.webkit.org/show_bug.cgi?id=95842
3370
3371         Reviewed by Kenneth Rohde Christiansen.
3372
3373         Provide proper implementation for TestRunner::pathToLocalResource()
3374         in EFL WKTR, identical to the one for DumpRenderTree.
3375
3376         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3377         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3378         are found my WebKitTestRunner.
3379
3380         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3381         (WTR::TestRunner::pathToLocalResource):
3382
3383 2012-09-05  Brady Eidson  <beidson@apple.com>
3384
3385         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3386         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3387
3388         Reviewed by Andy Estes.
3389
3390         Add a plug-in that always fails to initialize:
3391         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3392         (NPPNewFails):
3393         (NPPNewFails::NPPNewFails):
3394         (NPPNewFails::NPP_New):
3395
3396         Add it to all the project files:
3397         * DumpRenderTree/DumpRenderTree.gypi:
3398         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3399         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3400         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3401         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3402
3403 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3404
3405         [Qt] Fix makefile race condition between derived sources and target
3406
3407         r121966 removed too much of the old qmake logic, including the rule
3408         that ensured that qmake_all would not trigger dual runs of qmake --
3409         one of the derived sources -qmake-all rule, and one for making the
3410         derived sources.
3411
3412         We now follow a similar pattern as before, by introducing a custom
3413         target that explicitly depends on the derived sources' qmake-all before
3414         doing a manual run of make. That ensures a single qmake run for the derived
3415         sources.
3416
3417         https://bugs.webkit.org/show_bug.cgi?id=93847
3418
3419         Reviewed by Csaba Osztrogonác.
3420
3421         * qmake/mkspecs/features/functions.prf:
3422
3423 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3424
3425         WKTR doesn't implement dumpWillCacheResponse()
3426         https://bugs.webkit.org/show_bug.cgi?id=94607
3427
3428         Reviewed by Kenneth Rohde Christiansen.
3429
3430         Define shouldCacheResponse() callback in resource
3431         load client and provide implementation for
3432         dumpWillCacheResponse() in WebKitTestRunner.
3433
3434         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3435         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3436         (WTR::InjectedBundlePage::InjectedBundlePage):
3437         (WTR::InjectedBundlePage::shouldCacheResponse):
3438         (WTR):
3439         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3440         (InjectedBundlePage):
3441         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3442         (WTR::TestRunner::TestRunner):
3443         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3444         (WTR::TestRunner::dumpWillCacheResponse):
3445         (WTR::TestRunner::shouldDumpWillCacheResponse):
3446         (TestRunner):
3447
3448 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3449
3450         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3451         https://bugs.webkit.org/show_bug.cgi?id=92735
3452
3453         Reviewed by Hajime Morita.
3454
3455         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3456
3457         * DumpRenderTree/TestRunner.cpp:
3458         (TestRunner::staticFunctions):
3459         * DumpRenderTree/TestRunner.h:
3460         (TestRunner):
3461         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3462         (TestRunner::addUserStyleSheet):
3463         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3464         (DRTTestRunner::DRTTestRunner):
3465         (DRTTestRunner::hasCustomPageSizeStyle):
3466         * DumpRenderTree/chromium/DRTTestRunner.h:
3467         (DRTTestRunner):
3468         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3469         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3470         * DumpRenderTree/mac/TestRunnerMac.mm:
3471         * DumpRenderTree/qt/TestRunnerQt.cpp:
3472         (TestRunner::evaluateScriptInIsolatedWorld):
3473         * DumpRenderTree/qt/TestRunnerQt.h:
3474         (TestRunner):
3475         * DumpRenderTree/win/TestRunnerWin.cpp:
3476         * DumpRenderTree/wx/TestRunnerWx.cpp:
3477         (TestRunner::abortModal):
3478         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3479         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3480         (WTR):
3481         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3482         (TestRunner):
3483
3484 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3485
3486         [Qt] Automate the use of AllInOne files in the Qt build
3487         https://bugs.webkit.org/show_bug.cgi?id=95837
3488
3489         Reviewed by Tor Arne Vestbø.
3490
3491         New feature file that implements the all-in-one file automation by
3492         adding the requested all-in-one files to SOURCES and removing the files
3493         it includes from SOURCES.
3494
3495         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3496
3497 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3498
3499         Have NRWT log more output when crash logs are missing
3500         https://bugs.webkit.org/show_bug.cgi?id=95814
3501
3502         Reviewed by Dan Bernstein.
3503
3504         Log the stderr and stdout of the test, in order to provide slightly more
3505         context when the WebProcess times out while running tests.
3506
3507         * Scripts/webkitpy/layout_tests/port/driver.py:
3508         (Driver.run_test):
3509
3510 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3511
3512         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3513         https://bugs.webkit.org/show_bug.cgi?id=95770
3514
3515         Reviewed by Adam Barth.
3516
3517         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3518         (ChromiumAndroidDriver.__init__):
3519         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3520         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3521         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3522         (ChromiumAndroidDriver._push_executable):
3523         (ChromiumAndroidDriver._push_fonts):
3524         (ChromiumAndroidDriver._push_test_resources):
3525         (ChromiumAndroidDriver._run_adb_command):
3526         (ChromiumAndroidDriver._get_last_stacktrace):
3527         (ChromiumAndroidDriver._get_crash_log):
3528         (ChromiumAndroidDriver._start):
3529         (ChromiumAndroidDriver._start_once):
3530         (ChromiumAndroidDriver._start_once.deadlock_detector):
3531         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3532         (ChromiumAndroidDriverTest.test_get_crash_log):
3533
3534 2012-09-04  Satish Sampath  <satish@chromium.org>
3535
3536         Run git commands within the checkout directory
3537         https://bugs.webkit.org/show_bug.cgi?id=95742
3538
3539         Reviewed by Eric Seidel.
3540
3541         git commands run from scm/git.py are sometimes run with cwd set to the
3542         checkout_root and other times with whatever directory was the default cwd.
3543         Instead all these should run with the checkout root set as the cwd
3544         (except where we explicitly need a different path)
3545
3546         * Scripts/webkitpy/common/checkout/scm/git.py:
3547         (Git._run_git):
3548         (Git.find_checkout_root):
3549         (Git.discard_local_commits):
3550         (Git.local_commits):
3551         (Git.working_directory_is_clean):
3552         (Git.clean_working_directory):
3553         (Git.add_list):
3554         (Git.delete_list):
3555         (Git.exists):
3556         (Git._current_branch):
3557         (Git._changes_files_for_commit):
3558         (Git.revisions_changing_file):
3559         (Git.svn_revision):
3560         (Git._run_git_svn_find_rev):
3561         (Git.contents_at_revision):
3562         (Git.diff_for_file):
3563         (Git.show_head):
3564         (Git.committer_email_for_revision):
3565         (Git.apply_reverse_diff):
3566         (Git.revert_files):
3567         (Git.commit_with_message):
3568         (Git._commit_on_branch):
3569         (Git.svn_commit_log):
3570         (Git.last_svn_commit_log):
3571         (Git.svn_blame):
3572         (Git._branch_ref_exists):
3573         (Git.delete_branch):
3574         (Git.remote_merge_base):
3575         (Git.commit_locally_with_message):
3576         (Git.push_local_commits_to_server):
3577         (Git.commit_ids_from_commitish_arguments):
3578         (Git.commit_message_for_local_commit):
3579         (Git.files_changed_summary_for_commit):
3580
3581 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3582
3583         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3584         https://bugs.webkit.org/show_bug.cgi?id=95734
3585
3586         Reviewed by Adam Barth.
3587
3588         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3589         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3590         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3591         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3592         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3593         (MockWebRTCPeerConnectionHandler::createOffer):
3594         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3595         (MockWebRTCPeerConnectionHandler):
3596         (MockWebRTCPeerConnectionHandler::taskList):
3597         (SuccessCallbackTask):
3598         (FailureCallbackTask):
3599
3600 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3601
3602         [Chromium-Android] Output time and thread info in crash log
3603         https://bugs.webkit.org/show_bug.cgi?id=95768
3604
3605         Reviewed by Adam Barth.
3606
3607         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3608         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
3609
3610 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3611
3612         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3613         https://bugs.webkit.org/show_bug.cgi?id=95721
3614
3615         Reviewed by Adam Barth.
3616
3617         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3618         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
3619         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3620         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3621         (MockWebMediaStreamCenter):
3622
3623 2012-09-04  Tony Chang  <tony@chromium.org>
3624
3625         Elide test names when running new-run-webkit-tests
3626         https://bugs.webkit.org/show_bug.cgi?id=95626
3627
3628         Reviewed by Dirk Pranke.
3629
3630         When the test name exceeds the number of terminal columns, it leaves
3631         text on the screen. Avoid this by eliding the test name when running
3632         tests. This is similar to what ninja does when compiling.
3633
3634         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3635         (MeteredStream):
3636         (MeteredStream.number_of_columns): Helper method to get number of
3637         terminal columns. Won't work on Win32 python, but meh.
3638         * Scripts/webkitpy/layout_tests/views/printing.py:
3639         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
3640         because stderr appears to be ascii only.
3641         (Printer.print_started_test): Route through _test_status_line.
3642         (Printer.print_finished_test): Route through _test_status_line.
3643         (Printer._print_test_trace): Route through _test_status_line.
3644         (Printer._print_baseline): Route through _test_status_line.
3645         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3646         (test_test_status_line): Test for _test_status_line.
3647
3648 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
3649
3650         [GTK] Print API missing documentation when generating gtkdoc
3651         https://bugs.webkit.org/show_bug.cgi?id=95703
3652
3653         Reviewed by Carlos Garcia Campos.
3654
3655         Print out API missing documentation when generating gtkdoc. This makes it
3656         easier to fix documentation errors.
3657
3658         * gtk/generate-gtkdoc:
3659         (print_missing_api): Added.
3660         (generate_doc): Inline the rebase step, since it now reports an error
3661         when you try to rebase without generating documentation first.
3662         * gtk/gtkdoc.py:
3663         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
3664         generating documentation first to enable a small cleanup at the caller.
3665         (GTKDoc.api_missing_documentation): Added.
3666
3667 2012-09-04  Vincent Scheib  <scheib@chromium.org>
3668
3669         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
3670         https://bugs.webkit.org/show_bug.cgi?id=95628
3671
3672         Reviewed by James Robinson.
3673
3674         Future tests need the ability to respond asynchronously that
3675         pointer lock requests have been accepted or rejected. This patch
3676         adds the following:
3677             testRunner.setPointerLockWillRespondAsynchronously();
3678             testRunner.didAcquirePointerLock();
3679             testRunner.didNotAcquirePointerLock();
3680
3681         Tested in existing test:
3682             pointerlockchange-pointerlockerror-events.html
3683
3684         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3685         (DRTTestRunner::DRTTestRunner):
3686         (DRTTestRunner::didAcquirePointerLock):
3687         (DRTTestRunner::didNotAcquirePointerLock):
3688         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
3689         * DumpRenderTree/chromium/DRTTestRunner.h:
3690         (DRTTestRunner):
3691         * DumpRenderTree/chromium/WebViewHost.cpp:
3692         (WebViewHost::requestPointerLock):
3693         (WebViewHost::didAcquirePointerLock):
3694         (WebViewHost::didNotAcquirePointerLock):
3695         * DumpRenderTree/chromium/WebViewHost.h:
3696         (WebViewHost):
3697         (WebViewHost::setPointerLockWillRespondAsynchronously):
3698
3699 2012-09-04  Ojan Vafai  <ojan@chromium.org>
3700
3701         Move content shell bots to their own builder group
3702         https://bugs.webkit.org/show_bug.cgi?id=95765
3703
3704         Reviewed by Adam Barth.
3705
3706         In their current state of instability, they add too much noise. Once they get more stable,
3707         we can add them back to the regular group or just have them replace the other bots.
3708
3709         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
3710
3711         * TestResultServer/static-dashboards/builders.js:
3712         (isWebkitTestRunner):
3713         (isChromiumContentShellTestRunner):
3714         (isChromiumWebkitTipOfTreeTestRunner):
3715         (loadBuildersList):
3716
3717 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
3718
3719         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
3720         https://bugs.webkit.org/show_bug.cgi?id=95689
3721
3722         Reviewed by Kenneth Rohde Christiansen.
3723
3724         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
3725         So, there are bugs that key events are always generated in url bar although
3726         the user clicked the web view.
3727
3728         This patch recovers the focus of the web view when left button is pressed and
3729         adds for MiniBrowser to toggle the focus when middle button is pressed
3730         like EWebLauncher already did.
3731
3732         * EWebLauncher/main.c:
3733         (on_mouse_down):
3734         * MiniBrowser/efl/main.c:
3735         (on_mouse_down):
3736         (browserCreate):
3737
3738 2012-09-03  Tao Bai  <michaelbai@chromium.org>
3739
3740         Added ANDROID_GDBSERVER definition for Ant
3741         https://bugs.webkit.org/show_bug.cgi?id=95265
3742
3743         Reviewed by Adam Barth.
3744
3745         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
3746         is only used for finding the gdbserver.
3747
3748         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3749         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3750
3751 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
3752
3753         MediaStream API: Add Ice-related functionality to RTCPeerConnection
3754         https://bugs.webkit.org/show_bug.cgi?id=95565
3755
3756         Reviewed by Adam Barth.
3757
3758         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3759         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3760         (MockWebRTCPeerConnectionHandler::updateICE):
3761         (MockWebRTCPeerConnectionHandler::addICECandidate):
3762         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3763         (MockWebRTCPeerConnectionHandler):
3764
3765 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
3766
3767         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
3768         https://bugs.webkit.org/show_bug.cgi?id=95670
3769
3770         Reviewed by Kenneth Rohde Christiansen.
3771
3772         Fix layout issues related to the URL bar in Minibrowser
3773         and EWebLauncher when the window is resized.
3774
3775         The URL bar was not resized accordingly and the Web
3776         page was moved behing the URL bar, hiding part of it.
3777
3778         * EWebLauncher/main.c:
3779         (on_ecore_evas_resize):
3780         (closeWindow):
3781         * EWebLauncher/url_bar.c:
3782         (url_bar_width_set):
3783         (url_bar_add):
3784         * EWebLauncher/url_bar.h:
3785         * MiniBrowser/efl/main.c:
3786         (on_ecore_evas_resize):
3787         (main):
3788
3789 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3790
3791         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3792         https://bugs.webkit.org/show_bug.cgi?id=95605
3793
3794         Reviewed by Dirk Pranke.
3795
3796         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3797
3798         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3799         (ChromiumAndroidPort.check_sys_deps):
3800         (ChromiumAndroidPort.expectations_files):
3801         (ChromiumAndroidPort.clean_up_test_run):
3802
3803 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3804
3805         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3806         https://bugs.webkit.org/show_bug.cgi?id=95180
3807
3808         Reviewed by Chris Fleizach.
3809
3810         The bug that was fixed stood in the way of fully implementing stringValue().
3811         Testing that the bug is fixed requires stringValue() to be fully implemented
3812         and object replacement characters to be printable.
3813
3814         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3815         (replaceCharactersForResults): New method which turns object replacement
3816         characters into "<obj>" so that the characters can be properly shown in
3817         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3818         accessible text of a single object in the accessible tree doesn't mess up
3819         the readibility of the results.
3820         (AccessibilityUIElement::stringValue): Remove the code that immediately
3821         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3822         replaceCharactersForResults() prior to returning the accessible string
3823         value.
3824
3825 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3826
3827         MediaStream API: Add MediaStream management to RTCPeerConnection
3828         https://bugs.webkit.org/show_bug.cgi?id=95543
3829
3830         Reviewed by Adam Barth.
3831
3832         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
3833
3834         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3835         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3836         (MockWebRTCPeerConnectionHandler::addStream):
3837         (MockWebRTCPeerConnectionHandler::removeStream):
3838         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3839         (MockWebRTCPeerConnectionHandler):
3840
3841 2012-08-31  Tony Chang  <tony@chromium.org>
3842
3843         Remove ENABLE_CSS3_FLEXBOX compile time flag
3844         https://bugs.webkit.org/show_bug.cgi?id=95382
3845
3846         Reviewed by Ojan Vafai.
3847
3848         Everyone is already enabling this by default and the spec has stablized.
3849
3850         * Scripts/webkitperl/FeatureList.pm:
3851         * qmake/mkspecs/features/features.pri:
3852
3853 2012-08-31  Pratik Solanki  <psolanki@apple.com>
3854
3855         objc_msgSend and IMP should be cast appropriately before using
3856         https://bugs.webkit.org/show_bug.cgi?id=95242
3857
3858         Reviewed by Benjamin Poulain.
3859
3860         Fix for older compilers. Pass id as the return type to the template
3861         instead of relying on default type.
3862
3863         * DumpRenderTree/mac/DumpRenderTree.mm:
3864         (drt_NSFontManager_availableFontFamilies):
3865         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3866         (WTR::wtr_NSFontManager_availableFontFamilies):
3867
3868 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
3869
3870         nrwt: use scm instead of calling svn directly to get the revision in json results generator
3871         https://bugs.webkit.org/show_bug.cgi?id=89616
3872
3873         Reviewed by Eric Seidel.
3874
3875         Add the new 'executive' optional function argument to the SCM.in_working_directory
3876         class method. This way we get to reuse an Executive instance which is necessary in testing
3877         when we're operating with a mock version of the object.
3878
3879         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
3880         the SCMDetector with the generator's FileSystem and Executive instances.
3881
3882         * Scripts/webkitpy/common/checkout/scm/detection.py:
3883         (SCMDetector.detect_scm_system):
3884         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3885         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
3886         Executive output and test it against expected output.
3887         * Scripts/webkitpy/common/checkout/scm/git.py:
3888         (Git.in_working_directory):
3889         * Scripts/webkitpy/common/checkout/scm/scm.py:
3890         (SCM.in_working_directory):
3891         * Scripts/webkitpy/common/checkout/scm/svn.py:
3892         (SVN.in_working_directory):
3893         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3894         (JSONResultsGeneratorBase.__init__):
3895         (JSONResultsGeneratorBase._get_svn_revision):
3896
3897 2012-08-31  Jon Lee  <jonlee@apple.com>
3898
3899         [Tests] Add basic tests to http/tests/notifications
3900         https://bugs.webkit.org/show_bug.cgi?id=95493
3901         <rdar://problem/12209303>
3902
3903         Reviewed by Alexey Proskuryakov.
3904
3905         Add permission request support for WTR.
3906
3907         * WebKitTestRunner/TestController.cpp:
3908         (WTR::TestController::initialize):
3909         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3910         * WebKitTestRunner/TestController.h:
3911         (TestController):
3912
3913 2012-08-31  Jon Lee  <jonlee@apple.com>
3914
3915         [DRT] Make simulating a web click on a notification a queued task
3916         https://bugs.webkit.org/show_bug.cgi?id=95546
3917         <rdar://problem/12214170>
3918
3919         Reviewed by Alexey Proskuryakov.
3920
3921         Making the web click happen asynchronously better mimics user interaction with the platform.
3922
3923         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3924         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3925         not set.
3926         * DumpRenderTree/mac/DumpRenderTree.mm:
3927         (dump): Assert that the flag is not set.
3928         * DumpRenderTree/mac/TestRunnerMac.mm:
3929         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
3930         notification. In the case where the block gets executed after the flag has been unset, we avoid
3931         performing the click.
3932
3933 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3934
3935         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3936         https://bugs.webkit.org/show_bug.cgi?id=95575
3937
3938         Reviewed by Csaba Osztrogonác.
3939
3940         Output 100% difference in the case of differing image dimensions so
3941         the test harness knows that we won't produce any output further.
3942         This matches the behavior of other ports.
3943
3944         * DumpRenderTree/qt/ImageDiff.cpp:
3945         (main):
3946
3947 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3948
3949         Unreviewed, rolling out r127261.
3950         http://trac.webkit.org/changeset/127261
3951         https://bugs.webkit.org/show_bug.cgi?id=95572
3952
3953         This patch depends on other build fixes (see blockers of bug
3954         95466) which should land first (Requested by milian on
3955         #webkit).
3956
3957         * qmake/mkspecs/features/features.prf:
3958
3959 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3960
3961         [Qt] Support WebKit2/QML on QNX
3962         https://bugs.webkit.org/show_bug.cgi?id=95466
3963
3964         Reviewed by Noam Rosenthal.
3965
3966         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3967         this should finally work now.
3968
3969         * qmake/mkspecs/features/features.prf:
3970
3971 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3972
3973         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3974         https://bugs.webkit.org/show_bug.cgi?id=95400
3975
3976         Reviewed by Dirk Pranke.
3977
3978         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3979
3980         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3981         (ChromiumAndroidPort.skipped_layout_tests):
3982
3983 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3984
3985         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3986         https://bugs.webkit.org/show_bug.cgi?id=95499
3987
3988         Unreviewed. One more fix to avoid trying to run the empty string.
3989
3990         * Scripts/webkitdirs.pm:
3991         (buildAutotoolsProject):
3992
3993 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3994
3995         Unreviewed, rolling out r127171.
3996         http://trac.webkit.org/changeset/127171
3997         https://bugs.webkit.org/show_bug.cgi?id=95505
3998
3999         testRunner does not need dumpWebNotificationCallbacks().
4000         (Requested by jonlee on #webkit).
4001
4002         * DumpRenderTree/TestRunner.cpp:
4003         (TestRunner::TestRunner):
4004         (TestRunner::staticFunctions):
4005         * DumpRenderTree/TestRunner.h:
4006         (TestRunner):
4007         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
4008         (-[MockWebNotificationProvider webView:didShowNotification:]):
4009         (-[MockWebNotificationProvider webView:didClickNotification:]):
4010         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
4011         * DumpRenderTree/mac/UIDelegate.mm:
4012         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
4013
4014 2012-08-30  Pratik Solanki  <psolanki@apple.com>
4015
4016         objc_msgSend and IMP should be cast appropriately before using
4017         https://bugs.webkit.org/show_bug.cgi?id=95242
4018
4019         Reviewed by Benjamin Poulain.
4020
4021         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
4022         to a function pointer with right types when calling objc_msgSend and an
4023         IMP method directly.
4024
4025         * DumpRenderTree/mac/DumpRenderTree.mm:
4026         (drt_NSFontManager_availableFontFamilies):
4027         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
4028         (WTR::wtr_NSFontManager_availableFontFamilies):
4029
4030 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
4031
4032         Replace JSC::UString by WTF::String
4033         https://bugs.webkit.org/show_bug.cgi?id=95271
4034
4035         Reviewed by Geoffrey Garen.
4036
4037         Get rid of UString.
4038
4039         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
4040         * gdb/webkit.py:
4041         (WTFStringPrinter.to_string):
4042         (JSCIdentifierPrinter.to_string):
4043         (JSCJSStringPrinter.to_string):
4044         (add_pretty_printers):
4045
4046 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
4047
4048         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
4049         https://bugs.webkit.org/show_bug.cgi?id=95495
4050
4051         Reviewed by Ojan Vafai.
4052
4053         This is a follow-on to bug 95370 that adds in support for
4054         platform/wk2/TestExpectations and
4055         platform/{mac,win}-$version/TestExpectations.
4056
4057         * Scripts/webkitpy/layout_tests/port/apple.py:
4058         (ApplePort.expectations_files):
4059         * Scripts/webkitpy/layout_tests/port/base.py:
4060         (Port._skipped_file_search_paths):
4061         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4062         (MacTest.test_expectations_files):
4063         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4064         (MockDRTPortTest.make_port):
4065         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4066         (WinPortTest.test_expectations_files):
4067
4068 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
4069
4070         executive.run_in_parallel() hangs if given nothing to do
4071         https://bugs.webkit.org/show_bug.cgi?id=95387
4072
4073         Reviewed by Ojan Vafai.
4074
4075         Check to make sure that Executive.run_in_parallel() requires
4076         a non-empty list of commands to execute; passing an empty list
4077         seems surely like a programming error.
4078
4079         * Scripts/webkitpy/common/system/executive.py:
4080         (Executive.run_in_parallel):
4081         * Scripts/webkitpy/common/system/executive_unittest.py:
4082         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
4083
4084 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
4085
4086         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
4087         https://bugs.webkit.org/show_bug.cgi?id=94746
4088
4089         Reviewed by Ojan Vafai.
4090
4091         Add an assertion to diff_image() to check that we are passing
4092         tolerance=0 explicitly when diffing ref test results.
4093
4094         * Scripts/webkitpy/layout_tests/port/test.py:
4095         (TestPort.diff_image):
4096
4097 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
4098
4099         NRWT should look in mac-wk2 for a TestExpecations file
4100         https://bugs.webkit.org/show_bug.cgi?id=95370
4101
4102         Reviewed by Ojan Vafai.
4103
4104         Adds support for mac-wk2 and win-wk2 to expectations_files()
4105         for the apple mac and apple win ports.
4106         
4107         * Scripts/webkitpy/layout_tests/port/apple.py:
4108         (ApplePort.expectations_files):
4109         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4110         (MacTest.test_expectations_files):
4111         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4112         (WinTest.test_expectations_files):
4113         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4114         (PortTestCase.test_expectations_files):
4115
4116 2012-08-30  Jon Lee  <jonlee@apple.com>
4117
4118         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
4119         https://bugs.webkit.org/show_bug.cgi?id=95232
4120         <rdar://problem/12190776>
4121
4122         Reviewed by Alexey Proskuryakov.
4123
4124         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
4125
4126         * DumpRenderTree/TestRunner.cpp:
4127         (TestRunner::TestRunner):
4128         (dumpWebNotificationCallbacksCallback):
4129         (TestRunner::staticFunctions):
4130         * DumpRenderTree/TestRunner.h:
4131         (TestRunner):
4132         (TestRunner::dumpWebNotificationCallbacks):
4133         (TestRunner::setDumpWebNotificationCallbacks):
4134         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
4135         (-[WebNotification _drt_descriptionSuitableForTestResult]):
4136         (-[MockWebNotificationProvider webView:didShowNotification:]):
4137         (-[MockWebNotificationProvider webView:didClickNotification:]):
4138         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
4139         * DumpRenderTree/mac/UIDelegate.mm:
4140         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
4141
4142 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
4143
4144         MediaStream API: Introduce MediaConstraints
4145         https://bugs.webkit.org/show_bug.cgi?id=95198
4146
4147         Reviewed by Adam Barth.
4148
4149         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
4150
4151         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4152         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4153         (isSupportedConstraint):
4154         (isValidConstraint):
4155         (MockWebRTCPeerConnectionHandler::initialize):
4156         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4157         (MockWebRTCPeerConnectionHandler):
4158
4159 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4160
4161         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
4162         https://bugs.webkit.org/show_bug.cgi?id=95454
4163
4164         Reviewed by Kenneth Rohde Christiansen.
4165
4166         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
4167
4168         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4169         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
4170
4171 2012-08-30  Leo Yang  <leoyang@rim.com>
4172
4173         Update my email address.
4174
4175         Not reviewed.
4176
4177         * Scripts/webkitpy/common/config/committers.py:
4178
4179 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
4180
4181         [NRWT] Add support for recognizing arbitrary process names in crash lines
4182         https://bugs.webkit.org/show_bug.cgi?id=95435
4183
4184         Reviewed by Adam Barth.
4185
4186         When running layout tests in the chromium port using the content shell,
4187         we want to be able to report sub-process crashes as well.
4188
4189         * Scripts/webkitpy/layout_tests/port/driver.py:
4190         (Driver._check_for_driver_crash):
4191         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
4192         (DriverTest.test_check_for_driver_crash):
4193
4194 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
4195
4196         Random test-webkitpy failures on the buildbot
4197         https://bugs.webkit.org/show_bug.cgi?id=95096
4198
4199         Reviewed by Dirk Pranke.
4200
4201         Suppress occasional errors when running test-webkitpy on GTK builders
4202         by running these tests serially. The 64-bit Release builder is especially
4203         prone to these as it can run up to 24 tests in parallel.
4204
4205         Despite the tests not being run in parallel, the testing only lasts a handful
4206         of seconds more, so this is a worthy trade-off to avoid unnecessary
4207         false-alarm redness on the GTK builders.
4208
4209         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4210         (RunPythonTests.start):
4211
4212 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
4213
4214         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
4215         https://bugs.webkit.org/show_bug.cgi?id=95380
4216
4217         Reviewed by Michael Saboff.
4218
4219         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4220         Add very basic tests for String::ascii(). This covers the case of null strings that caused
4221         the crash.
4222
4223 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
4224
4225         AX: Canvas should have a distinct role
4226         https://bugs.webkit.org/show_bug.cgi?id=95248
4227
4228         Reviewed by Chris Fleizach.
4229
4230         Add support for canvas accessibility role.
4231
4232         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4233         (roleToString):
4234
4235 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
4236
4237         [Gtk] Process Gtk 3.4 smooth scroll events properly
4238         https://bugs.webkit.org/show_bug.cgi?id=88070
4239
4240         Added continousMouseScrollBy support in WebKitTestRunner, and added
4241         implementation for gtk, and stub for Qt, mac and EFL.
4242
4243         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
4244         scroll for emulating multi-tick mouseScrollBy events.
4245
4246         Reviewed by Martin Robinson.
4247
4248         * DumpRenderTree/gtk/EventSender.cpp:
4249         (mouseScrollByCallback):
4250         (continuousMouseScrollByCallback):
4251         * WebKitTestRunner/EventSenderProxy.h:
4252         (EventSenderProxy):
4253         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
4254         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4255         (WTR::EventSendingController::mouseScrollBy):
4256         (WTR):
4257         (WTR::EventSendingController::continuousMouseScrollBy):
4258         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4259         (EventSendingController):
4260         * WebKitTestRunner/TestController.cpp:
4261         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
4262         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
4263         (WTR):
4264         (WTR::EventSenderProxy::mouseScrollBy):
4265         (WTR::EventSenderProxy::continuousMouseScrollBy):
4266         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
4267         (WTR):
4268         (WTR::EventSenderProxy::continuousMouseScrollBy):
4269         * WebKitTestRunner/mac/EventSenderProxy.mm:
4270         (WTR::EventSenderProxy::continuousScrollBy):
4271         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
4272         (WTR::EventSenderProxy::continuousMouseScrollBy):
4273         (WTR):
4274
4275 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
4276
4277         [chromium] Support high DIP pixel tests with DumpRenderTree
4278         https://bugs.webkit.org/show_bug.cgi?id=94935
4279
4280         Reviewed by James Robinson.
4281
4282         Adding device scale factor into the drt image dumping code
4283
4284         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4285         (DRTTestRunner::reset):
4286         (DRTTestRunner::setBackingScaleFactor):
4287         * DumpRenderTree/chromium/WebViewHost.cpp:
4288         (WebViewHost::setDeviceScaleFactor):
4289         (WebViewHost::paintInvalidatedRegion):
4290         (WebViewHost::canvas):
4291         * DumpRenderTree/chromium/WebViewHost.h:
4292         (WebViewHost):
4293
4294 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
4295
4296         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
4297         https://bugs.webkit.org/show_bug.cgi?id=95177
4298
4299         Reviewed by Dirk Pranke.
4300
4301         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
4302
4303         * Scripts/webkitpy/common/checkout/scm/git.py:
4304
4305 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
4306
4307         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
4308         https://bugs.webkit.org/show_bug.cgi?id=95222
4309
4310         Reviewed by Adam Barth.
4311
4312         The code we had to remove REBASELINE lines from the
4313         TestExpectations files did not handle multiple files (in a
4314         cascade) correctly; we weren't limiting lines to a particular
4315         file correctly in without_rebaseline_modifier(). This patch
4316         fixes that and corrects the tests (which weren't correct and
4317         didn't cover things very well).
4318
4319         Note also that the webkit-patch rebaseline-commands are still
4320         using the include_overrides=False option in a couple places;
4321         this is never correct or needed at this point. This patch fixes
4322         the usage for webkit-patch rebaseline-expectations, but I still
4323         need to fix rebaseline-test-internal, which I will do in a
4324         separate patch (see bug 95268).
4325
4326         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4327         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
4328         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4329         (RebaseliningTest.assertRemove):
4330         (RebaseliningTest.test_remove):
4331         * Scripts/webkitpy/tool/commands/rebaseline.py:
4332         (RebaselineExpectations._update_expectations_files):
4333
4334 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
4335
4336         webkit-patch rebaseline-expectations hangs
4337         https://bugs.webkit.org/show_bug.cgi?id=95243
4338
4339         Reviewed by Tony Chang.
4340
4341         Don't try to run no commands in parallel; report an error
4342         instead that we didn't find any tests to rebaseline.
4343
4344         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
4345
4346         * Scripts/webkitpy/tool/commands/rebaseline.py:
4347         (RebaselineExpectations.execute):
4348         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4349         (_assert_command):
4350         (test_rebaseline_expectations_noop):