[Qt] Fix qt_minimal build
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
2
3         Reviewed by Andreas Kling.
4
5         [Qt] Fix qt_minimal build
6         https://bugs.webkit.org/show_bug.cgi?id=53172
7
8         * QtTestBrowser/locationedit.h:
9
10 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
11
12         Reviewed by Antonio Gomes.
13
14         QtTestBrowser should have a UI Setting to disable plugins
15         https://bugs.webkit.org/show_bug.cgi?id=52408
16         
17         Added a new action item named "Disable Plugins"
18         under the "Settings" menu. 
19
20         * QtTestBrowser/launcherwindow.cpp:
21         (LauncherWindow::createChrome):
22         (LauncherWindow::togglePlugins):
23         * QtTestBrowser/launcherwindow.h:
24
25 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
26
27         Reviewed by Adam Barth.
28
29         Move main CMakeLists.txt into Source directory
30         https://bugs.webkit.org/show_bug.cgi?id=52888
31
32         * Scripts/webkitdirs.pm:
33
34 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
35
36         Reviewed by Eric Seidel.
37
38         Improve label text in submit-to-ews
39         https://bugs.webkit.org/show_bug.cgi?id=53130
40
41         * QueueStatusServer/templates/submittoews.html:
42
43 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
44
45         Reviewed by Antonio Gomes.
46
47         QtTestBrowser should have a UI Settings to prevent loading images
48         https://bugs.webkit.org/show_bug.cgi?id=52409
49         
50         Added a new action item named "DisableAutoLoadImages"
51         under the "Settings" menu 
52
53         * QtTestBrowser/launcherwindow.cpp:
54         (LauncherWindow::createChrome):
55         (LauncherWindow::toggleAutoLoadImages):
56         * QtTestBrowser/launcherwindow.h:
57
58 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
59
60         Reviewed by Tony Chang.
61
62         Minor bug fixes and cleanup for filesystem wrappers, port/* test
63         classes, test_expectations.py. This change adds "test-win" and
64         "test-mac" variants to the test port so that we can better test
65         rebaselining, and adds a MockUser() object for reuse in testing.
66
67         https://bugs.webkit.org/show_bug.cgi?id=53036
68
69         * Scripts/webkitpy/common/system/filesystem.py:
70         * Scripts/webkitpy/common/system/filesystem_mock.py:
71         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
72         * Scripts/webkitpy/layout_tests/port/factory.py:
73         * Scripts/webkitpy/layout_tests/port/base.py:
74         * Scripts/webkitpy/layout_tests/port/test.py:
75         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
76         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
77         * Scripts/webkitpy/tool/mocktool.py:
78
79 2011-01-25  Tony Chang  <tony@chromium.org>
80
81         Reviewed by Dimitri Glazkov.
82
83         [chromium] remove unused layoutTestController callback
84         https://bugs.webkit.org/show_bug.cgi?id=53103
85
86         This method is used by a test_shell_test, but not needed by DRT.
87
88         * DumpRenderTree/chromium/LayoutTestController.cpp:
89         (LayoutTestController::LayoutTestController):
90         * DumpRenderTree/chromium/LayoutTestController.h:
91
92 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
93
94         Reviewed by Andreas Kling.
95
96         [GTK] Remove 64 bits release bot from the buildbot master
97         https://bugs.webkit.org/show_bug.cgi?id=52899
98
99         Removes the 64 bits release slave from the buildbot configuration,
100         so that we can use it as an EWS.
101
102         * BuildSlaveSupport/build.webkit.org-config/config.json:
103
104 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
105
106         Reviewed by Dan Bernstein.
107
108         Implement database quota callback to fix storage tests on WebKit2 bot
109         https://bugs.webkit.org/show_bug.cgi?id=53064
110
111         * WebKitTestRunner/TestController.cpp:
112         (WTR::exceededDatabaseQuota):
113         (WTR::TestController::createOtherPage):
114         (WTR::TestController::initialize):
115
116 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
117
118         Reviewed by Anders Carlsson.
119
120         Use designated temp directory for the database for WebKit2
121         https://bugs.webkit.org/show_bug.cgi?id=53052
122         
123         Adopt the new WK2 API for this.
124
125         * WebKitTestRunner/TestController.cpp:
126         (WTR::TestController::libraryPathForTesting):
127         (WTR::TestController::initialize):
128         * WebKitTestRunner/TestController.h:
129         * WebKitTestRunner/mac/TestControllerMac.mm:
130         (WTR::TestController::platformLibraryPathForTesting):
131         * WebKitTestRunner/qt/TestControllerQt.cpp:
132         (WTR::TestController::platformLibraryPathForTesting):
133         * WebKitTestRunner/win/TestControllerWin.cpp:
134         (WTR::TestController::platformLibraryPathForTesting):
135
136 2011-01-24  Lucas Forschler  <lforschler@apple.com>
137
138         Reviewed by Stephanie Lewis.
139
140         Add a new Leopard test bot.
141
142         * BuildSlaveSupport/build.webkit.org-config/config.json:
143
144 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
145
146         Reviewed by Adam Barth.
147
148         Add EFL Builder to core waterfall
149         https://bugs.webkit.org/show_bug.cgi?id=52704
150
151         Add EFL Builder to the core waterfall again.
152
153         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
154         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
155
156 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
157
158         Reviewed by Tony Chang.
159
160         new-run-webkit-tests fails to start HTTP server if there are proxy settings
161         https://bugs.webkit.org/show_bug.cgi?id=52872
162
163         Force disabling proxy to resolve the problem.
164
165         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
166         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
167
168 2011-01-24  Andreas Kling  <kling@webkit.org>
169
170         Reviewed by Darin Adler.
171
172         check-webkit-style: Update exemptions following Source/ move.
173         https://bugs.webkit.org/show_bug.cgi?id=53017
174
175         * Scripts/webkitpy/style/checker.py:
176         * Scripts/webkitpy/style/checker_unittest.py:
177
178 2011-01-24  Andras Becsi  <abecsi@webkit.org>
179
180         Rubber-stamped by Csaba Osztrogonác.
181
182         [Qt] Move project files into Source
183         https://bugs.webkit.org/show_bug.cgi?id=52891
184
185         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
186
187 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
188
189         Reviewed by Yury Semikhatsky.
190
191         Web Inspector: Find duplicate strings in localizedStrings.js
192
193         https://bugs.webkit.org/show_bug.cgi?id=53005
194
195         * Scripts/check-inspector-strings:
196
197 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
198
199         Reviewed by Andreas Kling.
200
201         [Qt] Regroup MiniBrowser's menubar and add open file action
202         https://bugs.webkit.org/show_bug.cgi?id=53000
203
204         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
205
206         * MiniBrowser/qt/BrowserWindow.cpp:
207         (BrowserWindow::BrowserWindow):
208         (BrowserWindow::openFile):
209         (BrowserWindow::~BrowserWindow):
210         * MiniBrowser/qt/BrowserWindow.h:
211
212 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
213
214         Unreviewed fix after r76496
215
216         [Qt] Move project files into Source
217         https://bugs.webkit.org/show_bug.cgi?id=52891
218
219         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
220         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
221         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
222
223 2011-01-24  Andras Becsi  <abecsi@webkit.org>
224
225         Reviewed by Csaba Osztrogonác.
226
227         [Qt] Move project files into Source
228         https://bugs.webkit.org/show_bug.cgi?id=52891
229
230         * DerivedSources.pro: Renamed from DerivedSources.pro.
231         * DumpRenderTree/qt/DumpRenderTree.pro:
232         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
233         * MiniBrowser/DerivedSources.pro:
234         * MiniBrowser/qt/MiniBrowser.pro:
235         * QtTestBrowser/QtTestBrowser.pro:
236         * Scripts/webkitdirs.pm:
237         * Tools.pro: Added.
238         * WebKitTestRunner/DerivedSources.pro:
239         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
240         * WebKitTestRunner/qt/WebKitTestRunner.pro:
241
242 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
243
244         Reviewed by Dan Bernstein.
245
246         Beefed up --threaded mode to catch even more kinds of errors.
247         https://bugs.webkit.org/show_bug.cgi?id=52971
248
249         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
250         context group to force JSC to mark multiple threads. (This used to be
251         the default, but it changed in SnowLeopard.)
252         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
253         to give threading mistakes more chances to show themselves.
254         (startJavaScriptThreads):
255         (stopJavaScriptThreads):
256
257 2011-01-22  Robert Hogan  <robert@webkit.org>
258
259         Reviewed by Andreas Kling.
260
261         [Qt] Support layoutTestController.addURLToRedirect()
262         https://bugs.webkit.org/show_bug.cgi?id=52956
263
264         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
265         (LayoutTestController::addURLToRedirect):
266         * DumpRenderTree/qt/LayoutTestControllerQt.h:
267
268 2011-01-22  Robert Hogan  <robert@webkit.org>
269
270         Reviewed by Kenneth Rohde Christiansen.
271
272         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
273         https://bugs.webkit.org/show_bug.cgi?id=49802
274
275         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
276         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
277         (WebCore::DumpRenderTree::open):
278
279 2011-01-21  Adam Barth  <abarth@webkit.org>
280
281         Reviewed by Maciej Stachowiak.
282
283         Disable mac_unittest.py that fails on some of the Mac bots
284         https://bugs.webkit.org/show_bug.cgi?id=52947
285
286         As noted in the comment, this test does not appear to be correct
287         because the function this test is testing returns different results
288         depending on which flavor of Mac the test is run on.  This patch
289         disable the test.  Hopefully we can re-enable the test once we've
290         probably insulated the test from its environment.
291
292         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
293
294 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
295
296         Reviewed by Mihai Parparita.
297
298         Fix bug introduced in r76322 that caused NRWT to not actually
299         read the Skipped files properly.
300
301         https://bugs.webkit.org/show_bug.cgi?id=52771
302
303         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
304         * Scripts/webkitpy/layout_tests/port/webkit.py:
305         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
306
307 2011-01-21  Sam Weinig  <sam@webkit.org>
308
309         Reviewed by Geoffrey Sean Garen and Mark Rowe.
310
311         WebKitTestRunner needs the HOME environment variable to be set.
312         <rdar://problem/8896573>
313
314         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
315         it exists.
316
317 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
318
319         Reviewed by Eric Seidel.
320
321         Suppress a few remaining integration tests so that none of the
322         layout_test unit tests ever read from the filesystem or launch
323         subprocesses that aren't part of the unit tests.
324
325         Also fix a minor bug in the printing unit tests that was
326         incorrectly relying on sys.argv.
327
328         https://bugs.webkit.org/show_bug.cgi?id=52863
329
330         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
331         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
332         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
333
334 2011-01-21  Darin Adler  <darin@apple.com>
335
336        Fix Mac build.
337
338         * MiniBrowser/mac/BrowserWindowController.m:
339         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
340
341 2011-01-20  Darin Adler  <darin@apple.com>
342
343         Reviewed by Dan Bernstein.
344
345         WebKit2: Implement showModalDialog
346         https://bugs.webkit.org/show_bug.cgi?id=52855
347
348         This fixes WebKitTestRunner to compile, but more work is probably
349         needed to get it to pass the tests.
350
351         * WebKitTestRunner/TestController.cpp:
352         (WTR::TestController::runModal): Added. Calls through to the
353         platform-specific version of runModal.
354         (WTR::TestController::createOtherPage): Changed to be a private
355         static member function so it can refer to runModal, which is
356         a private static member function.
357         (WTR::TestController::initialize): Pass 0 for the runModal
358         function since we don't need to run the main window modal.
359         I suspect this is wrong and will need to change.
360         * WebKitTestRunner/TestController.h: Added declarations for
361         the functions added above.
362         * WebKitTestRunner/mac/TestControllerMac.mm:
363         (WTR::TestController::runModal): Added. Untested implementation.
364         * WebKitTestRunner/qt/TestControllerQt.cpp:
365         (WTR::TestController::runModal): Added.
366         * WebKitTestRunner/win/TestControllerWin.cpp:
367         (WTR::TestController::runModal): Added.
368
369 2011-01-21  Eric Seidel  <eric@webkit.org>
370
371         Reviewed by Adam Barth.
372
373         Split Host object off from WebKitPatch for easier re-use
374         https://bugs.webkit.org/show_bug.cgi?id=52284
375
376         new-run-webkit-tests and other tools are eventually going to want one of these.
377         Basically you need to inherit from this class if you want to pretend to be a
378         self.tool object for Steps/Commands.
379
380         * Scripts/webkitpy/common/host.py: Added.
381         * Scripts/webkitpy/tool/main.py:
382
383 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
384
385         Reviewed by Adam Barth.
386
387         Disable the tests that start and stop the http server and web
388         server, so that we don't have to worry about port collisions on
389         the bots.
390
391         https://bugs.webkit.org/show_bug.cgi?id=52861
392
393         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
394
395 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
396
397         Reviewed by Eric Seidel.
398
399         nrwt: rewrite google_chrome_unittest to use mock filesystem.
400         
401         https://bugs.webkit.org/show_bug.cgi?id=52772
402         
403         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
404
405 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
406
407         Reviewed by Eric Siedel.
408
409         nrwt: clean up almost all remaining port references, remove
410         unnecessary import clauses. The only remaining references are
411         in places where a mock filesystem makes no sense or can't be
412         used, and in one routine in port/google_chrome_unittest that
413         I'll rewrite in a separate patch.
414
415         https://bugs.webkit.org/show_bug.cgi?id=52771
416
417         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
418         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
419         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
420         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
421         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
422         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
423         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
424         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
425         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
426         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
427         * Scripts/webkitpy/layout_tests/port/gtk.py:
428         * Scripts/webkitpy/layout_tests/port/mac.py:
429         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
430         * Scripts/webkitpy/layout_tests/port/qt.py:
431         * Scripts/webkitpy/layout_tests/port/webkit.py:
432         * Scripts/webkitpy/layout_tests/port/win.py:
433         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
434
435 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
436
437         Reviewed by Mihai Parparita.
438
439         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
440
441         https://bugs.webkit.org/show_bug.cgi?id=52762
442
443         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
444         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
445
446 2011-01-20  Tony Chang  <tony@chromium.org>
447
448         Reviewed by Ojan Vafai.
449
450         [chromium] fix the paths used for the rebaseline tool
451         https://bugs.webkit.org/show_bug.cgi?id=52857
452
453         Some of the bots were renamed so the path to grab the results zip
454         file has changed.
455
456         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
457
458 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
459
460         Reviewed by Tony Chang.
461
462         Fix bug introduced in r72688 / bug 52768 that broke the
463         generation of the output filename links in the results.html
464         output. Apparently none of the unit tests actually checked to
465         make sure the generated links were correct :(
466
467         https://bugs.webkit.org/show_bug.cgi?id=52854
468
469         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
470         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
471
472 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
473
474         Reviewed by Darin Adler.
475
476         https://bugs.webkit.org/show_bug.cgi?id=52849
477         Make window.print work with WebKit2
478
479         * MiniBrowser/mac/BrowserWindowController.m:
480         (-[BrowserWindowController awakeFromNib]):
481         * WebKitTestRunner/TestController.cpp:
482         (WTR::createOtherPage):
483         (WTR::TestController::initialize):
484         Added zeroes to WKPageUIClient structures to avoid build failures.
485
486 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
487
488         Reviewed by Eric Seidel.
489
490         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
491
492         https://bugs.webkit.org/show_bug.cgi?id=52756
493
494         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
495         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
496         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
497         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
498         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
499         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
500
501 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
502
503         Reviewed by Antonio Gomes.
504
505         QtTestBrowser should have a seperate menu for Settings
506         https://bugs.webkit.org/show_bug.cgi?id=52817
507         
508         Added a new menu item named "Settings"
509         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
510
511         * QtTestBrowser/launcherwindow.cpp:
512         (LauncherWindow::createChrome):
513
514 2011-01-20  Sam Weinig  <sam@webkit.org>
515
516         Reviewed by John Sullivan.
517
518         Update update-webkit-localizable-strings with new path to WebKit.
519
520         * Scripts/update-webkit-localizable-strings:
521
522 2011-01-20  James Robinson  <jamesr@chromium.org>
523
524         Reviewed by Darin Fisher.
525
526         Implement mozilla's requestAnimationFrame API
527         https://bugs.webkit.org/show_bug.cgi?id=51218
528
529         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
530
531         * DumpRenderTree/chromium/WebViewHost.cpp:
532         (invokeScheduleComposite):
533         (WebViewHost::scheduleAnimation):
534         (WebViewHost::paintInvalidatedRegion):
535         * DumpRenderTree/chromium/WebViewHost.h:
536
537 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
538
539         Reviewed by Adam Roben.
540
541         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
542         https://bugs.webkit.org/show_bug.cgi?id=42327
543
544         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
545         for methods that take their normal arguments but also a JSContextRef.
546         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
547         for evaluateScriptInIsolatedWorld.
548         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
549         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
550         this call is for an isolated world.
551         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
552         (WTR::worldMap): Helper to create a world map.
553         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
554         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
555         added LayoutTestController API.
556         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
557
558 2011-01-19  Adam Roben  <aroben@apple.com>
559
560         Convert paths in environment variables back to msys-style inside commit-log-editor
561
562         When this script gets run from inside git commit, msys-style paths in the environment will
563         have been turned into Windows-style paths with forward slashes. This screws up functions
564         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
565         the paths back to msys-style before doing anything else.
566
567         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
568         using msysgit's Perl and multiple ChangeLogs have been edited
569
570         Reviewed by David Kilzer.
571
572         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
573         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
574         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
575
576 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
577
578         [Win] Unreviewed build fix after r76248.
579
580         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
581
582 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
583
584         Reviewed by Csaba Osztrogonác.
585
586         Refactoring of the custom allocation framework
587         https://bugs.webkit.org/show_bug.cgi?id=49897
588
589         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
590         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
591         equivalent macro implementation at the necessary places.
592 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
593
594         Unreviewed. 
595
596         Adding myself to committers.py.
597
598         * Scripts/webkitpy/common/config/committers.py:
599
600 2011-01-20  Adam Barth  <abarth@webkit.org>
601
602         Reviewed by Tony Chang.
603
604         Chromium builders don't delete unversioned directories when DEPS change
605         https://bugs.webkit.org/show_bug.cgi?id=52745
606
607         If we pass this option to gclient sync, gclient will delete directories
608         that are no longer part of DEPS instead of leaving them around to
609         confuse us later.  Apparently, the downstream buildbots use this option
610         already.
611
612         * Scripts/update-webkit-chromium:
613
614 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
615
616         Unreviewed, build fix - I pulled this patch in to fix an issue
617         revealed by r76195 running on some new bots). Also fix a couple
618         of other issues revealed in testing.
619
620         nrwt: remove fs refs from layout_package/json*
621
622         https://bugs.webkit.org/show_bug.cgi?id=52754
623
624         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
625         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
626         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
627         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
628         * Scripts/webkitpy/layout_tests/port/base.py:
629
630 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
631
632         Unreviewed, build fix.
633
634         Fix a couple of minor bugs discovered while bringing up new bots
635         for testing.
636
637         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
638         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
639
640 2011-01-19  James Robinson  <jamesr@chromium.org>
641
642         Unreviewed, rolling out r76194.
643         http://trac.webkit.org/changeset/76194
644         https://bugs.webkit.org/show_bug.cgi?id=51218
645
646         Caused mysterious compile failure on the chromium win
647         build.webkit.org bots
648
649         * DumpRenderTree/chromium/WebViewHost.cpp:
650         (WebViewHost::paintInvalidatedRegion):
651         * DumpRenderTree/chromium/WebViewHost.h:
652
653 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
654
655         Reviewed by Mihai Parparita.
656
657         remove fs refs from test_runner, dump_render_tree_thread
658
659         https://bugs.webkit.org/show_bug.cgi?id=52753
660
661         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
662         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
663         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
664         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
665
666 2011-01-19  James Robinson  <jamesr@chromium.org>
667
668         Reviewed by Darin Fisher.
669
670         Implement mozilla's requestAnimationFrame API
671         https://bugs.webkit.org/show_bug.cgi?id=51218
672
673         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
674
675         * DumpRenderTree/chromium/WebViewHost.cpp:
676         (invokeScheduleComposite):
677         (WebViewHost::scheduleAnimation):
678         (WebViewHost::paintInvalidatedRegion):
679         * DumpRenderTree/chromium/WebViewHost.h:
680
681 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
682
683         Unreviewed, build fix.
684
685         Fix a few incorrect "self._filesystem" references introduced in
686         r76184.
687
688         * Scripts/webkitpy/layout_tests/port/chromium.py:
689         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
690
691 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
692
693         Reviewed by Mihai Parparita.
694
695         add a .sep property, abspath(), isabs(), mtime(), and
696         open_text_file_for_writing() to filesystem modules. Some of
697         these properties are not needed in this patch but will be needed
698         in subsequent patches (I'm doing this to avoid having to track
699         multiple versions of a single file).
700
701         Also, change most of the port/* modules to use the filesystem
702         objects instead of referencing the filesystem directly.
703
704         https://bugs.webkit.org/show_bug.cgi?id=52748
705
706         * Scripts/webkitpy/common/system/filesystem.py:
707         * Scripts/webkitpy/common/system/filesystem_mock.py:
708         * Scripts/webkitpy/layout_tests/port/__init__.py:
709         * Scripts/webkitpy/layout_tests/port/base.py:
710         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
711         * Scripts/webkitpy/layout_tests/port/chromium.py:
712         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
713         * Scripts/webkitpy/layout_tests/port/config.py:
714         * Scripts/webkitpy/layout_tests/port/test.py:
715         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
716
717 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
718
719         Reviewed by Anders Carlsson.
720
721         If resetting between tests times out, treat it as a WebProcess crash
722         https://bugs.webkit.org/show_bug.cgi?id=52757
723
724         * WebKitTestRunner/TestController.cpp:
725         (WTR::TestController::runTest):
726
727 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
728
729         Reviewed by Darin Adler.
730
731         https://bugs.webkit.org/show_bug.cgi?id=52739
732         Make it possible for a WebKit2 client to print headers and footers
733
734         Added dummy implementations for new printing UIClient calls.
735
736         * MiniBrowser/mac/BrowserWindowController.m:
737         (-[BrowserWindowController awakeFromNib]):
738         * WebKitTestRunner/TestController.cpp:
739         (WTR::createOtherPage):
740         (WTR::TestController::initialize):
741
742 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
743
744         Reviewed by Ojan Vafai.
745
746         Change webkitpy/layout_tests/port/test.py to use the
747         in-memory filesystem for cleaner unit testing. This
748         change allows us to kill a lot of code that was
749         specific to the test port, at the cost of being a
750         little less clear about how things would work if
751         you didn't have a filesystem.
752
753         https://bugs.webkit.org/show_bug.cgi?id=52605
754
755         * Scripts/webkitpy/layout_tests/port/test.py:
756
757 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
758
759         Unreviewed, build fix.
760
761         Fix test failure caused by committing attachment 79368 instead
762         of attachment 79461 on bug 52604.
763
764         * Scripts/webkitpy/common/system/filesystem_mock.py:
765
766 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
767
768         Reviewed by Mihai Parparita.
769
770         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
771         unit testing. os.walk() is too much of a hassle to implement on
772         top of the in-memory mock filesystem and adding the necessary
773         interface to files_under() gives clients a cleaner API anyway
774         (for this particular usage model).
775
776         https://bugs.webkit.org/show_bug.cgi?id=52691
777
778         * Scripts/webkitpy/common/system/filesystem.py:
779         * Scripts/webkitpy/common/system/filesystem_mock.py:
780         * Scripts/webkitpy/layout_tests/port/test_files.py:
781         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
782
783 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
784
785         Reviewed by Tony Chang.
786
787         Change more modules in the layout-tests code to use the
788         filesystem wrapper for cleaner unit testing.
789
790         This patch also adds the glob() wrapper to the filesystem
791         abstraction.
792         
793         https://bugs.webkit.org/show_bug.cgi?id=52604
794
795         * Scripts/webkitpy/layout_tests/port/test_files.py:
796         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
797         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
798         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
799         * Scripts/webkitpy/common/system/filesystem.py:
800         * Scripts/webkitpy/common/system/filesystem_mock.py:
801
802 2011-01-19  Levi Weintraub  <leviw@chromium.org>
803
804         Unreviewed.
805
806         Updating my email addresses and irc nick.
807
808         * Scripts/webkitpy/common/config/committers.py:
809
810 2011-01-19  Tony Chang  <tony@chromium.org>
811
812         Reviewed by Mihai Parparita.
813
814         [chromium] [linux] if check-sys-deps fails, output the failure reason
815         https://bugs.webkit.org/show_bug.cgi?id=52671
816
817         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
818             error handler functions.
819         * Scripts/webkitpy/layout_tests/port/chromium.py:
820             output the error text from --check-sys-deps
821         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
822
823 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
824
825         Reviewed by Andreas Kling.
826
827         [Qt] QtTestBrowser crashes when closing if Facebook is opened
828         https://bugs.webkit.org/show_bug.cgi?id=52554
829         
830         QtNetworkAccessManager is created in a thread and set as
831         member variable in QWebPage. When the thread is destroyed
832         the object is still used. So fix will set the object to
833         NULL once the thread is destroyed.
834
835         * QtTestBrowser/launcherwindow.cpp:
836         (LauncherWindow::~LauncherWindow):
837
838 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
839
840         Rubber stamped by Csaba Osztrogonac
841
842         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
843
844 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
845
846         Reviewed by Tony Chang.
847
848         new-run-webkit-tests: add a --build-directory command line argument
849
850         Official Google Chrome builds use a non-standard build directory
851         location. This patch adds a --build-directory argument that
852         allows that location to be specified on the command line. Only
853         Chromium-based builds will use this flag for now, but anyone can
854         in the future.
855
856         There are no unit tests for this since it's difficult to test
857         until mock filesystems are fully supported in the code. This was
858         tested by hand for now.
859
860         https://bugs.webkit.org/show_bug.cgi?id=52694
861
862         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
863         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
864         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
865         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
866
867 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
868
869         Not reviewed. Bot fix.
870
871         Remove an inadvertently committed debugging print.
872
873         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
874         (LayoutTestController::notifyDone):
875
876 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
877
878         Reviewed by Sam Weinig.
879
880         WebKitTestRunner should track loading more like DumpRenderTree
881         https://bugs.webkit.org/show_bug.cgi?id=52692
882
883         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
884         This makes some tests that call notifyDone multiple times pass.
885         
886         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
887         (WTR::InjectedBundle::InjectedBundle):
888         (WTR::InjectedBundle::done):
889         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
890         (WTR::InjectedBundle::topLoadingFrame):
891         (WTR::InjectedBundle::setTopLoadingFrame):
892         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
893         (WTR::InjectedBundlePage::InjectedBundlePage):
894         (WTR::InjectedBundlePage::stopLoading):
895         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
896         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
897         (WTR::InjectedBundlePage::didFinishLoadForFrame):
898         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
899         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
900         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
901         (WTR::LayoutTestController::notifyDone):
902         * WebKitTestRunner/TestController.cpp:
903         (WTR::TestController::didReceiveMessageFromInjectedBundle):
904
905 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
906
907         Reviewed by Kent Tamura.
908
909         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
910         https://bugs.webkit.org/show_bug.cgi?id=52678
911         
912         Update path now that WebKit is inside Source.
913
914         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
915
916 2011-01-18  Robert Hogan  <robert@webkit.org>
917
918         Reviewed by Simon Hausmann.
919
920         [Qt] http/tests/incremental/slow-utf8-text.pl fails
921         https://bugs.webkit.org/show_bug.cgi?id=44282
922
923         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
924         (WebCore::DumpRenderTree::dump):
925
926 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
927
928         Reviewed by Mihai Parparita.
929
930         Fix a small race condition that could cause the unit tests for
931         new-run-webkit-tests to fail in a multithreaded environment.
932         There was a small window in the code where one thread would
933         check to see if a thread had raised an exception, do something,
934         and then check to see if the thread was alive. If the other
935         thread raised an exception and exited in between these two
936         steps, the exception would be lost. Flipping the order of the
937         two checks fixes the race, since we will now always check for an
938         exception on the thread before exiting.
939
940         https://bugs.webkit.org/show_bug.cgi?id=51579
941
942         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
943
944 2011-01-18  Eric Seidel  <eric@webkit.org>
945
946         Reviewed by Adam Barth.
947
948         commit-queue dies when test archiving fails
949         https://bugs.webkit.org/show_bug.cgi?id=52617
950
951         I looked at the machine and it had 10 archives already
952         thus find_unused_name was returning None.  I've upped
953         the limit to 100 (per bug) and tested the case where
954         find_unused_name returns None (making archive return None).
955
956         * Scripts/webkitpy/common/system/workspace.py:
957         * Scripts/webkitpy/common/system/workspace_unittest.py:
958         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
959         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
960         * Scripts/webkitpy/tool/commands/queues.py:
961
962 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
963
964         Reviewed by Ojan Vafai.
965
966         Update rebaseline-chromium-webkit-tests unit tests to use a mock
967         filesystem. Also fix a couple of "with" statements missed by
968         r76050.
969
970         https://bugs.webkit.org/show_bug.cgi?id=52487
971
972         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
973
974 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
975
976         Reviewed by Martin Robinson.
977
978         [Gtk] Build fixes for gtk3 build
979         https://bugs.webkit.org/show_bug.cgi?id=52648
980
981         * DumpRenderTree/gtk/EventSender.cpp:
982         (beginDragWithFilesCallback):
983
984 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
985
986         Reviewed by Mihai Parparita.
987
988         Update rebaseline-chromium-webkit-tests to use filesystem objects
989         instead of direct references to os.path, shutil, tempfile, etc.
990
991         This patch doesn't change anything, but will allow subsequent
992         patches to change the unit tests to no longer use the real
993         filesystem.
994
995         This patch adds a bunch more methods to the filesystem object as
996         well.
997
998         https://bugs.webkit.org/show_bug.cgi?id=52482
999
1000         * Scripts/webkitpy/common/system/filesystem.py:
1001         * Scripts/webkitpy/common/system/filesystem_mock.py:
1002         * Scripts/webkitpy/tool/commands/queues.py:
1003         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1004         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1005
1006 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1007
1008         Reviewed by Mihai Parparita.
1009
1010         new-run-webkit-tests shouldn't crash when you try to run a
1011         directory containing only skipped files.
1012
1013         https://bugs.webkit.org/show_bug.cgi?id=52478
1014         
1015         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1016         * Scripts/webkitpy/layout_tests/port/test.py:
1017         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1018
1019 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1020
1021         Reviewed by Gustavo Noronha Silva.
1022
1023         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1024         https://bugs.webkit.org/show_bug.cgi?id=40833
1025
1026         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1027         GTK+ event sender.
1028         (dragWithFilesDragDataGetCallback): Added.
1029         (dragWithFilesDragEndCallback): Added.
1030         (beginDragWithFilesCallback): Added.
1031
1032 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1033
1034         Reviewed by Adam Barth.
1035
1036         ews: Add additional watcher to efl ews
1037         https://bugs.webkit.org/show_bug.cgi?id=52613
1038
1039         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1040
1041         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1042
1043 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1044
1045         Reviewed by Alexey Proskuryakov.
1046
1047         Fix some headers with missing or misspelled #ifndef guards
1048         https://bugs.webkit.org/show_bug.cgi?id=52545
1049
1050         * DumpRenderTree/chromium/TestEventPrinter.h:
1051         * DumpRenderTree/chromium/WebPreferences.h:
1052
1053 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1054
1055         Reviewed by Anders Carlsson.
1056
1057         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1058         navigating back to an unreachable URL
1059         https://bugs.webkit.org/show_bug.cgi?id=52388
1060
1061         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1062
1063         * DumpRenderTree/LayoutTestController.cpp:
1064         (queueLoadHTMLStringCallback):
1065         (LayoutTestController::queueLoadHTMLString):
1066         (LayoutTestController::queueLoadAlternateHTMLString):
1067         * DumpRenderTree/LayoutTestController.h:
1068
1069         * DumpRenderTree/WorkQueueItem.h:
1070         (LoadHTMLStringItem::LoadHTMLStringItem):
1071
1072         * DumpRenderTree/chromium/LayoutTestController.cpp:
1073         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1074         (WorkItemLoadHTMLString::run):
1075         (LayoutTestController::queueLoadHTMLString):
1076
1077         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1078         (LoadHTMLStringItem::invoke):
1079         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1080         (LoadHTMLStringItem::invoke):
1081         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1082         (LoadHTMLStringItem::invoke):
1083
1084 2011-01-17  Dan Bernstein  <mitz@apple.com>
1085
1086         Rubber-stamped by Mark Rowe.
1087
1088         Update xcodeproj svn:ignore to include xcuserdata.
1089
1090         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1091         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1092         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1093         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1094         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1095
1096 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1097
1098         Unreviewed fix after r75908.
1099
1100         Move WebKit into Source
1101         https://bugs.webkit.org/show_bug.cgi?id=52530
1102
1103         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1104
1105 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1106
1107         Unreviewed.
1108
1109         Remove accidentally committed debug printing after r75908.
1110
1111         * Scripts/webkitdirs.pm:
1112
1113 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1114
1115         Unreviewed.
1116
1117         Add myself to committers list
1118         https://bugs.webkit.org/show_bug.cgi?id=52566
1119
1120         * Scripts/webkitpy/common/config/committers.py:
1121
1122 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1123
1124         Reviewed by Jeremy Orlow.
1125
1126         GeolocationController should call stopUpdating on destruction
1127         https://bugs.webkit.org/show_bug.cgi?id=52216
1128
1129         fast/dom/Geolocation/window-close-crash.html requires that a
1130         Geolocation watch be started in a secondary window. Consequently,
1131         we need to allow geolocation permission and provide a mock
1132         geolocation position for the secondary window's
1133         GeolocationClientMock.
1134
1135         * DumpRenderTree/chromium/LayoutTestController.cpp:
1136         (LayoutTestController::setGeolocationPermission):
1137         (LayoutTestController::setMockGeolocationPosition):
1138         (LayoutTestController::setMockGeolocationError):
1139         * DumpRenderTree/chromium/TestShell.h:
1140         (TestShell::windowList):
1141
1142 2011-01-16  Adam Barth  <abarth@webkit.org>
1143
1144         Update more include paths to reflect WebKit move.
1145
1146         * DumpRenderTree/chromium/EventSender.cpp:
1147         (EventSender::keyDown):
1148         (EventSender::needsShiftModifier):
1149         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1150         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1151
1152 2011-01-16  Kent Tamura  <tkent@chromium.org>
1153
1154         Unreviewed, Chromium build fix.
1155
1156         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1157
1158 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1159
1160         Build fix for GTK+ after source directory movement.
1161
1162         * GNUmakefile.am: Correct include paths.
1163
1164 2011-01-16  Adam Barth  <abarth@webkit.org>
1165
1166         Teach svn-apply about WebKit move.
1167
1168         * Scripts/VCSUtils.pm:
1169
1170 2011-01-16  Adam Barth  <abarth@webkit.org>
1171
1172         Rubber-stamped by Eric Seidel.
1173
1174         Move WebKit into Source
1175         https://bugs.webkit.org/show_bug.cgi?id=52530
1176
1177         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1178         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1179         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1180         * DumpRenderTree/qt/GCControllerQt.cpp:
1181         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1182         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1183         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1184         * DumpRenderTree/wscript:
1185         * QtTestBrowser/launcherwindow.h:
1186         * Scripts/build-webkit:
1187         * Scripts/webkitdirs.pm:
1188
1189 2011-01-15  Adam Barth  <abarth@webkit.org>
1190
1191         Teach svn-apply about WebKit2 move.
1192
1193         * Scripts/VCSUtils.pm:
1194
1195 2011-01-15  Adam Barth  <abarth@webkit.org>
1196
1197         Rubber-stamped by Eric Seidel.
1198
1199         Move WebKit2 into Source
1200         https://bugs.webkit.org/show_bug.cgi?id=52438
1201
1202         * MiniBrowser/qt/MiniBrowser.pro:
1203         * Scripts/build-webkit:
1204         * Scripts/do-file-rename:
1205         * Scripts/do-webcore-rename:
1206         * Scripts/test-webkitpy:
1207         * Scripts/webkitdirs.pm:
1208         * Scripts/webkitpy/style/checker.py:
1209         * WebKitTestRunner/DerivedSources.pro:
1210         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1211         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1212
1213 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1214
1215         Reviewed by David Levin.
1216
1217         [chromium] remove obsolete createView method
1218         https://bugs.webkit.org/show_bug.cgi?id=52437
1219
1220         * DumpRenderTree/chromium/WebViewHost.cpp:
1221         (WebViewHost::createView):
1222         * DumpRenderTree/chromium/WebViewHost.h:
1223
1224 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1225
1226         Reviewed by Geoff Garen.
1227
1228         ShouldLoadResourceForFrame should use strings, not URLs.
1229         https://bugs.webkit.org/show_bug.cgi?id=52476
1230
1231         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1232         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1233         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1234
1235 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1236
1237         Reviewed by David Levin.
1238
1239         Add Tony Gentilcore as a reviewer
1240         https://bugs.webkit.org/show_bug.cgi?id=52480
1241
1242         * Scripts/webkitpy/common/config/committers.py:
1243
1244 2011-01-14  David Levin  <levin@chromium.org>
1245
1246         Reviewed by Eric Seidel.
1247
1248         check-webkit-style: _FunctionState should keep track of where the function name starts.
1249         https://bugs.webkit.org/show_bug.cgi?id=52454
1250
1251         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1252         _FunctionState and logic for setting it correctly.
1253         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1254
1255 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1256
1257         Reviewed by David Levin.
1258
1259         Add support to DumpRenderTree to use the GPU rather than software renderer
1260         https://bugs.webkit.org/show_bug.cgi?id=52333
1261
1262         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1263         (main):
1264         * Scripts/webkitpy/layout_tests/port/chromium.py:
1265         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1266
1267 2011-01-14  Tony Chang  <tony@chromium.org>
1268
1269         Reviewed by Kent Tamura.
1270
1271         [chromium] update fonts.conf to fix 6 linux tests in drt
1272         https://bugs.webkit.org/show_bug.cgi?id=52411
1273
1274         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1275             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1276
1277 2011-01-14  Eric Seidel  <eric@webkit.org>
1278
1279         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1280
1281         Reviewed by Adam Barth.
1282
1283         Fix when running Tools/Scripts/check-webkit-style without arguments.
1284         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1285
1286         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1287         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1288
1289 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1290
1291         Reviewed by David Levin.
1292
1293         Store the tempdir object in a variable so it doesn't get deleted too early.
1294         https://bugs.webkit.org/show_bug.cgi?id=51875
1295
1296         * Scripts/update-webkit-auxiliary-libs:
1297         * Scripts/update-webkit-support-libs:
1298
1299 2011-01-14  Eric Seidel  <eric@webkit.org>
1300
1301         Unreviewed.  Make it work in python 2.5.
1302
1303         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1304         https://bugs.webkit.org/show_bug.cgi?id=49158
1305
1306         * Scripts/webkitpy/common/checkout/api_unittest.py:
1307
1308 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1309
1310         Unreviewed, rolling out r75774.
1311         http://trac.webkit.org/changeset/75774
1312         https://bugs.webkit.org/show_bug.cgi?id=52431
1313
1314         gtk builds were broken (Requested by loislo2 on #webkit).
1315
1316         * Scripts/webkitpy/common/checkout/scm.py:
1317
1318 2011-01-14  David Levin  <levin@chromium.org>
1319
1320         Reviewed by Shinichiro Hamaji.
1321
1322         check-webkit-style: _FunctionState should detect pure functions.
1323         https://bugs.webkit.org/show_bug.cgi?id=52428
1324
1325         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1326         is a pure virtual function.
1327         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1328         virtual functions are correctly detected.
1329
1330 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1331
1332         Reviewed by Yury Semikhatsky.
1333
1334         Just small fix for problem with check-webkit-style.
1335         It just didn't work for this patch.
1336         Old code can't concatenate a list of strings with None.
1337
1338         * Scripts/webkitpy/common/checkout/scm.py:
1339
1340 2011-01-13  David Levin  <levin@chromium.org>
1341
1342         Reviewed by Shinichiro Hamaji.
1343
1344         check-webkit-style: _FunctionState should use Position to know where items are.
1345         https://bugs.webkit.org/show_bug.cgi?id=52424
1346
1347         * Scripts/webkitpy/style/checkers/cpp.py:
1348         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1349         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1350         did some minor clean-up.
1351         (*): Other changes are simply about converting to use the Position's in_FunctionState
1352         instead of line numbers.
1353         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1354         to verify the positions stored in _FunctionState.
1355
1356 2011-01-13  Eric Seidel  <eric@webkit.org>
1357
1358         Reviewed by David Levin.
1359
1360         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1361         https://bugs.webkit.org/show_bug.cgi?id=49158
1362
1363         This is not the most elegant, but it is a very safe fix to this bug.
1364         One advantage of catching ScriptError like this instead of adding a
1365         new added_or_modified_files or fixing all changed_files callers
1366         to use a more specific change_files variant, is that we catch
1367         all kinds of ScriptErrors which might cause our (non-essential)
1368         suggest-reviewers code to fail out.  This should make passing
1369         --suggest-reviewers to webkit-patch upload much more robust
1370         and may even make it possible for us to make it default.
1371
1372         The root of the problem here is that SCM.changed_files includes
1373         deleted ChangeLog paths (from moves, etc) which then when we ask
1374         SVN/Git for the contents of the file at that revision, the command
1375         errors out and Executive.run_command raises a ScriptError.
1376
1377         In the future we might fix this differently by making all current
1378         callers of chagned_files use a more specific method for requesting
1379         what types of changes they're interested in (adds, modifies, deletes, etc.)
1380
1381         * Scripts/webkitpy/common/checkout/api.py:
1382         * Scripts/webkitpy/common/checkout/api_unittest.py:
1383
1384 2011-01-13  Dan Bernstein  <mitz@apple.com>
1385
1386         Reviewed by Alexey Proskuryakov.
1387
1388         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1389         https://bugs.webkit.org/show_bug.cgi?id=52419
1390
1391         Allow to further control the behavior of the willSendRequest delegate callback by making it
1392         set a different URL in the new request.
1393
1394         * DumpRenderTree/LayoutTestController.cpp:
1395         (addURLToRedirectCallback): Added.
1396         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1397         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1398         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1399         * DumpRenderTree/LayoutTestController.h:
1400         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1401         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1402         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1403         change the URL in the new request to the redirect destination.
1404
1405 2011-01-13  Eric Seidel  <eric@webkit.org>
1406
1407         Reviewed by Mihai Parparita.
1408
1409         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1410         https://bugs.webkit.org/show_bug.cgi?id=52416
1411
1412         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1413         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1414
1415         I also added FIXMEs about the changed_files returning deleted files problem
1416         which is causing the other most common exception for suggest-reviewers
1417         (and is probably breaking sheriff-bots blame detection).
1418
1419         * Scripts/webkitpy/common/checkout/api.py:
1420         * Scripts/webkitpy/common/checkout/api_unittest.py:
1421         * Scripts/webkitpy/common/checkout/scm.py:
1422
1423 2011-01-13  Eric Seidel  <eric@webkit.org>
1424
1425         Reviewed by Adam Barth.
1426
1427         results archives from commit-queue are too large to upload
1428         https://bugs.webkit.org/show_bug.cgi?id=52405
1429
1430         * Scripts/webkitpy/common/system/filesystem.py:
1431         * Scripts/webkitpy/common/system/filesystem_mock.py:
1432         * Scripts/webkitpy/tool/commands/queues.py:
1433
1434 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1435
1436         Reviewed by Martin Robinson.
1437
1438         [gtk] Zero-sized font does not yet work
1439         https://bugs.webkit.org/show_bug.cgi?id=49793
1440
1441         Set minimum-font-size to 0 for the DRT.
1442
1443         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1444         (resetDefaultsToConsistentValues):
1445
1446 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1447
1448         Reviewed by Darin Adler.
1449
1450         Make old-run-webkit-tests more robust on buildbots
1451         https://bugs.webkit.org/show_bug.cgi?id=52364
1452
1453         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1454
1455 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1456
1457         Reviewed by Darin Adler.
1458
1459         Make old-run-webkit-tests more robust on buildbots
1460         https://bugs.webkit.org/show_bug.cgi?id=52364
1461
1462         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1463
1464 2011-01-13  Tony Chang  <tony@chromium.org>
1465
1466         Reviewed by Kent Tamura.
1467
1468         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1469         https://bugs.webkit.org/show_bug.cgi?id=52332
1470
1471         Forked Info.plist is not longer needed.
1472
1473         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1474
1475 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1476
1477         Reviewed by Timothy Hatcher.
1478
1479         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1480         to be passed directly to WebInspector.UIString
1481
1482         https://bugs.webkit.org/show_bug.cgi?id=52365
1483
1484         * Scripts/check-inspector-strings:
1485
1486 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1487
1488         Unreviewed, rolling out r74881.
1489         http://trac.webkit.org/changeset/74881
1490         https://bugs.webkit.org/show_bug.cgi?id=52357
1491
1492         The EFL builder has been red for days (Requested by abarth on
1493         #webkit).
1494
1495         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1496         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1497
1498 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1499
1500         Reviewed by David Levin.
1501
1502         Add beforeunload support to WebKitTestRunner
1503         https://bugs.webkit.org/show_bug.cgi?id=52353
1504         
1505         This makes a number of currently failing tests pass.
1506
1507         * WebKitTestRunner/TestController.cpp:
1508         (WTR::runBeforeUnloadConfirmPanel):
1509         (WTR::createOtherPage):
1510         (WTR::TestController::initialize):
1511
1512 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1513
1514         Reviewed by Sam Weinig.
1515
1516         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1517         https://bugs.webkit.org/show_bug.cgi?id=52330
1518
1519         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1520         a web process crash.
1521         * WebKitTestRunner/TestController.cpp:
1522         (WTR::TestController::initialize): Set up a processDidCrash
1523         callback.
1524         (WTR::TestController::processDidCrash): Report that the Web process
1525         crashed.
1526         * WebKitTestRunner/TestController.h:
1527
1528 2011-01-12  David Levin  <levin@chromium.org>
1529
1530         Reviewed by Shinichiro Hamaji.
1531
1532         check-webkit-style -- close_expression function doesn't work correctly.
1533         https://bugs.webkit.org/show_bug.cgi?id=52272
1534
1535         * Scripts/webkitpy/style/checkers/cpp.py:
1536         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1537         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1538         generally useful (for upcoming code changes).
1539         (close_expression): Changed to use Position for input and output.
1540         Also, fixed many bugs such as only working correctly for parenthesis,
1541         not working correctly if given an offset in a line and not finding
1542         the real closing element if there were multiple closing elements in
1543         the same line.
1544         (detect_functions): Adjusted due to the change in arguments for
1545         close_expression.
1546         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1547         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1548         two positions are the same.
1549         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1550         (CppStyleTest.test_close_expression): Added tests to catch the issues
1551         that were fixed.
1552
1553 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1554
1555         Unreviewed, rolling out r75576.
1556         http://trac.webkit.org/changeset/75576
1557         https://bugs.webkit.org/show_bug.cgi?id=52304
1558
1559         broke rebaseline-chromium-webkit-test (Requested by thakis on
1560         #webkit).
1561
1562         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1563         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1564         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1565         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1566         * Scripts/webkitpy/layout_tests/port/base.py:
1567         * Scripts/webkitpy/layout_tests/port/chromium.py:
1568         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1569         * Scripts/webkitpy/layout_tests/port/test.py:
1570         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1571         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1572         * Scripts/webkitpy/style/checkers/test_expectations.py:
1573         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1574
1575 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1576
1577         Reviewed by Darin Adler.
1578
1579         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1580         https://bugs.webkit.org/show_bug.cgi?id=52307
1581
1582         * Scripts/old-run-webkit-tests:
1583
1584 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1585
1586         Reviewed by Martin Robinson.
1587
1588         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1589         https://bugs.webkit.org/show_bug.cgi?id=50867
1590
1591         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1592         TestNetscapePlugin.cpp 
1593
1594         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1595         * Scripts/webkitdirs.pm:
1596
1597 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1598
1599         Reviewed by Pavel Feldman.
1600
1601         Add check-inspector-strings script.
1602
1603         https://bugs.webkit.org/show_bug.cgi?id=52295
1604
1605         * Scripts/check-inspector-strings: Added.
1606
1607 2011-01-12  Adam Roben  <aroben@apple.com>
1608
1609         Advertise the .testnetscape file extension on Windows
1610
1611         Fixes <http://webkit.org/b/52298>
1612         plugins/no-mime-with-valid-extension.html fails on Windows
1613
1614         Reviewed by Dan Bernstein.
1615
1616         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1617         FileExtents field to map the .testnetscape file extension to the
1618         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1619
1620 2011-01-12  Adam Barth  <abarth@webkit.org>
1621
1622         Reviewed by Eric Seidel.
1623
1624         Make webkit-patch support subdirectories for SVN checkouts
1625         https://bugs.webkit.org/show_bug.cgi?id=52261
1626
1627         os.relpath does not exist on Python 2.5, so we need to call our version
1628         of the API.
1629
1630         * Scripts/webkitpy/common/checkout/scm.py:
1631
1632 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1633
1634         Reviewed by Eric Seidel.
1635
1636         Close additional pages opened during a test once the test completes.
1637         https://bugs.webkit.org/show_bug.cgi?id=52276
1638
1639         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1640         (WTR::InjectedBundle::done):
1641
1642 2011-01-11  David Levin  <levin@chromium.org>
1643
1644         Reviewed by Eric Seidel.
1645
1646         Errors should be separated from the command line in bot messages.
1647         https://bugs.webkit.org/show_bug.cgi?id=52275
1648
1649         * Scripts/webkitpy/common/system/executive.py:
1650         (ScriptError.message_with_output): Added a newline to separate the command
1651         line from the errors.
1652         * Scripts/webkitpy/common/system/executive_unittest.py:
1653         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1654         paths in message_with_output.
1655
1656 2011-01-11  Eric Seidel  <eric@webkit.org>
1657
1658         Unreviewed.
1659
1660         commit-queue should know how to upload archived results (for test flakes or general failures)
1661         https://bugs.webkit.org/show_bug.cgi?id=52048
1662
1663         The zips are mostly empty due to forgetting -r.
1664         Expected diffs were not being pulled from the archive due
1665         to the archive having longer paths than I realized.
1666
1667         * Scripts/webkitpy/common/system/workspace.py:
1668         * Scripts/webkitpy/common/system/workspace_unittest.py:
1669         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1670         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1671
1672 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1673
1674         Reviewed by Ojan Vafai.
1675
1676         The current modifier parsing code in test_expectations is
1677         fragile and hard-coded, so it's not easy to understand the logic
1678         or easily add new types of modifiers (like GPU vs. CPU testing
1679         for graphics tests, or 32-bit vs. 64-bit differences).
1680
1681         This is the first of two patches that will add in more generic
1682         support and then eliminate the GPU-specific test expectations
1683         files for Chromium.
1684
1685         This patch adds two standalone objects for handling modifiers. The
1686         rules for interpreting modifiers, precedence, and conflicts are
1687         given in the docstring to the ModifierMatcher class, which
1688         returns ModifierMatchResult objects.
1689         
1690         This patch also adds routines to the Port interface and a
1691         default set of values in the base object, in order to obtain the
1692         values needed on a given test run. These values are then passed
1693         to the expectation parser. This also allows us to clean up the
1694         logic used to lint all of the different configurations in a
1695         single test_expectations.txt file.
1696
1697         The next patch will merge in the separate GPU expectations file.
1698
1699         https://bugs.webkit.org/show_bug.cgi?id=51222
1700
1701         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1702         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1703         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1704         * Scripts/webkitpy/layout_tests/port/base.py:
1705         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1706         * Scripts/webkitpy/layout_tests/port/chromium.py:
1707         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1708         * Scripts/webkitpy/layout_tests/port/test.py:
1709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1710         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1711
1712 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1713
1714         Reviewed by Adam Barth.
1715
1716         Make webkit-patch support subdirectories for SVN checkouts
1717         https://bugs.webkit.org/show_bug.cgi?id=52261
1718
1719         * Scripts/webkitpy/common/checkout/scm.py:
1720         * Scripts/webkitpy/style_references.py:
1721         * Scripts/webkitpy/tool/main.py:
1722         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1723
1724 2011-01-11  Eric Seidel  <eric@webkit.org>
1725
1726         Unreviewed.
1727
1728         commit-queue should know how to upload archived results (for test flakes or general failures)
1729         https://bugs.webkit.org/show_bug.cgi?id=52048
1730
1731         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1732         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1733
1734         * Scripts/webkitpy/common/system/workspace.py:
1735         * Scripts/webkitpy/common/system/workspace_unittest.py:
1736         * Scripts/webkitpy/tool/commands/queues.py:
1737
1738 2011-01-11  Sam Weinig  <sam@webkit.org>
1739
1740         Roll r75474 back in.
1741
1742 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1743
1744         Reviewed by Kenneth Rohde Christiansen.
1745
1746         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1747         https://bugs.webkit.org/show_bug.cgi?id=51204
1748
1749         * QtTestBrowser/webpage.h:
1750         (QtNAMThread::QtNAMThread):
1751         (QtNAMThread::networkAccessManager):
1752         (QtNAMThread::run):
1753
1754 2011-01-11  Peter Varga  <pvarga@webkit.org>
1755
1756         Unreviewed.
1757
1758         Add myself to committers' list.
1759
1760         * Scripts/webkitpy/common/config/committers.py:
1761
1762 2011-01-11  Eric Seidel  <eric@webkit.org>
1763
1764         Reviewed by Adam Barth.
1765
1766         commit-queue should know how to upload archived results (for test flakes or general failures)
1767         https://bugs.webkit.org/show_bug.cgi?id=52048
1768
1769         Now the queue will always upload results.  Either the entire zip, or just
1770         the diffs.txt in the case of text failures.
1771
1772         This should make understanding flakes much easier, and paves the way
1773         for having the EWS run layout tests (and upload failures).
1774
1775         In order to upload .zip files I had to teach bugzilla.py to autodetect
1776         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1777         for .patch files, I have it add one before calling guess_type.
1778
1779         We may find that always uploading the whole zip instead of just the -diffs.txt
1780         file is preferable, but for now I'm keeping the old behavior because it makes
1781         quickly understanding text failures easy.
1782
1783         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1784         * Scripts/webkitpy/common/system/workspace.py: Added.
1785         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1786         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1787         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1788         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1789         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1790         * Scripts/webkitpy/tool/commands/queues.py:
1791         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1792
1793 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1794
1795         Unreviewed, rolling out r75464.
1796         http://trac.webkit.org/changeset/75464
1797         https://bugs.webkit.org/show_bug.cgi?id=52193
1798
1799         Followup rollout for 75474 (Requested by Ossy on #webkit).
1800
1801         * MiniBrowser/mac/BrowserWindowController.m:
1802         (-[BrowserWindowController awakeFromNib]):
1803         * MiniBrowser/win/BrowserView.cpp:
1804         (BrowserView::create):
1805         * WebKitTestRunner/TestController.cpp:
1806         (WTR::createOtherPage):
1807         (WTR::TestController::initialize):
1808
1809 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1810
1811         Reviewed by Csaba Osztrogonác.
1812
1813         [Qt] Baseline qt_minimal configuration
1814         https://bugs.webkit.org/show_bug.cgi?id=51313
1815
1816         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1817         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1818         QT_NO_UNDOSTACK guard.
1819
1820         * QtTestBrowser/launcherwindow.cpp:
1821         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1822         guards.
1823         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1824         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1825         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1826         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1827
1828         * QtTestBrowser/launcherwindow.h:
1829         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1830         * QtTestBrowser/locationedit.h: Ditto.
1831
1832         * QtTestBrowser/mainwindow.cpp:
1833         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1834         QT_NO_UNDOSTACK guards.
1835         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1836         (MainWindow::changeLocation): Ditto.
1837         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1838         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1839
1840         * QtTestBrowser/webpage.cpp:
1841         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1842         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1843
1844         * QtTestBrowser/webview.cpp:
1845         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1846         (WebViewGraphicsBased::animatedYFlip): Ditto.
1847
1848 2011-01-10  Sam Weinig  <sam@webkit.org>
1849
1850         Fix build.
1851
1852         * MiniBrowser/mac/BrowserWindowController.m:
1853         (-[BrowserWindowController awakeFromNib]):
1854         * MiniBrowser/win/BrowserView.cpp:
1855         (BrowserView::create):
1856         * WebKitTestRunner/TestController.cpp:
1857         (WTR::createOtherPage):
1858         (WTR::TestController::initialize):
1859
1860 2011-01-10  Eric Seidel  <eric@webkit.org>
1861
1862         Reviewed by Ojan Vafai.
1863
1864         style-queue messages are way too long for big patches
1865         https://bugs.webkit.org/show_bug.cgi?id=52161
1866
1867         We definitely could build much fancier list-to-string-with-limit functions
1868         but this should be sufficient for our needs at the moment.
1869
1870         * Scripts/webkitpy/common/system/executive.py:
1871         * Scripts/webkitpy/common/system/executive_unittest.py:
1872
1873 2011-01-10  Tony Chang  <tony@chromium.org>
1874
1875         Unreviewed, rolling out r75398.
1876         http://trac.webkit.org/changeset/75398
1877         https://bugs.webkit.org/show_bug.cgi?id=52008
1878
1879         Some layout tests are crashing on Chromium Win.
1880
1881         * DumpRenderTree/chromium/WebViewHost.cpp:
1882         (WebViewHost::updatePaintRect):
1883         * DumpRenderTree/chromium/WebViewHost.h:
1884
1885 2011-01-10  Adam Roben  <aroben@apple.com>
1886
1887         Roll out r75392
1888
1889         It isn't needed now that r75289 has been rolled out.
1890
1891         * Scripts/run-javascriptcore-tests:
1892
1893 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1894
1895         Reviewed by Anders Carlsson.
1896
1897         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1898         https://bugs.webkit.org/show_bug.cgi?id=52160
1899
1900         * WebKitTestRunner/mac/TestControllerMac.mm:
1901         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1902         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1903         anyway.
1904
1905 2011-01-10  Tony Chang  <tony@chromium.org>
1906
1907         Reviewed by Mihai Parparita.
1908
1909         [chromium] fix for animated gif layout tests
1910         https://bugs.webkit.org/show_bug.cgi?id=52008
1911
1912         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1913             to trigger gif animations.
1914         (WebViewHostPaintTask::WebViewHostPaintTask):
1915         (WebViewHostPaintTask::runIfValid):
1916         (WebViewHost::updatePaintRect):
1917         * DumpRenderTree/chromium/WebViewHost.h:
1918         (WebViewHost::taskList):
1919
1920 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1921
1922         Reviewed by Xan Lopez.
1923
1924         [GTK] Fix gtk2 compilation for master
1925         https://bugs.webkit.org/show_bug.cgi?id=51885
1926
1927         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1928         (createBitmapContextFromWebView): Replaced the old
1929         gdk_drawable_get_size with gdk_pixmap_get_size.
1930
1931 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1932
1933         Reviewed by Laszlo Gombos.
1934
1935         [WINCE] Reenable NPAPI after r75203
1936         https://bugs.webkit.org/show_bug.cgi?id=52109
1937
1938         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1939         it with !isEfl(), because EFL port does not support NPAPI (yet).
1940
1941         * Scripts/build-webkit:
1942
1943 2011-01-10  Adam Roben  <aroben@apple.com>
1944
1945         Skip some asserting JS tests
1946
1947         See <http://webkit.org/b/52156>.
1948
1949         * Scripts/run-javascriptcore-tests:
1950
1951 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1952
1953         Reviewed by Xan Lopez.
1954
1955         [GTK] build-webkit disable Blob support via arguments passed to automake
1956         https://bugs.webkit.org/show_bug.cgi?id=52097
1957
1958         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1959         build-webkit.
1960
1961 2011-01-10  Adam Roben  <aroben@apple.com>
1962
1963         Use the same name and description for TestNetscapePlugin on Windows and
1964         Mac
1965
1966         Fixes <http://webkit.org/b/52151>
1967         fast/frames/iframe-reparenting-plugins.html fails on Windows
1968
1969         Reviewed by Steve Falkenburg.
1970
1971         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1972         the name and description from Mac's Info.plist.
1973
1974 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1975
1976         Reviewed by Laszlo Gombos.
1977
1978         [Qt][WK2] Guard gcc-specific syntax
1979
1980         Non-gcc based compliers choke on the "-include"
1981         syntax for preinclude, place guard around it.
1982
1983         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1984         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1985
1986 2011-01-10  Andreas Kling  <kling@webkit.org>
1987
1988         Reviewed by Simon Hausmann.
1989
1990         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1991         https://bugs.webkit.org/show_bug.cgi?id=52111
1992
1993         When getting a createNewPage() callback from QWKPage, create the
1994         new page with the same QWKContext as the page that is passed to
1995         the callback.
1996
1997         * MiniBrowser/qt/BrowserView.h:
1998         * MiniBrowser/qt/BrowserWindow.cpp:
1999         (newPageFunction):
2000         (BrowserWindow::BrowserWindow):
2001         * MiniBrowser/qt/BrowserWindow.h:
2002
2003 2011-01-10  Andreas Kling  <kling@webkit.org>
2004
2005         Reviewed by Kenneth Rohde Christiansen.
2006
2007         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2008
2009         BrowserView set its own useless createNewPage() callback on QWKPage.
2010         This was immediately overridden by BrowserWindow anyway, so remove
2011         the BrowserView one.
2012
2013         * MiniBrowser/qt/BrowserView.cpp:
2014         (BrowserView::BrowserView):
2015
2016 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2017
2018         Reviewed by Jeremy Orlow.
2019
2020         [Chromium] Remove non-client-based Geolocation code
2021         https://bugs.webkit.org/show_bug.cgi?id=50921
2022
2023         * DumpRenderTree/chromium/LayoutTestController.cpp:
2024         (LayoutTestController::setGeolocationPermission):
2025         (LayoutTestController::setMockGeolocationPosition):
2026         (LayoutTestController::setMockGeolocationError):
2027         * DumpRenderTree/chromium/WebViewHost.cpp:
2028         (WebViewHost::geolocationClientMock):
2029         (WebViewHost::reset):
2030         * DumpRenderTree/chromium/WebViewHost.h:
2031
2032 2011-01-10  Eric Seidel  <eric@webkit.org>
2033
2034         Reviewed by Adam Barth.
2035
2036         Commit bot tried to land r? cq+ patch
2037         https://bugs.webkit.org/show_bug.cgi?id=36638
2038
2039         It should now be possible to post a patch with r? and cq+ and the
2040         commit-queue will correctly wait for the r+ before attempting to land the patch.
2041         (This was a feature requested by several users.)
2042
2043         One caveat: We don't actually reject r-, cq+ patches from the queue
2044         (we just ignore them), but I think that's OK for now.
2045
2046         I also noticed that setting r- once a commit-queue node had grabbed
2047         a patch would not properly cancel the landing.  That's fixed and
2048         tested in this patch.
2049
2050         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2051         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2052         * Scripts/webkitpy/tool/bot/feeders.py:
2053         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2054
2055 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2056
2057         Reviewed by Kenneth Rohde Christiansen.
2058
2059         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2060         https://bugs.webkit.org/show_bug.cgi?id=51934
2061
2062         When accessing the network from the destructor of QWebPage, the network access manager
2063         was already deleted because the object WebPage was already destructed.
2064
2065         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2066         The object is now destructed in the destructor of QObject.
2067
2068         * QtTestBrowser/webpage.cpp:
2069         (WebPage::WebPage):
2070         (WebPage::setQnamThreaded):
2071         * QtTestBrowser/webpage.h:
2072         (QtNAMThread::QtNAMThread):
2073
2074 2011-01-08  Eric Seidel  <eric@webkit.org>
2075
2076         Reviewed by Ojan Vafai.
2077
2078         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2079         https://bugs.webkit.org/show_bug.cgi?id=52067
2080
2081         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2082         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2083
2084         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2085
2086 2011-01-08  Eric Seidel  <eric@webkit.org>
2087
2088         Reviewed by Mihai Parparita.
2089
2090         commit-queue hangs when the ChangeLog diff is bad
2091         https://bugs.webkit.org/show_bug.cgi?id=52072
2092
2093         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2094         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2095
2096 2011-01-08  Adam Barth  <abarth@webkit.org>
2097
2098         Teach svn-apply how to re-write WebCore to Source/WebCore.
2099
2100         * Scripts/VCSUtils.pm:
2101
2102 2011-01-07  Adam Barth  <abarth@webkit.org>
2103
2104         Rubber-stamped by Eric Seidel.
2105
2106         Move WebCore to Source
2107         https://bugs.webkit.org/show_bug.cgi?id=52050
2108
2109         Update the tools to understand WebCore's new location.
2110
2111         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2112         * DumpRenderTree/wscript:
2113         * GNUmakefile.am:
2114         * Scripts/build-webkit:
2115         * Scripts/do-file-rename:
2116         * Scripts/do-webcore-rename:
2117         * Scripts/generate-qt-inspector-resource:
2118         * Scripts/prepare-ChangeLog:
2119         * Scripts/run-bindings-tests:
2120         * Scripts/update-iexploder-cssproperties:
2121         * Scripts/update-sources-list.py:
2122         * Scripts/update-webkit-localizable-strings:
2123         * Scripts/webkitdirs.pm:
2124         * Scripts/webkitpy/common/config/build.py:
2125         * Scripts/webkitpy/common/config/build_unittest.py:
2126         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2127         * Scripts/webkitpy/style/checker.py:
2128         * Scripts/webkitpy/style/checker_unittest.py:
2129         * WebKitTestRunner/DerivedSources.pro:
2130         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2131         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2132         * wx/browser/wscript:
2133         * wx/build/settings.py:
2134
2135 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2136
2137         Reviewed by Sam Weinig.
2138
2139         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2140         https://bugs.webkit.org/show_bug.cgi?id=52086
2141
2142         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2143         (WTR::InjectedBundle::didReceiveMessage):
2144         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2145         (WTR::LayoutTestController::notifyDone):
2146         * WebKitTestRunner/TestController.cpp:
2147         (WTR::TestController::resetStateToConsistentValues):
2148         (WTR::TestController::run):
2149
2150 2011-01-07  James Robinson  <jamesr@chromium.org>
2151
2152         Revert "Implement mozilla's animationTime property"
2153         https://bugs.webkit.org/show_bug.cgi?id=51952
2154
2155         This approach isn't quite right.
2156
2157         * DumpRenderTree/chromium/WebViewHost.cpp:
2158         (WebViewHost::paintInvalidatedRegion):
2159
2160 2011-01-07  Adam Roben  <aroben@apple.com>
2161
2162         Build master fix
2163
2164         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2165         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2166
2167 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2168
2169         Reviewed by Csaba Osztrogonác.
2170
2171         run-qtwebkit-tests should be able to kill a testsuite.
2172
2173         Add new option in the script that can setup a timeout for a test.
2174         If the test execution takes more then specified time then the test
2175         would be terminated.
2176
2177         [Qt] run-qtwebkit-tests needs timeout
2178         https://bugs.webkit.org/show_bug.cgi?id=51894
2179
2180         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2181         * Scripts/run-qtwebkit-tests:
2182
2183 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2184
2185         Unreviewed fix after r75233.
2186
2187         Based on idea from Eric Seidel.
2188
2189         Add remote zip file handling to webkitpy.
2190         https://bugs.webkit.org/show_bug.cgi?id=50901
2191
2192         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2193
2194 2011-01-07  Shane Stephens  <shanestephens@google.com>
2195
2196         Reviewed by Eric Seidel.
2197
2198         svn-apply: should support git binary delta diffs
2199         https://bugs.webkit.org/show_bug.cgi?id=38864
2200
2201         * Scripts/VCSUtils.pm:
2202         * Scripts/svn-apply:
2203
2204 2011-01-06  Julie Parent  <jparent@chromium.org>
2205
2206         Reviewed by Eric Seidel.
2207
2208         Test Result Server not removing old results.
2209         https://bugs.webkit.org/show_bug.cgi?id=52012
2210
2211         * TestResultServer/model/jsonresults.py:
2212         Fix off-by-one: Truncate if >= num_runs, not just >.
2213         * TestResultServer/model/jsonresults_unittest.py:
2214         Add unit test to test that merging in a new result with the same value
2215         as the last result causes previous result to fall off.
2216
2217 2011-01-06  James Kozianski  <koz@chromium.org>
2218
2219         Reviewed by Mihai Parparita.
2220
2221         Add classes to provide a consistent interface to a set of files.
2222         https://bugs.webkit.org/show_bug.cgi?id=50901
2223
2224         These classes allow us to write code that is agnostic to whether a
2225         particular set of files resides in a local directory or in a zip file
2226         on a remote machine.
2227
2228         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2229         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2230         * Scripts/webkitpy/common/system/fileset.py: Added.
2231         * Scripts/webkitpy/common/system/filesystem.py:
2232         * Scripts/webkitpy/common/system/filesystem_mock.py:
2233         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2234         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2235
2236 2011-01-06  Eric Seidel  <eric@webkit.org>
2237
2238         Reviewed by Adam Barth.
2239
2240         NetworkTransaction should log the url it is retrying
2241         https://bugs.webkit.org/show_bug.cgi?id=52043
2242
2243         * Scripts/webkitpy/common/net/networktransaction.py:
2244         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2245
2246 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2247
2248         Windows build fix.
2249         Import os before using it.
2250
2251         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2252
2253 2011-01-06  Eric Seidel  <eric@webkit.org>
2254
2255         Reviewed by Adam Barth.
2256
2257         StyleQueue fails to report errors when patches have many files
2258         https://bugs.webkit.org/show_bug.cgi?id=52042
2259
2260         This is one of at least two errors preventing style error reporting at the moment.
2261         When we moved to passing the list of files to check explicitly,
2262         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2263         We could change the type of the QueueStatus.message type, or we could
2264         just teach statusserver.py how to clamp values (and warn when it does).
2265         I chose the latter path.
2266
2267         * Scripts/webkitpy/common/net/statusserver.py:
2268
2269 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2270
2271         Reviewed by Stephanie Lewis.
2272         
2273         Fix syntax error in script.
2274
2275         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2276         https://bugs.webkit.org/show_bug.cgi?id=51996
2277
2278         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2279
2280 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2281
2282         Unreviewed, fixing WinCE build after r75196.
2283
2284         WinCE port does not (yet) support NPAPI.
2285
2286         * Scripts/build-webkit:
2287
2288 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2289
2290         Reviewed by Darin Adler.
2291
2292         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2293         https://bugs.webkit.org/show_bug.cgi?id=52015
2294
2295         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2296         after the platform has been detected, otherwise the script will
2297         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2298         detection.
2299
2300 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2301
2302         Reviewed by Eric Seidel.
2303
2304         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2305         https://bugs.webkit.org/show_bug.cgi?id=51346
2306
2307         * Scripts/build-webkit:
2308
2309 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2310
2311         Reviewed by Adam Roben.
2312
2313         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2314         https://bugs.webkit.org/show_bug.cgi?id=51996
2315         
2316         After the configuration directory change, we were archiving the incorrect directory for
2317         build product, so we were running tests on the wrong binaries.
2318         
2319         This change archives the correct directory, and also unarchives it into a configuration-
2320         specific directory.
2321
2322         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2323         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2324
2325 2011-01-06  Eric Seidel  <eric@webkit.org>
2326
2327         Reviewed by Mihai Parparita.
2328
2329         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2330         https://bugs.webkit.org/show_bug.cgi?id=52002
2331
2332         See an example of this here:
2333         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2334
2335         It's due to the fact that we pass around TestFailure() instance
2336         objects and yet expect them to all compare to be the same.
2337
2338         This is bad.  We should either have shared instances of these values
2339         or we should just pass around the class names.  There are already hacks
2340         in place to make TestFailure objects pass equality tests, I just added
2341         a __hash__ implementation so they can be used in sets as expected.
2342
2343         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2344         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2345
2346 2011-01-06  Evan Martin  <evan@chromium.org>
2347
2348         Reviewed by Tony Chang.
2349
2350         [gdb] handle inaccessible memory and UChar*
2351         https://bugs.webkit.org/show_bug.cgi?id=52003
2352
2353         To pretty-print a UChar*, we just grope around in the memory
2354         looking for a terminating NUL.  We need to handle the exception
2355         that can occur when we poke into an invalid location.
2356
2357         Additionally, the logic for choosing which pretty-printer would
2358         early return before hitting the point where we'd use the UChar*
2359         printer.  (Did this ever work?  How did it regress?)
2360
2361         * gdb/webkit.py:
2362
2363 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2364
2365         Reviewed by Ada Chan.
2366
2367         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2368         https://bugs.webkit.org/show_bug.cgi?id=51969
2369         
2370         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2371
2372         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2373         (WTR::InjectedBundlePage::InjectedBundlePage):
2374         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2375         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2376
2377 2011-01-06  James Robinson  <jamesr@chromium.org>
2378
2379         Reviewed by Simon Fraser.
2380
2381         Implement mozilla's animationTime property
2382         https://bugs.webkit.org/show_bug.cgi?id=51952
2383
2384         Chromium DRT support for webkitAnimationTime.
2385
2386         * DumpRenderTree/chromium/WebViewHost.cpp:
2387         (WebViewHost::paintInvalidatedRegion):
2388
2389 2011-01-06  Julie Parent  <jparent@chromium.org>
2390
2391         Reviewed by Tony Chang.
2392
2393         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2394         https://bugs.webkit.org/show_bug.cgi?id=51217
2395
2396         * TestResultServer/model/jsonresults.py:
2397         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2398         Adds missing documentation.
2399         * TestResultServer/model/jsonresults_unittest.py:
2400         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2401         Update test_merge to take a number of builds to truncate at.
2402
2403 2011-01-06  Adam Barth  <abarth@webkit.org>
2404
2405         Reviewed by Eric Seidel.
2406
2407         The EWS should log outside of the working directory
2408         https://bugs.webkit.org/show_bug.cgi?id=51986
2409
2410         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2411         script, which will actually clean the working copy back to a pristine
2412         state instead of leaving untracked directories and ignored files.
2413
2414         * Scripts/webkitpy/tool/commands/queues.py:
2415         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2416
2417 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2418
2419         Windows build fix.
2420         Back out attempted change to built-product-archive.
2421
2422         * BuildSlaveSupport/built-product-archive:
2423
2424 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2425
2426         Windows build fix.
2427         Include configuration name when unpacking a build archive.
2428
2429         Needed, since we split Windows build results into configuration-specific directories
2430         under WebKitOutputDir.
2431
2432         * BuildSlaveSupport/built-product-archive:
2433
2434 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2435
2436         Reviewed by Darin Adler.
2437
2438         Debug and Release builds on Windows clobber each other
2439         https://bugs.webkit.org/show_bug.cgi?id=49185
2440
2441         Changes the structure of WebKitBuild build products directory so we
2442         completely separate each build configuration into independent directories.
2443         
2444         Although we previously had per-configuration directories for obj, this change adds
2445         per-configuration directories for bin, lib, obj, and include. Each configuration's
2446         build products are stored within a directory inside of WebKitBuild.
2447         
2448         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2449         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2450
2451         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2452         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2453         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2454         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2455         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2456         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2457         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2458         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2459         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2460         * FindSafari/FindSafari.vcproj:
2461         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2462         * MiniBrowser/MiniBrowserPostBuild.cmd:
2463         * MiniBrowser/MiniBrowserPreBuild.cmd:
2464         * Scripts/webkitdirs.pm:
2465         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2466         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2467         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2468         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2469         * TestWebKitAPI/win/copy-resources.cmd:
2470         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2471         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2472         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2473         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2474         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2475         * WebKitTestRunner/win/InjectedBundle.vcproj:
2476         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2477         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2478         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2479         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2480         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2481         * WinLauncher/WinLauncherCommon.vsprops:
2482         * WinLauncher/WinLauncherPostBuild.cmd:
2483         * WinLauncher/WinLauncherPreBuild.cmd:
2484
2485 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2486
2487         Reviewed by Ariya Hidayat.
2488
2489         [Qt] TestNetscapePlugin doesn't link on OS X
2490         https://bugs.webkit.org/show_bug.cgi?id=51948
2491
2492         Only add a dependency on libX11 on X11 systems
2493
2494         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2495
2496 2011-01-05  Jeff Miller  <jeffm@apple.com>
2497
2498         Reviewed by Adam Roben.
2499
2500         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2501         https://bugs.webkit.org/show_bug.cgi?id=51970
2502
2503         * Scripts/webkitpy/style/checker.py:
2504         Add -readability/naming for WebKit2 C API directories.
2505
2506 2011-01-05  Eric Seidel  <eric@webkit.org>
2507
2508         Unreviewed, just fixing one more log error from my previous python patch.
2509
2510         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2511         https://bugs.webkit.org/show_bug.cgi?id=51802
2512
2513         webkit-patch failure-reason was logging about parsing errors
2514         due to my misunderstanding of how BeautifulSoup.findAll worked.
2515
2516         Fixed, and added a unit test.
2517
2518         * Scripts/webkitpy/common/net/layouttestresults.py:
2519         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2520
2521 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2522
2523         Reviewed by Kenneth Rohde Christiansen.
2524
2525         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2526         https://bugs.webkit.org/show_bug.cgi?id=51951
2527
2528         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2529         to create new window from WebKit.
2530
2531         * MiniBrowser/qt/BrowserWindow.cpp:
2532         (newPageFunction):
2533         (BrowserWindow::BrowserWindow):
2534         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2535         (BrowserWindow::newWindow):
2536         (BrowserWindow::updateUserAgentList):
2537         (BrowserWindow::showUserAgentDialog):
2538         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2539         define the type of the backing store used for new windows.
2540         * MiniBrowser/qt/main.cpp:
2541         (main):
2542
2543 2011-01-05  Eric Seidel  <eric@webkit.org>
2544
2545         Reviewed by Ojan Vafai.
2546
2547         commit-queue should report failure type when reporting flaky tests
2548         https://bugs.webkit.org/show_bug.cgi?id=51900
2549
2550         This patch was a ridiculous amount of plumbing.  In the end I like
2551         the NRWT-style TestResult class even less.  But now we're passing
2552         a list of TestResult objects from the queue to the FlakyTestReporter.
2553         Thus the FlakyTestReporter can more easily report what type of failure
2554         occurred.
2555
2556         In the process, I found that I was not alone in finding TestResult
2557         cumbersome to use.  A bunch of code was trying to create a TestResult
2558         object with default values.  However since the constructor didn't make
2559         this easy, some places were getting it wrong (including the TestResult unit test)!
2560         I've fixed the TestResult constructor to have default values for non-essential
2561         arguments.
2562
2563         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2564         * Scripts/webkitpy/common/net/layouttestresults.py:
2565         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2566         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2567         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2568         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2569         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2570         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2571         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2572         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2573         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2574         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2575         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2576         * Scripts/webkitpy/tool/commands/queues.py:
2577         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2578
2579 2011-01-05  Eric Seidel  <eric@webkit.org>
2580
2581         Unreviewed.
2582
2583         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2584         https://bugs.webkit.org/show_bug.cgi?id=51802
2585
2586         Add another unit test to cover a previously missing import.
2587
2588         * Scripts/webkitpy/common/net/layouttestresults.py:
2589         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2590
2591 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2592
2593         Reviewed by David Levin.
2594
2595         Add mihaip@chromium.org as a reviewer
2596         https://bugs.webkit.org/show_bug.cgi?id=51966
2597         
2598         Add myself as a reviewer.
2599
2600         * Scripts/webkitpy/common/config/committers.py:
2601
2602 2011-01-05  James Simonsen  <simonjam@chromium.org>
2603
2604         Unreviewed. Adding myself to the list of committers.
2605
2606         * Scripts/webkitpy/common/config/committers.py:
2607
2608 2011-01-05  Eric Seidel  <eric@webkit.org>
2609
2610         Unreviewed.
2611
2612         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2613         https://bugs.webkit.org/show_bug.cgi?id=51802
2614
2615         Fix two exceptions seen on the bots after my original commit.
2616
2617         * Scripts/webkitpy/common/net/layouttestresults.py:
2618         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2619
2620 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2621
2622         Reviewed by Andreas Kling.
2623
2624         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2625         https://bugs.webkit.org/show_bug.cgi?id=51750
2626
2627         * QtTestBrowser/main.cpp:
2628         (LauncherApplication::handleUserOptions):
2629          Local storage settings can be enable form command line arguments for
2630          QtTestBrowser.
2631
2632 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2633
2634         Reviewed by Martin Robinson.
2635
2636         GTK: AX: DRT needs to use correct root object method.
2637         https://bugs.webkit.org/show_bug.cgi?id=51911
2638
2639         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2640         (AccessibilityController::rootElement):
2641
2642 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2643
2644         Rubber-stamped by Csaba Osztrogonác.
2645
2646         Based on idea from Péter Gál.
2647
2648         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2649
2650 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2651
2652         Reviewed by Adam Barth.
2653
2654         sheriff-bot should be able to do multi-revision rollouts
2655         https://bugs.webkit.org/show_bug.cgi?id=51176
2656
2657         * Scripts/webkitpy/tool/bot/irc_command.py:
2658         * Scripts/webkitpy/tool/bot/sheriff.py:
2659         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2660
2661 2011-01-05  Eric Seidel  <eric@webkit.org>
2662
2663         Reviewed by Adam Barth.
2664
2665         queues.webkit.org should have per-bot status pages
2666         https://bugs.webkit.org/show_bug.cgi?id=51906
2667
2668         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2669         statuses from a single queue.  Now that we have many bots servicing
2670         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2671         you care about scroll off the end of the 15-message limit on the main page.
2672
2673         Eventually we should probably rename /queue-status to /queue or /queues,
2674         but that's fodder for another patch.
2675
2676         * QueueStatusServer/handlers/queuestatus.py:
2677         * QueueStatusServer/index.yaml:
2678         * QueueStatusServer/main.py:
2679         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2680          - This probably should use a custom filter instead of hard-coding
2681            the URL scheme here, but I couldn't figure out how to easily
2682            create such a filter.  Most filters work with "strings" so we can't
2683            pass the status object.  We could add a method to the status
2684            object and call that, but that seemed a bit strange too.
2685         * QueueStatusServer/templates/queuestatus.html:
2686
2687 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2688
2689         Unreviewed. Adding myself to the list of committers.
2690
2691         * Scripts/webkitpy/common/config/committers.py:
2692
2693 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2694
2695         Reviewed by David Levin.
2696
2697         check-webkit-style treated some macros with parentheses after #elif as function calls
2698         https://bugs.webkit.org/show_bug.cgi?id=51695
2699
2700         Ingore function call space checking in any preprocessor directives
2701         (things starting with #). Change search() to match() because 
2702         preprocessor directives are supposed to be in the beginning of lines.
2703
2704         * Scripts/webkitpy/style/checkers/cpp.py:
2705         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2706
2707 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2708
2709         Reviewed by Tony Chang.
2710
2711         Change the --multi-load test option to --stress-opt
2712         https://bugs.webkit.org/show_bug.cgi?id=50751
2713
2714         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2715         (runTest):
2716         (main):
2717         * DumpRenderTree/chromium/TestShell.cpp:
2718         (TestShell::TestShell):
2719         * DumpRenderTree/chromium/TestShell.h:
2720         (TestShell::stressOpt):
2721         (TestShell::setStressOpt):
2722         (TestShell::stressDeopt):
2723         (TestShell::setStressDeopt):
2724         (TestShell::javaScriptFlags):
2725         (TestShell::setJavaScriptFlags):
2726         * Scripts/webkitpy/layout_tests/port/chromium.py:
2727         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2728
2729 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2730
2731         Reviewed by Sam Weinig.
2732
2733         WK2: Support Accessibility
2734         https://bugs.webkit.org/show_bug.cgi?id=51859
2735
2736         Use rootObject() method to get top of accessibility tree.
2737
2738         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2739         (AccessibilityController::focusedElement):
2740         (AccessibilityController::rootElement):
2741
2742 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2743
2744         Reviewed by Darin Adler.
2745
2746         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2747         https://bugs.webkit.org/show_bug.cgi?id=51846
2748
2749         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2750         back to GRefPtr.
2751
2752 2011-01-04  Zhe Su  <suzhe@chromium.org>
2753
2754         Reviewed by Kenneth Russell.
2755
2756         Fix insertText, setMarkedText and unmarkText methods of
2757         TextInputController to call corresponding methods of WebKit::WebView
2758         rather than WebKit::WebFrame. This change matches the behavior of
2759         chromium browser.
2760         insertText corresponds to WebView::confirmComposition(text)
2761         setMarkedText corresponds to WebView::setComposition(...)
2762         unmarkText corresponds to WebView::confirmComposition()
2763         https://bugs.webkit.org/show_bug.cgi?id=51693
2764
2765         * DumpRenderTree/chromium/TextInputController.cpp:
2766         (TextInputController::insertText):
2767         (TextInputController::setMarkedText):
2768         (TextInputController::unmarkText):
2769
2770 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2771
2772         Reviewed by Laszlo Gombos.
2773
2774         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2775
2776         On Symbian productDir points to the source directory. Removing all the
2777         empty files from the productDir directory corrupts the svn repository.
2778
2779         * Scripts/build-webkit:
2780
2781 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2782
2783         Reviewed by Adam Barth.
2784
2785         [Qt] Add SelectAll option to the context menu for the editor
2786         https://bugs.webkit.org/show_bug.cgi?id=50049
2787
2788         Set shortcut for the SelectAll action.
2789
2790         * QtTestBrowser/mainwindow.cpp:
2791         (MainWindow::buildUI):
2792
2793 2011-01-03  David Levin  <levin@chromium.org>
2794
2795         Reviewed by Eric Seidel.
2796
2797         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2798         https://bugs.webkit.org/show_bug.cgi?id=51842
2799
2800         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2801         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2802
2803 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2804
2805         Reviewed by David Kilzer.
2806
2807         [WINCE] Adds a build slave.
2808         https://bugs.webkit.org/show_bug.cgi?id=50523
2809
2810         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2811         entry for a release build of the WinCE port.
2812         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2813         flag to build the WinCE port.
2814
2815 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2816
2817         Reviewed by David Kilzer.
2818
2819         Add WinCE support to build-webkit
2820         https://bugs.webkit.org/show_bug.cgi?id=51642
2821
2822         * Scripts/build-webkit:
2823         * Scripts/webkitdirs.pm:
2824
2825 2011-01-03  Eric Seidel  <eric@webkit.org>
2826
2827         Reviewed by Adam Barth.
2828
2829         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2830         https://bugs.webkit.org/show_bug.cgi?id=51802
2831
2832         I'm not the biggest fan of the test_failures or test_results classes,
2833         but it's better to have one shared set of classes, than separate ones
2834         for new vs. old run-webkit-test result handling.
2835
2836         This moves the ORWT results class "LayoutTestResults" over to using
2837         TestResult and TestFailure classes, making it easy for us to
2838         make all our sheriff-bot and other webkitpy code NRWT ready.
2839
2840         This also makes it a trivial patch to generate results.json information
2841         from ORWT results.html files (for flaky test analysis, etc.) as well
2842         as making it a one-liner to report test failure types when the
2843         commit-queue sees flaky tests.
2844
2845         This patch tried not to add new functionality, but only to replace
2846         the guts of LayoutTestResults, while adding unit tests and hoping
2847         not to break anything.
2848
2849         I also moved callers which assumed User.prompt* were static/class methods
2850         to using them as instance methods (since we'll eventually want to make them such).
2851
2852         In the process of re-writing things, I broke the rebaseline command, so I wrote
2853         a unit test to catch my breakage were I do do so again in the future.
2854
2855         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2856         * Scripts/webkitpy/common/net/layouttestresults.py:
2857         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2858         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2859         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2860         * Scripts/webkitpy/tool/commands/queries.py:
2861         * Scripts/webkitpy/tool/commands/rebaseline.py:
2862         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2863         * Scripts/webkitpy/tool/mocktool.py:
2864
2865 2011-01-03  Adam Barth  <abarth@webkit.org>
2866
2867         Reviewed by Simon Fraser.
2868
2869         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2870         https://bugs.webkit.org/show_bug.cgi?id=51840
2871
2872         * Scripts/webkitpy/common/checkout/scm.py:
2873
2874 2011-01-03  Adam Barth  <abarth@webkit.org>
2875
2876         Reviewed by Simon Fraser.
2877
2878         webkit-patch should only hide update output if --quiet
2879         https://bugs.webkit.org/show_bug.cgi?id=51838
2880
2881         As requested by smfr.
2882
2883         * Scripts/webkitpy/tool/steps/update.py:
2884
2885 2011-01-03  Adam Barth  <abarth@webkit.org>
2886
2887         Reviewed by David Levin.
2888
2889         commit-queue shouldn't reject patches twice if two bots process the same patch
2890         https://bugs.webkit.org/show_bug.cgi?id=51805
2891
2892         Before raising an error, we first check whether the patch is still in
2893         the commit-queue.  This check is still racy, of course, but the time
2894         window is much smaller.
2895
2896         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2897
2898 2011-01-03  Sam Weinig  <sam@webkit.org>
2899
2900         Reviewed by Anders Carlsson.
2901
2902         Make run-api-tests less chatty.
2903         https://bugs.webkit.org/show_bug.cgi?id=51831
2904
2905         - Make script quiet by default and add --verbose option (replacing --quiet).
2906         - When not verbose, pipe stdout and stderr to devnull.
2907
2908         * Scripts/run-api-tests:
2909
2910 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2911
2912         Unreviewed. Adding myself to committers.py.
2913
2914         * Scripts/webkitpy/common/config/committers.py:
2915
2916 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2917
2918         Reviewed by Xan Lopez.
2919
2920         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2921         https://bugs.webkit.org/show_bug.cgi?id=51806
2922
2923         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2924         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2925         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2926         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2927         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2928         so make it 'WebKitBuild/Release/.libs'
2929
2930         * Scripts/webkitdirs.pm: 
2931
2932 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2933
2934         Reviewed by Adam Barth.
2935
2936         Make EFL a core builder
2937         https://bugs.webkit.org/show_bug.cgi?id=51804
2938
2939         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2940         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2941
2942 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2943
2944         [Qt] Unreviewed fix after r74855 and r74875.
2945
2946         * BuildSlaveSupport/built-product-archive:
2947          - Create directories explicitly.
2948          - Pass shell=True to subprocess.call().
2949
2950 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2951
2952         [Qt] Unreviewed fix after r74855.
2953
2954         Move JavaScriptCore to Source
2955         https://bugs.webkit.org/show_bug.cgi?id=51604
2956
2957         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2958
2959 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2960
2961         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2962
2963         Move JavaScriptCore to Source
2964         https://bugs.webkit.org/show_bug.cgi?id=51604
2965
2966         * Scripts/webkitdirs.pm:
2967
2968 2011-01-02  Robert Hogan  <robert@webkit.org>
2969
2970         Unreviewed, build fix.
2971
2972         [Qt] Fix DRT build after 74855
2973
2974         * DumpRenderTree/qt/DumpRenderTree.pro:
2975
2976 2011-01-01  Adam Barth  <abarth@webkit.org>
2977
2978         Remove the assumption from the Qt and Gtk builds that every project is
2979         in the root directory.
2980
2981         * Scripts/build-webkit:
2982
2983 2011-01-01  Adam Barth  <abarth@webkit.org>
2984
2985         Reviewed by Eric Seidel.
2986
2987         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2988         https://bugs.webkit.org/show_bug.cgi?id=51796
2989
2990         After this change, svn-apply will magically apply patches to
2991         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2992
2993         * Scripts/VCSUtils.pm:
2994
2995 2011-01-01  Adam Barth  <abarth@webkit.org>
2996
2997         Reviewed by Eric Seidel.
2998
2999         Move JavaScriptCore to Source
3000         https://bugs.webkit.org/show_bug.cgi?id=51604
3001
3002         Update references to JavaScriptCore to point to the new location.
3003
3004         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3005         * DumpRenderTree/qt/DumpRenderTree.pro:
3006         * DumpRenderTree/qt/ImageDiff.pro:
3007         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3008         * DumpRenderTree/wscript:
3009         * Scripts/build-jsc:
3010         * Scripts/build-webkit:
3011         * Scripts/do-file-rename:
3012         * Scripts/do-webcore-rename:
3013         * Scripts/run-javascriptcore-tests:
3014         * Scripts/update-javascriptcore-test-results:
3015         * Scripts/webkitdirs.pm:
3016         * Scripts/webkitpy/common/config/build_unittest.py:
3017         * Scripts/webkitpy/style/checker.py:
3018         * Scripts/webkitpy/style/checker_unittest.py:
3019         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3020         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3021         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3022         * wx/build/settings.py:
3023
3024 2011-01-01  Adam Barth  <abarth@webkit.org>
3025
3026         Reviewed by Eric Seidel.
3027
3028         Move Sources to Source
3029         https://bugs.webkit.org/show_bug.cgi?id=51794
3030
3031         Update scripts to point to the new location.
3032
3033         * Scripts/build-webkit:
3034         * Scripts/do-file-rename:
3035         * Scripts/do-webcore-rename:
3036         * Scripts/webkitpy/common/config/build.py:
3037         * Scripts/webkitpy/common/config/build_unittest.py:
3038
3039 2010-12-31  Kent Tamura  <tkent@chromium.org>
3040
3041         Reviewed by Eric Seidel.
3042
3043         [DRT/Chromium] Enable mock spell checker on non-OSX
3044         https://bugs.webkit.org/show_bug.cgi?id=51401
3045
3046         * DumpRenderTree/chromium/WebViewHost.cpp:
3047         (WebViewHost::spellCheck):
3048
3049 2010-12-31  Adam Barth  <abarth@webkit.org>
3050
3051         Reviewed by Ariya Hidayat.
3052
3053         Remove Tools/Scripts/wkstyle
3054         https://bugs.webkit.org/show_bug.cgi?id=51774
3055
3056         This script appears to not have been touched in a while and seems to
3057         have been replaced by check-webkit-style.
3058
3059         * Scripts/wkstyle: Removed.
3060
3061 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3062
3063         Unreviewed. Coding style fix.
3064
3065         * DumpRenderTree/chromium/TestShell.h:
3066
3067 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3068
3069         Reviewed by Pavel Feldman.
3070
3071         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3072
3073         It was a problem with Chromium DRT. DevToolsAgent object instance was
3074         attached not only to the inspected page but to the DevTools window too.
3075         As result all the inspector files were interpreted as a content of inspected page
3076         and were transfered to the DevTools scripts panel for debugging etc.
3077
3078         https://bugs.webkit.org/show_bug.cgi?id=51735
3079
3080         * DumpRenderTree/chromium/TestShell.cpp:
3081         (TestShell::TestShell):
3082         (TestShell::bindJSObjectsToWindow):
3083         (TestShell::createNewWindow):
3084         * DumpRenderTree/chromium/TestShell.h:
3085
3086 2010-12-31  Adam Barth  <abarth@webkit.org>
3087
3088         Rubber-stamped by Eric Seidel.
3089
3090         Move PageLoadTests to PerformanceTests/PageLoad
3091         https://bugs.webkit.org/show_bug.cgi?id=51771
3092
3093         Update references to PageLoadTests to point to the new location.
3094
3095         * Scripts/run-pageloadtest:
3096         * Scripts/webkitpy/common/config/build.py:
3097
3098 2010-12-31  Adam Barth  <abarth@webkit.org>
3099
3100         Rubber-stamped by Eric Seidel.
3101
3102         Move SunSpider into PerformanceTests
3103         https://bugs.webkit.org/show_bug.cgi?id=51769
3104
3105         Update these scripts to point to the new location.
3106
3107         * Scripts/run-sunspider:
3108         * Scripts/sunspider-compare-results:
3109
3110 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3111
3112         Reviewed by Kent Tamura.
3113
3114         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3115         https://bugs.webkit.org/show_bug.cgi?id=51728
3116         
3117         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3118         to render top-level scrollbars. This makes them match the Mac port's
3119         use of an NSScrollView, which means that we'll be able to share more
3120         pixel baselines.
3121         
3122         The new rendering code will not be activated until the 
3123         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3124         ScrollbarThemeChromiumMac.
3125
3126         * DumpRenderTree/DumpRenderTree.gypi:
3127         * DumpRenderTree/chromium/TestShellMac.mm:
3128         (platformInit):
3129         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3130         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3131         (+[FakeActiveWindow alwaysActiveWindow]):
3132         (+[FakeActiveWindow alwaysInactiveWindow]):
3133         (-[FakeActiveWindow initWithActiveControls:]):
3134         (-[FakeActiveWindow _hasActiveControls]):
3135         (WebThemeEngineDRTMac::paintScrollbarThumb):
3136         (stateToHIEnableState):
3137         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3138         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3139
3140 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3141
3142         Reviewed by David Kilzer.
3143
3144         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3145         used
3146         https://bugs.webkit.org/show_bug.cgi?id=51672
3147
3148         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3149         with USE_SYSTEM_MALLOC=1
3150         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3151         with USE_SYSTEM_MALLOC=1
3152
3153 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3154
3155         Reviewed by David Kilzer.
3156
3157         [Qt] [Symbian] Fix build-webkit script for Symbian
3158         https://bugs.webkit.org/show_bug.cgi?id=51509
3159
3160         Set the OUTPUT_DIR for Symbian to be the same as the source
3161         directory.
3162
3163         * Scripts/webkitdirs.pm:
3164
3165 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3166
3167         Reviewed by Darin Adler.
3168
3169         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3170         https://bugs.webkit.org/show_bug.cgi?id=51758
3171
3172         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3173
3174         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3175         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3176
3177 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3178
3179         Unreviewed WinCE buildfix.
3180
3181         * WinCELauncher/main.cpp: Add missing include.
3182
3183 2010-12-29  Daniel Bates  <dbates@rim.com>
3184
3185         Reviewed by Darin Adler.
3186
3187         svn-apply updates date of wrong change log entry for a change log diff that
3188         contains two consecutive entries with the same author and date
3189         https://bugs.webkit.org/show_bug.cgi?id=46061
3190
3191         Fixes an issue where the date of the wrong change log entry may be modified.
3192         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3193         in a ChangeLog file to the top of the file.
3194
3195         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3196         diff when it detects that the diff inserts a change log entry earlier in a
3197         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3198         change. With the advent of the commit-queue this functionality of bailing out
3199         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3200         Instead, we should always move the change log entry to the top of the ChangeLog file.
3201
3202         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3203         the date line of the correct change log entry in a ChangeLog diff.
3204
3205         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3206
3207         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3208           Updated the following unit tests now that we move entries inserted earlier to the top:
3209           - "fixChangeLogPatch: New entry inserted in middle."
3210             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3211
3212           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3213             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3214
3215         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3216
3217 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3218
3219         Reviewed by Eric Seidel.
3220
3221         [Qt] Fixed compatibility with gold linker on X11 platforms
3222         https://bugs.webkit.org/show_bug.cgi?id=51700
3223
3224         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3225         Linked TestNetscapePlugin with libX11 on Unix platforms
3226
3227 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3228
3229         Reviewed by Darin Adler.
3230
3231         Circular dependency in webkitpy.common.checkout.changelog module
3232         https://bugs.webkit.org/show_bug.cgi?id=50475
3233
3234         Remove automatic import of api.Checkout module when any checkout/
3235         submodule is imported (e.g.: when checkout.scm.Git is imported).
3236
3237         * Scripts/webkitpy/common/checkout/__init__.py:
3238
3239 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3240
3241         Reviewed by Ojan Vafai.
3242
3243         prepare-ChangeLog should support the -g option for specifying the git-commit
3244         https://bugs.webkit.org/show_bug.cgi?id=51708
3245
3246         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3247         webkit-patch, though the exact meaning of the two options remain different.
3248
3249         * Scripts/prepare-ChangeLog: Add -g.
3250
3251 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3252
3253         Reviewed by Simon Hausmann.
3254
3255         [Qt] Fix compilation with Qt in namespace
3256         https://bugs.webkit.org/show_bug.cgi?id=51701
3257
3258         * QtTestBrowser/webview.h:
3259
3260 2010-12-28  Daniel Bates  <dbates@rim.com>
3261
3262         Reviewed by Sam Weinig.
3263
3264         Substitute // MARK: for compiler-specific #pragma mark
3265         https://bugs.webkit.org/show_bug.cgi?id=51657
3266
3267         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3268         substituting  "// MARK:" for "#pragma mark", which provides
3269         analogous code-bookmarking functionality under Xcode.
3270
3271         Also, for consistency, we should substitute "// MARK:" for compiler-
3272         specific "#pragma mark" in the source files for the Mac port.
3273
3274         * DumpRenderTree/AccessibilityTextMarker.cpp:
3275         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3276         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3277         * DumpRenderTree/mac/ObjCController.m:
3278         * MiniBrowser/mac/AppDelegate.m:
3279         * MiniBrowser/mac/BrowserWindowController.m:
3280
3281 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3282
3283         Reviewed by Eric Seidel.
3284
3285         Add --no-build option to run-sunspider
3286         https://bugs.webkit.org/show_bug.cgi?id=51658
3287
3288         * Scripts/run-sunspider: add --no-build flag to skip building
3289         phase.
3290
3291 2010-12-27  Daniel Bates  <dbates@rim.com>
3292
3293         Rubber-stamped by Martin Robinson.
3294
3295         Append the directory Tools/DumpRenderTree to the list of directories that
3296         do-webcore-rename should search so that it can rename DRT files and
3297         source code.
3298
3299         * Scripts/do-webcore-rename:
3300
3301 2010-12-27  Eric Seidel  <eric@webkit.org>
3302
3303         Reviewed by Adam Barth.
3304
3305         build-webkit should detect missing Java SDK and explain how to install it
3306         https://bugs.webkit.org/show_bug.cgi?id=51651
3307
3308         * Scripts/build-webkit:
3309
3310 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3311
3312         Reviewed by Daniel Bates.
3313
3314         [GTK] Add support for build-jsc
3315         https://bugs.webkit.org/show_bug.cgi?id=51625
3316
3317         Add GTK+ support to build-jsc now that building the jsc executable as
3318         a standalone target is easy.
3319
3320         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3321         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3322         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3323         and pass it along to buildAutotoolsProject.
3324
3325 2010-12-27  David Levin  <levin@chromium.org>
3326
3327         Reviewed by Eric Seidel.
3328
3329         check-webkit-style check for meaningless variable names in function declarations.
3330         https://bugs.webkit.org/show_bug.cgi?id=51523
3331
3332         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3333         from the new check and whitespace/parens because the syntax is unusual and
3334         produced a fair number of positives for these checks.
3335         * Scripts/webkitpy/style/checkers/cpp.py:
3336         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3337         and parameter names when determining if the parameter name is useless.
3338         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3339         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3340         format.
3341         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3342         text or an acronym of it.
3343         (check_function_definition): Checks function definitions for meaningless variable names.
3344         (process_line): Added call to check_function_definition.
3345         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3346         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3347         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3348         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3349         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3350         because when only checking a snippet, there are a lot of bogus functions.
3351         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3352         that I put there previously and just noticed.
3353         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3354         check_function_definition and process_line.
3355
3356 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3357
3358         Reviewed by Martin Robinson.
3359
3360         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3361         https://bugs.webkit.org/show_bug.cgi?id=51591
3362
3363         Flash plugin uses gtk2 that is incompatible with gtk3 making
3364         webkit crash when it's built with gtk3.
3365
3366         * GtkLauncher/main.c:
3367         (main):
3368
3369 2010-12-25  Adam Barth  <abarth@webkit.org>
3370
3371         Reviewed by Eric Seidel.
3372
3373         Move ANGLE to Sources/ThirdParty
3374         https://bugs.webkit.org/show_bug.cgi?id=51605
3375
3376         * Scripts/build-webkit:
3377           - Point to the new ANGLE location.
3378
3379 2010-12-26  David Levin  <levin@chromium.org>
3380
3381         Reviewed by Eric Seidel.
3382
3383         check-webkit-style should be able to parse function declaration parameters.
3384         https://bugs.webkit.org/show_bug.cgi?id=51451
3385
3386         * Scripts/webkitpy/style/checkers/cpp.py:
3387         (Position.__init__): Holds simple position information (row, column).
3388         (Parameter.__init__): Holds information about a parameter.
3389         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3390         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3391         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3392         (find_parameter_name_index): Finds where the parameter name is.
3393         (parameter_list): Generates the list of parameters for a function.
3394         (_FunctionState.begin): Added information to allow determining the parameters
3395         on demand.
3396         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3397         (detect_functions): Improve function detection for operator functions and
3398         determine where the parameters end and pass that to _FunctionState.begin.
3399         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3400         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3401         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3402         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3403         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3404         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3405         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3406         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3407         the parameters found.
3408         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3409         detection test to verify that we catch the operator functions.
3410         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3411         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3412         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3413         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3414         test_function_length_check_definition_severity1_for_test.
3415
3416 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3417
3418         Unreviewed WinCE buildfix after r74334.
3419
3420         * CMakeListsWinCE.txt:
3421
3422 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3423
3424         Unreviewed, rolling out r74632.
3425         http://trac.webkit.org/changeset/74632
3426         https://bugs.webkit.org/show_bug.cgi?id=51600
3427
3428         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3429         on #webkit).
3430
3431         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3432         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3433
3434 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3435
3436         Reviewed by Kenneth Rohde Christiansen.
3437
3438         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3439         https://bugs.webkit.org/show_bug.cgi?id=43528
3440
3441         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3442         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3443         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3444         called.
3445
3446         * EWebLauncher/main.c:
3447         (browserCreate):
3448
3449 2010-12-24  Eric Seidel  <eric@webkit.org>
3450
3451         Reviewed by Adam Barth.
3452
3453         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3454         https://bugs.webkit.org/show_bug.cgi?id=28291
3455
3456         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3457         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3458         to strings with find in the diff.
3459         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3460
3461         * Scripts/webkitpy/common/checkout/api.py:
3462         * Scripts/webkitpy/common/checkout/diff_parser.py:
3463         * Scripts/webkitpy/tool/steps/abstractstep.py:
3464         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3465         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3466         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3467         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3468
3469 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3470
3471         Reviewed by Kenneth Russell.
3472
3473         Modify new-run-webkit-tests to shut up and exit when all the threads
3474         are wedged so that test runs complete faster and we don't end up
3475         w/ enormous log files.
3476
3477         https://bugs.webkit.org/show_bug.cgi?id=51572
3478
3479         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3480         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3481
3482 2010-12-24  Eric Seidel  <eric@webkit.org>
3483
3484         Reviewed by David Levin.
3485
3486         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3487         https://bugs.webkit.org/show_bug.cgi?id=51549
3488
3489         I've had multiple people ask me about the commit-queue's behavior
3490         regarding reporting flaky tests.  I figured it would be best to just
3491         have the queue explain itself in the bugs it files.
3492
3493         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3494         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3495
3496 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3497
3498         Reviewed by Eric Seidel.
3499
3500         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3501         https://bugs.webkit.org/show_bug.cgi?id=51467
3502
3503         * Scripts/webkitpy/style/checker.py:
3504         * Scripts/webkitpy/style/checker_unittest.py:
3505
3506 2010-12-23  Adam Barth  <abarth@webkit.org>
3507
3508         Rubber-stamped by Eric Seidel.
3509
3510         Move JavaScriptGlue into Sources
3511         https://bugs.webkit.org/show_bug.cgi?id=51583
3512
3513         These tools refer to JavaScriptGlue and need to be updated to its new
3514         location.
3515
3516         * Scripts/build-webkit:
3517         * Scripts/do-file-rename:
3518         * Scripts/do-webcore-rename:
3519         * Scripts/webkitpy/common/config/build.py:
3520         * Scripts/webkitpy/common/config/build_unittest.py:
3521
3522 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3523
3524         Reviewed by Eric Seidel.
3525
3526         Bug 51539 - update iexploder scripts to point to new location
3527
3528         * Scripts/run-iexploder-tests:
3529         * Scripts/update-iexploder-cssproperties:
3530
3531 2010-12-23  Evan Martin  <evan@chromium.org>
3532
3533         Reviewed by Ryosuke Niwa.
3534
3535         [chromium] LayoutTestController warning in float->int conversion
3536         https://bugs.webkit.org/show_bug.cgi?id=51553
3537
3538         Rather than reading an int, converting to a float, then getting a compiler
3539         warning on passing the float to something that expects an int, instead
3540         just pass around ints.
3541
3542         No tests, fixes a compiler warning.
3543
3544         * DumpRenderTree/chromium/LayoutTestController.cpp:
3545         (parsePageSizeParameters):
3546         (LayoutTestController::pageNumberForElementById):
3547         (LayoutTestController::numberOfPages):
3548
3549 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3550
3551         Reviewed by Darin Adler.
3552
3553         Bug 51537 - iexploder needs cleanup
3554         
3555         * iExploder/htdocs: Removed.
3556         * iExploder/htdocs/config.rb: Removed.
3557         * iExploder/htdocs/cssproperties.in: Removed.
3558         * iExploder/htdocs/cssvalues.in: Removed.
3559         * iExploder/htdocs/htmlattrs.in: Removed.
3560         * iExploder/htdocs/htmltags.in: Removed.
3561         * iExploder/htdocs/htmlvalues.in: Removed.
3562         * iExploder/htdocs/iexploder.cgi: Removed.
3563         * iExploder/htdocs/iexploder.rb: Removed.
3564         * iExploder/htdocs/index.html: Removed.
3565         * iExploder/htdocs/webserver.rb: Removed.
3566         * iExploder/iexploder-1.7.2/output: Removed.
3567         * iExploder/tools: Removed.
3568         * iExploder/tools/lasthit.rb: Removed.
3569         * iExploder/tools/osx_last_crash.rb: Removed.
3570         * iExploder/tools/showtest.rb: Removed.
3571
3572 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3573
3574         Reviewed by Kenneth Rohde Christiansen.
3575
3576         [EFL] Make 'single' the default backing store in EWebLauncher
3577         https://bugs.webkit.org/show_bug.cgi?id=51534
3578
3579         'single' is the simplest backing store and the one intended to be the
3580         default in the test browser. By mistake the tiled backing store was
3581         left as default in r72617.
3582
3583         * EWebLauncher/main.c:
3584         (browserCreate): ditto.
3585
3586 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3587
3588         Reviewed by Kenneth Rohde Christiansen.
3589
3590         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3591         https://bugs.webkit.org/show_bug.cgi?id=51533
3592
3593         There's no point in concatenating env("HOME") with "blah", so remove
3594         option from EWebLauncher.
3595
3596         * EWebLauncher/main.c:
3597         (main): ditto.
3598
3599 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3600
3601         Reviewed by Eric Seidel.
3602
3603         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3604
3605         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3606         I just discovered that we have two additional GC runs per each WebViewHost.
3607         Test_shell had no such calls.
3608         These gc runs eat 15% of cpu time.
3609
3610         https://bugs.webkit.org/show_bug.cgi?id=51479
3611
3612         * DumpRenderTree/chromium/WebViewHost.cpp:
3613         (WebViewHost::~WebViewHost):
3614
3615 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3616
3617         Reviewed by Ojan Vafai.
3618
3619         This change splits out the TestRunner class into its own file.
3620         When we fork the code for message passing, we will create a new
3621         TestRunner, and this change will allow that to be more modular.
3622
3623         While we're at it, split out TestInput and ResultSummary into
3624         their own files, to reduce the size of run_webkit_tests to
3625         something more managable.
3626
3627         https://bugs.webkit.org/show_bug.cgi?id=51092
3628
3629         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3630         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3631         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3632         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3633         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3634         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3635         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3636
3637  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3638
3639         Reviewed by Ojan Vafai.
3640
3641         nrwt multiprocessing - start over, prepare to fork the code
3642  
3643         This code cleans up the signatures and implementation of the
3644         TestRunner class so we can easily fork it to run either the
3645         stable implementation or the new, unstable message-passing
3646         implementation. The two variants will have different
3647         implementations of the run_tests() method. We will switch
3648         between the two based on the setting for the '--worker-model'
3649         switch. We rename the two currently valid values to 'old-inline'
3650         and 'old-threads'.
3651
3652         https://bugs.webkit.org/show_bug.cgi?id=51081
3653
3654         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3655         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3656
3657 2010-12-22  Victor Wang  <victorw@chromium.org>
3658
3659         Reviewed by Darin Fisher.
3660
3661         [Chromium] Update chromium archive test result url in rebaseline script.
3662
3663         https://bugs.webkit.org/show_bug.cgi?id=51503
3664
3665         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3666
3667 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3668
3669         Reviewed by Alice Liu.
3670
3671         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3672         Verified on Chrome, Safari, and IE.
3673         With this change, we will record memory from a parent browser window and all child processes.
3674
3675         * record-memory-win/main.cpp:
3676         (ProcessArgs):
3677         (PrintUsage):
3678         (getMemoryInfo):
3679         (printProcessInfo):
3680         (evalProcesses):
3681         (UseImage):
3682         (QueryContinuously):
3683         (ElapsedTime):
3684
3685 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3686
3687         Unreviewed rollout r74489, because it was missing changelog.
3688
3689         * record-memory-win/main.cpp:
3690         
3691 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3692
3693         Adding myself as a reviewer.
3694
3695         * Scripts/webkitpy/common/config/committers.py:
3696
3697 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3698
3699         Unreviewed.  Adding myself to committers.py.
3700
3701         * Scripts/webkitpy/common/config/committers.py:
3702
3703 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3704