a8617e4f7e8dd8b3856b93ada85cb09a89e1710c
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2
3         Add unit test for r239322
4         https://bugs.webkit.org/show_bug.cgi?id=197236
5
6         Reviewed by Chris Dumez.
7
8         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
9         May as well add the test infrastructure which was needed before and will be needed in the future.
10
11         * TestWebKitAPI/TCPServer.cpp:
12         (TestWebKitAPI::TCPServer::TCPServer):
13         * TestWebKitAPI/TCPServer.h:
14         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
15         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
16         (TestWebKitAPI::TEST):
17         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
18         (TestWebKitAPI::downloadAtRate):
19         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
20         (TEST):
21         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
22         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
23         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
24         (TestWebKitAPI::TEST):
25         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
26         (TEST):
27
28 2019-04-24  Chris Dumez  <cdumez@apple.com>
29
30         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
31         https://bugs.webkit.org/show_bug.cgi?id=197214
32         <rdar://problem/49237544>
33
34         Reviewed by Alex Christensen.
35
36         Extend API test coverage.
37
38         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
39         (TEST):
40
41 2019-04-24  Philippe Normand  <pnormand@igalia.com>
42
43         [Build][GStreamer] Update to 1.16.0
44         https://bugs.webkit.org/show_bug.cgi?id=197157
45
46         Reviewed by Xabier Rodriguez-Calvar.
47
48         The upstreamed patches were removed and a new one was added for a
49         regression detected in the scaletempo GStreamer element. The GNOME
50         Flatpak was migrated to 3.32 and I switched a few modules to Meson
51         on the way, as it is the preferred build system now in GStreamer
52         1.16.
53
54         * flatpak/files/httpd-autogen.sh:
55         * flatpak/flatpakutils.py:
56         (FlatpakPackage.install):
57         (WebkitFlatpak.run_in_sandbox):
58         * flatpak/org.webkit.CommonModules.yaml:
59         * flatpak/org.webkit.WebKit.yaml:
60         * gstreamer/jhbuild.modules:
61         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
62         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
63         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
64         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
65         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
66         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
67         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
68         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
69         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
70         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
71         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
72         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
73         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
74         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
75         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
76         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
77         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
78         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
79         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
80         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
81         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
82         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
83
84 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
85
86         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
87         https://bugs.webkit.org/show_bug.cgi?id=197156
88
89         Reviewed by Michael Catanzaro.
90
91         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
92         support was added.
93
94         * MiniBrowser/gtk/BrowserTab.c:
95         (browser_tab_set_background_color): Set the passed in color as web view background color.
96         * MiniBrowser/gtk/BrowserTab.h:
97         * MiniBrowser/gtk/BrowserWindow.c:
98         (browser_window_init): Initialize backgroundColor.
99         (browser_window_append_view): Call browser_tab_set_background_color().
100         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
101         are added.
102         * MiniBrowser/gtk/main.c:
103         (main): Call browser_window_set_background_color() before creating the tabs.
104
105 2019-04-23  John Wilander  <wilander@apple.com>
106
107         Move Ad Click Attribution from internal feature to experimental feature
108         https://bugs.webkit.org/show_bug.cgi?id=197218
109         <rdar://problem/47651691>
110
111         Reviewed by Brent Fulgham.
112
113         * DumpRenderTree/TestOptions.cpp:
114         (TestOptions::TestOptions):
115
116 2019-04-23  Andy Estes  <aestes@apple.com>
117
118         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
119         https://bugs.webkit.org/show_bug.cgi?id=196749
120         <rdar://problem/35773454>
121
122         Reviewed by Daniel Bates.
123
124         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
125
126         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
127         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
128         (-[QuickLookDelegate webView:didFinishNavigation:]):
129         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
130         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
131         (runTest):
132         (runTestDecideBeforeLoading):
133         (runTestDecideAfterLoading):
134         (TEST):
135
136 2019-04-23  John Wilander  <wilander@apple.com>
137
138         Remove Ad Click Attribution data when removing website data
139         https://bugs.webkit.org/show_bug.cgi?id=197215
140         <rdar://problem/47668988>
141
142         Reviewed by Chris Dumez.
143
144         This patch adds test infrastructure to delete Ad Click Attribution data
145         through WebsiteDataStore::removeData().
146
147         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
148         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
149         (WTR::TestRunner::clearAdClickAttribution):
150         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
151         * WebKitTestRunner/InjectedBundle/TestRunner.h:
152         * WebKitTestRunner/TestController.cpp:
153         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
154         * WebKitTestRunner/TestController.h:
155         * WebKitTestRunner/TestInvocation.cpp:
156         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
157
158 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
159
160         webkitpy: Kill unresponsive worker processes
161         https://bugs.webkit.org/show_bug.cgi?id=197205
162         <rdar://problem/50104388>
163
164         Reviewed by Lucas Forschler.
165
166         * Scripts/webkitpy/common/message_pool.py:
167         (_MessagePool.__init__): Add close timeout.
168         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
169
170 2019-04-23  Alex Christensen  <achristensen@webkit.org>
171
172         Add unit tests for WKWebView.serverTrust
173         https://bugs.webkit.org/show_bug.cgi?id=197202
174
175         Reviewed by Youenn Fablet
176
177         * TestWebKitAPI/TCPServer.cpp:
178         (TestWebKitAPI::deleter<BIO>::operator()):
179         (TestWebKitAPI::deleter<SSL>::operator()):
180         (TestWebKitAPI::deleter<X509>::operator()):
181         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
182         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
183         (TestWebKitAPI::TCPServer::TCPServer):
184         (TestWebKitAPI::TCPServer::listenForConnections):
185         * TestWebKitAPI/TCPServer.h:
186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
187         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
188         (TestWebKitAPI::TEST):
189         (verifyCertificateAndPublicKey):
190         (-[ServerTrustDelegate webView:didFinishNavigation:]):
191         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
192         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
193         (TestWebKitAPI::downloadAtRate):
194         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
195         (TEST):
196         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
197         (TEST):
198
199 2019-04-23  Commit Queue  <commit-queue@webkit.org>
200
201         Unreviewed, rolling out r244556.
202         https://bugs.webkit.org/show_bug.cgi?id=197212
203
204         Causing build failures on multiple builders (Requested by
205         ShawnRoberts on #webkit).
206
207         Reverted changeset:
208
209         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
210         https://bugs.webkit.org/show_bug.cgi?id=197171
211         https://trac.webkit.org/changeset/244556
212
213 2019-04-23  Alex Christensen  <achristensen@webkit.org>
214
215         Fix iOS build.
216         https://bugs.webkit.org/show_bug.cgi?id=195537
217
218         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
219         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
220         AdoptWK constructor is private now.  Use adoptWK instead.
221
222 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
223
224         Accessibility text search and selection API enhancements.
225         https://bugs.webkit.org/show_bug.cgi?id=197095
226         <rdar://problem/48181791>
227
228         Reviewed by Chris Fleizach.
229
230         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
231
232         * DumpRenderTree/AccessibilityTextMarker.h:
233         * DumpRenderTree/AccessibilityUIElement.cpp:
234         (searchTextWithCriteriaCallback):
235         (AccessibilityUIElement::getJSClass):
236         * DumpRenderTree/AccessibilityUIElement.h:
237         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
238         (convertVectorToObjectArray):
239         (convertNSArrayToVector):
240         (searchTextParameterizedAttributeForCriteria):
241         (AccessibilityUIElement::getLinkedUIElements):
242         (AccessibilityUIElement::getDocumentLinks):
243         (AccessibilityUIElement::getChildren):
244         (AccessibilityUIElement::getChildrenWithRange):
245         (AccessibilityUIElement::rowHeaders const):
246         (AccessibilityUIElement::columnHeaders const):
247         (AccessibilityUIElement::uiElementArrayAttributeValue const):
248         (AccessibilityUIElement::searchTextWithCriteria):
249         (AccessibilityUIElement::attributesOfColumnHeaders):
250         (AccessibilityUIElement::attributesOfRowHeaders):
251         (AccessibilityUIElement::attributesOfColumns):
252         (AccessibilityUIElement::attributesOfRows):
253         (AccessibilityUIElement::attributesOfVisibleCells):
254         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
255         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
256         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
257         (WTR::convertVectorToObjectArray):
258         (WTR::convertNSArrayToVector):
259         (WTR::searchTextParameterizedAttributeForCriteria):
260         (WTR::AccessibilityUIElement::getLinkedUIElements):
261         (WTR::AccessibilityUIElement::getDocumentLinks):
262         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
263         (WTR::AccessibilityUIElement::getChildren):
264         (WTR::AccessibilityUIElement::getChildrenWithRange):
265         (WTR::AccessibilityUIElement::rowHeaders const):
266         (WTR::AccessibilityUIElement::columnHeaders const):
267         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
268         (WTR::AccessibilityUIElement::searchTextWithCriteria):
269         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
270         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
271         (WTR::AccessibilityUIElement::attributesOfColumns):
272         (WTR::AccessibilityUIElement::attributesOfRows):
273         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
274         (WTR::convertElementsToObjectArray): Deleted.
275
276 2019-04-23  Guy Lewin  <guy@lewin.co.il>
277
278         Multiple File Input Icon Set Regardless of File List
279         https://bugs.webkit.org/show_bug.cgi?id=195537
280
281         Reviewed by Alexey Proskuryakov.
282
283         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
284         display string in iOS file inputs
285
286         * DumpRenderTree/TestRunner.cpp:
287         (SetOpenPanelFilesMediaIconCallback):
288         (TestRunner::staticFunctions):
289         (TestRunner::setOpenPanelFilesMediaIcon):
290         * DumpRenderTree/TestRunner.h:
291         (TestRunner::openPanelFilesMediaIcon const):
292         * DumpRenderTree/mac/UIDelegate.mm:
293         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
294         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
296         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
297         * WebKitTestRunner/InjectedBundle/TestRunner.h:
298         * WebKitTestRunner/TestController.cpp:
299         (WTR::runOpenPanel):
300         (WTR::TestController::resetStateToConsistentValues):
301         * WebKitTestRunner/TestController.h:
302         (WTR::TestController::openPanelFileURLsMediaIcon const):
303         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
304         * WebKitTestRunner/TestInvocation.cpp:
305         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
306
307 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
308
309         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
310         https://bugs.webkit.org/show_bug.cgi?id=197171
311         <rdar://problem/47454979>
312
313         Reviewed by Youenn Fablet.
314
315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
316         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
317         (TestWebKitAPI::TEST):
318
319 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
320
321         [ews-build] Add unit tests for UnApplyPatchIfRequired
322         https://bugs.webkit.org/show_bug.cgi?id=197197
323
324         Reviewed by Lucas Forschler.
325
326         * BuildSlaveSupport/ews-build/steps_unittest.py:
327         (TestUnApplyPatchIfRequired):
328         (TestUnApplyPatchIfRequired.test_success):
329         (TestUnApplyPatchIfRequired.test_failure):
330         (TestUnApplyPatchIfRequired.test_skip):
331
332 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
333
334         [ews-build] Add unit tests for CleanWorkingDirectory
335         https://bugs.webkit.org/show_bug.cgi?id=197195
336
337         Reviewed by Lucas Forschler.
338
339         * BuildSlaveSupport/ews-build/steps_unittest.py:
340         (TestCleanWorkingDirectory):
341         (TestCleanWorkingDirectory.test_success):
342         (TestCleanWorkingDirectory.test_failure):
343
344 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
345
346         [ews-build] Use explicit imports instead of wildcard imports
347         https://bugs.webkit.org/show_bug.cgi?id=197194
348
349         Reviewed by Lucas Forschler.
350
351         * BuildSlaveSupport/ews-build/factories.py:
352         * BuildSlaveSupport/ews-build/loadConfig.py:
353         * BuildSlaveSupport/ews-build/steps_unittest.py:
354
355 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
356
357         [ews-build] Add unit tests for DownloadBuiltProduct
358         https://bugs.webkit.org/show_bug.cgi?id=197193
359
360         Reviewed by Lucas Forschler.
361
362         * BuildSlaveSupport/ews-build/steps_unittest.py:
363         (TestDownloadBuiltProduct):
364         (TestDownloadBuiltProduct.setUp):
365         (TestDownloadBuiltProduct.tearDown):
366         (TestDownloadBuiltProduct.test_success):
367         (TestDownloadBuiltProduct.test_failure):
368
369 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
370
371         [ews-app] Exception while loading status-bubble when no build step has started
372         https://bugs.webkit.org/show_bug.cgi?id=196676
373
374         Reviewed by Lucas Forschler.
375
376         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
377         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
378
379 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
380
381         [PlayStation] Support running of JSC tests on remote playstation devices
382         https://bugs.webkit.org/show_bug.cgi?id=197170
383
384         Reviewed by Ross Kirsling.
385
386         Script changes
387
388         * Scripts/run-javascriptcore-tests:
389         (runJSCStressTests): Pass arguments for playstation to
390         run-jsc-stress-tests
391         * Scripts/run-jsc-stress-tests:
392         Handle $hostOS=="playstation" for determineArchitecture, turning
393         off $isFTLPlatform and runProfiler and defaulting test writer.
394         * Scripts/webkitdirs.pm:
395         (jscPath): PlayStation WebKit executables have .elf extension
396         (executableProductDir): PlayStation builds on Windows hosts but
397         uses bin directory rather than bin64/bin32 for executable output
398         location.
399         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
400
401 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
402
403         [CMake][Win] Use target oriented design for WebKit
404         https://bugs.webkit.org/show_bug.cgi?id=197173
405
406         Reviewed by Alex Christensen.
407
408         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
409         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
410
411 2019-04-23  Chris Dumez  <cdumez@apple.com>
412
413         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
414         https://bugs.webkit.org/show_bug.cgi?id=197097
415         <rdar://problem/50048318>
416
417         Reviewed by Alex Christensen.
418
419         Add API test coverage.
420
421         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
422         (-[PSONScheme webView:startURLSchemeTask:]):
423
424 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
425
426         [ATK] Implement AtkComponentIface scroll_to methods
427         https://bugs.webkit.org/show_bug.cgi?id=196856
428
429         Reviewed by Michael Catanzaro.
430
431         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
432         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
433         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
434         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
435
436 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
437
438         [ews-build] Improve summary for UploadBuiltProduct step
439         https://bugs.webkit.org/show_bug.cgi?id=197182
440
441         Reviewed by Lucas Forschler.
442
443         * BuildSlaveSupport/ews-build/steps.py:
444         (UploadBuiltProduct): Added descriptionDone.
445         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
446         * BuildSlaveSupport/ews-build/steps_unittest.py:
447         (TestUploadBuiltProduct.test_success): Updated unit-test.
448         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
449
450 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
451
452         [ews-build] Trigger queues only after uploading the archive
453         https://bugs.webkit.org/show_bug.cgi?id=197180
454
455         Reviewed by Lucas Forschler.
456
457         * BuildSlaveSupport/ews-build/factories.py:
458         (Factory.__init__):
459         (BuildFactory.__init__): Remove trigger step from factories.
460         (BuildFactory.propertiesToPassToTriggers): Deleted.
461         * BuildSlaveSupport/ews-build/steps.py:
462         (ConfigureBuild.__init__): Confiure triggers property.
463         (Trigger): Step to trigger other queues.
464         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
465         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
466
467 2019-04-22  Alex Christensen  <achristensen@webkit.org>
468
469         Deprecate WKContextCreateWithInjectedBundlePath
470         https://bugs.webkit.org/show_bug.cgi?id=197169
471
472         Reviewed by Youenn Fablet.
473
474         * TestWebKitAPI/PlatformUtilities.cpp:
475         (TestWebKitAPI::Util::createContextWithInjectedBundle):
476         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
477
478 2019-04-22  Alex Christensen  <achristensen@webkit.org>
479
480         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
481         https://bugs.webkit.org/show_bug.cgi?id=197093
482         <rdar://problem/49708268>
483
484         Reviewed by Chris Dumez.
485
486         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
487         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
488         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
489         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
490         and one for loads without credentials, so there are two TCP connections to the same server in this test.
491
492         * TestWebKitAPI/TCPServer.cpp:
493         (TestWebKitAPI::TCPServer::TCPServer):
494         (TestWebKitAPI::TCPServer::~TCPServer):
495         (TestWebKitAPI::TCPServer::socketBindListen):
496         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
497         * TestWebKitAPI/TCPServer.h:
498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
499         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
500         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
501         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
502         (respondWithChallengeThenOK):
503         (TestWebKitAPI::TEST):
504         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
505         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
506         (TEST):
507
508 2019-04-22  Chris Dumez  <cdumez@apple.com>
509
510         Delayed WebProcessLaunch may break the _relatedWebView SPI
511         https://bugs.webkit.org/show_bug.cgi?id=197160
512
513         Reviewed by Alex Christensen.
514
515         Add API test coverage.
516
517         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
518
519 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
520
521         Use curl to download packages for webkitpy autoinstaller
522         https://bugs.webkit.org/show_bug.cgi?id=197164
523
524         Reviewed by Darin Adler.
525
526         * Scripts/webkitpy/common/system/autoinstall.py:
527         (AutoInstaller._download): Use curl(1) to download packages necessary for
528         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
529         errors which are not present when using curl(1).
530
531 2019-04-22  Chris Dumez  <cdumez@apple.com>
532
533         Unreviewed, rolling out r244502.
534
535         Caused crashes on the bots
536
537         Reverted changeset:
538
539         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
540         https://bugs.webkit.org/show_bug.cgi?id=197160
541         https://trac.webkit.org/changeset/244502
542
543 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
544
545         Unreviewed, rolling out r244437.
546
547         Still breaks internal tests.
548
549         Reverted changeset:
550
551         "InjectedBundle parameters often need initialization function
552         called before unarchiving"
553         https://bugs.webkit.org/show_bug.cgi?id=189709
554         https://trac.webkit.org/changeset/244437
555
556 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
557
558         [ews-build] Use singular verb in failure description in case of single api test failure
559         https://bugs.webkit.org/show_bug.cgi?id=197013
560
561         Reviewed by Lucas Forschler.
562
563         * BuildSlaveSupport/ews-build/steps.py:
564         (AnalyzeAPITestsResults.analyzeResults):
565
566 2019-04-22  Chris Dumez  <cdumez@apple.com>
567
568         Delayed WebProcessLaunch may break the _relatedWebView SPI
569         https://bugs.webkit.org/show_bug.cgi?id=197160
570
571         Reviewed by Alex Christensen.
572
573         Add API test coverage.
574
575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
576
577 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
578
579         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
580         https://bugs.webkit.org/show_bug.cgi?id=194630
581
582         Reviewed by Michael Catanzaro.
583
584         Return early from getAttributeSet() is passed in accessible is nullptr.
585
586         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
587
588 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
589
590         Defer EditorState updates until the next layer tree flush in a few additional circumstances
591         https://bugs.webkit.org/show_bug.cgi?id=197145
592         <rdar://problem/50078170>
593
594         Reviewed by Darin Adler.
595
596         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
597         focus, or showing the font manager.
598
599         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
600         (TestWebKitAPI::TEST):
601         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
602         (TEST):
603         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
604         (TestWebKitAPI::TEST):
605
606 2019-04-21  Brian Burg  <bburg@apple.com>
607
608         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
609         https://bugs.webkit.org/show_bug.cgi?id=197125
610         <rdar://problem/50061468>
611
612         Reviewed by Darin Adler.
613
614         Sometimes I want to run wptserve independently of tests. Make it easier to script that
615         using this class rather than making our own ./wpt serve invocation.
616
617         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
618         (WebDriverW3CWebServer):
619         (WebDriverW3CWebServer.document_root): Expose this to clients.
620         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
621
622         (WebDriverW3CWebServer.__enter__):
623         (WebDriverW3CWebServer.__exit__):
624         Make it possible to use the web server with a 'with' statement.
625
626 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
627
628         [CMake][Win] Use target oriented design for WebKitLegacy
629         https://bugs.webkit.org/show_bug.cgi?id=197112
630
631         Reviewed by Konstantin Tokarev.
632
633         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
634
635         * DumpRenderTree/CMakeLists.txt:
636         * DumpRenderTree/PlatformWin.cmake:
637         * DumpRenderTree/win/EventSender.cpp:
638
639 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
640
641         Update text for old EWS submit button
642         https://bugs.webkit.org/show_bug.cgi?id=197140
643
644         Reviewed by Alexey Proskuryakov.
645
646         * QueueStatusServer/templates/statusbubble.html:
647
648 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
649
650         [ews-app] New EWS should poll bugzilla more frequently
651         https://bugs.webkit.org/show_bug.cgi?id=197138
652
653         Reviewed by Alexey Proskuryakov.
654
655         * BuildSlaveSupport/ews-app/ews/fetcher.py:
656         (FetchLoop.__init__):
657
658 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
659
660         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
661         https://bugs.webkit.org/show_bug.cgi?id=197139
662
663         Reviewed by Alexey Proskuryakov.
664
665         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
666         * QueueStatusServer/templates/statusbubble.html:
667
668 2019-04-20  Chris Dumez  <cdumez@apple.com>
669
670         Unreviewed, fix iOS build with recent SDKs.
671
672         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
673
674 2019-04-19  Keith Miller  <keith_miller@apple.com>
675
676         Add script to merge run_benchmark jsons
677         https://bugs.webkit.org/show_bug.cgi?id=197107
678
679         Reviewed by Michael Saboff.
680
681         The script basically recursively decends through all json objects until it gets
682         to an array or JSON primitive and concats or takes the first value, respectively.
683
684         This patch also adds +x bits to the compare-results script so it
685         can be run directly from the command line. I had to add a new line so that svn
686         will accept the change... yay svn!
687
688         * Scripts/compare-results:
689         * Scripts/merge-result-jsons: Added.
690         (readJSONFile):
691         (deepAppend):
692         (mergeJSONs):
693         (main):
694
695 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
696
697         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
698         https://bugs.webkit.org/show_bug.cgi?id=197079
699
700         Reviewed by Darin Adler.
701
702         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
703
704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
705         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
706
707 2019-04-18  Commit Queue  <commit-queue@webkit.org>
708
709         Unreviewed, rolling out r244434.
710         https://bugs.webkit.org/show_bug.cgi?id=197089
711
712         caused 1 API test failure (Requested by zalan on #webkit).
713
714         Reverted changeset:
715
716         "Regression (r244291): Broken API Test
717         AutoLayoutRenderingProgressRelativeOrdering"
718         https://bugs.webkit.org/show_bug.cgi?id=196948
719         https://trac.webkit.org/changeset/244434
720
721 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
722
723         Add new compatibility mode API on WKNavigation
724         https://bugs.webkit.org/show_bug.cgi?id=197069
725         <rdar://problem/50025800>
726
727         Reviewed by Tim Horton.
728
729         Add a block property for -didCommitNavigation to TestNavigationDelegate.
730
731         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
732         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
733         (-[TestNavigationDelegate webView:didCommitNavigation:]):
734
735 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
736
737         [CMake] Make WebCore headers copies
738         https://bugs.webkit.org/show_bug.cgi?id=182512
739         <rdar://problem/37510435>
740
741         Reviewed by Alex Christensen.
742
743         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
744         ports.
745
746         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
747         of WebCore headers using "*.h" were modified to <WebCore/*.h>
748
749         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
750         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
751         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
752         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
753         * TestWebKitAPI/CMakeLists.txt:
754         * TestWebKitAPI/PlatformWin.cmake:
755         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
756         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
757         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
758
759 2019-04-18  Jer Noble  <jer.noble@apple.com>
760
761         Add support for parsing FairPlayStreaming PSSH boxes.
762         https://bugs.webkit.org/show_bug.cgi?id=197064
763
764         Reviewed by Eric Carlson.
765
766         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
767         (TestWebKitAPI::TEST):
768
769 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
770
771         InjectedBundle parameters often need initialization function called before unarchiving
772         https://bugs.webkit.org/show_bug.cgi?id=189709
773         <rdar://problem/44573653>
774
775         Reviewed by Ryosuke Niwa.
776
777         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
778         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
779
780 2019-04-18  Zalan Bujtas  <zalan@apple.com>
781
782         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
783         https://bugs.webkit.org/show_bug.cgi?id=196948
784         <rdar://problem/49927131>
785
786         Reviewed by Tim Horton.
787
788         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
789         (TEST): 
790         The expected order of incoming events is
791         1. didInvalidateIntrinsicContentSize
792         2. didFirstLayout
793         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
794         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
795         (and remember, all we care about is ordering).
796
797 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
798
799         Unreviewed, rolling out r244299.
800
801         Breaks internal tests.
802
803         Reverted changeset:
804
805         "InjectedBundle parameters often need initialization function
806         called before unarchiving"
807         https://bugs.webkit.org/show_bug.cgi?id=189709
808         https://trac.webkit.org/changeset/244299
809
810 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
811
812         [WTF] StringBuilder should set correct m_is8Bit flag when merging
813         https://bugs.webkit.org/show_bug.cgi?id=197053
814
815         Reviewed by Saam Barati.
816
817         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
818         (TestWebKitAPI::TEST):
819
820 2019-04-17  Tim Horton  <timothy_horton@apple.com>
821
822         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
823         https://bugs.webkit.org/show_bug.cgi?id=197028
824         <rdar://problem/49985290>
825
826         Reviewed by Wenson Hsieh.
827
828         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
829         (TEST):
830         Liberal application of waitForNextPresentationUpdate works around a race
831         where if the page rapidly changes its viewport arguments (or an API client
832         rapidly changes its viewport arguments), we'd get stuck thinking that the
833         user had intentionally zoomed the page, and stop resetting the initial scale.
834         This deserves a separate bug, but no need to keep the test failing while
835         we think about it.
836
837 2019-04-17  Tim Horton  <timothy_horton@apple.com>
838
839         REGRESSION (r241988): Switching tabs is slow
840         https://bugs.webkit.org/show_bug.cgi?id=197037
841         <rdar://problem/49951473>
842
843         Reviewed by Simon Fraser.
844
845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
846         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
847         (TEST):
848         * TestWebKitAPI/cocoa/TestWKWebView.h:
849         * TestWebKitAPI/cocoa/TestWKWebView.mm:
850         (-[TestWKWebView addToTestWindow]):
851         Add a test that hangs without this fix.
852
853 2019-04-17  Truitt Savell  <tsavell@apple.com>
854
855         Unreviewed, rolling out r244400.
856
857         Caused testing to exit early with assertionon Debug WK2
858
859         Reverted changeset:
860
861         "UI↔Web deadlock when printing with a JavaScript alert
862         visible"
863         https://bugs.webkit.org/show_bug.cgi?id=196839
864         https://trac.webkit.org/changeset/244400
865
866 2019-04-17  Brady Eidson  <beidson@apple.com>
867
868         Link clicks in PDFs shouldn't send referrer headers.
869         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
870
871         Reviewed by Tim Horton.
872
873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
874         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
875         (putPDFBytesCallback):
876         (emptyReleaseInfoCallback):
877         (createPDFWithLinkToURL):
878         (TEST):
879
880 2019-04-17  Tim Horton  <timothy_horton@apple.com>
881
882         UI↔Web deadlock when printing with a JavaScript alert visible
883         https://bugs.webkit.org/show_bug.cgi?id=196839
884         <rdar://problem/49157642>
885
886         Reviewed by Andy Estes.
887
888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
889         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
890         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
891         (TEST):
892
893 2019-04-17  Alex Christensen  <achristensen@webkit.org>
894
895         WKRetainPtr's adoption constructor should be private
896         https://bugs.webkit.org/show_bug.cgi?id=197019
897
898         Reviewed by Tim Horton.
899
900         * DumpRenderTree/mac/DumpRenderTree.mm:
901         (dumpFramesAsText):
902         * TestWebKitAPI/InjectedBundleController.cpp:
903         (TestWebKitAPI::InjectedBundleController::initialize):
904         * TestWebKitAPI/PlatformUtilities.cpp:
905         (TestWebKitAPI::Util::createContextWithInjectedBundle):
906         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
907         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
908         (TestWebKitAPI::Util::toWK):
909         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
910         (TestWebKitAPI::TEST):
911         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
912         (TestWebKitAPI::TEST):
913         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
914         (TestWebKitAPI::TEST):
915         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
916         (TestWebKitAPI::TEST):
917         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
918         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
919         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
920         (TestWebKitAPI::TEST):
921         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
922         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
923         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
924         (TestWebKitAPI::TEST):
925         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
926         (TestWebKitAPI::TEST):
927         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
928         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
929         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
930         (TestWebKitAPI::TEST):
931         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
932         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
933         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
934         (TestWebKitAPI::TEST):
935         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
936         (TestWebKitAPI::TEST):
937         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
938         (TestWebKitAPI::TEST):
939         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
940         (TestWebKitAPI::TEST):
941         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
942         (TestWebKitAPI::TEST):
943         * TestWebKitAPI/Tests/WebKit/Find.cpp:
944         (TestWebKitAPI::TEST):
945         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
946         (TestWebKitAPI::TEST):
947         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
948         (TestWebKitAPI::TEST):
949         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
950         (TestWebKitAPI::TEST):
951         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
952         (TestWebKitAPI::TEST):
953         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
954         (TestWebKitAPI::TEST):
955         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
956         (TestWebKitAPI::TEST):
957         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
958         (TestWebKitAPI::TEST):
959         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
960         (TestWebKitAPI::TEST):
961         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
962         (TestWebKitAPI::TEST):
963         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
964         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
965         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
966         (TestWebKitAPI::TEST):
967         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
968         (TestWebKitAPI::TEST):
969         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
970         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
971         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
972         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
973         (TestWebKitAPI::TEST):
974         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
975         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
976         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
977         (TestWebKitAPI::TEST):
978         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
979         (TestWebKitAPI::TEST):
980         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
981         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
982         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
983         (TestWebKitAPI::TEST):
984         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
985         (TestWebKitAPI::loadAlternateHTMLString):
986         (TestWebKitAPI::TEST):
987         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
988         (TestWebKitAPI::TEST):
989         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
990         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
991         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
992         (TestWebKitAPI::buildAndPerformTest):
993         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
994         (TestWebKitAPI::TEST):
995         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
996         (TestWebKitAPI::TEST):
997         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
998         (TestWebKitAPI::TEST):
999         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1000         (TestWebKitAPI::TEST):
1001         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1002         (TestWebKitAPI::TEST):
1003         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1004         (TestWebKitAPI::TEST):
1005         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1006         (TestWebKitAPI::TEST):
1007         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1008         (TestWebKitAPI::TEST):
1009         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1010         (TestWebKitAPI::TEST):
1011         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1012         (TestWebKitAPI::TEST):
1013         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1014         (TestWebKitAPI::TEST):
1015         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1016         (TestWebKitAPI::TEST):
1017         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1018         (TestWebKitAPI::TEST):
1019         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1020         (TestWebKitAPI::TEST):
1021         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1022         (TestWebKitAPI::TEST):
1023         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1024         (TestWebKitAPI::TEST):
1025         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1026         (TestWebKitAPI::TEST):
1027         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1028         (TestWebKitAPI::TEST):
1029         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1030         (TestWebKitAPI::TEST):
1031         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1032         (TestWebKitAPI::TEST):
1033         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1034         (TestWebKitAPI::TEST):
1035         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1036         (TestWebKitAPI::TEST):
1037         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1038         (TestWebKitAPI::TEST):
1039         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1040         (TestWebKitAPI::TEST):
1041         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1042         (TestWebKitAPI::TEST):
1043         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1044         (TestWebKitAPI::TEST):
1045         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1046         (TestWebKitAPI::TEST):
1047         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1048         (TestWebKitAPI::TEST):
1049         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1050         (TestWebKitAPI::TEST):
1051         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1052         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1053         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1054         (TestWebKitAPI::TEST):
1055         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1056         (TestWebKitAPI::TEST):
1057         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1058         (TestWebKitAPI::TEST):
1059         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1060         (TestWebKitAPI::TEST):
1061         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1062         (TestWebKitAPI::TEST):
1063         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1064         (TestWebKitAPI::TEST):
1065         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1066         (TestWebKitAPI::TEST):
1067         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1068         (TestWebKitAPI::TEST):
1069         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1070         (TestWebKitAPI::TEST):
1071         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1072         (TestWebKitAPI::TEST):
1073         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1074         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1075         (TEST):
1076         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1077         (TEST):
1078         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1079         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1080         (TEST):
1081         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1082         (TestWebKitAPI::TEST):
1083         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1084         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1085         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1086         (WTR::getMenuItemTitleCallback):
1087         (WTR::createMouseMessageBody):
1088         (WTR::EventSendingController::mouseDown):
1089         (WTR::EventSendingController::mouseUp):
1090         (WTR::EventSendingController::mouseMoveTo):
1091         (WTR::EventSendingController::mouseForceClick):
1092         (WTR::EventSendingController::startAndCancelMouseForceClick):
1093         (WTR::EventSendingController::mouseForceDown):
1094         (WTR::EventSendingController::mouseForceUp):
1095         (WTR::EventSendingController::mouseForceChanged):
1096         (WTR::EventSendingController::leapForward):
1097         (WTR::EventSendingController::scheduleAsynchronousClick):
1098         (WTR::createKeyDownMessageBody):
1099         (WTR::EventSendingController::keyDown):
1100         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1101         (WTR::EventSendingController::mouseScrollBy):
1102         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1103         (WTR::EventSendingController::continuousMouseScrollBy):
1104         (WTR::EventSendingController::addTouchPoint):
1105         (WTR::EventSendingController::updateTouchPoint):
1106         (WTR::EventSendingController::setTouchModifier):
1107         (WTR::EventSendingController::setTouchPointRadius):
1108         (WTR::EventSendingController::touchStart):
1109         (WTR::EventSendingController::touchMove):
1110         (WTR::EventSendingController::touchEnd):
1111         (WTR::EventSendingController::touchCancel):
1112         (WTR::EventSendingController::clearTouchPoints):
1113         (WTR::EventSendingController::releaseTouchPoint):
1114         (WTR::EventSendingController::cancelTouchPoint):
1115         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1116         (WTR::InjectedBundle::didCreatePage):
1117         (WTR::InjectedBundle::didReceiveMessage):
1118         (WTR::InjectedBundle::didReceiveMessageToPage):
1119         (WTR::InjectedBundle::booleanForKey):
1120         (WTR::InjectedBundle::done):
1121         (WTR::InjectedBundle::dumpToStdErr):
1122         (WTR::InjectedBundle::outputText):
1123         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1124         (WTR::InjectedBundle::postAddChromeInputField):
1125         (WTR::InjectedBundle::postRemoveChromeInputField):
1126         (WTR::InjectedBundle::postFocusWebView):
1127         (WTR::InjectedBundle::postSetBackingScaleFactor):
1128         (WTR::InjectedBundle::postSetWindowIsKey):
1129         (WTR::InjectedBundle::postSetViewSize):
1130         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1131         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1132         (WTR::InjectedBundle::setGeolocationPermission):
1133         (WTR::InjectedBundle::setMockGeolocationPosition):
1134         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1135         (WTR::InjectedBundle::isGeolocationProviderActive const):
1136         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1137         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1138         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1139         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1140         (WTR::InjectedBundle::setCustomPolicyDelegate):
1141         (WTR::InjectedBundle::setHidden):
1142         (WTR::InjectedBundle::setCacheModel):
1143         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1144         (WTR::InjectedBundle::processWorkQueue):
1145         (WTR::InjectedBundle::queueBackNavigation):
1146         (WTR::InjectedBundle::queueForwardNavigation):
1147         (WTR::InjectedBundle::queueLoad):
1148         (WTR::InjectedBundle::queueLoadHTMLString):
1149         (WTR::InjectedBundle::queueReload):
1150         (WTR::InjectedBundle::queueLoadingScript):
1151         (WTR::InjectedBundle::queueNonLoadingScript):
1152         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1153         (WTR::frameToStr):
1154         (WTR::InjectedBundlePage::InjectedBundlePage):
1155         (WTR::dumpFrameDescriptionSuitableForTestResult):
1156         (WTR::dumpFrameScrollPosition):
1157         (WTR::dumpDescendantFrameScrollPositions):
1158         (WTR::dumpFrameText):
1159         (WTR::dumpDescendantFramesText):
1160         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1161         (WTR::TestRunner::shouldDumpPixels const):
1162         (WTR::TestRunner::setDumpPixels):
1163         (WTR::TestRunner::whatToDump const):
1164         (WTR::TestRunner::setWhatToDump):
1165         (WTR::TestRunner::setWaitUntilDone):
1166         (WTR::TestRunner::shouldWaitUntilDone const):
1167         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1168         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1169         (WTR::TestRunner::clearAllDatabases):
1170         (WTR::TestRunner::setIDBPerOriginQuota):
1171         (WTR::TestRunner::originsWithApplicationCache):
1172         (WTR::TestRunner::setCanOpenWindows):
1173         (WTR::TestRunner::setXSSAuditorEnabled):
1174         (WTR::TestRunner::setMediaDevicesEnabled):
1175         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1176         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1177         (WTR::TestRunner::setCustomUserAgent):
1178         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1179         (WTR::TestRunner::setModernMediaControlsEnabled):
1180         (WTR::TestRunner::setWebGL2Enabled):
1181         (WTR::TestRunner::setWritableStreamAPIEnabled):
1182         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1183         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1184         (WTR::TestRunner::setAllowsAnySSLCertificate):
1185         (WTR::TestRunner::setPluginsEnabled):
1186         (WTR::TestRunner::setValueForUser):
1187         (WTR::TestRunner::setAudioResult):
1188         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1189         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1190         (WTR::TestRunner::setAlwaysAcceptCookies):
1191         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1192         (WTR::TestRunner::isDoingMediaCapture const):
1193         (WTR::TestRunner::queueLoad):
1194         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1195         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1196         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1197         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1198         (WTR::TestRunner::setAuthenticationUsername):
1199         (WTR::TestRunner::setAuthenticationPassword):
1200         (WTR::TestRunner::secureEventInputIsEnabled const):
1201         (WTR::TestRunner::setBlockAllPlugins):
1202         (WTR::TestRunner::setPluginSupportedMode):
1203         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1204         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1205         (WTR::TestRunner::setNavigationGesturesEnabled):
1206         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1207         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1208         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1209         (WTR::TestRunner::terminateNetworkProcess):
1210         (WTR::TestRunner::terminateServiceWorkerProcess):
1211         (WTR::TestRunner::runUIScript):
1212         (WTR::TestRunner::setStatisticsDebugMode):
1213         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1214         (WTR::TestRunner::setStatisticsLastSeen):
1215         (WTR::TestRunner::setStatisticsPrevalentResource):
1216         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1217         (WTR::TestRunner::dumpResourceLoadStatistics):
1218         (WTR::TestRunner::isStatisticsPrevalentResource):
1219         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1220         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1221         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1222         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1223         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1224         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1225         (WTR::TestRunner::setStatisticsGrandfathered):
1226         (WTR::TestRunner::isStatisticsGrandfathered):
1227         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1228         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1229         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1230         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1231         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1232         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1233         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1234         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1235         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1236         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1237         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1238         (WTR::TestRunner::statisticsSubmitTelemetry):
1239         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1240         (WTR::TestRunner::setStatisticsIsRunningTest):
1241         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1242         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1243         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1244         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1245         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1246         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1247         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1248         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1249         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1250         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1251         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1252         (WTR::TestRunner::statisticsResetToConsistentState):
1253         (WTR::TestRunner::setStorageAccessAPIEnabled):
1254         (WTR::TestRunner::getAllStorageAccessEntries):
1255         (WTR::TestRunner::addMockMediaDevice):
1256         (WTR::TestRunner::clearMockMediaDevices):
1257         (WTR::TestRunner::removeMockMediaDevice):
1258         (WTR::TestRunner::resetMockMediaDevices):
1259         (WTR::TestRunner::connectMockGamepad):
1260         (WTR::TestRunner::disconnectMockGamepad):
1261         (WTR::TestRunner::setMockGamepadDetails):
1262         (WTR::TestRunner::setMockGamepadAxisValue):
1263         (WTR::TestRunner::setMockGamepadButtonValue):
1264         (WTR::TestRunner::removeAllSessionCredentials):
1265         (WTR::TestRunner::clearDOMCache):
1266         (WTR::TestRunner::clearDOMCaches):
1267         (WTR::TestRunner::hasDOMCache):
1268         (WTR::TestRunner::domCacheSize):
1269         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1270         (WTR::TestRunner::getApplicationManifestThen):
1271         (WTR::TestRunner::injectUserScript):
1272         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1273         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1274         (WTR::TestRunner::addTestKeyToKeychain):
1275         (WTR::TestRunner::cleanUpKeychain):
1276         (WTR::TestRunner::keyExistsInKeychain):
1277         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1278         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1279         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1280         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1281         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1282         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1283         * WebKitTestRunner/TestController.cpp:
1284         (WTR::TestController::initialize):
1285         (WTR::parseStringTestHeaderValueAsRelativePath):
1286         (WTR::updateTestOptionsFromTestHeader):
1287         (WTR::TestController::runTest):
1288         (WTR::TestController::didReceiveLiveDocumentsList):
1289         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1290         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1291         (WTR::TestController::didFinishNavigation):
1292         (WTR::TestController::didReceiveAuthenticationChallenge):
1293         * WebKitTestRunner/TestInvocation.cpp:
1294         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1295         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1296         (WTR::TestInvocation::uiScriptDidComplete):
1297         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1298         * WebKitTestRunner/WebNotificationProvider.cpp:
1299         (WTR::WebNotificationProvider::closeWebNotification):
1300         * WebKitTestRunner/WorkQueueManager.cpp:
1301         (WTR::ScriptItem::ScriptItem):
1302         (WTR::WorkQueueManager::queueLoad):
1303         (WTR::WorkQueueManager::queueLoadHTMLString):
1304
1305 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1306
1307         Add a comment to make my test from r244139 less mysterious.
1308         https://bugs.webkit.org/show_bug.cgi?id=196744
1309
1310         As suggested by Darin Adler.
1311
1312         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1313         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1314
1315 2019-04-17  Chris Dumez  <cdumez@apple.com>
1316
1317         Remember device orientation permission for the duration of the browsing session
1318         https://bugs.webkit.org/show_bug.cgi?id=196992
1319         <rdar://problem/49946067>
1320
1321         Reviewed by Alex Christensen.
1322
1323         Add API test coverage.
1324
1325         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1326         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1327         (TEST):
1328
1329 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1330
1331         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1332         https://bugs.webkit.org/show_bug.cgi?id=196675
1333
1334         Reviewed by Lucas Forschler.
1335
1336         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1337         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1338
1339 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1340
1341         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1342         https://bugs.webkit.org/show_bug.cgi?id=196919
1343         <rdar://problem/41630459>
1344
1345         Reviewed by Tim Horton.
1346
1347         Add iOS support for several new testing hooks. See below for more detail.
1348
1349         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1350         (WTR::UIScriptController::isDismissingMenu const):
1351
1352         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1353         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1354         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1355
1356         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1357         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1358         (WTR::UIScriptController::isDismissingMenu const):
1359         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1360         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1361         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1362         (WTR::InjectedBundle::didReceiveMessageToPage):
1363         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1364         (WTR::TestRunner::setAllowedMenuActions):
1365
1366         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1367         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1368         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1369         against the name of the custom action.
1370
1371         (WTR::TestRunner::installCustomMenuAction):
1372
1373         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1374         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1375         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1376         triggered.
1377
1378         (WTR::TestRunner::performCustomMenuAction):
1379
1380         Invoked when the custom menu action is triggered.
1381
1382         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1383         * WebKitTestRunner/TestController.cpp:
1384         (WTR::TestController::installCustomMenuAction):
1385         (WTR::TestController::setAllowedMenuActions):
1386         * WebKitTestRunner/TestController.h:
1387         * WebKitTestRunner/TestInvocation.cpp:
1388         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1389         (WTR::TestInvocation::performCustomMenuAction):
1390
1391         Add plumbing to call back into the injected bundle when performing the custom action.
1392
1393         * WebKitTestRunner/TestInvocation.h:
1394         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1395         (WTR::TestController::installCustomMenuAction):
1396         (WTR::TestController::setAllowedMenuActions):
1397         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1398         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1399         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1400         (-[TestRunnerWKWebView becomeFirstResponder]):
1401         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1402
1403         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1404         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1405         in the Mail app on iOS.
1406
1407         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1408         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1409         (-[TestRunnerWKWebView resetCustomMenuAction]):
1410         (-[TestRunnerWKWebView performCustomAction:]):
1411         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1412         (-[TestRunnerWKWebView _willHideMenu]):
1413         (-[TestRunnerWKWebView _didHideMenu]):
1414         * WebKitTestRunner/ios/TestControllerIOS.mm:
1415         (WTR::TestController::platformResetStateToConsistentValues):
1416
1417         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1418         if specified.
1419
1420         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1421         (WTR::UIScriptController::isDismissingMenu const):
1422
1423 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1424
1425         Allow sharing from imageSheet on an image document
1426         https://bugs.webkit.org/show_bug.cgi?id=196891
1427         <rdar://problem/25377386>
1428
1429         Reviewed by Tim Horton.
1430
1431         Test to make sure that the correct imageURL is extracted from an image element.
1432
1433         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1434         (TestWebKitAPI::TEST):
1435
1436 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1437
1438         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1439         https://bugs.webkit.org/show_bug.cgi?id=196995
1440
1441         Reviewed by Brady Eidson.
1442
1443         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1444         (TEST):
1445
1446 2019-04-16  Chris Dumez  <cdumez@apple.com>
1447
1448         URL set by document.open() is not communicated to the UIProcess
1449         https://bugs.webkit.org/show_bug.cgi?id=196941
1450         <rdar://problem/49237544>
1451
1452         Reviewed by Geoff Garen.
1453
1454         Add API test coverage.
1455
1456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1457         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1458         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1459         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1460         (TEST):
1461
1462 2019-04-16  Commit Queue  <commit-queue@webkit.org>
1463
1464         Unreviewed, rolling out r244321.
1465         https://bugs.webkit.org/show_bug.cgi?id=196968
1466
1467         Causing all WK2 Debug builds to exit early after Assertion
1468         failures. (Requested by ShawnRoberts on #webkit).
1469
1470         Reverted changeset:
1471
1472         "URL set by document.open() is not communicated to the
1473         UIProcess"
1474         https://bugs.webkit.org/show_bug.cgi?id=196941
1475         https://trac.webkit.org/changeset/244321
1476
1477 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1478
1479         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1480         https://bugs.webkit.org/show_bug.cgi?id=196948
1481
1482         Reviewed by Zalan Bujtas.
1483
1484         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1485         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1486
1487 2019-04-15  Chris Dumez  <cdumez@apple.com>
1488
1489         URL set by document.open() is not communicated to the UIProcess
1490         https://bugs.webkit.org/show_bug.cgi?id=196941
1491         <rdar://problem/49237544>
1492
1493         Reviewed by Geoffrey Garen.
1494
1495         Add API test coverage.
1496
1497         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1498         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1499         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1500         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1501         (TEST):
1502
1503 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1504
1505         Using Tools/Scripts/clean-webkit should not install requests
1506         https://bugs.webkit.org/show_bug.cgi?id=196940
1507
1508         Reviewed by Lucas Forschler.
1509
1510         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1511         existing, depending on the path autoinstalled is run through.
1512         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1513         needed.
1514         (Port.configuration_for_upload):
1515         (Port.commits_for_upload):
1516
1517 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1518
1519         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1520         https://bugs.webkit.org/show_bug.cgi?id=196773
1521
1522         Reviewed by Jer Noble.
1523
1524         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1525         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1526         (TEST):
1527
1528 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1529
1530         ews-build should clearly indicate flaky test failures
1531         https://bugs.webkit.org/show_bug.cgi?id=196947
1532
1533         Reviewed by Lucas Forschler.
1534
1535         * BuildSlaveSupport/ews-build/steps.py:
1536         (AnalyzeAPITestsResults.analyzeResults):
1537
1538 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1539
1540         InjectedBundle parameters often need initialization function called before unarchiving
1541         https://bugs.webkit.org/show_bug.cgi?id=189709
1542         <rdar://problem/44573653>
1543
1544         Reviewed by Ryosuke Niwa.
1545
1546         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1547         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1548
1549 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1550
1551         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1552         https://bugs.webkit.org/show_bug.cgi?id=196681
1553
1554         Reviewed by Darin Adler.
1555
1556         Added tests.
1557
1558         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1559         (WTF_HashSet.RemoveIf):
1560         (WTF_HashSet.RemoveIfShrinkToBestSize):
1561
1562 2019-04-15  John Wilander  <wilander@apple.com>
1563
1564         Send delayed Ad Click Attribution conversion requests to the click source
1565         https://bugs.webkit.org/show_bug.cgi?id=196838
1566         <rdar://problem/47650157>
1567
1568         Reviewed by Chris Dumez and Youenn Fablet.
1569
1570         This patch adds test infrastructure to override the default behavior in
1571         WebKit::NetworkAdClickAttribution.
1572
1573         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1574         (TestWebKitAPI::TEST):
1575         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1576         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1577         (WTR::TestRunner::dumpAdClickAttribution):
1578         (WTR::TestRunner::clearAdClickAttribution):
1579         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1580         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1581         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1582         * WebKitTestRunner/TestController.cpp:
1583         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1584         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1585         * WebKitTestRunner/TestController.h:
1586         * WebKitTestRunner/TestInvocation.cpp:
1587         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1588
1589 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1590
1591         [ews-app] status-bubble should display position in queue
1592         https://bugs.webkit.org/show_bug.cgi?id=196607
1593
1594         Reviewed by Lucas Forschler.
1595
1596         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1597         (StatusBubble._build_bubble):
1598         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1599
1600 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1601
1602         [ews-build] Do not run clean build by default on EWS builders
1603         https://bugs.webkit.org/show_bug.cgi?id=196897
1604
1605         Reviewed by Lucas Forschler.
1606
1607         * BuildSlaveSupport/ews-build/steps.py:
1608         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1609         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1610         untracked directories like WebKitBuild).
1611         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1612         untracked files/directories (like WebKitBuild).
1613
1614 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1615
1616         TestRunner::notifyDone() should be safely reentrant
1617         https://bugs.webkit.org/show_bug.cgi?id=196898
1618
1619         Reviewed by Darin Adler.
1620
1621         It is currently possible that TestRunner::notifyDone() will call itself, since
1622         notifyDone() will force a repaint, which can start executing JavaScript, which
1623         may call notifyDone() again. This can lead to test failures and flakiness.
1624         Fix this by setting the m_waitToDump flag before calling the dump() method.
1625
1626         * DumpRenderTree/mac/TestRunnerMac.mm:
1627         (TestRunner::notifyDone):
1628         (TestRunner::forceImmediateCompletion):
1629         * DumpRenderTree/win/TestRunnerWin.cpp:
1630         (TestRunner::notifyDone):
1631         (TestRunner::forceImmediateCompletion):
1632
1633 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1634
1635         [GTK][WPE] Add enable-media websetting
1636         https://bugs.webkit.org/show_bug.cgi?id=196863
1637
1638         Reviewed by Michael Catanzaro.
1639
1640         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1641         (testWebKitSettings): Add test for the enable-media web-setting.
1642
1643 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1644
1645         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1646         https://bugs.webkit.org/show_bug.cgi?id=196905
1647         <rdar://problem/49886096>
1648
1649         Reviewed by Tim Horton.
1650
1651         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1652         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1653         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1654         delay timer, we end up with this sequence of events in the problematic (failure) case:
1655
1656         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1657             ...IPC from UI to web process...
1658         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1659             ...IPC from web to UI process...
1660         (c) [UI]    Invoke completion handler for script #1
1661         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1662             ...IPC from UI to web process...
1663         (e) [Web]   Evaluate script #2 in the web process
1664         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1665
1666         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1667         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1668         #2 is run in step (e).
1669
1670         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1671         the UI process by waiting on a script message posted by the web process, after attachment updates are
1672         dispatched.
1673
1674         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1675         (TestWebKitAPI::TEST):
1676
1677 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1678
1679         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1680         https://bugs.webkit.org/show_bug.cgi?id=196909
1681
1682         Reviewed by Wenson Hsieh.
1683
1684         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1685         (TestWebKitAPI::TEST):
1686
1687 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1688
1689         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1690         https://bugs.webkit.org/show_bug.cgi?id=196880
1691
1692         Reviewed by Yusuke Suzuki.
1693
1694         Add a new function for bytecode cache tests that does not forceDiskCache
1695         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1696         test added in this patch, since the code is invalid and therefore won't be
1697         cached. It should also be useful for tests that evaluate dynamically
1698         generated code.
1699
1700         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1701         * Scripts/run-jsc-stress-tests:
1702
1703 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1704
1705         Update AudioSession route sharing policy
1706         https://bugs.webkit.org/show_bug.cgi?id=196776
1707         <rdar://problem/46501611>
1708
1709         Reviewed by Jer Noble.
1710
1711         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1712         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1713         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1714         (TestWebKitAPI::TEST):
1715
1716 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1717
1718         [iOS] Software keyboard is shown too frequently on some websites
1719         https://bugs.webkit.org/show_bug.cgi?id=195856
1720         <rdar://problem/49191395>
1721
1722         Reviewed by Darin Adler.
1723
1724         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1725
1726         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1727         (WTR::UIScriptController::setHardwareKeyboardAttached):
1728         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1729         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1730         (WTR::UIScriptController::setHardwareKeyboardAttached):
1731         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1732         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1733
1734         Additionally link against GraphicsServices in WebKitTestRunner.
1735
1736         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1737         (WTR::TestController::platformResetStateToConsistentValues):
1738         (WTR::UIScriptController::setHardwareKeyboardAttached):
1739
1740 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1741
1742         [GTK][WPE] Fix pacman install-dependencies packages
1743         https://bugs.webkit.org/show_bug.cgi?id=196817
1744
1745         Reviewed by Žan Doberšek.
1746         
1747         python3-setuptools is called python-setuptools
1748         ruby-highline is only available on AUR
1749         libv4l-devel is incorporated in v4l-utils
1750
1751         * gtk/install-dependencies:
1752         * wpe/install-dependencies:
1753
1754 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1755
1756         [GTK] REGRESSION(r243860): Many tests failing
1757         https://bugs.webkit.org/show_bug.cgi?id=196791
1758
1759         Reviewed by Joanmarie Diggs.
1760
1761         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1762         multiple documents and check that accessibility hierarchy is updated after a navigation.
1763
1764         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1765         (loadChangedCallback):
1766         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1767         (AccessibilityTest::AccessibilityTest):
1768         (AccessibilityTest::~AccessibilityTest):
1769         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1770         (AccessibilityTest::findTestServerApplication):
1771         (AccessibilityTest::findDocumentWeb):
1772         (AccessibilityTest::findRootObject):
1773         (AccessibilityTest::waitUntilChildrenRemoved):
1774         (AccessibilityTest::ensureProxy):
1775         (testAtspiBasicHierarchy):
1776         (beforeAll):
1777         (afterAll):
1778
1779 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1780
1781         [ews-build] Handle bug titles with unicode characters
1782         https://bugs.webkit.org/show_bug.cgi?id=196802
1783
1784         Reviewed by Dewei Zhu.
1785
1786         * BuildSlaveSupport/ews-build/steps.py:
1787         (ValidatePatch._is_bug_closed):
1788
1789 2019-04-11  Michael Saboff  <msaboff@apple.com>
1790
1791         Improve the Inline Cache Stats code
1792         https://bugs.webkit.org/show_bug.cgi?id=196836
1793
1794         Reviewed by Saam Barati.
1795
1796         Added a new script to consolidate and arrange the output of --useICStats option.
1797
1798         This script merges the output from every group into one large table and sorts it from most common to
1799         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1800         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1801         Put together, this is useful to see what property accesses are not getting cached.
1802
1803         * Scripts/ic-stats.py: Added.
1804         (ICStats):
1805         (ICStats.__init__):
1806         (ICStats.parse):
1807         (ICStats.dumpStats):
1808         (usage):
1809
1810 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1811
1812         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1813         https://bugs.webkit.org/show_bug.cgi?id=196809
1814         <rdar://49800762>
1815
1816         Reviewed by Brady Eidson.
1817
1818         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1819         (TEST):
1820
1821 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1822
1823         requestAnimationFrame should execute before the next frame
1824         https://bugs.webkit.org/show_bug.cgi?id=177484
1825
1826         Reviewed by Simon Fraser.
1827
1828         Add trace points for the page RenderingUpdate.
1829
1830         * Tracing/SystemTracePoints.plist:
1831
1832 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1833
1834         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1835         https://bugs.webkit.org/show_bug.cgi?id=196760
1836
1837         Reviewed by Don Olmstead.
1838
1839         vswhere.exe has been bundled since Visual Studio 2017 version
1840         15.2. We shouldn't download vswhere.exe.
1841
1842         * Scripts/build-jsc: Do not call update-vswhere.py.
1843         * Scripts/build-webkit: Ditto.
1844         * Scripts/update-vswhere.py: Removed.
1845         * Scripts/webkitdirs.pm:
1846         (requireModulesForVSWhere): Deleted.
1847         (pickCurrentVisualStudioInstallation): Deleted.
1848         (visualStudioInstallDirVSWhere): Return the latest installed VS
1849         installation path by using the bundled vswhere.exe.
1850         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1851         (visualStudioInstallDirFallback): Removed.
1852
1853 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1854
1855         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1856         https://bugs.webkit.org/show_bug.cgi?id=196780
1857
1858         Reviewed by Alexey Proskuryakov.
1859
1860         * BuildSlaveSupport/ews-build/steps.py:
1861         * BuildSlaveSupport/ews-build/steps_unittest.py:
1862
1863 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1864
1865         Add SPI WKNavigationResponse._downloadAttribute
1866         https://bugs.webkit.org/show_bug.cgi?id=196755
1867         <rdar://49587365>
1868
1869         Reviewed by Brady Eidson.
1870
1871         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1872         (-[NavigationResponseTestDelegate navigationResponse]):
1873         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1874         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1875         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1876         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1877         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1878         (readRequest):
1879         (writeResponse):
1880         (TEST):
1881
1882 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1883
1884         Add modern API for overriding the page's specified viewport configuration
1885         https://bugs.webkit.org/show_bug.cgi?id=167734
1886         <rdar://problem/30331795>
1887
1888         Reviewed by Simon Fraser.
1889
1890         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1891         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1892
1893 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1894
1895         Add support for incremental bytecode cache updates
1896         https://bugs.webkit.org/show_bug.cgi?id=195000
1897
1898         Reviewed by Filip Pizlo.
1899
1900         Exit when the initial run to generate bytecode fails.
1901
1902         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1903
1904 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1905
1906         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1907         https://bugs.webkit.org/show_bug.cgi?id=196744
1908         <rdar://49415309>
1909
1910         Reviewed by Chris Dumez.
1911
1912         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1913         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1914
1915 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1916
1917         Add a way to opt into modern compatibility mode in layout tests
1918         https://bugs.webkit.org/show_bug.cgi?id=196770
1919         <rdar://problem/49777550>
1920
1921         Reviewed by Antoine Quint.
1922
1923         Add a new test option to enable modern compatibility mode in layout tests.
1924
1925         * WebKitTestRunner/TestController.cpp:
1926         (WTR::updateTestOptionsFromTestHeader):
1927         * WebKitTestRunner/TestController.h:
1928         * WebKitTestRunner/TestOptions.h:
1929         (WTR::TestOptions::hasSameInitializationOptions const):
1930         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1931         (WTR::TestController::platformCreateWebView):
1932         (WTR::TestController::enableModernCompatibilityMode):
1933
1934 2019-04-10  Andy Estes  <aestes@apple.com>
1935
1936         Try to fix the 32-bit watchOS build.
1937
1938         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1939         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1940
1941 2019-04-10  Antoine Quint  <graouts@apple.com>
1942
1943         Enable Pointer Events on watchOS
1944         https://bugs.webkit.org/show_bug.cgi?id=196771
1945         <rdar://problem/49040909>
1946
1947         Reviewed by Dean Jackson.
1948
1949         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1950
1951 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1952
1953         Unreviewed. Fix WPE accessibility tests after r244059.
1954
1955         We are failing to load the injected bundle due to undefined symbol
1956         AccessibilityUIElement::replaceTextInRange().
1957
1958         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1959         (WTR::AccessibilityUIElement::replaceTextInRange):
1960
1961 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1962
1963         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1964         https://bugs.webkit.org/show_bug.cgi?id=196727
1965
1966         Reviewed by Fujii Hironori.
1967
1968         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1969         (WebKitBrowserWindow::create):
1970
1971 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1972
1973         [ews-build] Add unit tests for PrintConfiguration
1974         https://bugs.webkit.org/show_bug.cgi?id=196752
1975
1976         Reviewed by Dewei Zhu.
1977
1978         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1979
1980 2019-04-09  Keith Rollin  <krollin@apple.com>
1981
1982         Unreviewed build maintenance -- update .xcfilelists.
1983
1984         * DumpRenderTree/DerivedSources-input.xcfilelist:
1985         * DumpRenderTree/DerivedSources-output.xcfilelist:
1986
1987 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1988
1989         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1990         https://bugs.webkit.org/show_bug.cgi?id=196743
1991         <rdar://problem/43897551>
1992
1993         Reviewed by Tim Horton.
1994
1995         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1996         (TEST):
1997
1998 2019-04-09  Youenn Fablet  <youenn@apple.com>
1999
2000         Close service worker database on network process suspension
2001         https://bugs.webkit.org/show_bug.cgi?id=196623
2002         <rdar://problem/48930869>
2003
2004         Reviewed by Alex Christensen.
2005
2006         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2007
2008 2019-04-09  Daniel Bates  <dabates@apple.com>
2009
2010         [iPad] Should open popover when the spacebar is pressed
2011         https://bugs.webkit.org/show_bug.cgi?id=196360
2012         <rdar://problem/49389129>
2013
2014         Reviewed by Brent Fulgham.
2015
2016         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2017
2018         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2019         (WTR::UIScriptController::isShowingPopover const): Added.
2020         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2021         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2022         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2023         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2024         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2025         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2026         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2027         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2028         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2029         (WTR::UIScriptController::isShowingPopover const): Added.
2030         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2031         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2032         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2033         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2034         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2035         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2036         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2037         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2038         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2039         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2040         (WTR::UIScriptController::isShowingPopover const): Added.
2041         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2042         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2043
2044 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2045
2046         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2047         https://bugs.webkit.org/show_bug.cgi?id=196665
2048         <rdar://45115669>
2049
2050         Reviewed by Geoff Garen.
2051
2052         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2053         (goBack):
2054         (+[SimpleLookupContext sharedLookupContext]):
2055         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2056         (TEST):
2057         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2058         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2059
2060 2019-04-09  John Wilander  <wilander@apple.com>
2061
2062         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2063         https://bugs.webkit.org/show_bug.cgi?id=196558
2064         <rdar://problem/47650245>
2065
2066         Reviewed by Youenn Fablet.
2067
2068         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2069         (TestWebKitAPI::TEST):
2070             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2071
2072 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2073
2074         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2075         https://bugs.webkit.org/show_bug.cgi?id=196720
2076
2077         Reviewed by Konstantin Tokarev.
2078
2079         * TestWebKitAPI/PlatformMac.cmake:
2080
2081 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2082
2083         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2084         https://bugs.webkit.org/show_bug.cgi?id=196694
2085         <rdar://problem/48388734>
2086
2087         Rubber-stamped by Aakash Jain.
2088
2089         * Scripts/webkitpy/port/image_diff.py:
2090         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2091         * Scripts/webkitpy/port/server_process.py:
2092         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2093         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2094         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2095         * Scripts/webkitpy/port/server_process_mock.py:
2096         (MockServerProcess.has_available_stdout):
2097         * Scripts/webkitpy/port/server_process_unittest.py:
2098         (TestServerProcess.serial_test_basic):
2099
2100 2019-04-09  Jer Noble  <jer.noble@apple.com>
2101
2102         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2103         https://bugs.webkit.org/show_bug.cgi?id=196097
2104
2105         Reviewed by Eric Carlson.
2106
2107         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2108
2109         * DumpRenderTree/mac/DumpRenderTree.mm:
2110         (resetWebPreferencesToConsistentValues):
2111         * WebKitTestRunner/TestController.cpp:
2112         (WTR::TestController::resetPreferencesToConsistentValues):
2113
2114 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2115
2116         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2117         https://bugs.webkit.org/show_bug.cgi?id=196690
2118
2119         Reviewed by Michael Catanzaro.
2120
2121         * QueueStatusServer/config/queues.py:
2122         * Scripts/webkitpy/common/config/ews.json:
2123         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2124         (test_ews_name):
2125
2126 2019-04-09  Chris Dumez  <cdumez@apple.com>
2127
2128         Loads using loadHTMLString() cause flashing when process-swapping
2129         https://bugs.webkit.org/show_bug.cgi?id=196714
2130         <rdar://problem/49637354>
2131
2132         Reviewed by Antti Koivisto.
2133
2134         Add API test coverage.
2135
2136         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2137
2138 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2139
2140         Unreviewed. Fix ATK accessibility tests after r244059.
2141
2142         We are failing to load the injected bundle due to undefined symbol
2143         AccessibilityUIElement::replaceTextInRange().
2144
2145         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2146         (WTR::AccessibilityUIElement::replaceTextInRange):
2147
2148 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2149
2150         AX: Support API: accessibilityReplaceRange:withText
2151         https://bugs.webkit.org/show_bug.cgi?id=196636
2152
2153         Unreviewed build fix for Windows port.
2154
2155         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2156         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2157
2158 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2159
2160         [CMake][WinCairo] Separate copied headers into different directories
2161         https://bugs.webkit.org/show_bug.cgi?id=196655
2162
2163         Reviewed by Michael Catanzaro.
2164
2165         * DumpRenderTree/CMakeLists.txt:
2166         * MiniBrowser/win/CMakeLists.txt:
2167         * TestWebKitAPI/CMakeLists.txt:
2168         * TestWebKitAPI/PlatformWin.cmake:
2169
2170 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2171
2172         Log stack-trace for run-webkit-tests when interrupted
2173         https://bugs.webkit.org/show_bug.cgi?id=176393
2174         <rdar://problem/34262310>
2175
2176         Reviewed by Lucas Forschler.
2177
2178         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2179         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2180         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2181         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2182         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2183         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2184         (main): Set handlers to log stack trace on interruption.
2185
2186 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2187
2188         AX: Support API: accessibilityReplaceRange:withText
2189         https://bugs.webkit.org/show_bug.cgi?id=196636
2190
2191         Unreviewed build fix for Windows port.
2192
2193         * DumpRenderTree/AccessibilityUIElement.cpp:
2194         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2195
2196 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2197
2198         [ews-build] Scripts using Buildbot API have CORS error
2199         https://bugs.webkit.org/show_bug.cgi?id=196709
2200
2201         Reviewed by Alexey Proskuryakov.
2202
2203         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2204
2205 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2206
2207         AX: Support API: accessibilityReplaceRange:withText
2208         https://bugs.webkit.org/show_bug.cgi?id=196636
2209
2210         Reviewed by Daniel Bates.
2211
2212         * DumpRenderTree/AccessibilityUIElement.cpp:
2213         (replaceTextInRangeCallback):
2214         (AccessibilityUIElement::replaceTextInRange):
2215         (AccessibilityUIElement::getJSClass):
2216         * DumpRenderTree/AccessibilityUIElement.h:
2217         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2218         (AccessibilityUIElement::replaceTextInRange):
2219         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2220         (AccessibilityUIElement::replaceTextInRange):
2221         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2222         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2223         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2224         (WTR::AccessibilityUIElement::replaceTextInRange):
2225         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2226         (WTR::AccessibilityUIElement::replaceTextInRange):
2227
2228 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2229
2230         [iOS] Do not allow starting selection drags when selection views are not visible
2231         https://bugs.webkit.org/show_bug.cgi?id=196686
2232         <rdar://problem/49399192>
2233
2234         Reviewed by Tim Horton.
2235
2236         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2237         also add some new API tests to cover scenarios where the web view is not first responder.
2238
2239         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2240         (TestWebKitAPI::TEST):
2241         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2242
2243         Add a switch to optionally make the web view first responder when starting the simulated drag.
2244
2245         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2246         (-[DragAndDropSimulator initWithWebView:]):
2247         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2248
2249 2019-04-08  Justin Fan  <justin_fan@apple.com>
2250
2251         [Web GPU] Fix Web GPU experimental feature on iOS
2252         https://bugs.webkit.org/show_bug.cgi?id=196632
2253
2254         Reviewed by Myles C. Maxfield.
2255
2256         Properly make Web GPU available on iOS 11+.
2257
2258         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2259
2260 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2261
2262         [ews-build] Do not upload archive when Compile Fails
2263         https://bugs.webkit.org/show_bug.cgi?id=196674
2264
2265         Reviewed by Alexey Proskuryakov.
2266
2267         * BuildSlaveSupport/ews-build/factories.py:
2268         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2269         * BuildSlaveSupport/ews-build/steps.py:
2270         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2271         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2272         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2273
2274 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2275
2276         Enable DFG on MIPS
2277         https://bugs.webkit.org/show_bug.cgi?id=196689
2278
2279         Reviewed by Žan Doberšek.
2280
2281         Since the bytecode change, we enabled the baseline JIT on mips in
2282         r240432, but DFG is still missing. With this change, all tests are
2283         passing on a ci20 board.
2284
2285         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2286
2287 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2288
2289         [Flatpak] Second run update-webkitwpe-flatpak fails
2290         https://bugs.webkit.org/show_bug.cgi?id=192702
2291
2292         Reviewed by Carlos Garcia Campos.
2293
2294         * flatpak/flatpakutils.py:
2295         (FlatpakObject.flatpak): Fix typo.
2296         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2297         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2298
2299 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2300
2301         [GTK][WPE] outlook.live.com displays old-fashioned UI
2302         https://bugs.webkit.org/show_bug.cgi?id=196642
2303
2304         Reviewed by Carlos Garcia Campos.
2305
2306         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2307         (TestWebKitAPI::TEST): New Mac platform quirk test.
2308
2309 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2310
2311         Unreviewed, rolling out r243956.
2312         https://bugs.webkit.org/show_bug.cgi?id=196688
2313
2314         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2315         by aakashjain on #webkit).
2316
2317         Reverted changeset:
2318
2319         "Clicking "Go Back" from a safe browsing warning from an
2320         iframe should navigate the WKWebView back to the previous
2321         page"
2322         https://bugs.webkit.org/show_bug.cgi?id=196665
2323         https://trac.webkit.org/changeset/243956
2324
2325 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2326
2327         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2328         https://bugs.webkit.org/show_bug.cgi?id=196669
2329
2330         Reviewed by Geoffrey Garen.
2331
2332         Added three new unit tests for WeakHashSet.
2333
2334         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2335         (WTF_WeakPtr.WeakHashSetConstObjects):
2336         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2337         (WTF_WeakPtr.WeakHashSetComputeSize):
2338
2339 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2340
2341         Hide next and previous form control buttons when WKWebView is editable
2342         https://bugs.webkit.org/show_bug.cgi?id=196672
2343         <rdar://problem/35625321>
2344
2345         Reviewed by Tim Horton.
2346
2347         Add a new API test.
2348
2349         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2350         (-[TestWKWebView lastTrailingBarButtonGroup]):
2351         (TestWebKitAPI::TEST):
2352         * TestWebKitAPI/ios/UIKitSPI.h:
2353
2354 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2355
2356         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2357         https://bugs.webkit.org/show_bug.cgi?id=196077
2358         <rdar://problem/49108202>
2359
2360         Reviewed by Chris Dumez.
2361
2362         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2363         on new web view.
2364
2365         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2366
2367 2019-04-05  Saam Barati  <sbarati@apple.com>
2368
2369         Make compare-results understand MotionMark
2370         https://bugs.webkit.org/show_bug.cgi?id=196666
2371
2372         Reviewed by Yusuke Suzuki.
2373
2374         * Scripts/compare-results:
2375         (PLT5Results):
2376         (detectMotionMark):
2377         (detectMotionMark1_1):
2378         (motionMarkResults):
2379         (motionMark1_1Results):
2380         (detectBenchmark):
2381         (biggerIsBetter):
2382         (main):
2383
2384 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2385
2386         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2387         https://bugs.webkit.org/show_bug.cgi?id=196665
2388         <rdar://45115669>
2389
2390         Reviewed by Geoff Garen.
2391
2392         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2393         (goBack):
2394         (+[SimpleLookupContext sharedLookupContext]):
2395         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2396         (TEST):
2397         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2398         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2399
2400 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2401
2402         [ews-build] Add configuration and architecture for windows builders
2403         https://bugs.webkit.org/show_bug.cgi?id=196660
2404
2405         Reviewed by Lucas Forschler.
2406
2407         * BuildSlaveSupport/ews-build/config.json:
2408
2409 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2410
2411         webkitpy: Don't run subsequent rounds if interrupted
2412         https://bugs.webkit.org/show_bug.cgi?id=196646
2413
2414         Reviewed by Aakash Jain.
2415
2416         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2417         (Manager.run): Bail out if interrupted.
2418
2419 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2420
2421         Test sessionStorage in PSON private browsing mode
2422         https://bugs.webkit.org/show_bug.cgi?id=196561
2423
2424         Reviewed by Alex Christensen.
2425
2426         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2427
2428 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2429
2430         Unreviewed, rolling out r243833.
2431         https://bugs.webkit.org/show_bug.cgi?id=196645
2432
2433         This change breaks build of WPE and GTK ports (Requested by
2434         annulen on #webkit).
2435
2436         Reverted changeset:
2437
2438         "[CMake][WTF] Mirror XCode header directories"
2439         https://bugs.webkit.org/show_bug.cgi?id=191662
2440         https://trac.webkit.org/changeset/243833
2441
2442 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2443
2444         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2445         https://bugs.webkit.org/show_bug.cgi?id=196635
2446
2447         Reviewed by Antti Koivisto.
2448         
2449         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
2450         for a test to enable async frame scrolling via:
2451             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
2452         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
2453         
2454         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
2455
2456         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2457         (WTR::InjectedBundle::beginTesting):
2458         * WebKitTestRunner/TestController.cpp:
2459         (WTR::TestController::resetPreferencesToConsistentValues):
2460
2461 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2462
2463         Use a correct LC_RPATH when building with ASan
2464         https://bugs.webkit.org/show_bug.cgi?id=196576
2465
2466         Reviewed by David Kilzer.
2467
2468         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2469         so that ../Frameworks is checked. This is simpler and more reliable than updating
2470         each SPC service xcconfig.
2471
2472 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2473
2474         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2475         https://bugs.webkit.org/show_bug.cgi?id=196629
2476
2477         Reviewed by Lucas Forschler.
2478
2479         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2480
2481 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2482
2483         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2484         https://bugs.webkit.org/show_bug.cgi?id=196618
2485
2486         Reviewed by Lucas Forschler.
2487
2488         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2489         (StatusBubble): Added QUEUE_TRIGGERS.
2490         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2491         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2492         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2493         its parent(builder).
2494
2495 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2496
2497         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2498         https://bugs.webkit.org/show_bug.cgi?id=196625
2499
2500         Reviewed by Lucas Forschler.
2501
2502         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2503         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2504
2505 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2506
2507         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2508         https://bugs.webkit.org/show_bug.cgi?id=196630
2509
2510         Reviewed by Wenson Hsieh.
2511
2512         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2513
2514 2019-04-04  Youenn Fablet  <youenn@apple.com>
2515
2516         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2517         https://bugs.webkit.org/show_bug.cgi?id=196543
2518
2519         Reviewed by Alex Christensen.
2520
2521         * WebKitTestRunner/TestController.cpp:
2522         (WTR::TestController::generatePageConfiguration):
2523
2524 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2525
2526         [ews-app] Status bubble should not display skipped buildbot steps
2527         https://bugs.webkit.org/show_bug.cgi?id=196584
2528
2529         Reviewed by Lucas Forschler.
2530
2531         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2532
2533 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2534
2535         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2536         https://bugs.webkit.org/show_bug.cgi?id=196620
2537
2538         Reviewed by Lucas Forschler.
2539
2540         * BuildSlaveSupport/ews-app/ews/config.py:
2541
2542 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2543
2544         [Win] DumpRenderTreeWatchDog.py is not checked into source
2545         https://bugs.webkit.org/show_bug.cgi?id=196567
2546         <rdar://problem/49525901>
2547
2548         Reviewed by Lucas Forschler.
2549
2550         This script is used on Win EWS bots to terminate hanging DRT processes.
2551
2552         * EWSTools/dumprendertreewatchdog.py: Added.
2553
2554 2019-04-04  Chris Dumez  <cdumez@apple.com>
2555
2556         Unreviewed, roll out r243858 which made tests time out.
2557
2558         Disable new API tests on Windows instead.
2559
2560         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2561         (TestWebKitAPI::TEST):
2562
2563 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2564
2565         [ATK] Cleanup WebPageAccessibilityObjectAtk
2566         https://bugs.webkit.org/show_bug.cgi?id=196537
2567
2568         Reviewed by Michael Catanzaro.
2569
2570         Also consider files under atk directories as exceptions for GObject conventions.
2571
2572         * Scripts/webkitpy/style/checkers/cpp.py:
2573         (check_identifier_name_in_declaration):
2574
2575 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2576
2577         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2578         https://bugs.webkit.org/show_bug.cgi?id=196588
2579         <rdar://problem/49365787>
2580
2581         Unreviewed build fix for Windows port.
2582
2583         error C3861: 'kill': identifier not found
2584
2585         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2586         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2587
2588 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2589
2590         [ews-build] Cancel build and similar operations should have authentication
2591         https://bugs.webkit.org/show_bug.cgi?id=196520
2592
2593         Reviewed by Dewei Zhu.
2594
2595         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2596         environment variables.
2597
2598 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2599
2600         [ews-build] Do not trigger queues which are not in production yet
2601         https://bugs.webkit.org/show_bug.cgi?id=196581
2602
2603         Reviewed by Dewei Zhu.
2604
2605         * BuildSlaveSupport/ews-build/config.json:
2606
2607 2019-04-03  Chris Dumez  <cdumez@apple.com>
2608
2609         Unreviewed, fix typo in the name of API test added in r243848.
2610
2611         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2612         (TestWebKitAPI::TEST):
2613
2614 2019-04-03  Chris Dumez  <cdumez@apple.com>
2615
2616         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2617         https://bugs.webkit.org/show_bug.cgi?id=196588
2618         <rdar://problem/49365787>
2619
2620         Reviewed by Ryosuke Niwa.
2621
2622         Add API test coverage.
2623
2624         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2625         (TestWebKitAPI::nullJavaScriptCallback):
2626         (TestWebKitAPI::didCrashCheckFrames):
2627         (TestWebKitAPI::TEST):
2628
2629 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2630
2631         run-webkit-tests: Upload test results (new results database)
2632         https://bugs.webkit.org/show_bug.cgi?id=196577
2633         <rdar://problem/34841155>
2634
2635         Reviewed by Lucas Forschler.
2636
2637         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2638         (Manager.run): Upload results after each device shard, since the configuration will be
2639         different for each device.
2640         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2641         uploaded to a results database.
2642         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2643         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2644
2645 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2646
2647         -apple-trailing-word is needed for browser detection
2648         https://bugs.webkit.org/show_bug.cgi?id=196575
2649
2650         Unreviewed.
2651
2652         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2653
2654 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2655
2656         [CMake][WTF] Mirror XCode header directories
2657         https://bugs.webkit.org/show_bug.cgi?id=191662
2658
2659         Reviewed by Konstantin Tokarev.
2660
2661         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2662         builds.
2663
2664         * CMakeLists.txt:
2665         * DumpRenderTree/CMakeLists.txt:
2666         * DumpRenderTree/PlatformWin.cmake:
2667         * MiniBrowser/win/CMakeLists.txt:
2668         * TestWebKitAPI/CMakeLists.txt:
2669         * TestWebKitAPI/PlatformWin.cmake:
2670         * WebKitTestRunner/PlatformGTK.cmake:
2671         * WebKitTestRunner/PlatformWin.cmake:
2672
2673 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2674
2675         [ews-app] Status bubble should not display certain infrastructure status messages
2676         https://bugs.webkit.org/show_bug.cgi?id=196550
2677
2678         Reviewed by Lucas Forschler.
2679
2680         Do not display the steps which are un-needed for end-user. This information is still avaiable
2681         if the user click on the bubble and look at the Buildbot build.
2682         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2683         (StatusBubble._steps_messages):
2684         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2685
2686 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2687
2688         [ews-build] Use https for sending data to ews-app
2689         https://bugs.webkit.org/show_bug.cgi?id=196492
2690
2691         Reviewed by Lucas Forschler.
2692
2693         * BuildSlaveSupport/ews-build/events.py:
2694
2695 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2696
2697         Remove support for -apple-trailing-word
2698         https://bugs.webkit.org/show_bug.cgi?id=196525
2699
2700         Reviewed by Zalan Bujtas.
2701
2702         This CSS property is nonstandard and not used.
2703
2704         * Scripts/webkitperl/FeatureList.pm:
2705         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2706
2707 2019-04-03  Youenn Fablet  <youenn@apple.com>
2708
2709         Add a test for DOMCache on multiple browsing in case of private browsing
2710         https://bugs.webkit.org/show_bug.cgi?id=196524
2711
2712         Reviewed by Alex Christensen.
2713
2714         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2715         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2716
2717 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2718
2719         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2720         https://bugs.webkit.org/show_bug.cgi?id=196540
2721
2722         Reviewed by Aakash Jain.
2723
2724         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2725
2726 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2727
2728         Add plumbing for a compatibility mode preference in WebKit
2729         https://bugs.webkit.org/show_bug.cgi?id=196005
2730
2731         Reviewed by Tim Horton.
2732
2733         Add new API tests.
2734
2735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2736         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2737
2738 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2739
2740         [WPE][GTK] Update libsrtp dependency package for Debian
2741         https://bugs.webkit.org/show_bug.cgi?id=196528
2742
2743         Reviewed by Frédéric Wang.
2744
2745         * gtk/install-dependencies:
2746         * wpe/install-dependencies:
2747
2748 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2749
2750         [WK2] Add support for Window's beforeprint / afterprint events
2751         https://bugs.webkit.org/show_bug.cgi?id=196478
2752         <rdar://problem/49535124>
2753
2754         Unreviewed build fix for MSVC.
2755
2756         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2757
2758         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2759
2760         * WebKitTestRunner/TestController.cpp:
2761         (WTR::printFrame): Use int and float literals.
2762
2763 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2764
2765         [ews-build] Reassign bots to queues
2766
2767         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2768
2769 2019-04-02  Chris Dumez  <cdumez@apple.com>
2770
2771         [WK2] Add support for Window's beforeprint / afterprint events
2772         https://bugs.webkit.org/show_bug.cgi?id=196478
2773
2774         Reviewed by Alex Christensen.
2775
2776         Add minimal implementation for printFrame in WebKitTestRunner.
2777
2778         * WebKitTestRunner/TestController.cpp:
2779         (WTR::printFrame):
2780         (WTR::TestController::createOtherPage):
2781         (WTR::TestController::createWebViewWithOptions):
2782
2783 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2784
2785         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2786         https://bugs.webkit.org/show_bug.cgi?id=196491
2787
2788         Reviewed by Lucas Forschler.
2789
2790         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2791
2792 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2793
2794         [ews-build] Configure buildbot try credentials in environment variables
2795         https://bugs.webkit.org/show_bug.cgi?id=196501
2796
2797         Reviewed by Lucas Forschler.
2798
2799         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2800         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2801         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2802
2803 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2804
2805         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2806         https://bugs.webkit.org/show_bug.cgi?id=196496
2807         <rdar://problem/49521634>
2808
2809         Reviewed by Chris Dumez.
2810
2811         Add new API tests (see WebKit ChangeLog for more detail).
2812
2813         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2814         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2815         (TEST):
2816
2817 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2818
2819         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2820         <https://webkit.org/b/196499>
2821
2822         Reviewed by Alexey Proskuryakov.
2823
2824         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2825         ENABLE_ADDRESS_SANITIZER.
2826
2827 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2828
2829         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2830         https://bugs.webkit.org/show_bug.cgi?id=182757
2831
2832         Reviewed by Don Olmstead.
2833
2834         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2835         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2836
2837 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2838
2839         run-api-tests: Upload test results
2840         https://bugs.webkit.org/show_bug.cgi?id=196323
2841         <rdar://problem/49356714>
2842
2843         Reviewed by Lucas Forschler.
2844
2845         * Scripts/webkitpy/api_tests/manager.py:
2846         (Manager):
2847         (Manager.run): Upload results to a results database.
2848         * Scripts/webkitpy/api_tests/run_api_tests.py:
2849         (parse_args): Add upload arguments.
2850         * Scripts/webkitpy/port/base.py:
2851         (Port):
2852         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2853         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2854         with commits from any other associated repositories.
2855         * Scripts/webkitpy/port/device.py:
2856         (Device):
2857         (Device.build_version): Access build_versoin of underlying platform device.
2858         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2859         (IOSSimulatorTest):
2860         (IOSSimulatorTest.test_configuration_for_upload):
2861         * Scripts/webkitpy/port/device_port.py:
2862         (DevicePort):
2863         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2864         the same as the machine uploading results.
2865         * Scripts/webkitpy/port/mac.py:
2866         (MacPort):
2867         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2868         * Scripts/webkitpy/port/mac_unittest.py:
2869         (MacTest):
2870         (MacTest.test_configuration_for_upload):
2871         * Scripts/webkitpy/xcode/simulated_device.py:
2872         (SimulatedDeviceManager._create_device_with_runtime):
2873         (SimulatedDevice.__init__): Create simulated device with a build_version.
2874         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2875         (test_existing_simulator):
2876
2877 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2878
2879         Remove extra newline characters (Follow-up fix to r243707)
2880
2881         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2882
2883 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2884
2885         [ews-app] Use API_KEY to accept results data
2886         https://bugs.webkit.org/show_bug.cgi?id=196461
2887
2888         Reviewed by Dewei Zhu.
2889
2890         * BuildSlaveSupport/ews-app/ews/views/results.py:
2891         (Results.post): Validate EWS_API_KEY before accepting any data.
2892         * BuildSlaveSupport/ews-build/events.py:
2893         (Events.sendData): Send EWS_API_KEY if available along with event data.
2894
2895 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2896
2897         Unable to copy and paste a PDF from Notes into Mail compose body
2898         https://bugs.webkit.org/show_bug.cgi?id=196442
2899         <rdar://problem/48573098>
2900
2901         Reviewed by Tim Horton.
2902
2903         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2904         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2905         to be specified on the item providers.
2906
2907         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2908         (TestWebKitAPI::mapItemForTesting):
2909         (TestWebKitAPI::contactItemForTesting):
2910
2911 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2912
2913         Make UIWKDocumentContext rects per-character instead of per-word
2914         https://bugs.webkit.org/show_bug.cgi?id=196459
2915
2916         Reviewed by Wenson Hsieh.
2917
2918         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2919         (TEST):
2920         Adjust test results due to switching to per-character rects.
2921
2922 2019-04-01  Chris Dumez  <cdumez@apple.com>
2923
2924         UIProcess crash when a prewarmed process is terminated
2925         https://bugs.webkit.org/show_bug.cgi?id=196451
2926         <rdar://problem/49245471>
2927
2928         Reviewed by Geoffrey Garen.
2929
2930         Add API test coverage.
2931
2932         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2933         (TEST):
2934
2935 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2936
2937         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2938         https://bugs.webkit.org/show_bug.cgi?id=196449
2939
2940         Reviewed by Lucas Forschler.
2941
2942         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2943         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2944         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2945         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2946
2947 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2948
2949         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2950         https://bugs.webkit.org/show_bug.cgi?id=196444
2951
2952         Reviewed by Lucas Forschler.
2953
2954         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2955
2956 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2957
2958         Add SPI to canonicalize NSURLs with WTF::URL
2959         https://bugs.webkit.org/show_bug.cgi?id=196415
2960         <rdar://problem/44980271>
2961
2962         Reviewed by Darin Adler.
2963
2964         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2965         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2966         (TestWebKitAPI::TEST):
2967
2968 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2969
2970         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2971         https://bugs.webkit.org/show_bug.cgi?id=196441
2972
2973         Reviewed by Carlos Garcia Campos.
2974
2975         Don't cache the wpe_view_backend object that might not exist yet at the
2976         time of EventSenderProxy constructor invocation, but instead retrieve
2977         that object whenever it's required for event dispatching. This should
2978         avoid crashes in this constructor now that it's invoked before any
2979         PlatformWindow has been set up (as changed in r243496).
2980
2981         * WebKitTestRunner/EventSenderProxy.h:
2982         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2983         (WTR::viewBackend):
2984         (WTR::EventSenderProxy::EventSenderProxy):
2985         (WTR::EventSenderProxy::mouseDown):
2986         (WTR::EventSenderProxy::mouseUp):
2987         (WTR::EventSenderProxy::mouseMoveTo):
2988         (WTR::EventSenderProxy::mouseScrollBy):
2989         (WTR::EventSenderProxy::keyDown):
2990         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2991
2992 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2993
2994         [Win][WebKit] MiniBrowser should support high DPI display
2995         https://bugs.webkit.org/show_bug.cgi?id=196391
2996
2997         Reviewed by Alex Christensen.
2998
2999         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3000         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3001         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3002         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3003
3004 2019-03-31  Sam Weinig  <weinig@apple.com>
3005
3006         Remove more i386 specific configurations
3007         https://bugs.webkit.org/show_bug.cgi?id=196430
3008
3009         Reviewed by Alexey Proskuryakov.
3010
3011         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3012         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3013
3014 2019-03-31  Andy Estes  <aestes@apple.com>
3015
3016         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3017         https://bugs.webkit.org/show_bug.cgi?id=196433
3018         <rdar://problem/49293305>
3019
3020         Reviewed by Tim Horton.
3021
3022         Enhanced API test coverage to include all navigation response policy decisions in both
3023         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3024
3025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3026         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3027         (TestWebKitAPI::TEST):
3028         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3029         (readFile):
3030         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3031         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3032         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3033         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3034         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3035         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3036         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3037         (-[QuickLookDelegate _downloadDidStart:]):
3038         (-[QuickLookDelegate _download:didReceiveResponse:]):
3039         (-[QuickLookDelegate _download:didReceiveData:]):
3040         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3041         (-[QuickLookDelegate _downloadDidFinish:]):
3042         (-[QuickLookDelegate _download:didFailWithError:]):
3043         (-[QuickLookDelegate _downloadDidCancel:]):
3044         (-[QuickLookDelegate verifyDownload]):
3045         (runTest):
3046         (runTestDecideBeforeLoading):
3047         (runTestDecideAfterLoading):
3048         (TEST):
3049         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3050         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3051         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3052         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3053         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3054         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3055         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3056         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3057         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3058         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3059         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3060         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3061         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3062         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3063
3064 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3065
3066         [CMake] add testdfg as target with build-jsc
3067         https://bugs.webkit.org/show_bug.cgi?id=196393
3068
3069         Reviewed by Saam Barati.
3070
3071         Added testdfg as one of the targets to build when
3072         using CMake.
3073
3074         * Scripts/build-jsc:
3075
3076 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3077
3078         Delete WebMetal implementation in favor of WebGPU
3079         https://bugs.webkit.org/show_bug.cgi?id=195418
3080
3081         Reviewed by Dean Jackson.
3082
3083         * DumpRenderTree/mac/DumpRenderTree.mm:
3084         (enableExperimentalFeatures):
3085         (resetWebPreferencesToConsistentValues):
3086         * Scripts/webkitperl/FeatureList.pm:
3087         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3089         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3090         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3091         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3092         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3093         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3094         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3095         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3096         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3097         (WTR::InjectedBundle::beginTesting):
3098         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3099         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3100         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3101
3102 2019-03-29  Chris Dumez  <cdumez@apple.com>
3103
3104         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3105         https://bugs.webkit.org/show_bug.cgi?id=196405
3106         <rdar://problem/49428130>
3107
3108         Reviewed by Wenson Hsieh.
3109
3110         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3111         the popover presentation methods to be no-ops. Use this in the new test added in
3112         r243523 so that we do not swizzle those methods for all tests. This is needed because
3113         those WatchOS tests rely on the popover getting presented and interactive.
3114
3115         * WebKitTestRunner/TestController.cpp:
3116         (WTR::updateTestOptionsFromTestHeader):
3117         * WebKitTestRunner/TestController.h:
3118         * WebKitTestRunner/TestOptions.h:
3119         (WTR::TestOptions::hasSameInitializationOptions const):
3120         * WebKitTestRunner/ios/TestControllerIOS.mm:
3121         (WTR::TestController::platformInitialize):
3122         (WTR::TestController::platformResetStateToConsistentValues):
3123
3124 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3125
3126         [Curl] Add Server Trust Evaluation Support.
3127         https://bugs.webkit.org/show_bug.cgi?id=191646
3128
3129         Reviewed by Fujii Hironori.
3130
3131         Implemented MiniBrowser UI for asking if user trusts the server.
3132
3133         * MiniBrowser/win/Common.cpp:
3134         (askServerTrustEvaluation):
3135         (replaceString):
3136         * MiniBrowser/win/Common.h:
3137         * MiniBrowser/win/MiniBrowserLib.rc:
3138         * MiniBrowser/win/MiniBrowserLibResource.h:
3139         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3140         (createPEMString):
3141         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3142         (WebKitBrowserWindow::canTrustServerCertificate):
3143         * MiniBrowser/win/WebKitBrowserWindow.h:
3144
3145 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3146
3147         Implement ResizeObserver.
3148         https://bugs.webkit.org/show_bug.cgi?id=157743
3149
3150         Reviewed by Simon Fraser.
3151
3152         Support resizeObserverEnabled webPreferences.
3153
3154         * DumpRenderTree/TestOptions.cpp:
3155         (TestOptions::TestOptions):
3156         * DumpRenderTree/TestOptions.h:
3157         * DumpRenderTree/mac/DumpRenderTree.mm:
3158         (setWebPreferencesForTestOptions):
3159         * DumpRenderTree/win/DumpRenderTree.cpp:
3160         (enableExperimentalFeatures):
3161         * Scripts/webkitperl/FeatureList.pm:
3162         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3163
3164 2019-03-28  John Wilander  <wilander@apple.com>
3165
3166         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3167         https://bugs.webkit.org/show_bug.cgi?id=196281
3168         <rdar://problem/48938748>
3169
3170         Reviewed by Alex Christensen.
3171
3172         This patch adds the function isStatisticsHasLocalStorage() to the
3173         TestRunner. With it, the page can query the WebsiteDataStore in the
3174         UI process to make sure that it sees LocalStorage.
3175
3176         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3178         (WTR::TestRunner::isStatisticsHasLocalStorage):
3179         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3180         * WebKitTestRunner/TestController.cpp:
3181         (WTR::TestController::isStatisticsHasLocalStorage):
3182         * WebKitTestRunner/TestController.h:
3183         * WebKitTestRunner/TestInvocation.cpp:
3184         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3185
3186 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3187
3188         API::Data::createWithoutCopying should do a null check before calling CFRelease
3189         https://bugs.webkit.org/show_bug.cgi?id=196276
3190         <rdar://problem/48059859>
3191
3192         Reviewed by Alex Christensen.
3193
3194         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3195
3196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3197         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3198         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3199         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3200         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3201         (TestWebKitAPI::TEST):
3202
3203 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3204
3205         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3206         https://bugs.webkit.org/show_bug.cgi?id=186276
3207
3208         Reviewed by Carlos Garcia Campos.
3209
3210         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3211         (webViewLoadChanged):
3212         (testWebResourceGetDataError):
3213         (testWebResourceGetDataEmpty):
3214         (beforeAll):
3215         (webViewloadChanged): Deleted.
3216
3217 2019-03-27  Andy Estes  <aestes@apple.com>
3218
3219         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3220         https://bugs.webkit.org/show_bug.cgi?id=196317
3221
3222         Reviewed by Dan Bernstein.
3223
3224         package-root copies built products into a staging directory using ditto(1), which does not
3225         follow symbolic links as it traverses a directory. Now that the files in
3226         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3227         itself, these become broken links when ditto'd into the staging directory.
3228
3229         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3230
3231         * Scripts/package-root:
3232
3233 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3234
3235         [ews-app] Update display text of Submit for ews analysis
3236         https://bugs.webkit.org/show_bug.cgi?id=196309
3237
3238         Reviewed by Dewei Zhu.
3239
3240         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3241
3242 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3243
3244         run-webkit-tests should check for leaks in WebKit processes
3245         <https://webkit.org/b/193772>
3246         <rdar://problem/46526680>
3247
3248         Reviewed by Ryosuke Niwa.
3249
3250         This works by doing the following:
3251         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3252           The list of child processes are returned one per line:
3253           process.name: pid
3254         - Run the "#LIST CHILD PROCESSES" command just before the
3255           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3256           processes on the ServerProcess object.
3257         - When the `--leaks` switch is handled, run check_for_leaks() on
3258           each child process after the main test harness.
3259
3260         * DumpRenderTree/mac/DumpRenderTree.mm:
3261         (handleControlCommand):
3262         - Use strncmp() instead of strcmp().
3263         - Add support for handling "#LIST CHILD PROCESSES" command.
3264
3265         * Scripts/webkitpy/port/base.py:
3266         (Port.check_for_leaks):
3267         * Scripts/webkitpy/port/darwin.py:
3268         (DarwinPort.check_for_leaks):
3269         - Rename redundant 'process_pid' argument to 'process_id'.
3270
3271         * Scripts/webkitpy/port/driver.py:
3272         (Driver.do_post_tests_work):
3273         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3274           longer the only command this sends to WebKitTestRunner.
3275         - If the `--leaks` switch is present, send the
3276           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3277           result using Port.set_webkit_processes().
3278         (Driver._parse_child_processes_output):
3279         - Add helper method to parse list of child process names and
3280           process IDs returned from WebKitTestRunner.
3281
3282         * Scripts/webkitpy/port/ios_device.py:
3283         (IOSDevicePort.check_for_leaks):
3284         - Rename redundant 'process_pid' argument to 'process_id'.
3285
3286         * Scripts/webkitpy/port/leakdetector.py:
3287         (LeakDetector._parse_leaks_output):
3288         - Return early if there is no leaks_output.
3289         (LeakDetector.check_for_leaks):
3290         - Rename redundant 'process_pid' argument to 'process_id'.
3291
3292         * Scripts/webkitpy/port/server_process.py:
3293         (ServerProcess.__init__):
3294         (ServerProcess.child_processes):
3295         (ServerProcess.set_child_processes):
3296         - Add instance variable to Port to store list of child process
3297           names and process IDs returned from WebKitTestRunner.
3298         (ServerProcess._start):
3299         - Clear self._child_processes.
3300         (ServerProcess.stop):
3301         - If self._child_processes is set, call
3302           self._port.check_for_leaks() for each child process.
3303
3304         * Scripts/webkitpy/port/server_process_unittest.py:
3305         (TrivialMockPort.check_for_leaks):
3306         - Rename redundant 'process_pid' argument to 'process_id'.
3307
3308         * Scripts/webkitpy/port/simulator_process.py:
3309         (SimulatorProcess.stop):
3310         - If self._child_processes is set, call
3311           self._port.check_for_leaks() for each child process.
3312
3313         * Scripts/webkitpy/port/watch_device.py:
3314         (WatchDevicePort.check_for_leaks):
3315         - Rename redundant 'process_pid' argument to 'process_id'.
3316
3317         * WebKitTestRunner/TestController.cpp:
3318         (WTR::TestController::dumpResponse):
3319         - Extract method from findAndDumpWorldLeaks() so that it may be
3320           reused by findAndDumpWebKitProcessIdentifiers().
3321         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3322         - Add method to output process name and process ID of both the
3323           WebContent and Networking processes.
3324         (WTR::TestController::findAndDumpWorldLeaks):
3325         - Fix missing newline in output when there were no abandoned
3326           documents.
3327         - Call dumpResponse() for extracted code.
3328         (WTR::TestController::handleControlCommand):
3329         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3330         - Use strncmp() instead of strcmp().
3331         - Call findAndDumpWebKitProcessIdentifiers() when
3332           "#LIST CHILD PROCESSES" command is sent.
3333         * WebKitTestRunner/TestController.h:
3334         (WTR::TestController::dumpResponse):
3335         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3336         - Declare methods.
3337
3338 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3339
3340         Unreviewed. Add GLib API test cases after r243434.
3341
3342         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3343         (testWebViewActiveURI):
3344         (serverCallback):
3345         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3346         (sendRequestCallback):
3347
3348 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3349
3350         Geolocation request not complete when watch request was started in a different web process
3351         https://bugs.webkit.org/show_bug.cgi?id=195996
3352
3353         Reviewed by Alex Christensen.
3354
3355         Add a test case.
3356
3357         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3358         (TestWebKitAPI::runJavaScriptAlert):
3359         (TestWebKitAPI::TEST):
3360
3361 2019-03-26  Keith Rollin  <krollin@apple.com>
3362
3363         Update the way generate-xcfilelists returns strings from functions
3364         https://bugs.webkit.org/show_bug.cgi?id=195975
3365         <rdar://problem/49040807>
3366
3367         Reviewed by Dean Jackson.
3368
3369         There are places where generate-xcfilelists executes assignments with
3370         statements like:
3371
3372             FOO=$(some_function)
3373
3374         where "some_function" return a string by echoing it. E.g.
3375
3376             some_function()
3377             {
3378                 echo "Hello, World"
3379             }
3380
3381         This is a common idiom, but it has a problem if "some_function" needs
3382         to call "exit" in an attempt to halt the entire script right then and
3383         there. Since "some_function" is called inside of $(), it's being
3384         executed in a sub-shell. Calling exit in that sub-shell simply exits
3385         that shell; it doesn't not exit the outer shell in which the main part
3386         of the script is still running. As such, the main script keeps
3387         executing when the intent was for the script to halt.
3388
3389         The solution to this is to use a different idiom for returning
3390         strings. The one we now is to pass in the name of the variable to
3391         receive the string result:
3392
3393             some_function()
3394             {
3395                 variable_name=$1
3396                 eval $variable_name ="Hello, World"
3397             }
3398
3399         The call site now looks like
3400
3401             some_function FOO
3402
3403         Because there's no invocation of a sub-shell, some_function can now
3404         call "exit" if it wants to, and the entire script will exit at that
3405         point.
3406
3407         * Scripts/generate-xcfilelists:
3408
3409 2019-03-26  Chris Dumez  <cdumez@apple.com>
3410
3411         Add basic layout test coverage for File Picker on iOS
3412         https://bugs.webkit.org/show_bug.cgi?id=196265
3413
3414         Reviewed by Wenson Hsieh.
3415
3416         Add layout test infrastructure to test the file picker on iOS.
3417
3418         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3419         (WTR::UIScriptController::dismissFilePicker):
3420         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3421         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3422         (WTR::UIScriptController::dismissFilePicker):
3423         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3424         * WebKitTestRunner/TestController.cpp:
3425         (WTR::TestController::createWebViewWithOptions):
3426         (WTR::updateTestOptionsFromTestHeader):
3427         * WebKitTestRunner/TestOptions.h:
3428         (WTR::TestOptions::hasSameInitializationOptions const):
3429         * WebKitTestRunner/ios/TestControllerIOS.mm:
3430         (overridePresentViewController):
3431         (WTR::TestController::platformInitialize):
3432         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3433         (WTR::UIScriptController::dismissFilePicker):
3434
3435 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3436
3437         Implement async paste method on UIWKInteractionViewProtocol
3438         https://bugs.webkit.org/show_bug.cgi?id=196267
3439         <rdar://problem/49236346>
3440
3441         Reviewed by Tim Horton.
3442
3443         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3444         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3445         are now a part of all iOS 12 internal SDKs.
3446
3447         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3448
3449         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
3450         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
3451
3452         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3453         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3454         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3455         * TestWebKitAPI/ios/UIKitSPI.h:
3456
3457 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3458
3459         [ews-build] Use PostgreSQL for ews.webkit.org database
3460         https://bugs.webkit.org/show_bug.cgi?id=196270
3461
3462         Reviewed by Lucas Forschler.
3463
3464         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3465
3466 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3467
3468         [ews] Reset simctl states on reboot
3469         https://bugs.webkit.org/show_bug.cgi?id=196260
3470
3471         Rubber-stamped by Aakash Jain.
3472
3473         * EWSTools/start-queue-mac.sh:
3474
3475 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3476
3477         [ews-build] Use PostgreSQL for ews-build database
3478         https://bugs.webkit.org/show_bug.cgi?id=196229
3479
3480         Reviewed by Lucas Forschler.
3481
3482         * BuildSlaveSupport/ews-build/master.cfg:
3483
3484 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3485
3486         [ews-build] Get master_hostname dynamically in master.cfg
3487         https://bugs.webkit.org/show_bug.cgi?id=196255
3488
3489         Reviewed by Lucas Forschler.
3490
3491         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3492         send events data in test mode.
3493
3494 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3495
3496         [ews-app] Set db_constraint to False for Foreign Keys
3497         https://bugs.webkit.org/show_bug.cgi?id=196252
3498
3499         Reviewed by Lucas Forschler.
3500
3501         * BuildSlaveSupport/ews-app/ews/models/build.py:
3502         * BuildSlaveSupport/ews-app/ews/models/step.py:
3503
3504 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3505
3506         [ews-build] is_test_mode_enabled should default to True
3507         https://bugs.webkit.org/show_bug.cgi?id=196248
3508
3509         Reviewed by Lucas Forschler.
3510
3511         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3512
3513 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3514
3515         [ews-app] Add webkitperl to ENABLED_QUEUES
3516         https://bugs.webkit.org/show_bug.cgi?id=196253
3517
3518         Reviewed by Lucas Forschler.
3519
3520         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3521
3522 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3523
3524         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3525         https://bugs.webkit.org/show_bug.cgi?id=196211
3526         rdar://problem/49110552
3527
3528         Reviewed by Tim Horton.
3529
3530         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3531         Make sure that EventSenderProxy always exists when running tests. We used to create
3532         it when resetting before the first test, which is a bit too late.
3533
3534         * WebKitTestRunner/TestController.h:
3535         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3536         (WTR::TestController::platformCreateWebView):
3537         (WTR::TestController::platformCreateOtherPage):
3538         (WTR::TestController::finishCreatingPlatformWebView):
3539         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3540         (WTR::PlatformWebView::PlatformWebView):
3541         Moved some code that made NSWindow use NSEvent during web view creation. We may
3542         need to move more if some other case us found, but this is enough for now.
3543
3544 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3545
3546         Unreviewed. Fix typo in GLib geolocation API after r243285.
3547
3548         gelocation -> geolocation.
3549
3550         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
3551         (testGeolocationManagerWatchPosition):
3552
3553 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3554
3555         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3556         https://bugs.webkit.org/show_bug.cgi?id=196213
3557
3558         Reviewed by Geoff Garen.
3559
3560         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3561         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3562         (credentialWithIdentityAndKeychainPath):
3563         (-[ChallengeDelegate webView:didFinishNavigation:]):
3564         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3565         (TestWebKitAPI::TEST):
3566
3567 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3568
3569         Expected shouldn't assume its contained types are copyable
3570         https://bugs.webkit.org/show_bug.cgi?id=195986
3571
3572         Reviewed by JF Bastien.
3573
3574         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3575         (TestWebKitAPI::NonCopyable::operator== const):
3576         (TestWebKitAPI::NonCopyable::operator!= const):
3577         (TestWebKitAPI::TEST):
3578
3579 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3580
3581         Remove some now-unnecessary dynamic class lookup
3582         https://bugs.webkit.org/show_bug.cgi?id=196237
3583
3584         Reviewed by Simon Fraser.
3585
3586         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3587         (makeRequest):
3588         (TEST):
3589
3590 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3591
3592         Unreviewed, rolling out r243450.
3593
3594         AppleWin and WinCairo port builds get broken.
3595
3596         Reverted changeset:
3597
3598         "Add test for fix of #196095"
3599         https://bugs.webkit.org/show_bug.cgi?id=196097
3600         https://trac.webkit.org/changeset/243450
3601
3602 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3603
3604         Unreviewed, rolling out r243465.
3605         https://bugs.webkit.org/show_bug.cgi?id=196226
3606
3607         the test doesn't build (Requested by thorton on #webkit).
3608
3609         Reverted changeset:
3610
3611         "Do not terminate the NetworkProcess if a third party
3612         application sends a NSCredential with a SecIdentityRef"
3613         https://bugs.webkit.org/show_bug.cgi?id=196213
3614         https://trac.webkit.org/changeset/243465
3615
3616 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3617
3618         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3619         https://bugs.webkit.org/show_bug.cgi?id=196213
3620
3621         Reviewed by Geoff Garen.
3622
3623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3624         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3625         (credentialWithIdentityAndKeychainPath):
3626         (-[ChallengeDelegate webView:didFinishNavigation:]):
3627         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3628         (TestWebKitAPI::TEST):
3629
3630 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3631
3632         [ews-build] Gracefully handle missing patch_id in events
3633         https://bugs.webkit.org/show_bug.cgi?id=196216
3634
3635         Reviewed by Lucas Forschler.
3636
3637         * BuildSlaveSupport/ews-build/events.py:
3638
3639 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3640
3641         [ews-build] use lz4 compression for improving buildbot performance
3642         https://bugs.webkit.org/show_bug.cgi?id=196155
3643
3644         Reviewed by Lucas Forschler.
3645
3646         * BuildSlaveSupport/ews-build/master.cfg:
3647
3648 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3649
3650         Pull some API testing helper methods out of TestWKWebView
3651         https://bugs.webkit.org/show_bug.cgi?id=196212
3652
3653         Reviewed by Tim Horton.
3654
3655         Refactor some more API testing utility methods, so that they can be used in
3656         tests that do not u