a833cee51f0b69c5f6be7bf1788211671e94de97
[WebKit-https.git] / Tools / ChangeLog
1 2013-07-01  Tim Horton  <timothy_horton@apple.com>
2
3         Maximum scroll position can be negative in some cases
4         https://bugs.webkit.org/show_bug.cgi?id=118175
5         <rdar://problem/14301217>
6
7         Reviewed by Anders Carlsson.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
11         (TestWebKitAPI::didRunJavaScript):
12         (TestWebKitAPI::didLayout):
13         (TestWebKitAPI::TEST):
14         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
15         Add a test that loads a vertical-lr document, paginates it horizontally
16         from right to left, resizes the view to fit the entire document, and
17         verifies that the scroll position is negative, as it must be for the
18         document to be enclosed by the view.
19
20 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
21
22         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
23         https://bugs.webkit.org/show_bug.cgi?id=117249
24
25         Reviewed by Brent Fulgham.
26
27         Finish converting all use cases of WEBKITOUTPUTDIR to
28         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
29
30         * DumpRenderTree/efl/FontManagement.cpp:
31         (getCustomBuildDir):
32         (getPlatformFontsPath):
33         * DumpRenderTree/gtk/DumpRenderTree.cpp:
34         (getOutputDir):
35         * Scripts/webkitdirs.pm:
36         (determineBaseProductDir):
37         (usesPerConfigurationBuildDirectory):
38         * Scripts/webkitpy/port/base.py:
39         (Port.to.setup_environ_for_server):
40         * Scripts/webkitpy/port/driver.py:
41         (Driver._setup_environ_for_driver):
42         * Scripts/webkitpy/port/gtk.py:
43         (GtkPort.setup_environ_for_server):
44         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
45         (WTR::getOutputDir):
46         * jhbuild/jhbuildutils.py:
47         (get_dependencies_path):
48
49 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
50
51         Unreviewed change of my email address.
52
53         * Scripts/webkitpy/common/config/contributors.json:
54
55 2013-06-28  Andreas Kling  <akling@apple.com>
56
57         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
58
59         * DumpRenderTree/win/DumpRenderTree.cpp:
60         (addFontFallbackIfPresent):
61         (removeFontFallbackIfPresent):
62
63 2013-06-28  Anders Carlsson  <andersca@apple.com>
64
65         Remove String::deprecatedCharactersWithNullTermination() and related code
66         https://bugs.webkit.org/show_bug.cgi?id=118211
67
68         Reviewed by Benjamin Poulain.
69
70         Remove all hasTerminatingNullCharacter() checks.
71
72         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
73         (TestWebKitAPI::TEST):
74         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
75         (TestWebKitAPI::TEST):
76         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
77         (TestWebKitAPI::TEST):
78
79 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
80
81         [Mac] Crash when loading is stopped from -didReceiveResponse
82         https://bugs.webkit.org/show_bug.cgi?id=118209
83         <rdar://problem/14259249>
84
85         Reviewed by Brady Eidson.
86
87         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
88         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
89         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
90         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
91         (TestWebKitAPI::TEST):
92
93 2013-06-28  Andy Estes  <aestes@apple.com>
94
95         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
96         https://bugs.webkit.org/show_bug.cgi?id=118208
97
98         Reviewed by Mark Rowe.
99
100         Newer versions of clang use a default template depth of 128, but this
101         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
102         previous default.
103
104         Clang lowered the default to keep recursive template instantiation
105         from overflowing the stack (see <rdar://problem/13935016>), but
106         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
107         higher limit. If for some reason this starts happening then we can
108         lower the limit back down.
109
110         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
111
112 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
113
114         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
115         https://bugs.webkit.org/show_bug.cgi?id=118195
116
117         Reviewed by Daniel Bates.
118
119         Currently, ports that use jhbuild fail to determine jhbuild directory
120         when "webKitBranchBuild" git configuration property is enabled. To reproduce
121         that issue in Efl port, enable that flag in .git/config, switch to a git branch
122         other than "master" and try to build webkit. The build will fail to
123         locate dependencies due to lack of pkg-config paths which should be set
124         by jhbuild.
125
126         For more details about "webKitBranchBuild" option, see:
127         https://trac.webkit.org/wiki/UsingGitWithWebKit
128
129         * Scripts/webkitdirs.pm:
130         (getJhbuildPath):
131
132 2013-06-28  Jessie Berlin  <jberlin@apple.com>
133
134         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
135         https://bugs.webkit.org/show_bug.cgi?id=118201
136
137         Reviewed by Dean Jackson.
138
139         * WebKitTestRunner/mac/main.mm:
140         (main):
141         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
142         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
143
144 2013-06-28  David Farler  <dfarler@apple.com>
145
146         Upstream WebKit Nightly’s WebKitLauncher
147         https://bugs.webkit.org/show_bug.cgi?id=117418
148
149         Reviewed by Mark Rowe.
150
151         Literal patch from Nightly's OpenSource repo.
152
153         * WebKitLauncher/Configurations/Base.xcconfig:
154         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
155         * WebKitLauncher/Info.plist:
156         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
157         * WebKitLauncher/WebKitLauncherURLProtocol.m:
158         (+[WebKitLauncherURLProtocol load]):
159         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
160         (-[WebKitLauncherURLProtocol startLoading]):
161         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
162         (-[WebKitLauncherURLProtocol resourceNotFound]):
163         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
164         (initializeSparkle):
165         * WebKitLauncher/main.m:
166         (determineExecutablePath):
167         (currentMacOSXVersion):
168         (main):
169         * WebKitLauncher/start.html:
170
171 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
172
173         [EFL] back/forward keyboard shortcuts are non-intuitive
174         https://bugs.webkit.org/show_bug.cgi?id=118193
175
176         Reviewed by Christophe Dumez.
177
178         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
179
180         * EWebLauncher/main.c:
181         (on_key_down):
182         * MiniBrowser/efl/main.c:
183         (on_key_down):
184
185 2013-06-28  Roger Fong  <roger_fong@apple.com>
186
187         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
188         https://bugs.webkit.org/show_bug.cgi?id=118194.
189
190         Reviewed by Brent Fulgham.
191
192         * DumpRenderTree/win/DumpRenderTree.cpp:
193         (dllLauncherEntryPoint):
194         * WinLauncher/WinLauncher.cpp:
195         (dllLauncherEntryPoint):
196
197 2013-06-28  Roger Fong  <roger_fong@apple.com>
198
199         Unreviewed build fix for AppleWin port. Fix some file paths.
200
201         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
202         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
203
204 2013-06-27  Roger Fong  <roger_fong@apple.com>
205
206         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
207         https://bugs.webkit.org/show_bug.cgi?id=118160.
208
209         Reviewed by Brent Fulgham.
210
211         * WinLauncher/AccessibilityDelegate.cpp: Added.
212         (AccessibilityDelegate::QueryInterface):
213         (AccessibilityDelegate::AddRef):
214         (AccessibilityDelegate::Release):
215         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
216         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
217         * WinLauncher/AccessibilityDelegate.h: Added.
218         (AccessibilityDelegate::AccessibilityDelegate):
219         * WinLauncher/WinLauncher.cpp:
220         (dllLauncherEntryPoint):
221         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
222         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
223
224 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
225
226         Clean up temporary files created by the bindings test script
227         https://bugs.webkit.org/show_bug.cgi?id=118189
228
229         Reviewed by Kentaro Hara.
230
231         Remove temporary files created by preprocess-idls.pl script after
232         the bindings tests are executed.
233
234         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
235
236         * Scripts/webkitpy/bindings/main.py:
237         (BindingsTests.main):
238
239 2013-06-26  Dean Jackson  <dino@apple.com>
240
241         [Mac] Add Mavericks system font to Test systems
242         https://bugs.webkit.org/show_bug.cgi?id=118109
243
244         Reviewed by Simon Fraser.
245
246         OS X Mavericks uses a different font for system controls. Tell DRT and
247         WKTR about them otherwise they use a fallback font. Unfortunately the
248         fonts are hidden (not found in the list of available fonts) so I
249         had to add them manually.
250
251         Even though there is only one at the moment, I implemented this
252         as a set so it will be easier to add new fonts if necessary.
253
254         * DumpRenderTree/mac/DumpRenderTree.mm:
255         (allowedFontFamilySet): Fixed typo.
256         (systemHiddenFontFamilySet): New method that returns the system control font.
257         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
258         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
259         (WTR::allowedFontFamilySet): Fixed typo.
260         (WTR::systemHiddenFontFamilySet): As above.
261         (WTR::wtr_NSFontManager_availableFonts):
262
263 2013-06-27  Anders Carlsson  <andersca@apple.com>
264
265         Get rid of the last uses of deprecatedCharactersWithNullTermination()
266         https://bugs.webkit.org/show_bug.cgi?id=118159
267
268         Reviewed by Andreas Kling.
269
270         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
271
272         * DumpRenderTree/win/DumpRenderTree.cpp:
273         (findFontFallback):
274
275 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
276
277         Sync up w3c import script with changes in Blink
278         https://bugs.webkit.org/show_bug.cgi?id=118149
279
280         Reviewed by Dirk Pranke.
281
282         This is a port of the following blink changes:
283
284         https://codereview.chromium.org/15366004
285         https://chromiumcodereview.appspot.com/15592005
286         https://codereview.chromium.org/16021006
287         https://codereview.chromium.org/15590004
288         https://codereview.chromium.org/15901008
289         https://codereview.chromium.org/16171009
290         https://codereview.chromium.org/16465007
291         https://codereview.chromium.org/15981013
292
293         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
294         (setUp):
295         (test_commit_message_for_this_commit):
296         * Scripts/webkitpy/port/base.py:
297         (Port):
298         * Scripts/webkitpy/port/test.py:
299         * Scripts/webkitpy/w3c/test_converter.py:
300         (W3CTestConverter.__init__):
301         (W3CTestConverter.read_webkit_prefixed_css_property_list):
302         (W3CTestConverter.convert_for_webkit):
303         (W3CTestConverter.convert_css):
304         (W3CTestConverter.convert_html):
305         (W3CTestConverter.convert_testharness_paths):
306         (W3CTestConverter.convert_prefixed_properties):
307         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
308         * Scripts/webkitpy/w3c/test_converter_unittest.py:
309         * Scripts/webkitpy/w3c/test_importer.py:
310         (main):
311         (configure_logging):
312         (configure_logging.LogHandler):
313         (configure_logging.LogHandler.format):
314         (parse_args):
315         (TestImporter.__init__):
316         (TestImporter.find_importable_tests):
317         (TestImporter.import_tests):
318         (TestImporter.setup_destination_directory):
319         (TestImporter.remove_deleted_files):
320         * Scripts/webkitpy/w3c/test_importer_unittest.py:
321         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
322         (TestImporterTest.test_import_dir_with_no_tests):
323         (TestImporterTest):
324         * Scripts/webkitpy/w3c/test_parser.py:
325         (TestParser.load_file):
326         (TestParser.analyze_test):
327         (TestParser.support_files):
328         * Scripts/webkitpy/w3c/test_parser_unittest.py:
329
330 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
331
332         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
333         https://bugs.webkit.org/show_bug.cgi?id=118128
334
335         Reviewed by Ryosuke Niwa.
336
337         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
338         https://bugs.webkit.org/show_bug.cgi?id=117831
339
340         * Scripts/webkitpy/tool/commands/download.py:
341         (AbstractPatchSequencingCommand):
342         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
343         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
344         (AbstractPatchSequencingCommand._prepare_state): Added.
345
346 2013-06-27  Brendan Long  <b.long@cablelabs.com>
347
348         [Qt] Build overrides -j when given --makeargs="-sj40"
349         https://bugs.webkit.org/show_bug.cgi?id=116897
350
351         Reviewed by Csaba Osztrogonác.
352
353         * Scripts/webkitdirs.pm:
354         (buildQMakeProjects):
355         Change regex checking for -j* to also check for -*j*
356
357 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
358
359         Remove [NoInterfaceObject] from WorkerGlobalScope
360         https://bugs.webkit.org/show_bug.cgi?id=118071
361
362         Reviewed by Kentaro Hara.
363
364         Update bindings test script to pass 2 additional parameters
365         now needed by the preprocess-idls.pl script.
366
367         * Scripts/webkitpy/bindings/main.py:
368         (BindingsTests.generate_supplemental_dependency):
369         (BindingsTests.main):
370
371 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
372
373         Fixing some compiler warnings
374         https://bugs.webkit.org/show_bug.cgi?id=117791
375
376         Reviewed by Martin Robinson.
377
378         * GNUmakefile.am: Silenced format warning.
379         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
380         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
381         Solved warning about uninitialized variable.
382
383 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
384
385         Fix bindings tests after r152080
386         https://bugs.webkit.org/show_bug.cgi?id=118118
387
388         Reviewed by Gyuyoung Kim.
389
390         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
391         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
392         accordingly.
393
394         * Scripts/webkitpy/bindings/main.py:
395         (BindingsTests.generate_supplemental_dependency):
396         (BindingsTests.main):
397
398 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
399
400         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
401         https://bugs.webkit.org/show_bug.cgi?id=117982
402
403         Reviewed by Rob Buis.
404
405         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
406         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
407         m_policyDelegateIsPermissive.
408         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
409         Reset m_policyDelegateIsPermissive.
410         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
411         m_policyDelegateIsPermissive.
412         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
413         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
414         Return whether custom policy is enabled.
415         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
416         Return whether custom policy is permissive.
417
418 2013-06-26  Anders Carlsson  <andersca@apple.com>
419
420         Deprecate StringImpl::charactersWithNullTermination
421         https://bugs.webkit.org/show_bug.cgi?id=118108
422
423         Reviewed by Beth Dakin.
424
425         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
426
427         * DumpRenderTree/win/DumpRenderTree.cpp:
428         (findFontFallback):
429         (addFontFallbackIfPresent):
430         (removeFontFallbackIfPresent):
431
432 2013-06-26  Nico Weber  <thakis@chromium.org>
433
434         Remove detect-mismached-virtual-const.
435         https://bugs.webkit.org/show_bug.cgi?id=117999
436
437         Reviewed by Anders Carlsson.
438
439         Clang warns on mismatched virtual const, so there's no need for this
440         script any more.
441
442         * Scripts/detect-mismatched-virtual-const: Removed.
443
444 2013-06-26  Alex Christensen  <achristensen@apple.com>
445
446         Added a code coverage report.
447         https://bugs.webkit.org/show_bug.cgi?id=117941
448
449         Reviewed by Joseph Pecoraro.
450
451         * CodeCoverage: Added.
452         * CodeCoverage/results-template.html: Added.
453         * Scripts/generate-coverage-data: Generate and open the new report.
454
455 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
456
457         gdb: Remove the webcore.py pretty printer.
458         https://bugs.webkit.org/show_bug.cgi?id=117992
459
460         Reviewed by Jochen Eisinger.
461
462         webcore.py has been only a placeholder for backwards compatibility
463         for almost 3 years. It should be safe enough to remove it now.
464
465         * gdb/webcore.py: Removed.
466
467 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
468
469         Creating cURL watchlist and adding myself to it.
470
471         Reviewed by Csaba Osztrogonác.
472
473         * Scripts/webkitpy/common/config/watchlist:
474
475 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
476
477         Unreviewed, change my email address for watch list.
478
479         * Scripts/webkitpy/common/config/watchlist:
480
481 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
482
483         [EFL] Add a script to install dependencies.
484         https://bugs.webkit.org/show_bug.cgi?id=117968
485
486         Reviewed by Christophe Dumez.
487
488         Add a script which installs basic dependencies for building WebKit EFL.
489
490         The dependencies are from the current EFLWebKit wiki page.
491         After this patch is landed, the wiki page will be updated to use
492         this script.
493
494         * efl/install-dependencies: Added.
495
496 2013-06-24  Dean Jackson  <dino@apple.com>
497
498         [Mac] Update font used for Chinese in test systems
499         https://bugs.webkit.org/show_bug.cgi?id=117970
500
501         Reviewed by Alexey Proskuryakov.
502
503         Add "Songti TC" and "Songti SC" to the list of allowed fonts
504         in DRT and WKTR.
505
506         * DumpRenderTree/mac/DumpRenderTree.mm:
507         (allowedFontFamilySet):
508         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
509         (WTR::allowedFontFamilySet):
510
511 2013-06-24  Tim Horton  <timothy_horton@apple.com>
512
513         Make MiniBrowser paginated mode work with WebKit1
514         https://bugs.webkit.org/show_bug.cgi?id=117950
515
516         Reviewed by Beth Dakin.
517
518         * MiniBrowser/mac/WK1BrowserWindowController.m:
519         (-[WK1BrowserWindowController isPaginated]):
520         (-[WK1BrowserWindowController togglePaginationMode:]):
521         Hook up isPaginated and togglePaginationMode just as for WebKit2.
522
523 2013-06-24  David Kilzer  <ddkilzer@apple.com>
524
525         bisect-builds: improve heuristic for choosing the next build after a broken build
526         <http://webkit.org/b/117918>
527
528         Reviewed by Simon Fraser.
529
530         * Scripts/bisect-builds: When a build is broken, use a heuristic
531         that "bisects" the left side or the right side of the remaining
532         revisions to pick a revision that's sufficiently different from
533         the revision of the broken build.  This heuristic assumes there
534         is a sequential range of broken builds whenever one broken build
535         is found.
536
537 2013-06-24  Chris Rogers  <crogers@google.com>
538
539         WaveTable name has changed to PeriodicWave
540         https://bugs.webkit.org/show_bug.cgi?id=117748
541
542         Reviewed by Jer Noble.
543
544         * Scripts/do-webcore-rename:
545
546 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
547
548         [EFL] Add support for MHTML save/load feature to MiniBrowser
549         https://bugs.webkit.org/show_bug.cgi?id=106620
550
551         Reviewed by Christophe Dumez.
552
553         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
554         from filesystem.
555
556         * MiniBrowser/efl/CMakeLists.txt:
557         * MiniBrowser/efl/main.c:
558         (page_contents_callback):
559         (on_key_down):
560         (show_file_entry_dialog): generic function to show file enrty
561         selector dialogue
562
563 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
564
565         [Windows] Unreviewed crash protection for DRT
566
567         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
568         to avoid crashing during test runs.
569
570 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
571
572         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
573         https://bugs.webkit.org/show_bug.cgi?id=117825
574
575         Reviewed by Kentaro Hara.
576
577         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
578
579         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
580         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
581         * DumpRenderTree/efl/TestRunnerEfl.cpp:
582         (TestRunner::overridePreference):
583
584 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
585
586         [ATK] Added support for aria-required attribute.
587         https://bugs.webkit.org/show_bug.cgi?id=117730
588
589         Reviewed by Chris Fleizach.
590
591         Added support for testing aria-required attribute.
592
593         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
594         (AccessibilityUIElement::isRequired):
595         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
596         (WTR::AccessibilityUIElement::isRequired):
597
598 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
599
600         [CMAKE][EFL] Enable DOM4 Events Constructor
601         https://bugs.webkit.org/show_bug.cgi?id=117858
602
603         Reviewed by Laszlo Gombos.
604
605         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
606
607 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
608
609         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
610         https://bugs.webkit.org/show_bug.cgi?id=117827
611
612         Reviewed by Rob Buis.
613
614         Reset the passed in request if willSendRequestReturnsNull() is
615         true or willSendRequestReturnsNullOnRedirect() is true and it's a
616         redirection.
617
618         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
619         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
620         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
621
622 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
623
624         Commit queue shouldn't reopen unrelated bugs because of flakiness
625         https://bugs.webkit.org/show_bug.cgi?id=117503
626
627         Reviewed by Ryosuke Niwa.
628
629         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
630         (_follow_duplicate_chain):
631         (_update_bug_for_flaky_test):
632
633 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
634
635         [Windows] AX: Expand notification support.
636         https://bugs.webkit.org/show_bug.cgi?id=117761
637
638         Reviewed by Anders Carlsson.
639
640         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
641         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
642         (AccessibilityUIElement::press): Provide implementation.
643
644 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
645
646         Use the PlatformEvent timestamp when creating a DOM Event
647         https://bugs.webkit.org/show_bug.cgi?id=117179
648
649         Reviewed by Darin Adler.
650
651         * WebKitTestRunner/mac/EventSenderProxy.mm:
652         (WTR::EventSenderProxy::mouseDown):
653         (WTR::EventSenderProxy::mouseUp):
654         (WTR::EventSenderProxy::mouseMoveTo):
655         (WTR::EventSenderProxy::keyDown):
656
657 2013-06-18  Alex Christensen  <achristensen@apple.com>
658
659         Working on coverage script, added xml to json data extraction script.
660         https://bugs.webkit.org/show_bug.cgi?id=117648
661
662         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
663         coverage data, runs the tests, and collects all of the data in json format.
664
665         Reviewed by Stephanie Lewis.
666
667         * Scripts/generate-coverage-data:
668         (parseGcovrOutput):
669         (getFileHitsAndBranches):
670         (addLineCounts):
671         (createResultName):
672         * Scripts/webkitpy/tool/gcovr: Added.
673
674 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
675
676         Unreviewed build fix after r151699.
677
678         * TestWebKitAPI/CMakeLists.txt:
679         * WebKitTestRunner/CMakeLists.txt:
680         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
681
682 2013-06-18  Roger Fong  <roger_fong@apple.com>
683
684         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
685         <rdar://problem/14118143>.
686
687         Rubberstamped by Brent Fulgham.
688
689         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
690         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
691         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
692         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
693         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
694         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
695         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
696         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
697         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
698         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
699         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
700         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
701         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
702         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
703         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
704         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
705         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
706         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
707         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
708         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
709         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
710         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
711         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
712         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
713         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
714         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
715         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
716         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
717         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
718         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
719         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
720         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
721         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
722         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
723         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
724         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
725         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
726         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
727         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
728         * win/record-memory/record-memory.vcxproj:
729         * win/record-memory/record-memoryDebug.props:
730         * win/record-memory/record-memoryDebugWinCairo.props:
731         * win/record-memory/record-memoryProduction.props:
732         * win/record-memory/record-memoryRelease.props:
733         * win/record-memory/record-memoryReleaseWinCairo.props:
734
735 2013-06-17  Kangil Han  <kangil.han@samsung.com>
736
737         Unreviewed. Add my email to a DOM watchlist.
738
739         * Scripts/webkitpy/common/config/watchlist:
740
741 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
742
743         Unreviewed GTK gardening.
744
745         * Scripts/run-gtk-tests:
746         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
747
748 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
749
750         Unreviewed. Reorder my email addresses.
751         https://bugs.webkit.org/show_bug.cgi?id=100122
752
753         * Scripts/webkitpy/common/config/contributors.json:
754
755 2013-06-14  Enrica Casucci  <enrica@apple.com>
756
757         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
758         https://bugs.webkit.org/show_bug.cgi?id=117647
759         <rdar://problem/13881024>
760
761         Reviewed by Darin Adler.
762         
763         The test now uses content with a selection and tests both
764         forwards and backward find as well as the case of a find
765         that has no matches after the user selection.
766
767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
768         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
769         (TestWebKitAPI::didFindStringMatches):
770         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
771
772 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
773
774         Remove myself from Qt build system watchlist
775
776         Reviewed by Simon Hausmann.
777
778         * Scripts/webkitpy/common/config/watchlist:
779
780 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
781
782         [Qt][Mac] Disable QTKit video on OS X.
783         https://bugs.webkit.org/show_bug.cgi?id=117591
784
785         Reviewed by Tor Arne Vestbø.
786
787         Deployment of Qt binaries to different Mac OS X
788         platform version makes it impossible to link against
789         the correct version of the WebKitSystemInterface library,
790         so we need to disable QTKit for media elements.
791
792         * qmake/mkspecs/features/features.prf:
793
794 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
795
796         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
797         https://bugs.webkit.org/show_bug.cgi?id=116610
798
799         Reviewed by Noam Rosenthal.
800
801         Remove unnecessary code adjusting context menu position to webview position.
802         Now position is calculcated in EwkView.
803
804         * MiniBrowser/efl/main.c:
805         (on_context_menu_show):
806
807 2013-06-12  Roger Fong  <roger_fong@apple.com>
808
809         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
810
811         * Scripts/webkitpy/common/config/ews.json:
812
813 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
814
815         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
816         https://bugs.webkit.org/show_bug.cgi?id=115647
817
818         Reviewed by Martin Robinson.
819
820         Locale resolution is moved to WebKitAccessibleWrapperAtk using
821         AtkObject::get_object_locale() API. Now, implementation of
822         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
823         be leveraged to get_object_locale() of AtkObject.
824
825         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
826         method.
827
828         No new functionality, no new tests.
829
830         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
831         (AccessibilityUIElement::language): Leverage locale resolution to
832         AtkObject::get_object_locale().
833         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
834         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
835         AtkObject::get_object_locale().
836
837 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
838
839         Remove last bits of GYP from build-webkit and update-webkit scripts
840         https://bugs.webkit.org/show_bug.cgi?id=117557
841
842         Reviewed by Ryosuke Niwa.
843
844         * Scripts/build-webkit:
845         * Scripts/update-webkit:
846
847 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
848
849         Remove forgotten unused Tools/Script/make-gypi script
850         https://bugs.webkit.org/show_bug.cgi?id=117558
851
852         Reviewed by Ryosuke Niwa.
853
854         This script isn't used since the GYP removal from WebKit.
855
856         * Scripts/make-gypi: Removed.
857
858 2013-06-12  Andres Gomez  <agomez@igalia.com>
859
860         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
861         https://bugs.webkit.org/show_bug.cgi?id=117533
862
863         Reviewed by Carlos Garcia Campos.
864
865         MiniBrowser now starts automatically the download of the documents
866         that cannot be shown just by WebKit itself on link left clicking.
867
868         * MiniBrowser/gtk/BrowserWindow.c:
869         (webViewDecidePolicy): handled the
870         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
871
872 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
873
874         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
875         https://bugs.webkit.org/show_bug.cgi?id=116723
876
877         Reviewed by Carlos Garcia Campos.
878
879         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
880         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
881         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
882         not expensive and produces a working archive without problems even on incremental builds.
883
884 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
885
886         [EFL] Window resize should close the popupmenu
887         https://bugs.webkit.org/show_bug.cgi?id=117391
888
889         Reviewed by Christophe Dumez.
890         
891         Added the code to close the popup when main window is resized.
892
893         * MiniBrowser/efl/main.c:
894         (on_window_resize):
895
896 2013-06-11  Alex Christensen  <achristensen@apple.com>
897
898         Removed old broken code coverage tool.
899         https://bugs.webkit.org/show_bug.cgi?id=117520
900
901         Reviewed by Sam Weinig.
902
903         * CodeCoverage: Removed.
904         * CodeCoverage/README: Removed.
905         * CodeCoverage/amber.png: Removed.
906         * CodeCoverage/cov.py: Removed.
907         * CodeCoverage/emerald.png: Removed.
908         * CodeCoverage/gcov.css: Removed.
909         * CodeCoverage/glass.png: Removed.
910         * CodeCoverage/regenerate-coverage-display: Removed.
911         * CodeCoverage/ruby.png: Removed.
912         * CodeCoverage/run-generate-coverage-data: Removed.
913         * CodeCoverage/snow.png: Removed.
914
915 2013-06-11  Timothy Hatcher  <timothy@apple.com>
916
917         Have build-webkit build the WebInspectorUI project.
918
919         * Scripts/build-webkit:
920
921 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
922
923         Add an option to run-webkit-tests to skip java dependency check
924         https://bugs.webkit.org/show_bug.cgi?id=117516
925
926         Reviewed by Andreas Kling.
927
928         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
929         (parse_args):
930         * Scripts/webkitpy/port/mac.py:
931         (MacPort._check_port_build):
932
933 2013-06-11  Alex Christensen  <achristensen@apple.com>
934
935         https://bugs.webkit.org/show_bug.cgi?id=117514
936         Removed extra Xcode code coverage flags.
937
938         Reviewed by Sam Weinig.
939
940         * Scripts/webkitdirs.pm:
941         (XcodeCoverageSupportOptions):
942
943 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
944
945         [Windows] Implement 'attributeValue' accessor to support testing
946         https://bugs.webkit.org/show_bug.cgi?id=117513
947
948         Reviewed by Anders Carlsson.
949
950         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
951         (comparableObject): Move earlier in file.
952         (findAccessibleObjectById): New implemenation.
953         (AccessibilityController::accessibleElementById): New implementation.
954
955 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
956
957         Make WTR use its own temporary directory for application cache
958         https://bugs.webkit.org/show_bug.cgi?id=117143
959
960         Reviewed by Alexey Proskuryakov.
961
962         * WebKitTestRunner/TestController.cpp:
963         (WTR::TestController::initialize):
964
965 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
966
967         https://bugs.webkit.org/show_bug.cgi?id=117449
968         Remove dead code for storing fonts in __DATA section
969
970         Reviewed by Dan Bernstein.
971
972         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
973         Don't copy font resources to __DATA, as we don't have any code that reads them
974         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
975
976         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
977         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
978         Removed comments suggesting that we want to restore the old solution.
979
980 2013-06-10  Bear Travis  <betravis@adobe.com>
981
982         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
983         https://bugs.webkit.org/show_bug.cgi?id=117162
984
985         Reviewed by Alexandru Chiculita.
986
987         Adding the WebCore/rendering/shapes directory to the include list.
988
989         * DumpRenderTree/efl/CMakeLists.txt:
990
991 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
992
993         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
994         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
995         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
996         happends in some of the 'accessibility' test cases.
997
998 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
999
1000         [WinCairo] TestWebKitAPI fails to link.
1001         https://bugs.webkit.org/show_bug.cgi?id=117345
1002
1003         Reviewed by Brent Fulgham.
1004
1005         Need to link with WTF.lib.
1006
1007         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
1008
1009 2013-06-07  Roger Fong  <roger_fong@apple.com>
1010
1011         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
1012
1013         Rubberstamped by Ryousuke Niwa.
1014
1015         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1016         (RunTest.test_build_check):
1017
1018 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
1019
1020         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
1021         https://bugs.webkit.org/show_bug.cgi?id=117315
1022
1023         Reviewed by Benjamin Poulain.
1024
1025         Qt doesn't use the default values specified on FeatureList since r44681,
1026         this patch just remove a bit of noise.
1027
1028         * Scripts/webkitperl/FeatureList.pm:
1029
1030 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
1031
1032         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
1033         https://bugs.webkit.org/show_bug.cgi?id=115890
1034
1035         Reviewed by Christophe Dumez.
1036
1037         When user clicks HTML5 input type color,
1038         color selector window is created on browser object by using elm_colorchooser_add().
1039         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
1040         The evas_object_color_set() sets a color value returning to browser.
1041
1042         * MiniBrowser/efl/main.c:
1043         (window_free): When we delete parent window, deleting the colorpicker object.
1044         (on_color_changed): Change color of rectangle to show color selected by user.
1045         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
1046         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
1047         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
1048         (on_color_picker_dismiss): Delete colorpicker object.
1049         (on_color_picker_request): Create colorpicker window object.
1050         (window_create):
1051
1052 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
1053
1054         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
1055         https://bugs.webkit.org/show_bug.cgi?id=111066
1056
1057         Reviewed by Daniel Bates.
1058
1059         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
1060
1061         ParseGitDiffHeader() should support the path which line has space characters.
1062         To support this, I changed parsing algorithm like the following:
1063         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
1064         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
1065
1066         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
1067
1068         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
1069         I added a dummy tab and revision when we convert git diff to svn diff.
1070
1071         * Scripts/VCSUtils.pm:
1072         (parseGitDiffHeader):
1073         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
1074         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
1075         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
1076           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
1077
1078 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
1079
1080         Add a menu item to MiniBrowser to toggle Transparent windows
1081         https://bugs.webkit.org/show_bug.cgi?id=117316
1082
1083         Reviewed by Anders Carlsson.
1084         
1085         Add a menu item that toggles "Transparent window" mode, which is exposed
1086         via private WebKit API and WebKit2 API.
1087
1088         * MiniBrowser/mac/BrowserWindowController.h:
1089         * MiniBrowser/mac/MainMenu.xib:
1090         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1091         * MiniBrowser/mac/WK1BrowserWindowController.m:
1092         (-[WK1BrowserWindowController validateMenuItem:]):
1093         (-[WK1BrowserWindowController toggleTransparentWindow:]):
1094         * MiniBrowser/mac/WK2BrowserWindowController.m:
1095         (-[WK2BrowserWindowController validateMenuItem:]):
1096         (-[WK2BrowserWindowController toggleTransparentWindow:]):
1097         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
1098         when testing.
1099
1100 2013-06-06  Roger Fong  <roger_fong@apple.com>
1101
1102         Stop copying AAS binaries into build folder.
1103         https://bugs.webkit.org/show_bug.cgi?id=117319.
1104
1105         Rubberstamped by Darin Adler.
1106
1107         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
1108
1109 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
1110
1111         Aligning build-webkit command line switch names to the WebKit flag names
1112         https://bugs.webkit.org/show_bug.cgi?id=117254
1113
1114         Reviewed by Laszlo Gombos.
1115
1116         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
1117
1118 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
1119
1120         AX: iOS ignores ARIA progressbar elements
1121         https://bugs.webkit.org/show_bug.cgi?id=116727
1122
1123         Reviewed by David Kilzer.
1124
1125         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1126         (AccessibilityUIElement::minValue):
1127         (AccessibilityUIElement::maxValue):
1128
1129 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
1130
1131         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
1132         https://bugs.webkit.org/show_bug.cgi?id=117255
1133
1134         Reviewed by Daniel Bates.
1135
1136         Need to update configuration names according to solution file.
1137
1138         * Scripts/webkitdirs.pm:
1139         (determineConfiguration):
1140         (determinePassedConfiguration):
1141
1142 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
1143
1144         Remove run-performance-tests
1145         https://bugs.webkit.org/show_bug.cgi?id=117285
1146
1147         Reviewed by Andreas Kling.
1148         
1149         Remove the script since it's not used anywhere.
1150
1151         * BuildSlaveSupport/run-performance-tests: Removed.
1152
1153 2013-06-05  Bear Travis  <betravis@adobe.com>
1154
1155         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
1156         https://bugs.webkit.org/show_bug.cgi?id=117172
1157
1158         Reviewed by Alexandru Chiculita.
1159
1160         Adding the CSS_SHAPES compile flag.
1161
1162         * Scripts/webkitperl/FeatureList.pm:
1163         * qmake/mkspecs/features/features.pri:
1164
1165 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
1166
1167         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
1168         to UNIX-style they will not execute properly.
1169
1170         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
1171         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
1172
1173 2013-06-05  Roger Fong  <roger_fong@apple.com>
1174
1175         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
1176
1177         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1178         (RunWebKitTests.start):
1179
1180 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
1181
1182         [Windows] Switch to NRWT
1183         https://bugs.webkit.org/show_bug.cgi?id=117200
1184
1185         Reviewed by Anders Carlsson.
1186
1187         * Scripts/run-webkit-tests:
1188         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
1189
1190 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
1191
1192         Unreviewed name fix after r150662
1193
1194         My firstname got duplicated when fixing bug 116737.
1195
1196         * Scripts/webkitpy/common/config/contributors.json:
1197
1198 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1199
1200         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
1201         https://bugs.webkit.org/show_bug.cgi?id=117244
1202
1203         Reviewed by Daniel Bates.
1204
1205         Fixed a regression introduced by r151196: not only does webkit.org
1206         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
1207         infrastructure used by ports such as GTK+ and EFL also use on it for
1208         things such as jhbuild.
1209
1210         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
1211         both environment variables.
1212
1213         * Scripts/webkitdirs.pm:
1214         (determineBaseProductDir):
1215
1216 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
1217
1218         [GTK] Forwarding headers not generated for incremental build
1219         https://bugs.webkit.org/show_bug.cgi?id=117198
1220
1221         Reviewed by Carlos Garcia Campos.
1222
1223         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
1224
1225 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
1226
1227         [Qt][WK2] Fix layout testing with Qt 5.1
1228         https://bugs.webkit.org/show_bug.cgi?id=117203
1229
1230         Reviewed by Jocelyn Turcotte.
1231
1232         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
1233         go into loading state but directly call handler functions for
1234         finished state instead of relying on a connection.
1235         Our wrapper QQuickView uses a data URI scheme to create the root
1236         item for testing which results in a synchronous request when loading
1237         the QML data, therefore the state of the QQuickWindow immediately
1238         becomes Ready.
1239         Since the final initialization of the root item depended on the
1240         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
1241         up with a partially initialized wrapper window, thus most of our
1242         layout tests were failing.
1243         For compatibility with pre-5.1 Qt versions keep the old behaviour
1244         in case the WrapperWindow is not ready in the constructor yet.
1245
1246         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1247         (WTR::WrapperWindow::WrapperWindow):
1248         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
1249         (TestWebKitAPI::WrapperWindow::WrapperWindow):
1250
1251 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
1252
1253         Bad value in tests counter at new-run-webkit-tests
1254         in --debug-rwt-logging mode
1255         https://bugs.webkit.org/show_bug.cgi?id=116858
1256
1257         Reviewed by Dirk Pranke.
1258
1259         Fix by moving counter incrementation, from after printing line,
1260         to before printing. Also changed variable name.
1261
1262         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1263         (LayoutTestRunner.run_tests):
1264         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1265         (FakePrinter):
1266         * Scripts/webkitpy/layout_tests/views/printing.py:
1267         (Printer.__init__):
1268         (Printer._test_status_line):
1269         (Printer.print_started_test):
1270         (Printer.print_finished_test):
1271         * Scripts/webkitpy/test/printer.py:
1272         (Printer.__init__):
1273         (Printer.print_finished_test):
1274         (Printer._test_line):
1275         (Printer.print_result):
1276
1277 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
1278
1279         Move MemoryInfo under window.internals
1280         https://bugs.webkit.org/show_bug.cgi?id=117197
1281
1282         Reviewed by Ryosuke Niwa.
1283
1284         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
1285         the Automake build
1286         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
1287         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
1288
1289 2013-06-03  Roger Fong  <roger_fong@apple.com>
1290
1291         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
1292         <rdar://problem/14042021>.
1293
1294         Reviewed by Brent Fulgham.
1295
1296         * Scripts/build-api-tests:
1297         * Scripts/build-dumprendertree:
1298         * Scripts/build-webkit:
1299         * Scripts/update-webkit-dependency:
1300         * Scripts/update-webkit-support-libs:
1301         * Scripts/webkitdirs.pm:
1302         (determineBaseProductDir):
1303         (setupAppleWinEnv):
1304         (setupCygwinEnv):
1305
1306 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
1307
1308         [Windows] NRWT is not putting crash logs in proper place (corrections)
1309         https://bugs.webkit.org/show_bug.cgi?id=117212
1310
1311         Reviewed by Dirk Pranke.
1312
1313         * Scripts/webkitpy/common/system/crashlogs.py:
1314         (CrashLogs.__init__): Accept a result directory argument in constructor.
1315         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
1316         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
1317         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1318         (CrashLogsTest.test_find_log_win): Simplify test.
1319         * Scripts/webkitpy/common/system/executive.py:
1320         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
1321         * Scripts/webkitpy/port/win.py:
1322         (WinPort._get_crash_log): No longer require 'port' argument.
1323
1324 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
1325
1326         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
1327
1328         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1329
1330 2013-06-04  Greg Hughes  <ghughes@apple.com>
1331
1332         Add "VisibleOnly" key to search predicate
1333         https://bugs.webkit.org/show_bug.cgi?id=115491
1334
1335         Reviewed by Chris Fleizach.
1336
1337         Added support for accessibility clients to use the search predicate to find only visible elements
1338
1339         * DumpRenderTree/AccessibilityUIElement.cpp:
1340         (uiElementForSearchPredicateCallback):
1341         * DumpRenderTree/AccessibilityUIElement.h:
1342         (AccessibilityUIElement):
1343         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1344         (AccessibilityUIElement::uiElementForSearchPredicate):
1345         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1346         (AccessibilityUIElement::uiElementForSearchPredicate):
1347         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1348         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1349         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1350         (AccessibilityUIElement):
1351         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1352         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1353         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1354
1355 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
1356
1357         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
1358         causing build failure.
1359
1360         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
1361         DOS-style CR/LF endings.
1362
1363 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
1364
1365         [Windows] Unreviewed test correction.
1366
1367         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
1368         QuartzCore dll's, which are needed by TestWebKitAPI.
1369         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
1370         with VS2010 will run when linked against VS2005 support libraries.
1371
1372 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1373
1374         Automatically generate WorkerContext constructor attributes
1375         https://bugs.webkit.org/show_bug.cgi?id=117183
1376
1377         Reviewed by Kentaro Hara.
1378
1379         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
1380         tests.
1381
1382         * Scripts/webkitpy/bindings/main.py:
1383         (BindingsTests.generate_supplemental_dependency):
1384         (BindingsTests.main):
1385
1386 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
1387
1388         [EFL] File dialog of MiniBrowser have broken background.
1389         https://bugs.webkit.org/show_bug.cgi?id=117189
1390
1391         Reviewed by Christophe Dumez.
1392
1393         * MiniBrowser/efl/main.c:
1394         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
1395
1396 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1397
1398         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
1399         https://bugs.webkit.org/show_bug.cgi?id=117184
1400
1401         Reviewed by Gyuyoung Kim.
1402
1403         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
1404         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
1405
1406         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1407         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1408         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1409
1410 2013-06-03  Simon Pena  <simon.pena@samsung.com>
1411
1412         validate-committer-lists script is now outdated and does not work
1413         https://bugs.webkit.org/show_bug.cgi?id=115860
1414
1415         Reviewed by Brent Fulgham.
1416
1417         The script validate-committer-lists was outdated, still using the deprecated log
1418         system and having the old addresses for the mailing lists, as well as still referring
1419         to committers.py, after this was renamed to contributors.json. This patch fixes that
1420         so it can be used again.
1421
1422         * Scripts/validate-committer-lists: Replace calls to log and error with the
1423         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
1424         to committers.py, which should be contributors.json.
1425         (CommitterListFromMailingList):
1426         (CommitterListFromMailingList.check_for_emails_missing_from_list):
1427         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
1428         (CommitterListFromGit._fill_in_emails_for_old_logins):
1429         (CommitterListFromGit.print_committers_missing_from_committer_list):
1430
1431 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
1432
1433         add a script to dump the tests run most recently by a given worker
1434         https://bugs.webkit.org/show_bug.cgi?id=116571
1435
1436         Reviewed by Brent Fulgham.
1437
1438         The tests_run*.txt results files in layout-test-results/ were removed
1439         in r137356, in favor of collecting more data about how the tests were
1440         run and compressing it and storing it in stats.json. However, it was
1441         nice to just be able to look at a flat text file.
1442
1443         This script will extract the tests run by a given worker from a
1444         given stats.json file, and should help to address that.
1445
1446         * Scripts/dump-webkit-tests-run: Added.
1447         (main):
1448         (convert_trie_to_flat_paths):
1449
1450 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
1451
1452         [Windows] NRWT is not putting crash logs in proper place
1453         https://bugs.webkit.org/show_bug.cgi?id=117098
1454
1455         Reviewed by Ryosuke Niwa.
1456
1457         Provide windows-specific overloads for various Port features needed to create and capture
1458         crash logs.  This change makes it possible to view crash logs (when created) as part of the
1459         summary report at the end of the NRWT run.
1460
1461         * Scripts/webkitpy/common/system/crashlogs.py:
1462         (CrashLogs.find_newest_log): Add support for win32 crash logs
1463         (CrashLogs._find_newest_log_win): Added
1464         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1465         (make_mock_crash_report_win): Added
1466         (CrashLogsTest.test_find_log_win): Added.
1467         * Scripts/webkitpy/common/system/executive.py:
1468         (Executive.running_pids): Add support for Cygwin win32 crash logs
1469         * Scripts/webkitpy/common/system/executive_mock.py:
1470         (MockExecutive.__init__):
1471         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1472         (RealFileSystemTest.test_read_and_write_file): Add tests for
1473         malformed ascii/utf8 handling (i.e., Windows log files)
1474         * Scripts/webkitpy/port/base.py:
1475         (Port.find_system_pid): Added
1476         * Scripts/webkitpy/port/server_process.py:
1477         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
1478         * Scripts/webkitpy/port/win.py:
1479         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
1480         for user to hit enter.
1481         (WinPort._get_crash_log): Added
1482         (WinPort.look_for_new_crash_logs): Added
1483         (WinPort.find_system_pid): Added
1484         * Scripts/webkitpy/port/win_unittest.py:
1485         (WinPortTest.test_get_crash_log): Added test
1486
1487 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
1488
1489         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
1490         https://bugs.webkit.org/show_bug.cgi?id=116726
1491
1492         Reviewed by Gyuyoung Kim.
1493
1494         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
1495         the platform (it is not listed in jhbuild moduleset). That version is
1496         old-ish and contain deprecated symbols and missing API, that are blocking
1497         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
1498         moduleset, which is the same version the gtk port uses.
1499
1500         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
1501         why this is needed.
1502
1503         * efl/jhbuild.modules: Adds ATK module as dependency
1504
1505 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
1506
1507         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
1508         https://bugs.webkit.org/show_bug.cgi?id=117168
1509
1510         Reviewed by Martin Robinson.
1511
1512         The tool generate-gtkdoc internally calls pkg-config.
1513         When cross-compiling it shouldn't use pkg-config, but
1514         it should use the pkg-config which was detected by
1515         the ./configure script (for example this can be
1516         i686-w64-mingw32-pkg-config when cross-compiling)
1517
1518         * GNUmakefile.am:
1519         * gtk/gtkdoc.py:
1520         (PkgConfigGTKDoc.__init__):
1521
1522 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
1523
1524         [Windows] Unreviewed build fix.
1525
1526         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
1527         allow VS2010 builds to use VS2005 runtime libraries as needed.
1528
1529 2013-06-03  Roger Fong  <roger_fong@apple.com>
1530
1531         Nuke VS2005 files from the tree.
1532         <rdar://problem/14042021>.
1533
1534         Rubberstamped by Brent Fulgham.
1535
1536         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
1537         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
1538         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
1539         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
1540         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
1541         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
1542         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
1543         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
1544         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
1545         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
1546         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
1547         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
1548         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
1549         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
1550         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
1551         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
1552         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
1553         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
1554         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
1555         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
1556         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
1557         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
1558         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
1559         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
1560         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
1561         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
1562         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
1563         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
1564         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
1565         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
1566         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
1567         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
1568         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
1569         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
1570         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
1571         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
1572         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
1573         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
1574         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
1575         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
1576         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
1577         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
1578         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
1579         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
1580         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
1581         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
1582         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
1583         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
1584         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
1585         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
1586         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
1587         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
1588         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
1589         * Scripts/pdevenv: Removed.
1590         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
1591         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
1592         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
1593         * WebKitLauncherWin: Removed.
1594         * WebKitLauncherWin/Resource.h: Removed.
1595         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
1596         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
1597         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
1598         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
1599         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
1600         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
1601         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
1602         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
1603         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
1604         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
1605         * WebKitLauncherWin/webkit.ico: Removed.
1606         * WinLauncher/WinLauncher.ico: Removed.
1607         * WinLauncher/WinLauncher.rc: Removed.
1608         * WinLauncher/WinLauncher.vcproj: Removed.
1609         * WinLauncher/WinLauncherCommon.vsprops: Removed.
1610         * WinLauncher/WinLauncherDebug.vsprops: Removed.
1611         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
1612         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
1613         * WinLauncher/WinLauncherLauncher.rc: Removed.
1614         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
1615         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
1616         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
1617         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
1618         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
1619         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
1620         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
1621         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
1622         * WinLauncher/WinLauncherLauncherResource.h: Removed.
1623         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
1624         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
1625         * WinLauncher/WinLauncherProduction.vsprops: Removed.
1626         * WinLauncher/WinLauncherRelease.vsprops: Removed.
1627         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
1628         * WinLauncher/small.ico: Removed.
1629         * record-memory-win: Removed.
1630         * record-memory-win/main.cpp: Removed.
1631         * record-memory-win/record-memory-win-common.vsprops: Removed.
1632         * record-memory-win/record-memory-win.vcproj: Removed.
1633         * record-memory-win/record-memory-winDebug.vsprops: Removed.
1634         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
1635         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
1636         * record-memory-win/record-memory-winProduction.vsprops: Removed.
1637         * record-memory-win/record-memory-winRelease.vsprops: Removed.
1638         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
1639
1640 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
1641
1642         AX: MathML multiscripts not exposed in Accessibility
1643         https://bugs.webkit.org/show_bug.cgi?id=115069
1644
1645         Reviewed by Tim Horton.
1646
1647         Add methods to help output components of math multiscripts for accessibility.
1648
1649         * DumpRenderTree/AccessibilityUIElement.cpp:
1650         (mathPostscriptsDescriptionCallback):
1651         (mathPrescriptsDescriptionCallback):
1652         (AccessibilityUIElement::getJSClass):
1653         * DumpRenderTree/AccessibilityUIElement.h:
1654         (AccessibilityUIElement):
1655         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1656         (convertMathMultiscriptPairsToString):
1657         (AccessibilityUIElement::mathPostscriptsDescription):
1658         (AccessibilityUIElement::mathPrescriptsDescription):
1659         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1660         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1661         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1662         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1663         (AccessibilityUIElement):
1664         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1665         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1666         (WTR::_convertMathMultiscriptPairsToString):
1667         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1668         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1669
1670 2013-06-03  Commit Queue  <commit-queue@webkit.org>
1671
1672         Unreviewed, rolling out r151109.
1673         http://trac.webkit.org/changeset/151109
1674         https://bugs.webkit.org/show_bug.cgi?id=117145
1675
1676         "Plugins in WK2 aren't implemented yet." (Requested by
1677         jturcotte on #webkit).
1678
1679         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1680         * qmake/mkspecs/features/features.prf:
1681         * qmake/mkspecs/features/unix/default_pre.prf:
1682
1683 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1684
1685         [Qt] Re-enable plugins on Mac.
1686         https://bugs.webkit.org/show_bug.cgi?id=116622
1687
1688         Reviewed by Tor Arne Vestbø.
1689
1690         Plugins on Mac were only enabled if !embedded but the later was set if
1691         QPA is enabled, which is the default since Qt 5.0.
1692
1693         Remove references to 'embedded' and fix various build issues,
1694         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
1695         months.
1696
1697         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1698         * qmake/mkspecs/features/features.prf:
1699         * qmake/mkspecs/features/unix/default_pre.prf:
1700
1701 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
1702
1703         [GTK][WK2] accessibility/placeholder.html is failing
1704         https://bugs.webkit.org/show_bug.cgi?id=106344
1705
1706         Reviewed by Gyuyoung Kim.
1707
1708         Adds support for retrieving attribute value.
1709
1710         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1711         (WTR::coreAttributeToAtkAttribute):
1712         (WTR::AccessibilityUIElement::stringAttributeValue):
1713
1714 2013-06-01  Tim Horton  <timothy_horton@apple.com>
1715
1716         Add a preferred email address and "expertise" for me.
1717
1718         * Scripts/webkitpy/common/config/contributors.json:
1719
1720 2013-05-31  Roger Fong  <roger_fong@apple.com>
1721
1722         Unreviewed. Make windows test bots search in the correct directory for build output.
1723
1724         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1725         (RunWebKitTests.start):
1726         * Scripts/webkitdirs.pm:
1727         (determineConfigurationProductDir):
1728
1729 2013-05-31  Roger Fong  <roger_fong@apple.com>
1730
1731         Unreviewed. Windows build fix...
1732
1733         * BuildSlaveSupport/built-product-archive:
1734         (createZip):
1735
1736 2013-05-31  Roger Fong  <roger_fong@apple.com>
1737
1738         Unreviewed. Windows build fix. One more time!
1739
1740         * BuildSlaveSupport/built-product-archive:
1741         (archiveBuiltProduct):
1742         (extractBuiltProduct):
1743
1744 2013-05-31  Roger Fong  <roger_fong@apple.com>
1745
1746         Unreviewed. Windows build fix.
1747
1748         * Scripts/build-webkit:
1749
1750 2013-05-31  Roger Fong  <roger_fong@apple.com>
1751
1752         Unreviewed. Windows build fix.
1753
1754         * Scripts/build-webkit:
1755
1756 2013-05-31  Roger Fong  <roger_fong@apple.com>
1757
1758         Make build-webkit output VCExpress 2010 build logs properly.
1759         https://bugs.webkit.org/show_bug.cgi?id=117096
1760
1761         Reviewed by Brent Fulgham.
1762
1763         Make it so that output from VCExpress is always printed to console.
1764         Get build log results from AssembleBuildLogs project output.
1765         We don't need those old VCExpress scripts anymore either. 
1766
1767         * Scripts/build-webkit:
1768         * Scripts/print-msvc-project-dependencies: Removed.
1769         * Scripts/print-vse-failure-logs: Removed.
1770
1771 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
1772
1773         [Windows] Use WinLauncher to display LayoutTest results
1774         https://bugs.webkit.org/show_bug.cgi?id=117085
1775
1776         Reviewed by Oliver Hunt.
1777
1778         * Scripts/webkitdirs.pm:
1779         (runSafari): Use WinLauncher to display content
1780         * WinLauncher/WinLauncher.cpp:
1781         (dllLauncherEntryPoint): Check for URL argument.
1782
1783 2013-05-31  Roger Fong  <roger_fong@apple.com>
1784
1785         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
1786
1787         * win/AssembleBuildLogs/AssembleLogs.cmd:
1788
1789 2013-05-31  Commit Queue  <commit-queue@webkit.org>
1790
1791         Unreviewed, rolling out r151022.
1792         http://trac.webkit.org/changeset/151022
1793         https://bugs.webkit.org/show_bug.cgi?id=117084
1794
1795         Also breaks build by introducing duplicate symbols (Requested
1796         by bfulgham on #webkit).
1797
1798         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1799
1800 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
1801
1802         [Windows] Unreviewed build fix to NRWT
1803
1804         * Scripts/webkitpy/port/win.py:
1805         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
1806
1807 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
1808
1809         [Windows] Unreviewed build fix after r151012
1810
1811         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
1812         WTF library to support SHA tests
1813
1814 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
1815
1816         [Windows] Unreviewed build fix after r151012
1817
1818         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
1819         snprintf definition for Windows.
1820
1821 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
1822
1823         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
1824         https://bugs.webkit.org/show_bug.cgi?id=116445
1825
1826         Reviewed by Benjamin Poulain.
1827
1828         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
1829
1830         * TestWebKitAPI/CMakeLists.txt:
1831         * TestWebKitAPI/GNUmakefile.am:
1832         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1833         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1835         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
1836         (TestWebKitAPI):
1837         (TestWebKitAPI::expectMD5):
1838         (TestWebKitAPI::TEST):
1839         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
1840         (TestWebKitAPI):
1841         (TestWebKitAPI::expectSHA1):
1842         (TestWebKitAPI::TEST):
1843         * TestWebKitAPI/Tests/WTF/WTF.pro:
1844         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1845
1846 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
1847
1848         [Windows] Unreviewed build correction.
1849
1850         * Scripts/webkitpy/port/win.py:
1851         (WinPort.create_debugger_command_file): The directory needs to be
1852         a string, not a temporary directory object.
1853
1854 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
1855
1856         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
1857         https://bugs.webkit.org/show_bug.cgi?id=76935
1858
1859         Reviewed by Ryosuke Niwa.
1860
1861         Extend the WinPort class with commands to set and clean up various registry
1862         values needed to invoke the correct debugger to get crash files.
1863
1864         * Scripts/webkitpy/port/win.py:
1865         (WinPort): Added global caches for registry keys and settings
1866         (WinPort._ntsd_location): Added
1867         (WinPort.create_debugger_command_file): Added
1868         (WinPort.read_registry_string): Added
1869         (WinPort.write_registry_string): Added
1870         (WinPort.setup_crash_log_saving): Added
1871         (WinPort.restore_crash_log_saving): Added
1872         (WinPort.setup_test_run): Added overload to add registry settings.
1873         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
1874
1875 2013-05-30  Roger Fong  <roger_fong@apple.com>
1876
1877         Get rid of JavaScript exports file on AppleWin port.
1878         https://bugs.webkit.org/show_bug.cgi?id=117050.
1879
1880         Reviewed by Darin Adler.
1881
1882         Start linking in WTF.lib now that it's a shared library.
1883
1884         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1885         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
1886         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1887
1888 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1889
1890         Web Inspector: tests in PerformanceTests/inspector/ are timing out
1891         https://bugs.webkit.org/show_bug.cgi?id=77024
1892
1893         Reviewed by Andreas Kling.
1894
1895         Remove inspector performance tests since they have been disabled for ages,
1896         and they don't use the standard parser-style performance output.
1897
1898         It's adding a lot of code complexity to our infrastructure.
1899
1900         * Scripts/webkitpy/performance_tests/perftest.py:
1901         (SingleProcessPerfTest.__init__):
1902         (PerfTestFactory):
1903         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1904         (TestPerfTestFactory.test_regular_test):
1905         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1906         (TestDriver.run_test):
1907         (MainTest.run_test):
1908         (MainTest._tests_for_runner):
1909         (MainTest.test_run_test_set_kills_drt_per_run):
1910         (MainTest._test_run_with_json_output):
1911         (MainTest):
1912         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1913
1914 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1915
1916         Remove requires_http_server as Chromium Android was the only port that needed this
1917         https://bugs.webkit.org/show_bug.cgi?id=117018
1918
1919         Reviewed by Benjamin Poulain.
1920
1921         Removed the unused code that existed for Chromium Android port.
1922
1923         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1924         (LayoutTestRunner.run_tests):
1925         (LayoutTestRunner._handle_finished_test_list):
1926         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1927         (Manager._run_tests):
1928         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1929         (PerfTestsRunner._collect_tests):
1930         (PerfTestsRunner.run):
1931         * Scripts/webkitpy/port/base.py:
1932         (Port.to.start_helper):
1933         * Scripts/webkitpy/port/base_unittest.py:
1934         (PortTest.test_build_path):
1935
1936 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
1937
1938         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
1939         https://bugs.webkit.org/show_bug.cgi?id=113221
1940
1941         Reviewed by Ryosuke Niwa.
1942
1943         Teach prepare-Changelog to not list the names of modified namespaces, 
1944         classes, or structs in C++ files. Thus, if a change is made 
1945         within a namespace/class/struct yet outside a function, it will 
1946         not be reflected in the ChangeLog entry. 
1947         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
1948         for more details on how ChangeLog entries are affected.
1949
1950         * Scripts/prepare-ChangeLog:
1951         (get_function_line_ranges_for_cpp): 
1952         (delete_namespaces_from_ranges_for_cpp): Added.
1953         (is_function_in_namespace): Added.
1954         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
1955         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
1956
1957 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
1958
1959         Cleanup AudioSourceNode.idl from WebKit build.
1960         https://bugs.webkit.org/show_bug.cgi?id=116905.
1961
1962         Reviewed by Darin Adler.
1963
1964         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
1965         AudioNode is inherited directly in all the audio source nodes.
1966
1967         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1968
1969 2013-05-29  Andrew Lo  <anlo@rim.com>
1970
1971         Add Andrew Lo to contributors.json
1972         https://bugs.webkit.org/show_bug.cgi?id=116981
1973
1974         Reviewed by Rob Buis.
1975
1976         Adding Andrew Lo to contributors.json.
1977
1978         * Scripts/webkitpy/common/config/contributors.json:
1979
1980 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1981
1982         Unreviewed. Adding myself as a committer.
1983
1984         * Scripts/webkitpy/common/config/contributors.json:
1985
1986 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
1987
1988         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
1989         https://bugs.webkit.org/show_bug.cgi?id=116683
1990
1991         Reviewed by Noam Rosenthal.
1992
1993         A coordinates conversion test for WKViewUserViewportToContents was
1994         added to WebKit2 API tests.
1995
1996         * TestWebKitAPI/PlatformEfl.cmake:
1997         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
1998         (TestWebKitAPI):
1999         (TestWebKitAPI::TEST):
2000
2001 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
2002
2003         Unreviewed. Update my info.
2004
2005         * Scripts/webkitpy/common/config/contributors.json:
2006
2007 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
2008
2009         Unreviewed. Add myself as committer in contributors.json.
2010
2011         * Scripts/webkitpy/common/config/contributors.json:
2012
2013 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2014
2015         Unreviewed. Fix make distcheck.
2016
2017         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
2018         DISTCLEANFILES.
2019
2020 2013-05-29  Mary Wu  <mawu@blackberry.com>
2021
2022         Unreviewed: update my email address in contributors.json.
2023
2024         * Scripts/webkitpy/common/config/contributors.json:
2025
2026 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
2027
2028         Unreviewed: Adding myself to committers list.
2029
2030         * Scripts/webkitpy/common/config/contributors.json:
2031
2032 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
2033
2034         Unreviewed: Adding myself to committers list.
2035
2036         * Scripts/webkitpy/common/config/contributors.json:
2037
2038 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
2039
2040         [Windows] Many CSS2.1 tests fail under NRWT.
2041         https://bugs.webkit.org/show_bug.cgi?id=75707
2042
2043         Reviewed by Darin Adler.
2044
2045         * DumpRenderTree/win/DumpRenderTree.cpp:
2046         (findFontFallback): Added
2047         (addFontFallbackIfPresent): Added
2048         (removeFontFallbackIfPresent): Added
2049         (runTest): Set up/remove font fallbacks when needed.
2050
2051 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
2052
2053         [Windows] NRWT reports failure for 'mac' test cases.
2054         https://bugs.webkit.org/show_bug.cgi?id=116698
2055
2056         Reviewed by Ryosuke Niwa.
2057
2058         The Windows port falls back to the Mac port for many test results,
2059         and so adds the mac and mac-wk2 to its set of fallbacks.
2060         Unfortunately, NRWT thinks that this means that tests in these
2061         folders should be executed, resulting in many failures on
2062         Windows.
2063
2064         This change overloads the '_tests_for_other_platforms' method
2065         to return a subset of the result fallback list so that we do
2066         not attempt to execute Mac tests on Windows.
2067
2068         * Scripts/webkitpy/port/base.py:
2069         (Port.test_search_path): Added. Defaults to just calling the
2070         baseline_search_path method, which is how most ports behave.
2071         (Port._test_for_other_platforms): Modified to call the new
2072         test_search_path method.
2073
2074         * Scripts/webkitpy/port/win.py:
2075         (WinPort.test_search_path): Added custom overload. Strips
2076         out mac-specific test paths.
2077
2078 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
2079
2080         Fix GTK+ CMake build
2081
2082         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
2083         library target is simply "WebKit2."
2084
2085 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
2086
2087         [webkitpy] Explicitly specify the reference file extensions
2088         https://bugs.webkit.org/show_bug.cgi?id=116333
2089
2090         Reviewed by Benjamin Poulain.
2091
2092         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
2093         between valid reference files required by reftests and text baselines that have the same extension as
2094         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
2095         that were until this change recognized as reference files).
2096
2097         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
2098
2099         * Scripts/webkitpy/port/base.py:
2100         (Port.reference_files): Iterate through the _supported_reference_extensions set.
2101         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
2102         _supported_reference_extensions set, containing the extensions allowed for reference files.
2103         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
2104         (Port._has_supported_extension): Use _supported_test_extensions.
2105         * Scripts/webkitpy/port/base_unittest.py:
2106         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
2107         Port.is_reference_html_file method.
2108
2109 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
2110
2111         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
2112
2113         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2114         (NewCommitBot.next_work_item):
2115
2116 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
2117
2118         WKR and webkitbot build fixes.
2119
2120         * Scripts/webkitpy/tool/bot/irc_command.py:
2121         (RollChromiumDEPS.execute):
2122         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2123         (NewCommitBot.next_work_item):
2124
2125 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
2126
2127         roll-chromium-deps doesn't repeat the full name.
2128
2129         Rubber-stamped by Andreas Kling.
2130
2131         * Scripts/webkitpy/tool/bot/irc_command.py:
2132         (RollChromiumDEPS.execute):
2133
2134 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
2135
2136         Revert another erroneous change.
2137
2138         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2139         (NewCommitBot.next_work_item):
2140
2141 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
2142
2143         Revert an erroneous change.
2144
2145         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2146         (SheriffBot):
2147
2148 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
2149
2150         Some build fixes for WKR and webkitbot.
2151
2152         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2153         (IRCBotTest.test_help):
2154         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2155         (Agent):
2156         (Agent.__init__):
2157         (Agent.name):
2158         (NewCommitBot):
2159         (NewCommitBot.begin_work_queue):
2160         (NewCommitBot.next_work_item):
2161         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2162         (SheriffBot):
2163
2164 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
2165
2166         Teach webkitbot and WKR how to respond to yt?
2167         https://bugs.webkit.org/show_bug.cgi?id=116775
2168
2169         Reviewed by Andreas Kling.
2170
2171         * Scripts/webkitpy/tool/bot/irc_command.py:
2172         (Hi): Fixed the usage string.
2173         (Hi.execute): Made it more generic so that it works in WKR.
2174         (YouThere): Added.
2175         (YouThere.execute): Added.
2176         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2177
2178 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
2179
2180         Try to fix the EFL build.
2181         
2182         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2183         (TestRunner::setPageVisibility):
2184
2185 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
2186
2187         Unprefix Page Visibility API
2188         https://bugs.webkit.org/show_bug.cgi?id=102340
2189
2190         Reviewed by Tim Horton.
2191         
2192         Rename "preview" state to "unloaded" state, and adjust the tests
2193         to test for it.
2194
2195         * DumpRenderTree/mac/TestRunnerMac.mm:
2196         (TestRunner::setPageVisibility):
2197         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
2198         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
2199         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
2200         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
2201         (TestWebKitAPI::didRunStep4InStateUnloaded):
2202         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
2203         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2204         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
2205         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2206         (WTR::TestRunner::setPageVisibility):
2207
2208 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
2209
2210         Unreviewed build fix. Don't use new NRWT logic needed
2211         by Windows yet. Activate (and fix test) when we cut over.
2212
2213         * Scripts/webkitpy/port/driver.py:
2214         (Driver._setup_environ_for_driver):
2215         (Driver._start):
2216
2217 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
2218
2219         [Windows] Expose database storage and cache locations via preferences.
2220         https://bugs.webkit.org/show_bug.cgi?id=116729
2221
2222         Reviewed by Tim Horton.
2223
2224         Update DumpRenderTree to use CFPreferences to control where WebKit
2225         stores its local databases, URL caches, etc.
2226
2227         * DumpRenderTree/win/DumpRenderTree.cpp:
2228         (libraryPathForDumpRenderTree): Added.
2229         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
2230         * Scripts/webkitpy/port/base.py:
2231         (Port._driver_tempdir): Added (to allow port-specific overload).
2232         (Port._driver_tempdir_for_environment): Ditto
2233         * Scripts/webkitpy/port/driver.py:
2234         (Driver._setup_environ_for_driver): Use new overload to set
2235         environment variable.
2236         (Driver._start): Use new overload for temp directory location.
2237         * Scripts/webkitpy/port/win.py:
2238         (WinPort._driver_tempdir_for_environment): New overload to supply
2239         Windows path to DumpRenderTree environment (while still using
2240         cygwin paths for internal operations.
2241
2242 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2243
2244         Remove custom code for webkitAudioContext global constructor getter
2245         https://bugs.webkit.org/show_bug.cgi?id=116530
2246
2247         Reviewed by Geoffrey Garen.
2248
2249         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
2250         WebAudio feature instead of public ewk_view API since that API was
2251         removed.
2252
2253         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2254         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2255         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2256         (TestRunner::overridePreference):
2257
2258 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
2259
2260         Make team.html have each contributor's area of expertise
2261         https://bugs.webkit.org/show_bug.cgi?id=116737
2262
2263         Reviewed by Benjamin Poulain.
2264
2265         * Scripts/webkitpy/common/config/contributors.json:
2266         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
2267         
2268         Changed formatting of the file because the lines are getting way to
2269         long, and I generated this, so it's easier if the formatting of the
2270         file is regular.
2271
2272 2013-05-24  Simon Pena  <simon.pena@samsung.com>
2273
2274         Update WTF::Vector pretty printers
2275         https://bugs.webkit.org/show_bug.cgi?id=116719
2276
2277         Reviewed by Anders Carlsson.
2278
2279         After r148891, WTF::Vector pretty printers were left outdated, as
2280         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
2281         one as a member. This patch updates the pretty printers so they work
2282         again. 
2283
2284         * gdb/webkit.py:
2285         (WTFVectorPrinter.children):
2286         (WTFVectorPrinter.to_string):
2287
2288 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
2289
2290         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
2291         https://bugs.webkit.org/show_bug.cgi?id=116710
2292
2293         Reviewed by Mark Rowe.
2294
2295         * DumpRenderTree/mac/DumpRenderTree.mm:
2296         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
2297
2298 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
2299
2300         Add missing dependencies to deps script.
2301
2302         [GTK] Missing packages in install-dependencies script.
2303         https://bugs.webkit.org/show_bug.cgi?id=116632
2304
2305         Reviewed by Martin Robinson.
2306
2307         * gtk/install-dependencies:
2308
2309 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
2310
2311         [Windows] Unreviewed change for NRWT support.
2312
2313         * Scripts/webkitpy/port/win.py:
2314         (WinPort.default_child_processes): Added a default implementation
2315         that limits NRWT to a single instance.
2316
2317 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
2318
2319         Remove meaningless "test_uses_apache" from Python test cases.
2320         https://bugs.webkit.org/show_bug.cgi?id=38756
2321
2322         Reviewed by Ryosuke Niwa.
2323
2324         * Scripts/webkitpy/port/port_testcase.py:
2325         (PortTestCase.test_driver_cmd_line): Remove the meaningless
2326         "test_uses_apache" test case from the Python test infrastructure.
2327         It was hard-coded to true, even though not all ports use
2328         Apache.
2329
2330 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
2331
2332         [Windows] Update new-run-webkit-tests for Windows port.
2333         https://bugs.webkit.org/show_bug.cgi?id=38756
2334
2335         Reviewed by Ryosuke Niwa.
2336
2337         * Scripts/new-run-webkit-httpd:
2338         (run): Switch from 'chromium' to 'win'
2339         * Scripts/webkitpy/port/win.py:
2340         (WinPort): Add support methods for lighttpd server.
2341         (WinPort._uses_apache):
2342         (WinPort._path_to_lighttpd):
2343         (WinPort._path_to_lighttpd_modules):
2344         (WinPort._path_to_lighttpd_php):
2345
2346 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
2347
2348         Make default bug links in buildbot clickable
2349         https://bugs.webkit.org/show_bug.cgi?id=116673
2350
2351         Reviewed by Ryosuke Niwa.
2352
2353         Use changecommentlink of html.WebStatus to make the links clickable.
2354
2355         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2356
2357 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
2358
2359         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
2360         https://bugs.webkit.org/show_bug.cgi?id=116595
2361
2362         Temporarily skip this test.
2363
2364         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
2365         (TestWebKitAPI::TEST):
2366
2367 2013-05-22  Alex Christensen  <achristensen@apple.com>
2368
2369         Unreviewed.  Added myself to contributors.json.
2370
2371         * Scripts/webkitpy/common/config/contributors.json:
2372         Added myself.
2373
2374 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2375
2376         [EFL][WK2] Add sub menus to MiniBrowser
2377         https://bugs.webkit.org/show_bug.cgi?id=114728
2378
2379         Reviewed by Christophe Dumez.
2380
2381         Elementary Ctxpopup widget API does not provide support for submenu item.
2382         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
2383         Elementary Menu widget.
2384
2385         * MiniBrowser/efl/main.c:
2386         (_Browser_Window):
2387         (on_window_resize):
2388         (window_free):
2389         (context_menu_item_selected_cb):
2390         (context_menu_populate):
2391         (on_context_menu_show):
2392         (on_context_menu_hide):
2393         (window_create):
2394
2395 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
2396
2397         [EFL] Add command line option to MiniBrowser to set cookies policy.
2398         https://bugs.webkit.org/show_bug.cgi?id=115028
2399
2400         Reviewed by Christophe Dumez.
2401
2402         Add command line option to MiniBrowser EFL to set cookies policy:
2403         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
2404         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
2405
2406         * MiniBrowser/efl/main.c:
2407         (elm_main):
2408
2409 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2410
2411         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
2412         https://bugs.webkit.org/show_bug.cgi?id=116585
2413
2414         Reviewed by Alexey Proskuryakov.
2415
2416         willLoadURLRequest and willLoadDataRequest require the API version 6.
2417
2418         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2419
2420 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2421
2422         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
2423         https://bugs.webkit.org/show_bug.cgi?id=116516
2424
2425         Reviewed by Alexey Proskuryakov.
2426
2427         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
2428
2429         * DumpRenderTree/mac/DumpRenderTree.mm:
2430         (createWebViewAndOffscreenWindow): Match the ordering.
2431         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
2432
2433 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
2434
2435         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
2436         https://bugs.webkit.org/show_bug.cgi?id=116568
2437
2438         Reviewed by Anders Carlsson.
2439
2440         * WebKitTestRunner/WebNotificationProvider.cpp:
2441         (WTR::WebNotificationProvider::~WebNotificationProvider):
2442         * WebKitTestRunner/WebNotificationProvider.h:
2443         When the provider is destroyed, it should no longer be registered with the manager.
2444
2445         * WebKitTestRunner/GeolocationProviderMock.cpp:
2446         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
2447         * WebKitTestRunner/GeolocationProviderMock.h:
2448         I wasn't seeing a crash here, but this code has the same issue as notification
2449         provider, so applying the same fix.
2450
2451         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
2452         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
2453         destructor having fixed the above.
2454
2455 2013-05-21  Commit Queue  <commit-queue@webkit.org>
2456
2457         Unreviewed, rolling out r150386 and r150397.
2458         http://trac.webkit.org/changeset/150386
2459         http://trac.webkit.org/changeset/150397
2460         https://bugs.webkit.org/show_bug.cgi?id=116572
2461
2462         Broke a test; Alex is going to try again later. (Requested by
2463         thorton on #webkit).
2464
2465         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2466         (WTR::pathSuitableForTestResult):
2467         (WTR::dumpRequestDescriptionSuitableForTestResult):
2468         (WTR::dumpResponseDescriptionSuitableForTestResult):
2469         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
2470         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2471         (WTR::InjectedBundlePage::willSendRequestForFrame):
2472         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2473         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2474         (InjectedBundlePage):
2475
2476 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2477
2478         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
2479
2480         * Scripts/webkitpy/tool/commands/suggestnominations.py:
2481         (AbstractCommitLogCommand._recent_commit_messages):
2482
2483 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
2484
2485         [GTK] [CMake] Add support for building WebKit2
2486         https://bugs.webkit.org/show_bug.cgi?id=116372
2487
2488         Reviewed by Gustavo Noronha Silva.
2489
2490         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
2491         * MiniBrowser/gtk/CMakeLists.txt: Added.
2492
2493 2013-05-21  Jessie Berlin  <jberlin@apple.com>
2494
2495         Revert r149635, it was too optimistic.
2496
2497         Rubber-stamped by Andreas Kling.
2498
2499         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
2500         #ifdefs in WebCore code outside of WebCore/platform.
2501
2502         * Scripts/webkitpy/style/checkers/cpp.py:
2503         (check_invalid_increment):
2504         (process_line):
2505         (CppChecker):
2506         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2507         (CppStyleTest.test_plain_integral_bitfields):
2508
2509 2013-05-21  Jer Noble  <jer.noble@apple.com>
2510
2511         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
2512
2513         * lldb/lldb_webkit.py:
2514         (WTFVectorProvider.num_children):
2515         (WTFVectorProvider.get_child_index):
2516         (WTFVectorProvider.get_child_at_index):
2517         (WTFVectorProvider.update):
2518
2519 2013-05-21  Jessie Berlin  <jberlin@apple.com>
2520
2521         Expose a way to know when forms are added to a page or when form controls are added to a form
2522         in the injected bundle
2523         https://bugs.webkit.org/show_bug.cgi?id=116334
2524
2525         Reviewed by Alexey Proskuryakov.
2526
2527         Add tests for the new callbacks.
2528
2529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2530         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
2531
2532         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
2533         (TestWebKitAPI::nullJavaScriptCallback):
2534         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
2535         being passed in for the callback.
2536         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2537         After receiving the message that didAssociateFormControls callback was invoked from adding
2538         the form in the onload handler, tell the page to add a password field to the form, which
2539         should also invoke didAssociateFormControls callback.
2540         (TestWebKitAPI::setInjectedBundleClient):
2541         Register to receive messages.
2542         (TestWebKitAPI::TEST):
2543         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
2544         been invoked for both adding the form and for adding a password field to the form.
2545
2546         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
2547         (TestWebKitAPI::shouldNotifyOnFormChanges):
2548         Return true so the didAssociateFormControls callback is invoked.
2549         (TestWebKitAPI::didAssociateFormControls):
2550         Tell the UI process.
2551         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
2552         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
2553         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
2554
2555         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
2556         Add a form in response to the onload event. Add a button that will add the password field
2557         for manual testing.
2558
2559 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
2560
2561         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
2562         https://bugs.webkit.org/show_bug.cgi?id=106341
2563
2564         Reviewed by Martin Robinson.
2565
2566         Adds support for retrieving accessibility element at exact point.
2567
2568         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2569         (WTR::AccessibilityUIElement::elementAtPoint):
2570
2571 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
2572
2573         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
2574         https://bugs.webkit.org/show_bug.cgi?id=112913
2575
2576         Reviewed by Martin Robinson.
2577
2578         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
2579         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
2580         so the leak appears.
2581
2582         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2583         (WTR):
2584         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2585         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2586         (WTR::AccessibilityController::rootElement):
2587         (WTR):
2588         (WTR::AccessibilityController::focusedElement):
2589         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2590         (WTR::checkElementState):
2591         (WTR::indexRangeInTable):
2592         (WTR::alterCurrentValue):
2593         (WTR::AccessibilityUIElement::getChildren):
2594         (WTR::AccessibilityUIElement::getChildrenWithRange):
2595         (WTR::AccessibilityUIElement::childrenCount):
2596         (WTR::AccessibilityUIElement::indexOfChild):
2597         (WTR::AccessibilityUIElement::titleUIElement):
2598         (WTR::AccessibilityUIElement::parentElement):
2599         (WTR::AccessibilityUIElement::allAttributes):
2600         (WTR::AccessibilityUIElement::role):
2601         (WTR::AccessibilityUIElement::title):
2602         (WTR::AccessibilityUIElement::description):
2603         (WTR::AccessibilityUIElement::orientation):
2604         (WTR::AccessibilityUIElement::stringValue):
2605         (WTR::AccessibilityUIElement::language):
2606         (WTR::AccessibilityUIElement::x):
2607         (WTR::AccessibilityUIElement::y):
2608         (WTR::AccessibilityUIElement::width):
2609         (WTR::AccessibilityUIElement::height):
2610         (WTR::AccessibilityUIElement::intValue):
2611         (WTR::AccessibilityUIElement::minValue):
2612         (WTR::AccessibilityUIElement::maxValue):
2613         (WTR::AccessibilityUIElement::isEnabled):
2614         (WTR::AccessibilityUIElement::isFocused):
2615         (WTR::AccessibilityUIElement::isSelected):
2616         (WTR::AccessibilityUIElement::isExpanded):
2617         (WTR::AccessibilityUIElement::isChecked):
2618         (WTR::AccessibilityUIElement::rowCount):
2619         (WTR::AccessibilityUIElement::columnCount):
2620         (WTR::AccessibilityUIElement::rowIndexRange):
2621         (WTR::AccessibilityUIElement::columnIndexRange):
2622         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2623         (WTR::AccessibilityUIElement::increment):
2624         (WTR::AccessibilityUIElement::decrement):
2625         (WTR::AccessibilityUIElement::press):
2626         (WTR::AccessibilityUIElement::documentEncoding):
2627         (WTR::AccessibilityUIElement::documentURI):
2628         (WTR::AccessibilityUIElement::isFocusable):
2629         (WTR::AccessibilityUIElement::isSelectable):
2630         (WTR::AccessibilityUIElement::isMultiSelectable):
2631         (WTR::AccessibilityUIElement::isVisible):
2632
2633 2013-05-20  Lucas Forschler  <lforschler@apple.com>
2634
2635     Rollout 150398.
2636     
2637 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
2638
2639         [GTK] Fix concatenations of string literals that are not C++11-compliant
2640         https://bugs.webkit.org/show_bug.cgi?id=116449
2641
2642         Reviewed by Martin Robinson.
2643
2644         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
2645         is simply a matter of separating the string and the string literal that are being concatenated with a space.
2646
2647         * ImageDiff/gtk/ImageDiff.cpp:
2648         (printImage):
2649
2650 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
2651
2652         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
2653         https://bugs.webkit.org/show_bug.cgi?id=116450
2654
2655         Reviewed by Martin Robinson.
2656
2657         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
2658         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
2659         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
2660         TestWebKitAPI programs when compiling them.
2661
2662         * TestWebKitAPI/GNUmakefile.am:
2663
2664 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
2665
2666         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
2667         https://bugs.webkit.org/show_bug.cgi?id=116492
2668
2669         Reviewed by Dirk Pranke.
2670
2671         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
2672
2673         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
2674         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
2675         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
2676         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
2677         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
2678         to memory pressure on the machine.
2679
2680         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
2681         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
2682         for a subsequent patch just to make things easier to follow.
2683
2684         * Scripts/webkitpy/port/driver.py:
2685         (DriverProxy.__init__):
2686         (DriverProxy.run_test):
2687         (DriverProxy.has_crashed):
2688         (DriverProxy.stop):
2689
2690 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2691
2692         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
2693         https://bugs.webkit.org/show_bug.cgi?id=116423
2694
2695         Reviewed by Ryosuke Niwa.
2696
2697         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
2698
2699         * BuildSlaveSupport/build.webkit.org-config/config.json:
2700
2701 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
2702
2703         Remove remaining link-prerender code
2704         https://bugs.webkit.org/show_bug.cgi?id=116429
2705
2706         Reviewed by Darin Adler.
2707
2708         Link prerendering code was removed in r150356.
2709
2710         * Scripts/webkitperl/FeatureList.pm:
2711         * qmake/mkspecs/features/features.pri:
2712
2713 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
2714
2715         commit-queue should check for oops in changelog entries
2716         https://bugs.webkit.org/show_bug.cgi?id=116395
2717
2718         Reviewed by Martin Robinson.
2719
2720         Make changelog validation fail when it contains oops!.
2721
2722         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2723         (CommitQueueTask._validate_changelog):
2724         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2725         (CommitQueueTaskTest._run_through_task):
2726         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2727         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2728         (ValidateChangeLogs.options):
2729         (ValidateChangeLogs._check_changelog_diff):
2730         (ValidateChangeLogs._changelog_contains_oops):
2731         (ValidateChangeLogs.run):
2732         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2733         (ValidateChangeLogsTest._assert_start_line_produces_output):
2734         (ValidateChangeLogsTest.test_check_changelog_diff):
2735         (ValidateChangeLogsTest):
2736         (ValidateChangeLogsTest.test_changelog_contains_oops):
2737
2738 2013-05-20  Jessie Berlin  <jberlin@apple.com>
2739
2740         Expose a way to know when forms are added to a page or when form controls are added to a form
2741         in the injected bundle
2742         https://bugs.webkit.org/show_bug.cgi?id=116334
2743
2744         Reviewed by Alexey Proskuryakov.
2745
2746         Add tests for the new callbacks.
2747
2748         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2749         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
2750
2751         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
2752         (TestWebKitAPI::nullJavaScriptCallback):
2753         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
2754         being passed in for the callback.
2755         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2756         After receiving the message that didAssociateFormControls callback was invoked from adding
2757         the form in the onload handler, tell the page to add a password field to the form, which
2758         should also invoke didAssociateFormControls callback.
2759         (TestWebKitAPI::setInjectedBundleClient):
2760         Register to receive messages.
2761         (TestWebKitAPI::TEST):
2762         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
2763         been invoked for both adding the form and for adding a password field to the form.
2764
2765         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
2766         (TestWebKitAPI::shouldNotifyOnFormChanges):
2767         Return true so the didAssociateFormControls callback is invoked.
2768         (TestWebKitAPI::didAssociateFormControls):
2769         Tell the UI process.
2770         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
2771         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
2772         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
2773
2774         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
2775         Add a form in response to the onload event. Add a button that will add the password field
2776         for manual testing.
2777
2778 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2779
2780         [EFL][JHBUILD] Make sure eet is built before evas
2781         https://bugs.webkit.org/show_bug.cgi?id=116440
2782
2783         Reviewed by Gyuyoung Kim.
2784
2785         Mark eet as a dependency of evas since evas requires eet to enable some of its
2786         functionality.
2787
2788         * efl/jhbuild.modules:
2789
2790 2013-05-20  Alex Christensen  <achristensen@apple.com>
2791
2792         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
2793         https://bugs.webkit.org/show_bug.cgi?id=116125
2794
2795         Reviewed by Tim Horton.
2796
2797         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2798         (WTR::pathSuitableForTestResult):
2799         Changed string operations to match _drt_descriptionSuitableForTestResult.
2800         (WTR::dumpRequestDescriptionSuitableForTestResult):
2801         (WTR::dumpResponseDescriptionSuitableForTestResult):
2802         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
2803         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2804         (WTR::InjectedBundlePage::willSendRequestForFrame):
2805         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2806         Pass the main frame's URL to pathSuitableForTestResult.
2807         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2808         Added WKBundlePageRef to willPerformClientRedirectForFrame.
2809
2810 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
2811
2812         fix w3c test importer unit tests after r150324
2813         https://bugs.webkit.org/show_bug.cgi?id=116459
2814
2815         Reviewed by Ryosuke Niwa.
2816
2817         This patch fixes the unit tests to not actually call out to
2818         'hg' (by using a mock executive) and also changes the real
2819         directory we crawl from Source/WebCore/css to
2820         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
2821         still change this to a mock filesystem, but that's a separate change.
2822
2823         * Scripts/webkitpy/w3c/test_importer.py:
2824         (main):
2825         (TestImporter.__init__):
2826         (TestImporter.load_changeset):
2827         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2828         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
2829         (TestImporterTest.test_import_dir_with_no_tests):
2830
2831 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2832
2833         Unreviewed EFL build fix.
2834
2835         Fix linking errors due to undefined symbols on Ubuntu 13.04.
2836
2837         * DumpRenderTree/efl/CMakeLists.txt:
2838         * EWebLauncher/CMakeLists.txt:
2839         * MiniBrowser/efl/CMakeLists.txt:
2840
2841 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2842
2843         [EFL] Reenabled INDEXED_DATABASE after r150344
2844         https://bugs.webkit.org/show_bug.cgi?id=116430
2845
2846         Reviewed by Gyuyoung Kim.
2847
2848         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
2849         build was fixed in r150344.
2850
2851         * Scripts/webkitperl/FeatureList.pm:
2852
2853 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
2854
2855         [EFL] init/shutdown should be paired in EWebLauncher
2856         https://bugs.webkit.org/show_bug.cgi?id=116427
2857
2858         Reviewed by Christophe Dumez.
2859
2860         Added ecore_file_shutdown() for cleanup of ecore_file.
2861         Removed edje_init and ecore_evas_init because it was in ewk_init().
2862
2863         * EWebLauncher/main.c:
2864         (main):
2865
2866 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
2867
2868         [EFL] Add command line option to MiniBrowser to set user agent
2869         https://bugs.webkit.org/show_bug.cgi?id=116387
2870
2871         Reviewed by Christophe Dumez.
2872
2873         We need this option to compare the rendering differences according to different user agents.
2874
2875         * MiniBrowser/efl/main.c:
2876         (window_create):
2877         (elm_main):
2878
2879 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
2880
2881         Unreviewed, addressing test-webkitpy failures after r150317.
2882
2883         * Scripts/webkitpy/w3c/test_converter.py:
2884         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
2885
2886 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
2887
2888         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
2889         https://bugs.webkit.org/show_bug.cgi?id=114554
2890
2891         Reviewed by Gyuyoung Kim.
2892
2893         Using variables as target names is very uncommon in CMake.
2894         The usual way to specify the name of the resulting binary
2895         is to set the OUTPUT_NAME target property.
2896
2897         * DumpRenderTree/efl/CMakeLists.txt:
2898         * EWebLauncher/CMakeLists.txt:
2899         * ImageDiff/CMakeLists.txt:
2900         * MiniBrowser/efl/CMakeLists.txt:
2901         * TestWebKitAPI/CMakeLists.txt:
2902         * WebKitTestRunner/CMakeLists.txt:
2903         * WebKitTestRunner/PlatformEfl.cmake:
2904         * WinCELauncher/CMakeLists.txt:
2905
2906 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2907
2908         Unreviewed EFL build fix.
2909
2910         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
2911         WK2 build after r150305.
2912
2913         * Scripts/webkitperl/FeatureList.pm:
2914
2915 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
2916
2917         [GTK] Parallel build fails if gtk-doc is enabled
2918         https://bugs.webkit.org/show_bug.cgi?id=116227
2919
2920         Reviewed by Martin Robinson.
2921
2922         * GNUmakefile.am:
2923         Don't use the 'all' target to generate the documentation.
2924         The prerequisites of this target must be files that need to be
2925         built _before_ the actual compilation of WebKit starts. Since the
2926         documentation depends on WebKit being built first, this means in
2927         practice that the code will be built in parallel with the
2928         generation of its dependencies, potentially making the build fail.
2929
2930 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2931
2932         Don't run hg.
2933
2934         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2935         (TestImporterTest):
2936
2937 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
2938
2939         Create a script to import W3C tests
2940         https://bugs.webkit.org/show_bug.cgi?id=111513
2941
2942         Reviewed by Ryosuke Niwa.
2943
2944         This patch attempts to re-land the 'import-w3c-tests'
2945         script and accompanying modules.  The tests and code have
2946         been cleaned up so that we do not log anything to stdout/stderr
2947         while running the tests (thanks to outputcapture) and do not
2948         write into the source tree while running the tests, and much
2949         but not all of the code has been converted over to using the webkitpy
2950
2951         * Scripts/import-w3c-tests: Added.
2952         * Scripts/webkitpy/w3c/__init__.py: Added.
2953         * Scripts/webkitpy/w3c/test_converter.py: Added.
2954         (W3CTestConverter):
2955         (W3CTestConverter.__init__):
2956         (W3CTestConverter.path_from_webkit_root):
2957         (W3CTestConverter.read_webkit_prefixed_css_property_list):
2958         (W3CTestConverter.convert_for_webkit):
2959         (W3CTestConverter.convert_css):
2960         (W3CTestConverter.convert_html):
2961         (W3CTestConverter.convert_testharness_paths):
2962         (W3CTestConverter.convert_prefixed_properties):
2963         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2964         (W3CTestConverter.replace_tag):
2965         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2966         (W3CTestConverterTest):
2967         (W3CTestConverterTest.fake_dir_path):
2968         (W3CTestConverterTest.test_read_prefixed_property_list):
2969         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
2970         (test_convert_for_webkit_harness_only):
2971         (test_convert_for_webkit_properties_only):
2972         (test_convert_for_webkit_harness_and_properties):
2973         (test_convert_test_harness_paths):
2974         (test_convert_prefixed_properties):
2975         (verify_conversion_happened):
2976         (verify_no_conversion_happened):
2977         (verify_test_harness_paths):
2978         (verify_prefixed_properties):
2979         (generate_test_content):
2980         * Scripts/webkitpy/w3c/test_importer.py: Added.
2981         (main):
2982         (parse_args):
2983         (validate_import_directory):
2984         (TestImporter):
2985         (TestImporter.__init__):
2986         (TestImporter.path_from_webkit_root):
2987         (TestImporter.do_import):
2988         (TestImporter.load_changeset):
2989         (TestImporter.find_importable_tests):
2990         (TestImporter.import_tests):
2991         (TestImporter.setup_destination_directory):
2992         (TestImporter.update_test_status):
2993         (TestImporter.remove_deleted_files):
2994         (TestImporter.write_import_log):
2995         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2996         (TestImporterTest):
2997         (TestImporterTest.test_import_dir_with_no_tests):
2998         * Scripts/webkitpy/w3c/test_parser.py: Added.
2999         (TestParser):
3000         (TestParser.__init__):
3001         (TestParser.load_file):
3002         (TestParser.analyze_test):
3003         (TestParser.reference_links_of_type):
3004         (TestParser.is_jstest):
3005         (TestParser.support_files):
3006         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
3007         (TestParserTest):
3008         (TestParserTest.test_analyze_test_reftest_one_match):
3009         (test_analyze_test_reftest_multiple_matches):
3010         (test_analyze_test_reftest_match_and_mismatch):
3011         (test_analyze_test_reftest_with_ref_support_Files):
3012         (test_analyze_jstest):
3013         (test_analyze_pixel_test_all_true):
3014         (test_analyze_pixel_test_all_false):
3015         (test_analyze_non_html_file):
3016
3017 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
3018
3019         Leaks builders exit early frequently
3020         https://bugs.webkit.org/show_bug.cgi?id=116355
3021
3022         Reviewed by Stephanie Lewis.
3023
3024         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
3025         we tolerate from 20 to 50.
3026
3027         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3028         (RunWebKitTests.start):
3029         * Scripts/webkitpy/port/mac.py:
3030         (MacPort.default_child_processes):
3031
3032 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
3033
3034         Remove chrome-channels command from the webkit-patch
3035         https://bugs.webkit.org/show_bug.cgi?id=116303
3036
3037         Reviewed by Ryosuke Niwa.
3038
3039         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
3040         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
3041         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
3042         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
3043         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
3044         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
3045
3046 2013-05-17  David Kilzer  <ddkilzer@apple.com>
3047
3048         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
3049         Part 3 of 3: <http://webkit.org/b/116247>
3050
3051         Reviewed by Benjamin Poulain.
3052
3053         * Scripts/filter-build-webkit: Change while() loop to for() loop
3054         to track $previousLine, then pass $previousLine into
3055         shouldIgnoreLine().
3056         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
3057         line that begins with four spaces if the previous line is a
3058         linker error message.
3059         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3060         - Add "Ignored: " to test descriptions to document expected
3061           behavior.
3062         - Add comment blocks for various groups of tests.
3063         - Expand "Build settings" tests since we're changing the code in
3064           shouldIgnoreLine() that ignores those lines.
3065         - Add tests for undefined symbols error message.
3066         (description): Add.  Extract from global code.
3067
3068 2013-05-17  David Kilzer  <ddkilzer@apple.com>
3069
3070         Add tests for shouldIgnoreLine() in filter-build-webkit
3071         Part 2 of 3: <http://webkit.org/b/116247>
3072
3073         Reviewed by Benjamin Poulain.
3074
3075         * Scripts/filter-build-webkit:
3076         (shouldIgnoreLine): Add.  Extract code from global scope into
3077         subroutine to make it testable.
3078         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
3079         Tests shouldIgnoreLine() using output from a real build
3080         transcript.
3081
3082 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
3083
3084         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
3085         https://bugs.webkit.org/show_bug.cgi?id=116341
3086
3087         Reviewed by Brady Eidson.
3088
3089         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3090
3091 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
3092
3093         [Windows] Don't use pdevenv when building with VS2010.
3094         https://bugs.webkit.org/show_bug.cgi?id=116338.
3095
3096         Reviewed by Adam Roben.
3097
3098         * Scripts/webkitdirs.pm:
3099         (setupCygwinEnv): Check if we are using VS2005, and only use
3100         the 'pdevenv' hack if we are. Otherwise, just build with
3101         our standard project since it uses VS2010+'s native
3102         parallel building features.
3103
3104 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3105
3106         Unreviewed. Disable accelerated compositing until we figure out why it does not work
3107         properly in the 64 bits release bot.
3108
3109         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3110         (resetDefaultsToConsistentValues):
3111
3112 2013-05-17  David Kilzer  <ddkilzer@apple.com>
3113
3114         Make filter-build-webkit testable using LoadAsModule
3115         Part 1 of 3: <http://webkit.org/b/116247>
3116
3117         Reviewed by Benjamin Poulain.
3118
3119         * Scripts/filter-build-webkit: Change global variables that are
3120         used in subroutines from 'my' to 'our' to make it possible to
3121         evaluate the script in a package context in LoadAsModule.pm.
3122
3123 2013-05-14  Sam Weinig  <sam@webkit.org>
3124
3125         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
3126         https://bugs.webkit.org/show_bug.cgi?id=116132
3127
3128         Reviewed by Anders Carlsson.
3129
3130         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
3131         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
3132
3133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3134         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
3135         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
3136         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3137
3138 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
3139
3140         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
3141         https://bugs.webkit.org/show_bug.cgi?id=114781
3142
3143         Reviewed by Christophe Dumez.
3144
3145         Add run_before_unload_confirm and
3146         Print the log message with "CONFIRM NAVIGATION: " in console.
3147
3148         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3149         (onBeforeUnloadConfirm):
3150         (drtViewAdd):
3151
3152 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
3153
3154         Fix Analyze ChangeLog's entry processing
3155         https://bugs.webkit.org/show_bug.cgi?id=116219
3156
3157         Reviewed by Ryosuke Niwa.
3158
3159         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
3160         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
3161
3162 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
3163
3164         [Qt] UrlLoader::loadNext is broken in MiniBrowser
3165         https://bugs.webkit.org/show_bug.cgi?id=116099
3166
3167         Reviewed by Jocelyn Turcotte.
3168
3169         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
3170         are not available any more. So, UrlLoader::loadNext was broken
3171         because it failed to connect to those signals.
3172
3173         * MiniBrowser/qt/UrlLoader.cpp:
3174         (UrlLoader::UrlLoader):
3175         (UrlLoader::loadingChanged):
3176         * MiniBrowser/qt/UrlLoader.h:
3177         (UrlLoader):
3178
3179 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
3180
3181         [WebSocket] Update pywebsocket to r760
3182         https://bugs.webkit.org/show_bug.cgi?id=115863
3183
3184         Reviewed by Alexey Proskuryakov.
3185
3186         Version r760 supports a newer draft of message compression.
3187         We need this update to finish the permessage compression patch in
3188         bug 98840. This patch also fixes failing unit tests after the update.
3189
3190         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
3191         (StreamBase._read):
3192         (StreamBase._read.of):
3193         (StreamBase._write):
3194         (StreamBase.receive_bytes):
3195         (StreamBase._read_until):
3196         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
3197         (parse_frame):
3198         (StreamOptions.__init__):
3199         (Stream.__init__):
3200         (Stream._receive_frame_as_frame_object):
3201         (Stream._get_message_from_frame):
3202         (Stream._process_close_message):
3203         (Stream.close_connection):
3204         (Stream.get_last_received_opcode):
3205         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
3206         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
3207         (Dispatcher.do_extra_handshake):
3208         (Dispatcher.transfer_data):
3209         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
3210         (ExtensionProcessorInterface.__init__):
3211         (ExtensionProcessorInterface.request):
3212         (ExtensionProcessorInterface):
3213         (ExtensionProcessorInterface.name):
3214         (ExtensionProcessorInterface.check_consistency_with_other_processors):
3215         (ExtensionProcessorInterface.set_active):
3216         (ExtensionProcessorInterface.is_active):
3217         (ExtensionProcessorInterface._get_extension_response_internal):
3218         (ExtensionProcessorInterface.get_extension_response):
3219         (ExtensionProcessorInterface._setup_stream_options_internal):
3220         (ExtensionProcessorInterface.setup_stream_options):
3221         (_log_outgoing_compression_ratio):
3222         (_log_incoming_compression_ratio):
3223         (_parse_window_bits):
3224         (_AverageRatioCalculator):
3225         (_AverageRatioCalculator.__init__):
3226         (_AverageRatioCalculator.add_original_bytes):
3227         (_AverageRatioCalculator.add_result_bytes):
3228         (_AverageRatioCalculator.get_average_ratio):
3229         (DeflateFrameExtensionProcessor):
3230         (DeflateFrameExtensionProcessor.__init__):
3231         (DeflateFrameExtensionProcessor._get_extension_response_internal):
3232         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
3233         (DeflateFrameExtensionProcessor._outgoing_filter):
3234         (DeflateFrameExtensionProcessor._incoming_filter):
3235         (CompressionExtensionProcessorBase.for):
3236         (CompressionExtensionProcessorBase.__init__):
3237         (CompressionExtensionProcessorBase._get_extension_response_internal):
3238         (CompressionExtensionProcessorBase._setup_stream_options_internal):
3239         (PerFrameCompressExtensionProcessor):
3240         (PerMessageDeflateExtensionProcessor):
3241         (PerMessageDeflateExtensionProcessor.__init__):
3242         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
3243         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
3244         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
3245         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
3246         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
3247         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
3248         (PerMessageDeflateExtensionProcessor.set_bfinal):
3249         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
3250         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
3251         (_PerMessageDeflateFramer):
3252         (_PerMessageDeflateFramer.__init__):
3253         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
3254         (_PerMessageDeflateFramer._process_incoming_message):
3255         (_PerMessageDeflateFramer._process_outgoing_message):
3256         (_PerMessageDeflateFramer.setup_stream_options):
3257         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
3258         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
3259         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
3260         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
3261         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
3262         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
3263         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
3264         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
3265         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
3266         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
3267         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
3268         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
3269         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
3270         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
3271         (PerMessageCompressExtensionProcessor):
3272         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
3273         (MuxExtensionProcessor.__init__):
3274         (MuxExtensionProcessor.check_consistency_with_other_processors):
3275         (MuxExtensionProcessor):
3276         (MuxExtensionProcessor._get_extension_response_internal):
3277         (MuxExtensionProcessor._setup_stream_options_internal):
3278         (MuxExtensionProcessor.set_quota):
3279         (MuxExtensionProcessor.quota):
3280         (MuxExtensionProcessor.set_extensions):
3281         (MuxExtensionProcessor.extensions):
3282         (is_compression_extension):
3283         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
3284         (validate_subprotocol):
3285         (parse_host_header):
3286         (format_header):
3287         (check_request_line):
3288         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
3289         (Handshaker.do_handshake):
3290         (Handshaker._create_handshake_response):
3291         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
3292         (_validate_subprotocol):
3293         (_check_header_lines):
3294         (_build_location):
3295         (Handshaker.do_handshake):
3296         (Handshaker._set_subprotocol):
3297         (Handshaker._set_location):
3298         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
3299         (_create_dispatcher):
3300         (headerparserhandler):
3301         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
3302         (_create_add_channel_response):
3303         (_create_drop_channel):
3304         (_create_flow_control):
3305         (_create_new_channel_slot):
3306         (_create_fallback_new_channel_slot):
3307         (_MuxFramePayloadParser._read_number):
3308         (_MuxFramePayloadParser._read_size_and_contents):
3309         (_MuxFramePayloadParser._read_flow_control):
3310         (_MuxFramePayloadParser._read_new_channel_slot):
3311         (_LogicalConnection.__init__):
3312         (_LogicalConnection.write):
3313         (_LogicalConnection.on_write_data_done):
3314         (_LogicalConnection):
3315         (_LogicalConnection.on_writer_done):
3316         (_InnerMessage):
3317         (_InnerMessage.__init__):
3318         (_InnerMessageBuilder):
3319         (_InnerMessageBuilder.that):
3320         (_InnerMessageBuilder.__init__):
3321         (_InnerMessageBuilder._handle_first):
3322         (_InnerMessageBuilder._process_first_fragmented_control):
3323         (_InnerMessageBuilder._process_first_fragmented_message):
3324         (_InnerMessageBuilder._handle_fragmented_control):
3325         (_InnerMessageBuilder._reassemble_fragmented_control):
3326         (_InnerMessageBuilder._handle_fragmented_message):
3327         (_InnerMessageBuilder._reassemble_fragmented_message):
3328         (_InnerMessageBuilder.build):
3329         (_LogicalStream.__init__):
3330         (_LogicalStream._create_inner_frame):
3331         (_LogicalStream._write_inner_frame):
3332         (_LogicalStream.replenish_send_quota):
3333         (_LogicalStream.send_message):
3334         (_LogicalStream._receive_frame):
3335         (_LogicalStream._get_message_from_frame):
3336         (_LogicalStream.stop_sending):
3337         (_PhysicalConnectionWriter.__init__):
3338         (_PhysicalConnectionWriter._write_data):
3339         (_PhysicalConnectionWriter.run):
3340         (_PhysicalConnectionWriter.stop):
3341         (_Worker.run):
3342         (_MuxHandshaker.__init__):
3343         (_MuxHandshaker._create_stream):
3344         (_MuxHandshaker._create_handshake_response):
3345         (_HandshakeDeltaBase.create_headers):
3346         (_MuxHandler.start):
3347         (_MuxHandler.wait_until_done):
3348         (_MuxHandler.notify_write_data_done):
3349         (_MuxHandler._process_drop_channel):
3350         (_MuxHandler._process_logical_frame):
3351         (_MuxHandler.notify_reader_done):
3352         (_MuxHandler):
3353         (_MuxHandler.notify_writer_done):
3354         (_MuxHandler.fail_physical_connection):
3355         (_MuxHandler.fail_logical_channel):
3356         (use_mux):
3357         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
3358         (_StandaloneRequest.get_uri):
3359         (_StandaloneRequest.get_unparsed_uri):
3360         (_StandaloneRequest):
3361         (_StandaloneRequest.is_https):
3362         (_import_ssl):
3363         (_import_pyopenssl):
3364         (_StandaloneSSLConnection.for):
3365         (_StandaloneSSLConnection):
3366         (_StandaloneSSLConnection.__getattribute__):
3367         (_StandaloneSSLConnection.__setattr__):
3368         (_StandaloneSSLConnection.makefile):
3369         (_StandaloneSSLConnection.shutdown):
3370         (_StandaloneSSLConnection.recv):
3371         (WebSocketServer.__init__):
3372         (WebSocketServer._create_sockets):
3373         (WebSocketServer.handle_error):
3374         (WebSocketServer.get_request):
3375         (WebSocketServer.get_request.default_callback):
3376         (WebSocketRequestHandler.parse_request):
3377         (_build_option_parser):
3378         (_main):
3379         (_main.if):
3380         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
3381         (RepeatedXorMasker.__init__):
3382         (RepeatedXorMasker._mask_using_swig):
3383         (RepeatedXorMasker):
3384         (RepeatedXorMasker._mask_using_array):
3385         (_Deflater.compress_and_finish):
3386         (_RFC1979Deflater.filter):
3387         (DeflateSocket.send):
3388
3389 2013-05-16  Jonathan Liu  <net147@gmail.com>
3390
3391         Fix testing if program exists in PATH
3392         https://bugs.webkit.org/show_bug.cgi?id=116216
3393
3394         Reviewed by Jocelyn Turcotte.
3395
3396         functions.prf incorrectly uses win_cmd_shell to test whether to
3397         add .exe to the executable name when checking if it exists in
3398         the PATH environment variable. This works correctly when
3399         building using Windows Command Prompt but not under MSYS shell.
3400
3401         To resolve this, check the win32 platform scope instead of
3402         win_cmd_shell so that it correctly adds .exe to the executable
3403         name on Windows regardless of the shell used when testing if
3404         it exists in PATH.
3405
3406         * qmake/mkspecs/features/functions.prf:
3407
3408 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
3409
3410         Fix the hard-coded names of EWS bots that run tests.
3411
3412         * Scripts/webkitpy/tool/commands/queues.py:
3413         (CommitQueue.did_pass_testing_ews):
3414
3415 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3416
3417         [GTK] Build Xvfb with jhbuild
3418         https://bugs.webkit.org/show_bug.cgi?id=115907
3419
3420         Reviewed by Martin Robinson.
3421
3422         Build our own Xvfb so that we can avoid problems with the system Xvfb
3423         relying on symbols not present in our jhbuilt libraries such as pixman,
3424         and also to ensure we have the fix for a GLX module crasher.
3425
3426         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3427         (resetDefaultsToConsistentValues): enable accelerated compositing.
3428         * gtk/install-dependencies: list packages required for building Xvfb.
3429         * gtk/jhbuild.modules: add xserver as a jhbuild module.
3430         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
3431         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
3432         initializing the GLX module for Xvfb.
3433
3434 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3435
3436         [jhbuild] Should remove the sources directory as well when cleaning
3437         https://bugs.webkit.org/show_bug.cgi?id=116229
3438
3439         Reviewed by Martin Robinson.
3440
3441         * Scripts/update-webkit-libs-jhbuild:
3442         (cleanJhbuild): remove the Source directory as well when cleaning.
3443
3444 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
3445
3446         [EFL] Remove Intel Wk2 Buildbots from Master
3447         https://bugs.webkit.org/show_bug.cgi?id=116149
3448
3449         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
3450         since Gyuyoung Kim from Samsung plans to take over and maintain it.
3451
3452         Reviewed by Benjamin Poulain.
3453
3454         * BuildSlaveSupport/build.webkit.org-config/config.json:
3455
3456 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
3457
3458         [Windows] Update various build tools to understand VS2010 environment.
3459         https://bugs.webkit.org/show_bug.cgi?id=116169.
3460
3461         Reviewed by Anders Carlsson.
3462
3463         * Scripts/build-api-tests: Identify VS2010 environment.
3464         * Scripts/build-dumprendertree: Ditto.
3465         * Scripts/build-webkit: Ditto.
3466         * Scripts/webkitdirs.pm:
3467         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
3468         range of acceptable SDK's.
3469
3470 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
3471
3472         Allow http tests on Arch Linux
3473         https://bugs.webkit.org/show_bug.cgi?id=116155
3474
3475         Reviewed by Ryosuke Niwa.
3476
3477         * Scripts/webkitpy/port/base.py:
3478         (Port._is_arch_based): Added check for /etc/arch-release file.
3479         (Port._apache_config_file_name_for_platform): Call the check.
3480         * Scripts/webkitpy/port/port_testcase.py:
3481         (test_linux_distro_detection): Testcase added.
3482
3483 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
3484
3485         Remove a leftover v8 file from the watchlist
3486         https://bugs.webkit.org/show_bug.cgi?id=116158
3487
3488         Reviewed by Csaba Osztrogonác.
3489
3490         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
3491
3492 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
3493
3494         [GTK] Fails to build while generating gtkdoc
3495         https://bugs.webkit.org/show_bug.cgi?id=115612
3496
3497         Reviewed by Philippe Normand.
3498
3499         Fix typo in the prerequisites of docs-build.stamp.
3500
3501         * GNUmakefile.am:
3502
3503 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
3504
3505         Unreviewed, fixing the current test-webkitpy failure.
3506
3507         * Scripts/webkitpy/port/mac_unittest.py:
3508         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
3509         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
3510
3511 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
3512
3513         Fix build after r150090.
3514         https://bugs.webkit.org/show_bug.cgi?id=116129
3515
3516         Unreviewed build fix after r150090.
3517
3518         * WebKitTestRunner/TestInvocation.cpp:
3519         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3520
3521 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
3522
3523         [Windows, others] Unreviewed build fix after r150090.
3524
3525         * DumpRenderTree/TestRunner.cpp:
3526         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
3527         doesn't exist on other platforms.
3528
3529 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
3530
3531         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
3532         https://bugs.webkit.org/show_bug.cgi?id=115889
3533
3534         Reviewed by Benjamin Poulain.
3535
3536         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3537         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3538
3539 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
3540
3541         [Windows] Identify proper run environment for scripts.
3542         https://bugs.webkit.org/show_bug.cgi?id=116114
3543
3544         Reviewed by David Kilzer.
3545
3546         Determine (based on Visual Studio version) which path to use for
3547         executables (bin versus bin32).
3548
3549         * Scripts/webkitdirs.pm:
3550         (determineVisualStudioInstallDir): Added.
3551         (determineVisualStudioVersion): Added.
3552         (determineConfigurationProductDir): Modified to choose proper bin
3553         or bin32 directory.
3554         (visualStudioVersion): Added
3555         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
3556
3557 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
3558
3559         [Mac] Add tests for secure event input
3560         https://bugs.webkit.org/show_bug.cgi?id=116121
3561
3562         Reviewed by Mark Rowe.
3563
3564         * DumpRenderTree/TestRunner.cpp:
3565         (getSecureEventInputIsEnabledCallback):
3566         (TestRunner::staticValues):
3567         Expose an accessor for current secure event input state.
3568
3569         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3570         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3571         (WTR::TestRunner::secureEventInputIsEnabled):
3572         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3573         * WebKitTestRunner/TestInvocation.cpp:
3574         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3575         Expose an accessor for current secure event input state. This has to be done in
3576         UI process, as this is where it's changed by WebKit.
3577
3578 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
3579
3580         [Mac] Add a testing shim for secure event input functions
3581         https://bugs.webkit.org/show_bug.cgi?id=116122
3582
3583         Reviewed by Mark Rowe.
3584
3585         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
3586         Inject WebCore testing shim library to override system framework functions.
3587
3588 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
3589
3590         [Windows] Switch to embedded manifest commands for launcher executables.
3591         https://bugs.webkit.org/show_bug.cgi?id=116109
3592
3593         Reviewed by Darin Adler.
3594
3595         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
3596         now-unused WinLauncher.exe.manifest file.
3597         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
3598         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
3599         when building with VS2010 or newer.
3600
3601 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
3602
3603         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
3604         https://bugs.webkit.org/show_bug.cgi?id=116079
3605
3606         Reviewed by David Kilzer.
3607
3608         * Scripts/old-run-webkit-tests:
3609         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
3610
3611 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
3612
3613         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
3614         https://bugs.webkit.org/show_bug.cgi?id=115921
3615
3616         Reviewed by Gustavo Noronha Silva.
3617
3618         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
3619         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
3620
3621 2013-05-13  Alex Christensen  <achristensen@apple.com>
3622
3623         Added testRunner.setPrinting.
3624         https://bugs.webkit.org/show_bug.cgi?id=42693
3625         rdar://problem/8213845
3626
3627         Reviewed by Darin Adler.
3628
3629         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3630         Added setPrinting JavaScript function.
3631         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3632         (WTR::InjectedBundlePage::dump):
3633         Dump the external representation for printing if setPrinting has been called.
3634         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3635         (WTR::TestRunner::isPrinting): Added.
3636         (WTR::TestRunner::setPrinting): Added.
3637         Added and initialized m_isPrinting member boolean.
3638
3639 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
3640
3641         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
3642         https://bugs.webkit.org/show_bug.cgi?id=116016
3643
3644         Reviewed by Dirk Pranke.
3645
3646         Same fix as in the upstream style checker, but without hg support.
3647         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
3648
3649         * Scripts/webkitpy/style/checkers/cpp.py:
3650         (FileInfo.repository_name):
3651
3652 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
3653
3654         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
3655         https://bugs.webkit.org/show_bug.cgi?id=115918
3656
3657         Reviewed by Gustavo Noronha Silva.
3658
3659         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
3660         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
3661         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
3662         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
3663         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
3664         problems.
3665
3666         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
3667         These are then used as dependencies for the archive creation rule as well as the list from which the archive
3668         file paths are constructed and then used to dump the member files from these archives. The member files are
3669         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
3670         successfully link.
3671
3672         * TestWebKitAPI/GNUmakefile.am:
3673
3674 2013-05-13  Anders Carlsson  <andersca@apple.com>
3675
3676         Remove UnusedParam.h
3677         https://bugs.webkit.org/show_bug.cgi?id=116029
3678
3679         Reviewed by Andreas Kling.
3680
3681         Stop including UnusedParam.h.
3682
3683         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3684         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3685
3686 2013-05-12  Commit Queue  <commit-queue@webkit.org>
3687
3688         Unreviewed, rolling out r149955.
3689         http://trac.webkit.org/changeset/149955
3690         https://bugs.webkit.org/show_bug.cgi?id=115990
3691
3692         Broke lots of tests (Requested by smfr on #webkit).
3693
3694         * Scripts/webkitpy/port/mac.py:
3695
3696 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3697
3698         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
3699         https://bugs.webkit.org/show_bug.cgi?id=115914
3700
3701         Reviewed by Martin Robinson.
3702
3703         * GtkLauncher/main.c:
3704         (createToolbar):
3705         * MiniBrowser/gtk/BrowserWindow.c:
3706         (_BrowserWindow):
3707         (browserWindowSetStatusText):
3708         (fullScreenMessageTimeoutCallback):
3709         (webViewEnterFullScreen):
3710         (webViewLeaveFullScreen):
3711         (browserWindowFinalize):
3712         (browserWindowConstructed):
3713         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3714         (WTR::EventSenderProxy::mouseScrollBy):
3715         (WTR::EventSenderProxy::continuousMouseScrollBy):
3716
3717 2013-05-11  Anders Carlsson  <andersca@apple.com>
3718
3719         Crash when terminating a process that has not been fully launched
3720         https://bugs.webkit.org/show_bug.cgi?id=115962
3721         <rdar://problem/13660916>
3722
3723         Reviewed by Andreas Kling.
3724
3725         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
3726         before the process has had a chance to be fully launched.
3727
3728         * TestWebKitAPI/GNUmakefile.am:
3729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3730         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
3731         (TestWebKitAPI):
3732         (TestWebKitAPI::didFinishLoadForFrame):
3733         (TestWebKitAPI::TEST):
3734         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
3735
3736 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
3737
3738         Remove Mac OS X Leopard (10.5) support
3739         https://bugs.webkit.org/show_bug.cgi?id=107964
3740
3741         Reviewed by Ryosuke Niwa.
3742
3743         Removed the code for 10.5 and removed if-def for 10.6.
3744
3745         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3746         (convertMIMEType):
3747         (createXMLStringFromWebArchiveData):
3748         * DumpRenderTree/mac/TestRunnerMac.mm:
3749         (TestRunner::authenticateSession):
3750         (TestRunner::setTextDirection):
3751         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
3752         (convertMIMEType):
3753         (createXMLStringFromWebArchiveData):
3754
3755 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
3756
3757         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
3758         https://bugs.webkit.org/show_bug.cgi?id=115935
3759
3760         Reviewed by Jer Noble.
3761
3762         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
3763         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
3764         to the new manifest file.
3765         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
3766
3767 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
3768
3769         Fix some compiler warnings (miscellaneous)
3770         https://bugs.webkit.org/show_bug.cgi?id=80790
3771
3772         Reviewed by Rob Buis.
3773
3774         Fix the following warnings for BlackBerry:
3775         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
3776         used as truth value [-Wparentheses].
3777
3778         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3779         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3780
3781 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3782
3783         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
3784         https://bugs.webkit.org/show_bug.cgi?id=115928
3785
3786         Reviewed by Kenneth Rohde Christiansen.
3787
3788         WKViewSetThemePath was moved to WKViewEfl.h.
3789
3790         * TestWebKitAPI/efl/PlatformWebView.cpp:
3791
3792 2013-05-10  Andreas Kling  <akling@apple.com>
3793
3794         I accidentally the Java testing.
3795
3796         * Scripts/webkitpy/port/mac.py:
3797
3798 2013-05-10  Brian Holt  <brian.holt@samsung.com>
3799
3800         [GTK] Module Cairo fails to build under jhbuild
3801         https://bugs.webkit.org/show_bug.cgi?id=115854
3802
3803         Reviewed by Martin Robinson.
3804
3805         Make cairo depend on glib in jhbuild.modules.
3806
3807         * gtk/jhbuild.modules:
3808
3809 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3810
3811         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
3812         https://bugs.webkit.org/show_bug.cgi?id=115904
3813
3814         Reviewed by Martin Robinson.
3815
3816         * ImageDiff/gtk/ImageDiff.cpp:
3817         (main):
3818
3819 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
3820
3821         Add my new address to contributors.json. (Unreviewed)
3822
3823         * Scripts/webkitpy/common/config/contributors.json:
3824
3825 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3826
3827         Unreviewed. Move myself to the reviewers list.
3828
3829         * Scripts/webkitpy/common/config/contributors.json:
3830
3831 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3832
3833         Unreviewed. Add my email to a few watchlists.
3834
3835         * Scripts/webkitpy/common/config/watchlist:
3836
3837 2013-05-10  Simon Pena  <simon.pena@samsung.com>
3838
3839         Unicode support missing from string representation of Contributors in committers.py
3840         https://bugs.webkit.org/show_bug.cgi?id=115859
3841
3842         Reviewed by Darin Adler.
3843
3844         Contributors, in committers.py, provided a string representation in __str__ which
3845         didn't support unicode characters, so printing a contributor would fail in that case.
3846         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
3847         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
3848
3849         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
3850         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
3851         representation.
3852         (Contributor.__str__):
3853         (Contributor):
3854         (Contributor.__unicode__):
3855         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
3856         a contributor with unicode characters can be represented as a string.
3857         (CommittersTest):
3858         (CommittersTest.test_contributor_encoding):
3859
3860 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
3861
3862         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
3863         https://bugs.webkit.org/show_bug.cgi?id=92371
3864
3865         Reviewed by Brent Fulgham.
3866
3867         Use JavaScriptThreading.cpp where the same functionality is
3868         implemented too. This reduces the dependency on the pthread
3869         library. Also replace assert() with WebKit ASSERT().
3870
3871         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3872         * DumpRenderTree/win/DumpRenderTree.cpp:
3873         (dumpHistoryItem):
3874         (dumpBackForwardList):
3875         * DumpRenderTree/win/DumpRenderTree.vcproj:
3876
3877 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
3878
3879         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
3880         https://bugs.webkit.org/show_bug.cgi?id=92505
3881
3882         Reviewed by Brent Fulgham.
3883
3884         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3885         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
3886         (javaScriptThreadsMutex):
3887         (javaScriptThreads):
3888         (runJavaScriptThread):
3889         (startJavaScriptThreads):
3890         (stopJavaScriptThreads):
3891         * DumpRenderTree/pthreads: Removed.
3892         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
3893
3894 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3895
3896         Unreviewed. Update Simon Pena email on his behalf.
3897
3898         * Scripts/webkitpy/common/config/contributors.json:
3899
3900 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3901
3902         Add support for [NoInterfaceObject] Web IDL extended attribute
3903         https://bugs.webkit.org/show_bug.cgi?id=115714
3904
3905         Reviewed by Kentaro Hara.
3906
3907         Update BindingsTests.generate_supplemental_dependency() to pass an
3908         additional windowConstructorsFile argument to preprocess-idls.pl.
3909
3910         * Scripts/webkitpy/bindings/main.py:
3911         (BindingsTests.generate_supplemental_dependency):
3912         (BindingsTests.main):
3913
3914 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
3915
3916         [GTK][AC] Buildfix after r149694
3917         https://bugs.webkit.org/show_bug.cgi?id=115797
3918
3919         Reviewed by Gustavo Noronha Silva.
3920
3921         Add CLUTTER_LIBS for linking TestWebCore.
3922
3923         * TestWebKitAPI/GNUmakefile.am:
3924
3925 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3926
3927         [EFL] Remove unnecessary pkgs in EFL jhbuild
3928         https://bugs.webkit.org/show_bug.cgi?id=114908
3929
3930         Reviewed by Laszlo Gombos.
3931
3932         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
3933         handle them using jhbuild. We can reduce build time when using --update-efl.
3934
3935         * efl/jhbuild.modules:
3936
3937 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
3938
3939         [EFL] Disable SHADOW DOM feature in FeatureList.pm
3940         https://bugs.webkit.org/show_bug.cgi?id=115834
3941
3942         Reviewed by Gyuyoung Kim.
3943
3944         * Scripts/webkitperl/FeatureList.pm:
3945
3946 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3947
3948         Add Scheduler for Mac MtnLion 32bit Release builder.
3949         
3950         Unreviewed.
3951         
3952         * BuildSlaveSupport/build.webkit.org-config/config.json:
3953
3954 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
3955
3956         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
3957         https://bugs.webkit.org/show_bug.cgi?id=115808
3958
3959         Reviewed by Darin Adler.
3960
3961         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
3962         was left outdated after r127191, when the m_string member was changed
3963         from UString to String. This patch calls the right pretty printer for it.
3964
3965         * gdb/webkit.py:
3966         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
3967         WTFImplPrettyPrinter.
3968
3969 2013-05-08  Andy Estes  <aestes@apple.com>
3970
3971         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
3972         https://bugs.webkit.org/show_bug.cgi?id=115790
3973
3974         Reviewed by Alexey Proskuryakov.
3975
3976         Added two API tests:
3977
3978         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
3979         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
3980
3981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3982         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
3983         (TestWebKitAPI):
3984         (TestWebKitAPI::TEST):
3985         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
3986         (TestWebKitAPI):
3987         (TestWebKitAPI::decidePolicyForNavigationAction):
3988         (CustomProtocolInvalidSchemeTest):
3989         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
3990
3991 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3992
3993         Teach buildbot how to compile 32-bit on Mac.
3994
3995         Reviewed by Ryosuke Niwa.
3996
3997         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3998         (CompileWebKit.start):
3999         (ExtractTestResultsAndLeaks):
4000
4001 2013-05-08  Eli Fidler  <efidler@blackberry.com>
4002
4003         [BlackBerry] Fix usage of BlackBerry::Platform::String
4004         https://bugs.webkit.org/show_bug.cgi?id=115781
4005
4006         Reviewed by Rob Buis.
4007
4008         BlackBerry PRs 304193 and 327181
4009         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
4010
4011         We currently have a problem where we're passing UTF-8 encoded data into
4012         the char* constructors of BlackBerry::Platform::String. This means the string
4013         thinks its data is not UTF-8.
4014
4015         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4016         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
4017         (BlackBerry::WebKit::dumpHistoryItem):
4018         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4019         (TestRunner::setUserStyleSheetLocation):
4020         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
4021         (LoadHTMLStringItem::invoke):
4022
4023 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
4024
4025         Tools: add new BlackBerry include dirs.
4026         https://bugs.webkit.org/show_bug.cgi?id=115514
4027
4028         Reviewed by Rob Buis.
4029
4030         iType include dirs are missing, and HarfBuzz needs to be fixed.
4031
4032         * Scripts/webkitdirs.pm:
4033         (blackberryCMakeArguments):
4034
4035 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
4036
4037         [GTK] Plumb the Automake build system for the Battery Status API feature
4038         https://bugs.webkit.org/show_bug.cgi?id=115718
4039
4040         Reviewed by Martin Robinson.
4041
4042         * Scripts/webkitdirs.pm:
4043         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
4044         through the --(enable|disable)-battery-status flag passed to configure.
4045
4046 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
4047
4048         new-run-webkit-websocketserver doesn't work after Chromium removal
4049         https://bugs.webkit.org/show_bug.cgi?id=115816
4050
4051         Reviewed by Joseph Pecoraro.
4052
4053         Fix the bug by instantiating the correct port object.
4054
4055         * Scripts/new-run-webkit-websocketserver:
4056         (main):
4057
4058 2013-05-07  Lucas Forschler  <lforschler@apple.com>
4059
4060         Configure buildbot for 32bit builder.
4061         https://bugs.webkit.org/show_bug.cgi?id=115769
4062         
4063         Reviewed by Ryosuke Niwa.
4064
4065         * BuildSlaveSupport/build.webkit.org-config/config.json:
4066
4067 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
4068
4069         Unreviewed. Update to show my apple.com address.
4070
4071         * Scripts/webkitpy/common/config/contributors.json: Added
4072         my apple.com e-mail address.
4073
4074 2013-05-08  David Kilzer  <ddkilzer@apple.com>
4075
4076         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
4077
4078         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4079         (concatenateAttributeAndValue): Switch to appendVector().
4080
4081 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
4082
4083         [Qt][WTR] Fix the build on Mac after r149692
4084
4085         Unreviewed build fix.
4086
4087         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4088         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
4089
4090 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
4091
4092         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
4093         to the watchlist for Accessibility.
4094
4095         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
4096         * Scripts/webkitpy/common/config/watchlist: Added myself.
4097
4098 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
4099
4100         [Qt] Build fails with clang
4101         https://bugs.webkit.org/show_bug.cgi?id=115741
4102
4103         Reviewed by Benjamin Poulain.
4104
4105         Since r149112 std::move is used in AtomicString for compilers that
4106         support rvalue references and this requires a standard library
4107         implementing c++11 move semantics.
4108         We only explicitely require c++11 for WebKit2, but since clang supports
4109         rvalue references the build of subtargets using AtomicString fails because
4110         of missing std::move.
4111         It is safe to add CONFIG += c++11 for the whole project when using clang
4112         since we explicitely disable c++11 for ANGLE that had probems with libc++.
4113
4114         * qmake/mkspecs/features/unix/default_pre.prf:
4115
4116 2013-05-08  Darin Adler  <darin@apple.com>
4117
4118         Fix one more place that needed to use adoptCF/NS
4119         https://bugs.webkit.org/show_bug.cgi?id=115778
4120
4121         Reviewed by Benjamin Poulain.
4122
4123         Not sure why I missed this code last time, but found a bit more code that needs
4124         to switch to the newer style adoptCF/NS.
4125
4126         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
4127         (convertWebResourceDataToString): Use adoptCF.
4128         (convertWebResourceResponseToDictionary): Ditto.
4129         (createXMLStringFromWebArchiveData): Ditto.
4130         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
4131         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
4132
4133 2013-05-08  Commit Queue  <commit-queue@webkit.org>
4134
4135         Unreviewed, rolling out r149271.
4136         http://trac.webkit.org/changeset/149271
4137         https://bugs.webkit.org/show_bug.cgi?id=115780
4138
4139         The mangled symbols are now enforced through LDFLAGS
4140         (Requested by zdobersek on #webkit).
4141
4142         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
4143
4144 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
4145
4146         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
4147         https://bugs.webkit.org/show_bug.cgi?id=115636
4148
4149         Reviewed by Ryosuke Niwa.
4150
4151         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4152         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
4153         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
4154         while Chromium-specific, can't be removed just yet as there's more code that uses it.
4155
4156 2013-05-06  Darin Adler  <darin@apple.com>
4157
4158         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
4159         https://bugs.webkit.org/show_bug.cgi?id=115657
4160
4161         Reviewed by Sam Weinig.
4162
4163         This is similar to my last set of changes, but covers code that I missed with
4164         global replace using the Safari Xcode workspace.
4165
4166         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
4167         (convertWebResourceDataToString):
4168         (convertWebResourceResponseToDictionary):
4169         (createXMLStringFromWebArchiveData):
4170         * DumpRenderTree/cg/ImageDiffCG.cpp:
4171         (createImageFromStdin):
4172         (createDifferenceImage):
4173         (main):
4174         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
4175         (printPNG):
4176         (dumpBitmap):
4177         * DumpRenderTree/cg/PixelDumpSupportCG.h:
4178         (BitmapContext::BitmapContext):
4179         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
4180         (-[MockWebNotificationProvider init]):
4181         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4182         (createBitmapContext):
4183         * DumpRenderTree/mac/TestRunnerMac.mm:
4184         (TestRunner::addDisallowedURL):
4185         (TestRunner::applicationCacheDiskUsageForOrigin):
4186         (TestRunner::localStorageDiskUsageForOrigin):
4187         (TestRunner::clearApplicationCacheForOrigin):
4188         (TestRunner::deleteLocalStorageForOrigin):
4189         (TestRunner::copyDecodedHostName):
4190         (TestRunner::copyEncodedHostName):
4191         (TestRunner::queueLoad):
4192         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
4193         (TestRunner::setMockGeolocationPositionUnavailableError):
4194         (TestRunner::setUserStyleSheetLocation):
4195         (TestRunner::setValueForUser):
4196         (TestRunner::overridePreference):
4197         (TestRunner::setPersistentUserStyleSheetLocation):
4198         (TestRunner::execCommand):
4199         (TestRunner::findString):
4200         (TestRunner::isCommandEnabled):
4201         (TestRunner::addOriginAccessWhitelistEntry):
4202         (TestRunner::removeOriginAccessWhitelistEntry):
4203         (TestRunner::addUserScript):
4204         (TestRunner::addUserStyleSheet):
4205         (TestRunner::evaluateInWebInspector):
4206         (TestRunner::evaluateScriptInIsolatedWorld):
4207         (TestRunner::apiTestNewWindowDataLoadBaseURL):
4208         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
4209         (TestRunner::authenticateSession):
4210         (TestRunner::grantWebNotificationPermission):
4211         (TestRunner::denyWebNotificationPermission):
4212         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
4213         (createCFURLResponseFromResponseData):
4214         * DumpRenderTree/mac/WorkQueueItemMac.mm:
4215         (LoadItem::invoke):
4216         (LoadHTMLStringItem::invoke):
4217         (ScriptItem::invoke):
4218         * DumpRenderTree/win/DumpRenderTree.cpp:
4219         (substringFromIndex):
4220         (urlSuitableForTestResult):
4221         (lastPathComponent):
4222         (sharedCFURLCache):
4223         * DumpRenderTree/win/ImageDiffCairo.cpp:
4224         (createImageFromStdin):
4225         (main):
4226         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
4227         (createBitmapContextFromWebView):
4228         * DumpRenderTree/win/TestRunnerWin.cpp:
4229         (TestRunner::setUserStyleSheetLocation):
4230         (TestRunner::setPersistentUserStyleSheetLocation):
4231         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
4232         (TestWebKitAPI::TEST):
4233         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
4234         (TestWebKitAPI::TEST):
4235         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
4236         (TestWebKitAPI::TEST):
4237         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
4238         (TestWebKitAPI::TEST):
4239         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
4240         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4241         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
4242         (TestWebKitAPI::createWindow):
4243         (TestWebKitAPI::TEST):
4244         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
4245         (TestWebKitAPI::TEST):
4246         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
4247         (TestWebKitAPI::AcceptsFirstMouse::runTest):
4248         * TestWebKitAPI/Tests/mac/AttributedString.mm:
4249         (TestWebKitAPI::TEST):
4250         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
4251         (TestWebKitAPI::TEST):
4252         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
4253         (TestWebKitAPI::TEST):
4254         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
4255         (TestWebKitAPI::TEST):
4256         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
4257         (TestWebKitAPI::TEST):
4258         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
4259         (TestWebKitAPI::TEST):
4260         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
4261         (TestWebKitAPI::TEST):
4262         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
4263         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
4264         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
4265         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
4266         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
4267         (TestWebKitAPI::TEST):
4268         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
4269         (TestWebKitAPI::TEST):
4270         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
4271         (TestWebKitAPI::TEST):
4272         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
4273         (TestWebKitAPI::TEST):
4274         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
4275         (TestWebKitAPI::TEST):
4276         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
4277         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
4278         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
4279         (TestWebKitAPI::TEST):
4280         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
4281         (TestWebKitAPI::TEST):
4282         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
4283         (TestWebKitAPI::TEST):
4284         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
4285         (TestWebKitAPI::TEST):
4286         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
4287         (TestWebKitAPI::TEST):
4288         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
4289         (TestWebKitAPI::TEST):
4290         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
4291         (TestWebKitAPI::TEST):
4292         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
4293         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
4294         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
4295         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
4296         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
4297         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
4298         (WTR::testPathFromURL):
4299         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4300         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
4301         * WebKitTestRunner/cg/TestInvocationCG.cpp:
4302         (WTR::createCGContextFromImage):
4303         (WTR::dumpBitmap):
4304         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
4305         * WebKitTestRunner/mac/EventSenderProxy.mm:
4306         (WTR::EventSenderProxy::mouseScrollBy):
4307         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4308         (WTR::PlatformWebView::windowSnapshotImage):
4309         * WebKitTestRunner/win/TestControllerWin.cpp:
4310         (WTR::TestController::initializeTestPluginDirectory):
4311         Use adoptCF and adoptNS.
4312
4313 2013-05-07  Alex Christensen  <achristensen@apple.com>
4314
4315         Fix a memory leak introduced in r149692
4316         https://bugs.webkit.org/show_bug.cgi?id=115766
4317
4318         Reviewed by Mark Rowe.
4319
4320         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
4321         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
4322
4323         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4324         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
4325         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
4326
4327 2013-05-07  Darin Adler  <darin@apple.com>
4328
4329         [Win] Fix storage leak in Windows DumpRenderTree
4330         https://bugs.webkit.org/show_bug.cgi?id=115651
4331
4332         Reviewed by Sam Weinig.
4333
4334         * DumpRenderTree/win/DumpRenderTree.cpp:
4335         (lastPathComponent): Added a missing call to adoptCF.
4336
4337 2013-05-07  Alex Christensen  <achristensen@apple.com>