Gigacages should start allocations from a slide
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2
3         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
4         <https://webkit.org/b/193568>
5         <rdar://problem/47381130>
6
7         Reviewed by Alex Christensen.
8
9         Make sure no one re-introduces UIKit soft-linking by adding a
10         style rule.
11
12         * Scripts/webkitpy/style/checkers/cpp.py:
13         (check_language): Add softlink/uikit check.
14         (CppChecker): Enable softlink/uikit check.
15         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
16         (CppStyleTest): Add test for softlink/uikit.
17
18 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
19
20         [GTK] install-dependencies tool looks for libunistring-dev for dnf
21         https://bugs.webkit.org/show_bug.cgi?id=193584
22
23         Change "-dev" to "-devel".
24
25         Reviewed by Michael Catanzaro.
26
27         * gtk/install-dependencies:
28
29 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
30
31         webkitpy: Add iPhone and iPad ports
32         https://bugs.webkit.org/show_bug.cgi?id=193537
33         <rdar://problem/47353390>
34
35         Reviewed by Lucas Forschler.
36
37         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
38         ports. Note that this separation is optional, the --ios-simulator command remains.
39
40         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
41         (RunTest.test_device_type_test_division): Drive-by fix.
42         (RunTest.test_device_type_specific_listing): Ditto.
43         (RunTest.test_ipad_test_division):
44         (RunTest):
45         (RunTest.test_ipad_listing):
46         * Scripts/webkitpy/port/factory.py:
47         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
48         (PortFactory):
49         * Scripts/webkitpy/port/ios_simulator.py:
50         (IPhoneSimulatorPort):
51         (IPadSimulatorPort):
52
53 2019-01-18  Chris Dumez  <cdumez@apple.com>
54
55         Regression(PSON) Scroll position is not always restored properly when navigating back
56         https://bugs.webkit.org/show_bug.cgi?id=193578
57         <rdar://problem/47386331>
58
59         Reviewed by Tim Horton.
60
61         Add API test coverage.
62
63         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
64
65 2019-01-18  Youenn Fablet  <youenn@apple.com>
66
67         Add a new SPI to request for cache storage quota increase
68         https://bugs.webkit.org/show_bug.cgi?id=193323
69
70         Reviewed by Alex Christensen.
71
72         Implement WebsiteDataStore quota delegate to handle quota requests.
73         By default, do not update quota.
74         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
75
76         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
77         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
78         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
79         * WebKitTestRunner/InjectedBundle/TestRunner.h:
80         * WebKitTestRunner/TestController.cpp:
81         (WTR::TestController::allowCacheStorageQuotaIncrease):
82         * WebKitTestRunner/TestController.h:
83         * WebKitTestRunner/TestInvocation.cpp:
84         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
85         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
86         (-[CacheStorageQuotaManager init]):
87         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
88         (WTR::initializeWebViewConfiguration):
89         (WTR::TestController::cocoaResetStateToConsistentValues):
90         (WTR::TestController::allowCacheStorageQuotaIncrease):
91
92 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
93
94         [ews-build] Pass owner to the triggered builds
95         https://bugs.webkit.org/show_bug.cgi?id=193574
96
97         Reviewed by Lucas Forschler.
98
99         * BuildSlaveSupport/ews-build/factories.py:
100         (BuildFactory.propertiesToPassToTriggers):
101
102 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
103
104         [ews-app] Send patch author as a build property
105         https://bugs.webkit.org/show_bug.cgi?id=193560
106
107         Reviewed by Lucas Forschler.
108
109         * BuildSlaveSupport/ews-app/ews/fetcher.py:
110         (BugzillaPatchFetcher.fetch):
111
112 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
113
114         webkitpy: Implement device type specific expected results (Follow-up fix)
115         https://bugs.webkit.org/show_bug.cgi?id=192162
116         <rdar://problem/46345449>
117
118         Unreviewed infrastructure fix.
119
120         * Scripts/webkitpy/layout_tests/controllers/manager.py:
121         (Manager.run): Don't boot a device if no tests are available to run on it.
122
123 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
124
125         webkitpy: Implement device type specific expected results (Follow-up fix)
126         https://bugs.webkit.org/show_bug.cgi?id=192162
127         <rdar://problem/46345449>
128
129         Unreviewed infrastructure fix.
130
131         * Scripts/webkitpy/api_tests/manager.py:
132         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
133
134 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
135
136         webkitpy: Implement device type specific expected results (Part 2)
137         https://bugs.webkit.org/show_bug.cgi?id=192162
138         <rdar://problem/46345449>
139
140         Rubber-stamped by Aakash Jain.
141
142         This change uses device_type to select a different set of TestExpectation files based on the type of device running
143         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
144         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
145
146         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
147         (LayoutTestFinder.find_tests): Pass device_type through.
148         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
149         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
150         * Scripts/webkitpy/layout_tests/controllers/manager.py:
151         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
152         (Manager._collect_tests): Pass device type to test finder.
153         (Manager._needs_web_platform_test):
154         (Manager._prepare_lists): Index _expectations by device type.
155         (Manager._test_input_for_file):
156         (Manager._test_is_slow): Ditto.
157         (Manager._test_should_dump_jsconsolelog_in_stderr):
158         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
159         (Manager._get_test_inputs):
160         (Manager._update_worker_count):
161         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
162         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
163         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
164         the one which runs the test.
165         (Manager._run_test_subset):
166         (Manager._run_tests): Index _expectations by current_device_type.
167         (Manager._print_expectation_line_for_test): Ditto.
168         (Manager._print_expectations_for_subset): Ditto.
169         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
170         Unlike run, this function will behave the same regardless of what devices are available.
171         (Manager._custom_device_for_test): Deleted.
172         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
173         (ManagerTest.test_uses_custom_device): Deleted.
174         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
175         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
176         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
177         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
178         all of the expectations.
179         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
180         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
181         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
182         (TestExpectations.__init__): Allow device_type to be passed through.
183         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
184         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
185         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
186         (summarize_results):
187         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
188         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
189         a test ran with, one must check all expectations to find the first non-skip expectation.
190         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
191         (RunTest.test_device_type_test_division):
192         (RunTest):
193         (RunTest.test_device_type_specific_listing):
194         * Scripts/webkitpy/port/base.py:
195         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
196         (Port.supported_device_types): The result of this function will change based on what devices are available.
197         * Scripts/webkitpy/port/device_port.py:
198         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
199         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
200         can be used.
201         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
202         any, or the DEFAULT_DEVICE_TYPES of the port.
203         * Scripts/webkitpy/port/ios.py:
204         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
205         * Scripts/webkitpy/port/ios_simulator.py:
206         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
207         * Scripts/webkitpy/port/watch.py:
208         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
209         * Scripts/webkitpy/port/watch_simulator.py:
210         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
211         * Scripts/webkitpy/xcode/device_type.py:
212         (DeviceType):
213         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
214
215 2019-01-18  Philippe Normand  <pnormand@igalia.com>
216
217         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
218         https://bugs.webkit.org/show_bug.cgi?id=193575
219
220         Reviewed by Michael Catanzaro.
221
222         Allow the script to run without explicit port argument because
223         it's specific to the WPE port anyway.
224
225         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
226         and simplify the rest of the code accordingly.
227
228 2019-01-18  Charlie Turner  <cturner@igalia.com>
229
230         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
231         https://bugs.webkit.org/show_bug.cgi?id=192229
232
233         Reviewed by Xabier Rodriguez-Calvar.
234
235         * MiniBrowser/wpe/main.cpp:
236         (main): Enable encrypted-media by default.
237
238 2019-01-18  Philippe Normand  <pnormand@igalia.com>
239
240         [Flatpak] Missing KeyboardInterrupt exception handler
241         https://bugs.webkit.org/show_bug.cgi?id=193570
242
243         Reviewed by Michael Catanzaro.
244
245         * flatpak/flatpakutils.py:
246         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
247
248 2019-01-18  Zalan Bujtas  <zalan@apple.com>
249
250         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
251         https://bugs.webkit.org/show_bug.cgi?id=193564
252
253         Reviewed by Antti Koivisto.
254
255         * LayoutReloaded/misc/LFC-passing-tests.txt:
256
257 2019-01-18  Zalan Bujtas  <zalan@apple.com>
258
259         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
260         https://bugs.webkit.org/show_bug.cgi?id=193562
261
262         Reviewed by Antti Koivisto.
263
264         * LayoutReloaded/misc/LFC-passing-tests.txt:
265
266 2019-01-18  Zalan Bujtas  <zalan@apple.com>
267
268         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
269         https://bugs.webkit.org/show_bug.cgi?id=193555
270
271         Reviewed by Antti Koivisto.
272
273         * LayoutReloaded/misc/LFC-passing-tests.txt:
274
275 2019-01-18  Philippe Normand  <pnormand@igalia.com>
276
277         [WPE] Add Qt extension
278         https://bugs.webkit.org/show_bug.cgi?id=191464
279
280         Reviewed by Carlos Garcia Campos.
281
282         MiniBrowser and API tests for the WPE Qt API. To run the
283         MiniBrowser a new script is introduced. Example invocation:
284
285         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
286
287         Also note-worthy is the introduction of the python2-subprocess32
288         dependency to run the GLib API tests.
289
290         * MiniBrowser/wpe/CMakeLists.txt:
291         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
292         * MiniBrowser/wpe/qt/main.cpp: Added.
293         (main):
294         * MiniBrowser/wpe/qt/main.qml: Added.
295         * MiniBrowser/wpe/qt/qml.qrc: Added.
296         * Scripts/run-gtk-tests:
297         (GtkTestRunner.is_google_test):
298         (GtkTestRunner):
299         (GtkTestRunner.is_qt_test):
300         * Scripts/run-qt-wpe-minibrowser: Added.
301         * Scripts/run-wpe-tests:
302         (WPETestRunner):
303         (WPETestRunner.is_google_test):
304         (WPETestRunner.is_qt_test):
305         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
306         (TestLoad::main):
307         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
308         (TestLoadHtml::main):
309         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
310         (TestLoadRequest::main):
311         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
312         (TestRunJavaScript::main):
313         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
314         (waitForSignal):
315         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
316         (LoadSpy::LoadSpy):
317         (LoadSpy::~LoadSpy):
318         (LoadSpy::onLoadingChanged):
319         (LoadStartedCatcher::LoadStartedCatcher):
320         (LoadStartedCatcher::~LoadStartedCatcher):
321         (LoadStartedCatcher::onLoadingChanged):
322         (waitForLoadSucceeded):
323         (waitForLoadFailed):
324         * TestWebKitAPI/glib/CMakeLists.txt:
325         * flatpak/flatpakutils.py:
326         (WebkitFlatpak.load_from_args):
327         (WebkitFlatpak.__init__):
328         (WebkitFlatpak.clean_args):
329         (WebkitFlatpak.run_in_sandbox):
330         * flatpak/org.webkit.CommonModules.yaml:
331         * flatpak/org.webkit.WPE.yaml:
332         * flatpak/org.webkit.WPEModules.yaml:
333         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
334         * flatpak/org.webkit.WebKit.yaml:
335         * glib/api_test_runner.py:
336         (TestRunner._run_test_qt):
337         (TestRunner.is_qt_test):
338         (TestRunner._run_test):
339
340 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
341
342         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
343         https://bugs.webkit.org/show_bug.cgi?id=193494
344         <rdar://problem/46859627>
345
346         Reviewed by Simon Fraser and Tim Horton.
347
348         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
349         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
350
351         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
352         (WTR::UIScriptController::contentOffsetX const):
353         (WTR::UIScriptController::contentOffsetY const):
354         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
355         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
356         (WTR::UIScriptController::contentOffsetX const):
357         (WTR::UIScriptController::contentOffsetY const):
358         * TestRunnerShared/UIScriptContext/UIScriptController.h:
359
360         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
361
362         * WebKitTestRunner/TestController.cpp:
363         (WTR::updateTestOptionsFromTestHeader):
364         * WebKitTestRunner/TestOptions.h:
365         (WTR::TestOptions::hasSameInitializationOptions const):
366         * WebKitTestRunner/ios/TestControllerIOS.mm:
367         (WTR::TestController::platformResetStateToConsistentValues):
368         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
369         (WTR::UIScriptController::contentOffsetX const):
370         (WTR::UIScriptController::contentOffsetY const):
371
372 2019-01-17  Truitt Savell  <tsavell@apple.com>
373
374         Unreviewed, rolling out r240124.
375
376         This commit broke an internal build.
377
378         Reverted changeset:
379
380         "SDK_VARIANT build destinations should be separate from non-
381         SDK_VARIANT builds"
382         https://bugs.webkit.org/show_bug.cgi?id=189553
383         https://trac.webkit.org/changeset/240124
384
385 2019-01-17  Alex Christensen  <achristensen@webkit.org>
386
387         Fix string concatenation API test after r239920
388         https://bugs.webkit.org/show_bug.cgi?id=193551
389         <rdar://problem/47359304>
390
391         Reviewed by Youenn Fablet.
392
393         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
394         (TestWebKitAPI::TEST):
395         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
396         in WebKit's build configuration like it apparently is on Linux.
397
398 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
399
400         [ews-build] validate-patch should handle the case when bug_id is None
401         https://bugs.webkit.org/show_bug.cgi?id=193547
402
403         Reviewed by Lucas Forschler.
404
405         * BuildSlaveSupport/ews-build/steps.py:
406         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
407         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
408
409 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
410
411         [ews-build] Add patch author information in build
412         https://bugs.webkit.org/show_bug.cgi?id=193465
413
414         Reviewed by Lucas Forschler.
415
416         * BuildSlaveSupport/ews-build/steps.py:
417         (ValidatePatch._is_patch_obsolete):
418
419 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
420
421         [ews-build] Pass bug_id to the triggered builds
422         https://bugs.webkit.org/show_bug.cgi?id=193548
423
424         Reviewed by Lucas Forschler.
425
426         * BuildSlaveSupport/ews-build/factories.py:
427         (BuildFactory.propertiesToPassToTriggers):
428
429 2019-01-17  Jer Noble  <jer.noble@apple.com>
430
431         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
432         https://bugs.webkit.org/show_bug.cgi?id=189553
433
434         Reviewed by Tim Horton.
435
436         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
437
438         * ContentExtensionTester/Configurations/Base.xcconfig:
439         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
440         * DumpRenderTree/mac/Configurations/Base.xcconfig:
441         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
442         * ImageDiff/cg/Configurations/Base.xcconfig:
443         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
444         * MiniBrowser/Configurations/Base.xcconfig:
445         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
446         * MobileMiniBrowser/Configurations/Base.xcconfig:
447         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
448         * Scripts/webkitpy/style/checker.py:
449         (_all_categories):
450         (FileType):
451         (CheckerDispatcher._file_type):
452         (CheckerDispatcher._create_checker):
453         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
454         (SDKVariantChecker):
455         (SDKVariantChecker.__init__):
456         (SDKVariantChecker.check):
457         * TestWebKitAPI/Configurations/Base.xcconfig:
458         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
459         * WebEditingTester/Configurations/Base.xcconfig:
460         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
461         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
462         * WebKitTestRunner/Configurations/Base.xcconfig:
463         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
464         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
465         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
466
467 2019-01-17  Zalan Bujtas  <zalan@apple.com>
468
469         [LFC][BFC] An element with transform is a containing block for positioned descendants.
470         https://bugs.webkit.org/show_bug.cgi?id=193534
471
472         Reviewed by Antti Koivisto.
473
474         * LayoutReloaded/misc/LFC-passing-tests.txt:
475
476 2019-01-17  Zalan Bujtas  <zalan@apple.com>
477
478         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
479         https://bugs.webkit.org/show_bug.cgi?id=193528
480
481         Reviewed by Antti Koivisto.
482
483         * LayoutReloaded/misc/LFC-passing-tests.txt:
484
485 2019-01-17  Zalan Bujtas  <zalan@apple.com>
486
487         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
488         https://bugs.webkit.org/show_bug.cgi?id=193520
489
490         Reviewed by Antti Koivisto.
491
492         * LayoutReloaded/misc/LFC-passing-tests.txt:
493
494 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
495
496         [ews-build] unapply-patch step should not update source
497         https://bugs.webkit.org/show_bug.cgi?id=193234
498
499         Reviewed by Lucas Forschler.
500
501         * BuildSlaveSupport/ews-build/steps.py:
502         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
503         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
504
505 2019-01-16  Youenn Fablet  <youenn@apple.com>
506
507         Add a new SPI for controlling getUserMedia
508         https://bugs.webkit.org/show_bug.cgi?id=192793
509
510         Reviewed by Eric Carlson.
511
512         * MiniBrowser/mac/WK2BrowserWindowController.m:
513         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
514         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
515         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
516         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
517         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
518         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
519         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
520         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
521         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
522         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
523         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
524         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
525         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
526         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
527
528 2019-01-16  Zalan Bujtas  <zalan@apple.com>
529
530         [LFC][BFC] Inflow non-replaced used width should not be negative.
531         https://bugs.webkit.org/show_bug.cgi?id=193495
532
533         Reviewed by Antti Koivisto.
534
535         * LayoutReloaded/misc/LFC-passing-tests.txt:
536
537 2019-01-16  Chris Dumez  <cdumez@apple.com>
538
539         Regression(PSON) View becomes blank after click a cross-site download link
540         https://bugs.webkit.org/show_bug.cgi?id=193361
541         <rdar://problem/47099573>
542
543         Reviewed by Geoffrey Garen.
544
545         Add API test coverage.
546
547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
548         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
549
550 2019-01-16  Zalan Bujtas  <zalan@apple.com>
551
552         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
553         https://bugs.webkit.org/show_bug.cgi?id=193470
554
555         Reviewed by Antti Koivisto.
556
557         * LayoutReloaded/misc/LFC-passing-tests.txt:
558
559 2019-01-16  Zalan Bujtas  <zalan@apple.com>
560
561         [LFC] Adjust margin box verification.
562         https://bugs.webkit.org/show_bug.cgi?id=193482
563
564         Reviewed by Antti Koivisto.
565
566         * LayoutReloaded/misc/LFC-passing-tests.txt:
567
568 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
569
570         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
571         https://bugs.webkit.org/show_bug.cgi?id=193451
572
573         Reviewed by Geoffrey Garen.
574
575         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
576         (TEST):
577         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
578         (runWebsiteDataStoreCustomPaths):
579
580 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
581
582         webkitpy: Support boolean simctl isAvailable
583         https://bugs.webkit.org/show_bug.cgi?id=193472
584         <rdar://problem/47296150>
585
586         Reviewed by Ryosuke Niwa.
587
588         * Scripts/webkitpy/xcode/simulated_device.py:
589         (SimulatedDeviceManager._create_runtimes):
590         (SimulatedDeviceManager._create_device_with_runtime):
591
592 2019-01-15  Chris Dumez  <cdumez@apple.com>
593
594         Unreviewed, rolling out r239993, r239995, r239997, and
595         r239999.
596
597         Caused assertions under
598         ViewGestureController::disconnectFromProcess()
599
600         Reverted changesets:
601
602         "Regression(PSON) View becomes blank after click a cross-site
603         download link"
604         https://bugs.webkit.org/show_bug.cgi?id=193361
605         https://trac.webkit.org/changeset/239993
606
607         "Unreviewed iOS build fix after r239993."
608         https://trac.webkit.org/changeset/239995
609
610         "Fix iOS build after r239993"
611         https://bugs.webkit.org/show_bug.cgi?id=193361
612         https://trac.webkit.org/changeset/239997
613
614         "Unreviewed, revert part of r239997 as it is not needed to fix
615         the build."
616         https://trac.webkit.org/changeset/239999
617
618 2019-01-15  Tim Horton  <timothy_horton@apple.com>
619
620         Cannot tab out of WKWebView on macOS
621         https://bugs.webkit.org/show_bug.cgi?id=161448
622         <rdar://problem/28100085>
623
624         Reviewed by Dean Jackson.
625
626         Add a test that tabbing into and out of WKWebView works correctly.
627
628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
629         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
630         (WebKit2_CommandBackForwardTest::SetUp):
631         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
632         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
633         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
634         (-[FocusableView canBecomeKeyView]):
635         (TEST):
636         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
637         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
638         (-[OffscreenWindow initWithSize:]):
639         (-[OffscreenWindow isKeyWindow]):
640         (-[OffscreenWindow isVisible]):
641         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
642         (TestWebKitAPI::PlatformWebView::initialize):
643         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
644         (-[ActiveOffscreenWindow isVisible]): Deleted.
645         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
646
647 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
648
649         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
650         https://bugs.webkit.org/show_bug.cgi?id=193459
651
652         Reviewed by Mark Lam.
653
654         * BuildSlaveSupport/build.webkit.org-config/steps.py:
655         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
656
657 2019-01-15  Chris Dumez  <cdumez@apple.com>
658
659         Regression(PSON) View becomes blank after click a cross-site download link
660         https://bugs.webkit.org/show_bug.cgi?id=193361
661         <rdar://problem/47099573>
662
663         Reviewed by Geoff Garen.
664
665         Add API test coverage.
666
667         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
668         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
669
670 2019-01-15  Zalan Bujtas  <zalan@apple.com>
671
672         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
673         https://bugs.webkit.org/show_bug.cgi?id=193448
674
675         Reviewed by Antti Koivisto.
676
677         * LayoutReloaded/misc/LFC-passing-tests.txt:
678
679 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
680
681         webkitpy: Implement device type specific expected results (Part 1)
682         https://bugs.webkit.org/show_bug.cgi?id=192162
683
684         Reviewed by Lucas Forschler.
685
686         Device type specific expected results covers two related ideas. The first (covered by this change)
687         is where to search for -expected.* files. The second is which tests to run based on the
688         TestExpectations.txt file.
689
690         After this change, the baseline search path will be determined by the type of device running a
691         test. Device type will be passed into any function which picks a file based on the baseline search
692         path.
693
694         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
695         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
696         * Scripts/webkitpy/layout_tests/controllers/manager.py:
697         (Manager.run): Print baseline search path for each round of devices.
698         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
699         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
700         (SingleTestRunner._expected_driver_output): Ditto.
701         (SingleTestRunner._driver_input): Ditto.
702         * Scripts/webkitpy/layout_tests/views/printing.py:
703         (Printer.print_config): Move printing of baseline search path to a separate function.
704         (Printer.print_baseline_search_path): Moved from Printer.print_config.
705         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
706         (Testprinter.test_print_config):
707         (Testprinter.test_print_baseline_search_path):
708         * Scripts/webkitpy/port/base.py:
709         (Port.baseline_search_path): Pass device_type through.
710         (Port._expected_baselines_for_suffixes): Ditto.
711         (Port.expected_baselines): Ditto.
712         (Port.expected_filename): Ditto.
713         (Port.expected_checksum): Ditto.
714         (Port.expected_image): Ditto.
715         (Port.expected_audio): Ditto.
716         (Port.expected_text): Ditto.
717         (Port.reference_files): Ditto.
718         (Port.tests): Ditto.
719         (Port._expanded_paths): Ditto.
720         (Port.skipped_layout_tests): Ditto.
721         (Port.expectations_dict): Ditto.
722         (Port._port_specific_expectations_files): Ditto.
723         (Port.expectations_files): Ditto.
724         (Port.test_search_path): Ditto.
725         (Port._tests_for_other_platforms): Ditto.
726         * Scripts/webkitpy/port/base_unittest.py:
727         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
728         (PortTest.test_nonexistant_expectations): Ditto.
729         (test_ref_tests_platform_directory): Ditto.
730         * Scripts/webkitpy/port/darwin.py:
731         (DarwinPort._port_specific_expectations_files): Accept device_type.
732         * Scripts/webkitpy/port/driver.py:
733         (DriverProxy):
734         (DriverProxy.host): Expose _target_host for device_type information.
735         * Scripts/webkitpy/port/gtk.py:
736         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
737         * Scripts/webkitpy/port/ios.py:
738         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
739         * Scripts/webkitpy/port/mac.py:
740         (MacPort. default_baseline_search_path): Ditto.
741         * Scripts/webkitpy/port/port_testcase.py:
742         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
743         * Scripts/webkitpy/port/test.py:
744         * Scripts/webkitpy/port/watch.py:
745         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
746         * Scripts/webkitpy/port/win.py:
747         (WinPort.test_search_path): Accept, but do not use, device_type.
748         * Scripts/webkitpy/port/wpe.py:
749         (WPEPort._port_specific_expectations_files): Ditto.
750         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
751         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
752
753 2019-01-15  Zalan Bujtas  <zalan@apple.com>
754
755         [LFC] Use the containing block's padding box to position out-of-flow elements.
756         https://bugs.webkit.org/show_bug.cgi?id=193431
757
758         Reviewed by Antti Koivisto.
759
760         * LayoutReloaded/misc/LFC-passing-tests.txt:
761
762 2019-01-14  Tim Horton  <timothy_horton@apple.com>
763
764         Move a test implementation file that got misplaced in the Xcode project
765
766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
767
768 2019-01-14  Commit Queue  <commit-queue@webkit.org>
769
770         Unreviewed, rolling out r239901, r239909, r239910, r239912,
771         r239913, and r239914.
772         https://bugs.webkit.org/show_bug.cgi?id=193407
773
774         These revisions caused an internal failure (Requested by
775         Truitt on #webkit).
776
777         Reverted changesets:
778
779         "[Cocoa] Avoid importing directly from subumbrella frameworks"
780         https://bugs.webkit.org/show_bug.cgi?id=186016
781         https://trac.webkit.org/changeset/239901
782
783         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
784         https://trac.webkit.org/changeset/239909
785
786         "Tried to fix the build."
787         https://trac.webkit.org/changeset/239910
788
789         "Fixed iOS builds after r239910."
790         https://trac.webkit.org/changeset/239912
791
792         "More build fixing."
793         https://trac.webkit.org/changeset/239913
794
795         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
796         https://trac.webkit.org/changeset/239914
797
798 2019-01-14  Mark Lam  <mark.lam@apple.com>
799
800         Re-enable ability to build --cloop builds.
801         https://bugs.webkit.org/show_bug.cgi?id=192955
802         <rdar://problem/46882363>
803
804         Reviewed by Saam barati and Keith Miller.
805
806         The --cloop build option was being ignored this whole time since r236381.
807         This patch makes it possible to build CLoop builds again.
808
809         * Scripts/build-jsc:
810         * Scripts/webkitperl/FeatureList.pm:
811         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
812
813 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
814
815         webkitpy: Expose device_type from host-like objects
816         https://bugs.webkit.org/show_bug.cgi?id=193406
817         <rdar://problem/47262305>
818
819         Reviewed by Lucas Forschler.
820
821         Devices should expose device_type. As a result, all host objects should
822         provide a device_type property, even if they do not yet define a device_type.
823
824         * Scripts/webkitpy/common/system/systemhost.py:
825         (SystemHost):
826         (SystemHost.device_type):
827         * Scripts/webkitpy/common/system/systemhost_mock.py:
828         (MockSystemHost):
829         (MockSystemHost.device_type):
830         * Scripts/webkitpy/port/device.py:
831         (Device):
832         (Device.device_type):
833         * Scripts/webkitpy/xcode/simulated_device.py:
834         (SimulatedDeviceManager._find_exisiting_device_for_request):
835         (SimulatedDeviceManager._disambiguate_device_type):
836         (SimulatedDeviceManager._does_fulfill_request):
837         (SimulatedDeviceManager.device_count_for_type):
838         (SimulatedDeviceManager.initialize_devices):
839         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
840         (test_available_devices):
841         (test_swapping_devices):
842
843 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
844
845         webkitpy: Support alternate simctl device list output (Follow-up fix)
846         https://bugs.webkit.org/show_bug.cgi?id=193362
847         <rdar://problem/47122965>
848
849         Rubber-stamped by Lucas Forschler.
850
851         * Scripts/webkitpy/xcode/simulated_device.py:
852         (SimulatedDeviceManager.populate_available_devices):
853
854 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
855
856         [iOS] Expose SPI to access the current sentence boundary and selection state
857         https://bugs.webkit.org/show_bug.cgi?id=193398
858         <rdar://problem/45893108>
859
860         Reviewed by Dean Jackson.
861
862         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
863         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
864         expected.
865
866         * TestWebKitAPI/EditingTestHarness.h:
867         * TestWebKitAPI/EditingTestHarness.mm:
868         (-[EditingTestHarness moveBackward]):
869         (-[EditingTestHarness moveForward]):
870         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
871
872         Add a couple of new helper methods on EditingTestHarness.
873
874         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
875         (-[SelectionChangeObserver initWithWebView:]):
876         (-[SelectionChangeObserver webView]):
877         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
878         (-[SelectionChangeObserver currentSelectionAttributes]):
879
880 2019-01-14  Zalan Bujtas  <zalan@apple.com>
881
882         [LFC][BFC] Add basic box-sizing support.
883         https://bugs.webkit.org/show_bug.cgi?id=193392
884
885         Reviewed by Antti Koivisto.
886
887         * LayoutReloaded/misc/LFC-passing-tests.txt:
888
889 2019-01-14  Charlie Turner  <cturner@igalia.com>
890
891         [WPE] API test gardening
892         https://bugs.webkit.org/show_bug.cgi?id=193319
893
894         Reviewed by Michael Catanzaro.
895
896         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
897         passing tests.
898
899 2019-01-14  Charlie Turner  <cturner@igalia.com>
900
901         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
902         https://bugs.webkit.org/show_bug.cgi?id=192977
903
904         Reviewed by Carlos Garcia Campos.
905
906         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
907         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
908         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
909         (TestWebKitAPI::GStreamerTest::SetUp):
910         (TestWebKitAPI::GStreamerTest::TearDown):
911         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
912         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
913         (TestWebKitAPI::TEST_F):
914
915 2019-01-14  Charlie Turner  <cturner@igalia.com>
916
917         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
918         https://bugs.webkit.org/show_bug.cgi?id=193332
919
920         Reviewed by Michael Catanzaro.
921
922         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
923         defined as a char16_t, which changed in ICU 59, the
924         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
925         unsigned short. This test is relying on the behaviour that
926         UChar=unsigned short, which doesn't hold across platforms and ICU
927         library versions. The full fix would be a special syntax for
928         literal characters so that these ambiguities do not arise. That
929         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
930         (TestWebKitAPI::TEST):
931
932 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
933
934         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
935
936         * Scripts/make-dist:
937         (Distcheck.configure):
938
939 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
940
941         [ews-build] Update macOS queue configurations
942         https://bugs.webkit.org/show_bug.cgi?id=193365
943         <rdar://problem/47221073>
944
945         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
946
947         * BuildSlaveSupport/ews-build/config.json:
948
949 2019-01-13  Zalan Bujtas  <zalan@apple.com>
950
951         [LFC] Adjust assert for statically positioned fixed elements
952         https://bugs.webkit.org/show_bug.cgi?id=193385
953
954         Reviewed by Antti Koivisto.
955
956         * LayoutReloaded/misc/LFC-passing-tests.txt:
957
958 2019-01-13  Philippe Normand  <pnormand@igalia.com>
959
960         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
961         https://bugs.webkit.org/show_bug.cgi?id=193387
962
963         Reviewed by Carlos Garcia Campos.
964
965         * MiniBrowser/wpe/main.cpp:
966         (main):
967
968 2019-01-12  Timothy Hatcher  <timothy@apple.com>
969
970         Have prefers-color-scheme: light always match on macOS versions before Mojave.
971         https://bugs.webkit.org/show_bug.cgi?id=191655
972         rdar://problem/46074680
973
974         Reviewed by Megan Gardner.
975
976         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
977         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
978
979 2019-01-12  Dan Bernstein  <mitz@apple.com>
980
981         [Cocoa] Avoid importing directly from subumbrella frameworks
982         https://bugs.webkit.org/show_bug.cgi?id=186016
983         <rdar://problem/40591038>
984
985         Reviewed by Sam Weinig.
986
987         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
988           LaunchServices header.
989         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
990           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
991         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
992           when using SDKs earlier than 10.13.
993         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
994           and OTHER_CPLUSPLUSFLAGS.
995         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
996           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
997         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
998           LaunchServices header.
999
1000 2019-01-11  John Wilander  <wilander@apple.com>
1001
1002         Compile out Web API Statistics Collection
1003         https://bugs.webkit.org/show_bug.cgi?id=193370
1004         <rdar://problem/45388584>
1005
1006         Reviewed by Brent Fulgham.
1007
1008         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1009             Defined ENABLE_WEB_API_STATISTICS, off by default.
1010
1011 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1012
1013         [WPE] Add gtk-doc
1014         https://bugs.webkit.org/show_bug.cgi?id=178900
1015
1016         Reviewed by Michael Catanzaro.
1017
1018         Add Tools/gtkdoc to manifest.txt.in files.
1019         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1020
1021         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1022         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1023
1024 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1025
1026         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1027         https://bugs.webkit.org/show_bug.cgi?id=193364
1028         <rdar://problem/47214117>
1029
1030         Reviewed by Tim Horton.
1031
1032         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1033         precise, whereas dragging near the middle of the textarea does.
1034
1035         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1036         (TestWebKitAPI::TEST):
1037
1038 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1039
1040         webkitpy: Support alternate simctl device list output
1041         https://bugs.webkit.org/show_bug.cgi?id=193362
1042         <rdar://problem/47122965>
1043
1044         Reviewed by Lucas Forschler.
1045
1046         * Scripts/webkitpy/xcode/simulated_device.py:
1047         (SimulatedDeviceManager.populate_available_devices):
1048
1049 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1050
1051         [ews-build] Update macOS queue configurations
1052         https://bugs.webkit.org/show_bug.cgi?id=193365
1053
1054         Reviewed by Lucas Forschler.
1055
1056         * BuildSlaveSupport/ews-build/config.json:
1057
1058 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1059
1060         webkitpy: Incorporate device type into baseline search path
1061         https://bugs.webkit.org/show_bug.cgi?id=193356
1062         <rdar://problem/47215515>
1063
1064         Reviewed by Lucas Forschler.
1065
1066         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1067
1068         * Scripts/webkitpy/port/base.py:
1069         (Port.default_baseline_search_path): Allow device type to be passed in.
1070         * Scripts/webkitpy/port/gtk.py:
1071         (GtkPort.default_baseline_search_path): Ignore device type.
1072         * Scripts/webkitpy/port/ios.py:
1073         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1074         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1075         * Scripts/webkitpy/port/ios_device_unittest.py:
1076         (IOSDeviceTest):
1077         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1078         (IOSSimulatorTest):
1079         * Scripts/webkitpy/port/mac.py:
1080         (MacPort.default_baseline_search_path): Ignore device type.
1081         * Scripts/webkitpy/port/watch.py:
1082         (WatchPort.default_baseline_search_path): Ditto.
1083         * Scripts/webkitpy/port/win.py:
1084         (WinPort.default_baseline_search_path): Ditto.
1085         (WinCairoPort.default_baseline_search_path): Ditto.
1086         * Scripts/webkitpy/port/wpe.py:
1087         (WPEPort.default_baseline_search_path): Ditto.
1088
1089 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1090
1091         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1092         https://bugs.webkit.org/show_bug.cgi?id=193352
1093         <rdar://problem/47210736>
1094
1095         Reviewed by Lucas Forschler.
1096
1097         * Scripts/webkitpy/layout_tests/views/printing.py:
1098         (Printer.print_config): Print list on only baseline search paths which exist. 
1099         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1100         (Testprinter.test_print_config):
1101
1102 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1103
1104         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1105         https://bugs.webkit.org/show_bug.cgi?id=193340
1106
1107         Reviewed by David Kilzer.
1108
1109         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1110         (WTR::InjectedBundle::didReceiveMessageToPage):
1111         Pull the strings out into a WKRetainPtr.
1112
1113         * WebKitTestRunner/WebNotificationProvider.cpp:
1114         (WTR::WebNotificationProvider::closeWebNotification):
1115         Adopt the created value into the WKRetainPtr.
1116
1117         * WebKitTestRunner/mac/TestControllerMac.mm:
1118         (WTR::generateWhitelist):
1119         Immediately adopt a created value to avoid potential mistakes.
1120
1121 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1122
1123         Enable DFG on ARM/Linux again
1124         https://bugs.webkit.org/show_bug.cgi?id=192496
1125
1126         Reviewed by Yusuke Suzuki.
1127
1128         After changing the bytecode format DFG was disabled on all 32-bit
1129         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1130         on ARM by default.
1131
1132         * Scripts/run-jsc-stress-tests:
1133
1134 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1135
1136         Unreviewed, fix #ifdef in API test added in r239851.
1137         https://bugs.webkit.org/show_bug.cgi?id=193327
1138         rdar://problem/47093222
1139
1140         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1141
1142 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1143
1144         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1145         https://bugs.webkit.org/show_bug.cgi?id=193109
1146         <rdar://problem/44807048>
1147
1148         Reviewed by Ryosuke Niwa.
1149
1150         Introduce and respect a test option to enable the UndoManager API.
1151
1152         * WebKitTestRunner/TestController.cpp:
1153         (WTR::updateTestOptionsFromTestHeader):
1154         * WebKitTestRunner/TestOptions.h:
1155         (WTR::TestOptions::hasSameInitializationOptions const):
1156         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1157         (WTR::TestController::platformCreateWebView):
1158
1159 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1160
1161         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1162         https://bugs.webkit.org/show_bug.cgi?id=193346
1163
1164         Reviewed by Antti Koivisto.
1165
1166         * LayoutReloaded/misc/LFC-passing-tests.txt:
1167
1168 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1169
1170         Unreviewed, fix typo that breaks dashboard link.
1171
1172         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1173         (WebKitBuildbot):
1174
1175 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1176
1177         Update macOS queue configurations
1178         https://bugs.webkit.org/show_bug.cgi?id=193329
1179
1180         Reviewed by Alexey Proskuryakov.
1181
1182         * BuildSlaveSupport/build.webkit.org-config/config.json:
1183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1184         (BubbleQueueServer):
1185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1187         (WebKitBuildbot):
1188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1189         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
1190         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1191
1192 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1193
1194         MiniBrowser should be able to navigate to about:blank
1195         https://bugs.webkit.org/show_bug.cgi?id=193345
1196
1197         Reviewed by Simon Fraser.
1198
1199         * MiniBrowser/mac/BrowserWindowController.m:
1200         (-[BrowserWindowController addProtocolIfNecessary:]):
1201         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
1202
1203         * MiniBrowser/mac/WK1BrowserWindowController.m:
1204         (-[WK1BrowserWindowController fetch:]):
1205         * MiniBrowser/mac/WK2BrowserWindowController.m:
1206         (-[WK2BrowserWindowController fetch:]):
1207         Clean up the code that uses this to match style.
1208
1209 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1210
1211         Remove MiniBrowser custom "Process Swap" menu item which does not work
1212         https://bugs.webkit.org/show_bug.cgi?id=193344
1213
1214         Reviewed by Simon Fraser.
1215
1216         There is a menu item under the Experimental menu that does work.
1217
1218         * MiniBrowser/mac/AppDelegate.m:
1219         (defaultConfiguration):
1220         * MiniBrowser/mac/SettingsController.h:
1221         * MiniBrowser/mac/SettingsController.m:
1222         (-[SettingsController _populateMenu]):
1223         (-[SettingsController validateMenuItem:]):
1224         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
1225         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
1226
1227 2019-01-10  Timothy Hatcher  <timothy@apple.com>
1228
1229         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
1230         https://bugs.webkit.org/show_bug.cgi?id=193327
1231         rdar://problem/47093222
1232
1233         Reviewed by Tim Horton.
1234
1235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1236         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
1237         (TestWebKitAPI::didFinishNavigation):
1238         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1239         (TestWebKitAPI::TEST):
1240         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
1241         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
1242         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
1243         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1244         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
1245
1246 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1247
1248         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
1249         https://bugs.webkit.org/show_bug.cgi?id=193338
1250         <rdar://problem/46664774>
1251
1252         Reviewed by David Kilzer.
1253
1254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1255         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1256
1257 2019-01-10  Commit Queue  <commit-queue@webkit.org>
1258
1259         Unreviewed, rolling out r239825.
1260         https://bugs.webkit.org/show_bug.cgi?id=193330
1261
1262         Broke tests on armv7/linux bots (Requested by guijemont on
1263         #webkit).
1264
1265         Reverted changeset:
1266
1267         "Enable DFG on ARM/Linux again"
1268         https://bugs.webkit.org/show_bug.cgi?id=192496
1269         https://trac.webkit.org/changeset/239825
1270
1271 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
1272
1273         Disable the run-jsc-stress-test remote host key check.
1274         https://bugs.webkit.org/show_bug.cgi?id=192988
1275
1276         Reviewed by Alexey Proskuryakov.
1277
1278         * Scripts/run-jsc-stress-tests:
1279
1280 2019-01-10  John Wilander  <wilander@apple.com>
1281
1282         Override the session configuration for cookieAcceptPolicy
1283         https://bugs.webkit.org/show_bug.cgi?id=190925
1284         <rdar://problem/45497382>
1285
1286         Reviewed by Alexey Proskuryakov and Alex Christensen.
1287
1288         Test infrastructure for setting a first-party-only cookie policy.
1289
1290         * DumpRenderTree/TestRunner.cpp:
1291         (setOnlyAcceptFirstPartyCookiesCallback):
1292         (TestRunner::staticFunctions):
1293         * DumpRenderTree/TestRunner.h:
1294         * DumpRenderTree/mac/TestRunnerMac.mm:
1295         (TestRunner::setOnlyAcceptFirstPartyCookies):
1296         * DumpRenderTree/win/TestRunnerWin.cpp:
1297         (TestRunner::setOnlyAcceptFirstPartyCookies):
1298         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1299         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1300         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1301         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1302         * WebKitTestRunner/TestInvocation.cpp:
1303         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1304
1305 2019-01-09  Matt Rajca  <mrajca@apple.com>
1306
1307         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
1308         https://bugs.webkit.org/show_bug.cgi?id=193301
1309
1310         Reviewed by Jer Noble.
1311         
1312         Added API tests.
1313
1314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1315         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1316         (TEST):
1317         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
1318
1319 2019-01-10  Zalan Bujtas  <zalan@apple.com>
1320
1321         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
1322         https://bugs.webkit.org/show_bug.cgi?id=193310
1323
1324         Reviewed by Antti Koivisto.
1325
1326         * LayoutReloaded/misc/LFC-passing-tests.txt:
1327
1328 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
1329
1330         Enable DFG on ARM/Linux again
1331         https://bugs.webkit.org/show_bug.cgi?id=192496
1332
1333         Reviewed by Yusuke Suzuki.
1334
1335         After changing the bytecode format DFG was disabled on all 32-bit
1336         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1337         on ARM by default.
1338
1339         * Scripts/run-jsc-stress-tests:
1340
1341 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1342
1343         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
1344         https://bugs.webkit.org/show_bug.cgi?id=193271
1345
1346         Reviewed by Brent Fulgham.
1347
1348         BSTR is a special data structure created by SysAllocString, not a
1349         wchar_t null-terminated string.
1350
1351         * DumpRenderTree/win/TestRunnerWin.cpp:
1352         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
1353         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1354         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
1355         BSTR from wide string literals.
1356
1357 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
1358
1359         Tweak wording for build/version_check style checker error
1360         https://bugs.webkit.org/show_bug.cgi?id=193256
1361
1362         Reviewed by Tim Horton.
1363
1364         * Scripts/webkitpy/style/checkers/cpp.py:
1365         (check_os_version_checks):
1366         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1367         (WebKitStyleTest.test_os_version_checks):
1368
1369 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1370
1371         [ews-build] Add link to bug along with bug title
1372         https://bugs.webkit.org/show_bug.cgi?id=193293
1373
1374         Reviewed by Lucas Forschler.
1375
1376         * BuildSlaveSupport/ews-build/steps.py:
1377         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
1378         (ConfigureBuild.add_bug_id_url): Deleted.
1379         (ConfigureBuild.getBugURL): Deleted.
1380
1381 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1382
1383         [ews-build] Use https for ews-build server
1384         https://bugs.webkit.org/show_bug.cgi?id=193193
1385
1386         Reviewed by Lucas Forschler.
1387
1388         * BuildSlaveSupport/ews-build/steps.py:
1389
1390 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1391
1392         [ews-build] Parse and display number of style failures
1393         https://bugs.webkit.org/show_bug.cgi?id=193280
1394
1395         Reviewed by Lucas Forschler.
1396
1397         * BuildSlaveSupport/ews-build/steps.py:
1398         (CheckStyle): Use TestWithFailureCount as base class.
1399         (CheckStyle.countFailures): Count the number of style failures.
1400
1401 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1402
1403         [ews-build] use patch_id instead of ewspatchid
1404         https://bugs.webkit.org/show_bug.cgi?id=193235
1405
1406         Reviewed by Lucas Forschler.
1407
1408         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
1409         * BuildSlaveSupport/ews-build/steps.py: Ditto.
1410         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
1411
1412 2019-01-09  Zalan Bujtas  <zalan@apple.com>
1413
1414         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
1415         https://bugs.webkit.org/show_bug.cgi?id=192625
1416
1417         Reviewed by Antti Koivisto.
1418
1419         * LayoutReloaded/misc/LFC-passing-tests.txt:
1420
1421 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1422
1423         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
1424         https://bugs.webkit.org/show_bug.cgi?id=192841
1425
1426         Reviewed by Carlos Garcia Campos.
1427
1428         There are separate g_assert_*() macros for use in tests, which we use inconsistently
1429         currently. Use them always. We'll get nicer error messages now when tests fail, and the
1430         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
1431
1432         Note that the documentation of g_assert() says that it is not to be used when writing tests.
1433
1434         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1435         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
1436         (WebKitWebEditorTest::testSelectionChanged):
1437         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1438         (WebKitFrameTest::testMainFrame):
1439         (WebKitFrameTest::testURI):
1440         (WebKitFrameTest::testJavaScriptContext):
1441         (WebKitFrameTest::testJavaScriptValues):
1442         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1443         (testWebViewAuthenticationRequest):
1444         (testWebViewAuthenticationLoadCancelled):
1445         (testWebViewAuthenticationFailure):
1446         (testWebViewAuthenticationStorage):
1447         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1448         (testWebViewAuthenticationProxy):
1449         (testWebViewAuthenticationProxyHTTPS):
1450         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1451         (testAutomationSessionRequestSession):
1452         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1453         (testBackForwardListNavigation):
1454         (testWebKitWebViewSessionState):
1455         (testWebKitWebViewSessionStateWithFormData):
1456         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1457         (ConsoleMessageTest::consoleMessageReceivedCallback):
1458         (testWebKitConsoleMessageConsoleAPI):
1459         (testWebKitConsoleMessageJavaScriptException):
1460         (testWebKitConsoleMessageNetworkError):
1461         (testWebKitConsoleMessageSecurityError):
1462         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1463         (testCookieManagerAcceptPolicy):
1464         (testCookieManagerCookiesChanged):
1465         (testCookieManagerPersistentStorage):
1466         (testCookieManagerPersistentStorageDeleteAll):
1467         (testCookieManagerEphemeral):
1468         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
1469         (testWebKitDOMElementAutoFill):
1470         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1471         (downloadLocalFileSuccessfully):
1472         (createFileAtDestination):
1473         (testDownloadOverwriteDestinationDisallowed):
1474         (testDownloadLocalFileError):
1475         (testDownloadRemoteFile):
1476         (testDownloadRemoteFileError):
1477         (testWebViewDownloadURI):
1478         (testPolicyResponseDownload):
1479         (testPolicyResponseDownloadCancel):
1480         (testDownloadMIMEType):
1481         (contextMenuCallback):
1482         (testContextMenuDownloadActions):
1483         (testBlobDownload):
1484         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
1485         (testWebKitWebEditorSelectionChanged):
1486         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1487         (testWebKitFrameMainFrame):
1488         (testWebKitFrameURI):
1489         (testWebKitFrameJavaScriptContext):
1490         (testWebKitFrameJavaScriptValues):
1491         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1492         (LoadStopTrackingTest::loadFailed):
1493         (testWebViewTitle):
1494         (testURIRequestHTTPHeaders):
1495         (testURIRequestHTTPMethod):
1496         (testURIResponseHTTPHeaders):
1497         (testRedirectToDataURI):
1498         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1499         (testProcessPerWebView):
1500         (testWebProcessLimit):
1501         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1502         (testWebViewResources):
1503         (testWebResourceLoading):
1504         (testWebResourceSuggestedFilename):
1505         (testWebResourceGetData):
1506         (testWebResourceGetDataError):
1507         (testWebViewResourcesHistoryCache):
1508         (testWebResourceSendRequest):
1509         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1510         (testSSL):
1511         (testInsecureContent):
1512         (testTLSErrorsPolicy):
1513         (testTLSErrorsRedirect):
1514         (testTLSErrorsHTTPAuth):
1515         (testLoadFailedWithTLSErrors):
1516         (testSubresourceLoadFailedWithTLSErrors):
1517         (httpsServerCallback):
1518         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1519         (testWebViewCreateNavigationData):
1520         (testWebViewJavaScriptDialogs):
1521         (testWebViewWindowProperties):
1522         (testWebViewMouseTarget):
1523         (testWebViewFileChooserRequest):
1524         (testWebViewColorChooserRequest):
1525         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1526         (testWebExtensionGetTitle):
1527         (testDocumentLoadedSignal):
1528         (testWebKitWebViewProcessCrashed):
1529         (testWebExtensionWindowObjectCleared):
1530         (testWebExtensionIsolatedWorld):
1531         (permissionRequestCallback):
1532         (didAssociateFormControlsCallback):
1533         (testWebExtensionFormControlsAssociated):
1534         (FormSubmissionTest::FormSubmissionTest):
1535         (FormSubmissionTest::testFormSubmissionResult):
1536         (testWebExtensionFormSubmissionSteps):
1537         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1538         (testNotInitialized):
1539         (testClearDatabase):
1540         (testPrivateBrowsing):
1541         (testGetFavicon):
1542         (testWebViewFavicon):
1543         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1544         (testFindControllerTextFound):
1545         (testFindControllerTextNotFound):
1546         (testFindControllerMatchCount):
1547         (testFindControllerMaxMatchCount):
1548         (testFindControllerNext):
1549         (testFindControllerPrevious):
1550         (testFindControllerCountedMatches):
1551         (testFindControllerOptions):
1552         (testFindControllerHide):
1553         (testFindControllerInstance):
1554         (testFindControllerGetters):
1555         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
1556         (testNavigationPolicy):
1557         (testResponsePolicy):
1558         (testNewWindowPolicy):
1559         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1560         (testSecurityOriginBasicConstructor):
1561         (testSecurityOriginURIConstructor):
1562         (testSecurityOriginDefaultPort):
1563         (testSecurityOriginFileURI):
1564         (testOpaqueSecurityOrigin):
1565         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1566         (testWebKitSettings):
1567         (testWebKitSettingsNewWithSettings):
1568         (testWebKitSettingsUserAgent):
1569         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1570         (testWebViewNewWithUserContentManager):
1571         (isStyleSheetInjectedForURLAtPath):
1572         (isScriptInjectedForURLAtPath):
1573         (testUserContentManagerInjectedStyleSheet):
1574         (testUserContentManagerInjectedScript):
1575         (UserScriptMessageTest::scriptMessageReceived):
1576         (UserScriptMessageTest::waitUntilMessageReceived):
1577         (UserScriptMessageTest::runJavaScriptFinished):
1578         (testUserContentManagerScriptMessageReceived):
1579         (testUserContentManagerScriptMessageInWorldReceived):
1580         (testUserContentManagerScriptMessageFromDOMBindings):
1581         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1582         (testWebContextDefault):
1583         (testWebContextEphemeral):
1584         (testWebContextGetPlugins):
1585         (testWebContextURIScheme):
1586         (testWebContextSpellChecker):
1587         (testWebContextLanguages):
1588         (consoleMessageReceivedCallback):
1589         (testWebContextSecurityFileXHR):
1590         (ProxyTest::ProxyTest):
1591         (testWebContextProxySettings):
1592         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1593         (testWebViewWebContext):
1594         (testWebViewWebBackend):
1595         (testWebViewEphemeral):
1596         (testWebViewCustomCharset):
1597         (testWebViewSettings):
1598         (testWebViewRunJavaScript):
1599         (testWebViewCanShowMIMEType):
1600         (testWebViewSubmitForm):
1601         (testWebViewSave):
1602         (testWebViewPageVisibility):
1603         (testWebViewSnapshot):
1604         (testWebViewNotification):
1605         (testWebViewNotificationInitialPermissionAllowed):
1606         (testWebViewNotificationInitialPermissionDisallowed):
1607         (testWebViewIsPlayingAudio):
1608         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1609         (WebsiteDataTest::WebsiteDataTest):
1610         (WebsiteDataTest::remove):
1611         (WebsiteDataTest::clear):
1612         (testWebsiteDataConfiguration):
1613         (testWebsiteDataEphemeral):
1614         (testWebsiteDataCache):
1615         (testWebsiteDataStorage):
1616         (testWebsiteDataDatabases):
1617         (testWebsiteDataAppcache):
1618         (testWebsiteDataCookies):
1619         (testWebsiteDataDeviceIdHashSalt):
1620         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1621         (emitDocumentLoaded):
1622         (emitURIChanged):
1623         (sendRequestCallback):
1624         (contextMenuCallback):
1625         (consoleMessageSentCallback):
1626         (emitFormControlsAssociated):
1627         (formControlsAssociatedCallback):
1628         (emitFormSubmissionEvent):
1629         (willSubmitFormCallback):
1630         (windowObjectCleared):
1631         (methodCallCallback):
1632         (registerGResource):
1633         (webkit_web_extension_initialize_with_user_data):
1634         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
1635         (checkLeaks):
1636         (WebProcessTest::create):
1637         (runTest):
1638         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
1639         (AutocleanupsTest::testWebProcessAutocleanups):
1640         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
1641         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
1642         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
1643         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1644         (WebKitDOMDOMWindowTest::testSignals):
1645         (WebKitDOMDOMWindowTest::testDispatchEvent):
1646         (WebKitDOMDOMWindowTest::testGetComputedStyle):
1647         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
1648         (WebKitDOMNodeFilterTest::testTreeWalker):
1649         (WebKitDOMNodeFilterTest::testNodeIterator):
1650         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
1651         (WebKitDOMNodeTest::testHierarchyNavigation):
1652         (WebKitDOMNodeTest::testInsertion):
1653         (WebKitDOMNodeTest::testTagNamesNodeList):
1654         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1655         (WebKitDOMNodeTest::testDOMCache):
1656         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
1657         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1658         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1659         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1660         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
1661         (testUIProcessAutocleanups):
1662         (testWebProcessAutocleanups):
1663         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1664         (testContextMenuPopulateMenu):
1665         (testContextMenuDismissed):
1666         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
1667         (testWebKitDOMClientRectDivBoundingClientRectPosition):
1668         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
1669         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
1670         (testWebKitDOMDOMWindowSignals):
1671         (testWebKitDOMDOMWindowDispatchEvent):
1672         (testWebKitDOMDOMWindowGetComputedStyle):
1673         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
1674         (testWebKitDOMNodeHierarchyNavigation):
1675         (testWebKitDOMNodeInsertion):
1676         (testWebKitDOMNodeTagNamesNodeList):
1677         (testWebKitDOMNodeTagNamesHTMLCollection):
1678         (testWebKitDOMObjectCache):
1679         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
1680         (testWebKitDOMNodeFilterTreeWalker):
1681         (testWebKitDOMNodeFilterNodeIterator):
1682         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
1683         (testWebKitDOMXPathNSResolverNative):
1684         (testWebKitDOMXPathNSResolverCustom):
1685         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1686         (testInspectorDefault):
1687         (testInspectorManualAttachDetach):
1688         (testInspectorCustomContainerDestroyed):
1689         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
1690         (startTestServer):
1691         (testInspectorServerPageList):
1692         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
1693         (OptionMenuTest::showOptionMenuCallback):
1694         (OptionMenuTest::menuCloseCallback):
1695         (OptionMenuTest::close):
1696         (OptionMenuTest::activateItem):
1697         (OptionMenuTest::selectItem):
1698         (testOptionMenuSimple):
1699         (testOptionMenuGroups):
1700         (testOptionMenuActivate):
1701         (testOptionMenuSelect):
1702         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1703         (testPrintOperationPrintSettings):
1704         (webViewPrintCallback):
1705         (testPrintOperationPrint):
1706         (testPrintCustomWidget):
1707         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1708         (checkAtspiAccessible):
1709         (testAtspiBasicHierarchy):
1710         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
1711         (testWebKitCheckVersion):
1712         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1713         (testWebViewEditorCutCopyPasteNonEditable):
1714         (testWebViewEditorCutCopyPasteEditable):
1715         (testWebViewEditorSelectAllNonEditable):
1716         (testWebViewEditorSelectAllEditable):
1717         (loadContentsAndTryToCutSelection):
1718         (testWebViewEditorNonEditable):
1719         (testWebViewEditorEditable):
1720         (testWebViewEditorEditorStateTypingAttributes):
1721         (testWebViewEditorInsertImage):
1722         (testWebViewEditorCreateLink):
1723         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1724         (loadChangedCallback):
1725         (loadFailedCallback):
1726         (loadFailedWithTLSErrorsCallback):
1727         (LoadTrackingTest::LoadTrackingTest):
1728         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1729         (registerGResource):
1730         (removeNonEmptyDirectory):
1731         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1732         (Test::adoptView):
1733         (Test::~Test):
1734         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1735         (WebKitTestBus::getOrCreateConnection):
1736         (WebKitTestBus::createProxy):
1737         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1738         (WebKitTestServer::getWebSocketURIForPath const):
1739         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1740         (WebViewTest::initializeWebView):
1741         (WebViewTest::loadURI):
1742         (WebViewTest::loadHtml):
1743         (WebViewTest::loadPlainText):
1744         (WebViewTest::loadBytes):
1745         (WebViewTest::loadRequest):
1746         (WebViewTest::loadAlternateHTML):
1747         (WebViewTest::goBack):
1748         (WebViewTest::goForward):
1749         (WebViewTest::goToBackForwardListItem):
1750         (resourceGetDataCallback):
1751         (WebViewTest::mainResourceData):
1752         (WebViewTest::javascriptResultToCString):
1753         (WebViewTest::javascriptResultToNumber):
1754         (WebViewTest::javascriptResultToBoolean):
1755         (WebViewTest::javascriptResultIsNull):
1756         (WebViewTest::javascriptResultIsUndefined):
1757         (onSnapshotReady):
1758         (WebViewTest::runWebProcessTest):
1759         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
1760         (WebViewTest::platformInitializeWebView):
1761         (WebViewTest::showInWindow):
1762         (WebViewTest::showInWindowAndWaitUntilMapped):
1763         (WebViewTest::mouseMoveTo):
1764         (WebViewTest::emitPopupMenuSignal):
1765         (WebViewTest::keyStroke):
1766         (WebViewTest::doMouseButtonEvent):
1767
1768 2019-01-09  Philippe Normand  <pnormand@igalia.com>
1769
1770         [WPE] API tests can't run in flatpak environment
1771         https://bugs.webkit.org/show_bug.cgi?id=193242
1772
1773         Reviewed by Michael Catanzaro.
1774
1775         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
1776         flatpakutils so that it knows which port it's dealing with.
1777         * glib/common.py: Remove build_dir globals so that subsequent
1778         calls actually take args into account.
1779         (library_build_path):
1780         (binary_build_path):
1781
1782 2019-01-08  Dean Jackson  <dino@apple.com>
1783
1784         Blob references for System Previews don't get a correct file extension
1785         https://bugs.webkit.org/show_bug.cgi?id=193268
1786         <rdar://problem/47133037>
1787
1788         Reviewed by Tim Horton.
1789
1790         New test that a Blob download of a USDZ file gets named correctly.
1791
1792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1793         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1794         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1795         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
1796         (TEST):
1797         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
1798
1799 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
1800
1801         [WebAuthN] Support U2F HID Authenticators on macOS
1802         https://bugs.webkit.org/show_bug.cgi?id=191535
1803         <rdar://problem/47102027>
1804
1805         Reviewed by Brent Fulgham.
1806
1807         This patch:
1808         1) adds support for U2F mocking mechanism;
1809         2) updates tests to reflect U2fCommandConstructor changes.
1810
1811         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1812         (TestWebKitAPI::TEST):
1813         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1814         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1815         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1816
1817 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1818
1819         [iOS] Dispatch a synthetic mousedown event prior to starting drags
1820         https://bugs.webkit.org/show_bug.cgi?id=193229
1821         <rdar://problem/46717097>
1822
1823         Reviewed by Tim Horton.
1824
1825         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
1826         prevents a drag from starting.
1827
1828         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1829         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
1830
1831         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
1832
1833 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
1834   
1835         Layout test will generate a perf metric file to results dir.
1836         https://bugs.webkit.org/show_bug.cgi?id=192030
1837         <rdar://problem/32779516>
1838
1839         Reviewed by Aakash Jain.
1840
1841         Layout test running time will be collected to a perf metric file.
1842         For now, instead of outputing running time of all tests (which is huge),
1843         we aggregate them by test directories which are at most two level deep. 
1844
1845         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1846         (Manager._end_test_run):
1847         (Manager._output_perf_metrics):
1848         (Manager._print_expectation_line_for_test):
1849         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1850         (add_test_perf_metric):
1851         (test_perf_metrics):
1852         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1853         (JSONGeneratorTest.test_test_timings_trie):
1854         (JSONGeneratorTest):
1855         (JSONGeneratorTest.test_test_perf_metrics):
1856         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1857         (RebaselineTest.test_reset_results):
1858         (RebaselineTest.test_missing_results):
1859         (RebaselineTest.test_new_baseline):
1860
1861 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
1862
1863         [WPE][GTK] Add php-json to install-dependencies
1864         https://bugs.webkit.org/show_bug.cgi?id=193233
1865
1866         Reviewed by Michael Catanzaro.
1867
1868         * gtk/install-dependencies:
1869         * wpe/install-dependencies:
1870
1871 2019-01-08  Chris Dumez  <cdumez@apple.com>
1872
1873         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
1874         https://bugs.webkit.org/show_bug.cgi?id=193224
1875         <rdar://problem/47097726>
1876
1877         Reviewed by Alex Christensen.
1878
1879         Add API test coverage.
1880
1881         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1882
1883 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1884
1885         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
1886         <https://webkit.org/b/193222>
1887         <rdar://problem/46862309>
1888
1889         Reviewed by Joseph Pecoraro.
1890
1891         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1892         (WTR::executeCallback): Fix camel case of variable name.
1893         (WTR::EventSendingController::callAfterScrollingCompletes): If
1894         WKBundlePageRegisterScrollOperationCompletionCallback() returns
1895         false, make sure to release the ScrollCompletionCallbackData
1896         object.  This fixes the leak.
1897
1898 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1899
1900         [Win] EWS: wincairo-ews cannot apply a patch with *.png
1901         https://bugs.webkit.org/show_bug.cgi?id=193044
1902
1903         Reviewed by Daniel Bates.
1904
1905         WinCairo EWS bots are using Windows Perl. Binary files should be
1906         opened as binary mode.
1907
1908         * Scripts/svn-apply:
1909         (handleGitBinaryChange): Use 'binmode' for binary file handles.
1910
1911 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
1912
1913         [CMake] Add ENABLE_CSS_TYPED_OM option
1914         https://bugs.webkit.org/show_bug.cgi?id=193216
1915
1916         Reviewed by Michael Catanzaro.
1917
1918         * Scripts/webkitperl/FeatureList.pm:
1919
1920 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1921
1922         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1923         <https://webkit.org/b/193056>
1924
1925         Reviewed by Alex Christensen.
1926
1927         * Scripts/webkitpy/style/checker.py:
1928         - Ignore use of new runtime/retainptr check in
1929           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
1930           contains tests to ensure RetainPtr<NSObject *> is compatible
1931           with RetainPtr<NSObject>.
1932
1933         * Scripts/webkitpy/style/checkers/cpp.py:
1934         (check_language):
1935         (CppChecker):
1936         - Add checker for use of '*' in RetainPtr<> type.  A for loop
1937           was used instead of a single regex so that angle brackets
1938           could be matched up when checking the type contained within
1939           the RetainPtr<> type.
1940
1941         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1942         (CppStyleTest):
1943         - Add unit test for new runtime/retainptr check.
1944
1945         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
1946         * TestWebKitAPI/EditingTestHarness.h:
1947         - Remove '*' from RetainPtr<> type.
1948
1949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1950         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
1951           regressed in r201938.
1952
1953         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1954         (TestWebKitAPI::TEST):
1955         - Update tests to match RetainPtr.mm tests (except for the
1956           `*SimilarNSType` tests since there is no CF equivalent of
1957           RetainPtr<NSString> and RetainPtr<NSString *>).
1958
1959         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1960         (TestWebKitAPI::TEST):
1961         - Update tests to:
1962           - Not conflict by name with equivalent CF tests in
1963             RetainPtr.cpp.
1964           - Add test cases for RetainPtr<NSObject>,
1965             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
1966           - Add `*SimilarNSType` tests for converting between
1967             RetainPtr<NSObject> and RetainPtr<NSObject *>.
1968           - Change `0` to `nil` as appropriate.
1969           - Re-alphabetize the tests by name.
1970           - Add Optional<RetainPtr<>> tests.
1971           - Add retainPtr() tests.
1972
1973         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1974         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1975         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
1976         (TEST):
1977         - Remove '*' from RetainPtr<> type.
1978
1979         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
1980         (TEST(WebKit, JITEnabled)):
1981         - Add missing WTFMove().  Apparently a temporary was being
1982           created before in the argument list due to mismatched
1983           RetainPtr<> types.
1984
1985         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1986         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
1987         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
1988         (TestWebKitAPI::TEST):
1989         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1990         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1991         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1992         (WTR::resourcesDirectoryURL):
1993         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1994         (WTR::InjectedBundle::platformInitialize):
1995         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1996         - Remove '*' from RetainPtr<> type.
1997
1998 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
1999
2000         A MediaTime timescale must never be zero
2001         https://bugs.webkit.org/show_bug.cgi?id=193156
2002         <rdar://problem/32504501>
2003
2004         Reviewed by Jer Noble.
2005
2006         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2007         (TestWebKitAPI::TEST): Add tests for zero timescale.
2008
2009 2019-01-07  Youenn Fablet  <youenn@apple.com>
2010
2011         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2012         https://bugs.webkit.org/show_bug.cgi?id=193175
2013
2014         Reviewed by Chris Dumez.
2015
2016         Updated API test as we bumped the SW schema to version 4.
2017
2018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2019         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2020         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2021         (TEST):
2022
2023 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2024
2025         [Win][Clang] Fix compilation warnings of MiniBrowser
2026         https://bugs.webkit.org/show_bug.cgi?id=193029
2027
2028         Reviewed by Ross Kirsling.
2029
2030         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2031         and m_URLBarFont. Reorder member variables to fix -Wreorder
2032         warning.
2033         * MiniBrowser/win/PageLoadTestClient.cpp:
2034         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2035         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2036         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2037         m_currentURLIndex.
2038         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2039         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2040         navigationClient with '{ }' to fix the missing field warning.
2041         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2042         (initDocStruct): Changed the argument type docname to const.
2043
2044 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2045
2046         [WebAuthN] Import U2F command/response converters from Chromium
2047         https://bugs.webkit.org/show_bug.cgi?id=193150
2048         <rdar://problem/47054028>
2049
2050         Reviewed by Brent Fulgham.
2051
2052         Adds API tests.
2053
2054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2055         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2056         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2057         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2058         (TestWebKitAPI::getTestAttestationObjectBytes):
2059         (TestWebKitAPI::getTestSignResponse):
2060         (TestWebKitAPI::getTestU2fRegisterResponse):
2061         (TestWebKitAPI::TEST):
2062         (TestWebKitAPI::convertToVector): Deleted.
2063         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2064         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2065         (TestWebKitAPI::constructMakeCredentialRequest):
2066         (TestWebKitAPI::constructGetAssertionRequest):
2067         (TestWebKitAPI::TEST):
2068
2069 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2070
2071         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2072         https://bugs.webkit.org/show_bug.cgi?id=193136
2073
2074         Reviewed by Michael Catanzaro.
2075
2076         * gtk/install-dependencies:
2077         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2078         they are needed by update-webkitgtk-libs.
2079
2080 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2081
2082         Unreviewed follow-up fix to r239650
2083         https://bugs.webkit.org/show_bug.cgi?id=193140
2084         <rdar://problem/47063037>
2085
2086         Typecast patch_id to string.
2087
2088         * BuildSlaveSupport/ews-build/steps.py:
2089         (ValidatePatch._is_patch_obsolete):
2090
2091 2019-01-04  Daniel Bates  <dabates@apple.com>
2092
2093         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2094         https://bugs.webkit.org/show_bug.cgi?id=193024
2095
2096         Reviewed by Jer Noble.
2097
2098         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2099         for the bitmask type WebEventFlags as an example.
2100
2101         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2102         that can be used to register summary and synthetic child formatters for a bitmask type.
2103         For example, consider the following enum and bitmask typedefs:
2104
2105         typedef enum {
2106             A = 1 << 0,
2107             B = 1 << 1,
2108             C = 1 << 2,
2109         } SpecialFlagValues;
2110         typedef unsigned SpecialFlags;
2111
2112         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2113         __lldb_init_module():
2114
2115             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2116                     1 << 0: "A",
2117                     1 << 1: "B",
2118                     1 << 2: "C",
2119             })
2120
2121         * lldb/lldb_webkit.py:
2122         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2123         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2124         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2125         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2126         A convenience function to dynamically creaste a synthetic formatter class and summary
2127         string function for the specified bitmask type and enumerator value to name map. This
2128         function register the dynamically created class and function with LLDB.
2129
2130         (__lldb_init_module):
2131         (FlagEnumerationProvider):
2132         (FlagEnumerationProvider._enumerator_value_to_name_map):
2133         (FlagEnumerationProvider._bitmask):
2134         (FlagEnumerationProvider._update):
2135         (FlagEnumerationProvider.has_children):
2136         (FlagEnumerationProvider.num_children):
2137         (FlagEnumerationProvider.get_child_index):
2138         (FlagEnumerationProvider.get_child_at_index):
2139         (FlagEnumerationProvider.update):
2140         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2141
2142         (WTFOptionSetProvider):
2143         (WTFOptionSetProvider._enumerator_value_to_name_map):
2144         (WTFOptionSetProvider._bitmask):
2145         (WTFOptionSetProvider._update):
2146         Write in terms of the base class.
2147
2148         (RawBitmaskProviderBase):
2149         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2150         (RawBitmaskProviderBase._bitmask):
2151         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2152         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2153         {
2154             1 << 0: "A",
2155             1 << 1: "B",
2156             1 << 2: "C",
2157         }
2158         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2159         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2160
2161         (WTFOptionSetProvider.has_children): Deleted.
2162         (WTFOptionSetProvider.num_children): Deleted.
2163         (WTFOptionSetProvider.get_child_index): Deleted.
2164         (WTFOptionSetProvider.get_child_at_index): Deleted.
2165         (WTFOptionSetProvider.update): Deleted.
2166
2167 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2168
2169         [ews-build] Add build step to validate the patch before processing it
2170         https://bugs.webkit.org/show_bug.cgi?id=193140
2171
2172         Reviewed by Lucas Forschler.
2173
2174         * BuildSlaveSupport/ews-build/factories.py:
2175         (Factory.__init__): Added ValidatePatch step.
2176         * BuildSlaveSupport/ews-build/steps.py:
2177         (ValidatePatch):
2178         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2179         (ValidatePatch.get_patch_json): Get patch json data.
2180         (ValidatePatch.get_bug_json): Get bug json data.
2181         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2182         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2183         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2184         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2185         (ValidatePatch.skip_build): Skip the build.
2186         (ValidatePatch.start):
2187
2188 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2189
2190         Progress towards fixing Mac CMake build
2191         https://bugs.webkit.org/show_bug.cgi?id=193105
2192
2193         Reviewed by Don Olmstead.
2194
2195         * TestWebKitAPI/PlatformMac.cmake:
2196
2197 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2198
2199         Fix API test after r239631
2200         https://bugs.webkit.org/show_bug.cgi?id=193118
2201
2202         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2203         (TestWebKitAPI::TEST):
2204         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
2205         Do the same thing via the API to fix the test.
2206
2207 2019-01-04  Jer Noble  <jer.noble@apple.com>
2208
2209         [WebKitLegacy] Media playback pauses on scroll
2210         https://bugs.webkit.org/show_bug.cgi?id=192829
2211
2212         Reviewed by Eric Carlson.
2213
2214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2215         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
2216         (TestWebKitAPI::TEST):
2217         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
2218         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
2219         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
2220         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
2221         (TestWebKitAPI::TEST):
2222
2223 2019-01-04  Chris Dumez  <cdumez@apple.com>
2224
2225         Add support for toggling device orientation API support per site
2226         https://bugs.webkit.org/show_bug.cgi?id=193143
2227         <rdar://problem/46605724>
2228
2229         Reviewed by Alex Christensen.
2230
2231         Add API test coverage.
2232
2233         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2234         (-[DataMappingSchemeHandler setTaskHandler:]):
2235         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
2236         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
2237         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2238         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
2239
2240 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2241
2242         [ews-build] use svn-apply script to apply the patches
2243         https://bugs.webkit.org/show_bug.cgi?id=193138
2244
2245         Reviewed by Lucas Forschler.
2246
2247         * BuildSlaveSupport/ews-build/factories.py:
2248         (Factory.__init__): Add the ApplyPatch step.
2249         * BuildSlaveSupport/ews-build/steps.py:
2250         (CheckOutSource): Added step name.
2251         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
2252         (ApplyPatch): Build step to apply patch using svn-apply script.
2253         (UnApplyPatchIfRequired):
2254         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
2255
2256 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2257
2258         Deprecate WKContextCreate
2259         https://bugs.webkit.org/show_bug.cgi?id=193118
2260
2261         Reviewed by Brady Eidson.
2262
2263         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2264         (WebKitBrowserWindow::WebKitBrowserWindow):
2265         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
2266         (TestWebKitAPI::TEST):
2267         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2268         (TestWebKitAPI::TEST):
2269         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2270         (TestWebKitAPI::TEST):
2271         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2272         (TestWebKitAPI::TEST):
2273         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2274         (TestWebKitAPI::TEST):
2275         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2276         (TestWebKitAPI::TEST):
2277         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2278         (TestWebKitAPI::TEST):
2279         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2280         (TestWebKitAPI::TEST):
2281         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2282         (TestWebKitAPI::TEST):
2283         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2284         (TestWebKitAPI::TEST):
2285         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2286         (TestWebKitAPI::TEST):
2287         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2288         (TestWebKitAPI::TEST):
2289         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2290         (TestWebKitAPI::TEST):
2291         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2292         (TestWebKitAPI::TEST):
2293         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2294         (TestWebKitAPI::TEST):
2295         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2296         (TestWebKitAPI::TEST):
2297         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2298         (TestWebKitAPI::TEST):
2299         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2300         (TestWebKitAPI::TEST):
2301         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2302         (TestWebKitAPI::loadAlternateHTMLString):
2303         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2304         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2305         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2306         (TestWebKitAPI::buildAndPerformTest):
2307         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2308         (TestWebKitAPI::TEST):
2309         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
2310         (TestWebKitAPI::TEST):
2311         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
2312         (TestWebKitAPI::TEST):
2313         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2314         (TestWebKitAPI::TEST):
2315         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2316         (TestWebKitAPI::TEST):
2317         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2318         (TestWebKitAPI::TEST):
2319         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2320         (TestWebKitAPI::TEST):
2321         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2322         (TestWebKitAPI::TEST):
2323         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2324         (TestWebKitAPI::TEST):
2325         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2326         (TestWebKitAPI::TEST):
2327         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2328         (TestWebKitAPI::TEST):
2329         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2330         (TestWebKitAPI::TEST):
2331         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2332         (TestWebKitAPI::TEST):
2333         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2334         (TestWebKitAPI::TEST):
2335         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2336         (TestWebKitAPI::TEST):
2337         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2338         (TestWebKitAPI::TEST):
2339         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2340         (TestWebKitAPI::TEST):
2341         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2342         (TestWebKitAPI::TEST):
2343         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
2344         (TestWebKitAPI::TEST):
2345         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2346         (TestWebKitAPI::TEST):
2347         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2348         (TestWebKitAPI::TEST):
2349         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2350         (TestWebKitAPI::TEST):
2351         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2352         (TestWebKitAPI::TEST):
2353         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
2354         (TestWebKitAPI::TEST):
2355         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2356         (TestWebKitAPI::TEST):
2357         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2358         (TestWebKitAPI::TEST):
2359         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2360         (WebKit2_CommandBackForwardTestWKView::SetUp):
2361         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2362         (TestWebKitAPI::TEST):
2363         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2364         (TestWebKitAPI::TEST):
2365         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
2366         (TestWebKitAPI::TEST):
2367         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2368         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2369
2370 2019-01-03  Matt Rajca  <mrajca@apple.com>
2371
2372         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
2373         https://bugs.webkit.org/show_bug.cgi?id=193128
2374         rdar://34554231
2375
2376         Reviewed by Jer Noble.
2377
2378         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
2379         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
2380         event along with a flag that indicates whether or not autoplay was actually prevented.
2381
2382         Tests: existing API tests were updated to reflect the new names. New API tests
2383         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
2384
2385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2386         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
2387         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2388         (TEST):
2389         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
2390         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
2391
2392 2019-01-04  Chris Dumez  <cdumez@apple.com>
2393
2394         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
2395         https://bugs.webkit.org/show_bug.cgi?id=193120
2396
2397         Reviewed by Alex Christensen.
2398
2399         Add API test coverage.
2400
2401         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2402
2403 2019-01-04  Chris Dumez  <cdumez@apple.com>
2404
2405         Crash under WebProcessPool::addSuspendedPage()
2406         https://bugs.webkit.org/show_bug.cgi?id=193110
2407
2408         Reviewed by Youenn Fablet.
2409
2410         Add API test coverage.
2411
2412         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2413
2414 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2415
2416         [ews-build] Check patch relevance before applying the patch
2417         https://bugs.webkit.org/show_bug.cgi?id=193102
2418
2419         Reviewed by Lucas Forschler.
2420
2421         * BuildSlaveSupport/ews-build/factories.py:
2422         (Factory.__init__): Moved CheckPatchRelevance step to base class.
2423
2424 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2425
2426         [ews-build] Check patch relevance step should print patch id
2427         https://bugs.webkit.org/show_bug.cgi?id=193137
2428
2429         Reviewed by Lucas Forschler.
2430
2431         * BuildSlaveSupport/ews-build/steps.py:
2432         (CheckPatchRelevance.start): Update the status to include patch id.
2433
2434 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
2435
2436         webkitpy: Increase simulator teardown timeout
2437         https://bugs.webkit.org/show_bug.cgi?id=193141
2438         <rdar://problem/46174217>
2439
2440         Rubber-stamped by Aakash Jain.
2441
2442         * Scripts/webkitpy/xcode/simulated_device.py:
2443         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
2444
2445 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
2446
2447         test262-runner misbehaves when test file YAML has a trailing space
2448         https://bugs.webkit.org/show_bug.cgi?id=193053
2449
2450         Reviewed by Yusuke Suzuki.
2451
2452         * Scripts/test262/Runner.pm:
2453         (parseData):
2454         Accept trailing space when parsing a test file's YAML block.
2455
2456 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2457
2458         UserMedia test should use WKPageNavigationClient
2459         https://bugs.webkit.org/show_bug.cgi?id=192913
2460
2461         Reviewed by Youenn Fablet.
2462
2463         The test currently uses the deprecated WKPageLoaderClient. It should use
2464         WKPageNavigationClient instead, which provides the same callback under a similar name.
2465
2466         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2467         (TestWebKitAPI::TEST):
2468
2469 2019-01-02  Alex Christensen  <achristensen@webkit.org>
2470
2471         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
2472         https://bugs.webkit.org/show_bug.cgi?id=192944
2473
2474         Reviewed by Tim Horton.
2475
2476         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2477         (TestWebKitAPI::TEST):
2478
2479 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2480
2481         Add support for using the current text selection as the find string on iOS
2482         https://bugs.webkit.org/show_bug.cgi?id=193034
2483         <rdar://problem/45138739>
2484
2485         Reviewed by Tim Horton.
2486
2487         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
2488         _setStringForFind) works as expected.
2489
2490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2491         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
2492
2493 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
2494
2495         [ews-build] Use git on OpenSource EWS bots
2496         https://bugs.webkit.org/show_bug.cgi?id=193092
2497
2498         Reviewed by Lucas Forschler.
2499
2500         * BuildSlaveSupport/ews-build/steps.py:
2501         (CheckOutSource): Use git instead of svn.
2502         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
2503
2504 2019-01-02  Daniel Bates  <dabates@apple.com>
2505
2506         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
2507         https://bugs.webkit.org/show_bug.cgi?id=193023
2508
2509         Reviewed by Simon Fraser.
2510
2511         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
2512         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
2513         enumerator values. We should just remove this code.
2514
2515         * lldb/lldb_webkit.py:
2516         (WTFOptionSetProvider.has_children):
2517         (WTFOptionSetProvider.num_children):
2518         (WTFOptionSetProvider.get_child_index):
2519         (WTFOptionSetProvider.get_child_at_index):
2520
2521 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2522
2523         .ycm_extra_conf.py should handle XXXInlines.h
2524         https://bugs.webkit.org/show_bug.cgi?id=193055
2525
2526         Reviewed by Carlos Garcia Campos.
2527
2528         compile_commands.json database only records flags and options for cpp source files.
2529         So, when we open headers, this database does not have any information for that.
2530         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
2531         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
2532         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
2533         we attempt to find XXX.cpp and use the configuration if it exists.
2534
2535         * gtk/ycm_extra_conf.py:
2536         (getImplementationFilename):
2537         (FlagsForFile):
2538
2539 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2540
2541         Unreviewed. Support PHP 7.3 in Debian.
2542
2543         Add 7.3 to the list of php versions supported in Debian.
2544
2545         * Scripts/webkitpy/port/base.py:
2546         (Port._debian_php_version):
2547
2548 2018-12-27  Alex Christensen  <achristensen@webkit.org>
2549
2550         Resurrect Mac CMake build
2551         https://bugs.webkit.org/show_bug.cgi?id=192658
2552
2553         Reviewed by Yusuke Suzuki.
2554
2555         * DumpRenderTree/PlatformMac.cmake:
2556         * MiniBrowser/mac/CMakeLists.txt:
2557         * TestWebKitAPI/PlatformMac.cmake:
2558
2559 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
2560
2561         [Tools] Remove references to Bison and Flex
2562         https://bugs.webkit.org/show_bug.cgi?id=193033
2563
2564         Reviewed by Michael Catanzaro.
2565
2566         The Bison and Flex tools are not needed anymore since r209883.
2567
2568         * CygwinDownloader/cygwin-downloader.py:
2569         * EWSTools/ubuntu-ews-packages:
2570         * Scripts/filter-build-webkit:
2571         (shouldIgnoreLine):
2572         * gtk/install-dependencies:
2573         * wpe/install-dependencies:
2574
2575 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2576
2577         WebDriver: warn about non existing tests when parsing expectations
2578         https://bugs.webkit.org/show_bug.cgi?id=192979
2579
2580         Reviewed by Michael Catanzaro.
2581
2582         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
2583         renamed.
2584
2585         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2586         (WebDriverTestRunner.__init__):
2587
2588 2018-12-21  Chris Dumez  <cdumez@apple.com>
2589
2590         navigator.userAgent in service workers does not reflect customUserAgent set by client
2591         https://bugs.webkit.org/show_bug.cgi?id=192951
2592
2593         Reviewed by Youenn Fablet.
2594
2595         Extend API test coverage.
2596
2597         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2598         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
2599         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2600         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
2601         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2602
2603 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2604
2605         [WebAuthN] userPresence should always be true
2606         https://bugs.webkit.org/show_bug.cgi?id=192835
2607         <rdar://problem/46538788>
2608
2609         Reviewed by Brent Fulgham.
2610
2611         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2612         (TestWebKitAPI::TEST):
2613
2614 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
2615
2616         Add support to run-benchmark to use non-default copies of the browser apps
2617         https://bugs.webkit.org/show_bug.cgi?id=192905
2618         rdar://problem/46845840
2619
2620         Reviewed by Dewei Zhu.
2621         
2622         Add support for a --browser-path argument to run-benchmark, which allows you to use
2623         a custom app bundle for a given browser (only implemented for Safari at present).
2624
2625         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2626         (BenchmarkRunner.__init__):
2627         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2628         (BrowserDriver.__init__):
2629         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2630         (BrowserDriverFactory.create):
2631         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2632         (OSXBrowserDriver._launch_process):
2633         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
2634         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
2635         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2636         (OSXChromeCanaryDriver.launch_url):
2637         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2638         (OSXFirefoxNightlyDriver.launch_url):
2639         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2640         (OSXSafariDriver.__init__):
2641         (OSXSafariDriver.launch_url):
2642         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2643         (parse_args):
2644         (run_benchmark_plan):
2645         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2646         (WebServerBenchmarkRunner.__init__):
2647         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
2648         (FakeBenchmarkRunner.__init__):
2649
2650 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2651
2652         [WebAuthN] Import an APDU coder from Chromium
2653         https://bugs.webkit.org/show_bug.cgi?id=192949
2654         <rdar://problem/46879933>
2655
2656         Reviewed by Brent Fulgham.
2657
2658         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2659         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
2660         (TestWebKitAPI::TEST):
2661
2662 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2663
2664         Setting the file wrapper and content type of an attachment to a PDF should update its image
2665         https://bugs.webkit.org/show_bug.cgi?id=192984
2666         <rdar://problem/46798028>
2667
2668         Reviewed by Tim Horton.
2669
2670         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
2671         PDF data correctly updates the image element.
2672
2673         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2674
2675 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2676
2677         Add JSCOnly to bot dashboard
2678         https://bugs.webkit.org/show_bug.cgi?id=192964
2679
2680         Reviewed by Alexey Proskuryakov.
2681
2682         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
2683         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
2684         useful if they were not so secret, so add them.
2685
2686         There appear to be no build-only bots, so the first column is blank. And of course there are
2687         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
2688         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
2689         and there's plenty of room in the final column for all the bots.
2690
2691         I had a hard time picking a logo to use, because the JavaScript language does not have an
2692         official logo. But I believe I've found one that will be satisfactory.
2693
2694         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
2695
2696         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
2697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
2698         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2699         (BubbleQueueServer):
2700         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2701         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2702         (WebKitBuildbot):
2703         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2704         (table.queue-grid tr.platform.linux-jsconly img.logo):
2705
2706 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
2707
2708         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2709         https://bugs.webkit.org/show_bug.cgi?id=192821
2710
2711         Reviewed by Chris Dumez.
2712
2713         * DumpRenderTree/mac/DumpRenderTree.mm:
2714         (createWebViewAndOffscreenWindow):
2715         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2716
2717 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2718
2719         [Win][Clang] Fix compilation warnings of DumpRenderTree
2720         https://bugs.webkit.org/show_bug.cgi?id=192924
2721
2722         Reviewed by Alex Christensen.
2723
2724         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
2725         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2726         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
2727         * DumpRenderTree/win/DumpRenderTree.cpp:
2728         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
2729         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
2730         object to the argument of setDefaultTextEncodingName instead of a
2731         const string literal.
2732         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
2733         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
2734         (setCacheFolder): Deleted.
2735         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
2736         * DumpRenderTree/win/EditingDelegate.cpp:
2737         (dump): Use %d for int.
2738         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
2739         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2740         (BSTRFromString): Deleted unused function.
2741         * DumpRenderTree/win/TestRunnerWin.cpp:
2742         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
2743         the arguemnt of setQuota instead of const string literal.
2744         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2745         (jsStringRefToWString): Deleted unused function.
2746
2747 2018-12-20  Chris Dumez  <cdumez@apple.com>
2748
2749         Add API test coverage for customUserAgent client setting and service workers
2750         https://bugs.webkit.org/show_bug.cgi?id=192952
2751
2752         Reviewed by Alex Christensen.
2753
2754         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2755         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
2756         (-[SWSchemes webView:startURLSchemeTask:]):
2757         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2758         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2759
2760 2018-12-20  Chris Dumez  <cdumez@apple.com>
2761
2762         Use Optional::hasValue() instead of Optional::has_value()
2763         https://bugs.webkit.org/show_bug.cgi?id=192948
2764
2765         Reviewed by Tim Horton.
2766
2767         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
2768         (TestWebKitAPI::TEST):
2769         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
2770         (TestWebKitAPI::TEST):
2771         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2772         (TestWebKitAPI::TEST_F):
2773
2774 2018-12-20  Chris Dumez  <cdumez@apple.com>
2775
2776         Add style script rule to check for uses of std::optional<>
2777         https://bugs.webkit.org/show_bug.cgi?id=192931
2778
2779         Reviewed by Tim Horton.
2780
2781         * Scripts/webkitpy/style/checkers/cpp.py:
2782         (check_wtf_optional):
2783         (check_style):
2784
2785 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
2786
2787         [WebAuthN] Add a runtime flag for local authenticator
2788         https://bugs.webkit.org/show_bug.cgi?id=192792
2789         <rdar://problem/46798738>
2790
2791         Reviewed by Brent Fulgham.
2792
2793         * DumpRenderTree/TestOptions.cpp:
2794         (TestOptions::TestOptions):
2795         * DumpRenderTree/TestOptions.h:
2796         * DumpRenderTree/mac/DumpRenderTree.mm:
2797         (enableExperimentalFeatures):
2798         (setWebPreferencesForTestOptions):
2799         * WebKitTestRunner/TestController.cpp:
2800         (WTR::TestController::resetPreferencesToConsistentValues):
2801         (WTR::updateTestOptionsFromTestHeader):
2802         * WebKitTestRunner/TestOptions.h:
2803         (WTR::TestOptions::hasSameInitializationOptions const):
2804
2805 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
2806
2807         webkitpy: Autoinstall package URLs have changed
2808         https://bugs.webkit.org/show_bug.cgi?id=192909
2809         <rdar://problem/46860359>
2810
2811         Rubber-stamped by Alexey Proskuryakov.
2812
2813         PyPi urls have been moved around, we need to update our auto-installed packages.
2814
2815         We should check for Selenium before asking PyPi for the latest version.
2816
2817         * Scripts/webkitpy/thirdparty/__init__.py:
2818         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
2819         (AutoinstallImportHook._install_keyring): Ditto.
2820         (AutoinstallImportHook._install_pep8): Ditto.
2821         (AutoinstallImportHook._install_mozlog): Ditto.
2822         (AutoinstallImportHook._install_mozprocess): Ditto.
2823         (AutoinstallImportHook._install_pytest_timeout): Ditto.
2824         (AutoinstallImportHook._install_pytest): Ditto.
2825         (AutoinstallImportHook._install_pylint): Ditto.
2826         (AutoinstallImportHook._install_buildbot): Ditto.
2827         (AutoinstallImportHook._install_coverage): Ditto.
2828         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
2829         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
2830         for new Selenium if the installed version isn't sufficient.
2831         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
2832
2833 2018-12-20  Chris Dumez  <cdumez@apple.com>
2834
2835         Use Optional::valueOr() instead of Optional::value_or()
2836         https://bugs.webkit.org/show_bug.cgi?id=192933
2837
2838         Reviewed by Geoffrey Garen.
2839
2840         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2841         (TestWebKitAPI::checkURL):
2842         (TestWebKitAPI::checkRelativeURL):
2843         (TestWebKitAPI::checkURLDifferences):
2844         (TestWebKitAPI::checkRelativeURLDifferences):
2845         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
2846         (TestWebKitAPI::checkURL):
2847
2848 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
2849
2850         Unreviewed, rolling out r239417.
2851
2852         Introduced two API test failures on macOS.
2853
2854         Reverted changeset:
2855
2856         "<rdar://problem/46194315> macOS: WebKit1 does not handle
2857         occlusion changes"
2858         https://bugs.webkit.org/show_bug.cgi?id=192821
2859         https://trac.webkit.org/changeset/239417
2860
2861 2018-12-20  Devin Rousso  <drousso@apple.com>
2862
2863         Web Inspector: UIString should take an optional key and description to aid localization
2864         https://bugs.webkit.org/show_bug.cgi?id=153962
2865         <rdar://problem/24542505>
2866
2867         Reviewed by Brian Burg.
2868
2869         * Scripts/extract-localizable-js-strings:
2870
2871 2018-12-20  Tim Horton  <timothy_horton@apple.com>
2872
2873         Unparented WKWebView can't retrieve main resource data for a main frame plugin
2874         https://bugs.webkit.org/show_bug.cgi?id=192923
2875         <rdar://problem/46859068>
2876
2877         Reviewed by Wenson Hsieh.
2878
2879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2880         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
2881         Add a test ensuring that both parented and unparented WKWebViews can
2882         retrieve main resource data when loading a PDF.
2883
2884 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2885
2886         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
2887         https://bugs.webkit.org/show_bug.cgi?id=192852
2888
2889         Reviewed by Michael Catanzaro.
2890
2891         EmojiOne font was replaced by Noto Color Emoji.
2892
2893         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
2894         * gtk/jhbuild.modules:
2895         * wpe/jhbuild.modules:
2896
2897 2018-12-19  Chris Dumez  <cdumez@apple.com>
2898
2899         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
2900         https://bugs.webkit.org/show_bug.cgi?id=192728
2901         <rdar://problem/46746779>
2902
2903         Reviewed by Geoff Garen.
2904
2905         * DumpRenderTree/*:
2906         * MiniBrowser/*:
2907         * TestRunnerShared/*:
2908         * TestWebKitAPI/*:
2909         * WebGPUAPIStructure/*:
2910         * WebKitTestRunner/*:
2911
2912 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
2913
2914         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2915         https://bugs.webkit.org/show_bug.cgi?id=192821
2916
2917         Reviewed by Chris Dumez.
2918
2919         * DumpRenderTree/mac/DumpRenderTree.mm:
2920         (createWebViewAndOffscreenWindow):
2921
2922 2018-12-19  Alex Christensen  <achristensen@webkit.org>
2923
2924         Navigations away from the SafeBrowsing interstitial show a flash of old content
2925         https://bugs.webkit.org/show_bug.cgi?id=192676
2926
2927         Reviewed by Chris Dumez.
2928
2929         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2930         (safeBrowsingView):
2931         (TEST):
2932         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
2933
2934 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
2935
2936         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
2937         https://bugs.webkit.org/show_bug.cgi?id=192855
2938
2939         Reviewed by Michael Catanzaro.
2940
2941         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2942         (WTR::TestController::notifyDone): Use the WPE implementation.
2943         (WTR::TestController::platformRunUntil): Use the WPE implementation.
2944         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
2945         (WTR::TestController::platformRunUntil): Honor the condition flag.
2946
2947 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
2948
2949         Allow clients to set the navigator platform
2950         https://bugs.webkit.org/show_bug.cgi?id=192735
2951
2952         Reviewed by Tim Horton.
2953
2954         Add a test for setting a custom navigator platform.
2955
2956         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2957         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2958         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
2959
2960 2018-12-19  Truitt Savell  <tsavell@apple.com>
2961
2962         Unreviewed, rolling out r239358.
2963
2964         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
2965         crash on Debug bots
2966
2967         Reverted changeset:
2968
2969         "Clean up IndexedDB files between tests"
2970         https://bugs.webkit.org/show_bug.cgi?id=192796
2971         https://trac.webkit.org/changeset/239358
2972
2973 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2974
2975         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
2976         https://bugs.webkit.org/show_bug.cgi?id=192842
2977         <rdar://problem/46823586>
2978
2979         Reviewed by Tim Horton.
2980
2981         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
2982         item provider when dragging a rich text selection.
2983
2984         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2985
2986 2018-12-18  David Quesada  <david_quesada@apple.com>
2987
2988         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
2989         https://bugs.webkit.org/show_bug.cgi?id=192810
2990         <rdar://problem/46812536>
2991
2992         Reviewed by Alex Christensen.
2993
2994         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2995         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2996             After releasing our reference to the web view, wait until the next turn of the runloop
2997             before checking that the originatingWebView has been zeroed, since the web view might
2998             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
2999             testing general memory management of WKWebViews, only that _WKDownload does not retain
3000             its web view via the 'originatingWebView' property.
3001
3002 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3003
3004         Clean up IndexedDB files between tests
3005         https://bugs.webkit.org/show_bug.cgi?id=192796
3006
3007         Reviewed by Geoffrey Garen.
3008
3009         * DumpRenderTree/mac/DumpRenderTree.mm:
3010         (runTest):
3011         * WebKitTestRunner/TestController.cpp:
3012         (WTR::TestController::resetStateToConsistentValues):
3013         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3014         (WTR::RemoveAllIndexedDatabasesCallback):
3015         (WTR::TestController::ClearIndexedDatabases):
3016         * WebKitTestRunner/TestController.h:
3017
3018 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3019
3020         Fix API test introduced in r239339 on iOS.
3021         https://bugs.webkit.org/show_bug.cgi?id=192675
3022
3023         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3024         (TEST):
3025         The iOS implementation of the safe browsing warning is a little different.
3026         It does some element creation when it is added to the window so it knows how big it is.
3027         To test these elements, we need to simulate adding it to the window.
3028         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3029
3030 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3031
3032         webkitpy: Ignore device type for test when using --force
3033         https://bugs.webkit.org/show_bug.cgi?id=192786
3034         <rdar://problem/46794894>
3035
3036         Reviewed by Daniel Bates.
3037
3038         It is sometimes the case that a contributor will wish to run a test on a specific device,
3039         despite expectations which indicate a test should not be run on that device.
3040
3041         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3042         (parse_args):
3043         * Scripts/webkitpy/port/device_port.py:
3044         (DevicePort.default_child_processes): Strip device type information when using --force.
3045         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3046
3047 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3048
3049         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3050         https://bugs.webkit.org/show_bug.cgi?id=192675
3051
3052         Reviewed by Geoffrey Garen.
3053
3054         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3055         (goBack):
3056         (TEST):
3057         (visitUnsafeSite):
3058         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3059         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3060
3061 2018-12-18  Chris Dumez  <cdumez@apple.com>
3062
3063         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3064         https://bugs.webkit.org/show_bug.cgi?id=192772
3065
3066         Reviewed by Antti Koivisto.
3067
3068         Add API test coverage.
3069
3070         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3071
3072 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3073
3074         Unreviewed, JHBuild GTK build fix attempt
3075
3076         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3077         There's no ninja module either, it should be provided by the
3078         host system.
3079
3080 2018-12-17  Chris Dumez  <cdumez@apple.com>
3081
3082         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3083         https://bugs.webkit.org/show_bug.cgi?id=192789
3084         <rdar://problem/46755277>
3085
3086         Reviewed by Alex Christensen.
3087
3088         Add API test coverage.
3089
3090         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3091         (TEST):
3092
3093 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3094
3095         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3096         https://bugs.webkit.org/show_bug.cgi?id=192780
3097         rdar://problem/43394387
3098
3099         Reviewed by Tim Horton.
3100
3101         No need to set "AppleFontSmoothing" defaults for WK2.
3102
3103         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3104         (WTR::InjectedBundle::platformInitialize):
3105
3106 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3107
3108         webkitpy: Handle case where stdout and stderr don't accept unicode
3109         https://bugs.webkit.org/show_bug.cgi?id=192775
3110         <rdar://problem/46497303>
3111
3112         Reviewed by Stephanie Lewis.
3113
3114         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3115         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3116         characters with '?'.
3117         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3118         (RegularTest.test_stream_with_encoding):
3119
3120 2018-12-17  Daniel Bates  <dabates@apple.com>
3121
3122         Support concatenating StringView with other string types
3123         https://bugs.webkit.org/show_bug.cgi?id=177566
3124
3125         Reviewed by Darin Adler.
3126
3127         Add some tests to ensure we do not regress the number of allocations needed when performing
3128         string concatenation with string views.
3129
3130         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3131         (TestWebKitAPI::TEST):
3132
3133 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3134
3135         Unreviewed, rolling out r239265 and r239274.
3136         https://bugs.webkit.org/show_bug.cgi?id=192765
3137
3138         unorm_normalize is deprecated, and broke an internal build
3139         (Requested by Truitt on #webkit).
3140
3141         Reverted changesets:
3142
3143         "[GTK][WPE] Need a function to convert internal URI to display
3144         ("pretty") URI"
3145         https://bugs.webkit.org/show_bug.cgi?id=174816
3146         https://trac.webkit.org/changeset/239265
3147
3148         "Fix the Apple Internal Mac build with a newer SDK"
3149         https://trac.webkit.org/changeset/239274
3150
3151 2018-12-17  Daniel Bates  <dabates@apple.com>
3152
3153         Implement UIScriptController::toggleCapsLock() for iOS
3154         https://bugs.webkit.org/show_bug.cgi?id=191815
3155
3156         Reviewed by Andy Estes.
3157
3158         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3159
3160         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3161         * WebKitTestRunner/TestController.cpp:
3162         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3163         before running a test. This ensures that the caps lock state does not persist between
3164         tests should a test enable caps lock and not disable it.
3165         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3166         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3167         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3168         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3169         create the event. Also substituted NSString* for const String& as the data type for the first
3170         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3171         below.
3172         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3173         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3174
3175 2018-12-17  Daniel Bates  <dabates@apple.com>
3176
3177         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3178         https://bugs.webkit.org/show_bug.cgi?id=192633
3179
3180         Reviewed by Wenson Hsieh.
3181
3182         Update code to use the modern initializer.
3183
3184         * DumpRenderTree/mac/EventSendingController.mm:
3185         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3186
3187 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3188
3189         Unreviewed, rolling out r239254.
3190
3191         This broke the Windows 10 Debug build
3192
3193         Reverted changeset:
3194
3195         "Replace many uses of String::format with more type-safe
3196         alternatives"
3197         https://bugs.webkit.org/show_bug.cgi?id=192742
3198         https://trac.webkit.org/changeset/239254
3199
3200 2018-12-17  David Kilzer  <ddkilzer@apple.com>
3201
3202         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
3203         <https://webkit.org/b/192751>
3204         <rdar://problem/46771623>
3205
3206         Reviewed by Daniel Bates.
3207
3208         Change loop variables to const references to avoid unnecessary
3209         copies.
3210
3211         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3212         (-[LocalPasteboard pasteboardItems]):
3213
3214 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
3215
3216         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3217         https://bugs.webkit.org/show_bug.cgi?id=174816
3218
3219         Reviewed by Michael Catanzaro.
3220
3221         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
3222
3223         * TestWebKitAPI/CMakeLists.txt:
3224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3225         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
3226         (TestWebKitAPI::TEST):
3227         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3228         (testURIForDisplayUnaffected):
3229         (testURIForDisplayAffected):
3230         (beforeAll):
3231         (afterAll):
3232         * TestWebKitAPI/glib/CMakeLists.txt:
3233
3234 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3235
3236         [WPE] Add API to notify about frame displayed view backend callback
3237         https://bugs.webkit.org/show_bug.cgi?id=192224
3238
3239         Reviewed by Michael Catanzaro.
3240
3241         Add a test case to check the new API.
3242
3243         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3244         (testWebViewFrameDisplayed):
3245         (beforeAll):
3246         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
3247
3248 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
3249
3250         Unreviewed build fix after r239253
3251
3252         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
3253
3254 2018-12-15  Darin Adler  <darin@apple.com>
3255
3256         Use warning-ignoring macros more consistently and simply
3257         https://bugs.webkit.org/show_bug.cgi?id=192743
3258
3259         Reviewed by Mark Lam.
3260
3261         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3262         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
3263         * DumpRenderTree/mac/TextInputControllerMac.m:
3264         (-[TextInputController interpretKeyEvents:withSender:]): Use
3265         IGNORE_WARNINGS_BEGIN/END.
3266         * WebKitTestRunner/mac/EventSenderProxy.mm:
3267         (WTR::EventSenderProxy::mouseForceClick): Use
3268         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
3269         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
3270         (WTR::EventSenderProxy::mouseForceDown): Ditto.
3271         (WTR::EventSenderProxy::mouseForceUp): Ditto.
3272         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
3273
3274 2018-12-15  Darin Adler  <darin@apple.com>
3275
3276         Replace many uses of String::format with more type-safe alternatives
3277         https://bugs.webkit.org/show_bug.cgi?id=192742
3278
3279         Reviewed by Mark Lam.
3280
3281         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3282         (WTR::cacheTestRunnerCallback): Use makeString.
3283         * WebKitTestRunner/TestController.cpp:
3284         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3285         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3286
3287 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
3288
3289         [WPE][GTK] Add libpsl to JHBuild module sets
3290         https://bugs.webkit.org/show_bug.cgi?id=192740
3291
3292         Reviewed by Michael Catanzaro.
3293
3294         * gtk/jhbuild.modules: Add libpsl module.
3295         * wpe/jhbuild.modules: Ditto.
3296
3297 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
3298
3299         Add a style checker rule for Xcode version macros use
3300         https://bugs.webkit.org/show_bug.cgi?id=192703
3301
3302         Reviewed by Alex Christensen.
3303
3304         * Scripts/webkitpy/style/checkers/cpp.py:
3305         (check_os_version_checks):
3306         (process_line):
3307         (CppChecker):
3308         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3309         (WebKitStyleTest.test_os_version_checks):
3310
3311 2018-12-14  Chris Dumez  <cdumez@apple.com>
3312
3313         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
3314         https://bugs.webkit.org/show_bug.cgi?id=192704
3315
3316         Reviewed by Geoffrey Garen.
3317
3318         Extend existing API test to reproduce the problem.
3319
3320         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3321
3322 2018-12-14  Chris Dumez  <cdumez@apple.com>
3323
3324         [PSON] WebsitePolicies are lost on process-swap
3325         https://bugs.webkit.org/show_bug.cgi?id=192694
3326         <rdar://problem/46715748>
3327
3328         Reviewed by Brady Eidson.
3329
3330         Extend existing API test to reproduce the issue.
3331
3332         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3333
3334 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3335
3336         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
3337         https://bugs.webkit.org/show_bug.cgi?id=192678
3338
3339         Reviewed by Carlos Garcia Campos.
3340
3341         Update our ancient versions of libsoup and glib-networking.
3342
3343         * gtk/install-dependencies:
3344         * gtk/jhbuild.modules:
3345         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
3346         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
3347         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
3348         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3349         * wpe/install-dependencies:
3350         * wpe/jhbuild.modules:
3351         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3352
3353 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3354
3355         [WPE] Use new view state API from libwpe
3356         https://bugs.webkit.org/show_bug.cgi?id=191906
3357
3358         Reviewed by Žan Doberšek.
3359
3360         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3361         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
3362         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3363         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
3364         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3365         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3366         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
3367         wpe_view_activity_state_focused state flags.
3368         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
3369         * wpe/backends/HeadlessViewBackend.cpp:
3370         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
3371         * wpe/backends/WindowViewBackend.cpp:
3372         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
3373         received in configure callback.
3374         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
3375
3376 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3377
3378         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
3379         https://bugs.webkit.org/show_bug.cgi?id=192688
3380
3381         Reviewed by Ross Kirsling.
3382
3383         * win/DLLLauncher/DLLLauncherMain.cpp:
3384         (copyEnvironmentVariable): Moved.
3385         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
3386         (applePathFromRegistry): Ditto.
3387         (appleApplicationSupportDirectory): Ditto.
3388         (prependPath): Ditto.
3389
3390 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
3391
3392         Unreviewed. Changed my status to a reviewer.
3393
3394         * Scripts/webkitpy/common/config/contributors.json:
3395
3396 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3397
3398         [iOS] Support dropping contact card data (public.vcard) in editable content
3399         https://bugs.webkit.org/show_bug.cgi?id=192570
3400         <rdar://problem/35626913>
3401
3402         Reviewed by Tim Horton.
3403
3404         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3405
3406         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
3407         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
3408         additionally inserts a link).
3409
3410         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3411         (TestWebKitAPI::createMapItemForTesting):
3412         (TestWebKitAPI::createContactItemForTesting):
3413
3414         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
3415         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
3416         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
3417         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
3418         files.
3419
3420 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
3421
3422         Unreviewed -- update my status to "reviewer".
3423
3424         * Scripts/webkitpy/common/config/contributors.json:
3425
3426 2018-12-13  Youenn Fablet  <youenn@apple.com>
3427
3428         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
3429         https://bugs.webkit.org/show_bug.cgi?id=192657
3430
3431         Reviewed by Eric Carlson.
3432
3433         Add a test that loads a page registering ondevicechange,
3434         load another page in the same process, closes the first page.
3435         Ensure that the process does not crash in that case.
3436
3437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3438         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3439         (TestWebKitAPI::TEST):
3440         (TestWebKitAPI::didCrashCallback):
3441         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
3442
3443 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3444
3445         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
3446         https://bugs.webkit.org/show_bug.cgi?id=192643
3447
3448         Reviewed by Philippe Normand.
3449
3450         This problem happens with Arch Linux users which have libfdk-2.0.0
3451         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
3452
3453         The problem has already been solved upstream at
3454         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
3455
3456         Adding patches while this problem is not in a release yet.
3457
3458         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
3459         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
3460         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
3461
3462 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3463
3464         [FreeType] Add initial implementation of variation fonts
3465         https://bugs.webkit.org/show_bug.cgi?id=192151
3466
3467         Reviewed by Michael Catanzaro.
3468
3469         Add cairo patch to avoid crashes.
3470
3471         * gtk/jhbuild.modules:
3472         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3473
3474 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
3475
3476         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
3477         https://bugs.webkit.org/show_bug.cgi?id=192618
3478
3479         Reviewed by Alex Christensen.
3480
3481         * DumpRenderTree/win/DRTDataObject.cpp:
3482         * DumpRenderTree/win/DRTDataObject.h:
3483         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3484         * DumpRenderTree/win/DRTDropSource.h:
3485         * DumpRenderTree/win/EditingDelegate.h:
3486         * DumpRenderTree/win/PolicyDelegate.h:
3487         * DumpRenderTree/win/UIDelegate.h:
3488
3489 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
3490
3491         Make TextInputController.legacyAttributedString take DOM nodes and offsets
3492         https://bugs.webkit.org/show_bug.cgi?id=192653
3493
3494         Reviewed by Wenson Hsieh.
3495
3496         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
3497         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
3498         shadow boundaries.
3499
3500         * DumpRenderTree/mac/TextInputControllerMac.m:
3501         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
3502         (+[TextInputController webScriptNameForSelector:]): Ditto.
3503         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
3504         start node and offset then end node and offset pairs.
3505
3506 2018-12-12  Alex Christensen  <achristensen@webkit.org>
3507
3508         Implement safe browsing in WebKit on WatchOS
3509         https://bugs.webkit.org/show_bug.cgi?id=192641
3510         <rdar://problem/46376188>
3511
3512         Reviewed by Geoff Garen.
3513
3514         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3515         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
3516         (safeBrowsingView):
3517         Add a test that the new delegate callback is called.
3518
3519 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3520
3521         Unreviewed manual rollout of r239100-r239102 and r239116
3522         https://bugs.webkit.org/show_bug.cgi?id=192151
3523         <rdar://problem/46655586>
3524
3525         * gtk/jhbuild.modules:
3526         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
3527
3528 2018-12-12  Commit Queue  <commit-queue@webkit.org>
3529
3530         Unreviewed, rolling out r239103.
3531         https://bugs.webkit.org/show_bug.cgi?id=192627
3532
3533         It broke the built because it depends on another patch that
3534         didn't land yet (Requested by KaL on #webkit).
3535
3536         Reverted changeset:
3537
3538         "[WPE] Add API to notify about frame displayed view backend
3539         callback"
3540         https://bugs.webkit.org/show_bug.cgi?id=192224
3541         https://trac.webkit.org/changeset/239103
3542
3543 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3544
3545         [WPE] Add API to notify about frame displayed view backend callback
3546         https://bugs.webkit.org/show_bug.cgi?id=192224
3547
3548         Reviewed by Michael Catanzaro.
3549
3550         Add a test case to check the new API.
3551
3552         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3553         (testWebViewFrameDisplayed):
3554         (beforeAll):
3555
3556 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3557
3558         [FreeType] Add initial implementation of variation fonts
3559         https://bugs.webkit.org/show_bug.cgi?id=192151
3560
3561         Reviewed by Michael Catanzaro.
3562
3563         Add cairo patch to avoid crashes.
3564
3565         * gtk/jhbuild.modules:
3566         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3567
3568 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
3569
3570         Implement feature flag for CSS Typed OM
3571         https://bugs.webkit.org/show_bug.cgi?id=192610
3572
3573         Reviewed by Ryosuke Niwa.
3574
3575         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3576
3577 2018-12-11  Chris Dumez  <cdumez@apple.com>
3578
3579         Unreviewed, fix bad check in API test added in r239080.
3580
3581         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3582
3583 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3584
3585         [Win][Clang] Fix warning -Wmissing-field-initializers
3586         https://bugs.webkit.org/show_bug.cgi?id=192584
3587
3588         Reviewed by Yusuke Suzuki.
3589
3590         Initialize a struct with '{ }' instead of '= {0}'.
3591
3592         * DumpRenderTree/win/DumpRenderTree.cpp:
3593         (runTest):
3594         * DumpRenderTree/win/EventSender.cpp:
3595         (makeMsg):
3596         (replaySavedEvents):
3597         (beginDragWithFilesCallback):
3598         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3599         (createBitmapContextFromWebView):
3600         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3601         (updateMenuItemForHistoryItem):
3602         * MiniBrowser/win/WinMain.cpp:
3603         (wWinMain):
3604         * TestWebKitAPI/win/HostWindow.cpp:
3605         (TestWebKitAPI::HostWindow::clientRect const):
3606         (TestWebKitAPI::HostWindow::registerWindowClass):
3607         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3608         (TestWebKitAPI::PlatformWebView::registerWindowClass):
3609         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3610         (WTR::registerWindowClass):
3611         (WTR::PlatformWebView::windowFrame):
3612         (WTR::PlatformWebView::windowSnapshotImage):
3613
3614 2018-12-11  Chris Dumez  <cdumez@apple.com>
3615
3616         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
3617         https://bugs.webkit.org/show_bug.cgi?id=192482
3618         <rdar://problem/46470145>
3619
3620         Reviewed by Antti Koivisto.
3621
3622         Add API test coverage.
3623
3624         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3625
3626 2018-12-11  Andy Estes  <aestes@apple.com>
3627
3628         Introduce makeBlockPtr for lambdas
3629         https://bugs.webkit.org/show_bug.cgi?id=192594
3630
3631         Reviewed by Alex Christensen.
3632
3633         Adopted makeBlockPtr and added API tests.
3634
3635         * DumpRenderTree/TestRunner.cpp:
3636         (TestRunner::callUIScriptCallback):
3637         * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
3638         (TestWebKitAPI::TEST):
3639         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3640         (-[DownloadProgressTestRunner init]):
3641         (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
3642
3643 2018-12-11  Chris Dumez  <cdumez@apple.com>
3644
3645         REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
3646         https://bugs.webkit.org/show_bug.cgi?id=192361
3647         <rdar://problem/46524903>
3648
3649         Reviewed by Alex Christensen.
3650
3651         Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
3652         fixes the failures for me locally.