[Web Animations] Expose Web Animations CSS integration as an experimental feature
[WebKit-https.git] / Tools / ChangeLog
1 2018-05-15  Antoine Quint  <graouts@apple.com>
2
3         [Web Animations] Expose Web Animations CSS integration as an experimental feature
4         https://bugs.webkit.org/show_bug.cgi?id=185647
5
6         Reviewed by Dean Jackson.
7
8         Rename the Web Animations CSS integration flag.
9
10         * DumpRenderTree/TestOptions.cpp:
11         (TestOptions::TestOptions):
12         * DumpRenderTree/TestOptions.h:
13         * DumpRenderTree/mac/DumpRenderTree.mm:
14         (setWebPreferencesForTestOptions):
15         * WebKitTestRunner/TestController.cpp:
16         (WTR::TestController::resetPreferencesToConsistentValues):
17         (WTR::updateTestOptionsFromTestHeader):
18         * WebKitTestRunner/TestOptions.h:
19         (WTR::TestOptions::hasSameInitializationOptions const):
20
21 2018-05-14  Brady Eidson  <beidson@apple.com>
22
23         Add an API test to guard against regressions while re-entering setDefersLoading:.
24         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
25
26         Reviewed by Chris Dumez.
27
28         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
30         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
31         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
32         (-[DefersScheme initWithBytes:]):
33         (-[DefersScheme webView:startURLSchemeTask:]):
34         (-[DefersScheme webView:stopURLSchemeTask:]):
35         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
36         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
37         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
38         (-[DoubleDefersLoadingPlugIn dealloc]):
39
40 2018-05-14  Daniel Bates  <dabates@apple.com>
41
42         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
43         https://bugs.webkit.org/show_bug.cgi?id=185599
44         <rdar://problem/22493890>
45
46         Reviewed by Simon Fraser.
47
48         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
49         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
50         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
51         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
52         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
53         (TestWebKitAPI::TEST):
54         * TestWebKitAPI/ios/set-timeout-function.html: Added.
55
56 2018-05-14  Valerie R Young  <valerie@bocoup.com>
57
58         test262/Runner.pm: small bugs in CLI and error codes
59         https://bugs.webkit.org/show_bug.cgi?id=185629
60
61         Reviewed by Michael Saboff.
62
63         Fix two commandline args with use '-f', correct
64         error code of failures.
65
66         * Scripts/test262/Runner.pm:
67         (processCLI):
68         (main):
69
70 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
71
72         Disable API tests that time out after pointer poisioning was disabled.
73         https://bugs.webkit.org/show_bug.cgi?id=185586
74
75         Unreviewed test gardening.
76
77         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
78         (TestWebKitAPI::TEST):
79         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
80         (TestWebKitAPI::TEST):
81         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
82         (TestWebKitAPI::TEST):
83         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
84         (TestWebKitAPI::TEST):
85
86 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
87
88         Test262-Runner: Fix RegExp for capturing tests metadata"
89         https://bugs.webkit.org/show_bug.cgi?id=185622
90
91         Reviewed by Michael Saboff.
92
93         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
94         both LF and CRLF forms.
95
96         The fix also allows the runner to capture the proper results from two specific files using CR and
97         CRLF line terminators. They are updated in the expectations file.
98         * Scripts/test262/Runner.pm:
99         (parseData):
100
101 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
102
103         NSEvent event trackers don't work from WebKitTestRunner
104         https://bugs.webkit.org/show_bug.cgi?id=185383
105         rdar://problem/40025045
106
107         Reviewed by Simon Fraser.
108
109         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
110         NSEvent swipe tracking is used for webkit swipe navigation.
111
112         * WebKitTestRunner/mac/EventSenderProxy.mm:
113         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
114
115 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
116
117         Test262 Runner should search for the Debug JSC by default
118         https://bugs.webkit.org/show_bug.cgi?id=185562
119
120         Reviewed by Michael Saboff.
121
122         The Test262 Runner is now searching for the Debug build of JSC by
123         default, not the Release build.
124
125         This fix allows a similar call from the previous runner, making
126         it compatible with the current build bot configuration parameters.
127
128         This patch also adds some minor improvements the verbose mode output.
129
130         * Scripts/test262/Runner.pm:
131         (processCLI):
132         (main):
133         (getBuildPath):
134         (processResult):
135
136 2018-05-11  Charles Vazac  <cvazac@gmail.com>
137
138         Runtime feature flag for Server-Timing
139         https://bugs.webkit.org/show_bug.cgi?id=184758
140
141         Reviewed by Youenn Fablet.
142
143         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
144         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
145
146 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
147
148         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
149         https://bugs.webkit.org/show_bug.cgi?id=185418
150
151         Reviewed by Alex Christensen.
152
153         All WK1 related code should be moved into MiniBrowser for the preparation
154         of Bug 184770.
155
156         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
157
158         * MiniBrowser/win/Common.cpp:
159         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
160         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
161         * MiniBrowser/win/Common.h: Added.
162         * MiniBrowser/win/MiniBrowser.cpp:
163         (MiniBrowser::init): Moved the initilization code from wWinMain.
164         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
165         * MiniBrowser/win/MiniBrowser.h:
166         (MiniBrowser::setCacheFolder): Changed to a private method.
167         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
168         * MiniBrowser/win/WinMain.cpp:
169         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
170
171 2018-05-11  Brady Eidson  <beidson@apple.com>
172
173         Make sure history navigations reuse the existing process when necessary.
174         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
175
176         Reviewed by Ryosuke Niwa.
177
178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
179
180 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
181
182         [JSC][GLIB] Add introspectable alternatives to functions using vargars
183         https://bugs.webkit.org/show_bug.cgi?id=185508
184
185         Reviewed by Michael Catanzaro.
186
187         Add test cases for the new API.
188
189         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
190         (testJSCFunction):
191         (testJSCObject):
192
193 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
194
195         [Build Bot] Restore configuration options to the Test262 Runner
196
197         During the switch from the previous Test262 runner to the new one,
198         a call for an extra configurations options got removed.
199
200         This call is important to inform the script to find the debug or
201         release build of JSC. It's being restored in this patch.
202
203         https://bugs.webkit.org/show_bug.cgi?id=185513
204
205         Reviewed by Yusuke Suzuki.
206
207         * BuildSlaveSupport/build.webkit.org-config/steps.py:
208         (RunTest262Tests):
209
210 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
211
212         REGRESSION (r230998): Cannot stream API test output
213         https://bugs.webkit.org/show_bug.cgi?id=185090
214
215         Reviewed by Ryosuke Niwa.
216
217         Change run-api-tests so that the stdout and stderr of a test will be printed
218         before it's result. If -v is passed, the output of single test runs will be
219         streamed. 
220
221         * Scripts/webkitpy/api_tests/run_api_tests.py:
222         (run): Use print_timestamps flag.
223         (parse_args): Add timestamps option to print timestamps in the log.
224         * Scripts/webkitpy/api_tests/runner.py:
225         (Runner): Add running status.
226         (Runner.__init__): Add number of workers and a flag to detect if a newline
227         is needed at the beginning of a log line.
228         (Runner.run): Turn off most logging coming from server process since it is
229         not constructive for API tests.
230         (Runner.handle): Add new log message to stream stdout and stderr instead of
231         caching values until the test run finished.
232         (_Worker._run_single_test): Log stdout and stderr in real time.
233         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
234         the test.
235         (_Worker.post): Provide a post with explicitly enumerated argument names.
236         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
237         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
238         (MeteredStream.write): Allow for verbose logging without timestamps.
239         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
240         (RegularTest): Add print_timestamps flag.
241         (RegularTest.setUp):
242         (RegularTest.test_logging_not_included):
243         (VerboseTest.test_log_args):
244         (VerboseWithOutTimestamp):
245         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
246
247 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
248
249         build-webkit can erroneously warn about Xcode being too old
250         https://bugs.webkit.org/show_bug.cgi?id=185533
251
252         Reviewed by Dan Bernstein.
253
254         Don't assume the version number is always a single digit.
255
256         * Scripts/webkitdirs.pm:
257         (determineXcodeVersion):
258
259 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
260
261         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
262         https://bugs.webkit.org/show_bug.cgi?id=185528
263
264         Reviewed by Lucas Forschler.
265
266         * BuildSlaveSupport/build.webkit.org-config/factories.py:
267         (TestFactory.__init__):
268         * BuildSlaveSupport/build.webkit.org-config/steps.py:
269         (InstallWinCairoDependencies):
270
271 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
272
273         Fix some -Wstring-op-truncation warnings
274         https://bugs.webkit.org/show_bug.cgi?id=185496
275
276         Reviewed by Alex Christensen.
277
278         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
279         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
280         set the last bucket to NUL.
281
282         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
283         (TestWebKitAPI::testAtomicStringNumber):
284         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
285         (TestWebKitAPI::testStringNumberFixedPrecision):
286         (TestWebKitAPI::testStringNumberFixedWidth):
287         (TestWebKitAPI::testStringNumber):
288
289 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
290
291         [Win][MiniBrowser] Add a separate WndProc for the layered window
292         https://bugs.webkit.org/show_bug.cgi?id=185460
293
294         Reviewed by Brent Fulgham.
295
296         All WK1 related code should be moved into MiniBrowser for the
297         preparation of Bug 184770.
298
299         The layered window was using WndProc of the main window. The
300         layered window is specific only for WK1. the main window will be
301         shared among WK1 and WK2.
302
303         This change add a new WndProc for the layer window.
304
305         * MiniBrowser/win/Common.cpp:
306         (WndProc): Removed code for the layered windows.
307         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
308         * MiniBrowser/win/MiniBrowser.cpp:
309         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
310         (viewWndProc): New WndProc for the layered windows.
311         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
312         * MiniBrowser/win/MiniBrowser.h:
313         (MiniBrowser::hwnd):
314         * MiniBrowser/win/WinMain.cpp:
315         (wWinMain): Added m_viewWnd.
316
317 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
318
319         Support --verbose in run-javascriptcore-tests
320         https://bugs.webkit.org/show_bug.cgi?id=185492
321
322         Reviewed by Daniel Bates.
323
324         * Scripts/run-javascriptcore-tests:
325         (runJSCStressTests):
326
327 2018-05-10  Valerie R Young  <valerie@bocoup.com>
328
329         test262/Runner.pm: --failing-files uses results file not expectations
330         https://bugs.webkit.org/show_bug.cgi?id=185395
331
332         Reviewed by Michael Saboff.
333
334         --failing-files arg now uses results file to find failing tests
335         to rerun. It will look in the test262-results directory from whereever
336         the script is run, or a results.yaml file can be supplied via command
337         line argument.
338         --expectations arg added for suppling expectation file.
339
340         * Scripts/test262/Runner.pm:
341         (processCLI):
342         (main):
343         (loadImportFile):
344         (findAllFailing):
345
346 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
347
348         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
349         https://bugs.webkit.org/show_bug.cgi?id=185506
350
351         Reviewed by Philippe Normand.
352
353         Useful for testing and debugging.
354
355         * MiniBrowser/gtk/main.c:
356         (main):
357
358 2018-05-09  Chris Dumez  <cdumez@apple.com>
359
360         Unreviewed Windows build fix after r231622.
361
362         * DumpRenderTree/win/DumpRenderTree.cpp:
363         (enableExperimentalFeatures):
364
365 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
366
367         Update WebKit.WebsiteDataStoreCustomPaths after r231536
368         https://bugs.webkit.org/show_bug.cgi?id=185486
369         <rdar://problem/37214391>
370
371         Reviewed by Chris Dumez.
372
373         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
374
375         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
376         (TEST):
377
378 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
379
380         Test262-Runner: Improve the verbose output
381         https://bugs.webkit.org/show_bug.cgi?id=185491
382
383         Reviewed by Michael Saboff.
384
385         * Scripts/test262/Import.pm:
386         (transferFiles):
387         * Scripts/test262/Runner.pm:
388         (processResult):
389
390 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
391
392         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
393         https://bugs.webkit.org/show_bug.cgi?id=185488
394
395         Reviewed by Michael Saboff.
396
397         * Scripts/test262/Runner.pm:
398         (processCLI):
399         (getBuildPath):
400         (runTest):
401
402 2018-05-09  Richard Houle  <rhoule@apple.com>
403
404         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
405         https://bugs.webkit.org/show_bug.cgi?id=185260
406         <rdar://problem/39290394>
407
408         Reviewed by Tim Horton.
409
410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
411         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
412         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
413         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
414         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
415         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
416
417 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
418
419         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
420         https://bugs.webkit.org/show_bug.cgi?id=185481
421
422         Reviewed by Philippe Normand.
423
424         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
425
426         * Scripts/webkitpy/port/gtk.py:
427         (GtkPort.setup_environ_for_server):
428
429 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
430
431         Set build.webkit.org to use the new Test262-runner
432         https://bugs.webkit.org/show_bug.cgi?id=184933
433
434         Reviewed by Aakash Jain.
435
436         * BuildSlaveSupport/build.webkit.org-config/steps.py:
437         (RunTest262Tests):
438         (RunTest262Tests.countFailures):
439         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
440
441 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
442
443         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
444         https://bugs.webkit.org/show_bug.cgi?id=185461
445
446         Reviewed by Michael Catanzaro.
447
448         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
449
450         * gtk/jhbuild.modules:
451
452 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
453
454         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
455
456         * wpe/manifest.txt.in: Distribute the NEWS.
457
458 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
459
460         [WPE] Build cleanly with GCC 8 and ICU 60
461         https://bugs.webkit.org/show_bug.cgi?id=185462
462
463         Reviewed by Carlos Alberto Lopez Perez.
464
465         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
466         sure why this was never noticed until now or why the bots are OK.
467         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
468         * gtk/patches/glib-cast-function-type.patch: Added.
469         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
470         * wpe/patches/glib-cast-function-type.patch: Added.
471
472 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
473
474         [JSC][GTK][JSCONLY] Use capstone disassembler
475         https://bugs.webkit.org/show_bug.cgi?id=185283
476
477         Reviewed by Michael Catanzaro.
478
479         * gtk/manifest.txt.in:
480         * wpe/manifest.txt.in:
481
482 2018-05-09  Antti Koivisto  <antti@apple.com>
483
484         Add OptionSet::operator& and operator bool
485         https://bugs.webkit.org/show_bug.cgi?id=185306
486
487         Reviewed by Anders Carlsson.
488
489         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
490         (TestWebKitAPI::TEST):
491
492 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
493
494         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
495         https://bugs.webkit.org/show_bug.cgi?id=185340
496
497         Reviewed by Tim Horton.
498
499         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
500         non-empty text in a contenteditable.
501
502         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
503         (TestWebKitAPI::TEST):
504
505 2018-05-08  Valerie R Young  <valerie@bocoup.com>
506
507         test262/Runner.pm: create results dir for results of test262 run
508         https://bugs.webkit.org/show_bug.cgi?id=185392
509
510         Reviewed by Michael Saboff.
511
512         New directory test262-results created from where ever script is
513         called.
514
515         * Scripts/test262/Runner.pm:
516         (processCLI):
517
518 2018-05-08  Valerie R Young  <valerie@bocoup.com>
519
520         test262/Runner.pm: lower number of processes per core
521         https://bugs.webkit.org/show_bug.cgi?id=185426
522
523         Reviewed by Michael Saboff.
524
525         * Scripts/test262/Runner.pm:
526         (getProcesses):
527
528 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
529
530         Test262-Runner: Add base Perl UnicodeData
531         https://bugs.webkit.org/show_bug.cgi?id=185444
532
533         Reviewed by Michael Saboff.
534
535         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
536         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
537
538 2018-05-08  Daniel Bates  <dabates@apple.com>
539
540         Add tests to ensure that the Strong Password appearance is removed on form reset
541         https://bugs.webkit.org/show_bug.cgi?id=185440
542
543         Reviewed by Ryosuke Niwa.
544
545         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
546         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
547         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
548         (TEST):
549
550 2018-05-08  Daniel Bates  <dabates@apple.com>
551
552         Resign Strong Password appearance when text field value changes
553         https://bugs.webkit.org/show_bug.cgi?id=185433
554         <rdar://problem/39958508>
555
556         Reviewed by Ryosuke Niwa.
557
558         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
559         when the field has the Strong Password button and its value changes.
560
561         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
562         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
563         (TEST):
564
565 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
566
567         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
568         https://bugs.webkit.org/show_bug.cgi?id=185365
569
570         Reviewed by Saam Barati.
571         
572         Make it possible to measure compile times.
573         
574         Rolling back in after fixing cloop builds.
575
576         * Scripts/run-jsc-benchmarks:
577
578 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
579
580         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
581         https://bugs.webkit.org/show_bug.cgi?id=185414
582
583         Reviewed by Tim Horton.
584
585         Adjust a test expectation to check that the resulting DOM contains an attachment element,
586         anchor element, and another attachment element in that order. This ensures that the test
587         still passes, even after the anchor element is followed by a line break.
588
589         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
590         (TestWebKitAPI::TEST):
591
592 2018-05-08  Commit Queue  <commit-queue@webkit.org>
593
594         Unreviewed, rolling out r231491.
595         https://bugs.webkit.org/show_bug.cgi?id=185434
596
597         Setting the Created key on a cookie does not work yet, due a
598         bug in CFNetwork (Requested by ggaren on #webkit).
599
600         Reverted changeset:
601
602         "[WKHTTPCookieStore getAllCookies] returns inconsistent
603         creation time"
604         https://bugs.webkit.org/show_bug.cgi?id=185041
605         https://trac.webkit.org/changeset/231491
606
607 2018-05-08  Valerie R Young  <valerie@bocoup.com>
608
609         test262/Runner.pm: move input files to JSTests/test262
610         https://bugs.webkit.org/show_bug.cgi?id=185389
611
612         Reviewed by Michael Saboff.
613
614         * Scripts/test262/Runner.pm:
615         (processCLI):
616
617 2018-05-08  Chris Dumez  <cdumez@apple.com>
618
619         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
620
621         * Scripts/webkitpy/performance_tests/perftest.py:
622         (PerfTest):
623
624 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
625
626         Unreviewed, rolling out r231468.
627
628         Broke the CLoop build
629
630         Reverted changeset:
631
632         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
633         any abstract values"
634         https://bugs.webkit.org/show_bug.cgi?id=185365
635         https://trac.webkit.org/changeset/231468
636
637 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
638
639         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
640         https://bugs.webkit.org/show_bug.cgi?id=185041
641         <rdar://problem/34684214>
642
643         Reviewed by Geoffrey Garen.
644
645         Add API test Coverage.
646
647         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
648         (TEST):
649
650 2018-05-08  Chris Dumez  <cdumez@apple.com>
651
652         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
653
654         * Scripts/webkitpy/performance_tests/perftest.py:
655         (PerfTest):
656
657 2018-05-08  Chris Dumez  <cdumez@apple.com>
658
659         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
660
661         * Scripts/webkitpy/performance_tests/perftest.py:
662         (PerfTest):
663
664 2018-05-07  Chris Dumez  <cdumez@apple.com>
665
666         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
667
668         * Scripts/webkitpy/performance_tests/perftest.py:
669         (PerfTest):
670
671 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
672
673         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
674         https://bugs.webkit.org/show_bug.cgi?id=185365
675
676         Reviewed by Saam Barati.
677         
678         Make it possible to measure compile times.
679
680         * Scripts/run-jsc-benchmarks:
681
682 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
683
684         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
685         https://bugs.webkit.org/show_bug.cgi?id=185390
686
687         Reviewed by Michael Saboff.
688
689         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
690
691 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
692
693         Check for com.apple.datamigrator before declaring simulators booted
694         https://bugs.webkit.org/show_bug.cgi?id=185315
695         <rdar://problem/39986261>
696
697         Reviewed by David Kilzer.
698
699         * Scripts/webkitdirs.pm:
700         (waitUntilProcessNotRunning): Wait until a process is not found.
701         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
702         a simulator booted.
703         * Scripts/webkitpy/common/system/executive_mock.py:
704         (MockExecutive2.__init__): Define _running_pids.
705         * Scripts/webkitpy/xcode/simulated_device.py:
706         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
707         declaring that devices have been booted, increase the timeout since data migration will frequently
708         take longer than 60 seconds, especially with multiple simulators booting.
709         (SimulatedDeviceManager.swap): Ditto.
710         (SimulatedDeviceManager):
711         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
712         processes running.
713
714 2018-05-07  Daniel Bates  <dabates@apple.com>
715
716         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
717         https://bugs.webkit.org/show_bug.cgi?id=185054
718         <rdar://problem/39773209>
719
720         Reviewed by Ryosuke Niwa.
721
722         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
723
724         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
725         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
726         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
727         tests for the port.
728
729         * Scripts/webkitpy/port/mac.py:
730         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
731         have Apple Additions.
732         * Scripts/webkitpy/port/mac_unittest.py:
733         (MacTest.test_factory_with_future_version): Added.
734         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
735         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
736         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
737         is absent.
738
739 2018-05-07  Brian Burg  <bburg@apple.com>
740
741         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
742         https://bugs.webkit.org/show_bug.cgi?id=184861
743         <rdar://problem/39153768>
744
745         Reviewed by Timothy Hatcher.
746
747         Add a new test that checks whether a new process is used for navigation when
748         an Inspector is shown. Also check that the behavior reverts to normal after
749         the Inspector has been closed.
750
751         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
752
753 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
754
755         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
756         https://bugs.webkit.org/show_bug.cgi?id=185289
757         <rdar://problem/35756912>
758
759         Reviewed by Tim Horton and Darin Adler.
760
761         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
762         sessions.
763
764         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
765         (TestWebKitAPI::TEST):
766
767 2018-05-04  Timothy Hatcher  <timothy@apple.com>
768
769         Deprecate legacy WebView and friends
770         https://bugs.webkit.org/show_bug.cgi?id=185279
771         rdar://problem/33268700
772
773         Reviewed by Tim Horton.
774
775         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
776         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
777
778 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
779
780         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
781         https://bugs.webkit.org/show_bug.cgi?id=185314
782
783         Reviewed by Michael Saboff.
784
785         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
786
787 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
788
789         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
790         https://bugs.webkit.org/show_bug.cgi?id=184196
791         <rdar://problem/39054481>
792
793         Reviewed by Tim Horton.
794
795         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
796         earlier than 11.3. Also re-enables these tests.
797
798         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
799         (TestWebKitAPI::TEST):
800         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
801         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
802
803 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
804
805         Text shaping in the simple path is flipped in the y direction
806         https://bugs.webkit.org/show_bug.cgi?id=185062
807         <rdar://problem/39778678>
808
809         Reviewed by Simon Fraser.
810
811         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
812
813         * Scripts/webkitpy/common/config/contributors.json:
814
815 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
816
817         Test262-Runner: place the processCLI inside the main call
818         https://bugs.webkit.org/show_bug.cgi?id=185304
819
820         Reviewed by Michael Saboff.
821
822         * Scripts/test262/Runner.pm:
823         (main):
824
825 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
826
827         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
828         https://bugs.webkit.org/show_bug.cgi?id=174730
829
830         Reviewed by Michael Catanzaro.
831
832         Update unit tests to check that User-Agent header is included in HTTP download requests.
833
834         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
835         (testDownloadRemoteFile):
836         (testWebViewDownloadURI):
837         (testPolicyResponseDownload):
838         (testPolicyResponseDownloadCancel):
839         (testDownloadMIMEType):
840         (testContextMenuDownloadActions):
841
842 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
843
844         [WinCairo] Test archive must use Python zipfile, just like build product.
845         https://bugs.webkit.org/show_bug.cgi?id=185265
846
847         Reviewed by Per Arne Vollan.
848
849         * BuildSlaveSupport/test-result-archive:
850         (archive_test_results):
851         Copy over Win32-oriented archiving logic from built-product-archive.
852
853 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
854
855         cleanup modules usage for the Test262-Runner
856         https://bugs.webkit.org/show_bug.cgi?id=185263
857
858         Reviewed by Michael Saboff.
859
860         * Scripts/test262-runner:
861         * Scripts/test262/Runner.pm:
862         (processCLI):
863
864 2018-05-03  Valerie R Young  <valerie@bocoup.com>
865
866         test262/Runner.pm: minor fixes
867         https://bugs.webkit.org/show_bug.cgi?id=185250
868
869         Reviewed by Michael Saboff.
870
871         Add comments, change output and fix bug: unintended interpolation
872         of filename when running jsc.
873
874         * Scripts/test262/Runner.pm:
875         (processCLI):
876         (main):
877         (runTest):
878
879 2018-05-03  Chris Dumez  <cdumez@apple.com>
880
881         Load hangs if the WebProcess fails to launch
882         https://bugs.webkit.org/show_bug.cgi?id=185225
883         <rdar://problem/38249058>
884
885         Reviewed by Geoff Garen.
886
887         Add API test coverage.
888
889         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
890         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
891         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
892         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
893         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
894         (TEST):
895
896 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
897
898         [WinCairo] Add JSC test bots
899         https://bugs.webkit.org/show_bug.cgi?id=185234
900
901         Reviewed by Per Arne Vollan.
902
903         * BuildSlaveSupport/build.webkit.org-config/config.json:
904         * BuildSlaveSupport/build.webkit.org-config/steps.py:
905         (RunJavaScriptCoreTests.start):
906
907 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
908
909         WebKit should send fake macOS user agent to docs.google.com
910         https://bugs.webkit.org/show_bug.cgi?id=185165
911
912         Reviewed by Carlos Garcia Campos.
913
914         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
915         (TestWebKitAPI::TEST):
916
917 2018-05-03  Valerie R Young  <valerie@bocoup.com>
918
919         test262/Runner.pm: performance improvements
920         https://bugs.webkit.org/show_bug.cgi?id=185202
921
922         Reviewed by Michael Saboff.
923
924         Batch the tests by the number of processes, and give each process
925         a file to save results to to avoid threading. Do not parallelize
926         when running small sets of tests.
927
928         * Scripts/test262/Runner.pm:
929         (processCLI):
930         (main):
931         (processFile):
932         (processResult):
933
934 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
935
936         Unreviewed, rolling out r231253.
937
938         The API test added with this change is crashing on the bots.
939
940         Reverted changeset:
941
942         "Web Inspector: opt out of process swap on navigation if a Web
943         Inspector frontend is connected"
944         https://bugs.webkit.org/show_bug.cgi?id=184861
945         https://trac.webkit.org/changeset/231253
946
947 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
948
949         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
950         https://bugs.webkit.org/show_bug.cgi?id=183348
951
952         Reviewed by Michael Catanzaro.
953
954         Add a test case to reproduce the crash.
955
956         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
957         (testWebViewCloseQuickly):
958         (beforeAll):
959
960 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
961
962         Can't copy and paste URLs that have no title into Mail (macOS)
963         https://bugs.webkit.org/show_bug.cgi?id=185205
964         <rdar://problem/36352406>
965
966         Reviewed by Tim Horton.
967
968         Added test to verify behavior when copying and pasting a URL without a title.
969
970         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
971         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
972         (TestWebKitAPI::TEST):
973
974 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
975
976         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
977         https://bugs.webkit.org/show_bug.cgi?id=184699
978
979         Unreviewed follow-up fix after r231230.
980
981         * Scripts/generate-jsc-bundle:
982         (generate_wrapper_script): Quote the arguments passed to jsc.
983
984 2018-05-02  Brian Burg  <bburg@apple.com>
985
986         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
987         https://bugs.webkit.org/show_bug.cgi?id=184861
988         <rdar://problem/39153768>
989
990         Reviewed by Ryosuke Niwa.
991
992         Add a new test that checks whether a new process is used for navigation when
993         an Inspector is shown. Also check that the behavior reverts to normal after
994         the Inspector has been closed.
995
996         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
997
998 2018-05-02  Valerie R Young  <valerie@bocoup.com>
999
1000         test262/Runner.pm: save summary to file
1001         https://bugs.webkit.org/show_bug.cgi?id=185200
1002
1003         Reviewed by Michael Saboff.
1004
1005         * Scripts/test262/Runner.pm:
1006         (processCLI):
1007         (main):
1008         (summarizeResults):
1009
1010 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1011
1012         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
1013         https://bugs.webkit.org/show_bug.cgi?id=184699
1014
1015         Reviewed by Gustavo Noronha Silva.
1016
1017         This adds a new step for the GTK 64-bit release build bot and the
1018         GTK 32-bit release build&test bot.
1019
1020         This step will be run as one of the lasts ones (after the product
1021         is built) and will execute the script generate-jsc-bundle.
1022         This script will take care of creating a JSC bundle and uploading
1023         it to a server defined on a configuration file that has to be
1024         deployed on the bots with the required server data and credentials
1025         for this upload.
1026
1027         In this case, the built products should then be accessible at
1028         <https://webkitgtk.org/jsc-built-products>. But the implementation
1029         is not tied to any specific server. All the details about where
1030         to upload the file is done in configuration file that is kept
1031         private on each bot outside of the WebKit source tree.
1032
1033         The script also supports generating a JSC bundle locally and not
1034         uploading it anywhere. This is the default mode of running.
1035         The remote upload will only be activated if a --remote-config-file
1036         parameter is passed (which is done from the buildbot config)
1037
1038         * BuildSlaveSupport/build.webkit.org-config/config.json:
1039         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1040         (BuildFactory):
1041         (BuildFactory.__init__):
1042         (TestFactory):
1043         (TestFactory.__init__):
1044         (BuildAndGenerateJSCBundleFactory):
1045         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
1046         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1047         (GenerateJSCBundle):
1048         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1049         * Scripts/generate-jsc-bundle: Added.
1050         (ldd_get_libs_and_interpreter):
1051         (generate_readme):
1052         (generate_wrapper_script):
1053         (copy_and_remove_rpath):
1054         (createJSCBundle):
1055         (sha256sum):
1056         (uploadJSCBundle):
1057         (main):
1058
1059 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
1060
1061         PSON: Make WebKitTestRunner work with process swap on navigation turned on
1062         https://bugs.webkit.org/show_bug.cgi?id=185111
1063
1064         Reviewed by Chris Dumez.
1065
1066         Add the basic support for running layout tests with process-swap-on-navigation turned on.
1067
1068         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
1069         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
1070
1071         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
1072         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
1073         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
1074         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
1075
1076         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1077         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
1078         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
1079         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
1080         beginTesting with BegingTestingMode::Resume when this boolean is set.
1081         (WTR::InjectedBundle::didReceiveMessageToPage):
1082         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
1083         bundle after a process swap on navigation.
1084         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1085         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1086         (WTR::InjectedBundlePage::dump):
1087         (WTR::InjectedBundlePage::frameDidChangeLocation):
1088         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1089         (WTR::TestRunner::TestRunner):
1090         (WTR::TestRunner::shouldDumpPixels const): Added.
1091         (WTR::TestRunner::setDumpPixels): Added.
1092         (WTR::TestRunner::dumpAsText):
1093         (WTR::TestRunner::whatToDump const): Added.
1094         (WTR::TestRunner::setWhatToDump): Added.
1095         (WTR::TestRunner::waitUntilDone):
1096         (WTR::TestRunner::setWaitUntilDone): Added.
1097         (WTR::TestRunner::shouldWaitUntilDone): Added.
1098         (WTR::TestRunner::notifyDone):
1099         (WTR::TestRunner::forceImmediateCompletion):
1100         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
1101         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
1102         (WTR::TestRunner::setAudioResult):
1103         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1104         (WTR::TestRunner::dumpChildFramesAsText):
1105         (WTR::TestRunner::dumpDOMAsWebArchive):
1106         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
1107         (WTR::TestRunner::whatToDump const): Moved to cpp.
1108         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
1109         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
1110         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
1111         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
1112         * WebKitTestRunner/TestInvocation.cpp:
1113         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
1114         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
1115         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
1116         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
1117         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
1118         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
1119         started as a result of a process swap on navigation (m_startedTesting is true).
1120         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
1121         support initializing the injected bundle in a process swapped after navigation and set/get messages for
1122         the states which must persist across process swaps within a test.
1123         * WebKitTestRunner/TestInvocation.h:
1124         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1125         * Tools/WebKitTestRunner/WhatToDump.h:
1126         (WTR::WhatToDump): Added.
1127
1128 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
1129
1130         Auto save the results for Test262
1131         https://bugs.webkit.org/show_bug.cgi?id=184926
1132
1133         Reviewed by Michael Saboff.
1134
1135         * Scripts/test262/Runner.pm:
1136         (processCLI):
1137         (main):
1138         (parseError):
1139         (processResult):
1140         (summarizeResults):
1141         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
1142
1143 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
1144
1145         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
1146         https://bugs.webkit.org/show_bug.cgi?id=185164
1147
1148         Reviewed by David Kilzer.
1149
1150         * Scripts/webkitpy/common/system/executive.py:
1151         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
1152         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
1153
1154 2018-05-01  Chris Dumez  <cdumez@apple.com>
1155
1156         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
1157         https://bugs.webkit.org/show_bug.cgi?id=184918
1158         <rdar://problem/39705516>
1159
1160         Reviewed by Wenson Hsieh.
1161
1162         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
1163         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
1164         asynchronously because we ask the client if it is OK to do the load and the policy
1165         delegates are asynchronous nowadays.
1166
1167         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1168         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
1169         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1170         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1171         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
1172         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
1173         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
1174
1175 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
1176
1177         [WinCairo] Align buildbot test stages with AppleWin.
1178         https://bugs.webkit.org/show_bug.cgi?id=185094
1179
1180         Reviewed by Brent Fulgham.
1181
1182         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1183         (TestFactory.__init__):
1184         Do run API tests, don't run dashboard tests.
1185
1186         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1187         (RunUnitTests):
1188         Call run-api-tests with Python, not Perl (bugfix for r230998).
1189
1190         * Scripts/webkitpy/port/win.py:
1191         (WinPort.environment_for_api_tests):
1192         Retrieve necessary Windows environment variables.
1193
1194 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
1195
1196         [MediaStream] remove WK1 support
1197         https://bugs.webkit.org/show_bug.cgi?id=185136
1198
1199         Reviewed by Youenn Fablet.
1200
1201         * DumpRenderTree/mac/UIDelegate.mm:
1202         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
1203
1204 2018-05-01  Chris Dumez  <cdumez@apple.com>
1205
1206         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
1207         https://bugs.webkit.org/show_bug.cgi?id=185157
1208
1209         Reviewed by Geoffrey Garen.
1210
1211         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
1212         common configuration and should therefore be the configuration we test by default.
1213
1214         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1215         (WTR::InjectedBundlePage::decidePolicyForResponse):
1216
1217 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
1218
1219         WebAssembly: add support for stream APIs - JavaScript API
1220         https://bugs.webkit.org/show_bug.cgi?id=183442
1221
1222         Reviewed by Yusuke Suzuki and JF Bastien.
1223
1224         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1225
1226 2018-04-30  Mark Lam  <mark.lam@apple.com>
1227
1228         Apply PtrTags to the MetaAllocator and friends.
1229         https://bugs.webkit.org/show_bug.cgi?id=185110
1230         <rdar://problem/39533895>
1231
1232         Reviewed by Saam Barati.
1233
1234         Update the test to match MetaAllocator changes in WTF.
1235
1236         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1237         (TestWebKitAPI::TEST_F):
1238         (WTF::tagForPtr):
1239         (WTF::ptrTagName):
1240
1241 2018-04-30  Alex Christensen  <achristensen@webkit.org>
1242
1243         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
1244         https://bugs.webkit.org/show_bug.cgi?id=180955
1245
1246         Reviewed by Andy Estes.
1247
1248         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
1249         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
1250         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
1251
1252 2018-04-30  JF Bastien  <jfbastien@apple.com>
1253
1254         Use some C++17 features
1255         https://bugs.webkit.org/show_bug.cgi?id=185135
1256
1257         Reviewed by Alex Christensen.
1258
1259         * DumpRenderTree/PlatformMac.cmake:
1260         * gtk/ycm_extra_conf.py:
1261         (FlagsForFile):
1262
1263 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1264
1265         Use WordLock instead of std::mutex for Threading
1266         https://bugs.webkit.org/show_bug.cgi?id=185121
1267
1268         Reviewed by Geoffrey Garen.
1269
1270         * TestWebKitAPI/Tests/WTF/Signals.cpp:
1271         (TEST):
1272
1273 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1274
1275         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
1276         https://bugs.webkit.org/show_bug.cgi?id=185103
1277
1278         Reviewed by Carlos Garcia Campos.
1279
1280         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1281         (TestWebKitAPI::TEST):
1282
1283 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
1284
1285         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
1286         https://bugs.webkit.org/show_bug.cgi?id=185052
1287
1288         Reviewed by Geoffrey Garen.
1289
1290         Modified API test to provide correct test cases for HTTPOnly flag.
1291
1292         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1293         (TEST):
1294
1295 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
1296
1297         Token misspelled "tocken" in error message string
1298         https://bugs.webkit.org/show_bug.cgi?id=185030
1299
1300         Reviewed by Saam Barati.
1301
1302         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
1303
1304 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
1305
1306         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
1307         https://bugs.webkit.org/show_bug.cgi?id=185049
1308
1309         Reviewed by Keith Miller.
1310
1311         * Scripts/run-javascriptcore-tests:
1312         (runJSCStressTests):
1313         * Scripts/run-jsc-stress-tests:
1314
1315 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1316
1317         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
1318         https://bugs.webkit.org/show_bug.cgi?id=185066
1319
1320         Reviewed by Youenn Fablet.
1321
1322         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
1323         WebKit should not swap WebContent process in this case.
1324
1325         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1326         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1327         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1328
1329 2018-04-27  Nan Wang  <n_wang@apple.com>
1330
1331         AX: Accessibility needs to know which part of the content view is visible on iOS
1332         https://bugs.webkit.org/show_bug.cgi?id=185085
1333         <rdar://problem/39801363>
1334
1335         Reviewed by Chris Fleizach.
1336
1337         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1338         (WTR::AccessibilityUIElement::stringAttributeValue):
1339
1340 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1341
1342         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
1343         https://bugs.webkit.org/show_bug.cgi?id=185050
1344         <rdar://problem/39624038>
1345
1346         Reviewed by Tim Horton.
1347
1348         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
1349         tested by the layout test added in this patch.
1350
1351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1352         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
1353
1354 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1355
1356         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
1357         https://bugs.webkit.org/show_bug.cgi?id=185061
1358
1359         Reviewed by Aakash Jain.
1360
1361         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1362         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
1363         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
1364
1365 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1366
1367         Add release bots for WinCairo.
1368         https://bugs.webkit.org/show_bug.cgi?id=185042
1369
1370         Reviewed by Lucas Forschler.
1371
1372         * BuildSlaveSupport/build.webkit.org-config/config.json:
1373         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
1374
1375 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
1376
1377         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
1378         https://bugs.webkit.org/show_bug.cgi?id=184938
1379         <rdar://problem/34737395>
1380
1381         Reviewed by Geoffrey Garen.
1382
1383         Add API test coverage.
1384
1385         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1386         (TEST):
1387
1388 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1389
1390         WinCairo test bots should run JSC tests with options for Windows command prompt.
1391         https://bugs.webkit.org/show_bug.cgi?id=185019
1392
1393         Reviewed by Per Arne Vollan.
1394
1395         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1396         (RunJavaScriptCoreTests.start):
1397
1398 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
1399
1400         WinCairo WKL Debug Test bot is not using DRT.
1401         https://bugs.webkit.org/show_bug.cgi?id=185009
1402
1403         Reviewed by Per Arne Vollan.
1404
1405         * BuildSlaveSupport/build.webkit.org-config/config.json:
1406
1407 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
1408
1409         Disable content filtering in minimal simulator mode
1410         https://bugs.webkit.org/show_bug.cgi?id=185027
1411         <rdar://problem/39736091>
1412
1413         Reviewed by Jer Noble.
1414
1415         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1416
1417 2018-04-26  Brady Eidson  <beidson@apple.com>
1418
1419         Add a setting for keeping around all processes and always reusing them per-origin.
1420         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
1421
1422         Reviewed by Andy Estes.
1423
1424         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1425
1426 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
1427
1428         [INTL] Implement Intl.PluralRules
1429         https://bugs.webkit.org/show_bug.cgi?id=184312
1430
1431         Reviewed by JF Bastien.
1432
1433         Added Intl.PluralRules feature flag.
1434
1435         * Scripts/webkitperl/FeatureList.pm:
1436         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1437
1438 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1439
1440         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
1441         https://bugs.webkit.org/show_bug.cgi?id=184643
1442
1443         Reviewed by Žan Doberšek.
1444
1445         Add missing INCLUDE_DIRS in many places.
1446
1447         Adapt to single-header WPE includes.
1448
1449         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
1450
1451         * TestWebKitAPI/PlatformWPE.cmake:
1452         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1453         (testWebViewWebBackend):
1454         * TestWebKitAPI/glib/PlatformWPE.cmake:
1455         * WebKitTestRunner/EventSenderProxy.h:
1456         * WebKitTestRunner/PlatformWPE.cmake:
1457         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1458         * wpe/HeadlessViewBackend/CMakeLists.txt:
1459         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
1460         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
1461         * wpe/jhbuild.modules:
1462
1463 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
1464
1465         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
1466         https://bugs.webkit.org/show_bug.cgi?id=184982
1467
1468         Rubber-stamped by Aakash Jain.
1469
1470         Correctly count the number of API test failures.
1471
1472         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1473         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
1474         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1475         * Scripts/webkitpy/api_tests/manager.py:
1476         (Manager.run): Disabled tests are not run.
1477
1478 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
1479
1480         Remove access to keychain from the WebContent process
1481         https://bugs.webkit.org/show_bug.cgi?id=184428
1482         <rdar://problem/13150903>
1483
1484         Reviewed by Brent Fulgham.
1485
1486         This patch does the followings:
1487         1. Added an API test for this patch.
1488         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
1489
1490         * DumpRenderTree/mac/UIDelegate.mm:
1491         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
1492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1493         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
1494         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
1495         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
1496         (TestWebKitAPI::TEST_F):
1497         * WebKitTestRunner/TestController.cpp:
1498         (WTR::copySignedPublicKeyAndChallengeString):
1499         (WTR::TestController::createOtherPage):
1500         (WTR::TestController::createWebViewWithOptions):
1501
1502 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1503
1504         [Extra zoom mode] The search field on www.bing.com is missing label text
1505         https://bugs.webkit.org/show_bug.cgi?id=184975
1506         <rdar://problem/39723081>
1507
1508         Reviewed by Tim Horton.
1509
1510         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
1511         focused element in extra zoom mode.
1512
1513         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1514         (WTR::UIScriptController::formInputLabel const):
1515         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1516         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1517         (WTR::UIScriptController::formInputLabel const):
1518         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1519         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1520         (WTR::UIScriptController::formInputLabel const):
1521
1522 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1523
1524         [WPE] Should load injected bundle from builddir in developer builds
1525         https://bugs.webkit.org/show_bug.cgi?id=184983
1526
1527         Reviewed by Carlos Alberto Lopez Perez.
1528
1529         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
1530
1531         * Scripts/run-minibrowser:
1532
1533 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1534
1535         [WPE] libgstggtk.so broken in jhbuild environment
1536         https://bugs.webkit.org/show_bug.cgi?id=184984
1537
1538         Reviewed by Carlos Alberto Lopez Perez.
1539
1540         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
1541         gst-plugins-good.
1542
1543         * wpe/jhbuild.modules:
1544
1545 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1546
1547         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
1548         https://bugs.webkit.org/show_bug.cgi?id=184962
1549
1550         Reviewed by Youenn Fablet.
1551
1552         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
1553
1554         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1555         (ProcessSwap.SameOriginBlobNavigation): Added.
1556         (ProcessSwap.CrossOriginBlobNavigation): Added.
1557         (ProcessSwap.NavigateToAboutBlank): Added.
1558         (ProcessSwap.NavigateToDataURL): Added.
1559
1560 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1561
1562         [WPE] Remove deprecated functions and properties from the API
1563         https://bugs.webkit.org/show_bug.cgi?id=179295
1564
1565         Reviewed by Žan Doberšek.
1566
1567         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1568         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
1569         to rewrite LoadTrackingTest to not require the web view at construction time.
1570         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1571         (testWebKitSettings): Don't test private browsing setting, which is gone.
1572         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
1573
1574 2018-04-25  Andy Estes  <aestes@apple.com>
1575
1576         [Mac] Number of drop items is always 0 when performing a DHTML drag
1577         https://bugs.webkit.org/show_bug.cgi?id=184943
1578
1579         Reviewed by Ryosuke Niwa.
1580
1581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1582         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
1583         (-[DragInfo numberOfValidItemsForDrop]):
1584         (-[DragInfo setNumberOfValidItemsForDrop:]):
1585         (TestWebKitAPI::TEST):
1586         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
1587
1588 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
1589
1590         API test harness should be Python
1591         https://bugs.webkit.org/show_bug.cgi?id=181043
1592         <rdar://problem/36164410>
1593
1594         Reviewed by David Kilzer.
1595
1596         Run API tests from a Python script rather than Perl. The Python API tests have
1597         the same structure as the layout tests.
1598
1599         * Scripts/run-api-tests: Changed from Perl to Python.
1600         * Scripts/webkitpy/api_tests: Added.
1601         * Scripts/webkitpy/api_tests/__init__.py: Added.
1602         * Scripts/webkitpy/api_tests/manager.py: Added.
1603         (Manager):
1604         (Manager.__init__):
1605         (Manager._test_list_from_output): Construct a list of tests from the output of
1606         TestWTF and TestWebKitAPI.
1607         (Manager._find_test_subset): Given a list of all possible tests and command line
1608         arguments, return a list of tests which match the provided arguments.
1609         (Manager._collect_tests): Run TestWTF and TestWebKitAPI with --gtest_list_tests
1610         to determine which tests will be run.
1611         (Manager._print_test_result): Formatted print of a test with it's output.
1612         (Manager._print_tests_result_with_status): Print all tests and output for tests
1613         which ran with a specified exit status.
1614         (Manager.run): Collect all tests, run them and then print results from the run.
1615         * Scripts/webkitpy/api_tests/run_api_tests.py: Added.
1616         (main): Parse arguments, construct a port, early exit for illegal ports and
1617         then run tests.
1618         (run): Setup logging and printing before using the Manager to run tests.
1619         (parse_args): Use argparse to define all options used by run-api-tests.
1620         * Scripts/webkitpy/api_tests/runner.py: Added.
1621         (Runner):
1622         (Runner.__init__):
1623         (Runner._shard_tests): Split tests so that each suite runs together.
1624         (Runner.command_for_port): Run a command on the device specified by the given
1625         port object. Once <https://bugs.webkit.org/show_bug.cgi?id=175204> is completed,
1626         this function would be entirely replaced by the server_process factory owned
1627         by the port object.
1628         (Runner.run): Run all shards in the message_pool.
1629         (Runner.handle): Handle reports from child processes.
1630         (Runner.result_map_by_status): Return a mapping of tests to output for tests
1631         which exit with a specific status.
1632         (_Worker):
1633         (_Worker.__init__):
1634         (_Worker._filter_noisy_output): Filter out objc warnings since these polite the log.
1635         (_Worker._run_single_test): Runs a single test in a single child process.
1636         (_Worker._run_shard_with_binary): Attempts to run a group of tests in the same
1637         child process. If this technique fails, the remaining tests are run singly.
1638         (_Worker.handle): Run the specified shard.
1639         * Scripts/webkitpy/port/base.py:
1640         (Port):
1641         (Port.check_api_test_build): Check if TestWTF and TestWebKitAPI are built.
1642         (Port.environment_for_api_tests): Return the environment needed to run
1643         the TestWebKitAPI binary.
1644         (Port. path_to_api_test_binaries): Return a list of the path to all binaries
1645         used when running API tests.
1646         (Port._build_api_tests): Build TestWTF and TestWebKitAPI if required.
1647         * Scripts/webkitpy/port/mac.py:
1648         (MacPort.environment_for_api_tests): Enable GuardMalloc for API tests.
1649         * Scripts/webkitpy/port/server_process.py: 
1650         (ServerProcess.pop_all_buffered_stdout):
1651
1652 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1653
1654         Incorrect number of WebDriver test failures shown in the bots
1655         https://bugs.webkit.org/show_bug.cgi?id=184959
1656
1657         Reviewed by Michael Catanzaro.
1658
1659         The regular expression we are using to get the number of failures from the log is matching a particular test
1660         error output. Improve the regular expression to avoid matching other strings in the log. Ensure that only
1661         matches at the beginning of lines and add spaces after Unexpected and before the (<failures>).
1662
1663         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1664         (RunWebDriverTests.commandComplete):
1665
1666 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1667
1668         [GTK] Implement MouseEvent.buttons
1669         https://bugs.webkit.org/show_bug.cgi?id=184913
1670
1671         Reviewed by Žan Doberšek.
1672
1673         Include the mouse buttons state in WTR synthesized events.
1674
1675         * WebKitTestRunner/EventSenderProxy.h:
1676         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1677         (WTR::EventSenderProxy::EventSenderProxy):
1678         (WTR::EventSenderProxy::createMouseButtonEvent):
1679         (WTR::EventSenderProxy::mouseDown):
1680         (WTR::EventSenderProxy::mouseUp):
1681         (WTR::EventSenderProxy::mouseMoveTo):
1682
1683 2018-04-24  Pablo Saavedra  <psaavedra@igalia.com>
1684
1685         [GTK][WPE] Fix triggered bot name on the WPE Debug Build bot
1686         https://bugs.webkit.org/show_bug.cgi?id=184954
1687
1688         Reviewed by Michael Catanzaro.
1689
1690         * BuildSlaveSupport/build.webkit.org-config/config.json:
1691
1692 2018-04-24  Saam Barati  <sbarati@apple.com>
1693
1694         Keep around a pre-warmed process when doing process swap on navigation
1695         https://bugs.webkit.org/show_bug.cgi?id=184765
1696         <rdar://problem/39685099>
1697
1698         Reviewed by Ryosuke Niwa and Brady Eidson.
1699
1700         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1701
1702 2018-04-24  Aakash Jain  <aakash_jain@apple.com>
1703
1704         [build.webkit.org] unit-tests fail when passwords.json is missing
1705         https://bugs.webkit.org/show_bug.cgi?id=180390
1706
1707         Reviewed by Carlos Alberto Lopez Perez.
1708
1709         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
1710         (loadBuilderConfig): Add support for test_mode. Load mock passwords in test_mode.
1711         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1712         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): Call _add_webkitpy_to_sys_path as well.
1713         (BuildBotConfigLoader._mock_open): Deleted.
1714         (BuildBotConfigLoader.load_config): Deleted.
1715
1716 2018-04-24  John Wilander  <wilander@apple.com>
1717
1718         From-Origin: Support for 'same' and 'same-site' response header, nested frame origin check
1719         https://bugs.webkit.org/show_bug.cgi?id=184560
1720         <rdar://problem/38901344>
1721
1722         Reviewed by Youenn Fablet and Daniel Bates.
1723
1724         This patch implements significant parts of https://github.com/whatwg/fetch/issues/687.
1725         We consume the From-Origin response header and only load the resource if:
1726         - The header is non-existent, empty, or invalid.
1727         - The header specifies 'same' and the resource's origin matches the originating
1728           document's origin and the origins up the frame tree.
1729         - The header specifies 'same-site' and the resource's eTLD+1 matches the originating
1730           document's eTLD+1 and the eTLD+1 of the documents up the frame tree.
1731
1732         This feature is experimental and off by default.
1733
1734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1735         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: Added.
1736         (TestWebKitAPI::TEST):
1737             Tests for From-Origin header parsing.
1738
1739 2018-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1740
1741         Unreviewed. Update W3C WebDriver imported tests.
1742
1743         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1744         (WebDriverW3CExecutor.__init__):
1745
1746 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
1747
1748         [WPE] Remove libgbm dependency
1749         https://bugs.webkit.org/show_bug.cgi?id=184906
1750
1751         Reviewed by Carlos Garcia Campos.
1752
1753         Stop searching for libgbm, using its compiler flags for the
1754         HeadlessViewBackend compilation and linking against the .so object.
1755         This is not necessary anymore after r230562 switched to a different
1756         backend implementation for testing.
1757
1758         * wpe/HeadlessViewBackend/CMakeLists.txt:
1759         * wpe/install-dependencies:
1760
1761 2018-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1762
1763         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests
1764         https://bugs.webkit.org/show_bug.cgi?id=184816
1765
1766         Reviewed by Michael Catanzaro.
1767
1768         Pass a function from api test runner to glib test runner to check if a test is slow and use the given slow
1769         timeout.
1770
1771         * TestWebKitAPI/glib/TestExpectations.json:
1772         * glib/api_test_runner.py:
1773         (TestRunner._run_test_glib.is_slow_test):
1774         (TestRunner._run_test_glib):
1775         * glib/glib_test_runner.py:
1776         (GLibTestRunner.__init__):
1777         (GLibTestRunner._stop_timeout):
1778         (GLibTestRunner._subtest_start):
1779         (GLibTestRunner._subtest_end):
1780
1781 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1782
1783         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
1784         https://bugs.webkit.org/show_bug.cgi?id=184901
1785         <rdar://problem/39664797>
1786
1787         Reviewed by Tim Horton.
1788
1789         Introduce a new UIScriptController method to set the value of a currently focused input of type time, by
1790         interacting with the UI. See WebKit ChangeLogs for more detail.
1791
1792         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1793         (WTR::UIScriptController::setTimePickerValue):
1794         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1795         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1796         (WTR::UIScriptController::setTimePickerValue):
1797         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1798         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1799         (WTR::UIScriptController::setTimePickerValue):
1800
1801 2018-04-23  Zalan Bujtas  <zalan@apple.com>
1802
1803         [LayoutFormattingContext] Initial commit.
1804         https://bugs.webkit.org/show_bug.cgi?id=184896
1805
1806         Reviewed by Antti Koivisto.
1807
1808         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1809
1810 2018-04-23  Chris Dumez  <cdumez@apple.com>
1811
1812         [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
1813         https://bugs.webkit.org/show_bug.cgi?id=184801
1814
1815         Reviewed by Geoffrey Garen.
1816
1817         Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
1818         This is a more common configuration and therefore should be the default testing configuration.
1819
1820         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1821         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1822         Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
1823         is now asked for the policy decision.
1824
1825 2018-04-23  Pablo Saavedra  <psaavedra@igalia.com>
1826
1827         [GTK][WPE] Add Debug bots (build and tests) for WPE
1828         https://bugs.webkit.org/show_bug.cgi?id=184887
1829
1830         Reviewed by Carlos Alberto Lopez Perez.
1831
1832         Deployed 2 new bots for WPE Debug: wpe-linux-bot-3 and
1833         wpe-linux-bot-4
1834
1835         Both bots have already the credentials ready to authenticated against
1836         build.webkit.org. They provides the bots for the "debug" configuration over
1837         the "WPE" platform and building for the "x86_64" architecture:
1838         WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests) 
1839
1840         * BuildSlaveSupport/build.webkit.org-config/config.json:
1841         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1842
1843 2018-04-23  Chris Dumez  <cdumez@apple.com>
1844
1845         HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction
1846         https://bugs.webkit.org/show_bug.cgi?id=184848
1847         <rdar://problem/39145306>
1848
1849         Reviewed by Brady Eidson.
1850
1851         Add API test coverage.
1852
1853         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1854         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
1855         (TEST):
1856
1857 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
1858
1859         [GTK][WPE] TestSSL fails due to additional TLS errors returned
1860         https://bugs.webkit.org/show_bug.cgi?id=184860
1861
1862         Reviewed by Carlos Garcia Campos.
1863
1864         Add script and config file for regenerating the test certificate.
1865         Regenerate it. TestSSL no longer fails on my machine.
1866
1867         I do see a ton of network process crashes and JavaScript errors, none of
1868         which prevent the test from passing, but this commit only claims to fix
1869         the certificate validation portion of the test.
1870
1871         * TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
1872         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
1873         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
1874
1875 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1876
1877         [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
1878         https://bugs.webkit.org/show_bug.cgi?id=184815
1879
1880         Reviewed by Michael Catanzaro.
1881
1882         This is because in the test we are calling both join and detach. We should only call join.
1883
1884         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1885         (testsJSCVirtualMachine):
1886
1887 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1888
1889         [GLIB] Test /jsc/prototypes crashes in debug
1890         https://bugs.webkit.org/show_bug.cgi?id=184814
1891
1892         Reviewed by Michael Catanzaro.
1893
1894         We should also call the constructor/destructor of Bar struct to ensure Foo is constructed.
1895
1896         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1897         (barCreate):
1898         (barFree):
1899
1900 2018-04-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1901
1902         REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
1903         https://bugs.webkit.org/show_bug.cgi?id=184804
1904
1905         Reviewed by Carlos Garcia Campos.
1906
1907         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1908         (WebSocketTest::WebSocketTest):
1909         (WebSocketTest::~WebSocketTest):
1910         (WebSocketTest::serverWebSocketCallback):
1911         (WebSocketTest::webSocketTestResultCallback):
1912         (WebSocketTest::connectToServerAndWaitForEvents):
1913         (testWebSocketTLSErrors):
1914         (beforeAll):
1915
1916 2018-04-20  Chris Dumez  <cdumez@apple.com>
1917
1918         Unreviewed, update 2 more API tests after r230876.
1919
1920         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1921         (TEST):
1922         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1923         (TestWebKitAPI::TEST):
1924
1925 2018-04-20  Tim Horton  <timothy_horton@apple.com>
1926
1927         Adjust geolocation feature flag
1928         https://bugs.webkit.org/show_bug.cgi?id=184856
1929
1930         Reviewed by Wenson Hsieh.
1931
1932         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1933
1934 2018-04-20  Chris Dumez  <cdumez@apple.com>
1935
1936         REGRESSION (r229828): web view doesn’t update or respond to resizing until client calls policy decision handler
1937         https://bugs.webkit.org/show_bug.cgi?id=184210
1938         <rdar://problem/39072354>
1939
1940         Reviewed by Wenson Hsieh.
1941
1942         * TestWebKitAPI/Tests/WebKit/large-red-square-image.html:
1943         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-change-selection-offscreen.html:
1944         Add viewport meta tags.
1945
1946         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1947         (-[WKWebView _test_waitForDidFinishNavigation]):
1948         Update _test_waitForDidFinishNavigation to wait for the next presentation update
1949         to make iOS API tests happy without having to modify each of them.
1950
1951 2018-04-20  Timothy Hatcher  <timothy@apple.com>
1952
1953         REGRESSION: API test WebKit.BackgroundColorSystemColor is failing
1954
1955         https://bugs.webkit.org/show_bug.cgi?id=184849
1956         rdar://problem/39386405
1957
1958         Reviewed by Brian Burg.
1959
1960         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
1961         (TestWebKitAPI::TEST): Use CGColorEqualToColor since we might get a different
1962         CGColor pointer from NSColor each time.
1963
1964 2018-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1965
1966         [Extra zoom mode] Injected bundle form client should be notified when editing text fields
1967         https://bugs.webkit.org/show_bug.cgi?id=184822
1968         <rdar://problem/38807319>
1969
1970         Reviewed by Tim Horton.
1971
1972         Add WebKitTestRunner support for listening to form editing SPI hooks in the injected bundle. The new layout test
1973         installs callbacks that listen for "begin editing", "end editing", and "text changed" calls to injected bundle
1974         SPI. See other ChangeLogs for more detail.
1975
1976         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1977         (WTR::UIScriptController::enterText):
1978         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1979
1980         Add UIScriptController support for simulating text entry in the currently focused element.
1981
1982         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1983         (WTR::UIScriptController::enterText):
1984         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1985         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1986
1987         Add TestRunner bindings for registering injected bundle form client callbacks.
1988
1989         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1990         (WTR::handleTextDidChangeInTextField):
1991         (WTR::handleTextFieldDidBeginEditing):
1992         (WTR::handleTextFieldDidEndEditing):
1993         (WTR::InjectedBundle::didCreatePage):
1994
1995         Set the injected bundle form editor client.
1996
1997         (WTR::InjectedBundle::setUpInjectedBundleClients):
1998         (WTR::InjectedBundle::textDidChangeInTextField):
1999         (WTR::InjectedBundle::textFieldDidBeginEditing):
2000         (WTR::InjectedBundle::textFieldDidEndEditing):
2001         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2002         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2003         (WTR::TestRunner::installTextDidChangeInTextFieldCallback):
2004         (WTR::TestRunner::textDidChangeInTextFieldCallback):
2005         (WTR::TestRunner::installTextFieldDidBeginEditingCallback):
2006         (WTR::TestRunner::textFieldDidBeginEditingCallback):
2007         (WTR::TestRunner::installTextFieldDidEndEditingCallback):
2008         (WTR::TestRunner::textFieldDidEndEditingCallback):
2009         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2010         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2011         (WTR::UIScriptController::enterText):
2012
2013 2018-04-20  Youenn Fablet  <youenn@apple.com>
2014
2015         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
2016         https://bugs.webkit.org/show_bug.cgi?id=184369
2017
2018         Reviewed by Chris Dumez.
2019
2020         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2021         (TEST):
2022
2023 2018-04-20  Daniel Bates  <dabates@apple.com>
2024
2025         Remove Strong Password decoration when text field type changes
2026         https://bugs.webkit.org/show_bug.cgi?id=184795
2027         <rdar://problem/38325108>
2028
2029         Reviewed by Antti Koivisto.
2030
2031         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2032         when the field has the Strong Password button and its type changes.
2033
2034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2035         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm: Added.
2036         (didResignInputElementStrongPasswordAppearance):
2037         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
2038         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2039         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]):
2040         (-[DidResignInputElementStrongPasswordAppearanceDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2041         (TEST):
2042
2043 2018-04-20  Brady Eidson  <beidson@apple.com>
2044
2045         Add a test to verify load/unload/pageshow/pagehide all work with process swapping.
2046         https://bugs.webkit.org/show_bug.cgi?id=184807
2047
2048         Reviewed by Chris Dumez.
2049
2050         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2051         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
2052
2053 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2054
2055         Unreviewed. Mark TestJSC as slow in debug.
2056
2057         Only /jsc/vm is slow, but GLib API test runner only checks the test binary for GLib tests.
2058
2059         * TestWebKitAPI/glib/TestExpectations.json:
2060
2061 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2062
2063         [GTK] Local cross references are broken in API documentation
2064         https://bugs.webkit.org/show_bug.cgi?id=184771
2065
2066         Reviewed by Michael Catanzaro.
2067
2068         The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
2069         ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
2070         ../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
2071         the cases.
2072
2073         * gtk/gtkdoc.py:
2074         (GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
2075         anything here.
2076         (GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
2077         (GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
2078         which gtkdoc-fixxref always uses absolute paths.
2079         * gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
2080
2081 2018-04-19  Brady Eidson  <beidson@apple.com>
2082
2083         Make back forward cache work with process swapping.
2084         <rdar://problem/38676604> and https://bugs.webkit.org/show_bug.cgi?id=184793
2085
2086         Reviewed by Chris Dumez.
2087
2088         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2089
2090 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2091
2092         Enable Objective-C weak references
2093         <https://webkit.org/b/184789>
2094         <rdar://problem/39571716>
2095
2096         Reviewed by Dan Bernstein.
2097
2098         * ContentExtensionTester/Configurations/Base.xcconfig:
2099         (CLANG_ENABLE_OBJC_WEAK): Enable.
2100         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2101         (CLANG_ENABLE_OBJC_WEAK): Enable.
2102         * ImageDiff/cg/Configurations/Base.xcconfig:
2103         (CLANG_ENABLE_OBJC_WEAK): Enable.
2104         * MiniBrowser/Configurations/Base.xcconfig:
2105         (CLANG_ENABLE_OBJC_WEAK): Enable.
2106         * TestWebKitAPI/Configurations/Base.xcconfig:
2107         (CLANG_ENABLE_OBJC_WEAK): Enable.
2108         * WebEditingTester/Configurations/Base.xcconfig:
2109         (CLANG_ENABLE_OBJC_ARC): Re-order.
2110         * WebKitLauncher/Configurations/Base.xcconfig: Add newline at
2111         end of file.
2112         (CLANG_ENABLE_OBJC_WEAK): Enable.
2113         * WebKitTestRunner/Configurations/Base.xcconfig:
2114         (CLANG_ENABLE_OBJC_WEAK): Enable.
2115
2116 2018-04-19  Chris Dumez  <cdumez@apple.com>
2117
2118         REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string
2119         https://bugs.webkit.org/show_bug.cgi?id=184209
2120         <rdar://problem/39145306>
2121
2122         Reviewed by Ryosuke Niwa.
2123
2124         Add API test coverage.
2125
2126         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2127         (TEST):
2128
2129 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2130
2131         [WinCairo][EWS] Build bot should clean user temp directory each time.
2132         https://bugs.webkit.org/show_bug.cgi?id=184761
2133
2134         Reviewed by Lucas Forschler.
2135
2136         * EWSTools/Start-Queue.ps1:
2137         Clean user's temp directory before each build, so that Windows git doesn't fill it up over time.
2138
2139 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2140
2141         Buildbots using Python zipfile should enable compression
2142         https://bugs.webkit.org/show_bug.cgi?id=184759
2143
2144         Reviewed by Lucas Forschler.
2145
2146         * BuildSlaveSupport/built-product-archive:
2147         (createZipManually):
2148         Default is to archive without compressing, so tell it to compress as well. 
2149
2150 2018-04-18  Nan Wang  <n_wang@apple.com>
2151
2152         AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event
2153         https://bugs.webkit.org/show_bug.cgi?id=184742
2154
2155         Reviewed by Chris Fleizach.
2156
2157         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2158         (AccessibilityUIElement::increment):
2159         (AccessibilityUIElement::decrement):
2160         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2161         (WTR::AccessibilityUIElement::asyncIncrement):
2162         (WTR::AccessibilityUIElement::asyncDecrement):
2163         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2164         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2165         (WTR::AccessibilityUIElement::increment):
2166         (WTR::AccessibilityUIElement::decrement):
2167         (WTR::AccessibilityUIElement::asyncIncrement):
2168         (WTR::AccessibilityUIElement::asyncDecrement):
2169
2170 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
2171
2172         Fix archive step for WinCairo build bot.
2173         https://bugs.webkit.org/show_bug.cgi?id=184715
2174
2175         Reviewed by Lucas Forschler.
2176
2177         * BuildSlaveSupport/built-product-archive:
2178         (archiveBuiltProduct):
2179         (extractBuiltProduct):
2180
2181 2018-04-18  Sihui Liu  <sihui_liu@apple.com>
2182
2183         REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list
2184         https://bugs.webkit.org/show_bug.cgi?id=184570
2185         <rdar://problem/34807323>
2186
2187         Reviewed by Chris Dumez.
2188
2189         Add API test coverage.
2190
2191         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
2192         (TEST):
2193
2194 2018-04-18  Chris Dumez  <cdumez@apple.com>
2195
2196         Add support for converting a local window to a remote window
2197         https://bugs.webkit.org/show_bug.cgi?id=184515
2198         <rdar://problem/39011318>
2199
2200         Reviewed by Ryosuke Niwa.
2201
2202         * MiniBrowser/mac/AppDelegate.m:
2203         (defaultConfiguration):
2204         * MiniBrowser/mac/SettingsController.h:
2205         * MiniBrowser/mac/SettingsController.m:
2206         (-[SettingsController _populateMenu]):
2207         (-[SettingsController validateMenuItem:]):
2208         (-[SettingsController processSwapOnWindowOpenWithOpenerEnabled]):
2209         (-[SettingsController toggleProcessSwapOnWindowOpenWithOpener:]):
2210         Add menu entry in minibrowser to turn on process swap on cross-origin window.open().
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2213         Turn on process swap on cross-origin window.open() for corresponding test and update
2214         test to expect that a new WebProcess is created.
2215
2216         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2217         (WTR::InjectedBundlePage::decidePolicyForResponse):
2218         Add null checks for injectedBundle.testRunner(). When we swap process on navigation,
2219         the InjectedBundlePage::decidePolicyForResponse() gets called in the new process.
2220         In this new process, we have constructed a InjectedBundlePage for the page but we
2221         have not initialized the InjectedBundle members such as testRunner.
2222
2223         * WebKitTestRunner/TestController.cpp:
2224         (WTR::TestController::createWebViewWithOptions):
2225         (WTR::updateTestOptionsFromTestHeader):
2226         * WebKitTestRunner/TestOptions.h:
2227         (WTR::TestOptions::hasSameInitializationOptions const):
2228         Add a way for layout tests to turn on process swap on navigation via a test header.
2229
2230 2018-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
2231
2232         Unreviewed, reland r230697, r230720, and r230724.
2233         https://bugs.webkit.org/show_bug.cgi?id=184600
2234
2235         * Scripts/run-jsc-stress-tests:
2236
2237 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2238
2239         [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
2240         https://bugs.webkit.org/show_bug.cgi?id=184687
2241
2242         Reviewed by Michael Catanzaro.
2243
2244         Add test cases for the new API.
2245
2246         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2247         (fooCreate):
2248         (fooFree):
2249         (fooGetProperty):
2250         (fooSetProperty):
2251         (testJSCPromises):
2252         (testJSCGarbageCollector):
2253         (testsJSCVirtualMachine):
2254         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2255         (windowObjectClearedCallback):
2256
2257 2018-04-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2258
2259         [Extra zoom mode] Programmatically changing focus when an element already has focus is a confusing experience
2260         https://bugs.webkit.org/show_bug.cgi?id=184635
2261         <rdar://problem/39440642>
2262
2263         Reviewed by Tim Horton.
2264
2265         Add plumbing to support invoking `didHideKeyboardCallback` and `didShowKeyboardCallback` when (respectively)
2266         dismissing or presenting fullscreen input view controllers in extra zoom mode.
2267
2268         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2269         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2270         (-[TestRunnerWKWebView dealloc]):
2271         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
2272         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
2273         (-[TestRunnerWKWebView _keyboardDidShow:]):
2274         (-[TestRunnerWKWebView _keyboardDidHide:]):
2275         (-[TestRunnerWKWebView _webView:didPresentFocusedElementViewController:]):
2276         (-[TestRunnerWKWebView _webView:didDismissFocusedElementViewController:]):
2277
2278 2018-04-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2279
2280         [GTK] Webkit should spoof as Safari on a Mac for Outlook.com
2281         https://bugs.webkit.org/show_bug.cgi?id=184573
2282
2283         Reviewed by Carlos Alberto Lopez Perez.
2284
2285         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2286         (TestWebKitAPI::TEST):
2287
2288 2018-04-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2289
2290         [WinCairo][TestWebKitAPI] Implement PlatformWebView for TestWebKit
2291         https://bugs.webkit.org/show_bug.cgi?id=184524
2292
2293         Reviewed by Alex Christensen.
2294
2295         Resurrect PlatformWebView for Windows port which was removed in Bug 104607.
2296
2297         * TestWebKitAPI/PlatformWebView.h:
2298         * TestWebKitAPI/PlatformWin.cmake:
2299         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
2300         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2301         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2302         (TestWebKitAPI::Util::moduleDirectory):
2303         (TestWebKitAPI::Util::createInjectedBundlePath):
2304         (TestWebKitAPI::Util::createURLForResource):
2305         (TestWebKitAPI::Util::URLForNonExistentResource):
2306         (TestWebKitAPI::Util::isKeyDown):
2307         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2308         (TestWebKitAPI::PlatformWebView::registerWindowClass):
2309         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2310         (TestWebKitAPI::PlatformWebView::initialize):
2311         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2312         (TestWebKitAPI::PlatformWebView::page const):
2313         (TestWebKitAPI::PlatformWebView::resizeTo):
2314         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2315         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2316         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2317         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2318         (TestWebKitAPI::PlatformWebView::wndProc):
2319         * TestWebKitAPI/win/UtilitiesWin.cpp: Added.
2320         (TestWebKitAPI::Util::run):
2321         (TestWebKitAPI::Util::spinRunLoop):
2322         (TestWebKitAPI::Util::sleep):
2323
2324 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2325
2326         Fix hasher tests for system with 32 bit longs
2327         https://bugs.webkit.org/show_bug.cgi?id=184708
2328         <rdar://problem/39459977>
2329
2330         Reviewed by Mark Lam.
2331
2332         Some systems have 32 bit longs. The Hasher WTF tests should handle this case.
2333
2334         * TestWebKitAPI/Tests/WTF/Hasher.cpp:
2335         (TestWebKitAPI::TEST):
2336
2337 2018-04-17  Commit Queue  <commit-queue@webkit.org>
2338
2339         Unreviewed, rolling out r230697, r230720, and r230724.
2340         https://bugs.webkit.org/show_bug.cgi?id=184717
2341
2342         These caused multiple failures on the Test262 testers.
2343         (Requested by mlewis13 on #webkit).
2344
2345         Reverted changesets:
2346
2347         "[WebAssembly][Modules] Prototype wasm import"
2348         https://bugs.webkit.org/show_bug.cgi?id=184600
2349         https://trac.webkit.org/changeset/230697
2350
2351         "[WebAssembly][Modules] Implement function import from wasm
2352         modules"
2353         https://bugs.webkit.org/show_bug.cgi?id=184689
2354         https://trac.webkit.org/changeset/230720
2355
2356         "[JSC] Rename runWebAssembly to runWebAssemblySuite"
2357         https://bugs.webkit.org/show_bug.cgi?id=184703
2358         https://trac.webkit.org/changeset/230724
2359
2360 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2361
2362         Unreviewed rollout of r230632. Regression in memory usage.
2363
2364         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2365
2366         * DumpRenderTree/TestOptions.h:
2367         * DumpRenderTree/mac/DumpRenderTree.mm:
2368         (runTest):
2369         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference): Deleted.
2370         * WebKitTestRunner/TestController.cpp:
2371         (WTR::TestController::resetPreferencesToConsistentValues):
2372         * WebKitTestRunner/TestOptions.cpp:
2373         (WTR::TestOptions::TestOptions):
2374         (WTR::isLegacyAnimationEngineTestPath): Deleted.
2375         * WebKitTestRunner/TestOptions.h:
2376
2377 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2378
2379         [JSC] Rename runWebAssembly to runWebAssemblySuite
2380         https://bugs.webkit.org/show_bug.cgi?id=184703
2381
2382         Reviewed by JF Bastien.
2383
2384         * Scripts/run-jsc-stress-tests:
2385
2386 2018-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2387
2388         [WebAssembly][Modules] Implement function import from wasm modules
2389         https://bugs.webkit.org/show_bug.cgi?id=184689
2390
2391         Reviewed by JF Bastien.
2392
2393         Add runWebAssemblyDirect, which runs wasm file directly.
2394
2395         * Scripts/run-jsc-stress-tests:
2396
2397 2018-04-17  Saam Barati  <sbarati@apple.com>
2398
2399         Add system trace points for process launch and for initializeWebProcess
2400         https://bugs.webkit.org/show_bug.cgi?id=184669
2401
2402         Reviewed by Simon Fraser.
2403
2404         * Tracing/SystemTracePoints.plist:
2405
2406 2018-04-17  Ross Kirsling  <ross.kirsling@sony.com>
2407
2408         Add debug bots for WinCairo.
2409         https://bugs.webkit.org/show_bug.cgi?id=184663
2410
2411         Reviewed by Lucas Forschler.
2412
2413         * BuildSlaveSupport/build.webkit.org-config/config.json:
2414         Add a debug build bot and two debug test bots.
2415
2416         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2417         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2418         Add a WinCairo category to build.webkit.org.
2419
2420 2018-04-17  Zalan Bujtas  <zalan@apple.com>
2421
2422         [LayoutReloaded] Set inline-block box position.
2423         https://bugs.webkit.org/show_bug.cgi?id=184690
2424
2425         Reviewed by Antti Koivisto.
2426
2427         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2428         (InlineFormattingContext.prototype._handleInlineBlock):
2429         * LayoutReloaded/Utils.js:
2430         (Utils._dumpBox):
2431         * LayoutReloaded/test/inline-block-with-fixed-width-height.html:
2432
2433 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2434
2435         [GLIB] Add API to clear JSCContext uncaught exception
2436         https://bugs.webkit.org/show_bug.cgi?id=184685
2437
2438         Reviewed by Žan Doberšek.
2439
2440         Add test cases for the new API.
2441
2442         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2443         (testJSCExceptions):
2444
2445 2018-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2446
2447         [GLIB] Add API to query, delete and enumerate properties
2448         https://bugs.webkit.org/show_bug.cgi?id=184647
2449
2450         Reviewed by Michael Catanzaro.
2451
2452         Add test cases for the new API.
2453
2454         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2455         (testJSCObject):
2456         (testJSCClass):
2457         (testJSCPrototypes):
2458
2459 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2460
2461         [LayoutReloaded] Add support for replaced box.
2462         https://bugs.webkit.org/show_bug.cgi?id=184680
2463
2464         Reviewed by Antti Koivisto.
2465
2466         Basic support for inline replaced.
2467
2468         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2469         (InlineFormattingContext.prototype._handleInlineBox):
2470         (InlineFormattingContext.prototype._handleInlineBlock):
2471         (InlineFormattingContext.prototype._handleReplaced):
2472         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
2473         (Line.prototype.lastLineBox):
2474         (Line.prototype.addInlineBox):
2475         (Line.prototype.addInlineContainerBox): Deleted.
2476         * LayoutReloaded/TreeBuilder.js:
2477         (TreeBuilder.prototype._createAndAttachBox):
2478         * LayoutReloaded/Utils.js:
2479         (Utils._dumpBox):
2480         * LayoutReloaded/test/index.html:
2481         * LayoutReloaded/test/inline-simple-replaced.html: Added.
2482
2483 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2484
2485         [LayoutReloaded] Minor InlineFormattingContext::layout() cleanup.
2486         https://bugs.webkit.org/show_bug.cgi?id=184679
2487
2488         Reviewed by Antti Koivisto.
2489
2490         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2491         (InlineFormattingContext):
2492         (InlineFormattingContext.prototype.layout):
2493         (InlineFormattingContext.prototype._handleInlineContainer):
2494         (InlineFormattingContext.prototype._handleInlineContent):
2495         (InlineFormattingContext.prototype._handleInlineBlock):
2496         (InlineFormattingContext.prototype._handleReplacedBox):
2497         (InlineFormattingContext.prototype._clearNeedsLayoutAndMoveToNextSibling):
2498         (InlineFormattingContext.prototype._handleInlineBlockContainer): Deleted.
2499         (InlineFormattingContext.prototype._clearAndMoveToNext): Deleted.
2500
2501 2018-04-16  Zalan Bujtas  <zalan@apple.com>
2502
2503         [LayoutReloaded] Introduce fragmentation state/context.
2504         https://bugs.webkit.org/show_bug.cgi?id=184677
2505
2506         Reviewed by Antti Koivisto.
2507
2508         State/context for fragmented content (multicol, regions, pagination etc).
2509
2510         * LayoutReloaded/FormattingContext/FragmentationContext.js: Added.
2511         (FragmentationContext):
2512         * LayoutReloaded/FormattingState/FragmentationState.js: Added.
2513         (FragmentationState):
2514         (FragmentationState.prototype.formattingState):
2515
2516 2018-04-16  Andy Estes  <aestes@apple.com>
2517
2518         [iOS] Enable WKPDFView by default
2519         https://bugs.webkit.org/show_bug.cgi?id=184675
2520         <rdar://problem/27885452>
2521
2522         Reviewed by Darin Adler.
2523
2524         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
2525
2526 2018-04-16  Leo Balter  <leonardo.balter@gmail.com>
2527
2528         Perl-based Test262 runner
2529         https://bugs.webkit.org/show_bug.cgi?id=183343
2530
2531         Reviewed by Michael Saboff.
2532
2533         * Scripts/test262-helpers/README.md: Added.
2534         * Scripts/test262-helpers/agent.js: Added.
2535         (262.getGlobal):
2536         (262.setGlobal):
2537         (262.destroy):
2538         (262.IsHTMLDDA):
2539         * Scripts/test262-helpers/cpanfile: Added.
2540         * Scripts/test262-helpers/cpanfile.snapshot: Added.
2541         * Scripts/test262-helpers/test262-runner.pl: Added.
2542         (main):
2543         (processFile):
2544         (getScenarios):
2545         (addScenario):
2546         (compileTest):
2547         (runTest):
2548         (processResult):
2549         (getTempFile):
2550         (getContents):
2551         (parseData):
2552         (getHarness):
2553         * Scripts/test262-helpers/tests.log: Added.
2554
2555 2018-04-15  Andy Estes  <aestes@apple.com>
2556
2557         [iOS] Add API tests for PDF find-in-page
2558         https://bugs.webkit.org/show_bug.cgi?id=184634
2559
2560         Reviewed by Dan Bernstein.
2561
2562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2563         * TestWebKitAPI/Tests/WebKit/find.pdf: Added.
2564         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
2565         (-[TestFindDelegate findString]):
2566         (-[TestFindDelegate _webView:didCountMatches:forString:]):
2567         (-[TestFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
2568         (-[TestFindDelegate _webView:didFailToFindString:]):
2569         (loadWebView):
2570         (TEST):
2571
2572 2018-04-13  Zalan Bujtas  <zalan@apple.com>
2573
2574         [LayoutReloaded] Update class documentation
2575         https://bugs.webkit.org/show_bug.cgi?id=184625
2576
2577         Reviewed by Antti Koivisto.
2578
2579         * LayoutReloaded/DisplayTree/Box.js:
2580         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
2581         * LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js:
2582         * LayoutReloaded/FormattingContext/FloatingContext.js:
2583         * LayoutReloaded/FormattingContext/FormattingContext.js:
2584         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2585         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
2586         * LayoutReloaded/FormattingState/BlockFormattingState.js:
2587         * LayoutReloaded/FormattingState/FloatingState.js:
2588         * LayoutReloaded/FormattingState/FormattingState.js:
2589         * LayoutReloaded/FormattingState/InlineFormattingState.js:
2590         * LayoutReloaded/LayoutState.js:
2591         * LayoutReloaded/LayoutTree/BlockContainer.js:
2592         * LayoutReloaded/LayoutTree/Box.js:
2593         * LayoutReloaded/LayoutTree/Container.js:
2594         * LayoutReloaded/LayoutTree/InlineBox.js:
2595         * LayoutReloaded/LayoutTree/InlineContainer.js:
2596         * LayoutReloaded/LayoutTree/Text.js:
2597         * LayoutReloaded/misc/headers/BlockContainer.h: Removed.
2598         * LayoutReloaded/misc/headers/BlockFormattingContext.h: Removed.
2599         * LayoutReloaded/misc/headers/BlockMarginCollapse.h: Removed.
2600         * LayoutReloaded/misc/headers/Box.h: Removed.
2601         * LayoutReloaded/misc/headers/Container.h: Removed.
2602         * LayoutReloaded/misc/headers/FloatingContext.h: Removed.
2603         * LayoutReloaded/misc/headers/FormattingContext.h: Removed.
2604         * LayoutReloaded/misc/headers/InitialBlockContainer.h: Removed.
2605         * LayoutReloaded/misc/headers/InlineBox.h: Removed.
2606         * LayoutReloaded/misc/headers/LayoutContext.h: Removed.
2607         * LayoutReloaded/misc/headers/Line.h: Removed.
2608         * LayoutReloaded/misc/headers/Text.h: Removed.
2609
2610 2018-04-13  Zalan Bujtas  <zalan@apple.com>
2611
2612         [LayoutReloaded] Add simple implementation for FormattingState::markNeedsLayout()
2613         https://bugs.webkit.org/show_bug.cgi?id=184621
2614
2615         Reviewed by Antti Koivisto.
2616
2617         This is just a simple, mark ancestors dirty implementation.
2618
2619         * LayoutReloaded/FormattingState/FormattingState.js:
2620         (FormattingState.prototype.markNeedsLayout):
2621         * LayoutReloaded/LayoutState.js:
2622         (LayoutState.prototype.markNeedsLayout):
2623         (LayoutState.prototype.setNeedsLayoutById): Deleted.
2624         (LayoutState.prototype.setNeedsLayout): Deleted.
2625         * LayoutReloaded/TreeBuilder.js:
2626         (TreeBuilder.prototype._createAndAttachBox):
2627         (TreeBuilder.prototype._findBox): Deleted.
2628         * LayoutReloaded/Utils.js:
2629         (Utils.layoutBoxById):
2630         * LayoutReloaded/test/index.html:
2631         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html:
2632
2633 2018-04-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2634
2635         [WPE] [webkitpy] The driver requirements should be checked before starting the tests
2636         https://bugs.webkit.org/show_bug.cgi?id=184595
2637
2638         Reviewed by Michael Catanzaro.
2639
2640         Ensure Driver.check_driver() is checked at check_sys_deps() time.
2641
2642         * Scripts/webkitpy/port/wpe.py:
2643         (WPEPort.check_sys_deps):
2644
2645 2018-04-13  Zalan Bujtas  <zalan@apple.com>
2646
2647         Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).
2648
2649         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
2650
2651 2018-04-13  Jonathan Bedard  <jbedard@apple.com>
2652
2653         Boot fewer simulators in CI/EWS machines
2654         https://bugs.webkit.org/show_bug.cgi?id=184594
2655         <rdar://problem/39188082>
2656
2657         Reviewed by Alexey Proskuryakov.
2658
2659         This is a temporary workaround fro <rdar://problem/39393590>.
2660
2661         * Scripts/webkitpy/xcode/simulated_device.py:
2662         (SimulatedDeviceManager): Treat simulators as taking 6 gigs instead of 2.
2663
2664 2018-04-13  Brady Eidson  <beidson@apple.com>
2665
2666         Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one.
2667         https://bugs.webkit.org/show_bug.cgi?id=184559
2668
2669         Reviewed by Alex Christensen.
2670
2671         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2672
2673 2018-04-13  Chris Dumez  <cdumez@apple.com>
2674
2675         input.webkitEntries does not work as expected when folder contains accented chars
2676         https://bugs.webkit.org/show_bug.cgi?id=184517
2677         <rdar://problem/39265537>
2678
2679         Reviewed by Alex Christensen.
2680
2681         Add API test coverage.
2682
2683         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2684         (TestWebKitAPI::TEST_F):
2685
2686 2018-04-13  Thibault Saunier  <tsaunier@igalia.com>
2687
2688         Update my emails ordering in contributors.json
2689         https://bugs.webkit.org/show_bug.cgi?id=184587
2690
2691         Rubber-stamped by Philippe Normand.
2692
2693         Bugzilla seems to pick up tsaunier@igalia.com which is not the one I use there.
2694
2695         * Scripts/webkitpy/common/config/contributors.json:
2696
2697 2018-04-13  Michael Catanzaro  <mcatanzaro@igalia.com>
2698
2699         [WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb
2700         https://bugs.webkit.org/show_bug.cgi?id=184388
2701
2702         Reviewed by Carlos Alberto Lopez Perez.
2703
2704         Remove libxkbcommon from the JHBuild environment. We could alternatively add
2705         xkeyboard-config, but there doesn't seem to be any need to build libxkbcommon because I do
2706         not believe it depends on anything else in the JHBuild environment.
2707
2708         * wpe/install-dependencies:
2709         * wpe/jhbuild.modules:
2710
2711 2018-04-12  Antoine Quint  <graouts@apple.com>
2712
2713         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2714         https://bugs.webkit.org/show_bug.cgi?id=184569
2715         <rdar://problem/38671301>
2716
2717         Reviewed by Jon Lee.
2718
2719         We set the default value for the CSS Animations and CSS Transitions as Web Animations flag to true
2720         but override it to be false always in the LayoutTests/legacy-animation-engine directory.
2721
2722         * DumpRenderTree/TestOptions.h:
2723         * DumpRenderTree/mac/DumpRenderTree.mm:
2724         (shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference):
2725         (runTest):
2726         * WebKitTestRunner/TestController.cpp:
2727         (WTR::TestController::resetPreferencesToConsistentValues):
2728         * WebKitTestRunner/TestOptions.cpp:
2729         (WTR::isLegacyAnimationEngineTestPath):
2730         (WTR::TestOptions::TestOptions):
2731         * WebKitTestRunner/TestOptions.h:
2732
2733 2018-04-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2734
2735         [GLIB] Tests WTF_RefPtr.ReleaseInNonMainThread and WTF_RefPtr.ReleaseInNonMainThreadDestroyInMainThread are crashing since they were added
2736         https://bugs.webkit.org/show_bug.cgi?id=184531
2737
2738         Reviewed by Michael Catanzaro.
2739
2740         It's not a bug in WebKit, but in the tests. The problem is that those tests are using RunLoop::main() but main
2741         run loop hasn't been initialized. ReleaseInNonMainThread doesn't really need to initialize the main run loop if
2742         we change Util::run() to always use RunLop::current() instead of RunLoop::main(). But
2743         ReleaseInNonMainThreadDestroyInMainThread ends up scheduling a task to the main thread, and the generic
2744         implementation fo that uses RunLoop::main(), so we need to initialize the main loop in this case.
2745
2746         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2747         (TestWebKitAPI::TEST): Call RunLoop::initializeMainRunLoop().
2748         * TestWebKitAPI/glib/UtilitiesGLib.cpp:
2749         (TestWebKitAPI::Util::run): Use RunLop::current() to stop the current run loop.
2750         (TestWebKitAPI::Util::sleep): Ditto.
2751
2752 2018-04-12  Zalan Bujtas  <zalan@apple.com>
2753
2754         [LayoutReloaded] Add support for incremental layout
2755         https://bugs.webkit.org/show_bug.cgi?id=184578
2756
2757         Reviewed by Antti Koivisto.
2758
2759         * LayoutReloaded/Layout.js:
2760         (layout):
2761         * LayoutReloaded/LayoutState.js:
2762         (LayoutState.prototype.rootContainer):
2763         (LayoutState.prototype.setNeedsLayoutById):
2764         * LayoutReloaded/Utils.js:
2765         (Utils.layoutTreeDump):
2766         * LayoutReloaded/test/TestHarness.js:
2767         (verifyLayout):
2768         (runLayout):
2769         (verifyLayoutTreeDump): Deleted.
2770         * LayoutReloaded/test/index.html:
2771         * LayoutReloaded/test/simple-incremental-layout-with-static-content.html: Added.
2772
2773 2018-04-12  Zalan Bujtas  <zalan@apple.com>
2774
2775         [LayoutReloaded] Move root container ownership to layout state
2776         https://bugs.webkit.org/show_bug.cgi?id=184575
2777
2778         Reviewed by Antti Koivisto.
2779
2780         Now the root container is on the associated layout state (ICB only at this point though).
2781
2782         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
2783         (BlockFormattingContext.prototype.layout):
2784         * LayoutReloaded/FormattingContext/FormattingContext.js:
2785         (FormattingContext.prototype._layoutOutOfFlowDescendants):
2786         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2787         (InlineFormattingContext.prototype._handleInlineBlockContainer):
2788         (InlineFormattingContext.prototype._handleFloatingBox):
2789         * LayoutReloaded/Layout.js:
2790         (layout):
2791         * LayoutReloaded/LayoutState.js:
2792         (LayoutState):
2793         (LayoutState.prototype.formattingContext):
2794         (LayoutState.prototype.establishedFormattingState):
2795         (LayoutState.prototype.formattingStateForBox):
2796         (LayoutState.prototype.needsLayout):
2797         (LayoutState.prototype.displayBox):
2798         (LayoutState.prototype._formattingContext):
2799         (LayoutState.prototype.layout): Deleted.
2800         (LayoutState.prototype.formattingStates): Deleted.
2801         (LayoutState.prototype.initialDisplayBox): Deleted.
2802         * LayoutReloaded/Utils.js:
2803         (Utils._dumpBox):
2804         (Utils._findDisplayBox): Deleted.
2805
2806 2018-04-12  Jonathan Bedard  <jbedard@apple.com>
2807
2808         Fix --build-directory flag for run-webkit-tests
2809         https://bugs.webkit.org/show_bug.cgi?id=184545
2810         <rdar://problem/39385080>
2811
2812         Rubber-stamped by Aakash Jain.
2813
2814         The --build-directory path does not work with iOS-Simulator.
2815
2816         * Scripts/webkitpy/port/base.py:
2817         (Port._build_path): Use the port configuration to calculate the root directory.
2818         * Scripts/webkitpy/port/base_unittest.py:
2819         (PortTest.test_build_path): Test build directories for embedded configurations.
2820
2821 2018-04-12  Ross Kirsling  <ross.kirsling@sony.com>
2822
2823         pemfile.py should not assume POSIX line endings
2824         https://bugs.webkit.org/show_bug.cgi?id=184507
2825
2826         Reviewed by Daniel Bates.
2827
2828         * Scripts/webkitpy/common/system/pemfile.py:
2829         (_parse_pem_format):
2830         * Scripts/webkitpy/common/system/pemfile_unittest.py:
2831         (PemFileTest.test_parse_crlf):
2832         (PemFileTest.test_parse_cr):
2833
2834 2018-04-12  Zalan Bujtas  <zalan@apple.com>
2835
2836         [LayoutReloaded] Minor cleanup in LayoutSate
2837         https://bugs.webkit.org/show_bug.cgi?id=184546
2838
2839         Reviewed by Antti Koivisto.
2840
2841         * LayoutReloaded/FormattingContext/FormattingContext.js:
2842         (FormattingContext.isInFormattingContext):
2843         * LayoutReloaded/FormattingState/FormattingState.js:
2844         (FormattingState.prototype.displayBoxes):
2845         (FormattingState.prototype.displayBox):
2846         (FormattingState.prototype._markSubTreeNeedsLayout):
2847         (FormattingState):
2848         (FormattingState.prototype.displayBoxMap): Deleted.
2849         * LayoutReloaded/LayoutState.js:
2850         (LayoutState.prototype.formattingStateForBox):
2851         (LayoutState.prototype.needsLayout):
2852         (LayoutState.prototype.displayBox):
2853         (LayoutState.prototype._createFormattingState):
2854         (LayoutState):
2855         * LayoutReloaded/LayoutTree/Box.js:
2856         (Layout.Box.prototype.isFormattingContextDescendant): Deleted.
2857         * LayoutReloaded/LayoutTree/Container.js:
2858         (Layout.Container.prototype.isContainingBlockDescendant): Deleted.
2859         * LayoutReloaded/Utils.js:
2860         (Utils._findDisplayBox):
2861
2862 2018-04-12  Zalan Bujtas  <zalan@apple.com>
2863
2864         [LayoutReloaded] Introduce needsLayout to InlineFormattingContext
2865         https://bugs.webkit.org/show_bug.cgi?id=184538
2866
2867         Reviewed by Antti Koivisto.
2868
2869         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
2870         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
2871         (BlockFormattingContext):
2872         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout): Deleted.
2873         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout): Deleted.
2874         * LayoutReloaded/FormattingContext/FormattingContext.js:
2875         (FormattingContext.prototype._firstInFlowChildWithNeedsLayout):
2876         (FormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
2877         (FormattingContext):
2878         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
2879         (InlineFormattingContext.prototype.layout):
2880         (InlineFormattingContext.prototype._handleInlineContainer):
2881         (InlineFormattingContext.prototype._handleInlineBlockContainer):
2882         (InlineFormattingContext.prototype._handleInlineContent):
2883         (InlineFormattingContext.prototype._clearAndMoveToNext):
2884         (InlineFormattingContext):
2885
2886 2018-04-12  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2887
2888         [GStreamer] Speed up GStreamer dependency build by removing examples compilation
2889         https://bugs.webkit.org/show_bug.cgi?id=184528
2890
2891         Reviewed by Philippe Normand.
2892
2893         * gstreamer/jhbuild.modules: Added --disable-examples for GStreamer package.
2894
2895 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
2896
2897         [WPE] Switch testing process to using WPEBackend-fdo
2898         https://bugs.webkit.org/show_bug.cgi?id=184357
2899
2900         Reviewed by Carlos Alberto Lopez Perez.
2901
2902         Switch WPE testing to using the WPEBackend-fdo implementation that
2903         depends on the WL_bind_wayland_display EGL extension, as defined under
2904         the freedesktop.org project.
2905         https://cgit.freedesktop.org/mesa/mesa/tree/docs/specs/WL_bind_wayland_display.spec
2906
2907         HeadlessViewBackend is refactored to use the WPEBackend-fdo API, but
2908         otherwise is not changed in functionality.
2909
2910         Unit tests now have to unconditionally use HeadlessViewBackend as a
2911         wpe_view_backend provider, since WPEBackend-fdo does not provide a
2912         default wpe_view_backend implementation. Unit tests covering that are
2913         adjusted to instead use a mock wpe_view_backend interface.
2914
2915         * Scripts/webkitdirs.pm:
2916         (builtDylibPathForName): Fix the libWPEWebKit.so name to also include
2917         the API version that was added in r230449.
2918         * Scripts/webkitpy/port/waylanddriver.py:
2919         (WaylandDriver._setup_environ_for_test): Export EGL_PLATFORM=wayland.
2920         * Scripts/webkitpy/port/wpe.py:
2921         (WPEPort._driver_class): Use WaylandDriver by default.
2922         * TestWebKitAPI/PlatformWebView.h:
2923         (): Deleted.
2924         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2925         (testWebViewWebBackend):
2926         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2927         (Test::createWebViewBackend):
2928         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
2929         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2930         (TestWebKitAPI::PlatformWebView::initialize):
2931         * wpe/HeadlessViewBackend/CMakeLists.txt:
2932         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
2933         (getEGLDisplay):
2934         (HeadlessViewBackend::HeadlessViewBackend):
2935         (HeadlessViewBackend::~HeadlessViewBackend):
2936         (HeadlessViewBackend::backend const):
2937         (HeadlessViewBackend::createSnapshot):
2938         (HeadlessViewBackend::performUpdate):
2939         (HeadlessViewBackend::makeCurrent): Deleted.
2940         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
2941         * wpe/jhbuild.modules: Module name cleanup. Dyz version is bumped.
2942
2943 2018-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2944
2945         [GTK] Switch to use always complex text code path
2946         https://bugs.webkit.org/show_bug.cgi?id=183285
2947
2948         Reviewed by Michael Catanzaro.
2949
2950         Keep the auto mode for the layout tests to avoid having to rebaseline a lot of tests.
2951
2952         * WebKitTestRunner/gtk/main.cpp:
2953         (main): Set WEBKIT_FORCE_COMPLEX_TEXT to 0 unless it's already present in the environment.
2954
2955 2018-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2956
2957         [GLIB] Handle strings containing null characters
2958         https://bugs.webkit.org/show_bug.cgi?id=184450
2959
2960         Reviewed by Michael Catanzaro.
2961
2962         Add test case for strings with null characters and update all calls to evaluate to pass the script length.
2963
2964         * TestWebKitAPI/PlatformGTK.cmake:
2965         * TestWebKitAPI/PlatformWPE.cmake:
2966         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2967         (testJSCBasic):
2968         (testJSCFunction):
2969         (testJSCObject):
2970         (testJSCClass):
2971         (testJSCPrototypes):
2972         (testJSCExceptions):
2973         (testJSCPromises):
2974         (testJSCGarbageCollector):
2975         (testJSCWeakValue):
2976         (testsJSCVirtualMachine):
2977         (testsJSCAutocleanups):
2978         * TestWebKitAPI/Tests/JavaScriptCore/glib/script.js: Added.
2979         * TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp:
2980         (DOMElementTest::testAutoFill):
2981         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2982         (WebKitWebEditorTest::testSelectionChanged):
2983         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2984         (WebKitFrameTest::testJavaScriptValues):
2985         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2986         (consoleMessageSentCallback):
2987         (methodCallCallback):
2988
2989 2018-04-11  Zan Dobersek  <zdobersek@igalia.com>
2990
2991         [WPE] Make WebKitWebViewBackend object mandatory for webkit_web_view_new*() constructors
2992         https://bugs.webkit.org/show_bug.cgi?id=184513
2993
2994         Reviewed by Michael Catanzaro.
2995
2996         Update the WPE-specific testWebViewWebBackend() test case, removing the
2997         test that passes a null WebKitWebViewBackend object to the
2998         webkit_web_view_new() call.
2999
3000         Helper createWebViewBackend() that's called via Test::createWebView()
3001         variations is updated to, in case of not using the headless backend,
3002         return a WebKitWebViewBackend instance that wraps around a
3003         default wpe_view_backend object.
3004
3005         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3006         (testWebViewWebBackend):
3007         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3008         (Test::createWebViewBackend):
3009
3010 2018-04-11  Zalan Bujtas  <zalan@apple.com>
3011
3012         [LayoutReloaded] Introduce needsLayout flag
3013         https://bugs.webkit.org/show_bug.cgi?id=184527
3014
3015         Reviewed by Antti Koivisto.
3016
3017         Use the formatting state to mark boxes dirty.
3018
3019         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3020         (BlockFormattingContext.prototype.layout):
3021         (BlockFormattingContext.prototype._firstInFlowChildWithNeedsLayout):
3022         (BlockFormattingContext.prototype._nextInFlowSiblingWithNeedsLayout):
3023         (BlockFormattingContext):
3024         * LayoutReloaded/FormattingContext/FormattingContext.js:
3025         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3026         * LayoutReloaded/FormattingState/FormattingState.js:
3027         (FormattingState):
3028         (FormattingState.prototype.markNeedsLayout):
3029         (FormattingState.prototype.clearNeedsLayout):
3030         (FormattingState.prototype.needsLayout):
3031         (FormattingState.prototype.layoutNeeded):
3032         (FormattingState.prototype._markSubTreeNeedsLayout):
3033         * LayoutReloaded/LayoutState.js:
3034         (LayoutState.prototype.formattingStateForBox):
3035         (LayoutState.prototype.setNeedsLayout):
3036         (LayoutState.prototype.needsLayout):
3037         * LayoutReloaded/LayoutTree/Box.js:
3038         (Layout.Box.prototype.isFormattingContextDescendant):
3039         * LayoutReloaded/LayoutTree/Container.js:
3040         (Layout.Container.prototype.isContainingBlockDescendant):
3041
3042 2018-04-11  Jonathan Bedard  <jbedard@apple.com>
3043
3044         Fix TestInvocation class for newer versions of clang.
3045         https://bugs.webkit.org/show_bug.cgi?id=184508
3046         <rdar://problem/39328648>
3047
3048         Reviewed by Alexey Proskuryakov.
3049
3050         Declare TestInvocation to be final so it does not require a virtual destructor.
3051
3052         * WebKitTestRunner/TestInvocation.h:
3053
3054 2018-04-10  Alex Christensen  <achristensen@webkit.org>
3055
3056         IDN spoofing with Hebrew combining characters
3057         https://bugs.webkit.org/show_bug.cgi?id=184472
3058         <rdar://problem/39148687>
3059
3060         Reviewed by Brent Fulgham.
3061
3062         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3063         (TestWebKitAPI::TEST):
3064
3065 2018-04-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3066
3067         [Extra zoom mode] Missing label when focusing a <select> with a title attribute but no associated <label>
3068         https://bugs.webkit.org/show_bug.cgi?id=184352
3069         <rdar://problem/39237683>
3070
3071         Reviewed by Andy Estes.
3072
3073         Add support for UIScriptController::selectFormPopoverTitle, which returns the title of the current select
3074         popover's UITableViewController (for testing purposes).
3075
3076         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3077         (WTR::UIScriptController::selectFormPopoverTitle const):
3078         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3079         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3080         (WTR::UIScriptController::selectFormPopoverTitle const):
3081         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3082         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3083         (WTR::UIScriptController::selectFormPopoverTitle const):
3084
3085 2018-04-10  Nan Wang  <n_wang@apple.com>
3086
3087         AX: Expose strong password fields on iOS
3088         https://bugs.webkit.org/show_bug.cgi?id=184465
3089         <rdar://problem/39325104>
3090
3091         Reviewed by Chris Fleizach.
3092
3093         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3094         (AccessibilityUIElement::boolAttributeValue):
3095         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3096         (WTR::AccessibilityUIElement::boolAttributeValue):
3097
3098 2018-04-10  Zalan Bujtas  <zalan@apple.com>
3099
3100         [LayoutReloaded] Add support for out-of-flow descendants in inline formatting context.
3101         https://bugs.webkit.org/show_bug.cgi?id=184454
3102
3103         Reviewed by Antti Koivisto.
3104
3105         When the containing block of an out-of-flow positioned element establishes an inline formatting context.
3106         This is mostly about moving out-of-flow logic from BlockFormattingContext to the base class.
3107
3108         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3109         (BlockFormattingContext.prototype._adjustBottomWithFIXME):
3110         (BlockFormattingContext):
3111         (BlockFormattingContext.prototype._layoutOutOfFlowDescendants): Deleted.
3112         (BlockFormattingContext.prototype._computeOutOfFlowWidth): Deleted.
3113         (BlockFormattingContext.prototype._computeInFlowWidth): Deleted.
3114         (BlockFormattingContext.prototype._computeOutOfFlowHeight): Deleted.
3115         (BlockFormattingContext.prototype._computeOutOfFlowPosition): Deleted.
3116         (BlockFormattingContext.prototype._shrinkToFitWidth): Deleted.
3117         * LayoutReloaded/FormattingContext/FormattingContext.js:
3118         (FormattingContext.prototype._placeInFlowPositionedChildren):
3119         (FormattingContext.prototype._computeInFlowWidth):
3120         (FormattingContext.prototype._layoutOutOfFlowDescendants):
3121         (FormattingContext.prototype._computeOutOfFlowWidth):
3122         (FormattingContext.prototype._computeOutOfFlowHeight):
3123         (FormattingContext.prototype._computeOutOfFlowPosition):
3124         (FormattingContext.prototype._shrinkToFitWidth):
3125         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3126         (InlineFormattingContext.prototype.layout):
3127         (InlineFormattingContext.prototype._handleInlineContainer):
3128         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3129         (InlineFormattingContext.prototype._placeOutOfFlowDescendants): Deleted.
3130         * LayoutReloaded/test/index.html:
3131         * LayoutReloaded/test/inline-with-out-of-flow-descendant.html: Added.
3132
3133 2018-04-09  Zan Dobersek  <zdobersek@igalia.com>
3134
3135         WKTR: Enable DOM cache, SW registration directory cleanup on non-Cocoa platforms
3136         https://bugs.webkit.org/show_bug.cgi?id=184414
3137
3138         Reviewed by Michael Catanzaro.
3139
3140         Enable clearServiceWorkerRegistrations(), clearDOMCache() and
3141         clearDOMCaches() implementations in WebKitTestRunner's TestController
3142         class for non-Cocoa platforms. Implementations depend on the generic
3143         WK2 C API that other ports can leverage as well.
3144
3145         The clearDOMCache() and clearDOMCaches() calls are now operational for
3146         tests that invoke them. clearServiceWorkerRegistrations() and
3147         clearDOMCaches() are also called between each test, cleaning up relevant
3148         resources.
3149
3150         The TestController::getAllStorageAccessEntries() stub for non-Cocoa
3151         platforms is moved into the main !PLATFORM(COCOA) block.
3152
3153         * WebKitTestRunner/TestController.cpp:
3154         (WTR::TestController::getAllStorageAccessEntries):
3155         (WTR::clearServiceWorkerRegistrationsCallback):
3156         (WTR::TestController::clearServiceWorkerRegistrations):
3157         (WTR::clearDOMCacheCallback):
3158         (WTR::TestController::clearDOMCache):
3159         (WTR::TestController::clearDOMCaches):
3160
3161 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3162
3163         [LayoutReloaded] Add support for relatively positioned containers in inline formatting context.
3164         https://bugs.webkit.org/show_bug.cgi?id=184439
3165
3166         Reviewed by Antti Koivisto.
3167
3168         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3169         (BlockFormattingContext.prototype._placeInFlowPositionedChildren): Deleted.
3170         (BlockFormattingContext.prototype._computeInFlowPositionedPosition): Deleted.
3171         * LayoutReloaded/FormattingContext/FormattingContext.js:
3172         (FormattingContext.prototype._computeInFlowPositionedPosition):
3173         (FormattingContext.prototype._placeInFlowPositionedChildren):
3174         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3175         (InlineFormattingContext.prototype._placeInFlowPositionedChildren): Deleted.
3176         * LayoutReloaded/Utils.js:
3177         (Utils._dumpBox):
3178         (Utils._dumpLines.):
3179         (Utils._dumpLines):
3180         (Utils.precisionRoundWithDecimals):
3181         (Utils.precisionRound):
3182         (Utils):
3183         * LayoutReloaded/test/index.html:
3184         * LayoutReloaded/test/inline-with-relative-positioning.html: Added.
3185
3186 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3187
3188         [LayoutReloaded] Remove Layout.InitialContainingBlock class
3189         https://bugs.webkit.org/show_bug.cgi?id=184436
3190
3191         Reviewed by Antti Koivisto.
3192
3193         * LayoutReloaded/LayoutTree/Box.js:
3194         (Layout.Box.prototype.establishesBlockFormattingContext):
3195         * LayoutReloaded/LayoutTree/InitialBlockContainer.js: Removed.
3196         * LayoutReloaded/TreeBuilder.js:
3197         (TreeBuilder.prototype.createTree):
3198         * LayoutReloaded/test/index.html:
3199
3200 2018-04-09  Zalan Bujtas  <zalan@apple.com>
3201
3202         [LayoutReloaded] Add support for inline-block.
3203         https://bugs.webkit.org/show_bug.cgi?id=184434
3204
3205         Reviewed by Antti Koivisto.
3206
3207         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3208         (InlineFormattingContext):
3209         (InlineFormattingContext.prototype.layout):
3210         (InlineFormattingContext.prototype._handleInlineContainer):
3211         (InlineFormattingContext.prototype._handleInlineBlockContainer):
3212         (InlineFormattingContext.prototype._handleInlineContent):
3213         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3214         (Line.prototype.addInlineContainerBox):
3215         (Line.prototype.addTextLineBox):
3216         (Line):
3217         * LayoutReloaded/LayoutTree/Box.js:
3218         (Layout.Box.prototype.isInlineBlockBox):
3219         * LayoutReloaded/Utils.js:
3220         (LayoutRect.prototype.growHorizontally):
3221         (Utils.isBlockContainerElement):
3222         (Utils.isInlineBlockElement):
3223         (Utils._dumpLines.):
3224         (Utils._dumpLines):
3225         * LayoutReloaded/test/index.html:
3226         * LayoutReloaded/test/inline-block-with-fixed-width-height.html: Added.
3227
3228 2018-04-09  Timothy Hatcher  <timothy@apple.com>
3229
3230         Add support for setting a background color on WKWebView and WKView
3231         https://bugs.webkit.org/show_bug.cgi?id=184426
3232
3233         Reviewed by Wenson Hsieh.
3234
3235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3236         * TestWebKitAPI/Tests/mac/BackgroundColor.mm: Added.
3237
3238 2018-04-09  Charlie Turner  <cturner@igalia.com>
3239
3240         [WPE] Add some missing install dependencies
3241         https://bugs.webkit.org/show_bug.cgi?id=184383
3242
3243         Reviewed by Michael Catanzaro.
3244
3245         * wpe/install-dependencies:
3246
3247 2018-04-09  Sihui Liu  <sihui_liu@apple.com>
3248
3249         REGRESSION(r229929): localStorage is broken for WebInspector
3250         https://bugs.webkit.org/show_bug.cgi?id=184382
3251         <rdar://problem/39257355>
3252
3253         Reviewed by Chris Dumez.
3254
3255         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3256         (TEST):
3257         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-empty-string-value.html:
3258
3259 2018-04-09  Zan Dobersek  <zdobersek@igalia.com>
3260
3261         Unreviewed follow-up to r230389.
3262
3263         * WebKitTestRunner/TestController.cpp:
3264         (WTR::TestController::platformAdjustContext): Use the 'ServiceWorkers'
3265         subdirectory for the temporary testing-purpose SW registration directory
3266         like it's used in Cocoa's TestController, addressing the review comment
3267         that I forgot about.
3268
3269 2018-04-08  Zan Dobersek  <zdobersek@igalia.com>
3270
3271         Non-Cocoa ports use default directory for ServiceWorker data during testing
3272         https://bugs.webkit.org/show_bug.cgi?id=183784
3273
3274         Reviewed by Youenn Fablet.
3275
3276         * WebKitTestRunner/TestController.cpp:
3277         (WTR::TestController::platformAdjustContext): Set the service worker registration
3278         directory through the new WKWebsiteDataStore API for non-Cocoa ports.
3279
3280 2018-04-08  Zalan Bujtas  <zalan@apple.com>
3281
3282         [LayoutReloaded] Adjust line with inline container's margin border and padding
3283         https://bugs.webkit.org/show_bug.cgi?id=184409
3284
3285         Reviewed by Antti Koivisto.
3286
3287         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3288         (InlineFormattingContext.prototype.layout):
3289         (InlineFormattingContext.prototype._handleFloatingBox):
3290         (InlineFormattingContext.prototype._adjustLineForInlineContainerStart):
3291         (InlineFormattingContext.prototype._adjustLineForInlineContainerEnd):
3292         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3293         (Line.prototype.shrink):
3294         (Line.prototype.adjustWithOffset):
3295         (Line.prototype.moveContentHorizontally):
3296         (Line.prototype.addTextLineBox):
3297         (Line):
3298         (Line.prototype.addFloatingBox): Deleted.
3299         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3300         * LayoutReloaded/test/index.html:
3301         * LayoutReloaded/test/inline-with-padding-border-margin-offsets.html: Added.
3302
3303 2018-04-07  Zalan Bujtas  <zalan@apple.com>
3304
3305         [LayoutReloaded] Add support for InlineContainer
3306         https://bugs.webkit.org/show_bug.cgi?id=184394
3307
3308         Reviewed by Antti Koivisto.
3309
3310         * LayoutReloaded/FormattingContext/FormattingContext.js:
3311         (FormattingContext.prototype._addToLayoutQueue):
3312         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3313         (InlineFormattingContext.prototype.layout):
3314         (InlineFormattingContext.prototype._handleInlineContent):
3315         (InlineFormattingContext.prototype._handleFloatingBox):
3316         (InlineFormattingContext.prototype._adjustLineForInlineContainerStart):
3317         (InlineFormattingContext.prototype._adjustLineForInlineContainerEnd):
3318         (InlineFormattingContext.prototype._placeInFlowPositionedChildren):
3319         (InlineFormattingContext.prototype._placeOutOfFlowDescendants):
3320         (InlineFormattingContext.prototype._createNewLine):
3321         (InlineFormattingContext.prototype._handleContent): Deleted.
3322         * LayoutReloaded/LayoutState.js:
3323         (LayoutState.prototype._createFormattingState):
3324         * LayoutReloaded/LayoutTree/Box.js:
3325         (Layout.Box.prototype.isContainer):
3326         (Layout.Box.prototype.isInlineContainer):
3327         (Layout.Box.prototype.isInlineBox):
3328         * LayoutReloaded/LayoutTree/Container.js:
3329         (Layout.Container.prototype.isContainer): Deleted.
3330         * LayoutReloaded/LayoutTree/InlineContainer.js: Added.
3331         (Layout.InlineContainer):
3332         * LayoutReloaded/TreeBuilder.js:
3333         (TreeBuilder.prototype._createAndAttachBox):
3334         * LayoutReloaded/Utils.js:
3335         (Utils._dumpBox):
3336         (Utils.precisionRound):
3337         (Utils):
3338         * LayoutReloaded/test/index.html:
3339         * LayoutReloaded/test/inline-content-simple2.html: Added.
3340         * LayoutReloaded/test/inline-floating1.html: Added.
3341         * LayoutReloaded/test/inline-formatting-context-floats1.html: Added.
3342         * LayoutReloaded/test/inline-formatting-context-floats2.html: Added.
3343
3344 2018-04-07  Timothy Hatcher  <timothy@apple.com>
3345
3346         Use the system's link color when system appearance is desired for a WebView.
3347
3348         https://bugs.webkit.org/show_bug.cgi?id=184353
3349         rdar://problem/9420053
3350
3351         Reviewed by Wenson Hsieh.
3352
3353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3354         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm: Added.
3355         (TestWebKitAPI::WebKit::LinkColor):
3356         (TestWebKitAPI::WebKit::LinkColorWithSystemAppearance):
3357
3358 2018-04-06  Zalan Bujtas  <zalan@apple.com>
3359
3360         Rebaseline LayoutReloaded patch file.
3361
3362         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3363
3364 2018-04-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3365
3366         [Win][WebCore] Expose a constant for scrollbar pixels per line (cScrollbarPixelsPerLine)
3367         https://bugs.webkit.org/show_bug.cgi?id=184296
3368
3369         Reviewed by Alex Christensen.
3370
3371         * DumpRenderTree/win/EventSender.cpp:
3372         (mouseScrollBy): Removed the duplicated cScrollbarPixelsPerLine
3373         definition. Use WebCore::cScrollbarPixelsPerLine.
3374
3375 2018-04-06  Zalan Bujtas  <zalan@apple.com>
3376
3377         Rebaseline LayoutReloaded patch file.
3378
3379         * LayoutReloaded/misc/LayoutReloadedWebKit.patch:
3380
3381 2018-04-05  Youenn Fablet  <youenn@apple.com>
3382
3383         Test expectation updater should handle Win bot results
3384         https://bugs.webkit.org/show_bug.cgi?id=184274
3385
3386         Reviewed by Ryosuke Niwa.
3387
3388         Add processing of win bot results.
3389         They will update platform/win results.
3390
3391         Updated the script so that if there is no mac-wk2 results, it will still process specific results.
3392
3393         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py:
3394         (TestExpectationUpdater.__init__):
3395         (TestExpectationUpdater._bot_type):
3396         (TestExpectationUpdater.do_update):
3397         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py:
3398         (MockAttachment):
3399         (MockAttachment.__init__):
3400         (MockAttachment.contents):
3401         (MockBugzilla):
3402         (MockBugzilla.__init__):
3403         (MockBugzilla.fetch_bug):
3404         (MockBugzilla.attachments):
3405         (MockZip):
3406         (MockZip.__init__):
3407         (MockZip.unzip):
3408         (MockZip.read):
3409         (TestExpectationUpdaterTest.test_update_test_expectations):
3410         (TestExpectationUpdaterTest):
3411         (TestExpectationUpdaterTest.test_update_win_future_test_expectations):
3412
3413 2018-04-05  Zalan Bujtas  <zalan@apple.com>
3414
3415         [LayoutReloaded] Fix static position for floating boxes when they don't fit the current line
3416         https://bugs.webkit.org/show_bug.cgi?id=184354
3417
3418         Reviewed by Antti Koivisto.
3419
3420         Do not shrink the current line with the floating box unless it is on the current line.
3421
3422         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3423         (InlineFormattingContext.prototype._handleFloatingBox):
3424         (InlineFormattingContext.prototype._mapFloatingVerticalPosition):
3425         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3426         (Line.prototype.addFloatingBox):
3427         (Line):
3428         * LayoutReloaded/test/index.html:
3429         * LayoutReloaded/test/inline-with-right-floats3.html: Added.
3430
3431 2018-04-05  Zalan Bujtas  <zalan@apple.com>
3432
3433         [LayoutReloaded] Add support for right floating boxes in inline formatting context
3434         https://bugs.webkit.org/show_bug.cgi?id=184351
3435
3436         Reviewed by Antti Koivisto.
3437
3438         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3439         (InlineFormattingContext.prototype._handleFloatingBox):
3440         (InlineFormattingContext.prototype._mapFloatingVerticalPosition):
3441         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3442         (Line.prototype.addFloatingBox):
3443         (Line):
3444         * LayoutReloaded/test/index.html:
3445         * LayoutReloaded/test/inline-with-right-float-simple.html: Added.
3446         * LayoutReloaded/test/inline-with-right-floats2.html: Added.
3447
3448 2018-04-05  Zalan Bujtas  <zalan@apple.com>
3449
3450         [LayoutReloaded] Move floating box to the next line when needed
3451         https://bugs.webkit.org/show_bug.cgi?id=184349
3452
3453         Reviewed by Antti Koivisto.
3454
3455         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3456         (InlineFormattingContext.prototype.layout):
3457         (InlineFormattingContext.prototype._handleContent):
3458         (InlineFormattingContext.prototype._handleText):
3459         (InlineFormattingContext.prototype._handleFloatingBox):
3460         (InlineFormattingContext.prototype._mapFloatingHorizontalPosition):
3461         (InlineFormattingContext):
3462         (InlineFormattingContext.prototype._handleFloatingBoxes): Deleted.
3463         (InlineFormattingContext.prototype._floatingBoxes): Deleted.
3464         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3465         (Line.prototype.addTextLineBox):
3466         (Line.prototype.addFloatingBox):
3467         (Line):
3468         * LayoutReloaded/Utils.js:
3469         (LayoutRect.prototype.moveHorizontally):
3470         (LayoutRect.prototype.moveVertically):
3471         * LayoutReloaded/test/index.html:
3472         * LayoutReloaded/test/inline-with-floats-when-they-dont-fit.html: Added.
3473
3474 2018-04-05  Brady Eidson  <beidson@apple.com>
3475
3476         Process Swap on Navigation causes many webpages to hang due to attempted process swap for iframe navigations.
3477         <rdar://problem/39162236> and https://bugs.webkit.org/show_bug.cgi?id=184318
3478
3479         Reviewed by Andy Estes.
3480
3481         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3482         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
3483         (-[PSONScheme addMappingFromURLString:toData:]):
3484         (-[PSONScheme webView:startURLSchemeTask:]):
3485
3486 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3487
3488         [WTF] Remove StaticLock
3489         https://bugs.webkit.org/show_bug.cgi?id=184332
3490
3491         Reviewed by Mark Lam.
3492
3493         * DumpRenderTree/JavaScriptThreading.cpp:
3494
3495 2018-04-05  Zalan Bujtas  <zalan@apple.com>
3496
3497         [LayoutReloaded] Find the correct left edge for a line when floating boxes are in parent formatting context.
3498         https://bugs.webkit.org/show_bug.cgi?id=184330
3499
3500         Reviewed by Antti Koivisto.
3501
3502         In inline formatting context, the floating boxes can come from the parent (block) formatting context. Let's
3503         take them into account when computing the line edges.
3504
3505         * LayoutReloaded/FormattingContext/FloatingContext.js:
3506         (FloatingContext.prototype.left):
3507         (FloatingContext.prototype.right):
3508         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3509         (InlineFormattingContext.prototype._createNewLine):
3510         (InlineFormattingContext.prototype._mapFloatingVerticalPosition):
3511         (InlineFormattingContext.prototype._mapFloatingHorizontalPosition):
3512         (InlineFormattingContext.prototype._mapFloatingPosition): Deleted.
3513         * LayoutReloaded/test/index.html:
3514         * LayoutReloaded/test/multiple-left-floats-on-line-from-parent-formatting-context.html: Added.
3515
3516 2018-04-05  Zalan Bujtas  <zalan@apple.com>
3517
3518         [LayoutReloaded] Collect floating boxes in inline formatting context and layout them first.
3519         https://bugs.webkit.org/show_bug.cgi?id=184329
3520
3521         Reviewed by Antti Koivisto.
3522
3523         Let's do this for now. There might be some cases where this violates layout.
3524
3525         * LayoutReloaded/FormattingContext/FormattingContext.js:
3526         (FormattingContext.prototype._outOfFlowDescendants):
3527         (FormattingContext):
3528         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3529         (InlineFormattingContext.prototype.layout):
3530         (InlineFormattingContext.prototype._handleFloatingBoxes):
3531         (InlineFormattingContext.prototype._handleFloatingBox):
3532         (InlineFormattingContext.prototype._floatingBoxes):
3533         (InlineFormattingContext):
3534         * LayoutReloaded/test/index.html:
3535         * LayoutReloaded/test/multiple-left-floats-on-line-simple.html: Added.
3536
3537 2018-04-04  Youenn Fablet  <youenn@apple.com>
3538
3539         WebRTC data channel only applications require capture permissions for direct connections
3540         https://bugs.webkit.org/show_bug.cgi?id=174500
3541         <rdar://problem/34134281>
3542
3543         Reviewed by Eric Carlson.
3544
3545         Adding options to enable MDNS ICE candidates.
3546
3547         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3548         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3549         (WTR::TestRunner::setMediaDevicesEnabled):
3550         (WTR::TestRunner::setMDNSICECandidatesEnabled):
3551         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3552         * WebKitTestRunner/TestController.cpp:
3553         (WTR::TestController::resetPreferencesToConsistentValues):
3554
3555 2018-04-04  Ryan Haddad  <ryanhaddad@apple.com>
3556
3557         Disable failing WKWebViewAutofillTests
3558         https://bugs.webkit.org/show_bug.cgi?id=184196
3559
3560         Unreviewed test gardening.
3561
3562         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3563         (TestWebKitAPI::TEST):
3564
3565 2018-04-04  Youenn Fablet  <youenn@apple.com>
3566
3567         Introduce a ThreadSafeRefCounted parameter to ensure being destroyed on the main thread
3568         https://bugs.webkit.org/show_bug.cgi?id=183988
3569
3570         Reviewed by Darin Adler.
3571
3572         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3573         (TestWebKitAPI::ThreadSafeRefCountedObject::create):
3574         (TestWebKitAPI::ThreadSafeRefCountedObject::~ThreadSafeRefCountedObject):
3575         (TestWebKitAPI::MainThreadSafeRefCountedObject::create):
3576         (TestWebKitAPI::MainThreadSafeRefCountedObject::~MainThreadSafeRefCountedObject):
3577         (TestWebKitAPI::TEST):
3578
3579 2018-04-04  Ms2ger  <Ms2ger@igalia.com>
3580
3581         Test gardening for GTK.
3582         https://bugs.webkit.org/show_bug.cgi?id=184298
3583
3584         Unreviewed test gardening.
3585
3586         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Add pointer to
3587         https://bugs.webkit.org/show_bug.cgi?id=184295.
3588
3589 2018-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3590
3591         ASSERTION FAILED: !m_mainFrame->coreFrame()->loader().frameHasLoaded() || !m_pendingNavigationID when reloading page while a page is loading
3592         https://bugs.webkit.org/show_bug.cgi?id=153210
3593
3594         Reviewed by Alex Christensen.
3595
3596         Add unit tests to WebKit C API and WebKitGLib.
3597
3598         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3599         (TestWebKitAPI::TEST):
3600         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3601         (LoadTwiceAndReloadTest::reloadOnFinishLoad):
3602         (LoadTwiceAndReloadTest::LoadTwiceAndReloadTest):
3603         (LoadTwiceAndReloadTest::~LoadTwiceAndReloadTest):
3604         (LoadTwiceAndReloadTest::waitUntilFinished):
3605         (testWebViewLoadTwiceAndReload):
3606         (beforeAll):
3607
3608 2018-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3609
3610         [GTK] Test /webkit/WebKitWebPage/context-menu is failing since r229831
3611         https://bugs.webkit.org/show_bug.cgi?id=184260
3612
3613         Reviewed by Michael Catanzaro.
3614
3615         This is not a regression introduced in r229831, though, it's a bug in the test itself revealed by r229831. We
3616         should wait for the load to complete before trying to show the context menu.
3617
3618         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3619         (testContextMenuWebExtensionMenu):
3620
3621 2018-04-03  Zalan Bujtas  <zalan@apple.com>
3622
3623         [LayoutReloaded] Introduce floating to InlineFormattingContext
3624         https://bugs.webkit.org/show_bug.cgi?id=184288
3625
3626         Reviewed by Antti Koivisto.
3627
3628         * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
3629         (BlockFormattingContext.prototype._computeFloatingWidth): Deleted.
3630         (BlockFormattingContext.prototype._computeFloatingHeight): Deleted.
3631         * LayoutReloaded/FormattingContext/FormattingContext.js:
3632         (FormattingContext.prototype._computeFloatingWidth):
3633         (FormattingContext.prototype._computeFloatingHeight):
3634         * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
3635         (InlineFormattingContext.prototype.layout):
3636         (InlineFormattingContext.prototype._handleFloatingBox):
3637         * LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
3638         (Line.prototype.addFloatingBox):
3639         (Line):
3640         * LayoutReloaded/test/float-is-inside-inline-formatting-context-simple.html: Added.
3641         * LayoutReloaded/test/index.html:
3642
3643 2018-04-03  Youenn Fablet  <youenn@apple.com>
3644
3645         NetworkResourceLoader does not need to expose all redirect response headers
3646         https://bugs.webkit.org/show_bug.cgi?id=184114
3647         <rdar://problem/39010557>
3648
3649         Reviewed by Ryosuke Niwa.
3650
3651         Add an option to dump the number of headers in a response.
3652         This allows validating that filtering does happen or not.
3653
3654         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3655         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3656         (WTR::dumpResponseDescriptionSuitableForTestResult):
3657         (WTR::InjectedBundlePage::responseHeaderCount):
3658         (WTR::InjectedBundlePage::willSendRequestForFrame):
3659         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3660         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3661         (WTR::TestRunner::dumpAllHTTPRedirectedResponseHeaders):
3662         (WTR::TestRunner::shouldDumpAllHTTPRedirectedResponseHeaders const):
3663         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3664         (WTR::InjectedBundlePage::responseHeaderCount):
3665         * WebKitTestRunner/TestController.cpp:
3666         (WTR::TestController::resetPreferencesToConsistentValues):
3667
3668 2018-04-03  Andy Estes  <aestes@apple.com>
3669
3670         [Mac] Prioritize file promises over filenames during drag and drop
3671         https://bugs.webkit.org/show_bug.cgi?id=184237
3672       &nb