a6f8b7658d812a070fe7c21026b874427b9395ef
[WebKit-https.git] / Tools / ChangeLog
1 2012-10-09  Daniel Bates  <dbates@webkit.org>
2
3         VCSUtils.pm doesn't support SVN 1.7 diff files
4         <https://bugs.webkit.org/show_bug.cgi?id=80762>
5
6         Reviewed by Eric Seidel.
7
8         Implement support for the SVN 1.7 diff format.
9
10         * Scripts/VCSUtils.pm:
11         (parseChunkRange): Modified to support parsing an SVN 1.7 chunk range
12         that begins and ends with "##" (e.g. ## -0,0 +1,7 ##). For comparison,
13         earlier versions of SVN parsed chunk ranges of the form "@@ -0,0 +1,7 @@".
14
15         (parseSvnDiffHeader): Modified to parse an SVN 1.7 binary diff; SVN 1.7
16         has an unusual display format for a binary diff. It repeats the first
17         two lines of the diff header.
18
19         (parseSvnProperty): Modified to ignore both an SVN 1.7 chunk range and
20         lines of the form "\ No newline at end of property". SVN 1.7 emits the latter
21         message after a property value that doesn't end in a newline.
22
23         (parseSvnPropertyValue): Stop parsing an SVN property value when we encounter
24         a line of the form "\ No newline at end of property" (emitted by svn diff as of
25         SVN 1.7).
26
27         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
28           - Added the following unit tests:
29           "Line count is 0"
30           "New line count is 1"
31
32         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
33           - Added the following unit tests:
34           "svn:executable followed by custom property using SVN 1.7 syntax"
35           "svn:executable followed by custom property without newline using SVN 1.7 syntax"
36
37         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
38           - Updated test results for test "binary file".
39           - Added unit test "binary file using SVN 1.7 syntax".
40
41         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
42           - Added the following unit tests:
43           "simple: add svn:executable using SVN 1.7 syntax"
44           "simple: delete svn:executable using SVN 1.7 syntax"
45           "add svn:mime-type and add svn:executable using SVN 1.7 syntax"
46
47         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
48           - Added the following unit tests:
49           "singe-line '+' change using SVN 1.7 syntax"
50           "single-line '-' change using SVN 1.7 syntax"
51
52 2012-10-09  James Robinson  <jamesr@chromium.org>
53
54         Unreviewed, rolling out r128488.
55         http://trac.webkit.org/changeset/128488
56         https://bugs.webkit.org/show_bug.cgi?id=96678
57
58         The bot is fixed now
59
60         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
61         (.):
62
63 2012-10-09  Zan Dobersek  <zandobersek@gmail.com>
64
65         XvfbDriver unit test is flaky on Linux builders
66         https://bugs.webkit.org/show_bug.cgi?id=98346
67
68         Reviewed by Adam Barth.
69
70         Temporarily skip the XvfbDriver test case that tests
71         the display number of the next free display. The test
72         is flaky on Linux builders.
73
74         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
75         (XvfbDriverTest.disabled_test_next_free_display):
76
77 2012-10-09  Ojan Vafai  <ojan@chromium.org>
78
79         Don't duplicated build numbers when merging flakiness dashboard JSON
80         https://bugs.webkit.org/show_bug.cgi?id=98812
81
82         Reviewed by Dirk Pranke.
83
84         In general, build numbers are not unique, but we should basically never
85         get the same build number uploaded twice in a row. This is a workaround
86         for https://bugs.webkit.org/show_bug.cgi?id=97643, which frequently hits this
87         because we update results_small.json and timeout updating results.json and then
88         we retry the whole request.
89
90         * TestResultServer/model/jsonresults.py:
91         (JsonResults.merge):
92         * TestResultServer/model/jsonresults_unittest.py:
93         (JsonResultsTest.test_merge_duplicate_build_number):
94
95 2012-10-09  Alexis Menard  <alexis@webkit.org>
96
97         [GTK] Shadow builds are not working anymore.
98         https://bugs.webkit.org/show_bug.cgi?id=98785
99
100         Reviewed by Martin Robinson.
101
102         When setting WEBKITOUTPUTDIR the build was failing with a python
103         error : the os.execve expect three arguments. Also the condition
104         to check whether we build the GTK port with jhbuild or not was buggy
105         as it was always assuming an in source build. We can use now jhbuildutils
106         which has a convenient function to locate the directory where 
107         the dependencies built with jhbuild are and take into account WEBKITOUTPUTDIR.
108         If the Dependencies path does not exist then the build was not done using
109         jhbuild so we can fallback to a regular build against system libraries.
110
111         * gtk/run-with-jhbuild:
112
113 2012-10-08  Simon Fraser  <simon.fraser@apple.com>
114
115         Remove DRT/WTR implementations of layerTreeAsText
116         https://bugs.webkit.org/show_bug.cgi?id=98697
117
118         Reviewed by Tim Horton, James Robinson, Alexey Proskuryakov.
119
120         Remove code related to layerTreeAsText(), which is now on window.internals.
121
122         * DumpRenderTree/TestRunner.cpp:
123         (TestRunner::staticFunctions):
124         * DumpRenderTree/TestRunner.h:
125         (TestRunner):
126         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
127         * DumpRenderTree/chromium/DRTTestRunner.cpp:
128         (DRTTestRunner::DRTTestRunner):
129         * DumpRenderTree/chromium/DRTTestRunner.h:
130         (DRTTestRunner):
131         * DumpRenderTree/efl/TestRunnerEfl.cpp:
132         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
133         * DumpRenderTree/mac/TestRunnerMac.mm:
134         * DumpRenderTree/qt/TestRunnerQt.cpp:
135         * DumpRenderTree/qt/TestRunnerQt.h:
136         (TestRunner):
137         * DumpRenderTree/win/TestRunnerWin.cpp:
138         * DumpRenderTree/wx/TestRunnerWx.cpp:
139         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
140         * WebKitTestRunner/InjectedBundle/TestRunner.h:
141
142 2012-10-09  Zoltan Horvath  <zoltan@webkit.org>
143
144         Unreviewed. Remove myself from QtWebKit2 subscriptions.
145
146         * Scripts/webkitpy/common/config/watchlist:
147
148 2012-10-09  Harald Alvestrand  <hta@google.com>
149
150         Change PeerConnection getStats function to single value local / remote
151         elements in RTCStatsReport.
152         https://bugs.webkit.org/show_bug.cgi?id=98753
153
154         Reviewed by Adam Barth.
155
156         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
157         (MockWebRTCPeerConnectionHandler::getStats):
158
159 2012-10-09  Sadrul Habib Chowdhury  <sadrul@chromium.org>
160
161         [chromium] Make sure events are transformed correctly for plugins.
162         https://bugs.webkit.org/show_bug.cgi?id=89250
163
164         Reviewed by Tony Chang.
165
166         Update the test plugin to print event details for mouse and gesture events.
167
168         * DumpRenderTree/chromium/TestWebPlugin.cpp:
169         (printEventDetails):
170
171 2012-10-09  Simon Hausmann  <simon.hausmann@digia.com>
172
173         Unreviewed trivial Qt build fix: Remove stray closing braces from r130758.
174
175         * qmake/mkspecs/features/features.prf:
176
177 2012-10-09  Simon Hausmann  <simon.hausmann@digia.com>
178
179         [Qt] Clean up Qt module detection
180
181         Reviewed by Tor Arne Vestbø.
182
183         Replace the use of MOBILITY_CONFIG (not supported anymore) with modern use of haveQtModule.
184
185         * qmake/mkspecs/features/features.prf:
186
187 2012-10-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
188
189         [GTK] Respect WEBKITOUTPUTDIR in run-with-jhbuild.
190         https://bugs.webkit.org/show_bug.cgi?id=98732
191
192         Reviewed by Gustavo Noronha Silva.
193
194         Follow-up to r113066: if the WEBKITOUTPUTDIR environment variable
195         was used when running update-webkitgtk-libs,
196         WebKitBuild/Dependencies will not exist, so we now check its
197         contents first and then fall back to WebKitBuild/.
198
199         * gtk/run-with-jhbuild:
200
201 2012-10-09  Zan Dobersek  <zandobersek@gmail.com>
202
203         Unreviewed GTK gardening.
204
205         Skipping the accept-policy test in TestCookieManager API test that's
206         currently failing. The test failure is covered by
207         https://bugs.webkit.org/show_bug.cgi?id=98738.
208
209         * Scripts/run-gtk-tests:
210         (TestRunner):
211
212 2012-10-09  Laszlo Gombos  <l.gombos@samsung.com>
213
214         [Qt] Remove redundant JAVASCRIPTCORE_JIT variable
215         https://bugs.webkit.org/show_bug.cgi?id=50000
216
217         Reviewed by Simon Hausmann.
218
219         Use ENABLE_JIT instead.
220
221         * qmake/mkspecs/features/valgrind.prf:
222
223 2012-10-08  Kiran Muppala  <cmuppala@apple.com>
224
225         Throttle DOM timers on hidden pages.
226         https://bugs.webkit.org/show_bug.cgi?id=98474
227
228         Reviewed by Maciej Stachowiak.
229
230         Implement testRunner.setPageVisibility on mac for testing throttling
231         of timers on hidden pages using DumpRenderTree.
232
233         * DumpRenderTree/mac/Configurations/Base.xcconfig:
234         Fix build error on mac-ews bot.  Add JSC copy of ICU headers to search path.
235
236         * DumpRenderTree/mac/TestRunnerMac.mm:
237         (TestRunner::resetPageVisibility):
238         (TestRunner::setPageVisibility):
239
240 2012-10-08  Dirk Pranke  <dpranke@chromium.org>
241
242         results.html and garden-o-matic are ignoring IMAGE failures when expected to FAIL
243         https://bugs.webkit.org/show_bug.cgi?id=98706
244
245         Reviewed by Ojan Vafai.
246
247         FAIL is supposed to map onto Failure which is supposed to map
248         onto the old [ TEXT, IMAGE_PLUS_TEXT, AUDIO ] mapping.
249         results.html was including IMAGE in this and garden-o-matic was
250         including CRASH and TIMEOUT as well :(.
251
252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
253         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
254
255 2012-10-08  Ryuan Choi  <ryuan.choi@samsung.com>
256
257         [EFL] Build ControlTheme only when necessary
258         https://bugs.webkit.org/show_bug.cgi?id=98519
259
260         Reviewed by Eric Seidel.
261
262         * EWebLauncher/ControlTheme/CMakeLists.txt:
263         Added custom command keyword not to build ControlTheme every time.
264         In addition, removed `ALL` keyword because targets, which use ControlTheme,
265         already have dependency.
266
267 2012-10-08  Peter Rybin  <peter.rybin@gmail.com>
268
269         Do not swallow fatal messages in qt/DumpRenderTree
270         https://bugs.webkit.org/show_bug.cgi?id=98211
271
272         Reviewed by Eric Seidel.
273
274         Fix condition in message type filtering.
275
276         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
277         (messageHandler):
278
279 2012-10-08  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
280
281         Unreviewed. Moving myself from Committer to Reviewer list.
282         http://lists.webkit.org/pipermail/webkit-dev/2012-October/022460.html
283
284         * Scripts/webkitpy/common/config/committers.py:
285
286 2012-10-08  Dirk Pranke  <dpranke@chromium.org>
287
288         nrwt: [chromium] run http tests in parallel on bigger machines
289         https://bugs.webkit.org/show_bug.cgi?id=98562
290
291         Reviewed by Eric Seidel.
292
293         The "locked tests" shard (which includes the http tests and the
294         perf tests) is the long pole on machines where we have 4 or more
295         workers, so we should start making sure that
296         we can run http tests in parallel, following the normal sharding
297         rules (all tests in the same directory are in the same shard by
298         default). We should still probably limit the number of workers
299         hitting the web server in parallel where we can; a heuristic of
300         no more than 25% of them seems okay for a start. This will
301         likely only affect developer workstations and a couple of bots
302         at first, so should be low risk and a good reward.
303
304         * Scripts/webkitpy/layout_tests/port/base.py:
305         (Port.default_max_locked_shards):
306         * Scripts/webkitpy/layout_tests/port/chromium.py:
307         (ChromiumPort.default_max_locked_shards):
308         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
309         (ChromiumPortTestCase.test_default_max_locked_shards):
310         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
311         (PortTestCase.test_default_max_locked_shards):
312         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
313         (_set_up_derived_options):
314         (parse_args):
315         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
316         (MainTest.test_max_locked_shards):
317
318 2012-10-08  Zan Dobersek  <zandobersek@gmail.com>
319
320         GTK port should warn if bug modifier is missing in TestExpectations
321         https://bugs.webkit.org/show_bug.cgi?id=98678
322
323         Reviewed by Dirk Pranke.
324
325         Reimplement the warn_if_bug_missing_in_test_expectations method in
326         GtkPort, returning True for producing a warning in such cases.
327
328         * Scripts/webkitpy/layout_tests/port/gtk.py:
329         (GtkPort.warn_if_bug_missing_in_test_expectations):
330
331 2012-10-08  Ryuan Choi  <ryuan.choi@samsung.com>
332
333         [EFL][DRT] Switch default backing store to single
334         https://bugs.webkit.org/show_bug.cgi?id=98591
335
336         Reviewed by Eric Seidel.
337
338         There are two backing stores for WebKit/Efl, Single Backing Store(SBS) and
339         Tiled Backing Store(TBS), and DRT/Efl has used TBS.
340         But, TBS is not suitable to run pixel tests because it does not have a good way
341         to render mock scrollbars well.
342
343         So, this patch changes the default backing store to SBS.
344         In addition, this changes the environment variable from DRT_USE_SINGLE_BACKING_STORE
345         to DRT_USE_TILED_BACKING_STORE.
346
347         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
348         (shouldUseTiledBackingStore):
349         (chooseAndInitializeAppropriateSmartClass):
350
351 2012-10-08  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
352
353         [WK2][WTR] WebKitTestRunner needs testRunner.dispatchPendingLoadRequests
354         https://bugs.webkit.org/show_bug.cgi?id=98638
355
356         Reviewed by Eric Seidel.
357
358         Add implementation for testRunner.dispatchPendingLoadRequests in
359         WebKitTestRunner.
360
361         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
362         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
363         (WTR::TestRunner::dispatchPendingLoadRequests):
364         (WTR):
365         * WebKitTestRunner/InjectedBundle/TestRunner.h:
366         (TestRunner):
367
368 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
369
370         [EFL][WK2] Add support for window.close in Minibrowser
371         https://bugs.webkit.org/show_bug.cgi?id=98667
372
373         Reviewed by Laszlo Gombos.
374
375         When calling window.close() from JavaScript, MiniBrowser
376         now closes the given window.
377
378         * MiniBrowser/efl/main.c:
379         (window_close):
380         (on_ecore_evas_delete):
381         (on_close_window):
382         (window_create):
383
384 2012-10-08  Ojan Vafai  <ojan@chromium.org>
385
386         Properly strip new tests from the test results json if they are pass/nodata/skip.
387         https://bugs.webkit.org/show_bug.cgi?id=98669
388
389         Reviewed by Eric Seidel.
390
391         In _merge_json, we had a codepath that didn't call _normalize_results_json
392         for tests that aren't already in the aggregated results.
393         Instead, now do all the merging first and then normalize the aggregated results.
394
395         * TestResultServer/model/jsonresults.py:
396         (JsonResults._merge_json):
397         (JsonResults._merge_tests):
398         (JsonResults._normalize_results):
399         (JsonResults):
400         (JsonResults._should_delete_leaf):
401         * TestResultServer/model/jsonresults_unittest.py:
402         Removed test_merge_build_directory_hierarchy_old_version since there is
403         no longer any version 3 json to support.
404         (JsonResultsTest.test_merge_remove_new_test):
405         (JsonResultsTest.test_merge_prune_extra_results_with_new_result_of_same_type):
406
407 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
408
409         [EFL][WK2] Simplify frame flattening support in MiniBrowser
410         https://bugs.webkit.org/show_bug.cgi?id=98657
411
412         Reviewed by Kenneth Rohde Christiansen.
413
414         Simplify frame flattening support code in MiniBrowser to
415         avoid passing the setting around to window_create()
416         function().
417
418         * MiniBrowser/efl/main.c:
419         (on_key_down):
420         (on_new_window):
421         (window_create):
422         (main):
423
424 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
425
426         [EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher
427         https://bugs.webkit.org/show_bug.cgi?id=98655
428
429         Reviewed by Kenneth Rohde Christiansen.
430
431         Use "Ctrl+n" shortcut instead of "F9" to open a new window in
432         MiniBrowser and EWebLauncher. This is the shortcut that is
433         commonly used for this action.
434
435         * EWebLauncher/main.c:
436         (on_key_down):
437         * MiniBrowser/efl/main.c:
438         (on_key_down):
439
440 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
441
442         [EFL][WK2] Add support for window.create in Minibrowser
443         https://bugs.webkit.org/show_bug.cgi?id=98649
444
445         Reviewed by Kenneth Rohde Christiansen.
446
447         Calling window.create() from JavaScript now creates a
448         new window in Minibrowser, as directed.
449
450         * MiniBrowser/efl/main.c:
451         (on_new_window):
452         (window_create):
453
454 2012-10-08  Andreas Kling  <kling@webkit.org>
455
456         Using float/double as WTF hash table key is unreliable.
457         <http://webkit.org/b/98627>
458
459         Reviewed by Geoffrey Garen.
460
461         Add a test case checking that using double as the hash table key type won't
462         have problems distinguishing between keys that are considered equal by operator==
463         but have different binary representations.
464
465         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
466         (TestDoubleHashTraits):
467
468 2012-10-08  Christophe Dumez  <christophe.dumez@intel.com>
469
470         [EFL][WK2] Use URL instead of URI in the API
471         https://bugs.webkit.org/show_bug.cgi?id=98643
472
473         Reviewed by Kenneth Rohde Christiansen.
474
475         Update Minibrowser to reflect API changes. We now
476         use URL instead of URI in WK2 EFL API.
477
478         * EWebLauncher/url_bar.c:
479         (on_urlbar_key_down):
480         * MiniBrowser/efl/CMakeLists.txt:
481         * MiniBrowser/efl/main.c:
482         (on_url_changed):
483         (window_create):
484
485 2012-10-08  Balazs Kelemen  <kbalazs@webkit.org>
486
487         [Qt] Reenable plugin tests
488         https://bugs.webkit.org/show_bug.cgi?id=98528
489
490         Reviewed by Csaba Osztrogonác.
491
492         Uncomment this function so we can pick up the test plugin.
493         It was commented out because of https://bugs.webkit.org/show_bug.cgi?id=86620
494         and that bug seems to be fixed now.
495
496         * WebKitTestRunner/qt/TestControllerQt.cpp:
497         (WTR::TestController::initializeTestPluginDirectory):
498
499 2012-10-08  Jinwoo Song  <jinwoo7.song@samsung.com>
500
501         [EFL][WK2] Support multiple window creation for MiniBrowser
502         https://bugs.webkit.org/show_bug.cgi?id=97884
503
504         Reviewed by Kenneth Rohde Christiansen.
505
506         Implement the multiple window creation for MiniBrowser and bind the 'F9' key for opening a new window.
507         Also, refactored MiniBrowser codes according to EFL coding style.
508
509         * MiniBrowser/efl/main.c:
510         (_Browser_Window):
511         (window_free):
512         (main_signal_exit):
513         (on_ecore_evas_delete):
514         (on_ecore_evas_resize):
515         (on_key_down):
516         (on_title_changed):
517         (on_url_changed):
518         (on_progress):
519         (window_create):
520         (main):
521
522 2012-10-07  Seokju Kwon  <seokju.kwon@samsung.com>
523
524         [EFL] Add Web Inspector to EWebLauncher
525         https://bugs.webkit.org/show_bug.cgi?id=91718
526
527         Reviewed by Gyuyoung Kim.
528
529         Implementation of Web Inspector in EWebLauncher.
530         The Web Inspector can be opened or closed by pressing ctrl+i on web page.
531
532         * EWebLauncher/main.c:
533         (on_browser_ecore_evas_resize):
534         (on_web_inspector_ecore_evas_resize):
535         (on_key_down):
536         (on_web_inspector_view_create):
537         (on_web_inspector_view_close):
538         (on_web_inspector_view_destroyed):
539         (browserCreate):
540         (webInspectorCreate):
541         (windowCreate):
542         (closeWindow):
543         (main_signal_exit):
544         (parseUserArguments):
545
546 2012-10-07  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
547
548         Rename first/second to key/value in HashMap iterators
549         https://bugs.webkit.org/show_bug.cgi?id=82784
550
551         Reviewed by Eric Seidel.
552
553         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
554         (MockWebSpeechInputController::addMockRecognitionResult):
555         * DumpRenderTree/chromium/NotificationPresenter.cpp:
556         (NotificationPresenter::simulateClick):
557         (NotificationPresenter::show):
558         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
559         (CppBoundClass::~CppBoundClass):
560         (CppBoundClass::invoke):
561         (CppBoundClass::getProperty):
562         (CppBoundClass::setProperty):
563         (CppBoundClass::bindCallback):
564         (CppBoundClass::bindProperty):
565         * DumpRenderTree/chromium/WebPreferences.cpp:
566         (applyFontMap):
567         * DumpRenderTree/chromium/WebViewHost.cpp:
568         (WebViewHost::printResourceDescription):
569         * DumpRenderTree/mac/TestRunnerMac.mm:
570         (worldIDForWorld):
571         (TestRunner::evaluateScriptInIsolatedWorld):
572         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
573         (AccessibilityController::~AccessibilityController):
574         (AccessibilityController::winNotificationReceived):
575         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
576         (ResourceLoadDelegate::descriptionSuitableForTestResult):
577         * DumpRenderTree/win/TestRunnerWin.cpp:
578         (worldIDForWorld):
579         (TestRunner::evaluateScriptInIsolatedWorld):
580         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
581         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
582         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
583         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
584         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
585         (WTR::TestRunner::worldIDForWorld):
586         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
587
588 2012-10-07  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
589
590         Unreviewed, rolling out r130596.
591         http://trac.webkit.org/changeset/130596
592         https://bugs.webkit.org/show_bug.cgi?id=98616
593
594         Broke build bots without IPV6 support
595
596         * Scripts/webkitpy/common/system/platforminfo_mock.py:
597         (MockPlatformInfo.is_cygwin):
598         * Scripts/webkitpy/layout_tests/port/base.py:
599         (Port.baseline_version_dir):
600         (Port.to.start_websocket_server):
601         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
602         (PortTest.test_operating_system):
603         (PortTest.test_build_path):
604         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
605         (LayoutTestApacheHttpd):
606         (LayoutTestApacheHttpd.__init__):
607
608 2012-10-07  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
609
610         webkitpy: Pass the `Listen' Apache directive from Apache, not the httpd.conf files.
611         https://bugs.webkit.org/show_bug.cgi?id=98602
612
613         Reviewed by Eric Seidel.
614
615         Unify all the different `Listen' directives present in the several
616         httpd.conf files we have in LayoutTests/http/conf. For one, we
617         were already passing `Listen 127.0.0.1:8000' via webkitpy before,
618         and opening the other ports from the conf files.
619
620         The configuration files differed mostly in the way they handled
621         IPV6 ports. Some of them did not listen to IPV6 ports because the
622         systems which used them sometimes did not have IPV6 support. The
623         `http_server_supports_ipv6' method has been added to Port to
624         address that. cygwin, on its turn, still seems to use Apache 1.3,
625         which does not support IPV6 at all; the newly-added method has a
626         special case for that.
627
628         * Scripts/webkitpy/common/system/platforminfo_mock.py:
629         (MockPlatformInfo.is_cygwin):
630         * Scripts/webkitpy/layout_tests/port/base.py:
631         (Port.baseline_version_dir):
632         (Port.to.start_websocket_server):
633         (Port.to):
634         (Port.to.http_server_supports_ipv6):
635         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
636         (PortTest.test_http_server_supports_ipv6):
637         (PortTest.test_build_path):
638         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
639         (LayoutTestApacheHttpd):
640         (LayoutTestApacheHttpd.__init__):
641
642 2012-10-05  Simon Fraser  <simon.fraser@apple.com>
643
644         Attempt to fix the SnowLeopard build to making the implementation of
645         -isPaginated come before its use.
646
647         * MiniBrowser/mac/WK1BrowserWindowController.m:
648         (-[WK1BrowserWindowController reload:]):
649         (-[WK1BrowserWindowController forceRepaint:]):
650         (-[WK1BrowserWindowController goBack:]):
651         (-[WK1BrowserWindowController goForward:]):
652         (-[WK1BrowserWindowController isPaginated]):
653
654 2012-10-05  Simon Fraser  <simon.fraser@apple.com>
655
656         Provide a way to run WebKit1
657         https://bugs.webkit.org/show_bug.cgi?id=98568
658
659         Reviewed by Tim Horton.
660
661         Make it possible to create both WebKit1 and WebKit2 windows in MiniBrowser.
662         
663         Turn BrowserWindowController into a base class; subclassed by
664         WK1BrowserWindowController and WK2BrowserWindowController, each of
665         which implement the BrowserController protocol.
666         
667         Use Command-N to get a WebKit1 window, and Command-Option-N to
668         get a WK2 window. Also add "Open Location" to focus the URL bar,
669         and code to add an http:// if missing.
670         
671         Hook up window title callbacks; append " [WK1/2]" to window title
672         as appropriate.
673
674         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
675         * MiniBrowser/mac/AppDelegate.m:
676         (-[BrowserAppDelegate newWindow:]):
677         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
678         * MiniBrowser/mac/BrowserWindowController.h:
679         * MiniBrowser/mac/BrowserWindowController.m:
680         (-[BrowserWindowController initWithWindow:]):
681         (-[BrowserWindowController windowDidLoad]):
682         (-[BrowserWindowController openLocation:]):
683         (-[BrowserWindowController loadURLString:]):
684         (-[BrowserWindowController applicationTerminating]):
685         (-[BrowserWindowController addProtocolIfNecessary:]):
686         * MiniBrowser/mac/MainMenu.xib:
687         * MiniBrowser/mac/WK1BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
688         (WebView):
689         * MiniBrowser/mac/WK1BrowserWindowController.m: Added.
690         (-[WK1BrowserWindowController awakeFromNib]):
691         (-[WK1BrowserWindowController dealloc]):
692         (-[WK1BrowserWindowController loadURLString:]):
693         (-[WK1BrowserWindowController fetch:]):
694         (-[WK1BrowserWindowController showHideWebView:]):
695         (-[WK1BrowserWindowController removeReinsertWebView:]):
696         (-[WK1BrowserWindowController validateMenuItem:]):
697         (-[WK1BrowserWindowController reload:]):
698         (-[WK1BrowserWindowController forceRepaint:]):
699         (-[WK1BrowserWindowController goBack:]):
700         (-[WK1BrowserWindowController goForward:]):
701         (-[WK1BrowserWindowController validateUserInterfaceItem:]):
702         (-[WK1BrowserWindowController validateToolbar]):
703         (-[WK1BrowserWindowController windowShouldClose:]):
704         (-[WK1BrowserWindowController windowWillClose:]):
705         (-[WK1BrowserWindowController applicationTerminating]):
706         (-[WK1BrowserWindowController currentZoomFactor]):
707         (-[WK1BrowserWindowController canZoomIn]):
708         (-[WK1BrowserWindowController zoomIn:]):
709         (-[WK1BrowserWindowController canZoomOut]):
710         (-[WK1BrowserWindowController zoomOut:]):
711         (-[WK1BrowserWindowController canResetZoom]):
712         (-[WK1BrowserWindowController resetZoom:]):
713         (-[WK1BrowserWindowController toggleZoomMode:]):
714         (-[WK1BrowserWindowController isPaginated]):
715         (-[WK1BrowserWindowController togglePaginationMode:]):
716         (-[WK1BrowserWindowController find:]):
717         (-[WK1BrowserWindowController dumpSourceToConsole:]):
718         (-[WK1BrowserWindowController webView:didStartProvisionalLoadForFrame:]):
719         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
720         * MiniBrowser/mac/WK2BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
721         * MiniBrowser/mac/WK2BrowserWindowController.m: Copied from Tools/MiniBrowser/mac/BrowserWindowController.m.
722         (-[WK2BrowserWindowController initWithContext:pageGroup:]):
723         (-[WK2BrowserWindowController dealloc]):
724         (-[WK2BrowserWindowController fetch:]):
725         (-[WK2BrowserWindowController showHideWebView:]):
726         (-[WK2BrowserWindowController removeReinsertWebView:]):
727         (-[WK2BrowserWindowController validateMenuItem:]):
728         (-[WK2BrowserWindowController reload:]):
729         (-[WK2BrowserWindowController forceRepaint:]):
730         (-[WK2BrowserWindowController goBack:]):
731         (-[WK2BrowserWindowController goForward:]):
732         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
733         (-[WK2BrowserWindowController validateToolbar]):
734         (-[WK2BrowserWindowController windowShouldClose:]):
735         (-[WK2BrowserWindowController windowWillClose:]):
736         (-[WK2BrowserWindowController applicationTerminating]):
737         (-[WK2BrowserWindowController currentZoomFactor]):
738         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
739         (-[WK2BrowserWindowController canZoomIn]):
740         (-[WK2BrowserWindowController zoomIn:]):
741         (-[WK2BrowserWindowController canZoomOut]):
742         (-[WK2BrowserWindowController zoomOut:]):
743         (-[WK2BrowserWindowController canResetZoom]):
744         (-[WK2BrowserWindowController resetZoom:]):
745         (-[WK2BrowserWindowController toggleZoomMode:]):
746         (-[WK2BrowserWindowController isPaginated]):
747         (-[WK2BrowserWindowController togglePaginationMode:]):
748         (-[WK2BrowserWindowController dumpSourceToConsole:]):
749         (didStartProvisionalLoadForFrame):
750         (didReceiveServerRedirectForProvisionalLoadForFrame):
751         (didFailProvisionalLoadWithErrorForFrame):
752         (didCommitLoadForFrame):
753         (didFinishDocumentLoadForFrame):
754         (didFinishLoadForFrame):
755         (didFailLoadWithErrorForFrame):
756         (didSameDocumentNavigationForFrame):
757         (didReceiveTitleForFrame):
758         (didFirstLayoutForFrame):
759         (didFirstVisuallyNonEmptyLayoutForFrame):
760         (didRemoveFrameFromHierarchy):
761         (didDisplayInsecureContentForFrame):
762         (didRunInsecureContentForFrame):
763         (didDetectXSSForFrame):
764         (didStartProgress):
765         (didChangeProgress):
766         (didFinishProgress):
767         (didBecomeUnresponsive):
768         (didBecomeResponsive):
769         (processDidExit):
770         (didChangeBackForwardList):
771         (decidePolicyForNavigationAction):
772         (decidePolicyForNewWindowAction):
773         (decidePolicyForResponse):
774         (createNewPage):
775         (showPage):
776         (closePage):
777         (runJavaScriptAlert):
778         (runJavaScriptConfirm):
779         (runJavaScriptPrompt):
780         (setStatusText):
781         (mouseDidMoveOverElement):
782         (getWindowFrame):
783         (setWindowFrame):
784         (runBeforeUnloadConfirmPanel):
785         (runOpenPanel):
786         (-[WK2BrowserWindowController awakeFromNib]):
787         (-[WK2BrowserWindowController didStartProgress]):
788         (-[WK2BrowserWindowController didChangeProgress:]):
789         (-[WK2BrowserWindowController didFinishProgress]):
790         (-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
791         (-[WK2BrowserWindowController didStartProvisionalLoadForFrame:]):
792         (-[WK2BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
793         (-[WK2BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
794         (-[WK2BrowserWindowController didFailLoadWithErrorForFrame:]):
795         (-[WK2BrowserWindowController didSameDocumentNavigationForFrame:]):
796         (-[WK2BrowserWindowController didCommitLoadForFrame:]):
797         (-[WK2BrowserWindowController loadURLString:]):
798         (-[WK2BrowserWindowController performFindPanelAction:]):
799         (-[WK2BrowserWindowController find:]):
800
801 2012-10-05  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
802
803         [WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
804         https://bugs.webkit.org/show_bug.cgi?id=98524
805
806         Reviewed by Alexey Proskuryakov.
807
808         Add implementation for testRunner.setSerializeHTTPLoads in
809         WebKitTestRunner.
810
811         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
812         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
813         (WTR::InjectedBundle::beginTesting):
814         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
815         (WTR::TestRunner::setSerializeHTTPLoads):
816         (WTR):
817         * WebKitTestRunner/InjectedBundle/TestRunner.h:
818         (TestRunner):
819
820 2012-10-05  Richard Larocque  <rlarocque@chromium.org>
821
822         TestResultsServer does not display sync_integration_tests results
823         https://bugs.webkit.org/show_bug.cgi?id=98551
824
825         Reviewed by Ojan Vafai.
826
827         Allow builders whose name contains "Sync" to pass through the
828         isChromiumWebkitDepsTestRunner filter.
829
830         The test expectations in flakiness_dashboard_unittests.js have been
831         updated to match the new behaviour.
832
833         * TestResultServer/static-dashboards/builders.js:
834         (isChromiumDepsGTestRunner):
835
836 2012-10-05  Roger Fong  <roger_fong@apple.com>
837
838         Tests in webkitpy involving child processes are flaky. 
839         Skipping run_webkit_tests_integrationtest.py.
840         https://bugs.webkit.org/show_bug.cgi?id=98559
841
842         Reviewed by Dirk Pranke.
843
844         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
845         (MainTest.test_verbose_in_child_processes):
846
847 2012-10-05  Zan Dobersek  <zandobersek@gmail.com>
848
849         [Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder
850         https://bugs.webkit.org/show_bug.cgi?id=91009
851
852         Reviewed by Martin Robinson.
853
854         Include libxml2 into the jhbuild module. Version 2.8.0 introduces
855         a more correct (but not completely correct) behavior in the
856         fast/xsl/xslt-missing-namespace-in-xslt.html test.
857
858         * gtk/jhbuild.modules:
859
860 2012-10-05  Rob Buis  <rbuis@rim.com>
861
862         [BlackBerry] Implement TestRunner.setMockDeviceOrientation
863         https://bugs.webkit.org/show_bug.cgi?id=98542
864
865         Reviewed by Antonio Gomes.
866
867         PR 120681
868
869         This fixes tests in fast/dom/DeviceOrientation.
870
871         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
872         (TestRunner::setMockDeviceOrientation):
873
874 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
875
876         [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
877         https://bugs.webkit.org/show_bug.cgi?id=98256
878
879         Reviewed by Kenneth Rohde Christiansen.
880
881         Implement UIClient's focus callbacks for the main page in
882         WebKitTestRunner.
883
884         * WebKitTestRunner/TestController.cpp:
885         (WTR::focus):
886         (WTR::TestController::initialize):
887
888 2012-10-05  Mark Hahnenberg  <mhahnenberg@apple.com>
889
890         JSC should have a way to gather and log Heap memory use and pause times
891         https://bugs.webkit.org/show_bug.cgi?id=98431
892
893         Reviewed by Geoffrey Garen.
894
895         * DumpRenderTree/mac/DumpRenderTree.mm:
896         (main): Added a check as to whether we should dump our JSC Heap statistics on exit.
897
898 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
899
900         [EFL][WK2] Fix mktemp() compilation warning in Minibrowser
901         https://bugs.webkit.org/show_bug.cgi?id=98493
902
903         Reviewed by Kenneth Rohde Christiansen.
904
905         Fix wrong mktemp usage causing a compilation warning
906         in MiniBrowser.
907
908         * MiniBrowser/efl/main.c:
909         (on_download_request):
910
911 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
912
913         [WK2][WKTR] Avoid duplication of UIClient callbacks for main page and other pages
914         https://bugs.webkit.org/show_bug.cgi?id=98503
915
916         Reviewed by Kenneth Rohde Christiansen.
917
918         Avoid the need for duplicating UIClient callbacks for main page
919         and other pages by passing the view as clientInfo
920         for those callbacks.
921
922         Previously, callbacks for the main page were passed the
923         TestController as clientInfo while the callbacks for other pages
924         were passed the PlatformWebView as clientInfo. This was error prone
925         and leads to useless code duplication.
926
927         * WebKitTestRunner/TestController.cpp:
928         (WTR::getWindowFrame):
929         (WTR::setWindowFrame):
930         (WTR::runBeforeUnloadConfirmPanel):
931         (WTR::TestController::createOtherPage):
932         (WTR::TestController::initialize):
933         (WTR::TestController::decidePolicyForNotificationPermissionRequest):
934
935 2012-10-05  Sadrul Habib Chowdhury  <sadrul@chromium.org>
936
937         [chromium] Allow dragging into plugins.
938         https://bugs.webkit.org/show_bug.cgi?id=98277
939
940         Reviewed by Tony Chang.
941
942         Update the TestWebPlugin to receive drag events and print them out.
943
944         * DumpRenderTree/chromium/TestWebPlugin.cpp:
945         (TestWebPlugin::handleDragStatusUpdate):
946         * DumpRenderTree/chromium/TestWebPlugin.h:
947         (TestWebPlugin):
948
949 2012-10-05  Jongseok Yang  <js45.yang@samsung.com>
950
951         [EFL][WK2] Remove "web" word from ewk_web_error APIs
952         https://bugs.webkit.org/show_bug.cgi?id=97886
953
954         Reviewed by Gyuyoung Kim.
955
956         Remove "web" word from ewk_web_error APIs.
957         "web" word was redundant because "ewk" means "EFL WebKit" and WK APIs for error does not have "web" word.
958
959         * MiniBrowser/efl/main.c:
960         (on_error):
961
962 2012-10-05  Csaba Osztrogonác  <ossy@webkit.org>
963
964         [Qt] Enable CSS compositing by default
965         https://bugs.webkit.org/show_bug.cgi?id=98490
966
967         Reviewed by Simon Hausmann.
968
969         * qmake/mkspecs/features/features.pri:
970
971 2012-10-05  Sheriff Bot  <webkit.review.bot@gmail.com>
972
973         Unreviewed, rolling out r130466.
974         http://trac.webkit.org/changeset/130466
975         https://bugs.webkit.org/show_bug.cgi?id=98495
976
977         It made 12 tests crash on Qt-WK2 (Requested by Ossy on
978         #webkit).
979
980         * WebKitTestRunner/TestController.cpp:
981         (WTR::focus):
982         (WTR::TestController::initialize):
983
984 2012-10-05  Christophe Dumez  <christophe.dumez@intel.com>
985
986         [EFL] Fix window resizing / moving in WK1 and WKTR
987         https://bugs.webkit.org/show_bug.cgi?id=98486
988
989         Reviewed by Gyuyoung Kim.
990
991         Fix PlatformWebView::windowFrame() and
992         PlatformWebView::setWindowFrame() in EFL's WKTR so
993         that it resizes / moves the window, not the view.
994
995         The new code matches the implementation in EwkView's
996         UIClient.
997
998         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
999         (WTR::PlatformWebView::windowFrame):
1000         (WTR::PlatformWebView::setWindowFrame):
1001
1002 2012-10-04  KyungTae Kim  <ktf.kim@samsung.com>
1003
1004         [EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser
1005         https://bugs.webkit.org/show_bug.cgi?id=98334
1006
1007         Reviewed by Gyuyoung Kim.
1008
1009         Add callback functions for download requests to Minibrowser to set the destination path for download.
1010         Set the destination path with suggested file name as (destination folder) + (suggested file name).
1011         The 'destination folder' should be a specific folder user selected, but is set to '/tmp' for now.
1012
1013         Additionally, for printing out the download status, 
1014         use the info macro and set the verbose variable to 1 to enable it.
1015
1016         * MiniBrowser/efl/main.c:
1017         (on_download_request):
1018         (on_download_finished):
1019         (on_download_failed):
1020         (browserCreate):
1021
1022 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
1023
1024         [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
1025         https://bugs.webkit.org/show_bug.cgi?id=98256
1026
1027         Reviewed by Kenneth Rohde Christiansen.
1028
1029         Implement UIClient's focus callbacks in WebKitTestRunner.
1030
1031         * WebKitTestRunner/TestController.cpp:
1032         (WTR::focus):
1033         (WTR::TestController::initialize):
1034
1035 2012-10-04  Rik Cabanier  <cabanier@adobe.com>
1036
1037         Turn Compositing on by default in WebKit build
1038         https://bugs.webkit.org/show_bug.cgi?id=98315
1039
1040         Reviewed by Simon Fraser.
1041
1042         enable -webkit-blend-mode on trunk.
1043
1044         * Scripts/webkitperl/FeatureList.pm:
1045
1046 2012-10-04  Ryuan Choi  <ryuan.choi@samsung.com>
1047
1048         [EFL][WK2] Add APIs to get/set the frame flattening.
1049         https://bugs.webkit.org/show_bug.cgi?id=95982
1050
1051         Reviewed by Gyuyoung Kim.
1052
1053         * MiniBrowser/efl/main.c: Added frame flattening option to test.
1054         (browserCreate):
1055         (main):
1056
1057 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
1058
1059         [EFL] Add libxml 2.8.0 to jhbuild
1060         https://bugs.webkit.org/show_bug.cgi?id=98418
1061
1062         Reviewed by Laszlo Gombos.
1063
1064         Add libxml 2.8.0 to EFL's jhbuild for consistency.
1065
1066         * efl/jhbuild.modules:
1067
1068 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
1069
1070         [WK2] Support all attributes of GeolocationPosition
1071         https://bugs.webkit.org/show_bug.cgi?id=98212
1072
1073         Reviewed by Sam Weinig.
1074
1075         Expand WebKitTestRunner and DumpRenderTree to test all the attributes
1076         of GeolocationPosition.
1077
1078         * DumpRenderTree/TestRunner.cpp:
1079         (setMockGeolocationPositionCallback):
1080         * DumpRenderTree/TestRunner.h:
1081         (TestRunner):
1082         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1083         (TestRunner::setMockGeolocationPosition):
1084         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1085         (TestRunner::setMockGeolocationPosition):
1086         * DumpRenderTree/mac/TestRunnerMac.mm:
1087         (TestRunner::setMockGeolocationPosition):
1088         * DumpRenderTree/win/TestRunnerWin.cpp:
1089         (TestRunner::setMockGeolocationPosition):
1090         * DumpRenderTree/wx/TestRunnerWx.cpp:
1091         (TestRunner::setMockGeolocationPosition):
1092         * WebKitTestRunner/GeolocationProviderMock.cpp:
1093         (WTR::GeolocationProviderMock::setPosition):
1094         * WebKitTestRunner/GeolocationProviderMock.h:
1095         (GeolocationProviderMock):
1096         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1097         (_platformTypeVariableDeclaration):
1098         Use a proper constructor for the JSValueRef, it is an opaque type, we are not supposed
1099         to build the pointer outself.
1100         This is necessary to support optional JSValueRef properly.
1101
1102         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1103         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1104         (WTR::InjectedBundle::setMockGeolocationPosition):
1105         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1106         (InjectedBundle):
1107         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1108         (WTR::TestRunner::setMockGeolocationPosition):
1109         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1110         (TestRunner):
1111         * WebKitTestRunner/TestController.cpp:
1112         (WTR::TestController::setMockGeolocationPosition):
1113         * WebKitTestRunner/TestController.h:
1114         (TestController):
1115         * WebKitTestRunner/TestInvocation.cpp:
1116         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1117
1118 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1119
1120         Make the Xvfb driver recognize `X' as a valid X server binary.
1121         https://bugs.webkit.org/show_bug.cgi?id=98434
1122
1123         Reviewed by Dirk Pranke.
1124
1125         The X server binary can also be called `X', so account for that
1126         possibility in the _next_free_display regexp.
1127
1128         Additionally, make the regular expression require at least one
1129         space character after the `ps comm' part.
1130
1131         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1132         (XvfbDriver._next_free_display):
1133         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
1134         (XvfbDriverTest.test_next_free_display):
1135
1136 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1137
1138         webkitpy: Accept WEBKITOUTPUTDIR in Port._setup_environ_for_server.
1139         https://bugs.webkit.org/show_bug.cgi?id=98436
1140
1141         Reviewed by Dirk Pranke.
1142
1143         The Xvfb driver (ab)uses Port._setup_environ_for_server() to set
1144         the environment for the server process, and the WEBKITOUTPUTDIR
1145         environment variable was not being passed through, causing the
1146         build directory to be wrongfully set to WebKitBuild/ all the time.
1147
1148         * Scripts/webkitpy/layout_tests/port/base.py:
1149         (Port.to.setup_environ_for_server):
1150
1151 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
1152
1153         [EFL][WK2] Add setting to allow file access from file:// URLs
1154         https://bugs.webkit.org/show_bug.cgi?id=98121
1155
1156         Reviewed by Laszlo Gombos.
1157
1158         Allow file access from file:// URLs by default in Minibrowser
1159         to facilitate testing.
1160
1161         * MiniBrowser/efl/main.c:
1162         (browserCreate):
1163
1164 2012-10-04  Christophe Dumez  <christophe.dumez@intel.com>
1165
1166         [EFL] Run unit tests with Xvfb
1167         https://bugs.webkit.org/show_bug.cgi?id=98389
1168
1169         Reviewed by Laszlo Gombos.
1170
1171         Run EFL unit tests with Xvfb, similarly to GTK port.
1172
1173         * Scripts/run-efl-tests:
1174
1175 2012-10-04  Adrian Perez de Castro  <aperez@igalia.com>
1176
1177         [GTK] Enable inspector by default in GtkLauncher/MiniBrowser
1178         https://bugs.webkit.org/show_bug.cgi?id=98333
1179
1180         Reviewed by Xan Lopez.
1181
1182         Both MiniBrowser and GtkLauncher are tools for testing, so in
1183         the end every time we want to test the inspector we have to
1184         manually enable enable the “developer extras” setting when using
1185         them. It make sense to have this setting enabled by default.
1186
1187         * GtkLauncher/main.c:
1188         (main):
1189         * MiniBrowser/gtk/main.c:
1190         (main):
1191
1192 2012-10-04  Harald Alvestrand  <hta@google.com>
1193
1194         Change RTCPeerConnection GetStats to use Date timestamp format
1195         https://bugs.webkit.org/show_bug.cgi?id=98263
1196
1197         Reviewed by Yury Semikhatsky.
1198
1199         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1200         (MockWebRTCPeerConnectionHandler::getStats):
1201
1202 2012-10-04  Dirk Pranke  <dpranke@chromium.org>
1203
1204         [NRWT] --skipped option is ignored when --test-list is used
1205         https://bugs.webkit.org/show_bug.cgi?id=98260
1206
1207         Reviewed by Ojan Vafai.
1208
1209         Adds a --skipped=always flag that will skip any tests listed in
1210         TestExpectations even if they're listed explicitly on the
1211         command line.
1212
1213         This is most useful if you are using --test-list to specify a
1214         long list of files but you still want to skip some of them
1215         depending on what's in TestExpectations.
1216
1217         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1218         (LayoutTestFinder.skip_tests):
1219         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1220         (parse_args):
1221         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1222         (MainTest.test_skipped_flag):
1223
1224 2012-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1225
1226         Unreviewed, rolling out r130377.
1227         http://trac.webkit.org/changeset/130377
1228         https://bugs.webkit.org/show_bug.cgi?id=98392
1229
1230         Chromium Win compilation is broken (Requested by yurys on
1231         #webkit).
1232
1233         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1234         (MockWebRTCPeerConnectionHandler::getStats):
1235
1236 2012-10-04  Harald Alvestrand  <hta@google.com>
1237
1238         Change RTCPeerConnection GetStats to use Date timestamp format
1239         https://bugs.webkit.org/show_bug.cgi?id=98263
1240
1241         Reviewed by Adam Barth.
1242
1243         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1244         (MockWebRTCPeerConnectionHandler::getStats):
1245
1246 2012-10-04  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1247
1248         Unreviewed, remove unused $legacyWebKitBlobBuilderSupport variable after r130343.
1249
1250         * Scripts/webkitperl/FeatureList.pm:
1251
1252 2012-10-03  Philip Rogers  <pdr@google.com>
1253
1254         Force GC between PageLoad tests.
1255         https://bugs.webkit.org/show_bug.cgi?id=98203
1256
1257         Reviewed by Ryosuke Niwa.
1258
1259         Previously, our PageLoad PerfTests had multi-modal distributions,
1260         typically with a small cluster at 1-2x the median. This turned out
1261         to be caused by not garbage collecting between tests!
1262
1263         This patch adds a new file, force-gc.html, and loads this file between
1264         PageLoad tests to force a GC. I manually verified that this cleans up
1265         our perf test outliers.
1266
1267         * Scripts/webkitpy/performance_tests/perftest.py:
1268         (PageLoadingPerfTest.__init__):
1269         (PageLoadingPerfTest):
1270         (PageLoadingPerfTest.run_single):
1271
1272             This function now loads two pages: one to force a gc and
1273             then the test to run.
1274
1275         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1276
1277             Modified several existing tests to show that the force-gc file
1278             is loaded.
1279
1280         (MockPort):
1281         (MockPort.__init__):
1282         (MockPort.perf_tests_dir):
1283         (TestPageLoadingPerfTest.MockDriver.__init__):
1284         (TestPageLoadingPerfTest.MockDriver.run_test):
1285         (TestPageLoadingPerfTest.test_run):
1286         (TestPageLoadingPerfTest.test_run_with_bad_output):
1287         (TestReplayPerfTest.ReplayTestPort):
1288         (TestReplayPerfTest.ReplayTestPort.__init__):
1289         (TestReplayPerfTest.test_run_single.run_test):
1290         (TestReplayPerfTest.test_run_single):
1291         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1292         (TestPerfTestFactory.test_regular_test):
1293         (TestPerfTestFactory.test_inspector_test):
1294         (TestPerfTestFactory.test_page_loading_test):
1295
1296 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
1297
1298         [EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
1299         https://bugs.webkit.org/show_bug.cgi?id=98231
1300
1301         Reviewed by Gyuyoung Kim.
1302
1303         Enable use of X11 in DumpRenderTree / WebKitTestRunner.
1304         Call ecore_evas_new() instead of ecore_evas_buffer_new()
1305         in EFL's DumpRenderTree and WebKitTestRunner.
1306         It is safe to do this now that we are using XvfbDriver
1307         for the layout tests.
1308
1309         * DumpRenderTree/efl/DumpRenderTree.cpp:
1310         (parseCommandLineOptions):
1311         (initEcoreEvas):
1312         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1313         (WTR::initEcoreEvas):
1314         * WebKitTestRunner/efl/main.cpp:
1315         (main):
1316
1317 2012-10-03  Dirk Pranke  <dpranke@chromium.org>
1318
1319         run-webkit-tests tests on win32 after r127302
1320         https://bugs.webkit.org/show_bug.cgi?id=98323
1321
1322         Reviewed by Eric Seidel.
1323
1324         run-webkit-tests tests on win32 after r127302
1325         https://bugs.webkit.org/show_bug.cgi?id=98323
1326
1327         Reviewed by Eric Seidel.
1328
1329         Looks like when we converted the json-building logic to use scm
1330         to try and get the svn revision, we missed a win32-ism and
1331         didn't check to make sure had initialized the scm subsystem.
1332
1333         This change fixes that and renames _initialize_scm to be a public method.
1334
1335         * Scripts/webkitpy/common/host.py:
1336         (Host.initialize_scm):
1337         * Scripts/webkitpy/common/host_mock.py:
1338         (MockHost.__init__):
1339         (MockHost.initialize_scm):
1340         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1341         (summarize_results):
1342         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1343         (JSONResultsGeneratorBase.get_json):
1344         (JSONResultsGeneratorBase._get_result_char):
1345         (JSONResultsGeneratorBase._get_svn_revision):
1346         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1347         (PerfTestsRunner.__init__):
1348         * Scripts/webkitpy/style/checkers/test_expectations.py:
1349         (TestExpectationsChecker.__init__):
1350         * Scripts/webkitpy/style/main.py:
1351         (CheckWebKitStyle.main):
1352         * Scripts/webkitpy/tool/main.py:
1353         (WebKitPatch.handle_global_options):
1354         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1355         (get_test_baselines):
1356
1357 2012-10-03  Adrian Perez de Castro  <aperez@igalia.com>
1358
1359         [GTK] Make inspector directly useable in GtkLauncher/MiniBrowser
1360         https://bugs.webkit.org/show_bug.cgi?id=98310
1361
1362         Reviewed by Martin Robinson.
1363
1364         Make MiniBrowser/GtkLauncher define the path to the inspector
1365         resources by setting the WEBKIT_INSPECTOR_PATH environment
1366         variable pointing to the copy of the inspector resources in
1367         the build directory. If the environment variable is already
1368         defined, its value is not overwritten. The path is derived
1369         from the WEBKIT_EXEC_PATH macro defined in the makefiles.
1370
1371         * GNUmakefile.am:
1372         * GtkLauncher/main.c:
1373         (main):
1374         * MiniBrowser/gtk/main.c:
1375         (main):
1376
1377 2012-10-03  Benjamin Poulain  <bpoulain@apple.com>
1378
1379         Fix Geolocation/window-close-crash.html and harden WebKitTestRunner for Geolocation
1380         https://bugs.webkit.org/show_bug.cgi?id=97608
1381
1382         Reviewed by Sam Weinig.
1383
1384         The test fast/dom/Geolocation/window-close-crash.html was crashing because
1385         handleGeolocationPermissionRequest() was executed on the wrong pointer. Depending on how
1386         the page was created, the void* clientInfo can either be a PlatformWebView or
1387         a TestController.
1388
1389         Using the global TestController fixes the issue.
1390
1391         * WebKitTestRunner/GeolocationProviderMock.cpp:
1392         (WTR::GeolocationProviderMock::setPosition):
1393         (WTR::GeolocationProviderMock::setPositionUnavailableError):
1394         To be reliable, the test fast/dom/Geolocation/maximum-age.html needs the setting the position
1395         to clear the error and vice versa.
1396         This is the same behavior as GeolocationClientMock and MockGeolocationProvider of WebKit1.
1397
1398         (WTR::GeolocationProviderMock::sendPositionIfNeeded):
1399         (WTR::GeolocationProviderMock::sendErrorIfNeeded):
1400         Some tests expect the position/error cant be sent multiple time,
1401         just keep the position after sending.
1402
1403         * WebKitTestRunner/TestController.cpp:
1404         (WTR::decidePolicyForGeolocationPermissionRequest):
1405         (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):
1406         * WebKitTestRunner/TestController.h:
1407         Let's play as if we did not know what is in GeolocationPermissionRequestManagerProxy like a real
1408         client would have to do.
1409
1410 2012-10-03  Otto Derek Cheung  <otcheung@rim.com>
1411
1412         [BlackBerry] Implementing the NetworkInfo API for BB port
1413         https://bugs.webkit.org/show_bug.cgi?id=98273
1414
1415         Reviewed by Rob Buis.
1416
1417         Enabling NetworkInfo API for the BlackBerry port.
1418
1419         * Scripts/webkitperl/FeatureList.pm:
1420
1421 2012-10-03  Anders Carlsson  <andersca@apple.com>
1422
1423         Exception thrown when running accessibility/container-node-delete-causes-crash.html test
1424         https://bugs.webkit.org/show_bug.cgi?id=98291
1425
1426         Reviewed by Andreas Kling.
1427
1428         The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree
1429         to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown
1430         when trying to access the children of an element that didn't have any children. Fix this by adding
1431         BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children.
1432
1433         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1434         (findAccessibleObjectById):
1435
1436 2012-10-03  Ojan Vafai  <ojan@chromium.org>
1437
1438         Make partytime work when loading garden-o-matic from trac.webkit.org
1439         https://bugs.webkit.org/show_bug.cgi?id=98283
1440
1441         Reviewed by Adam Barth.
1442
1443         CSP was blocking the reqest for partytime.gif because 'self' wasn't on the img-src directive.
1444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1445
1446 2012-10-03  Roger Fong  <roger_fong@apple.com>
1447
1448         Unreviewed. Adding sys.platform check to skip a failing assert on the Apple Windows platform.
1449         https://bugs.webkit.org/show_bug.cgi?id=98288
1450
1451         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1452         (ChromiumAndroidDriverTest.test_command_from_driver_input):
1453
1454 2012-10-03  Ojan Vafai  <ojan@chromium.org>
1455
1456         Get rid of warning about non-existant platform name when loading garden-o-matic
1457         https://bugs.webkit.org/show_bug.cgi?id=98282
1458
1459         Reviewed by Adam Barth.
1460
1461         If you loaded without a platform query parameter we'd return "null" as the platform name
1462         instead of null.
1463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1465
1466 2012-10-03  Balazs Kelemen  <kbalazs@webkit.org>
1467
1468         [Qt] Enable mock scrollbars
1469         https://bugs.webkit.org/show_bug.cgi?id=98011
1470
1471         Reviewed by Csaba Osztrogonác.
1472
1473         Enable mock scrollbars for the Qt port. This patch will require a huge rebaseline.
1474
1475         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1476         (WebCore::DumpRenderTree::DumpRenderTree):
1477         * WebKitTestRunner/TestController.cpp:
1478         (WTR::TestController::resetStateToConsistentValues):
1479
1480 2012-10-03  Alberto Garcia  <agarcia@igalia.com>
1481
1482         [GTK] [WK2] Add favicon support to the MiniBrowser
1483         https://bugs.webkit.org/show_bug.cgi?id=98063
1484
1485         Reviewed by Carlos Garcia Campos.
1486
1487         Set the icon in the URI text entry using the favicon property of
1488         the WebKitWebView.
1489
1490         * MiniBrowser/gtk/BrowserWindow.c:
1491         (_BrowserWindow):
1492         (updateUriEntryIcon):
1493         (uriEntryTextChanged):
1494         (faviconChanged):
1495         (browserWindowFinalize):
1496         (browser_window_init):
1497         (browserWindowConstructed):
1498
1499 2012-10-03  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1500
1501         [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
1502         https://bugs.webkit.org/show_bug.cgi?id=98200
1503
1504         Reviewed by Csaba Osztrogonác.
1505
1506         * DumpRenderTree/qt/TestRunnerQt.cpp:
1507         (TestRunner::overridePreference):
1508
1509 2012-10-03  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1510
1511         [Qt][WRT] Fix build error with MSVC on Windows.
1512         https://bugs.webkit.org/show_bug.cgi?id=97697
1513
1514         Reviewed by Simon Hausmann.
1515
1516         WTR build is failing when WebKit directory is located on a longer path.
1517         This seems to caused by source files that has the same name in
1518         WTR and DRT directories. The solution is removing referencies 
1519         from Target.pri to DRT directory and adding an alternate version of
1520         the required files to WTR. Those files simply include the real ones from DRT.
1521
1522         * WebKitTestRunner/InjectedBundle/Target.pri:
1523         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Added.
1524         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Added.
1525
1526 2012-10-03  Christophe Dumez  <christophe.dumez@intel.com>
1527
1528         [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
1529         https://bugs.webkit.org/show_bug.cgi?id=98238
1530
1531         Reviewed by Csaba Osztrogonác.
1532
1533         Reset AlwaysAcceptCookies setting between tests to avoid
1534         flakiness due to TestRunner.setAlwaysAcceptCookies().
1535
1536         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1537         (WTR::InjectedBundle::beginTesting):
1538
1539 2012-10-03  Harald Alvestrand  <hta@google.com>
1540
1541         Add data passing to the GetStats interface of RTCPeerConnection
1542         https://bugs.webkit.org/show_bug.cgi?id=98003
1543
1544         Reviewed by Adam Barth.
1545
1546         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1547         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
1548         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
1549         (MockWebRTCPeerConnectionHandler::addStream):
1550         (MockWebRTCPeerConnectionHandler::removeStream):
1551         (MockWebRTCPeerConnectionHandler::getStats):
1552         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
1553         (MockWebRTCPeerConnectionHandler):
1554
1555 == Rolled over to ChangeLog-2012-10-02 ==