[chromium] Unreviewed, update .gitignore to handle VS2010 files.
[WebKit-https.git] / Tools / ChangeLog
1 2012-07-03  Tony Chang  <tony@chromium.org>
2
3         [chromium] Unreviewed, update .gitignore to handle VS2010 files.
4
5         * .gitignore:
6         * DumpRenderTree/DumpRenderTree.gyp/.gitignore:
7         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore:
8
9 2012-07-03  Ojan Vafai  <ojan@chromium.org>
10
11         Have webkit-patch rebaseline use rebaseline-test-internal
12         https://bugs.webkit.org/show_bug.cgi?id=90491
13
14         Reviewed by Dirk Pranke.
15
16         This lets it handle new files, reduces duplicate code and lays the
17         groundwork for making rebaseline have a richer interface.
18
19         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
20         (MockBuild):
21         (MockBuild.__init__):
22         (MockBuilder.build):
23         * Scripts/webkitpy/tool/commands/rebaseline.py:
24         (AbstractParallelRebaselineCommand._files_to_add):
25         (Rebaseline):
26         (Rebaseline._builder_to_pull_from):
27         (Rebaseline._tests_to_update):
28         (Rebaseline.execute):
29         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
30         (test_overrides_are_included_correctly):
31         (test_rebaseline):
32         (test_rebaseline.mock_builder_to_pull_from):
33         (test_rebaseline.mock_tests_to_update):
34
35 2012-07-03  Ojan Vafai  <ojan@chromium.org>
36
37         Rename rebaseline-test to rebaseline-test-internal
38         https://bugs.webkit.org/show_bug.cgi?id=90485
39
40         Reviewed by Adam Barth.
41
42         It's now only used by other rebaseline commands. It's still useful to leave it
43         as it's own command to aid in debugging when something goes wrong. In a followup
44         patch, I'll make webkit-patch rebaseline cover any use-cases that rebaseline-test
45         might have covered.
46
47         We no longer need the --print-scm-changes option since the only caller always passes
48         that option in.
49
50         Also, make all the arguments command-line flags instead. Simplifies the code
51         a bit in my opinion.
52
53         * Scripts/webkitpy/tool/commands/rebaseline.py:
54         (RebaselineTest):
55         (RebaselineTest.__init__):
56         (RebaselineTest.execute):
57         (AbstractParallelRebaselineCommand._rebaseline_commands):
58         (RebaselineExpectations.execute):
59         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
60         (test_rebaseline_all):
61
62 2012-07-03  Balazs Kelemen  <kbalazs@webkit.org>
63
64         [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
65         https://bugs.webkit.org/show_bug.cgi?id=90262
66
67         Unreviewed build fix.
68
69         Reverting r121550 manually because it caused build
70         break on ARM and Mac. It turned out that the Qt build
71         system is too broken for this change now, first we have
72         to address two issues:
73             * symbol hiding was forbidden accidentally on x86 Linux
74             * Qt lacks a separate library for test support
75
76         * Tools.pro:
77         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
78         (WTR::InjectedBundlePage::resetAfterTest):
79         (WTR::InjectedBundlePage::didClearWindowForFrame):
80         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
81
82 2012-07-03  Tony Chang  <tony@chromium.org>
83
84         [chromium] Handle trailing backslash on %VSINSTALLDIR%
85         https://bugs.webkit.org/show_bug.cgi?id=90410
86
87         Reviewed by Ojan Vafai.
88
89         * Scripts/webkitdirs.pm:
90         (buildChromiumVisualStudioProject): Handle VSINSTALLDIR ending in a backslash, the backslash escapes the closing double quote.
91
92 2012-07-02  Ojan Vafai  <ojan@chromium.org>
93
94         Make the skia_test_expectations.txt file optional.
95         https://bugs.webkit.org/show_bug.cgi?id=90400
96
97         Reviewed by Dirk Pranke.
98
99         It used to be optional. This regressed at some point. It's important that it be
100         optional so that webkit-patch commands work in a pure-webkit checkout for chromium bots.
101         Specifically, this was breaking webkit-patch rebaseline-test when it would go to update
102         TestExpectations.
103
104         * Scripts/webkitpy/layout_tests/port/chromium.py:
105         (ChromiumPort.expectations_files):
106         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
107         (ChromiumDriverTest.test_expectations_dict):
108
109 2012-07-03  Raphael Kubo da Costa  <rakuco@webkit.org>
110
111         [jhbuild][EFL] Bump libffi dependency.
112         https://bugs.webkit.org/show_bug.cgi?id=85373
113
114         Reviewed by Gustavo Noronha Silva.
115
116         Update libffi to 3.0.11, which fixes the build on some platforms
117         where 3.0.10 had problems.
118
119         * efl/jhbuild.modules:
120
121 2012-07-03  George Staikos  <staikos@webkit.org>
122
123         [BlackBerry] Enable microdata support for BlackBerry.
124         https://bugs.webkit.org/show_bug.cgi?id=90429
125
126         Reviewed by Rob Buis.
127
128         * Scripts/webkitperl/FeatureList.pm:
129
130 2012-07-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
131
132         [Qt] Make use of .qmake.cache for caching features
133
134         Instead of loading() features from the files that need them (and re-running
135         a bunch of checks), we now run feature detection as part of configure.pro,
136         and have build-webkit write the computed feature-defines and CONFIG to
137         .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
138         when building WebKit.pro.
139
140         At some point we'll be able to selectivly prevent running of config tests
141         in configure.pro, which means we don't need a separate code-path for
142         the build-webkit --help case.
143
144         We should also move the code in build-webkit that now uses .webkit.config
145         to detect clean builds, to use .qmake.cache, since we now store the same
146         thing there.
147
148         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
149
150         Reviewed by Tor Arne Vestbø.
151
152         * DumpRenderTree/qt/DumpRenderTree.pro:
153         * QtTestBrowser/QtTestBrowser.pro:
154         * Scripts/webkitdirs.pm:
155         (qtFeatureDefaults):
156         (buildQMakeProjects):
157         * Tools.pro:
158         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
159         * WebKitTestRunner/InjectedBundle/Target.pri:
160         * WebKitTestRunner/Target.pri:
161         * qmake/.qmake.conf: Added.
162         * qmake/configure.pro:
163         * qmake/mkspecs/features/default_post.prf:
164         * qmake/mkspecs/features/default_pre.prf:
165         * qmake/mkspecs/features/features.prf:
166
167 2012-07-03  Nico Weber  <thakis@chromium.org>
168
169         -Wunused-private-field cleanup, linux edition
170         https://bugs.webkit.org/show_bug.cgi?id=90463
171
172         Reviewed by Stephen White.
173
174         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
175         * DumpRenderTree/chromium/GamepadController.h:
176         (GamepadController):
177         * DumpRenderTree/chromium/NotificationPresenter.h:
178         (NotificationPresenter::NotificationPresenter):
179         (NotificationPresenter):
180
181 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
182
183         Unreviewed, rolling out r121766.
184         http://trac.webkit.org/changeset/121766
185         https://bugs.webkit.org/show_bug.cgi?id=90465
186
187         It caused flakey build errors on the bots (Requested by Ossy
188         on #webkit).
189
190         * DumpRenderTree/qt/DumpRenderTree.pro:
191         * QtTestBrowser/QtTestBrowser.pro:
192         * Scripts/webkitdirs.pm:
193         (qtFeatureDefaults):
194         (buildQMakeProjects):
195         * Tools.pro:
196         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
197         * WebKitTestRunner/InjectedBundle/Target.pri:
198         * WebKitTestRunner/Target.pri:
199         * qmake/.qmake.conf: Removed.
200         * qmake/configure.pro:
201         * qmake/mkspecs/features/default_post.prf:
202         * qmake/mkspecs/features/default_pre.prf:
203         * qmake/mkspecs/features/features.prf:
204
205 2012-07-03  George Staikos  <staikos@webkit.org>
206
207         [BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
208         https://bugs.webkit.org/show_bug.cgi?id=90422
209
210         Reviewed by Rob Buis.
211
212         * Scripts/webkitperl/FeatureList.pm:
213
214 2012-07-03  George Staikos  <staikos@webkit.org>
215
216         [BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
217         https://bugs.webkit.org/show_bug.cgi?id=90422
218
219         Reviewed by Rob Buis.
220
221         * Scripts/webkitperl/FeatureList.pm:
222
223 2012-07-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
224
225         [EFL] Add run API tests as a step on the build bots
226         https://bugs.webkit.org/show_bug.cgi?id=87252
227
228         Reviewed by Daniel Bates.
229
230         Run EFL API test suite on the build bots.
231
232         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
233         (RunEflAPITests):
234         (TestFactory.__init__):
235         (BuildAndTestFactory.__init__):
236         * Scripts/run-efl-tests: Added.
237
238 2012-07-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
239
240         [Qt] Make use of .qmake.cache for caching features
241
242         Instead of loading() features from the files that need them (and re-running
243         a bunch of checks), we now run feature detection as part of configure.pro,
244         and have build-webkit write the computed feature-defines and CONFIG to
245         .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
246         when building WebKit.pro.
247
248         At some point we'll be able to selectivly prevent running of config tests
249         in configure.pro, which means we don't need a separate code-path for
250         the build-webkit --help case.
251
252         We should also move the code in build-webkit that now uses .webkit.config
253         to detect clean builds, to use .qmake.cache, since we now store the same
254         thing there.
255
256         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
257
258         Reviewed by Tor Arne Vestbø.
259
260         * DumpRenderTree/qt/DumpRenderTree.pro:
261         * QtTestBrowser/QtTestBrowser.pro:
262         * Scripts/webkitdirs.pm:
263         (qtFeatureDefaults):
264         (buildQMakeProjects):
265         * Tools.pro:
266         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
267         * WebKitTestRunner/InjectedBundle/Target.pri:
268         * WebKitTestRunner/Target.pri:
269         * qmake/.qmake.conf: Added.
270         * qmake/configure.pro:
271         * qmake/mkspecs/features/default_post.prf:
272         * qmake/mkspecs/features/default_pre.prf:
273         * qmake/mkspecs/features/features.prf:
274
275 2012-07-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>  Joel Dillon <joel.dillon@codethink.co.uk>
276
277         [Qt][Win] Fix broken QtWebKit5.lib linking
278         https://bugs.webkit.org/show_bug.cgi?id=88321
279
280         Reviewed by Kenneth Rohde Christiansen.
281
282         On windows the import/export definition is part of the symbol's signature.
283         Define STATICALLY_LINKED_WITH_$$library for each dependend module
284         that is being linked statically to make sure that they can be linked together
285         later on.
286
287         Also do not compile Assertions.cpp in DumpRenderTree anymore since all the
288         used symbols are exported and it would cause a duplicate symbols error.
289
290         * DumpRenderTree/qt/DumpRenderTree.pro:
291         * qmake/mkspecs/features/default_post.prf:
292
293 2012-07-03  Szilard Ledan  <szledan@inf.u-szeged.hu>
294
295         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
296         https://bugs.webkit.org/show_bug.cgi?id=89001
297
298         Reviewed by Csaba Osztrogonác.
299
300         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
301         (UploadBuiltProduct.__init__):
302         (UploadTestResults.__init__):
303         (ExtractTestResults.__init__):
304         (Factory.__init__):
305         (BuildFactory.__init__):
306         (TestFactory.__init__):
307         (BuildAndTestFactory.__init__):
308         (BuildAndPerfTestFactory.__init__):
309         (BuildAndPerfTestWebKit2Factory.__init__):
310         (DownloadAndPerfTestFactory.__init__):
311
312 2012-07-03  Ádám Kallai  <kadam@inf.u-szeged.hu>
313
314         Update unit test after r121724.
315         https://bugs.webkit.org/show_bug.cgi?id=90444
316
317         Reviewed by Csaba Osztrogonác.
318
319         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
320         (GardeningServerTest.test_rebaseline_new_port):
321
322 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
323
324         Unreviewed, rolling out r121749.
325         http://trac.webkit.org/changeset/121749
326         https://bugs.webkit.org/show_bug.cgi?id=90441
327
328         Tests crash on the paralel NRWT Qt bot (Requested by Ossy on
329         #webkit).
330
331         * Scripts/webkitpy/layout_tests/port/qt.py:
332         (QtPort._build_driver):
333         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
334         (XvfbDriver._start):
335         (XvfbDriver._start.x_filter):
336         (XvfbDriver.stop):
337
338 2012-07-03  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
339
340         [NRWT] XvfbDriver should choose the next free display
341         https://bugs.webkit.org/show_bug.cgi?id=88414
342
343         Reviewed by Dirk Pranke.
344
345         * Scripts/webkitpy/layout_tests/port/qt.py:
346         (QtPort._driver_class):
347         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
348         (XvfbDriver.__init__):
349         (XvfbDriver._start):
350         (XvfbDriver._start.next_free_id):
351         (XvfbDriver.stop):
352
353 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
354
355         [EFL] Enable MICRODATA support
356         https://bugs.webkit.org/show_bug.cgi?id=90377
357
358         Reviewed by Kenneth Rohde Christiansen.
359
360         Turn on MICRODATA flag for EFL port by default.
361
362         * Scripts/webkitperl/FeatureList.pm:
363
364 2012-07-02  George Staikos  <staikos@webkit.org>
365
366         [BlackBerry] Enable scoped style for BlackBerry.
367         https://bugs.webkit.org/show_bug.cgi?id=90418
368
369         Reviewed by Rob Buis.
370
371         * Scripts/webkitperl/FeatureList.pm:
372
373 2012-07-02  Xiaobo Wang  <xbwang@torchmobile.com.cn>
374
375         [BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
376         https://bugs.webkit.org/show_bug.cgi?id=90271
377
378         Reviewed by George Staikos.
379
380         RIM PR #154707
381
382         Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not
383         defined by default.
384         We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't
385         need to rebuild webkit before running DRT.
386
387         * Scripts/webkitdirs.pm:
388         (blackberryCMakeArguments):
389
390 2012-07-02  Ojan Vafai  <ojan@chromium.org>
391
392         webkit-patch rebaseline-expectations should share code with rebaseline-all
393         https://bugs.webkit.org/show_bug.cgi?id=90413
394
395         Reviewed by Dirk Pranke.
396
397         Make them share code. In addition to reducing code duplication this makes
398         rebaseline-expectations considerably faster by rebaselining in parallel.
399
400         * Scripts/webkitpy/tool/commands/rebaseline.py:
401         (AbstractParallelRebaselineCommand):
402         (AbstractParallelRebaselineCommand._run_webkit_patch):
403         (AbstractParallelRebaselineCommand._rebaseline):
404         (RebaselineJson):
405         (RebaselineJson.execute):
406         (RebaselineExpectations):
407         (RebaselineExpectations._update_expectations_file):
408         (RebaselineExpectations._tests_to_rebaseline):
409         (RebaselineExpectations._add_tests_to_rebaseline_for_port):
410         (RebaselineExpectations.execute):
411         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
412         (test_rebaseline_all):
413         (test_rebaseline_expectations.run_in_parallel):
414         (test_rebaseline_expectations):
415
416 2012-07-02  Xiaobo Wang  <xbwang@torchmobile.com.cn>
417
418         [BlackBerry] Update DumpRenderTree to have it work interactively in parallel
419         https://bugs.webkit.org/show_bug.cgi?id=88326
420
421         Reviewed by Rob Buis.
422
423         1. Test name is sent to torch-launcher via PPS message(from host machine).
424            So we get test list by monitoring and receiving PPS message instead of
425            reading file index.drt.
426         2. Torch-launcher create a <test file>.done file when it finished a test.
427         3. We don't need to search for Ref-tests in DumpRenderTree.cpp any more. NRWT
428            will get them for us.
429
430         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
431         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
432         (BlackBerry::WebKit::DumpRenderTree::doneDrt):
433         (BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
434         (BlackBerry::WebKit::DumpRenderTree::ensurePPS):
435         (WebKit):
436         (BlackBerry::WebKit::DumpRenderTree::handlePPSData):
437         (BlackBerry::WebKit::DumpRenderTree::waitForTest):
438         (BlackBerry::WebKit::DumpRenderTree::runTests):
439         (BlackBerry::WebKit::DumpRenderTree::dump):
440         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
441         (DumpRenderTree):
442
443 2012-07-02  Adam Barth  <abarth@webkit.org>
444
445         Remove flashplugin-installer from the EWS image because it causes some tests to crash
446         https://bugs.webkit.org/show_bug.cgi?id=90403
447
448         Reviewed by Tony Chang.
449
450         * EWSTools/cold-boot.sh:
451
452 2012-07-02  Leandro Gracia Gil  <leandrogracia@chromium.org>
453
454         [Chromium] Implement a Layout Test for editing/SurroundingText
455         https://bugs.webkit.org/show_bug.cgi?id=82461
456
457         Reviewed by Ryosuke Niwa.
458
459         Add a new method to the layout test controller in order to retrieve the
460         text surrounding a provided element.
461
462         * DumpRenderTree/chromium/LayoutTestController.cpp:
463         (LayoutTestController::LayoutTestController):
464         (LayoutTestController::textSurroundingElement):
465         * DumpRenderTree/chromium/LayoutTestController.h:
466         (LayoutTestController):
467
468 2012-07-02  Ojan Vafai  <ojan@chromium.org>
469
470         Delete unused rebaseline method in gardeningserver.py
471         https://bugs.webkit.org/show_bug.cgi?id=90396
472
473         Reviewed by Eric Seidel.
474
475         As best I can tell, the only usage was in this unittest.
476
477         * Scripts/webkitpy/tool/servers/gardeningserver.py:
478         (GardeningHTTPRequestHandler.updateexpectations):
479         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
480         (GardeningServerTest.test_rebaseline_new_port):
481
482 2012-07-02  Csaba Osztrogonác  <ossy@webkit.org>
483
484         REGRESSION(r121497): It switched off and broke many unittests
485         https://bugs.webkit.org/show_bug.cgi?id=90371
486
487         Reviewed by Adam Barth.
488
489         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
490         (ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
491         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
492         (ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
493         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
494         (PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.
495
496 2012-07-02  Ojan Vafai  <ojan@chromium.org>
497
498         Move rebaseline-all command from the gardening-server down into webkit-patch
499         https://bugs.webkit.org/show_bug.cgi?id=90395
500
501         Reviewed by Adam Barth.
502
503         This is just moving code. It it in preparation for making rebaseline-expectations
504         use the same code in order to get the parallelism benefits and reduces the amount
505         of code we have for doing rebaselines.
506
507         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
508         (CheckoutTest.test_apply_patch):
509         Updated due to the change to executive_mock.
510         * Scripts/webkitpy/common/system/executive_mock.py:
511         (MockExecutive.run_command):
512         Update to print out the input passed to stdin.
513         * Scripts/webkitpy/tool/commands/download_unittest.py:
514         Updated due to executive_mock change.
515         * Scripts/webkitpy/tool/commands/rebaseline.py:
516         (RebaselineAll):
517         (RebaselineAll._run_webkit_patch):
518         (RebaselineAll._builders_to_fetch_from):
519         (RebaselineAll._rebaseline_commands):
520         (RebaselineAll._files_to_add):
521         (RebaselineAll._optimize_baselines):
522         (RebaselineAll._rebaseline):
523         (RebaselineAll.execute):
524         All this code is just copy-pasted except for mechanical changes
525         (e.g. self.server.tool --> self._tool) and the reading in of the 
526         JSON from stdin instead of the post body.
527         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
528         (test_rebaseline_all):
529         Copied the test-case out of gardeningserver_unittest.py.
530         * Scripts/webkitpy/tool/servers/gardeningserver.py:
531         (GardeningHTTPRequestHandler):
532         (GardeningHTTPRequestHandler.rebaseline):
533         (GardeningHTTPRequestHandler.rebaselineall):
534         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
535         (GardeningServerTest.test_rebaselineall):
536         (GardeningServerTest.test_rebaselineall.run_command):
537
538 2012-07-02  Ojan Vafai  <ojan@chromium.org>
539
540         Remove Leopard support from the flakiness dashboard
541         https://bugs.webkit.org/show_bug.cgi?id=90390
542
543         Reviewed by Adam Barth.
544
545         * TestResultServer/static-dashboards/flakiness_dashboard.js:
546         (nonChromiumPlatform):
547         (chromiumPlatform):
548         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
549         (test):
550         * TestResultServer/static-dashboards/run-embedded-unittests.html:
551         * TestResultServer/static-dashboards/run-unittests.html:
552
553 2012-07-02  Ojan Vafai  <ojan@chromium.org>
554
555         Fix posting from garden-o-matic. This broke in moving away from jquery's ajax method
556         in http://trac.webkit.org/changeset/121617.
557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
558
559 2012-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
560
561         [GTK] Read fonts path when running layout tests from alternative fonts dir when main dir doesn't exist
562         https://bugs.webkit.org/show_bug.cgi?id=89437
563
564         Reviewed by Martin Robinson.
565
566         If main fonts directory doesn't exist, try with an alternative
567         fonts directory at build directory.
568
569         * DumpRenderTree/gtk/DumpRenderTree.cpp:
570         (getOutputDir):
571         (getFontsPath):
572         (initializeFonts):
573         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
574         (WTR::getOutputDir):
575         (WTR):
576         (WTR::getFontsPath):
577         (WTR::inititializeFontConfigSetting):
578
579 2012-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
580
581         [GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild
582         https://bugs.webkit.org/show_bug.cgi?id=89435
583
584         Reviewed by Martin Robinson.
585
586         * Scripts/new-run-webkit-tests: Don't run the tests with the
587         jhbuild wrapper if there isn't a Dependencies directory inside the
588         build directory.
589
590 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
591
592         [Qt] Simplify detection of non-installed module file
593
594         Has the additional advantage that we do not rely on additional information.
595
596         Reviewed by Tor Arne Vestbø.
597
598         * qmake/qt_webkit.pri:
599
600 2012-07-01  Christophe Dumez  <christophe.dumez@intel.com>
601
602         [EFL] Add Gamepad support
603         https://bugs.webkit.org/show_bug.cgi?id=90170
604
605         Reviewed by Kenneth Rohde Christiansen.
606
607         * Scripts/webkitperl/FeatureList.pm: Turn on GAMEPAD flag
608         by default for EFL port.
609         * efl/jhbuild.modules: Bump dependency versions of EFL libs
610         since the latest Eeze is required for gamepad support.
611
612 2012-07-01  Adam Barth  <abarth@webkit.org>
613
614         Unreviewed.
615
616         Using the default start cylinder for fdisk causes a warning about the
617         partition not starting on physical sector boundary.  The Ubuntu forums
618         recommend using a number that's divisible by 8, which is what we do in
619         this patch.
620
621         * EWSTools/cold-boot.sh:
622
623 2012-07-01  Adam Barth  <abarth@webkit.org>
624
625         Unreviewed.
626
627         It turns out we need to use Ubuntu 10.04 to get the right image results
628         for chromium-linux. This patch updates our scripts to be compatible
629         with Ubuntu 10.04.
630
631         * EWSTools/cold-boot.sh:
632             - fdisk doesn't have p and 1 as default commands in 10.04.
633         * EWSTools/start-queue.sh:
634             - git doesn't understanding the -B argument in 10.04. We've been
635               using this change locally on the EC2 bots for a while.
636
637 2012-07-01  Adam Barth  <abarth@webkit.org>
638
639         Unreviewed.
640
641         * EWSTools/boot.sh:
642             - We need to start the screen in detached mode so that we can run
643               it remotely via ssh.
644
645 2012-07-01  Adam Barth  <abarth@webkit.org>
646
647         Unreviewed.
648
649         * EWSTools/cold-boot.sh:
650             - Turns out we need to sudo this command in order for it to
651               actually dimiss the EULA screen. :)
652
653 2012-06-29  Adam Barth  <abarth@webkit.org>
654
655         Turns out we need zip too.
656
657         * EWSTools/cold-boot.sh:
658
659 2012-06-29  Adam Barth  <abarth@webkit.org>
660
661         Add a cold-boot.sh script for the EWS
662         https://bugs.webkit.org/show_bug.cgi?id=90330
663
664         Unreviewed.
665
666         * EWSTools/cold-boot.sh: Added.
667             - This script can take us from a cold GCE instance to a running EWS
668               bot in one fell swoop.
669         * EWSTools/start-queue.sh:
670             - The if-block at the top of this script was causing trouble. I
671               removed it from the bots a while ago. Now that we're using SVN to
672               cold-boot the EWS bots, we need to make this change in the repo.
673
674 2012-06-29  Luiz Agostini  <luiz.agostini@nokia.com>
675
676         [Qt][WK2] Private non-QtQuick API
677         https://bugs.webkit.org/show_bug.cgi?id=84532
678
679         MiniBrowserRaw is an usage example for the QRawWebView API.
680         It is only an example and is not fully implemented.
681
682         Reviewed by Noam Rosenthal.
683
684         * MiniBrowser/qt/raw/DerivedSources.pri: Added.
685         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Added.
686         * MiniBrowser/qt/raw/Target.pri: Added.
687         * MiniBrowser/qt/raw/View.cpp: Added.
688         * MiniBrowser/qt/raw/View.h: Added.
689         * Scripts/webkitpy/style/checker.py:
690         * Tools.pro:
691
692 2012-06-29  Ojan Vafai  <ojan@chromium.org>
693
694         Remove leopard bots from garden-o-matic
695         https://bugs.webkit.org/show_bug.cgi?id=90328
696
697         Reviewed by Adam Barth.
698
699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
702
703 2012-06-29  Ojan Vafai  <ojan@chromium.org>
704
705         garden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url')
706         https://bugs.webkit.org/show_bug.cgi?id=90243
707
708         Reviewed by Dirk Pranke.
709
710         jQuery was trying to be too smart and parsing the jsonp as json because of it's content-type.
711         Excise jQuery and just use XHR directly since it's easier to maintain something where we control it
712         all.
713
714         Not really sure how to unittest this. I tested it all manually of course.
715
716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
717         Made net.ajax a drop-in replacement for the features of $.ajax that we were using.
718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
719         Not related to this patch, but figured I'd update the failing test while I was at it.
720
721 2012-06-29  Yaron Friedman  <yfriedman@chromium.org>
722
723         Fix layout test runner for Android after https://bugs.webkit.org/show_bug.cgi?id=88134
724         https://bugs.webkit.org/show_bug.cgi?id=90309
725
726         Reviewed by Adam Barth.
727
728         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
729         (ChromiumAndroidPort.start_http_server):
730
731 2012-06-29  James Weatherall  <wez@chromium.org>
732
733         NPObjectWrapper may not address all window script object lifetime issues
734         https://bugs.webkit.org/show_bug.cgi?id=85679
735
736         TestNetscapePlugin now has a leak-window-scriptable-object test which takes a reference to the window script object, and a second reference to it via the "self" property, and does not release those references. This is used to simulate a leaky plugin in layout tests of the NPAPI scripting interface glue code.
737
738         Reviewed by Nate Chapin.
739
740         * DumpRenderTree/DumpRenderTree.gypi:
741         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
742         (PluginTest::NPN_GetProperty):
743         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
744         (PluginTest):
745         * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Added.
746         (LeakWindowScriptableObject):
747         (LeakWindowScriptableObject::LeakWindowScriptableObject):
748         (LeakWindowScriptableObject::NPP_New):
749
750 2012-06-29  Dirk Pranke  <dpranke@chromium.org>
751
752         webkitpy: add comment about how determine_full_port_name() works for apple ports, fix -wk2 bug
753         https://bugs.webkit.org/show_bug.cgi?id=90314
754
755         Reviewed by Ojan Vafai.
756
757         Add comments and fix a bug in how we would handle the mac-wk2
758         and win-wk2 port names after confusion around in bug 90312 :).
759
760         * Scripts/webkitpy/layout_tests/port/apple.py:
761         (ApplePort.determine_full_port_name):
762
763 2012-06-29  Dirk Pranke  <dpranke@chromium.org>
764
765         webkitpy: remove support for mac leopard from chromium configurations
766         https://bugs.webkit.org/show_bug.cgi?id=90313
767
768         Reviewed by Tony Chang.
769
770         Google has shipped the last version of Chrome that will support
771         Mac OS 10.5 (Leopard), and we no longer have bots that run this
772         configuration, so we're removing support for it.
773
774         A subsequent change will remove the baselines in platform/chromium-mac-leopard.
775
776         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
777         (BaselineOptimizerTest.test_complex_shadowing):
778         * Scripts/webkitpy/layout_tests/port/builders.py:
779         * Scripts/webkitpy/layout_tests/port/chromium.py:
780         (ChromiumPort):
781         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
782         (ChromiumMacPort):
783         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
784         (ChromiumMacPortTest.test_versions):
785         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
786         (FactoryTest.test_mac):
787         (FactoryTest.test_chromium_mac):
788         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
789         (test_rebaseline_and_copy_test_with_lion_result):
790
791 2012-06-29  Ojan Vafai  <ojan@chromium.org>
792
793         Fix optimize-baselines to not move baselines from win to win-7sp0
794         https://bugs.webkit.org/show_bug.cgi?id=90312
795
796         Reviewed by Dirk Pranke.
797
798         It used to consider win-7sp0 as the common directory for all the Apple
799         windows ports and incorrectly move results out of win.
800
801         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
802         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
803         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
804         (BaselineOptimizerTest.test_common_directory_includes_root):
805
806 2012-06-28  Ojan Vafai  <ojan@chromium.org>
807
808         Fix rebaselining for Qt and Apple ports
809         https://bugs.webkit.org/show_bug.cgi?id=90204
810
811         Reviewed by Dirk Pranke.
812
813         -Apporpriately put wk2 results in the -wk2 directories.
814         -Since Qt and Apple-Win don't have bots that correspond to the
815         platform/qt and platform/win directories, we need to fudge it
816         and always put the results in those directories for those ports.
817
818         * Scripts/webkitpy/layout_tests/port/builders.py:
819         (rebaseline_override_dir):
820         * Scripts/webkitpy/layout_tests/port/factory.py:
821         (_builder_options):
822         Identify webkit2 builders by the WK2 in the builder name.
823         * Scripts/webkitpy/tool/commands/rebaseline.py:
824         (RebaselineTest._baseline_directory):
825         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
826         (TestRebaseline.test_baseline_directory):
827
828 2012-06-29  Zoltan Horvath  <zoltan@webkit.org>
829
830         Add support for --force parameter to run-performance-tests
831         https://bugs.webkit.org/show_bug.cgi?id=90279
832
833         Reviewed by Dirk Pranke.
834
835         It's helpful to be able to run tests from the Skipped list of the performance tests.
836
837         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
838         (PerfTestsRunner._parse_args):
839         (PerfTestsRunner._collect_tests):
840         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Add test.
841         (test_collect_tests_with_skipped_list):
842
843 2012-06-29  Tony Chang  <tony@chromium.org>
844
845         [GTK] Enable CSS grid layout LayoutTests on GTK+
846         https://bugs.webkit.org/show_bug.cgi?id=90226
847
848         Reviewed by Martin Robinson.
849
850         This feature is disabled via Settings by default, but for testing,
851         we enable it using layoutTestController.overridePreferences. Add the
852         necessary plumbing for DRT.
853
854         WTR already works because support was added for Apple Mac earlier.
855
856         * DumpRenderTree/gtk/DumpRenderTree.cpp:
857         (resetDefaultsToConsistentValues): Feature is off by default.
858         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
859         (LayoutTestController::overridePreference): Add handling of WebKitCSSGridLayoutEnabled.
860
861 2012-06-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
862
863         [Qt] Added Qt port for garden-o-matic.
864         https://bugs.webkit.org/show_bug.cgi?id=82719
865
866         Reviewed by Adam Barth.
867
868         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
869         (.):
870
871 2012-06-29  Balazs Kelemen  <kbalazs@webkit.org>
872
873         [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
874         https://bugs.webkit.org/show_bug.cgi?id=90262
875
876         Reviewed by Alexey Proskuryakov.
877
878         Now that we decided to not support v8 in WebKit2
879         we can get rid of using DumpRenderTreeSupportQt
880         in WebKitTestRunner.
881
882         * Tools.pro:
883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
884         (WTR::InjectedBundlePage::resetAfterTest):
885         (WTR::InjectedBundlePage::didClearWindowForFrame):
886         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
887
888 2012-06-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
889
890         Revert r121540, it broke most Qt builds
891
892         * qmake/mkspecs/features/default_post.prf:
893         * qmake/mkspecs/features/functions.prf:
894
895 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
896
897         [Qt] Make build-webkit reject uknown configurations, eg. --profile
898
899         The qmake-based buildsystem doesn't support it.
900
901         Reviewed by Tor Arne Vestbø.
902
903         * Scripts/webkitdirs.pm:
904         (buildQMakeProjects):
905
906 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
907
908         [Qt] Don't add Qt module dependencies in features.prf
909
910         The required dependencies are already added in WebCore.pri.
911
912         Reviewed by Tor Arne Vestbø.
913
914         * qmake/mkspecs/features/features.prf:
915
916 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
917
918         [Qt] Use LIBS_PRIVATE instead of putting dependencies into LIBS
919
920         Reviewed by Tor Arne Vestbø..
921
922         * qmake/mkspecs/features/default_post.prf:
923         * qmake/mkspecs/features/functions.prf:
924
925 2012-06-28  Ryosuke Niwa  <rniwa@webkit.org>
926
927         DOMHTMLCollection::item may return a wrong element after namedItem is called
928         https://bugs.webkit.org/show_bug.cgi?id=90240
929
930         Reviewed by Antti Koivisto.
931
932         Add a WebKit API test since namedItem is not used in the JS/V8 binding code.
933
934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
935         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.html: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html.
936         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm.
937         (TestWebKitAPI::TEST):
938
939 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
940
941         nrwt: remove the 'google-chrome' port code
942         https://bugs.webkit.org/show_bug.cgi?id=88824
943
944         Reviewed by Ojan Vafai.
945
946         NRWT now supports passing additional baseline directories
947         and expectations files on the command line, so there's no need
948         to support the concept of a 'google-chrome' port directly.
949
950         * Scripts/webkitpy/layout_tests/port/base.py:
951         (Port.path_to_test_expectations_file):
952         * Scripts/webkitpy/layout_tests/port/builders.py:
953         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
954         (ChromiumMacPort.__init__):
955         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
956         (ChromiumWinPort.__init__):
957         * Scripts/webkitpy/layout_tests/port/factory.py:
958         (PortFactory):
959         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
960         (FactoryTest.test_win):
961         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Removed.
962         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: Removed.
963
964 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
965
966         nrwt: clean up how arguments are passed to workers
967         https://bugs.webkit.org/show_bug.cgi?id=90126
968
969         Reviewed by Ojan Vafai.
970
971         The way arguments are passed to workers has been crufty. It
972         turns out it can be a lot cleaner via two things:
973         1) using a factory method instead of instantiating objects
974         directly in manager_worker_broker removes the need for passing
975         'worker arguments' to the broker.
976         2) it turns out that since mock hosts and test ports are purely
977         in-memory constructions, they can be pickled and passed to child
978         workers, meaning that the worker no longer needs hacky code to
979         pass the port in a special case or to guess what to do if we
980         don't have a host - all of the test-specific logic can move to
981         the test file, where we can stub out the mock host's
982         port_factory to return the same already-created port when it
983         needs to be shared.
984
985         This change also moves WorkerException to manager_worker_broker.py
986         where it belongs, and removes several useless tests that were
987         just a maintenance burden (and would've needed rewriting when we
988         change the rest of the broker implementation).
989
990         * Scripts/webkitpy/layout_tests/controllers/manager.py:
991         (Manager._run_tests.worker_factory):
992         (Manager._run_tests):
993         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
994         (get):
995         (WorkerException):
996         (AbstractWorker.__init__):
997         (_ManagerConnection.__init__):
998         (_ManagerConnection.start_worker):
999         (_InlineManager.__init__):
1000         (_InlineManager.start_worker):
1001         (_MultiProcessManager._can_pickle_host):
1002         (_MultiProcessManager):
1003         (_MultiProcessManager.start_worker):
1004         (_WorkerConnection.__init__):
1005         (_InlineWorkerConnection.__init__):
1006         (_InlineWorkerConnection.join):
1007         (_InlineWorkerConnection.run):
1008         (_Process.run):
1009         (_MultiProcessWorkerConnection.__init__):
1010         (_MultiProcessWorkerConnection.start):
1011         (_MultiProcessWorkerConnection):
1012         (_MultiProcessWorkerConnection.run):
1013         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1014         (_TestWorker.__init__):
1015         (_TestWorker.run):
1016         (_TestsMixin.test_name):
1017         (_TestsMixin.test_cancel):
1018         (_TestsMixin.test_done):
1019         (_TestsMixin.test_unknown_message):
1020         (InlineBrokerTests.setUp):
1021         (MultiProcessBrokerTests.setUp):
1022         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1023         (Worker.__init__):
1024         (Worker.run):
1025         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Removed.
1026         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1027         (passing_run):
1028         (logging_run):
1029         (run_and_capture):
1030         (MainTest.test_child_processes_2):
1031         (MainTest.test_child_processes_min):
1032         (MainTest.test_exception_raised):
1033         (MainTest.test_keyboard_interrupt):
1034         (MainTest.test_retrying_and_flaky_tests):
1035         (MainTest.test_run_order__inline):
1036
1037 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
1038
1039         nrwt: don't try to catch worker exceptions in run_webkit_tests.__main__
1040         https://bugs.webkit.org/show_bug.cgi?id=90125
1041
1042         Reviewed by Ojan Vafai.
1043
1044         It turns out run_webkit_tests.py wasn't really using
1045         WorkerException and the catch we had for it was pointless. I've
1046         removed the symbol import and moved it to the integration tests
1047         where it is needed. Eventually the definition of the exception
1048         moves to the broker module, and so minimizing the number of
1049         users of it is a good thing.
1050
1051         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1052         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1053         (MainTest.test_exception_raised):
1054
1055 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
1056
1057         nrwt: clean up passing of log messages between processes
1058         https://bugs.webkit.org/show_bug.cgi?id=90123
1059
1060         Reviewed by Ojan Vafai.
1061
1062         It turns out log messages are perfectly picklable by themselves
1063         and contain the process id of the process that generated the
1064         message, so if we just pass the record from the worker to the
1065         manager and call logger.handle() in the manager, everything just
1066         works :).
1067
1068         The change is covered by existing tests.
1069
1070         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1071         (Manager._log_messages):
1072         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1073         (_WorkerLogHandler.emit):
1074         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1075         (MeteredStream.__init__):
1076         (_LogHandler.emit):
1077
1078 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
1079
1080         add a pylint wrapper for linting python code
1081         https://bugs.webkit.org/show_bug.cgi?id=90232
1082
1083         Reviewed by Adam Barth.
1084
1085         Currently we use 'pep8' to check python code in
1086         check-webkit-style. pep8 is fast but simple; pylint is slower
1087         but has much more robust linting capabilities and will catch
1088         variable typos and all sorts of other things. Eventually we
1089         should switch check-webkit-style to use this, but our code is
1090         far from linting now so it needs to be cleaned up first.
1091
1092         This change adds the infrastructure and a wrapper so we can
1093         start doing that.
1094
1095         * Scripts/lint-webkitpy: Added.
1096         * Scripts/webkitpy/pylintrc: Added.
1097         * Scripts/webkitpy/thirdparty/__init__.py:
1098         (AutoinstallImportHook.find_module):
1099         (AutoinstallImportHook._install_pylint):
1100
1101 2012-06-28  Tony Chang  <tony@chromium.org>
1102
1103         [GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
1104         https://bugs.webkit.org/show_bug.cgi?id=90215
1105
1106         Reviewed by Martin Robinson.
1107
1108         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1109         (initializeFonts): Check for WEBKITOUTPUTDIR first.
1110         * Scripts/webkitpy/layout_tests/port/gtk.py:
1111         (GtkPort.setup_environ_for_server): Copy the environment variable to the child process.
1112         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1113         (WTR::inititializeFontConfigSetting): Check for WEBKITOUTPUTDIR first.
1114
1115 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
1116
1117         derive ChromiumPort from WebKitPort in NRWT in order to support skipping tests if symbols are missing
1118         https://bugs.webkit.org/show_bug.cgi?id=89706
1119
1120         Reviewed by Ojan Vafai.
1121
1122         Try again to land the change first landed in r121363. This patch
1123         adds a bunch more tests and reworks the handling of
1124         port-specific default values for --pixel-tests and --time-out-ms
1125         to be more consistent (adding a default_pixel_tests() method,
1126         pushing the webkit default_timeout_ms() value up into base.py,
1127         and overriding it properly in the chromium and apple mac ports.
1128
1129         Also change the logic in
1130         run_webkit_tests._setup_derived_options() to not second-guess
1131         what the port wants the timeout value to be for debug builds;
1132         computing this in two different places led to several bugs.
1133
1134         This change also changes the Chromium unittest ports to derive
1135         from ChromiumPortTestCase instead of PortTestCase, so that we
1136         ensure that we're running the same tests on all port variants
1137         more easily. There's more cleanup that can be done here, but
1138         this is good enough for now
1139
1140         * Scripts/webkitpy/layout_tests/port/base.py:
1141         (Port.default_pixel_tests):
1142         (Port):
1143         (Port.default_timeout_ms):
1144         * Scripts/webkitpy/layout_tests/port/chromium.py:
1145         (ChromiumPort):
1146         (ChromiumPort.__init__):
1147         (ChromiumPort.default_pixel_tests):
1148         (ChromiumPort.default_timeout_ms):
1149         (ChromiumPort.driver_name):
1150         (ChromiumPort._driver_class):
1151         (ChromiumPort._missing_symbol_to_skipped_tests):
1152         (ChromiumPort.skipped_layout_tests):
1153         (ChromiumPort.setup_test_run):
1154         (ChromiumPort._path_to_image_diff):
1155         (ChromiumPort._convert_path):
1156         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1157         (ChromiumAndroidPortTest):
1158         (ChromiumAndroidPortTest.test_expectations_files):
1159         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1160         (ChromiumLinuxPort._modules_to_search_for_symbols):
1161         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1162         (ChromiumLinuxPortTest):
1163         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1164         (ChromiumMacPort._modules_to_search_for_symbols):
1165         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1166         (ChromiumMacPortTest):
1167         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1168         split off from chromium_unittest.
1169         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1170         (ChromiumWinPort._modules_to_search_for_symbols):
1171         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1172         (ChromiumWinTest):
1173         * Scripts/webkitpy/layout_tests/port/mac.py:
1174         (MacPort.default_timeout_ms):
1175         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1176         (MacTest.test_default_timeout_ms):
1177         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1178         (MockDRTPort.start_http_server):
1179         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1180         (PortTestCase.test_default_timeout_ms):
1181         (PortTestCase):
1182         (PortTestCase.test_default_pixel_tests):
1183         * Scripts/webkitpy/layout_tests/port/test.py:
1184         (TestPort.default_pixel_tests):
1185         * Scripts/webkitpy/layout_tests/port/webkit.py:
1186         (WebKitPort._modules_to_search_for_symbols):
1187         (WebKitPort):
1188         (WebKitPort._symbols_string):
1189         (WebKitPort._skipped_tests_for_unsupported_features):
1190         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1191         (TestWebKitPort._symbols_string):
1192         (TestWebKitPort._tests_for_disabled_features):
1193         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1194         (_set_up_derived_options):
1195
1196 2012-06-28  Joshua Bell  <jsbell@chromium.org>
1197
1198         run-bindings-tests should return non-zero exit code on test failure
1199         https://bugs.webkit.org/show_bug.cgi?id=90205
1200
1201         Reviewed by Adam Barth.
1202
1203         * Scripts/run-bindings-tests:
1204         (main):
1205
1206 2012-06-28  Terry Anderson  <tdanderson@chromium.org>
1207
1208         [chromium] Reset the device scale factor to 1 before each test is run
1209         https://bugs.webkit.org/show_bug.cgi?id=90212
1210
1211         Reviewed by Adam Barth.
1212
1213         Some tests change the device scale factor, so this needs to be reset to
1214         1.0 at the start of each test to avoid test flakiness.
1215
1216         * DumpRenderTree/chromium/LayoutTestController.cpp:
1217         (LayoutTestController::reset):
1218
1219 2012-06-28  Ryosuke Niwa  <rniwa@webkit.org>
1220
1221         Cleanup HTMLFormCollection
1222         https://bugs.webkit.org/show_bug.cgi?id=90111
1223
1224         Reviewed by Andreas Kling.
1225
1226         Add a WebKit API test using copy-paste design pattern per kling's request.
1227
1228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1229         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html: Added.
1230         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm: Added.
1231         (-[HTMLFormCollectionNamedItemTest webView:didFinishLoadForFrame:]):
1232         (TestWebKitAPI):
1233         (TestWebKitAPI::TEST):
1234
1235 2012-06-28  Tim Horton  <timothy_horton@apple.com>
1236
1237         [mac] WKTR windows still don't stay off screen sometimes
1238         https://bugs.webkit.org/show_bug.cgi?id=90214
1239         <rdar://problem/11760263>
1240
1241         Reviewed by Simon Fraser.
1242
1243         In some cases, the system itself will consult [WebKitTestRunnerWindow frame], so we should refrain from
1244         overriding it and instead provide a different method to use when we want the web-facing "fake" window origin
1245         (for PlatformWebView::windowFrame()).
1246
1247         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1248         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1249         (WTR::PlatformWebView::windowFrame):
1250
1251 2012-06-28  Martin Robinson  <mrobinson@igalia.com>
1252
1253         [GTK] Add unit tests for GtkInputMethodFilter
1254         https://bugs.webkit.org/show_bug.cgi?id=88698
1255
1256         Reviewed by Carlos Garcia Campos.
1257
1258         Add unit tests for GtkInputMethodFilter in the WebCore platform layer.
1259         This change adds the TestGtk test suite which will be used for all non-API
1260         layer GTK unit tests.
1261
1262         * TestWebKitAPI/GNUmakefile.am: Update the build to include the new tests.
1263         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Added.
1264         (TestWebKitAPI::PlatformWebView::PlatformWebView): Remove the call to gtk_init here
1265         as it's now in main.cpp.
1266         * TestWebKitAPI/gtk/main.cpp: Change the g_type_init call to gtk_init, because now
1267         a majority of all unit tests depend on GTK+ being initialized.
1268
1269 2012-06-28  Christophe Dumez  <christophe.dumez@intel.com>
1270
1271         [EFL] Enable support for HTML5 datalist
1272         https://bugs.webkit.org/show_bug.cgi?id=90157
1273
1274         Reviewed by Martin Robinson.
1275
1276         Turn on DATALIST flag by default on EFL port to
1277         support HTML5 datalist tag.
1278
1279         * Scripts/webkitperl/FeatureList.pm:
1280
1281 2012-06-28  Tony Chang  <tony@chromium.org>
1282
1283         Enable CSS grid layout LayoutTests on platform Mac
1284         https://bugs.webkit.org/show_bug.cgi?id=90113
1285
1286         Reviewed by Ojan Vafai.
1287
1288         * DumpRenderTree/mac/DumpRenderTree.mm:
1289         (resetDefaultsToConsistentValues): Reset the value to NO between tests.
1290
1291 2012-06-28  Mike Fenton  <mifenton@rim.com>
1292
1293         [BlackBerry] Add watchlist options for Blackberry and editing.
1294         https://bugs.webkit.org/show_bug.cgi?id=90193
1295
1296         Unreviewed.
1297
1298         Add BlackBerry and Editing watchlist and monitor them.
1299
1300         * Scripts/webkitpy/common/config/watchlist:
1301
1302 2012-06-28  Tim Horton  <timothy_horton@apple.com>
1303
1304         Unreviewed, upgrade myself to a reviewer!
1305
1306         http://www.webkit.org/blog/2082/tim-horton-is-now-a-webkit-reviewer/
1307
1308         * Scripts/webkitpy/common/config/committers.py:
1309
1310 2012-06-28  Terry Anderson  <tdanderson@chromium.org>
1311
1312         [Chromium] Chromium's LayoutTestController is missing setBackingScaleFactor
1313         https://bugs.webkit.org/show_bug.cgi?id=83635
1314
1315         Reviewed by Adam Barth.
1316
1317         Added InvokeCallbackTask, a new derived class of MethodTask. When
1318         setBackingScaleFactor is called, a call to setDeviceScaleFactor in
1319         WebView is made and then postTask is used to invoke the callback
1320         function specified in testRunner.setBackingScaleFactor. 
1321
1322         * DumpRenderTree/chromium/LayoutTestController.cpp:
1323         (LayoutTestController::LayoutTestController):
1324         (InvokeCallbackTask):
1325         (InvokeCallbackTask::InvokeCallbackTask):
1326         (InvokeCallbackTask::runIfValid):
1327         (LayoutTestController::setBackingScaleFactor):
1328         * DumpRenderTree/chromium/LayoutTestController.h:
1329         (LayoutTestController):
1330
1331 2012-06-28  Ojan Vafai  <ojan@chromium.org>
1332
1333         Make rebaseline-test and rebaseline-expectations work for non-Chromium ports
1334         https://bugs.webkit.org/show_bug.cgi?id=90186
1335
1336         Reviewed by Adam Barth.
1337
1338         This makes rebaselining work for all ports that have a TestExpectations file
1339         in the tree. I didn't test other ports.
1340
1341         This doesn't address 100% of the problem. The rebaseline code puts the expectations
1342         in the most specific directory and relies on optimize-baselines to merge baselines
1343         appropriately. This only works if every platform directory has an equivalent bot
1344         that runs the tests, which is not true for most ports.
1345
1346         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1347         (Builder._revision_and_build_for_filename):
1348         Some bots have filenames that aren't revision/build number pairs
1349         e.g. they are random junk like aQhxvx. Handle this gracefully.
1350         (Builder._fetch_revision_to_build_map):
1351         (Builder._file_info_list_to_revision_to_build_list):
1352         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1353         (BuilderTest.test_build_and_revision_for_filename):
1354         (BuilderTest.test_file_info_list_to_revision_to_build_list):
1355         * Scripts/webkitpy/layout_tests/port/builders.py:
1356         Update the list of builders. This list needs to be kept up
1357         to date for the rebaseline tool to work.
1358         * Scripts/webkitpy/tool/commands/rebaseline.py:
1359         (RebaselineTest._results_url):
1360         (RebaselineExpectations._run_webkit_patch):
1361         (RebaselineExpectations._rebaseline_port):
1362         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1363         Qt port uses qmake to determine the right version. Systems without qmake correctly fallback
1364         to a specific version.
1365
1366 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
1367
1368         [Qt][NRWT] Fix baseline and skipped file search path.
1369         https://bugs.webkit.org/show_bug.cgi?id=89882
1370
1371         Unreviewed trivial typo fix after r121430.
1372
1373         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1374         (QtPortTest._assert_search_path):
1375         (QtPortTest._assert_skipped_path):
1376
1377 2012-06-28  János Badics  <jbadics@inf.u-szeged.hu>
1378
1379         [Qt][NRWT] Fix baseline and skipped file search path.
1380         https://bugs.webkit.org/show_bug.cgi?id=89882
1381
1382         Reviewed by Csaba Osztrogonác.
1383
1384         * Scripts/webkitpy/layout_tests/port/qt.py:
1385         (QtPort._search_paths):
1386         (QtPort):
1387         (QtPort.baseline_search_path):
1388         (QtPort._skipped_file_search_paths):
1389         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1390         (QtPortTest):
1391         (QtPortTest._assert_skipped_path):
1392         (QtPortTest.test_baseline_search_path):
1393         (QtPortTest.test_skipped_file_search_path):
1394
1395 2012-06-28  Alexander Pavlov  <apavlov@chromium.org>
1396
1397         [Qt] inspector/styles/inject-stylesheet.html makes 4 tests flakey (TEXT PASS)
1398         https://bugs.webkit.org/show_bug.cgi?id=90167
1399
1400         Reviewed by Csaba Osztrogonác.
1401
1402         DRT should remove user stylesheets from the page group when resetting before running another test.
1403
1404         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1405         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1406
1407 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
1408
1409         [Qt][DRT] Reset AcceleratedCompositingEnabled between tests
1410         https://bugs.webkit.org/show_bug.cgi?id=90164
1411
1412         Reviewed by Simon Hausmann.
1413
1414         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1415         (WebCore::WebPage::resetSettings):
1416
1417 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
1418
1419         [Qt] Restore original value of mock scrollbars between tests
1420         https://bugs.webkit.org/show_bug.cgi?id=90155
1421
1422         Reviewed by Simon Hausmann.
1423
1424         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1425         (WebCore::WebPage::resetSettings):
1426         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1427         (LayoutTestController::setMockScrollbarsEnabled):
1428         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1429         (LayoutTestController):
1430
1431 2012-06-27  Mark Rowe  <mrowe@apple.com>
1432
1433         <http://webkit.org/b/90096> Building within Xcode sometimes does a full rebuild after building via build-webkit
1434
1435         We need to ensure that build-webkit uses the same setting for SHARED_PRECOMPS_DIR
1436         as what Xcode itself will use when building, otherwise switching between the two
1437         can result in the precompiled headers being rebuilt and thus the entire world
1438         rebuilding.
1439
1440         Reviewed by Dan Bernstein.
1441
1442         * Scripts/webkitdirs.pm:
1443         (determineBaseProductDir):
1444
1445 2012-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1446
1447         Unreviewed, rolling out r121363, r121367, r121384, and
1448         r121390.
1449         http://trac.webkit.org/changeset/121363
1450         http://trac.webkit.org/changeset/121367
1451         http://trac.webkit.org/changeset/121384
1452         http://trac.webkit.org/changeset/121390
1453         https://bugs.webkit.org/show_bug.cgi?id=90134
1454
1455         It broke debug NRWT on GTK and on Qt (Requested by Ossy_NIGHT
1456         on #webkit).
1457
1458         * Scripts/webkitpy/layout_tests/port/chromium.py:
1459         (ChromiumPort):
1460         (ChromiumPort.__init__):
1461         (ChromiumPort._check_file_exists):
1462         (ChromiumPort.default_results_directory):
1463         (ChromiumPort._driver_class):
1464         (ChromiumPort._build_path):
1465         (ChromiumPort._path_to_image_diff):
1466         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1467         (ChromiumLinuxPort.baseline_search_path):
1468         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1469         (ChromiumMacPort.baseline_search_path):
1470         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1471         (ChromiumPortTest):
1472         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1473         (ChromiumWinPort.baseline_search_path):
1474         * Scripts/webkitpy/layout_tests/port/webkit.py:
1475         (WebKitPort.__init__):
1476         (WebKitPort._webcore_symbols_string):
1477         (WebKitPort._skipped_tests_for_unsupported_features):
1478         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1479         (TestWebKitPort._webcore_symbols_string):
1480         (WebKitPortUnitTests.test_default_options):
1481
1482 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
1483
1484         Fix typo in r121384 :(
1485
1486         Unreviewed, build fix.
1487
1488         * Scripts/webkitpy/layout_tests/port/webkit.py:
1489         (WebKitPort.default_test_timeout_ms):
1490
1491 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
1492
1493         nrwt: default timeout for debug bots broke in r121363
1494         https://bugs.webkit.org/show_bug.cgi?id=90112
1495
1496         Unreviewed, build fix.
1497
1498         I forgot to account for release and debug having different
1499         default values :(.
1500
1501         * Scripts/webkitpy/layout_tests/port/chromium.py:
1502         (ChromiumPort.default_test_timeout_ms):
1503         * Scripts/webkitpy/layout_tests/port/webkit.py:
1504         (WebKitPort):
1505         (WebKitPort.default_test_timeout_ms):
1506         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1507         (WebKitPortUnitTests.test_default_options):
1508
1509 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
1510
1511         webkitpy: fix a couple of issues running under cygwin
1512         https://bugs.webkit.org/show_bug.cgi?id=90035
1513
1514         Reviewed by Eric Seidel.
1515
1516         These were causing unit tests to fail on cygwin (apple win bot).
1517
1518         * Scripts/webkitpy/layout_tests/port/chromium.py:
1519         * Scripts/webkitpy/performance_tests/perftest.py:
1520
1521 2012-06-27  Adam Barth  <abarth@webkit.org>
1522
1523         [Chromium] DumpRenderTree on Android should call SkUseTestFontConfigFile once available
1524         https://bugs.webkit.org/show_bug.cgi?id=89801
1525
1526         Reviewed by Nate Chapin.
1527
1528         Let's call SkUseTestFontConfigFile now that it exists.
1529
1530         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1531         (platformInit):
1532
1533 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
1534
1535         Fix typo introduced in r121363.
1536
1537         Unreviewed, build fix.
1538
1539         * Scripts/webkitpy/layout_tests/port/webkit.py:
1540         (WebKitPort._symbols_string):
1541
1542 2012-06-27  Mark Hahnenberg  <mhahnenberg@apple.com>
1543
1544         Moving from committers to reviewers :-)
1545
1546         Rubber stamped by Filip Pizlo.
1547
1548         * Scripts/webkitpy/common/config/committers.py:
1549
1550 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
1551
1552         Derive ChromiumPort from WebKitPort to add support for missing symbols to skip tests
1553         https://bugs.webkit.org/show_bug.cgi?id=89706
1554
1555         Reviewed by Adam Barth.
1556
1557         Based on the original patch by Raymond Toy.
1558
1559         This patch changes ChromiumPort to derive from webkit.WebKitPort
1560         instead of base.Port. This is a long-awaited change and a
1561         precursor to merging base.Port and webkit.WebKitPort, but is
1562         driven by the desire to dynamically detect whether the MP3 and
1563         AAC codecs are compiled into DRT on Chromium, for which we
1564         wanted to re-use the existing logic in WebKit port for determine
1565         what to skip at compile time.
1566
1567         Most of the changes are shuffling things around so that we don't
1568         change any other logic and so we override the necessary methods
1569         in WebKitPort (and try to follow the same method definition
1570         order where possible).
1571
1572         Also, on the Chromium port the mp3 and aac codecs are actually
1573         defined in a separate library, so scanning webcore isn't
1574         sufficient. This patch generalizes the symbol lookup to handle
1575         multiple libraries, and uses different libraries as appropriate
1576         for Chromium.
1577
1578         The only functional/visible changes should be in the value
1579         returned for skipped_layout_tests().
1580
1581         * Scripts/webkitpy/layout_tests/port/chromium.py:
1582         (ChromiumPort):
1583         (ChromiumPort.__init__):
1584         (ChromiumPort.driver_name):
1585         (ChromiumPort._driver_class):
1586         (ChromiumPort._missing_symbol_to_skipped_tests):
1587         (ChromiumPort.skipped_layout_tests):
1588         (ChromiumPort.setup_test_run):
1589         (ChromiumPort._path_to_image_diff):
1590         (ChromiumPort._convert_path):
1591         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1592         (ChromiumPortTest.test_missing_symbol_to_skipped_tests):
1593         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1594         (ChromiumLinuxPort._modules_to_search_for_symbols):
1595         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1596         (ChromiumLinuxPort._modules_to_search_for_symbols):
1597         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1598         (ChromiumLinuxPort._modules_to_search_for_symbols):
1599         * Scripts/webkitpy/layout_tests/port/webkit.py:
1600         (WebKitPort):
1601         (WebKitPort.__init__):
1602         (WebKitPort._symbols_string):
1603         (WebKitPort._modules_to_search_for_symbols):
1604
1605 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
1606
1607         [Qt] REGRESSION(r121339): It broke the build on the Qt Windows bots
1608         https://bugs.webkit.org/show_bug.cgi?id=90081
1609
1610         Buildfix for Qt 4.8 Windows. Use the former path for Qt 4.8, and the newer one for Qt 5.
1611
1612         Reviewed by Noam Rosenthal.
1613
1614         * qmake/mkspecs/features/features.prf:
1615
1616 2012-06-27  Sergio Villar Senin  <svillar@igalia.com>
1617
1618         [WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
1619         https://bugs.webkit.org/show_bug.cgi?id=90061
1620
1621         Reviewed by Gustavo Noronha Silva.
1622
1623         Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
1624         this flag libtool tells the linker to set the rpath for the output
1625         file to the full path of the .libs directory, instead of using a
1626         wrapper script to set up the LD_LIBRARY_PATH. This will allow us
1627         to directly reuse builds in the pure testing bots.
1628
1629         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
1630
1631 2012-06-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1632
1633         [Qt] No need to save and restore TEMPLATE in a function
1634
1635         This was a leftover from when the logic was not in its own function scope.
1636
1637         QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
1638         will surprisingly affect the global scope as well, so we have to save and restore it.
1639
1640         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
1641
1642         Reviewed by Tor Arne Vestbø.
1643
1644         * qmake/mkspecs/features/functions.prf:
1645
1646 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
1647
1648         [Qt] Fix lookup location for sqlite sources
1649
1650         Don't look in the install dir - we are unlikely to find anything there
1651         unless we are doing a developer build.
1652
1653         Reviewed by Tor Arne Vestbø.
1654
1655         * qmake/mkspecs/features/features.prf:
1656
1657 2012-06-27  Zan Dobersek  <zandobersek@gmail.com>
1658
1659         [Gtk] Add support for the Gamepad API
1660         https://bugs.webkit.org/show_bug.cgi?id=87503
1661
1662         Reviewed by Carlos Garcia Campos.
1663
1664         Enable the gamepad support for the GTK port.
1665
1666         * Scripts/webkitperl/FeatureList.pm:
1667
1668 2012-06-27  Ryosuke Niwa  <rniwa@webkit.org>
1669
1670         Fix gcc build after r121302
1671         https://bugs.webkit.org/show_bug.cgi?id=90055
1672
1673         Reviewed by Mark Rowe.
1674
1675         Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.
1676
1677         It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.
1678
1679         * TestWebKitAPI/Configurations/Base.xcconfig:
1680         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1681         (TestWebKitAPI::AcceptsFirstMouse::runTest):
1682
1683 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
1684
1685         Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
1686         https://bugs.webkit.org/show_bug.cgi?id=89564
1687
1688         Reviewed by Tony Chang.
1689
1690         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1691         (BuildStepsConstructorTest):
1692         (BuildStepsConstructorTest.generateTests):
1693         (BuildStepsConstructorTest.createTest):
1694         (BuildStepsConstructorTest.createTest.doTest):
1695
1696 2012-06-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1697
1698         Add support for preciseTime() to WebKitTestRunner
1699         https://bugs.webkit.org/show_bug.cgi?id=90027
1700
1701         Reviewed by Darin Adler.
1702
1703         It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
1704
1705         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1706         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 
1707         (WTR::LayoutTestController::preciseTime): 
1708         (WTR):
1709         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1710         (LayoutTestController):
1711
1712 2012-06-26  Lucas Forschler  <lforschler@apple.com>
1713
1714       Teach the Apple port how to build the test tools in build-webkit
1715       https://bugs.webkit.org/show_bug.cgi?id=89540
1716
1717       Reviewed by Jon Lee & Simon Fraser.
1718
1719       * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1720       (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
1721       (RunUnitTests.start): ditto
1722       * Scripts/build-webkit: add tools to the projects build list
1723
1724 2012-06-26  Ojan Vafai  <ojan@chromium.org>
1725
1726         Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
1727         https://bugs.webkit.org/show_bug.cgi?id=90025
1728
1729         Reviewed by Simon Fraser.
1730
1731         Move the chromium-specific filtering code into config.js and replace it with a method on each platform
1732         config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).
1733
1734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1736         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1737
1738 2012-06-26  Ojan Vafai  <ojan@chromium.org>
1739
1740         Fix failing garden-o-matic unittests
1741         https://bugs.webkit.org/show_bug.cgi?id=90021
1742
1743         Reviewed by Adam Barth.
1744
1745         These had all just fallen out of date.
1746
1747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1748         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1750
1751 2012-06-26  Ojan Vafai  <ojan@chromium.org>
1752
1753         Fix platform picker change handler in garden-o-matic
1754         https://bugs.webkit.org/show_bug.cgi?id=90010
1755
1756         Reviewed by Simon Fraser.
1757
1758         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1759         The old code never worked. This is hard to test because change handlers require
1760         a user-initiated action and the code is changing the window's location, which would
1761         navigate the test page.
1762
1763         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1764         Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
1765         due to the large margin-bottom.
1766
1767 2012-06-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1768
1769         webkitpy: Make webkit-patch patches-to-review useful
1770         https://bugs.webkit.org/show_bug.cgi?id=89470
1771
1772         Reviewed by Eric Seidel.
1773
1774         webkit-patch patches-to-review will now output the list of
1775         bugs with patches pending for review that has the user on CC,
1776         excluding patches with cq-, sorted by the age of the patch.
1777
1778         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1779         (BugzillaQueries.fetch_bugs_from_review_queue):
1780         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1781         (MockBugzillaQueries.fetch_bugs_from_review_queue):
1782         (MockBugzilla.__init__):
1783         (MockBugzilla.authenticate):
1784         * Scripts/webkitpy/tool/commands/queries.py:
1785         (PatchesToReview):
1786         (PatchesToReview.__init__):
1787         (PatchesToReview._print_report):
1788         (PatchesToReview._generate_report):
1789         (PatchesToReview.execute):
1790         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1791         (QueryCommandsTest.test_patches_to_review):
1792
1793 2012-06-26  Dirk Pranke  <dpranke@chromium.org>
1794
1795         nrwt: broken for chromium on vista
1796         https://bugs.webkit.org/show_bug.cgi?id=89988
1797
1798         Reviewed by Tony Chang.
1799
1800         r121194 removed support for 'chromium-win-vista' as a separate
1801         port, but this actually prevented the code from running on vista
1802         at all, which is unduly harsh and broke the websocket tests on
1803         the (non-webkit) chromium bots that are still running on vista.
1804
1805         It's probably good enough to pretend that vista is win7 instead;
1806         some layout tests will still fail but at least things'll run.
1807
1808         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1809         (ChromiumWinPort.determine_full_port_name):
1810         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1811         (ChromiumWinTest.test_versions):
1812
1813 2012-06-26  Csaba Osztrogonác  <ossy@webkit.org>
1814
1815         master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
1816         https://bugs.webkit.org/show_bug.cgi?id=89215
1817
1818         We need it because it is deprecated and will be dropped in buildbot 0.8.7
1819
1820         Reviewed by Tony Chang.
1821
1822         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1823         (CheckOutSource.__init__):
1824         (Factory.__init__):
1825
1826 2012-06-26  Simon Hausmann  <simon.hausmann@nokia.com>
1827
1828         [Qt][Win] Symbols are not exported in QtWebKit5.dll
1829         https://bugs.webkit.org/show_bug.cgi?id=88873
1830
1831         Reviewed by Tor Arne Vestbø.
1832
1833         When linking the target dll make sure to re-export the symbols from
1834         the static libraries marked as export, with the help of a little python
1835         script and a qmake extra compiler.
1836
1837         * Scripts/generate-win32-export-forwards: Added.
1838         * qmake/mkspecs/features/win32/default_post.prf:
1839
1840 2012-06-25  Jocelyn Turcotte  <turcotte.j@gmail.com>
1841
1842         Add a note about hostname completion not working well with --cc completion
1843
1844         Reviewed by Simon Hausmann.
1845
1846         Hostname completion tries to resolve anything after an @ sign which is present
1847         in the completed list of contributor emails to CC.
1848
1849         * Scripts/webkit-tools-completion.sh:
1850
1851 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1852
1853         Unreviewed, rolling out r121244.
1854         http://trac.webkit.org/changeset/121244
1855         https://bugs.webkit.org/show_bug.cgi?id=89966
1856
1857         skip list path is incorrect now. (Requested by Ossy on
1858         #webkit).
1859
1860         * Scripts/webkitpy/layout_tests/port/qt.py:
1861         (QtPort.baseline_search_path):
1862         (QtPort._skipped_file_search_paths):
1863         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1864         (QtPortTest.test_baseline_search_path):
1865
1866 2012-06-26  János Badics  <jbadics@inf.u-szeged.hu>
1867
1868         [Qt][NRWT] Fix baseline and skipped file search path.
1869         https://bugs.webkit.org/show_bug.cgi?id=89882
1870
1871         Reviewed by Csaba Osztrogonác.
1872
1873         * Scripts/webkitpy/layout_tests/port/qt.py:
1874         (QtPort.baseline_search_path):
1875         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1876         (QtPortTest.test_baseline_search_path):
1877
1878 2012-06-26  Tony Chang  <tony@chromium.org>
1879
1880         [Qt] Enable grid layout LayoutTests
1881         https://bugs.webkit.org/show_bug.cgi?id=89909
1882
1883         Reviewed by Csaba Osztrogonác.
1884
1885         These tests pass, we just need to hook up the overridePreference.
1886
1887         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1888         (WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
1889         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1890         (LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.
1891
1892 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1893
1894         Unreviewed, rolling out r121236.
1895         http://trac.webkit.org/changeset/121236
1896         https://bugs.webkit.org/show_bug.cgi?id=89956
1897
1898         It's broke the nrwt on qt and gtk platform (Requested by
1899         kkristof on #webkit).
1900
1901         * Scripts/webkitpy/layout_tests/port/qt.py:
1902         (QtPort._build_driver):
1903         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1904         (XvfbDriver._start):
1905         (XvfbDriver._start.x_filter):
1906         (XvfbDriver.stop):
1907
1908 2012-06-26  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1909
1910         [NRWT] XvfbDriver should choose the next free display
1911         https://bugs.webkit.org/show_bug.cgi?id=88414
1912
1913         Reviewed by Dirk Pranke.
1914
1915         * Scripts/webkitpy/layout_tests/port/qt.py:
1916         (QtPort._driver_class):
1917         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1918         (XvfbDriver.__init__):
1919         (XvfbDriver._start):
1920         (XvfbDriver._start.next_free_id):
1921         (XvfbDriver.stop):
1922
1923 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
1924
1925         [Qt] Make it possible to build WebKit without QtWidgets
1926         https://bugs.webkit.org/show_bug.cgi?id=78109
1927
1928         Reviewed by Tor Arne Vestbø.
1929
1930         * Tools.pro: Disable various tools that depend on WK1.
1931         * qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
1932         * qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
1933         * qmake/mkspecs/modules/webkit1.prf: Added.
1934
1935 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
1936
1937         put vista back for chromium (non-webkit) bots ...
1938         https://bugs.webkit.org/show_bug.cgi?id=89929
1939
1940         Unreviewed, build fix.
1941
1942         Turns out we've only gotten rid of vista on the webkit tests so
1943         far. Put vista back for the other chromium bots ...
1944
1945         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1946         (chromiumPlatform):
1947         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1948         (test):
1949
1950 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
1951
1952         update flakiness dashboard after removing chromium-vista bots
1953         https://bugs.webkit.org/show_bug.cgi?id=89925
1954
1955         Unreviewed, build fix.
1956
1957         More changes missed in r121194 :(.
1958
1959         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1960         (chromiumPlatform):
1961         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1962         (test):
1963
1964 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
1965
1966         remove support for chromium vista from tools
1967         https://bugs.webkit.org/show_bug.cgi?id=89915
1968
1969         Reviewed by Tony Chang.
1970
1971         This change is all deleting code and updating tests to handle
1972         the configuration being gone. All tests now pass except for a
1973         few unittests for the flakiness dashboard which were failing
1974         before this patch.
1975
1976         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1977         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1980         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1981         (BaselineOptimizerTest.test_complex_shadowing):
1982         * Scripts/webkitpy/layout_tests/port/builders.py:
1983         * Scripts/webkitpy/layout_tests/port/chromium.py:
1984         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1985         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1986         (ChromiumWinPort):
1987         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1988         (ChromiumWinTest.test_versions):
1989         (ChromiumWinTest.test_baseline_path):
1990         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1991         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1992         (BuildCoverageExtrapolatorTest.test_extrapolate):
1993
1994 2012-06-25  Scott Graham  <scottmg@chromium.org>
1995
1996         [Chromium] add empty impl of WebThemeEngine::getSize() for DRT
1997         https://bugs.webkit.org/show_bug.cgi?id=89907
1998
1999         Not reviewed. Fix build in Chromium.
2000
2001         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2002         (WebThemeEngineDRTWin::getSize):
2003         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2004         (WebThemeEngineDRTWin):
2005
2006 2012-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2007
2008         [EFL] Implement Network Information API
2009         https://bugs.webkit.org/show_bug.cgi?id=87067
2010
2011         Reviewed by Kenneth Rohde Christiansen.
2012
2013         * efl/jhbuild.modules: Add eeze library dependency.
2014
2015 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
2016
2017         [Qt] Fix Win32 debug build
2018
2019         Reviewed by Tor Arne Vestbø.
2020
2021         Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
2022
2023         * qmake/mkspecs/features/unix/default_pre.prf:
2024         * qmake/mkspecs/features/win32/default_pre.prf: Added.
2025
2026 2012-06-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2027
2028         [Qt] Enable <input type="color"> support by default
2029         https://bugs.webkit.org/show_bug.cgi?id=89653
2030
2031         Reviewed by Kenneth Rohde Christiansen.
2032
2033         This feature is complete for Qt WebKit2. Enabling by default
2034         will help to mature the implementation.
2035
2036         * Scripts/webkitperl/FeatureList.pm:
2037         * qmake/mkspecs/features/features.pri:
2038
2039 2012-06-24  Dan Bernstein  <mitz@apple.com>
2040
2041         Made debug-{minibrowser,safari,test-runner} work with LLDB.
2042
2043         Reviewed by Sam Weinig.
2044
2045         * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to
2046         printHelpAndExitForRunAndDebugWebKitAppIfNeeded().
2047         * Scripts/debug-safari: Ditto.
2048         * Scripts/debug-test-runner: Ditto.
2049         * Scripts/webkitdirs.pm:
2050         (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger.
2051         (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present,
2052         and to "gdb" otherwise.
2053         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the
2054         --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING.
2055         (execMacWebKitAppForDebugging): Changed to use the chosen debugger.
2056
2057 2012-06-24  Adam Barth  <abarth@webkit.org>
2058
2059         [Chromium] Release media resources after each LayoutTest on Android
2060         https://bugs.webkit.org/show_bug.cgi?id=89720
2061
2062         Reviewed by Eric Carlson.
2063
2064         The LayoutTests can hang when run on Android because we sometimes run
2065         out of media resources. This patch causes us to release our media
2066         resources after each test in order to avoid running out of this
2067         resource. In production, there are other mechanisms that manage this
2068         resource.
2069
2070         * DumpRenderTree/chromium/TestShell.cpp:
2071         (TestShell::resetTestController):
2072
2073 2012-06-23  Zan Dobersek  <zandobersek@gmail.com>
2074
2075         [Gtk] REGRESSION(r120918): Causes flaky DND tests
2076         https://bugs.webkit.org/show_bug.cgi?id=89770
2077
2078         Reviewed by Martin Robinson.
2079
2080         Connect to the run-file-chooser signal of the WebKitWebView and
2081         return TRUE so no file chooser dialog is run. This prevents certain
2082         test failures.
2083
2084         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2085         (webViewRunFileChooser):
2086         (createWebView):
2087
2088 2012-06-23  Dan Bernstein  <mitz@apple.com>
2089
2090         debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin.
2091
2092         Reviewed by Sam Weinig.
2093
2094         * Scripts/webkitdirs.pm:
2095         (execMacWebKitAppForDebugging): Use xcrun to locate gdb.
2096
2097 2012-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2098
2099         Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide.
2100
2101         It fails always when running it in Xvfb.
2102
2103         * gtk/run-api-tests:
2104         (TestRunner):
2105
2106 2012-06-23  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
2107
2108         [GTK][WK2]Mis-spelt defaultWindowTitle
2109         https://bugs.webkit.org/show_bug.cgi?id=89808
2110
2111         Reviewed by Carlos Garcia Campos.
2112
2113         * MiniBrowser/gtk/BrowserWindow.c:
2114
2115 2012-06-23  Sergio Villar Senin  <svillar@igalia.com>
2116
2117         [GTK] Add a new webkit2 tests slave bot
2118         https://bugs.webkit.org/show_bug.cgi?id=89336
2119
2120         Reviewed by Csaba Osztrogonác.
2121
2122         Slave configuration for a new GTK 64 bit release bot that will run
2123         WebKit2 tests.
2124
2125         Also BuildAndTest now accepts the "triggers" parametter,
2126         this means that apart from building and testing it can trigger
2127         some other build/test sequences in other slaves.
2128
2129         * BuildSlaveSupport/build.webkit.org-config/config.json:
2130         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2131         (BuildAndTestFactory.__init__):
2132
2133 2012-06-23  Kwang Yul Seo  <skyul@company100.net>
2134
2135         Unreviewed. Update my email.
2136
2137         * Scripts/webkitpy/common/config/committers.py:
2138
2139 2012-06-22  Adam Barth  <abarth@webkit.org>
2140
2141         [Chromium] DumpRenderTree on Android needs to configure fonts for testing
2142         https://bugs.webkit.org/show_bug.cgi?id=89721
2143
2144         Reviewed by Nate Chapin.
2145
2146         This patch teaches DumpRenderTree to configure Skia to use the fallback
2147         fonts that the LayoutTests assume. This patch reduces the number result
2148         differences between chromium-android and chromium-linux.
2149
2150         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2151         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2152         (platformInit):
2153         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added.
2154         * DumpRenderTree/chromium/android_main_fonts.xml: Added.
2155         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2156
2157 2012-06-22  Alexandru Chiculita  <achicu@adobe.com>
2158
2159         [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
2160         https://bugs.webkit.org/show_bug.cgi?id=89781
2161
2162         Reviewed by Dean Jackson.
2163
2164         Added CSS Shaders as enabled by default on Safari for Mac.
2165
2166         * Scripts/webkitperl/FeatureList.pm:
2167
2168 2012-06-22  Adam Barth  <abarth@webkit.org>
2169
2170         Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch
2171         https://bugs.webkit.org/show_bug.cgi?id=89791
2172
2173         Reviewed by Dirk Pranke.
2174
2175         Downstream, the chromium-android port maintains a test expectations
2176         file to keep track of which tests pass or fail. That causes them to
2177         keep a patch in chromium_android.py in their branch.
2178
2179         This patch teaches chromium_android.py to use test_expectations_android.txt.
2180         We don't intend to use this file upstream, but having this code patch
2181         upstream lets us unfork webkitpy.
2182
2183         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2184         (ChromiumAndroidPort.expectations_files):
2185
2186 2012-06-22  Dirk Pranke  <dpranke@chromium.org>
2187
2188         run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
2189         https://bugs.webkit.org/show_bug.cgi?id=89734
2190
2191         Reviewed by Ryosuke Niwa.
2192
2193         Fix a crash in ServerProcess if you called .pid() after it
2194         crashed during a write(). We had a test for this case but the
2195         test wasn't calling pid(), just has_crashed(). Fixed the problem
2196         and the test.
2197
2198         * Scripts/webkitpy/layout_tests/port/server_process.py:
2199         (ServerProcess.__init__):
2200         (ServerProcess.pid):
2201         (ServerProcess._start):
2202         (ServerProcess.stop):
2203         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2204         (FakeServerProcess._start):
2205         (TestServerProcess.test_broken_pipe):
2206
2207 2012-06-22  Peter Beverloo  <peter@chromium.org>
2208
2209         [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
2210         https://bugs.webkit.org/show_bug.cgi?id=88853
2211
2212         Reviewed by Steve Block.
2213
2214         The Android exclusions were necessary to fix a gyp generation error, as
2215         the gcc_version variable wasn't being defined for Android. Remove these
2216         exceptions when Chromium is able to define the gcc_version variable.
2217
2218         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2219
2220 2012-06-22  Mario Sanchez Prada  <msanchez@igalia.com>
2221
2222         Unreviewed gardening. Unskipping test passing after fixing bug 88419.
2223
2224         * gtk/run-api-tests:
2225         (TestRunner): Unskip WTF.HashMap.
2226
2227 2012-06-22  Zoltan Horvath  <zoltan@webkit.org>
2228
2229         [Qt] Allow DumpRenderTree to dump about:blank
2230         https://bugs.webkit.org/show_bug.cgi?id=89685
2231
2232         Reviewed by Ryosuke Niwa.
2233
2234         We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports,
2235         additionaly this behavior is required for running WTR performance tests.
2236
2237         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2238         (WebCore::DumpRenderTree::processLine):
2239
2240 2012-06-21  Adam Barth  <abarth@webkit.org>
2241
2242         [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test
2243         https://bugs.webkit.org/show_bug.cgi?id=89718
2244
2245         Reviewed by Kent Tamura.
2246
2247         We should reset this WebSetting to its default value so that it behaves
2248         consistently across tests.
2249
2250         * DumpRenderTree/chromium/WebPreferences.cpp:
2251         (WebPreferences::reset):
2252         (WebPreferences::applyTo):
2253         * DumpRenderTree/chromium/WebPreferences.h:
2254         (WebPreferences):
2255
2256 2012-06-21  Zoltan Horvath  <zoltan@webkit.org>
2257
2258         DRT/WTR python interface handles about:blank incorrectly
2259         https://bugs.webkit.org/show_bug.cgi?id=89563
2260
2261         Reviewed by Dirk Pranke.
2262
2263         Currently DRT/WTR python interface's _command_from_driver_input function
2264         puts the test directory path before about:blank. Remove this incorrect behavior.
2265
2266         * Scripts/webkitpy/layout_tests/port/webkit.py:
2267         (WebKitDriver._command_from_driver_input):
2268
2269 2012-06-21  Dirk Pranke  <dpranke@chromium.org>
2270
2271         reenable perf tests on win
2272         https://bugs.webkit.org/show_bug.cgi?id=89690
2273
2274         Reviewed by Ryosuke Niwa.
2275
2276         Only the replay tests don't work, and those are disabled by
2277         default. This change also fixes the undefined _log reference
2278         that was causing a crash.
2279
2280         * Scripts/run-perf-tests:
2281
2282 2012-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2283
2284         Unreviewed, rolling out r120937.
2285         http://trac.webkit.org/changeset/120937
2286         https://bugs.webkit.org/show_bug.cgi?id=89679
2287
2288         This patch brought buildbot master down (Requested by svillar
2289         on #webkit).
2290
2291         * BuildSlaveSupport/build.webkit.org-config/config.json:
2292
2293 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
2294
2295         [GTK] Combine WebKit API tests into fewer binaries
2296         https://bugs.webkit.org/show_bug.cgi?id=88458
2297
2298         Reviewed by Carlos Garcia Campos.
2299
2300         Instead of creating one binary per-test file, create binaries for each
2301         category of tests. Right now this includes WTF and the WebKit2 C API,
2302         but later tests can be added for the GTK+ platform layer and the WebKit1
2303         and WebKit2 API layers.
2304
2305         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
2306           C API and one for WTF. Refresh the source list to ensure that new test are active.
2307         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
2308         concept of skipping a test and skipping a suite (program) of tests. Test cases are
2309         skipped because of legitimate failures, but entire programs are skipped because of
2310         problems in the harness. As of right now a test program is only skipped if the
2311         accessibility bus cannot be started.
2312         (SkippedTest.__init__): Make the test case a required argument and have one skipped
2313         test case per SkippedTest instance.
2314         (SkippedTest.__str__): Ditto.
2315         (TestRunner): Update the directory list. We only have two gtest binaries now and they are
2316         in one directory. Reformat the test list to make it slightly easier to read.
2317         (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
2318         test programs that are skipped.
2319         (TestRunner._setup_testing_environment): Use the new member.
2320         (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
2321         the first SkippedTest that matches.
2322         (TestRunner._should_run_test_program): Take a look at the new member to make this
2323         decision.
2324         (TestRunner._run_test_command): Use the name test_program instead of test
2325         to disambiguate between test cases and test suites.
2326         (TestRunner._run_test_glib): ditto.
2327         (TestRunner._run_test_google): Ditto.
2328         (TestRunner._run_test): Ditto.
2329         (TestRunner.run_tests): Ditto.
2330
2331 2012-06-21  Yong Li  <yoli@rim.com>
2332
2333         Unreviewed. Moving myself from committer to reviewer.
2334
2335         * Scripts/webkitpy/common/config/committers.py:
2336
2337 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
2338
2339         [GTK] Add a new webkit2 tests slave bot
2340         https://bugs.webkit.org/show_bug.cgi?id=89336
2341
2342         Reviewed by Philippe Normand.
2343
2344         Slave configuration for a new GTK bot that will run WebKit2 tests.
2345
2346         * BuildSlaveSupport/build.webkit.org-config/config.json:
2347
2348 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2349
2350         [Qt] Add a custom Color Chooser widget to MiniBrowser
2351         https://bugs.webkit.org/show_bug.cgi?id=87988
2352
2353         Reviewed by Alexis Menard.
2354
2355         Added custom color chooser example for the MiniBrowser.
2356
2357         * MiniBrowser/qt/MiniBrowser.qrc:
2358         * MiniBrowser/qt/qml/BrowserWindow.qml:
2359         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
2360
2361 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
2362
2363         Remove the warning "File not found" in MiniBrowser post-build event
2364         https://bugs.webkit.org/show_bug.cgi?id=89601
2365
2366         Reviewed by Adam Roben.
2367
2368         * MiniBrowser/MiniBrowserPostBuild.cmd:
2369
2370 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
2371
2372         [Qt] DRT in standalone mode hangs after the first test
2373         https://bugs.webkit.org/show_bug.cgi?id=89613
2374
2375         Reviewed by Csaba Osztrogonác.
2376
2377         Break an inline signal slot chain that ends up in setting
2378         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
2379         we emit done() which starts the chain that finishes in DumpRenderTree::open().
2380         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
2381         these two lines but it seems to be wrong in general to start the next load
2382         from this call chain. The server mode (when DRT is runned by the test harness)
2383         also uses a queued connection to read the next test from stdin.
2384
2385         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2386         (WebCore::DumpRenderTree::processArgsLine):
2387
2388 2012-06-20  Hans Wennborg  <hans@chromium.org>
2389
2390         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
2391         https://bugs.webkit.org/show_bug.cgi?id=89217
2392
2393         Reviewed by Adam Barth.
2394
2395         Add a method for checking whether the mock speech
2396         recognition was aborted.
2397
2398         Also redo the way the mock posts tasks. Instead of posting them all at once,
2399         maintain an internal queue of task objects, and call postTask() for them
2400         once at the time. This means that for example when the page is navigated
2401         away and abort() is called, that call doesn't end up after a bunch
2402         of previously posted events on the event loop.
2403
2404         * DumpRenderTree/chromium/LayoutTestController.cpp:
2405         (LayoutTestController::LayoutTestController):
2406         (LayoutTestController::wasMockSpeechRecognitionAborted):
2407         * DumpRenderTree/chromium/LayoutTestController.h:
2408         (LayoutTestController):
2409         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2410         (WebKit::ClientCallTask::ClientCallTask):
2411         (WebKit::ResultTask::ResultTask):
2412         (WebKit::NoMatchTask::NoMatchTask):
2413         (WebKit::ErrorTask::ErrorTask):
2414         (MockWebSpeechRecognizer::start):
2415         (MockWebSpeechRecognizer::abort):
2416         (MockWebSpeechRecognizer::setError):
2417         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
2418         (MockWebSpeechRecognizer::startTaskQueue):
2419         (MockWebSpeechRecognizer::StepTask::runIfValid):
2420         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
2421         (MockWebSpeechRecognizer::hasBeenAborted):
2422         (MockWebSpeechRecognizer):
2423         (MockWebSpeechRecognizer::taskList):
2424         (Task):
2425         (MockWebSpeechRecognizer::Task::Task):
2426         (MockWebSpeechRecognizer::Task::~Task):
2427         (StepTask):
2428         (MockWebSpeechRecognizer::StepTask::StepTask):
2429
2430 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
2431
2432         [GTK] Add support for window.showModalDialog in WebKit2GTK+
2433         https://bugs.webkit.org/show_bug.cgi?id=79500
2434
2435         Reviewed by Carlos Garcia Campos.
2436
2437         Add support for modal dialogs in GTK's MiniBrowser.
2438
2439         * MiniBrowser/gtk/BrowserWindow.c:
2440         (webViewRunAsModal):
2441         (webViewCreate):
2442         (webViewDecidePolicy):
2443         (browser_window_new):
2444         * MiniBrowser/gtk/BrowserWindow.h:
2445         * MiniBrowser/gtk/main.c:
2446         (createBrowserWindow):
2447
2448 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
2449
2450         [WinCairo] Unreviewed build fix.
2451         The wrapper script that launched new- and old-run-webkit-tests
2452         was discarding the --wincairo argument needed to get the proper
2453         test infrastructure to build under WinCairo.
2454
2455         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
2456         behavior to chain the --wincairo flag through to the new build
2457         and test scripts.
2458
2459 2012-06-20  Mark Rowe  <mrowe@apple.com>
2460
2461         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
2462
2463         Reviewed by Dan Bernstein.
2464
2465         * Scripts/webkitdirs.pm:
2466         (executableHasEntitlements):
2467         (safariPathFromSafariBundle):
2468
2469 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2470
2471         Unreviewed, rolling out r120821.
2472         http://trac.webkit.org/changeset/120821
2473         https://bugs.webkit.org/show_bug.cgi?id=89605
2474
2475         It made duplicated reviewer entries (Requested by Ossy on
2476         #webkit).
2477
2478         * Scripts/webkitpy/common/checkout/changelog.py:
2479         (ChangeLog.set_reviewer):
2480         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2481         (test_set_reviewer):
2482         (test_set_short_description_and_bug_url):
2483
2484 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
2485
2486         nrwt outputs empty files for wdiff output if wdiff is not installed
2487         https://bugs.webkit.org/show_bug.cgi?id=88709
2488
2489         Reviewed by Tony Chang.
2490
2491         Reviewed by Tony Chang.
2492
2493         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
2494         aren't available, and clean up the handling for them in the port
2495         code.
2496
2497         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
2498         (MainTest.test_output_diffs):
2499         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2500         (TestResultWriter.create_text_diff_and_write_result):
2501         * Scripts/webkitpy/layout_tests/port/base.py:
2502         (Port.check_pretty_patch):
2503         (Port.check_wdiff):
2504         (Port._wdiff_missing_message):
2505         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2506         (ChromiumLinuxPort.check_build):
2507         (ChromiumLinuxPort._wdiff_missing_message):
2508         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2509         (ChromiumMacPort.check_build):
2510         (ChromiumMacPort):
2511         (ChromiumMacPort._wdiff_missing_message):
2512         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2513         (ChromiumMacPortTest):
2514
2515 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
2516
2517         nrwt: fix unit tests for ensuring svn revision is correct
2518         https://bugs.webkit.org/show_bug.cgi?id=89498
2519
2520         Reviewed by Eric Seidel.
2521
2522         Reviewed by Eric Seidel.
2523
2524         Fix the unit tests for testing that we are embedding the SVN
2525         revision in the results json for NRWT properly; this was broken
2526         in r120646 but because the MockHost worked differently than the
2527         real one (by always initializing the MockSCM object) we didn't
2528         notice. Unfortunately, just changing the default breaks all
2529         sorts of unit tests ...
2530
2531         * Scripts/webkitpy/common/host_mock.py:
2532         (MockHost.__init__):
2533         (MockHost._initialize_scm):
2534         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2535         (ResultSummaryTest.test_no_svn_revision):
2536         (ResultSummaryTest.test_svn_revision):
2537
2538 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
2539
2540         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
2541         https://bugs.webkit.org/show_bug.cgi?id=69360
2542
2543         Reviewed by Eric Seidel.
2544
2545         Reviewed by Eric Seidel.
2546
2547         Propagate the 'port_implementation' part of the platform (i.e.,
2548         gtk,qt,chromium) to webkit-build-directory so that we can pick
2549         up the gtk-specific handling of WEBKITOUTPUTDIR ...
2550
2551         I didn't write any additional tests for this; testing it
2552         properly is an integration test between the python code and the
2553         perl code, which I verified by hand.
2554
2555         * Scripts/webkitpy/layout_tests/port/base.py:
2556         (Port.__init__):
2557         * Scripts/webkitpy/layout_tests/port/config.py:
2558         (Config.__init__):
2559         (Config.build_directory):
2560         * Scripts/webkitpy/layout_tests/port/config_mock.py:
2561         (MockConfig.__init__):
2562         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2563         (ConfigTest.test_build_directory_passes_port_implementation):
2564
2565 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
2566
2567         Fix import sorting missed in r120846
2568
2569         Reviewed by Tony Chang.
2570
2571         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2572
2573 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
2574
2575         Fix chromium win http servers after breakage introduced in r120846.
2576
2577         Unreviewed, build fix.
2578
2579         * Scripts/webkitpy/layout_tests/port/base.py:
2580         (Port.to.start_http_server):
2581         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2582         (Lighttpd.__init__):
2583
2584 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
2585
2586         tweak output of webkit-patch print-{baselines,expectations}
2587         https://bugs.webkit.org/show_bug.cgi?id=89588
2588
2589         Reviewed by Tony Chang.
2590
2591         Minor tweaks to the output to make it more readable, including
2592         turning off csv by default for print-baselines with multiple ports.
2593
2594         * Scripts/webkitpy/layout_tests/port/test.py:
2595         (TestPort):
2596         * Scripts/webkitpy/tool/commands/queries.py:
2597         (PrintExpectations.execute):
2598         (PrintBaselines.execute):
2599         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2600         (PrintExpectationsTest.run_test):
2601         (PrintExpectationsTest.test_multiple):
2602         (PrintBaselinesTest.setUp):
2603         (PrintBaselinesTest.test_multiple):
2604
2605 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
2606
2607         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
2608         https://bugs.webkit.org/show_bug.cgi?id=88134
2609
2610         Reviewed by Tony Chang.
2611
2612         Change NRWT to spin up 2*min(child_processes, locked_shards)
2613         http servers by default so that we are less likely to get a
2614         bunch of http timeouts at the beginning of a test run.
2615
2616         Note that I had to tweak executive_mock to support mocked stderr
2617         because the apache_http_server code reads stderr when starting a
2618         process to ensure it started okay.
2619
2620         * Scripts/webkitpy/common/system/executive_mock.py:
2621         (MockProcess.__init__):
2622         * Scripts/webkitpy/common/system/outputcapture.py:
2623         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2624         (Manager._run_tests):
2625         (Manager.start_servers_with_lock):
2626         * Scripts/webkitpy/layout_tests/port/base.py:
2627         (Port.to.start_http_server):
2628         * Scripts/webkitpy/layout_tests/port/test.py:
2629         (TestPort.start_http_server):
2630         (TestPort._path_to_apache):
2631         (TestPort):
2632         (TestPort._path_to_apache_config_file):
2633         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2634         (LayoutTestApacheHttpd.__init__):
2635         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
2636         (LayoutTestApacheHttpd.__init__):
2637         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2638         (Lighttpd.__init__):
2639         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2640         (HttpServerBase.__init__):
2641
2642 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
2643
2644         Unreviewed: Back out accidentally checked in debug print which broke a test
2645
2646         * Scripts/webkitpy/performance_tests/perftest.py:
2647         (PerfTest.parse_output):
2648
2649 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
2650
2651         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
2652         https://bugs.webkit.org/show_bug.cgi?id=78789
2653
2654         Reviewed by Ryosuke Niwa.
2655
2656         Updated parser to include fps as a valid unit.
2657
2658         * Scripts/webkitpy/performance_tests/perftest.py:
2659         (PerfTest):
2660         (PerfTest.parse_output):
2661
2662 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
2663
2664         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
2665         https://bugs.webkit.org/show_bug.cgi?id=67935
2666
2667         Reviewed by Ryosuke Niwa.
2668
2669         * Scripts/webkitpy/common/checkout/changelog.py:
2670         (ChangeLog.set_reviewer):
2671         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2672         (test_set_reviewer):
2673         (test_set_short_description_and_bug_url):
2674
2675 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
2676
2677         Unreviewed trivial permissions fix.
2678
2679         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
2680
2681 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
2682
2683         [EFL][Regression] Build break after r120786
2684         https://bugs.webkit.org/show_bug.cgi?id=89549
2685
2686         Unreviewed build fix for Efl port.
2687
2688         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
2689
2690 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
2691
2692         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
2693         https://bugs.webkit.org/show_bug.cgi?id=64489
2694
2695         Reviewed by Tony Chang.
2696
2697         This change changes NRWT so that we don't start the websocket
2698         server if we aren't running websocket tests and don't start the
2699         HTTP server if we aren't running http tests.
2700         
2701         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2702         (Manager._websocket_tests):
2703         (Manager.start_servers_with_lock):
2704         (Manager.stop_servers_with_lock):
2705         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2706         (ManagerTest.test_servers_started):
2707
2708 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
2709
2710         test-webkitpy: add a -p flag to pass through captured output to enable debugging
2711         https://bugs.webkit.org/show_bug.cgi?id=89158
2712
2713         Reviewed by Eric Seidel.
2714
2715         Normally when outputcapture runs it intercepts stdout/stderr,
2716         which makes running under the debugger difficult and mostly
2717         pointless (since you can't see any output). This change adds a
2718         flag to test-webkitpy (-p) that will cause outputcapture to pass
2719         through the output as well as capture it.
2720
2721         * Scripts/webkitpy/common/system/outputcapture.py:
2722         (OutputCapture.stream_wrapper):
2723         (OutputCapture._capture_output_with_name):
2724         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2725         (OutputCaptureTest.setUp):
2726         * Scripts/webkitpy/test/main.py:
2727         (Tester._parse_args):
2728         (Tester._run_tests):
2729         (Tester._log_exception):
2730         (_CaptureAndPassThroughStream):
2731         (_CaptureAndPassThroughStream.__init__):
2732         (_CaptureAndPassThroughStream.write):
2733         (_CaptureAndPassThroughStream._message_is_from_pdb):
2734         (_CaptureAndPassThroughStream.flush):
2735         (_CaptureAndPassThroughStream.getvalue):
2736
2737 2012-06-19  Adam Barth  <abarth@webkit.org>
2738
2739         garden-o-matic fails to rebaseline tests with MISSING results
2740         https://bugs.webkit.org/show_bug.cgi?id=89521
2741
2742         Reviewed by Kenneth Russell.
2743
2744         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
2745
2746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2747
2748 2012-06-19  Adam Barth  <abarth@webkit.org>
2749
2750         svn.delete_list fails to delete empty parent directories
2751         https://bugs.webkit.org/show_bug.cgi?id=89520
2752
2753         Reviewed by Dirk Pranke.
2754
2755         These functions were calling scm.delete and scm.add, which already
2756         delete the parent directory. We'd get an exception when we tried to
2757         delete the parent directory again.
2758
2759         * Scripts/webkitpy/common/checkout/scm/svn.py:
2760         (SVN._add_parent_directories):
2761         (SVN._delete_parent_directories):
2762
2763 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2764
2765         webkitpy: Simplify fetch_bugs_matching_search()
2766         https://bugs.webkit.org/show_bug.cgi?id=89497
2767
2768         Reviewed by Adam Barth.
2769
2770         Removed parameter with default value. It's not being used
2771         and the handling of the parameter was wrong. Saves a check.
2772
2773         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2774         (BugzillaQueries.fetch_bugs_matching_search):
2775         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2776         (MockBugzillaQueries.fetch_bugs_matching_search):
2777
2778 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
2779
2780         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
2781         https://bugs.webkit.org/show_bug.cgi?id=89522
2782
2783         Reviewed by Eric Seidel.
2784
2785         They were no longer being used. No tests necessary.
2786
2787         * Scripts/webkitpy/layout_tests/port/chromium.py:
2788
2789 2012-06-19  Adam Barth  <abarth@webkit.org>
2790
2791         Missing results aren't shown in garden-o-matic
2792
2793         Reviewed by Kenneth Russell.
2794
2795         Previously we didn't know to look for text and image results when the
2796         bot told us that results were missing.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2799
2800 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
2801
2802         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
2803
2804         Unreviewed, build fix.
2805
2806         It turns out that we store the svn revision two different ways
2807         in the JSON, and I only caught one of them :(. This should fix
2808         the other.
2809
2810         Also, this part of the code is poorly tested. I will investigate
2811         adding at least a basic test for this in a separate fix.
2812
2813         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2814         (summarize_results):
2815
2816 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
2817
2818         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
2819         https://bugs.webkit.org/show_bug.cgi?id=78127
2820
2821         Reviewed by Ryosuke Niwa.
2822
2823         Add the --add-platform-exceptions flag from ORWT, and ensure
2824         that --new-baseline is equivalent to --reset-results
2825         --add-platform-exceptions. Also fix the default logic for where to
2826         put PNGs and render tree dumps if --new-test-results is true:
2827         if --add-platform-exceptions is False, baselines should go in
2828         the least-specific platform directory (e.g., platform/mac)
2829         rather than the most-specific (platform/mac-snowleopard).
2830
2831         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2832         (SingleTestRunner):
2833         (SingleTestRunner.run):
2834         (SingleTestRunner._run_rebaseline):
2835         (SingleTestRunner._add_missing_baselines):
2836         (SingleTestRunner._location_for_new_baseline):
2837         (SingleTestRunner._overwrite_baselines):
2838         (SingleTestRunner._save_baseline_data):
2839         * Scripts/webkitpy/layout_tests/port/base.py:
2840         (Port.baseline_path):
2841         (Port):
2842         (Port.baseline_platform_dir):
2843         (Port.baseline_version_dir):
2844         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2845         (_set_up_derived_options):
2846         (parse_args):
2847         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2848         (RebaselineTest.assertBaselines):
2849         (RebaselineTest.test_reset_results):
2850         (RebaselineTest.test_missing_results):
2851         (RebaselineTest.test_new_baseline):
2852
2853 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
2854
2855         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
2856         https://bugs.webkit.org/show_bug.cgi?id=81379
2857
2858         Reviewed by Eric Seidel.
2859
2860         The 'free memory' calculation we were running on the mac seemed
2861         to underestimate how many children we can run in parallel, and
2862         it was complex. This patch replaces that calculation with a
2863         simpler one that reserves 2GB for overhead and assumes 256MB per
2864         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
2865
2866         Also, there was a bug where we were truncating the memory
2867         installed on the machine to 4GB by casting to an int instead of
2868         a long; this was probably the source of some of the earlier
2869         problems when using total memory.
2870
2871         This patch also removes the no-longer-needed restrictions on the
2872         number of workers on beefy Lion boxes for both Apple Mac and Chromium
2873         Mac; we should now use all of the cores by default.
2874
2875         The memory calculations have only been implemented on the mac;
2876         having the calculation in base.default_child_processes() was IMO
2877         misleading, and so this patch also moves the computation into
2878         the MacPort. I have not heard of the # of workers being an issue
2879         on any other ports, so this should be fine.
2880
2881         * Scripts/webkitpy/common/system/platforminfo.py:
2882         (PlatformInfo.total_bytes_memory):
2883         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2884         (PlatformInfo.total_bytes_memory):
2885         (PlatformInfo.total_bytes_memory):
2886         (PlatformInfo._win_version_tuple_from_cmd):
2887         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2888         (TestPlatformInfo.test_total_bytes_memory):
2889         * Scripts/webkitpy/layout_tests/port/base.py:
2890         (Port.default_child_processes):
2891         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2892         (PortTest.test_default_child_processes):
2893         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2894         (ChromiumMacPort.operating_system):
2895         * Scripts/webkitpy/layout_tests/port/mac.py:
2896         (MacPort.default_child_processes):
2897         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2898         (TestMacPort.test_default_child_processes):
2899
2900 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
2901
2902         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
2903         https://bugs.webkit.org/show_bug.cgi?id=85446
2904
2905         Reviewed by Simon Fraser.
2906
2907         Embed whether pixel testing was enabled into the results.json.
2908
2909         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2910         (summarize_results):
2911
2912 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
2913
2914         [Qt] Modify HTTPS port to 8443 for performance tests
2915         https://bugs.webkit.org/show_bug.cgi?id=89442
2916
2917         Reviewed by Ryosuke Niwa.
2918
2919         We should be consistent with the default HTTPS port and with the changelog of r119188.
2920
2921         * Scripts/webkitpy/performance_tests/perftest.py:
2922         (ReplayServer.__init__):
2923
2924 2012-06-19  Mike West  <mkwst@chromium.org>
2925
2926         Introduce ENABLE_CSP_NEXT configuration flag.
2927         https://bugs.webkit.org/show_bug.cgi?id=89300
2928
2929         Reviewed by Adam Barth.
2930
2931         The 1.0 draft of the Content Security Policy spec is just about to
2932         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
2933         this ENABLE flag, disabled by default.
2934
2935         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
2936
2937         * Scripts/webkitperl/FeatureList.pm:
2938         * qmake/mkspecs/features/features.pri:
2939
2940 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
2941
2942         [EFL] EFL's LayoutTestController does not support setTextDirection
2943         https://bugs.webkit.org/show_bug.cgi?id=87481
2944
2945         Reviewed by Hajime Morita.
2946
2947         Implement setTextDirection in EFL's LayoutTestController and
2948         properly reset its value between test cases to avoid flakiness.
2949
2950         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2951         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2952         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2953         (LayoutTestController::setTextDirection):
2954
2955 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2956
2957         [Qt] Temporarily disable xvfb driver in nrwt
2958         https://bugs.webkit.org/show_bug.cgi?id=88414
2959
2960         Reviewed by Csaba Osztrogonác.
2961
2962         * Scripts/webkitpy/layout_tests/port/qt.py:
2963         (QtPort._build_driver):
2964
2965 2012-06-18  Joone Hur  <joone.hur@intel.com>
2966
2967         [EFL] Fontconfig can't be linked properly
2968         https://bugs.webkit.org/show_bug.cgi?id=89418
2969
2970         Unreviewed build fix.
2971
2972         Make Fontconfig be linked correctly.
2973
2974         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
2975
2976 2012-06-18  Joone Hur  <joone.hur@intel.com>
2977
2978         Unreviewed. Updating email for committers.py script.
2979
2980         * Scripts/webkitpy/common/config/committers.py:
2981
2982 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
2983
2984         Fix a typo that caused TestFailures to have a syntax error.
2985         
2986         Sadly TestFailures is broken for another reason now too:
2987         https://bugs.webkit.org/show_bug.cgi?id=89419
2988
2989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
2990         (ViewController.prototype._domForBuildName):
2991
2992 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
2993
2994         Provide bug links for suspicious commits
2995         https://bugs.webkit.org/show_bug.cgi?id=89408
2996         
2997         Reviewed by Adam Barth.
2998
2999         Add links to bugs for the suspicious commits if we have bug data.
3000
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3004         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
3005         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
3006
3007 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
3008
3009         [Chromium] DeviceOrientation Cleanup
3010         https://bugs.webkit.org/show_bug.cgi?id=89354
3011
3012         Reviewed by Kent Tamura.
3013
3014         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
3015         (WebViewHost):
3016
3017 2012-06-18  James Robinson  <jamesr@chromium.org>
3018
3019         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
3020         https://bugs.webkit.org/show_bug.cgi?id=89254
3021
3022         Reviewed by Adrienne Walker.
3023
3024         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
3025         upstream.
3026
3027         * DumpRenderTree/chromium/WebViewHost.cpp:
3028         (WebViewHost::createGraphicsContext3D):
3029
3030 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
3031
3032         Minor fix suggested by Adam Barth.
3033
3034         Use $(this._what).empty(); rather than removing children one at a time.
3035         For some reason removeAllChildren() is undefined on this node.
3036         
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3038
3039 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
3040
3041         Show TOT revision in garden-o-matic, and make the revisions into links
3042         https://bugs.webkit.org/show_bug.cgi?id=89396
3043
3044         Reviewed by Adam Barth.
3045
3046         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
3047         where the revisions are links to trac.
3048         
3049         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
3050         the knock-on effect of flipping the target and href attributes for anchors in some test output.
3051
3052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
3053         (ViewController.prototype._displayTesters.updateList.list):
3054         (ViewController.prototype._displayTesters.updateList):
3055         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
3056         (ViewController.prototype._domForRegressionRange):
3057         (ViewController.prototype._domForAuxiliaryUIElements):
3058         (ViewController.prototype._domForBuildName):
3059         (ViewController.prototype):
3060         (ViewController.prototype.):
3061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3066
3067 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
3068
3069         REGRESSION(r100558): NRWT should work without SVN or GIT
3070         https://bugs.webkit.org/show_bug.cgi?id=76630
3071
3072         Reviewed by Dirk Pranke.
3073
3074         NRWT is not supposed to have a requirement that we have an
3075         actual SVN or Git checkout, and we were unnecessarily
3076         initializing the checkout. This patch removes that line :).
3077
3078         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3079         (main):
3080
3081 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
3082
3083         [garden-o-matic] Add support for the GTK builders
3084         https://bugs.webkit.org/show_bug.cgi?id=89360
3085
3086         Reviewed by Adam Barth.
3087
3088         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
3089         both get their data from build.webkit.org.
3090
3091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3092         (.):
3093
3094 2012-06-18  Nico Weber  <thakis@chromium.org>
3095
3096         [chromium/mac] Unbreak smooth scrolling.
3097         https://bugs.webkit.org/show_bug.cgi?id=89327
3098
3099         Reviewed by Dimitri Glazkov.
3100
3101         Broken by Sam in r115589 / r115591.
3102
3103         * DumpRenderTree/mac/DumpRenderTree.mm:
3104         (resetDefaultsToConsistentValues):
3105         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3106         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3107         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3108         (WTR::InjectedBundle::platformInitialize):
3109
3110 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3111
3112         Unreviewed, rolling out r120541, r120547, and r120548.
3113         http://trac.webkit.org/changeset/120541
3114         http://trac.webkit.org/changeset/120547
3115         http://trac.webkit.org/changeset/120548
3116         https://bugs.webkit.org/show_bug.cgi?id=89383
3117
3118         This approach doesn't work for WebKit2 (Requested by abarth on
3119         #webkit).
3120
3121         * DumpRenderTree/LayoutTestController.cpp:
3122         (setBackingScaleFactorCallback):
3123         (LayoutTestController::staticFunctions):
3124         * DumpRenderTree/LayoutTestController.h:
3125         (LayoutTestController):
3126         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3127         (LayoutTestController::setBackingScaleFactor):
3128         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3129         (LayoutTestController::setBackingScaleFactor):
3130         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3131         (LayoutTestController::setBackingScaleFactor):
3132         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3133         (LayoutTestController::setBackingScaleFactor):
3134         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3135         (LayoutTestController::setBackingScaleFactor):
3136         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3137         (LayoutTestController::setBackingScaleFactor):
3138         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3139         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3140         (WTR::InjectedBundle::didReceiveMessage):
3141         (WTR::InjectedBundle::postSetBackingScaleFactor):
3142         (WTR):
3143         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3144         (InjectedBundle):
3145         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3146         (WTR::LayoutTestController::setBackingScaleFactor):
3147         (WTR):
3148         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
3149         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3150         (LayoutTestController):
3151         * WebKitTestRunner/TestInvocation.cpp:
3152         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3153
3154 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
3155
3156         REGRESSION(r120546): It made 3 webkitpy tests fail
3157         https://bugs.webkit.org/show_bug.cgi?id=89332
3158
3159         Reviewed by Adam Barth.
3160
3161         Update the BaselineOptimizer unittest after r120546.
3162
3163         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3164         (BaselineOptimizerTest.test_no_add_mac_future):
3165         (BaselineOptimizerTest.test_mac_future):
3166         (BaselineOptimizerTest.test_complex_shadowing):
3167
3168 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
3169
3170         new-run-webkit-tests output gets confused when logging
3171         https://bugs.webkit.org/show_bug.cgi?id=63793
3172
3173         Reviewed by Adam Barth.
3174
3175         Ship all of the log messages generated in the worker back
3176         to the manager; this allows the messages to be properly
3177         serialized to stderr and for the meter to flush its output correctly.
3178
3179         Note however that this will likely result in messages to be
3180         logged out of order between workers; I'm not sure that there's
3181         an easy way to fix this short of buffering a potentially
3182         unbounded amount of data. It might be better to just log through
3183         stderr unless we're in 'metering' mode, but it's also worth
3184         noting that we already get messages out of order through stderr
3185         on Windows.
3186
3187         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3188         (Manager.handle_done):
3189         (Manager.handle_finished_test):
3190         (Manager._log_messages):
3191         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3192         (Worker.__init__):
3193         (Worker._set_up_logging):
3194         (Worker.run):
3195         (Worker._run_test):
3196         (Worker.cleanup):
3197         (Worker.run_single_test):
3198         (_WorkerLogHandler):
3199         (_WorkerLogHandler.__init__):
3200         (_WorkerLogHandler.emit):
3201         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3202         (MeteredStream.write):
3203         (MeteredStream.writeln):
3204         * Scripts/webkitpy/layout_tests/views/printing.py:
3205         (Printer.writeln):
3206
3207 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
3208
3209         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
3210         https://bugs.webkit.org/show_bug.cgi?id=89362
3211
3212         Reviewed by Simon Fraser.
3213
3214         Replace white spaces, braces and dots in the builder name with underscores. This
3215         way the JQuery tabs will be properly matched with the according container.
3216
3217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3218
3219 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
3220
3221         nrwt: metered output doesn't handle ^C cleanly
3222         https://bugs.webkit.org/show_bug.cgi?id=89249
3223
3224         Reviewed by Tony Chang.
3225
3226         If you ctrl-c a running nrwt (w/o --verbose), then all but
3227         two characters of the last update are erased, and then we print
3228         "interrupted, exiting" as an update, which itself then gets
3229         erased. Fix this so that we flush the meter (making the last
3230         update persistent, so that we print the ^C for a visual clue),
3231         print the interrupt message, and move on ...
3232
3233         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3234         (Manager._run_tests):
3235         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3236         (MeteredStream.flush):
3237         * Scripts/webkitpy/layout_tests/views/printing.py:
3238         (Printer._write):
3239         (Printer):
3240         (Printer.flush):
3241
3242 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
3243
3244         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
3245         https://bugs.webkit.org/show_bug.cgi?id=89228
3246
3247         Reviewed by Tony Chang.
3248
3249         * DumpRenderTree/chromium/LayoutTestController.cpp:
3250         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3251
3252 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
3253
3254         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
3255         https://bugs.webkit.org/show_bug.cgi?id=89226
3256
3257         Reviewed by Martin Robinson.
3258
3259         Implement increment() and decrement() functions in term of the AtkValue interface,
3260         instead of using DumpRenderTreeSupportGtk helper class.
3261
3262         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3263         (AccessibilityUIElement::intValue):
3264         (AccessibilityUIElement::minValue):
3265         (AccessibilityUIElement::maxValue):
3266         (alterCurrentValue):
3267         (AccessibilityUIElement::increment):
3268         (AccessibilityUIElement::decrement):
3269
3270 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
3271
3272         garden-o-matic 'Results' panel is broken for the Apple platform
3273         https://bugs.webkit.org/show_bug.cgi?id=89310
3274
3275         Reviewed by Adam Barth.
3276         
3277         For platforms that don't use accumulated build directories on the server,
3278         carry along buildLocation data with buildInfo, so that we know where to
3279         look for the test results files for a given test.
3280         
3281         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
3282         it now returns an array of objects with buildNumber, revision and url info.
3283         
3284         Fixed results.fetchResultsURLs() to use this data to find results.
3285         
3286         Fixed the results display to not scroll when you click on a test to see the results.
3287         Made the h3s look less ugly
3288         
3289         Don't try to show the flakiness dashboard for the Apple platform.
3290
3291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3297         (.results-view .top-panel):
3298         (.results-view h3):
3299
3300 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
3301
3302         Make garden-o-matic work for the Apple Mac port
3303         https://bugs.webkit.org/show_bug.cgi?id=84642
3304
3305         Reviewed by Adam Barth.
3306         
3307         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
3308         educating the scripts in various ways:
3309         * Wrap up platform-related differences in config.kPlatforms[]
3310         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
3311         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
3312           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
3313           recent build with valid results.
3314         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
3315           try to test a build that has already been deleted). Make walkHistory() more robust here.
3316         * webkit.org uses differently named test result directories, that include the SVN revision as
3317           well as the build number. That forces us to fetch more build info before we can get the
3318           result directory URL.
3319         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
3320           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
3321           dirs.
3322         * Various URLs differ between webkit.org and chromium.org
3323         * Better UI for the failures info, so that some info is visible even when not hovered.
3324
3325         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3326         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
3327         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
3328         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3329         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3330         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
3332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
3335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
3339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3340         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3341         (ol.notifications>li table.failures):
3342         (ol.notifications>li:hover table.failures):
3343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3344         (#onebar #platform-picker):
3345         * Scripts/webkitpy/layout_tests/port/builders.py:
3346
3347 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3348
3349         Unreviewed, rolling out r120536.
3350         http://trac.webkit.org/changeset/120536
3351         https://bugs.webkit.org/show_bug.cgi?id=89296
3352
3353         Does not compile on chromium-linux (Requested by abarth on
3354         #webkit).
3355
3356         * DumpRenderTree/chromium/LayoutTestController.cpp:
3357         (LayoutTestController::reset):
3358         (LayoutTestController::setTextSubpixelPositioning):
3359         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3360
3361 2012-06-16  Adam Barth  <abarth@webkit.org>
3362
3363         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
3364         https://bugs.webkit.org/show_bug.cgi?id=89274
3365
3366         Reviewed by Levi Weintraub.
3367
3368         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
3369         Note: The WebKit2 API that setBackingScaleFactor exercises is still
3370         tested by API-level tests.
3371
3372         * DumpRenderTree/LayoutTestController.cpp:
3373         (LayoutTestController::staticFunctions):
3374         * DumpRenderTree/LayoutTestController.h:
3375         (LayoutTestController):
3376         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3377         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3378         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3379         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3380         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3381         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3382         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3383         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3384         (WTR::InjectedBundle::didReceiveMessage):
3385         (WTR):
3386         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3387         (InjectedBundle):
3388         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3389         (WTR):
3390         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3391         (LayoutTestController):
3392         * WebKitTestRunner/TestInvocation.cpp:
3393         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3394
3395 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
3396
3397         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
3398         https://bugs.webkit.org/show_bug.cgi?id=89228
3399
3400         Reviewed by Tony Chang.
3401
3402         * DumpRenderTree/chromium/LayoutTestController.cpp:
3403         (LayoutTestController::reset):
3404         (LayoutTestController::setTextSubpixelPositioning):
3405         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3406
3407 2012-06-15  Adam Barth  <abarth@webkit.org>
3408
3409         garden-o-matic's results.js should use RequestTracker
3410         https://bugs.webkit.org/show_bug.cgi?id=89257
3411
3412         Reviewed by Dimitri Glazkov.
3413
3414         We wrote results.js before we recognized the RequestTracker pattern.
3415         This patch replaces the manual implementations of RequestTracker with
3416         the real deal.
3417
3418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3419
3420 2012-06-15  Darin Adler  <darin@apple.com>
3421
3422         * Scripts/webkitpy/bindings: Added property svn:ignore.
3423
3424 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3425
3426         Unreviewed, rolling out r120511.
3427         http://trac.webkit.org/changeset/120511
3428         https://bugs.webkit.org/show_bug.cgi?id=89255
3429
3430         Breaks at least Android builder (Requested by wangxianzhu on
3431         #webkit).
3432
3433         * DumpRenderTree/chromium/LayoutTestController.cpp:
3434         (LayoutTestController::reset):
3435         (LayoutTestController::setTextSubpixelPositioning):
3436
3437 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
3438
3439         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
3440         https://bugs.webkit.org/show_bug.cgi?id=89228
3441
3442         Reviewed by Tony Chang.
3443
3444         * DumpRenderTree/chromium/LayoutTestController.cpp:
3445         (LayoutTestController::reset):
3446         (LayoutTestController::setTextSubpixelPositioning):
3447
3448 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
3449
3450         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
3451         https://bugs.webkit.org/show_bug.cgi?id=89135
3452
3453         Re-land change in r120370 with fix in
3454         PortFactory.get_from_builder_name() that changes BuilderOptions
3455         to an actual optparse.Values object.
3456
3457         * Scripts/webkitpy/layout_tests/port/base.py:
3458         (Port.__init__):
3459         (Port.get_option):
3460         (Port.set_option_default):
3461         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3462         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
3463         * Scripts/webkitpy/layout_tests/port/factory.py:
3464         (_builder_options):
3465         (PortFactory.get_from_builder_name):
3466         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3467         (FactoryTest.test_get_from_builder_name):
3468         * Scripts/webkitpy/style/checkers/test_expectations.py:
3469         (TestExpectationsChecker._determine_port_from_expectations_path):
3470         * Scripts/webkitpy/tool/mocktool.py:
3471         (MockOptions.ensure_value):
3472
3473 2012-06-15  Bill Budge  <bbudge@chromium.org>
3474
3475         Add bbudge@chromium.org to committers.py
3476
3477         Unreviewed.
3478
3479         * Scripts/webkitpy/common/config/committers.py:
3480
3481 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
3482
3483         Unreviewed style fix after r120351.
3484
3485         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3486         (body.interface):
3487
3488 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
3489
3490         master.cfg cleanup, remove unnecessary workaround
3491         https://bugs.webkit.org/show_bug.cgi?id=88994
3492
3493         Reviewed by Lucas Forschler.
3494
3495         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3496         (loadBuilderConfig):
3497
3498 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
3499
3500         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
3501         https://bugs.webkit.org/show_bug.cgi?id=88581
3502
3503         Reviewed by Adam Barth.
3504
3505         Make sure we only optimize the suffixes we rebaselined during
3506         rebaseline-expectations, and not all suffixes for a test.
3507         While optimizing is somewhere between harmless and good, it's also confusing :)
3508
3509         * Scripts/webkitpy/tool/commands/rebaseline.py:
3510         (RebaselineExpectations._rebaseline_port):
3511         (RebaselineExpectations.execute):
3512         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3513
3514 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
3515
3516         Update builder.html template for newer buildmaster
3517         https://bugs.webkit.org/show_bug.cgi?id=89207
3518
3519         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
3520
3521         Reviewed by Zoltan Herczeg.
3522
3523         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
3524
3525 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
3526
3527         Add ForceScheduler to build.webkit.org
3528         https://bugs.webkit.org/show_bug.cgi?id=88982
3529
3530         Reviewed by Ryosuke Niwa.
3531
3532         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3533         (loadBuilderConfig):
3534
3535 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
3536
3537         [EFL][WK2] Add title support to Ewk_View
3538         https://bugs.webkit.org/show_bug.cgi?id=89095
3539
3540         Reviewed by Kenneth Rohde Christiansen.
3541
3542         Update the MiniBrowser so it listens for the "title,change"
3543         signal on the view and keeps the browser window title
3544         up-to-date.
3545
3546         * MiniBrowser/efl/main.c:
3547         (on_title_changed):
3548         (browserCreate):
3549
3550 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
3551
3552         [WK2][EFL] Implement navigation back/forward in Ewk_View
3553         https://bugs.webkit.org/show_bug.cgi?id=89173
3554
3555         Reviewed by Kenneth Rohde Christiansen.
3556
3557         Implement navigation back / forward in MiniBrowser. Use
3558         'F1' to navigate back and 'F2' to navigate forward.
3559
3560         * MiniBrowser/efl/main.c:
3561         (on_key_down):
3562
3563 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
3564
3565         [EFL] EFL's LayoutTestController does not support titleTextDirection
3566         https://bugs.webkit.org/show_bug.cgi?id=86475
3567
3568         Reviewed by Hajime Morita.
3569
3570         Add titleTextDirection getter and setter to LayoutTestController and
3571         expose its value to JavaScript.
3572         Update the titleTextDirection value from EFL's "title,changed"
3573         callback in DumpRenderTree.
3574
3575         * DumpRenderTree/LayoutTestController.cpp:
3576         (LayoutTestController::LayoutTestController):
3577         (getTitleTextDirectionCallback):
3578         (LayoutTestController::staticValues):
3579         * DumpRenderTree/LayoutTestController.h:
3580         (LayoutTestController::titleTextDirection):
3581         (LayoutTestController::setTitleTextDirection):
3582         (LayoutTestController):
3583         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3584         (DumpRenderTreeChrome::onFrameTitleChanged):
3585
3586 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
3587
3588         [EFL][WK2] Implement reload / stop in Ewk_View
3589         https://bugs.webkit.org/show_bug.cgi?id=89168
3590
3591         Reviewed by Kenneth Rohde Christiansen.
3592
3593         Implement view reload / stop loading in MiniBrowser.
3594         Use 'F5' for reload and 'F6' for stopping the load.
3595
3596         * MiniBrowser/efl/main.c:
3597         (on_key_down):
3598         (browserCreate):
3599
3600 2012-06-15  Hironori Bono  <hbono@chromium.org>
3601
3602         Allow platforms to choose whether to remove markers on editing
3603         https://bugs.webkit.org/show_bug.cgi?id=88838
3604
3605         Reviewed by Hajime Morita.
3606
3607         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
3608         run grammar tests.
3609
3610         * DumpRenderTree/chromium/WebViewHost.cpp:
3611         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
3612         * DumpRenderTree/chromium/WebViewHost.h:
3613         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
3614
3615 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3616
3617         Unreviewed, rolling out r120370.
3618         http://trac.webkit.org/changeset/120370
3619         https://bugs.webkit.org/show_bug.cgi?id=89183
3620
3621         Broke webkit-patch rebaseline (Requested by zdobersek on
3622         #webkit).
3623
3624         * Scripts/webkitpy/layout_tests/port/base.py:
3625         (DummyOptions):
3626         (DummyOptions.__init__):
3627         (DummyOptions.__init__.this):
3628         (Port.__init__):
3629         (Port.get_option):
3630         (Port.set_option_default):
3631         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3632         (ChromiumWinTest.RegisterCygwinOption):
3633         (ChromiumWinTest.RegisterCygwinOption.__init__):
3634         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
3635         * Scripts/webkitpy/style/checkers/test_expectations.py:
3636         (TestExpectationsChecker._determine_port_from_expectations_path):
3637         * Scripts/webkitpy/tool/mocktool.py:
3638         (MockOptions.update):
3639
3640 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
3641
3642         [Chromium-Android] Initialize font rendering in DumpRenderTree
3643         https://bugs.webkit.org/show_bug.cgi?id=89133
3644
3645         Reviewed by Adam Barth.
3646
3647         * DumpRenderTree/chromium/LayoutTestController.cpp:
3648         (LayoutTestController::reset):
3649         (LayoutTestController::setTextSubpixelPositioning):
3650         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3651         (platformInit):
3652
3653 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
3654
3655         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
3656         https://bugs.webkit.org/show_bug.cgi?id=88622
3657
3658         Reviewed by Philippe Normand.
3659
3660         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
3661         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3662