Tools/ChangeLog

   1 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
   2
   3         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
   4         to build on Mac.
   5
   6         * waf/build/settings.py:
   7         * wx/install-unix-extras:
   8
   9 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
  10
  11         [wx] Unreviewed build fixes for recent trunk changes.
  12
  13         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  14         (LayoutTestController::setTextDirection):
  15         * waf/build/settings.py:
  16
  17 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
  18
  19         Fix the GTK+ build.
  20
  21         * GNUmakefile.am: Add some missing newline escape.
  22
  23 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
  24
  25         Try to fix the GTK+ bulid.
  26
  27         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
  28         source list.
  29
  30 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
  31
  32         Reviewed by Adam Barth.
  33
  34         nrwt: should skip chromium test expectation overrides on upstream bots
  35         https://bugs.webkit.org/show_bug.cgi?id=61888
  36
  37         * Scripts/webkitpy/layout_tests/port/chromium.py:
  38         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  39
  40 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
  41
  42         Reviewed by Ojan Vafai.
  43
  44         new-run-webkit-tests: minor logging, code cleanup
  45         https://bugs.webkit.org/show_bug.cgi?id=62055
  46
  47         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  48         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  49
  50 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
  51
  52         Try to fix the build failure on the GTK+ 32-bit Release bot.
  53
  54         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
  55
  56 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
  57
  58         Reviewed by Ryosuke Niwa.
  59
  60         [GTK] Support smart replace for the pasteboard
  61         https://bugs.webkit.org/show_bug.cgi?id=61734
  62
  63         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
  64         This is required to produce consistent test results.
  65
  66         * DumpRenderTree/gtk/DumpRenderTree.cpp:
  67         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
  68         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  69         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
  70         methods which calls into DumpRenderTreeSupportGtk.
  71
  72 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
  73
  74         Reviewed by Dimitri Glazkov.
  75
  76         Teach Gtk build about window.internals
  77         https://bugs.webkit.org/show_bug.cgi?id=61071
  78
  79         * DumpRenderTree/gtk/DumpRenderTree.cpp:
  80         (webViewWindowObjectCleared): Inject the new internals object when the
  81         window object clears.
  82         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
  83         Also do a little bit of cleanup.
  84
  85 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
  86
  87         Reviewed by Tony Chang.
  88
  89         Worker may not be stopped after LT.
  90         https://bugs.webkit.org/show_bug.cgi?id=61847
  91
  92         Re-submit a variant of the first fix for this bug. It's possible
  93         that actually calling cleanup() in the worker threads was taking
  94         too long and we triggered the assertions in the manager thread.
  95
  96         I've bumped up the timeout in the manager and added better
  97         diagnostics. I also cleaned up the cleanup() code a bit because
  98         there was some unnecessary if-checks.
  99
 100         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
 101         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
 102
 103 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
 104
 105         Reviewed by Tony Chang.
 106
 107         nrwt: fix duplicate logging regression
 108         https://bugs.webkit.org/show_bug.cgi?id=61981
 109
 110         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 111
 112 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
 113
 114         Reviewed by Adam Barth.
 115
 116         Modified addTouchPoint to correctly re-use touchPoint id values starting
 117         from the lowest not-un-use touchPoint id as is done by the embedder
 118         APIs. (Fixes BUGCR36415)
 119
 120         https://bugs.webkit.org/show_bug.cgi?id=62016
 121
 122         * DumpRenderTree/chromium/EventSender.cpp:
 123         (EventSender::addTouchPoint):
 124
 125 2011-06-03  Cary Clark  <caryclark@google.com>
 126
 127         Reviewed by Eric Seidel.
 128
 129         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
 130         https://bugs.webkit.org/show_bug.cgi?id=61534
 131
 132         Skia on Mac uses Skia to render WebKit, and CG
 133         to render UI elements. The CG elements need a
 134         transcribed graphics context that preserves the
 135         canvas matrix, and the canvas clip.
 136
 137         The SkiaBitLocker utility class sets up a CGContext
 138         from the SkCanvas, locks the bitmap's bits, and
 139         releases the lock when the class goes out of scope.
 140
 141         The SkiaBitLocker implementation is described by
 142         this patch:
 143         http://codereview.chromium.org/7031006/
 144
 145         When WebKit uses Skia for rendering, the WebCanvas
 146         is an SkCanvas. Create an equivalent CGContext to
 147         draw the scrollbar thumb.
 148
 149         As the Chrome Mac port does not yet use Skia, this
 150         patch has no effect and requires no tests.
 151
 152         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
 153         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
 154
 155 2011-06-03  Andras Becsi  <abecsi@webkit.org>
 156
 157         Unreviewed build fix.
 158
 159         Fix typo.
 160
 161         * Scripts/old-run-webkit-tests:
 162
 163 2011-06-03  Andras Becsi  <abecsi@webkit.org>
 164
 165         Reviewed by Csaba Osztrogonác.
 166
 167         Print error message when there is no httpd present on the system
 168         https://bugs.webkit.org/show_bug.cgi?id=61939
 169
 170         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
 171         * Scripts/webkitperl/httpd.pm:
 172
 173 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
 174
 175         Reviewed by Yury Semikhatsky.
 176
 177         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
 178         https://bugs.webkit.org/show_bug.cgi?id=61533
 179
 180         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
 181
 182         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
 183         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
 184         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
 185         * DumpRenderTree/chromium/LayoutTestController.cpp:
 186         (LayoutTestController::LayoutTestController):
 187         (LayoutTestController::setJavaScriptProfilingEnabled):
 188         * DumpRenderTree/chromium/LayoutTestController.h:
 189         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 190         (LayoutTestController::setJavaScriptProfilingEnabled):
 191         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 192         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
 193         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 194
 195 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
 196
 197         Reviewed by Tony Chang.
 198
 199         NRWT needs a way to log to a file without including backspaces without needing --verbose
 200         https://bugs.webkit.org/show_bug.cgi?id=60328
 201
 202         This change modifies NRWT so that if it can tell if it is
 203         writing to a terminal, it will overwrite any messages printed
 204         in the 'one-line-progress' and 'updates' print options, and if
 205         not (or if --verbose was specified) the messages will be printed
 206         without backspaces.
 207
 208         If the overwriting updates are disabled, one-line-progress will
 209         only print every 10 seconds instead of on every update. This
 210         ensures that we still get updates once in a while while the
 211         tests are running, even if we're not in --verbose mode. Note
 212         that one-line-progress will now still be printed in --verbose,
 213         since it's useful as long as you're not flooded with the
 214         updates.
 215
 216         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
 217         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 218         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 219
 220 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
 221
 222         Reviewed by Gustavo Noronha Silva.
 223
 224         [GTK] autogen.sh is run twice for each buld on the bots
 225         https://bugs.webkit.org/show_bug.cgi?id=61951
 226
 227         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
 228         for the WebKit project. This prevents build-jsc runs from forcing subsequent
 229         build-webkit runs to re-rerun autogen.sh.
 230
 231 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
 232
 233         Unreviewed, rolling out r87946.
 234         http://trac.webkit.org/changeset/87946
 235         https://bugs.webkit.org/show_bug.cgi?id=61965
 236
 237         Cause NRWT to break (Requested by abarth|gardener on #webkit).
 238
 239         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
 240
 241 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
 242
 243         Reviewed by Darin Adler.
 244
 245         Add build logistics and plumbing for window.internals object.
 246         https://bugs.webkit.org/show_bug.cgi?id=60313
 247
 248         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
 249         * DumpRenderTree/chromium/TestShell.cpp:
 250         (TestShell::bindJSObjectsToWindow): Added injection code.
 251         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 252         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
 253
 254 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
 255
 256         Reviewed by Dirk Pranke.
 257
 258         Call cleanup() explicitly at the end of worker.run().
 259         https://bugs.webkit.org/show_bug.cgi?id=61847
 260
 261         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
 262
 263 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
 264
 265         Unreviewed, rolling out r87926.
 266         http://trac.webkit.org/changeset/87926
 267         https://bugs.webkit.org/show_bug.cgi?id=60313
 268
 269         Fails to find WebCoreTestSupport.dylib on bots.
 270
 271         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 272         * DumpRenderTree/chromium/TestShell.cpp:
 273         (TestShell::bindJSObjectsToWindow):
 274         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 275         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
 276
 277 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
 278
 279         Reviewed by Darin Adler.
 280
 281         Add build logistics and plumbing for window.internals object.
 282         https://bugs.webkit.org/show_bug.cgi?id=60313
 283
 284         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
 285         * DumpRenderTree/chromium/TestShell.cpp:
 286         (TestShell::bindJSObjectsToWindow): Added injection code.
 287         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 288         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
 289
 290 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 291
 292         Reviewed by Eric Seidel.
 293
 294         Adjust efl coding style to more efl directories
 295         https://bugs.webkit.org/show_bug.cgi?id=61903
 296
 297         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
 298
 299 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
 300
 301         Reviewed by Tony Chang.
 302
 303         old-run-webkit-tests: add support for audio files
 304         https://bugs.webkit.org/show_bug.cgi?id=57992
 305
 306         * Scripts/old-run-webkit-tests:
 307
 308 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
 309
 310         Reviewed by Adam Barth.
 311
 312         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
 313         https://bugs.webkit.org/show_bug.cgi?id=34314
 314
 315         * DumpRenderTree/DumpRenderTree.gypi:
 316         * DumpRenderTree/chromium/LayoutTestController.cpp:
 317         (LayoutTestController::LayoutTestController):
 318         (LayoutTestController::setImagesAllowed):
 319         (LayoutTestController::setStorageAllowed):
 320         * DumpRenderTree/chromium/LayoutTestController.h:
 321         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
 322         (WebPermissions::WebPermissions):
 323         (WebPermissions::~WebPermissions):
 324         (WebPermissions::allowImages):
 325         (WebPermissions::allowStorage):
 326         (WebPermissions::setImagesAllowed):
 327         (WebPermissions::setStorageAllowed):
 328         (WebPermissions::reset):
 329         * DumpRenderTree/chromium/WebPermissions.h:
 330
 331 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
 332
 333         Reviewed by Tony Chang.
 334
 335         Test plugin should support event logging on the windows port.
 336         https://bugs.webkit.org/show_bug.cgi?id=61721
 337
 338         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
 339         (handleEventWin): Well, handle them.
 340
 341 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
 342
 343         Reviewed by Tony Chang.
 344
 345         [chromium] Use correct file name for dragging out images.
 346         https://bugs.webkit.org/show_bug.cgi?id=24887
 347
 348         * DumpRenderTree/chromium/EventSender.cpp:
 349         (EventSender::EventSender):
 350         (EventSender::dumpFilenameBeingDragged):
 351         * DumpRenderTree/chromium/EventSender.h:
 352
 353 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
 354
 355         Reviewed by Tony Chang.
 356
 357         nrwt: make webaudio work w/o content-length header
 358         https://bugs.webkit.org/show_bug.cgi?id=61819
 359
 360         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 361         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
 362         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
 363         * Scripts/webkitpy/layout_tests/port/webkit.py:
 364
 365 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
 366
 367         Reviewed by Andreas Kling.
 368
 369         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
 370         https://bugs.webkit.org/show_bug.cgi?id=61802
 371
 372         Add command line parameter and menu item to MiniBrowser application
 373         enabling use of QGLWidget for browser viewport.
 374
 375         * MiniBrowser/qt/BrowserWindow.cpp:
 376         (BrowserWindow::BrowserWindow):
 377         (BrowserWindow::toggleGLViewport):
 378         * MiniBrowser/qt/BrowserWindow.h:
 379         * MiniBrowser/qt/MiniBrowserApplication.cpp:
 380         (MiniBrowserApplication::handleUserOptions):
 381         * MiniBrowser/qt/MiniBrowserApplication.h:
 382         (WindowOptions::WindowOptions):
 383
 384 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
 385
 386         Reviewed by Xan Lopez.
 387
 388         Print out autogen arguments when they differ from the last set, to help
 389         with debugging build issues.
 390
 391         * Scripts/webkitdirs.pm: Print out previous and current build arguments
 392         when they differ.
 393
 394 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
 395
 396         Reviewed by Martin Robinson.
 397
 398         [GTK] run-launcher should run MiniBrowser in WebKit2
 399         https://bugs.webkit.org/show_bug.cgi?id=61858
 400
 401         * Scripts/run-launcher: Check whether -2 command line option has
 402         been passed and run MiniBrowser instead of GtkLauncher.
 403
 404 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
 405
 406         Reviewed by Dirk Pranke.
 407
 408         Fix exception in verbose printing mode.
 409         https://bugs.webkit.org/show_bug.cgi?id=61723
 410
 411         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 412
 413 2011-05-31  Yong Li  <yoli@rim.com>
 414
 415         Reviewed by Eric Seidel.
 416
 417         https://bugs.webkit.org/show_bug.cgi?id=54807
 418         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
 419         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
 420         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
 421         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
 422         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
 423         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
 424         rule we should have in order to make our code independent from compilers and compiler flags.
 425
 426         * Scripts/webkitpy/style/checkers/cpp.py:
 427
 428 2011-05-31  Hironori Bono  <hbono@chromium.org>
 429
 430         Reviewed by Eric Seidel.
 431
 432         Add a JavaScript function layoutTestController.setTextDirection().
 433         https://bugs.webkit.org/show_bug.cgi?id=50952
 434
 435         This change adds a new JavaScript function setTextDirection() to the
 436         LayoutTestController class of Safari and Chrome to write layout tests
 437         that changes the text direction of an editable element.
 438
 439         * DumpRenderTree/LayoutTestController.cpp:
 440         (setTextDirectionCallback):
 441         (LayoutTestController::staticFunctions):
 442         * DumpRenderTree/LayoutTestController.h:
 443         * DumpRenderTree/chromium/LayoutTestController.cpp:
 444         (LayoutTestController::LayoutTestController):
 445         (LayoutTestController::setTextDirection):
 446         * DumpRenderTree/chromium/LayoutTestController.h:
 447         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 448         (LayoutTestController::setTextDirection):
 449         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 450         (LayoutTestController::setTextDirection):
 451         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 452         (LayoutTestController::setTextDirection):
 453
 454 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
 455
 456         Reviewed by Simon Hausmann.
 457
 458         [Qt] User-agent list of Qt test browsers is very outdated
 459         https://bugs.webkit.org/show_bug.cgi?id=61531
 460
 461         The user can edit the user-agent manually, so there's no need to have
 462         a super complete and up to date list, but it's nice to have it
 463         minimally updated.
 464
 465         * MiniBrowser/qt/useragentlist.txt:
 466         * QtTestBrowser/useragentlist.txt:
 467
 468 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
 469
 470         Reviewed by Adam Roben.
 471
 472         [GTK] [WebKit2] Implement a basic WebKitTestRunner
 473         https://bugs.webkit.org/show_bug.cgi?id=57068
 474
 475         Add an implementation of WebKitTestRunner for GTK+.
 476
 477         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
 478         * Scripts/old-run-webkit-tests: Ditto.
 479         * Scripts/run-launcher: Ditto.
 480         * Scripts/webkitdirs.pm: Ditto.
 481         * WebKitTestRunner/GNUmakefile.am: Added.
 482         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 483         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
 484         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
 485         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
 486         * WebKitTestRunner/PlatformWebView.h:
 487         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
 488         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
 489         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
 490         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
 491         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
 492         (main): Added.
 493
 494 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
 495
 496         Reviewed by Tony Chang.
 497
 498         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
 499         https://bugs.webkit.org/show_bug.cgi?id=60241
 500
 501         * Scripts/new-run-webkit-tests:
 502
 503 2011-05-31  Eric Seidel  <eric@webkit.org>
 504
 505         Reviewed by David Kilzer.
 506
 507         webkitpy should create zips with zip -9
 508         https://bugs.webkit.org/show_bug.cgi?id=61789
 509
 510         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
 511
 512         * Scripts/webkitpy/common/system/workspace.py:
 513         * Scripts/webkitpy/common/system/workspace_unittest.py:
 514
 515 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
 516
 517         Reviewed by Csaba Osztrogonác.
 518
 519         [Qt] Implement find feature for QtTestBrowser
 520         https://bugs.webkit.org/show_bug.cgi?id=61425
 521
 522         Buildfix for --minimal and CONFIG+=qt_minimal build.
 523
 524         * QtTestBrowser/launcherwindow.cpp:
 525         (LauncherWindow::LauncherWindow):
 526         (LauncherWindow::createChrome):
 527         * QtTestBrowser/launcherwindow.h:
 528
 529 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
 530
 531         Reviewed by Csaba Osztrogonác.
 532
 533         [Qt] Implement find feature for QtTestBrowser
 534         https://bugs.webkit.org/show_bug.cgi?id=61425
 535
 536         * QtTestBrowser/launcherwindow.cpp:
 537         (LauncherWindow::LauncherWindow):
 538         (LauncherWindow::createChrome):
 539         (LauncherWindow::showFindBar):
 540         (LauncherWindow::find):
 541         * QtTestBrowser/launcherwindow.h:
 542
 543 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
 544
 545         Reviewed by Martin Robinson.
 546
 547         [GTK] Implement JavaScript dialogs in MiniBrowser
 548         https://bugs.webkit.org/show_bug.cgi?id=61725
 549
 550         * MiniBrowser/gtk/BrowserWindow.c:
 551         (WKStringGetCString): Helper function to get a UTF-8 c string from
 552         a WKStringRef.
 553         (WKURLGetCString): Helper function to get a UTF-8 c string from a
 554         WKURLRef.
 555         (browserWindowUpdateURL): Update to use WKURLGetCString.
 556         (didReceiveTitleForFrame): Update to use WKStringGetCString.
 557         (createMessageDialog): Create a GtkMessageDialog.
 558         (runJavaScriptAlert):
 559         (runJavaScriptConfirm):
 560         (runJavaScriptPrompt):
 561         (browserWindowUIClientInit):
 562
 563 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
 564
 565         Reviewed by Kent Tamura.
 566
 567         WebSocket closing handshake
 568         https://bugs.webkit.org/show_bug.cgi?id=35721
 569
 570         * Scripts/webkitpy/thirdparty/__init__.py:
 571         Pull in pywebsocket 0.6b1. We need to update pywebsocket
 572         to get the right behavior of closing handshake.
 573
 574 2011-05-29  Daniel Bates  <dbates@rim.com>
 575
 576         Reviewed by David Kilzer.
 577
 578         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
 579         https://bugs.webkit.org/show_bug.cgi?id=61162
 580
 581         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
 582         that omits a line count. In particular, the chunk range regular expression does
 583         not match a chunk range line that omits a line count. GNU diff(1) will omit the
 584         line count in the chunk range if the line count is exactly 1. For example, appending
 585         a new line to the end of an existing file F that contains exactly one line of text will
 586         be represented in a diff with a chunk range line that omits the line count for F.
 587
 588         * Scripts/VCSUtils.pm:
 589           (parseChunkRange): Added.
 590         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
 591         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
 592           - Added unit test "Git: Append new line to the end of an existing file".
 593
 594 2011-05-28  Adam Barth  <abarth@webkit.org>
 595
 596         Reviewed by Eric Seidel.
 597
 598         EWS builds patches that fail to build twice, which seems useless and slows down the bots
 599         https://bugs.webkit.org/show_bug.cgi?id=55585
 600
 601         This patch switches all the early warning system bots over to the new
 602         PatchAnalysisTask-based infrastructure.  This patch makes these bots
 603         more efficient (in the case where patches fail to build) and paves the
 604         way for running tests on these bots!
 605
 606         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 607         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
 608         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
 609         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 610         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 611         * Scripts/webkitpy/tool/commands/queues.py:
 612
 613 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
 614
 615         Reviewed by Kent Tamura.
 616
 617         Add bashi as a committer.
 618
 619         https://bugs.webkit.org/show_bug.cgi?id=61685
 620
 621         * Scripts/webkitpy/common/config/committers.py:
 622
 623 2011-05-27  Adam Barth  <abarth@webkit.org>
 624
 625         Reviewed by Eric Seidel.
 626
 627         When checking whether the tree is red, the EWS posts a link to the wrong log
 628         https://bugs.webkit.org/show_bug.cgi?id=61072
 629
 630         We need to cache the original script error because that contains the
 631         failure log we want to upload.  If we don't cache that script error,
 632         self._script_error will get overwritten when we sanity check the clean
 633         tree (and it also has test failures).
 634
 635         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 636             - This testing approach is slightly goofy.  We'd like to use
 637               assertRaisesRegexp, but that's not available until Python 2.7.
 638         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
 639
 640 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
 641
 642         Reviewed by Adam Barth.
 643
 644         Add layoutTestController.setStorageAllowed() to control whether access
 645         to the localStorage API is enabled via the WebPermissionClient
 646         https://bugs.webkit.org/show_bug.cgi?id=61581
 647
 648         * DumpRenderTree/chromium/LayoutTestController.cpp:
 649         (LayoutTestController::LayoutTestController):
 650         (LayoutTestController::setStorageAllowed):
 651         * DumpRenderTree/chromium/LayoutTestController.h:
 652         * DumpRenderTree/chromium/TestShell.cpp:
 653         (TestShell::TestShell):
 654         (TestShell::createNewWindow):
 655         * DumpRenderTree/chromium/TestShell.h:
 656         * DumpRenderTree/chromium/WebPermissions.h: Added.
 657         (WebPermissions::WebPermissions):
 658         (WebPermissions::allowStorage):
 659         (WebPermissions::setStorageAllowed):
 660         (WebPermissions::reset):
 661
 662 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
 663
 664         Reviewed by Eric Seidel.
 665
 666         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
 667         https://bugs.webkit.org/show_bug.cgi?id=60326
 668
 669         This patch removes a lot of the complexity from the
 670         metered_stream implementation that was unnecessary since there
 671         was only one caller and the logic could be coordinated better.
 672
 673         There should be no functional changes in this patch, just code
 674         getting deleted and cleaned up.
 675
 676         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
 677         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
 678         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 679         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 680
 681 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
 682
 683         Reviewed by Eric Seidel.
 684
 685         NRWT: minor cleanup in printing module
 686         https://bugs.webkit.org/show_bug.cgi?id=60329
 687
 688         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 689
 690 2011-05-27  Steve Lacey  <sjl@chromium.org>
 691
 692         Reviewed by David Levin.
 693
 694         Add sjl@chromium.org as a committer.
 695
 696         https://bugs.webkit.org/show_bug.cgi?id=61672
 697
 698         * Scripts/webkitpy/common/config/committers.py:
 699
 700 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
 701
 702         Reviewed by Adam Barth.
 703
 704         NRWT: remove --print detailed-progress
 705         https://bugs.webkit.org/show_bug.cgi?id=60324
 706
 707         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
 708         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 709         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 710         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 711
 712 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
 713
 714         Reviewed by Ojan Vafai.
 715
 716         NRWT: debug messages from the workers are being logged twice
 717         https://bugs.webkit.org/show_bug.cgi?id=60428
 718
 719         It looks like when the workers are run in separate processes
 720         we end up getting two copies of every log message they print.
 721         This has to do with the multiprocessing module on UNIX cloning
 722         the log configuration in a way I wasn't expecting, and so two
 723         log handlers end up getting registered.
 724
 725         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
 726         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
 727         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 728         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 729
 730 2011-05-27  Adam Roben  <aroben@apple.com>
 731
 732         Always decode tester names from location.hash
 733
 734         When navigating directly to a tester-specific URL (e.g.,
 735         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
 736         with a URL-encoded tester name in the page, and then the encoded name could make its way
 737         into Bugzilla bugs. Bad!
 738
 739         Reviewed by David Kilzer.
 740
 741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
 742         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
 743         decodeURIComponent before trying to use it.
 744
 745 2011-05-27  Adam Roben  <aroben@apple.com>
 746
 747         Remove testing code that snuck into r87528
 748
 749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
 750         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
 751
 752 2011-05-27  Adam Roben  <aroben@apple.com>
 753
 754         Add links to TestFailures to easily file bugs about failing tests
 755
 756         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
 757         links to file bugs for failing tests
 758
 759         Reviewed by David Kilzer.
 760
 761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
 762         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
 763         for a particular build.
 764         (Builder.prototype._getFailingTests): Use resultsPageURL.
 765
 766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
 767         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
 768         failures.
 769         (ViewController.prototype._domForBuildName): Use resultsPageURL.
 770         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
 771         new bug link. The bug has a title, description, and URL already filled in for you!
 772
 773 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 774
 775         Unreviewed, rolling out r87464.
 776         http://trac.webkit.org/changeset/87464
 777         https://bugs.webkit.org/show_bug.cgi?id=61643
 778
 779         client-close/server-close tests are flaky on Chromium Mac and
 780         Windows (Requested by aklein on #webkit).
 781
 782         * Scripts/webkitpy/thirdparty/__init__.py:
 783
 784 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
 785
 786         Added Douglas Davidson to contributors list for easier CC'ing.
 787
 788         * Scripts/webkitpy/common/config/committers.py:
 789
 790 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
 791
 792         Reviewed by Adam Barth.
 793
 794         Fix worldID and destinationDomain argument names
 795         https://bugs.webkit.org/show_bug.cgi?id=61571
 796
 797         As part of working on r87423, I noticed a couple of inconsistencies in
 798         argument names:
 799         - We would use worldId in .h files but worldID in .cpp files.
 800           Standardize on the latter
 801         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
 802           destinationDomains argument, even though the actual parameter was for
 803           a single domain (renamed to be singular).
 804
 805         * DumpRenderTree/LayoutTestController.h:
 806         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 807         (LayoutTestController::evaluateScriptInIsolatedWorld):
 808
 809 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
 810
 811         Reviewed by Kent Tamura.
 812
 813         WebSocket closing handshake
 814         https://bugs.webkit.org/show_bug.cgi?id=35721
 815
 816         * Scripts/webkitpy/thirdparty/__init__.py:
 817         Pull in pywebsocket 0.6b1. We need to update pywebsocket
 818         to get the right behavior of closing handshake.
 819
 820 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
 821
 822         Reviewed by Andreas Kling.
 823
 824         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
 825         https://bugs.webkit.org/show_bug.cgi?id=42676
 826
 827         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
 828
 829         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 830         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 831         (WTR::InjectedBundle::beginTesting):
 832         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 833         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
 834         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 835
 836 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
 837
 838         Reviewed by Andreas Kling.
 839
 840         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
 841         https://bugs.webkit.org/show_bug.cgi?id=61527
 842
 843         The setMaximumHeight() call is unecessary and breaks the dialog at
 844         least on my setup.
 845
 846         * QtTestBrowser/launcherwindow.cpp:
 847         (LauncherWindow::showUserAgentDialog):
 848
 849 2011-05-02  Robert Hogan  <robert@webkit.org>
 850
 851         Reviewed by Adam Roben.
 852
 853         [Qt] Allow popup windows from plugins when initiated by a user gesture
 854
 855         https://bugs.webkit.org/show_bug.cgi?id=41292
 856
 857         Support parameters introduced in plugin-initiate-popup-window.html
 858
 859         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 860         (webkit_test_plugin_new_instance):
 861         (webkit_test_plugin_handle_event):
 862
 863 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
 864
 865         Reviewed by Adam Barth.
 866
 867         Support cross-origin XMLHttpRequest in isolated worlds
 868         https://bugs.webkit.org/show_bug.cgi?id=59843
 869
 870         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
 871
 872         * DumpRenderTree/chromium/LayoutTestController.cpp:
 873         (LayoutTestController::LayoutTestController):
 874         (LayoutTestController::setIsolatedWorldSecurityOrigin):
 875         * DumpRenderTree/chromium/LayoutTestController.h:
 876
 877 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
 878
 879         Reviewed by Adam Roben.
 880
 881         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
 882         https://bugs.webkit.org/show_bug.cgi?id=61474
 883         <rdar://problem/9468337>
 884
 885         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 886         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
 887
 888 2011-05-26  Andreas Kling  <kling@webkit.org>
 889
 890         Unreviewed, correct address to webkit-committers mailing list.
 891
 892         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 893
 894 2011-05-25  Adam Roben  <aroben@apple.com>
 895
 896         Don't assume that builds finish in the order they were started
 897
 898         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
 899         build when one slave is taking a long time to finish a build
 900
 901         Reviewed by Antti Koivisto.
 902
 903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
 904         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
 905         newer than the oldest in-progress build are also themselves in progress. Just check whether
 906         each build is actually in progress (as signified by its presence in the currentBuilds set).
 907
 908 2011-05-25  Adam Roben  <aroben@apple.com>
 909
 910         Correctly detect cases where only a single test failed/crashed/timed out
 911
 912         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
 913         failing test
 914
 915         Reviewed by Darin Adler.
 916
 917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
 918         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
 919         will be singular when only a single test fails/crashes/times out.
 920
 921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
 922         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
 923         failed/crashed/timed out.
 924
 925 2011-05-26  Tom Hudson  <tomhudson@google.com>
 926
 927         Reviewed by Tony Chang.
 928
 929         Add flags to Chromium ImageDiff to write image comparison metrics on
 930         stdout.
 931         https://bugs.webkit.org/show_bug.cgi?id=60569
 932
 933         * DumpRenderTree/chromium/ImageDiff.cpp:
 934         (Image::createFromStdin): Fix spelling.
 935         (maxOf3): New function to do 3-way maximum.
 936         (getRedComponent): Extract red component from ABGR packed encoding.
 937         (getGreenComponent): Extract green component from ABGR packed encoding.
 938         (getBlueComponent): Extract blue component from ABGR packed encoding.
 939         (weightedPercentageDifferent): Determine % of pixels different in two
 940         images multiplied by intensity difference of each pixel.
 941         (printHelp): Document new arguments.
 942         (compareImages): Parameterize.
 943         (untestedCompareImages): Parameterize.
 944         (diffImages): Parameterize; write results on stdout if requested.
 945         (main): Parse new arguments.
 946
 947 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
 948
 949         Reviewed by Simon Hausmann.
 950
 951         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
 952         https://bugs.webkit.org/show_bug.cgi?id=42697
 953
 954         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
 955
 956         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 957         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 958         (WTR::InjectedBundle::beginTesting):
 959         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 960         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
 961         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 962
 963 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
 964
 965         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
 966         https://bugs.webkit.org/show_bug.cgi?id=61428
 967         <rdar://problem/9457006>
 968
 969         Reviewed by Adam Roben.
 970
 971         The crash occurs when Flash posts a message to a window that it
 972         creates, and in processing the message, it calls NPN_Evaluate to
 973         evaluate JavaScript that removes the plug-in from the page. Flash then
 974         crashes when we return to Flash code.
 975
 976         This test emulates that behavior.
 977
 978         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
 979         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
 980         Initialize member vars.
 981         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
 982         Remove our custom property from the message window, and destroy it.
 983         (CallJSThatDestroysPlugin::NPP_Destroy):
 984         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
 985         layout test controller that we're done.
 986         (wndProc):
 987         Get the PluginTest object, and call its runTest() function.
 988         (CallJSThatDestroysPlugin::NPP_New):
 989         Setup the test: register a class for the message-only window, create
 990         it, and post a message to it to run the test.
 991         (CallJSThatDestroysPlugin::runTest):
 992         Execute JS that removes the plug-in from the page, and if we're not
 993         destroyed, log a success message.
 994
 995         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 996         Add new test to project.
 997
 998 2011-05-25  Tony Chang  <tony@chromium.org>
 999
1000         Reviewed by Adam Barth.
1001
1002         webkitpy's NetworkTransaction shouldn't use mechanize
1003         https://bugs.webkit.org/show_bug.cgi?id=61450
1004
1005         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
1006         use urllib2 directly.  Re-add NetworkTransaction to
1007         test_results_uploader.py (reverting r87124).
1008
1009         * Scripts/webkitpy/common/net/networktransaction.py:
1010         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1011
1012 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1013
1014         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
1015         until the port begins using those export macros.
1016
1017         * DumpRenderTree/chromium/config.h:
1018
1019 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1020
1021         Unreviewed, rolling out r87257.
1022         http://trac.webkit.org/changeset/87257
1023         https://bugs.webkit.org/show_bug.cgi?id=61457
1024
1025         This broke layout tests, see bug 61431. (Requested by
1026         hwennborg on #webkit).
1027
1028         * DumpRenderTree/chromium/LayoutTestController.cpp:
1029         (LayoutTestController::LayoutTestController):
1030         (LayoutTestController::clearAllDatabases):
1031         * DumpRenderTree/chromium/LayoutTestController.h:
1032
1033 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
1034
1035         Reviewed by Andreas Kling.
1036
1037         [Qt] fast/css/disabled-author-styles.html failed
1038         https://bugs.webkit.org/show_bug.cgi?id=61438
1039
1040         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
1041
1042         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1043         (WebCore::WebPage::resetSettings):
1044         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1045         (LayoutTestController::setAuthorAndUserStylesEnabled):
1046         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1047
1048 2011-05-25  Adam Roben  <aroben@apple.com>
1049
1050         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
1051
1052         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
1053         started exiting early due to too many crashes, timeouts, or failures
1054
1055         Reviewed by David Kilzer.
1056
1057         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1058         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
1059         run-webkit-tests exits early due to too many failures, pass that information in another
1060         argument to the callback.
1061         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
1062         the new structure of the object passed to the callback.
1063         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
1064         getNumberOfFailingTests and to pass that along to our own callbacks.
1065         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
1066         from _getFailingTests and to store that value in the history object.
1067
1068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1069         (.info): Added.
1070
1071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1072         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
1073         object and to add a note when run-webkit-tests exited early due to too many failures.
1074         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
1075         latestBuildInfos since each entry now contains more than just the tester and failure count.
1076         Now displays a message for testers where the latest build exited early due to too many
1077         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
1078         store that value in latestBuildInfos.
1079
1080 2011-05-24  Keishi Hattori  <keishi@webkit.org>
1081
1082         Reviewed by Kent Tamura.
1083
1084         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
1085         https://bugs.webkit.org/show_bug.cgi?id=61273
1086
1087         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
1088
1089 2011-05-24  Greg Simon  <gregsimon@chromium.org>
1090
1091         Reviewed by Dimitri Glazkov.
1092
1093         Control Indexeddb backends from LayoutTestController
1094         https://bugs.webkit.org/show_bug.cgi?id=61000
1095
1096         * DumpRenderTree/chromium/LayoutTestController.cpp:
1097         (LayoutTestController::LayoutTestController):
1098         (LayoutTestController::setOverrideIndexedDBBackingStore):
1099         (LayoutTestController::clearAllDatabases):
1100         * DumpRenderTree/chromium/LayoutTestController.h:
1101
1102 2011-05-24  Robert Hogan  <robert@webkit.org>
1103
1104         Reviewed by Ryosuke Niwa.
1105
1106         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
1107         https://bugs.webkit.org/show_bug.cgi?id=61393
1108
1109         * DumpRenderTree/qt/EventSenderQt.h:
1110         * DumpRenderTree/qt/EventSenderQt.cpp:
1111         (getModifiers): static function for interpreting modifiers
1112         (EventSender::mouseDown): Respect keyboard modifiers
1113         (EventSender::keyDown): use new static function
1114         (EventSender::sendOrQueueEvent): whitespace fix
1115
1116 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
1117
1118         Reviewed by Adam Barth.
1119
1120         Adding MHTML reading support.
1121         https://bugs.webkit.org/show_bug.cgi?id=7168
1122
1123         * Scripts/build-webkit:
1124         * Scripts/old-run-webkit-tests:
1125         * Scripts/webkitperl/features.pm:
1126         * Scripts/webkitpy/layout_tests/port/test_files.py:
1127         * Scripts/webkitpy/layout_tests/port/webkit.py:
1128
1129 2011-05-24  Stephen White  <senorblanco@chromium.org>
1130
1131         Reviewed by Kenneth Russell.
1132
1133         Remove most style checks on Source/ThirdParty/glu, since it doesn't
1134         follow WebKit style.
1135         https://bugs.webkit.org/show_bug.cgi?id=61365
1136
1137         * Scripts/webkitpy/style/checker.py:
1138
1139 2011-05-24  Adam Roben  <aroben@apple.com>
1140
1141         Don't allow forcing builds through the build.webkit.org web interface
1142
1143         Someone has been forcing bogus builds.
1144
1145         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1146
1147 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
1148
1149         Reviewed by Adam Roben.
1150
1151         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1152         https://bugs.webkit.org/show_bug.cgi?id=42669
1153
1154         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the
1155         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
1156         Because that case changed the setting.
1157
1158         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1159         (WTR::InjectedBundle::beginTesting):
1160
1161 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1162
1163         Reviewed by Kenneth Rohde Christiansen.
1164
1165         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
1166         https://bugs.webkit.org/show_bug.cgi?id=61052
1167
1168         * Scripts/old-run-webkit-tests:
1169
1170 2011-05-24  Adam Roben  <aroben@apple.com>
1171
1172         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
1173
1174         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
1175         that don't have any failing tests, which isn't useful
1176
1177         Reviewed by David Kilzer.
1178
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
1180         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
1181         instead of name strings.
1182         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
1183         builder names into an array of builders.
1184
1185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1186         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
1187         the most recently completed build, or -1 if there is no such build.
1188         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
1189         in the given build, or -1 if the number could not be determined. Some of this code came from
1190         _getFailingTests.
1191         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
1192         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
1193         getNumberOfFailingTests functions.
1194
1195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1196         (ViewController.prototype._displayTesters): Get the current number of test failures for each
1197         tester and show it in the list. Omit testers that have no failures at all. We keep the
1198         testers and failure counts in an array and sort it before displaying the current data, as
1199         the order in which data will be fetched is unpredictable.
1200
1201 2011-05-23  Tony Chang  <tony@chromium.org>
1202
1203         Reviewed by Ojan Vafai.
1204
1205         [nrwt] don't use NetworkTranslation when uploading results
1206         https://bugs.webkit.org/show_bug.cgi?id=61315
1207
1208         This avoids autoinstalling mechanize.  It didn't matter anyway
1209         because test_results_uploader.py wasn't using mechanize to make the
1210         request so NetworkTransaction::run wasn't doing anything extra
1211         (it only matters if it catches mechanize.HTTPError).
1212
1213         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1214
1215 2011-05-23  Tony Chang  <tony@chromium.org>
1216
1217         Reviewed by Dirk Pranke.
1218
1219         [chromium] fix the rebaseline tool to work with Linux GPU failures
1220         https://bugs.webkit.org/show_bug.cgi?id=61312
1221
1222         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1223
1224 2011-05-23  Darin Adler  <darin@apple.com>
1225
1226         Ignore generated .pyc files in a directory full of python code.
1227
1228         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
1229
1230 2011-05-23  Adam Barth  <abarth@webkit.org>
1231
1232         Reviewed by Eric Seidel.
1233
1234         sheriffbot should give more details about the failures in IRC
1235         https://bugs.webkit.org/show_bug.cgi?id=61233
1236
1237         With this patch, sheriffbot will annonce the set of failing tests,
1238         which might help folks triage the problem.
1239
1240         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1241         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1242
1243 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1244
1245         Unreviewed, rolling out r87078.
1246         http://trac.webkit.org/changeset/87078
1247         https://bugs.webkit.org/show_bug.cgi?id=61294
1248
1249         Patch contains errors and seems likely to break a bunch of
1250         bots (Requested by abarth on #webkit).
1251
1252         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1253         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1254         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1255
1256 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
1257
1258         Reviewed by Ojan Vafai.
1259
1260         Convert json_results_generator.py to output version 4 JSON.
1261         https://bugs.webkit.org/show_bug.cgi?id=60869
1262
1263         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1264         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1265         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1266
1267 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
1268
1269         Reviewed by Adam Barth.
1270
1271         Move generation of shell_command from port to executive
1272         https://bugs.webkit.org/show_bug.cgi?id=61251
1273
1274         After move it's possible to use the code in other places too.
1275
1276         * Scripts/webkitpy/common/config/ports.py:
1277         * Scripts/webkitpy/common/system/executive.py:
1278
1279 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
1280
1281         Reviewed by Darin Adler.
1282
1283         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
1284         https://bugs.webkit.org/show_bug.cgi?id=42669
1285
1286         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
1287
1288         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1289         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1290         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
1291         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1292
1293 2011-05-22  Robert Hogan  <robert@webkit.org>
1294
1295         Reviewed by Kenneth Rohde Christiansen.
1296
1297         Fix policyDelegate in Qt DRT
1298         https://bugs.webkit.org/show_bug.cgi?id=61247
1299
1300         Use the 'policy delegate' implemented in FrameLoaderClient
1301         for layout tests. The partial implementation in DumpRenderTreeQt
1302         is redundant, so remove it.
1303
1304         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1305         (WebCore::WebPage::acceptNavigationRequest):
1306         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1307         (LayoutTestController::waitForPolicyDelegate):
1308
1309 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
1310
1311         Reviewed by Darin Adler.
1312
1313         Use double quotes for filename arguments
1314         https://bugs.webkit.org/show_bug.cgi?id=61250
1315
1316         Windows does not support single quotes on the command line,
1317         so replace them with double quotes.
1318
1319         * Scripts/prepare-ChangeLog:
1320
1321 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
1322
1323         Reviewed by Sam Weinig.
1324
1325         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
1326         https://bugs.webkit.org/show_bug.cgi?id=42550
1327
1328         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
1329
1330         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1331         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1332         Copy the code for pausing animations, FIXME comments and all.
1333         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1334         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1335
1336 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
1337
1338         Reviewed by Stephen White.
1339
1340         Adding myself to the committers list.
1341
1342         * Scripts/webkitpy/common/config/committers.py:
1343
1344 2011-05-19  Adam Roben  <aroben@apple.com>
1345
1346         Test that the WebKit2 UI process doesn't crash when starting a download
1347
1348         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
1349         (preceded by assertion) in fastMalloc when downloading a file
1350
1351         Reviewed by Darin Adler.
1352
1353         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
1354
1355         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
1356         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
1357         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
1358         started, cancel the download, and return a bogus string.
1359
1360         (TestWebKitAPI::setContextDownloadClient):
1361         (TestWebKitAPI::setPagePolicyClient):
1362         Simple helper functions.
1363
1364         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
1365         our policy client, and run until we know that the download was started. If we haven't
1366         crashed, we win!
1367
1368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1369         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1370         * TestWebKitAPI/win/copy-resources.cmd:
1371         Added new files.
1372
1373 2011-05-20  Kent Tamura  <tkent@chromium.org>
1374
1375         Reviewed by Ryosuke Niwa.
1376
1377         Fix style errors in DumpRenderTree/chromium/.
1378         https://bugs.webkit.org/show_bug.cgi?id=61172
1379
1380         * DumpRenderTree/chromium/CppBoundClass.cpp:
1381         (CppBoundClass::getAsCppVariant):
1382         (CppBoundClass::bindToJavascript):
1383         * DumpRenderTree/chromium/CppBoundClass.h:
1384         (CppBoundClass::GetterCallback::~GetterCallback):
1385         (CppBoundClass::CppBoundClass):
1386         (CppBoundClass::Callback::~Callback):
1387         (CppBoundClass::MemberCallback::MemberCallback):
1388         (CppBoundClass::MemberCallback::~MemberCallback):
1389         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
1390         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
1391         * DumpRenderTree/chromium/CppVariant.h:
1392         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1393         (DRTDevToolsAgent::~DRTDevToolsAgent):
1394         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1395         (DRTDevToolsClient::sendFrontendLoaded):
1396         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1397         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1398         (main):
1399         * DumpRenderTree/chromium/EventSender.cpp:
1400         (SavedEvent::SavedEvent):
1401         (EventSender::EventSender):
1402         (EventSender::keyDown):
1403         * DumpRenderTree/chromium/EventSender.h:
1404         * DumpRenderTree/chromium/ImageDiff.cpp:
1405         (Image::Image):
1406         * DumpRenderTree/chromium/LayoutTestController.cpp:
1407         (LayoutTestController::LayoutTestController):
1408         (LayoutTestController::WorkQueue::reset):
1409         (WorkItemBackForward::WorkItemBackForward):
1410         (WorkItemLoadingScript::WorkItemLoadingScript):
1411         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1412         (WorkItemLoad::WorkItemLoad):
1413         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1414         (LayoutTestController::pathToLocalResource):
1415         * DumpRenderTree/chromium/LayoutTestController.h:
1416         (LayoutTestController::WorkItem::~WorkItem):
1417         (LayoutTestController::WorkQueue::WorkQueue):
1418         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1419         (MockSpellCheck::MockSpellCheck):
1420         (MockSpellCheck::~MockSpellCheck):
1421         * DumpRenderTree/chromium/MockSpellCheck.h:
1422         * DumpRenderTree/chromium/NotificationPresenter.h:
1423         (NotificationPresenter::NotificationPresenter):
1424         * DumpRenderTree/chromium/Task.cpp:
1425         (WebTask::WebTask):
1426         * DumpRenderTree/chromium/Task.h:
1427         (TaskList::TaskList):
1428         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1429         (DRTPrinter::DRTPrinter):
1430         (TestShellPrinter::TestShellPrinter):
1431         * DumpRenderTree/chromium/TestNavigationController.cpp:
1432         (TestNavigationEntry::TestNavigationEntry):
1433         (TestNavigationEntry::~TestNavigationEntry):
1434         (TestNavigationController::TestNavigationController):
1435         (TestNavigationController::reload):
1436         (TestNavigationController::loadEntry):
1437         (TestNavigationController::didNavigateToEntry):
1438         * DumpRenderTree/chromium/TestNavigationController.h:
1439         (TestShellExtraData::TestShellExtraData):
1440         * DumpRenderTree/chromium/TestShell.cpp:
1441         (dumpHistoryItem):
1442         * DumpRenderTree/chromium/TestShell.h:
1443         (TestParams::TestParams):
1444         * DumpRenderTree/chromium/TestShellWin.cpp:
1445         (TestShell::waitTestFinished):
1446         * DumpRenderTree/chromium/TestWebWorker.h:
1447         (TestWebWorker::startWorkerContext):
1448         (TestWebWorker::terminateWorkerContext):
1449         (TestWebWorker::postMessageToWorkerContext):
1450         (TestWebWorker::clientDestroyed):
1451         (TestWebWorker::postMessageToWorkerObject):
1452         (TestWebWorker::postExceptionToWorkerObject):
1453         (TestWebWorker::postConsoleMessageToWorkerObject):
1454         (TestWebWorker::confirmMessageFromWorkerObject):
1455         (TestWebWorker::reportPendingActivity):
1456         (TestWebWorker::workerContextClosed):
1457         (TestWebWorker::~TestWebWorker):
1458         * DumpRenderTree/chromium/TextInputController.cpp:
1459         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1460         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1461         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1462         (WebThemeEngineDRTWin::paintButton):
1463         (WebThemeEngineDRTWin::paintMenuList):
1464         (WebThemeEngineDRTWin::paintTrackbar):
1465         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1466         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1467         * DumpRenderTree/chromium/WebViewHost.cpp:
1468         (WebViewHost::navigate):
1469         (WebViewHost::updateSessionHistory):
1470         (WebViewHost::paintInvalidatedRegion):
1471         * DumpRenderTree/chromium/WebViewHost.h:
1472
1473 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1474
1475         Reviewed by Adam Roben.
1476
1477         Detect hangs in run-api-tests
1478         https://bugs.webkit.org/show_bug.cgi?id=48043
1479
1480         * Scripts/run-api-tests: Added test timeouts
1481
1482 2011-05-19  Dmitry Lomov  <dslomov@google.com>
1483
1484         Reviewed by Adam Roben.
1485
1486         run-api-tests should run one test per process
1487         https://bugs.webkit.org/show_bug.cgi?id=61088
1488
1489         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows,
1490         return code, and parsing GTest output format.
1491
1492 2011-05-15  Robert Hogan  <robert@webkit.org>
1493
1494         Reviewed by Antonio Gomes.
1495
1496         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
1497         https://bugs.webkit.org/show_bug.cgi?id=60834
1498         Fix unix test plugin for plugins/get-url-with-javascript-url.html
1499
1500         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1501         (webkit_test_plugin_new_stream):
1502         (webkit_test_plugin_write_ready):
1503         (webkit_test_plugin_write):
1504
1505 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1506
1507         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
1508         http://trac.webkit.org/changeset/86869
1509         http://trac.webkit.org/changeset/86873
1510         http://trac.webkit.org/changeset/86875
1511         http://trac.webkit.org/changeset/86877
1512         https://bugs.webkit.org/show_bug.cgi?id=61139
1513
1514         broke builds and debug DRT (Requested by rniwa on #webkit).
1515
1516         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1517         * DumpRenderTree/chromium/TestShell.cpp:
1518         (TestShell::bindJSObjectsToWindow):
1519         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1520         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1521
1522 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
1523
1524         Reviewed by Darin Adler.
1525
1526         Add build logistics and plumbing for window.internals object.
1527         https://bugs.webkit.org/show_bug.cgi?id=60313
1528
1529         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
1530         * DumpRenderTree/chromium/TestShell.cpp:
1531         (TestShell::bindJSObjectsToWindow): Added injection code.
1532         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1533         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1534
1535 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1536
1537         Reviewed by Csaba Osztrogonác.
1538
1539         [Qt] Implement eventSender.scalePageBy
1540         https://bugs.webkit.org/show_bug.cgi?id=60015
1541
1542         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1543         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1544         * DumpRenderTree/qt/EventSenderQt.cpp:
1545         (EventSender::scalePageBy):
1546         * DumpRenderTree/qt/EventSenderQt.h:
1547
1548 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
1549
1550         Reviewed by Kent Tamura.
1551
1552         [Chromium] IME candidate window appears wrong position in an iframe
1553         https://bugs.webkit.org/show_bug.cgi?id=61023
1554
1555         Call the focused frame's firstRectForCharacterRange() instead of the
1556         main frame so that DRT behaves as the same as Chromium.
1557
1558         * DumpRenderTree/chromium/TextInputController.cpp:
1559         (TextInputController::firstRectForCharacterRange):
1560
1561 2011-05-18  Adam Roben  <aroben@apple.com>
1562
1563         Add a new page to build.webkit.org to help find when tests started failing
1564
1565         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
1566         right now, but already shows some useful information. It's somewhat similar to webkit-patch
1567         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
1568         little more convenient than either of them, though, because it's all done in the browser
1569         (and thus it's easy to go directly to the relevant test results).
1570
1571         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
1572         (Buildbot): This class represents a Buildbot server.
1573         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
1574         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
1575         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
1576         callback.
1577         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
1578         be implemented by a derived class that understands this server's build naming scheme.
1579         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1580         particular build.
1581
1582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
1583         (Builder): This class represents one builder on the buildbot.
1584         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
1585         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
1586         information about a particular test failure.
1587         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
1588         information about when tests started failing.
1589         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
1590         particular build.
1591         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
1592         callback.
1593         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
1594         extracts all the failing tests listed in it, passing them to the callback.
1595         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
1596         build, merges them into the build history, and calls the callback telling it whether the
1597         next build should be fetched to provide more information.
1598
1599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1600         Added. Just some simple styles.
1601
1602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
1603         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
1604         (getResource): Wrapper around XMLHttpRequest.
1605         (Array.prototype.findFirst): Finds the first element matching the given predicate and
1606         returns it.
1607         (Array.prototype.last): Returns the last element of the array.
1608
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
1610         (ViewController): This class contains the main logic for displaying the page.
1611         (ViewController.loaded): Just calls through to parseHash.
1612         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
1613         shows the list of all testers so one can be chosen. This function is called when the page
1614         loads and whenever we get a hashchange event.
1615         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
1616         as it is fetched. The display ends up grouping tests by when they started failing.
1617         (ViewController._displayTesters): Gets the list of testers and displays it.
1618
1619         (ViewController._domForBuildName):
1620         (ViewController._domForFailedTest):
1621         Helper functions to create descriptions and links for a particular build or failed test.
1622
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
1624         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
1625         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
1626
1627         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
1628         loads all the files and sets up a ViewController, which does the rest.
1629
1630         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
1631         page.
1632
1633 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1634
1635         Reviewed by Csaba Osztrogonác.
1636
1637         [Qt] Implement layoutTestController.setValueForUser()
1638         https://bugs.webkit.org/show_bug.cgi?id=60956
1639
1640         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1641         (LayoutTestController::setValueForUser):
1642         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1643
1644 2011-05-16  Robert Hogan  <robert@webkit.org>
1645
1646         Reviewed by Kenneth Rohde Christiansen.
1647
1648         plugins/invalidate_rect.html fails on linux ports
1649
1650         - Make the unix test netscape plugin recognize the onPaintEvent
1651           and windowedPlugin parameters.
1652
1653         https://bugs.webkit.org/show_bug.cgi?id=54051
1654
1655         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1656         (handleEventX11):
1657         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1658         (LayoutTestController::displayInvalidatedRegion):
1659         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1660         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1661         (webkit_test_plugin_new_instance):
1662         (webkit_test_plugin_handle_event):
1663
1664 2011-05-17  Tony Chang  <tony@chromium.org>
1665
1666         Reviewed by Ojan Vafai.
1667
1668         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
1669         https://bugs.webkit.org/show_bug.cgi?id=60895
1670
1671         Update the tools to handle the move.  Lucid 32 results now go in
1672         chromium-linux-x86 and the default platform on Linux is now x86_64.
1673
1674         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
1675         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1676         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
1677         * Scripts/webkitpy/layout_tests/port/base.py: ditto
1678         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
1679         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1680         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
1681         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
1682         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
1683
1684 2011-05-17  Adam Roben  <aroben@apple.com>
1685
1686         Make run-api-tests work on Windows when there are spaces in the path
1687
1688         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
1689         spaces in the path to TestWebKitAPI.exe
1690
1691         Reviewed by David Levin.
1692
1693         * Scripts/run-api-tests:
1694         (runTestTool): Use the "direct object" form of system() to avoid having the path to
1695         TestWebKitAPI.exe be split by the shell.
1696
1697 2011-05-16  Ian Henderson  <ianh@apple.com>
1698
1699         Reviewed by Joseph Pecoraro.
1700
1701         Page::goToItem doesn't work while loading is deferred
1702         https://bugs.webkit.org/show_bug.cgi?id=60412
1703
1704         Add setDefersLoading and goBack methods to LayoutTestController.  We
1705         need to use goBack() instead of history.back() because the latter goes
1706         through NavigationScheduler, hence doesn't exhibit the bug.
1707
1708         * DumpRenderTree/LayoutTestController.cpp:
1709         (goBackCallback):
1710         (setDefersLoadingCallback):
1711         (LayoutTestController::staticFunctions):
1712         * DumpRenderTree/LayoutTestController.h:
1713         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1714         (LayoutTestController::goBack):
1715         (LayoutTestController::setDefersLoading):
1716         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1717         (LayoutTestController::goBack):
1718         (LayoutTestController::setDefersLoading):
1719         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1720         (LayoutTestController::goBack):
1721         (LayoutTestController::setDefersLoading):
1722         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1723         (LayoutTestController::goBack):
1724         (LayoutTestController::setDefersLoading):
1725
1726 2011-05-16  Sam Weinig  <sam@webkit.org>
1727
1728         Reviewed by Anders Carlsson.
1729
1730         TestWebKitAPI should build with clang if it can
1731         https://bugs.webkit.org/show_bug.cgi?id=60918
1732
1733         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1734         Update CompilerVersion.xcconfig to match others.
1735
1736         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1737         Add CompilerVersion.xcconfig to the project.
1738
1739         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1740         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1741         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1742         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1743         Add some casts to quiet warnings from clang.
1744
1745 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
1746
1747         Reviewed by David Levin.
1748
1749         add dpranke as a reviewer
1750         https://bugs.webkit.org/show_bug.cgi?id=60919
1751
1752         * Scripts/webkitpy/common/config/committers.py:
1753
1754 2011-05-16  Robert Hogan  <robert@webkit.org>
1755
1756         Reviewed by Anders Carlsson.
1757
1758         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
1759
1760         https://bugs.webkit.org/show_bug.cgi?id=60838
1761
1762         The unix test plugin needs to call the test's NPP_URLNotify
1763         rather than the browsers.
1764
1765         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1766         (webkit_test_plugin_url_notify):
1767
1768 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
1769
1770         Rubber-stamped by Adam Roben.
1771
1772         Adding myself as a reviewer.
1773         * Scripts/webkitpy/common/config/committers.py:
1774
1775 2011-05-16  Sam Weinig  <sam@webkit.org>
1776
1777         Fix typo pointed out by Dave Levin.
1778
1779         * TestWebKitAPI/PlatformUtilities.h:
1780         (TestWebKitAPI::Util::assertWKStringEqual):
1781         Strig -> String.
1782
1783 2011-05-16  Sam Weinig  <sam@webkit.org>
1784
1785         Reviewed by David Levin.
1786
1787         Convert api tester over to using gtest expectations directly
1788         https://bugs.webkit.org/show_bug.cgi?id=60862
1789
1790         * TestWebKitAPI/PlatformUtilities.cpp:
1791         (TestWebKitAPI::Util::toSTD):
1792         * TestWebKitAPI/PlatformUtilities.h:
1793         (TestWebKitAPI::Util::assertWKStrigEqual):
1794         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
1795         the implementation of the macro simpler.
1796
1797         * TestWebKitAPI/Test.h:
1798         Remove TEST_ASSERT forwarder.
1799
1800         [Test changes elided]
1801
1802 2011-05-16  David Kilzer  <ddkilzer@apple.com>
1803
1804         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
1805         <rdar://problem/9446430>
1806
1807         Reviewed by Mark Rowe.
1808
1809         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
1810         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1811         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1812
1813 2011-05-16  Jon Lee  <jonlee@apple.com>
1814
1815         Reviewed by Simon Fraser.
1816
1817         Can't horizontally scroll iframes and overflow because wheel events are always accepted
1818         https://bugs.webkit.org/show_bug.cgi?id=60779
1819
1820         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1821         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
1822
1823 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1824
1825         Reviewed by Csaba Osztrogonác.
1826
1827         [Qt] Tools.pro misses include(common.pri)
1828         https://bugs.webkit.org/show_bug.cgi?id=60883
1829
1830         It includes features.pri, which depends on common.pri (the build is
1831         not broken today with the default options, but this is the right
1832         thing to do).
1833
1834         * Tools.pro:
1835
1836 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
1837
1838         Unreviewed: adding myself to committers.py.
1839
1840         * Scripts/webkitpy/common/config/committers.py:
1841
1842 2011-05-15  Daniel Bates  <dbates@webkit.org>
1843
1844         Reviewed by Chris Jerdonek.
1845
1846         svn-apply can't handle Git diff that only changes executable bit
1847         https://bugs.webkit.org/show_bug.cgi?id=60848
1848
1849         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
1850         that only has an executable bit change.
1851
1852         * Scripts/VCSUtils.pm:
1853           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
1854         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
1855         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
1856         * Scripts/svn-apply:
1857         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
1858         * Scripts/svn-unapply:
1859         (patch): Ditto.
1860         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1861           - Updated expected results for test cases to account for numTextChunks.
1862           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
1863           - Added test case "Git: file that only has an executable bit change".
1864         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1865           - Updated expected results for test cases to account for numTextChunks.
1866
1867 2011-05-15  Sam Weinig  <sam@webkit.org>
1868
1869         Fix windows build.
1870
1871         * TestWebKitAPI/win/main.cpp:
1872         (main):
1873
1874 2011-05-15  Sam Weinig  <sam@webkit.org>
1875
1876         Reviewed by David Levin.
1877
1878         Make API tester more gtest friendly
1879         https://bugs.webkit.org/show_bug.cgi?id=60859
1880
1881         * Scripts/run-api-tests:
1882         Numerous changes:
1883         - Remove logic to run tests one at a time.
1884         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to
1885           the test runner and allow gtest to print it for us.
1886         - Forward stdout from the test tool to stdout, even in non-verbose runs.
1887         - Run test tool from the current working directory instead of the root webkit
1888           directory.
1889
1890         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1891         Move plist to be with other bundle sources.
1892
1893         * TestWebKitAPI/TestsController.cpp:
1894         (TestWebKitAPI::TestsController::TestsController):
1895         (TestWebKitAPI::TestsController::run):
1896         * TestWebKitAPI/TestsController.h:
1897         * TestWebKitAPI/mac/main.mm:
1898         Simplify TestController down to a single run function. We should consider removing the class
1899         entirely at some point.
1900
1901 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1902
1903         Unreviewed, rolling out r86504.
1904         http://trac.webkit.org/changeset/86504
1905         https://bugs.webkit.org/show_bug.cgi?id=60853
1906
1907         "Broke Qt EventSender in editing/selection tests" (Requested
1908         by mwenge on #webkit).
1909
1910         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1911         (WebCore::WebPage::WebPage):
1912         (WebCore::DumpRenderTree::DumpRenderTree):
1913         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1914         (WebCore::DumpRenderTree::initJSObjects):
1915         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1916         (WebCore::DumpRenderTree::eventSender):
1917         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1918         (webkit_test_plugin_new_instance):
1919         (webkit_test_plugin_set_window):
1920         (webkit_test_plugin_handle_event):
1921
1922 2011-05-12  Robert Hogan  <robert@webkit.org>
1923
1924         Reviewed by Benjamin Poulain.
1925
1926         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
1927
1928         The support for this test added to the unix test plugin here
1929         may allow other platforms to pass it (nearly everyone
1930         skips it). On Qt it required a bit of trickiness with
1931         the page's EventSender object to get it working fully though,
1932         so only unskipping Qt here.
1933
1934         https://bugs.webkit.org/show_bug.cgi?id=60722
1935
1936         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1937         (WebCore::WebPage::WebPage):
1938         (WebCore::WebPage::eventSender):
1939         (WebCore::DumpRenderTree::DumpRenderTree):
1940         (WebCore::DumpRenderTree::initJSObjects):
1941         (WebCore::DumpRenderTree::createWindow):
1942         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1943         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1944         (webkit_test_plugin_new_instance):
1945         (webkit_test_plugin_set_window):
1946         (webkit_test_plugin_handle_event):
1947
1948 2011-05-14  Arno Renevier  <arno@renevier.net>
1949
1950         Reviewed by Martin Robinson.
1951
1952         make run-gtk-tests executable
1953         https://bugs.webkit.org/show_bug.cgi?id=59278
1954
1955         * Scripts/run-gtk-tests:
1956
1957 2011-05-14  Anders Carlsson  <andersca@apple.com>
1958
1959         Reviewed by Kevin Decker.
1960
1961         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1962         https://bugs.webkit.org/show_bug.cgi?id=60823
1963         <rdar://problem/9430386>
1964
1965         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
1966
1967         * DumpRenderTree/DumpRenderTree.gypi:
1968         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1969         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
1970         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
1971         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
1972         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
1973         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1974         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1975         * GNUmakefile.am:
1976
1977 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1978
1979         Unreviewed, rolling out r86476.
1980         http://trac.webkit.org/changeset/86476
1981         https://bugs.webkit.org/show_bug.cgi?id=60832
1982
1983         It made plugins/get-url-notify-with-url-that-fails-to-
1984         load.html crash on GTK (Requested by Ossy on #webkit).
1985
1986         * DumpRenderTree/DumpRenderTree.gypi:
1987         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1988         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
1989         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1990         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1991         * GNUmakefile.am:
1992
1993 2011-05-13  Anders Carlsson  <andersca@apple.com>
1994
1995         Reviewed by Sam Weinig.
1996
1997         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
1998         https://bugs.webkit.org/show_bug.cgi?id=60823
1999         <rdar://problem/9430386>
2000
2001         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
2002
2003         * DumpRenderTree/DumpRenderTree.gypi:
2004         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2005         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
2006         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
2007         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
2008         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
2009         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2010         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2011         * GNUmakefile.am:
2012
2013 2011-05-13  Anders Carlsson  <andersca@apple.com>
2014
2015         Build fix.
2016
2017         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
2018
2019 2011-05-13  Anders Carlsson  <andersca@apple.com>
2020
2021         Reviewed by Sam Weinig.
2022
2023         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
2024         https://bugs.webkit.org/show_bug.cgi?id=60810
2025
2026         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
2027
2028         * DumpRenderTree/DumpRenderTree.gypi:
2029         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2030         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2031         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2032         * GNUmakefile.am:
2033         Add files.
2034
2035         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2036         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2037         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
2038
2039         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
2040         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
2041         (GetURLWithJavaScriptURL::NPP_New):
2042         (GetURLWithJavaScriptURL::NPP_NewStream):
2043         (GetURLWithJavaScriptURL::NPP_DestroyStream):
2044         (GetURLWithJavaScriptURL::NPP_WriteReady):
2045         (GetURLWithJavaScriptURL::NPP_Write):
2046         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2047         (NPP_NewStream):
2048         (NPP_WriteReady):
2049         (NPP_Write):
2050         (NPP_URLNotify):
2051         call the PluginTest NPP wrappers.
2052
2053 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2054
2055         Unreviewed, rolling out r86447.
2056         http://trac.webkit.org/changeset/86447
2057         https://bugs.webkit.org/show_bug.cgi?id=60809
2058
2059         "Broke some uses of EventSender object on Qt" (Requested by
2060         mwenge on #webkit).
2061
2062         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2063         (WebCore::WebPage::WebPage):
2064         (WebCore::DumpRenderTree::DumpRenderTree):
2065         (WebCore::DumpRenderTree::initJSObjects):
2066         (WebCore::DumpRenderTree::createWindow):
2067         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2068         (WebCore::DumpRenderTree::eventSender):
2069         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2070         (webkit_test_plugin_new_instance):
2071         (webkit_test_plugin_set_window):
2072         (webkit_test_plugin_handle_event):
2073
2074 2011-05-13  Robert Hogan  <robert@webkit.org>
2075
2076         Reviewed by Benjamin Poulain.
2077
2078         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
2079
2080         The support for this test added to the unix test plugin here
2081         may allow other platforms to pass it (nearly everyone
2082         skips it). On Qt it required a bit of trickiness with
2083         the page's EventSender object to get it working fully though,
2084         so only unskipping Qt here.
2085
2086         https://bugs.webkit.org/show_bug.cgi?id=60722
2087
2088         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2089         (WebCore::WebPage::WebPage):
2090         (WebCore::WebPage::eventSender):
2091         (WebCore::DumpRenderTree::DumpRenderTree):
2092         (WebCore::DumpRenderTree::initJSObjects):
2093         (WebCore::DumpRenderTree::createWindow):
2094         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2095         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2096         (webkit_test_plugin_new_instance):
2097         (webkit_test_plugin_set_window):
2098         (webkit_test_plugin_handle_event):
2099
2100 2011-05-13  Adam Roben  <aroben@apple.com>
2101
2102         Exclude the Leopard NRWT bot from the core builder set
2103
2104         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
2105
2106         Reviewed by Darin Adler.
2107
2108         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2109         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
2110         in the core builder set.
2111
2112         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2113         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
2114         regexps.
2115
2116 2011-05-13  Adam Roben  <aroben@apple.com>
2117
2118         Group all the NRWT bots together
2119
2120         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
2121         bots are experimental, it seems best not to clutter up the non-experimental bots with
2122         experimental ones.
2123
2124         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
2125         on build.webkit.org
2126
2127         Reviewed by Dan Bernstein.
2128
2129         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
2130         Chromium testers, which also use new-run-webkit-tests.
2131
2132 2011-05-13  Adam Roben  <aroben@apple.com>
2133
2134         Add a plugin test that dumps the plugin window's rect
2135
2136         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
2137         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
2138
2139         Reviewed by Dan Bernstein.
2140
2141         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
2142         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
2143         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
2144         harness window and log it.
2145
2146         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
2147
2148 2011-05-13  Adam Roben  <aroben@apple.com>
2149
2150         Move code required for most tests of plugin window geometry into a base class
2151
2152         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
2153         having all the trickiness in a shared base class, writing new window geometry tests will be
2154         much easier.
2155
2156         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
2157
2158         Reviewed by Anders Carlsson.
2159
2160         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2161         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
2162         WindowGeometryTest base class. Most of the code from this class was moved to the new base
2163         class.
2164         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
2165         This is called by the base class when it is safe to check the window's geometry. Note that
2166         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
2167         just vestigial code from an earlier version of this test.
2168
2169         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
2170         WindowGeometryTest class.
2171
2172         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
2173         WindowRegionIsSetToClipRect.
2174         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
2175         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
2176         Subclasses can implement that function to perform their own tests.
2177
2178         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
2179
2180 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
2181
2182         Reviewed by Csaba Osztrogonác.
2183
2184         Missing 2nd #EOF if WebProcess is killed.
2185         https://bugs.webkit.org/show_bug.cgi?id=60761
2186
2187         If the WebProcess is killed, only one #EOF is yielded
2188         by WebKitTestRunner. However, run-webkit-test wait for
2189         a second #EOF, which signals the finishing of pixel dump.
2190         Since this never happens, run-webkit-test waits forever.
2191
2192         * WebKitTestRunner/TestInvocation.cpp:
2193         (WTR::TestInvocation::dump):
2194         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2195         * WebKitTestRunner/TestInvocation.h:
2196
2197 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2198
2199         Reviewed by Csaba Osztrogonác.
2200
2201         [NRWT] chromium-linux tests shouldn't run on other platforms
2202         https://bugs.webkit.org/show_bug.cgi?id=60162
2203
2204         Remove _tests_for_other_platforms defs because r82753
2205         implemented it properly in the baseclass in webkit.py.
2206
2207         * Scripts/webkitpy/layout_tests/port/gtk.py:
2208         * Scripts/webkitpy/layout_tests/port/qt.py:
2209         * Scripts/webkitpy/layout_tests/port/win.py:
2210
2211 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
2212
2213         Reviewed by Antonio Gomes.
2214
2215         [EFL] Remove unused option of EWeblauncher
2216         https://bugs.webkit.org/show_bug.cgi?id=60747
2217
2218         Remove sudo-workaround option.
2219         This option is not used and make other option wrong.
2220
2221         * EWebLauncher/main.c:
2222
2223 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2224
2225         Reviewed by Stephanie Lewis.
2226
2227         Fix config.json to address missing WK2 builder/tester config.
2228         Fix naming of machines (xserve not macpro)
2229
2230         * BuildSlaveSupport/build.webkit.org-config/config.json:
2231
2232 2011-05-12  Lucas Forschler  <lforschler@apple.com>
2233
2234         Reviewed by Stephanie Lewis.
2235
2236         Add SnowLeopard Debug builder and Test bot.
2237         apple-xserve-8 = SL Debug Tester.
2238         apple-xserve-9 = SL Debug Builder.
2239
2240         * BuildSlaveSupport/build.webkit.org-config/config.json:
2241
2242 2011-05-12  Adam Barth  <abarth@webkit.org>
2243
2244         This patch disables sheriffbot's bug postings.  He's just been way too
2245         spammy recently due to test flakiness.
2246
2247         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2248         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2249
2250 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2251
2252         Reviewed by Anders Carlsson.
2253
2254         After relaunching an unresponsive web process, web page stops responding to mouse movement
2255         https://bugs.webkit.org/show_bug.cgi?id=60669
2256         <rdar://problem/9409934>
2257
2258         This test follows the steps needed to reproduce this bug:
2259         1) Hang the web process
2260         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
2261         3) Kill and restart the WebProcess
2262         4) Move the mouse
2263
2264         We are testing that we receive mouse move events after the WebProcess has restarted.
2265
2266         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
2267         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
2268         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
2269         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
2270         (TestWebKitAPI::setPageLoaderClient):
2271         (TestWebKitAPI::TEST):
2272         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
2273         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
2274         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
2275         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
2276
2277         * TestWebKitAPI/PlatformWebView.h:
2278         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2279         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
2280         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2281         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
2282
2283         Add new files.
2284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2285         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2286         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2287         * TestWebKitAPI/win/copy-resources.cmd:
2288
2289 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
2290
2291         Reviewed by Antonio Gomes.
2292
2293         [EFL] Added initialization/shutdown for ecore_file library
2294         https://bugs.webkit.org/show_bug.cgi?id=60457
2295
2296         Added initialization and shuthown for ecore_file library and replaced
2297         realpath function to ecore_file_realpath.
2298
2299         * EWebLauncher/main.c:
2300         (quit):
2301         (findThemePath):
2302         (main):
2303
2304 2011-05-12  Young Han Lee  <joybro@company100.net>
2305
2306         Reviewed by Kenneth Rohde Christiansen.
2307
2308         [Qt] Implement layoutTestController.layerTreeAsText()
2309         https://bugs.webkit.org/show_bug.cgi?id=60367
2310
2311         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2312         (LayoutTestController::layerTreeAsText):
2313         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2314
2315 2011-05-11  Eric Seidel  <eric@webkit.org>
2316
2317         Reviewed by David Levin.
2318
2319         Teach validate-committer-lists how to validate committers bugzilla_email()
2320         https://bugs.webkit.org/show_bug.cgi?id=60651
2321
2322         It turns out we currently have 9 committers with invalid values for their
2323         bugzilla_email field (meaning we don't know what email is their bugzilla account).
2324         "Alexander Kellett" <lypanov@mac.com>
2325         "Andre Boule" <aboule@apple.com>
2326         "Cameron McCormack" <cam@webkit.org>
2327         "Chris Petersen" <cpetersen@apple.com>
2328         "Eli Fidler" <eli@staikos.net>
2329         "Matt Lilek" <webkit@mattlilek.com>
2330         "Pierre d'Herbemont" <pdherbemont@free.fr>
2331         "Scott Violet" <sky@chromium.org>
2332         "Adam Treat" <treat@kde.org>
2333
2334         Most of those haven't committed in a very long time, so it's not suprising
2335         that we haven't noticed that their bugzilla emails are bogus.
2336
2337         * Scripts/validate-committer-lists:
2338         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2339         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2340
2341 2011-05-11  Dmitry Lomov  <dslomov@google.com>
2342
2343         Reviewed by David Levin.
2344
2345         https://bugs.webkit.org/show_bug.cgi?id=59561
2346         Switch TestWebKitAPI to GTest
2347
2348         Fixes Makefiles and WinCairo build as well
2349
2350         * Makefile:
2351         * Scripts/build-api-tests:
2352         * Scripts/run-api-tests:
2353         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2354         * TestWebKitAPI/Test.h:
2355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2356         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2357         (TestWebKitAPI::TEST):
2358         * TestWebKitAPI/TestsController.cpp:
2359         (TestWebKitAPI::TestsController::TestsController):
2360         (TestWebKitAPI::TestsController::dumpTestNames):
2361         (TestWebKitAPI::TestsController::runTestNamed):
2362         (TestWebKitAPI::TestsController::runAllTests):
2363         * TestWebKitAPI/TestsController.h:
2364         * TestWebKitAPI/mac/main.mm:
2365         (main):
2366
2367 2011-05-11  Eric Seidel  <eric@webkit.org>
2368
2369         Reviewed by Alexey Proskuryakov.
2370
2371         Add Luke Macpherson to committers.py as a Contributor
2372         https://bugs.webkit.org/show_bug.cgi?id=60639
2373
2374         * Scripts/webkitpy/common/config/committers.py:
2375
2376 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
2377
2378         Reviewed by Kenneth Rohde Christiansen.
2379
2380         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
2381         https://bugs.webkit.org/show_bug.cgi?id=60439
2382
2383         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
2384
2385         * Scripts/build-webkit:
2386
2387 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
2388
2389         Reviewed by Adam Roben.
2390
2391         REGRESSION (r86161): WKPreferences API test failing on Windows
2392         https://bugs.webkit.org/show_bug.cgi?id=60658
2393
2394         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2395         (TestWebKitAPI::TEST):
2396
2397 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
2398
2399         Reviewed by Ojan Vafai.
2400
2401         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
2402         https://bugs.webkit.org/show_bug.cgi?id=60521
2403
2404         First steps towards making the results JSON all hierarchical.
2405
2406         * TestResultServer/model/jsonresults.py:
2407         * TestResultServer/model/jsonresults_unittest.py:
2408
2409 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
2410
2411         [wx] Build fix, adding new LayoutTestController method stubs.
2412
2413         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2414         (LayoutTestController::localStorageDiskUsageForOrigin):
2415         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2416
2417 2011-05-11  Jessie Berlin  <jberlin@apple.com>
2418
2419         Reviewed by Darin Adler.
2420
2421         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
2422         about the usage for both the origin overall and the database in question.
2423         https://bugs.webkit.org/show_bug.cgi?id=60573
2424
2425         * WebKitTestRunner/TestController.cpp:
2426         (WTR::exceededDatabaseQuota):
2427
2428 2011-05-10  Stephen White  <senorblanco@chromium.org>
2429
2430         Reviewed by David Levin.
2431
2432         Adding myself as a reviewer.
2433         https://bugs.webkit.org/show_bug.cgi?id=60587
2434
2435         * Scripts/webkitpy/common/config/committers.py:
2436
2437 2011-05-11  Eric Seidel  <eric@webkit.org>
2438
2439         Reviewed by Csaba Osztrogonác.
2440
2441         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
2442         https://bugs.webkit.org/show_bug.cgi?id=60614
2443
2444         AppEngine has a result limit of 1000.  We hit that when trying
2445         to find out how many patches the style-queue (and other queues)
2446         have passed in the last 30 days.  So lets display 1000+ instead
2447         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
2448
2449         I also made the status pages show "never" instead of just "ago" when we
2450         haven't seen a pass or boot message in the last 1000 messages.
2451
2452         * QueueStatusServer/handlers/queuestatus.py:
2453         * QueueStatusServer/templates/queuestatus.html:
2454
2455 2011-05-11  Adam Barth  <abarth@webkit.org>
2456
2457         Reviewed by Eric Seidel.
2458
2459         sheriffbot shouldn't spam bugs when it can't figure out who to blame
2460         https://bugs.webkit.org/show_bug.cgi?id=60613
2461
2462         This patch limits the number of bugs sheriffbot will spam to three.
2463         Ideally, we'd come up with some smarter huerstics, but hopefully this
2464         will cut down on the bugmail spam for slow bots.
2465
2466         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2467
2468 2011-05-10  Eric Seidel  <eric@webkit.org>
2469
2470         Reviewed by Adam Barth.
2471
2472         EWS bots should be robust against test-webkitpy hangs
2473         https://bugs.webkit.org/show_bug.cgi?id=60579
2474
2475         Added a killAfterTimeout subroutine, which takes a child_pid
2476         and timeout, and will setup a watchdog process to kill that child
2477         after the timeout.  killAfterTimeout will waitpid on the child.
2478
2479         * EWSTools/start-queue.sh:
2480
2481 2011-05-10  MORITA Hajime  <morrita@google.com>
2482
2483         Unreviewed, moved myself to the reviewers list.
2484
2485         * Scripts/webkitpy/common/config/committers.py:
2486
2487 2011-05-10  Anton D'Auria  <adauria@apple.com>
2488
2489         Reviewed by David Levin.
2490
2491         StorageTracker should report actual local storage usage on disk
2492         https://bugs.webkit.org/show_bug.cgi?id=60558
2493
2494         * DumpRenderTree/LayoutTestController.cpp:
2495         (localStorageDiskUsageForOriginCallback):
2496         (LayoutTestController::staticFunctions):
2497         * DumpRenderTree/LayoutTestController.h:
2498         * DumpRenderTree/chromium/LayoutTestController.cpp:
2499         (LayoutTestController::LayoutTestController):
2500         (LayoutTestController::localStorageDiskUsageForOrigin):
2501         * DumpRenderTree/chromium/LayoutTestController.h:
2502         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2503         (LayoutTestController::localStorageDiskUsageForOrigin):
2504         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2505         (LayoutTestController::localStorageDiskUsageForOrigin):
2506         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2507         (LayoutTestController::localStorageDiskUsageForOrigin):
2508         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2509         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2510         (LayoutTestController::localStorageDiskUsageForOrigin):
2511
2512 2011-05-10  Anton D'Auria  <adauria@apple.com>
2513
2514         Reviewed by Alexey Proskuryakov.
2515
2516         Add ApplicationCache API to get disk usage per origin
2517         https://bugs.webkit.org/show_bug.cgi?id=57127
2518
2519         Added test that loads two frames with ~15Kb image, checks usage,
2520         deletes app cache, verifies usage is 0.
2521
2522         * DumpRenderTree/LayoutTestController.cpp:
2523         (applicationCacheDiskUsageForOriginCallback):
2524         (LayoutTestController::staticFunctions):
2525         * DumpRenderTree/LayoutTestController.h:
2526         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2527         (LayoutTestController::LayoutTestController):
2528         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2529         * DumpRenderTree/chromium/LayoutTestController.h:
2530         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2531         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2532         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2533         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2534         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2535         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2536         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2537         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2538         (LayoutTestController::applicationCacheDiskUsageForOrigin):
2539
2540 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2541
2542         Unreviewed, adding Rafael Antognolli as a committer.
2543
2544         * Scripts/webkitpy/common/config/committers.py:
2545
2546 2011-05-10  Chris Evans  <cevans@chromium.org>
2547
2548         Reviewed by Adam Barth.
2549
2550         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
2551         https://bugs.webkit.org/show_bug.cgi?id=58378
2552
2553         * DumpRenderTree/chromium/LayoutTestController.cpp:
2554         (LayoutTestController::LayoutTestController):
2555         (LayoutTestController::setAllowDisplayOfInsecureContent):
2556         (LayoutTestController::setAllowRunningOfInsecureContent):
2557         * DumpRenderTree/chromium/LayoutTestController.h:
2558         * DumpRenderTree/chromium/WebPreferences.cpp:
2559         (WebPreferences::reset):
2560         (WebPreferences::applyTo):
2561         * DumpRenderTree/chromium/WebPreferences.h:
2562         Add plumbing for new settings to Chromium DRT.
2563
2564 2011-05-10  Enrica Casucci  <enrica@apple.com>
2565
2566         Reviewed by Beth Dakin.
2567
2568         Added my name to the reviewers list and removed my name from
2569         to committer-only list.
2570
2571         * Scripts/webkitpy/common/config/committers.py:
2572
2573 2011-05-10  David Levin  <levin@chromium.org>
2574
2575         Reviewed by Shinichiro Hamaji.
2576
2577         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
2578         https://bugs.webkit.org/show_bug.cgi?id=60466
2579
2580         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
2581         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
2582           that property was removed.
2583         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
2584           filtering for errors.
2585         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
2586           verify that the line filtering is turned off.
2587         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
2588           and remove the unused file_path parameter.
2589         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
2590           line filtering is turned off (and fix test_no_error).
2591         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
2592           of errors based on the lines changed in the patch.
2593         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
2594           the filtering.
2595
2596 2011-05-10  Adam Roben  <aroben@apple.com>
2597
2598         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
2599
2600         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
2601         platform/win/plugins/window-geometry-initialized-before-set-window.html and
2602         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
2603         (WebKit2 Tests)
2604
2605         Reviewed by Anders Carlsson.
2606
2607         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
2608         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
2609         WindowedPluginTest::testHarnessWindow function.
2610
2611         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
2612         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
2613         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
2614         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
2615         created for.
2616
2617         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
2618         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
2619         WindowedPluginTest, and initialized new members.
2620         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
2621         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
2622         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
2623         then clean up and tell the test harness we're done.
2624         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
2625         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
2626         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
2627         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
2628         window becomes visible.
2629         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
2630         if it was hidden at the start of the test.
2631         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
2632         This should cause our window to become visible and our window region to get set. When we get
2633         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
2634         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
2635         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
2636         "startTest".
2637         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
2638
2639         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
2640         (WindowedPluginTest::testHarnessWindow):
2641         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
2642         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
2643
2644 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2645
2646         Reviewed by Kenneth Rohde Christiansen.
2647
2648         [Qt] Add new qt-4.8 platform for layout testing
2649         https://bugs.webkit.org/show_bug.cgi?id=60544
2650
2651         * Scripts/old-run-webkit-tests:
2652         * Scripts/webkitdirs.pm:
2653
2654 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2655
2656         Unreviewed, rolling out r86108.
2657         http://trac.webkit.org/changeset/86108
2658         https://bugs.webkit.org/show_bug.cgi?id=60533
2659
2660         Broke makefile based builds and Cairo (Requested by weinig on
2661         #webkit).
2662
2663         * Scripts/build-api-tests:
2664         * Scripts/run-api-tests:
2665         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2666         * TestWebKitAPI/Test.h:
2667         (TestWebKitAPI::Test::~Test):
2668         (TestWebKitAPI::Test::name):
2669         (TestWebKitAPI::Test::Register::Register):
2670         (TestWebKitAPI::Test::Register::create):
2671         (TestWebKitAPI::Test::Test):
2672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2673         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2674         (TestWebKitAPI::TEST):
2675         * TestWebKitAPI/TestsController.cpp:
2676         (TestWebKitAPI::TestsController::TestsController):
2677         (TestWebKitAPI::TestsController::dumpTestNames):
2678         (TestWebKitAPI::TestsController::runTestNamed):
2679         (TestWebKitAPI::TestsController::testFailed):
2680         (TestWebKitAPI::TestsController::registerCreateTestFunction):
2681         * TestWebKitAPI/TestsController.h:
2682         * TestWebKitAPI/mac/main.mm:
2683         (main):
2684
2685 2011-05-09  Hayato Ito  <hayato@chromium.org>
2686
2687         Reviewed by Ojan Vafai.
2688
2689         Skip reftests if pixel tests are disabled.
2690
2691         https://bugs.webkit.org/show_bug.cgi?id=59078
2692
2693         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2694         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2695         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2696         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2697
2698 2011-05-09  Chang Shu  <cshu@webkit.org>
2699
2700         Reviewed by Kenneth Rohde Christiansen.
2701
2702         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
2703         https://bugs.webkit.org/show_bug.cgi?id=60499
2704
2705         The implementation is similar to gtk.
2706
2707         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2708         (TextInputController::unmarkText):
2709         * DumpRenderTree/qt/TextInputControllerQt.h:
2710
2711 2011-05-09  James Robinson  <jamesr@chromium.org>
2712
2713         Reviewed by Eric Seidel.
2714
2715         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
2716         https://bugs.webkit.org/show_bug.cgi?id=60520
2717
2718         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2719
2720 2011-05-09  Dmitry Lomov  <dslomov@google.com>
2721
2722         Reviewed by Sam Weinig.
2723
2724         Switch TestWebKitAPI to GTest
2725         https://bugs.webkit.org/show_bug.cgi?id=59561
2726
2727         * Scripts/build-api-tests:
2728         * Scripts/run-api-tests:
2729         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2730         * TestWebKitAPI/Test.h:
2731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2732         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2733         (TestWebKitAPI::TEST):
2734         * TestWebKitAPI/TestsController.cpp:
2735         (TestWebKitAPI::TestsController::TestsController):
2736         (TestWebKitAPI::TestsController::dumpTestNames):
2737         (TestWebKitAPI::TestsController::runTestNamed):
2738         (TestWebKitAPI::TestsController::runAllTests):
2739         * TestWebKitAPI/TestsController.h:
2740         * TestWebKitAPI/mac/main.mm:
2741         (main):
2742
2743 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
2744
2745         Reviewed by Andreas Kling.
2746
2747         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
2748         https://bugs.webkit.org/show_bug.cgi?id=60487
2749
2750         When adding a new touch point, the start position of this point needs to be set.
2751
2752         * DumpRenderTree/qt/EventSenderQt.cpp:
2753         (EventSender::addTouchPoint):
2754
2755 2011-05-09  Robert Hogan  <robert@webkit.org>
2756
2757         Reviewed by Adam Roben.
2758
2759         https://bugs.webkit.org/show_bug.cgi?id=57137
2760
2761         Unskip plugins/embed-prefers-plugins-for-images.html
2762
2763         Add image/png mime-type to test netscape plugin on Unix.
2764
2765         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2766         (NP_GetMIMEDescription):
2767
2768 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
2769
2770         Reviewed by Ojan Vafai.
2771
2772         Pull jsonresults_unittest test cases out into separate test methods.
2773         https://bugs.webkit.org/show_bug.cgi?id=60418
2774
2775         * TestResultServer/model/jsonresults_unittest.py:
2776
2777 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2778
2779         Reviewed by Andreas Kling.
2780
2781         [Qt] fix fast/dom/Geolocation/window-close-crash.html
2782         https://bugs.webkit.org/show_bug.cgi?id=60458
2783
2784         Update all pages with Mock position/error/permission.
2785
2786         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2787         (LayoutTestController::setGeolocationPermission):
2788         (LayoutTestController::setMockGeolocationError):
2789         (LayoutTestController::setMockGeolocationPosition):
2790
2791 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
2792
2793         Reviewed by Tony Gentilcore.
2794
2795         Implement Page Visibility API.
2796         https://bugs.webkit.org/show_bug.cgi?id=54181
2797
2798         * DumpRenderTree/LayoutTestController.cpp:
2799         (setPageVisibilityCallback):
2800         (resetPageVisibilityCallback):
2801         (LayoutTestController::staticFunctions):
2802         * DumpRenderTree/LayoutTestController.h:
2803         (LayoutTestController::setPageVisibility):
2804         (LayoutTestController::resetPageVisibility):
2805         * DumpRenderTree/chromium/LayoutTestController.cpp:
2806         (LayoutTestController::LayoutTestController):
2807         (LayoutTestController::resetPageVisibility):
2808         (LayoutTestController::setPageVisibility):
2809         * DumpRenderTree/chromium/LayoutTestController.h:
2810
2811 2011-05-07  Adam Barth  <abarth@webkit.org>
2812
2813         Reviewed by Eric Seidel.
2814
2815         Testing EWS spins on patches with a large number of failures
2816         https://bugs.webkit.org/show_bug.cgi?id=60441
2817
2818         In cases where the tree has a small number of persistent failures but a
2819         patch has a large number of failures, we weren't believing any results.
2820         That lead to us retrying the patch forever while we waited for
2821         trustworthy results that would never come.
2822
2823         This patch loosens the semantics of unexpected_failures to return a
2824         subset (rather than the exact set) of unexpected failures.  In the case
2825         where the tree has a bounded number of failures and the patch has an
2826         unbounded number of failures, we can accurately compute such a subset
2827         and reject the patch.
2828
2829         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2830         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2831         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2832         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2833         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2834
2835 2011-05-07  Joe Mason  <jmason@rim.com>
2836
2837         Reviewed by Daniel Bates.
2838
2839         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
2840         https://bugs.webkit.org/show_bug.cgi?id=52211
2841
2842         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
2843         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
2844
2845         * DumpRenderTree/chromium/WebViewHost.cpp:
2846         (WebViewHost::willPerformClientRedirect):
2847         (WebViewHost::didStartProvisionalLoad):
2848         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2849         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2850
2851 2011-05-07  Daniel Bates  <dbates@webkit.org>
2852
2853         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
2854         <http://trac.webkit.org/changeset/86007> (bug #60438).
2855
2856         * Scripts/old-run-webkit-tests:
2857           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
2858             file local variable.
2859
2860 2011-05-07  Pratik Solanki  <psolanki@apple.com>
2861
2862         Reviewed by Darin Adler.
2863
2864         Remove references to Tiger in scripts
2865         https://bugs.webkit.org/show_bug.cgi?id=60438
2866
2867         Remove isTiger() and all of the code that depends on it.
2868
2869         * Scripts/build-webkit:
2870         * Scripts/ensure-valid-python:
2871         * Scripts/gdb-safari:
2872         * Scripts/webkitdirs.pm:
2873
2874 2011-05-06  David Grogan  <dgrogan@chromium.org>
2875
2876         Reviewed by Eric Seidel.
2877
2878         update link to message about mac 64bit git binaries
2879         https://bugs.webkit.org/show_bug.cgi?id=60411
2880
2881         The original message implied (correctly, at-the-time) that
2882         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
2883         binaries. The new message notes that they do. This might prevent someone
2884         else from spending a few minutes confused.
2885
2886         * Scripts/webkitpy/common/checkout/scm/git.py:
2887
2888 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
2889
2890         Reviewed by Ojan Vafai.
2891
2892         new-run-webkit-tests: crashes in race with crashing DRT
2893         https://bugs.webkit.org/show_bug.cgi?id=60238
2894
2895         This fixes a race where if we wrote the URL to DRT and
2896         DRT crashed immediately, we could get a broken pipe
2897         error back during the write() and not handle it correctly,
2898         causing NRWT to also crash.
2899
2900         * Scripts/webkitpy/layout_tests/port/server_process.py:
2901         * Scripts/webkitpy/layout_tests/port/webkit.py:
2902
2903 2011-05-06  Adam Barth  <abarth@webkit.org>
2904
2905         Reviewed by Eric Seidel.
2906
2907         Add a --skip-integrationtests mode to test-webkitpy
2908         https://bugs.webkit.org/show_bug.cgi?id=60354
2909
2910         These two test suites account for 2/3 of test-webkitpy's running time
2911         because they're not actually unit tests.  They're integration tests.
2912         This patch adds the ability to skip integration tests by passing a
2913         command line argument to test-webkitpy.  The buildbots will continue to
2914         run these integration tests to make sure they don't regress.  This
2915         option is for use by developers when working on parts of the code that
2916         are well-covered by unit tests.
2917
2918         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
2919         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2920         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
2921         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
2922         * Scripts/webkitpy/test/main.py:
2923
2924 2011-05-06  Adam Barth  <abarth@webkit.org>
2925
2926         Reviewed by Eric Seidel.
2927
2928         The results.zip generated by the Chromium EWS are too big
2929         https://bugs.webkit.org/show_bug.cgi?id=60352
2930
2931         Currently results.zip created by the Chromium EWS bot contain roughly
2932         1000 tests that we expect to fail.  These test results are not helpful
2933         to contributors.
2934
2935         There are several approaches to solving this problem:
2936
2937         1) We could be more selective about which files to include in the zip.
2938         2) We could ask new-run-webkit-tests not to generate results for
2939            expected failures.
2940         3) We could ask new-run-webkit-tests not to run tests that we expect to
2941            fail.
2942
2943         This patch takes approach (3).  Currently, we're ignoring the outcome
2944         of failing tests anyway, so there's not much point in actually running
2945         them.  As a side benefit, this will speed up the test run by about 6%.
2946         In the future, we might revisit this decision and choose another
2947         approach.
2948
2949         * Scripts/webkitpy/common/config/ports.py:
2950         * Scripts/webkitpy/common/config/ports_unittest.py:
2951
2952 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
2953
2954         Reviewed by Csaba Osztrogonác.
2955
2956         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
2957
2958         * Scripts/old-run-webkit-tests:
2959
2960 2011-05-06  Adam Barth  <abarth@webkit.org>
2961
2962         Reviewed by Ojan Vafai.
2963
2964         Add an option to NRWT to skip failing tests
2965         https://bugs.webkit.org/show_bug.cgi?id=60295
2966
2967         This option is similar to the way old-run-webkit-tests works.  We're
2968         planning to use this option on the testing EWS bots because they don't
2969         use information from failing tests yet.
2970
2971         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2972         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2973         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2974
2975 2011-05-04  Philippe Normand  <pnormand@igalia.com>
2976
2977         Reviewed by Dimitri Glazkov.
2978
2979         Implement LayoutTestController::pseudoShadowId()
2980         https://bugs.webkit.org/show_bug.cgi?id=60034
2981
2982         shadowPseudoId support in the various LayoutTestController
2983         implementations.
2984
2985         * DumpRenderTree/LayoutTestController.cpp:
2986         (shadowPseudoIdCallback):
2987         (LayoutTestController::staticFunctions):
2988         * DumpRenderTree/LayoutTestController.h:
2989         * DumpRenderTree/chromium/LayoutTestController.cpp:
2990         (LayoutTestController::LayoutTestController):
2991         (LayoutTestController::shadowPseudoId):
2992         * DumpRenderTree/chromium/LayoutTestController.h:
2993         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2994         (LayoutTestController::shadowPseudoId):
2995         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2996         (LayoutTestController::shadowPseudoId):
2997         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2998         (LayoutTestController::shadowPseudoId):
2999         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3000         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3001         (LayoutTestController::shadowPseudoId):
3002         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3003         (LayoutTestController::shadowPseudoId):
3004         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3005         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3006         (WTR::LayoutTestController::shadowPseudoId):
3007         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3008
3009 2011-05-06  Adam Barth  <abarth@webkit.org>
3010
3011         EWS can't reject patches
3012         https://bugs.webkit.org/show_bug.cgi?id=60345
3013
3014         We're supposed to use patch.id() for the attachment ID, silly.
3015
3016         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3017         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3018
3019 2011-05-05  Steve Lacey  <sjl@chromium.org>
3020
3021         Reviewed by Ojan Vafai.
3022
3023         Fix generation of results html file by passing relative path to scm
3024         methods.
3025         Generate diff images for results html file.
3026
3027         https://bugs.webkit.org/show_bug.cgi?id=60086
3028
3029         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3030         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3031
3032 2011-05-05  Andy Estes  <aestes@apple.com>
3033
3034         Reviewed by Daniel Bates.
3035
3036         update-webkit should handle Internal using a different VCS than OpenSource.
3037         https://bugs.webkit.org/show_bug.cgi?id=60310
3038
3039         isGit() and isSVN() cache their results, so Internal will always be
3040         updated using the VCS commands used for OpenSource. If Internal uses a
3041         different VCS, this will fail. Fix this by calling isGitDirectory() and
3042         isSVNDirectory() instead, which do not cache their results.
3043
3044         * Scripts/update-webkit:
3045
3046 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3047
3048         Reviewed by Ojan Vafai.
3049
3050         nrwt: revamp integration tests incl. tests for servers
3051         https://bugs.webkit.org/show_bug.cgi?id=59985
3052
3053         This change adds the ability to run "integration tests" that
3054         depend on (and affect) the local environment on your machine.
3055         These tests can be run manually by invoking python on the
3056         test file in question and passing the '-i' flag, but are
3057         not run automatically as part of test-webkitpy.
3058
3059         Integration tests are identified by being methods named as
3060         "integration_test_*" instead of "test_*", and we use a
3061         custom TestLoader instead of the default one provided by
3062         unittest.
3063
3064         This change also adds a protected "_default_to_apache" method
3065         to the port object so we can do the right thing when starting
3066         and stopping web servers with less mechanism.
3067
3068         * Scripts/webkitpy/layout_tests/port/base.py:
3069         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3070         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3071         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3072         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3073         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3074
3075 2011-05-05  Adam Roben  <aroben@apple.com>
3076
3077         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
3078
3079         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
3080         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
3081         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
3082         safeguard against this, we fill the alpha channel with constant full opacity after the
3083         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
3084         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
3085         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
3086         results need an alpha channel, too.)
3087
3088         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
3089         generated due to alpha channel weirdness
3090
3091         Reviewed by Sam Weinig.
3092
3093         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3094         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
3095         constant full opacity.
3096         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
3097         in a CGContext or cairo_surface.
3098
3099 2011-05-05  Adam Roben  <aroben@apple.com>
3100
3101         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
3102
3103         Passing true tells the test harness to dump pixels even though we're not dumping a render
3104         tree.
3105
3106         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
3107         WebKitTestRunner doesn't result in pixel results being generated
3108
3109         Reviewed by Sam Weinig.
3110
3111         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
3112         argument to dumpAsText.
3113
3114         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3115         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
3116
3117         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3118         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
3119
3120         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
3121
3122         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
3123         developers.
3124
3125 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3126
3127         Reviewed by Ojan Vafai.
3128
3129         new-run-webkit-tests: merge os, version fields in test config
3130         https://bugs.webkit.org/show_bug.cgi?id=60004
3131
3132         This change removes the 'o/s' field from the TestConfiguration
3133         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
3134         the expectations file to macros that expand to the version names
3135         for each platform.
3136
3137         This means that you can once again put any subset of the
3138         operating system versions on a single line, e.g.:
3139           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
3140
3141         This change will break any existing test_expectations.txt
3142         file that uses the "OS-VERSION" macros, which are no longer
3143         needed. It turns out they were never needed, as just VERSION
3144         by itself was sufficient. The test_expectations.txt file should
3145         be updated accordingly prior to landing this change.
3146
3147         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3148         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3149         * Scripts/webkitpy/layout_tests/port/base.py:
3150
3151 2011-05-05  Tony Chang  <tony@chromium.org>
3152
3153         Reviewed by Adam Barth.
3154
3155         [chromium] switch from Lucida to free fonts for Hindi and Thai
3156         https://bugs.webkit.org/show_bug.cgi?id=60287
3157
3158         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
3159         packages on Lucid. There are actually multiple Thai fonts in the
3160         package, so I just picked one.
3161
3162         * DumpRenderTree/chromium/TestShellGtk.cpp:
3163         (setupFontconfig):
3164
3165 2011-05-05  Tony Chang  <tony@chromium.org>
3166
3167         Reviewed by Ojan Vafai.
3168
3169         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
3170         https://bugs.webkit.org/show_bug.cgi?id=60290
3171
3172         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
3173         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
3174         lucid64.  Because of that, google-chrome-64 used to skip the
3175         chromium-linux-x86_64 results since they were more incorrect.
3176
3177         Now that we're switching to lucid for google-chrome, we want
3178         google-chrome-64 to fall back to chromium-linux-x86_64.
3179
3180         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3181
3182 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
3183
3184         Reviewed by Ojan Vafai.
3185
3186         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
3187         https://bugs.webkit.org/show_bug.cgi?id=60002
3188
3189         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3190         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3191         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3192         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3193         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3194         * Scripts/webkitpy/style/checkers/test_expectations.py:
3195
3196 2011-05-05  Eric Seidel  <eric@webkit.org>
3197
3198         Reviewed by Adam Barth.
3199
3200         commit-queue should reject patches which fail ewses
3201         https://bugs.webkit.org/show_bug.cgi?id=47534
3202
3203         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3204         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3205         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3206
3207 2011-05-05  Chang Shu  <cshu@webkit.org>
3208
3209         Reviewed by Andreas Kling.
3210
3211         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
3212         https://bugs.webkit.org/show_bug.cgi?id=59638
3213
3214         1. Call QGraphicsWKView constructor with pageGroupRef.
3215         2. Disable setFontFamily calls as it breaks Qt test fonts.
3216
3217         * WebKitTestRunner/TestController.cpp:
3218         (WTR::TestController::resetStateToConsistentValues):
3219         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3220         (WTR::WebView::WebView):
3221         (WTR::PlatformWebView::PlatformWebView):
3222
3223 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
3224
3225         Reviewed by David Kilzer.
3226
3227         Add --only-webkit option to build-webkit
3228         https://bugs.webkit.org/show_bug.cgi?id=60245
3229
3230         * Scripts/build-webkit: If --only-webkit was specified
3231         just build the WebKit project, and not its dependencies.
3232
3233 2011-05-05  Jeff Miller  <jeffm@apple.com>
3234
3235         Reviewed by Darin Adler.
3236
3237         Add didNotHandleWheelEvent callback to WKPageUIClient
3238         https://bugs.webkit.org/show_bug.cgi?id=60203
3239
3240         * MiniBrowser/gtk/BrowserWindow.c:
3241         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
3242         * MiniBrowser/mac/BrowserWindowController.m:
3243         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
3244         * MiniBrowser/win/BrowserView.cpp:
3245         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
3246         * WebKitTestRunner/TestController.cpp:
3247         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
3248         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
3249
3250 2011-05-04  Eric Seidel  <eric@webkit.org>
3251
3252         Reviewed by Adam Barth.
3253
3254         Add more missing imports from scm refactor
3255         https://bugs.webkit.org/show_bug.cgi?id=60239
3256
3257         * Scripts/webkitpy/common/checkout/scm/git.py:
3258         * Scripts/webkitpy/common/checkout/scm/svn.py:
3259
3260 2011-05-04  Eric Seidel  <eric@webkit.org>
3261
3262         Reviewed by Adam Barth.
3263
3264         sheriff-bot is having more exception trouble
3265         https://bugs.webkit.org/show_bug.cgi?id=60233
3266
3267         A webpage-forced build was causing SB to throw an exception.
3268         We've long had this bug, but we just didn't notice it until now.
3269
3270         In debugging this I found we fetch an absurd amount of data now
3271         that we use buildbot's json (instead of xmlrpc), so I added
3272         the filter=1 parameter to reduce it a little.  That required
3273         me to handle the case where filter=1 would strip
3274         result=0 in some cases (it's unclear why it does that).
3275
3276         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3277         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3278
3279 2011-05-04  Cris Neckar  <cdn@chromium.org>
3280
3281         Unreviewed, Adding Cris Neckar as a committer
3282
3283         * Scripts/webkitpy/common/config/committers.py:
3284
3285 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3286
3287         Reviewed by Laszlo Gombos.
3288
3289         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
3290         https://bugs.webkit.org/show_bug.cgi?id=59462
3291
3292         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging.
3293
3294 2011-05-04  Eric Seidel  <eric@webkit.org>
3295
3296         Reviewed by Adam Barth.
3297
3298         The testing EWS bots should upload layout-test-results.zip to bugs after failures
3299         https://bugs.webkit.org/show_bug.cgi?id=60223
3300
3301         This required sharing a bit of code between the commit-queue
3302         (which already knew how to do this) and the new EWS testing bots.
3303
3304         In the process I also cleaned up EWS testing a little and
3305         removed some dead code from the commit-queue.
3306
3307         * Scripts/webkitpy/common/config/committervalidator.py:
3308         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3309         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3310         * Scripts/webkitpy/tool/commands/queues.py:
3311         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3312
3313 2011-05-04  James Kozianski  <koz@chromium.org>
3314
3315         Reviewed by Eric Seidel.
3316
3317         Add method to make a Port able to retrieve TestOutputSets from its builders.
3318         https://bugs.webkit.org/show_bug.cgi?id=58211
3319
3320         This will be used in the new rebaseline script - TestOutputs are
3321         potential new baselines.
3322
3323         * Scripts/webkitpy/common/config/urls.py:
3324         * Scripts/webkitpy/layout_tests/port/base.py:
3325         * Scripts/webkitpy/layout_tests/port/chromium.py:
3326         * Scripts/webkitpy/layout_tests/port/factory.py:
3327         * Scripts/webkitpy/layout_tests/port/webkit.py:
3328
3329 2011-05-04  Eric Seidel  <eric@webkit.org>
3330
3331         Reviewed by Ojan Vafai.
3332
3333         sheriff-bot can't parse results.html
3334         https://bugs.webkit.org/show_bug.cgi?id=60196
3335
3336         The problem was that the NRWT bots are currently core
3337         and so sheriff-bot was trying to diagnose failures on
3338         them.  It was trying to parse their results.html file
3339         and BeautifulSoup was throwing an exception.
3340
3341         It seems our version of BeautifulSoup was quite old
3342         and unable to handle <script> tags correctly.
3343         This moves us to 3.2 which doesn't seem to have this bug.
3344
3345         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
3346
3347 2011-05-04  Adam Barth  <abarth@webkit.org>
3348
3349         Reviewed by Eric Seidel.
3350
3351         Make the EWS test logging less verbose
3352         https://bugs.webkit.org/show_bug.cgi?id=60201
3353
3354         This should help us generate less than a hundred MB of logs per hour.
3355
3356         * Scripts/webkitpy/common/config/ports.py:
3357         * Scripts/webkitpy/common/config/ports_unittest.py:
3358
3359 2011-05-04  Tao Bai  <michaelbai@chromium.org>
3360
3361         Reviewed by David Kilzer.
3362
3363         Populate touch-icon url to FrameLoaderClient
3364         https://bugs.webkit.org/show_bug.cgi?id=59143
3365
3366         Disable touch icon by default.
3367
3368         * Scripts/build-webkit:
3369
3370 2011-05-04  Justin Novosad  <junov@chromium.org>
3371
3372         Reviewed by Kenneth Russell.
3373
3374         [Chromium] Add gpu acceleration flags to DumpRenderTree
3375         https://bugs.webkit.org/show_bug.cgi?id=60168
3376         Adding support for command line flags
3377         enable-accelerated-2d-canvas an
3378         enable-accelerated-drawing in DumpRenderTree.
3379
3380         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3381         (main):
3382         * DumpRenderTree/chromium/TestShell.cpp:
3383         (TestShell::TestShell):
3384         (TestShell::resetWebSettings):
3385         * DumpRenderTree/chromium/TestShell.h:
3386         (TestShell::setLegacyAccelerated2dCanvasEnabled):
3387         (TestShell::setAcceleratedDrawingEnabled):
3388         * DumpRenderTree/chromium/WebPreferences.cpp:
3389         (WebPreferences::reset):
3390         (WebPreferences::applyTo):
3391         * DumpRenderTree/chromium/WebPreferences.h:
3392
3393 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3394
3395         Reviewed by Csaba Osztrogonác.
3396
3397         [Qt] run-qtwebkit-tests misses exec bit
3398         https://bugs.webkit.org/show_bug.cgi?id=60188
3399
3400         Also removing an unecessary import (mostly to let this bugfix goes
3401         through the system, as this is just a chmod).
3402
3403         * Scripts/run-qtwebkit-tests:
3404
3405 2011-05-04  Adam Barth  <abarth@webkit.org>
3406
3407         Fix import of ircproxy module to actually import the module.  I don't
3408         really understand how this code could have worked before.
3409
3410         * Scripts/webkitpy/common/host.py:
3411
3412 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
3413
3414         Reviewed by Andreas Kling.
3415
3416         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
3417         https://bugs.webkit.org/show_bug.cgi?id=60172
3418
3419         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
3420         (BrowserWindow::BrowserWindow):
3421
3422 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
3423
3424         Reviewed by Ojan Vafai.
3425
3426         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
3427         https://bugs.webkit.org/show_bug.cgi?id=60088
3428
3429         Makes --new-baseline put new baselines into the first entry in the
3430         baseline search path, including any additional directories passed in via
3431         --additional-platform-directory.
3432
3433         Simplifies baseline_path() by making it return the first entry in the
3434         baseline search path instead of requiring each port to have an
3435         implementation (should not result in any behavior change).
3436
3437         * Scripts/webkitpy/layout_tests/port/base.py:
3438         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3439         * Scripts/webkitpy/layout_tests/port/chromium.py:
3440         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3441         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3442         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3443         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3444         * Scripts/webkitpy/layout_tests/port/mac.py:
3445         * Scripts/webkitpy/layout_tests/port/test.py:
3446         * Scripts/webkitpy/layout_tests/port/webkit.py:
3447
3448 2011-05-04  Adam Barth  <abarth@webkit.org>
3449
3450         Reviewed by Eric Seidel.
3451
3452         Fix circular dependency in webkitpy
3453         https://bugs.webkit.org/show_bug.cgi?id=60075
3454
3455         These functions don't belong in bugzilla.py.  They only exist there
3456         because they are old.  Really, these functions shouldn't be free
3457         functions at all, but that's a patch for another day.
3458
3459         * Scripts/webkitpy/common/checkout/changelog.py:
3460         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3461         * Scripts/webkitpy/common/checkout/checkout.py:
3462         * Scripts/webkitpy/common/config/urls.py:
3463         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3464         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3465         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3466         * Scripts/webkitpy/style/checkers/changelog.py:
3467         * Scripts/webkitpy/tool/bot/irc_command.py:
3468         * Scripts/webkitpy/tool/bot/sheriff.py:
3469         * Scripts/webkitpy/tool/commands/upload.py:
3470
3471 2011-05-03  Pratik Solanki  <psolanki@apple.com>
3472
3473         Reviewed by Dan Bernstein.
3474
3475         https://bugs.webkit.org/show_bug.cgi?id=60141
3476         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
3477
3478         * Scripts/build-webkit:
3479
3480 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
3481
3482         Reviewed by Ojan Vafai.
3483
3484         Update rebaseline queue server to handle hierarchical test results
3485         https://bugs.webkit.org/show_bug.cgi?id=60063
3486
3487         Update test result parsing done by the rebaseline queue server to handle
3488         the hierarchical test result output that is generated as of r85254.
3489
3490         * RebaselineQueueServer/templates/builder-queue-edit.html:
3491
3492 2011-05-03  Eric Seidel  <eric@webkit.org>
3493
3494         Reviewed by Adam Roben.
3495
3496         webkit-patch post-commits HEAD^.. throws an exception
3497         https://bugs.webkit.org/show_bug.cgi?id=60027
3498
3499         * Scripts/webkitpy/common/checkout/scm/git.py:
3500
3501 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
3502
3503         Reviewed by Kenneth Rohde Christiansen.
3504
3505         [Qt] Layout tests may timeout if loadFinished receives false
3506         https://bugs.webkit.org/show_bug.cgi?id=60064
3507
3508         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
3509         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
3510         a response is ignored, like it should be for 204 responses. It is a problem for creating
3511         tests for 204 responses for example.
3512
3513         This change has been tested and it causes no regressions in layout tests.
3514
3515         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3516         (LayoutTestController::maybeDump):
3517
3518 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3519
3520         Unreviewed, rolling out r85659.
3521         http://trac.webkit.org/changeset/85659
3522         https://bugs.webkit.org/show_bug.cgi?id=59977
3523
3524         restarting isn't working correctly
3525
3526         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3527         * Scripts/webkitpy/layout_tests/port/http_server.py:
3528         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3529         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3530
3531 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3532
3533         Reviewed by Ojan Vafai.
3534
3535         new-run-webkit-tests: fix http server startup/shutdown
3536
3537         Previous versions of the code had three problems that made startup
3538         and shutdown flaky. The first is that it would throw exceptions
3539         if it couldn't delete stale log files, which was overly
3540         paranoid. The second is that some of the exceptions weren't
3541         defined properly. The third, and most important, is that it was
3542         using urllib to check if ports were available, which was leaving
3543         sockets in a half-closed state, and keeping ports from being
3544         reused. By switching to raw sockets, we are able to now reliably
3545         restart.
3546
3547         This change also switches the code to using Executives to stop
3548         processes, which will let us delete a bunch of code in the
3549         port/* implementations and fix a weird layering problem in a
3550         subsequent patch.
3551
3552         https://bugs.webkit.org/show_bug.cgi?id=59977
3553
3554         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3555         * Scripts/webkitpy/layout_tests/port/http_server.py:
3556         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3557         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3558
3559 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
3560
3561         Reviewed by Adam Barth.
3562
3563         fix failing printing_unittest on win32
3564         https://bugs.webkit.org/show_bug.cgi?id=59963
3565
3566         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3567
3568 2011-05-03  Adam Roben  <aroben@apple.com>
3569
3570         Fix most strict PassOwnPtr violations on Windows
3571
3572         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
3573         enabled
3574
3575         Reviewed by Anders Carlsson.
3576
3577         * WebKitAPITest/Test.h: Use adoptPtr.
3578
3579 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3580
3581         Reviewed by Andreas Kling.
3582
3583         Add myself to the committers list.
3584
3585         * Scripts/webkitpy/common/config/committers.py:
3586
3587 2011-05-03  James Robinson  <jamesr@chromium.org>
3588
3589         Reviewed by Kenneth Russell.
3590
3591         [chromium] Layout test animations/3d/replace-filling-transform.html failing
3592         https://bugs.webkit.org/show_bug.cgi?id=59839
3593
3594         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
3595
3596         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3597
3598 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3599
3600         Unreviewed, rolling out r85471.
3601         http://trac.webkit.org/changeset/85471
3602         https://bugs.webkit.org/show_bug.cgi?id=59922
3603
3604         The rule of thumb in EFL is that you init in all the places
3605         you use it. So, if in your application you call ecore_evas_*
3606         functions, you have to call ecore_evas_init() first.
3607
3608         * EWebLauncher/main.c: always call *_init() functions when you use
3609         that namespace.
3610         (quit):
3611         (main):
3612
3613 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3614
3615         Reviewed by Tony Chang.
3616
3617         remove no longer used method
3618         https://bugs.webkit.org/show_bug.cgi?id=59981
3619
3620         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3621         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3622
3623 2011-05-02  Ojan Vafai  <ojan@chromium.org>
3624
3625         Reviewed by Tony Chang.
3626
3627         add image toggling behavior from old-run-webkit-tests
3628         https://bugs.webkit.org/show_bug.cgi?id=59978
3629
3630         Output -diffs.html files. This matches old-run-webkit-tests.
3631         In theory, we could use data urls in the results.html file, but
3632         data urls don't currently have access to local files.
3633
3634         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3635
3636 2011-05-02  Tony Chang  <tony@chromium.org>
3637
3638         Reviewed by Ojan Vafai.
3639
3640         [nrwt] remove some obsolete references to .checksum files
3641         https://bugs.webkit.org/show_bug.cgi?id=59971
3642
3643         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3644         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.