a690cc20b6edb839f8b6738e52e7ae6e1d92e11d
[WebKit-https.git] / Tools / ChangeLog
1 2016-05-23  Brady Eidson  <beidson@apple.com>
2
3         check-webkit-style gets flags std::literals::chrono_literals as bad naming.
4         https://bugs.webkit.org/show_bug.cgi?id=157969
5
6         Reviewed by Alex Christensen.
7
8         * Scripts/webkitpy/style/checkers/cpp.py:
9         (check_identifier_name_in_declaration):
10         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
11         (WebKitStyleTest.test_names):
12
13 2016-05-22  Alexey Proskuryakov  <ap@apple.com>
14
15         RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
16         https://bugs.webkit.org/show_bug.cgi?id=157977
17         rdar://problem/20874156
18
19         Reviewed by David Kilzer.
20
21         * WebKitTestRunner/TestInvocation.cpp:
22         (WTR::TestInvocation::invoke): Be more certain to launch a new process when there was
23         a timeout detected. If we don't, there is a chance that the process is not quite frozen,
24         and will still send a response that we no longer expect.
25         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr
26         too, as stdout is not available, at least not in the case that I was observing.
27
28 2016-05-22  Brady Eidson  <beidson@apple.com>
29
30         Move to C++14.
31         https://bugs.webkit.org/show_bug.cgi?id=157948
32
33         Reviewed by Michael Catanzaro.
34
35         * DumpRenderTree/mac/Configurations/Base.xcconfig:
36         * MiniBrowser/Configurations/Base.xcconfig:
37         * TestWebKitAPI/Configurations/Base.xcconfig:
38         * WebKitTestRunner/Configurations/Base.xcconfig:
39
40 2016-05-21  Aakash Jain  <aakash_jain@apple.com>
41
42         Simulator launch fails intermittently due to failure in checking simulator boot status
43         https://bugs.webkit.org/show_bug.cgi?id=157965
44         rdar://problem/26402404
45
46         Reviewed by Alexey Proskuryakov.
47
48         * Scripts/webkitpy/xcode/simulator.py:
49         (Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
50         whether simulator has finished booting.
51
52 2016-05-21  Dan Bernstein  <mitz@apple.com>
53
54         Silence warnings from svn propget when using newer versions of Subversion.
55         https://bugs.webkit.org/show_bug.cgi?id=157879
56
57         Reviewed by Daniel Bates.
58
59         * Scripts/prepare-ChangeLog:
60         (attributeCommand): Redirect svn propget stderr to /dev/null.
61         * Scripts/svn-create-patch:
62         (findMimeType): Ditto.
63
64 2016-05-20  Ryosuke Niwa  <rniwa@webkit.org>
65
66         run-benchmark's results should contain Animometer's debug output
67         https://bugs.webkit.org/show_bug.cgi?id=157941
68
69         Reviewed by Stephanie Lewis.
70
71         Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
72         The result can be dragged and dropped into Animometer's developer.html page.
73
74         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
75         (BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
76         (BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.
77         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
78         Modified the patch to store the debug output.
79         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
80         (ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
81         when the request body is larger than a certain size on twisted.
82
83 2016-05-20  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
84
85         Use clearer names for JSON output of javascriptcore test results
86         https://bugs.webkit.org/show_bug.cgi?id=157921
87
88         Reviewed by Alexey Proskuryakov.
89
90         "failures" and "apiTestResult" were somewhat ambiguous names. 
91         
92         * Scripts/run-javascriptcore-tests:
93         (runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".
94
95 2016-05-20  Chris Dumez  <cdumez@apple.com>
96
97         Unreviewed, fix API test introduced in r201213.
98
99         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
100         (TestWebKitAPI::TEST):
101
102 2016-05-20  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
103
104         Implement operator== for WeakPtr
105         https://bugs.webkit.org/show_bug.cgi?id=157883
106
107         Reviewed by Chris Dumez.
108
109         Implement operator== and operator!= for WeakPtr and update code to use the operators.
110
111         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
112         (TestWebKitAPI::TEST):
113
114 2016-05-19  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
115
116         Add JSON results to 32-bit and CLoop JSC tests
117         https://bugs.webkit.org/show_bug.cgi?id=157929
118
119         Reviewed by Alexey Proskuryakov.
120
121         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
122         (RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
123         (Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
124
125 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
126
127         Typo fix in import-test262-tests
128         https://bugs.webkit.org/show_bug.cgi?id=157902
129
130         Reviewed by Keith Miller.
131
132         * Scripts/import-test262-tests:
133
134 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
135
136         [EFL] Fix the gst-libav build on ARM Thumb2 after r199649
137         https://bugs.webkit.org/show_bug.cgi?id=157893
138
139         Reviewed by Antonio Gomes.
140
141         * efl/patches/gst-libav.patch:
142
143 2016-05-19  Jer Noble  <jer.noble@apple.com>
144
145         REGRESSION(r200951): VideoControlsManager API tests time out
146         https://bugs.webkit.org/show_bug.cgi?id=157896
147         <rdar://problem/26326293>
148
149         Reviewed by Eric Carlson.
150
151         Explicitly disable user gesture requirements for playback.
152
153         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
154         (TestWebKitAPI::TEST):
155
156 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
157
158         Slow JSC stress tests times out in 32 bit debug mode
159         https://bugs.webkit.org/show_bug.cgi?id=154964
160
161         Reviewed by Michael Catanzaro.
162
163         * Scripts/run-javascriptcore-tests:
164         (runJSCStressTests): Pass through the --debug option.
165         * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
166
167 2016-05-18  Aakash Jain  <aakash_jain@apple.com>
168
169         Remove underline from Status Bubbles on dashboard
170         https://bugs.webkit.org/show_bug.cgi?id=157870
171         rdar://problem/26332321
172
173         Reviewed by Alexey Proskuryakov.
174
175         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style 
176         change made in http://trac.webkit.org/r200880
177
178 2016-05-18  Michael Saboff  <msaboff@apple.com>
179
180         r199812 broke test262
181         https://bugs.webkit.org/show_bug.cgi?id=157595
182
183         Reviewed by Filip Pizlo.
184
185         Added a new run type, runOneLargeHeap, for tests that use a large amount of memory.
186         This run type will not run with the --memory-limited option.  Without that option,
187         we'll only the default test variant.
188
189         * Scripts/run-jsc-stress-tests:
190
191 2016-05-18  Simon Fraser  <simon.fraser@apple.com>
192
193         REGRESSION (r200534) Command-+ no longer zooms pages 
194         https://bugs.webkit.org/show_bug.cgi?id=157826
195         rdar://problem/26334636
196
197         Reviewed by Dean Jackson.
198
199         * DumpRenderTree/mac/DumpRenderTree.mm:
200         (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).
201
202 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
203
204         [GTK] accessibility/meter-element.html is failing
205         https://bugs.webkit.org/show_bug.cgi?id=115633
206
207         Reviewed by Chris Fleizach.
208
209         Implement AccessibilityUIElement::valueDescription() and add mapping
210         from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
211
212         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
213         (WTR::AccessibilityUIElement::valueDescription):
214
215 2016-05-18  Brady Eidson  <beidson@apple.com>
216
217         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
218         https://bugs.webkit.org/show_bug.cgi?id=157823
219
220         Reviewed by Alex Christensen.
221
222         * DumpRenderTree/mac/TestRunnerMac.mm:
223         (TestRunner::clearAllDatabases):
224         
225         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
226         (WTR::TestRunner::clearAllDatabases):
227         
228         * WebKitTestRunner/TestInvocation.cpp:
229         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
230
231 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
232
233         AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
234         https://bugs.webkit.org/show_bug.cgi?id=157822
235
236         Reviewed by Chris Fleizach.
237
238         Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
239         nullptr upon failure.
240
241         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
242         (WTR::AccessibilityUIElement::helpText):
243
244 2016-05-17  Beth Dakin  <bdakin@apple.com>
245
246         Make handleAcceptedCandidate a public function
247         https://bugs.webkit.org/show_bug.cgi?id=157763
248         -and corresponding-
249         rdar://problem/26206397
250
251         Reviewed by Tim Horton.
252
253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
254         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added.
255         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added.
256         (-[DoNotLeakWebView dealloc]):
257         (-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
258         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
259         (TestWebKitAPI::TEST):
260
261 2016-05-17  Keith Miller  <keith_miller@apple.com>
262
263         Add test262 harness support code
264         https://bugs.webkit.org/show_bug.cgi?id=157797
265
266         Reviewed by Filip Pizlo.
267
268         The import-test262-tests script is used to generate the yaml file used to run test262. It
269         takes a path to the local copy of the Test262 repository as well as an optional path to file
270         containing a list of failures. This script currently just creates the yaml file used to run
271         the script. It does not relocate the test files into our tests directory. In the future I
272         plan to add that feature but it didn't seem essential for the first iteration. Since many
273         test262 tests need to be run in both strict and non-strict mode, import-test262-tests
274         creates two separate runs for those tests. This enables us to distinguish between failures
275         in only one of the two modes.
276
277         This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order
278         to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262
279         takes an actual test file along with the metadata associated with it. prepareTest262Fixture
280         takes a fixture file (used by module tests for importing) and makes sure that file is
281         properly relocated to the test runner directory.
282
283         The proccess I used to import the tests was to first run import-test262-tests to create a
284         yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is
285         passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the
286         output to a file and collected all the lines with "FAIL" in it. Finally, I reran
287         import-test262-tests with the new failure file to create the final yaml.
288
289         * Scripts/import-test262-tests: Added.
290         * Scripts/run-jsc-stress-tests:
291
292 2016-05-16  Enrica Casucci  <enrica@apple.com>
293
294         build fix after r200968 and r200969
295
296         Unreviewed.
297
298         * DumpRenderTree/mac/EventSendingController.mm:
299         (-[EventSendingController keyDown:withModifiers:withLocation:]):
300
301 2016-05-16  Jer Noble  <jer.noble@apple.com>
302
303         API test WebKit2.MSEIsPlayingAudio timing out after r200951
304         https://bugs.webkit.org/show_bug.cgi?id=157748
305
306         Reviewed by Eric Carlson.
307
308         The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the
309         "user gesture" check fails at that point.  Call play() up front; playback will begin as soon
310         as enough data is loaded.
311
312         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html:
313
314 2016-05-16  Enrica Casucci  <enrica@apple.com>
315
316         Remove unused initializer for WebEvent on iOS.
317         https://bugs.webkit.org/show_bug.cgi?id=157689
318
319         Reviewed by Anders Carlsson.
320
321         Adopting different initializer for WebEvent to fix the build.
322
323         * DumpRenderTree/mac/EventSendingController.mm:
324         (-[EventSendingController keyDown:withModifiers:withLocation:]):
325
326 2016-05-16  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
327
328         Add machine-readable results for JSC API tests to the Buildbot json log
329         https://bugs.webkit.org/show_bug.cgi?id=157642
330
331         Reviewed by Geoffrey Garen.
332
333         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
334         (RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests
335         * Scripts/run-javascriptcore-tests:
336         (runJSCStressTests): Abstracted out writing JSON to file (new function below)
337         (writeJsonDataIfApplicable): Added
338
339 2016-04-06  Jer Noble  <jer.noble@apple.com>
340
341         [WK2] Add API to WKWebViewConfiguration to control autoplay policy.
342         https://bugs.webkit.org/show_bug.cgi?id=156312
343
344         Reviewed by Dan Bernstein.
345
346         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
347         (WTR::initializeWebViewConfiguration):
348         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
349         (TEST_F):
350
351 2016-05-16  Brent Fulgham  <bfulgham@apple.com>
352
353         REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays
354         https://bugs.webkit.org/show_bug.cgi?id=157630
355         <rdar://problem/25277577>
356
357         Reviewed by Simon Fraser.
358
359         Update test infrastructure to support checking the number of images in the pasteboard.
360
361         * DumpRenderTree/TestRunner.cpp:
362         (imageCountInGeneralPasteboardCallback): Added.
363         (TestRunner::staticFunctions):
364         * DumpRenderTree/TestRunner.h:
365         * DumpRenderTree/mac/TestRunnerMac.mm:
366         (TestRunner::imageCountInGeneralPasteboard): Added.
367         * DumpRenderTree/win/TestRunnerWin.cpp:
368         (TestRunner::imageCountInGeneralPasteboard): Added stub method.
369         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
370         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
371         (WTR::InjectedBundle::imageCountInGeneralPasteboard): Added.
372         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
373         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
374         (WTR::TestRunner::imageCountInGeneralPasteboard): Added.
375         * WebKitTestRunner/InjectedBundle/TestRunner.h:
376         * WebKitTestRunner/TestController.cpp:
377         (WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation.
378         * WebKitTestRunner/TestController.h:
379         * WebKitTestRunner/TestInvocation.cpp:
380         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message.
381         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
382         (WTR::TestController::imageCountInGeneralPasteboard): Added.
383
384 2016-05-13  Dewei Zhu  <dewei_zhu@apple.com>
385
386         Fix JSBench which causes math domain error in run-benchmark script.
387         https://bugs.webkit.org/show_bug.cgi?id=157697
388         <rdar://problem/26279292>
389
390         Reviewed by Ryosuke Niwa.
391
392         Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
393         Also fix a round-off error while calculating stdev.
394
395         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
396         (BenchmarkResults._format_values):
397         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
398
399 2016-05-13  Brady Eidson  <beidson@apple.com>
400
401         Extend protector naming code style guideline to cover operator= assignment.
402         https://bugs.webkit.org/show_bug.cgi?id=157693
403
404         Reviewed by Darin Adler.
405
406         * Scripts/webkitpy/style/checkers/cpp.py:
407         (check_identifier_name_in_declaration):
408         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
409         (WebKitStyleTest.test_names):
410
411 2016-05-13  Aakash Jain  <aakash_jain@apple.com>
412
413         Dashboard code restructuring
414         https://bugs.webkit.org/show_bug.cgi?id=157680
415         <rdar://problem/14736888>
416
417         Reviewed by Alexey Proskuryakov.
418
419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
420         (BubbleQueueView.prototype.addLinkToRow): Moved to base class.
421         (BubbleQueueView.prototype.addTextToRow): Moved to base class.
422         (BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
424         (BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
426         (BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
428         (BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
430         (BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
431         additional argument.
432         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
433         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
434         (BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
435         (BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
437         (documentReady): Display any customView if available.
438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
439         (QueueView.prototype.addLinkToRow): Moved from child class, no changes.
440         (QueueView.prototype.addTextToRow): Moved from child class, no changes.
441         (QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
442         (QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
443         by taking latestIterationGetter method as an argument.
444         (QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
445         (QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
446         (QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
448         (a:hover:link): Underline only when there is a link.
449
450 2016-05-13  Yoav Weiss  <yoav@yoav.ws>
451
452         Turn on WEB_TIMING for all ports
453         https://bugs.webkit.org/show_bug.cgi?id=157673
454
455         Reviewed by Alex Christensen.
456
457         * Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.
458
459 2016-05-13  Brady Eidson  <beidson@apple.com>
460
461         Protector Ref/RefPtrs should have a specified naming style.
462         https://bugs.webkit.org/show_bug.cgi?id=157591
463
464         Reviewed by Darin Adler.
465
466         * Scripts/webkitpy/style/checkers/cpp.py:
467         (check_identifier_name_in_declaration):
468         (CppChecker):
469         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
470         (WebKitStyleTest.test_names):
471
472 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
473
474         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
475         https://bugs.webkit.org/show_bug.cgi?id=157564
476
477         Reviewed by Darin Adler.
478
479         * Scripts/webkitperl/FeatureList.pm:
480         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
481
482 2016-05-11  Joanmarie Diggs  <jdiggs@igalia.com>
483
484         [GTK] accessibility/aria-readonly.html is failing
485         https://bugs.webkit.org/show_bug.cgi?id=98357
486
487         Reviewed by Chris Fleizach.
488
489         Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
490         AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
491         ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
492         with range verification for inputs which implement AtkValue. The latter two
493         additions are admittedly a heuristic workaround for platform accessibility
494         API differences. But they should be sufficient to facilitate cross-platform
495         testing of isAttributeSettable() for form elements which lack ARIA attributes.
496
497         Bump the minimum version of at-spi2-core and at-spi2-atk
498         to 2.15.4 (earliest version that supports STATE_READ_ONLY).
499
500         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
501         (WTR::AccessibilityUIElement::isAttributeSettable):
502         * gtk/jhbuild.modules:
503
504 2016-05-10  Ryan Haddad  <ryanhaddad@apple.com>
505
506         Another attempt to fix the build after r200668.
507
508         Unreviewed build fix.
509
510         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
511         (TEST):
512
513 2016-05-10  Dan Bernstein  <mitz@apple.com>
514
515         Tried to fix the Mac build after r200668.
516
517         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
518         (WTR::TestController::platformCreateWebView):
519
520 2016-05-10  Sam Weinig  <sam@webkit.org>
521
522         Tweak underline style for data detected links
523         https://bugs.webkit.org/show_bug.cgi?id=157546
524
525         Reviewed by Tim Horton.
526
527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
528         * TestWebKitAPI/Tests/WebCore/Color.cpp: Added.
529         (TestWebKitAPI::TEST):
530         Add tests for the new Color::getHSV() function.
531
532 2016-05-10  Filip Pizlo  <fpizlo@apple.com>
533
534         Internal JSC profiler should have a timestamped log of events for each code block
535         https://bugs.webkit.org/show_bug.cgi?id=157538
536
537         Reviewed by Benjamin Poulain.
538
539         * Scripts/display-profiler-output:
540
541 2016-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
542
543         [Linux] Remove seccomp filters support
544         https://bugs.webkit.org/show_bug.cgi?id=157380
545
546         Reviewed by Darin Adler.
547
548         * Scripts/webkitperl/FeatureList.pm:
549         * TestWebKitAPI/PlatformEfl.cmake:
550         * TestWebKitAPI/PlatformGTK.cmake:
551         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed.
552         * efl/jhbuild.modules:
553         * gtk/jhbuild.modules:
554
555 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
556
557         [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling
558         https://bugs.webkit.org/show_bug.cgi?id=157496
559         rdar://problem/22963278
560
561         Reviewed by Tim Horton.
562
563         Enhance UIScriptController to generate a drag, which is useful for scrolling.
564
565         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
566         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
567         (WTR::UIScriptController::dragFromPointToPoint):
568         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
569         * WebKitTestRunner/ios/HIDEventGenerator.h:
570         * WebKitTestRunner/ios/HIDEventGenerator.mm:
571         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
572         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
573         (WTR::UIScriptController::dragFromPointToPoint):
574
575 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
576
577         Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
578         https://bugs.webkit.org/show_bug.cgi?id=157480
579
580         Reviewed by Zalan Bujtas.
581
582         Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
583         and move it next to the other iOS text autosizing tests.
584         
585         Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
586
587         * DumpRenderTree/TestRunner.cpp:
588         (setTextAutosizingEnabledCallback): Deleted.
589         (TestRunner::staticFunctions): Deleted.
590         * DumpRenderTree/mac/TestRunnerMac.mm:
591         (TestRunner::setTextAutosizingEnabled): Deleted.
592
593 2016-05-07  Darin Adler  <darin@apple.com>
594
595         Next step on dictionary bindings, along with other bindings refinements
596         https://bugs.webkit.org/show_bug.cgi?id=157451
597
598         Reviewed by Chris Dumez.
599
600         * Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.
601         Also skip test expectations in a directory that this was modifying unnecessarily.
602
603 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
604
605         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
606         https://bugs.webkit.org/show_bug.cgi?id=157432
607         rdar://problem/16406720
608
609         Reviewed by Dean Jackson.
610
611         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
612
613         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
614         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
615         These two settings are shared with TEXT_AUTOSIZING.
616
617         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
618
619         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
620         without changes.
621
622         An implication of this set of changes is that the way clients enable text autosizing
623         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
624         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
625         on iPhone only, not iPad.
626
627         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
628         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
629
630         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
631         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
632         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
633
634         * DumpRenderTree/mac/DumpRenderTree.mm:
635         (resetWebPreferencesToConsistentValues):
636         * DumpRenderTree/mac/TestRunnerMac.mm:
637         (TestRunner::setTextAutosizingEnabled):
638         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
639         * WebKitTestRunner/ios/TestControllerIOS.mm:
640         (WTR::TestController::platformResetPreferencesToConsistentValues):
641
642 2016-05-06  Dean Jackson  <dino@apple.com>
643
644         Regions, Shapes and Tracks don't need runtime features
645         https://bugs.webkit.org/show_bug.cgi?id=157426
646         <rdar://problem/26146262>
647
648         Reviewed by Simon Fraser.
649
650         The following RuntimeEnabledFeatures can be removed since
651         we have no need to disable them (they are stable and have
652         shipped for a while):
653         - CSS Regions
654         - CSS Shapes
655         - Media tracks
656
657         * DumpRenderTree/mac/DumpRenderTree.mm:
658         (resetWebPreferencesToConsistentValues): Deleted.
659
660 2016-05-06  Ryan Haddad  <ryanhaddad@apple.com>
661
662         Increase delay when launching multiple ios-simulators in parallel
663         https://bugs.webkit.org/show_bug.cgi?id=157422
664
665         Reviewed by Alexey Proskuryakov.
666
667         Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening
668         this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue.
669
670         * Scripts/webkitpy/port/ios.py:
671         (IOSSimulatorPort.setup_test_run):
672
673 2016-05-06  Per Arne Vollan  <peavo@outlook.com>
674
675         [Win] Remove WinXP support.
676         https://bugs.webkit.org/show_bug.cgi?id=157416
677
678         Reviewed by Brent Fulgham.
679
680         * win/DLLLauncher/DLLLauncherMain.cpp:
681         (enableTerminationOnHeapCorruption):
682
683 2016-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
684
685         [css-grid] Unprefix CSS Grid Layout properties
686         https://bugs.webkit.org/show_bug.cgi?id=157137
687
688         Reviewed by Simon Fraser.
689
690         Remove "-webkit" prefix from all the grid layout properties,
691         including the display value.
692         Update the source code to remove the prefix where it was used too.
693
694         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
695         (TestWebKitAPI::TEST):
696
697 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
698
699         Partially revert http://trac.webkit.org/r200504
700         Improve HTTP test names in WebKitTestRunner's crash report information
701         https://bugs.webkit.org/show_bug.cgi?id=157389
702
703         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs
704         in crash reporter information.
705
706 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
707
708         Improve HTTP test names in WebKitTestRunner's crash report information
709         https://bugs.webkit.org/show_bug.cgi?id=157389
710
711         Reviewed by Alex Christensen.
712
713         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
714         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
715
716         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
717         (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
718         use other port numbers too. For http tests, return the complete URL string, not
719         just the path.
720
721 2016-05-04  Alex Christensen  <achristensen@webkit.org>
722
723         Blocked redirected main resource requests need descriptive errors
724         https://bugs.webkit.org/show_bug.cgi?id=156828
725         rdar://problem/25711316
726
727         Reviewed by Daniel Bates.
728
729         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
730         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
731         Print out the error type to make sure we have the most descriptive error type.
732
733 2016-05-05  Enrique Ocaña González  <eocanha@igalia.com>
734
735         [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
736         https://bugs.webkit.org/show_bug.cgi?id=157341
737
738         Reviewed by Xabier Rodriguez-Calvar.
739
740         * gtk/jhbuild.modules:
741         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
742         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
743
744 2016-05-04  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
745
746         Add JSC test results in JSON format to a Buildbot log
747         https://bugs.webkit.org/show_bug.cgi?id=156920
748
749         Reviewed by Daniel Bates.
750
751         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
752         (RunJavaScriptCoreTests): Move command-line option for output file out
753         of WithProperties.
754
755 2016-05-04  Dean Jackson  <dino@apple.com>
756
757         TestRunner should always enable all the experimental features
758         https://bugs.webkit.org/show_bug.cgi?id=157360
759         <rdar://problem/26099748>
760
761         Reviewed by Anders Carlsson.
762
763         Call the new SPI that enables all the experimental features.
764
765         * WebKitTestRunner/TestController.cpp:
766         (WTR::TestController::resetPreferencesToConsistentValues):
767
768 2016-05-04  Mark Lam  <mark.lam@apple.com>
769
770         ES6 Function.name inferred from property names of literal objects can break some websites.
771         https://bugs.webkit.org/show_bug.cgi?id=157246
772
773         Reviewed by Geoffrey Garen.
774
775         * WebKitTestRunner/TestController.cpp:
776         (WTR::TestController::resetPreferencesToConsistentValues):
777         (WTR::updateTestOptionsFromTestHeader):
778         * WebKitTestRunner/TestOptions.h:
779
780         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
781         (WTR::PlatformWebView::viewSupportsOptions):
782         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
783         (WTR::PlatformWebView::viewSupportsOptions):
784         - Add needsSiteSpecificQuirks to WKTR options that can be set. 
785
786 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
787
788         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
789         https://bugs.webkit.org/show_bug.cgi?id=157331
790
791         Reviewed by Chris Fleizach.
792
793         Add AXLandmarkRegion to the landmark strings handled by roleToString
794         for objects with ATK_ROLE_LANDMARK.
795
796         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
797
798 2016-05-03  Beth Dakin  <bdakin@apple.com>
799
800         Add VideoControlsManager tests
801         https://bugs.webkit.org/show_bug.cgi?id=157332
802         -and corresponding-
803         rdar://problem/24358431
804
805         Reviewed by Sam Weinig.
806
807         This patch adds three VideoControlsManager tests.
808
809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
810         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
811         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
812         (-[DidPlayMessageHandler initWithWKWebView:]):
813         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
814         (TestWebKitAPI::TEST):
815         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
816         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
817         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
818
819 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
820
821         [ATK] accessibility/document-attributes.html is failing
822         https://bugs.webkit.org/show_bug.cgi?id=125348
823
824         Reviewed by Chris Fleizach.
825
826         The test was failing because the WebArea is now being exposed with the role of
827         ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
828         change was made, documentEncoding() and documentURI() were not updated accordingly.
829
830         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
831         (WTR::AccessibilityUIElement::documentEncoding):
832         (WTR::AccessibilityUIElement::documentURI):
833
834 2016-05-03  Brent Fulgham  <bfulgham@apple.com>
835
836         [Win] Unreviewed build fix.
837
838         * EWSTools/start-queue-win.sh: Establish proper VS2015 build
839         environment at start of queue run.
840
841 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
842
843         [ATK] accessibility/content-editable-as-textarea.html fails
844         https://bugs.webkit.org/show_bug.cgi?id=155353
845
846         Reviewed by Darin Adler.
847
848         The test was timing out because it expected an AXValueChanged notification.
849         In ATK, AXValueChanged notifications are made for widgets which implement
850         the AtkValue interface (sliders, progress bars, etc.). We should be listening
851         for AXTextChanged instead. AtkText's text-insert and text-remove have been
852         added to the AccessibilityNotificationHandler.
853
854         Also, ATK's AccessibilityUIElement support had a number of unimplemented
855         methods that are being used as part of the previously-failing test. Those
856         methods are now implemented so that the ATK results are much more similar
857         to those on the Mac.
858
859         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
860         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
861         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
862         (WTR::AccessibilityUIElement::stringAttributeValue):
863         (WTR::AccessibilityUIElement::rangeForLine):
864         (WTR::AccessibilityUIElement::boundsForRange):
865         (WTR::AccessibilityUIElement::attributedStringForRange):
866
867 2016-05-02  Brady Eidson  <beidson@apple.com>
868
869         Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
870         https://bugs.webkit.org/show_bug.cgi?id=157274
871
872         Reviewed by Alex Christensen.
873
874         Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
875         and reset them in between tests:
876         * DumpRenderTree/TestRunner.cpp:
877         (accummulateLogsForChannel):
878         (TestRunner::staticFunctions):
879         (TestRunner::waitToDumpWatchdogTimerFired):
880         (TestRunner::setAccummulateLogsForChannel):
881         * DumpRenderTree/TestRunner.h:
882         * DumpRenderTree/mac/DumpRenderTree.mm:
883         (resetWebViewToConsistentStateBeforeTesting):
884
885         Also add the new method to WKTR's TestRunner, but just stubbed for now:
886         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
887         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
888         (WTR::TestRunner::accummulateLogsForChannel):
889         * WebKitTestRunner/InjectedBundle/TestRunner.h:
890
891 2016-05-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
892
893         Add fail-fast option to run-javascriptcore-tests
894         https://bugs.webkit.org/show_bug.cgi?id=157270
895
896         Reviewed by Geoffrey Garen.
897
898         * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
899         Defaults to yes, which is the current behavior.
900
901 2016-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
902
903         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
904         https://bugs.webkit.org/show_bug.cgi?id=157268
905
906         Reviewed by Michael Catanzaro.
907
908         * MiniBrowser/gtk/CMakeLists.txt:
909
910 2016-04-30  Darin Adler  <darin@apple.com>
911
912         Streamline and remove unused bindings generation code
913         https://bugs.webkit.org/show_bug.cgi?id=157237
914
915         Reviewed by Chris Dumez.
916
917         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
918         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
919         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
920         Replace non-standard "int" with standard "long", which means the same thing.
921
922 2016-04-30  Darin Adler  <darin@apple.com>
923
924         Next batch of conversions to use C++ enum class instead of strings for enumerations
925         https://bugs.webkit.org/show_bug.cgi?id=157232
926
927         Reviewed by Chris Dumez.
928
929         * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
930         checking. We don't want to waste time trying to make our generated code match our style.
931
932 2016-04-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
933
934         Add JSC test results in JSON format to a Buildbot log.
935         https://bugs.webkit.org/show_bug.cgi?id=156920
936
937         Reviewed by Daniel Bates.
938
939         Generate JSON results for JSC tests and upload them to the master
940         using Buildbot's logfiles machinery.
941
942         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
943         (RunJavaScriptCoreTests): Use --json-output option when invoking the
944         run-javascriptcore-tests Perl script, and expose this JSON output as a 
945         Buildbot log.
946         * Scripts/run-javascriptcore-tests:
947         (runJSCStressTests): Change key names and remove redundant count key.
948
949 2016-04-29  Joanmarie Diggs  <jdiggs@igalia.com>
950
951         [ATK] Expose the value of aria-roledescription via an AtkObject attribute
952         https://bugs.webkit.org/show_bug.cgi?id=146719
953
954         Reviewed by Chris Fleizach.
955
956         Implement roleDescription() so that the implementation can be tested.
957
958         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
959         (WTR::AccessibilityUIElement::roleDescription):
960
961 2016-04-27  Alexey Proskuryakov  <ap@apple.com>
962
963         Don't throttle GuardMalloc on 8-core Macs
964         https://bugs.webkit.org/show_bug.cgi?id=157108
965
966         Reviewed by Alex Christensen.
967
968         This was making them slower unnecessarily.
969
970         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
971
972 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
973
974         Unreviewed: add myself to the committers list.
975
976         * Scripts/webkitpy/common/config/contributors.json:
977
978 2016-04-26  Ryosuke Niwa  <rniwa@webkit.org>
979
980         Fix text in log files autogenerated by import-w3c-tests
981         https://bugs.webkit.org/show_bug.cgi?id=157021
982
983         Unreviewed. Fixing the second typo.
984
985         * Scripts/webkitpy/w3c/test_importer.py:
986         (TestImporter.write_import_log):
987
988 2016-04-26  Filip Pizlo  <fpizlo@apple.com>
989
990         WebCore on Mac ignores the user's preferred region (country) while getting the language
991         https://bugs.webkit.org/show_bug.cgi?id=156993
992
993         Reviewed by Geoffrey Garen.
994
995         Change the test expectations for this test. If the variant is not explicitly specified in
996         the AppleLanguage, then we use the locale's country code, which this test assumes is US.
997
998         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
999         (TestWebKitAPI::languageForSystemLanguage):
1000         (TestWebKitAPI::TEST):
1001
1002 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1003
1004         Remove the build flag for template elements
1005         https://bugs.webkit.org/show_bug.cgi?id=157022
1006
1007         Reviewed by Daniel Bates.
1008
1009         Removed the build option.
1010
1011         * Scripts/webkitperl/FeatureList.pm:
1012
1013 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1014
1015         Fix text in log files autogenerated by import-w3c-tests
1016         https://bugs.webkit.org/show_bug.cgi?id=157021
1017
1018         Reviewed by Chris Dumez.
1019
1020         s/Webkit/WebKit/ and end each sentence with a period.
1021
1022         * Scripts/webkitpy/w3c/test_importer.py:
1023         (TestImporter.write_import_log):
1024
1025 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
1026
1027         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
1028         https://bugs.webkit.org/show_bug.cgi?id=156929
1029
1030         Reviewed by Darin Adler.
1031
1032         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1033         (TestWebKitAPI::TEST):
1034
1035 2016-04-25  Caitlin Potter  <caitp@igalia.com>
1036
1037         [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
1038         https://bugs.webkit.org/show_bug.cgi?id=156976
1039
1040         Reviewed by Darin Adler.
1041
1042         Mitigate style-checker spam on bugs which introduce new JavaScript
1043         token types.
1044
1045         * Scripts/webkitpy/style/checkers/cpp.py:
1046         (_EnumState.__init__):
1047         (_EnumState.process_clean_line):
1048         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1049         (NoNonVirtualDestructorsTest.test_enum_casing):
1050
1051 2016-04-25  Simon Fraser  <simon.fraser@apple.com>
1052
1053         Fix issues with content-animation performance tests
1054         https://bugs.webkit.org/show_bug.cgi?id=157001
1055
1056         Reviewed by Sam Weinig.
1057
1058         Add patch content for svg-animation.html, and fix the paths in the patch so
1059         it applies correctly.
1060
1061         Add the patch file to the .plan file.
1062
1063         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
1064         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1065
1066 2016-04-25  Brady Eidson  <beidson@apple.com>
1067
1068         Tweaking IndexedDB watchlist and adding myself to it.
1069
1070         * Scripts/webkitpy/common/config/watchlist:
1071
1072 2016-04-25  Commit Queue  <commit-queue@webkit.org>
1073
1074         Unreviewed, rolling out r199916.
1075         https://bugs.webkit.org/show_bug.cgi?id=156989
1076
1077         Might break buildbot when master is restarted (Requested by
1078         Srinivasan Vijayaraghava, Guest100, on #webkit).
1079
1080         Reverted changeset:
1081
1082         "Add JSC test results in json format to a buildbot log"
1083         https://bugs.webkit.org/show_bug.cgi?id=156920
1084         http://trac.webkit.org/changeset/199916
1085
1086 2016-04-23  Chris Dumez  <cdumez@apple.com>
1087
1088         [WebIDL] Drop [Default] WebKit-IDL extended attribute
1089         https://bugs.webkit.org/show_bug.cgi?id=156955
1090
1091         Reviewed by Darin Adler.
1092
1093         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1094
1095 2016-04-23  Csaba Osztrogonác  <ossy@webkit.org>
1096
1097         Really enable INDEXED_DATABASE on Apple Mac cmake build
1098         https://bugs.webkit.org/show_bug.cgi?id=156902
1099
1100         Reviewed by Michael Catanzaro.
1101
1102         * Scripts/webkitperl/FeatureList.pm:
1103
1104 2016-04-23  Andy Estes  <aestes@apple.com>
1105
1106         check-webkit-style: fix false-positive warnings about @synchronized
1107         https://bugs.webkit.org/show_bug.cgi?id=156957
1108
1109         Reviewed by Dan Bernstein.
1110
1111         * Scripts/webkitpy/style/checkers/cpp.py:
1112         (check_spacing_for_function_call): Ignore @synchronized lines.
1113         (check_braces): Ditto.
1114         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1115         (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
1116
1117 2016-04-22  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1118
1119         Add JSC test results in json format to a buildbot log
1120         https://bugs.webkit.org/show_bug.cgi?id=156920
1121
1122         Reviewed by Alexey Proskuryakov.
1123
1124         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1125         (RunJavaScriptCoreTests):
1126         Add runtime flag to output json into buildbot
1127         * Scripts/run-javascriptcore-tests:
1128         (runJSCStressTests):
1129         Change key names and remove redundant count key
1130
1131 2016-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1132
1133         Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
1134
1135         Unreviewed test gardening.
1136
1137         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1138         (TestWebKitAPI::TEST):
1139
1140 2016-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1141
1142         [GTK] Enable the download attribute support
1143         https://bugs.webkit.org/show_bug.cgi?id=99025
1144
1145         Reviewed by Žan Doberšek.
1146
1147         * Scripts/webkitperl/FeatureList.pm:
1148
1149 2016-04-21  Keith Miller  <keith_miller@apple.com>
1150
1151         WebScriptObject description swizzler should work in a multi-threaded world
1152         https://bugs.webkit.org/show_bug.cgi?id=156808
1153
1154         Add a test for our NSObject swizzling TLS implementation. The test runs on
1155         two threads. One in JS and another in Objective-C. We expect the JS thread
1156         to use our NSObject description override and the Objective-C thread to act
1157         as though it was using the original NSObject description method.
1158
1159         Reviewed by Geoffrey Garen.
1160
1161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1162         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
1163         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
1164         (nsObjectDescriptionTest):
1165         (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
1166         (TestWebKitAPI::TEST):
1167
1168 2016-04-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1169
1170         [GTK] WebKitWebView should claim the contents size as its natural size
1171         https://bugs.webkit.org/show_bug.cgi?id=156835
1172
1173         Reviewed by Žan Doberšek.
1174
1175         Add test case to check the WebKitWebView preferred size.
1176
1177         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1178         (testWebViewPreferredSize):
1179         (beforeAll):
1180
1181 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
1182
1183         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
1184         https://bugs.webkit.org/show_bug.cgi?id=156827
1185         
1186         Update the .plan file now that the files are present in SVN.
1187
1188         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1189
1190 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
1191
1192         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
1193         https://bugs.webkit.org/show_bug.cgi?id=156827
1194         rdar://problem/24358135
1195
1196         Reviewed by Stephanie Lewis.
1197
1198         Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
1199         and collate results across them. Also add the ability for the browser_driver to supply
1200         additional results, allowing for tests that collect results data in native code, rather
1201         than generating it in the web page.
1202
1203         Add a set of "content animation" tests that use this new functionality, which test
1204         CSS animation and requestAnimationFrame performance.
1205
1206         'plan' files have two new optional keys:
1207             'test_files': a list of files to run as a suite
1208             'options': optional parameters. Currently supports one new option,
1209                 'animation_command', which affects the way that iOS tests are run,
1210                 and is passed to MobileSafari as a parameter on launch.
1211
1212         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1213         (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
1214         (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
1215         (BenchmarkRunner):
1216         (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
1217         running a single test. It starts and stops the http_server_driver.
1218         (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
1219         key, otherwise look for the new 'test_files' and load each in a loop.
1220         (BenchmarkRunner._dump):
1221         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1222         (BrowserDriver.launch_url): Pass options.
1223         (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
1224         (BrowserDriver):
1225         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
1226         (GTKMiniBrowserDriver.launch_url):
1227         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1228         (OSXBrowserDriver.close_browsers):
1229         (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
1230         (OSXBrowserDriver._terminiate_processes): Deleted.
1231         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1232         (OSXChromeDriver.launch_url):
1233         (OSXChromeCanaryDriver.launch_url):
1234         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1235         (OSXFirefoxDriver.launch_url):
1236         (OSXFirefoxNightlyDriver.launch_url):
1237         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1238         (OSXSafariDriver.launch_url):
1239         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
1240         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
1241
1242 2016-04-20  Dustin Falgout  <dustin@falgout.us>
1243
1244         [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
1245         https://bugs.webkit.org/show_bug.cgi?id=156651
1246
1247         Reviewed by Michael Catanzaro.
1248
1249         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1250         (testWebKitSettings):
1251
1252 2016-04-20  Brady Eidson  <beidson@apple.com>
1253
1254         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
1255         https://bugs.webkit.org/show_bug.cgi?id=156782
1256
1257         Reviewed by Alex Christensen.
1258
1259         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1260
1261 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
1262
1263         Unreviewed build fix after r199752.
1264
1265         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1266         (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
1267
1268 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
1269
1270         Remove remaining bits of dynamic <link> rel='icon' loading
1271         https://bugs.webkit.org/show_bug.cgi?id=156727
1272
1273         Reviewed by Darin Adler.
1274
1275         Remove unused test infrastructure. This code never existed in WebKit2
1276         testing since was only used on Windows.
1277
1278         * DumpRenderTree/TestRunner.cpp:
1279         (dumpIconChangesCallback): Deleted.
1280         * DumpRenderTree/TestRunner.h:
1281         (TestRunner::dumpIconChanges): Deleted.
1282         (TestRunner::setDumpIconChanges): Deleted.
1283
1284 2016-04-19  Keith Miller  <keith_miller@apple.com>
1285
1286         ObjcInstance::stringValue should not call NSObject's description method
1287         https://bugs.webkit.org/show_bug.cgi?id=156758
1288
1289         Reviewed by Geoffrey Garen.
1290
1291         Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
1292         an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
1293         call the NSObjects description method without first swizzling it.
1294
1295         * DumpRenderTree/mac/ObjCController.m:
1296         (+[ObjCController isSelectorExcludedFromWebScript:]):
1297         (+[ObjCController webScriptNameForSelector:]):
1298         (-[ObjCController testArrayOfObjects]):
1299         (-[ObjCController testObject]):
1300
1301 2016-04-18  Dan Bernstein  <mitz@apple.com>
1302
1303         Fixed building with old Xcode.
1304
1305         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1306         (TEST):
1307
1308 2016-04-18  Dean Jackson  <dino@apple.com>
1309
1310         New SPI to export a dictionary of runtime features
1311         https://bugs.webkit.org/show_bug.cgi?id=156645
1312         <rdar://problem/23621666>
1313
1314         Reviewed by Darin Adler.
1315
1316         Test the experimental features SPI on WKPreferences.
1317
1318         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1319
1320 2016-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
1321
1322         [JSCOnly] Implement RunLoop and remove glib dependency
1323         https://bugs.webkit.org/show_bug.cgi?id=155706
1324
1325         Reviewed by Michael Catanzaro.
1326
1327         Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
1328         Platform specific ones locate under jsconly directory since
1329         it is not `generic` (Since it includes the GLIB event loop case).
1330
1331         * CMakeLists.txt:
1332         * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
1333         * TestWebKitAPI/PlatformUtilities.h:
1334         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1335         (TestWebKitAPI::TEST):
1336         * TestWebKitAPI/config.h:
1337         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
1338         (TestWebKitAPI::Util::run):
1339         (TestWebKitAPI::Util::sleep):
1340         * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
1341         (main):
1342
1343 2016-04-18  Jon Lee  <jonlee@apple.com>
1344
1345         Update Animometer plan.
1346         https://bugs.webkit.org/show_bug.cgi?id=156652
1347
1348         Reviewed by Darin Adler.
1349
1350         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
1351
1352 2016-04-18  Dana Burkart  <dburkart@apple.com>
1353
1354         svn-apply: add option for ignoring changes to ChangeLog files
1355         https://bugs.webkit.org/show_bug.cgi?id=156618
1356
1357         Reviewed by Darin Adler.
1358
1359         This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
1360         patch() if the file in question is a ChangeLog.
1361
1362         * Scripts/svn-apply:
1363         (patch):
1364
1365 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1366
1367         Pending API Request URL is wrong after reloading
1368         https://bugs.webkit.org/show_bug.cgi?id=139342
1369
1370         Reviewed by Darin Adler.
1371
1372         Update test case to check that the active URL should remain the
1373         same after a reload.
1374
1375         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
1376         (TestWebKitAPI::TEST):
1377
1378 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1379
1380         Pending API request URL no set when loading Data, Alternate HTML or plain text
1381         https://bugs.webkit.org/show_bug.cgi?id=136916
1382
1383         Reviewed by Darin Adler.
1384
1385         Add new test to check that active URL is the requested one right
1386         after calling WKPage load methods.
1387
1388         * TestWebKitAPI/PlatformEfl.cmake:
1389         * TestWebKitAPI/PlatformGTK.cmake:
1390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1391         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
1392         (TestWebKitAPI::TEST):
1393         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1394         (WebViewTest::loadPlainText): Remove FIXME.
1395         (WebViewTest::loadBytes): Ditto.
1396         (WebViewTest::loadAlternateHTML): Ditto.
1397
1398 2016-04-18  Commit Queue  <commit-queue@webkit.org>
1399
1400         Unreviewed, rolling out r199660.
1401         https://bugs.webkit.org/show_bug.cgi?id=156691
1402
1403         It broke the iOS build (Requested by KaL on #webkit).
1404
1405         Reverted changeset:
1406
1407         "Pending API request URL no set when loading Data, Alternate
1408         HTML or plain text"
1409         https://bugs.webkit.org/show_bug.cgi?id=136916
1410         http://trac.webkit.org/changeset/199660
1411
1412 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1413
1414         Pending API request URL no set when loading Data, Alternate HTML or plain text
1415         https://bugs.webkit.org/show_bug.cgi?id=136916
1416
1417         Reviewed by Darin Adler.
1418
1419         Add new test to check that active URL is the requested one right
1420         after calling WKPage load methods.
1421
1422         * TestWebKitAPI/PlatformEfl.cmake:
1423         * TestWebKitAPI/PlatformGTK.cmake:
1424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1425         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
1426         (TestWebKitAPI::TEST):
1427         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1428         (WebViewTest::loadPlainText): Remove FIXME.
1429         (WebViewTest::loadBytes): Ditto.
1430         (WebViewTest::loadAlternateHTML): Ditto.
1431
1432 2016-04-18  Jeremy Huddleston Sequoia  <jeremyhu@apple.com>
1433
1434         Fix incorrect assumption that APPLE implies Mac.
1435         https://bugs.webkit.org/show_bug.cgi?id=156679
1436
1437         Addresses build failure introduced in r198947
1438
1439         Reviewed by Alex Christensen.
1440
1441         * CMakeLists.txt:
1442
1443 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1444
1445         [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
1446         https://bugs.webkit.org/show_bug.cgi?id=156621
1447
1448         Reviewed by Martin Robinson.
1449
1450         This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
1451         scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
1452         simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
1453
1454         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1455         (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
1456
1457 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1458
1459         [EFL] Bump gstreamer from 1.4.4 to 1.6.3
1460         https://bugs.webkit.org/show_bug.cgi?id=156655
1461
1462         Reviewed by Antonio Gomes.
1463
1464         To support html5 video feature, we should bump gstreamer version.
1465
1466         * efl/jhbuild.modules:
1467         * efl/patches/gst-libav.patch: Update against newer version.
1468         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
1469
1470 2016-04-16  Sam Weinig  <sam@webkit.org>
1471
1472         More build fixing.
1473
1474         * MiniBrowser/mac/BrowserWindowController.m:
1475         (-[BrowserWindowController share:]):
1476
1477 2016-04-16  Sam Weinig  <sam@webkit.org>
1478
1479         Another build fix.
1480
1481         * MiniBrowser/mac/BrowserWindowController.m:
1482         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
1483
1484 2016-04-16  Sam Weinig  <sam@webkit.org>
1485
1486         Fix 32-bit build.
1487
1488         * MiniBrowser/mac/BrowserWindowController.m:
1489         (-[BrowserWindowController share:]):
1490         (-[BrowserWindowController fetch:]):
1491         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1492
1493 2016-04-15  Sam Weinig  <sam@webkit.org>
1494
1495         Add support for NSSharingService to MiniBrowser, for no great reasons
1496         https://bugs.webkit.org/show_bug.cgi?id=156658
1497
1498         Reviewed by Darin Adler.
1499
1500         * MiniBrowser/mac/BrowserWindow.xib:
1501         * MiniBrowser/mac/BrowserWindowController.h:
1502         Add the share button.
1503
1504         * MiniBrowser/mac/BrowserWindowController.m:
1505         (-[BrowserWindowController windowDidLoad]):
1506         Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
1507
1508         (-[BrowserWindowController share:]):
1509         Show the picker when the button is pressed.
1510         (-[BrowserWindowController mainContentView]):
1511         Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
1512
1513         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
1514         (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
1515         (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
1516         (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
1517         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1518         (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
1519         Add delegate methods.
1520
1521         * MiniBrowser/mac/WK1BrowserWindowController.m:
1522         (-[WK1BrowserWindowController mainContentView]):
1523         * MiniBrowser/mac/WK2BrowserWindowController.m:
1524         (-[WK2BrowserWindowController mainContentView]):
1525         Implement to return the web view.
1526
1527 2016-04-16  Alexey Proskuryakov  <ap@apple.com>
1528
1529         Build fix.
1530
1531         Temporary workaround for rdar://problem/25754945.
1532
1533         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
1534
1535 2016-04-15  Commit Queue  <commit-queue@webkit.org>
1536
1537         Unreviewed, rolling out r199600.
1538         https://bugs.webkit.org/show_bug.cgi?id=156642
1539
1540         It didn't help (Requested by ap_ on #webkit).
1541
1542         Reverted changeset:
1543
1544         "Build fix."
1545         http://trac.webkit.org/changeset/199600
1546
1547 2016-04-15  Alexey Proskuryakov  <ap@apple.com>
1548
1549         Build fix.
1550
1551         * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
1552
1553 2016-04-14  Alexey Proskuryakov  <ap@apple.com>
1554
1555         Some GuardMalloc bots are not happy when running many parallel processes
1556         https://bugs.webkit.org/show_bug.cgi?id=156614
1557         rdar://problem/24711525
1558
1559         Reviewed by David Kilzer.
1560
1561         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
1562
1563 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
1564
1565         Make <a download> a runtime enabled option
1566         https://bugs.webkit.org/show_bug.cgi?id=156583
1567         <rdar://problem/25733449>
1568
1569         Reviewed by Alex Christensen.
1570
1571         * DumpRenderTree/mac/DumpRenderTree.mm:
1572         (resetWebPreferencesToConsistentValues):
1573         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1574         (WTR::InjectedBundle::beginTesting):
1575         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1576         (WTR::TestRunner::setDownloadAttributeEnabled):
1577         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1578
1579 2016-04-14  Anders Carlsson  <andersca@apple.com>
1580
1581         Another build fix attempt.
1582
1583         * MiniBrowser/mac/WK2BrowserWindowController.m:
1584
1585 2016-04-14  Anders Carlsson  <andersca@apple.com>
1586
1587         Fix build.
1588
1589         * MiniBrowser/mac/WK2BrowserWindowController.m:
1590         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1591
1592 2016-04-14  Anders Carlsson  <andersca@apple.com>
1593
1594         [Mac] Add API for open panel handling to WKWebView
1595         https://bugs.webkit.org/show_bug.cgi?id=137759
1596         rdar://problem/23278623
1597
1598         Reviewed by Tim Horton.
1599
1600         Have MiniBrowser implement the new delegate method.
1601
1602         * MiniBrowser/mac/WK2BrowserWindowController.m:
1603         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1604
1605 2016-04-14  Jiewen Tan  <jiewen_tan@apple.com>
1606
1607         Unreviewed, rolling out r199554.
1608
1609         The change breaks Yosemite Release/Debug build
1610
1611         Reverted changeset:
1612
1613         "[Mac] Add API for open panel handling to WKWebView"
1614         https://bugs.webkit.org/show_bug.cgi?id=137759
1615         http://trac.webkit.org/changeset/199554
1616
1617 2016-04-14  Anders Carlsson  <andersca@apple.com>
1618
1619         [Mac] Add API for open panel handling to WKWebView
1620         https://bugs.webkit.org/show_bug.cgi?id=137759
1621         rdar://problem/23278623
1622
1623         Reviewed by Tim Horton.
1624
1625         Have MiniBrowser implement the new delegate method.
1626
1627         * MiniBrowser/mac/WK2BrowserWindowController.m:
1628         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1629
1630 2016-04-14  Jon Lee  <jonlee@apple.com>
1631
1632         Update Animometer plan
1633         https://bugs.webkit.org/show_bug.cgi?id=156569
1634
1635         Reviewed by Alex Christensen.
1636
1637         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
1638         resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
1639
1640 2016-04-13  Alex Christensen  <achristensen@webkit.org>
1641
1642         CMake MiniBrowser should be an app bundle
1643         https://bugs.webkit.org/show_bug.cgi?id=156521
1644
1645         Reviewed by Brent Fulgham.
1646
1647         * MiniBrowser/mac/CMakeLists.txt:
1648         Make an app bundle and compile nibs.
1649         * MiniBrowser/mac/Info.plist:
1650         CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.
1651
1652 2016-04-13  Chris Dumez  <cdumez@apple.com>
1653
1654         We should not speculatively revalidate cached redirects
1655         https://bugs.webkit.org/show_bug.cgi?id=156548
1656         <rdar://problem/25583886>
1657
1658         Reviewed by Darin Adler.
1659
1660         Re-enable speculative loading in the context of layout tests. This was
1661         turned off by mistake when speculative loading was turned into a
1662         setting recently.
1663
1664         * WebKitTestRunner/TestController.cpp:
1665         (WTR::TestController::generatePageConfiguration):
1666
1667 2016-04-12  Alexey Proskuryakov  <ap@apple.com>
1668
1669         Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
1670         https://bugs.webkit.org/show_bug.cgi?id=155367
1671
1672         Reviewed by Darin Adler.
1673
1674         * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
1675         Don't flakily consume the return code with waitpid, callers need to do waitpid on
1676         their own. Not sure if this line of code was even intentional.
1677
1678 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
1679
1680         [OS X] Flakey crash after ScrollAnimatorMac destruction
1681         https://bugs.webkit.org/show_bug.cgi?id=156372
1682
1683         Reviewed by Darin Adler.
1684
1685         Implement the new <!-- webkit-test-runner --> flag.
1686
1687         * WebKitTestRunner/TestController.cpp:
1688         (WTR::TestController::createWebViewWithOptions):
1689         (WTR::TestController::ensureViewSupportsOptionsForTest):
1690         (WTR::TestController::resetPreferencesToConsistentValues):
1691         (WTR::TestController::resetStateToConsistentValues):
1692         (WTR::updateTestOptionsFromTestHeader):
1693         * WebKitTestRunner/TestController.h:
1694         * WebKitTestRunner/TestInvocation.cpp:
1695         (WTR::TestInvocation::invoke):
1696         * WebKitTestRunner/TestOptions.h:
1697         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1698         (WKR::PlatformWebView::viewSupportsOptions):
1699
1700 2016-04-12  Tomas Popela  <tpopela@redhat.com>
1701
1702         Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported
1703         https://bugs.webkit.org/show_bug.cgi?id=156338
1704
1705         Reviewed by Michael Catanzaro.
1706
1707         Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just
1708         for the i686 where it is supported and not for other architectures
1709         (such as s390(x) and ppc(64)) where the build will fail with these
1710         CXXFLAGS.
1711
1712         * Scripts/webkitdirs.pm:
1713         (generateBuildSystemFromCMakeProject):
1714
1715 2016-04-11  Alex Christensen  <achristensen@webkit.org>
1716
1717         Build MiniBrowser with CMake on Mac
1718         https://bugs.webkit.org/show_bug.cgi?id=156471
1719
1720         Reviewed by Daniel Bates.
1721
1722         * CMakeLists.txt:
1723         * DumpRenderTree/CMakeLists.txt:
1724         * DumpRenderTree/PlatformWin.cmake:
1725         * MiniBrowser/mac/CMakeLists.txt: Added.
1726
1727 2016-04-11  Ryuan Choi  <ryuan.choi@navercorp.com>
1728
1729         [EFL] Do not pass context to EwkViewCreate
1730         https://bugs.webkit.org/show_bug.cgi?id=156461
1731
1732         Reviewed by Darin Adler.
1733
1734         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1735         (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls.
1736         * TestWebKitAPI/efl/PlatformWebView.cpp:
1737         (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto.
1738         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1739         (WTR::PlatformWebView::PlatformWebView): Ditto.
1740
1741 2016-04-11  Fujii Hironori  <Hironori.Fujii@jp.sony.com>
1742
1743         [CMake] Make FOLDER property INHERITED
1744         https://bugs.webkit.org/show_bug.cgi?id=156460
1745
1746         Reviewed by Brent Fulgham.
1747
1748         * CMakeLists.txt:
1749         * DumpRenderTree/CMakeLists.txt:
1750         * DumpRenderTree/PlatformWin.cmake:
1751         * ImageDiff/CMakeLists.txt:
1752         * MiniBrowser/efl/CMakeLists.txt:
1753         * MiniBrowser/gtk/CMakeLists.txt:
1754         * MiniBrowser/win/CMakeLists.txt:
1755         Set FOLDER property as a directory property not a target property
1756
1757 2016-04-10  Caitlin Potter  <caitp@igalia.com>
1758
1759         [Tools] correctly check for braces in multiline branches in macro definition
1760         https://bugs.webkit.org/show_bug.cgi?id=156441
1761
1762         Reviewed by Darin Adler.
1763
1764         Prevents emitting whitespace/braces warning for code like the
1765         following:
1766
1767         ```
1768         #define MACRO(x) \
1769             if (x) { \
1770                 doTheThing(); \
1771                 continue; \
1772             }
1773         ```
1774
1775         * Scripts/webkitpy/style/checkers/cpp.py:
1776         (check_braces):
1777         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1778         (WebKitStyleTest.test_line_breaking):
1779
1780 2016-04-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1781
1782         Testharness-based tests that time out should be able to produce a detailed output
1783         https://bugs.webkit.org/show_bug.cgi?id=145313
1784
1785         Reviewed by Xabier Rodriguez-Calvar.
1786
1787         Adding timeout readonly accessor to TestRunner for both WK1 and WK2.
1788
1789         * DumpRenderTree/TestRunner.cpp:
1790         (getTimeoutCallback): The js "timeout" property getter.
1791         (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value.
1792         * DumpRenderTree/TestRunner.h:
1793         (TestRunner::timeout): Adding access to DRT m_timeout private value.
1794         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS.
1795         * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition.
1796         (WTR::TestRunner::timeout):
1797
1798 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
1799
1800         stylebot should know about TestWebKitAPI FeatureDefines.xcconfig
1801         https://bugs.webkit.org/show_bug.cgi?id=156387
1802
1803         Rubber-stamped by Dan Bernstein.
1804
1805         * Scripts/webkitpy/style/checkers/featuredefines.py:
1806         (FeatureDefinesChecker.check):
1807
1808 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
1809
1810         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
1811         https://bugs.webkit.org/show_bug.cgi?id=156384
1812
1813         Reviewed by Ryosuke Niwa.
1814
1815         * Scripts/webkitperl/FeatureList.pm:
1816         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1817
1818 2016-04-06  Dean Jackson  <dino@apple.com>
1819
1820         Watchlist modifications:
1821         - remove roger_fong
1822         - add myself to a few areas
1823         - remove graouts from WebInspectorAPI
1824
1825         * Scripts/webkitpy/common/config/watchlist:
1826
1827 2016-04-07  Simon Fraser  <simon.fraser@apple.com>
1828
1829         Make it possible to test effect of view exposed rect on tiled backing
1830         https://bugs.webkit.org/show_bug.cgi?id=156365
1831
1832         Reviewed by Tim Horton.
1833
1834         Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable
1835         testing of tile coverage when setViewExposedRect() is passed a non-null rectangle.
1836
1837         testRunner.setViewSize() is used instead of using window.resizeTo(), since we
1838         can't easily resize a window to larger than the screen being tested on.
1839
1840         * DumpRenderTree/TestRunner.cpp:
1841         (setViewSizeCallback):
1842         (TestRunner::staticFunctions):
1843         * DumpRenderTree/TestRunner.h:
1844         * DumpRenderTree/mac/TestRunnerMac.mm:
1845         (TestRunner::setViewSize):
1846         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1847         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1848         (WTR::InjectedBundle::postSetViewSize):
1849         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1850         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1851         (WTR::TestRunner::setViewSize):
1852         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1853         * WebKitTestRunner/TestInvocation.cpp:
1854         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1855
1856 2016-04-07  Jason Marcell  <jmarcell@apple.com>
1857
1858         Adding layout tests for the bot watcher's dashboard QUnit tests.
1859         https://bugs.webkit.org/show_bug.cgi?id=155272
1860
1861         Reviewed by Daniel Bates.
1862
1863         Moved supporting resources into a resources folder and updated index.html accordingly
1864         to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done.
1865
1866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added.
1867         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory.
1868         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from
1869         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js.
1870         (MockBuildbotQueue):
1871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from
1872         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js.
1873         (MockBuildbotQueueView):
1874         (MockBuildbotQueueView.prototype._latestProductiveIteration):
1875         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from
1876         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js.
1877         (MockTrac):
1878         (MockTrac.prototype.get oldestRecordedRevisionNumber):
1879         (MockTrac.prototype.get latestRecordedRevisionNumber):
1880         (MockTrac.prototype.loadMoreHistoricalData):
1881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from
1882         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml.
1883         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from
1884         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml.
1885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from
1886         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js.
1887         Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory.
1888         (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done.
1889         * Scripts/run-dashboard-tests: Added.
1890
1891 2016-04-06  ChangSeok Oh  <changseok@webkit.org>
1892
1893         Unreviewed, Update my primary email address and expertise.
1894
1895         * Scripts/webkitpy/common/config/contributors.json:
1896
1897 2016-04-06  Jon Lee  <jonlee@apple.com>
1898
1899         Update the Animometer patch and plan files
1900         https://bugs.webkit.org/show_bug.cgi?id=156263
1901
1902         Reviewed by Ryosuke Niwa.
1903
1904         Measure the latest set of tests by updating the plan revision to r199134.
1905
1906         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only.
1907         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead
1908         of the developer page.
1909
1910 2016-04-06  Saam barati  <sbarati@apple.com>
1911
1912         jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989
1913         https://bugs.webkit.org/show_bug.cgi?id=156187
1914
1915         Reviewed by Keith Miller.
1916
1917         * Scripts/run-jsc-stress-tests:
1918
1919 2016-04-06  Alex Christensen  <achristensen@webkit.org>
1920
1921         Compile WebKitTestRunner with CMake on Mac
1922         https://bugs.webkit.org/show_bug.cgi?id=156310
1923
1924         Reviewed by Daniel Bates.
1925
1926         * CMakeLists.txt:
1927         * WebKitTestRunner/CMakeLists.txt:
1928         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1929         * WebKitTestRunner/PlatformEfl.cmake:
1930         * WebKitTestRunner/PlatformGTK.cmake:
1931         * WebKitTestRunner/PlatformMac.cmake: Added.
1932
1933 2016-04-05  Simon Fraser  <simon.fraser@apple.com>
1934
1935         Implement operator== and operator!= for Optional<>
1936         https://bugs.webkit.org/show_bug.cgi?id=156266
1937
1938         Reviewed by Anders Carlsson.
1939
1940         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1941         (TestWebKitAPI::TEST):
1942
1943 2016-04-05  Alex Christensen  <achristensen@webkit.org>
1944
1945         Make CMake-generated binaries on Mac able to run
1946         https://bugs.webkit.org/show_bug.cgi?id=156268
1947
1948         Reviewed by Daniel Bates.
1949
1950         * DumpRenderTree/CMakeLists.txt:
1951         * DumpRenderTree/PlatformMac.cmake:
1952         * DumpRenderTree/PlatformWin.cmake:
1953         * TestWebKitAPI/PlatformMac.cmake:
1954
1955 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1956
1957         [Fetch API] Add a runtime flag to fetch API and related constructs
1958         https://bugs.webkit.org/show_bug.cgi?id=156113
1959  
1960         Reviewed by Alex Christensen.
1961
1962         * DumpRenderTree/TestRunner.h:
1963         * DumpRenderTree/mac/DumpRenderTree.mm:
1964         (resetWebPreferencesToConsistentValues):
1965         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1966         (WTR::InjectedBundle::beginTesting):
1967         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1968         (WTR::TestRunner::setWebGL2Enabled):
1969         (WTR::TestRunner::setFetchAPIEnabled):
1970         (WTR::TestRunner::setAllowUniversalAccessFromFileURLs):
1971         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1972
1973 2016-04-05  Keith Miller  <keith_miller@apple.com>
1974
1975         Make Keith a reviewer!
1976         https://bugs.webkit.org/show_bug.cgi?id=156246
1977
1978         Reviewed by Mark Lam.
1979
1980         * Scripts/webkitpy/common/config/contributors.json:
1981
1982 2016-04-05  Antoine Quint  <graouts@apple.com>
1983
1984         [WebGL2] Allow enabling WebGL2 with a runtime flag
1985         https://bugs.webkit.org/show_bug.cgi?id=156166
1986         <rdar://problem/25526929>
1987
1988         Always enable WebGL2 during testing.
1989
1990         Reviewed by Dean Jackson.
1991
1992         * DumpRenderTree/mac/DumpRenderTree.mm:
1993         (resetWebPreferencesToConsistentValues):
1994         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1995         (WTR::InjectedBundle::beginTesting):
1996         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1997         (WTR::TestRunner::setWebGL2Enabled):
1998         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1999
2000 2016-04-04  Bill Ming  <mbbill@gmail.com>
2001
2002         [win] run-webkit-tests failed to launch DumpRenderTree
2003         https://bugs.webkit.org/show_bug.cgi?id=156150
2004
2005         Reviewed by Alex Christensen.
2006
2007         * Tools/Scripts/webkitpy/port/base.py:
2008
2009 2016-04-04  Bill Ming  <mbbill@gmail.com>
2010
2011         prepare-ChangeLog set endl incorrectly.
2012         https://bugs.webkit.org/show_bug.cgi?id=156151
2013
2014         Reviewed by Alex Christensen.
2015
2016         * Tools/Scripts/prepare-ChangeLog:
2017
2018 2016-04-03  Sam Weinig  <sam@webkit.org>
2019
2020         Add SPI to allow install script message handlers in isolated worlds
2021         https://bugs.webkit.org/show_bug.cgi?id=156153
2022
2023         Reviewed by Anders Carlsson.
2024
2025         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2026         Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
2027
2028 2016-04-04  Jiewen Tan  <jiewen_tan@apple.com>
2029
2030         Build fix for r198956.
2031
2032         Unreviewed.
2033
2034         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
2035         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2036         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2037         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2038
2039 2016-04-04  Bill Ming  <mbbill@gmail.com>
2040
2041         [win] prepare-ChangeLog should treat windows path differently.
2042         https://bugs.webkit.org/show_bug.cgi?id=156120
2043
2044         Reviewed by Brent Fulgham.
2045
2046         * Scripts/prepare-ChangeLog:
2047
2048 2016-04-04  Alejandro G. Castro  <alex@igalia.com>
2049
2050         REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations
2051         https://bugs.webkit.org/show_bug.cgi?id=156164
2052
2053         Reviewed by Philippe Normand.
2054
2055         Enable the new WEB_RTC option by default for Gtk+.
2056
2057         * Scripts/webkitperl/FeatureList.pm:
2058
2059 2016-04-03  Dan Bernstein  <mitz@apple.com>
2060
2061         Use the correct value for the first nightly build with frameworks built for OS X 10.11.
2062
2063         * Scripts/bisect-builds:
2064         (makeNightlyList):
2065
2066 2016-04-03  Dan Bernstein  <mitz@apple.com>
2067
2068         Made bisect-builds work again.
2069
2070         Rubber-stamped by Sam Weinig.
2071
2072         * Scripts/bisect-builds:
2073         Changed to use HTTPS to access nightly.webkit.org, and added a minimum revision for OS X 10.11.
2074
2075 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
2076
2077         Build fix for r198956.
2078
2079         Unreviewed.
2080
2081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2082         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm.
2083         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]):
2084         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]):
2085         (TEST):
2086         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2087         (-[LoadInvalidSchemeDelegate browsingContextController:didFailProvisionalLoadWithError:]):
2088         (TestWebKitAPI::TEST):
2089
2090 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
2091
2092         WebKit should dispatchDidFailProvisionalLoad while loading invalid URLs
2093         https://bugs.webkit.org/show_bug.cgi?id=155995
2094         <rdar://problem/14967004>
2095
2096         Reviewed by Andy Estes.
2097
2098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2099         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm:
2100         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
2101         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didStartProvisionalNavigation:]):
2102         (TEST):
2103         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Added.
2104         (literalURL):
2105         (-[LoadInvalidURLNavigationActionDelegate webView:didCommitNavigation:]):
2106         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2107         (TestWebKitAPI::TEST):
2108         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html: Added.
2109         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: Added.
2110         (-[LoadInvalidURLWebFrameLoadDelegate webView:didCommitLoadForFrame:]):
2111         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2112         (TestWebKitAPI::TEST):
2113
2114 2016-04-01  Brent Fulgham  <bfulgham@apple.com>
2115
2116         Confirm <a download> satisfies specification criteria
2117         https://bugs.webkit.org/show_bug.cgi?id=156057
2118
2119         Reviewed by Andy Estes.
2120
2121         Revise WebKitTestRunner:
2122         (1) Provide a download client delegate.
2123         (2) Teach WKTR to wait to finish a test until a download finishes.
2124         (3) Allow WKTR to notify the current TestRunner that it can finish.
2125
2126         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2127         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2128         (WTR::InjectedBundle::didReceiveMessageToPage): Update to recognize a new
2129         message "NotifyDownloadDone".
2130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2131         (WTR::InjectedBundlePage::decidePolicyForNavigationAction): Handle 'download'
2132         attribute case.
2133         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2134         (WTR::TestRunner::waitUntilDownload): Added.
2135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2136         (WTR::TestRunner::shouldFinishAfterDownload): Added.
2137         * WebKitTestRunner/TestController.cpp:
2138         (WTR::TestController::createWebViewWithOptions): Set up the download client.
2139         (WTR::TestController::downloadDidStart): Added.
2140         (WTR::TestController::decideDestinationWithSuggestedFilename): Added.
2141         (WTR::TestController::downloadDidFinish): Added.
2142         (WTR::TestController::downloadDidFail): Added.
2143         (WTR::TestController::downloadDidCancel): Added.
2144         * WebKitTestRunner/TestController.h:
2145         * WebKitTestRunner/TestInvocation.cpp:
2146         (WTR::TestInvocation::notifyDownloadDone): Added.
2147         * WebKitTestRunner/TestInvocation.h:
2148
2149 2016-04-01  Alex Christensen  <achristensen@webkit.org>
2150
2151         Compile DumpRenderTree with CMake on Mac
2152         https://bugs.webkit.org/show_bug.cgi?id=156088
2153
2154         Reviewed by Brent Fulgham.
2155
2156         * CMakeLists.txt:
2157         * DumpRenderTree/CMakeLists.txt:
2158         * DumpRenderTree/DefaultPolicyDelegate.m:
2159         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2160         * DumpRenderTree/DumpRenderTreeFileDraggingSource.m:
2161         * DumpRenderTree/PlatformMac.cmake: Added.
2162         * DumpRenderTree/PlatformWin.cmake:
2163         * DumpRenderTree/mac/AppleScriptController.m:
2164         (convertAEDescToObject):
2165         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
2166         * DumpRenderTree/mac/LayoutTestHelper.m:
2167
2168 2016-03-31  Bill Ming  <mbbill@gmail.com>
2169
2170         https://bugs.webkit.org/show_bug.cgi?id=156094
2171         [Win] TestWebCore target build sometimes fail.
2172
2173         Reviewed by Alex Christensen.
2174
2175         * Tools/TestWebKitAPI/PlatformWin.cmake:
2176
2177 2016-03-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2178
2179         [EFL] Bump EFL version to 1.17.0
2180         https://bugs.webkit.org/show_bug.cgi?id=153008
2181
2182         Reviewed by Michael Catanzaro.
2183
2184         Original author is Csaba Osztrogonác  <ossy@webkit.org>
2185
2186         * efl/jhbuild.modules:
2187
2188 2016-03-31  Daniel Bates  <dabates@apple.com>
2189
2190         run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled
2191         https://bugs.webkit.org/show_bug.cgi?id=156071
2192         <rdar://problem/25467827>
2193
2194         Reviewed by Brent Fulgham.
2195
2196         Fixes an issue where run-webkit-tests will fail to create the suffixed user's cache directory
2197         on non-Apple Internal machines with System Integrity Protection enabled because the OS only
2198         honors the suffix, specified by the environment variable DIRHELPER_USER_DIR_SUFFIX, in
2199         privileged processes. And python(1) does not have sufficient privileges. As a workaround for
2200         systems that have System Integrity Protection enabled we compute the path to the suffixed
2201         user's cache directory by hand.
2202
2203         Additionally, fix an issue where the user's cache directory created by run-webkit-test was
2204         never deleted on cessation of the test run.
2205
2206         * Scripts/webkitpy/port/driver.py:
2207         (Driver._start): Actually store the path to the user's cache directory in self._driver_user_cache_directory
2208         so that we can delete this directory on cessation of the test run.
2209         * Scripts/webkitpy/port/mac.py:
2210         (MacPort):
2211         (MacPort._path_to_user_cache_directory): Unset the environment variable DIRHELPER_USER_DIR_SUFFIX (if set),
2212         query the OS for the path to the user's cache directory and concatenate this path with the
2213         specified suffix.
2214
2215 2016-03-31  Jiewen Tan  <jiewen_tan@apple.com>
2216
2217         WebKit should set Original URL of a download request correctly
2218         https://bugs.webkit.org/show_bug.cgi?id=155914
2219         <rdar://problem/10473811>
2220
2221         Reviewed by Anders Carlsson.
2222
2223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2224         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2225         (-[DownloadRequestOriginalURLDelegate initWithExpectOriginalURL:]):
2226         (-[DownloadRequestOriginalURLDelegate _downloadDidStart:]):
2227         (-[DownloadRequestOriginalURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2228         (TEST):
2229         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Added.
2230         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Added.
2231         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Added.
2232
2233 2016-03-30  Dewei Zhu  <dewei_zhu@apple.com>
2234
2235         Extend animometer timeout for slow CPUs.
2236         https://bugs.webkit.org/show_bug.cgi?id=156047
2237
2238         Reviewed by Ryosuke Niwa.
2239
2240         Extend animometer timeout to 30 minutes for slow device.
2241
2242         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
2243
2244 2016-03-30  Daniel Bates  <dabates@apple.com>
2245
2246         run-webkit-tests must create parent directory of user's cache directory before running tests
2247         https://bugs.webkit.org/show_bug.cgi?id=156009
2248         <rdar://problem/25442682>
2249
2250         Reviewed by Alexey Proskuryakov.
2251
2252         The script run-webkit-tests must create the parent directory of the user's cache directory
2253         before running tests because a WebKit2 child process expects that this directory exists
2254         when it starts.
2255
2256         The script run-webkit-tests influences the path chosen by a WebKit2 child process for the
2257         user's temporary directory and user's cache directory via the environment variable
2258         DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it
2259         as part of setting up the test environment. But run-webkit-tests does not create the user's
2260         cache directory. Therefore there is race between the time AppKit creates it and when the
2261         launched WebContent and Network processes query for the path to the user's cache directory
2262         such that the OS may return the empty string to the WebContent and Network processes if
2263         queried for this directory before AppKit creates it.
2264
2265         * Scripts/webkitpy/port/base.py:
2266         (Port._path_to_user_cache_directory): Added. Base class implementation that returns the
2267         empty string. We will override this method for the OS X port to return the path to the
2268         user's cache directory with the specified suffix.
2269         (Port.remove_cache_directory): Deleted.
2270         * Scripts/webkitpy/port/driver.py:
2271         (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory
2272         to the suffix to use for the user's temporary and cache directories and the path to the
2273         user's cache directory, respectively.
2274         (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX
2275         to self._driver_user_directory_suffix.
2276         (Driver._start): Compute the user directory suffix and the path to the user's cache
2277         directory. Create the user's cache directory (if applicable).
2278         (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable).
2279         * Scripts/webkitpy/port/mac.py:
2280         (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory().
2281         (MacPort.remove_cache_directory): Deleted.
2282
2283 2016-03-29  Benjamin Poulain  <bpoulain@apple.com>
2284
2285         [WTF] Removing a smart pointer from HashTable issues two stores to the same location
2286         https://bugs.webkit.org/show_bug.cgi?id=155676
2287
2288         Reviewed by Darin Adler.
2289
2290         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2291         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2292
2293 2016-03-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2294
2295         Add machine-readable results for JSC stress tests
2296         https://bugs.webkit.org/show_bug.cgi?id=155771
2297
2298         Reviewed by Darin Adler and Dean Johnson
2299
2300         Add an option to output JSC stress test results to a user-specified file in JSON format.
2301
2302         * Scripts/run-javascriptcore-tests:
2303         (runJSCStressTests): Add JSON output support
2304         (readAllLines): Remove trailing newline from the end of each item
2305
2306 2016-03-29  Alex Christensen  <achristensen@webkit.org>
2307
2308         Fix Windows build.
2309
2310         * TestWebKitAPI/PlatformWin.cmake:
2311
2312 2016-03-29  Timothy Hatcher  <timothy@apple.com>
2313
2314         Update WebKit nightly to have a red needle to better match Safari
2315
2316         https://bugs.webkit.org/show_bug.cgi?id=155983
2317
2318         Reviewed by Joseph Pecoraro.
2319
2320         * WebKitLauncher/webkit.icns:
2321
2322 2016-03-28  Joanmarie Diggs  <jdiggs@igalia.com>
2323
2324         Adding myself as a reviewer.
2325
2326         Unreviewed.
2327
2328         * Scripts/webkitpy/common/config/contributors.json:
2329
2330 2016-03-25  Dewei Zhu  <dewei_zhu@apple.com>
2331
2332         Dromaeo patch used by run-benchmark should not include an invalid address.
2333         https://bugs.webkit.org/show_bug.cgi?id=155910
2334
2335         Reviewed by Ryosuke Niwa.
2336
2337         Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.
2338         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
2339
2340 2016-03-25  Daniel Bates  <dabates@apple.com>
2341
2342         Add WebKitSystemInterface for iOS 9.3
2343         https://bugs.webkit.org/show_bug.cgi?id=155893
2344
2345         Rubber-stamped by Alexey Proskuryakov.
2346
2347         * Scripts/copy-webkitlibraries-to-product-directory:
2348
2349 2016-03-25  Daniel Bates  <dabates@apple.com>
2350
2351         Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
2352         in copy-webkitlibraries-to-product-directory
2353         https://bugs.webkit.org/show_bug.cgi?id=155869
2354
2355         Reviewed by Alexey Proskuryakov.
2356
2357         It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
2358         webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
2359         line argument.
2360
2361         * Scripts/copy-webkitlibraries-to-product-directory:
2362
2363 2016-03-25  Konstantin Tokarev  <annulen@yandex.ru>
2364
2365         Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
2366         https://bugs.webkit.org/show_bug.cgi?id=155882
2367
2368         Reviewed by Michael Catanzaro.
2369
2370         It was already enabled in all trunk ports, and is required for
2371         WebInspectorUI to work.
2372
2373         * Scripts/webkitperl/FeatureList.pm:
2374
2375 2016-03-24  Jeremy Zerfas  <WebKit@JeremyZerfas.com>
2376
2377         Improve update-webkit-dependency script.
2378         https://bugs.webkit.org/show_bug.cgi?id=155576
2379
2380         Reviewed by Brent Fulgham.
2381
2382         * Scripts/update-webkit-dependency:
2383         -Updated script to also use ETags for helping to determine whether dependency is up to date.
2384         -Updated script so it usually won't need to download the entire dependency each time it is
2385          ran.
2386         -Updated script to ensure zip file contains expected directories before trying to install.
2387         -Added some more error checking and improved error messages.
2388         (lastModifiedToUnixTime): Deleted.
2389
2390         * Scripts/update-webkit-wincairo-libs:
2391         -Corrected comment about what script does.
2392
2393 2016-03-24 Bill Ming <mbbill@gmail.com>
2394
2395         Fix webkitpy tests after r198617
2396         https://bugs.webkit.org/show_bug.cgi?id=155827
2397
2398         Reviewed by Alex Christensen.
2399
2400         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2401         (ConfirmDiff._show_pretty_diff):
2402
2403 2016-03-23  Bill Ming  <mbbill@gmail.com>
2404
2405         webkit-patch failed to open pretty diff on Windows
2406         https://bugs.webkit.org/show_bug.cgi?id=155827
2407
2408         Reviewed by Alex Christensen.
2409
2410         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2411         (ConfirmDiff._show_pretty_diff):
2412
2413 2016-03-23  Jer Noble  <jer.noble@apple.com>
2414
2415         [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
2416         https://bugs.webkit.org/show_bug.cgi?id=155764
2417
2418         Reviewed by Eric Carlson.
2419
2420         Remove the requirement for media elements to have webkit-playsinline attributes on iOS.
2421
2422         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2423         (RequiresUserActionForPlaybackTest::SetUp):
2424
2425 2016-03-23  Anders Carlsson  <andersca@apple.com>
2426
2427         Crash when using KVO from within -[WebView initWithCoder:]
2428         https://bugs.webkit.org/show_bug.cgi?id=155816
2429         rdar://problem/17073265
2430
2431         Reviewed by Dan Bernstein.
2432
2433         Add test.
2434
2435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2436         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added.
2437         (-[EarlyKVOCrashResponder initWithWebView:]):
2438         (-[EarlyKVOCrashResponder initWithCoder:]):
2439         (-[EarlyKVOCrashResponder dealloc]):
2440         (-[EarlyKVOCrashResponder encodeWithCoder:]):
2441         (TestWebKitAPI::TEST):
2442
2443 2016-03-23  Lucas Forschler  <lforschler@apple.com>
2444
2445         Teach kill-old-processes about perl 5.18.
2446         
2447         Reviewed by Alexey Proskuryakov
2448
2449         * BuildSlaveSupport/kill-old-processes:
2450         (main):
2451
2452 2016-03-22  Keith Rollin  <krollin@apple.com>
2453
2454         Unreviewed: add Keith Rollin to the committers list.
2455
2456         * Scripts/webkitpy/common/config/contributors.json:
2457
2458 2016-03-22  Per Arne Vollan  <peavo@outlook.com>
2459
2460         [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
2461         https://bugs.webkit.org/show_bug.cgi?id=141499
2462
2463         Reviewed by Brent Fulgham.
2464
2465         As we have moved on to VS2015, this workaround is no longer needed.
2466
2467         * DumpRenderTree/cg/ImageDiffCG.cpp:
2468         (main):
2469         * DumpRenderTree/win/DumpRenderTree.cpp:
2470         (main):
2471         * DumpRenderTree/win/ImageDiffCairo.cpp:
2472         (main):
2473         * MiniBrowser/win/Common.cpp:
2474         (DllMain):
2475         * TestWebKitAPI/win/main.cpp:
2476         (main):
2477         * win/DLLLauncher/DLLLauncherMain.cpp:
2478         (wWinMain):
2479
2480 2016-03-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2481
2482         [JSC] ASMBench cannot be run without JSBENCH_PATH
2483         https://bugs.webkit.org/show_bug.cgi?id=155751
2484
2485         Reviewed by Saam Barati.
2486
2487         Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files.
2488
2489         * Scripts/run-jsc-benchmarks:
2490
2491 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
2492
2493         [Win] SharedBuffer::copy() can cause a segmentation fault.
2494         https://bugs.webkit.org/show_bug.cgi?id=155739
2495
2496         Reviewed by Ryosuke Niwa.
2497
2498         * TestWebKitAPI/PlatformWin.cmake: Build and run the
2499         SharedBuffer tests.
2500
2501 2016-03-22  Csaba Osztrogonác  <ossy@webkit.org>
2502
2503         [buildbot] Move ARM Linux bots to JSCOnly port
2504         https://bugs.webkit.org/show_bug.cgi?id=155655
2505
2506         Reviewed by Lucas Forschler.
2507
2508         * BuildSlaveSupport/build.webkit.org-config/config.json:
2509         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2510         (ConfigureBuild.__init__):
2511         (appendCustomBuildFlags):
2512         (CompileJSCOnly):
2513         (Factory.__init__):
2514         (BuildAndRemoteJSCTestsFactory):
2515         (BuildAndRemoteJSCTestsFactory.__init__):
2516         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2517         * BuildSlaveSupport/clean-build:
2518         (main):
2519
2520 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
2521
2522         Improve SharedBuffer testing
2523         https://bugs.webkit.org/show_bug.cgi?id=93078
2524         <rdar://problem/25277829>
2525
2526         Reviewed by Ryosuke Niwa.
2527
2528         Based on a Blink patch by Huang Dongsung <luxtella@company100.net>.
2529         <https://src.chromium.org/viewvc/blink?revision=153850&view=revision,
2530         and a Blink patch by <tyoshino@chromium.org>
2531         <https://src.chromium.org/viewvc/blink?view=rev&revision=151617>
2532
2533         Add three test cases from the Blink project that cover various append,
2534         copy, and createArrayBuffer calls.
2535
2536         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
2537         (TestWebKitAPI::TEST_F):
2538
2539 2016-03-21  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2540
2541         [Win] Connect layoutTestController.findString() to support testing
2542         https://bugs.webkit.org/show_bug.cgi?id=50234
2543
2544         Reviewed by Alex Christensen.
2545
2546         Implement TestRunner::findString().
2547
2548         * DumpRenderTree/win/TestRunnerWin.cpp:
2549         (TestRunner::findString):
2550
2551 2016-03-20  Dan Bernstein  <mitz@apple.com>
2552
2553         [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
2554         https://bugs.webkit.org/show_bug.cgi?id=155707
2555         <rdar://problem/24980691>
2556
2557         Reviewed by Darin Adler.
2558
2559         * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR
2560           based on the last component of MACOSX_DEPLOYMENT_TARGET.
2561         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds,
2562           preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
2563
2564         Similarly for these projects:
2565
2566         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2567         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2568         * LayoutTestRelay/Configurations/Base.xcconfig:
2569         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2570         * MiniBrowser/Configurations/Base.xcconfig:
2571         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2572         * TestWebKitAPI/Configurations/Base.xcconfig:
2573         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2574         * WebEditingTester/Configurations/Base.xcconfig:
2575         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2576         * WebKitTestRunner/Configurations/Base.xcconfig:
2577         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2578
2579 2016-03-20  Dan Bernstein  <mitz@apple.com>
2580
2581         Update build settings
2582
2583         Rubber-stamped by Andy Estes.
2584
2585         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2586         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2587         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2588         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2589         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2590         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source.
2591         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2592         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2593         * asan/asan.xcconfig:
2594
2595 2016-03-18  Sam Weinig  <sam@webkit.org>
2596
2597         Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost
2598         https://bugs.webkit.org/show_bug.cgi?id=155621
2599
2600         Reviewed by Alex Christensen.
2601
2602         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2603         (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger):
2604         (TestWebKitAPI::testMovingUsingEnsure):
2605         (TestWebKitAPI::testMovingUsingAdd):
2606         Add tests ensuring that objects moved into a map using ensure don't
2607         have extra ref-churn.
2608
2609 2016-03-17  Tim Horton  <timothy_horton@apple.com>
2610
2611         Fix some deprecation warnings in WebEditingTester
2612         https://bugs.webkit.org/show_bug.cgi?id=155601
2613
2614         Reviewed by Simon Fraser.
2615
2616         * WebEditingTester/AppDelegate.m:
2617         (-[WebEditingAppDelegate showOperations:]):
2618         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2619
2620 2016-03-17  Tim Horton  <timothy_horton@apple.com>
2621
2622         Find-in-page indicator in Mail viewer is the wrong scale and cut off
2623         https://bugs.webkit.org/show_bug.cgi?id=155605
2624         <rdar://problem/23948165>
2625
2626         Reviewed by Simon Fraser.
2627
2628         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
2629         (TEST):
2630         Add a test that ensures that the find result image is correctly @2x.
2631         The NSImage size should be in points.
2632
2633 2016-03-16  Commit Queue  <commit-queue@webkit.org>
2634
2635         Unreviewed, rolling out r198187.
2636         https://bugs.webkit.org/show_bug.cgi?id=155564
2637
2638         Potentially break testing on iOS (Requested by Guest23 on
2639         #webkit).
2640
2641         Reverted changeset:
2642
2643         "Add twisted-15.5.0 module to
2644         webkitpy.thirdparty.autoinstalled."
2645         https://bugs.webkit.org/show_bug.cgi?id=154667
2646         http://trac.webkit.org/changeset/198187
2647
2648 2016-03-16  David Kilzer  <ddkilzer@apple.com>
2649
2650         check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
2651         <http://webkit.org/b/155445>
2652
2653         Reviewed by Darin Adler.
2654
2655         * Scripts/webkitpy/style/checker.py:
2656         (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
2657         on TestWebKitAPI since this project uses a config.h header as of
2658         r95188.  Also remove references to WebKitAPITest, which ceased
2659         to exist in r95944.
2660
2661         * Scripts/webkitpy/style/checker_unittest.py:
2662         (GlobalVariablesTest.test_path_rules_specifier): Add tests.
2663         Remove reference to WebKitAPITest project.
2664
2665 2016-03-16  Tim Horton  <timothy_horton@apple.com>
2666
2667         [mac] Printing test snapshots are upside-down after r198242
2668         https://bugs.webkit.org/show_bug.cgi?id=155543
2669
2670         Reviewed by Simon Fraser.
2671
2672         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2673         (createPagedBitmapContext):
2674         Flip printing snapshots in DRT so that everything is right-side-up.
2675
2676 2016-03-16  Alexey Proskuryakov  <ap@apple.com>
2677
2678         Update unit test for iOS debug queues.
2679
2680         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2681
2682 2016-03-16  Jiewen Tan  <jiewen_tan@apple.com>
2683
2684         URL Parsing should signal failure for illegal IDN
2685         https://bugs.webkit.org/show_bug.cgi?id=154945
2686         <rdar://problem/8014795>
2687
2688         Reviewed by Brent Fulgham.
2689
2690         * MiniBrowser/mac/WK2BrowserWindowController.m:
2691         (-[WK2BrowserWindowController fetch:]):
2692         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
2693         (TestWebKitAPI::TEST):
2694
2695 2016-03-15  Tim Horton  <timothy_horton@apple.com>
2696
2697         [iOS Simulator] Test result snapshots are upside down
2698         https://bugs.webkit.org/show_bug.cgi?id=154761
2699
2700         Reviewed by Simon Fraser.
2701
2702         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2703         (WTR::createCGContextFromImage):
2704         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2705         In r97104, Simon added code to take WindowServer snapshots, which came
2706         in flipped, and added code to flip them back. At this point, WindowServer
2707         snapshots got flipped, and software snapshots did not.
2708
2709         In r140067, Simon noticed that WindowServer ref test images were upside-down
2710         on Mac (not sure why this changed), so turned off the flipping code (but
2711         didn't delete it!). Now, WindowServer snapshots and software snapshots both
2712         are not flipped.
2713
2714         In r190304, Carlos added an enum for the source of the snapshot ("WebView"
2715         for window server snapshots, and "WebContent" for software snapshots),
2716         and - critically - changed the flipping logic to flip software snapshots!
2717
2718         We didn't notice this on Mac because at this point we've made it so that
2719         we *always* have WindowServer snapshots, but on iOS we still don't have
2720         WindowServer snapshots, so now they're flipped.
2721
2722         And that's how we got here.
2723
2724         To restore the behavior from r140067, and correctly unflip snapshots on
2725         iOS, just delete this code.
2726
2727 2016-03-15  Alexey Proskuryakov  <ap@apple.com>
2728
2729         run-api-tests doesn't print test name when the test crashes
2730         https://bugs.webkit.org/show_bug.cgi?id=155476
2731
2732         Reviewed by Daniel Bates.
2733
2734         * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
2735         doesn't contain the test name yet. Changed test name output to always be before raw
2736         stdout for clarity.
2737
2738 2016-03-15  Chris Dumez  <cdumez@apple.com>
2739
2740         Unreviewed, rolling out r198203.
2741
2742         Favorites view is no longer loading on iOS
2743
2744         Reverted changeset:
2745
2746         "URL Parsing should signal failure for illegal IDN"
2747         https://bugs.webkit.org/show_bug.cgi?id=154945
2748         http://trac.webkit.org/changeset/198203
2749
2750 2016-03-15  Jiewen Tan  <jiewen_tan@apple.com>
2751
2752         URL Parsing should signal failure for illegal IDN
2753         https://bugs.webkit.org/show_bug.cgi?id=154945
2754         <rdar://problem/8014795>
2755
2756         Reviewed by Brent Fulgham.
2757
2758         * MiniBrowser/mac/WK2BrowserWindowController.m:
2759         (-[WK2BrowserWindowController fetch:]):
2760         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
2761         (TestWebKitAPI::TEST):
2762
2763 2016-03-14  Chris Dumez  <cdumez@apple.com>
2764
2765         Unreviewed, rolling out r197981.
2766
2767         Caused a massive PLT regression on Mac.
2768
2769         Reverted changeset:
2770
2771         "Font antialiasing (smoothing) changes when elements are
2772         rendered into compositing layers"
2773         https://bugs.webkit.org/show_bug.cgi?id=23364
2774         http://trac.webkit.org/changeset/197981
2775
2776 2016-03-14  Dewei Zhu  <dewei_zhu@apple.com>
2777
2778         Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
2779         https://bugs.webkit.org/show_bug.cgi?id=154667
2780
2781         Reviewed by Ryosuke Niwa and Simon Fraser.
2782
2783         Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
2784         Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.
2785
2786         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2787         (ServerControl.render_POST): Deleted.
2788         * Scripts/webkitpy/thirdparty/__init__.py:
2789         (AutoinstallImportHook.find_module):
2790         (AutoinstallImportHook._install_twisted_15_5_0):
2791         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2792         (ThirdpartyTest.test_imports):
2793
2794 2016-03-14  Mark Lam  <mark.lam@apple.com>
2795
2796         Need to distinguish between Symbol() and Symbol("").
2797         https://bugs.webkit.org/show_bug.cgi?id=155438
2798
2799         Reviewed by Saam Barati.
2800
2801         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2802         (TestWebKitAPI::TEST):
2803         - Test that the a symbol with an empty string is not equivalent to a null symbol. 
2804
2805 2016-03-14  David Kilzer  <ddkilzer@apple.com>
2806
2807         Remove blank lines after #include "config.h"
2808
2809         Follow-up fix from review comments on Bug 155394.
2810
2811         * TestWebKitAPI/PlatformUtilities.cpp:
2812         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
2813
2814 2016-03-14  Frederic Wang  <fred.wang@free.fr>
2815
2816         Unreviewed: Add my professional email address.
2817
2818         * Scripts/webkitpy/common/config/contributors.json:
2819
2820 2016-03-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2821
2822         Web platform test server should not try to launch servers on already bound sockets
2823         https://bugs.webkit.org/show_bug.cgi?id=141157
2824
2825         Reviewed by Darin Adler.
2826
2827         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2828         (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json.
2829         (base_url): Refactored to use wpt_config_json routine.
2830         (WebPlatformTestServer.__init__): Fill port mappings according WPT config.
2831
2832 2016-03-13  Joseph Pecoraro  <pecoraro@apple.com>
2833
2834         Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
2835         https://bugs.webkit.org/show_bug.cgi?id=155417
2836
2837         Reviewed by Yusuke Suzuki.
2838
2839         * Scripts/webkitperl/FeatureList.pm:
2840         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2841
2842 2016-03-13  Dean Jackson  <dino@apple.com>
2843
2844         DRT should enable WebGL by default on Mac
2845         https://bugs.webkit.org/show_bug.cgi?id=155419
2846         <rdar://problem/25136981>
2847
2848         Reviewed by Sam Weinig.
2849
2850         For some reason, lost in time, WebGL was enabled
2851         by default on trunk, but disabled by default
2852         in DumpRenderTree when using WebKit 1. This
2853         was very annoying, because each test had
2854         an explicit command to enable it.
2855
2856         * DumpRenderTree/mac/DumpRenderTree.mm:
2857         (resetWebPreferencesToConsistentValues): Deleted WebGL line.
2858
2859 2016-03-13  Konstantin Tokarev  <annulen@yandex.ru>
2860
2861         Added new port JSCOnly.
2862         https://bugs.webkit.org/show_bug.cgi?id=154512
2863
2864         Reviewed by Michael Catanzaro.
2865
2866         This port allows to build JavaScriptCore engine with minimal
2867         dependencies.
2868
2869         * Scripts/build-jsc:
2870         * Scripts/webkitdirs.pm:
2871         (argumentsForConfiguration):
2872         (executableProductDir):
2873         (determinePortName):
2874         (isJSCOnly):
2875         (wrapperPrefixIfNeeded):
2876         (generateBuildSystemFromCMakeProject):
2877         (buildCMakeGeneratedProject):
2878
2879 2016-03-13  David Kilzer  <ddkilzer@apple.com>
2880
2881         TestWebKitAPI: fix linker warnings
2882         <http://webkit.org/b/155394>
2883
2884         Reviewed by Darin Adler.
2885
2886         * TestWebKitAPI/CMakeLists.txt:
2887         - Add RefLogger.cpp source file.
2888         - Add other missing cross-platform source files.
2889         - Add FIXMEs about RunLoop.cpp and about missing
2890           platform-specific source files.
2891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2892         - Add RefLogger.cpp source file.
2893
2894         * TestWebKitAPI/Counters.cpp:
2895         (DeleterCounter<ConstructorDestructorCounter>::deleterCount):
2896         Move specific declaration here to fix linker warning.
2897         * TestWebKitAPI/Counters.h:
2898         (DeleterCounter<T>::deleterCount): Remove declaration of global
2899         template variable.
2900
2901         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added.
2902         (TestWebKitAPI::log): Added.  Move inline definition in
2903         RefLogger.h to here to fix linker warning.
2904
2905         * TestWebKitAPI/Tests/WTF/RefLogger.h:
2906         (TestWebKitAPI::log): Replace inline function with declaration.
2907
2908 2016-03-12  David Kilzer  <ddkilzer@apple.com>
2909
2910         REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp
2911
2912         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to
2913         "Test.h" to fix incorrect case.  This was discovered when adding
2914         WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394.
2915
2916 2016-03-12  David Kilzer  <ddkilzer@apple.com>
2917
2918         run-webkit-tests: handle Darwin framework/library environment variables more consistently
2919         <http://webkit.org/b/155392>
2920
2921         Reviewed by Daniel Bates.
2922
2923         These changes will make it possible to pass through environment
2924         variables from the run-webkit-tests command-line.
2925
2926         * Scripts/webkitpy/port/base.py:
2927         (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH,
2928         __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the
2929         list of variables to keep from the run-webkit-test environment.
2930
2931         * Scripts/webkitpy/port/driver.py:
2932         (Driver._append_environment_variable_path): Add method to append
2933         a path to an environment variable, or set the path if the
2934         variable doesn't exist.
2935         (Driver._setup_environ_for_driver): Extract build_root_path into
2936         a local variable.  Use Driver._append_environment_variable_path
2937         to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH,
2938         DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of
2939         overwriting them.
2940
2941         * Scripts/webkitpy/port/driver_unittest.py:
2942         (DriverTest.test__append_environment_variable_path): Add test
2943         method to test Driver._append_environment_variable_path.
2944
2945 2016-03-11  Alexey Proskuryakov  <ap@apple.com>
2946
2947         [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out
2948         https://bugs.webkit.org/show_bug.cgi?id=155276
2949
2950         [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out
2951         https://bugs.webkit.org/show_bug.cgi?id=155345
2952
2953         [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
2954         https://bugs.webkit.org/show_bug.cgi?id=153997
2955         <rdar://problem/23580034>
2956
2957         <rdar://problem/23580018> TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty
2958
2959         Rubber-stamped by Filip Pizlo.
2960
2961         * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout.
2962
2963         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
2964         on iOS again.
2965
2966 2016-03-11  Jer Noble  <jer.noble@apple.com>
2967
2968         [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting
2969         https://bugs.webkit.org/show_bug.cgi?id=155365
2970
2971         Reviewed by Darin Adler.
2972
2973         Allow tests running on iOS simulator to play video inline, avoiding this assert.
2974
2975         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2976         (RequiresUserActionForPlaybackTest::SetUp):
2977
2978 2016-03-11  Frederic Wang  <fwang@igalia.com>
2979
2980         [jhbuild] Disable LLVM OCaml bindings.
2981         https://bugs.webkit.org/show_bug.cgi?id=153274
2982
2983         Reviewed by Michael Catanzaro.
2984
2985         * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM.
2986
2987 2016-03-11  Commit Queue  <commit-queue@webkit.org>
2988
2989         Unreviewed, rolling out r197495.
2990         https://bugs.webkit.org/show_bug.cgi?id=155369
2991
2992         LLVM is needed to run update-webkitgtk-libs reliably
2993         (Requested by mcatanzaro on #webkit).
2994
2995         Reverted changeset:
2996
2997         "[jhbuild] Remove LLVM dependency."
2998         https://bugs.webkit.org/show_bug.cgi?id=153274
2999         http://trac.webkit.org/changeset/197495
3000
3001 2016-03-11  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3002
3003         WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
3004         https://bugs.webkit.org/show_bug.cgi?id=153419
3005
3006         Reviewed by Darin Adler.
3007
3008         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3009         (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase.
3010
3011
3012 2016-03-10  Simon Fraser  <simon.fraser@apple.com>
3013
3014         Font antialiasing (smoothing) changes when elements are rendered into compositing layers
3015         https://bugs.webkit.org/show_bug.cgi?id=23364
3016
3017         Reviewed by Tim Horton.
3018
3019         Turn off smoothed layer text because it affects many layout test results.
3020
3021         * DumpRenderTree/mac/DumpRenderTree.mm:
3022         (resetWebViewToConsistentStateBeforeTesting):
3023         * WebKitTestRunner/TestController.cpp:
3024         (WTR::TestController::resetStateToConsistentValues):
3025
3026 2016-03-10  Jer Noble  <jer.noble@apple.com>
3027
3028         Partial roll-out of r197953; test fails because encode/decode support of those properties were never added.
3029
3030         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3031         (TEST): Deleted.
3032
3033 2016-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3034
3035         [OS X] Main frame scrollbars should appear on the left on RTL systems
3036         https://bugs.webkit.org/show_bug.cgi?id=155149
3037
3038         Reviewed by Simon Fraser.
3039
3040         Setting the volatile default needs to be done early, so it is
3041         plumbed through the injected bundle's initialization routine.
3042
3043         Control of RTL scrollbars is handled by putting the string
3044         <!-- webkit-test-runner [ rtlScrollbars=true ] -->
3045         on the first line of a test.
3046
3047         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3048         (WTR::shouldUseRTLScrollbars):
3049         (WTR::InjectedBundle::platformInitialize):
3050         * WebKitTestRunner/TestController.cpp:
3051         (WTR::TestController::generatePageConfiguration):
3052         (WTR::updateTestOptionsFromTestHeader):
3053         (WTR::TestController::getInjectedBundleInitializationUserData):
3054         * WebKitTestRunner/TestController.h:
3055         * WebKitTestRunner/TestOptions.h:
3056         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3057         (WTR::PlatformWebView::viewSupportsOptions):
3058
3059 2016-03-08  Jer Noble  <jer.noble@apple.com>
3060
3061         Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
3062         https://bugs.webkit.org/show_bug.cgi?id=155141
3063
3064         Reviewed by Beth Dakin.
3065
3066         Set the default values for media preferences unconditionally, not just on PLATFORM(IOS). Set "video requires user gesture"
3067         to sane defaults in addition to "audio requires user gesture" and (in the case of DumpREnderTree) instead of "media requires user gesture".
3068
3069         Add a new test of WK2 user gesture requirement preferences.
3070
3071         * DumpRenderTree/mac/DumpRenderTree.mm:
3072         (resetWebPreferencesToConsistentValues):
3073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3074         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
3075         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
3076         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Added.
3077         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]):
3078         (-[RequiresUserActionForPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
3079         (RequiresUserActionForPlaybackTest::SetUp):
3080         (RequiresUserActionForPlaybackTest::createWebView):
3081         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
3082         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
3083         (RequiresUserActionForPlaybackTest::testAudioOnly):
3084         (TEST_F):
3085         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3086         (TEST):
3087
3088 2016-03-10  Brian Burg  <bburg@apple.com>
3089
3090         Web Inspector: should be able to run protocol and input generator scripts from any directory
3091         https://bugs.webkit.org/show_bug.cgi?id=155307
3092
3093         Reviewed by Joseph Pecoraro.
3094
3095         * Scripts/webkitpy/inspector/main.py:
3096         (InspectorGeneratorTests.main):
3097         * Scripts/webkitpy/replay/main.py:
3098         (InputGeneratorTests.main):
3099         Compute the current SCM based on the location of the script being executed, not
3100         the $CWD which could be anything. There's rarely a good reason to use $CWD.
3101
3102 2016-03-10  David Kilzer  <ddkilzer@apple.com>
3103
3104         [iOS] DumpRenderTree crashes when accessing window.testRunner.inspectorTestStubURL
3105         <http://webkit.org/b/155295>
3106
3107         Reviewed by Brent Fulgham.
3108
3109         * DumpRenderTree/mac/TestRunnerMac.mm:
3110         (TestRunner::inspectorTestStubURL): Always return nullptr for
3111         PLATFORM(IOS).  This matches what we did in r192604 for
3112         WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm.
3113
3114 2016-03-10  Frederic Wang  <fwang@igalia.com>
3115
3116         [GTK] Add support for WOFF2
3117         https://bugs.webkit.org/show_bug.cgi?id=152616
3118
3119         Reviewed by Carlos Garcia Campos.
3120
3121         * Scripts/webkitpy/style/checker.py: Only verify basic style for third party modules brotli and woff2.
3122
3123 2016-03-09  Ryosuke Niwa  <rniwa@webkit.org>
3124
3125         Add runtime flags for shadow DOM and custom elements
3126         https://bugs.webkit.org/show_bug.cgi?id=155213
3127
3128         Reviewed by Dean Jackson.
3129
3130         Always enable shadow DOM and custom elements during testing.
3131
3132         * DumpRenderTree/mac/DumpRenderTree.mm:
3133         (resetWebPreferencesToConsistentValues):
3134         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3135         (WTR::InjectedBundle::beginTesting):
3136         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3137         (WTR::TestRunner::setShadowDOMEnabled): Added.
3138         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3139
3140 2016-03-09  Brent Fulgham  <bfulgham@apple.com>
3141
3142         Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
3143         https://bugs.webkit.org/show_bug.cgi?id=155265
3144         <rdar://problem/11101440>
3145
3146         Reviewed by Andy Estes.
3147
3148         WK2 localStorage tests need the 'AllowUniversalAccessFromFileURLs' preference set by default.
3149         Tests that confirm blocking localStorage manually set the flag to "False" in the test.
3150
3151         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3152         (WTR::initializeWebViewConfiguration): Set the default state to the correct value.
3153
3154 2016-03-09  David Kilzer  <ddkilzer@apple.com>
3155
3156         check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files
3157         <http://webkit.org/b/155273>
3158
3159         Reviewed by Andy Estes.
3160
3161         * Scripts/webkitpy/style/checkers/cpp.py:
3162         (check_spacing_for_function_call): Ignore @catch lines.
3163         (check_braces): Ditto.
3164         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3165         (CppStyleTest.test_brace_at_begin_of_line): Add test case.
3166
3167 2016-03-09  Jason Marcell  <jmarcell@apple.com>
3168
3169         Removing reference to Dashboard.Repository.Internal.trac from open source unit tests.
3170         https://bugs.webkit.org/show_bug.cgi?id=155274
3171
3172         Reviewed by Alexey Proskuryakov.
3173
3174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:
3175         (setup): Deleted. In bug 154180 we removed Dashboard.Repository.Internal which was causing an
3176         error in the unit tests.
3177
3178 2016-03-09  Aakash Jain  <aakash_jain@apple.com>
3179
3180         use ulimit command to check process limit in webkitpy
3181         https://bugs.webkit.org/show_bug.cgi?id=155260
3182
3183         Reviewed by Alexey Proskuryakov.
3184
3185         * Scripts/webkitpy/port/ios.py:
3186         (IOSSimulatorPort.default_child_processes): Use ulimit command output instead of 
3187         launchctl limit maxproc command.
3188
3189 2016-03-09  Alexey Proskuryakov  <ap@apple.com>
3190
3191         Stop building armv7 on iOS device builders
3192         https://bugs.webkit.org/show_bug.cgi?id=155246
3193
3194         Reviewed by David Kilzer.
3195
3196         * BuildSlaveSupport/build.webkit.org-config/config.json: Building both armv7 and
3197         armv7s makes the bots unnecessarily slow. We can catch super rare v7-only regressions
3198         elsewhere.
3199
3200         * Scripts/webkitpy/common/config/ews.json: Changed EWS to match, as we always want
3201         EWS configuration to be verified by buildbot queues.
3202
3203         * Scripts/webkitdirs.pm:
3204         * Scripts/webkitpy/port/ios.py:
3205         Changed default to arm64. I think that the default is probably not used in any
3206         practical scenarios, but it's nice to make it more sensible.
3207
3208 2016-03-09  Alexey Proskuryakov  <ap@apple.com>
3209
3210         Add iOS Simulator EWS to bot watcher's dashboard
3211         https://bugs.webkit.org/show_bug.cgi?id=155220
3212
3213         Reviewed by Lucas Forschler.
3214
3215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3216
3217 2016-03-09  Brent Fulgham  <bfulgham@apple.com>
3218
3219         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
3220         https://bugs.webkit.org/show_bug.cgi?id=155185
3221         <rdar://problem/11101440>
3222
3223         Reviewed by Anders Carlsson.
3224
3225         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
3226         (TestWebKitAPI::TEST): Allow local file accesss to run test.
3227         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3228         (TEST): Ditto.
3229         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
3230         (TEST): Ditto.
3231
3232 2016-03-09  Tim Horton  <timothy_horton@apple.com>
3233
3234         Removing and re-adding a script message handler with the same name results in an unusable message handler
3235         https://bugs.webkit.org/show_bug.cgi?id=155223
3236
3237         Reviewed by Sam Weinig.
3238
3239         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3240         (TEST):
3241         Add a test ensuring that it is possible to remove and re-add a script message handler
3242         with the same name and still dispatch messages to it.
3243
3244 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
3245
3246         Fix iOS Simulator EWS.
3247
3248         Unreviewed build fix.
3249
3250         * Scripts/webkitpy/common/config/ports.py:
3251
3252 2016-03-08  Aakash Jain  <aakash_jain@apple.com>
3253
3254         Booting multiple iOS simulator parallely fails sometimes
3255         https://bugs.webkit.org/show_bug.cgi?id=155208
3256         <rdar://problem/25019651>
3257
3258         Reviewed by Darin Adler.
3259
3260         * Scripts/webkitpy/port/ios.py:
3261         (IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent
3262         simulator boot.
3263
3264 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
3265
3266         Add iOS debug testers to flakiness dashboard
3267         https://bugs.webkit.org/show_bug.cgi?id=155206
3268
3269         Reviewed by Darin Adler.
3270
3271         * TestResultServer/static-dashboards/builders.jsonp:
3272
3273 2016-03-08  Oliver Hunt  <oliver@apple.com>
3274
3275         Start moving to separated writable and executable mappings in the JIT
3276         https://bugs.webkit.org/show_bug.cgi?id=155178
3277
3278         Reviewed by Fil Pizlo.
3279
3280         Making run-jsc-benchmarks slightly happier on my machine.
3281
3282         * Scripts/run-jsc-benchmarks:
3283
3284 2016-03-08  Anders Carlsson  <andersca@apple.com>
3285
3286         Use NSUInteger instead of NSWindowStyleMask.
3287
3288         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3289
3290 2016-03-08  Anders Carlsson  <andersca@apple.com>
3291
3292         Fix build.
3293
3294         We intentionally don't use AppKitCompatibilityDeclarations.h here, since we want
3295         MiniBrowser to build without WTF.
3296
3297         * MiniBrowser/mac/AppDelegate.m:
3298         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3299         * MiniBrowser/mac/BrowserWindowController.m:
3300         (-[BrowserWindowController windowDidLoad]):
3301         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3302
3303 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
3304
3305         Add iOS simulator EWS that runs tests
3306         https://bugs.webkit.org/show_bug.cgi?id=155175
3307
3308         Reviewed by Lucas Forschler.
3309
3310         * QueueStatusServer/config/queues.py:
3311         * Scripts/webkitpy/common/config/ews.json:
3312         * Scripts/webkitpy/common/config/ports.py:
3313
3314 2016-03-08  Commit Queue  <commit-queue@webkit.org>
3315
3316         Unreviewed, rolling out r197793 and r197799.
3317         https://bugs.webkit.org/show_bug.cgi?id=155195
3318
3319         something weird happened while landing this and everything
3320         broke (Requested by olliej on #webkit).
3321
3322         Reverted changesets:
3323
3324         "Start moving to separated writable and executable mappings in
3325         the JIT"
3326         https://bugs.webkit.org/show_bug.cgi?id=155178
3327         http://trac.webkit.org/changeset/197793
3328
3329         "arm64 build fix after r197793."
3330         http://trac.webkit.org/changeset/197799
3331
3332 2016-03-08  Oliver Hunt  <oliver@apple.com>
3333
3334         Start moving to separated writable and executable mappings in the JIT
3335         https://bugs.webkit.org/show_bug.cgi?id=155178
3336
3337         Reviewed by Filip Pizlo.
3338
3339         Making run-jsc-benchmarks slightly happier on my machine.
3340
3341         * Scripts/run-jsc-benchmarks:
3342
3343 2016-03-08  Daniel Bates  <dabates@apple.com>
3344
3345         Support iterating over an OptionSet and checking if it is empty
3346         https://bugs.webkit.org/show_bug.cgi?id=154941
3347         <rdar://problem/24964187>
3348
3349         Reviewed by Darin Adler.
3350
3351         Add tests to ensure that we do not regression both iteration of an OptionSet and
3352         determining whether an OptionSet is empty.
3353
3354         * TestWebKitAPI/Test.h:
3355         (TestWebKitAPI::Util::assertStrongEnum): Helper function to assert two strong enum type for equality.
3356         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
3357         (TestWebKitAPI::TEST):
3358
3359 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
3360
3361         Add debug iOS Simulator bots to the dashboard
3362         https://bugs.webkit.org/show_bug.cgi?id=155157
3363
3364         Reviewed by Darin Adler.
3365
3366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3367
3368 2016-03-08  Alejandro G. Castro  <alex@igalia.com>
3369
3370         Unreviewed EFL build fix after r197752.
3371
3372         * Scripts/webkitperl/FeatureList.pm: Avoid MEDIA_STREAM
3373         compilation by default until EFL bumps gstreamer to 1.6.
3374
3375 2016-03-08  Alejandro G. Castro  <alex@igalia.com>
3376
3377         [GTK] [EFL] Avoid running mediastream tests by default until we compile by default
3378         https://bugs.webkit.org/show_bug.cgi?id=153540
3379
3380         Reviewed by Philippe Normand.
3381
3382         After bumping gstreamer to 1.6.3 in r196804 we can enable again
3383         compilation of mediastream and running the tests.
3384
3385         * Scripts/run-gtk-tests:
3386         (TestRunner): Enable again the UserMedia API test.
3387         * Scripts/webkitperl/FeatureList.pm: Enable the compilation of the
3388         mediastream by default.
3389         * gtk/jhbuild-webrtc.modules: Removed the specific jhbuild modules
3390         file.
3391         * gtk/jhbuild.modules: Bumped the openwebrtc version to the one we
3392         are currently using.
3393
3394 2016-03-07  Jon Lee  <jonlee@apple.com>
3395
3396         Update perf bot configuration for Animometer
3397         https://bugs.webkit.org/show_bug.cgi?id=155134
3398
3399         Reviewed by Ryosuke Niwa.
3400
3401         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Refactor the patch
3402         to work with the latest version of the harness.
3403         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Bump up the timeout,
3404         and use the latest version of the harness.
3405
3406 2016-03-07  Joanmarie Diggs  <jdiggs@igalia.com>
3407
3408         [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0
3409         https://bugs.webkit.org/show_bug.cgi?id=154839
3410
3411         Reviewed by Michael Catanzaro.
3412
3413         Add '-Wno-error' to jhbuildrc; remove it from the module sets for macos.
3414
3415         * gtk/jhbuild-webrtc.modules:
3416         * gtk/jhbuild.modules:
3417         * gtk/jhbuildrc:
3418
3419 2016-03-07  Aakash Jain  <aakash_jain@apple.com>
3420
3421         webkitpy should verify timestamp from CrashLogs while collecting all crash logs
3422         https://bugs.webkit.org/show_bug.cgi?id=155000
3423         <rdar://problem/24860219>
3424
3425         Reviewed by Alexey Proskuryakov.
3426
3427         * Scripts/webkitpy/common/system/crashlogs.py:
3428         (CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected 
3429         time range, because file modification time is not always accurate.
3430         (CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs.
3431         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3432         (CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function.
3433
3434 2016-03-06  Alexey Proskuryakov  <ap@apple.com>
3435
3436         build-webkit prints an error on iOS simulator bots
3437         https://bugs.webkit.org/show_bug.cgi?id=155078
3438
3439         Reviewed by Dan Bernstein.
3440
3441         This happens when build-layouttestrelay sets $xcodeSDK to undefined, to use host SDK.
3442
3443         * Scripts/webkitdirs.pm: (buildXCodeProject): There is no need to pass -sdk, because
3444         XcodeOptions() already passes SDKROOT as appropriate.
3445
3446         * Scripts/build-layouttestrelay: Added a FIXME. Resetting $xcodeSDK doesn't reset
3447         any other configuration variables that were derived from its initial value, like $portName.
3448
3449 2016-03-05  Tim Horton  <timothy_horton@apple.com>
3450
3451         Create a DOMHTMLVideoElement when wrapping <video> elements
3452         https://bugs.webkit.org/show_bug.cgi?id=155084
3453         <rdar://problem/24997193>
3454
3455         Reviewed by Dan Bernstein.
3456
3457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3458         * TestWebKitAPI/Tests/mac/DOMHTMLVideoElementWrapper.mm: Added.
3459         (-[VideoWrapperFrameLoadDelegate webView:didFinishLoadForFrame:]):
3460         (TestWebKitAPI::TEST):
3461         Add an API test for this behavior.
3462
3463 2016-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3464
3465         [GTK] Fix logging details after r197505 (Run the run-benchmark script on the performance bot.)
3466         https://bugs.webkit.org/show_bug.cgi?id=154595
3467
3468         Unreviewed.
3469
3470         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3471         (start): Use logging.exception when a test fails in order to get the details about the error.
3472
3473 2016-03-04  Alexey Proskuryakov  <ap@apple.com>
3474
3475         Add iOS simulator debug bots
3476         https://bugs.webkit.org/show_bug.cgi?id=155053
3477
3478         Reviewed by Lucas Forschler.
3479
3480         * BuildSlaveSupport/build.webkit.org-config/config.json:
3481
3482 2016-03-04  Brent Fulgham  <bfulgham@apple.com>
3483
3484         [WK2] Gather resource load statistics
3485         https://bugs.webkit.org/show_bug.cgi?id=154278
3486         <rdar://problem/24702892>
3487
3488         Reviewed by Andy Estes.
3489
3490         * MiniBrowser/mac/AppDelegate.m:
3491         (defaultConfiguration): Retrieve state of the ResourceLoadStatisticsEnabled setting.
3492         * MiniBrowser/mac/SettingsController.m:
3493         (-[SettingsController _populateMenu]): Move setting from WK1-only to be
3494         universally applicable.
3495         * MiniBrowser/mac/WK2BrowserWindowController.m:
3496         (-[WK2BrowserWindowController didChangeSettings]): Recognize when the
3497         Resource Load Statistics flag has changed.
3498
3499 2016-03-04  Alex Christensen  <achristensen@webkit.org>
3500
3501         Remove vcxproj build system
3502         https://bugs.webkit.org/show_bug.cgi?id=154388
3503
3504         Rubber-stamped by Brent Fulgham.
3505
3506         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Removed.
3507         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Removed.
3508         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Removed.
3509         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Removed.
3510         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Removed.
3511         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Removed.
3512         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Removed.
3513         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Removed.
3514         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Removed.
3515         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Removed.
3516         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Removed.
3517         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Removed.
3518         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Removed.
3519         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Removed.
3520         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Removed.
3521         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Removed.
3522         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Removed.
3523         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Removed.
3524         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Removed.
3525         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Removed.
3526         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Removed.
3527         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Removed.
3528         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Removed.
3529         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Removed.
3530         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Removed.
3531         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Removed.
3532         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Removed.
3533         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Removed.
3534         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Removed.
3535         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Removed.
3536         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Removed.
3537         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Removed.
3538         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Removed.
3539         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Removed.
3540         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Removed.
3541         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Removed.
3542         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Removed.
3543         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Removed.
3544         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Removed.
3545         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Removed.
3546         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Removed.
3547         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Removed.
3548         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Removed.
3549         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Removed.
3550         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Removed.
3551         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Removed.
3552         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Removed.
3553         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Removed.
3554         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Removed.
3555         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Removed.
3556         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Removed.
3557         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Removed.
3558         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Removed.
3559         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Removed.
3560         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Removed.
3561         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Removed.
3562         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Removed.
3563         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Removed.
3564         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Removed.
3565         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Removed.
3566         * TestWebKitAPI/TestWebKitAPI.vcxproj: Removed.
3567         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Removed.
3568         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Removed.
3569         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Removed.
3570         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Removed.
3571         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Removed.
3572         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Removed.
3573         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Removed.
3574         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Removed.
3575         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Removed.
3576         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Removed.
3577         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Removed.
3578         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Removed.
3579         * win/AssembleBuildLogs: Removed.
3580         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Removed.
3581         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Removed.
3582         * win/AssembleBuildLogs/AssembleLogs.cmd: Removed.
3583         * win/AssembleBuildLogs/README: Removed.
3584
3585 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
3586
3587         Whitespace causes font-variant: all-small-caps to synthesize
3588         https://bugs.webkit.org/show_bug.cgi?id=155004
3589         <rdar://problem/24630796>
3590
3591         Reviewed by Darin Adler.
3592
3593         * DumpRenderTree/mac/DumpRenderTree.mm:
3594         (allowedFontFamilySet):
3595         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3596         (WTR::allowedFontFamilySet):
3597         * WebKitTestRunner/mac/TestControllerMac.mm:
3598         (WTR::allowedFontFamilySet):
3599
3600 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
3601
3602         [iOS] Crash during font loading when injected bundle cancels load
3603         https://bugs.webkit.org/show_bug.cgi?id=155001
3604
3605         Reviewed by Tim Horton.
3606
3607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3608         * TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Added.
3609         * TestWebKitAPI/Tests/WebKit2/webfont.html: Added.
3610         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Added.
3611         (-[Myles webView:didFinishNavigation:]):
3612         (TEST):
3613         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Added.
3614         (-[CancelFontSubresourcePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3615         (-[CancelFontSubresourcePlugIn webProcessPlugInBrowserContextController:frame:willSendRequestForResource:request:redirectResponse:]):
3616
3617 2016-03-04  Konstantin Tokarev  <annulen@yandex.ru>
3618
3619         [check-webkit-style] Added checks for redundant virtual specifiers.
3620         https://bugs.webkit.org/show_bug.cgi?id=155017
3621
3622         Reviewed by Darin Adler.
3623
3624         Added 3 new checks related to virtual, override, and final specifiers:
3625
3626         1. When "override" is present, "virtual" is redundant.
3627         2. When "final" is present, "virtual" is redundant.
3628         3. When "final" is present, "override" is redundant.
3629
3630         * Scripts/webkitpy/style/checkers/cpp.py:
3631         (_FunctionState.begin):
3632         (_FunctionState.is_virtual):
3633         (_check_parameter_name_against_text):
3634         (_error_redundant_specifier):
3635         (check_function_definition):
3636         (CppChecker):
3637         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3638         (FunctionDetectionTest.perform_function_detection):
3639         (FunctionDetectionTest.test_basic_function_detection):
3640         (FunctionDetectionTest.test_function_declaration_detection):
3641         (FunctionDetectionTest.test_pure_function_detection):
3642         (FunctionDetectionTest.test_override_and_final_function_detection):
3643         (FunctionDetectionTest.test_non_functions):
3644         (FunctionDetectionTest.test_parameter_list):
3645
3646 2016-03-03  Darin Adler  <darin@apple.com>
3647
3648         Followup to:
3649         Remove "virtual" from all lines that have both "virtual" and "override".
3650         https://bugs.webkit.org/show_bug.cgi?id=155005
3651
3652         Reviewed by Geoffrey Garen.
3653
3654         * Scripts/do-webcore-rename: Added more regular expressions to make sure we always
3655         use either override or final, not both, and to remove virtual from all lines that
3656         have both virtual and final.
3657
3658 2016-03-03  Darin Adler  <darin@apple.com>
3659
3660         Remove "virtual" from all lines that have both "virtual" and "override".
3661         https://bugs.webkit.org/show_bug.cgi?id=155005
3662
3663         Reviewed by Geoffrey Garen.
3664
3665         * Scripts/do-webcore-rename: Added a regular expression to this script to do the job.
3666
3667 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3668
3669         [GTK] Unreviewed fix after r197505 (Run the run-benchmark script on the performance bot.)
3670         https://bugs.webkit.org/show_bug.cgi?id=154595
3671
3672         Unreviewed fix after r197505.
3673
3674         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3675         (RunBenchmarkTests.start):
3676
3677 2016-03-03  Daniel Bates  <dabates@apple.com>
3678
3679         Add unit tests for WTF::OptionSet
3680         https://bugs.webkit.org/show_bug.cgi?id=154925
3681         <rdar://problem/24964211>
3682
3683         Reviewed by Darin Adler.
3684
3685         Add tests to ensure that we do not regress the behavior of WTF::OptionSet.
3686
3687         * TestWebKitAPI/CMakeLists.txt: Add file TestWebKitAPI/Tests/WTF/OptionSet.cpp.
3688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3689         * TestWebKitAPI/Tests/WTF/OptionSet.cpp: Added.
3690         (TestWebKitAPI::TEST):
3691
3692 2016-03-03  Commit Queue  <commit-queue@webkit.org>
3693
3694         Unreviewed, rolling out r197442.
3695         https://bugs.webkit.org/show_bug.cgi?id=154967
3696
3697         Broke tests, and also uses a wrong approach (Requested by ap
3698         on #webkit).
3699
3700         Reverted changeset:
3701
3702         "Disable FTL JIT testing on 32-bit JSC tester bots"
3703         https://bugs.webkit.org/show_bug.cgi?id=154858
3704         http://trac.webkit.org/changeset/197442
3705
3706 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3707
3708         [GTK] Run the run-benchmark script on the performance bot.
3709         https://bugs.webkit.org/show_bug.cgi?id=154595
3710
3711         Reviewed by Carlos Garcia Campos.
3712
3713         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add new RunBenchmarkTests step on the perf bots (only for the GTK+ port at this moment).
3714         (RunBenchmarkTests):
3715         (RunBenchmarkTests.start):
3716         (RunBenchmarkTests.getText):
3717         (RunBenchmarkTests.getText2):
3718         (BuildAndPerfTestFactory.__init__):
3719         (DownloadAndPerfTestFactory.__init__):
3720         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add new test for RunBenchmarkTests and update expected steps of GTK+ perf bot.
3721         (RunBenchmarkTest):
3722         (RunBenchmarkTest.assertResults):
3723         (RunBenchmarkTest.test_success):
3724         (RunBenchmarkTest.test_tests_failed):
3725         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Log both the current iteration as also the total iterations for the current benchmark/plan.
3726         (BenchmarkRunner._run_benchmark):
3727         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Use python logging also for errors.
3728         (GTKMiniBrowserDriver.close_browsers):
3729         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Implement support for running all available benchmark plans.
3730         (parse_args):
3731         (start):
3732         (main):
3733
3734 2016-03-03  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3735
3736         [EFL] Remove u-szeged.hu SVN mirror in EFL perf bot
3737         https://bugs.webkit.org/show_bug.cgi?id=154960
3738
3739         Reviewed by Csaba Osztrogonác.
3740
3741         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove szeged univ's svn mirror.
3742         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3743
3744 2016-03-03  Frederic Wang  <fwang@igalia.com>
3745
3746         [jhbuild] Remove LLVM dependency.
3747         https://bugs.webkit.org/show_bug.cgi?id=153274
3748
3749         Reviewed by Carlos Garcia Campos.
3750
3751         * gtk/jhbuild.modules:
3752
3753 2016-03-02  Alejandro G. Castro  <alex@igalia.com>
3754
3755         Unreviewed build fix for media-stream after r197114.
3756
3757         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3758         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
3759
3760 2016-03-01  Csaba Osztrogonác  <ossy@webkit.org>
3761
3762         Disable FTL JIT testing on 32-bit JSC tester bots
3763         https://bugs.webkit.org/show_bug.cgi?id=154858
3764
3765         Reviewed by Saam Barati.
3766
3767         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3768         (Run32bitJSCTests):
3769
3770 2016-03-01  Dean Johnson  <dean_johnson@apple.com>
3771
3772         Fix iOS EWS.
3773         https://bugs.webkit.org/show_bug.cgi?id=154880
3774
3775         Reviewed by Alexey Proskuryakov.
3776
3777         * Scripts/copy-webkitlibraries-to-product-directory:
3778
3779 2016-02-29  Chris Dumez  <cdumez@apple.com>
3780
3781         Have parseHTMLInteger() / parseHTMLNonNegativeInteger() use WTF::Optional
3782         https://bugs.webkit.org/show_bug.cgi?id=154845
3783
3784         Reviewed by Ryosuke Niwa.
3785
3786         Update API tests accordingly.
3787
3788         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
3789         (TestWebKitAPI::testParseHTMLInteger):
3790         (TestWebKitAPI::parseHTMLIntegerFails):
3791         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
3792         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
3793         (TestWebKitAPI::TEST): Deleted.
3794
3795 2016-02-29  Simon Fraser  <simon.fraser@apple.com>
3796
3797         Remove the experimental feature of antialiased font dilation
3798         https://bugs.webkit.org/show_bug.cgi?id=154843
3799
3800         Reviewed by Zalan Bujtas.
3801
3802         Remove the "antialiased font dilation" code path, and related prefs.
3803
3804         * DumpRenderTree/mac/DumpRenderTree.mm:
3805         (resetWebPreferencesToConsistentValues): Deleted.
3806         * WebKitTestRunner/TestController.cpp:
3807         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
3808
3809 2016-02-29  Brady Eidson  <beidson@apple.com>
3810
3811         Fix timing flakiness in test I added in http://trac.webkit.org/changeset/197372
3812
3813         Unreviewed.
3814
3815         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html:
3816         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3817         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3818         (TEST): Sometimes a third message from the first html file was leaking through. The message is expected
3819           so we should always wait for it and make sure we got it.
3820
3821 2016-02-29  Brady Eidson  <beidson@apple.com>
3822
3823         Modern IDB: WebKit 2 IPC layer easily confused about multiple web processes being connected.
3824         https://bugs.webkit.org/show_bug.cgi?id=154837
3825
3826         Reviewed by Alex Christensen.
3827
3828         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3829         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Added.
3830         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Added.
3831         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Added.
3832
3833 2016-02-29  Joanmarie Diggs  <jdiggs@igalia.com>
3834
3835         [GTK][jhbuild] GLib build fails with GCC 6.0
3836         https://bugs.webkit.org/show_bug.cgi?id=154825
3837
3838         Use the upstream work-around. https://bugzilla.gnome.org/show_bug.cgi?id=761550
3839
3840         Reviewed by Csaba Osztrogonác.
3841
3842         * gtk/jhbuild.modules: Apply upstream path.
3843         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Added.
3844
3845 2016-02-29  Filip Pizlo  <fpizlo@apple.com>
3846
3847         We've been running Octane/regexp all wrong in run-jsc-benchmarks
3848         https://bugs.webkit.org/show_bug.cgi?id=154827
3849
3850         Reviewed by Andreas Kling.
3851
3852         Octane v.2 and JetStream v.1.1 run this benchmark with warmup. This script was running
3853         it without warmup. This patches fixes this by making this script run it with warmup.
3854
3855         This fix shows that my last patch, which added FTL support for regexp, was actually a 3%
3856         speed-up on Octane/regexp, not a slow-down as the ChangeLog claimed.
3857
3858         It discovered this bug because for each Octane test that I want to debug, I usually make
3859         a standalone .js file that contains the whole test along with a miniharness - usually
3860         a plain loop - that runs it almost like it would for real but with whatever hacks I'm
3861         using for debugging. When I wrote such a thing for regexp, I used a ~20 iteration warmup
3862         to match the one second of warmup that this benchmark gets in Octane. To my surprise,
3863         this quite faithful regexp runner did not see the regression that run-jsc-benchmarks
3864         saw. That's when I found out that run-jsc-benchmarks was running it wrong.
3865
3866         The reason for the no-warmup slow-down is that the FTL is actually fairly expensive to
3867         run on some of these very large functions in the regexp benchmark. I don't think we can
3868         do anything about that, and I'd argue that the speed-up we see after the compilation is
3869         done suggests that it was worth it.
3870
3871         * Scripts/run-jsc-benchmarks:
3872
3873 2016-02-29  Gavin Barraclough  <barraclough@apple.com>
3874
3875         RefCounter<T>::Event -> RefCounterEvent
3876         https://bugs.webkit.org/show_bug.cgi?id=154767
3877
3878         Reviewed by Darin Adler.
3879
3880         RefCounter<T>::Event is kinda verbose to use, and there is no need for this
3881         to be specific to a particular typeof RefCounter. Move the enum class up to
3882         the top level & rename to RefCounterEvent.
3883
3884         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3885         (TestWebKitAPI::TEST):
3886
3887 2016-02-29  Csaba Osztrogonác  <ossy@webkit.org>
3888
3889         Remove more LLVM related cruft
3890         https://bugs.webkit.org/show_bug.cgi?id=154821
3891
3892         Reviewed by Darin Adler.
3893
3894         * Scripts/build-jsc:
3895         * Scripts/build-webkit:
3896         * Scripts/copy-webkitlibraries-to-product-directory:
3897         * Scripts/export-llvm-build: Removed.
3898         * Scripts/run-jsc-stress-tests:
3899
3900 2016-02-28  Sam Weinig  <sam@webkit.org>
3901
3902         Reimplement WKPageGroup in terms of WKUserContentController
3903         https://bugs.webkit.org/show_bug.cgi?id=154804
3904
3905         Reviewed by Dan Bernstein.
3906
3907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3908         * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Added.
3909
3910 2016-02-28  Sam Weinig  <sam@webkit.org>
3911
3912         Bind _WKUserStyleSheets to WKUserContentWorlds to allow for grouping of user content by associating to a world
3913         https://bugs.webkit.org/show_bug.cgi?id=154798
3914
3915         Reviewed by Dan Bernstein.
3916
3917         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3918         Add tests for removing _WKUserStyleSheets and WKUserScripts
3919
3920 2016-02-27  Alexey Proskuryakov  <ap@apple.com>
3921
3922         Silence leaks under TextCodecICU::registerCodecs
3923         https://bugs.webkit.org/show_bug.cgi?id=154737
3924
3925         Reviewed by Darin Adler.
3926
3927         * Scripts/webkitpy/port/leakdetector.py:
3928         (LeakDetector._callstacks_to_exclude_from_leaks):
3929
3930 2016-02-26  Michael Catanzaro  <mcatanzaro@igalia.com>
3931
3932         [GTK] Fix incorrect cast
3933
3934         Unreviewed.
3935
3936         * MiniBrowser/gtk/main.c:
3937         (createBrowserWindow):
3938
3939 2016-02-26  Chris Dumez  <cdumez@apple.com>
3940
3941         Fix the behavior of reflecting IDL attributes of type unsigned long
3942         https://bugs.webkit.org/show_bug.cgi?id=154771
3943
3944         Reviewed by Ryosuke Niwa.
3945
3946         Update API tests to cover the fixes to the parseHTMLNonNegativeInteger()
3947         implementation:
3948         - "-0" is parsed as 0.
3949         - Range boundaries are now [0; 2147483647].
3950
3951         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
3952         (TestWebKitAPI::TEST):
3953
3954 2016-02-26  Brady Eidson  <beidson@apple.com>
3955
3956         Modern IDB: New database versions are never committed to SQLite.
3957         <rdar://problem/24860952> and https://bugs.webkit.org/show_bug.cgi?id=154741
3958         
3959         Modern IDB: If a database handle is not open, files are not actually deleted from disk
3960         https://bugs.webkit.org/show_bug.cgi?id=154756
3961
3962         Reviewed by Alex Christensen.
3963
3964         This also happens to test the previously untested fix for http://trac.webkit.org/changeset/197190
3965
3966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3967         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Added.
3968         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Added.
3969         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Added.
3970         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]):
3971         (-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]):
3972         (TEST):
3973
3974 2016-02-26  Commit Queue  <commit-queue@webkit.org>
3975
3976         Unreviewed, rolling out r197216.
3977         https://bugs.webkit.org/show_bug.cgi?id=154766
3978
3979         Test simply needs updated result (Requested by litherum on
3980         #webkit).
3981
3982         Reverted changeset:
3983
3984         "Unreviewed, rolling out r197158."
3985         https://bugs.webkit.org/show_bug.cgi?id=154758
3986         http://trac.webkit.org/changeset/197216
3987
3988 2016-02-26  Alexey Proskuryakov  <ap@apple.com>
3989
3990         [iOS Simulator] Reftests don't work
3991         https://bugs.webkit.org/show_bug.cgi?id=154764
3992
3993         Reviewed by Daniel Bates.
3994
3995         * Scripts/webkitpy/port/image_diff.py: (IOSSimulatorImageDiffer._start):
3996         Use simctl instead of sim.
3997
3998 2016-02-26  Chris Dumez  <cdumez@apple.com>
3999
4000         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger
4001         https://bugs.webkit.org/show_bug.cgi?id=154714
4002
4003         Reviewed by Darin Adler.
4004
4005         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per:
4006         - https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
4007         - https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers
4008
4009         * TestWebKitAPI/PlatformEfl.cmake:
4010         * TestWebKitAPI/PlatformGTK.cmake:
4011         * TestWebKitAPI/PlatformWin.cmake:
4012         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4013         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
4014         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4015         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: Added.
4016         (TestWebKitAPI::testParseHTMLInteger):
4017         (TestWebKitAPI::parseHTMLIntegerFails):
4018         (TestWebKitAPI::TEST):
4019         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
4020         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
4021
4022 2016-02-26  Commit Queue  <commit-queue@webkit.org>
4023
4024         Unreviewed, rolling out r197158.
4025         https://bugs.webkit.org/show_bug.cgi?id=154758
4026
4027         This change did not fix the failing test (Requested by
4028         ryanhaddad on #webkit).
4029
4030         Reverted changeset:
4031
4032         "REGRESSION(r195795): [WK2] fast/text/crash-complex-text-
4033         surrogate.html is flakey"
4034         https://bugs.webkit.org/show_bug.cgi?id=154709
4035         http://trac.webkit.org/changeset/197158
4036
4037 2016-02-26  Anders Carlsson  <andersca@apple.com>
4038
4039         WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
4040         https://bugs.webkit.org/show_bug.cgi?id=154750
4041         rdar://problem/23861395
4042
4043         Reviewed by Tim Horton.
4044
4045         * MiniBrowser/mac/WK2BrowserWindowController.m:
4046         (-[WK2BrowserWindowController fetchWebsiteData:]):
4047         Use the new WKWebsiteDataStore SPI to compute data sizes.
4048
4049 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
4050
4051         RefCounter value changed callback should be called on all changes (not just zero edge).
4052         https://bugs.webkit.org/show_bug.cgi?id=154699
4053
4054         Reviewed by Geoff Garen.
4055
4056         RefCounter currently only triggers a callback when the count goes from zero
4057         to non-zero and vice-versa. Change that, to be useful to more clients.
4058
4059         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
4060         (TestWebKitAPI::TEST):
4061             - Updated for change in RefCounter callback siganture & behaviour.
4062
4063 2016-02-25  Sam Weinig  <sam@webkit.org>
4064
4065         Allow WKUserScripts to be run in isolated worlds
4066         https://bugs.webkit.org/show_bug.cgi?id=154701
4067
4068         Reviewed by Anders Carlsson.
4069
4070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4071         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorld.mm: Added.
4072         (-[SimpleDelegate webView:didFinishNavigation:]):
4073         (-[UserContentWorldRemoteObject didObserveNormalWorld]):
4074         (-[UserContentWorldRemoteObject didObserveWorldWithName:]):
4075         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldPlugIn.mm: Added.
4076         (-[_WKUserContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4077         (-[_WKUserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
4078         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldProtocol.h: Added.
4079
4080 2016-02-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4081
4082         W3C test importer should have an option to clean the destination directory
4083         https://bugs.webkit.org/show_bug.cgi?id=152685
4084
4085         Reviewed by Darin Adler.
4086
4087         Adding --clean-dest-dir option to W3C test importer.
4088         When this option is set, all files in the destination directory will be deleted
4089         except for WebKit specific files (test expectations, .gitignore...) before new tests import.
4090         Dangling test expectations are removed after tests import.'
4091
4092         Adding unit test and minor refactoring for the other tests.
4093
4094         * Scripts/webkitpy/w3c/test_importer.py:
4095         (parse_args): Add '--clean-dest-dir' option.
4096         (TestImporter.do_import):
4097         (TestImporter._is_baseline): helper routine to capture -expected.txt files.
4098         (TestImporter):
4099         (TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
4100         (TestImporter.clean_destination_directory):
4101         (TestImporter.remove_dangling_expectations):
4102         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4103         (TestImporterTest._parse_options):
4104         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
4105         (TestImporterTest.test_import_dir_with_no_tests):
4106         (TestImporterTest.test_import_dir_with_empty_init_py):
4107         (test_clean_directory_option):
4108
4109 2016-02-25  Myles C. Maxfield  <mmaxfield@apple.com>
4110
4111         REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
4112         https://bugs.webkit.org/show_bug.cgi?id=154709
4113         <rdar://problem/24483596>
4114
4115         Reviewed by Dan Bernstein.
4116
4117         Force auto-activation rules to a consistent state.
4118
4119         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4120         (WTR::InjectedBundle::platformInitialize):
4121
4122 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
4123
4124         Unreivewed build fix for r197150.
4125
4126         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
4127
4128 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
4129
4130         Restrict information passed with navigation action which is triggered by untrusted event
4131         https://bugs.webkit.org/show_bug.cgi?id=154571
4132         <rdar://problem/15967937>
4133
4134         Reviewed by Andy Estes.
4135
4136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4137         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: Added.
4138         (-[WKNavigationActionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4139         (TestWebKitAPI::TEST):
4140         (-[NavigationActionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
4141         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.html: Added.
4142
4143 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
4144
4145         Should template RefCounter instead of RefCounter::Token
4146         https://bugs.webkit.org/show_bug.cgi?id=154691
4147
4148         Reviewed by Anders Carlsson.
4149
4150         Mechanical update per RefCounter interface change.
4151
4152         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
4153         (TestWebKitAPI::TEST):
4154
4155 2016-02-25  Skachkov Aleksandr  <gskachkov@gmail.com>
4156
4157         Unreviewed: Add Aleksandr Skachkov as a commiter
4158
4159         * Scripts/webkitpy/common/config/contributors.json:
4160
4161 2016-02-25  Sam Weinig  <sam@webkit.org>
4162
4163         HashMap::ensure() should return an AddResult like all the other add-like functions
4164         https://bugs.webkit.org/show_bug.cgi?id=154680
4165
4166         Reviewed by Anders Carlsson.
4167
4168         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4169         (TestWebKitAPI::TEST):
4170         Update tests to use/test the new AddResult result.
4171
4172 2016-02-25  Alexey Proskuryakov  <ap@apple.com>
4173
4174         Enable MallocScribble when detecting leaks
4175         https://bugs.webkit.org/show_bug.cgi?id=154679
4176
4177         Reviewed by Geoffrey Garen.
4178
4179         * Scripts/webkitpy/port/ios.py:
4180         (IOSSimulatorPort.setup_environ_for_server):
4181         * Scripts/webkitpy/port/mac.py:
4182         (MacPort.setup_environ_for_server):
4183         * Scripts/webkitpy/port/mac_unittest.py:
4184         (MacTest.test_setup_environ_for_server):
4185
4186 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
4187
4188         Unreviewed, fix iOS builds after r197114.
4189
4190         * WebKitTestRunner/TestController.cpp:
4191         (WTR::createCanonicalUUIDString):
4192         (WTR::TestController::saltForOrigin):
4193
4194 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
4195
4196         [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin
4197         https://bugs.webkit.org/show_bug.cgi?id=153163
4198         <rdar://problem/24334526>
4199
4200         Reviewed by Tim Horton.
4201
4202         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4203         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Take top level document origin.
4204         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4205
4206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4207         (WTR::TestRunner::setUserMediaPermissionForOrigin): Ditto.
4208         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4209
4210         * WebKitTestRunner/TestController.cpp:
4211         (WTR::decidePolicyForUserMediaPermissionRequest): Pass through top level document origin.
4212         (WTR::checkUserMediaPermissionForOrigin): Ditto.
4213         (WTR::TestController::resetStateToConsistentValues): m_userMediaOriginPermissions -> m_cahcedUserMediaPermissions.
4214         (WTR::originUserVisibleName): Return a String.
4215         (WTR::userMediaOriginHash): Create a hash of the origin plus top level document origin.
4216         (WTR::TestController::saltForOrigin): Return salt for an origin.
4217         (WTR::TestController::setUserMediaPermissionForOrigin): Return permission for an origin.
4218         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
4219         (WTR::TestController::handleUserMediaPermissionRequest):
4220         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
4221         (WTR::OriginSettings::OriginSettings): New, class to cache settings for an origin.
4222         (WTR::OriginSettings::persistentPermission): Persistent permissions for origin.
4223         (WTR::OriginSettings::setPersistentPermission): Set permissions for origin.
4224         (WTR::OriginSettings::persistentSalt): Return the persistent salt for the origin, if any.
4225         (WTR::OriginSettings::setPersistentSalt): Set the persistent salt for the origin
4226         (WTR::OriginSettings::ephemeralSalts): Return hashmap used to store per-frame salts.
4227         * WebKitTestRunner/TestController.h:
4228
4229         * WebKitTestRunner/TestInvocation.cpp:
4230         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4231
4232 2016-02-24  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
4233
4234         [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
4235         https://bugs.webkit.org/show_bug.cgi?id=151688
4236
4237         Reviewed by Dean Jackson.
4238
4239         Enables the WEB_ANIMATIONS compiler switch by default.
4240
4241         * Scripts/webkitperl/FeatureList.pm:
4242
4243 2016-02-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4244
4245         W3C importer should generate all web-platform-tests submodules descriptions
4246         https://bugs.webkit.org/show_bug.cgi?id=154587
4247
4248         Reviewed by Darin Adler.
4249
4250         Updated submodules description format (removing submodule name as it is the last string of the path really).
4251         Added git subroutines.
4252
4253         * Scripts/webkitpy/common/checkout/scm/git.py:
4254         (Git.origin_url):
4255         (Git):
4256         (Git.init_submodules):
4257         (Git.submodules_status):
4258         (Git.deinit_submodules):
4259         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4260         (WebPlatformTestServer._install_modules): Updated to submodule name removal.
4261         * Scripts/webkitpy/w3c/test_downloader.py:
4262         (TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
4263         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4264         (TestImporterTest.test_submodules_generation): Reactivated partially this test.
4265
4266 2016-02-23  Dan Bernstein  <mitz@apple.com>
4267
4268         [Xcode] Linker errors display mangled names, but no longer should
4269         https://bugs.webkit.org/show_bug.cgi?id=154632
4270
4271         Reviewed by Sam Weinig.
4272
4273         * ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
4274         * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto.
4275         * LayoutTestRelay/Configurations/Base.xcconfig: Ditto.
4276         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
4277         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
4278         * WebEditingTester/Configurations/Base.xcconfig: Ditto.
4279         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
4280
4281 2016-02-23  Anders Carlsson  <andersca@apple.com>
4282
4283         WKWebView should implement NSCoding
4284         https://bugs.webkit.org/show_bug.cgi?id=137160
4285
4286         Reviewed by Dan Bernstein.
4287
4288         Add tests.
4289
4290         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
4291         (TEST):
4292
4293 2016-02-23  Anders Carlsson  <andersca@apple.com>
4294
4295         WKProcessPool should conform to NSCoding
4296         https://bugs.webkit.org/show_bug.cgi?id=154608
4297
4298         Reviewed by Sam Weinig.
4299
4300         Add tests.
4301
4302         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
4303         (TEST):
4304
4305 2016-02-23  Anders Carlsson  <andersca@apple.com>
4306
4307         WKWebsiteDataStore should conform to NSCoding
4308         https://bugs.webkit.org/show_bug.cgi?id=154605
4309
4310         Reviewed by Dan Bernstein.
4311
4312         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
4313         (TEST):
4314
4315 2016-02-23  Anders Carlsson  <andersca@apple.com>
4316
4317         WKWebViewConfiguration should conform to NSCoding
4318         https://bugs.webkit.org/show_bug.cgi?id=154602
4319
4320         Reviewed by Beth Dakin.
4321
4322         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
4323         (TEST):
4324
4325 2016-02-23  Anders Carlsson  <andersca@apple.com>
4326
4327         WKPreferences should conform to NSCoding
4328         https://bugs.webkit.org/show_bug.cgi?id=154597
4329
4330         Reviewed by Sam Weinig.
4331
4332         Test encoding and decoding WKPreferences.
4333
4334         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
4335         (encodeAndDecode):
4336         (TEST):
4337
4338 2016-02-23  Anders Carlsson  <andersca@apple.com>
4339
4340         Fix build.
4341
4342         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
4343         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]):
4344
4345 2016-02-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4346
4347         [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.
4348         https://bugs.webkit.org/show_bug.cgi?id=153993
4349
4350         Reviewed by Carlos Garcia Campos.
4351
4352         * MiniBrowser/gtk/main.c:
4353         (createBrowserWindow): Support --geometry argument for MiniBrowser.
4354         We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized.