Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-15  Youenn Fablet  <youenn@apple.com>
2
3         Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
4         https://bugs.webkit.org/show_bug.cgi?id=197463
5         <rdar://problem/47403621>
6
7         Reviewed by Alex Christensen.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
10         (-[QuotaDelegate init]):
11         (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
12         (-[QuotaDelegate quotaDelegateCalled]):
13         (-[QuotaDelegate grantQuota]):
14         (-[StorageSchemes webView:startURLSchemeTask:]):
15         (-[StorageSchemes webView:stopURLSchemeTask:]):
16         (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
17         (doTest):
18
19 2019-05-15  Youenn Fablet  <youenn@apple.com>
20
21         Constant crashes under WebPage::isThrottleable() after r245299
22         https://bugs.webkit.org/show_bug.cgi?id=197902
23         <rdar://problem/50793796>
24
25         Reviewed by Alex Christensen.
26
27         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
28
29 2019-05-15  Philippe Normand  <pnormand@igalia.com>
30
31         [GTK][jhbuild] misc cleanups and bumps
32         https://bugs.webkit.org/show_bug.cgi?id=197913
33
34         Reviewed by Xabier Rodriguez-Calvar.
35
36         * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
37         * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
38
39 2019-05-15  Chris Dumez  <cdumez@apple.com>
40
41         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
42         https://bugs.webkit.org/show_bug.cgi?id=195102
43         <rdar://problem/48456786>
44
45         Reviewed by Alex Christensen.
46
47         Try to wait longer for the number of processes to reach the expected number
48         and before failing.
49
50         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
51
52 2019-05-15  Alex Christensen  <achristensen@webkit.org>
53
54         Allow NSFileCoordinator to be called from WebContent process
55         https://bugs.webkit.org/show_bug.cgi?id=197895
56         <rdar://problem/50107679>
57
58         Reviewed by Brent Fulgham.
59
60         Add a unit test that verifies calling the block succeeds.
61
62         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
63         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
64
65 2019-05-14  Andy Estes  <aestes@apple.com>
66
67         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
68         https://bugs.webkit.org/show_bug.cgi?id=197751
69         <rdar://problem/50631563>
70
71         Reviewed by Alex Christensen.
72
73         Added new API tests.
74
75         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
76         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
77         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
78         (TestWebKitAPI::TEST):
79         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
80         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
81
82 2019-05-14  Youenn Fablet  <youenn@apple.com>
83
84         A service worker process should app nap when all its clients app nap
85         https://bugs.webkit.org/show_bug.cgi?id=185626
86         <rdar://problem/46785908>
87
88         Reviewed by Alex Christensen.
89
90         Allow to enable app nap through test header.
91
92         * WebKitTestRunner/TestController.cpp:
93         (WTR::TestController::resetPreferencesToConsistentValues):
94         (WTR::updateTestOptionsFromTestHeader):
95         * WebKitTestRunner/TestOptions.h:
96         (WTR::TestOptions::hasSameInitializationOptions const):
97
98 2019-05-14  Commit Queue  <commit-queue@webkit.org>
99
100         Unreviewed, rolling out r245281.
101         https://bugs.webkit.org/show_bug.cgi?id=197887
102
103         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
104         (Requested by aakashjain on #webkit).
105
106         Reverted changeset:
107
108         "Add a unit test for client certificate authentication"
109         https://bugs.webkit.org/show_bug.cgi?id=197800
110         https://trac.webkit.org/changeset/245281
111
112 2019-05-14  Youenn Fablet  <youenn@apple.com>
113
114         Add support for webkit-test-runner options to WPT importer
115         https://bugs.webkit.org/show_bug.cgi?id=197826
116
117         Reviewed by Alex Christensen.
118
119         In case of overwriting an existing test, check if the existing test
120         contains a <!-- webkit-test-runner --> comment and insert it back if
121         needed in the new test.
122
123         For exporter, forbid creating a WPT PR if there are changes containing
124         the webkit-test-runner string.
125
126         * Scripts/webkitpy/w3c/test_converter.py:
127         (convert_for_webkit):
128         (_W3CTestConverter.__init__):
129         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
130         (_W3CTestConverter.handle_starttag):
131         (_W3CTestConverter.handle_comment):
132         (_W3CTestConverter.handle_decl):
133         (_W3CTestConverter.handle_pi):
134         * Scripts/webkitpy/w3c/test_exporter.py:
135         (WebPlatformTestExporter.write_git_patch_file):
136         (WebPlatformTestExporter.make_pull_request):
137         * Scripts/webkitpy/w3c/test_importer.py:
138         (TestImporter.webkit_test_runner_options):
139         (TestImporter):
140         (TestImporter.add_webkit_test_runner_options_to_content):
141         (TestImporter.copy_html_file):
142         (TestImporter.write_html_template):
143         (TestImporter.write_html_files_for_templated_js_tests):
144         (TestImporter.import_tests):
145         * Scripts/webkitpy/w3c/test_importer_unittest.py:
146         (test_manual_slow_test):
147         (test_webkit_test_runner_options):
148
149 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
150
151         [ews-app] Status bubble should turn orange when any build step fails
152         https://bugs.webkit.org/show_bug.cgi?id=197812
153
154         Reviewed by Jonathan Bedard.
155
156         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
157         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
158         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
159
160 2019-05-14  Alex Christensen  <achristensen@webkit.org>
161
162         Add a unit test for client certificate authentication
163         https://bugs.webkit.org/show_bug.cgi?id=197800
164
165         Reviewed by Youenn Fablet.
166
167         Make better abstractions for reading and writing from/to TCPServer.
168         Add a unit test that causes a client certificate authentication challenge to happen.
169
170         * TestWebKitAPI/TCPServer.cpp:
171         (TestWebKitAPI::TCPServer::TCPServer):
172         (TestWebKitAPI::TCPServer::read):
173         (TestWebKitAPI::TCPServer::write):
174         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
175         (TestWebKitAPI::TCPServer::respondWithOK):
176         * TestWebKitAPI/TCPServer.h:
177         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
178         (credentialWithIdentity):
179         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
180         (TEST):
181         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
182         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
183         (-[ClientCertificateDelegate challengeCount]):
184         (TestWebKitAPI::TEST):
185         (respondWithChallengeThenOK): Deleted.
186         (credentialWithIdentityAndKeychainPath): Deleted.
187         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
188         (TEST):
189         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
190         (TestWebKitAPI::TEST):
191         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
192         (TEST):
193         (readRequest): Deleted.
194         (writeResponse): Deleted.
195         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
196         (TestWebKitAPI::TEST):
197         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
198
199 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
200
201         [CG] Adding support for HEIF-sequence ('public.heics') images
202         https://bugs.webkit.org/show_bug.cgi?id=197384
203
204         Reviewed by Simon Fraser.
205
206         * DumpRenderTree/TestOptions.cpp:
207         (TestOptions::TestOptions):
208         * DumpRenderTree/TestOptions.h:
209         * DumpRenderTree/mac/DumpRenderTree.mm:
210         (resetWebViewToConsistentStateBeforeTesting):
211         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
212         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
213         the test.
214
215         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
216         (WTR::InjectedBundle::stringForKey):
217         (WTR::InjectedBundle::beginTesting):
218         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
219         * WebKitTestRunner/TestController.cpp:
220         (WTR::TestController::resetStateToConsistentValues):
221         (WTR::updateTestOptionsFromTestHeader):
222         * WebKitTestRunner/TestInvocation.cpp:
223         (WTR::TestInvocation::createTestSettingsDictionary):
224         * WebKitTestRunner/TestOptions.h:
225         (WTR::TestOptions::hasSameInitializationOptions const):
226         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
227         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
228         the test.
229
230 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
231
232         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
233         https://bugs.webkit.org/show_bug.cgi?id=197730
234
235         Reviewed by Filip Pizlo.
236
237         * TestWebKitAPI/CMakeLists.txt:
238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
239         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
240         (TestWebKitAPI::TEST):
241         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
242         (TestWebKitAPI::TEST):
243
244 2019-05-10  Chris Dumez  <cdumez@apple.com>
245
246         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
247
248         It became flaky after r245198.
249
250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
251
252 2019-05-10  Youenn Fablet  <youenn@apple.com>
253
254         A service worker instance should be terminated when its SWServer is destroyed
255         https://bugs.webkit.org/show_bug.cgi?id=197801
256         <rdar://problem/50587270>
257
258         Reviewed by Chris Dumez.
259
260         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
261
262 2019-05-10  Chris Dumez  <cdumez@apple.com>
263
264         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
265         https://bugs.webkit.org/show_bug.cgi?id=197750
266
267         Reviewed by Geoffrey Garen.
268
269         Add API test coverage.
270
271         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
272         (TEST):
273
274 2019-05-10  Keith Miller  <keith_miller@apple.com>
275
276         Remove legacy test262 import script
277         https://bugs.webkit.org/show_bug.cgi?id=197788
278
279         Reviewed by Yusuke Suzuki.
280
281         import-test262-tests doesn't work anymore. We should be using test262-import instead.
282
283         * Scripts/import-test262-tests: Removed.
284
285 2019-05-10  Charlie Turner  <cturner@igalia.com>
286
287         [WPE] Forward libepoxy cflags
288         https://bugs.webkit.org/show_bug.cgi?id=197784
289
290         Reviewed by Žan Doberšek.
291
292         Patch by Zan Dobersek.
293
294         * wpe/backends/CMakeLists.txt: This is required to keep
295         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
296         up trying to include X11 headers even when they're not present in the
297         environment.
298
299 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
300
301         Fix a bunch of compiler warnings
302         https://bugs.webkit.org/show_bug.cgi?id=197785
303
304         Reviewed by Don Olmstead.
305
306         Add preprocessor guards to avoid -Wunused-function warnings.
307
308         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
309         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
310         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
311
312 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
313
314         [WPE][GTK] Add webkit_frame_get_id() API
315         https://bugs.webkit.org/show_bug.cgi?id=197270
316
317         Reviewed by Carlos Garcia Campos.
318
319         This was hard, but I added a test to verify that two different WebKitFrames of the same
320         WebKitWebPage return two different frame IDs.
321
322         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
323         (WebKitFrameTest::willSubmitFormCallback):
324         (WebKitFrameTest::testSubframe):
325         (registerTests):
326         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
327         (testWebKitFrameSubframe):
328         (beforeAll):
329         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
330         (willSubmitFormCallback):
331         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
332         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
333
334 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
335
336         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
337         https://bugs.webkit.org/show_bug.cgi?id=197271
338
339         Reviewed by Youenn Fablet.
340
341         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
342         (formControlsAssociatedForFrameCallback):
343         (pageCreatedCallback):
344         (formControlsAssociatedCallback): Deleted.
345
346 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
347
348         [Flatpak] Use the safe PyYAML loader if available
349         https://bugs.webkit.org/show_bug.cgi?id=197771
350
351         Reviewed by Philippe Normand.
352
353         * flatpak/flatpakutils.py:
354         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
355         still used as fallback when the former is not provided by the module.
356
357 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
358
359         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
360         https://bugs.webkit.org/show_bug.cgi?id=197734
361
362         Reviewed by Don Olmstead.
363
364         * Scripts/webkitpy/port/win.py:
365         (WinCairoPort._search_paths): Add 'wk2' and
366         additional_platform_directory to paths as well as other ports do.
367
368 2019-05-09  Daniel Bates  <dabates@apple.com>
369
370         [iOS] Numpad comma key has incorrect keyIdentifier property
371         https://bugs.webkit.org/show_bug.cgi?id=197753
372         <rdar://problem/50636274>
373
374         Reviewed by Brent Fulgham.
375
376         Recognize "numpadComma" and return the appropriate HID usage code.
377
378         * WebKitTestRunner/ios/HIDEventGenerator.mm:
379         (hidUsageCodeForCharacter):
380
381 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
382
383         Refine AudioSession route sharing policy
384         https://bugs.webkit.org/show_bug.cgi?id=197742
385         <rdar://problem/50590818>
386
387         Reviewed by Darin Adler.
388
389         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
390         (TestWebKitAPI::TEST):
391
392 2019-05-09  Alex Christensen  <achristensen@webkit.org>
393
394         Remove unnecessary test SPI after r244883
395         https://bugs.webkit.org/show_bug.cgi?id=197575
396
397         Reviewed by Tim Horton.
398
399         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
400         (TEST):
401         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
402         (TestWebKitAPI::TEST):
403
404 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
405
406         [ews-app] Add migrations file to repository
407         https://bugs.webkit.org/show_bug.cgi?id=197729
408
409         Reviewed by Jonathan Bedard.
410
411         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
412
413 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
414
415         [ews-build] Fix formatting issues and typos
416         https://bugs.webkit.org/show_bug.cgi?id=197737
417
418         Reviewed by Jonathan Bedard.
419
420         * BuildSlaveSupport/ews-build/steps.py:
421         (CompileWebKit.evaluateCommand): Removed extra empty line.
422         * BuildSlaveSupport/ews-build/steps_unittest.py:
423         (TestRunWebKitPerlTests): Fixed typo.
424         * BuildSlaveSupport/ews-app/ews/models/step.py:
425         (Step.save_step): Changed log level to info so that it is logged in production.
426
427 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
428
429         [ews-app] Production and Development env should configure DEBUG appropriately
430         https://bugs.webkit.org/show_bug.cgi?id=197700
431
432         Reviewed by Jonathan Bedard.
433
434         * BuildSlaveSupport/ews-app/ews-app/settings.py:
435
436 2019-05-09  Xan López  <xan@igalia.com>
437
438         [CMake] Detect SSE2 at compile time
439         https://bugs.webkit.org/show_bug.cgi?id=196488
440
441         Reviewed by Carlos Garcia Campos.
442
443         * Scripts/webkitdirs.pm:
444         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
445         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
446
447 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
448
449         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
450         https://bugs.webkit.org/show_bug.cgi?id=197697
451
452         Reviewed by Žan Doberšek.
453
454         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
455         * wpe/jhbuild.modules: Ditto.
456
457 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
458
459         Update ANGLE
460         https://bugs.webkit.org/show_bug.cgi?id=197676
461
462         Reviewed by Alex Christensen.
463
464         * TestWebKitAPI/PlatformWin.cmake:
465         Remove unnecessary library linkage.
466
467 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
468
469         [Win] build-webkit should be ready for Visual Studio 2019
470         https://bugs.webkit.org/show_bug.cgi?id=196622
471
472         Reviewed by Ross Kirsling.
473
474         1. Accommodated to the new msbuild.exe location of VS 2019.
475         2. Removed the hard coded "Visual Studio 15" generator.
476
477         build-webkit is going to choose a Visual Studio generator version
478         matching with the latest installed VS. If you invoke vcvars.bat
479         before build-webkit, it chooses the corresponding Visual Studio
480         generator version by cheking 'VisualStudioVersion' env var which
481         is set by vcvars.bat.
482
483         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
484         (msBuildPath): When looking for MSBuild, look in
485         "MSBuild\Current\bin" (the new expected location) and fallback
486         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
487         first location.
488         (msBuildInstallDir): Renamed to msBuildPath.
489         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
490         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
491
492 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
493
494         [PlayStation] Update port options
495         https://bugs.webkit.org/show_bug.cgi?id=197723
496
497         Reviewed by Ross Kirsling.
498
499         ICU headers were missing from TestWTF.
500
501         * TestWebKitAPI/PlatformPlayStation.cmake:
502
503 2019-05-08  Alex Christensen  <achristensen@webkit.org>
504
505         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
506         https://bugs.webkit.org/show_bug.cgi?id=197712
507         <rdar://problem/50429770>
508
509         Reviewed by Tim Horton.
510
511         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
512         (TestWebKitAPI::TEST):
513
514 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
515
516         Change my status to be a WebKit reviewer.
517
518         * Scripts/webkitpy/common/config/contributors.json:
519
520 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
521
522         Unreviewed, rolling out r244952.
523
524         Caused inspector to appear blank.
525
526         Reverted changeset:
527
528         "Web Inspector: Provide UIString descriptions to improve
529         localizations"
530         https://bugs.webkit.org/show_bug.cgi?id=195132
531         https://trac.webkit.org/changeset/244952
532
533 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
534
535         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
536         https://bugs.webkit.org/show_bug.cgi?id=197685
537
538         Reviewed by Alex Christensen.
539
540         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
541         completion. See LayoutTests/ChangeLog for more details.
542
543         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
544         (WTR::UIScriptController::platformClearAllCallbacks):
545
546 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
547
548         Unreviewed. Add myself as a committer.
549
550         * Scripts/webkitpy/common/config/contributors.json:
551
552 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
553
554         Unreviewed, rolling out r245038.
555
556         Breaks internal builds.
557
558         Reverted changeset:
559
560         "Add SPI to set a list of hosts to which to send custom header
561         fields cross-origin"
562         https://bugs.webkit.org/show_bug.cgi?id=197397
563         https://trac.webkit.org/changeset/245038
564
565 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
566
567         Unreviewed. Add myself as a committer.
568
569         * Scripts/webkitpy/common/config/contributors.json:
570
571 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
572
573         Define media buffering policy
574         https://bugs.webkit.org/show_bug.cgi?id=196979
575         <rdar://problem/28383861>
576
577         Reviewed by Jer Noble.
578
579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
580         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
581         (waitUntilBufferingPolicyIsEqualTo):
582         (TEST):
583
584 2019-05-07  Alex Christensen  <achristensen@webkit.org>
585
586         Add SPI to set a list of hosts to which to send custom header fields cross-origin
587         https://bugs.webkit.org/show_bug.cgi?id=197397
588
589         Reviewed by Geoff Garen.
590
591         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
592         (TEST):
593         (expectLegacyHeaders):
594         (expectHeaders):
595         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
596         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
597         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
598
599 2019-05-07  Keith Rollin  <krollin@apple.com>
600
601         Add option to build-webkit to control whether or not XCBuild is used
602         https://bugs.webkit.org/show_bug.cgi?id=197668
603         <rdar://problem/50549728>
604
605         Reviewed by Tim Horton.
606
607         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
608         Also update build-webkit and the makefiles with the foundation for
609         automatically using XCBuild when the conditions allow it. This latter
610         facility is currently turned off until Xcode fully supports building
611         WebKit with XCBuild.
612
613         * Scripts/build-webkit:
614         * Scripts/webkitdirs.pm:
615         (XcodeOptions):
616         (canUseXCBuild):
617
618 2019-05-07  Andy Estes  <aestes@apple.com>
619
620         run-bindings-tests should test global scope constructor generation
621         https://bugs.webkit.org/show_bug.cgi?id=197669
622
623         Reviewed by Alex Christensen.
624
625         * Scripts/webkitpy/bindings/main.py:
626         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
627         invoking preprocess-idls.pl.
628
629 2019-05-07  Youenn Fablet  <youenn@apple.com>
630
631         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
632         https://bugs.webkit.org/show_bug.cgi?id=195997
633         <rdar://problem/50509884>
634
635         Reviewed by Chris Dumez.
636
637         Spin test until successful.
638
639         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
640
641 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
642
643         [Flatpak] webkit-build fails due to missing GTK2 in build environment
644         https://bugs.webkit.org/show_bug.cgi?id=197352
645
646         Reviewed by Philippe Normand.
647
648         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
649         to build it ourselves on top in order to be able to build the GTK 2.x plugin
650         process.
651
652         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
653
654 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
655
656         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
657         https://bugs.webkit.org/show_bug.cgi?id=197644
658         <rdar://problem/50526364>
659
660         Reviewed by Tim Horton.
661
662         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
663
664         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
665         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
666         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
667         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
668
669 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
670
671         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
672         https://bugs.webkit.org/show_bug.cgi?id=197651
673
674         Reviewed by Žan Doberšek.
675
676         This is required since the process creation was delayed until something is loaded in the view.
677
678         * MiniBrowser/gtk/BrowserWindow.c:
679         (browser_window_get_or_create_web_view_for_automation):
680         * MiniBrowser/wpe/main.cpp:
681         (main):
682
683 2019-05-06  Tim Horton  <timothy_horton@apple.com>
684
685         _overrideViewportWithArguments does not work when called before loading
686         https://bugs.webkit.org/show_bug.cgi?id=197638
687         <rdar://problem/50505111>
688
689         Reviewed by Wenson Hsieh.
690
691         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
692         (TEST):
693
694 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
695
696         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
697         https://bugs.webkit.org/show_bug.cgi?id=197510
698
699         Reviewed by Alex Christensen.
700
701         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
702         (TestWebKitAPI::TEST):
703
704 2019-05-06  Keith Rollin  <krollin@apple.com>
705
706         Temporarily disable generate-xcfilelists
707         https://bugs.webkit.org/show_bug.cgi?id=197619
708         <rdar://problem/50507392>
709
710         Reviewed by Alex Christensen.
711
712         We need to perform a significant update to the generate-xcfilelist
713         scripts. This work involves coordinated work with another facility. If
714         the work does not occur in tandem, the build will be broken. To avoid
715         this, disable the invoking of the scripts during the transition. The
716         checking will be restored once the new scripts are in place.
717
718         * DumpRenderTree/Scripts/check-xcfilelists.sh:
719         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
720
721 2019-05-04  Alex Christensen  <achristensen@webkit.org>
722
723         Revert r244953 and r244954 because they broke internal builds.
724         https://bugs.webkit.org/show_bug.cgi?id=197534
725
726         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
727         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
728         * DumpRenderTree/mac/DumpRenderTree.mm:
729         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
730         * DumpRenderTree/mac/TestRunnerMac.mm:
731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
732         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
733         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
734         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
735         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
736         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
737         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
738         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
739         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
740         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
741         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
742         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
743         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
744         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
745         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
746         * TestWebKitAPI/cocoa/TestWKWebView.mm:
747         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
748         * TestWebKitAPI/ios/UIKitSPI.h: Added.
749         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
750         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
751         * WebKitTestRunner/ios/HIDEventGenerator.h:
752         * WebKitTestRunner/ios/HIDEventGenerator.mm:
753         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
754         * WebKitTestRunner/ios/TestControllerIOS.mm:
755         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
756         * WebKitTestRunner/ios/mainIOS.mm:
757
758 2019-05-04  Alex Christensen  <achristensen@webkit.org>
759
760         Merge the three UIKitSPI.h files into a single one in PAL
761         https://bugs.webkit.org/show_bug.cgi?id=197534
762
763         Reviewed by Darin Adler.
764
765         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
766         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
767         * DumpRenderTree/mac/DumpRenderTree.mm:
768         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
769         * DumpRenderTree/mac/TestRunnerMac.mm:
770         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
771         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
772         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
773         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
774         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
775         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
776         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
777         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
778         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
779         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
780         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
781         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
782         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
783         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
784         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
785         * TestWebKitAPI/cocoa/TestWKWebView.mm:
786         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
787         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
788         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
789         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
790         * WebKitTestRunner/ios/HIDEventGenerator.h:
791         * WebKitTestRunner/ios/HIDEventGenerator.mm:
792         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
793         * WebKitTestRunner/ios/TestControllerIOS.mm:
794         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
795         * WebKitTestRunner/ios/mainIOS.mm:
796
797 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
798
799         Web Inspector: Provide UIString descriptions to improve localizations
800         https://bugs.webkit.org/show_bug.cgi?id=195132
801         <rdar://problem/48457817>
802
803         Reviewed by Devin Rousso.
804
805         Allow WI.UIString to take:
806         - WI.UIString(string, key, comment)
807         - WI.UIString(string, comment)
808         - WI.UIString(string)
809
810         * Scripts/extract-localizable-js-strings:
811
812 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
813
814         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
815         https://bugs.webkit.org/show_bug.cgi?id=197579
816
817         Reviewed by Tim Horton.
818
819         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
820         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
821         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
822         ensure that the the focused element has been blurred.
823
824         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
825
826 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
827
828         Add a tool to block spammer accounts
829         https://bugs.webkit.org/show_bug.cgi?id=197537
830
831         Reviewed by Darin Adler.
832
833         Usage: block-spammers email1 email2 ...
834
835         The tool finds and hides all bugs and comments from this account. Before any work
836         is done, these bugs and comments are displayed for confirmation.
837
838         * Scripts/block-spammers: Added.
839         (get_bugzilla_token):
840         (invalidate_bugzilla_token):
841         (get_user_info):
842         (get_user_info_self):
843         (can_use_this_tool):
844         (disable_user):
845         (get_bugs_created_by_user):
846         (get_bugs_commented_on_by_user):
847         (get_comments):
848         (hide_bug):
849         (hide_comments):
850         (ask_yes_no):
851         (sanitized_string):
852         (main):
853
854 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
855
856         run-apit-tests: Add --iterations and --repeat-each
857         https://bugs.webkit.org/show_bug.cgi?id=197563
858
859         Reviewed by Aakash Jain.
860
861         * Scripts/webkitpy/api_tests/manager.py:
862         (Manager.run): Add --iterations and --repeat-each/
863         * Scripts/webkitpy/api_tests/run_api_tests.py:
864         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
865
866 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
867
868         New EWS: Clicking on white bubble navigates to page with only bubbles
869         https://bugs.webkit.org/show_bug.cgi?id=197520
870
871         Reviewed by Lucas Forschler.
872
873         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
874
875 2019-05-03  Daniel Bates  <dabates@apple.com>
876
877         [lldb-webkit] Support adding pretty-printing for qualified types
878         https://bugs.webkit.org/show_bug.cgi?id=197518
879
880         Reviewed by Darin Adler.
881
882         Remove all "::"s from the name of the specified type when computing the name for the Python classes
883         that will provide summary and synthetic details as LLDB is not happy about registering such classes
884         when they contain :: in their name.
885
886         * lldb/lldb_webkit.py:
887         (addSummaryAndSyntheticFormattersForRawBitmaskType):
888
889 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
890
891         New EWS: patches on recently added queues listed as #1 for older bugs
892         https://bugs.webkit.org/show_bug.cgi?id=197496
893
894         Reviewed by Lucas Forschler.
895
896         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
897         (StatusBubble._build_bubble):
898         (StatusBubble._queue_position):
899
900 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
901
902         webkit-patch --no-review upload does not submit patch to New EWS
903         https://bugs.webkit.org/show_bug.cgi?id=197519
904         <rdar://problem/50424887>
905
906         Reviewed by Lucas Forschler.
907
908         * Scripts/webkitpy/tool/steps/submittoews.py:
909         (SubmitToEWS.run): Submit to both old and new EWS.
910         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
911         * Scripts/webkitpy/common/net/ewsserver.py: Added.
912         (EWSServer._server_url): Method to return server url.
913         (EWSServer._post_patch_to_ews): Method to post patch to ews.
914         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
915         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
916         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
917         * Scripts/webkitpy/common/net/statusserver_mock.py:
918         (MockStatusServer.submit_to_ews): Updated the log text.
919         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
920         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
921         * Scripts/webkitpy/tool/main.py:
922         (WebKitPatch.__init__): Initialize ews_server. 
923         * Scripts/webkitpy/tool/mocktool.py:
924         (MockTool.__init__): Ditto.
925
926 2019-05-03  Chris Dumez  <cdumez@apple.com>
927
928         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
929         https://bugs.webkit.org/show_bug.cgi?id=197574
930         <rdar://problem/50453181>
931
932         Reviewed by Tim Horton.
933
934         Add API test coverage.
935
936         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
937         (TEST):
938
939 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
940
941         [JSC] Generator CodeBlock generation should be idempotent
942         https://bugs.webkit.org/show_bug.cgi?id=197552
943
944         Reviewed by Keith Miller.
945
946         * Scripts/run-javascriptcore-tests:
947         (runJSCStressTests):
948         * Scripts/run-jsc-stress-tests:
949
950 2019-05-03  Commit Queue  <commit-queue@webkit.org>
951
952         Unreviewed, rolling out r244881.
953         https://bugs.webkit.org/show_bug.cgi?id=197559
954
955         Breaks compilation of jsconly on linux, breaking compilation
956         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
957         guijemont on #webkit).
958
959         Reverted changeset:
960
961         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
962         WEBKIT_COPY_FILES"
963         https://bugs.webkit.org/show_bug.cgi?id=197174
964         https://trac.webkit.org/changeset/244881
965
966 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
967
968         Unreviewed WPE build fix after r244898.
969
970         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
971         (WTR::TestController::abortModal): Add the missing (no-op) definition.
972
973 2019-05-02  Alex Christensen  <achristensen@webkit.org>
974
975         Mark U+01C0 as a homograph of U+006C
976         https://bugs.webkit.org/show_bug.cgi?id=197526
977         <rdar://problem/50301904>
978
979         Reviewed by Tim Horton.
980
981         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
982         (TestWebKitAPI::TEST):
983
984 2019-05-02  Chris Dumez  <cdumez@apple.com>
985
986         Add test coverage for <rdar://problem/49731231>
987         https://bugs.webkit.org/show_bug.cgi?id=196730
988         <rdar://problem/49731231>
989
990         Reviewed by Ryosuke Niwa.
991
992         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
993         to match DumpRenderTree.
994
995         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
996         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
997         (WTR::TestRunner::abortModal):
998         * WebKitTestRunner/InjectedBundle/TestRunner.h:
999         * WebKitTestRunner/TestController.cpp:
1000         (WTR::TestController::runModal):
1001         * WebKitTestRunner/TestController.h:
1002         * WebKitTestRunner/TestInvocation.cpp:
1003         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1004         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1005         (WTR::TestController::abortModal):
1006         * WebKitTestRunner/ios/TestControllerIOS.mm:
1007         (WTR::TestController::abortModal):
1008         * WebKitTestRunner/mac/TestControllerMac.mm:
1009         (WTR::TestController::abortModal):
1010         * WebKitTestRunner/win/TestControllerWin.cpp:
1011         (WTR::TestController::abortModal):
1012
1013 2019-05-02  Christopher Reid  <chris.reid@sony.com>
1014
1015         [CMake] Add support for LTO builds
1016         https://bugs.webkit.org/show_bug.cgi?id=188986
1017
1018         Reviewed by Don Olmstead.
1019
1020         Add support to configure --lto-mode with cmake builds.
1021
1022         * Scripts/build-webkit:
1023         * Scripts/webkitdirs.pm:
1024         (generateBuildSystemFromCMakeProject):
1025
1026 2019-05-02  John Wilander  <wilander@apple.com>
1027
1028         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
1029         https://bugs.webkit.org/show_bug.cgi?id=197521
1030         <rdar://problem/49651503>
1031
1032         Reviewed by Brent Fulgham.
1033
1034         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1035         (TestWebKitAPI::TEST):
1036            Added a test for host strings with leading dots since they are
1037            often used for the domain attribute in cookies.
1038
1039 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
1040
1041         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1042         https://bugs.webkit.org/show_bug.cgi?id=197510
1043
1044         Reviewed by Alex Christensen.
1045
1046         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1047         (TestWebKitAPI::TEST):
1048
1049 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
1050
1051         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
1052         https://bugs.webkit.org/show_bug.cgi?id=197174
1053
1054         Reviewed by Alex Christensen.
1055
1056         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
1057
1058         * TestWebKitAPI/PlatformGTK.cmake:
1059         * TestWebKitAPI/PlatformWPE.cmake:
1060
1061 2019-05-02  Alex Christensen  <achristensen@webkit.org>
1062
1063         Build fix for internal branch.
1064
1065         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1066         RetainPtr.h was not explicitly included.
1067
1068 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
1069
1070         webkitpy: Ignore errors when shutting down an already shutdown simulator
1071         <https://bugs.webkit.org/show_bug.cgi?id=197514>
1072         <rdar://problem/50390247>
1073
1074         Reviewed by Lucas Forschler.
1075
1076         * Scripts/webkitpy/xcode/simulated_device.py:
1077         (SimulatedDevice._shut_down):
1078
1079 2019-05-02  Frederic Wang  <fwang@igalia.com>
1080
1081         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
1082         https://bugs.webkit.org/show_bug.cgi?id=196142
1083
1084         This patch introduces some experimental runtime flag to let users
1085         disable MathML features that are removed from MathML Core [1]. For now,
1086         these features are only disabled on GTK and WPE ports.
1087
1088         [1] https://mathml-refresh.github.io/mathml-core/
1089
1090         Reviewed by Rob Buis.
1091
1092         * DumpRenderTree/TestOptions.cpp:
1093         (TestOptions::TestOptions):
1094         * DumpRenderTree/TestOptions.h:
1095         * DumpRenderTree/mac/DumpRenderTree.mm:
1096         (setWebPreferencesForTestOptions):
1097
1098 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
1099
1100         TestWebKitAPI config.h should be aware of what suite is being built
1101         https://bugs.webkit.org/show_bug.cgi?id=196583
1102
1103         Reviewed by Konstantin Tokarev.
1104
1105         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
1106         benefit the macro defines BUILDING_* for the executable which allows the includes
1107         of the config.h to be tailored to the test suite being built. Because of that the
1108         dependencies of the Test* executable are specific to the test suite which may
1109         speed up the build.
1110
1111         Some source files were including "PlatformUtilities.h" which includes WebKit headers
1112         when "Utilities.h" is what was needed.
1113
1114         * TestWebKitAPI/CMakeLists.txt:
1115         * TestWebKitAPI/PlatformGTK.cmake:
1116         * TestWebKitAPI/PlatformJSCOnly.cmake:
1117         * TestWebKitAPI/PlatformMac.cmake:
1118         * TestWebKitAPI/PlatformPlayStation.cmake:
1119         * TestWebKitAPI/PlatformUtilities.h:
1120         * TestWebKitAPI/PlatformWPE.cmake:
1121         * TestWebKitAPI/PlatformWin.cmake:
1122         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1123         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1124         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1125         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
1126         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
1127         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1128         * TestWebKitAPI/config.h:
1129
1130 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
1131
1132         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
1133         https://bugs.webkit.org/show_bug.cgi?id=181950
1134         <rdar://problem/43357371>
1135
1136         Reviewed by Brent Fulgham.
1137
1138         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1139         (TestWebKitAPI::TEST_F):
1140
1141 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1142
1143         Remove webkitpy and bindings EWS queues from dashboard
1144         https://bugs.webkit.org/show_bug.cgi?id=197475
1145
1146         Reviewed by Alexey Proskuryakov.
1147
1148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1149
1150 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
1151
1152         Remove webkitpy and bindings test queues from old EWS
1153         https://bugs.webkit.org/show_bug.cgi?id=197468
1154
1155         Reviewed by Alexey Proskuryakov.
1156
1157         * QueueStatusServer/config/queues.py:
1158
1159 2019-04-30  Tim Horton  <timothy_horton@apple.com>
1160
1161         Fix the WebKitTestRunner build
1162         https://bugs.webkit.org/show_bug.cgi?id=197449
1163         <rdar://problem/50334169>
1164
1165         Reviewed by Alexey Proskuryakov.
1166
1167         * WebKitTestRunner/mac/EventSenderProxy.mm:
1168         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1169         (WTR::EventSenderProxy::mouseForceChanged):
1170         Use some SPI instead of IPI.
1171
1172 2019-04-30  Chris Dumez  <cdumez@apple.com>
1173
1174         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1175         https://bugs.webkit.org/show_bug.cgi?id=197426
1176         <rdar://problem/50256169>
1177
1178         Reviewed by Brady Eidson.
1179
1180         Add API test coverage.
1181
1182         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1183         (-[PSONScheme setShouldRespondAsynchronously:]):
1184         (-[PSONScheme webView:startURLSchemeTask:]):
1185         (-[PSONScheme webView:stopURLSchemeTask:]):
1186
1187 2019-04-30  Chris Dumez  <cdumez@apple.com>
1188
1189         Unreviewed, rolling out r244802.
1190
1191         Caused an API test failure
1192
1193         Reverted changeset:
1194
1195         "Regression(PSON) URL scheme handlers can no longer respond
1196         asynchronously"
1197         https://bugs.webkit.org/show_bug.cgi?id=197426
1198         https://trac.webkit.org/changeset/244802
1199
1200 2019-04-30  Chris Dumez  <cdumez@apple.com>
1201
1202         Regression(PSON) URL scheme handlers can no longer respond asynchronously
1203         https://bugs.webkit.org/show_bug.cgi?id=197426
1204         <rdar://problem/50256169>
1205
1206         Reviewed by Brady Eidson.
1207
1208         Add API test coverage.
1209
1210         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1211         (-[PSONScheme setShouldRespondAsynchronously:]):
1212         (-[PSONScheme webView:startURLSchemeTask:]):
1213         (-[PSONScheme webView:stopURLSchemeTask:]):
1214
1215 2019-04-30  Chris Dumez  <cdumez@apple.com>
1216
1217         Only use a related page's process if that page has not been closed yet
1218         https://bugs.webkit.org/show_bug.cgi?id=197393
1219         <rdar://problem/50302423>
1220
1221         Reviewed by Tim Horton.
1222
1223         Add API test coverage.
1224
1225         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1226
1227 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1228
1229         [ews-build] Enable Bindings tests queue on new EWS
1230         https://bugs.webkit.org/show_bug.cgi?id=197424
1231
1232         Reviewed by Lucas Forschler.
1233
1234         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1235         (StatusBubble):
1236         * BuildSlaveSupport/ews-build/config.json:
1237
1238 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1239
1240         [ews-build] Configure ews151 for running various tests
1241         https://bugs.webkit.org/show_bug.cgi?id=197419
1242
1243         Reviewed by Lucas Forschler.
1244
1245         * BuildSlaveSupport/ews-build/config.json:
1246
1247 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1248
1249         [ews-build] Parse and display bindings test failures
1250         https://bugs.webkit.org/show_bug.cgi?id=197423
1251
1252         Reviewed by Lucas Forschler.
1253
1254         * BuildSlaveSupport/ews-build/steps.py:
1255         (RunBindingsTests.__init__): Set timeout of 5 minutes.
1256         (RunBindingsTests.start): Initialize log_observer for json output.
1257         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
1258         (RunBindingsTests._addToLog): Method to add message to log.
1259         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1260
1261 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
1262
1263         Unreviewed. Add myself as a committer.
1264
1265         * Scripts/webkitpy/common/config/contributors.json:
1266
1267 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1268
1269         [ews-build] Enable webkitpy queue on new EWS
1270         https://bugs.webkit.org/show_bug.cgi?id=197396
1271
1272         Reviewed by Lucas Forschler.
1273
1274         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1275         (StatusBubble):
1276         * BuildSlaveSupport/ews-build/config.json:
1277
1278 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
1279
1280         [ews-build] Parse and display webkitpy failures
1281         https://bugs.webkit.org/show_bug.cgi?id=197395
1282
1283         Reviewed by Lucas Forschler.
1284
1285         * BuildSlaveSupport/ews-build/steps.py:
1286         (RunWebKitPyTests.start): Initialize log_observer for json output.
1287         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
1288         (RunWebKitPyTests._addToLog): Method to add message to log.
1289         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
1290
1291 2019-04-29  Alex Christensen  <achristensen@webkit.org>
1292
1293         <rdar://problem/50299396> Fix internal High Sierra build
1294         https://bugs.webkit.org/show_bug.cgi?id=197388
1295
1296         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1297         * MiniBrowser/Configurations/Base.xcconfig:
1298         * MobileMiniBrowser/Configurations/Base.xcconfig:
1299         * TestWebKitAPI/Configurations/Base.xcconfig:
1300         * WebKitTestRunner/Configurations/Base.xcconfig:
1301
1302 2019-04-29  Youenn Fablet  <youenn@apple.com>
1303
1304         Remove spurious GVA printf logging
1305         https://bugs.webkit.org/show_bug.cgi?id=197368
1306         <rdar://problem/35975256>
1307
1308         Reviewed by Alexey Proskuryakov.
1309
1310         * Scripts/webkitpy/port/mac.py:
1311         (MacPort.logging_patterns_to_strip):
1312
1313 2019-04-29  Youenn Fablet  <youenn@apple.com>
1314
1315         getDisplayMedia should be called on user gesture
1316         https://bugs.webkit.org/show_bug.cgi?id=197356
1317         <rdar://problem/50296074>
1318
1319         Reviewed by Eric Carlson.
1320
1321         Update test configuration to inject internals
1322         so that we can use it to simulate a user click to call getDisplayMedia.
1323
1324         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1325         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1326         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
1327
1328 2019-04-26  Stephanie Lewis  <slewis@apple.com>
1329
1330         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
1331         https://bugs.webkit.org/show_bug.cgi?id=197339
1332
1333         Reviewed by Dewei Zhu.
1334
1335         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
1336         test run for setup steps that are too expensive to do every iteration.
1337
1338         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1339         (BenchmarkRunner._run_benchmark):
1340         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1341         (BrowserDriver):
1342         (BrowserDriver.prepare_initial_env):
1343         (BrowserDriver.restore_env_after_all_testing):
1344         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1345         (LinuxBrowserDriver.prepare_initial_env):
1346         (LinuxBrowserDriver.restore_env_after_all_testing):
1347         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1348         (OSXBrowserDriver.prepare_initial_env):
1349         (OSXBrowserDriver.restore_env_after_all_testing):
1350
1351 2019-04-28  Andy Estes  <aestes@apple.com>
1352
1353         Fix the watchOS engineering build.
1354
1355         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1356         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
1357
1358 2019-04-27  Chris Dumez  <cdumez@apple.com>
1359
1360         [WKTR] Move test timeout handling to the UIProcess
1361         https://bugs.webkit.org/show_bug.cgi?id=197333
1362
1363         Reviewed by Darin Adler.
1364
1365         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
1366         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
1367         every WebContent process in the case of swapping.
1368
1369         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
1370         would lead to crashes when firing the timer.
1371
1372         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1373         (WTR::InjectedBundle::didReceiveMessageToPage):
1374         (WTR::InjectedBundle::done):
1375         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1376         (WTR::InjectedBundle::shouldDumpPixels const):
1377         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1378         (WTR::TestRunner::TestRunner):
1379         (WTR::TestRunner::waitUntilDone):
1380         (WTR::TestRunner::setWaitUntilDone):
1381         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1382         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1383         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1384         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
1385         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
1386         * WebKitTestRunner/TestInvocation.cpp:
1387         (WTR::TestInvocation::TestInvocation):
1388         (WTR::TestInvocation::createTestSettingsDictionary):
1389         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1390         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1391         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
1392         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
1393         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
1394         (WTR::TestInvocation::setWaitUntilDone):
1395         (WTR::TestInvocation::done):
1396         * WebKitTestRunner/TestInvocation.h:
1397
1398 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
1399
1400         [JSC] linkPolymorphicCall now does GC
1401         https://bugs.webkit.org/show_bug.cgi?id=197306
1402
1403         Reviewed by Saam Barati.
1404
1405         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
1406         To add this test, we add `runWithoutBaseOption`.
1407
1408         * Scripts/run-jsc-stress-tests:
1409
1410 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1411
1412         Update inactive reviewers' status to 'contributor'.
1413
1414         Accidentally skipped one at first.
1415
1416         * Scripts/webkitpy/common/config/contributors.json:
1417
1418 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
1419
1420         Update inactive reviewers' status to 'contributor'.
1421
1422         * Scripts/webkitpy/common/config/contributors.json: The change.
1423
1424         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1425         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1426         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1427         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1428         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1429         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1430         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1431         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1432         Sadly, regression tests operate on a crazy mix of mock and live data for
1433         contributors.json. It would be a substantial project to mock all code paths,
1434         so changing the tests instead.
1435
1436 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
1437
1438         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1439         https://bugs.webkit.org/show_bug.cgi?id=197171
1440         <rdar://problem/47454979>
1441
1442         Reviewed by Youenn Fablet.
1443
1444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1445         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1446         (TestWebKitAPI::TEST):
1447
1448 2019-04-26  David Kilzer  <ddkilzer@apple.com>
1449
1450         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
1451         <https://webkit.org/b/197314>
1452         <rdar://problem/50245252>
1453
1454         Reviewed by Simon Fraser.
1455
1456         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1457         (WTR::UIScriptController::lastUndoLabel const):
1458         (WTR::UIScriptController::firstRedoLabel const):
1459         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1460
1461         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1462         (-[HIDEventGenerator sendEventStream:completionBlock:]):
1463         - Call -autorelease to fix leak of NSDictionary.
1464
1465         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1466         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
1467         (WTR::UIScriptController::selectFormPopoverTitle const):
1468         (WTR::UIScriptController::textContentType const):
1469         (WTR::UIScriptController::formInputLabel const):
1470         (WTR::UIScriptController::scrollingTreeAsText const):
1471         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
1472
1473 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
1474
1475         webkitpy: Running a single test will always use the default device
1476         https://bugs.webkit.org/show_bug.cgi?id=195472
1477         <rdar://problem/48724825>
1478
1479         Reviewed by Lucas Forschler.
1480
1481         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
1482         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
1483         requested will be run regardless of what shard they are in.
1484
1485         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1486         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
1487         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1488         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
1489         on the default device type.
1490         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1491         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
1492         (RunTest.test_run_part): Ditto.
1493
1494 2019-04-26  Alex Christensen  <achristensen@webkit.org>
1495
1496         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
1497         https://bugs.webkit.org/show_bug.cgi?id=197165
1498
1499         Reviewed by Youenn Fablet.
1500
1501         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1502
1503 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
1504
1505         Replace iOS build queue hardware
1506         https://bugs.webkit.org/show_bug.cgi?id=197312
1507
1508         Reviewed by Aakash Jain.
1509
1510         * BuildSlaveSupport/build.webkit.org-config/config.json:
1511         Use newer hardware that supports macOS Mojave.
1512
1513 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
1514
1515         check-webkit-style complains the first block in while loop.
1516         https://bugs.webkit.org/show_bug.cgi?id=197307
1517
1518         The style checker shouldn't complain about an open brace on
1519         its own line if the last non-whitespace character on the previous
1520         non-blank line is another open brace, because it's likely to
1521         indicate the begining of a nested code block.
1522
1523         Reviewed by Alex Christensen.
1524
1525         * Scripts/webkitpy/style/checkers/cpp.py:
1526         (check_braces):
1527         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1528         (WebKitStyleTest.test_braces):
1529
1530 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
1531
1532         Stop IDB transactions to release locked database files when network process is ready to suspend
1533         https://bugs.webkit.org/show_bug.cgi?id=196372
1534         <rdar://problem/48930116>
1535
1536         Reviewed by Brady Eidson.
1537
1538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1539         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
1540         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
1541         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
1542         (runTestAndCheckResult):
1543         (keepNetworkProcessActive):
1544         (TEST):
1545
1546 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1547
1548         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
1549         https://bugs.webkit.org/show_bug.cgi?id=188357
1550         <rdar://problem/42986633>
1551
1552         Reviewed by Dean Jackson.
1553
1554         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
1555         tests would fall into low memory mode and have different behavior.
1556         
1557         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
1558         to Internals, so it's shared by DRT and WTR.
1559         
1560         We no longer need the WK2 C SPI glue.
1561
1562         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1563         (WTR::InjectedBundlePage::prepare):
1564
1565 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
1566
1567         webkitpy: Including skipped tests in the final count
1568         https://bugs.webkit.org/show_bug.cgi?id=197298
1569         <rdar://problem/49705424>
1570
1571         Reviewed by Lucas Forschler.
1572
1573         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1574         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1575
1576 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1577
1578         Disable date and time inputs on iOSMac.
1579         https://bugs.webkit.org/show_bug.cgi?id=197287
1580         rdar://problem/46794376
1581
1582         Reviewed by Wenson Hsieh.
1583
1584         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1585
1586 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1587
1588         Fix test-webkitpy after r244653
1589         https://bugs.webkit.org/show_bug.cgi?id=197131
1590
1591         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1592         Also use C++17.
1593
1594 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1595
1596         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1597         https://bugs.webkit.org/show_bug.cgi?id=196991
1598         <rdar://problem/45507423>
1599
1600         Reviewed by Alex Christensen.
1601
1602         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1603         (-[NavigationTestDelegate init]):
1604         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1605         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1606         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1607         (TestWebKitAPI::TEST):
1608         (TEST): Deleted.
1609
1610 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1611
1612         Revert some code accidentally committed with r244653
1613         https://bugs.webkit.org/show_bug.cgi?id=197131
1614
1615         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1616         (TestWebKitAPI::TEST):
1617
1618 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1619
1620         Start using C++17
1621         https://bugs.webkit.org/show_bug.cgi?id=197131
1622
1623         Reviewed by Darin Adler.
1624
1625         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1626         * MiniBrowser/Configurations/Base.xcconfig:
1627         * MobileMiniBrowser/Configurations/Base.xcconfig:
1628         * TestWebKitAPI/Configurations/Base.xcconfig:
1629         * WebKitTestRunner/Configurations/Base.xcconfig:
1630
1631 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1632
1633         Unreviewed, rolling out r244627.
1634         https://bugs.webkit.org/show_bug.cgi?id=197282
1635
1636         Causing internal build failures (Requested by ShawnRoberts on
1637         #webkit).
1638
1639         Reverted changeset:
1640
1641         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1642         https://bugs.webkit.org/show_bug.cgi?id=197171
1643         https://trac.webkit.org/changeset/244627
1644
1645 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1646
1647         [GTK] Hardcoded text color in input fields
1648         https://bugs.webkit.org/show_bug.cgi?id=126907
1649
1650         Reviewed by Michael Catanzaro.
1651
1652         Add dark-mode command line option to MiniBrowser.
1653
1654         * MiniBrowser/gtk/main.c:
1655         (main):
1656
1657 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1658
1659         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1660         https://bugs.webkit.org/show_bug.cgi?id=196948
1661         <rdar://problem/49927131>
1662
1663         Reviewed by Tim Horton.
1664
1665         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1666         (TEST):
1667         The expected order of incoming events is
1668         1. didInvalidateIntrinsicContentSize
1669         2. didFirstLayout
1670         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1671         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1672         (and remember, all we care about is ordering).
1673
1674 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1675
1676         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1677         https://bugs.webkit.org/show_bug.cgi?id=197171
1678         <rdar://problem/47454979>
1679
1680         Reviewed by Youenn Fablet.
1681
1682         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1683         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1684         (TestWebKitAPI::TEST):
1685
1686 2019-04-24  Brady Eidson  <beidson@apple.com>
1687
1688         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1689         https://bugs.webkit.org/show_bug.cgi?id=191362
1690
1691         Reviewed by Alex Christensen.
1692
1693         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1694           from an XHR to a custom protocol.
1695
1696 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1697
1698         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1699         https://bugs.webkit.org/show_bug.cgi?id=197273
1700
1701         Reviewed by Dean Jackson.
1702
1703         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1704         so that WebCoreTestSupport::resetInternalsObject() is always run.
1705
1706         * DumpRenderTree/mac/DumpRenderTree.mm:
1707         (resetWebViewToConsistentStateBeforeTesting):
1708         (runTest):
1709
1710 2019-04-24  John Wilander  <wilander@apple.com>
1711
1712         Age out unconverted Ad Click Attributions after one week.
1713         https://bugs.webkit.org/show_bug.cgi?id=197238
1714         <rdar://problem/50177349>
1715
1716         Reviewed by Chris Dumez.
1717
1718         This patch adds infrastructure to allow tests to expire all unconverted
1719         attributions early.
1720
1721         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1722         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1723         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1724         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1725         * WebKitTestRunner/TestController.cpp:
1726         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1727         * WebKitTestRunner/TestController.h:
1728         * WebKitTestRunner/TestInvocation.cpp:
1729         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1730
1731 2019-04-24  Chris Dumez  <cdumez@apple.com>
1732
1733         Fix flaky crashes in a couple of PSON API tests
1734         https://bugs.webkit.org/show_bug.cgi?id=197239
1735
1736         Reviewed by Tim Horton.
1737
1738         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1739
1740         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1741
1742 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1743
1744         Make it possible to control the renderTreeAsText output by setting options on testRunner
1745         https://bugs.webkit.org/show_bug.cgi?id=197133
1746
1747         Reviewed by Sam Weinig.
1748
1749         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1750         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1751         these flags through the various framework layers.
1752
1753         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1754
1755         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1756         and hand-code DumpRenderTree bindings.
1757
1758         Some cleanup of the TestRunners, using member initializers.
1759
1760         * DumpRenderTree/TestRunner.cpp:
1761         (TestRunner::TestRunner):
1762         (setRenderTreeDumpOptionsCallback):
1763         (TestRunner::staticFunctions):
1764         (TestRunner::setRenderTreeDumpOptions):
1765         * DumpRenderTree/TestRunner.h:
1766         (TestRunner::renderTreeDumpOptions const):
1767         * DumpRenderTree/mac/DumpRenderTree.mm:
1768         (dump):
1769         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1770         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1771         (WTR::InjectedBundlePage::dump):
1772         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1773         (WTR::TestRunner::TestRunner):
1774         (WTR::TestRunner::setRenderTreeDumpOptions):
1775         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1776         (WTR::TestRunner::renderTreeDumpOptions const):
1777
1778 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1779
1780         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1781         https://bugs.webkit.org/show_bug.cgi?id=197078
1782         <rdar://problem/49564348>
1783
1784         Reviewed by Geoff Garen.
1785
1786         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1787         (TEST_F):
1788         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1789         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1790         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1791
1792 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1793
1794         Add unit test for r239322
1795         https://bugs.webkit.org/show_bug.cgi?id=197236
1796
1797         Reviewed by Chris Dumez.
1798
1799         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1800         May as well add the test infrastructure which was needed before and will be needed in the future.
1801
1802         * TestWebKitAPI/TCPServer.cpp:
1803         (TestWebKitAPI::TCPServer::TCPServer):
1804         * TestWebKitAPI/TCPServer.h:
1805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1806         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1807         (TestWebKitAPI::TEST):
1808         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1809         (TestWebKitAPI::downloadAtRate):
1810         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1811         (TEST):
1812         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1813         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1814         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1815         (TestWebKitAPI::TEST):
1816         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1817         (TEST):
1818
1819 2019-04-24  Chris Dumez  <cdumez@apple.com>
1820
1821         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1822         https://bugs.webkit.org/show_bug.cgi?id=197214
1823         <rdar://problem/49237544>
1824
1825         Reviewed by Alex Christensen.
1826
1827         Extend API test coverage.
1828
1829         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1830         (TEST):
1831
1832 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1833
1834         [Build][GStreamer] Update to 1.16.0
1835         https://bugs.webkit.org/show_bug.cgi?id=197157
1836
1837         Reviewed by Xabier Rodriguez-Calvar.
1838
1839         The upstreamed patches were removed and a new one was added for a
1840         regression detected in the scaletempo GStreamer element. The GNOME
1841         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1842         on the way, as it is the preferred build system now in GStreamer
1843         1.16.
1844
1845         * flatpak/files/httpd-autogen.sh:
1846         * flatpak/flatpakutils.py:
1847         (FlatpakPackage.install):
1848         (WebkitFlatpak.run_in_sandbox):
1849         * flatpak/org.webkit.CommonModules.yaml:
1850         * flatpak/org.webkit.WebKit.yaml:
1851         * gstreamer/jhbuild.modules:
1852         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1853         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1854         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1855         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1856         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1857         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1858         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1859         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1860         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1861         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1862         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1863         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1864         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1865         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1866         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1867         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1868         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1869         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1870         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1871         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1872         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1873         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1874
1875 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1876
1877         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1878         https://bugs.webkit.org/show_bug.cgi?id=197156
1879
1880         Reviewed by Michael Catanzaro.
1881
1882         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1883         support was added.
1884
1885         * MiniBrowser/gtk/BrowserTab.c:
1886         (browser_tab_set_background_color): Set the passed in color as web view background color.
1887         * MiniBrowser/gtk/BrowserTab.h:
1888         * MiniBrowser/gtk/BrowserWindow.c:
1889         (browser_window_init): Initialize backgroundColor.
1890         (browser_window_append_view): Call browser_tab_set_background_color().
1891         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1892         are added.
1893         * MiniBrowser/gtk/main.c:
1894         (main): Call browser_window_set_background_color() before creating the tabs.
1895
1896 2019-04-23  John Wilander  <wilander@apple.com>
1897
1898         Move Ad Click Attribution from internal feature to experimental feature
1899         https://bugs.webkit.org/show_bug.cgi?id=197218
1900         <rdar://problem/47651691>
1901
1902         Reviewed by Brent Fulgham.
1903
1904         * DumpRenderTree/TestOptions.cpp:
1905         (TestOptions::TestOptions):
1906
1907 2019-04-23  Andy Estes  <aestes@apple.com>
1908
1909         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1910         https://bugs.webkit.org/show_bug.cgi?id=196749
1911         <rdar://problem/35773454>
1912
1913         Reviewed by Daniel Bates.
1914
1915         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1916
1917         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1918         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1919         (-[QuickLookDelegate webView:didFinishNavigation:]):
1920         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1921         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1922         (runTest):
1923         (runTestDecideBeforeLoading):
1924         (runTestDecideAfterLoading):
1925         (TEST):
1926
1927 2019-04-23  John Wilander  <wilander@apple.com>
1928
1929         Remove Ad Click Attribution data when removing website data
1930         https://bugs.webkit.org/show_bug.cgi?id=197215
1931         <rdar://problem/47668988>
1932
1933         Reviewed by Chris Dumez.
1934
1935         This patch adds test infrastructure to delete Ad Click Attribution data
1936         through WebsiteDataStore::removeData().
1937
1938         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1939         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1940         (WTR::TestRunner::clearAdClickAttribution):
1941         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1942         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1943         * WebKitTestRunner/TestController.cpp:
1944         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1945         * WebKitTestRunner/TestController.h:
1946         * WebKitTestRunner/TestInvocation.cpp:
1947         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1948
1949 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1950
1951         webkitpy: Kill unresponsive worker processes
1952         https://bugs.webkit.org/show_bug.cgi?id=197205
1953         <rdar://problem/50104388>
1954
1955         Reviewed by Lucas Forschler.
1956
1957         * Scripts/webkitpy/common/message_pool.py:
1958         (_MessagePool.__init__): Add close timeout.
1959         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1960
1961 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1962
1963         Add unit tests for WKWebView.serverTrust
1964         https://bugs.webkit.org/show_bug.cgi?id=197202
1965
1966         Reviewed by Youenn Fablet
1967
1968         * TestWebKitAPI/TCPServer.cpp:
1969         (TestWebKitAPI::deleter<BIO>::operator()):
1970         (TestWebKitAPI::deleter<SSL>::operator()):
1971         (TestWebKitAPI::deleter<X509>::operator()):
1972         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1973         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1974         (TestWebKitAPI::TCPServer::TCPServer):
1975         (TestWebKitAPI::TCPServer::listenForConnections):
1976         * TestWebKitAPI/TCPServer.h:
1977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1978         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1979         (TestWebKitAPI::TEST):
1980         (verifyCertificateAndPublicKey):
1981         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1982         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1983         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1984         (TestWebKitAPI::downloadAtRate):
1985         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1986         (TEST):
1987         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1988         (TEST):
1989
1990 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1991
1992         Unreviewed, rolling out r244556.
1993         https://bugs.webkit.org/show_bug.cgi?id=197212
1994
1995         Causing build failures on multiple builders (Requested by
1996         ShawnRoberts on #webkit).
1997
1998         Reverted changeset:
1999
2000         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
2001         https://bugs.webkit.org/show_bug.cgi?id=197171
2002         https://trac.webkit.org/changeset/244556
2003
2004 2019-04-23  Alex Christensen  <achristensen@webkit.org>
2005
2006         Fix iOS build.
2007         https://bugs.webkit.org/show_bug.cgi?id=195537
2008
2009         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2010         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2011         AdoptWK constructor is private now.  Use adoptWK instead.
2012
2013 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
2014
2015         Accessibility text search and selection API enhancements.
2016         https://bugs.webkit.org/show_bug.cgi?id=197095
2017         <rdar://problem/48181791>
2018
2019         Reviewed by Chris Fleizach.
2020
2021         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
2022
2023         * DumpRenderTree/AccessibilityTextMarker.h:
2024         * DumpRenderTree/AccessibilityUIElement.cpp:
2025         (searchTextWithCriteriaCallback):
2026         (AccessibilityUIElement::getJSClass):
2027         * DumpRenderTree/AccessibilityUIElement.h:
2028         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2029         (convertVectorToObjectArray):
2030         (convertNSArrayToVector):
2031         (searchTextParameterizedAttributeForCriteria):
2032         (AccessibilityUIElement::getLinkedUIElements):
2033         (AccessibilityUIElement::getDocumentLinks):
2034         (AccessibilityUIElement::getChildren):
2035         (AccessibilityUIElement::getChildrenWithRange):
2036         (AccessibilityUIElement::rowHeaders const):
2037         (AccessibilityUIElement::columnHeaders const):
2038         (AccessibilityUIElement::uiElementArrayAttributeValue const):
2039         (AccessibilityUIElement::searchTextWithCriteria):
2040         (AccessibilityUIElement::attributesOfColumnHeaders):
2041         (AccessibilityUIElement::attributesOfRowHeaders):
2042         (AccessibilityUIElement::attributesOfColumns):
2043         (AccessibilityUIElement::attributesOfRows):
2044         (AccessibilityUIElement::attributesOfVisibleCells):
2045         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2046         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2047         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2048         (WTR::convertVectorToObjectArray):
2049         (WTR::convertNSArrayToVector):
2050         (WTR::searchTextParameterizedAttributeForCriteria):
2051         (WTR::AccessibilityUIElement::getLinkedUIElements):
2052         (WTR::AccessibilityUIElement::getDocumentLinks):
2053         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
2054         (WTR::AccessibilityUIElement::getChildren):
2055         (WTR::AccessibilityUIElement::getChildrenWithRange):
2056         (WTR::AccessibilityUIElement::rowHeaders const):
2057         (WTR::AccessibilityUIElement::columnHeaders const):
2058         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
2059         (WTR::AccessibilityUIElement::searchTextWithCriteria):
2060         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2061         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2062         (WTR::AccessibilityUIElement::attributesOfColumns):
2063         (WTR::AccessibilityUIElement::attributesOfRows):
2064         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2065         (WTR::convertElementsToObjectArray): Deleted.
2066
2067 2019-04-23  Guy Lewin  <guy@lewin.co.il>
2068
2069         Multiple File Input Icon Set Regardless of File List
2070         https://bugs.webkit.org/show_bug.cgi?id=195537
2071
2072         Reviewed by Alexey Proskuryakov.
2073
2074         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
2075         display string in iOS file inputs
2076
2077         * DumpRenderTree/TestRunner.cpp:
2078         (SetOpenPanelFilesMediaIconCallback):
2079         (TestRunner::staticFunctions):
2080         (TestRunner::setOpenPanelFilesMediaIcon):
2081         * DumpRenderTree/TestRunner.h:
2082         (TestRunner::openPanelFilesMediaIcon const):
2083         * DumpRenderTree/mac/UIDelegate.mm:
2084         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
2085         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2086         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2087         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
2088         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2089         * WebKitTestRunner/TestController.cpp:
2090         (WTR::runOpenPanel):
2091         (WTR::TestController::resetStateToConsistentValues):
2092         * WebKitTestRunner/TestController.h:
2093         (WTR::TestController::openPanelFileURLsMediaIcon const):
2094         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
2095         * WebKitTestRunner/TestInvocation.cpp:
2096         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2097
2098 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
2099
2100         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2101         https://bugs.webkit.org/show_bug.cgi?id=197171
2102         <rdar://problem/47454979>
2103
2104         Reviewed by Youenn Fablet.
2105
2106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2107         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2108         (TestWebKitAPI::TEST):
2109
2110 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2111
2112         [ews-build] Add unit tests for UnApplyPatchIfRequired
2113         https://bugs.webkit.org/show_bug.cgi?id=197197
2114
2115         Reviewed by Lucas Forschler.
2116
2117         * BuildSlaveSupport/ews-build/steps_unittest.py:
2118         (TestUnApplyPatchIfRequired):
2119         (TestUnApplyPatchIfRequired.test_success):
2120         (TestUnApplyPatchIfRequired.test_failure):
2121         (TestUnApplyPatchIfRequired.test_skip):
2122
2123 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2124
2125         [ews-build] Add unit tests for CleanWorkingDirectory
2126         https://bugs.webkit.org/show_bug.cgi?id=197195
2127
2128         Reviewed by Lucas Forschler.
2129
2130         * BuildSlaveSupport/ews-build/steps_unittest.py:
2131         (TestCleanWorkingDirectory):
2132         (TestCleanWorkingDirectory.test_success):
2133         (TestCleanWorkingDirectory.test_failure):
2134
2135 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2136
2137         [ews-build] Use explicit imports instead of wildcard imports
2138         https://bugs.webkit.org/show_bug.cgi?id=197194
2139
2140         Reviewed by Lucas Forschler.
2141
2142         * BuildSlaveSupport/ews-build/factories.py:
2143         * BuildSlaveSupport/ews-build/loadConfig.py:
2144         * BuildSlaveSupport/ews-build/steps_unittest.py:
2145
2146 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2147
2148         [ews-build] Add unit tests for DownloadBuiltProduct
2149         https://bugs.webkit.org/show_bug.cgi?id=197193
2150
2151         Reviewed by Lucas Forschler.
2152
2153         * BuildSlaveSupport/ews-build/steps_unittest.py:
2154         (TestDownloadBuiltProduct):
2155         (TestDownloadBuiltProduct.setUp):
2156         (TestDownloadBuiltProduct.tearDown):
2157         (TestDownloadBuiltProduct.test_success):
2158         (TestDownloadBuiltProduct.test_failure):
2159
2160 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
2161
2162         [ews-app] Exception while loading status-bubble when no build step has started
2163         https://bugs.webkit.org/show_bug.cgi?id=196676
2164
2165         Reviewed by Lucas Forschler.
2166
2167         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2168         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
2169
2170 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
2171
2172         [PlayStation] Support running of JSC tests on remote playstation devices
2173         https://bugs.webkit.org/show_bug.cgi?id=197170
2174
2175         Reviewed by Ross Kirsling.
2176
2177         Script changes
2178
2179         * Scripts/run-javascriptcore-tests:
2180         (runJSCStressTests): Pass arguments for playstation to
2181         run-jsc-stress-tests
2182         * Scripts/run-jsc-stress-tests:
2183         Handle $hostOS=="playstation" for determineArchitecture, turning
2184         off $isFTLPlatform and runProfiler and defaulting test writer.
2185         * Scripts/webkitdirs.pm:
2186         (jscPath): PlayStation WebKit executables have .elf extension
2187         (executableProductDir): PlayStation builds on Windows hosts but
2188         uses bin directory rather than bin64/bin32 for executable output
2189         location.
2190         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
2191
2192 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
2193
2194         [CMake][Win] Use target oriented design for WebKit
2195         https://bugs.webkit.org/show_bug.cgi?id=197173
2196
2197         Reviewed by Alex Christensen.
2198
2199         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
2200         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
2201
2202 2019-04-23  Chris Dumez  <cdumez@apple.com>
2203
2204         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
2205         https://bugs.webkit.org/show_bug.cgi?id=197097
2206         <rdar://problem/50048318>
2207
2208         Reviewed by Alex Christensen.
2209
2210         Add API test coverage.
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2213         (-[PSONScheme webView:startURLSchemeTask:]):
2214
2215 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2216
2217         [ATK] Implement AtkComponentIface scroll_to methods
2218         https://bugs.webkit.org/show_bug.cgi?id=196856
2219
2220         Reviewed by Michael Catanzaro.
2221
2222         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2223         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
2224         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
2225         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
2226
2227 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2228
2229         [ews-build] Improve summary for UploadBuiltProduct step
2230         https://bugs.webkit.org/show_bug.cgi?id=197182
2231
2232         Reviewed by Lucas Forschler.
2233
2234         * BuildSlaveSupport/ews-build/steps.py:
2235         (UploadBuiltProduct): Added descriptionDone.
2236         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
2237         * BuildSlaveSupport/ews-build/steps_unittest.py:
2238         (TestUploadBuiltProduct.test_success): Updated unit-test.
2239         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
2240
2241 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2242
2243         [ews-build] Trigger queues only after uploading the archive
2244         https://bugs.webkit.org/show_bug.cgi?id=197180
2245
2246         Reviewed by Lucas Forschler.
2247
2248         * BuildSlaveSupport/ews-build/factories.py:
2249         (Factory.__init__):
2250         (BuildFactory.__init__): Remove trigger step from factories.
2251         (BuildFactory.propertiesToPassToTriggers): Deleted.
2252         * BuildSlaveSupport/ews-build/steps.py:
2253         (ConfigureBuild.__init__): Confiure triggers property.
2254         (Trigger): Step to trigger other queues.
2255         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
2256         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
2257
2258 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2259
2260         Deprecate WKContextCreateWithInjectedBundlePath
2261         https://bugs.webkit.org/show_bug.cgi?id=197169
2262
2263         Reviewed by Youenn Fablet.
2264
2265         * TestWebKitAPI/PlatformUtilities.cpp:
2266         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2267         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
2268
2269 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2270
2271         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
2272         https://bugs.webkit.org/show_bug.cgi?id=197093
2273         <rdar://problem/49708268>
2274
2275         Reviewed by Chris Dumez.
2276
2277         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
2278         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
2279         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
2280         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
2281         and one for loads without credentials, so there are two TCP connections to the same server in this test.
2282
2283         * TestWebKitAPI/TCPServer.cpp:
2284         (TestWebKitAPI::TCPServer::TCPServer):
2285         (TestWebKitAPI::TCPServer::~TCPServer):
2286         (TestWebKitAPI::TCPServer::socketBindListen):
2287         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
2288         * TestWebKitAPI/TCPServer.h:
2289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2290         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
2291         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2292         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2293         (respondWithChallengeThenOK):
2294         (TestWebKitAPI::TEST):
2295         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
2296         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2297         (TEST):
2298
2299 2019-04-22  Chris Dumez  <cdumez@apple.com>
2300
2301         Delayed WebProcessLaunch may break the _relatedWebView SPI
2302         https://bugs.webkit.org/show_bug.cgi?id=197160
2303
2304         Reviewed by Alex Christensen.
2305
2306         Add API test coverage.
2307
2308         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2309
2310 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
2311
2312         Use curl to download packages for webkitpy autoinstaller
2313         https://bugs.webkit.org/show_bug.cgi?id=197164
2314
2315         Reviewed by Darin Adler.
2316
2317         * Scripts/webkitpy/common/system/autoinstall.py:
2318         (AutoInstaller._download): Use curl(1) to download packages necessary for
2319         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
2320         errors which are not present when using curl(1).
2321
2322 2019-04-22  Chris Dumez  <cdumez@apple.com>
2323
2324         Unreviewed, rolling out r244502.
2325
2326         Caused crashes on the bots
2327
2328         Reverted changeset:
2329
2330         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
2331         https://bugs.webkit.org/show_bug.cgi?id=197160
2332         https://trac.webkit.org/changeset/244502
2333
2334 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2335
2336         Unreviewed, rolling out r244437.
2337
2338         Still breaks internal tests.
2339
2340         Reverted changeset:
2341
2342         "InjectedBundle parameters often need initialization function
2343         called before unarchiving"
2344         https://bugs.webkit.org/show_bug.cgi?id=189709
2345         https://trac.webkit.org/changeset/244437
2346
2347 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
2348
2349         [ews-build] Use singular verb in failure description in case of single api test failure
2350         https://bugs.webkit.org/show_bug.cgi?id=197013
2351
2352         Reviewed by Lucas Forschler.
2353
2354         * BuildSlaveSupport/ews-build/steps.py:
2355         (AnalyzeAPITestsResults.analyzeResults):
2356
2357 2019-04-22  Chris Dumez  <cdumez@apple.com>
2358
2359         Delayed WebProcessLaunch may break the _relatedWebView SPI
2360         https://bugs.webkit.org/show_bug.cgi?id=197160
2361
2362         Reviewed by Alex Christensen.
2363
2364         Add API test coverage.
2365
2366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2367
2368 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2369
2370         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
2371         https://bugs.webkit.org/show_bug.cgi?id=194630
2372
2373         Reviewed by Michael Catanzaro.
2374
2375         Return early from getAttributeSet() is passed in accessible is nullptr.
2376
2377         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2378
2379 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2380
2381         Defer EditorState updates until the next layer tree flush in a few additional circumstances
2382         https://bugs.webkit.org/show_bug.cgi?id=197145
2383         <rdar://problem/50078170>
2384
2385         Reviewed by Darin Adler.
2386
2387         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
2388         focus, or showing the font manager.
2389
2390         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2391         (TestWebKitAPI::TEST):
2392         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2393         (TEST):
2394         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2395         (TestWebKitAPI::TEST):
2396
2397 2019-04-21  Brian Burg  <bburg@apple.com>
2398
2399         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
2400         https://bugs.webkit.org/show_bug.cgi?id=197125
2401         <rdar://problem/50061468>
2402
2403         Reviewed by Darin Adler.
2404
2405         Sometimes I want to run wptserve independently of tests. Make it easier to script that
2406         using this class rather than making our own ./wpt serve invocation.
2407
2408         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2409         (WebDriverW3CWebServer):
2410         (WebDriverW3CWebServer.document_root): Expose this to clients.
2411         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
2412
2413         (WebDriverW3CWebServer.__enter__):
2414         (WebDriverW3CWebServer.__exit__):
2415         Make it possible to use the web server with a 'with' statement.
2416
2417 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
2418
2419         [CMake][Win] Use target oriented design for WebKitLegacy
2420         https://bugs.webkit.org/show_bug.cgi?id=197112
2421
2422         Reviewed by Konstantin Tokarev.
2423
2424         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
2425
2426         * DumpRenderTree/CMakeLists.txt:
2427         * DumpRenderTree/PlatformWin.cmake:
2428         * DumpRenderTree/win/EventSender.cpp:
2429
2430 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2431
2432         Update text for old EWS submit button
2433         https://bugs.webkit.org/show_bug.cgi?id=197140
2434
2435         Reviewed by Alexey Proskuryakov.
2436
2437         * QueueStatusServer/templates/statusbubble.html:
2438
2439 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2440
2441         [ews-app] New EWS should poll bugzilla more frequently
2442         https://bugs.webkit.org/show_bug.cgi?id=197138
2443
2444         Reviewed by Alexey Proskuryakov.
2445
2446         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2447         (FetchLoop.__init__):
2448
2449 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
2450
2451         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
2452         https://bugs.webkit.org/show_bug.cgi?id=197139
2453
2454         Reviewed by Alexey Proskuryakov.
2455
2456         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2457         * QueueStatusServer/templates/statusbubble.html:
2458
2459 2019-04-20  Chris Dumez  <cdumez@apple.com>
2460
2461         Unreviewed, fix iOS build with recent SDKs.
2462
2463         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2464
2465 2019-04-19  Keith Miller  <keith_miller@apple.com>
2466
2467         Add script to merge run_benchmark jsons
2468         https://bugs.webkit.org/show_bug.cgi?id=197107
2469
2470         Reviewed by Michael Saboff.
2471
2472         The script basically recursively decends through all json objects until it gets
2473         to an array or JSON primitive and concats or takes the first value, respectively.
2474
2475         This patch also adds +x bits to the compare-results script so it
2476         can be run directly from the command line. I had to add a new line so that svn
2477         will accept the change... yay svn!
2478
2479         * Scripts/compare-results:
2480         * Scripts/merge-result-jsons: Added.
2481         (readJSONFile):
2482         (deepAppend):
2483         (mergeJSONs):
2484         (main):
2485
2486 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
2487
2488         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
2489         https://bugs.webkit.org/show_bug.cgi?id=197079
2490
2491         Reviewed by Darin Adler.
2492
2493         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
2494
2495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2496         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
2497
2498 2019-04-18  Commit Queue  <commit-queue@webkit.org>
2499
2500         Unreviewed, rolling out r244434.
2501         https://bugs.webkit.org/show_bug.cgi?id=197089
2502
2503         caused 1 API test failure (Requested by zalan on #webkit).
2504
2505         Reverted changeset:
2506
2507         "Regression (r244291): Broken API Test
2508         AutoLayoutRenderingProgressRelativeOrdering"
2509         https://bugs.webkit.org/show_bug.cgi?id=196948
2510         https://trac.webkit.org/changeset/244434
2511
2512 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2513
2514         Add new compatibility mode API on WKNavigation
2515         https://bugs.webkit.org/show_bug.cgi?id=197069
2516         <rdar://problem/50025800>
2517
2518         Reviewed by Tim Horton.
2519
2520         Add a block property for -didCommitNavigation to TestNavigationDelegate.
2521
2522         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2523         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2524         (-[TestNavigationDelegate webView:didCommitNavigation:]):
2525
2526 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
2527
2528         [CMake] Make WebCore headers copies
2529         https://bugs.webkit.org/show_bug.cgi?id=182512
2530         <rdar://problem/37510435>
2531
2532         Reviewed by Alex Christensen.
2533
2534         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
2535         ports.
2536
2537         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
2538         of WebCore headers using "*.h" were modified to <WebCore/*.h>
2539
2540         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2541         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
2542         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
2543         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
2544         * TestWebKitAPI/CMakeLists.txt:
2545         * TestWebKitAPI/PlatformWin.cmake:
2546         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
2547         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
2548         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2549
2550 2019-04-18  Jer Noble  <jer.noble@apple.com>
2551
2552         Add support for parsing FairPlayStreaming PSSH boxes.
2553         https://bugs.webkit.org/show_bug.cgi?id=197064
2554
2555         Reviewed by Eric Carlson.
2556
2557         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
2558         (TestWebKitAPI::TEST):
2559
2560 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
2561
2562         InjectedBundle parameters often need initialization function called before unarchiving
2563         https://bugs.webkit.org/show_bug.cgi?id=189709
2564         <rdar://problem/44573653>
2565
2566         Reviewed by Ryosuke Niwa.
2567
2568         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2569         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2570
2571 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2572
2573         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2574         https://bugs.webkit.org/show_bug.cgi?id=196948
2575         <rdar://problem/49927131>
2576
2577         Reviewed by Tim Horton.
2578
2579         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2580         (TEST): 
2581         The expected order of incoming events is
2582         1. didInvalidateIntrinsicContentSize
2583         2. didFirstLayout
2584         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2585         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2586         (and remember, all we care about is ordering).
2587
2588 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2589
2590         Unreviewed, rolling out r244299.
2591
2592         Breaks internal tests.
2593
2594         Reverted changeset:
2595
2596         "InjectedBundle parameters often need initialization function
2597         called before unarchiving"
2598         https://bugs.webkit.org/show_bug.cgi?id=189709
2599         https://trac.webkit.org/changeset/244299
2600
2601 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2602
2603         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2604         https://bugs.webkit.org/show_bug.cgi?id=197053
2605
2606         Reviewed by Saam Barati.
2607
2608         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2609         (TestWebKitAPI::TEST):
2610
2611 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2612
2613         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2614         https://bugs.webkit.org/show_bug.cgi?id=197028
2615         <rdar://problem/49985290>
2616
2617         Reviewed by Wenson Hsieh.
2618
2619         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2620         (TEST):
2621         Liberal application of waitForNextPresentationUpdate works around a race
2622         where if the page rapidly changes its viewport arguments (or an API client
2623         rapidly changes its viewport arguments), we'd get stuck thinking that the
2624         user had intentionally zoomed the page, and stop resetting the initial scale.
2625         This deserves a separate bug, but no need to keep the test failing while
2626         we think about it.
2627
2628 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2629
2630         REGRESSION (r241988): Switching tabs is slow
2631         https://bugs.webkit.org/show_bug.cgi?id=197037
2632         <rdar://problem/49951473>
2633
2634         Reviewed by Simon Fraser.
2635
2636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2637         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2638         (TEST):
2639         * TestWebKitAPI/cocoa/TestWKWebView.h:
2640         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2641         (-[TestWKWebView addToTestWindow]):
2642         Add a test that hangs without this fix.
2643
2644 2019-04-17  Truitt Savell  <tsavell@apple.com>
2645
2646         Unreviewed, rolling out r244400.
2647
2648         Caused testing to exit early with assertionon Debug WK2
2649
2650         Reverted changeset:
2651
2652         "UI↔Web deadlock when printing with a JavaScript alert
2653         visible"
2654         https://bugs.webkit.org/show_bug.cgi?id=196839
2655         https://trac.webkit.org/changeset/244400
2656
2657 2019-04-17  Brady Eidson  <beidson@apple.com>
2658
2659         Link clicks in PDFs shouldn't send referrer headers.
2660         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2661
2662         Reviewed by Tim Horton.
2663
2664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2665         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2666         (putPDFBytesCallback):
2667         (emptyReleaseInfoCallback):
2668         (createPDFWithLinkToURL):
2669         (TEST):
2670
2671 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2672
2673         UI↔Web deadlock when printing with a JavaScript alert visible
2674         https://bugs.webkit.org/show_bug.cgi?id=196839
2675         <rdar://problem/49157642>
2676
2677         Reviewed by Andy Estes.
2678
2679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2680         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2681         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2682         (TEST):
2683
2684 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2685
2686         WKRetainPtr's adoption constructor should be private
2687         https://bugs.webkit.org/show_bug.cgi?id=197019
2688
2689         Reviewed by Tim Horton.
2690
2691         * DumpRenderTree/mac/DumpRenderTree.mm:
2692         (dumpFramesAsText):
2693         * TestWebKitAPI/InjectedBundleController.cpp:
2694         (TestWebKitAPI::InjectedBundleController::initialize):
2695         * TestWebKitAPI/PlatformUtilities.cpp:
2696         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2697         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2698         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2699         (TestWebKitAPI::Util::toWK):
2700         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2701         (TestWebKitAPI::TEST):
2702         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2703         (TestWebKitAPI::TEST):
2704         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2705         (TestWebKitAPI::TEST):
2706         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2707         (TestWebKitAPI::TEST):
2708         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2709         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2710         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2711         (TestWebKitAPI::TEST):
2712         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2713         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2714         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2715         (TestWebKitAPI::TEST):
2716         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2717         (TestWebKitAPI::TEST):
2718         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2719         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2720         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2721         (TestWebKitAPI::TEST):
2722         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2723         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2724         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2725         (TestWebKitAPI::TEST):
2726         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2727         (TestWebKitAPI::TEST):
2728         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2729         (TestWebKitAPI::TEST):
2730         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2731         (TestWebKitAPI::TEST):
2732         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2733         (TestWebKitAPI::TEST):
2734         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2735         (TestWebKitAPI::TEST):
2736         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2737         (TestWebKitAPI::TEST):
2738         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2739         (TestWebKitAPI::TEST):
2740         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2741         (TestWebKitAPI::TEST):
2742         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2743         (TestWebKitAPI::TEST):
2744         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2745         (TestWebKitAPI::TEST):
2746         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2747         (TestWebKitAPI::TEST):
2748         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2749         (TestWebKitAPI::TEST):
2750         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2751         (TestWebKitAPI::TEST):
2752         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2753         (TestWebKitAPI::TEST):
2754         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2755         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2756         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2757         (TestWebKitAPI::TEST):
2758         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2759         (TestWebKitAPI::TEST):
2760         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2761         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2762         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2763         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2764         (TestWebKitAPI::TEST):
2765         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2766         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2767         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2768         (TestWebKitAPI::TEST):
2769         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2770         (TestWebKitAPI::TEST):
2771         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2772         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2773         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2774         (TestWebKitAPI::TEST):
2775         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2776         (TestWebKitAPI::loadAlternateHTMLString):
2777         (TestWebKitAPI::TEST):
2778         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2779         (TestWebKitAPI::TEST):
2780         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2781         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2782         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2783         (TestWebKitAPI::buildAndPerformTest):
2784         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2785         (TestWebKitAPI::TEST):
2786         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2787         (TestWebKitAPI::TEST):
2788         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2789         (TestWebKitAPI::TEST):
2790         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2791         (TestWebKitAPI::TEST):
2792         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2793         (TestWebKitAPI::TEST):
2794         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2795         (TestWebKitAPI::TEST):
2796         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2797         (TestWebKitAPI::TEST):
2798         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2799         (TestWebKitAPI::TEST):
2800         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2801         (TestWebKitAPI::TEST):
2802         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2803         (TestWebKitAPI::TEST):
2804         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2805         (TestWebKitAPI::TEST):
2806         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2807         (TestWebKitAPI::TEST):
2808         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2809         (TestWebKitAPI::TEST):
2810         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2811         (TestWebKitAPI::TEST):
2812         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2813         (TestWebKitAPI::TEST):
2814         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2815         (TestWebKitAPI::TEST):
2816         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2817         (TestWebKitAPI::TEST):
2818         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2819         (TestWebKitAPI::TEST):
2820         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2821         (TestWebKitAPI::TEST):
2822         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2823         (TestWebKitAPI::TEST):
2824         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2825         (TestWebKitAPI::TEST):
2826         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2827         (TestWebKitAPI::TEST):
2828         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2829         (TestWebKitAPI::TEST):
2830         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2831         (TestWebKitAPI::TEST):
2832         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2833         (TestWebKitAPI::TEST):
2834         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2835         (TestWebKitAPI::TEST):
2836         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2837         (TestWebKitAPI::TEST):
2838         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2839         (TestWebKitAPI::TEST):
2840         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2841         (TestWebKitAPI::TEST):
2842         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2843         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2844         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2845         (TestWebKitAPI::TEST):
2846         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2847         (TestWebKitAPI::TEST):
2848         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2849         (TestWebKitAPI::TEST):
2850         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2851         (TestWebKitAPI::TEST):
2852         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2853         (TestWebKitAPI::TEST):
2854         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2855         (TestWebKitAPI::TEST):
2856         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2857         (TestWebKitAPI::TEST):
2858         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2859         (TestWebKitAPI::TEST):
2860         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2861         (TestWebKitAPI::TEST):
2862         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2863         (TestWebKitAPI::TEST):
2864         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2866         (TEST):
2867         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2868         (TEST):
2869         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2870         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2871         (TEST):
2872         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2873         (TestWebKitAPI::TEST):
2874         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2875         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2876         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2877         (WTR::getMenuItemTitleCallback):
2878         (WTR::createMouseMessageBody):
2879         (WTR::EventSendingController::mouseDown):
2880         (WTR::EventSendingController::mouseUp):
2881         (WTR::EventSendingController::mouseMoveTo):
2882         (WTR::EventSendingController::mouseForceClick):
2883         (WTR::EventSendingController::startAndCancelMouseForceClick):
2884         (WTR::EventSendingController::mouseForceDown):
2885         (WTR::EventSendingController::mouseForceUp):
2886         (WTR::EventSendingController::mouseForceChanged):
2887         (WTR::EventSendingController::leapForward):
2888         (WTR::EventSendingController::scheduleAsynchronousClick):
2889         (WTR::createKeyDownMessageBody):
2890         (WTR::EventSendingController::keyDown):
2891         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2892         (WTR::EventSendingController::mouseScrollBy):
2893         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2894         (WTR::EventSendingController::continuousMouseScrollBy):
2895         (WTR::EventSendingController::addTouchPoint):
2896         (WTR::EventSendingController::updateTouchPoint):
2897         (WTR::EventSendingController::setTouchModifier):
2898         (WTR::EventSendingController::setTouchPointRadius):
2899         (WTR::EventSendingController::touchStart):
2900         (WTR::EventSendingController::touchMove):
2901         (WTR::EventSendingController::touchEnd):
2902         (WTR::EventSendingController::touchCancel):
2903         (WTR::EventSendingController::clearTouchPoints):
2904         (WTR::EventSendingController::releaseTouchPoint):
2905         (WTR::EventSendingController::cancelTouchPoint):
2906         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2907         (WTR::InjectedBundle::didCreatePage):
2908         (WTR::InjectedBundle::didReceiveMessage):
2909         (WTR::InjectedBundle::didReceiveMessageToPage):
2910         (WTR::InjectedBundle::booleanForKey):
2911         (WTR::InjectedBundle::done):
2912         (WTR::InjectedBundle::dumpToStdErr):
2913         (WTR::InjectedBundle::outputText):
2914         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2915         (WTR::InjectedBundle::postAddChromeInputField):
2916         (WTR::InjectedBundle::postRemoveChromeInputField):
2917         (WTR::InjectedBundle::postFocusWebView):
2918         (WTR::InjectedBundle::postSetBackingScaleFactor):
2919         (WTR::InjectedBundle::postSetWindowIsKey):
2920         (WTR::InjectedBundle::postSetViewSize):
2921         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2922         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2923         (WTR::InjectedBundle::setGeolocationPermission):
2924         (WTR::InjectedBundle::setMockGeolocationPosition):
2925         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2926         (WTR::InjectedBundle::isGeolocationProviderActive const):
2927         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2928         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2929         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2930         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2931         (WTR::InjectedBundle::setCustomPolicyDelegate):
2932         (WTR::InjectedBundle::setHidden):
2933         (WTR::InjectedBundle::setCacheModel):
2934         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2935         (WTR::InjectedBundle::processWorkQueue):
2936         (WTR::InjectedBundle::queueBackNavigation):
2937         (WTR::InjectedBundle::queueForwardNavigation):
2938         (WTR::InjectedBundle::queueLoad):
2939         (WTR::InjectedBundle::queueLoadHTMLString):
2940         (WTR::InjectedBundle::queueReload):
2941         (WTR::InjectedBundle::queueLoadingScript):
2942         (WTR::InjectedBundle::queueNonLoadingScript):
2943         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2944         (WTR::frameToStr):
2945         (WTR::InjectedBundlePage::InjectedBundlePage):
2946         (WTR::dumpFrameDescriptionSuitableForTestResult):
2947         (WTR::dumpFrameScrollPosition):
2948         (WTR::dumpDescendantFrameScrollPositions):
2949         (WTR::dumpFrameText):
2950         (WTR::dumpDescendantFramesText):
2951         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2952         (WTR::TestRunner::shouldDumpPixels const):
2953         (WTR::TestRunner::setDumpPixels):
2954         (WTR::TestRunner::whatToDump const):
2955         (WTR::TestRunner::setWhatToDump):
2956         (WTR::TestRunner::setWaitUntilDone):
2957         (WTR::TestRunner::shouldWaitUntilDone const):
2958         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2959         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2960         (WTR::TestRunner::clearAllDatabases):
2961         (WTR::TestRunner::setIDBPerOriginQuota):
2962         (WTR::TestRunner::originsWithApplicationCache):
2963         (WTR::TestRunner::setCanOpenWindows):
2964         (WTR::TestRunner::setXSSAuditorEnabled):
2965         (WTR::TestRunner::setMediaDevicesEnabled):
2966         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2967         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2968         (WTR::TestRunner::setCustomUserAgent):
2969         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2970         (WTR::TestRunner::setModernMediaControlsEnabled):
2971         (WTR::TestRunner::setWebGL2Enabled):
2972         (WTR::TestRunner::setWritableStreamAPIEnabled):
2973         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2974         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2975         (WTR::TestRunner::setAllowsAnySSLCertificate):
2976         (WTR::TestRunner::setPluginsEnabled):
2977         (WTR::TestRunner::setValueForUser):
2978         (WTR::TestRunner::setAudioResult):
2979         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2980         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2981         (WTR::TestRunner::setAlwaysAcceptCookies):
2982         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2983         (WTR::TestRunner::isDoingMediaCapture const):
2984         (WTR::TestRunner::queueLoad):
2985         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2986         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2987         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2988         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2989         (WTR::TestRunner::setAuthenticationUsername):
2990         (WTR::TestRunner::setAuthenticationPassword):
2991         (WTR::TestRunner::secureEventInputIsEnabled const):
2992         (WTR::TestRunner::setBlockAllPlugins):
2993         (WTR::TestRunner::setPluginSupportedMode):
2994         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2995         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2996         (WTR::TestRunner::setNavigationGesturesEnabled):
2997         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2998         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2999         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3000         (WTR::TestRunner::terminateNetworkProcess):
3001         (WTR::TestRunner::terminateServiceWorkerProcess):
3002         (WTR::TestRunner::runUIScript):
3003         (WTR::TestRunner::setStatisticsDebugMode):
3004         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
3005         (WTR::TestRunner::setStatisticsLastSeen):
3006         (WTR::TestRunner::setStatisticsPrevalentResource):
3007         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
3008         (WTR::TestRunner::dumpResourceLoadStatistics):
3009         (WTR::TestRunner::isStatisticsPrevalentResource):
3010         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3011         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3012         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3013         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3014         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
3015         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3016         (WTR::TestRunner::setStatisticsGrandfathered):
3017         (WTR::TestRunner::isStatisticsGrandfathered):
3018         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
3019         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
3020         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
3021         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
3022         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
3023         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
3024         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3025         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
3026         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
3027         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3028         (WTR::TestRunner::statisticsUpdateCookieBlocking):
3029         (WTR::TestRunner::statisticsSubmitTelemetry):
3030         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3031         (WTR::TestRunner::setStatisticsIsRunningTest):
3032         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
3033         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3034         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3035         (WTR::TestRunner::setStatisticsGrandfatheringTime):
3036         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
3037         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
3038         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3039         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
3040         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
3041         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3042         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
3043         (WTR::TestRunner::statisticsResetToConsistentState):
3044         (WTR::TestRunner::setStorageAccessAPIEnabled):
3045         (WTR::TestRunner::getAllStorageAccessEntries):
3046         (WTR::TestRunner::addMockMediaDevice):
3047         (WTR::TestRunner::clearMockMediaDevices):
3048         (WTR::TestRunner::removeMockMediaDevice):
3049         (WTR::TestRunner::resetMockMediaDevices):
3050         (WTR::TestRunner::connectMockGamepad):
3051         (WTR::TestRunner::disconnectMockGamepad):
3052         (WTR::TestRunner::setMockGamepadDetails):
3053         (WTR::TestRunner::setMockGamepadAxisValue):
3054         (WTR::TestRunner::setMockGamepadButtonValue):
3055         (WTR::TestRunner::removeAllSessionCredentials):
3056         (WTR::TestRunner::clearDOMCache):
3057         (WTR::TestRunner::clearDOMCaches):
3058         (WTR::TestRunner::hasDOMCache):
3059         (WTR::TestRunner::domCacheSize):
3060         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3061         (WTR::TestRunner::getApplicationManifestThen):
3062         (WTR::TestRunner::injectUserScript):
3063         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
3064         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3065         (WTR::TestRunner::addTestKeyToKeychain):
3066         (WTR::TestRunner::cleanUpKeychain):
3067         (WTR::TestRunner::keyExistsInKeychain):
3068         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3069         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3070         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3071         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3072         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3073         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3074         * WebKitTestRunner/TestController.cpp:
3075         (WTR::TestController::initialize):
3076         (WTR::parseStringTestHeaderValueAsRelativePath):
3077         (WTR::updateTestOptionsFromTestHeader):
3078         (WTR::TestController::runTest):
3079         (WTR::TestController::didReceiveLiveDocumentsList):
3080         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3081         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3082         (WTR::TestController::didFinishNavigation):
3083         (WTR::TestController::didReceiveAuthenticationChallenge):
3084         * WebKitTestRunner/TestInvocation.cpp:
3085         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3086         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3087         (WTR::TestInvocation::uiScriptDidComplete):
3088         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
3089         * WebKitTestRunner/WebNotificationProvider.cpp:
3090         (WTR::WebNotificationProvider::closeWebNotification):
3091         * WebKitTestRunner/WorkQueueManager.cpp:
3092         (WTR::ScriptItem::ScriptItem):
3093         (WTR::WorkQueueManager::queueLoad):
3094         (WTR::WorkQueueManager::queueLoadHTMLString):
3095
3096 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3097
3098         Add a comment to make my test from r244139 less mysterious.
3099         https://bugs.webkit.org/show_bug.cgi?id=196744
3100
3101         As suggested by Darin Adler.
3102
3103         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3104         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3105
3106 2019-04-17  Chris Dumez  <cdumez@apple.com>
3107
3108         Remember device orientation permission for the duration of the browsing session
3109         https://bugs.webkit.org/show_bug.cgi?id=196992
3110         <rdar://problem/49946067>
3111
3112         Reviewed by Alex Christensen.
3113
3114         Add API test coverage.
3115
3116         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3117         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3118         (TEST):
3119
3120 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
3121
3122         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
3123         https://bugs.webkit.org/show_bug.cgi?id=196675
3124
3125         Reviewed by Lucas Forschler.
3126
3127         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
3128         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
3129
3130 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3131
3132         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
3133         https://bugs.webkit.org/show_bug.cgi?id=196919
3134         <rdar://problem/41630459>
3135
3136         Reviewed by Tim Horton.
3137
3138         Add iOS support for several new testing hooks. See below for more detail.
3139
3140         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3141         (WTR::UIScriptController::isDismissingMenu const):
3142
3143         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
3144         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
3145         by UIKit when dismissing the callout bar (i.e. UIMenuController).
3146
3147         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3148         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3149         (WTR::UIScriptController::isDismissingMenu const):
3150         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3151         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3152         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3153         (WTR::InjectedBundle::didReceiveMessageToPage):
3154         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3155         (WTR::TestRunner::setAllowedMenuActions):
3156
3157         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
3158         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
3159         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
3160         against the name of the custom action.
3161
3162         (WTR::TestRunner::installCustomMenuAction):
3163
3164         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
3165         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
3166         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
3167         triggered.
3168
3169         (WTR::TestRunner::performCustomMenuAction):
3170
3171         Invoked when the custom menu action is triggered.
3172
3173         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3174         * WebKitTestRunner/TestController.cpp:
3175         (WTR::TestController::installCustomMenuAction):
3176         (WTR::TestController::setAllowedMenuActions):
3177         * WebKitTestRunner/TestController.h:
3178         * WebKitTestRunner/TestInvocation.cpp:
3179         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3180         (WTR::TestInvocation::performCustomMenuAction):
3181
3182         Add plumbing to call back into the injected bundle when performing the custom action.
3183
3184         * WebKitTestRunner/TestInvocation.h:
3185         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3186         (WTR::TestController::installCustomMenuAction):
3187         (WTR::TestController::setAllowedMenuActions):
3188         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3189         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3190         (-[TestRunnerWKWebView initWithFrame:configuration:]):
3191         (-[TestRunnerWKWebView becomeFirstResponder]):
3192         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
3193
3194         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
3195         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
3196         in the Mail app on iOS.
3197
3198         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
3199         (-[TestRunnerWKWebView setAllowedMenuActions:]):
3200         (-[TestRunnerWKWebView resetCustomMenuAction]):
3201         (-[TestRunnerWKWebView performCustomAction:]):
3202         (-[TestRunnerWKWebView canPerformAction:withSender:]):
3203         (-[TestRunnerWKWebView _willHideMenu]):
3204         (-[TestRunnerWKWebView _didHideMenu]):
3205         * WebKitTestRunner/ios/TestControllerIOS.mm:
3206         (WTR::TestController::platformResetStateToConsistentValues):
3207
3208         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
3209         if specified.
3210
3211         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3212         (WTR::UIScriptController::isDismissingMenu const):
3213
3214 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
3215
3216         Allow sharing from imageSheet on an image document
3217         https://bugs.webkit.org/show_bug.cgi?id=196891
3218         <rdar://problem/25377386>
3219
3220         Reviewed by Tim Horton.
3221
3222         Test to make sure that the correct imageURL is extracted from an image element.
3223
3224         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3225         (TestWebKitAPI::TEST):
3226
3227 2019-04-16  Alex Christensen  <achristensen@webkit.org>
3228
3229         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
3230         https://bugs.webkit.org/show_bug.cgi?id=196995
3231
3232         Reviewed by Brady Eidson.
3233
3234         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3235         (TEST):
3236
3237 2019-04-16  Chris Dumez  <cdumez@apple.com>
3238
3239         URL set by document.open() is not communicated to the UIProcess
3240         https://bugs.webkit.org/show_bug.cgi?id=196941
3241         <rdar://problem/49237544>
3242
3243         Reviewed by Geoff Garen.
3244
3245         Add API test coverage.
3246
3247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3248         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3249         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3250         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3251         (TEST):
3252
3253 2019-04-16  Commit Queue  <commit-queue@webkit.org>
3254
3255         Unreviewed, rolling out r244321.
3256         https://bugs.webkit.org/show_bug.cgi?id=196968
3257
3258         Causing all WK2 Debug builds to exit early after Assertion
3259         failures. (Requested by ShawnRoberts on #webkit).
3260
3261         Reverted changeset:
3262
3263         "URL set by document.open() is not communicated to the
3264         UIProcess"
3265         https://bugs.webkit.org/show_bug.cgi?id=196941
3266         https://trac.webkit.org/changeset/244321
3267
3268 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3269
3270         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3271         https://bugs.webkit.org/show_bug.cgi?id=196948
3272
3273         Reviewed by Zalan Bujtas.
3274
3275         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3276         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
3277
3278 2019-04-15  Chris Dumez  <cdumez@apple.com>
3279
3280         URL set by document.open() is not communicated to the UIProcess
3281         https://bugs.webkit.org/show_bug.cgi?id=196941
3282         <rdar://problem/49237544>
3283
3284         Reviewed by Geoffrey Garen.
3285
3286         Add API test coverage.
3287
3288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3289         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
3290         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3291         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3292         (TEST):
3293
3294 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
3295
3296         Using Tools/Scripts/clean-webkit should not install requests
3297         https://bugs.webkit.org/show_bug.cgi?id=196940
3298
3299         Reviewed by Lucas Forschler.
3300
3301         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
3302         existing, depending on the path autoinstalled is run through.
3303         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
3304         needed.
3305         (Port.configuration_for_upload):
3306         (Port.commits_for_upload):
3307
3308 2019-04-15  Alex Christensen  <achristensen@webkit.org>
3309
3310         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
3311         https://bugs.webkit.org/show_bug.cgi?id=196773
3312
3313         Reviewed by Jer Noble.
3314
3315         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
3316         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
3317         (TEST):
3318
3319 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3320
3321         ews-build should clearly indicate flaky test failures
3322         https://bugs.webkit.org/show_bug.cgi?id=196947
3323
3324         Reviewed by Lucas Forschler.
3325
3326         * BuildSlaveSupport/ews-build/steps.py:
3327         (AnalyzeAPITestsResults.analyzeResults):
3328
3329 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
3330
3331         InjectedBundle parameters often need initialization function called before unarchiving
3332         https://bugs.webkit.org/show_bug.cgi?id=189709
3333         <rdar://problem/44573653>
3334
3335         Reviewed by Ryosuke Niwa.
3336
3337         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
3338         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
3339
3340 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
3341
3342         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
3343         https://bugs.webkit.org/show_bug.cgi?id=196681
3344
3345         Reviewed by Darin Adler.
3346
3347         Added tests.
3348
3349         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3350         (WTF_HashSet.RemoveIf):
3351         (WTF_HashSet.RemoveIfShrinkToBestSize):
3352
3353 2019-04-15  John Wilander  <wilander@apple.com>
3354
3355         Send delayed Ad Click Attribution conversion requests to the click source
3356         https://bugs.webkit.org/show_bug.cgi?id=196838
3357         <rdar://problem/47650157>
3358
3359         Reviewed by Chris Dumez and Youenn Fablet.
3360
3361         This patch adds test infrastructure to override the default behavior in
3362         WebKit::NetworkAdClickAttribution.
3363
3364         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3365         (TestWebKitAPI::TEST):
3366         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3367         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3368         (WTR::TestRunner::dumpAdClickAttribution):
3369         (WTR::TestRunner::clearAdClickAttribution):
3370         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
3371         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
3372         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3373         * WebKitTestRunner/TestController.cpp:
3374         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
3375         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
3376         * WebKitTestRunner/TestController.h:
3377         * WebKitTestRunner/TestInvocation.cpp:
3378         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3379
3380 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3381
3382         [ews-app] status-bubble should display position in queue
3383         https://bugs.webkit.org/show_bug.cgi?id=196607
3384
3385         Reviewed by Lucas Forschler.
3386
3387         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3388         (StatusBubble._build_bubble):
3389         (StatusBubble._queue_position): Method to calculate patch's position in queue.
3390
3391 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
3392
3393         [ews-build] Do not run clean build by default on EWS builders
3394         https://bugs.webkit.org/show_bug.cgi?id=196897
3395
3396         Reviewed by Lucas Forschler.
3397
3398         * BuildSlaveSupport/ews-build/steps.py:
3399         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
3400         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
3401         untracked directories like WebKitBuild).
3402         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
3403         untracked files/directories (like WebKitBuild).
3404
3405 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
3406
3407         TestRunner::notifyDone() should be safely reentrant
3408         https://bugs.webkit.org/show_bug.cgi?id=196898
3409
3410         Reviewed by Darin Adler.
3411
3412         It is currently possible that TestRunner::notifyDone() will call itself, since
3413         notifyDone() will force a repaint, which can start executing JavaScript, which
3414         may call notifyDone() again. This can lead to test failures and flakiness.
3415         Fix this by setting the m_waitToDump flag before calling the dump() method.
3416
3417         * DumpRenderTree/mac/TestRunnerMac.mm:
3418         (TestRunner::notifyDone):
3419         (TestRunner::forceImmediateCompletion):
3420         * DumpRenderTree/win/TestRunnerWin.cpp:
3421         (TestRunner::notifyDone):
3422         (TestRunner::forceImmediateCompletion):
3423
3424 2019-04-15  Philippe Normand  <pnormand@igalia.com>
3425
3426         [GTK][WPE] Add enable-media websetting
3427         https://bugs.webkit.org/show_bug.cgi?id=196863
3428
3429         Reviewed by Michael Catanzaro.
3430
3431         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3432         (testWebKitSettings): Add test for the enable-media web-setting.
3433
3434 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3435
3436         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
3437         https://bugs.webkit.org/show_bug.cgi?id=196905
3438         <rdar://problem/49886096>
3439
3440         Reviewed by Tim Horton.
3441
3442         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
3443         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
3444         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
3445         delay timer, we end up with this sequence of events in the problematic (failure) case:
3446
3447         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
3448             ...IPC from UI to web process...
3449         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
3450             ...IPC from web to UI process...
3451         (c) [UI]    Invoke completion handler for script #1
3452         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
3453             ...IPC from UI to web process...
3454         (e) [Web]   Evaluate script #2 in the web process
3455         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
3456
3457         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
3458         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
3459         #2 is run in step (e).
3460
3461         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
3462         the UI process by waiting on a script message posted by the web process, after attachment updates are
3463         dispatched.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3466         (TestWebKitAPI::TEST):
3467
3468 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
3469
3470         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
3471         https://bugs.webkit.org/show_bug.cgi?id=196909
3472
3473         Reviewed by Wenson Hsieh.
3474
3475         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3476         (TestWebKitAPI::TEST):
3477
3478 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
3479
3480         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
3481         https://bugs.webkit.org/show_bug.cgi?id=196880
3482
3483         Reviewed by Yusuke Suzuki.
3484
3485         Add a new function for bytecode cache tests that does not forceDiskCache
3486         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
3487         test added in this patch, since the code is invalid and therefore won't be
3488         cached. It should also be useful for tests that evaluate dynamically
3489         generated code.
3490
3491         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3492         * Scripts/run-jsc-stress-tests:
3493
3494 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
3495
3496         Update AudioSession route sharing policy
3497         https://bugs.webkit.org/show_bug.cgi?id=196776
3498         <rdar://problem/46501611>
3499
3500         Reviewed by Jer Noble.
3501
3502         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3503         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
3504         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
3505         (TestWebKitAPI::TEST):
3506
3507 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3508
3509         [iOS] Software keyboard is shown too frequently on some websites
3510         https://bugs.webkit.org/show_bug.cgi?id=195856
3511         <rdar://problem/49191395>
3512
3513         Reviewed by Darin Adler.
3514
3515         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
3516
3517         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3518         (WTR::UIScriptController::setHardwareKeyboardAttached):
3519         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3520         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3521         (WTR::UIScriptController::setHardwareKeyboardAttached):
3522         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3523         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3524
3525         Additionally link against GraphicsServices in WebKitTestRunner.
3526
3527         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3528         (WTR::TestController::platformResetStateToConsistentValues):
3529         (WTR::UIScriptController::setHardwareKeyboardAttached):
3530
3531 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
3532
3533         [GTK][WPE] Fix pacman install-dependencies packages
3534         https://bugs.webkit.org/show_bug.cgi?id=196817
3535
3536         Reviewed by Žan Doberšek.
3537         
3538         python3-setuptools is called python-setuptools
3539         ruby-highline is only available on AUR
3540         libv4l-devel is incorporated in v4l-utils
3541
3542         * gtk/install-dependencies:
3543         * wpe/install-dependencies:
3544
3545 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3546
3547         [GTK] REGRESSION(r243860): Many tests failing
3548         https://bugs.webkit.org/show_bug.cgi?id=196791
3549
3550         Reviewed by Joanmarie Diggs.
3551
3552         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
3553         multiple documents and check that accessibility hierarchy is updated after a navigation.
3554
3555         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
3556         (loadChangedCallback):
3557         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3558         (AccessibilityTest::AccessibilityTest):
3559         (AccessibilityTest::~AccessibilityTest):
3560         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
3561         (AccessibilityTest::findTestServerApplication):
3562         (AccessibilityTest::findDocumentWeb):
3563         (AccessibilityTest::findRootObject):
3564         (AccessibilityTest::waitUntilChildrenRemoved):
3565         (AccessibilityTest::ensureProxy):
3566         (testAtspiBasicHierarchy):
3567         (beforeAll):
3568         (afterAll):
3569
3570 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3571
3572         [ews-build] Handle bug titles with unicode characters
3573         https://bugs.webkit.org/show_bug.cgi?id=196802
3574
3575         Reviewed by Dewei Zhu.
3576
3577         * BuildSlaveSupport/ews-build/steps.py:
3578         (ValidatePatch._is_bug_closed):
3579
3580 2019-04-11  Michael Saboff  <msaboff@apple.com>
3581
3582         Improve the Inline Cache Stats code
3583         https://bugs.webkit.org/show_bug.cgi?id=196836
3584
3585         Reviewed by Saam Barati.
3586
3587         Added a new script to consolidate and arrange the output of --useICStats option.
3588
3589         This script merges the output from every group into one large table and sorts it from most common to
3590         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3591         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3592         Put together, this is useful to see what property accesses are not getting cached.
3593
3594         * Scripts/ic-stats.py: Added.
3595         (ICStats):
3596         (ICStats.__init__):
3597         (ICStats.parse):
3598         (ICStats.dumpStats):
3599         (usage):
3600
3601 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3602
3603         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3604         https://bugs.webkit.org/show_bug.cgi?id=196809
3605         <rdar://49800762>
3606
3607         Reviewed by Brady Eidson.
3608
3609         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3610         (TEST):
3611
3612 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3613
3614         requestAnimationFrame should execute before the next frame
3615         https://bugs.webkit.org/show_bug.cgi?id=177484
3616
3617         Reviewed by Simon Fraser.
3618
3619         Add trace points for the page RenderingUpdate.
3620
3621         * Tracing/SystemTracePoints.plist:
3622
3623 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3624
3625         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3626         https://bugs.webkit.org/show_bug.cgi?id=196760
3627
3628         Reviewed by Don Olmstead.
3629
3630         vswhere.exe has been bundled since Visual Studio 2017 version
3631         15.2. We shouldn't download vswhere.exe.
3632
3633         * Scripts/build-jsc: Do not call update-vswhere.py.
3634         * Scripts/build-webkit: Ditto.
3635         * Scripts/update-vswhere.py: Removed.
3636         * Scripts/webkitdirs.pm:
3637         (requireModulesForVSWhere): Deleted.
3638         (pickCurrentVisualStudioInstallation): Deleted.
3639         (visualStudioInstallDirVSWhere): Return the latest installed VS
3640         installation path by using the bundled vswhere.exe.
3641         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3642         (visualStudioInstallDirFallback): Removed.
3643
3644 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3645
3646         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3647         https://bugs.webkit.org/show_bug.cgi?id=196780
3648
3649         Reviewed by Alexey Proskuryakov.
3650
3651         * BuildSlaveSupport/ews-build/steps.py:
3652         * BuildSlaveSupport/ews-build/steps_unittest.py:
3653
3654 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3655
3656         Add SPI WKNavigationResponse._downloadAttribute
3657         https://bugs.webkit.org/show_bug.cgi?id=196755
3658         <rdar://49587365>
3659