Pull IPadUserInterfaceSwizzler out into a separate header file
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Pull IPadUserInterfaceSwizzler out into a separate header file
4         https://bugs.webkit.org/show_bug.cgi?id=196193
5
6         Reviewed by Anders Carlsson.
7
8         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
9         be used in other API tests.
10
11         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
13         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
14         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
15         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
16         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
17         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
18
19 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
20
21         Remove NavigatorContentUtils in WebCore/Modules
22         https://bugs.webkit.org/show_bug.cgi?id=196070
23
24         Reviewed by Alex Christensen.
25
26         NavigatorContentUtils was to support the custom scheme spec [1].
27         However, in WebKit side, no port has supported the feature in
28         WebKit layer after EFL port was removed. So there has been the
29         only IDL implementation of the NavigatorContentUtils in WebCore.
30         So we don't need to keep the implementation in WebCore anymore.
31
32         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
33
34         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
35
36 2019-03-24  Andy Estes  <aestes@apple.com>
37
38         [watchOS] Remove unused Proximity Networking code
39         https://bugs.webkit.org/show_bug.cgi?id=196188
40
41         Reviewed by Tim Horton.
42
43         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
44         (TEST):
45
46 2019-03-23  Keith Miller  <keith_miller@apple.com>
47
48         Refactor clz/ctz and fix getLSBSet.
49         https://bugs.webkit.org/show_bug.cgi?id=196162
50
51         Reviewed by Saam Barati.
52
53         Add tests for clz, ctz, getLSBSet, and getMSBSet.
54
55         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
56         (TestWebKitAPI::TEST):
57
58 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
59
60         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
61         https://bugs.webkit.org/show_bug.cgi?id=196143
62
63         Reviewed by Michael Catanzaro.
64
65         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
66         directories.
67
68         * Scripts/webkitpy/style/checkers/cpp.py:
69         (check_identifier_name_in_declaration):
70         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
71         (WebKitStyleTest.test_names):
72
73 2019-03-22  Philippe Normand  <pnormand@igalia.com>
74
75         [Flatpak] Manifest expanding fails for qt WPE extension
76         https://bugs.webkit.org/show_bug.cgi?id=196148
77
78         Reviewed by Alex Christensen.
79
80         * flatpak/flatpakutils.py:
81         (expand_submodules_recurse): The last recurse manifest expand
82         iteration might lead to a single module so take it into account
83         and don't try to recurse further.
84
85 2019-03-22  Chris Dumez  <cdumez@apple.com>
86
87         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
88         https://bugs.webkit.org/show_bug.cgi?id=195348
89         <rdar://problem/48622090>
90
91         Reviewed by Alex Christensen.
92
93         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
94         to NO when test.options().shouldIgnoreMetaViewport is false.
95
96         * WebKitTestRunner/ios/TestControllerIOS.mm:
97         (WTR::TestController::platformConfigureViewForTest):
98
99 2019-03-22  Chris Dumez  <cdumez@apple.com>
100
101         Prewarmed processes should be usable with any website data store
102         https://bugs.webkit.org/show_bug.cgi?id=196104
103
104         Reviewed by Alex Christensen.
105
106         Add API test coverage.
107
108         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
109         (runInitialWarmedProcessUsedTest):
110         (TEST):
111
112 2019-03-22  David Kilzer  <ddkilzer@apple.com>
113
114         Back out local changes to Alex's Subversion working directory
115
116         They were accidentally committed.
117
118         * Scripts/webkitpy/common/system/abstractexecutive.py:
119         (AbstractExecutive.wait_newest):
120         * Scripts/webkitpy/common/system/executive.py:
121         (Executive.running_pids):
122         * Scripts/webkitpy/common/system/executive_mock.py:
123         (MockExecutive.running_pids):
124         * Scripts/webkitpy/common/system/executive_unittest.py:
125         (ExecutiveTest.serial_test_running_pids):
126         * Scripts/webkitpy/port/darwin.py:
127         (DarwinPort.check_for_leaks):
128         * Scripts/webkitpy/port/leakdetector.py:
129         (LeakDetector.check_for_leaks):
130         - This was the hack attached to Bug 193772.
131
132         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
133         (+[WebKitTestRunnerEvent mouseLocation]):
134         - This works around a crash on an internal build.
135
136 2019-03-22  Tim Horton  <timothy_horton@apple.com>
137
138         Fix the build after r243354
139         https://bugs.webkit.org/show_bug.cgi?id=196138
140         <rdar://problem/49145951>
141
142         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
143         (TEST):
144         * TestWebKitAPI/ios/UIKitSPI.h:
145
146 2019-03-21  Tim Horton  <timothy_horton@apple.com>
147
148         Adopt UIWKDocumentContext
149         https://bugs.webkit.org/show_bug.cgi?id=196040
150         <rdar://problem/48642440>
151
152         Reviewed by Ryosuke Niwa.
153
154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
155         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
156         (makeRequest):
157         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
158         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
159         (applyStyle):
160         (TEST):
161         Add tests for UIWKDocumentContext.
162
163         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
164         (TEST):
165         (recursiveFindWKContentView): Deleted.
166         * TestWebKitAPI/cocoa/TestWKWebView.h:
167         * TestWebKitAPI/cocoa/TestWKWebView.mm:
168         (recursiveFindWKContentView):
169         (-[TestWKWebView wkContentView]):
170         * TestWebKitAPI/ios/UIKitSPI.h:
171         Share the WKContentView finding code between tests.
172
173 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
174
175         [iOS WK2] Turn on async overflow scrolling by default
176         https://bugs.webkit.org/show_bug.cgi?id=196011
177         rdar://problem/48453859
178
179         Reviewed by Antti Koivisto.
180         
181         Explicitly turn off the async overflow scrolling internal feature for tests by default,
182         since so many basic layout tests have different results when compositing is triggered for
183         overflow.
184         
185         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
186
187         * WebKitTestRunner/TestController.cpp:
188         (WTR::TestController::resetPreferencesToConsistentValues):
189
190 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
191
192         [ews-build] Retry API test in case of failures
193         https://bugs.webkit.org/show_bug.cgi?id=196004
194
195         Reviewed by Lucas Forschler.
196
197         * BuildSlaveSupport/ews-build/steps.py:
198         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
199         (CompileWebKitToT.doStepIf): Ditto.
200         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
201         (ReRunAPITests): Re-run API tests.
202         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
203         (RunAPITestsWithoutPatch): Run API tests without patch.
204         (RunAPITestsWithoutPatch.doStepIf):
205         (RunAPITestsWithoutPatch.hideStepIf):
206         (RunAPITestsWithoutPatch.evaluateCommand):
207         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
208         (AnalyzeAPITestsResults.start):
209         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
210         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
211         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
212         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
213
214 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
215
216         [ews-build] Update queues configurations
217         https://bugs.webkit.org/show_bug.cgi?id=196074
218
219         Reviewed by Dewei Zhu.
220
221         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
222         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
223
224 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
225
226         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
227         https://bugs.webkit.org/show_bug.cgi?id=195680
228         <rdar://problem/48903534>
229
230         Unreviewed infrastructure fix.
231
232         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
233         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
234
235 2019-03-21  Andy Estes  <aestes@apple.com>
236
237         [iOS] Apple Pay should be available in documents with no user agent scripts
238         https://bugs.webkit.org/show_bug.cgi?id=196061
239         <rdar://problem/48649391>
240
241         Reviewed by Brady Eidson.
242
243         Added API tests and related infrastructure.
244
245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
246         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
247         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
248         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
249         (TestWebKitAPI::TEST):
250         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
251         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
252         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
253         * TestWebKitAPI/cocoa/TestProtocol.mm:
254         (-[TestProtocol startLoading]):
255         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
256         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
257         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
258         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
259
260 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
261
262         REGRESSSION (r243297): webkitpy tests broken
263         https://bugs.webkit.org/show_bug.cgi?id=196108
264
265         Reviewed by Aakash Jain.
266
267         r243297 updated contributors.json, which broke a few unit tests.
268
269         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
270         (IRCCommandTest.test_whois):
271         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
272
273 2019-03-21  Chris Dumez  <cdumez@apple.com>
274
275         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
276         https://bugs.webkit.org/show_bug.cgi?id=196041
277         <rdar://problem/49083230>
278
279         Reviewed by Alex Christensen.
280
281         Add API test coverage.
282
283         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
284         (TEST):
285
286 2019-03-21  Alex Christensen  <achristensen@webkit.org>
287
288         Add SPI to inform applications of WKContentRuleList actions
289         https://bugs.webkit.org/show_bug.cgi?id=195965
290         <rdar://problem/42664365>
291
292         Reviewed by Geoff Garen.
293
294         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
295         (TestWebKitAPI::allActionsForResourceLoad):
296         (TestWebKitAPI::testRequest):
297         (TestWebKitAPI::TEST_F):
298         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
299         (Notification::description):
300         (Notification::operator== const):
301         (toVector):
302         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
303         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
304         (makeContentRuleList):
305         (TEST):
306         (makeWarnContentRuleList): Deleted.
307
308 2019-03-21  Timothy Hatcher  <timothy@apple.com>
309
310         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
311         https://bugs.webkit.org/show_bug.cgi?id=196088
312
313         Reviewed by Brian Burg.
314
315         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
316         Support checks when only one platform is specified. Also deprecate macosx() and
317         force the use of macos() instead.
318
319         * Scripts/webkitpy/style/checkers/cpp.py:
320         (check_min_versions_of_wk_api_available):
321         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
322         (WebKitStyleTest.test_min_versions_of_wk_api_available):
323
324 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
325
326         Update status inactive committers' status to 'contributor'.
327
328         * Scripts/webkitpy/common/config/contributors.json:
329
330 2019-03-21  Xan Lopez  <xan@igalia.com>
331
332         [JSC][x86] Drop support for x87 floating point
333         https://bugs.webkit.org/show_bug.cgi?id=194853
334
335         Reviewed by Don Olmstead.
336
337         Force SSE2 on x86/32bit builds.
338
339         * Scripts/webkitdirs.pm:
340         (generateBuildSystemFromCMakeProject):
341
342 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
343
344         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
345         https://bugs.webkit.org/show_bug.cgi?id=196073
346
347         Reviewed by Michael Catanzaro.
348
349         Add test cases to check functions and constructors with no arguments but receiving user data.
350
351         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
352         (checkUserData):
353         (testJSCFunction):
354         (fooCreateWithUserData):
355         (testJSCClass):
356
357 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
358
359         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
360
361         Add g_assert_cmpfloat_with_epsilon macro if not defined.
362
363         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
364
365 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
366
367         [GTK][WPE] Add API to provide geolocation information
368         https://bugs.webkit.org/show_bug.cgi?id=195940
369
370         Reviewed by Michael Catanzaro.
371
372         Add a new test to check the new API.
373
374         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
375         (testGeolocationManagerCurrentPosition):
376         (testGeolocationManagerWatchPosition):
377         (beforeAll):
378         (afterAll):
379         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
380         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
381         (beforeAll): Ditto.
382         * TestWebKitAPI/glib/CMakeLists.txt:
383
384 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
385
386         [GLib] Returning G_TYPE_OBJECT from a method does not work
387         https://bugs.webkit.org/show_bug.cgi?id=195574
388
389         Reviewed by Michael Catanzaro.
390
391         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
392
393         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
394         (getGFile):
395         (getParent):
396         (createGString):
397         (getGString):
398         (getGStringCopyWillRaise):
399         (getGStringCopy):
400         (getGStringStr):
401         (getGStringLen):
402         (freeGString):
403         (testJSCClass):
404
405 2019-03-20  Saam Barati  <sbarati@apple.com>
406
407         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
408         https://bugs.webkit.org/show_bug.cgi?id=195721
409
410         Reviewed by Filip Pizlo.
411
412         * Scripts/run-javascriptcore-tests:
413
414 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
415
416         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
417         https://bugs.webkit.org/show_bug.cgi?id=196049
418
419         Reviewed by Tim Horton.
420
421         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
422         overflow scrolling in general, so rename it.
423
424         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
425
426 2019-03-20  Daniel Bates  <dabates@apple.com>
427
428         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
429         https://bugs.webkit.org/show_bug.cgi?id=196031
430         <rdar://problem/49078172>
431
432         Reviewed by Tim Horton.
433
434         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
435         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
436         same code path used when the Done button is pressed to dismiss the <select> picker.
437
438         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
439         (TestWebKitAPI::TEST):
440
441 2019-03-20  Chris Dumez  <cdumez@apple.com>
442
443         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
444         https://bugs.webkit.org/show_bug.cgi?id=196029
445         <rdar://problem/48954651>
446
447         Reviewed by Tim Horton.
448
449         Add API test coverage.
450
451         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
452
453 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
454
455         [ews-build] Improve failure summary string for ApplyPatch step
456         https://bugs.webkit.org/show_bug.cgi?id=195995
457
458         Reviewed by Alexey Proskuryakov.
459
460         * BuildSlaveSupport/ews-build/steps.py:
461         (ApplyPatch.getResultSummary): Override getResultSummary.
462
463 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
464
465         AX: Implement support for new meter ARIA role
466         https://bugs.webkit.org/show_bug.cgi?id=195966
467
468         Reviewed by Chris Fleizach.
469
470         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
471         to AXLevelIndicator.
472
473         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
474
475 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
476
477         [WebAuthN] Implement FIDO AppID extension
478         https://bugs.webkit.org/show_bug.cgi?id=143491
479         <rdar://problem/48298273>
480
481         Reviewed by Brent Fulgham.
482
483         Add a test that covers the new flag of convertToU2fSignCommand.
484
485         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
486         (TestWebKitAPI::TEST):
487         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
488         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
489         (TestWebKitAPI::TEST):
490
491 2019-03-19  Keith Rollin  <krollin@apple.com>
492
493         Add support for more platforms to generate-xcfilelists
494         https://bugs.webkit.org/show_bug.cgi?id=195977
495
496         Reviewed by Alexey Proskuryakov.
497
498         generate-xcfilelists incorrectly complains when involved with building
499         WebKit for iphonesimulator:
500
501             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
502             …
503             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
504
505         Address this by teaching generate-xcfilelists about more platforms.
506
507         * Scripts/generate-xcfilelists:
508
509 2019-03-19  John Wilander  <wilander@apple.com>
510
511         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
512         https://bugs.webkit.org/show_bug.cgi?id=195923
513         <rdar://problem/49001272>
514
515         Reviewed by Alex Christensen.
516
517         This patch does the following to the TestRunner:
518         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
519         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
520         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
521
522         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
523         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
524         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
525         * WebKitTestRunner/InjectedBundle/TestRunner.h:
526         * WebKitTestRunner/TestController.cpp:
527         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
528         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
529         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
530         * WebKitTestRunner/TestController.h:
531         * WebKitTestRunner/TestInvocation.cpp:
532         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
533
534 2019-03-19  Christopher Reid  <chris.reid@sony.com>
535
536         [CMake] Support more clang and gcc sanitizers
537         https://bugs.webkit.org/show_bug.cgi?id=195956
538
539         Reviewed by Michael Catanzaro.
540
541         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
542
543 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
544
545         [ews-build] Improve summary for PrintConfiguration step
546         https://bugs.webkit.org/show_bug.cgi?id=195945
547
548         Reviewed by Lucas Forschler.
549
550         * BuildSlaveSupport/ews-build/steps.py:
551         (PrintConfiguration.getResultSummary): Override getResultSummary.
552
553 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
554
555         [ews-build] Improve summary for CheckOutSource step
556         https://bugs.webkit.org/show_bug.cgi?id=195963
557
558         Reviewed by Lucas Forschler.
559
560         * BuildSlaveSupport/ews-build/steps.py:
561         (CheckOutSource.getResultSummary):
562
563 2019-03-19  Daniel Bates  <dabates@apple.com>
564
565         [iOS] Focus not preserved when switching between tabs
566         https://bugs.webkit.org/show_bug.cgi?id=195820
567         <rdar://problem/43614450>
568
569         Reviewed by Brent Fulgham.
570
571         Add tests to ensure that we restore focus when resigning and becoming first responder.
572
573         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
574         (TestWebKitAPI::TEST):
575
576 2019-03-19  Alex Christensen  <achristensen@webkit.org>
577
578         Make WTFLogChannelState and WTFLogLevel enum classes
579         https://bugs.webkit.org/show_bug.cgi?id=195904
580
581         Reviewed by Eric Carlson.
582
583         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
584         (TestWebKitAPI::TEST_F):
585
586 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
587
588         [GStreamer][EME] Backported mssdemux protection data crash fix
589         https://bugs.webkit.org/show_bug.cgi?id=195918
590
591         Reviewed by Philippe Normand.
592
593         * gstreamer/jhbuild.modules:
594         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
595
596 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
597
598         Unreviewed, rolling out r243132.
599
600         Broke GTK build
601
602         Reverted changeset:
603
604         "Make WTFLogChannelState and WTFLogLevel enum classes"
605         https://bugs.webkit.org/show_bug.cgi?id=195904
606         https://trac.webkit.org/changeset/243132
607
608 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
609
610         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
611
612         * Scripts/webkitdirs.pm:
613         (builtDylibPathForName): Adjust the shared library name that's changed
614         with the API version bump in r243073.
615
616 2019-03-18  Alex Christensen  <achristensen@webkit.org>
617
618         Make WTFLogChannelState and WTFLogLevel enum classes
619         https://bugs.webkit.org/show_bug.cgi?id=195904
620
621         Reviewed by Eric Carlson.
622
623         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
624         (TestWebKitAPI::TEST_F):
625
626 2019-03-18  Alex Christensen  <achristensen@webkit.org>
627
628         Disable flaky test added in r2431100
629         https://webkit.org/b/195785
630
631         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
632         (TestWebKitAPI::TEST):
633         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
634
635 2019-03-18  Timothy Hatcher  <timothy@apple.com>
636
637         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
638         https://bugs.webkit.org/show_bug.cgi?id=195916
639
640         Reviewed by Tim Horton.
641
642         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
643         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
644
645 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
646
647         Add a secondary e-mail address for Fujii Hironori to make tools happier.
648
649         * Scripts/webkitpy/common/config/contributors.json:
650
651 2019-03-18  Alex Christensen  <achristensen@webkit.org>
652
653         Implement DownloadMonitor to prevent long-running slow downloads from background apps
654         https://bugs.webkit.org/show_bug.cgi?id=195785
655
656         Reviewed by Geoffrey Garen.
657
658         * TestWebKitAPI/TCPServer.cpp: Added.
659         (TestWebKitAPI::TCPServer::TCPServer):
660         (TestWebKitAPI::TCPServer::~TCPServer):
661         (TestWebKitAPI::TCPServer::socketBindListen):
662         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
663         * TestWebKitAPI/TCPServer.h: Added.
664         (TestWebKitAPI::TCPServer::port const):
665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
666         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
667         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
668         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
669         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
670         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
671         (TestWebKitAPI::respondSlowly):
672         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
673         (TestWebKitAPI::downloadAtRate):
674         (TestWebKitAPI::TEST):
675
676 2019-03-18  Saam Barati  <sbarati@apple.com>
677
678         Add a plan file for JetStream 2
679         https://bugs.webkit.org/show_bug.cgi?id=190734
680
681         Reviewed by Mark Lam.
682
683         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
684
685 2019-03-18  Chris Dumez  <cdumez@apple.com>
686
687         Delay WebProcess launch until a load is triggered in a Web view
688         https://bugs.webkit.org/show_bug.cgi?id=195758
689         <rdar://problem/48126013>
690
691         Reviewed by Geoff Garen.
692
693         Add API test coverage. Also update some existing API tests to not expect
694         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
695
696         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
697         (TestWebKitAPI::TEST):
698         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
699         (TestWebKitAPI::TEST):
700         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
701         (TEST):
702         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
703         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
704         (TEST):
705         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
706         (TEST):
707         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
708
709 2019-03-18  Xan Lopez  <xan@igalia.com>
710
711         [CMake] Prevent potential warning when determining $architecture
712         https://bugs.webkit.org/show_bug.cgi?id=195891
713
714         Reviewed by Michael Catanzaro.
715
716         It's possible for generateBuildSystemForCMakeProject to be called
717         before determineArchitecture() is ever called. This will make the
718         first eq check with $architecture to be bogus (and print a
719         warning). Change that to an eq check with architecture(), which
720         implicitly calls determineArchitecture() if needed, and change all
721         the other similar cases in the method in the same way to prevent
722         future bugs like this one.
723
724         * Scripts/webkitdirs.pm:
725         (generateBuildSystemFromCMakeProject):
726
727 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
728
729         [WPE] Tarballs generated with “make dist” cannot build documentation
730         https://bugs.webkit.org/show_bug.cgi?id=195885
731
732         Reviewed by Carlos Garcia Campos.
733
734         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
735
736 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
737
738         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
739         https://bugs.webkit.org/show_bug.cgi?id=195883
740
741         Reviewed by Carlos Garcia Campos.
742
743         * gtkdoc/gtkdoc.py:
744         (GTKDoc._run_command): When commands fail to run, include the full command line for
745         the program invocation and the output it has generated on the standard error stream.
746
747 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
748
749         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
750         https://bugs.webkit.org/show_bug.cgi?id=195786
751
752         Reviewed by Philippe Normand.
753
754         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
755         * wpe/jhbuild.modules: Ditto.
756
757 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
758
759         [ews-build] Don't run clean builds on EWS builders
760         https://bugs.webkit.org/show_bug.cgi?id=195851
761
762         Reviewed by Geoffrey Garen.
763
764         * BuildSlaveSupport/ews-build/factories.py:
765
766 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
767
768         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
769         https://bugs.webkit.org/show_bug.cgi?id=195849
770
771         Reviewed by Chris Dumez.
772
773         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
774
775         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
776         (runWebsiteDataStoreCustomPaths):
777
778 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
779
780         webkitpy: Upload test results
781         https://bugs.webkit.org/show_bug.cgi?id=195755
782         <rdar://problem/48896182>
783
784         Reviewed by Aakash Jain.
785
786         Establish a new format for uploading results that is not tied to layout tests, apply
787         that format to webkitpy tests.
788
789         * Scripts/webkitpy/common/checkout/scm/git.py:
790         (Git.native_branch): Return what branch the current checkout is on.
791         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
792         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
793         * Scripts/webkitpy/common/checkout/scm/svn.py:
794         (SVN.native_branch): Ditto.
795         * Scripts/webkitpy/common/system/platforminfo.py:
796         (PlatformInfo.build_version): Return a build version for Mac.
797         * Scripts/webkitpy/common/system/platforminfo_mock.py:
798         (MockPlatformInfo.__init__):
799         (MockPlatformInfo.build_version):
800         * Scripts/webkitpy/results: Added.
801         * Scripts/webkitpy/results/__init__.py: Added.
802         * Scripts/webkitpy/results/options.py: Added.
803         (upload_options): OptParse list for upload options.
804         * Scripts/webkitpy/results/upload.py: Added.
805         (Upload): Class which enforces the upload format expected by the results server.
806         (Upload.Expectations):
807         (Upload.create_configuration):
808         (Upload.create_commit):
809         (Upload.create_details):
810         (Upload.create_run_stats):
811         (Upload.create_test_result):
812         (Upload.__init__):
813         (Upload.Encoder): Encode Upload object as json.
814         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
815         * Scripts/webkitpy/results/upload_unittest.py: Added.
816         * Scripts/webkitpy/test/main.py:
817         (Tester._parse_args): Add upload arguments.
818         (Tester._run_tests): Allow results to be uploaded.
819         * Scripts/webkitpy/test/runner.py:
820         (Runner.__init__): Record which tests were run, rather than just counting them.
821         (Runner.handle):
822         * Scripts/webkitpy/test/runner_unittest.py:
823         (RunnerTest.test_run):
824         * Scripts/webkitpy/thirdparty/__init__.py:
825         (AutoinstallImportHook.find_module): Add requests auto-install.
826         (AutoinstallImportHook._install_requests):
827         * Scripts/webkitpy/tool/commands/queues_unittest.py:
828         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
829
830 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
831
832         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
833         https://bugs.webkit.org/show_bug.cgi?id=195810
834
835         Reviewed by Tim Horton.
836
837         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
838         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
839         ending certain layout tests.
840
841         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
842         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
843         (-[TestRunnerWKWebView dealloc]):
844         (-[TestRunnerWKWebView resetInteractionCallbacks]):
845
846         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
847         helper method when destroying the web view, and when resetting state between tests.
848
849         * WebKitTestRunner/ios/TestControllerIOS.mm:
850         (WTR::TestController::platformResetStateToConsistentValues):
851
852         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
853
854 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
855
856         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
857         https://bugs.webkit.org/show_bug.cgi?id=190350
858         <rdar://problem/45089503>
859
860         Reviewed by Geoffrey Garen.
861
862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
863         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
864         (TEST):
865         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
866         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
867         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
868         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
869         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
870         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
871         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
872         (runTest):
873         (createDirectories):
874         (TEST):
875         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
876         (TEST):
877         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
878         (TEST):
879
880 2019-03-15  Timothy Hatcher  <timothy@apple.com>
881
882         Add support to WebPage for getting the contents as an attributed string.
883         https://bugs.webkit.org/show_bug.cgi?id=195636
884         rdar://problem/45055697
885
886         Reviewed by Tim Horton.
887
888         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
889         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
890
891 2019-03-15  Chris Dumez  <cdumez@apple.com>
892
893         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
894         https://bugs.webkit.org/show_bug.cgi?id=195747
895
896         Reviewed by Geoff Garen.
897
898         Add API test coverage.
899
900         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
901
902 2019-03-15  Shawn Roberts  <sroberts@apple.com>
903
904         Unreviewed, rolling out r242952.
905
906         Causing API failures on iOS Simulator
907
908         Reverted changeset:
909
910         "[PSON] Make sure the WebProcessCache is leverage when
911         relaunching a process after termination"
912         https://bugs.webkit.org/show_bug.cgi?id=195747
913         https://trac.webkit.org/changeset/242952
914
915 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
916
917         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
918         https://bugs.webkit.org/show_bug.cgi?id=195740
919
920         Reviewed by Ross Kirsling.
921
922         window.open doesn't work for WebKitBrowserWindow because it is not
923         implemented yet.
924
925         1. Implemented createNewPage callback of WKPageUIClient.
926         2. Changed MainWindow to take a BrowserWindow factory function
927           instead of BrowserWindowType to be flexible to create
928           BrowserWindow with extra settings.
929         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
930           because it is not relevant with MainWindow anymore.
931
932         * MiniBrowser/win/Common.cpp:
933         (parseCommandLine):
934         * MiniBrowser/win/Common.h:
935         (CommandLineOptions::CommandLineOptions):
936         * MiniBrowser/win/MainWindow.cpp:
937         (MainWindow::MainWindow):
938         (MainWindow::create):
939         (MainWindow::init):
940         (MainWindow::WndProc):
941         * MiniBrowser/win/MainWindow.h:
942         * MiniBrowser/win/PrintWebUIDelegate.cpp:
943         (PrintWebUIDelegate::createWebViewWithRequest):
944         * MiniBrowser/win/WebKitBrowserWindow.cpp:
945         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
946         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
947         (WebKitBrowserWindow::updateProxySettings):
948         (WebKitBrowserWindow::createNewPage):
949         * MiniBrowser/win/WebKitBrowserWindow.h:
950         * MiniBrowser/win/WinMain.cpp:
951         (wWinMain):
952
953 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
954
955         Make it possible to test scrolling tree layer manipulation more easily
956         https://bugs.webkit.org/show_bug.cgi?id=195780
957
958         Reviewed by Tim Horton.
959         
960         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
961         cuts off communication of scrolling tree scrolls back to the web process
962         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
963         allows tests to trigger scrolls which run the scrolling tree layer positioning
964         logic, but never get another commit from the web process that might mask
965         scrolling tree bugs.
966         
967         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
968         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
969         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
970
971         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
972         (WTR::UIScriptController::scrollUpdatesDisabled const):
973         (WTR::UIScriptController::setScrollUpdatesDisabled):
974         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
975         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
976         (WTR::UIScriptController::scrollUpdatesDisabled const):
977         (WTR::UIScriptController::setScrollUpdatesDisabled):
978         * TestRunnerShared/UIScriptContext/UIScriptController.h:
979         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
980         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
981         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
982         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
983         * WebKitTestRunner/ios/TestControllerIOS.mm:
984         (WTR::TestController::platformResetStateToConsistentValues):
985         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
986         (WTR::UIScriptController::scrollUpdatesDisabled const):
987         (WTR::UIScriptController::setScrollUpdatesDisabled):
988
989 2019-03-14  Youenn Fablet  <youenn@apple.com>
990
991         Move IDB storage in private browsing mode to NetworkProcess
992         https://bugs.webkit.org/show_bug.cgi?id=195602
993
994         Reviewed by Brady Eidson.
995
996         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
997         (TEST):
998
999 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1000
1001         [ews-build] Make descriptionDone messages more readable
1002         https://bugs.webkit.org/show_bug.cgi?id=195760
1003
1004         Reviewed by Lucas Forschler.
1005
1006         * BuildSlaveSupport/ews-build/steps.py:
1007         * BuildSlaveSupport/ews-build/steps_unittest.py:
1008
1009 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1010
1011         [ews-build] Generate status-bubble hover-over messages
1012         https://bugs.webkit.org/show_bug.cgi?id=195680
1013
1014         Reviewed by Lucas Forschler.
1015
1016         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1017         (StatusBubble):
1018         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1019         on hover-over.
1020         (StatusBubble._iso_time):
1021         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1022         hover-over message.
1023         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1024
1025 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1026
1027         [ews-app] Gracefully handle the case when state_string is None
1028         https://bugs.webkit.org/show_bug.cgi?id=195753
1029
1030         Reviewed by Lucas Forschler.
1031
1032         * BuildSlaveSupport/ews-app/ews/models/build.py:
1033         * BuildSlaveSupport/ews-app/ews/models/step.py:
1034
1035 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1036
1037         [ews-app] Status bubble display pending for currently running build step
1038         https://bugs.webkit.org/show_bug.cgi?id=195744
1039
1040         Reviewed by Lucas Forschler.
1041
1042         * BuildSlaveSupport/ews-build/events.py:
1043         (Events.stepStarted): If state_string is pending, replace it with step name.
1044
1045 2019-03-14  Chris Dumez  <cdumez@apple.com>
1046
1047         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1048         https://bugs.webkit.org/show_bug.cgi?id=195750
1049
1050         Reviewed by Geoffrey Garen.
1051
1052         Add API test coverage.
1053
1054         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1055         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1056         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1057         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1058
1059 2019-03-14  Chris Dumez  <cdumez@apple.com>
1060
1061         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1062         https://bugs.webkit.org/show_bug.cgi?id=195747
1063
1064         Reviewed by Geoff Garen.
1065
1066         Add API test coverage.
1067
1068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1069
1070 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1071
1072         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1073         https://bugs.webkit.org/show_bug.cgi?id=195725
1074         <rdar://problem/48545062>
1075
1076         Reviewed by Tim Horton.
1077
1078         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1079         handler is nil.
1080
1081         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1082         (TestWebKitAPI::TEST):
1083
1084 2019-03-13  Sam Weinig  <sam@webkit.org>
1085
1086         Add utility function to allow easy reverse range-based iteration of a container
1087         https://bugs.webkit.org/show_bug.cgi?id=195542
1088
1089         Reviewed by Antti Koivisto.
1090
1091         * TestWebKitAPI/CMakeLists.txt:
1092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1093         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1094         (TestWebKitAPI::TEST):
1095         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1096
1097 2019-03-13  Chris Dumez  <cdumez@apple.com>
1098
1099         Use a ServiceWorker process per registrable domain
1100         https://bugs.webkit.org/show_bug.cgi?id=195649
1101
1102         Reviewed by Youenn Fablet.
1103
1104         Update API test coverage.
1105
1106         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1107
1108 2019-03-13  Chris Dumez  <cdumez@apple.com>
1109
1110         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1111         https://bugs.webkit.org/show_bug.cgi?id=195684
1112         <rdar://problem/48294714>
1113
1114         Reviewed by Antti Koivisto.
1115
1116         Add API test coverage.
1117
1118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1119
1120 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1121
1122         [ews-app] Remove unused patch view
1123         https://bugs.webkit.org/show_bug.cgi?id=195669
1124
1125         Reviewed by Lucas Forschler.
1126
1127         * BuildSlaveSupport/ews-app/ews/urls.py:
1128         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1129
1130 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1131
1132         [ews-app] Use Buildbot result code variables
1133         https://bugs.webkit.org/show_bug.cgi?id=195668
1134
1135         Reviewed by Alexey Proskuryakov.
1136
1137         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1138         (Buildbot): Added Buildbot result code variables.
1139         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1140         (StatusBubble._build_bubble): Used Buildbot result code variables.
1141
1142 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1143
1144         [Flatpak] Expand submodule recursively
1145         https://bugs.webkit.org/show_bug.cgi?id=195672
1146
1147         Building WPE with flatpak was impossible without that as it was raising an exception.
1148         Also update wpebackend-fdo to match what is built in jhbuild
1149
1150         Reviewed by Philippe Normand.
1151
1152         * flatpak/flatpakutils.py:
1153         (expand_submodules_recurse):
1154         (expand_manifest):
1155         * flatpak/org.webkit.WPEModules.yaml:
1156
1157 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1158
1159         [ews-app] status bubble should be hidden for certain builds
1160         https://bugs.webkit.org/show_bug.cgi?id=194597
1161
1162         Reviewed by Dewei Zhu.
1163
1164         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1165         (StatusBubble._build_bubble):
1166         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1167         because the patch didn't have relevant changes.
1168         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1169         in production yet.
1170
1171 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1172
1173         [Win] Fix a slew of simple clang-cl warnings.
1174         https://bugs.webkit.org/show_bug.cgi?id=195652
1175
1176         Reviewed by Don Olmstead.
1177
1178         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1179         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1180
1181 2019-03-12  Justin Fan  <justin_fan@apple.com>
1182
1183         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1184         https://bugs.webkit.org/show_bug.cgi?id=195518
1185         <rdar://problem/46322356>
1186
1187         Reviewed by Myles C. Maxfield.
1188
1189         * DumpRenderTree/DerivedSources-input.xcfilelist:
1190         * DumpRenderTree/DerivedSources-output.xcfilelist:
1191
1192 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1193
1194         Unreviewed, rolling out r242825.
1195         https://bugs.webkit.org/show_bug.cgi?id=195648
1196
1197         "Broke webkitpy tests with my change to
1198         lldb_dump_class_layout.py" (Requested by rmorisset on
1199         #webkit).
1200
1201         Reverted changeset:
1202
1203         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1204         classes with suspicious padding"
1205         https://bugs.webkit.org/show_bug.cgi?id=195573
1206         https://trac.webkit.org/changeset/242825
1207
1208 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1209
1210         [ews-build] Show status bubbles while the patch is waiting in queue
1211         https://bugs.webkit.org/show_bug.cgi?id=195618
1212
1213         Reviewed by Lucas Forschler.
1214
1215         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1216         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1217         enabled in initial deployment.
1218         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1219         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1220         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1221         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1222         (StatusBubble._build_bubbles_for_patch):
1223
1224 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1225
1226         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1227         https://bugs.webkit.org/show_bug.cgi?id=195573
1228
1229         Reviewed by Simon Fraser.
1230
1231         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1232
1233         * Scripts/dump-class-layout:
1234         (main):
1235         * lldb/lldb_dump_class_layout.py:
1236         (ClassLayout.__init__):
1237         (ClassLayout._compute_padding_recursive):
1238         (LLDBDebuggerInstance.dump_layout_for_classname):
1239         (LLDBDebuggerInstance):
1240         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1241         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1242
1243 2019-03-12  Chris Dumez  <cdumez@apple.com>
1244
1245         Device Orientation access permission should be denied unless explicitly granted by the client
1246         https://bugs.webkit.org/show_bug.cgi?id=195625
1247
1248         Reviewed by Youenn Fablet.
1249
1250         add API test coverage.
1251
1252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1253         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1254         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1255         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1256         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1257         (runDeviceOrientationTest):
1258         (TEST):
1259         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1260         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1261
1262 2019-03-12  Jer Noble  <jer.noble@apple.com>
1263
1264         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1265         https://bugs.webkit.org/show_bug.cgi?id=195137
1266         <rdar://problem/48810307>
1267
1268         Reviewed by Eric Carlson.
1269
1270         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1271         (TestWebKitAPI::TEST):
1272
1273 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1274
1275         [ews-build] Change urls from uat to production
1276         https://bugs.webkit.org/show_bug.cgi?id=195566
1277
1278         Reviewed by Lucas Forschler.
1279
1280         * BuildSlaveSupport/ews-app/ews/config.py:
1281         * BuildSlaveSupport/ews-build/events.py:
1282         * BuildSlaveSupport/ews-build/steps.py:
1283
1284 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1285
1286         [ews-build] change max_builds for local-worker to 1
1287         https://bugs.webkit.org/show_bug.cgi?id=195568
1288
1289         Reviewed by Lucas Forschler.
1290
1291         * BuildSlaveSupport/ews-build/loadConfig.py:
1292
1293 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1294
1295         Fix the build
1296
1297         * TestRunnerShared/spi/PencilKitTestSPI.h:
1298         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1299
1300 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1301
1302         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1303         https://bugs.webkit.org/show_bug.cgi?id=194131
1304
1305         Reviewed by Michael Catanzaro.
1306
1307         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1308         (uriChanged):
1309         (testUnfinishedSubresourceLoad):
1310         (serverCallback):
1311         (beforeAll):
1312
1313 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1314
1315         WTF::Expected should use std::addressof instead of operator&
1316         https://bugs.webkit.org/show_bug.cgi?id=195604
1317
1318         Reviewed by Myles Maxfield.
1319
1320         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1321         (TestWebKitAPI::Unique::Unique):
1322         (TestWebKitAPI::Unique::operator&):
1323         (TestWebKitAPI::TEST):
1324
1325 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
1326
1327         Add Optional to Forward.h.
1328         https://bugs.webkit.org/show_bug.cgi?id=195586
1329
1330         Reviewed by Darin Adler.
1331
1332         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
1333         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1334         Remove unnecessary includes from headers.
1335
1336 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
1337
1338         Add testing API to hit-test and scroll overflow scrollers
1339         https://bugs.webkit.org/show_bug.cgi?id=195278
1340
1341         Reviewed by Antti Koivisto.
1342         
1343         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
1344         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
1345         
1346         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
1347
1348         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1349         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1350         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1351         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1352         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1353         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1354         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1355         (WTR::enclosingScrollViewIncludingSelf):
1356         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1357
1358 2019-03-11  Tim Horton  <timothy_horton@apple.com>
1359
1360         API test WebKit.RequestTextInputContext fails on iOS
1361         https://bugs.webkit.org/show_bug.cgi?id=195585
1362
1363         Reviewed by Wenson Hsieh and Simon Fraser.
1364
1365         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1366         (applyStyle):
1367         (TEST):
1368         Add a viewport, so that the coordinates match up on iOS.
1369         Scroll by moving the UIScrollView's contentOffset.
1370
1371 2019-03-11  Chris Dumez  <cdumez@apple.com>
1372
1373         Assert in WebPageProxy::suspendCurrentPageIfPossible()
1374         https://bugs.webkit.org/show_bug.cgi?id=195506
1375         <rdar://problem/48733477>
1376
1377         Reviewed by Alex Christensen.
1378
1379         Add API test coverage.
1380
1381         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1382
1383 2019-03-11  Shawn Roberts  <sroberts@apple.com>
1384
1385         Adding myself to contributors.json
1386
1387         Unreviewed, addming myself to contributors.json .
1388
1389         * Scripts/webkitpy/common/config/contributors.json:
1390
1391 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1392
1393         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1394         https://bugs.webkit.org/show_bug.cgi?id=195511
1395         <rdar://problem/44873269>
1396
1397         Reviewed by Darin Adler.
1398
1399         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1400         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1401         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1402         (TEST_F):
1403
1404 2019-03-11  Chris Dumez  <cdumez@apple.com>
1405
1406         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
1407         https://bugs.webkit.org/show_bug.cgi?id=195561
1408
1409         Reviewed by Youenn Fablet.
1410
1411         Make sure the JS in the test requests for permission to receive device orientation events.
1412
1413         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1414
1415 2019-03-11  Youenn Fablet  <youenn@apple.com>
1416
1417         Allow storage quota increase by default in WTR
1418         https://bugs.webkit.org/show_bug.cgi?id=195541
1419
1420         Reviewed by Geoffrey Garen.
1421
1422         Allow storage quota increase by default in WTR.
1423         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
1424         Use this for tests that explicitly need cache increase.
1425
1426         Instead of increasing quota by 2, make sure the next request is
1427         granted by adding all given parameters.
1428
1429         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1431         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1432         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
1433         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1434         * WebKitTestRunner/TestController.cpp:
1435         (WTR::TestController::setAllowStorageQuotaIncrease):
1436         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1437         * WebKitTestRunner/TestController.h:
1438         * WebKitTestRunner/TestInvocation.cpp:
1439         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1440         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1441         (WTR::TestController::cocoaResetStateToConsistentValues):
1442         (WTR::TestController::setAllowStorageQuotaIncrease):
1443         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1444         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1445         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1446
1447 2019-03-11  Xan Lopez  <xan@igalia.com>
1448
1449         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
1450         https://bugs.webkit.org/show_bug.cgi?id=194147
1451
1452         Reviewed by Michael Saboff.
1453
1454         To make --32-bit work correctly on Linux/64bit we need to:
1455
1456         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
1457         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
1458         unfortunately CMake only allows us to do this during
1459         crosscompilation, which is overkill here.
1460         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
1461         pkg-config detection module uses the x86 .pc files instead of the
1462         x86_64 ones.
1463         - Set the -m32 flags for the compiler.
1464
1465         * Scripts/webkitdirs.pm:
1466         (generateBuildSystemFromCMakeProject):
1467
1468 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
1469
1470         Add MotionMark-1.1 plan file for run-benchmark script.
1471         https://bugs.webkit.org/show_bug.cgi?id=195481
1472
1473         Rubber-stamped by Darin Adler.
1474
1475         Run-benchmark script should support MontionMark-1.1.
1476
1477         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
1478
1479 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1480
1481         [ews-app] Add support for submit-to-ews url
1482         https://bugs.webkit.org/show_bug.cgi?id=195477
1483
1484         Reviewed by Lucas Forschler.
1485
1486         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1487         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1488         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
1489         * BuildSlaveSupport/ews-app/ews/urls.py:
1490         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
1491
1492 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
1493
1494         Unreviewed, rolling out r242688, r242643, r242624.
1495
1496         Caused multiple layout test failures and crashes on iOS and macOS.
1497
1498         Reverted changeset:
1499
1500         "requestAnimationFrame should execute before the next frame"
1501         https://bugs.webkit.org/show_bug.cgi?id=177484
1502         https://trac.webkit.org/changeset/242624/webkit
1503
1504         * Tracing/SystemTracePoints.plist:
1505
1506 2019-03-11  John Wilander  <wilander@apple.com>
1507
1508         Resource Load Statistics: Make it possible exclude localhost from classification
1509         https://bugs.webkit.org/show_bug.cgi?id=195474
1510         <rdar://problem/47520577>
1511
1512         Reviewed by Brent Fulgham.
1513
1514         This patch allows for localhost to be excluded from classification and
1515         treatment as a prevalent resource.
1516
1517         The WebKit Tools change adds a new function called
1518         testRunner.setStatisticsIsRunningTest() which can be used to control this
1519         behavior.
1520
1521         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1523         (WTR::TestRunner::setStatisticsIsRunningTest):
1524         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1525         * WebKitTestRunner/TestController.cpp:
1526         (WTR::TestController::setStatisticsIsRunningTest):
1527         * WebKitTestRunner/TestController.h:
1528         * WebKitTestRunner/TestInvocation.cpp:
1529         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1530
1531 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1532
1533         [ews-build] Disable waterfall and console view for ews-build.webkit.org
1534         https://bugs.webkit.org/show_bug.cgi?id=195560
1535
1536         Reviewed by Lucas Forschler.
1537
1538         * BuildSlaveSupport/ews-build/master.cfg:
1539
1540 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1541
1542         Unreviewed, rolling out r242698.
1543
1544         API test crashes on bots.
1545
1546         Reverted changeset:
1547
1548         "Add a WKContentRuleList variant that uses copied memory
1549         instead of mmap'd shared memory for class A containerized
1550         apps"
1551         https://bugs.webkit.org/show_bug.cgi?id=195511
1552         https://trac.webkit.org/changeset/242698
1553
1554 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1555
1556         [WPE] Enable web process sandbox
1557         https://bugs.webkit.org/show_bug.cgi?id=195169
1558
1559         Reviewed by Daniel Bates.
1560
1561         * wpe/install-dependencies:
1562         * wpe/jhbuild.modules:
1563
1564 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1565
1566         [ews-app] Use port 17000 for worker communication
1567         https://bugs.webkit.org/show_bug.cgi?id=195558
1568
1569         Reviewed by Lucas Forschler.
1570
1571         * BuildSlaveSupport/ews-build/master.cfg:
1572
1573 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1574
1575         [ews-build] unit-tests fail when passwords.json is missing
1576         https://bugs.webkit.org/show_bug.cgi?id=195557
1577
1578         Reviewed by Lucas Forschler.
1579
1580         * BuildSlaveSupport/ews-build/loadConfig.py:
1581         (loadBuilderConfig):
1582         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1583         (ConfigDotJSONTest.test_configuration):
1584         * BuildSlaveSupport/ews-build/master.cfg:
1585
1586 2019-03-11  Truitt Savell  <tsavell@apple.com>
1587
1588         Unreviewed, rolling out r242702.
1589
1590         Broke High Sierra builders.
1591
1592         Reverted changeset:
1593
1594         "Add utility function to allow easy reverse range-based
1595         iteration of a container"
1596         https://bugs.webkit.org/show_bug.cgi?id=195542
1597         https://trac.webkit.org/changeset/242702
1598
1599 2019-03-11  Sam Weinig  <sam@webkit.org>
1600
1601         Add utility function to allow easy reverse range-based iteration of a container
1602         https://bugs.webkit.org/show_bug.cgi?id=195542
1603
1604         Reviewed by Antti Koivisto.
1605
1606         * TestWebKitAPI/CMakeLists.txt:
1607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1608         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1609         (TestWebKitAPI::TEST):
1610         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1611
1612 2019-03-10  Alex Christensen  <achristensen@webkit.org>
1613
1614         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1615         https://bugs.webkit.org/show_bug.cgi?id=195511
1616         <rdar://problem/44873269>
1617
1618         Reviewed by Darin Adler.
1619
1620         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1621         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1622         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1623         (TEST_F):
1624
1625 2019-03-10  Tim Horton  <timothy_horton@apple.com>
1626
1627         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
1628         https://bugs.webkit.org/show_bug.cgi?id=195499
1629
1630         Reviewed by Darin Adler.
1631
1632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1633         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
1634         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
1635         (-[WKWebView synchronouslyFocusTextInputContext:]):
1636         (applyStyle):
1637         (applyIframe):
1638         (TEST):
1639         Add some tests for this SPI.
1640
1641 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
1642
1643         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
1644         https://bugs.webkit.org/show_bug.cgi?id=181151
1645
1646         Reviewed by Don Olmstead.
1647
1648         * TestWebKitAPI/CMakeLists.txt:
1649         * TestWebKitAPI/PlatformWin.cmake:
1650         Enable TestWTF RunLoop tests in all platforms.
1651
1652         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1653         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1654         (TestWebKitAPI::DerivedOneShotTimer::fired):
1655         (TestWebKitAPI::TEST):
1656         Only a few platforms support nested RunLoop.
1657
1658         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1659         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1660
1661 2019-03-10  David Quesada  <david_quesada@apple.com>
1662
1663         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1664         https://bugs.webkit.org/show_bug.cgi?id=152480
1665
1666         Reviewed by Chris Dumez.
1667
1668         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1669         there are no additional references to the process pool besides the one held by
1670         the download, waits for the download to finish (in the sense that the
1671         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1672         measure, also check that the process pool has been deallocated at the end of the
1673         test. The test wouldn't be meaningful if the process pool were still alive.
1674
1675         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1676         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1677         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
1678             The download will be canceled because the delegate does not implement the
1679             method to decide the download's destination, so this is where we know the
1680             DownloadProxyMap is done with the DownloadProxy.
1681         (TEST):
1682
1683 2019-03-08  Chris Dumez  <cdumez@apple.com>
1684
1685         Add support for Device Orientation / Motion permission API
1686         https://bugs.webkit.org/show_bug.cgi?id=195329
1687         <rdar://problem/47645367>
1688
1689         Reviewed by Geoffrey Garen.
1690
1691         Add test infrastructure to help test the Device Orientation / Motion permission API.
1692
1693         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1694         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1695         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1696         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1697         * WebKitTestRunner/TestController.cpp:
1698         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1699         (WTR::TestController::createWebViewWithOptions):
1700         (WTR::TestController::resetStateToConsistentValues):
1701         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1702         * WebKitTestRunner/TestController.h:
1703         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1704         * WebKitTestRunner/TestInvocation.cpp:
1705         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1706
1707 2019-03-08  Saam barati  <sbarati@apple.com>
1708
1709         Add a compare-results script to compare benchmark results
1710         https://bugs.webkit.org/show_bug.cgi?id=195486
1711         <rdar://problem/48723397>
1712
1713         Reviewed by Geoffrey Garen.
1714
1715         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1716         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1717         to extend it to learn about our other benchmarks.
1718
1719         * Scripts/compare-results: Added.
1720         (readJSONFile):
1721         (detectJetStream2):
1722         (JetStream2Results):
1723         (detectSpeedometer2):
1724         (Speedometer2Results):
1725         (detectPLT5):
1726         (PLT5Results):
1727         (detectBenchmark):
1728         (biggerIsBetter):
1729         (ttest):
1730         (getOptions):
1731         (main):
1732
1733 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1734
1735         Ensure old tab state is cleared between iterations of run-benchmark
1736         https://bugs.webkit.org/show_bug.cgi?id=195393
1737         <rdar://problem/46885583>
1738
1739         Reviewed by Dewei Zhu.
1740
1741         a) ensure the default to restore state is not set
1742         b) terminate Safari correctly
1743         c) Set the system default to ignore Persistent State in Safari
1744
1745         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1746         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1747         (OSXBrowserDriver.prepare_env): 
1748         (OSXBrowserDriver.restore_env):
1749         (OSXBrowserDriver.close_browsers):
1750         (OSXBrowserDriver._terminate_processes):
1751         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
1752         (OSXChromeDriver):
1753         (OSXChromeCanaryDriver):
1754         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
1755         (OSXFirefoxDriver):
1756         (OSXFirefoxNightlyDriver):
1757         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
1758         (OSXSafariDriver):
1759         (OSXSafariDriver.prepare_env):
1760
1761 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
1762
1763         [GTK] Several InputMethodFilter tests are failing
1764         https://bugs.webkit.org/show_bug.cgi?id=195408
1765
1766         Reviewed by Carlos Garcia Campos.
1767
1768         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1769         Regressed in r241751.
1770         Hexadecimal values of keycodes are expressed now in upper letters.
1771         Composited characters should be cast to UTF8 strings.
1772
1773         (TestWebKitAPI::TEST):
1774
1775 2019-03-07  Tomas Popela  <tpopela@redhat.com>
1776
1777         [GTK] Make Tools/gtkdoc python3 compatible
1778         https://bugs.webkit.org/show_bug.cgi?id=195359
1779
1780         Reviewed by Carlos Garcia Campos.
1781
1782         * gtkdoc/generate-gtkdoc:
1783         ConfigParser was reworked in Python 3.2 so we have adapt the code to
1784         work with Python 2 and 3.
1785         (get_gtkdoc_module_paths):
1786         The iteritems() was removed in Python 3, so let's use items() that's
1787         available in Python 2 and 3.
1788         (get_generator_for_config):
1789         * gtkdoc/gtkdoc.py:
1790         (GTKDoc._run_command):
1791         The sys.stdout.write() is expecting str in Python 3 and not bytes
1792         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
1793         for passing the bytes there.
1794
1795 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1796
1797         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1798         https://bugs.webkit.org/show_bug.cgi?id=195346
1799         <rdar://problem/48667048>
1800
1801         Unreviewed build fix for clang-cl.
1802
1803         * DumpRenderTree/win/DumpRenderTree.cpp:
1804         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
1805
1806 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1807
1808         requestAnimationFrame should execute before the next frame
1809         https://bugs.webkit.org/show_bug.cgi?id=177484
1810
1811         Reviewed by Simon Fraser.
1812
1813         Add trace points for the page RenderingUpdate.
1814
1815         * Tracing/SystemTracePoints.plist:
1816
1817 2019-03-07  Zalan Bujtas  <zalan@apple.com>
1818
1819         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
1820         https://bugs.webkit.org/show_bug.cgi?id=195353
1821         <rdar://problem/48626394>
1822
1823         Reviewed by Simon Fraser.
1824
1825         * WebKitTestRunner/ios/TestControllerIOS.mm:
1826         (WTR::TestController::platformResetPreferencesToConsistentValues):
1827
1828 2019-03-07  John Wilander  <wilander@apple.com>
1829
1830         Resource Load Statistics: Make it possible to purge only script-accessible cookies
1831         https://bugs.webkit.org/show_bug.cgi?id=195383
1832         <rdar://problem/48570136>
1833
1834         Reviewed by Brent Fulgham.
1835
1836         This patch adds test infrastructure to purge only script-accessible cookies,
1837         including a new testRunner function called statisticsDeleteCookiesForHost().git a
1838
1839         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1840         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1841         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1842         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1843         * WebKitTestRunner/TestController.cpp:
1844         (WTR::TestController::statisticsDeleteCookiesForHost):
1845         * WebKitTestRunner/TestController.h:
1846         * WebKitTestRunner/TestInvocation.cpp:
1847         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1848
1849 2019-03-07  Commit Queue  <commit-queue@webkit.org>
1850
1851         Unreviewed, rolling out r242354.
1852         https://bugs.webkit.org/show_bug.cgi?id=195402
1853
1854         breaks layout tests in all configurations (Requested by
1855         zdobersek on #webkit).
1856
1857         Reverted changeset:
1858
1859         "[WPE] Enable web process sandbox"
1860         https://bugs.webkit.org/show_bug.cgi?id=195169
1861         https://trac.webkit.org/changeset/242354
1862
1863 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
1864
1865         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1866         https://bugs.webkit.org/show_bug.cgi?id=195346
1867
1868         Reviewed by Fujii Hironori.
1869
1870         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1871         (TestWebKitAPI::TEST):
1872         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
1873
1874         * DumpRenderTree/win/DumpRenderTree.cpp:
1875         (findFontFallback):
1876         (addFontFallbackIfPresent):
1877         (removeFontFallbackIfPresent):
1878         (main):
1879         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1880         (TestWebKitAPI::Util::moduleDirectory):
1881         (TestWebKitAPI::Util::createInjectedBundlePath):
1882         Use wchar helpers as needed.
1883
1884 2019-03-06  Rob Buis  <rbuis@igalia.com>
1885
1886         Consider supporting the `referrerpolicy` attribute.
1887         https://bugs.webkit.org/show_bug.cgi?id=179053
1888
1889         Reviewed by Darin Adler.
1890
1891         Add a runtime flag for referrerpolicy attribute.
1892
1893         * DumpRenderTree/mac/DumpRenderTree.mm:
1894         (enableExperimentalFeatures):
1895
1896 2019-03-05  Daniel Bates  <dabates@apple.com>
1897
1898         Update expected API test result following r242379
1899         (https://bugs.webkit.org/show_bug.cgi?id=195125)
1900
1901         Update expected x-coordinate of selection rect now that the left padding of
1902         a textarea is sized in ems (so dependent on the font size) just like the left
1903         padding of a text field.
1904
1905         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1906         (TestWebKitAPI::TEST):
1907
1908 2019-03-05  David Quesada  <david_quesada@apple.com>
1909
1910         [WK2] It should be possible to follow links with 'download' attributes
1911         https://bugs.webkit.org/show_bug.cgi?id=195145
1912         rdar://problem/48462642
1913
1914         Reviewed by Alex Christensen.
1915
1916         Add a unit test to verify that activating links with 'download' attributes now
1917         navigates to the linked resource, rather than starts downloading it. Add another
1918         to verify that it is still possible to explicitly download the link via the
1919         'Download' navigation action policy.
1920
1921         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1922         (-[DownloadAttributeTestDelegate init]):
1923         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
1924         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
1925         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
1926         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
1927         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1928         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
1929         (TEST):
1930         * WebKitTestRunner/TestController.cpp:
1931         (WTR::TestController::decidePolicyForNavigationAction):
1932         * WebKitTestRunner/TestController.h:
1933
1934 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
1935
1936         [Curl] Implement Cookie Accept Policy.
1937         https://bugs.webkit.org/show_bug.cgi?id=191645
1938
1939         Reviewed by Fujii Hironori.
1940
1941         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1942         (TestWebKitAPI::Curl::TEST_F):
1943
1944 2019-03-05  Youenn Fablet  <youenn@apple.com>
1945
1946         Rename requestCacheStorageSpace to requestStorageSpace
1947         https://bugs.webkit.org/show_bug.cgi?id=195282
1948
1949         Reviewed by Chris Dumez.
1950
1951         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1952         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1953         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
1954
1955 2019-03-05  Brady Eidson  <beidson@apple.com>
1956
1957         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
1958         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
1959
1960         Reviewed by Tim Horton.
1961
1962         Loading a file: URL into a WKWebView and then loading another file: url from a completely
1963         different directory into that same WKWebView should work.
1964
1965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1966         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
1967
1968 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1969
1970         Add WeakHashSet
1971         https://bugs.webkit.org/show_bug.cgi?id=195152
1972
1973         Reviewed by Antti Koivisto.
1974
1975         Added tests for WeakHashSet.
1976
1977         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1978         (TestWebKitAPI::Base::Base): Moved.
1979         (TestWebKitAPI::Derived::foo): Moved.
1980         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
1981         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
1982         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
1983         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
1984
1985 2019-03-04  Chris Dumez  <cdumez@apple.com>
1986
1987         Do not share WebProcesses between private and regular sessions
1988         https://bugs.webkit.org/show_bug.cgi?id=195189
1989         <rdar://problem/48421064>
1990
1991         Reviewed by Alex Christensen.
1992
1993         Add API test coverage.
1994
1995         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1996         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1997
1998 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1999
2000         [WPE] Enable web process sandbox
2001         https://bugs.webkit.org/show_bug.cgi?id=195169
2002
2003         Reviewed by Daniel Bates.
2004
2005         * wpe/install-dependencies:
2006         * wpe/jhbuild.modules:
2007
2008 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2009
2010         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2011         https://bugs.webkit.org/show_bug.cgi?id=195206
2012
2013         Reviewed by Žan Doberšek.
2014
2015         Add a new test case.
2016
2017         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2018         (testJSCClass):
2019
2020 2019-03-04  Charlie Turner  <cturner@igalia.com>
2021
2022         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2023         https://bugs.webkit.org/show_bug.cgi?id=194898
2024
2025         Reviewed by Žan Doberšek.
2026
2027         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2028         a GCC extension that permits arithmetic on void* pointer. Inline
2029         the macro until this issue is fixed upstream.
2030
2031 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2032
2033         Rid the world of WK_API_ENABLED
2034         https://bugs.webkit.org/show_bug.cgi?id=195263
2035
2036         Reviewed by Dan Bernstein.
2037
2038         List of changed files elided because it's useless.
2039
2040 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2041
2042         Unreviewed follow-up to r242292.
2043
2044         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2045
2046         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2047         (TestWebKitAPI::testStrip): Renamed from strip.
2048         (TestWebKitAPI::TEST):
2049
2050 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2051
2052         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2053
2054         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2055         and bug #194272 for details.
2056
2057         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2058
2059 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2060
2061         Remove some more unused 32-bit code
2062         https://bugs.webkit.org/show_bug.cgi?id=195255
2063
2064         Reviewed by Darin Adler.
2065
2066         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2067         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2068         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2069         (NPP_New):
2070         (NPP_HandleEvent):
2071         (handleEventCarbon): Deleted.
2072
2073 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2074
2075         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2076
2077         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2078         (TestWebKitAPI::TEST):
2079
2080 2019-03-01  Darin Adler  <darin@apple.com>
2081
2082         Finish removing String::format
2083         https://bugs.webkit.org/show_bug.cgi?id=194893
2084
2085         Reviewed by Daniel Bates.
2086 '
2087         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2088
2089 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2090
2091         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2092         https://bugs.webkit.org/show_bug.cgi?id=195229
2093         <rdar://problem/48520362>
2094
2095         Reviewed by Chris Dumez.
2096
2097         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2098         (TEST):
2099
2100 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2101
2102         Add a system trace scope for event region building
2103         https://bugs.webkit.org/show_bug.cgi?id=195226
2104
2105         Reviewed by Jon Lee.
2106
2107         This trace scope measures the time spend converting element rects into Region objects,
2108         which can be large on some pages.
2109
2110         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2111
2112         * Tracing/SystemTracePoints.plist:
2113
2114 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2115
2116         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2117         https://bugs.webkit.org/show_bug.cgi?id=194612
2118
2119         Reviewed by Alex Christensen.
2120
2121         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2122         Just test the new string-processing function and don't touch the actual environment.
2123         (Test cases are all as before, but based on operator== instead of strcmp.)
2124
2125 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2126
2127         [ews-app] Update primary keys for handling multiple Buildbot instances
2128         https://bugs.webkit.org/show_bug.cgi?id=195120
2129
2130         Reviewed by Stephanie Lewis.
2131
2132         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2133         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2134         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2135
2136         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2137         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2138         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2139         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2140         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2141         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2142
2143 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2144
2145         [WinCairo] Enable service worker
2146         https://bugs.webkit.org/show_bug.cgi?id=188318
2147
2148         Reviewed by Youenn Fablet.
2149
2150         * DumpRenderTree/DumpRenderTreePrefix.h:
2151         * TestWebKitAPI/PlatformWin.cmake:
2152         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2153         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2154         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2155
2156 2019-03-01  Justin Fan  <justin_fan@apple.com>
2157
2158         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2159         https://bugs.webkit.org/show_bug.cgi?id=195191
2160
2161         Rubber-stamped by Dean Jackson.
2162
2163         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2164
2165         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2166
2167 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2168
2169         Unreviewed, fix lldb webkitpy tests
2170         https://bugs.webkit.org/show_bug.cgi?id=194375
2171
2172         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2173
2174         * lldb/lldb_webkit.py:
2175         (WTFStringImplProvider.is_8bit):
2176
2177 2019-02-28  David Quesada  <david_quesada@apple.com>
2178
2179         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2180         https://bugs.webkit.org/show_bug.cgi?id=195121
2181         rdar://problem/48450302
2182
2183         Reviewed by Alex Christensen.
2184
2185         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2186         configurations where the 'download' attribute is absent, blank, or populated
2187         with a filename, and where the anchor element is same-origin or cross-origin
2188         (meaning the 'download' attribute shouldn't be honored).
2189
2190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2191         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2192         (-[NavigationActionTestDelegate init]):
2193         (-[NavigationActionTestDelegate navigationAction]):
2194         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2195         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2196         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2197         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2198         (TEST):
2199
2200 2019-02-28  Antoine Quint  <graouts@apple.com>
2201
2202         Enable the Pointer Events runtime flag by default
2203         https://bugs.webkit.org/show_bug.cgi?id=195156
2204
2205         Reviewed by Dean Jackson.
2206
2207         * DumpRenderTree/mac/DumpRenderTree.mm:
2208         (enableExperimentalFeatures):
2209
2210 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2211
2212         Several PasteImage API tests are flaky
2213         https://bugs.webkit.org/show_bug.cgi?id=195160
2214
2215         Reviewed by Tim Horton.
2216
2217         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2218         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2219         listening for a "load" event after image load is already complete.
2220
2221         To address this, make these tests first register a "load" event handler, then run script to insert an image
2222         element into the document, and finally wait until the load event is observed before checking image size.
2223
2224         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2225
2226 2019-02-28  Chris Dumez  <cdumez@apple.com>
2227
2228         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2229         https://bugs.webkit.org/show_bug.cgi?id=195107
2230
2231         Reviewed by Alex Christensen.
2232
2233         Give some time for the zoom level to get restored.
2234
2235         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2236
2237 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2238
2239         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2240         https://bugs.webkit.org/show_bug.cgi?id=194958
2241
2242         Reviewed by Geoffrey Garen.
2243
2244         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2245         (TEST):
2246
2247 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2248
2249         [ews-app] Update method to save build to handle builder_display_name
2250         https://bugs.webkit.org/show_bug.cgi?id=195047
2251
2252         Reviewed by Dewei Zhu.
2253
2254         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2255         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2256
2257 2019-02-28  Justin Fan  <justin_fan@apple.com>
2258
2259         [Web GPU] Enable Web GPU only on 64-bit
2260         https://bugs.webkit.org/show_bug.cgi?id=195139
2261
2262         Because Metal is only supported on 64 bit apps.
2263
2264         Unreviewed build fix.
2265
2266         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2267
2268 2019-02-27  Youenn Fablet  <youenn@apple.com>
2269
2270         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2271         https://bugs.webkit.org/show_bug.cgi?id=194959
2272
2273         Reviewed by Chris Dumez.
2274
2275         Spin loop until getting the condition to remove flakiness.
2276
2277         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2278
2279 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2280
2281         [ews-build] Buildbot should include builder_display_name in the build events
2282         https://bugs.webkit.org/show_bug.cgi?id=195045
2283
2284         Reviewed by Dewei Zhu.
2285
2286         * BuildSlaveSupport/ews-build/events.py:
2287         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2288         buildername to builder_name to be consistent in naming style.
2289         (Events.buildFinished): Ditto.
2290
2291 2019-02-27  Chris Dumez  <cdumez@apple.com>
2292
2293         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2294         https://bugs.webkit.org/show_bug.cgi?id=194480
2295
2296         Reviewed by Brady Eidson.
2297
2298         Update existing API test to make it more likely to reproduce the issue.
2299
2300         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2301
2302 2019-02-27  Brady Eidson  <beidson@apple.com>
2303
2304         Universal links from Google search results pages don't open the app.
2305         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2306
2307         Reviewed by Geoffrey Garen.
2308
2309         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2310         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2311         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2312         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2313
2314 2019-02-27  Chris Dumez  <cdumez@apple.com>
2315
2316         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2317         https://bugs.webkit.org/show_bug.cgi?id=195102
2318
2319         Reviewed by Geoffrey Garen.
2320
2321         If the number of processes is not yet what we expect, wait a bit and check again to give
2322         processes some time to exit.
2323
2324         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2325
2326 2019-02-27  Chris Dumez  <cdumez@apple.com>
2327
2328         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
2329         https://bugs.webkit.org/show_bug.cgi?id=194545
2330
2331         Reviewed by Brady Eidson.
2332
2333         Make sure the test navigates forward and then back only once. Previously, navigating
2334         back would trigger a navigation again in a timer.
2335
2336         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2337
2338 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2339
2340         High Sierra Debug JSC test queue should use faster hardware
2341         https://bugs.webkit.org/show_bug.cgi?id=194603
2342
2343         Rubber-stamped by Alexey Proskuryakov.
2344
2345         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
2346
2347         * BuildSlaveSupport/build.webkit.org-config/config.json:
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2349         (BubbleQueueServer):
2350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2351         (WebKitBuildbot):
2352         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2353         * QueueStatusServer/config/queues.py:
2354         * Scripts/webkitpy/common/config/ews.json:
2355         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2356         (test_ews_name):
2357
2358 2019-02-27  John Wilander  <wilander@apple.com>
2359
2360         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
2361         https://bugs.webkit.org/show_bug.cgi?id=195071
2362         <rdar://problem/48417690>
2363
2364         Reviewed by Alex Christensen and Brent Fulgham.
2365
2366         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2367         (TestWebKitAPI::createURL):
2368             Convenience function.
2369         (TestWebKitAPI::TEST):
2370             WebCore::AdClickAttribution now takes a URL when creating Source and
2371             Destination.
2372         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2373         (TestWebKitAPI::TEST):
2374             WebCore::AdClickAttribution now takes a URL when creating Source and
2375             Destination.
2376
2377 2019-02-27  Antoine Quint  <graouts@apple.com>
2378
2379         Support Pointer Events on macOS
2380         https://bugs.webkit.org/show_bug.cgi?id=195008
2381         <rdar://problem/47454419>
2382
2383         Reviewed by Dean Jackson.
2384
2385         * DumpRenderTree/mac/DumpRenderTree.mm:
2386         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
2387         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2388
2389 2019-02-26  Mark Lam  <mark.lam@apple.com>
2390
2391         Remove remaining poisoning code.
2392         https://bugs.webkit.org/show_bug.cgi?id=194138
2393
2394         Reviewed by Saam Barati.
2395
2396         * TestWebKitAPI/CMakeLists.txt:
2397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2398         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
2399         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
2400         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
2401         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
2402         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
2403         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
2404
2405 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2406
2407         Move ephemeral local storage from WebProcess to UIProcess
2408         https://bugs.webkit.org/show_bug.cgi?id=195074
2409         <rdar://problem/47937975>
2410
2411         Reviewed by Geoff Garen.
2412
2413         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2414
2415 2019-02-20  Jer Noble  <jer.noble@apple.com>
2416
2417         [Cocoa] Media elements will restart network buffering just before suspending
2418         https://bugs.webkit.org/show_bug.cgi?id=193691
2419
2420         Reviewed by Eric Carlson.
2421
2422         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2423         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2424         (TEST):
2425
2426 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
2427
2428         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
2429         https://bugs.webkit.org/show_bug.cgi?id=191652
2430
2431         Reviewed by Alex Christensen.
2432
2433         Fix WinCairo MiniBrowser behavior of authentication dialog.
2434
2435         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2436         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2437
2438 2019-02-26  Youenn Fablet  <youenn@apple.com>
2439
2440         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
2441         https://bugs.webkit.org/show_bug.cgi?id=195028
2442         <rdar://problem/48243733>
2443
2444         Reviewed by Eric Carlson.
2445
2446         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2447
2448 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2449
2450         [WPE] Add API for webview background color configuration
2451         https://bugs.webkit.org/show_bug.cgi?id=192305
2452
2453         Reviewed by Michael Catanzaro.
2454
2455         * MiniBrowser/wpe/main.cpp:
2456         (main): Add a new option to configure the webview background
2457         color. Example: --bg-color=transparent.
2458         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2459         (testWebViewBackgroundColor): Enable background color API tests for WPE.
2460         (beforeAll): Ditto.
2461
2462 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2463
2464         scalableNativeWebpageParameters() is not preserved on new page navigation.
2465         https://bugs.webkit.org/show_bug.cgi?id=194892
2466         <rdar://problem/47538280>
2467
2468         Reviewed by Wenson Hsieh.
2469         
2470         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
2471
2472         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2473         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2474         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2475         (WTR::UIScriptController::allowsViewportShrinkToFit):
2476         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2477         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2478         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2479         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2480         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2481         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2482
2483 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2484
2485         [ews-app] Add model for handling multiple Buildbot instances
2486         https://bugs.webkit.org/show_bug.cgi?id=194863
2487
2488         Reviewed by Stephanie Lewis.
2489
2490         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
2491
2492 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2493
2494         [ews-app] Remove BuilderMapping table
2495         https://bugs.webkit.org/show_bug.cgi?id=194961
2496
2497         Reviewed by Stephanie Lewis.
2498
2499         Store builder name directly in build table, instead of having a separate
2500         table for it.
2501
2502         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2503         * BuildSlaveSupport/ews-app/ews/models/build.py:
2504         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
2505         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2506
2507 2019-02-25  John Wilander  <wilander@apple.com>
2508
2509         Introduce and adopt new class RegistrableDomain for eTLD+1
2510         https://bugs.webkit.org/show_bug.cgi?id=194791
2511         <rdar://problem/48179240>
2512
2513         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
2514
2515         This patch adds an API test and replaces two instances of
2516         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
2517
2518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2519         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2520         (TestWebKitAPI::TEST):
2521             Changed two strings to make sure the registrable domains are still considered
2522             invalid and pass the test.
2523         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
2524         (TestWebKitAPI::TEST):
2525         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2526         (WTR::InjectedBundle::didReceiveMessageToPage):
2527
2528 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
2529
2530         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
2531         https://bugs.webkit.org/show_bug.cgi?id=195001
2532
2533         Reviewed by Carlos Garcia Campos.
2534
2535         API version 1.0 always includes the functionality previously guarded with
2536         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
2537         unconditionally.
2538
2539         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2540         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
2541         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2542         (WebViewTest::showInWindow): Ditto.
2543         (WebViewTest::hideView): Ditto.
2544         * wpe/backends/HeadlessViewBackend.cpp:
2545         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
2546         * wpe/backends/ViewBackend.cpp:
2547         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
2548         * wpe/backends/WindowViewBackend.cpp:
2549         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
2550         WPE_BACKEND_CHECK_VERSION().
2551         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
2552
2553 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2554
2555         [Flatpak] Add support for flatpak > 1.1.2
2556         https://bugs.webkit.org/show_bug.cgi?id=194088
2557
2558         Flatpak 1.2 is now out so we need to support that
2559         version now.
2560
2561         Reviewed by Michael Catanzaro.
2562
2563         * flatpak/flatpakutils.py:
2564         (check_flatpak):
2565         (FlatpakPackages.__init__):
2566         (FlatpakPackages.__detect_packages):
2567         (FlatpakPackages.__detect_packages.in):
2568         (FlatpakRepos.update):
2569
2570 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2571
2572         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
2573         https://bugs.webkit.org/show_bug.cgi?id=194998
2574
2575         Reviewed by Carlos Garcia Campos.
2576
2577         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
2578         to a Git checkout and using the latest commit containing various fixes
2579         and improvements.
2580
2581 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2582
2583         [WPE][GTK] Remove user agent quirk for washingtonpost.com
2584         https://bugs.webkit.org/show_bug.cgi?id=194981
2585
2586         Reviewed by Žan Doberšek.
2587
2588         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2589         (TestWebKitAPI::TEST):
2590
2591 2019-02-23  Keith Miller  <keith_miller@apple.com>
2592
2593         Add new mac target numbers
2594         https://bugs.webkit.org/show_bug.cgi?id=194955
2595
2596         Reviewed by Tim Horton.
2597
2598         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2599         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2600         * MiniBrowser/Configurations/Base.xcconfig:
2601         * TestWebKitAPI/Configurations/Base.xcconfig:
2602         * WebKitTestRunner/Configurations/Base.xcconfig:
2603
2604 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
2605
2606         [WinCairo] Enable wk1/wk2 suffix for platform search path.
2607         https://bugs.webkit.org/show_bug.cgi?id=194846
2608
2609         Reviewed by Don Olmstead.
2610
2611         Added _search_paths() and _port_specific_expectations_files() for
2612         WinCairoPort.
2613
2614         * Scripts/webkitpy/port/win.py:
2615         (WinCairoPort.default_baseline_search_path):
2616         (WinCairoPort):
2617         (WinCairoPort._port_specific_expectations_files):
2618         (WinCairoPort._search_paths):
2619
2620 2019-02-22  Tim Horton  <timothy_horton@apple.com>
2621
2622         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
2623         https://bugs.webkit.org/show_bug.cgi?id=194963
2624
2625         Reviewed by Dean Jackson.
2626
2627         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2628         Do a `contains` check instead of `equals`, because in debug builds we
2629         put the GraphicsLayer pointer in a prefix.
2630
2631 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2632
2633         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
2634         https://bugs.webkit.org/show_bug.cgi?id=194873
2635         <rdar://problem/46701974>
2636
2637         Reviewed by Tim Horton.
2638
2639         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
2640
2641         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2642         (WTR::UIScriptController::menuRect const):
2643         (WTR::UIScriptController::isShowingMenu const):
2644         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2645         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2646         (WTR::UIScriptController::menuRect const):
2647
2648         Add a function to query the bounds of the callout menu in content coordinates.
2649
2650         (WTR::UIScriptController::isShowingMenu const):
2651
2652         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2653
2654         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2655         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2656         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2657         (WTR::UIScriptController::rectForMenuAction const):
2658         (WTR::UIScriptController::menuRect const):
2659         (WTR::UIScriptController::isShowingMenu const):
2660         (WTR::findViewInHierarchyOfType): Deleted.
2661
2662 2019-02-22  Chris Dumez  <cdumez@apple.com>
2663
2664         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2665         https://bugs.webkit.org/show_bug.cgi?id=194954
2666         <rdar://problem/48127957>
2667
2668         Reviewed by Alex Christensen.
2669
2670         Add API test coverage.
2671
2672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2673         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2674         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2675         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2676
2677 2019-02-22  Chris Dumez  <cdumez@apple.com>
2678
2679         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
2680         https://bugs.webkit.org/show_bug.cgi?id=194924
2681         <rdar://problem/48216125>
2682
2683         Reviewed by Geoffrey Garen.
2684
2685         Add API test coverage.
2686
2687         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2688
2689 2019-02-22  Chris Dumez  <cdumez@apple.com>
2690
2691         Unreviewed, disable API test added in r241928 on iOS.
2692
2693         The cache is not enabled on devices with less than 3GB of RAM.
2694
2695         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2696
2697 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2698
2699         Hardcode Visual Viewports on everywhere except iOS WK1
2700         https://bugs.webkit.org/show_bug.cgi?id=194928
2701
2702         Reviewed by Zalan Bujtas.
2703
2704         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2705         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2706         set it to false. The setting has shipped for several years and there's no need to turn
2707         it off now.
2708
2709         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2710         Visual Viewports are not enabled.
2711         
2712         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2713         that only runs in WK2
2714
2715         * MiniBrowser/mac/SettingsController.h:
2716         * MiniBrowser/mac/SettingsController.m:
2717         (-[SettingsController init]):
2718         (-[SettingsController _populateMenu]):
2719         (-[SettingsController validateMenuItem:]):
2720         (-[SettingsController visualViewportEnabled]): Deleted.
2721         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2722         * MiniBrowser/mac/WK1BrowserWindowController.m:
2723         (-[WK1BrowserWindowController didChangeSettings]):
2724         * MiniBrowser/mac/WK2BrowserWindowController.m:
2725         (-[WK2BrowserWindowController didChangeSettings]):
2726
2727 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2728
2729         Discard cached processes when clearing website data store
2730         https://bugs.webkit.org/show_bug.cgi?id=194894
2731
2732         Reviewed by Chris Dumez.
2733
2734         Added a test case.
2735
2736         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2737         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2738
2739 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2740
2741         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2742         https://bugs.webkit.org/show_bug.cgi?id=194914
2743         <rdar://problem/47586889>
2744
2745         Reviewed by Geoffrey Garen.
2746
2747         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2748         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2749         (TEST):
2750         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2751
2752 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2753
2754         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
2755         <https://webkit.org/b/194761>
2756
2757         Reviewed by Myles Maxfield.
2758
2759         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2760         (WTR::activateSystemCoreWebFonts): Log `error` to console if
2761         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
2762         to use ARC-compliant cast.
2763         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
2764         ARC-compliant cast.
2765         (WTR::installFakeHelvetica): Log `error` to console if
2766         CTFontManagerRegisterFontsForURL() fails, but only on supported
2767         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2768         Call CFRelease() on `error` to fix the leak.  Update to use
2769         ARC-compliant cast.
2770         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2771         cast.
2772
2773 2019-02-21  Chris Dumez  <cdumez@apple.com>
2774
2775         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
2776         https://bugs.webkit.org/show_bug.cgi?id=194481
2777
2778         Reviewed by Alex Christensen.
2779
2780         Give the processes a chance to shutdown and wait until we reached the expected number
2781         of processes.
2782
2783         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2784
2785 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2786
2787         Fix the macOS build
2788
2789         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2790
2791 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2792
2793         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2794
2795         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2796         I am a backwards.
2797
2798 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2799
2800         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2801
2802         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2803         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
2804         We could force on UI-side compositing, but I feel like the test might be more
2805         valuable exercising the normal path on each platform (though the original
2806         bug was also UI-side specific). Though we can't validate that the overlay
2807         layer was installed successfully, there are layout tests that do that.
2808
2809 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2810
2811         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
2812         https://bugs.webkit.org/show_bug.cgi?id=194845
2813         <rdar://problem/47944579>
2814
2815         Reviewed by Antti Koivisto.
2816
2817         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2818         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2819
2820 2019-02-21  Zalan Bujtas  <zalan@apple.com>
2821
2822         [LFC][Floats] Add support for placing formatting roots in-between floats.
2823         https://bugs.webkit.org/show_bug.cgi?id=194902
2824
2825         Reviewed by Antti Koivisto.
2826
2827         * LayoutReloaded/misc/LFC-passing-tests.txt:
2828
2829 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
2830
2831         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
2832         https://bugs.webkit.org/show_bug.cgi?id=194901
2833
2834         Unreviewed build fix.
2835
2836         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
2837         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
2838         WPEBackend-fdo-0.1 as library name.
2839
2840 2019-02-21  Rob Buis  <rbuis@igalia.com>
2841
2842         Update MIME type parser
2843         https://bugs.webkit.org/show_bug.cgi?id=180526
2844
2845         Reviewed by Darin Adler.
2846
2847         Add tests involving leading and trailing whitespace, non-token
2848         characters and quoted strings.
2849
2850         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2851         (TestWebKitAPI::TEST):
2852
2853 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
2854
2855         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
2856         https://bugs.webkit.org/show_bug.cgi?id=194884
2857
2858         Reviewed by Michael Catanzaro.
2859
2860         * PlatformWin.cmake:
2861
2862 2019-02-20  Chris Dumez  <cdumez@apple.com>
2863
2864         Add API test for <rdar://problem/47471222>
2865         https://bugs.webkit.org/show_bug.cgi?id=194847
2866
2867         Reviewed by Alex Christensen.
2868
2869         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2870
2871 2019-02-20  Chris Dumez  <cdumez@apple.com>
2872
2873         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
2874         https://bugs.webkit.org/show_bug.cgi?id=194872
2875         <rdar://problem/47924500>
2876
2877         Reviewed by Alex Christensen.
2878
2879         Add API test coverage.
2880
2881         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2882
2883 2019-02-20  Jer Noble  <jer.noble@apple.com>
2884
2885         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
2886         https://bugs.webkit.org/show_bug.cgi?id=191332
2887
2888         Reviewed by Dean Jackson.
2889
2890         * Scripts/git-is-in-range: Added.
2891
2892 2019-02-20  Andy Estes  <aestes@apple.com>
2893
2894         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
2895         https://bugs.webkit.org/show_bug.cgi?id=194869
2896
2897         Rubber-stamped by Jer Noble.
2898
2899         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2900         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
2901         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2902         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2904         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2905
2906 2019-02-20  Chris Dumez  <cdumez@apple.com>
2907
2908         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
2909         https://bugs.webkit.org/show_bug.cgi?id=194857
2910         <rdar://problem/47759323>
2911
2912         Reviewed by Alex Christensen.
2913
2914         Add API test coverage.
2915
2916         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2917
2918 2019-02-20  Chris Dumez  <cdumez@apple.com>
2919
2920         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
2921         https://bugs.webkit.org/show_bug.cgi?id=194829
2922         <rdar://problem/47889906>
2923
2924         Reviewed by Alexey Proskuryakov.
2925
2926         Every time the TestOptions were changing we were creating both a new Web view and
2927         a new WKContext, which would start a new Network process. In most cases, we only
2928         need to contruct a new Web view and we do can keep reusing the same WKContext.
2929         This patch implements this optimization and thus avoids spinning a lot of new
2930         Network processes while running the layout tests.
2931
2932         * WebKitTestRunner/TestController.cpp:
2933         (WTR::TestController::generateContextConfiguration const):
2934         (WTR::TestController::generatePageConfiguration):
2935         (WTR::TestController::createWebViewWithOptions):
2936         (WTR::TestController::resetPreferencesToConsistentValues):
2937         (WTR::updateTestOptionsFromTestHeader):
2938         * WebKitTestRunner/TestController.h:
2939         * WebKitTestRunner/TestOptions.h:
2940         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
2941         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
2942         (WTR::TestOptions::hasSameInitializationOptions const):
2943         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
2944         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2945         (WTR::TestController::platformAddTestOptions const):
2946
2947 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
2948
2949         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
2950         https://bugs.webkit.org/show_bug.cgi?id=167941
2951
2952         Reviewed by Carlos Garcia Campos.
2953
2954         * MiniBrowser/gtk/main.c:
2955         (filterSavedCallback): Added.
2956         (main): Support loading a JSON rule set file for content filtering.
2957         * MiniBrowser/wpe/main.cpp:
2958         (filterSavedCallback): Added.
2959         (main): Support loading a JSON rule set file for content filtering.
2960         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
2961         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
2962         (WTF::derefGPtr): Ditto.
2963         (testEmptyStore):
2964         (testSaveInvalidFilter):
2965         (testSaveLoadFilter):
2966         (testSavedFilterIdentifierMatch):
2967         (testRemoveFilter):
2968         (testSaveMultipleFilters):
2969         (testSaveFilterFromFile):
2970         (testFilterPersistence):
2971         (beforeAll):
2972         (afterAll):
2973         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2974         (removeOldInjectedContentAndResetLists): Also reset content filters.
2975         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
2976         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
2977         the element affected by the style sheet.
2978         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
2979         and returns it to be used by tests.
2980         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
2981         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
2982         (serverCallback): Add support for serving a CSS style sheet for testing.
2983         (beforeAll): Add call to testUserContentManagerContentFilter().
2984         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
2985
2986 2019-02-19  Keith Rollin  <krollin@apple.com>
2987
2988         Add timing information to build output
2989         https://bugs.webkit.org/show_bug.cgi?id=194839
2990         <rdar://problem/48219609>
2991
2992         Reviewed by Alexey Proskuryakov.
2993
2994         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
2995         emit each project's build time to its output. E.g.,
2996
2997             ** BUILD SUCCEEDED ** [0.132 sec]
2998
2999         * Scripts/webkitdirs.pm:
3000         (XcodeOptions):
3001
3002 2019-02-19  Truitt Savell  <tsavell@apple.com>
3003
3004         Unreviewed, rolling out r241784.
3005
3006         Broke all OpenSource builds.
3007
3008         Reverted changeset:
3009
3010         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3011         instances view"
3012         https://bugs.webkit.org/show_bug.cgi?id=172848
3013         https://trac.webkit.org/changeset/241784
3014
3015 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3016
3017         [LFC][Floats] Remove redundant intersecting logic
3018         https://bugs.webkit.org/show_bug.cgi?id=194804
3019
3020         Reviewed by Antti Koivisto.
3021
3022         * LayoutReloaded/misc/LFC-passing-tests.txt:
3023
3024 2019-02-19  Dean Jackson  <dino@apple.com>
3025
3026         Clean-up output from generate-xcfilelists so it can be filtered
3027         https://bugs.webkit.org/show_bug.cgi?id=194795
3028
3029         Reviewed by Joseph Pecoraro (and Keith Rollin).
3030
3031         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3032         make a slight tweak to filter-build-webkit so such lines are marked
3033         as plain.
3034
3035         * Scripts/filter-build-webkit:
3036         * Scripts/generate-xcfilelists:
3037
3038 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3039
3040         pytest is not correctly auto-installed
3041         https://bugs.webkit.org/show_bug.cgi?id=194707
3042
3043         Reviewed by Carlos Garcia Campos.
3044
3045         * Scripts/webkitpy/thirdparty/__init__.py:
3046         (AutoinstallImportHook._install_pytest):
3047
3048 2019-02-18  Chris Dumez  <cdumez@apple.com>
3049
3050         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3051         https://bugs.webkit.org/show_bug.cgi?id=194797
3052         <rdar://problem/48055151>
3053
3054         Reviewed by Geoffrey Garen.
3055
3056         Add API test coverage.
3057
3058         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3059
3060 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3061
3062         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3063         https://bugs.webkit.org/show_bug.cgi?id=194670
3064         <rdar://problem/39066529>
3065
3066         Reviewed by Tim Horton.
3067
3068         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3069         pasted in an editable area as attachment elements.
3070
3071         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3072         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3073         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3074         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3075         (TestWebKitAPI::TEST):
3076         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3077         (WTR::InjectedBundlePage::InjectedBundlePage):
3078
3079 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3080
3081         Fix API test after r241728
3082        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3083
3084         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3085         (TEST):
3086         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3087
3088 2019-02-18  Daniel Bates  <dabates@apple.com>
3089
3090         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3091         https://bugs.webkit.org/show_bug.cgi?id=192824
3092         <rdar://problem/47100332>
3093
3094         Reviewed by Wenson Hsieh.
3095
3096         Fix a bug where the wrong usage code was used for F13 thru F24.
3097
3098         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3099         (keyCodeForDOMFunctionKey):
3100
3101 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3102
3103         Bytecode cache should a have a boot-specific validation
3104         https://bugs.webkit.org/show_bug.cgi?id=194769
3105         <rdar://problem/48149509>
3106
3107         Reviewed by Keith Miller.
3108
3109         Add test for WTF::bootSessionUUIDString()
3110
3111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3112         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3113         (TEST):
3114
3115 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3116
3117         Disable safe browsing in WKWebView and remove its WKPreferences API
3118         https://bugs.webkit.org/show_bug.cgi?id=194723
3119         <rdar://problem/48122993>
3120
3121         Reviewed by Geoffrey Garen.
3122
3123         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3124         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3125         (TEST):
3126         (safeBrowsingView):
3127         Make tests use SPI instead of API.
3128
3129 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3130
3131         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3132         https://bugs.webkit.org/show_bug.cgi?id=194586
3133
3134         Reviewed by Ross Kirsling.
3135
3136         * DumpRenderTree/win/DumpRenderTree.cpp:
3137         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3138         * Scripts/webkitpy/port/driver.py:
3139         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3140
3141 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3142
3143         Unreviewed, rolling out r241620.
3144
3145         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3146         (Requested by ddkilzer on #webkit.)
3147
3148         Reverted changeset:
3149
3150         "[WTF] Add environment variable helpers"
3151         https://bugs.webkit.org/show_bug.cgi?id=192405
3152         https://trac.webkit.org/changeset/241620
3153
3154 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3155
3156         [LFC] RenderImage's default intrinsic size is 0.
3157         https://bugs.webkit.org/show_bug.cgi?id=194745
3158
3159         Reviewed by Antti Koivisto.
3160
3161         * LayoutReloaded/misc/LFC-passing-tests.txt:
3162
3163 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3164
3165         [LFC][BFC] Add support for block replaced intrinsic width.
3166         https://bugs.webkit.org/show_bug.cgi?id=194705
3167
3168         Reviewed by Simon Fraser.
3169
3170         * LayoutReloaded/misc/LFC-passing-tests.txt:
3171
3172 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3173
3174         [LFC] Apply min/max width constraints to preferred width computation
3175         https://bugs.webkit.org/show_bug.cgi?id=194739
3176
3177         Reviewed by Simon Fraser.
3178
3179         * LayoutReloaded/misc/LFC-passing-tests.txt:
3180
3181 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3182
3183         [WTF] Add environment variable helpers
3184         https://bugs.webkit.org/show_bug.cgi?id=192405
3185
3186         Reviewed by Michael Catanzaro.
3187
3188         * DumpRenderTree/mac/DumpRenderTree.mm:
3189         (libraryPathForDumpRenderTree):
3190         * DumpRenderTree/win/DumpRenderTree.cpp:
3191         (libraryPathForDumpRenderTree):
3192         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3193         (setUpIOSLayoutTestCommunication):
3194         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3195         (beforeAll):
3196         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3197         (main):
3198         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3199         (WebKitTestBus::run):
3200         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3201         (WTR::getOutputDir):
3202         (WTR::initializeFontConfigSetting):
3203         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3204         (WTR::InjectedBundle::platformInitialize):
3205         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3206         (WTR::topLevelPath):
3207         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3208         (WTR::topLevelPath):
3209         (WTR::getOutputDir):
3210         (WTR::activateFonts):
3211         * WebKitTestRunner/TestController.cpp:
3212         (WTR::TestController::libraryPathForTesting):
3213         (WTR::TestController::generateContextConfiguration const):
3214         (WTR::TestController::generatePageConfiguration):
3215         (WTR::TestController::decideDestinationWithSuggestedFilename):
3216         (WTR::TestController::platformAdjustContext):
3217         * WebKitTestRunner/TestController.h:
3218         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3219         (WTR::TestController::cocoaPlatformInitialize):
3220         (WTR::TestController::platformAdjustContext):
3221         * WebKitTestRunner/gtk/main.cpp:
3222         (main):
3223         * WebKitTestRunner/mac/TestControllerMac.mm:
3224         (WTR::TestController::configureContentExtensionForTest):
3225         * WebKitTestRunner/wpe/main.cpp:
3226         (main):
3227         Utilize WTF::Environment where possible.
3228
3229 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3230
3231         [iOS] WKWebView callout bar is missing Change Writing Direction item
3232         https://bugs.webkit.org/show_bug.cgi?id=190015
3233         <rdar://problem/44810366>
3234
3235         Reviewed by Tim Horton.
3236
3237         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3238         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
3239
3240         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
3241         (TestWebKitAPI::TEST):
3242
3243 2019-02-15  Chris Dumez  <cdumez@apple.com>
3244
3245         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
3246         https://bugs.webkit.org/show_bug.cgi?id=194717
3247         <rdar://problem/47884404>
3248
3249         Reviewed by Brady Eidson.
3250
3251         Add API test coverage.
3252
3253         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3254
3255 2019-02-15  Youenn Fablet  <youenn@apple.com>
3256
3257         Make navigator.mediaDevices SecureContext
3258         https://bugs.webkit.org/show_bug.cgi?id=194666
3259
3260         Reviewed by Eric Carlson.
3261
3262         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3263         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3264         (TEST_F):
3265
3266 2019-02-15  Brian Burg  <bburg@apple.com>
3267
3268         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3269         https://bugs.webkit.org/show_bug.cgi?id=194411
3270         <rdar://problem/47787614>
3271
3272         Reviewed by Joseph Pecoraro.
3273
3274         Remove unnecessary soft linking macro usage.
3275
3276         * DumpRenderTree/mac/TestRunnerMac.mm:
3277         (TestRunner::inspectorTestStubURL):
3278         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3279         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3280         (WTR::TestRunner::inspectorTestStubURL):
3281
3282 2019-02-15  Commit Queue  <commit-queue@webkit.org>
3283
3284         Unreviewed, rolling out r241559 and r241566.
3285         https://bugs.webkit.org/show_bug.cgi?id=194710
3286
3287         Causes layout test crashes under GuardMalloc (Requested by
3288         ryanhaddad on #webkit).
3289
3290         Reverted changesets:
3291
3292         "[WTF] Add environment variable helpers"
3293         https://bugs.webkit.org/show_bug.cgi?id=192405
3294         https://trac.webkit.org/changeset/241559
3295
3296         "Unreviewed build fix for WinCairo Debug after r241559."
3297         https://trac.webkit.org/changeset/241566
3298
3299 2019-02-15  Zalan Bujtas  <zalan@apple.com>
3300
3301         [LFC] Out-of-flow box is never a float box
3302         https://bugs.webkit.org/show_bug.cgi?id=194704
3303
3304         Reviewed by Antti Koivisto.
3305
3306         * LayoutReloaded/misc/LFC-passing-tests.txt:
3307
3308 2019-02-10  Darin Adler  <darin@apple.com>
3309
3310         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
3311         https://bugs.webkit.org/show_bug.cgi?id=194487
3312
3313         Reviewed by Daniel Bates.
3314
3315         * DumpRenderTree/win/DumpRenderTree.cpp:
3316         (applicationId): Use makeString instead of String::format.
3317         (main): Ditto.
3318         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3319         (TestWebKitAPI::Util::createURLForResource): Ditto.
3320         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3321         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
3322
3323         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3324         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
3325         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
3326         (WTR::createStringWithAttributes): Use appendLiteral.
3327         (WTR::AccessibilityUIElement::helpText const): Ditto.
3328         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
3329         directly instead of using String::format.
3330         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
3331         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
3332
3333 2019-02-15  Truitt Savell  <tsavell@apple.com>
3334
3335         Unreviewed, rolling out r241564.
3336
3337         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
3338
3339         Reverted changeset:
3340
3341         "[Mac] WebInspectorUI.framework does not need to be soft-
3342         linked anymore"
3343         https://bugs.webkit.org/show_bug.cgi?id=194411
3344         https://trac.webkit.org/changeset/241564
3345
3346 2019-02-15  Saam barati  <sbarati@apple.com>
3347
3348         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
3349         https://bugs.webkit.org/show_bug.cgi?id=194036
3350
3351         Reviewed by Yusuke Suzuki.
3352
3353         * Scripts/run-jsc-stress-tests:
3354
3355 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3356
3357         Fix the build.
3358
3359         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3360         (WTR::UIScriptController::drawSquareInEditableImage):
3361         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3362         (TestWebKitAPI::drawSquareInEditableImage):
3363
3364 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3365
3366         Fix the build.
3367
3368         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3369         (WTR::UIScriptController::drawSquareInEditableImage):
3370         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3371         (TestWebKitAPI::drawSquareInEditableImage):
3372
3373 2019-02-14  Brian Burg  <bburg@apple.com>
3374
3375         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3376         https://bugs.webkit.org/show_bug.cgi?id=194411
3377         <rdar://problem/47787614>
3378
3379         Reviewed by Joseph Pecoraro.
3380
3381         Remove unnecessary soft linking macro usage.
3382
3383         * DumpRenderTree/mac/TestRunnerMac.mm:
3384         (TestRunner::inspectorTestStubURL):
3385         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3386         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3387         (WTR::TestRunner::inspectorTestStubURL):
3388
3389 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3390
3391         [ews-app] status bubble should fetch builder name info from BuilderMapping table
3392         https://bugs.webkit.org/show_bug.cgi?id=194599
3393
3394         Reviewed by Lucas Forschler.
3395
3396         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3397         (StatusBubble._build_bubble):
3398
3399 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3400
3401         [ews-app] Set Foreign Key in Django build model
3402         https://bugs.webkit.org/show_bug.cgi?id=194667
3403
3404         Reviewed by Lucas Forschler.
3405
3406         * BuildSlaveSupport/ews-app/ews/models/build.py:
3407         (Build):
3408
3409 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3410
3411         [WTF] Add environment variable helpers
3412         https://bugs.webkit.org/show_bug.cgi?id=192405
3413
3414         Reviewed by Michael Catanzaro.
3415
3416         * DumpRenderTree/mac/DumpRenderTree.mm:
3417         (libraryPathForDumpRenderTree):
3418         * DumpRenderTree/win/DumpRenderTree.cpp:
3419         (libraryPathForDumpRenderTree):
3420         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3421         (setUpIOSLayoutTestCommunication):
3422         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3423         (TestWebKitAPI::strip):
3424         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3425         (beforeAll):
3426         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3427         (main):
3428         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3429         (WebKitTestBus::run):
3430         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3431         (WTR::getOutputDir):
3432         (WTR::initializeFontConfigSetting):
3433         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3434         (WTR::InjectedBundle::platformInitialize):
3435         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3436         (WTR::topLevelPath):
3437         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3438         (WTR::topLevelPath):
3439         (WTR::getOutputDir):
3440         (WTR::activateFonts):
3441         * WebKitTestRunner/TestController.cpp:
3442         (WTR::TestController::libraryPathForTesting):
3443         (WTR::TestController::generateContextConfiguration const):
3444         (WTR::TestController::generatePageConfiguration):
3445         (WTR::TestController::decideDestinationWithSuggestedFilename):
3446         (WTR::TestController::platformAdjustContext):
3447         * WebKitTestRunner/TestController.h:
3448         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3449         (WTR::TestController::cocoaPlatformInitialize):
3450         (WTR::TestController::platformAdjustContext):
3451         * WebKitTestRunner/gtk/main.cpp:
3452         (main):
3453         * WebKitTestRunner/mac/TestControllerMac.mm:
3454         (WTR::TestController::configureContentExtensionForTest):
3455         * WebKitTestRunner/wpe/main.cpp:
3456         (main):
3457         Utilize WTF::Environment where possible.
3458
3459 2019-02-14  Chris Dumez  <cdumez@apple.com>
3460
3461         [PSON] Introduce a WebContent Process cache
3462         https://bugs.webkit.org/show_bug.cgi?id=194594
3463         <rdar://problem/46793397>
3464
3465         Reviewed by Geoff Garen.
3466
3467         Update API tests to turn on the WebContent Process cache.
3468
3469         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3470
3471 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
3472
3473         Unreviewed, build fix after r241480
3474
3475         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3476         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3477         (-[DragAndDropSimulator initWithWebView:]):
3478
3479 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
3480
3481         AX: ARIA Reflection was disabled in error
3482         https://bugs.webkit.org/show_bug.cgi?id=194647
3483         <rdar://problem/48068336>
3484
3485         Reviewed by Ryosuke Niwa.
3486
3487         Remove test override now that this feature should be enabled by default.
3488
3489         * WebKitTestRunner/TestController.cpp:
3490         (WTR::TestController::resetPreferencesToConsistentValues):
3491
3492 2019-02-14  Commit Queue  <commit-queue@webkit.org>
3493
3494         Unreviewed, rolling out r241486.
3495         https://bugs.webkit.org/show_bug.cgi?id=194655
3496
3497         causing API failures in builds (Requested by ShawnRoberts on
3498         #webkit).
3499
3500         Reverted changeset:
3501
3502         "[Cocoa] Media elements will restart network buffering just
3503         before suspending"
3504         https://bugs.webkit.org/show_bug.cgi?id=193691
3505         https://trac.webkit.org/changeset/241486
3506
3507 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3508
3509         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
3510         https://bugs.webkit.org/show_bug.cgi?id=194622
3511
3512         Reviewed by Antti Koivisto.
3513
3514         * LayoutReloaded/misc/LFC-passing-tests.txt:
3515
3516 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3517
3518         [LFC] Shrink-to-fit-width should be constrained by min/max width
3519         https://bugs.webkit.org/show_bug.cgi?id=194653
3520
3521         Reviewed by Antti Koivisto.
3522
3523         * LayoutReloaded/misc/LFC-passing-tests.txt:
3524
3525 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3526
3527         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
3528         https://bugs.webkit.org/show_bug.cgi?id=194641
3529
3530         Reviewed by Geoffrey Garen.
3531
3532         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
3533         so that the test would fail without this fix.
3534
3535         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3536         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3537
3538 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3539
3540         [ews-app] Change log level for a log statement
3541
3542         Unreviewed minor fix.
3543
3544         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3545         (Patch.save_patch):
3546
3547 2019-02-13  Jer Noble  <jer.noble@apple.com>
3548
3549         [Cocoa] Media elements will restart network buffering just before suspending
3550         https://bugs.webkit.org/show_bug.cgi?id=193691
3551
3552         Reviewed by Eric Carlson.
3553
3554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3555         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3556         (TEST):
3557
3558 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3559
3560         [ews-app] Fetch builder id to name mapping
3561         https://bugs.webkit.org/show_bug.cgi?id=194355
3562
3563         Reviewed by Lucas Forschler.
3564
3565         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3566         (Buildbot.get_builder_id_to_name_mapping):
3567         (Buildbot._get_display_name_from_builder_name):
3568
3569 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
3570
3571         Further restricting webarchive loads
3572         https://bugs.webkit.org/show_bug.cgi?id=194567
3573         <rdar://problem/47610130>
3574
3575         Reviewed by Youenn Fablet.
3576
3577         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
3578         navigations on drop.
3579
3580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3581         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
3582         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
3583         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3584         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3585         (TestWebKitAPI::TEST):
3586         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
3587         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
3588         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
3589         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3590         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3591         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3592         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
3593
3594 2019-02-13  John Wilander  <wilander@apple.com>
3595
3596         Store Ad Click Attribution requests in the network process
3597         https://bugs.webkit.org/show_bug.cgi?id=194510
3598         <rdar://problem/47650118>
3599
3600         Reviewed by Alex Christensen and Daniel Bates.
3601
3602         This patch adds two TestRunner functions:
3603         - dumpAdClickAttribution()
3604         - clearAdClickAttribution()
3605
3606         They call into the network process to dump and clear Ad Click
3607         Attribution state, respectively.
3608
3609         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3610         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3611         (WTR::TestRunner::dumpAdClickAttribution):
3612         (WTR::TestRunner::clearAdClickAttribution):
3613         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3614         * WebKitTestRunner/TestController.cpp:
3615         (WTR::TestController::resetStateToConsistentValues):
3616         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
3617         (WTR::adClickAttributionStringResultCallback):
3618         (WTR::TestController::dumpAdClickAttribution):
3619         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
3620         (WTR::adClickAttributionVoidCallback):
3621         (WTR::TestController::clearAdClickAttribution):
3622         * WebKitTestRunner/TestController.h:
3623         * WebKitTestRunner/TestInvocation.cpp:
3624         (WTR::TestInvocation::dumpResults):
3625         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3626         (WTR::TestInvocation::dumpAdClickAttribution):
3627         * WebKitTestRunner/TestInvocation.h:
3628
3629 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3630
3631         [ews-app] Generate status-bubble
3632         https://bugs.webkit.org/show_bug.cgi?id=194572
3633
3634         Reviewed by Lucas Forschler.
3635
3636         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3637         (StatusBubble._build_bubble):
3638         (StatusBubble._should_show_bubble_for):
3639         (StatusBubble._build_bubbles_for_patch):
3640
3641 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3642
3643         [ews-app] Add status bubble html template
3644         https://bugs.webkit.org/show_bug.cgi?id=194571
3645
3646         Reviewed by Lucas Forschler.
3647
3648         * BuildSlaveSupport/ews-app/ews/templates: Added.
3649         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
3650
3651 2019-02-12  Chris Dumez  <cdumez@apple.com>
3652
3653         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
3654         https://bugs.webkit.org/show_bug.cgi?id=194568
3655         <rdar://problem/47944490>
3656
3657         Reviewed by Ryosuke Niwa.
3658
3659         Add API test coverage.
3660
3661         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3662         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3663
3664 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3665
3666         webkitpy: Remove bug_dummy from parsed test expectations
3667         https://bugs.webkit.org/show_bug.cgi?id=194562
3668         <rdar://problem/47853999>
3669
3670         Reviewed by Lucas Forschler.
3671
3672         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3673         (TestExpectationParser):
3674         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
3675         skipped tests.
3676         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3677
3678 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
3679
3680         [ews-app] Add method to fetch patch
3681         https://bugs.webkit.org/show_bug.cgi?id=194518
3682
3683         Reviewed by Lucas Forschler.
3684
3685         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3686         (Patch.get_patch):
3687
3688 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3689
3690         [LFC] Expand tests coverage (60 new tests -> 860)
3691
3692         Unreviewed test gardening (run-singly, --child-processes=1).
3693
3694         * LayoutReloaded/misc/LFC-passing-tests.txt:
3695
3696 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3697
3698         Allow pages to trigger programmatic paste from script on iOS
3699         https://bugs.webkit.org/show_bug.cgi?id=194271
3700         <rdar://problem/47808810>
3701
3702         Reviewed by Tim Horton.
3703
3704         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
3705
3706         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3707         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3708         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3709         (WTR::UIScriptController::rectForMenuAction const):
3710
3711         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
3712         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
3713  &n