[EFL][jhbuild] Use tarballs for gstreamer instead of git
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2
3         [EFL][jhbuild] Use tarballs for gstreamer instead of git
4         https://bugs.webkit.org/show_bug.cgi?id=106552
5
6         Reviewed by Laszlo Gombos.
7
8         Use tarballs for gstreamer instead of git in EFL's jhbuild
9         to work around intermittent network issues on our build
10         bots. Tarballs are fully cached and require no network
11         operation if their checksum matches.
12
13         * efl/jhbuild.modules:
14
15 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
16
17         Add Mac WK2 EWS bots
18         https://bugs.webkit.org/show_bug.cgi?id=106590
19
20         Reviewed by Adam Barth.
21
22         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
23         Also add a deprecated MacWK2Port class.
24
25         * QueueStatusServer/model/queues.py:
26         (Queue):
27         * Scripts/webkitpy/common/config/ports.py:
28         (DeprecatedPort.port):
29         (MacWK2Port):
30         (MacWK2Port.run_webkit_tests_command):
31         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
32         (MacEWS):
33         (MacWK2EWS):
34         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
35         (_test_ewses):
36
37 2013-01-10  Dan Carney  <dcarney@google.com>
38
39         [chromium] move webpermissionclient related methods to TestRunner library
40         https://bugs.webkit.org/show_bug.cgi?id=106548
41
42         Reviewed by Jochen Eisinger.
43
44         * DumpRenderTree/DumpRenderTree.gypi:
45         * DumpRenderTree/chromium/DRTTestRunner.cpp:
46         (DRTTestRunner::DRTTestRunner):
47         (DRTTestRunner::reset):
48         * DumpRenderTree/chromium/DRTTestRunner.h:
49         (DRTTestRunner):
50         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
51         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
52         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
53         (WebKit):
54         (WebTestRunner::WebTestRunner::webPermissions):
55         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
56         (WebTestRunner::TestRunner::TestRunner):
57         (WebTestRunner::TestRunner::setDelegate):
58         (WebTestRunner):
59         (WebTestRunner::TestRunner::reset):
60         (WebTestRunner::TestRunner::webPermissions):
61         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
62         (WebTestRunner::TestRunner::setImagesAllowed):
63         (WebTestRunner::TestRunner::setScriptsAllowed):
64         (WebTestRunner::TestRunner::setStorageAllowed):
65         (WebTestRunner::TestRunner::setPluginsAllowed):
66         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
67         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
68         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
69         (WebTestRunner):
70         (TestRunner):
71         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
72         (WebTestRunner):
73         (WebTestRunner::WebPermissions::WebPermissions):
74         (WebTestRunner::WebPermissions::~WebPermissions):
75         (WebTestRunner::WebPermissions::allowImage):
76         (WebTestRunner::WebPermissions::allowScriptFromSource):
77         (WebTestRunner::WebPermissions::allowStorage):
78         (WebTestRunner::WebPermissions::allowPlugins):
79         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
80         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
81         (WebTestRunner::WebPermissions::setImagesAllowed):
82         (WebTestRunner::WebPermissions::setScriptsAllowed):
83         (WebTestRunner::WebPermissions::setStorageAllowed):
84         (WebTestRunner::WebPermissions::setPluginsAllowed):
85         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
86         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
87         (WebTestRunner::WebPermissions::setDelegate):
88         (WebTestRunner::WebPermissions::setDumpCallbacks):
89         (WebTestRunner::WebPermissions::reset):
90         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
91         (WebTestRunner):
92         (WebPermissions):
93         * DumpRenderTree/chromium/TestShell.cpp:
94         (TestShell::initialize):
95         (TestShell::resetTestController):
96         (TestShell::createNewWindow):
97         * DumpRenderTree/chromium/TestShell.h:
98         (TestShell):
99         * DumpRenderTree/chromium/WebViewHost.cpp:
100         (WebViewHost::normalizeLayoutTestURL):
101         * DumpRenderTree/chromium/WebViewHost.h:
102         (WebViewHost):
103
104 2013-01-10  Alan Cutter  <alancutter@chromium.org>
105
106         Split EWS tool cold-boot.sh into modular components
107         https://bugs.webkit.org/show_bug.cgi?id=106527
108
109         Reviewed by Adam Barth.
110
111         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
112         Updated GCE bot build scripts to match.
113         Unable to test scripts directly as they depend on being in the repository to work!
114
115         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
116         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
117         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
118         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
119         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
120
121 2013-01-10  Julie Parent  <jparent@chromium.org>
122
123         Dashboard Cleanup: Do not generate the page if we are about to reload.
124         https://bugs.webkit.org/show_bug.cgi?id=106584
125
126         Reviewed by Dirk Pranke.
127
128         Move the logic to determine if we should generate the page into
129         parseParameters() since that is where we have the knowledge to
130         determine it, and return that value to handleLocationChange, 
131         rather than passing the changed parameters back to handleLocationChange
132         and having it make the decision.
133         
134         This is logically equivalent, save one case: when we are about to do
135         a reload, we know that there is no reason to generate the page.  Old
136         code was causing an extra page generation in this case.
137         
138         * TestResultServer/static-dashboards/dashboard_base.js:
139         (parseParameters):
140         (handleLocationChange):
141
142 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
143
144         [jhbuild] Use the "configure" script to build glib
145         https://bugs.webkit.org/show_bug.cgi?id=106569
146
147         Reviewed by Martin Robinson.
148
149         So far both EFL and GTK have been using autogen.sh to build glib.
150         While that does work most of the time, it's not really needed since
151         we are downloading and building stable releases from tarballs.
152         Additionally, autogen.sh fails to work with automake 1.13 due to the
153         usage of some macros that have been removed (this has already been
154         fixed in glib master).
155
156         * efl/jhbuild.modules:
157         * gtk/jhbuild.modules:
158
159 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
160
161         Changing tests to be consistent and use self.scm rather then recreating the scm object.
162         (Missed a couple)
163         https://bugs.webkit.org/show_bug.cgi?id=106536
164
165         Reviewed by Eric Seidel.
166
167         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
168
169 2013-01-10  Tony Chang  <tony@chromium.org>
170
171         Speed up supplemental dependency computation
172         https://bugs.webkit.org/show_bug.cgi?id=106503
173
174         Reviewed by Adam Barth.
175
176         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
177
178         * WebKitTestRunner/CMakeLists.txt:
179
180 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
181
182         Remove the ENABLE_ANIMATION_API feature define occurences
183         https://bugs.webkit.org/show_bug.cgi?id=106544
184
185         Reviewed by Simon Fraser.
186
187         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
188         feature define handling still lingers in various build systems and configurations
189         but is of no use, so it should be removed.
190
191         * Scripts/webkitperl/FeatureList.pm:
192         * qmake/mkspecs/features/features.pri:
193
194 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
195
196         [GTK] Add support for loading web process extensions
197         https://bugs.webkit.org/show_bug.cgi?id=105631
198
199         Reviewed by Gustavo Noronha Silva.
200
201         * MiniBrowser/gtk/GNUmakefile.am:
202         * MiniBrowser/gtk/main.c:
203         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
204         bundle lib from build dir.
205         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
206         located in WebProcess/InjectedBundle/API/gtk.
207         * gtk/generate-gtkdoc:
208         (get_webkit2_options): Scan also files in
209         WebProcess/InjectedBundle/API/gtk to generate API docs.
210         (get_webkit2_options.injected_bundle_src_path): Helper function to
211         build paths in WebProcess/InjectedBundle/API/gtk.
212
213 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
214
215         [EFL][WK2] Writing immediately to created windows (open) fails
216         https://bugs.webkit.org/show_bug.cgi?id=105276
217
218         Reviewed by Kenneth Rohde Christiansen.
219
220         Do not reset 'about:blank' url for the new pages in mini browser.
221
222         * MiniBrowser/efl/main.c:
223         (window_create):
224
225 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
226
227         Changing tests to be consistent and use self.scm rather then recreating the scm object.
228         https://bugs.webkit.org/show_bug.cgi?id=106536
229
230         Reviewed by Eric Seidel.
231
232         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
233
234 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
235
236         Converting to unittest2 so we can use assertItemsEqual, making tests
237         not dependent on order of items.
238         https://bugs.webkit.org/show_bug.cgi?id=106532
239
240         Before:
241         Ran 1733 tests in 38.385s
242         FAILED (failures=1, errors=22)
243
244         After:
245         Ran 1733 tests in 32.298s
246         FAILED (failures=0, errors=22)
247
248         Reviewed by Eric Seidel.
249
250         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
251         * Scripts/webkitpy/thirdparty/__init__.py:
252         (AutoinstallImportHook._install_unittest2):
253
254 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
255
256         [EFL] Add gstreamer 1.0.5 to jhbuild
257         https://bugs.webkit.org/show_bug.cgi?id=106178
258
259         Reviewed by Laszlo Gombos.
260
261         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
262
263         * efl/jhbuild.modules:
264
265 2013-01-09  Alan Cutter  <alancutter@chromium.org>
266
267         Updated parameters in GCE build scripts so they now work.
268         https://bugs.webkit.org/show_bug.cgi?id=106523
269
270         Reviewed by Adam Barth.
271
272         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
273         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
274         * EWSTools/cold-boot.sh:
275
276 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
277
278         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
279         https://bugs.webkit.org/show_bug.cgi?id=106520
280
281         Reviewed by James Robinson.
282
283         Part of a larger refactoring series. See tracking bug 82948.
284
285         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
286         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
287
288 2013-01-09  Julie Parent  <jparent@chromium.org>
289
290         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
291         https://bugs.webkit.org/show_bug.cgi?id=106514
292
293         This is old code, as these can no longer get out of sync.
294         permmaLinkURLHash is generated from currentState, which is set only
295         from the location.  The commment about how these can get out of sync
296         refers to a function that no longer exists.
297         
298         Reviewed by Dirk Pranke.
299
300         * TestResultServer/static-dashboards/dashboard_base.js:
301         (handleLocationChange):
302
303 2013-01-09  Julie Parent  <jparent@chromium.org>
304
305         Dashboard Cleanup: Reload the page as soon as we know we need to.
306         https://bugs.webkit.org/show_bug.cgi?id=106515
307
308         No need to continue parsing all of the data once we know that
309         we need to do a reload.
310         
311         Reviewed by Dirk Pranke.
312
313         * TestResultServer/static-dashboards/dashboard_base.js:
314         (parseParameters):
315
316 2013-01-09  Eric Seidel  <eric@webkit.org>
317
318         run-perf-tests --chromium-android --profile should show symbols for the kernel
319         https://bugs.webkit.org/show_bug.cgi?id=106498
320
321         Reviewed by Adam Barth.
322
323         Turns out this was easy, once I finally read the output from "perf report".
324         It appears there may be a bug in "perf record" on android, as it complains
325         about not being able to read from /proc/kallsyms even when
326         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
327         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
328         but rather just flip it to 0 long enough to grab the /proc/kallsyms
329         and then flip it back to whatever the device had.
330
331         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
332         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
333         to symbol names.  Its world-readable, but will return all 0s if you
334         don't have permission to see the kernel symbols.  kptr_restrict
335         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
336         1 is only a specific group, and 2 is "no one, not even root".
337         By default kptr_restrict is 2 on Android it seems.
338         More kptr_restrict docs: http://lwn.net/Articles/420403/
339
340         I also took this opportunity to clean up how the perf record command
341         was built for use/display in AndroidPerf.profile_after_exit and
342         change to always using long-form names for the arguments (to hopefully help readability).
343
344         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
345         (AndroidPerf.__init__):
346         (profile_after_exit):
347         (ChromiumAndroidDriver.__init__):
348         (ChromiumAndroidDriver._update_kallsyms_cache):
349         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
350
351 2013-01-09  Julie Parent  <jparent@chromium.org>
352
353         Dashboard cleanup: remove dead code.
354         https://bugs.webkit.org/show_bug.cgi?id=106509
355
356         Reviewed by Dirk Pranke.
357
358         * TestResultServer/static-dashboards/dashboard_base.js:
359         (parseParameters):
360
361 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
362
363         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
364         https://bugs.webkit.org/show_bug.cgi?id=105638
365
366         Reviewed by Martin Robinson.
367
368         The test was failing for two reasons:
369         - AccessibilityRenderObject::correspondingLabelForControlElement() was
370           not ignoring the ARIA labelled-by property
371         - AccessibilityController::accessibleElementById() was not implemented
372
373         Because getting an element by ID cannot be done in the UIProcess, the
374         decision was made to expose the element's ID as an accessible attribute
375         of the object.
376
377         In addition, fixing the bug in AccessibilityRenderObject made it possible
378         to eliminate the Gtk platform-specific expectations for another test.
379
380         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
381         (childElementById): Added. Walks the tree looking for the AtkObject
382         Attribute which exposes the HTML element's ID.
383         (AccessibilityController::accessibleElementById): Implemented.
384         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
385         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
386         when there is no title, as is done with the Mac port.
387         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
388         (WTR):
389         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
390         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
391         Attribute which exposes the HTML element's ID.
392         (WTR):
393         (WTR::AccessibilityController::accessibleElementById): Implemented.
394         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
395         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
396         even when there is no title, as is done with the Mac port.
397
398 2013-01-09  Gregg Tavares  <gman@google.com>
399
400         Add Gregg Tavares as a committer
401         https://bugs.webkit.org/show_bug.cgi?id=106492
402
403         Unreviewed.
404
405         * Scripts/webkitpy/common/config/committers.py:
406
407 2013-01-09  Roger Fong  <roger_fong@apple.com>
408
409         Enable seamless iFrames for Windows DRT.
410         https://bugs.webkit.org/show_bug.cgi?id=106468.
411
412         Rubberstamped by Timothy Horton.
413
414         * DumpRenderTree/win/DumpRenderTree.cpp:
415         (resetDefaultsToConsistentValues):
416
417 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
418
419         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
420         https://bugs.webkit.org/show_bug.cgi?id=93979
421
422         Reviewed by Benjamin Poulain.
423
424         Implement eventSender.scheduleAsynchronousKeyDown() in
425         WebKitTestRunner.
426
427         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
428         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
429         (WTR::createKeyDownMessageBody):
430         (WTR::EventSendingController::keyDown):
431         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
432         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
433         (EventSendingController):
434         * WebKitTestRunner/TestController.cpp:
435         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
436         (WTR::TestController::didReceiveMessageFromInjectedBundle):
437         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
438         * WebKitTestRunner/TestController.h:
439         (TestController):
440
441 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
442
443         [chromium] move resource load callback dumping to TestRunner library
444         https://bugs.webkit.org/show_bug.cgi?id=106449
445
446         Reviewed by Adam Barth.
447
448         * DumpRenderTree/chromium/DRTTestRunner.cpp:
449         (DRTTestRunner::DRTTestRunner):
450         (DRTTestRunner::reset):
451         * DumpRenderTree/chromium/DRTTestRunner.h:
452         (DRTTestRunner):
453         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
454         (WebKit):
455         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
456         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
457         (WebKit):
458         (WebTestProxyBase):
459         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
460         (WebTestRunner::WebTestProxy::willRequestResource):
461         (WebTestRunner::WebTestProxy::willSendRequest):
462         (WebTestRunner::WebTestProxy::didReceiveResponse):
463         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
464         (WebTestRunner::WebTestProxy::didFailResourceLoad):
465         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
466         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
467         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
468         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
469         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
470         (WebTestRunner::TestRunner::TestRunner):
471         (WebTestRunner::TestRunner::reset):
472         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
473         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
474         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
475         (WebTestRunner):
476         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
477         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
478         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
479         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
480         (TestRunner):
481         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
482         (WebTestRunner::WebTestProxyBase::reset):
483         (WebTestRunner):
484         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
485         (WebTestRunner::WebTestProxyBase::willRequestResource):
486         (WebTestRunner::WebTestProxyBase::willSendRequest):
487         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
488         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
489         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
490         * DumpRenderTree/chromium/WebViewHost.cpp:
491         (WebViewHost::willSendRequest):
492         (WebViewHost::makeURLErrorDescription):
493         (WebViewHost::reset):
494         * DumpRenderTree/chromium/WebViewHost.h:
495         (WebViewHost):
496
497 2013-01-09  Dan Carney  <dcarney@google.com>
498
499         [chromium] move dumpcreateview methods to testrunner library
500         https://bugs.webkit.org/show_bug.cgi?id=106434
501
502         Reviewed by Adam Barth.
503
504         * DumpRenderTree/chromium/DRTTestRunner.cpp:
505         (DRTTestRunner::DRTTestRunner):
506         (DRTTestRunner::reset):
507         * DumpRenderTree/chromium/DRTTestRunner.h:
508         (DRTTestRunner):
509         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
510         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
511         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
512         (WebTestRunner::TestRunner::TestRunner):
513         (WebTestRunner::TestRunner::reset):
514         (WebTestRunner::TestRunner::shouldDumpCreateView):
515         (WebTestRunner):
516         (WebTestRunner::TestRunner::dumpCreateView):
517         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
518         (TestRunner):
519
520 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
521
522         webkitpy cleanup: Merge additional_comment_text into comment_text
523         https://bugs.webkit.org/show_bug.cgi?id=106421
524
525         Reviewed by Adam Barth.
526
527         * Scripts/webkitpy/common/config/committervalidator.py:
528         (CommitterValidator.reject_patch_from_commit_queue):
529         (CommitterValidator.reject_patch_from_review_queue):
530         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
531         (Bugzilla.set_flag_on_attachment):
532         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
533         (MockBugzilla.set_flag_on_attachment):
534         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
535         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
536         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
537         * Scripts/webkitpy/tool/commands/queues_unittest.py:
538
539 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
540
541         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
542         https://bugs.webkit.org/show_bug.cgi?id=106464
543
544         Reviewed by Martin Robinson.
545
546         Current version in jhbuild.modules (2.26.0) is giving trouble to
547         when trying to build WebKitGTK from scratch, due to a segmentation
548         fault error in gdk-pixbuf-query-loader during the 'make'
549         phase. Raising the version to 2.26.5 fixes this issue.
550
551         * gtk/jhbuild.modules: Version raised, checksums updated.
552
553 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
554
555         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
556         https://bugs.webkit.org/show_bug.cgi?id=90968.
557
558         Reviewed by Csaba Osztrogonác.
559
560         Added functionality in DRT and WTR to use any timeout value while running
561         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
562         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
563         to indicate whether the current port supports setting timeout value
564         per test (it's False by default; I enabled it only on Qt).
565         Also corrected a typo in driver.py
566
567         * DumpRenderTree/DumpRenderTree.h:
568         (TestCommand::TestCommand):
569         (TestCommand):
570         * DumpRenderTree/DumpRenderTreeCommon.cpp:
571         (parseInputLine):
572         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
573         (WebCore::DumpRenderTree::processLine):
574         * Scripts/webkitpy/layout_tests/port/base.py:
575         (Port.supports_per_test_timeout):
576         * Scripts/webkitpy/layout_tests/port/driver.py:
577         (Driver.run_test):
578         (Driver._command_from_driver_input):
579         * Scripts/webkitpy/layout_tests/port/qt.py:
580         (QtPort.supports_per_test_timeout):
581         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
582         (WTR::InjectedBundle::InjectedBundle):
583         (WTR::InjectedBundle::didReceiveMessage):
584         (WTR::InjectedBundle::beginTesting):
585         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
586         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
587         (WTR::TestRunner::setCustomTimeout):
588         (WTR):
589         * WebKitTestRunner/InjectedBundle/TestRunner.h:
590         (TestRunner):
591         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
592         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
593         * WebKitTestRunner/TestController.cpp:
594         (WTR::TestController::TestController):
595         (WTR::TestController::getCustomTimeout):
596         (WTR):
597         (WTR::TestCommand::TestCommand):
598         (TestCommand):
599         (WTR::parseInputLine):
600         (WTR::TestController::runTest):
601         (WTR::TestController::runUntil):
602         * WebKitTestRunner/TestController.h:
603         (TestController):
604         * WebKitTestRunner/TestInvocation.cpp:
605         (WTR::TestInvocation::TestInvocation):
606         (WTR::TestInvocation::setCustomTimeout):
607         (WTR):
608         (WTR::TestInvocation::invoke):
609         * WebKitTestRunner/TestInvocation.h:
610         (TestInvocation):
611
612 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
613
614         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
615         https://bugs.webkit.org/show_bug.cgi?id=106290
616
617         Reviewed by Martin Robinson.
618
619         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
620         the macro isn't enabled.
621
622         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
623
624 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
625
626         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
627         https://bugs.webkit.org/show_bug.cgi?id=103653
628
629         Reviewed by Anders Carlsson.
630
631         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
632         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
633         client callback.
634
635         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
636         methods to the JavaScript API.
637         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
638         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
639         (WTR::TestRunner::setAuthenticationUsername): Ditto.
640         (WTR::TestRunner::setAuthenticationPassword): Ditto.
641         * WebKitTestRunner/InjectedBundle/TestRunner.h:
642         (TestRunner): Added new declarations for the above.
643         * WebKitTestRunner/TestController.cpp:
644         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
645         callback.
646         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
647         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
648         the authentication information passed from the InjectedBundle.
649         * WebKitTestRunner/TestController.h:
650         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
651         to communicate with the TestController.
652         (WTR::TestController::setAuthenticationUsername): Ditto.
653         (WTR::TestController::setAuthenticationPassword): Ditto.
654         (TestController):
655         * WebKitTestRunner/TestInvocation.cpp:
656         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
657         information from the InjectedBundle.
658         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
659         text to the TestInvocation text output.
660         * WebKitTestRunner/TestInvocation.h:
661         (TestInvocation): Added declaration for new method.
662
663 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
664
665         Add myself as a watcher for Web Geolocation
666
667         Unreviewed.
668
669         * Scripts/webkitpy/common/config/watchlist:
670
671 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
672
673         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
674         https://bugs.webkit.org/show_bug.cgi?id=106364
675
676         Reviewed by Eric Seidel.
677
678         When the setup_test_run method is called on the subclasses of the base Port
679         interface, the parent method should also be called via super(), despite the
680         parent method not doing anything at the moment.
681
682         The according calls to super() are required in the ChromiumPort, EflPort
683         and GtkPort implementations.
684
685         * Scripts/webkitpy/layout_tests/port/chromium.py:
686         (ChromiumPort.setup_test_run):
687         * Scripts/webkitpy/layout_tests/port/efl.py:
688         (EflPort.setup_test_run):
689         * Scripts/webkitpy/layout_tests/port/gtk.py:
690         (GtkPort.setup_test_run):
691
692 2013-01-08  Julie Parent  <jparent@chromium.org>
693
694         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
695         https://bugs.webkit.org/show_bug.cgi?id=106356
696
697         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
698         dashboard_base, assigned by Loader, and used only by dashboard_base to
699         create error messages.  Moved the variables to be privates on the Loader
700         object, moved error message creation to _getLoadingErrorMessages on the
701         Loader object, and now pass the errors back to dashboard base via the
702         resourceLoadingComplete callback.
703         
704         Also removed the now unused clearError function, it was only being used
705         by unit tests to clean up global state.
706         
707         Reviewed by Dirk Pranke.
708
709         * TestResultServer/static-dashboards/dashboard_base.js:
710         (resourceLoadingComplete):
711         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
712         * TestResultServer/static-dashboards/loader.js:
713         (.):
714         * TestResultServer/static-dashboards/loader_unittests.js:
715
716 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
717
718         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
719         https://bugs.webkit.org/show_bug.cgi?id=106354
720
721         Reviewed by Eric Seidel.
722
723         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
724         instead of those two inheriting from it. Also add a mock object of the
725         sanitizer that's used in unit tests.
726
727         * Scripts/webkitpy/layout_tests/port/efl.py:
728         (EflPort):
729         (EflPort.__init__):
730         (EflPort.setup_test_run):
731         (EflPort.clean_up_test_run):
732         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
733         importing order.
734         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
735         * Scripts/webkitpy/layout_tests/port/gtk.py:
736         (GtkPort):
737         (GtkPort.__init__):
738         (GtkPort.setup_test_run):
739         (GtkPort.clean_up_test_run):
740         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
741         importing order.
742         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
743         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
744         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
745         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
746         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
747         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
748         (PulseAudioSanitizerMock.unload_pulseaudio_module):
749         (PulseAudioSanitizerMock.restore_pulseaudio_module):
750
751 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
752
753         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
754         https://bugs.webkit.org/show_bug.cgi?id=106324
755
756         Reviewed by Adam Barth.
757
758         Since the frame load callbacks are part of the WebFrameClient, the
759         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
760         methods.
761
762         * DumpRenderTree/chromium/DRTTestRunner.cpp:
763         (DRTTestRunner::DRTTestRunner):
764         (DRTTestRunner::reset):
765         * DumpRenderTree/chromium/DRTTestRunner.h:
766         (DRTTestRunner):
767         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
768         (WebTestInterfaces):
769         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
770         (WebKit):
771         (WebTestProxyBase):
772         (WebTestRunner):
773         (WebTestRunner::WebTestProxy::WebTestProxy):
774         (WebTestProxy):
775         (WebTestRunner::WebTestProxy::didInvalidateRect):
776         (WebTestRunner::WebTestProxy::didScrollRect):
777         (WebTestRunner::WebTestProxy::scheduleComposite):
778         (WebTestRunner::WebTestProxy::scheduleAnimation):
779         (WebTestRunner::WebTestProxy::setWindowRect):
780         (WebTestRunner::WebTestProxy::show):
781         (WebTestRunner::WebTestProxy::didAutoResize):
782         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
783         (WebTestRunner::WebTestProxy::startDragging):
784         (WebTestRunner::WebTestProxy::shouldBeginEditing):
785         (WebTestRunner::WebTestProxy::shouldEndEditing):
786         (WebTestRunner::WebTestProxy::shouldInsertNode):
787         (WebTestRunner::WebTestProxy::shouldInsertText):
788         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
789         (WebTestRunner::WebTestProxy::shouldDeleteRange):
790         (WebTestRunner::WebTestProxy::shouldApplyStyle):
791         (WebTestRunner::WebTestProxy::didBeginEditing):
792         (WebTestRunner::WebTestProxy::didChangeSelection):
793         (WebTestRunner::WebTestProxy::didChangeContents):
794         (WebTestRunner::WebTestProxy::didEndEditing):
795         (WebTestRunner::WebTestProxy::registerIntentService):
796         (WebTestRunner::WebTestProxy::dispatchIntent):
797         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
798         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
799         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
800         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
801         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
802         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
803         (WebTestRunner::WebTestProxy::didReceiveTitle):
804         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
805         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
806         (WebTestRunner::WebTestProxy::didFailLoad):
807         (WebTestRunner::WebTestProxy::didFinishLoad):
808         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
809         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
810         (WebTestRunner::WebTestProxy::didRunInsecureContent):
811         (WebTestRunner::WebTestProxy::didDetectXSS):
812         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
813         (WebTestRunner::WebTestRunner::setTestIsRunning):
814         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
815         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
816         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
817         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
818         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
819         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
820         (WebTestRunner::TestRunner::TestRunner):
821         (WebTestRunner::TestRunner::reset):
822         (WebTestRunner::TestRunner::setTestIsRunning):
823         (WebTestRunner):
824         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
825         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
826         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
827         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
828         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
829         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
830         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
831         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
832         (WebTestRunner::TestRunner::dumpTitleChanges):
833         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
834         (TestRunner):
835         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
836         (WebTestInterfaces::Internal):
837         (WebTestRunner::WebTestInterfaces::Internal::webView):
838         (WebTestRunner::WebTestInterfaces::Internal::Internal):
839         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
840         (WebTestRunner):
841         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
842         (WebTestRunner::WebTestInterfaces::setWebView):
843         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
844         (WebTestRunner::WebTestInterfaces::webView):
845         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
846         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
847         (WebTestRunner):
848         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
849         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
850         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
851         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
852         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
853         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
854         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
855         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
856         (WebTestRunner::WebTestProxyBase::didFailLoad):
857         (WebTestRunner::WebTestProxyBase::didFinishLoad):
858         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
859         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
860         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
861         (WebTestRunner::WebTestProxyBase::didDetectXSS):
862         * DumpRenderTree/chromium/TestShell.cpp:
863         (TestShell::runFileTest):
864         (TestShell::testFinished):
865         * DumpRenderTree/chromium/TestShell.h:
866         (TestShell):
867         * DumpRenderTree/chromium/WebViewHost.cpp:
868         (WebViewHost::didStartProvisionalLoad):
869         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
870         (WebViewHost::didFailProvisionalLoad):
871         (WebViewHost::didCommitProvisionalLoad):
872         (WebViewHost::didReceiveTitle):
873         (WebViewHost::didFailLoad):
874         (WebViewHost::didFinishLoad):
875         * DumpRenderTree/chromium/WebViewHost.h:
876         (WebViewHost):
877
878 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
879
880         [GTK] Lower the default timeout value for WebKitTestRunner
881         https://bugs.webkit.org/show_bug.cgi?id=106353
882
883         Reviewed by Dirk Pranke.
884
885         The default timeout value for WebKitTestRunner should be lowered.
886         The current value (80 seconds) is irrational and just leads to producing
887         text failures for layout tests that genuinely time out. This just leads
888         to more deviation from the GTK WK1 port in terms of test expectations.
889
890         The value used is the same as when running the DumpRenderTree, that's
891         6 seconds in release builds and 12 seconds in debug builds.
892
893         * Scripts/webkitpy/layout_tests/port/gtk.py:
894         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
895         (GtkPortTest.test_default_timeout_ms):
896
897 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
898
899         test-webkitpy shows failure output on my linux box
900         https://bugs.webkit.org/show_bug.cgi?id=101261
901
902         Reviewed by Eric Seidel.
903
904         Mock out the PulseAudioSanitizer methods when creating testing instances
905         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
906         PulseAudio output when the sanitizer was trying to unload modules which
907         were already unloaded by another unit test that was being run in parallel.
908
909         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
910         (EflPortTest):
911         (EflPortTest.make_port):
912         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
913         (GtkPortTest):
914         (GtkPortTest.make_port):
915
916 2013-01-08  Julie Parent  <jparent@chromium.org>
917
918         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
919         https://bugs.webkit.org/show_bug.cgi?id=106254
920
921         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
922         only to figure out if we should call addBuilderLoadErrors during
923         handleLocationChange, which was called when the loader completed and on
924         any hash change, but we only ever wanted to call addBuilderLoadErrors
925         on the initial loader load.  Moved the call of addBuilderLoadErrors to
926         resourceLoadingComplete rather than handleLocationChange, so now we
927         only call it when we want to, and the check can go away completely.
928
929         Reviewed by Dirk Pranke.
930
931         * TestResultServer/static-dashboards/dashboard_base.js:
932         (addBuilderLoadErrors):
933         (resourceLoadingComplete):
934         (handleLocationChange):
935         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
936
937 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
938
939         Add aboxhall@chromium.org to accessibility watchlist.
940
941         Unreviewed.
942
943         * Scripts/webkitpy/common/config/watchlist:
944
945 2013-01-08  Dan Winship  <danw@gnome.org>
946
947         Add Apache 2.4 support for Fedora 18
948         https://bugs.webkit.org/show_bug.cgi?id=104478
949
950         Reviewed by Martin Robinson.
951
952         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
953         need a separate config.
954
955         * Scripts/webkitpy/layout_tests/port/base.py:
956         (Port._apache_version):
957         (Port._apache_config_file_name_for_platform):
958         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
959         * Scripts/run-webkit-httpd:
960         * Scripts/webkitperl/httpd.pm:
961         (getApacheVersion):
962         (getDefaultConfigForTestDirectory):
963         (getHTTPDConfigPathForTestDirectory):
964
965 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
966
967         Make the override-feature-defines script compatible with Python v3
968         https://bugs.webkit.org/show_bug.cgi?id=105742
969
970         Reviewed by Martin Robinson.
971
972         Instead of printing output through a statement, use the print function and format
973         the output using the str.format method. This makes the script runnable with Python v3.
974
975         * gtk/override-feature-defines:
976         (adjust_feature_defines_makefile):
977
978 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
979
980         [Qt] Fix libxml2 config test
981         https://bugs.webkit.org/show_bug.cgi?id=106317
982
983         Reviewed by Simon Hausmann.
984
985         Don't assume standard include/libxml2, libxml-2.0.pc should know
986         where it's headers are.
987
988         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
989
990 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
991
992         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
993         https://bugs.webkit.org/show_bug.cgi?id=106195
994
995         Reviewed by Philippe Normand.
996
997         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
998         to make the Python code compatible with Python 3. This includes modifying
999         print statements, exception handling, dictionary iteration and
1000         byte-sequence-to-string conversion.
1001
1002         * gtk/common.py:
1003         (get_build_path):
1004         (pkg_config_file_variable):
1005         (gtk_version_of_pkg_config_file):
1006         * gtk/generate-gtkdoc:
1007         (print_missing_api):
1008         * gtk/gtkdoc.py:
1009         (GTKDoc.__init__):
1010         (GTKDoc._run_command):
1011
1012 2013-01-02  Steve Block  <steveblock@chromium.org>
1013
1014         Add chromium.org email address for Steve Block.
1015
1016         Unreviewed.
1017
1018         * Scripts/webkitpy/common/config/committers.py:
1019
1020 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
1021
1022         Rationalize closure call heuristics and profiling
1023         https://bugs.webkit.org/show_bug.cgi?id=106270
1024
1025         Reviewed by Oliver Hunt.
1026         
1027         Add ability to use display-profiler-output via a pipe, and add the ability to dump
1028         all generated code ('display *' or 'd *').
1029
1030         * Scripts/display-profiler-output:
1031
1032 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1033
1034         Sorted more xcodeproj files.
1035
1036         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1037         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1038         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1039
1040 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1041
1042         Sorted xcodeproj files.
1043
1044         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1045         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1046
1047 2013-01-07  Dan Bernstein  <mitz@apple.com>
1048
1049         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
1050         https://bugs.webkit.org/show_bug.cgi?id=106261
1051
1052         Reviewed by Simon Fraser.
1053
1054         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
1055
1056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1057         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
1058         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
1059         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
1060         (TestWebKitAPI):
1061         (TestWebKitAPI::TEST):
1062
1063 2013-01-07  Ojan Vafai  <ojan@chromium.org>
1064
1065         Add the Apple MountainLion bots to garden-o-matic.
1066         Eventually, we really should move away from hardcoding
1067         the list of bots.
1068
1069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1070
1071 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1072
1073         [chromium] move web audio related methods to testrunner library
1074         https://bugs.webkit.org/show_bug.cgi?id=106211
1075
1076         Reviewed by Adam Barth.
1077
1078         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1079         (DRTTestRunner::DRTTestRunner):
1080         (DRTTestRunner::reset):
1081         * DumpRenderTree/chromium/DRTTestRunner.h:
1082         (DRTTestRunner):
1083         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1084         (WebKit):
1085         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
1086         (WebTestRunner::WebTestRunner::audioData):
1087         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1088         (WebTestRunner::TestRunner::TestRunner):
1089         (WebTestRunner::TestRunner::reset):
1090         (WebTestRunner::TestRunner::shouldDumpAsAudio):
1091         (WebTestRunner):
1092         (WebTestRunner::TestRunner::audioData):
1093         (WebTestRunner::TestRunner::setAudioData):
1094         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1095         (TestRunner):
1096         * DumpRenderTree/chromium/TestShell.cpp:
1097         (TestShell::dump):
1098
1099 2013-01-07  Mike West  <mkwst@chromium.org>
1100
1101         Make the IFRAME_SEAMLESS flag runtime-enabled.
1102         https://bugs.webkit.org/show_bug.cgi?id=106213
1103
1104         Reviewed by Ojan Vafai.
1105
1106         * DumpRenderTree/chromium/TestShell.cpp:
1107         (TestShell::TestShell):
1108         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1109         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1110         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1111         (resetDefaultsToConsistentValues):
1112         * DumpRenderTree/mac/DumpRenderTree.mm:
1113         (resetDefaultsToConsistentValues):
1114         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1115         (WebCore::WebPage::resetSettings):
1116         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1117         (WTR::InjectedBundle::beginTesting):
1118             Ensure that seamless IFrames are enabled for layout tests in each of
1119             the ports that support seamless IFrames.
1120
1121 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1122
1123         [chromium] move dumpAsText and friends to the TestRunner library
1124         https://bugs.webkit.org/show_bug.cgi?id=106222
1125
1126         Reviewed by Adam Barth.
1127
1128         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
1129
1130         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1131         (DRTTestRunner::DRTTestRunner):
1132         (DRTTestRunner::reset):
1133         * DumpRenderTree/chromium/DRTTestRunner.h:
1134         (DRTTestRunner):
1135         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1136         (WebTestRunner::WebTestRunner::shouldDumpAsText):
1137         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
1138         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
1139         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
1140         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
1141         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
1142         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1143         (WebTestRunner::TestRunner::TestRunner):
1144         (WebTestRunner::TestRunner::reset):
1145         (WebTestRunner::TestRunner::shouldDumpAsText):
1146         (WebTestRunner):
1147         (WebTestRunner::TestRunner::setShouldDumpAsText):
1148         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
1149         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
1150         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
1151         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
1152         (WebTestRunner::TestRunner::dumpAsText):
1153         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
1154         (WebTestRunner::TestRunner::dumpChildFramesAsText):
1155         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1156         (TestRunner):
1157
1158 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1159
1160         Build fix attempt after r138810.
1161
1162         Apparently python 2.6 is really bad at floating point computation.
1163
1164         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1165         (MainTest.test_run_memory_test):
1166
1167 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1168
1169         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
1170         https://bugs.webkit.org/show_bug.cgi?id=106172
1171
1172         Reviewed by Tony Chang.
1173
1174         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
1175         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
1176         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
1177         test on perf-o-matic and perf. test's results page.
1178
1179         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
1180
1181         * Scripts/webkitpy/performance_tests/perftest.py:
1182         (PerfTestMetric): Added.
1183         (PerfTestMetric.__init__): Added.
1184         (PerfTestMetric.metric): Added.
1185         (PerfTestMetric.has_values): Added.
1186         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
1187         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
1188         conversions to be done on the client side (perf-o-matic and results page).
1189         (PerfTestMetric.append): Added.
1190         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
1191         a result for this metric.
1192         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
1193         (PerfTestMetric.compute_statistics): Moved from PerfTest.
1194
1195         (PerfTest._create_driver): Extracted from PerfTest.run.
1196         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
1197         as needed.
1198         (PerfTest._run_with_driver):
1199         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
1200         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
1201         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
1202
1203         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
1204         from other perf tests, there isn't much point in sharing the code here.
1205
1206         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
1207         statistics for the measured values.
1208
1209         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1210         (TestPerfTestMetric): Added.
1211         (TestPerfTestMetric.test_init_set_missing_unit): Added.
1212         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
1213         (TestPerfTestMetric.test_has_values): Added.
1214         (TestPerfTestMetric.test_append): Added.
1215         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
1216         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
1217
1218         (TestPerfTest._assert_results_are_correct): Updated as needed.
1219         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
1220         in PerfTest.run now after generating the results dictionary.
1221         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
1222
1223 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
1224
1225         Support size_t multiplication and division operators on LayoutUnit
1226         https://bugs.webkit.org/show_bug.cgi?id=83848
1227
1228         Reviewed by Emil A Eklund.
1229
1230         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1231         Added some simple tests for the new operators using size_t.
1232
1233 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1234
1235         [Qt] run-webkit-tests cleanup for parallel NRWT
1236         https://bugs.webkit.org/show_bug.cgi?id=106220
1237
1238         Reviewed by Dirk Pranke.
1239
1240         * Scripts/run-webkit-tests:
1241         (useNewRunWebKitTests):
1242         * Scripts/webkitpy/layout_tests/port/qt.py:
1243         (QtPort):
1244         (QtPort.default_child_processes):
1245
1246 2013-01-07  Philippe Normand  <pnormand@igalia.com>
1247
1248         Create a GStreamerAudio watchlist and add myself to it.
1249
1250         Unreviewed.
1251
1252         * Scripts/webkitpy/common/config/watchlist:
1253
1254 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
1255
1256         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
1257         Also removed the empty mac directory.
1258
1259         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
1260         * BuildSlaveSupport/download-built-product: Added property svn:executable.
1261         * BuildSlaveSupport/mac: Removed.
1262         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
1263
1264 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1265
1266         Add a script to delete stale zero-byte build files
1267         https://bugs.webkit.org/show_bug.cgi?id=106131
1268
1269         Reviewed by Tony Chang.
1270
1271         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
1272
1273         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1274         (DeleteStaleBuildFiles): Added.
1275         (Factory.__init__): Add DeleteStaleBuildFiles step.
1276         * BuildSlaveSupport/delete-stale-build-files: Added.
1277         (main): Delete zero-byte files except ones intentionally generated by our build process.
1278         (webkitBuildDirectory): Copied from build-product-archive.
1279
1280 2013-01-04  Michael Pruett  <michael@68k.org>
1281
1282         [GTK] Fix build error on GTK due to r138836
1283         https://bugs.webkit.org/show_bug.cgi?id=106154
1284
1285         Reviewed by Kentaro Hara.
1286
1287         * GNUmakefile.am:
1288
1289 2013-01-04  Dan Bernstein  <mitz@apple.com>
1290
1291         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
1292         https://bugs.webkit.org/show_bug.cgi?id=106121
1293
1294         Reviewed by Adele Peterson.
1295
1296         Added test for -[DOMTHMLTableCellElement _cellAbove].
1297
1298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1299         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
1300         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
1301         (TestWebKitAPI):
1302         (TestWebKitAPI::expectCellAboveCell):
1303         (TestWebKitAPI::TEST):
1304         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
1305
1306 2013-01-04  Eric Seidel  <eric@webkit.org>
1307
1308         FlakyTestReporter should be re-enabled and taught how to post patches
1309         https://bugs.webkit.org/show_bug.cgi?id=103839
1310
1311         Reviewed by Adam Barth.
1312
1313         This moves LayoutTestResultsReader off of the DeprecatedPort object.
1314         It also adds a real Port object to the EWS and CommitQueue objects
1315         using a new PatchProcessingQueue superclass.
1316         PatchProcessingQueue doesn't seem to be the cleanest insertion point
1317         but works for this purpose.
1318         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
1319         to resolve a FIXME.
1320
1321         This required some hacks/shiming between the non-specific "old"
1322         port names which the EWS system is currently using, and the new
1323         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
1324
1325         Hopefully this will fix the flaky test reporter and results uploading.
1326         Certainly it's another small step towards getting rid of the old ports.py
1327         infrastructure and making the NRWT Port class common webkitpy infrastructure.
1328
1329         Now that DeprecatedPort is no longer used for the results directory
1330         I removed all the explicit results-dir code which webkit-patch was using
1331         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
1332
1333         * Scripts/webkitpy/common/config/ports.py:
1334         (DeprecatedPort.run_perl_unittests_command):
1335         * Scripts/webkitpy/common/config/ports_mock.py:
1336         (MockPort.name):
1337         * Scripts/webkitpy/common/system/outputcapture.py:
1338         (OutputCapture.assert_outputs):
1339         * Scripts/webkitpy/layout_tests/port/apple.py:
1340         (ApplePort.determine_full_port_name):
1341         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1342         (LayoutTestResultsReader.__init__):
1343         (LayoutTestResultsReader):
1344         (LayoutTestResultsReader._read_file_contents):
1345         (LayoutTestResultsReader._create_layout_test_results):
1346         (LayoutTestResultsReader._create_unit_test_results):
1347         (LayoutTestResultsReader.results):
1348         (LayoutTestResultsReader.archive):
1349         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1350         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1351         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1352         (test_missing_unit_test_results_path):
1353         (test_layout_test_results):
1354         (test_archive_last_layout_test_results):
1355         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1356         (AbstractEarlyWarningSystem):
1357         (AbstractEarlyWarningSystem.__init__):
1358         (AbstractEarlyWarningSystem.begin_work_queue):
1359         (AbstractEarlyWarningSystem.run_command):
1360         * Scripts/webkitpy/tool/commands/queues.py:
1361         (AbstractPatchQueue.work_item_log_path):
1362         (PatchProcessingQueue):
1363         (PatchProcessingQueue._new_port_name_from_old):
1364         (PatchProcessingQueue.begin_work_queue):
1365         (PatchProcessingQueue._upload_results_archive_for_patch):
1366         (CommitQueue):
1367         (CommitQueue.begin_work_queue):
1368         (CommitQueue.run_command):
1369         (AbstractReviewQueue):
1370         (AbstractReviewQueue.__init__):
1371         (AbstractReviewQueue.begin_work_queue):
1372         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1373         (AbstractPatchQueueTest.test_next_patch):
1374         (PatchProcessingQueueTest):
1375         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1376         * Scripts/webkitpy/tool/steps/runtests.py:
1377         (RunTests.run):
1378         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1379
1380 2013-01-04  Dana Jansens  <danakj@chromium.org>
1381
1382         [chromium] Remove lost-compositor-context layout tests
1383         https://bugs.webkit.org/show_bug.cgi?id=106089
1384
1385         Reviewed by James Robinson.
1386
1387         Remove the loseCompositorContext() test function.
1388
1389         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1390         (WebTestRunner::TestRunner::TestRunner):
1391         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1392         (TestRunner):
1393
1394 2013-01-04  Adam Klein  <adamk@chromium.org>
1395
1396         Remove ENABLE_MUTATION_OBSERVERS #define
1397         https://bugs.webkit.org/show_bug.cgi?id=105459
1398
1399         Reviewed by Ryosuke Niwa.
1400
1401         * Scripts/webkitperl/FeatureList.pm:
1402         * qmake/mkspecs/features/features.pri:
1403
1404 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1405
1406         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
1407         https://bugs.webkit.org/show_bug.cgi?id=106078
1408
1409         Reviewed by Tony Chang.
1410
1411         This patch updates values for individual iterations in dummy performance tests used in
1412         perftest_unittest.py and perftest_integrationtest.py so that they match up with
1413         statistics such as stdev and median reported in those tests. This change is required
1414         to resolve the bug 97510.
1415
1416         This patch also refactors integration tests by extracting *TestData classes that
1417         centralizes the definitions of each dummy performance test's text (DRT output),
1418         runner output, and parsed results (JSON) so that we may share more data between
1419         python tests.
1420
1421         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1422         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
1423         Use self.assertAlmostEqual when comparing the standard deviation.
1424         (MainTest.test_parse_output):
1425         (test_parse_output_with_failing_line):
1426         (test_parse_output_with_description): Use _assert_results_are_correct.
1427         (test_parse_output_with_subtests): Ditto.
1428
1429         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1430         (InspectorPassTestData): Extracted from tests below.
1431         (EventTargetWrapperTestData): Ditto.
1432         (SomeParserTestData): Ditto.
1433         (MemoryTestData): Ditto.
1434         (TestDriver.run_test): Moved test definitions out of the method.
1435         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
1436         (MainTest._load_output_json): Extracted from create_runner.
1437         (MainTest.create_runner):
1438         (MainTest.test_run_test_set_for_parser_tests):
1439         (MainTest.test_run_memory_test):
1440         (MainTest._test_run_with_json_output):
1441         (MainTest.test_run_with_json_output):
1442         (MainTest.test_run_with_description):
1443         (MainTest.test_run_generates_json_by_default):
1444         (MainTest.test_run_merges_output_by_default):
1445         (MainTest.test_run_respects_reset_results):
1446         (MainTest.test_run_generates_and_show_results_page):
1447         (MainTest.test_run_with_slave_config_json):
1448         (MainTest.test_run_with_multiple_repositories):
1449
1450 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
1451
1452         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
1453         https://bugs.webkit.org/show_bug.cgi?id=106045
1454
1455         Reviewed by Carlos Garcia Campos.
1456
1457         Update test results to confirm that compositions without preedits do not trigger
1458         a composition confirmation.
1459
1460         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
1461         (TestWebKitAPI::verifyCanceledComposition):
1462
1463 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
1464
1465         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
1466         https://bugs.webkit.org/show_bug.cgi?id=105958
1467
1468         Reviewed by Alexey Proskuryakov.
1469
1470         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
1471
1472         * WebKitTestRunner/mac/EventSenderProxy.mm:
1473         (KeyMappingEntry):
1474         (WTR):
1475         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
1476
1477 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
1478
1479         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
1480         https://bugs.webkit.org/show_bug.cgi?id=106073
1481
1482         Reviewed by Ryosuke Niwa.
1483
1484         Check that the element being compared to is not nil. 
1485         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
1486         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
1487         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
1488         sometimes before on parallel WebKitTestRunner runs.
1489
1490         * DumpRenderTree/AccessibilityUIElement.cpp:
1491         (AccessibilityUIElement::isEqual):
1492         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1493         (WTR::AccessibilityUIElement::isEqual):
1494
1495 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1496
1497         Downloads can be flaky, so try downloading multiple times.
1498         https://bugs.webkit.org/show_bug.cgi?id=105976
1499
1500         Reviewed by Eric Seidel.
1501
1502         * Scripts/webkitpy/common/system/autoinstall.py:
1503         (AutoInstaller._download_to_stream):
1504
1505 2013-01-03  Eric Seidel  <eric@webkit.org>
1506
1507         Rename Tool.port to deprecated_port in preparation for removing more callers
1508         https://bugs.webkit.org/show_bug.cgi?id=106076
1509
1510         Reviewed by Ryosuke Niwa.
1511
1512         This resolves a long-standing FIXME to rename this method. :)
1513
1514         * Scripts/webkitpy/tool/bot/botinfo.py:
1515         (BotInfo.summary_text):
1516         * Scripts/webkitpy/tool/bot/irc_command.py:
1517         (Rollout._update_working_copy):
1518         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1519         (LayoutTestResultsReader._create_layout_test_results):
1520         (LayoutTestResultsReader._create_unit_test_results):
1521         (LayoutTestResultsReader._results_directory):
1522         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1523         (test_missing_unit_test_results_path):
1524         * Scripts/webkitpy/tool/main.py:
1525         (WebKitPatch.deprecated_port):
1526         * Scripts/webkitpy/tool/mocktool.py:
1527         (MockTool.deprecated_port):
1528         * Scripts/webkitpy/tool/steps/build.py:
1529         (Build.build):
1530         * Scripts/webkitpy/tool/steps/checkstyle.py:
1531         (CheckStyle.run):
1532         * Scripts/webkitpy/tool/steps/commit.py:
1533         (Commit._check_test_expectations):
1534         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1535         (PrepareChangeLog.run):
1536         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1537         (PrepareChangeLogForDEPSRoll.run):
1538         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1539         (PrepareChangeLogForRevert.run):
1540         * Scripts/webkitpy/tool/steps/runtests.py:
1541         (RunTests.run):
1542         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1543         (StepsTest.test_runtests_args):
1544         * Scripts/webkitpy/tool/steps/update.py:
1545         (Update._update_command):
1546
1547 2013-01-03  Eric Seidel  <eric@webkit.org>
1548
1549         Add myself to the webkitpy watchlist.
1550
1551         Unreviewed.
1552
1553         * Scripts/webkitpy/common/config/watchlist:
1554
1555 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1556
1557         Cleanup perftest* tests and add a test for computing statistics
1558         https://bugs.webkit.org/show_bug.cgi?id=105685
1559
1560         Reviewed by Eric Seidel.
1561
1562         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
1563         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
1564
1565         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
1566
1567         * Scripts/webkitpy/performance_tests/perftest.py:
1568         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
1569         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
1570         accurate result for the mean.
1571         (PageLoadingPerfTest.run_single):
1572         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1573         (MainTest.test_compute_statistics):
1574         (MainTest.test_compute_statistics.compute_statistics): Added.
1575         (TestPageLoadingPerfTest.test_run): floatify values.
1576         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
1577         correctly recognizes them as integers.
1578
1579         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
1580         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
1581         (TestDriver): Moved out of MainTest.
1582         (MainTest): Got rid of assertWritten and all unit tests.
1583         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
1584         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1585         (MainTest.test_run_test_set_for_parser_tests):
1586         (MainTest.test_run_memory_test):
1587         (MainTest._test_run_with_json_output):
1588         (MainTest.test_run_generates_json_by_default):
1589         (MainTest.test_run_merges_output_by_default):
1590         (MainTest.test_run_respects_reset_results):
1591         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
1592         parsing output JSON files. Just verify that the output path is correct instead.
1593         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1594         (MainTest): Removed all integration tests.
1595         (MainTest.create_runner): Simplified.
1596
1597 2013-01-03  Julie Parent  <jparent@chromium.org>
1598
1599         Dashboard cleanup: remove usage of global g_defaultBuilderName
1600         https://bugs.webkit.org/show_bug.cgi?id=106043
1601
1602         Use now public defaultBuilder() from the BuilderGroup, rather
1603         than global variable.
1604
1605         Also eliminates the setup() and initBuilders() functions since we
1606         no longer need to track the global.
1607
1608         Reviewed by Adam Barth.
1609
1610         * TestResultServer/static-dashboards/builders.js:
1611         (BuilderGroup.prototype.defaultBuilder):
1612         (BuilderGroup.prototype.master):
1613         * TestResultServer/static-dashboards/dashboard_base.js:
1614         (parseParameters):
1615         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1616         (updateDefaultBuilderState):
1617         * TestResultServer/static-dashboards/loader.js:
1618         (.):
1619         * TestResultServer/static-dashboards/loader_unittests.js:
1620
1621 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1622
1623         Disable an intermittently failing unit test for now.
1624         The failure is tracked by the bug 106051.
1625
1626         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1627         (TestWebKitAPI::TEST):
1628
1629 2013-01-03  Dan Bernstein  <mitz@apple.com>
1630
1631         No way to obtain a DOMNode given a JS wrapper for a Node
1632         https://bugs.webkit.org/show_bug.cgi?id=106033
1633
1634         Added a test for +[DOMNode _nodeFromJSWrapper:].
1635
1636         Reviewed by Sam Weinig.
1637
1638         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1639         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
1640         (TestWebKitAPI):
1641         (TestWebKitAPI::TEST):
1642
1643 2013-01-03  Emil A Eklund  <eae@chromium.org>
1644
1645         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
1646         https://bugs.webkit.org/show_bug.cgi?id=105961
1647
1648         Reviewed by Levi Weintraub.
1649         
1650         Add tests for LayoutUnit::ceil and floor.
1651
1652         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1653         (TestWebKitAPI::TEST):
1654         (TestWebKitAPI):
1655
1656 2013-01-03  Julie Parent  <jparent@chromium.org>
1657
1658         Add unit test for default builder for the dashboards.
1659         https://bugs.webkit.org/show_bug.cgi?id=105972
1660
1661         Reviewed by Dirk Pranke.
1662
1663         * TestResultServer/static-dashboards/loader_unittests.js:
1664
1665 2013-01-03  Tony Chang  <tony@chromium.org>
1666
1667         Generate internal.settings from Settings.in
1668         https://bugs.webkit.org/show_bug.cgi?id=104740
1669
1670         Reviewed by Adam Barth.
1671
1672         * GNUmakefile.am: Compile new generated files on GTK+.
1673         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1674         with both extra_sources and add_output_to_sources=false will still
1675         compile the files in extra_sources. This makes it possible to compile
1676         InternalSettingsGenerated.cpp and not be confused by
1677         InternalSettingsGenerated.idl.
1678
1679 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
1680
1681         [style] WebIDL-reflecting uppercase enums reported as style violation
1682         https://bugs.webkit.org/show_bug.cgi?id=105832
1683
1684         Reviewed by Tony Chang.
1685
1686         Recognize the enum as WebIDL-reflecting one if there's a comment present that
1687         indicates this. In enums spanning over multiple lines, the comment is expected
1688         on the first line. In enums placed in one line, the comment is expected at the
1689         end of that line.
1690
1691         WebIDL-reflecting enum values are required to be written in uppercase and as such
1692         violate the common rule of these values being written in InterCaps. Annotating
1693         enums this way makes it possible to avoid false style violation reports.
1694
1695         The comment is of form '// Web(?:Kit)?IDL enum'.
1696
1697         * Scripts/webkitpy/style/checkers/cpp.py:
1698         (_EnumState.__init__):
1699         (_EnumState.process_clean_line):
1700         (check_enum_casing):
1701         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1702         (NoNonVirtualDestructorsTest.test_enum_casing):
1703
1704 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1705
1706         Adding favicon.ico to the garden-o-matic.
1707         https://bugs.webkit.org/show_bug.cgi?id=105982
1708
1709         Reviewed by Adam Barth.
1710
1711         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1712         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
1713
1714 2013-01-03  Jonathan Liu  <net147@gmail.com>
1715
1716         [Qt] Fix library linking order
1717         https://bugs.webkit.org/show_bug.cgi?id=105818
1718
1719         Some Qt libraries are linked before the private static libraries
1720         that depend on them which results in QtWebKit failing to link.
1721
1722         Copy Qt module dependencies from QT to QT_PRIVATE when creating
1723         module to ensure the Qt libraries are linked after the private
1724         static libraries that depend on them.
1725
1726         Reviewed by Tor Arne Vestbø.
1727
1728         * qmake/mkspecs/features/default_post.prf:
1729
1730 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
1731
1732         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
1733         https://bugs.webkit.org/show_bug.cgi?id=102209
1734
1735         Reviewed by Gyuyoung Kim.
1736
1737         Set tooltip on the elm_window instead of ewk_view, and add delay to
1738         show the tooltip window.
1739
1740         Setting tooltip on the ewk_view makes elementary error message because
1741         ewk_view is not an elementary widget. To remove the error message,
1742         tooltip should be set on the elm_window.
1743
1744         Most browsers show the tooltip after a mouse pointer stays on an
1745         element object that has tooltip text.
1746         But elm_tooltip widget itself doesn't have delay or handle mouse
1747         events to show/hide.
1748
1749         So additional codes are added to show/hide tooltip widget along with
1750         mouse events.
1751           1) When a mouse pointer stays for a second on an element which has
1752              tooltip text, then tooltip widget is displayed.
1753           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
1754              widget.
1755
1756         * MiniBrowser/efl/main.c:
1757         (_Tooltip_Information):
1758         (_Browser_Window):
1759         (on_tooltip_show):
1760         (window_tooltip_hide):
1761         (window_tooltip_update):
1762         (on_mouse_in):
1763         (on_mouse_move):
1764         (on_mouse_out):
1765         (window_free):
1766         (on_tooltip_text_set):
1767         (on_tooltip_text_unset):
1768         (window_create):
1769
1770 2013-01-02  Tony Chang  <tony@chromium.org>
1771
1772         Unreviewed, rolling out r138661.
1773         http://trac.webkit.org/changeset/138661
1774         https://bugs.webkit.org/show_bug.cgi?id=104740
1775
1776         Compile problems on EFL
1777
1778         * GNUmakefile.am:
1779         * qmake/mkspecs/features/default_post.prf:
1780
1781 2013-01-02  Tony Chang  <tony@chromium.org>
1782
1783         Generate internal.settings from Settings.in
1784         https://bugs.webkit.org/show_bug.cgi?id=104740
1785
1786         Reviewed by Adam Barth.
1787
1788         * GNUmakefile.am: Compile new generated files on GTK+.
1789         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1790         with both extra_sources and add_output_to_sources=false will still
1791         compile the files in extra_sources. This makes it possible to compile
1792         InternalSettingsGenerated.cpp and not be confused by
1793         InternalSettingsGenerated.idl.
1794
1795 2013-01-02  Adam Barth  <abarth@webkit.org>
1796
1797         Remove old-run-webkit-tests support from webkitpy
1798         https://bugs.webkit.org/show_bug.cgi?id=105619
1799
1800         Reviewed by Eric Seidel.
1801
1802         This patch removes support for webkitpy parsing the
1803         old-run-webkit-tests results format. There doesn't seem to be any
1804         reason to keep this code around anymore now that most bots have
1805         switched to new-run-webkit-tests.
1806
1807         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1808         (Builder.fetch_layout_test_results):
1809         * Scripts/webkitpy/common/net/layouttestresults.py:
1810         (path_for_layout_test):
1811         (LayoutTestResults.results_from_string):
1812         (LayoutTestResults):
1813         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1814         (LayoutTestResultsTest.test_results_from_string):
1815         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1816         (test_flaky_test_failure):
1817         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1818         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1819         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1820         (PatchAnalysisTask._test_patch):
1821         * Scripts/webkitpy/tool/commands/queuestest.py:
1822         (QueuesTest.assert_queue_outputs):
1823
1824 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
1825
1826         [Qt][WK2] Add simple UI to find text from page
1827         https://bugs.webkit.org/show_bug.cgi?id=96481
1828
1829         Reviewed by Jocelyn Turcotte.
1830
1831         Find bar that slides between navigation bar and WebView.
1832
1833         * MiniBrowser/qt/BrowserWindow.cpp:
1834         (BrowserWindow::toggleFind):
1835         * MiniBrowser/qt/BrowserWindow.h:
1836         (BrowserWindow):
1837         * MiniBrowser/qt/MiniBrowser.qrc:
1838         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1839         (MiniBrowserApplication::notify):
1840         * MiniBrowser/qt/icons/find.png: Added.
1841         * MiniBrowser/qt/qml/BrowserWindow.qml:
1842
1843 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
1844
1845         Regression(r138603): Caused 2 webkitpy tests to fail
1846         https://bugs.webkit.org/show_bug.cgi?id=105913
1847
1848         Reviewed by Kentaro Hara.
1849
1850         Fix 2 webkitpy tests that started to fail after
1851         r138603.
1852
1853         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1854         (IRCCommandTest._sheriff_test_data_url): Make sure the
1855         returned test file URL is valid no matter what the
1856         current working directory is.
1857         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1858         (IRCBotTest.test_help): Add "sheriffs" command to the
1859         list of available commands.
1860
1861 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
1862
1863         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
1864         https://bugs.webkit.org/show_bug.cgi?id=105897
1865
1866         Reviewed by Alexey Proskuryakov.
1867
1868         Dump in WebKitTestRunner the message that is expected by layout tests
1869         when the missing plugin button is clicked.
1870
1871         * WebKitTestRunner/TestController.cpp:
1872         (WTR::TestController::createWebViewWithOptions):
1873         (WTR::TestController::unavailablePluginButtonClicked):
1874         (WTR):
1875         * WebKitTestRunner/TestController.h:
1876         (TestController):
1877
1878 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
1879
1880         [EFL] Enable MHTML feature
1881         https://bugs.webkit.org/show_bug.cgi?id=105815
1882
1883         Reviewed by Laszlo Gombos.
1884
1885         Enable MHTML feature for EFL port by default.
1886
1887         * Scripts/webkitperl/FeatureList.pm:
1888
1889 2013-01-01  Alan Cutter  <alancutter@chromium.org>
1890
1891         sheriff-bot should know who the gardeners/sheriffs are
1892         https://bugs.webkit.org/show_bug.cgi?id=105698
1893
1894         Reviewed by Eric Seidel.
1895
1896         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
1897
1898         * Scripts/webkitpy/tool/bot/irc_command.py:
1899         (Current):
1900         (Current._retrieve_webkit_sheriffs):
1901         (Current.execute):
1902         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1903         (IRCCommandTest.test_current):
1904         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
1905         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
1906         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
1907         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
1908         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
1909
1910 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1911
1912         [GTK] Move ImageDiff to the Tools directory root
1913         https://bugs.webkit.org/show_bug.cgi?id=105421
1914
1915         Reviewed by Kenneth Rohde Christiansen.
1916
1917         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
1918         * GNUmakefile.am:
1919         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
1920
1921 2012-12-30  Mike West  <mkwst@chromium.org>
1922
1923         Add myself to watchlists for CSP and console logs.
1924         https://bugs.webkit.org/show_bug.cgi?id=105874
1925
1926         Reviewed by Dirk Pranke.
1927
1928         Because I really, really, really need more email.
1929
1930         * Scripts/webkitpy/common/config/committers.py:
1931             Add mkwst+watchlist@chromium.org as a contributor.
1932         * Scripts/webkitpy/common/config/watchlist:
1933             Create watchlist categories for 1) the various mechanisms used to
1934             generate console messages, and 2) CSP usage and files.
1935
1936 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1937
1938         [EFL] Enable TEMPLATE_ELEMENT feature
1939         https://bugs.webkit.org/show_bug.cgi?id=105865
1940         
1941         Reviewed by Laszlo Gombos.
1942
1943         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
1944
1945 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
1946
1947         Unreviewed GTK gardening of the unit tests.
1948
1949         Skip the TestInspectorServer unit test that's timing out completely.
1950
1951         * Scripts/run-gtk-tests:
1952         (TestRunner):
1953
1954 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
1955
1956         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
1957         https://bugs.webkit.org/show_bug.cgi?id=105855
1958
1959         Reviewed by Vsevolod Vlasov.
1960
1961         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
1962         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
1963
1964         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
1965         (ReportMemoryUsageVisitor):
1966         (clang::AddMemberCallVisitor::VisitCallExpr):
1967         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
1968         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
1969
1970 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
1971
1972         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
1973         https://bugs.webkit.org/show_bug.cgi?id=105852
1974
1975         Reviewed by Alexander Pavlov.
1976
1977         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
1978         (clang):
1979         (AddMemberCallVisitor):
1980         (ReportMemoryUsageVisitor):
1981         (clang::ReportMemoryUsageAction::ParseArgs):
1982         (clang::AddMemberCallVisitor::VisitCallExpr):
1983         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
1984         (clang::ReportMemoryUsageVisitor::emitWarning):
1985         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
1986         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
1987         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
1988
1989 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
1990
1991         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
1992         https://bugs.webkit.org/show_bug.cgi?id=105835
1993
1994         Reviewed by Dirk Pranke.
1995
1996         The BeautifulSoup module is a third-party import and as such we don't have much control
1997         over its testing. Because of that it should be omitted from code coverage checking.
1998
1999         * Scripts/webkitpy/test/main.py:
2000         (Tester._run_tests):
2001
2002 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
2003
2004         [GTK][WK2] Add support for IME Composition
2005         https://bugs.webkit.org/show_bug.cgi?id=65093
2006
2007         Reviewed by Carlos Garcia Campos.
2008
2009         Update unit tests for GtkInputMethodFilter to note whether or not an event
2010         was a fake event synthesized for composition purposes. This is now used
2011         for WebKit2.
2012
2013         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2014         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
2015         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
2016         (TestWebKitAPI::TEST):
2017         * gtk/generate-gtkdoc:
2018         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
2019         generation.
2020
2021 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
2022
2023         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
2024         https://bugs.webkit.org/show_bug.cgi?id=105800
2025
2026         Reviewed by Yury Semikhatsky.
2027
2028         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2029         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
2030         (clang):
2031
2032 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
2033
2034         Create a GTK build system watchlist and add myself to it
2035         https://bugs.webkit.org/show_bug.cgi?id=105769
2036
2037         Reviewed by Dirk Pranke.
2038
2039         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
2040         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
2041         omitted on purpose due to relatively high change rate they are exposed to.
2042
2043         The new watchlist would be of use to me as the GTK build system recently went
2044         through a series of changes that included a changed policy on adding configuration
2045         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
2046         mailing list about this change will be published later, but I'd also like to be
2047         notified of any pending changes to these files just so I can check the changes are
2048         in compliance with the new policy.
2049
2050         * Scripts/webkitpy/common/config/watchlist:
2051
2052 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
2053
2054         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
2055         As example ..../DevTools/src/third_party/WebKit
2056
2057         * Scripts/webkitpy/common/webkit_finder.py:
2058         (WebKitFinder.webkit_base):
2059
2060 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
2061
2062         [EFL][WK2] Refactor snapshot taking code
2063         https://bugs.webkit.org/show_bug.cgi?id=105687
2064
2065         Reviewed by Kenneth Rohde Christiansen.
2066
2067         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
2068         since the function was renamed to follow naming style.
2069
2070         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2071         (WTR::PlatformWebView::windowSnapshotImage):
2072
2073 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
2074
2075         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
2076         https://bugs.webkit.org/show_bug.cgi?id=105725
2077
2078         Reviewed by Yury Semikhatsky.
2079
2080         MemberType value names were adjusted according to Style Guide.
2081         Existing tests were extended with link type validation.
2082
2083         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2084
2085 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2086
2087         [BlackBerry] DRT - Crashed when running pixels tests
2088         https://bugs.webkit.org/show_bug.cgi?id=105711
2089
2090         RIM PR 270003
2091
2092         Reviewed by George Staikos.
2093
2094         Calling window->post() here will result in buffer swapping which is
2095         only allowed in UI thread now, and I found we don't need to call it
2096         for GL renderer.
2097
2098         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2099         (createBitmapContextFromWebView):
2100
2101 2012-12-22  Dan Winship  <danw@gnome.org>
2102
2103         Add a patch to fix libxml2 2.9.0 regression
2104         https://bugs.webkit.org/show_bug.cgi?id=104494
2105
2106         Reviewed by Martin Robinson.
2107
2108         * gtk/jhbuild.modules:
2109         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
2110
2111 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2112
2113         Unreviewed update of status to reviewer.
2114
2115         * Scripts/webkitpy/common/config/committers.py:
2116
2117 2012-12-23  Philippe Normand  <pnormand@igalia.com>
2118
2119         [GTK][jhbuild] Bump GStreamer to 1.0.4
2120         https://bugs.webkit.org/show_bug.cgi?id=105640
2121
2122         Reviewed by Martin Robinson.
2123
2124         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
2125
2126 2012-12-21  Nico Weber  <thakis@chromium.org>
2127
2128         chromium: webkit-build-directory doesn't handle ninja output dirs
2129         https://bugs.webkit.org/show_bug.cgi?id=105671
2130
2131         Reviewed by Daniel Bates.
2132
2133         Teach webkit-build-directory to detect the ninja build directory.
2134
2135         * Scripts/webkitdirs.pm:
2136         (determineBaseProductDir):
2137         (determineIsChromiumNinja):
2138
2139 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
2140
2141         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
2142         https://bugs.webkit.org/show_bug.cgi?id=95477
2143
2144         Reviewed by Sam Weinig.
2145
2146         Co-authored by Jia Pu.
2147
2148         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
2149         we can have consistent autocorrection behavior when running tests.
2150
2151         * DumpRenderTree/mac/DumpRenderTree.mm:
2152         (resetDefaultsToConsistentValues):
2153         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2154         (WTR::InjectedBundle::platformInitialize):
2155
2156 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
2157
2158         [GTK] Add WebKit1-specific TestExpectations file
2159         https://bugs.webkit.org/show_bug.cgi?id=97562
2160
2161         Reviewed by Dirk Pranke.
2162
2163         Implement the expectations_files method inside the GtkPort class that
2164         returns the list of the TestExpectations files the current test configuration
2165         requires. The method is implemented in a similar way as on the EFL port.
2166         A unit test is also added.
2167
2168         * Scripts/webkitpy/layout_tests/port/gtk.py:
2169         (GtkPort._search_paths):
2170         (GtkPort):
2171         (GtkPort.expectations_files):
2172         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2173         (GtkPortTest.test_expectations_files):
2174
2175 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2176
2177         [EFL] Enable feature option for the CSS sticky position
2178         https://bugs.webkit.org/show_bug.cgi?id=105630
2179
2180         Reviewed by Kenneth Rohde Christiansen.
2181
2182         Enable CSS sticky position feature by default for the
2183         EFL port. This feature option was added in r138252.
2184
2185         No new tests. Existing layout tests pass.
2186
2187         * Scripts/webkitperl/FeatureList.pm:
2188
2189 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2190
2191         [WK2] REGRESSION(r138232): It made 4 tests timeout
2192         https://bugs.webkit.org/show_bug.cgi?id=105623
2193
2194         Reviewed by Kenneth Rohde Christiansen.
2195
2196         r138232 changed functionality so that empty text output
2197         no longer leads to a dump() call, which leads to a timeout.
2198         Instead do a text dump if there is text output or if there
2199         is no audio output.
2200
2201         * WebKitTestRunner/TestInvocation.cpp:
2202         (WTR::TestInvocation::dumpResults):
2203
2204 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2205
2206         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2207         https://bugs.webkit.org/show_bug.cgi?id=105309
2208
2209         On Windows the library name is Qt5WebKitWidgets as well.
2210         So r138136 should not have adjusted the library name for Windows.
2211
2212         Reviewed by Simon Hausmann.
2213
2214         * Scripts/webkitdirs.pm:
2215         (builtDylibPathForName):
2216
2217 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2218
2219         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
2220         https://bugs.webkit.org/show_bug.cgi?id=105424
2221
2222         This change will allow us to run a very specific
2223         subset of the available LayoutTests on a mac buildbot.
2224         The new baseline search path for mac will look as follows:
2225         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
2226
2227         Reviewed by Dirk Pranke.
2228
2229         * Scripts/webkitpy/layout_tests/port/qt.py:
2230         (QtPort._search_paths):
2231         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2232         (QtPortTest):
2233
2234 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2235
2236         [EFL] Build break with latest EFL libraries.
2237         https://bugs.webkit.org/show_bug.cgi?id=104827
2238
2239         Reviewed by Laszlo Gombos.
2240
2241         The eo EFL package is introduced and evas and ecore use it since 1.8.
2242         While introducing Eo, EFL changed several structures of Evas and Ecore
2243         from own specific class to Eo.
2244
2245         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
2246         Ecore_Timer to build with latest EFL libraries.
2247
2248         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
2249         * EWebLauncher/CMakeLists.txt: Ditto.
2250         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2251         * ImageDiff/PlatformEfl.cmake: Ditto.
2252         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
2253         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
2254         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
2255         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
2256         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
2257
2258 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
2259
2260         TestExpectation fallback is broken
2261         https://bugs.webkit.org/show_bug.cgi?id=105583
2262
2263         Reviewed by Ryosuke Niwa.
2264
2265         When I added support for the -wk2 in port names, it looks
2266         like I broke the way we computed the list of TestExpectations
2267         files so that the implementation-version directory was left out :(.
2268         Fixed and cleaned up the tests.
2269
2270         * Scripts/webkitpy/layout_tests/port/base.py:
2271         (Port.expectations_files):
2272         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2273         (TestWebKitPort.__init__):
2274         (PortTestCase.test_skipped_directories_for_symbols):
2275         (test_skipped_directories_for_features):
2276         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2277         (test_skipped_tests_for_unsupported_features_empty_test_list):
2278         (test_skipped_layout_tests):
2279         (test_expectations_files):
2280
2281 2012-12-20  Anders Carlsson  <andersca@apple.com>
2282
2283         Don't include WebKit2 headers when building TestWebKitAPI on windows
2284         https://bugs.webkit.org/show_bug.cgi?id=105582
2285
2286         Reviewed by Tim Horton.
2287
2288         * TestWebKitAPI/config.h:
2289         * TestWebKitAPI/win/main.cpp:
2290
2291 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
2292
2293         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
2294         https://bugs.webkit.org/show_bug.cgi?id=105370
2295
2296         Reviewed by Simon Fraser.
2297
2298         Re-enable the test.
2299
2300         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2301         (TestWebKitAPI::TEST):
2302
2303 2012-12-20  Nico Weber  <thakis@chromium.org>
2304
2305         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
2306         https://bugs.webkit.org/show_bug.cgi?id=105498
2307
2308         Reviewed by Dirk Pranke.
2309
2310         Use the newest binary available rather than an than always picking one
2311         build directory over another based on iteration order.
2312
2313         * Scripts/webkitpy/layout_tests/port/chromium.py:
2314         (ChromiumPort._static_build_path):
2315         Check for timestamps.
2316         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2317         (ChromiumMacPortTest.test_build_path_timestamps):
2318         Test that out / xcodebuild selection happens based on timestamps
2319         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2320         (ChromiumWinPortTest.test_build_path_timestamps):
2321         Test that out / build selection happens based on timestamps
2322
2323 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
2324
2325         Lots of sticky tests failing in WK2
2326         https://bugs.webkit.org/show_bug.cgi?id=105464
2327
2328         Reviewed by Beth Dakin.
2329
2330         WebKitTestRunner had a race between snapshotting in the UI process,
2331         and resettting after the test in the web process. InjectedBundle::done()
2332         was a bad place to call page()->resetAfterTest(), because of this race;
2333         it could reset the scroll position before the UI snapshot had been obtained.
2334         
2335         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
2336         for the "Reset" message which will come in before the next test.
2337
2338         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2339         (WTR::InjectedBundle::didReceiveMessage):
2340         (WTR::InjectedBundle::done):
2341
2342 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
2343
2344         DFG speculation checks that take JumpList should consolidate OSRExits
2345         https://bugs.webkit.org/show_bug.cgi?id=105401
2346
2347         Reviewed by Oliver Hunt.
2348
2349         Update the profiler to understand that an OSR exit may have multiple
2350         candidate exit sites.
2351
2352         * Scripts/display-profiler-output:
2353
2354 2012-12-20  Eric Seidel  <eric@webkit.org>
2355
2356         EWSes do not need to dump build/test logs when things pass
2357         https://bugs.webkit.org/show_bug.cgi?id=105402
2358
2359         Reviewed by Dirk Pranke.
2360
2361         When we were first writing the commit-queue and EWS system
2362         and running them locally, we thought it was important to see the
2363         build/test output as it happened.  Now these queues have been running
2364         for years, and we don't use this feature anymore.  So this patch
2365         makes us stop tee-ing the output directly to stdout, and instead
2366         only print any output from commands when they fail.
2367
2368         I also added some logging when we execute each command
2369         since we are no longer printing the command output itself.
2370         This should make it much easier to see errors with the EWS
2371         system itself, now that all the passing-build output is removed.
2372
2373         This required updating a zillion unittests, since we have a bunch of
2374         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
2375         already approximating this behavior by using a "logging" Executive.
2376         I disabled logging in those cases to avoid redundant logging in those tests.
2377
2378         * Scripts/webkitpy/common/system/executive.py:
2379         (Executive.command_for_printing):
2380         (Executive.run_command):
2381         * Scripts/webkitpy/common/system/executive_mock.py:
2382         (MockExecutive.command_for_printing):
2383         (MockExecutive.run_command):
2384         * Scripts/webkitpy/common/system/executive_unittest.py:
2385         (ExecutiveTest.test_auto_stringify_args):
2386         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2387         (EarlyWarningSytemTest._default_expected_logs):
2388         (_test_ews):
2389         (_test_ewses):
2390         * Scripts/webkitpy/tool/commands/queues.py:
2391         (AbstractQueue.run_webkit_patch):
2392         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2393         (AbstractQueueTest._assert_run_webkit_patch):
2394         (CommitQueueTest.test_commit_queue):
2395         (test_rollout):
2396         (test_rollout_lands):
2397         (test_manual_reject_during_processing):
2398         (StyleQueueTest.test_style_queue_with_style_exception):
2399         (test_style_queue_with_watch_list_exception):
2400
2401 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
2402
2403         AX: support clickPoint in DRT for chromium
2404         https://bugs.webkit.org/show_bug.cgi?id=97359
2405
2406         Reviewed by Chris Fleizach.
2407
2408         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2409         several more tests can pass.
2410
2411         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2412         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2413         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2414         (WebTestRunner):
2415         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2416         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2417         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2418         (AccessibilityUIElement):
2419
2420 2012-12-20  Dan Bernstein  <mitz@apple.com>
2421
2422         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
2423         https://bugs.webkit.org/show_bug.cgi?id=99268
2424
2425         Reviewed by Alexey Proskuryakov.
2426
2427         * Scripts/prepare-ChangeLog:
2428         (generateNewChangeLogs): Removed the "Additional information of the change" line.
2429
2430 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2431
2432         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
2433
2434         * Scripts/run-gtk-tests:
2435         (TestRunner):
2436
2437 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2438
2439         [Qt] Move ImageDiff to the Tools directory root
2440         https://bugs.webkit.org/show_bug.cgi?id=105420
2441
2442         Reviewed by Tor Arne Vestbø.
2443
2444         Moved ImageDiff from outside DumpRenderTree because it is also a
2445         dependency when running pixel tests for WebKit2.
2446
2447         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
2448         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
2449         * Tools.pro:
2450
2451 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
2452
2453         [GTK] Remove the --enable-unstable-features configuration option
2454         https://bugs.webkit.org/show_bug.cgi?id=105327
2455
2456         Reviewed by Martin Robinson.
2457
2458         Add a missing feature option for the CSS sticky position feature.
2459
2460         * Scripts/webkitperl/FeatureList.pm:
2461
2462 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2463
2464         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
2465
2466         * Scripts/run-gtk-tests:
2467         (TestRunner):
2468
2469 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2470
2471         [EFL] MiniBrowser does not play Infinite Gangnam Style
2472         https://bugs.webkit.org/show_bug.cgi?id=103531
2473
2474         Reviewed by Kenneth Rohde Christiansen.
2475
2476         For EFL we would like this feature to be built by default.
2477
2478         * Scripts/webkitperl/FeatureList.pm:
2479
2480 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
2481
2482         [Qt] EWS bots should call qmake always
2483         https://bugs.webkit.org/show_bug.cgi?id=90049
2484
2485         Reviewed by Simon Hausmann.
2486
2487         * Scripts/webkitdirs.pm:
2488         (buildQMakeProjects):
2489
2490 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
2491
2492         [chromium] fix stray printf in TestRunner's WebTestProxy
2493         https://bugs.webkit.org/show_bug.cgi?id=105515
2494
2495         Reviewed by Ryosuke Niwa.
2496
2497         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2498         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
2499
2500 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2501
2502         [WK2] WebAudio WKTR support
2503         https://bugs.webkit.org/show_bug.cgi?id=95084
2504
2505         Reviewed by Kenneth Rohde Christiansen.
2506
2507         Implementing audio data dump support for WebKitTestRunner,
2508         by adding the API to the IDL, enabling IPC for transferring
2509         the audio data as bytebuffer and dumping it according
2510         to run-webkit-tests script's expectations.
2511         This enables audio testing on WebKit2 ports.
2512         Based on initial wip-patch from Philippe Normand - thanks.
2513
2514         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
2515         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
2516         (WTR::TestRunner::setAudioData):
2517         (WTR):
2518         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
2519         (TestRunner):
2520         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
2521         (WTR::InjectedBundle::done):
2522         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
2523         (WTR::InjectedBundle::setAudioResult):
2524         (InjectedBundle):
2525         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2526         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
2527         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
2528         (WTR::TestInvocation::dumpResults):
2529         (WTR):
2530         (WTR::TestInvocation::dumpAudio):
2531         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
2532         * WebKitTestRunner/TestInvocation.h:
2533         (TestInvocation):
2534
2535 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
2536
2537         [GTK] Count failed and timed out tests separately
2538         https://bugs.webkit.org/show_bug.cgi?id=105448
2539
2540         Reviewed by Carlos Garcia Campos.
2541
2542         Display the number of tests that fail, time out and are skipped
2543         separately in the buildbot page.
2544
2545         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2546         (RunGtkAPITests.commandComplete):
2547         (RunGtkAPITests.evaluateCommand):
2548         (RunGtkAPITests.getText2):
2549         * Scripts/run-gtk-tests:
2550         (TestRunner.run_tests):
2551
2552 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
2553
2554         PerfTest.parse_output does too much
2555         https://bugs.webkit.org/show_bug.cgi?id=105391
2556
2557         Reviewed by Tony Chang.
2558
2559         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
2560         Also moved the code to output test results into PerfTest._run_with_driver.
2561
2562         * Scripts/webkitpy/performance_tests/perftest.py:
2563         (PerfTest.__init__): Added _description.
2564         (PerfTest.description): Added.
2565         (PerfTest._run_with_driver): Moved the code to output test description and test results.
2566         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
2567         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
2568         respectively. Also removed the code that allowed some tests to omit values since all tests report each
2569         iteration now since r136492.
2570         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
2571         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
2572         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
2573         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
2574         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
2575         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
2576         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2577         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
2578         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
2579         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
2580         so that it's not string-concatenated with the next line.
2581         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
2582         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
2583
2584 2012-12-19  Alexis Menard  <alexis@webkit.org>
2585
2586         Implement CSS parsing for CSS transitions unprefixed.
2587         https://bugs.webkit.org/show_bug.cgi?id=104804
2588
2589         Reviewed by Dean Jackson.
2590
2591         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
2592         to cover the work of unprefixing Transforms, Animations and 
2593         Transitions. It will let the possibility of each ports to turn it off 
2594         in their release branches until we're confident that these CSS 
2595         properties are ready to be unprefixed.
2596
2597         * Scripts/webkitperl/FeatureList.pm:
2598         * qmake/mkspecs/features/features.pri:
2599
2600 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
2601
2602         2 clampTo unit tests are failing
2603         https://bugs.webkit.org/show_bug.cgi?id=105253
2604
2605         Reviewed by Emil A Eklund.
2606
2607         Removed clampToUnsigned as it was actually testing exactly what
2608         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
2609         to precision loss (fix suggested by Emil).
2610
2611         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2612
2613 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2614
2615         [EFL] Move ImageDiff to the Tools directory root
2616         https://bugs.webkit.org/show_bug.cgi?id=105305
2617
2618         Reviewed by Laszlo Gombos.
2619
2620         We previously moved this directory from the DRT directory to
2621         efl/ImageDiff. The major reason for doing so was because ImageDiff does
2622         not depend on DumpRenderTree but for legacy reasons was living inside the
2623         DRT folder, even though it is needed when running pixel tests for WK2.
2624
2625         Now we are moving to Tool directory root as other ports agreed to do the same.
2626
2627         * CMakeLists.txt:
2628         * ImageDiff/CMakeLists.txt: Added.
2629         * ImageDiff/PlatformEfl.cmake: Added.
2630         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
2631         * efl/ImageDiff/CMakeLists.txt: Removed.
2632
2633 2012-12-19  Zeno Albisser  <zeno@webkit.org>
2634
2635         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2636         https://bugs.webkit.org/show_bug.cgi?id=105309
2637
2638         The version number is only used as a part
2639         of the library name on Linux.
2640
2641         Reviewed by Kenneth Rohde Christiansen.
2642
2643         * Scripts/webkitdirs.pm:
2644         (builtDylibPathForName):
2645
2646 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
2647
2648         [GTK] Tests that time out are not considered as failures.
2649         https://bugs.webkit.org/show_bug.cgi?id=105318
2650
2651         Reviewed by Martin Robinson.
2652
2653         Fix parsing of the GTK API tests log files.
2654
2655         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2656         (RunGtkAPITests.commandComplete):
2657
2658 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
2659
2660         Unreviewed, rolling out r138061.
2661         https://bugs.webkit.org/show_bug.cgi?id=105396
2662
2663         Original patch:
2664         http://trac.webkit.org/changeset/138061
2665         https://bugs.webkit.org/show_bug.cgi?id=97359
2666
2667         It is crashing on Debug bots
2668
2669         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2670         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2671         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2672         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2673         (AccessibilityUIElement):
2674
2675 2012-12-18  Alice Liu  <alice.liu@apple.com>
2676
2677         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
2678         Add SPI to WebKit1 WebFrame for hit testing
2679
2680         Reviewed by Dan Bernstein.
2681
2682         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
2683         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
2684         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
2685         Then hit-tests at three points, expecting to hit the two divs and body element. 
2686
2687 2012-12-18  Alice Liu  <alice.liu@apple.com>
2688
2689         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
2690         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
2691
2692         Reviewed by Anders Carlsson.
2693
2694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
2695         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
2696         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
2697         Loads html with a single div element. In an isolated world, creates a property on that node.
2698         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
2699             - Existence of the isolated property in the isolated world.
2700             - Existence of the standard property in the standard world.
2701             - Non-existence of the isolated property in the standard world.
2702             - Non-existence of the standard property in the isolated world.
2703
2704 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
2705
2706         Disable the SimplifyMarkup API test, wich asserts in debug builds.
2707         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
2708         
2709         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2710         (TestWebKitAPI::TEST):
2711
2712 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
2713
2714         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
2715         https://bugs.webkit.org/show_bug.cgi?id=104279
2716
2717         Reviewed by David Kilzer.
2718
2719         Add a build phase script that checks a framework's header files for
2720         Platform.h and Compiler.h macros. Also add some tests for the script.
2721
2722         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
2723         Script to be used in build phases to check for inappropriate macros in headers.
2724
2725         * Scripts/test-webkitruby: Added.
2726         Script that can be used to run all webkitruby tests.
2727
2728         * Scripts/test-webkit-scripts:
2729         Also run the ruby tests.
2730
2731         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
2732         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
2733         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
2734         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
2735         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
2736         Tests for the new script.
2737
2738 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
2739
2740         AX: support clickPoint in DRT for chromium
2741         https://bugs.webkit.org/show_bug.cgi?id=97359
2742
2743         Reviewed by Chris Fleizach.
2744
2745         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2746         several more tests can pass.
2747
2748         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2749         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2750         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2751         (WebTestRunner):
2752         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2753         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2754         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2755         (AccessibilityUIElement):
2756
2757 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2758
2759         Build fix after r138045.
2760
2761         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2762         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
2763         is not explicitly specified. The condition was backwards but never matched so we
2764         always ran the test regardless of whether it's listed in the skipped list or not.
2765         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2766         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
2767
2768 2012-12-18  Emil A Eklund  <eae@chromium.org>
2769
2770         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
2771         https://bugs.webkit.org/show_bug.cgi?id=105332
2772         
2773         Reviewed by Levi Weintraub.
2774         
2775         Create new test suite for LayoutUnit tests as the KURL tests are
2776         of the incompatible TEST_F type.
2777
2778         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2779         (TestWebKitAPI):
2780         (TestWebKitAPI::TEST_F):
2781
2782 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2783
2784         Running a skipped test with run-perf-tests could alert the user
2785         https://bugs.webkit.org/show_bug.cgi?id=105219
2786
2787         Reviewed by Eric Seidel.
2788
2789         Force run skipped performance tests explicitly specified in the command line.
2790         Also warn the user when the specified paths don't exist.
2791
2792         * Scripts/webkitpy/layout_tests/port/base.py:
2793         (Port.relative_test_filename):
2794         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2795         (PerfTestsRunner._parse_args):
2796         (PerfTestsRunner._collect_tests):
2797         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2798         (test_collect_tests_with_skipped_list_and_files):
2799
2800 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
2801
2802         Chrome Android java output is too verbose
2803         https://bugs.webkit.org/show_bug.cgi?id=105247
2804
2805         Reviewed by Tony Chang.
2806
2807         Pass -quiet to ant to suppress extraneous output.
2808
2809         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2810         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2811
2812 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2813
2814         Consider removing --pause-before-testing option
2815         https://bugs.webkit.org/show_bug.cgi?id=105248
2816
2817         Reviewed by Eric Seidel.
2818
2819         Remove --pause-before-testing option.
2820
2821         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
2822         (DriverProxy.start): Removed.
2823         * Scripts/webkitpy/performance_tests/perftest.py:
2824         (PerfTest.__init__):
2825         (PerfTest.test_path): Renamed from path_or_url.
2826         (PerfTest.run):
2827         (PerfTest): Removed "driver" argument.
2828         (PerfTest._run_with_driver):
2829         (PerfTest.run_single):
2830         (ChromiumStylePerfTest.__init__):
2831         (PageLoadingPerfTest.__init__):
2832         (PageLoadingPerfTest.run_single):
2833         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
2834         (ReplayPerfTest.__init__):
2835         (ReplayPerfTest.prepare):
2836         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2837         (TestPageLoadingPerfTest.test_run):
2838         (TestPageLoadingPerfTest.test_run_with_memory_output):
2839         (TestPageLoadingPerfTest.test_run_with_bad_output):
2840         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2841         (PerfTestsRunner._parse_args):
2842         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
2843         (PerfTestsRunner._run_single_test): Removed "driver" argument.
2844         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2845         (run_test):
2846         (test_run_test_pause_before_testing): Removed.
2847
2848 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
2849
2850         [GTK] Tests that time out are not considered as failures.
2851         https://bugs.webkit.org/show_bug.cgi?id=105318
2852
2853         Reviewed by Martin Robinson.
2854
2855         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2856         (RunGtkAPITests.commandComplete):
2857         Consider log lines that end with TIMEOUT as errors.
2858
2859         * Scripts/run-gtk-tests:
2860         (TestRunner.run_tests):
2861         Consider timeouts as failures when returning the number of failed
2862         tests.
2863
2864 2012-12-18  Pravin D  <pravin.d@samsung.com>
2865
2866         Unreviewed, adding secondary email.
2867
2868         * Scripts/webkitpy/common/config/committers.py:
2869
2870 2012-12-18  Pravin D  <pravin.d@samsung.com>
2871
2872         Unreviewed, promoting myself to committer's list.
2873
2874         * Scripts/webkitpy/common/config/committers.py:
2875
2876 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2877
2878         [EFL] ImageDiff does not build on WebKit2 only builds
2879         https://bugs.webkit.org/show_bug.cgi?id=105288
2880
2881         Reviewed by Kenneth Rohde Christiansen.
2882
2883         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
2884         the folder with things which are EFL-specific.
2885
2886         ImageDiff will be built by default now regardless of WebKit API flavor
2887         you choose.
2888
2889         * CMakeLists.txt:
2890         * DumpRenderTree/efl/CMakeLists.txt:
2891         * efl/ImageDiff/CMakeLists.txt: Added.
2892         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
2893
2894 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2895
2896         [EFL][WK2] When creating new windows, use the opener's context
2897         https://bugs.webkit.org/show_bug.cgi?id=105283
2898
2899         Reviewed by Laszlo Gombos.
2900
2901         Use the context of the opener if exists.
2902
2903         * MiniBrowser/efl/main.c:
2904         (on_key_down):
2905         (on_window_create):
2906         (window_create):
2907         (elm_main):
2908
2909 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2910
2911         [EFL][WK2] Gardening of TestWebKitAPI tests
2912         https://bugs.webkit.org/show_bug.cgi?id=105268
2913
2914         Reviewed by Kenneth Rohde Christiansen.
2915
2916         Some tests were marked as failing but are passing and the newly added
2917         LayoutUnit should have it's own binary because it conflicts with the
2918         fixture used by KURL and is failing on the bots because of that.
2919
2920         * TestWebKitAPI/CMakeLists.txt:
2921         * TestWebKitAPI/PlatformEfl.cmake:
2922
2923 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
2924
2925         [chromium] move webintent related methods to TestRunner library
2926         https://bugs.webkit.org/show_bug.cgi?id=105164
2927
2928         Reviewed by Darin Fisher.
2929
2930         Also deleted the unused deliveredIntentFailure and
2931         deliveredIntentResult methods.
2932
2933         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2934         (DRTTestRunner::DRTTestRunner):
2935         * DumpRenderTree/chromium/DRTTestRunner.h:
2936         (DRTTestRunner):
2937         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2938         (WebKit):
2939         (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
2940         (WebTestRunner::WebTestDelegate::currentWebIntentRequest):
2941         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2942         (WebKit):
2943         (WebTestProxyBase):
2944         (WebTestRunner::WebTestProxy::registerIntentService):
2945         (WebTestRunner::WebTestProxy::dispatchIntent):
2946         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2947         (WebTestRunner::TestRunner::TestRunner):
2948         (WebTestRunner::TestRunner::sendWebIntentResponse):
2949         (WebTestRunner):
2950         (WebTestRunner::TestRunner::deliverWebIntent):
2951         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2952         (TestRunner):
2953         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2954         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
2955         (WebTestRunner::WebTestProxyBase::registerIntentService):
2956         (WebTestRunner):
2957         (WebTestRunner::WebTestProxyBase::dispatchIntent):
2958         * DumpRenderTree/chromium/WebViewHost.cpp:
2959         (WebViewHost::setCurrentWebIntentRequest):
2960         (WebViewHost::currentWebIntentRequest):
2961         * DumpRenderTree/chromium/WebViewHost.h:
2962         (WebKit):
2963         (WebViewHost):
2964
2965 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
2966
2967         [chromium] move editing callback dumping to the WebTestProxy
2968         https://bugs.webkit.org/show_bug.cgi?id=105013
2969
2970         Reviewed by Darin Fisher.
2971
2972         To decide whether or not to dump the editing callbacks, the WebTestProxy
2973         needs to query the TestRunner. For this purpose, I introduce a
2974         WebTestRunner class that just exposes the shouldDumpEditingCallbacks
2975         method. In contrast to e.g. WebEventSender, the WebTestRunner is just
2976         an interface, and it is not owned by the WebTestInterfaces, but the
2977         embedder of the TestRunner library must provide it. This will change
2978         once all TestRunner methods are in the library.
2979
2980         * DumpRenderTree/DumpRenderTree.gypi:
2981         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2982         (DRTTestRunner::DRTTestRunner):
2983         (DRTTestRunner::reset):
2984         * DumpRenderTree/chromium/DRTTestRunner.h:
2985         (DRTTestRunner):
2986         (DRTTestRunner::taskList):
2987         (DRTTestRunner::WorkQueue::taskList):
2988         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2989         (WebTestRunner):
2990         (WebTestInterfaces):
2991         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2992         (WebKit):
2993         (WebTestRunner):
2994         (WebTestProxyBase):
2995         (WebTestRunner::WebTestProxy::shouldBeginEditing):
2996         (WebTestRunner::WebTestProxy::shouldEndEditing):
2997         (WebTestRunner::WebTestProxy::shouldInsertNode):
2998         (WebTestRunner::WebTestProxy::shouldInsertText):
2999         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3000         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3001         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3002         (WebTestRunner::WebTestProxy::didBeginEditing):
3003         (WebTestRunner::WebTestProxy::didChangeSelection):
3004         (WebTestRunner::WebTestProxy::didChangeContents):
3005         (WebTestRunner::WebTestProxy::didEndEditing):
3006         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
3007         (WebTestRunner):
3008         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
3009         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3010         (WebTestRunner::TestRunner::TestRunner):
3011         (WebTestRunner::TestRunner::~TestRunner):
3012         (WebTestRunner):
3013         (WebTestRunner::TestRunner::reset):
3014         (WebTestRunner::TestRunner::shouldDumpEditingCallbacks):
3015         (WebTestRunner::TestRunner::dumpEditingCallbacks):
3016         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3017         (TestRunner):
3018         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3019         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
3020         (WebTestRunner::WebTestInterfaces::Internal::setTestRunner):
3021         (WebTestInterfaces::Internal):
3022         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3023         (WebTestRunner::WebTestInterfaces::testRunner):
3024         (WebTestRunner):
3025         (WebTestRunner::WebTestInterfaces::setTestRunner):
3026         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3027         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3028         (WebTestRunner):
3029         (WebTestRunner::WebTestProxyBase::shouldBeginEditing):
3030         (WebTestRunner::WebTestProxyBase::shouldEndEditing):
3031         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
3032         (WebTestRunner::WebTestProxyBase::shouldInsertText):
3033         (WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
3034         (WebTestRunner::WebTestProxyBase::shouldDeleteRange):
3035         (WebTestRunner::WebTestProxyBase::shouldApplyStyle):
3036         (WebTestRunner::WebTestProxyBase::didBeginEditing):
3037         (WebTestRunner::WebTestProxyBase::didChangeSelection):
3038         (WebTestRunner::WebTestProxyBase::didChangeContents):
3039         (WebTestRunner::WebTestProxyBase::didEndEditing):
3040         * DumpRenderTree/chromium/TestShell.cpp:
3041         (TestShell::initialize):
3042         (TestShell::createNewWindow):
3043         * DumpRenderTree/chromium/WebViewHost.cpp:
3044         (WebViewHost::shouldBeginEditing):
3045         (WebViewHost::shouldEndEditing):
3046         (WebViewHost::shouldInsertNode):
3047         (WebViewHost::shouldInsertText):
3048         (WebViewHost::shouldChangeSelectedRange):
3049         (WebViewHost::shouldDeleteRange):
3050         (WebViewHost::shouldApplyStyle):
3051         * DumpRenderTree/chromium/WebViewHost.h:
3052         (WebViewHost):
3053
3054 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3055
3056         [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
3057         https://bugs.webkit.org/show_bug.cgi?id=105154
3058
3059         Reviewed by Tony Chang.
3060
3061         If the settings are modified directly, the embedder can't keep track of
3062         them and might accidentially override the changed settings.
3063
3064         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3065         (WebPreferences):
3066         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3067         (WebTestRunner::TestRunner::TestRunner):
3068         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
3069         (WebTestRunner):
3070         (WebTestRunner::TestRunner::setMinimumTimerInterval):
3071         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3072         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3073         (TestRunner):
3074         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3075         (WebTestRunner::WebPreferences::reset):
3076         (WebTestRunner::WebPreferences::applyTo):
3077
3078 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3079
3080         Unreviewed unit test skipping.
3081
3082         Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.
3083
3084         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3085         (TestWebKitAPI):
3086         (TestWebKitAPI::TEST):
3087
3088 2012-12-17  Dean Jackson  <dino@apple.com>
3089
3090         Unreviewed. Add Silvia Pfeiffer to contributor list.
3091
3092         * Scripts/webkitpy/common/config/committers.py:
3093
3094 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3095
3096         build.webkit.org - add more google windows bots
3097         https://bugs.webkit.org/show_bug.cgi?id=105225
3098
3099         Reviewed by Eric Seidel.
3100
3101         Adds two more windows bots (google-windows-3, a builder, and
3102         google-windows-4, a tester) for the Chromium configs.
3103
3104         * BuildSlaveSupport/build.webkit.org-config/config.json:
3105
3106 2012-12-17  Eric Seidel  <eric@webkit.org>
3107
3108         Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
3109         https://bugs.webkit.org/show_bug.cgi?id=105217
3110
3111         Reviewed by Dirk Pranke.
3112
3113         Previously --profile would fail strangely if find_unused_filename returned None
3114         (which would happen as soon as we had 100 report files).
3115         Now we'll search through 1000 filenames before giving up (and assert if we failed to find one).
3116         I also made some minor cleanups to the output of perf, and tried to make the
3117         commands more self-documenting by using long-names for args.
3118
3119         * Scripts/webkitpy/common/system/profiler.py:
3120         (SingleFileOutputProfiler.__init__):
3121         (Perf.attach_to_pid):
3122         (Perf.profile_after_exit):
3123
3124 2012-12-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3125
3126         Unreviewed, rolling out r137198.
3127         http://trac.webkit.org/changeset/137198
3128         https://bugs.webkit.org/show_bug.cgi?id=105212
3129
3130         This patch is causing API behavior compatibility problems
3131         (Requested by zdobersek on #webkit).
3132
3133         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3134         (willSendRequestCallback):
3135
3136 2012-12-17  Elliott Sprehn  <esprehn@chromium.org>
3137
3138         Unreviewed. Adding myself to committers list.
3139
3140         * Scripts/webkitpy/common/config/committers.py:
3141
3142 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3143
3144         nrwt: shuffle code around for cleanup in run_webkit_tests.py
3145         https://bugs.webkit.org/show_bug.cgi?id=105078
3146
3147         Reviewed by Ojan Vafai.
3148
3149         This patch reorders functions so that run_webkit_tests can be
3150         understood in a top-down matter better, and to make things slightly
3151         more sensible when I merge manager.py into it.
3152
3153         Also, this adds tests for the actual main() routine, which had several
3154         bugs get through testing a week or two ago.
3155
3156         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3157         (main):
3158         (parse_args):
3159         (_set_up_derived_options):
3160         (run):
3161         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3162         (RunTest):
3163         (RunTest.test_no_http_tests):
3164         (PortTest.disabled_test_mac_lion):
3165         (MainTest):
3166         (MainTest.test_exception_handling):
3167         (MainTest.test_exception_handling.interrupting_run):
3168         (MainTest.test_exception_handling.successful_run):
3169         (MainTest.test_exception_handling.successful_run.FakeRunDetails):
3170         (MainTest.test_exception_handling.exception_raising_run):
3171
3172 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3173
3174         webkitpy: move --lint-test-files code into its own module
3175         https://bugs.webkit.org/show_bug.cgi?id=105077
3176
3177         Reviewed by Eric Seidel.
3178
3179         It really didn't need to be in run_webkit_tests.py anymore.
3180         This patch adds a new lint-test-expectations scripts to Tools/Scripts;
3181         rwt --lint-test-files is still supported for backwards compatibility
3182         for now.
3183
3184         * Scripts/lint-test-expectations: Added.
3185         * Scripts/webkitpy/layout_tests/lint_test_expectations.py: Added.
3186         (lint):
3187         (main):
3188         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: Added.
3189         (FakePort):
3190         (FakePort.__init__):
3191         (FakePort.test_configuration):
3192         (FakePort.expectations_dict):
3193         (FakePort.skipped_layout_tests):
3194         (FakePort.all_test_configurations):
3195         (FakePort.configuration_specifier_macros):
3196         (FakePort.get_option):
3197         (FakeFactory):
3198         (FakeFactory.__init__):
3199         (FakeFactory.get):
3200         (FakeFactory.all_port_names):
3201         (LintTest):
3202         (LintTest.test_all_configurations):
3203         (LintTest.test_lint_test_files):
3204         (LintTest.test_lint_test_files__errors):
3205         (MainTest):
3206         (MainTest.test_success):
3207         (MainTest.test_success.interrupting_lint):
3208         (MainTest.test_success.successful_lint):
3209         (MainTest.test_success.exception_raising_lint):
3210         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3211         (main):
3212         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3213         (StreamTestingMixin.assertNotEmpty):
3214
3215 2012-12-17  Adam Klein  <adamk@chromium.org>
3216
3217         build-webkit: rename --template-tag to --template-element to match ENABLE #define name
3218         https://bugs.webkit.org/show_bug.cgi?id=105072
3219
3220         Reviewed by Laszlo Gombos.
3221
3222         * Scripts/webkitperl/FeatureList.pm:
3223
3224 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3225
3226         Add some unit testing for WTF::clampTo* functions
3227         https://bugs.webkit.org/show_bug.cgi?id=105060
3228
3229         Reviewed by Emil A Eklund.
3230
3231         The new tests are targeted at clamping to int / unsigned and float as those are
3232         the one explicitely exposed through more dedicated functions (like clampToInteger,
3233         clampToPositiveInteger and clampToFloat).
3234
3235         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3236
3237 2012-12-17  Eric Seidel  <eric@webkit.org>
3238
3239         rpt --profile --chromium-android throws exception
3240         https://bugs.webkit.org/show_bug.cgi?id=105061
3241
3242         Reviewed by Daniel Bates.
3243
3244         Somehow popen(args) got turned into popen(*args) at some point,
3245         which caused my new stringify code to fail when args was passed by name.
3246         Fixed and tested.
3247
3248         * Scripts/webkitpy/common/system/executive.py:
3249         (Executive._stringify_args):
3250         (Executive):
3251         (Executive.popen):
3252         * Scripts/webkitpy/common/system/executive_unittest.py:
3253         (ExecutiveTest.test_popen_args):
3254
3255 2012-12-17  Mark Pilgrim  <pilgrim@chromium.org>
3256
3257         Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
3258         https://bugs.webkit.org/show_bug.cgi?id=105054
3259
3260         Reviewed by Jochen Eisinger.
3261
3262         Part of a refactoring series; see tracking bug 82948.
3263
3264         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3265         (NotificationPresenter::show):
3266         * DumpRenderTree/chromium/Task.cpp:
3267         (postTask):
3268         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
3269
3270 2012-12-17  Emil A Eklund  <eae@chromium.org>
3271
3272         Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled
3273         https://bugs.webkit.org/show_bug.cgi?id=104955
3274
3275         Reviewed by Julien Chaffraix.
3276
3277         Add tests for LayoutUnit.
3278
3279         * TestWebKitAPI/CMakeLists.txt:
3280         * TestWebKitAPI/ForwardingHeaders: Added.
3281         * TestWebKitAPI/ForwardingHeaders/WebCore: Added.
3282         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Added.
3283         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3284         * TestWebKitAPI/TestWebKitAPI.gypi:
3285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3286         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Added.
3287         (TestWebKitAPI):
3288         (TestWebKitAPI::TEST):
3289         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3290
3291 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3292
3293         [chromium] removed unused preferences from testRunner.overridePreference
3294         https://bugs.webkit.org/show_bug.cgi?id=105169
3295
3296         Reviewed by Tony Chang.
3297
3298         Most notably this removes the code related to font family maps which is
3299         now handled via window.internals.settings
3300
3301         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3302         (WebPreferences):
3303         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3304         (WebTestRunner::TestRunner::overridePreference):
3305         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3306         (TestRunner):
3307         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3308         (WebTestRunner::WebPreferences::applyTo):
3309
3310 2012-12-17  James Robinson  <jamesr@chromium.org>
3311
3312         [chromium] Move creation of WebLayerTreeView to WebWidgetClient
3313         https://bugs.webkit.org/show_bug.cgi?id=105071
3314
3315         Reviewed by Adrienne Walker.
3316
3317         Update WebViewHost for the new WebWidgetClient interface.
3318
3319         * DumpRenderTree/chromium/WebViewHost.cpp:
3320         (WebViewHost::initializeLayerTreeView):
3321         (WebViewHost::layerTreeView):
3322         (WebViewHost::~WebViewHost):
3323         * DumpRenderTree/chromium/WebViewHost.h:
3324         (WebViewHost):
3325
3326 2012-12-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3327
3328         [EFL][WK2] window_create doesn't receive the url
3329         https://bugs.webkit.org/show_bug.cgi?id=105184
3330
3331         Reviewed by Alexis Menard.
3332
3333         * MiniBrowser/efl/main.c: Use the url supplied to window_create
3334         (on_window_create):
3335
3336 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3337
3338         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3339         https://bugs.webkit.org/show_bug.cgi?id=105026
3340
3341         Reviewed by Yury Semikhatsky.
3342
3343         Old SFINAE test was replaced with new one based on this article:
3344         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3345
3346         New test which covers this problem was added.
3347
3348         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3349
3350 2012-12-17  Anthony Scian  <ascian@rim.com>
3351
3352         [Blackberry] Static code analysis warning fixes
3353         https://bugs.webkit.org/show_bug.cgi?id=105129
3354
3355         Reviewed by Rob Buis.
3356
3357         Added null checks for fopen calls, no recovery attempted; access fault prevention only.
3358
3359         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3360         (BlackBerry::WebKit::createFile):
3361         (BlackBerry::WebKit::DumpRenderTree::runTest):
3362
3363 2012-12-17  John Mellor  <johnme@chromium.org>
3364
3365         Add Anton Vayvod and Tim Volodine as contributors in committers.py
3366         https://bugs.webkit.org/show_bug.cgi?id=105025
3367
3368         Unreviewed. Adds two contributors to committers.py.
3369         They are initially contributing to the Text Autosizing feature (master bug: 84186).
3370
3371         * Scripts/webkitpy/common/config/committers.py:
3372
3373 2012-12-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3374
3375         Unreviewed, add myself to committers.py.
3376
3377         * Scripts/webkitpy/common/config/committers.py:
3378
3379 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3380
3381         [Qt] remove some unnecessary CONFIG additions
3382
3383         Reviewed by Simon Hausmann.
3384
3385         qt is already added by spec_pre.prf, warn_on and depend_includepath by
3386         default_pre.prf.
3387
3388         * qmake/mkspecs/features/default_post.prf:
3389
3390 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3391
3392         Unreviewed, rolling out r137892.
3393         http://trac.webkit.org/changeset/137892
3394         https://bugs.webkit.org/show_bug.cgi?id=105026
3395
3396         it broke compilation on windows
3397
3398         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3399
3400 2012-12-14  Ilya Tikhonovsky  <loislo@chromium.org>
3401
3402         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3403         https://bugs.webkit.org/show_bug.cgi?id=105026
3404
3405         Reviewed by Yury Semikhatsky.
3406
3407         Old SFINAE test was replaced with new one based on this article:
3408         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3409
3410         New test which covers this problem was added.
3411
3412         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3413
3414 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3415
3416         [Qt] rely on automatic output directory setup
3417
3418         Reviewed by Simon Hausmann.
3419
3420         Now being a proper qt module (by virtue of having load(qt_build_config)
3421         in .qmake.conf), webkit gets the path setup goodies for free.
3422
3423         This also fixes Makefile.api.Debug/Release trying to generate qrc_WebKit.cpp
3424         at the same time, instead of the debug and release version ending up in different
3425         directories as they should.
3426
3427         * qmake/mkspecs/features/default_pre.prf:
3428
3429 2012-12-17  Charles Wei  <charles.wei@torchmobile.com.cn>
3430
3431         [BlackBerry] Need to re-enable video track
3432         https://bugs.webkit.org/show_bug.cgi?id=105155
3433
3434         Reviewed by George Staikos.
3435
3436         Just enable Video Track for BlackBerry.
3437
3438         * Scripts/webkitperl/FeatureList.pm:
3439
3440 2012-12-17  János Badics  <jbadics@inf.u-szeged.hu>
3441
3442         Unreviewed. Added myself to committers.py
3443
3444         * Scripts/webkitpy/common/config/committers.py:
3445
3446 2012-12-17  Jonathan Liu  <net147@gmail.com>
3447
3448         Fix linking of libraries with -Wl,-whole-archive
3449         https://bugs.webkit.org/show_bug.cgi?id=104436
3450
3451         Reviewed by Simon Hausmann.
3452
3453         If there is more than one library in LIBS linked with
3454         -Wl,-whole-archive -l... -Wl,-no-whole-archive, qmake tries to
3455         merge the duplicate flags in LIBS which causes linking to fail.
3456
3457         Add no_smart_library_merge to CONFIG to prevent the duplicate
3458         flags from being removed when using -Wl,-whole-archive.
3459
3460         * qmake/mkspecs/features/functions.prf:
3461
3462 2012-12-16  Arvid Nilsson  <anilsson@rim.com>
3463
3464         [BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API
3465         https://bugs.webkit.org/show_bug.cgi?id=105143
3466         RIM PR 171941
3467
3468         Reviewed by Rob Buis.
3469         Internally reviewed by George Staikos.
3470
3471         Adapt to new method names and encapsulation of TouchPoint data members.
3472
3473         * DumpRenderTree/blackberry/EventSender.cpp:
3474         (addTouchPointCallback):
3475         (updateTouchPointCallback):
3476         (touchEndCallback):
3477         (releaseTouchPointCallback):
3478         (sendTouchEvent):
3479
3480 2012-12-16  Maciej Stachowiak  <mjs@apple.com>
3481
3482         Add a script to compute the mean and 95% confidence interval (using two-sided t-test) of a sample set
3483         https://bugs.webkit.org/show_bug.cgi?id=105148
3484
3485         Reviewed by Filip Pizlo.
3486
3487         Usage examples:
3488         
3489         $ sampstat --help
3490         Usage: sampstat [options] [FILES]
3491           Compute the mean and 95% confidence interval of a sample set.
3492           Standard input or files must contain two or more decimal numbers, one per line.
3493         
3494         Options:
3495           -h, --help            show this help message and exit
3496           -u UNIT, --unit=UNIT  assume values are in units of UNIT
3497           -v, --verbose         print all values (with units)
3498         
3499         $ sampstat -u MB memresults.txt
3500         2356.90 MB +/- 101.34 MB (4.3%)
3501         
3502         $ sampstat -v -u MB memresults.txt
3503               2318.21 MB
3504               2399.56 MB
3505               2352.93 MB
3506         ----------------
3507         Mean: 2356.90 MB +/- 101.34 MB (4.3%)
3508         
3509
3510         * Scripts/sampstat: Added.
3511         (sum): Helper function to compute the sum of a list.
3512         (arithmeticMean): Compute the meam of a list.
3513         (standardDeviation): Compute the sample standard deviation (unbiased estimator).
3514         (standardError): Compute the sample standard error.
3515         (tDist): Compute t(.025, n-1), the t-value for atwo-sided 95% confidence interval. 
3516         (twoSidedConfidenceInterval): Compute the two-sided confidence interval range about the mean.
3517
3518 2012-12-15  Nima Ghanavatian  <nghanavatian@rim.com>
3519
3520         [BlackBerry] Pass key modifiers with touch and mouse events
3521         https://bugs.webkit.org/show_bug.cgi?id=105108
3522
3523         Reviewed by Rob Buis.
3524
3525         Update DRT to new api.
3526
3527         Internally reviewed by Gen Mak.
3528
3529         * DumpRenderTree/blackberry/EventSender.cpp:
3530         (mouseDownCallback):
3531         (mouseUpCallback):
3532         (mouseMoveToCallback):
3533
3534 2012-12-15  Zan Dobersek  <zandobersek@gmail.com>
3535
3536         Stop the XvfbDriver before proceeding with its starting setup
3537         https://bugs.webkit.org/show_bug.cgi?id=105006
3538
3539         Reviewed by Philippe Normand.
3540
3541         Just as with the base Driver implementation, stop the XvfbDriver
3542         before proceeding with setting up lock files and a new Xvfb instance.
3543         This forces any driver or Xvfb instances that are currently under
3544         the driver's control to be closed/killed and cleaned up after.
3545
3546         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3547         (XvfbDriver._start):
3548
3549 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
3550
3551         webkitpy: make port_name a required parameter to the non-test ports
3552         https://bugs.webkit.org/show_bug.cgi?id=105057
3553
3554         Reviewed by Eric Seidel.
3555
3556         This is just minor code cleanup along the path to making Port
3557         constructors simpler and pushing more logic into the port factory.
3558
3559         * Scripts/webkitpy/layout_tests/port/base.py:
3560         (Port.__init__):
3561         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3562         (PortTest.make_port):
3563         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3564         (TestWebKitPort.__init__):
3565         * Scripts/webkitpy/layout_tests/port/test.py:
3566         (TestPort):
3567         (TestPort.determine_full_port_name):
3568         (TestPort.__init__):
3569         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
3570         (XvfbDriverTest.make_driver):
3571         (XvfbDriverTest.test_stop):
3572
3573 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
3574
3575         garden-o-matic doesn't know about reftests
3576         https://bugs.webkit.org/show_bug.cgi?id=101976
3577
3578         Reviewed by Eric Seidel.
3579
3580         Attempt to make garden-o-matic properly aware of reftests again.
3581
3582         This is re-landing r137407 with a change to
3583         rebaselineWithStatusUpdates() to actually pass the filtered
3584         failureInofLost to checkout.rebaseline().
3585
3586         Unfortunately, the testing coverage for this whole module is almost
3587         non-existent, and it's not obvious that there's a good way to
3588         stub out checkout.rebaseline() to test that the right thing
3589         happens. I verified the change manually.
3590
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3592         (.):
3593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3594         (.):
3595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3596
3597 2012-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3598
3599         "Running 1 DumpRenderTree over X shards" is not a helpful output
3600         https://bugs.webkit.org/show_bug.cgi?id=104858
3601
3602         Reviewed by Dirk Pranke.
3603
3604         The word "shard" is not typically used in test frameworks. This word is confusing for many WebKit
3605         contributors who typically don't have much experience on distributed computations and databases.
3606         So only print this message out in the debug mode.
3607
3608         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3609         * Scripts/webkitpy/layout_tests/views/printing.py:
3610         (Printer.print_workers_and_shards):
3611
3612 2012-12-13  Eric Seidel  <eric@webkit.org>
3613
3614         Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
3615         https://bugs.webkit.org/show_bug.cgi?id=104891
3616
3617         Reviewed by Ryosuke Niwa.
3618
3619         I also implemented a very simple "Sample" Profiler using
3620         Mac OS X's /usr/bin/sample command line tool.
3621
3622         The real reason for this abstraction is to make it easy
3623         to support both perf and pprof on linux which seem to
3624         be about equally popular among those I ask in the Chrome team.
3625
3626         * Scripts/webkitpy/common/system/profiler.py:
3627         (ProfilerFactory.create_profiler):
3628