Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
[WebKit-https.git] / Tools / ChangeLog
1 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
2
3         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
4         https://bugs.webkit.org/show_bug.cgi?id=165686
5
6         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
7         so that right config.h comes first in include path.
8
9 2016-12-11  Dave Hyatt  <hyatt@apple.com>
10
11         [CSS Parser] Make sure content extensions initialize AtomicString
12         https://bugs.webkit.org/show_bug.cgi?id=165737
13
14         Reviewed by Darin Adler.
15
16         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
17         (TestWebKitAPI::makeBackend):
18
19 2016-12-08  Dave Hyatt  <hyatt@apple.com>
20
21         [CSS Parser] Remove the old CSS Parser
22         https://bugs.webkit.org/show_bug.cgi?id=165645
23
24         Reviewed by Daniel Bates.
25
26         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
27         (TestWebKitAPI::TEST):
28
29 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
30
31         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
32         https://bugs.webkit.org/show_bug.cgi?id=165686
33
34         Reviewed by Michael Catanzaro.
35
36         This change reduces duplication of include path lists between modules,
37         and reduces future need for fixes like r209605 (broken build because of
38         WebCore header suddenly becoming used in WebKit2).
39
40         * DumpRenderTree/CMakeLists.txt:
41         * DumpRenderTree/PlatformMac.cmake:
42         * ImageDiff/CMakeLists.txt:
43         * MiniBrowser/gtk/CMakeLists.txt:
44         * MiniBrowser/mac/CMakeLists.txt:
45         * MiniBrowser/win/CMakeLists.txt:
46         * TestWebKitAPI/CMakeLists.txt:
47         * TestWebKitAPI/PlatformEfl.cmake:
48         * TestWebKitAPI/PlatformJSCOnly.cmake:
49         * TestWebKitAPI/PlatformMac.cmake:
50         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
51         * WebKitTestRunner/CMakeLists.txt:
52         * WebKitTestRunner/PlatformGTK.cmake:
53         * WebKitTestRunner/PlatformMac.cmake:
54
55 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
56
57         Unreviewed buildfix after r209630.
58
59         * Scripts/build-jsc: Remove building the non-existing testWASM.
60
61 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
62
63         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
64         https://bugs.webkit.org/show_bug.cgi?id=165251
65
66         Reviewed by Dean Jackson.
67
68         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
69
70         * DumpRenderTree/mac/DumpRenderTree.mm:
71         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
72
73         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
74         (WTR::InjectedBundle::beginTesting): Ditto.
75
76         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
77         (WTR::TestRunner::setMediaStreamEnabled): New.
78         (WTR::TestRunner::setPeerConnectionEnabled): New.
79         * WebKitTestRunner/InjectedBundle/TestRunner.h:
80
81 2016-12-09  Brady Eidson  <beidson@apple.com> 
82  
83         Re-landing:
84         Add _WKIconLoadingDelegate SPI. 
85         https://bugs.webkit.org/show_bug.cgi?id=164894 
86  
87         Reviewed by Alex Christensen. 
88         
89         Add MiniBrowser support for this new SPI, configurable with a setting. 
90  
91         * MiniBrowser/mac/SettingsController.h: 
92         * MiniBrowser/mac/SettingsController.m: 
93         (-[SettingsController _populateMenu]): 
94         (-[SettingsController validateMenuItem:]): 
95         (-[SettingsController loadsAllSiteIcons]): 
96         (-[SettingsController toggleLoadsAllSiteIcons:]): 
97         * MiniBrowser/mac/WK2BrowserWindowController.m: 
98         (-[WK2BrowserWindowController awakeFromNib]): 
99         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
100
101 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
102
103         Fix the 32-bit build.
104
105         Unreviewed build fix.
106
107         * MiniBrowser/mac/SettingsController.h:
108
109 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
110
111         Fedora also needs a PHP7 config file alternative
112         https://bugs.webkit.org/show_bug.cgi?id=165606
113
114         Reviewed by Michael Catanzaro.
115
116         * Scripts/webkitpy/port/base.py:
117         (Port._is_fedora_php_version_7): check for the php7 library.
118         (Port._fedora_php_version): get the appropriate filename for Fedora.
119         (Port._apache_config_file_name_for_platform):
120
121 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
122
123         Complete the revert of r208865.
124         https://bugs.webkit.org/show_bug.cgi?id=164894
125
126         Unreviewed build fix.
127
128         * MiniBrowser/mac/SettingsController.h:
129         * MiniBrowser/mac/SettingsController.m:
130         (-[SettingsController _populateMenu]):
131         (-[SettingsController validateMenuItem:]):
132         (-[SettingsController loadsAllSiteIcons]): Deleted.
133         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
134         * MiniBrowser/mac/WK2BrowserWindowController.m:
135         (-[WK2BrowserWindowController awakeFromNib]):
136         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
137
138 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
139
140         [GTK] Force GDK backend to x11 when running with XvfbDriver
141         https://bugs.webkit.org/show_bug.cgi?id=165612
142
143         Reviewed by Michael Catanzaro.
144
145         When the developer is running a Wayland session, GDK may get confused
146         and try to use its Wayland backend (which is higher priority) instead.
147         This ensures it will use the appropriate backend when running under
148         Xvfb.
149
150         * Scripts/webkitpy/port/gtk.py:
151         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
152         force GDK_BACKEND to x11.
153
154 2016-12-08  Keith Miller  <keith_miller@apple.com>
155
156         Add 64-bit signed LEB decode method
157         https://bugs.webkit.org/show_bug.cgi?id=165630
158
159         Reviewed by Ryosuke Niwa.
160
161         Add tests for LEB int64 and uint64 decode since I guess
162         I forgot to add tests before.
163
164         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
165         (TestWebKitAPI::testUInt32LEBDecode):
166         (TestWebKitAPI::TEST):
167         (TestWebKitAPI::testUInt64LEBDecode):
168         (TestWebKitAPI::testInt32LEBDecode):
169         (TestWebKitAPI::testInt64LEBDecode):
170         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
171
172 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
173
174         Make it easy to enable --force-collectContinuously
175         https://bugs.webkit.org/show_bug.cgi?id=165638
176
177         Reviewed by Keith Miller.
178
179         * Scripts/run-javascriptcore-tests:
180         (runJSCStressTests):
181
182 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
183
184         Disable the collectContinuously mode until I investigate failures.
185
186         Rubber stamped by Keith Miller.
187         
188         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
189         while I investigate.
190
191         * Scripts/run-jsc-stress-tests:
192
193 2016-12-08  Alex Christensen  <achristensen@webkit.org>
194
195         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
196         https://bugs.webkit.org/show_bug.cgi?id=165621
197
198         Reviewed by Dan Bernstein.
199
200         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
201         (TestWebKitAPI::TEST_F):
202
203 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
204
205         Concurrent GC should be stable enough to land enabled
206         https://bugs.webkit.org/show_bug.cgi?id=164990
207
208         Reviewed by Geoffrey Garen.
209         
210         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
211         
212         It's clear that this works just fine in release, but I'm still trying to figure out if it's
213         safe for debug. It might be too slow for debug.
214
215         * Scripts/run-jsc-stress-tests:
216
217 2016-12-08  Alex Christensen  <achristensen@webkit.org>
218
219         Add SPI for sending WebsiteSettings to WebProcess during navigation
220         https://bugs.webkit.org/show_bug.cgi?id=165517
221         <rdar://29341068>
222
223         Reviewed by Anders Carlsson.
224
225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
226         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
227         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
228         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
229         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
230         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
231         (TEST):
232
233 2016-12-08  Chris Dumez  <cdumez@apple.com>
234
235         Unreviewed, rolling out r209489.
236
237         Likely caused large regressions on JetStream, Sunspider and
238         Speedometer
239
240         Reverted changeset:
241
242         "Add system trace points for JavaScript VM entry/exit"
243         https://bugs.webkit.org/show_bug.cgi?id=165550
244         http://trac.webkit.org/changeset/209489
245
246 2016-12-08  Keith Miller  <keith_miller@apple.com>
247
248         Move LEB tests to API tests
249         https://bugs.webkit.org/show_bug.cgi?id=165586
250
251         Reviewed by Saam Barati.
252
253         Move the tests from testWasm.cpp and make them functions
254         rather than macros.
255
256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
257         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
258         (TestWebKitAPI::testUnsignedLEBDecode):
259         (TestWebKitAPI::TEST):
260         (TestWebKitAPI::testInt32LEBDecode):
261
262 2016-12-08  Chris Dumez  <cdumez@apple.com>
263
264         Support running the layout tests offline
265         https://bugs.webkit.org/show_bug.cgi?id=165534
266
267         Reviewed by Ryosuke Niwa.
268
269         * Scripts/webkitpy/common/system/autoinstall.py:
270         (AutoInstaller._download_to_stream):
271         getcode() returns None for file URLs so handle this.
272
273         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
274         (WebPlatformTestServer._install_modules):
275         Deal with local path in the json file and resolve them into file URLs
276         before using AutoInstall.
277
278 2016-12-08  Alex Christensen  <achristensen@webkit.org>
279
280         Fix CMake build.
281
282         * DumpRenderTree/PlatformMac.cmake:
283         Remove CheckedMalloc.cpp after r209516.
284
285 2016-12-07  Mark Lam  <mark.lam@apple.com>
286
287         DumpRenderTree should stop using CheckedMalloc.
288         https://bugs.webkit.org/show_bug.cgi?id=165563
289         <rdar://problem/28945820>
290
291         Reviewed by Geoffrey Garen.
292
293         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
294            in CheckedMalloc.
295         2. bmalloc does not honor the settings of CheckedMalloc.
296
297         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
298         malloc.  As a result, DRT exhibits different behavior from the normal way we run
299         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
300         with WKTR.
301
302         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
303         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
304         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
305         * DumpRenderTree/mac/DumpRenderTree.mm:
306         (prepareConsistentTestingEnvironment):
307
308 2016-12-07  Dean Jackson  <dino@apple.com>
309
310         Remove runtime toggle for pointer-lock
311         https://bugs.webkit.org/show_bug.cgi?id=165577
312         <rdar://problems/29566996>
313
314         Reviewed by Jon Lee.
315
316         Remove any runtime calls to check if pointer-lock is enabled. It's
317         either compiled in or out.
318
319         * DumpRenderTree/mac/DumpRenderTree.mm:
320         (resetWebPreferencesToConsistentValues):
321         * WebKitTestRunner/TestController.cpp:
322         (WTR::TestController::resetPreferencesToConsistentValues):
323
324 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
325
326         [MediaStream][Mac] Revoke sandbox extensions when capture ends
327         https://bugs.webkit.org/show_bug.cgi?id=165476
328
329         Reviewed by Brady Eidson.
330         
331         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
332         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
333         is reset and recreated when a web page exits and is reloaded.
334
335         * TestWebKitAPI/PlatformGTK.cmake:
336         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
337         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
338         (TestWebKitAPI::checkUserMediaPermissionCallback):
339         (TestWebKitAPI::TEST):
340         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
341
342 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
343
344         One esc to exit fullscreen and pointer lock
345         https://bugs.webkit.org/show_bug.cgi?id=165416
346         rdar://problem/29430711
347
348         Reviewed by Jer Noble.
349
350         Implement WKPageUIClientV8 for pointer lock support.
351         Add "escape" key support in EventSenderProxy.
352
353         * WebKitTestRunner/TestController.cpp:
354         (WTR::requestPointerLock):
355         (WTR::TestController::createOtherPage):
356         (WTR::TestController::createWebViewWithOptions):
357         * WebKitTestRunner/mac/EventSenderProxy.mm:
358         (WTR::EventSenderProxy::keyDown):
359
360 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
361
362         Add system trace points for JavaScript VM entry/exit
363         https://bugs.webkit.org/show_bug.cgi?id=165550
364
365         Reviewed by Tim Horton.
366
367         Add trace points for entry/exit into/out of the JS VM.
368
369         * Tracing/SystemTracePoints.plist:
370
371 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
372
373         [GTK] Cannot build GTK+ with CUPS 2.* versions
374         https://bugs.webkit.org/show_bug.cgi?id=163591
375
376         Reviewed by Michael Catanzaro.
377
378         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
379         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
380         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
381         old gtk+ since it requires not only bumping up glib accordingly and its consequence
382         causes many printing test failures. So, I propose to fix the configuration issue by
383         applying the change to the configure file directly. By doing this, we don't need to
384         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
385
386         * gtk/jhbuild.modules:
387         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
388
389 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
390
391         Fix use of enum in a WK2 C SPI header.
392         rdar://problem/28725583
393
394         Followup to correctly prefix the enum values.
395
396         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
397         (WTR::InjectedBundlePage::prepare):
398
399 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
400
401         Fix use of enum in a WK2 C SPI header.
402         rdar://problem/28725583
403
404         Reviewed by Dan Bernstein.
405
406         Use correct enum style for a C SPI header and fix the callers.
407
408         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
409         (WTR::InjectedBundlePage::prepare):
410
411 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
412
413         Add a new project for recording and playing back editing commands in editable web content
414         https://bugs.webkit.org/show_bug.cgi?id=165114
415         <rdar://problem/29408135>
416
417         Reviewed by Beth Dakin.
418
419         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
420         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
421         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
422         then be dragged into the playback test harness.
423
424         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
425         steps:
426
427         1. Load the capture harness and perform test-specific editing on the web view.
428         2. Let originalState be a dump of the DOM at this point in time.
429         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
430         4. Rewind all editing to the beginning.
431         5. Playback all editing to the end.
432         6. Dump the state of the DOM. This should be identical to originalState.
433
434         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
435         * EditingHistory/EditingHistory/Info.plist: Added.
436         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
437         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
438         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
439         * EditingHistory/EditingHistory/TestRunner.h: Added.
440         * EditingHistory/EditingHistory/TestRunner.m: Added.
441         (injectedMessageEventHandlerScript):
442         (-[TestRunner init]):
443         (-[TestRunner deleteBackwards:]):
444         (-[TestRunner typeString:]):
445         (-[TestRunner bodyElementSubtree]):
446         (-[TestRunner bodyTextContent]):
447         (-[TestRunner editingHistoryJSON]):
448         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
449         (-[TestRunner numberOfUpdates]):
450         (-[TestRunner jumpToUpdateIndex:]):
451         (-[TestRunner expectEvents:afterPerforming:]):
452         (-[TestRunner loadCaptureTestHarness]):
453         (-[TestRunner setTextObfuscationEnabled:]):
454         (-[TestRunner isDoneWaitingForPendingEvents]):
455         (-[TestRunner userContentController:didReceiveScriptMessage:]):
456
457         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
458         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
459
460         * EditingHistory/EditingHistory/TestUtil.h: Added.
461         * EditingHistory/EditingHistory/TestUtil.m: Added.
462         (waitUntilWithTimeout):
463         (waitUntil):
464
465         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
466
467         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
468         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
469         (-[WKWebView loadPageFromBundleNamed:]):
470         (-[WKWebView typeCharacter:]):
471         (-[WKWebView keyPressWithCharacters:keyCode:]):
472         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
473
474         Provides utilities for simulating interaction in a web view.
475
476         * EditingHistory/EditingHistory/main.m: Added.
477         (main):
478         * EditingHistory/EditingHistoryTests/Info.plist: Added.
479         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
480         (-[RewindAndPlaybackTests setUp]):
481         (-[RewindAndPlaybackTests tearDown]):
482         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
483         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
484         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
485         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
486         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
487
488 2016-12-07  Philippe Normand  <pnormand@igalia.com>
489
490         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
491         https://bugs.webkit.org/show_bug.cgi?id=165525
492
493         Reviewed by Carlos Garcia Campos.
494
495         * gtk/jhbuild.modules: gst-plugins-good should depend on the
496         libvpx package built within jhbuild.
497
498 2016-12-07  Philippe Normand  <pnormand@igalia.com>
499
500         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
501         https://bugs.webkit.org/show_bug.cgi?id=165520
502
503         Reviewed by Carlos Garcia Campos.
504
505         * gtk/jhbuild.modules: Added missing dependency on openh264 in
506         gst-plugins-bad, along with 2 upstream patches fixing the build
507         against OpenSSL 1.1.0.
508         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
509         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
510
511 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
512
513         Correct SDKROOT values in xcconfig files
514         https://bugs.webkit.org/show_bug.cgi?id=165487
515         rdar://problem/29539209
516
517         Reviewed by Dan Bernstein.
518
519         Fix suggested by Dan Bernstein.
520
521         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
522         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
523         * MiniBrowser/Configurations/DebugRelease.xcconfig:
524         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
525         * WebEditingTester/Configurations/DebugRelease.xcconfig:
526         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
527
528 2016-12-06  Daniel Bates  <dabates@apple.com>
529
530         WebKitTestRunner: Plugins are disabled in new windows
531         https://bugs.webkit.org/show_bug.cgi?id=165410
532
533         Reviewed by Alex Christensen.
534
535         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
536         a new window and loads a plugin will fail. We should enable plugins in all windows by
537         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
538
539         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
540         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
541         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
542
543         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
544         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
545         WKBundleSetPluginsEnabled().
546         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
547         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
548         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
549
550 2016-12-05  Dean Jackson  <dino@apple.com>
551
552         pointer lock needs to be feature detectable
553         https://bugs.webkit.org/show_bug.cgi?id=165426
554         <rdar://problem/29486715>
555
556         Reviewed by Antoine Quint.
557
558         Expose the comment line to turn on/off pointer lock.
559
560         * DumpRenderTree/TestOptions.h:
561         * DumpRenderTree/TestOptions.mm:
562         (TestOptions::TestOptions):
563         * DumpRenderTree/mac/DumpRenderTree.mm:
564         (resetWebPreferencesToConsistentValues):
565         * WebKitTestRunner/TestController.cpp:
566         (WTR::TestController::resetPreferencesToConsistentValues):
567         (WTR::updateTestOptionsFromTestHeader):
568         * WebKitTestRunner/TestOptions.h:
569         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
570         (WTR::PlatformWebView::viewSupportsOptions):
571         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
572         (WTR::PlatformWebView::viewSupportsOptions):
573
574 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
575
576         Make it possible to use an existing simulator instance for one-off testing
577         https://bugs.webkit.org/show_bug.cgi?id=164568
578         <rdar://problem/29189133>
579
580         Reviewed by Daniel Bates.
581
582         With this patch, if a simulator is currently running on the machine and
583         '--dedicated-simulators' is not passed into the application, only one simulator
584         instance will be used, and this instance will be the existing instance.
585         If no simulator is running or '--dedicated-simulators' is passed to the script,
586         previous behavior will be used.
587
588         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
589         (parse_args):
590         * Scripts/webkitpy/port/ios.py:
591         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
592         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
593         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
594         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
595         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
596         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
597         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
598         * Scripts/webkitpy/xcode/simulator.py:
599         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
600         (Simulator.current_device): Get currently running device.
601
602 2016-12-05  Dan Bernstein  <mitz@apple.com>
603
604         Disable a crashing test on iOS.
605
606         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
607
608 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
609
610         Fix a build break on EFL since r209303.
611
612         Unreviewed build fix.
613
614         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
615
616 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
617
618         Refactor SymbolImpl layout
619         https://bugs.webkit.org/show_bug.cgi?id=165247
620
621         Reviewed by Darin Adler.
622
623         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
624         (TestWebKitAPI::TEST):
625
626 2016-12-03  Dan Bernstein  <mitz@apple.com>
627
628         Fixed the build after r209307.
629
630         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
631         (TEST):
632
633 2016-12-03  Dan Bernstein  <mitz@apple.com>
634
635         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
636         https://bugs.webkit.org/show_bug.cgi?id=165276
637         <rdar://problem/29467040>
638
639         Reviewed by Darin Adler.
640
641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
642         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
643         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
644         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
645         (TEST):
646         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
647         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
648         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
649         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
650         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
651         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
652
653 2016-12-02  Andy Estes  <aestes@apple.com>
654
655         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
656         https://bugs.webkit.org/show_bug.cgi?id=164492
657
658         Reviewed by Dan Bernstein.
659
660         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
661         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
662         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
663         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
664         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
665         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
666         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
667         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
668         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
669         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
670         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
671         com.apple.$(PRODUCT_NAME:rfc1034identifier).
672         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
673         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
674         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
675         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
676         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
677         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
678         com.apple.$(PRODUCT_NAME:rfc1034identifier).
679         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
680         com.apple.$(PRODUCT_NAME:rfc1034identifier).
681         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
682         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
683         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
684         value ${PRODUCT_BUNDLE_IDENTIFIER}.
685         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
686         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
687         com.apple.WebKitTestRunner.InjectedBundle.
688         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
689         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
690         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
691         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
692         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
693         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
694         ${PRODUCT_BUNDLE_IDENTIFIER}.
695
696 2016-12-02  Brady Eidson  <beidson@apple.com>
697
698         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
699         https://bugs.webkit.org/show_bug.cgi?id=165330
700
701         Reviewed by Alex Christensen.
702
703         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
704
705         Problem is that doesn't reliably destroy the view.
706         We should explicitly kill the process instead.
707
708         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
709         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
710
711         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
712         (TEST):
713
714 2016-12-02  Commit Queue  <commit-queue@webkit.org>
715
716         Unreviewed, rolling out r209136.
717         https://bugs.webkit.org/show_bug.cgi?id=165337
718
719         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
720
721         Reverted changeset:
722
723         "Make it possible to use an existing simulator instance for
724         one-off testing"
725         https://bugs.webkit.org/show_bug.cgi?id=164568
726         http://trac.webkit.org/changeset/209136
727
728 2016-12-02  Chris Dumez  <cdumez@apple.com>
729
730         [Mac][WK1] Implement new HTML interactive form validation user interface
731         https://bugs.webkit.org/show_bug.cgi?id=164483
732
733         Reviewed by Simon Fraser.
734
735         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
736         on Mac DRT as this is needed by the HTML form validation layout tests.
737
738         * DumpRenderTree/mac/UIScriptControllerMac.mm:
739         (WTR::UIScriptController::contentsOfUserInterfaceItem):
740
741 2016-12-02  Brady Eidson  <beidson@apple.com>
742
743         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
744         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
745
746         Reviewed by Alexey Proskuryakov.
747
748         These tests had "run-loop races."
749         
750         The test spins the runloop waiting for one message.
751         Two messages might come in from the WebProcess in short succession, and both be delivered to the
752         UIProcess in the same spin of the runloop.
753
754         Therefore by the time the test stops spinning the runloop, notified that a message was received,
755         the first message has been overwritten by the second.
756
757         These tests are fixed by queueing the incoming messages instead of just storing one.
758
759         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
760         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
761         (getNextMessage):
762         (TEST):
763
764         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
765         (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
766         (getNextMessage):
767         (TEST):
768
769 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
770
771         Add a runtime flag for SubtleCrypto
772         https://bugs.webkit.org/show_bug.cgi?id=164982
773
774         Reviewed by Brent Fulgham.
775
776         * DumpRenderTree/mac/DumpRenderTree.mm:
777         (resetWebPreferencesToConsistentValues):
778         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
779         (WTR::InjectedBundle::beginTesting):
780         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
781         (WTR::TestRunner::setSubtleCryptoEnabled):
782         * WebKitTestRunner/InjectedBundle/TestRunner.h:
783
784 2016-12-01  Alexey Proskuryakov  <ap@apple.com>
785
786         Remove webkitpy dependency on Eliza
787         https://bugs.webkit.org/show_bug.cgi?id=164979
788
789         Reviewed by Daniel Bates.
790
791         This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!
792
793         * Scripts/webkitpy/thirdparty/__init__.py:
794         * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to
795         test buildbot instead of eliza.
796         * Scripts/webkitpy/tool/bot/ircbot.py:
797         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
798
799 2016-12-01  Beth Dakin  <bdakin@apple.com>
800
801         Force clicking tests fail on some machines
802         https://bugs.webkit.org/show_bug.cgi?id=165263
803
804         Reviewed by Tim Horton.
805
806         Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on 
807         the user account having this feature enabled. 
808         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
809         (WTR::InjectedBundle::platformInitialize):
810         * WebKitTestRunner/mac/main.mm:
811         (setDefaultsToConsistentValuesForTesting):
812
813 2016-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
814
815         Introduce StringImpl::StaticStringImpl with constexpr constructor
816         https://bugs.webkit.org/show_bug.cgi?id=165093
817
818         Reviewed by Darin Adler.
819
820         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
821         (TestWebKitAPI::TEST):
822
823 2016-11-30  Antoine Quint  <graouts@apple.com>
824
825         [Modern Media Controls] Add an HTML comment flag to turn the feature on
826         https://bugs.webkit.org/show_bug.cgi?id=165226
827
828         Reviewed by Dean Jackson.
829
830         Add a new flag to turn Modern Media Controls on in the test runners.
831
832         * DumpRenderTree/TestOptions.h:
833         * DumpRenderTree/TestOptions.mm:
834         (TestOptions::TestOptions):
835         * DumpRenderTree/mac/DumpRenderTree.mm:
836         (resetWebPreferencesToConsistentValues):
837         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
838         (WTR::InjectedBundle::beginTesting):
839         * WebKitTestRunner/TestController.cpp:
840         (WTR::TestController::resetPreferencesToConsistentValues):
841         (WTR::updateTestOptionsFromTestHeader):
842         * WebKitTestRunner/TestOptions.h:
843         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
844         (WTR::PlatformWebView::viewSupportsOptions):
845         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
846         (WTR::PlatformWebView::viewSupportsOptions):
847
848 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
849
850         Add separate settings and preferences to enable/disable async decoding for large images and animated images
851         https://bugs.webkit.org/show_bug.cgi?id=165177
852
853         Reviewed by Simon Fraser.
854         
855         Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2.
856
857         * MiniBrowser/mac/SettingsController.h:
858         * MiniBrowser/mac/SettingsController.m:
859         (-[SettingsController _populateMenu]):
860         (-[SettingsController validateMenuItem:]):
861         (-[SettingsController toggleLargeImageAsyncDecodingEnabled:]):
862         (-[SettingsController largeImageAsyncDecodingEnabled]):
863         (-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]):
864         (-[SettingsController animatedImageAsyncDecodingEnabled]):
865         (-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted.
866         (-[SettingsController asyncImageDecodingEnabled]): Deleted.
867         * MiniBrowser/mac/WK1BrowserWindowController.m:
868         (-[WK1BrowserWindowController didChangeSettings]):
869         * MiniBrowser/mac/WK2BrowserWindowController.m:
870         (-[WK2BrowserWindowController didChangeSettings]):
871
872 2016-11-30  Jonathan Bedard  <jbedard@apple.com>
873
874         Make it possible to use an existing simulator instance for one-off testing
875         https://bugs.webkit.org/show_bug.cgi?id=164568
876         <rdar://problem/29189133>
877
878         Reviewed by Daniel Bates.
879
880         With this patch, if a simulator is currently running on the machine and
881         '--dedicated-simulators' is not passed into the application, only one simulator
882         instance will be used, and this instance will be the existing instance.
883         If no simulator is running or '--dedicated-simulators' is passed to the script,
884         previous behavior will be used.
885
886         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
887         (parse_args):
888         * Scripts/webkitpy/port/ios.py:
889         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
890         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
891         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
892         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
893         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
894         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
895         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
896         * Scripts/webkitpy/xcode/simulator.py:
897         (Simulator.current_device): Get currently running device.
898
899 2016-11-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
900
901         [Linux] run-benchmark should be able to execute the benchmarks with more browsers.
902         https://bugs.webkit.org/show_bug.cgi?id=164792
903
904         Reviewed by Michael Catanzaro.
905
906         This removes the GTKBrowserDriver (and the platform 'gtk') from the run-benchmark script,
907         and adds a new LinuxBrowserDriver with a platform 'linux'.
908
909         It add also drivers for Chrome (Chromium), Firefox, Epiphany and MiniBrowser-GTK (previously MiniBrowser).
910
911         The detection of the platform is now done automatically, so it is not longer needed to pass a "--platform" parameter.
912
913         The tracking of the browser process is now more robust, we track the pid of the browser process and we only try to
914         kill the ones that were executed by this script, instead of doing a 'killall $browser' (like before).
915         We also check for browser process childs and we kill them if they are still alive after the main browser process has been killed.
916         This depends on psutil, so this will only be done if psutil is installed.
917
918         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
919         (RunBenchmarkTests.start): The platform is now autodetected and the MiniBrowser driver is renamed to MiniBrowser-GTK.
920         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
921         (BenchmarkRunner._run_benchmark): Fix a bug that caused close_browsers to be called twice. Its already called inside BenchmarkRunner._run_one_test.
922         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: Added.
923         (LinuxBrowserDriver): Implement base class that has all the needed functionality for driving the browsers.
924         (LinuxBrowserDriver.__init__):
925         (LinuxBrowserDriver.prepare_env):
926         (LinuxBrowserDriver.restore_env):
927         (LinuxBrowserDriver.close_browsers): Made the dependency on psutil optional (because it was listed as such on the README file <Tools/Scripts/webkitpy/benchmark_runner/README.md>)
928         (LinuxBrowserDriver.launch_url):
929         (LinuxBrowserDriver._get_first_executable_path_from_list):
930         (LinuxBrowserDriver._screen_size):
931         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
932         (LinuxChromeDriver):
933         (LinuxChromeDriver.launch_url):
934         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py.
935         (EpiphanyBrowserDriver):
936         (EpiphanyBrowserDriver.launch_url):
937         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
938         (LinuxFirefoxDriver):
939         (LinuxFirefoxDriver.launch_url):
940         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
941         (GTKMiniBrowserDriver):
942         (GTKMiniBrowserDriver.launch_url):
943         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
944         (SimpleHTTPServerDriver):
945         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
946         (getplatform):
947         (getdefaultbrowser):
948         (parse_args):
949         * Scripts/webkitpy/benchmark_runner/utils.py:
950         (load_subclasses): The loading of subclasses was still (even after r196979) sensitive to the order in which the modules are loaded.
951         We have to ensure that the files containing subclasses of the base_class_file are loaded after the base_class_file,
952         we can do that by matching against the base_class_file pattern when the list is created.
953
954 2016-11-29  Andy Estes  <aestes@apple.com>
955
956         [Cocoa] Enable two clang warnings recommended by Xcode
957         https://bugs.webkit.org/show_bug.cgi?id=164498
958
959         Reviewed by Mark Lam.
960
961         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
962         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
963         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
964         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
965
966 2016-11-29  Eric Carlson  <eric.carlson@apple.com>
967
968         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
969         https://bugs.webkit.org/show_bug.cgi?id=164760
970         <rdar://problem/29261266>
971
972         Reviewed by Youenn Fablet.
973         
974         Allow scripts to determine the number of times the user has been prompted for capture device access.
975
976         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
977         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
978         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
979         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
980         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
981         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
982         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
983         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
984         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
985         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
986         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
987         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
988         * WebKitTestRunner/InjectedBundle/TestRunner.h:
989         * WebKitTestRunner/TestController.cpp:
990         (WTR::TestController::resetStateToConsistentValues):
991         (WTR::OriginSettings::incrementRequestCount):
992         (WTR::OriginSettings::resetRequestCount):
993         (WTR::OriginSettings::requestCount):
994         (WTR::TestController::saltForOrigin):
995         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
996         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
997         (WTR::TestController::settingsForOrigin):
998         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
999         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
1000         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1001         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
1002         * WebKitTestRunner/TestController.h:
1003         * WebKitTestRunner/TestInvocation.cpp:
1004         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1005         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1006
1007 2016-11-29  Simon Fraser  <simon.fraser@apple.com>
1008
1009         intersection-observer-entry-interface.html test fails on the bots
1010         https://bugs.webkit.org/show_bug.cgi?id=165133
1011
1012         Reviewed by Darin Adler.
1013         
1014         Tests that enabled Intersection Observer via <!-- webkit-test-runner [ enableIntersectionObserver=true ] -->
1015         would fail sometimes, because TestController::ensureViewSupportsOptionsForTest() failed to check
1016         to see if this option required creating a new web view, so would just use the old view without
1017         even resetting preferences.
1018         
1019         In general, TestController doesn't distinguish properly between options that require the creation
1020         of a new view (like mock scrollbars), and those that can be simply reset as resetPreferencesToConsistentValues()
1021         does.
1022         
1023         Do the easy fix of having viewSupportsOptions() check options.enableIntersectionObserver. We should probably
1024         just call resetPreferencesToConsistentValues() even when re-use the same view.
1025         
1026         * WebKitTestRunner/TestController.cpp:
1027         (WTR::TestController::resetPreferencesToConsistentValues):
1028         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1029         (WTR::PlatformWebView::viewSupportsOptions):
1030         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1031         (WTR::PlatformWebView::viewSupportsOptions):
1032
1033 2016-11-28  Ryan Haddad  <ryanhaddad@apple.com>
1034
1035         Unreviewed, rolling out r209008.
1036
1037         This change appears to have caused two fast/mediastrem
1038         LayoutTests to fail.
1039
1040         Reverted changeset:
1041
1042         "[MediaStream] Don't request user permission for a device if
1043         it has already been granted in the current browsing context"
1044         https://bugs.webkit.org/show_bug.cgi?id=164760
1045         http://trac.webkit.org/changeset/209008
1046
1047 2016-11-28  Daniel Bates  <dabates@apple.com>
1048
1049         Teach webkitpy how to read CSSProperties.json r209001
1050         https://bugs.webkit.org/show_bug.cgi?id=165108
1051
1052         Reviewed by Simon Fraser.
1053
1054         Fix webkitpy logic so that it can read CSS property names from CSSProperties.json following r209001.
1055
1056         Following r209001 CSSPropertyNames.in no longer exists as it was replaced with CSSProperties.json.
1057         We need to modify the webkitpy machinery that processed CSSPropertyNames.in to process CSSProperties.json.
1058
1059         * Scripts/webkitpy/w3c/test_converter.py:
1060         (_W3CTestConverter.__init__): Make self._css_property_file and self._css_property_value_file local
1061         variables as it is unnecessary for them to be instance variables. Call read_webkit_prefixed_css_property_list()
1062         to read the property names from file CSSProperties.json. Call legacy_read_webkit_prefixed_css_property_list() to
1063         read CSS keyword values from CSSValueKeywords.in.
1064         (_W3CTestConverter.read_webkit_prefixed_css_property_list): Added.
1065         (_W3CTestConverter):
1066         (_W3CTestConverter.legacy_read_webkit_prefixed_css_property_list): Renamed from read_webkit_prefixed_css_property_list.
1067         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1068         (TestImporterTest.test_harnesslinks_conversion): Substitute CSSProperties.json for CSSPropertyNames.in.
1069
1070 2016-11-28  Eric Carlson  <eric.carlson@apple.com>
1071
1072         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
1073         https://bugs.webkit.org/show_bug.cgi?id=164760
1074         <rdar://problem/29261266>
1075
1076         Reviewed by Youenn Fablet.
1077         
1078         Allow scripts to determine the number of times the user has been prompted for capture device access.
1079
1080         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1081         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1082         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1083         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
1084         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1085         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
1086         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1087         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1088         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
1089         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
1090         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
1091         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
1092         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1093         * WebKitTestRunner/TestController.cpp:
1094         (WTR::TestController::resetStateToConsistentValues):
1095         (WTR::OriginSettings::incrementRequestCount):
1096         (WTR::OriginSettings::resetRequestCount):
1097         (WTR::OriginSettings::requestCount):
1098         (WTR::TestController::saltForOrigin):
1099         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
1100         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1101         (WTR::TestController::settingsForOrigin):
1102         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
1103         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
1104         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1105         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
1106         * WebKitTestRunner/TestController.h:
1107         * WebKitTestRunner/TestInvocation.cpp:
1108         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1109         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1110
1111 2016-11-18  Jer Noble  <jer.noble@apple.com>
1112
1113         Add some performance tests for various aspects of media loading and playback.
1114         https://bugs.webkit.org/show_bug.cgi?id=164977
1115
1116         Reviewed by Darin Adler.
1117
1118         Allow callers to pass in extra alias/directory pairs to run-webkit-httpd.
1119
1120         * Scripts/run-webkit-httpd:
1121         (parse_args):
1122         (main):
1123
1124 2016-11-27  Simon Fraser  <simon.fraser@apple.com>
1125
1126         Another fix for CMake.
1127
1128         * DumpRenderTree/TestOptions.h:
1129         * DumpRenderTree/TestOptions.mm:
1130
1131 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
1132
1133         Better fix for the Mac CMake build.
1134
1135         * DumpRenderTree/PlatformMac.cmake:
1136
1137 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
1138
1139         Attempt to fix Mac CMake build.
1140
1141         * DumpRenderTree/PlatformMac.cmake:
1142
1143 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1144
1145         [WTF] Import std::optional reference implementation as WTF::Optional
1146         https://bugs.webkit.org/show_bug.cgi?id=164199
1147
1148         Reviewed by Saam Barati and Sam Weinig.
1149
1150         Use WTF::Optional::value_or.
1151
1152         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1153         (WTR::UIScriptController::stableStateOverride):
1154         (WTR::UIScriptController::setStableStateOverride):
1155         * TestRunnerShared/Bindings/JSWrappable.h:
1156         (WTR::JSValueMakeBooleanOrNull):
1157         (WTR::JSValueToNullableBoolean):
1158         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1159         (WTR::UIScriptController::stableStateOverride):
1160         (WTR::UIScriptController::setStableStateOverride):
1161         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1162         * TestWebKitAPI/Tests/WTF/Optional.cpp:
1163         (TestWebKitAPI::TEST):
1164         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
1165         (TestWebKitAPI::testParseHTMLInteger):
1166         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
1167         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1168         (TestWebKitAPI::checkURL):
1169         (TestWebKitAPI::checkRelativeURL):
1170         (TestWebKitAPI::checkURLDifferences):
1171         (TestWebKitAPI::checkRelativeURLDifferences):
1172         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1173         (WTR::UIScriptController::stableStateOverride):
1174         (WTR::UIScriptController::setStableStateOverride):
1175
1176 2016-11-26  Sam Weinig  <sam@webkit.org>
1177
1178         Convert IntersectionObserver over to using RuntimeEnabledFeatures so it can be properly excluded from script
1179         https://bugs.webkit.org/show_bug.cgi?id=164965
1180
1181         Reviewed by Simon Fraser.
1182
1183         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1184         Add new files.
1185
1186         * DumpRenderTree/TestOptions.h: Added.
1187         * DumpRenderTree/TestOptions.mm: Added.
1188         (parseBooleanTestHeaderValue):
1189         (TestOptions::TestOptions):
1190         Port TestOption parsing from WKTR to DRT.
1191
1192         * DumpRenderTree/mac/DumpRenderTree.mm:
1193         (resetWebPreferencesToConsistentValues):
1194         (resetWebViewToConsistentStateBeforeTesting):
1195         (runTest):
1196         * WebKitTestRunner/TestController.cpp:
1197         Pass TestOptions down to resetWebPreferencesToConsistentValues to allow setting
1198         preferences conditionally.
1199
1200         (WTR::TestController::resetPreferencesToConsistentValues):
1201         (WTR::updateTestOptionsFromTestHeader):
1202         * WebKitTestRunner/TestOptions.h:
1203         Add a new test option header, enableIntersectionObserver, to enable IntersectionObserver.
1204
1205 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
1206
1207         Migrate some layout timer-related code from std::chrono to Seconds and MonotonicTime
1208         https://bugs.webkit.org/show_bug.cgi?id=164992
1209
1210         Reviewed by Darin Adler.
1211         
1212         Use Seconds::zero().
1213
1214         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1215
1216 2016-11-26  Simon Fraser  <simon.fraser@apple.com>
1217
1218         Add literals for various time units
1219         https://bugs.webkit.org/show_bug.cgi?id=165074
1220
1221         Reviewed by Filip Pizlo.
1222         
1223         Add tests for new time literals. Add new tests for units.
1224
1225         * TestWebKitAPI/Tests/WTF/Time.cpp:
1226         (TestWebKitAPI::TEST):
1227
1228 2016-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1229
1230         Fix compile warnings after r208415
1231         https://bugs.webkit.org/show_bug.cgi?id=165061
1232
1233         Reviewed by Andy Estes.
1234
1235         * TestWebKitAPI/Tests/WTF/Time.cpp:
1236         (TestWebKitAPI::TEST):
1237
1238 2016-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1239
1240         [GTK] Notifications API does not expose or respect the "tag" attribute
1241         https://bugs.webkit.org/show_bug.cgi?id=164771
1242
1243         Reviewed by Gustavo Noronha Silva.
1244
1245         Verify that showing a notification with the same tag as another notification closes the
1246         previous notification before the new notification is shown.
1247
1248         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1249         (testWebViewNotification):
1250
1251 2016-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1252
1253         Unreviewed. Fix GTK+ test /webkit2/WebKitWebContext/get-plugins after r208429.
1254
1255         Test plugin library was renamed as libTestNetscapePlugIn.so in r208429.
1256
1257         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1258         (testWebContextGetPlugins): Update the library name.
1259
1260 2016-11-22  Darin Adler  <darin@apple.com>
1261
1262         Make normal case fast in the input element limitString function
1263         https://bugs.webkit.org/show_bug.cgi?id=165023
1264
1265         Reviewed by Dan Bernstein.
1266
1267         * TestWebKitAPI/CMakeLists.txt: Added TextBreakIterator.cpp.
1268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1269         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp: Added.
1270         Contains some tests for the numGraphemeClusters and
1271         numCharactersInGraphemeClusters functions that I used to make sure
1272         that the new fast paths I added work correctly.
1273
1274 2016-11-22  Tomas Popela  <tpopela@redhat.com>
1275
1276         Unreviewed, add myself as a WebKit committer.
1277
1278         * Scripts/webkitpy/common/config/contributors.json:
1279
1280 2016-11-21  Mark Lam  <mark.lam@apple.com>
1281
1282         Hasher::addCharacters() should be able to handle zero length strings.
1283         https://bugs.webkit.org/show_bug.cgi?id=165024
1284
1285         Reviewed by Yusuke Suzuki.
1286
1287         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1288         (TestWebKitAPI::TEST):
1289
1290 2016-11-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1291
1292         [CMake] build fails after update to cmake 3.7
1293         https://bugs.webkit.org/show_bug.cgi?id=165008
1294
1295         Reviewed by Dan Bernstein.
1296
1297         When we remove the CMake cache, we should remove both the
1298         CMakeCache.txt file and the CMakeFiles directory.
1299         See: https://gitlab.kitware.com/cmake/cmake/issues/14820
1300
1301         * Scripts/webkitdirs.pm:
1302         (cmakeFilesPath):
1303         (removeCMakeCache):
1304
1305 2016-11-16  Philippe Normand  <pnormand@igalia.com>
1306
1307         [GTK][WebRTC] Switch to downstream OpenWebRTC and more recent GStreamer
1308         https://bugs.webkit.org/show_bug.cgi?id=164817
1309
1310         Reviewed by Alejandro G. Castro.
1311
1312         This is temporary, hopefully. The OpenWebRTC patches will/should
1313         be soon reviewed and upstream but meanwhile it makes sense to use
1314         the Igalia downstream fork so that the WebRTC testing is easier.
1315
1316         Recent GStreamer patches are also needed for RTP bundling support
1317         and RTP retransmission fixes.
1318
1319         * gtk/jhbuild.modules:
1320         * gtk/openwebrtc.modules: Removed.
1321         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Added.
1322         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Added.
1323         * gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1324
1325 2016-11-20  Zan Dobersek  <zdobersek@igalia.com>
1326
1327         [EncryptedMedia] Make EME API runtime-enabled
1328         https://bugs.webkit.org/show_bug.cgi?id=164927
1329
1330         Reviewed by Jer Noble.
1331
1332         Enable the EME API via the WKTR InjectedBundle whenever testing
1333         commences. This does not have any effect unless the EME feature
1334         is enabled at compile-time, but it's still added to match other
1335         features and for future use.
1336
1337         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1338         (WTR::InjectedBundle::beginTesting):
1339         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1340         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1341         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1342
1343 2016-11-19  Simon Fraser  <simon.fraser@apple.com>
1344
1345         Fix the Mac and iOS bulds.
1346
1347         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1348         (-[TestRunnerWKWebView _stableStateOverride]):
1349         (-[TestRunnerWKWebView _setStableStateOverride:]):
1350
1351 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
1352
1353         Make it possible to test non-stable-state scrolling on iOS
1354         https://bugs.webkit.org/show_bug.cgi?id=164905
1355
1356         Reviewed by Dan Bernstein.
1357
1358         Make it possible for an iOS layout test to force every visible rect update
1359         from the UI process to the web process to be in a non-stable state. This emulates
1360         what happens during panning and zooming interactions, and allows us to test the
1361         scrolling and layer trees in these transient states.
1362         
1363         This is done by adding a testing property on WKWebView, _stableStateOverride, whose
1364         getters and setters are overridden in TestRunnerWKWebView. When non-nil, we _updateVisibleContentRectAfterScrollInView
1365         consults the NSNumber's boolValue and uses it to override the stable state.
1366         
1367         To facilitate this kind of testing, also add immediateScrollToOffset() and
1368         immediateZoomToScale() to UIScriptController. Finally, add doAfterPresentationUpdate()
1369         which provides a callback that fires after one trip to the web process and back.
1370         
1371         Add code generation support for optional boolean attributes in IDL.
1372
1373         Align CodeGeneratorDumpRenderTree.pm and CodeGeneratorTestRunner.pm.
1374
1375         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1376         (_generateImplementationFile):
1377         (_platformTypeConstructor):
1378         (_returnExpression):
1379         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1380         (WTR::UIScriptController::doAfterPresentationUpdate):
1381         (WTR::contentOffsetBoundedInValidRange):
1382         (WTR::UIScriptController::scrollToOffset):
1383         (WTR::UIScriptController::immediateScrollToOffset):
1384         (WTR::UIScriptController::immediateZoomToScale):
1385         (WTR::UIScriptController::stableStateOverride):
1386         (WTR::UIScriptController::setStableStateOverride):
1387         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1388         (WTR::UIScriptController::doAfterPresentationUpdate):
1389         * TestRunnerShared/Bindings/JSWrappable.h:
1390         (WTR::JSValueMakeBooleanOrNull):
1391         (WTR::JSValueToNullableBoolean):
1392         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1393         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1394         (WTR::UIScriptController::immediateScrollToOffset):
1395         (WTR::UIScriptController::immediateZoomToScale):
1396         (WTR::UIScriptController::stableStateOverride):
1397         (WTR::UIScriptController::setStableStateOverride):
1398         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1399         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1400         (_classRefGetter):
1401         (_platformTypeConstructor):
1402         (_returnExpression):
1403         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1404         (-[TestRunnerWKWebView dealloc]):
1405         (-[TestRunnerWKWebView _stableStateOverride]):
1406         (-[TestRunnerWKWebView _setStableStateOverride:]):
1407         * WebKitTestRunner/ios/TestControllerIOS.mm:
1408         (WTR::TestController::platformResetStateToConsistentValues):
1409         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1410         (WTR::UIScriptController::doAsyncTask):
1411         (WTR::UIScriptController::doAfterPresentationUpdate):
1412         (WTR::UIScriptController::zoomToScale):
1413         (WTR::UIScriptController::immediateScrollToOffset):
1414         (WTR::UIScriptController::immediateZoomToScale):
1415         (WTR::UIScriptController::stableStateOverride):
1416         (WTR::UIScriptController::setStableStateOverride):
1417         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1418         (WTR::UIScriptController::doAfterPresentationUpdate):
1419
1420 2016-11-19  Joanmarie Diggs  <jdiggs@igalia.com>
1421
1422         AX: [ATK] Expose aria-busy via ATK_STATE_BUSY
1423         https://bugs.webkit.org/show_bug.cgi?id=164909
1424
1425         Reviewed by Chris Fleizach.
1426
1427         Implement boolAttributeValue() for ATK so we can test AXElementBusy.
1428
1429         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1430         (WTR::AccessibilityUIElement::boolAttributeValue):
1431
1432 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
1433
1434         [iOS WK2] Eliminate a source of flakiness in layout tests by forcing WebPage into "responsive" mode for all tests, with an internals override
1435         https://bugs.webkit.org/show_bug.cgi?id=164980
1436
1437         Reviewed by Chris Dumez.
1438
1439         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1440         (WTR::InjectedBundlePage::prepare):
1441
1442 2016-11-18  Dean Jackson  <dino@apple.com>
1443
1444         AX: "(inverted-colors)" media query only matches on page reload; should match on change
1445         https://bugs.webkit.org/show_bug.cgi?id=163564
1446         <rdar://problem/28807350>
1447
1448         Reviewed by Simon Fraser.
1449
1450         Add a UIScriptController method that tricks WebKit into thinking
1451         it has received a notification that accessibility settings have
1452         changed. Combined with our forced overrides, this allows us to
1453         test if a page would react to the notifications.
1454
1455         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1456         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
1457         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1458         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
1459         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1460         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1461         (WTR::simulateAccessibilitySettingsChangeNotification):
1462         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1463         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1464         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
1465         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1466         (WTR::UIScriptController::simulateAccessibilitySettingsChangeNotification):
1467
1468 2016-11-18  Alex Christensen  <achristensen@webkit.org>
1469
1470         Fix API test after r208902
1471         https://bugs.webkit.org/show_bug.cgi?id=144194
1472
1473         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
1474         (TestWebKitAPI::TEST):
1475         The fullwidth solidus, U+FF0F, changed encoding from IDN2003 to IDN2008, probably to prevent domains from using it
1476         to spoof other domains.  https://webkit.org/blog/ and https://webkit.org\uFF0Fblog/ would otherwise look 
1477         too similar when rendered.
1478
1479 2016-11-17  Alex Christensen  <achristensen@webkit.org>
1480
1481         Support IDN2008 with UTS #46 instead of IDN2003
1482         https://bugs.webkit.org/show_bug.cgi?id=144194
1483
1484         Reviewed by Darin Adler.
1485
1486         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1487         (TestWebKitAPI::TEST_F):
1488         Add some tests from http://unicode.org/faq/idn.html verifying that we follow UTS46's deviations from IDN2008.
1489         Add some tests based on https://tools.ietf.org/html/rfc5893 verifying that we check for bidirectional text.
1490         Add a test based on https://tools.ietf.org/html/rfc5892 verifying that we do not do ContextO check.
1491         Add a test for U+321D and U+321E which have particularly interesting punycode encodings.  We match Firefox here now.
1492         Also add a test from http://www.unicode.org/reports/tr46/#IDNAComparison verifying we are not using IDN2003.
1493         We should consider importing all of http://www.unicode.org/Public/idna/9.0.0/IdnaTest.txt as URL domain tests.
1494
1495 2016-11-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1496
1497         Downloads started by context menu actions should also have a web view associated
1498         https://bugs.webkit.org/show_bug.cgi?id=164364
1499
1500         Reviewed by Michael Catanzaro.
1501
1502         Add a GTK+ unit tests to check that downloads started by the context menu have a web view associated.
1503
1504         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1505         (downloadLocalFileSuccessfully):
1506         (testDownloadOverwriteDestinationDisallowed):
1507         (testDownloadLocalFileError):
1508         (testDownloadRemoteFile):
1509         (testDownloadRemoteFileError):
1510         (testDownloadMIMEType):
1511         (contextMenuCallback):
1512         (testContextMenuDownloadActions):
1513         (beforeAll):
1514
1515 2016-11-17  Ryosuke Niwa  <rniwa@webkit.org>
1516
1517         Add an experimental API to find elements across shadow boundaries
1518         https://bugs.webkit.org/show_bug.cgi?id=164851
1519         <rdar://problem/28220092>
1520
1521         Reviewed by Sam Weinig.
1522
1523         Added test cases for window.collectMatchingElementsInFlatTree to WebKit2.InjectedBundleMakeAllShadowRootOpen.
1524
1525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1526         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRoot*s*Open_Bundle.cpp: Renamed
1527         from InjectedBundleMakeAllShadowRootOpen_Bundle.cpp.
1528         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize): Added test cases for
1529         window.collectMatchingElementsInFlatTree by calling alert() many times.
1530         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1531         (TestWebKitAPI::runJavaScriptAlert): Added expectations for multiple test cases. Each test case
1532         finishes with a call to alert, and moves testNumber forward.
1533         (TestWebKitAPI::TEST): Use the newly added closed-shadow-tree-test.html
1534         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Added. Creates a shadow tree with slots
1535         and tests that window.collectMatchingElementsInFlatTree is not present when
1536         an event named "testnormalworld" is dispatched by the injected bundle.
1537
1538 2016-11-17  Brady Eidson  <beidson@apple.com>
1539
1540         Add _WKIconLoadingDelegate SPI.
1541         https://bugs.webkit.org/show_bug.cgi?id=164894
1542
1543         Reviewed by Alex Christensen.
1544
1545         Add MiniBrowser support for this new SPI, configurable with a setting.
1546
1547         * MiniBrowser/mac/SettingsController.h:
1548         * MiniBrowser/mac/SettingsController.m:
1549         (-[SettingsController _populateMenu]):
1550         (-[SettingsController validateMenuItem:]):
1551         (-[SettingsController loadsAllSiteIcons]):
1552         (-[SettingsController toggleLoadsAllSiteIcons:]):
1553         * MiniBrowser/mac/WK2BrowserWindowController.m:
1554         (-[WK2BrowserWindowController awakeFromNib]):
1555         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]):
1556
1557 2016-11-17  Caitlin Potter  <caitp@igalia.com>
1558
1559         [JSC] remove leftover references to ES2017_ASYNCFUNCTION_SYNTAX flag
1560         https://bugs.webkit.org/show_bug.cgi?id=164879
1561
1562         Reviewed by Alex Christensen.
1563
1564         The flag was referenced in FeatureList.pm and in one of the
1565         FeatureDefines.xcconfig files, despite being removed.
1566
1567         * Scripts/webkitperl/FeatureList.pm:
1568         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1569
1570 2016-11-17  Per Arne Vollan  <pvollan@apple.com>
1571
1572         [Win] run-api-tests is failing.
1573         https://bugs.webkit.org/show_bug.cgi?id=164818
1574
1575         Reviewed by Alexey Proskuryakov.
1576
1577         Make sure Visual Studio interprets string literal as utf8.
1578  
1579         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1580         (TestWebKitAPI::TEST_F):
1581
1582 2016-11-17  Yusuke Suzuki  <utatane.tea@gmail.com>
1583
1584         [JSC] WTF::TemporaryChange with WTF::SetForScope
1585         https://bugs.webkit.org/show_bug.cgi?id=164761
1586
1587         Reviewed by Saam Barati.
1588
1589         * TestWebKitAPI/CMakeLists.txt:
1590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1591         * TestWebKitAPI/Tests/WTF/SetForScope.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporaryChange.cpp.
1592         (TestWebKitAPI::TEST):
1593         * WebKitTestRunner/TestController.cpp:
1594         (WTR::TestController::resetStateToConsistentValues):
1595
1596 2016-11-16  Alexey Proskuryakov  <ap@apple.com>
1597
1598         REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing
1599         https://bugs.webkit.org/show_bug.cgi?id=164572
1600
1601         Reviewed by Tim Horton.
1602
1603         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformResetStateToConsistentValues):
1604         Use the correct constant.
1605
1606 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1607
1608         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
1609         https://bugs.webkit.org/show_bug.cgi?id=164827
1610
1611         Reviewed by Ryosuke Niwa.
1612
1613         Enabled ES6 Modules in test runners.
1614
1615         * DumpRenderTree/mac/DumpRenderTree.mm:
1616         (resetWebPreferencesToConsistentValues):
1617         * DumpRenderTree/win/DumpRenderTree.cpp:
1618         (resetWebPreferencesToConsistentValues):
1619         * Scripts/webkitperl/FeatureList.pm:
1620         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1621         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1622         (WTR::InjectedBundle::beginTesting):
1623         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1624         (WTR::TestRunner::setES6ModulesEnabled):
1625         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1626
1627 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
1628
1629         Hard to write reliable UIScriptController scrollingTreeAsText tests
1630         https://bugs.webkit.org/show_bug.cgi?id=164764
1631
1632         Reviewed by Wenson Hsieh.
1633
1634         Fix one cause of flakiness by resetting the WKWebView's UIScrollView scale
1635         and scroll position between tests.
1636
1637         * WebKitTestRunner/ios/TestControllerIOS.mm:
1638         (WTR::TestController::platformResetStateToConsistentValues):
1639
1640 2016-11-16  Simon Fraser  <simon.fraser@apple.com>
1641
1642         UIScriptController: script with no async tasks fails if an earlier script registered a callback
1643         https://bugs.webkit.org/show_bug.cgi?id=164762
1644
1645         Reviewed by Wenson Hsieh.
1646         
1647         Make TestRunner::callUIScriptCallback() async in DumpRenderTree to match WebKitTestRunner behavior.
1648         This fixes ui-side-script-with-callback.html in WK1, which failed because the second runUIScript()
1649         would occur inside the completion callback from the first. This no longer happens.
1650
1651         * DumpRenderTree/TestRunner.cpp:
1652         (TestRunner::callUIScriptCallback):
1653         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1654         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
1655
1656 2016-11-16  Ryan Haddad  <ryanhaddad@apple.com>
1657
1658         Unreviewed, rolling out r208770.
1659
1660         The test added with this change is timing out on mac-wk1.
1661
1662         Reverted changeset:
1663
1664         "UIScriptController: script with no async tasks fails if an
1665         earlier script registered a callback"
1666         https://bugs.webkit.org/show_bug.cgi?id=164762
1667         http://trac.webkit.org/changeset/208770
1668
1669 2016-11-16  Per Arne Vollan  <pvollan@apple.com>
1670
1671         [Win] WebCore test is failing.
1672         https://bugs.webkit.org/show_bug.cgi?id=164772
1673
1674         Reviewed by Brent Fulgham.
1675
1676         The value of CGRectInfinite is not the same on Windows as on Mac.
1677
1678         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1679         (TestWebKitAPI::TEST):
1680
1681 2016-11-15  Alexey Proskuryakov  <ap@apple.com>
1682
1683         Update Youenn's e-mail addresses.
1684
1685         * Scripts/webkitpy/common/config/contributors.json:
1686
1687 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
1688
1689         UIScriptController: script with no async tasks fails if an earlier script registered a callback
1690         https://bugs.webkit.org/show_bug.cgi?id=164762
1691
1692         Reviewed by Wenson Hsieh.
1693         
1694         UIScriptContext::runUIScript() considers a script to be "immediate" if that script doesn't
1695         queue any async tasks. However, if an earlier UI script registered a callback, UIScriptContext::runUIScript()
1696         would consider that an outstanding task.
1697         
1698         Fix by unregistering any callbacks associated with the current UI script when uiScriptComplete() is called.
1699
1700         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1701         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
1702
1703 2016-11-15  Simon Fraser  <simon.fraser@apple.com>
1704
1705         UIScriptController: setting a callback to undefined should unregister it
1706         https://bugs.webkit.org/show_bug.cgi?id=164796
1707
1708         Reviewed by Dean Jackson.
1709         
1710         "Immediate" UI scripts (those that don't schedule any async tasks) should return
1711         immediately, without the need to call uiScriptComplete(). However, this is broken if
1712         an earlier UI script registered a callback (since no-one clears that callback after the
1713         first script completes).
1714
1715         Make possible the workaround of setting the callback to undefined, which previously did
1716         not clear the callback registration.
1717
1718         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1719         (UIScriptContext::registerCallback):
1720         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1721         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1722         (WTR::UIScriptController::platformClearAllCallbacks):
1723
1724 2016-11-14  Mark Lam  <mark.lam@apple.com>
1725
1726         Enhance run-jsc-stress-test script to allow optional test specific options to be added for all test run configurations.
1727         https://bugs.webkit.org/show_bug.cgi?id=164695
1728
1729         Reviewed by Keith Miller.
1730
1731         This gives us more flexibility when specific tests needs to enable special JSC
1732         options in order to exercise specific code paths to be tested.  It also saves us
1733         from having to create duplicate test run configurations e.g. runMiscFTLNoCJITTest.
1734         We can now just use runFTLNoCJIT in its place.
1735
1736         Also replaced the ifJSCArgIsntProvidedAreWeReleaseBuild variable with $buildType
1737         so that we have the ability to skip certain tests for release or debug builds.
1738         This will be needed in the upcoming patch for https://webkit.org/b/155145.
1739
1740         * Scripts/run-jsc-stress-tests:
1741
1742 2016-11-14  Joanmarie Diggs  <jdiggs@igalia.com>
1743
1744         AX: [ATK] Expose STATE_SINGLE_LINE and STATE_MULTI_LINE for ARIA searchbox role
1745         https://bugs.webkit.org/show_bug.cgi?id=164712
1746
1747         Reviewed by Chris Fleizach.
1748
1749         Add AccessibilityUIElement::isSingleLine, AccessibilityUIElement::isMultiLine
1750         to DRT and WKTR. Implement it for ATK.
1751
1752         * DumpRenderTree/AccessibilityUIElement.h:
1753         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1754         (AccessibilityUIElement::isSingleLine):
1755         (AccessibilityUIElement::isMultiLine):
1756         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1757         (AccessibilityUIElement::isSingleLine):
1758         (AccessibilityUIElement::isMultiLine):
1759         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1760         (AccessibilityUIElement::isSingleLine):
1761         (AccessibilityUIElement::isMultiLine):
1762         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1763         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1764         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1765         (WTR::AccessibilityUIElement::isSingleLine):
1766         (WTR::AccessibilityUIElement::isMultiLine):
1767         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1768         (WTR::AccessibilityUIElement::isSingleLine):
1769         (WTR::AccessibilityUIElement::isMultiLine):
1770         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1771         (WTR::AccessibilityUIElement::isSingleLine):
1772         (WTR::AccessibilityUIElement::isMultiLine):
1773
1774 2016-11-14  Youenn Fablet  <youenn@apple.com>
1775
1776         Support WPT templated tests
1777         https://bugs.webkit.org/show_bug.cgi?id=164707
1778
1779         Reviewed by Sam Weinig.
1780
1781         * Scripts/webkitpy/w3c/test_importer.py:
1782         (TestImporter.write_html_files_for_templated_js_tests): Generating empty HTML files for templated JS tests.
1783         (TestImporter.import_tests):
1784
1785 2016-11-13  JF Bastien  <jfbastien@apple.com>
1786
1787         Implement WTF::Expected
1788         https://bugs.webkit.org/show_bug.cgi?id=164526
1789
1790         Reviewed by Yusuke Suzuki.
1791
1792         std::expected isn't in C++17, and may be in C++20. It's a nice
1793         complement to std::any / std::optional because it's a type-tagged
1794         union which has a single expected result but could also contain an
1795         error.
1796
1797         This would be useful in the WebAssembly parser, for example.
1798
1799         Using this implementation will allow us to provide feedback to the
1800         standards committee and guide std::expected's design before it
1801         gets standardized. I've already sent a bunch of feedback to the
1802         author based on my experience implementing this.
1803
1804         This could supplement WTF::Either and WTF::ExceptionOr.
1805
1806         * TestWebKitAPI/CMakeLists.txt:
1807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1808         * TestWebKitAPI/Tests/WTF/Expected.cpp: Added.
1809         (WTF::operator<<):
1810         (TestWebKitAPI::TEST):
1811         (TestWebKitAPI::foo::foo):
1812         (TestWebKitAPI::foo::~foo):
1813         (TestWebKitAPI::foo::operator==):
1814         (TestWebKitAPI::operator<<):
1815
1816 2016-11-12  Simon Fraser  <simon.fraser@apple.com>
1817
1818         Add a way to get the UI-side scrolling tree as text via UIScriptController
1819         https://bugs.webkit.org/show_bug.cgi?id=164697
1820
1821         Reviewed by Zalan Bujtas.
1822
1823         Add UIScriptController::scrollingTreeAsText(), which gets the state of the scrolling
1824         tree in the UI process, including the current positions of CALayers. This will be used
1825         to test UI-side scrolling and visual viewports.
1826
1827         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1828         (WTR::UIScriptController::scrollingTreeAsText):
1829         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1830         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1831         (WTR::UIScriptController::scrollingTreeAsText):
1832         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1833         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1834         (WTR::UIScriptController::scrollingTreeAsText):
1835
1836 2016-11-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1837
1838         The main content heuristic should be robust when handling large media elements
1839         https://bugs.webkit.org/show_bug.cgi?id=164676
1840         <rdar://problem/29211503>
1841
1842         Reviewed by Eric Carlson.
1843
1844         Added a new test verifying that enormous video elements are handled gracefully when put through the main
1845         content heuristic.
1846
1847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1848         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1849         (TestWebKitAPI::TEST):
1850         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Added.
1851
1852 2016-11-12  Dan Bernstein  <mitz@apple.com>
1853
1854         run-safari does not work for open source contributors
1855         https://bugs.webkit.org/show_bug.cgi?id=164667
1856         <rdar://problem/29229894>
1857
1858         Reviewed by Joseph Pecoraro.
1859
1860         * Scripts/run-api-tests:
1861         (archCommandLineArgumentsForRestrictedEnvironmentVariables): Moved from here…
1862         * Scripts/webkitdirs.pm:
1863         (archCommandLineArgumentsForRestrictedEnvironmentVariables): …to here
1864         (runMacWebKitApp): Have arch(1) carry the DYLD_* variables we set in our environmet over
1865           to the environment of the app being run.
1866
1867 2016-11-11  Joseph Pecoraro  <pecoraro@apple.com>
1868
1869         Removed unused INCLUDE_OPTIONS_FOR_DEBUGGING
1870         https://bugs.webkit.org/show_bug.cgi?id=164664
1871
1872         Reviewed by Dan Bernstein.
1873
1874         * Scripts/debug-minibrowser:
1875         * Scripts/debug-safari:
1876         * Scripts/debug-test-runner:
1877         * Scripts/webkitdirs.pm:
1878         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
1879         There are no debug specific options anymore.
1880
1881 2016-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1882
1883         [WK2] autocorrect and autocapitalize attributes do not work in contenteditable elements
1884         https://bugs.webkit.org/show_bug.cgi?id=164538
1885         <rdar://problem/8418711>
1886
1887         Reviewed by Ryosuke Niwa.
1888
1889         Adds support for being able to test autocorrect and autocapitalize attributes in contenteditable areas. To do
1890         this, we add removeAllDynamicDictionaries to UIScriptController in order to ensure that autocorrect suggestions
1891         are reset to their defaults prior to running contenteditable-autocorrect-off.html.
1892
1893         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1894         (WTR::UIScriptController::removeAllDynamicDictionaries):
1895         * Scripts/webkitpy/port/ios.py:
1896         (IOSSimulatorPort._createSimulatorApp):
1897         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1898         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1899         (WTR::UIScriptController::removeAllDynamicDictionaries):
1900         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1901         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1902         (-[TestRunnerWKWebView _keyboardDidShow:]):
1903         (-[TestRunnerWKWebView _keyboardDidHide:]):
1904
1905         Work around an issue where consecutive UIKeyboardDidShowNotification would cause keyboard appearance callbacks
1906         to be fired multiple times. This was causing a single key press to cause two characters to be typed. While this
1907         does not affect the correctness of existing tests, the new autocorrection test requires this workaround.
1908
1909         * WebKitTestRunner/ios/UIKitSPI.h:
1910         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1911         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1912         (WTR::UIScriptController::removeAllDynamicDictionaries):
1913
1914 2016-11-11  Alex Christensen  <achristensen@webkit.org>
1915
1916         Build all Mac API tests
1917         https://bugs.webkit.org/show_bug.cgi?id=164633
1918
1919         Reviewed by Gyuyoung Kim.
1920
1921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1922         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
1923
1924 2016-11-11  Alex Christensen  <achristensen@webkit.org>
1925
1926         Allow mutable lambdas in HashMap::ensure
1927         https://bugs.webkit.org/show_bug.cgi?id=164642
1928
1929         Reviewed by Sam Weinig.
1930
1931         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1932         (TestWebKitAPI::TEST):
1933
1934 2016-11-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1935
1936         Composition state should be cleared when changing focus to a non-editable element
1937         https://bugs.webkit.org/show_bug.cgi?id=164595
1938         <rdar://problem/26412551>
1939
1940         Reviewed by Enrica Casucci.
1941
1942         Adds support for window.textInputController in DumpRenderTree on iOS. So far, only the methods needed for the
1943         new layout test (editing/focus-change-with-marked-text.html) are supported. These are insertText, setMarkedText,
1944         and markedRange.
1945
1946         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1947         * DumpRenderTree/TextInputController.h: Renamed from Tools/DumpRenderTree/mac/TextInputController.h.
1948
1949         Remove the PLATFORM(MAC) guard for defining the TextInputController. Also, move the TextInputController header
1950         out of the /mac platform directory.
1951
1952         * DumpRenderTree/ios/TextInputControllerIOS.m: Added.
1953         (+[TextInputController isSelectorExcludedFromWebScript:]):
1954         (+[TextInputController webScriptNameForSelector:]):
1955         (-[TextInputController initWithWebView:]):
1956         (-[TextInputController markedRange]):
1957         (-[TextInputController insertText:]):
1958         (-[TextInputController setMarkedText:selectedFrom:length:]):
1959
1960         Introduces TextInputControllerIOS.m, which contains an iOS implementation of TextInputController. Only a subset
1961         of the methods available on the Mac version will be available on iOS for now (see above).
1962
1963         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1964
1965         Remove the PLATFORM(MAC) guard for initializing the TextInputController and binding it to the window object.
1966
1967         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1968         * DumpRenderTree/mac/TextInputControllerMac.m: Renamed from Tools/DumpRenderTree/mac/TextInputController.m.
1969         (-[WebHTMLView interpretKeyEvents:]):
1970         (-[WebNSRange initWithNSRange:]):
1971         (-[WebNSRange location]):
1972         (-[WebNSRange length]):
1973         (+[WebNSRange isSelectorExcludedFromWebScript:]):
1974         (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
1975         (+[NSMutableAttributedString webScriptNameForSelector:]):
1976         (-[NSMutableAttributedString getLength]):
1977         (-[NSMutableAttributedString ranges]):
1978         (-[NSMutableAttributedString attributeNamesAtIndex:]):
1979         (-[NSMutableAttributedString valueOfAttribute:atIndex:]):
1980         (-[NSMutableAttributedString addAttribute:value:]):
1981         (-[NSMutableAttributedString addAttribute:value:from:length:]):
1982         (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:]):
1983         (-[NSMutableAttributedString addColorAttribute:red:green:blue:alpha:from:length:]):
1984         (-[NSMutableAttributedString addFontAttribute:fontName:size:]):
1985         (-[NSMutableAttributedString addFontAttribute:fontName:size:from:length:]):
1986         (+[TextInputController isSelectorExcludedFromWebScript:]):
1987         (+[TextInputController webScriptNameForSelector:]):
1988         (-[TextInputController initWithWebView:]):
1989         (-[TextInputController dealloc]):
1990         (-[TextInputController textInput]):
1991         (-[TextInputController insertText:]):
1992         (-[TextInputController doCommand:]):
1993         (-[TextInputController setMarkedText:selectedFrom:length:]):
1994         (-[TextInputController unmarkText]):
1995         (-[TextInputController hasMarkedText]):
1996         (-[TextInputController conversationIdentifier]):
1997         (-[TextInputController substringFrom:length:]):
1998         (-[TextInputController attributedSubstringFrom:length:]):
1999         (-[TextInputController legacyAttributedString:]):
2000         (-[TextInputController markedRange]):
2001         (-[TextInputController selectedRange]):
2002         (-[TextInputController firstRectForCharactersFrom:length:]):
2003         (-[TextInputController characterIndexForPointX:Y:]):
2004         (-[TextInputController validAttributesForMarkedText]):
2005         (-[TextInputController attributedStringWithString:]):
2006         (-[TextInputController stringWithUndoGroupingInsertion:]):
2007         (-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
2008         (-[TextInputController setInputMethodHandler:]):
2009         (-[TextInputController interpretKeyEvents:withSender:]):
2010
2011         Fixes miscellaneous style issues.
2012
2013 2016-11-11  Philippe Normand  <pnormand@igalia.com>
2014
2015         [GTK][JHbuild] bump libnice version in openwebrtc.modules
2016         https://bugs.webkit.org/show_bug.cgi?id=164586
2017
2018         Reviewed by Michael Catanzaro.
2019
2020         Update to a recent libnice git snapshot and remove patches already
2021         upstream or not applying anymore. The patches not upstream yet
2022         will be reported in Phabricator.
2023
2024         * gtk/openwebrtc.modules:
2025         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Removed.
2026         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Removed.
2027         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Removed.
2028         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Removed.
2029         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Removed.
2030
2031 2016-11-10  Alex Christensen  <achristensen@webkit.org>
2032
2033         Fix assertion after r208534.
2034         https://bugs.webkit.org/show_bug.cgi?id=160497
2035
2036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2037         * TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added.
2038         (TestWebKitAPI::TEST):
2039         Add a regression test.
2040
2041 2016-11-10  Chris Dumez  <cdumez@apple.com>
2042
2043         REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
2044         https://bugs.webkit.org/show_bug.cgi?id=164570
2045
2046         Reviewed by Simon Fraser.
2047
2048         Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to
2049         avoid flakiness.
2050
2051         * WebKitTestRunner/TestController.cpp:
2052         (WTR::TestController::resetStateToConsistentValues):
2053
2054 2016-11-10  Miguel Gomez  <magomez@igalia.com>
2055
2056         Unreviewed. Added myself to the list of committers.
2057
2058         * Scripts/webkitpy/common/config/contributors.json:
2059
2060 2016-10-27  Sergio Villar Senin  <svillar@igalia.com>
2061
2062         [GTK] New API to notify about dynamically added forms
2063         https://bugs.webkit.org/show_bug.cgi?id=164050
2064
2065         Reviewed by Carlos Garcia Campos.
2066
2067         Added a new test case to verify that dinamically added forms correctly trigger the
2068         "form-controls-associated" signal from WebPage.
2069
2070         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2071         (didAssociateFormControlsCallback):
2072         (testWebExtensionFormControlsAssociated):
2073         (beforeAll):
2074         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2075         (DelayedSignal::DelayedSignal):
2076         (emitFormControlsAssociated):
2077         (formControlsAssociatedCallback):
2078         (pageCreatedCallback):
2079
2080 2016-11-09  Ryosuke Niwa  <rniwa@webkit.org>
2081
2082         WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange
2083         https://bugs.webkit.org/show_bug.cgi?id=164501
2084         <rdar://problem/29152282>
2085
2086         Reviewed by Sam Weinig.
2087
2088         * DumpRenderTree/mac/TextInputController.m:
2089         (-[TextInputController legacyAttributedString:]):
2090
2091 2016-11-09  Chris Dumez  <cdumez@apple.com>
2092
2093         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
2094         https://bugs.webkit.org/show_bug.cgi?id=164458
2095         <rdar://problem/28905514>
2096
2097         Reviewed by Darin Adler.
2098
2099         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
2100         tests can request that such resources are downloaded instead of being ignored.
2101
2102         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2103         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2104         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2105         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2106         * WebKitTestRunner/TestController.cpp:
2107         (WTR::TestController::decidePolicyForNavigationResponse):
2108         * WebKitTestRunner/TestController.h:
2109         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
2110         * WebKitTestRunner/TestInvocation.cpp:
2111         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2112
2113 2016-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2114
2115         NetworkSession: Network process crash when converting main resource to download
2116         https://bugs.webkit.org/show_bug.cgi?id=164220
2117
2118         Reviewed by Alex Christensen.
2119
2120         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
2121         converted to a download and another one to test the cancellation as the test was doing before. When doing the
2122         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
2123         download.
2124
2125         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2126         (testPolicyResponseDownload):
2127         (testPolicyResponseDownloadCancel):
2128         (beforeAll):
2129
2130 2016-11-09  KwangHyuk Kim  <hyuki.kim@samsung.com>
2131
2132         [EFL] fix error message caused by eina log
2133         https://bugs.webkit.org/show_bug.cgi?id=164546
2134
2135         Reviewed by Gyuyoung Kim.
2136
2137         Fix error message caused by eina log when MiniBrowser is working with help option.
2138
2139         * MiniBrowser/efl/main.c:
2140         (quit):
2141
2142 2016-11-09  Brent Fulgham  <bfulgham@apple.com>
2143
2144         Unreviewed build fix after r208509.
2145
2146         * DumpRenderTree/win/TestRunnerWin.cpp:
2147         (TestRunner::setNeedsStorageAccessFromFileURLsQuirk): Add missing TestRunner implementation."
2148
2149 2016-11-09  Alex Christensen  <achristensen@webkit.org>
2150
2151         Unreviewed, rolling out r208438.
2152
2153         crashes
2154
2155         Reverted changeset:
2156
2157         "[WK2][NETWORK_SESSION] Add support for downloading file
2158         backed blobs"
2159         https://bugs.webkit.org/show_bug.cgi?id=164458
2160         http://trac.webkit.org/changeset/208438
2161
2162 2016-11-04  Brent Fulgham  <bfulgham@apple.com>
2163
2164         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
2165         https://bugs.webkit.org/show_bug.cgi?id=155185
2166         <rdar://problem/11101440>
2167
2168         Reviewed by Brady Eidson.
2169
2170         * DumpRenderTree/TestRunner.cpp:
2171         (setNeedsLocalStorageQuirkCallback): Added.
2172         (TestRunner::staticFunctions):
2173         * DumpRenderTree/TestRunner.h:
2174         * DumpRenderTree/mac/DumpRenderTree.mm:
2175         (resetWebPreferencesToConsistentValues): Update for new quirk setting.
2176         * DumpRenderTree/mac/TestRunnerMac.mm:
2177         (TestRunner::setNeedsLocalStorageQuirk):
2178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2179         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2180         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2181         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm:
2182         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Added.
2183         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Added.
2184         (-[LocalStorageQuirkMessageHandler userContentController:didReceiveScriptMessage:]):
2185         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2186         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2187         (WTR::InjectedBundle::beginTesting): Update for new quirk setting.
2188         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2189         (WTR::TestRunner::setNeedsLocalStorageQuirk): Added.
2190         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2191
2192 2016-11-09  Alex Christensen  <achristensen@webkit.org>
2193
2194         URLParser should not consider path of URLs with no host to start at the first slash after the colon
2195         https://bugs.webkit.org/show_bug.cgi?id=164555
2196
2197         Reviewed by Tim Horton.
2198
2199         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2200         (TestWebKitAPI::TEST_F):
2201
2202 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
2203
2204         test-webkitpy failing test_create_patch_is_full_patch unit test
2205         https://bugs.webkit.org/show_bug.cgi?id=164385
2206
2207         Reviewed by Darin Adler.
2208
2209         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Fixed expected output to match output.
2210
2211 2016-11-09  Chris Dumez  <cdumez@apple.com>
2212
2213         [Mac] Stop using deprecated AppKit enumeration values
2214         https://bugs.webkit.org/show_bug.cgi?id=164494
2215
2216         Reviewed by Darin Adler.
2217
2218         Stop using deprecated AppKit enumeration values.
2219
2220         * DumpRenderTree/mac/EventSendingController.mm:
2221         (eventTypeForMouseButtonAndAction):
2222         (modifierFlags):
2223         (-[EventSendingController mouseMoveToX:Y:]):
2224         (-[EventSendingController contextClick]):
2225         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2226         * DumpRenderTree/mac/TextInputController.m:
2227         (-[TextInputController interpretKeyEvents:withSender:]):
2228         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
2229         (simulateCommandArrow):
2230         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
2231         (TestWebKitAPI::TEST):
2232         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm:
2233         (TestWebKitAPI::TEST):
2234         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
2235         (TestWebKitAPI::TEST):
2236         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2237         (TEST):
2238         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm:
2239         (UserInitiatedActionTest::SetUp):
2240         (UserInitiatedActionTest::click):
2241         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
2242         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2243         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2244         (TestWebKitAPI::contextMenuCopyLink):
2245         (TestWebKitAPI::TEST):
2246         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
2247         (TestWebKitAPI::TEST):
2248         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2249         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
2250         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2251         (TestWebKitAPI::TEST):
2252         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2253         (TestWebKitAPI::Util::isKeyDown):
2254         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2255         (TestWebKitAPI::PlatformWebView::initialize):
2256         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2257         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2258         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2259         (TestWebKitAPI::eventTypeForButton):
2260         (TestWebKitAPI::modifierFlagsForWKModifiers):
2261         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
2262         (__simulated_forceClickAssociatedEventsMask):
2263         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2264         (-[TestWKWebView _setUpTestWindow:]):
2265         (-[TestWKWebView typeCharacter:]):
2266         * WebKitTestRunner/mac/EventSenderProxy.mm:
2267         (WTR::eventTypeForMouseButtonAndAction):
2268         (WTR::buildModifierFlags):
2269         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2270         (WTR::EventSenderProxy::mouseForceClick):
2271         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
2272         (WTR::EventSenderProxy::mouseMoveTo):
2273         (WTR::EventSenderProxy::keyDown):
2274         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2275         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2276         (WTR::PlatformWebView::PlatformWebView):
2277         * WebKitTestRunner/mac/TestControllerMac.mm:
2278         (WTR::TestController::platformResetStateToConsistentValues):
2279
2280 2016-11-09  Beth Dakin  <bdakin@apple.com>
2281
2282         Support TouchBar in WebKit
2283         https://bugs.webkit.org/show_bug.cgi?id=164437
2284         -and corresponding-
2285         rdar://problem/28876524
2286
2287         Reviewed by Darin Adler.
2288
2289         This makes MiniBrowser support TouchBar customization. 
2290
2291         * MiniBrowser/mac/AppDelegate.m:
2292         (-[BrowserAppDelegate awakeFromNib]):
2293
2294 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2295
2296         [EFL] Use libgcrypt instead of GnuTLS for CryptoDigest
2297         https://bugs.webkit.org/show_bug.cgi?id=164461
2298
2299         Reviewed by Michael Catanzaro.
2300
2301         As GTK port in r208297, EFL port starts to use libgcrypt instead of GnuTLS as well.
2302
2303         * efl/install-dependencies: Add libgcript package dependecy.
2304
2305 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2306
2307         [EFL] Remove unused function in MiniBrowser
2308         https://bugs.webkit.org/show_bug.cgi?id=164398
2309
2310         Reviewed by Darin Adler.
2311
2312         * MiniBrowser/efl/main.c:
2313         (window_find_with_elm_window): Deleted because it is not used anywhere.
2314
2315 2016-11-09  Chris Dumez  <cdumez@apple.com>
2316
2317         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
2318         https://bugs.webkit.org/show_bug.cgi?id=164458
2319         <rdar://problem/28905514>
2320
2321         Reviewed by Darin Adler.
2322
2323         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
2324         tests can request that such resources are downloaded instead of being ignored.
2325
2326         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2327         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2328         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2329         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2330         * WebKitTestRunner/TestController.cpp:
2331         (WTR::TestController::decidePolicyForNavigationResponse):
2332         * WebKitTestRunner/TestController.h:
2333         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
2334         * WebKitTestRunner/TestInvocation.cpp:
2335         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2336
2337 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
2338
2339         Make rpaths more robust for iOS Simulators
2340         https://bugs.webkit.org/show_bug.cgi?id=164521
2341
2342         Reviewed by Simon Fraser.
2343
2344         * Scripts/webkitpy/port/ios.py:
2345         (IOSSimulatorPort._createSimulatorApp): Added more robust path.
2346
2347 2016-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2348
2349         Fix Tools build on case sensitive file systems
2350         https://bugs.webkit.org/show_bug.cgi?id=164474
2351
2352         Unreviewed buildfix.
2353
2354         * DumpRenderTree/CMakeLists.txt:
2355         * DumpRenderTree/PlatformMac.cmake:
2356         * DumpRenderTree/PlatformWin.cmake:
2357         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2358         * MiniBrowser/mac/CMakeLists.txt:
2359
2360 2016-11-04  Filip Pizlo  <fpizlo@apple.com>
2361
2362         WTF::ParkingLot should stop using std::chrono because std::chrono::duration casts are prone to overflows
2363         https://bugs.webkit.org/show_bug.cgi?id=152045
2364
2365         Reviewed by Andy Estes.
2366
2367         * TestWebKitAPI/CMakeLists.txt:
2368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2369         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2370         (TestWebKitAPI::TEST):
2371         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
2372         (TestWebKitAPI::ToUpperConverter::stopProducing):
2373         (TestWebKitAPI::ToUpperConverter::stopConsuming):
2374         * TestWebKitAPI/Tests/WTF/Time.cpp: Added.
2375         (WTF::operator<<):
2376         (TestWebKitAPI::TEST):
2377
2378 2016-11-04  Alex Christensen  <achristensen@webkit.org>
2379
2380         Unreviewed, rolling out r208293.
2381
2382         asserts in API tests.
2383
2384         Reverted changeset:
2385
2386         "NetworkSession: Network process crash when converting main
2387         resource to download"
2388         https://bugs.webkit.org/show_bug.cgi?id=164220
2389         http://trac.webkit.org/changeset/208293
2390
2391 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2392
2393         Add a setting and preferences to enable/disable async image decoding
2394         https://bugs.webkit.org/show_bug.cgi?id=164417
2395
2396         Reviewed by Simon Fraser.
2397
2398         Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2.
2399
2400         * MiniBrowser/mac/SettingsController.h:
2401         * MiniBrowser/mac/SettingsController.m:
2402         (-[SettingsController _populateMenu]):
2403         (-[SettingsController validateMenuItem:]):
2404         (-[SettingsController toggleAsyncImageDecodingEnabled:]):
2405         (-[SettingsController asyncImageDecodingEnabled]):
2406         * MiniBrowser/mac/WK1BrowserWindowController.m:
2407         (-[WK1BrowserWindowController didChangeSettings]):
2408         * MiniBrowser/mac/WK2BrowserWindowController.m:
2409         (-[WK2BrowserWindowController didChangeSettings]):
2410
2411 2016-11-04  Brady Eidson  <beidson@apple.com>
2412
2413         REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
2414         https://bugs.webkit.org/show_bug.cgi?id=164390
2415
2416         Reviewed by Geoffrey Garen.
2417
2418         Operating under the assumption that the behavior change is okay/desirable, this updates the test.
2419
2420         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2421         (TestWebKitAPI::TEST):
2422
2423 2016-11-04  Joanmarie Diggs  <jdiggs@igalia.com>
2424
2425         AX: [ATK] Attempting to clear selection on ARIA listboxes results in crash
2426         https://bugs.webkit.org/show_bug.cgi?id=164331
2427
2428         Reviewed by Chris Fleizach.
2429
2430         Add AccessibilityUIElement::clearSelectedChildren() to DRT and WKTR.
2431         Implement it for ATK.
2432
2433         * DumpRenderTree/AccessibilityUIElement.h:
2434         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2435         (AccessibilityUIElement::clearSelectedChildren):
2436         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2437         (AccessibilityUIElement::clearSelectedChildren):
2438         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2439         (AccessibilityUIElement::clearSelectedChildren):
2440         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2441         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2442         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2443         (WTR::AccessibilityUIElement::clearSelectedChildren):
2444         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2445         (WTR::AccessibilityUIElement::clearSelectedChildren):
2446         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2447         (WTR::AccessibilityUIElement::clearSelectedChildren):
2448
2449 2016-11-04  Per Arne Vollan  <pvollan@apple.com>
2450
2451         [Win] Page visibility tests are timing out.
2452         https://bugs.webkit.org/show_bug.cgi?id=164363
2453
2454         Reviewed by Brent Fulgham.
2455
2456         Implement methods to set page visibility.
2457
2458         * DumpRenderTree/win/TestRunnerWin.cpp:
2459         (TestRunner::resetPageVisibility):
2460         (TestRunner::setPageVisibility):
2461
2462 2016-11-03  Simon Fraser  <simon.fraser@apple.com>
2463
2464         Give all the geometry classes a single-argument scale() function for consistency
2465         https://bugs.webkit.org/show_bug.cgi?id=164400
2466
2467         Reviewed by Zalan Bujtas.
2468         
2469         Test single-argument scale().
2470
2471         * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp:
2472         (TestWebKitAPI::TEST):
2473
2474 2016-11-03  Chris Dumez  <cdumez@apple.com>
2475
2476         [WK2][Cocoa] Implement user interface for HTML form validation
2477         https://bugs.webkit.org/show_bug.cgi?id=164143
2478         <rdar://problem/28944652>
2479
2480         Reviewed by Simon Fraser.
2481
2482         Add support for UIScriptController::contentsOfUserInterfaceItem("validationBubble")
2483         on both Mac and iOS to retrieve the currently displayed validation message.
2484
2485         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2486         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2487         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2488         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2489         (WTR::UIScriptController::selectFormAccessoryPickerRow):
2490         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2491         (WTR::UIScriptController::contentsOfUserInterfaceItem):
2492
2493 2016-11-03  Konstantin Tokarev  <annulen@yandex.ru>
2494
2495         Fixes to build JSCOnly on macOS
2496         https://bugs.webkit.org/show_bug.cgi?id=164379
2497
2498         Reviewed by Michael Catanzaro.
2499
2500         * TestWebKitAPI/PlatformJSCOnly.cmake: Moved BUILDING_JSCONLY__
2501         definition to OptionsJSCOnly.cmake
2502
2503 2016-11-03  Dan Bernstein  <mitz@apple.com>
2504
2505         WKWebView’s _observedRenderingProgressEvents not restored after web process crash
2506         https://bugs.webkit.org/show_bug.cgi?id=164368
2507         <rdar://problem/29091954>
2508
2509         Reviewed by Anders Carlsson.
2510
2511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2512         * TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Added.
2513         (TEST):
2514
2515 2016-11-03  Alex Christensen  <achristensen@webkit.org>
2516
2517         Purge PassRefPtr from Tools
2518         https://bugs.webkit.org/show_bug.cgi?id=164358
2519
2520         Reviewed by Michael Catanzaro.
2521
2522         * ImageDiff/efl/ImageDiff.cpp:
2523         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
2524         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2525         (WTR::AccessibilityController::create):
2526         (WTR::AccessibilityController::rootElement):
2527         (WTR::AccessibilityController::focusedElement):
2528         (WTR::AccessibilityController::elementAtPoint):
2529         (WTR::AccessibilityController::addNotificationListener): Deleted.
2530         (WTR::AccessibilityController::removeNotificationListener): Deleted.
2531         (WTR::AccessibilityController::accessibleElementById): Deleted.
2532         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2533         (WTR::AccessibilityController::resetToConsistentState): Deleted.
2534         (WTR::AccessibilityController::platformName): Deleted.
2535         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2536         (WTR::AccessibilityController::logAccessibilityEvents):
2537         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2538         (WTR::AccessibilityTextMarker::create):
2539         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h:
2540         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2541         (WTR::AccessibilityTextMarkerRange::create):
2542         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h:
2543         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2544         (WTR::AccessibilityUIElement::create):
2545         (WTR::AccessibilityUIElement::linkedElement):
2546         (WTR::AccessibilityUIElement::headerElementAtIndex):
2547         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2548         (WTR::AccessibilityUIElement::characterAtOffset):
2549         (WTR::AccessibilityUIElement::wordAtOffset):
2550         (WTR::AccessibilityUIElement::lineAtOffset):
2551         (WTR::AccessibilityUIElement::sentenceAtOffset):
2552         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2553         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2554         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2555         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2556         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2557         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2558         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2559         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2560         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2561         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2562         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2563         (WTR::AccessibilityUIElement::AccessibilityUIElement): Deleted.
2564         (WTR::AccessibilityUIElement::~AccessibilityUIElement): Deleted.
2565         (WTR::AccessibilityUIElement::isEqual): Deleted.
2566         (WTR::AccessibilityUIElement::elementAtPoint): Deleted.
2567         (WTR::AccessibilityUIElement::childAtIndex): Deleted.
2568         (WTR::AccessibilityUIElement::indexOfChild): Deleted.
2569         (WTR::AccessibilityUIElement::childrenCount): Deleted.
2570         (WTR::AccessibilityUIElement::titleUIElement): Deleted.
2571         (WTR::AccessibilityUIElement::parentElement): Deleted.
2572         (WTR::AccessibilityUIElement::takeFocus): Deleted.
2573         (WTR::AccessibilityUIElement::takeSelection): Deleted.
2574         (WTR::AccessibilityUIElement::addSelection): Deleted.
2575         (WTR::AccessibilityUIElement::removeSelection): Deleted.
2576         (WTR::AccessibilityUIElement::allAttributes): Deleted.
2577         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements): Deleted.
2578         (WTR::AccessibilityUIElement::linkedUIElementAtIndex): Deleted.
2579         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Deleted.
2580         (WTR::AccessibilityUIElement::attributesOfChildren): Deleted.
2581         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Deleted.
2582         (WTR::AccessibilityUIElement::increment): Deleted.
2583         (WTR::AccessibilityUIElement::decrement): Deleted.
2584         (WTR::AccessibilityUIElement::showMenu): Deleted.
2585         (WTR::AccessibilityUIElement::press): Deleted.
2586         (WTR::AccessibilityUIElement::stringAttributeValue): Deleted.
2587         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): Deleted.
2588         (WTR::AccessibilityUIElement::uiElementAttributeValue): Deleted.
2589         (WTR::AccessibilityUIElement::numberAttributeValue): Deleted.
2590         (WTR::AccessibilityUIElement::boolAttributeValue): Deleted.
2591         (WTR::AccessibilityUIElement::isAttributeSupported): Deleted.
2592         (WTR::AccessibilityUIElement::isAttributeSettable): Deleted.
2593         (WTR::AccessibilityUIElement::isPressActionSupported): Deleted.
2594         (WTR::AccessibilityUIElement::isIncrementActionSupported): Deleted.
2595         (WTR::AccessibilityUIElement::isDecrementActionSupported): Deleted.
2596         (WTR::AccessibilityUIElement::role): Deleted.
2597         (WTR::AccessibilityUIElement::subrole): Deleted.
2598         (WTR::AccessibilityUIElement::roleDescription): Deleted.
2599         (WTR::AccessibilityUIElement::computedRoleString): Deleted.
2600         (WTR::AccessibilityUIElement::title): Deleted.
2601         (WTR::AccessibilityUIElement::description): Deleted.
2602         (WTR::AccessibilityUIElement::language): Deleted.
2603         (WTR::AccessibilityUIElement::stringValue): Deleted.
2604         (WTR::AccessibilityUIElement::accessibilityValue): Deleted.
2605         (WTR::AccessibilityUIElement::helpText): Deleted.
2606         (WTR::AccessibilityUIElement::orientation): Deleted.
2607         (WTR::AccessibilityUIElement::x): Deleted.
2608         (WTR::AccessibilityUIElement::y): Deleted.
2609         (WTR::AccessibilityUIElement::width): Deleted.
2610         (WTR::AccessibilityUIElement::height): Deleted.
2611         (WTR::AccessibilityUIElement::intValue): Deleted.
2612         (WTR::AccessibilityUIElement::minValue): Deleted.
2613         (WTR::AccessibilityUIElement::maxValue): Deleted.
2614         (WTR::AccessibilityUIElement::valueDescription): Deleted.
2615         (WTR::AccessibilityUIElement::insertionPointLineNumber): Deleted.
2616         (WTR::AccessibilityUIElement::selectedTextRange): Deleted.
2617         (WTR::AccessibilityUIElement::isEnabled): Deleted.
2618         (WTR::AccessibilityUIElement::isRequired): Deleted.
2619         (WTR::AccessibilityUIElement::isFocused): Deleted.
2620         (WTR::AccessibilityUIElement::isFocusable): Deleted.
2621         (WTR::AccessibilityUIElement::isSelected): Deleted.
2622         (WTR::AccessibilityUIElement::isSelectedOptionActive): Deleted.
2623         (WTR::AccessibilityUIElement::isSelectable): Deleted.
2624         (WTR::AccessibilityUIElement::isMultiSelectable): Deleted.
2625         (WTR::AccessibilityUIElement::setSelectedChild): Deleted.
2626         (WTR::AccessibilityUIElement::setSelectedChildAtIndex): Deleted.
2627         (WTR::AccessibilityUIElement::removeSelectionAtIndex): Deleted.
2628         (WTR::AccessibilityUIElement::selectedChildrenCount): Deleted.
2629         (WTR::AccessibilityUIElement::selectedChildAtIndex): Deleted.
2630         (WTR::AccessibilityUIElement::isExpanded): Deleted.
2631         (WTR::AccessibilityUIElement::isChecked): Deleted.
2632         (WTR::AccessibilityUIElement::isIndeterminate): Deleted.
2633         (WTR::AccessibilityUIElement::isVisible): Deleted.
2634         (WTR::AccessibilityUIElement::isOffScreen): Deleted.
2635         (WTR::AccessibilityUIElement::isCollapsed): Deleted.
2636         (WTR::AccessibilityUIElement::isIgnored): Deleted.
2637         (WTR::AccessibilityUIElement::hasPopup): Deleted.
2638         (WTR::AccessibilityUIElement::hierarchicalLevel): Deleted.
2639         (WTR::AccessibilityUIElement::clickPointX): Deleted.
2640         (WTR::AccessibilityUIElement::clickPointY): Deleted.
2641         (WTR::AccessibilityUIElement::documentEncoding): Deleted.
2642         (WTR::AccessibilityUIElement::documentURI): Deleted.
2643         (WTR::AccessibilityUIElement::url): Deleted.
2644         (WTR::AccessibilityUIElement::speak): Deleted.
2645         (WTR::AccessibilityUIElement::attributesOfColumnHeaders): Deleted.
2646         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Deleted.
2647         (WTR::AccessibilityUIElement::attributesOfColumns): Deleted.
2648         (WTR::AccessibilityUIElement::attributesOfRows): Deleted.
2649         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Deleted.
2650         (WTR::AccessibilityUIElement::attributesOfHeader): Deleted.
2651         (WTR::AccessibilityUIElement::indexInTable): Deleted.
2652         (WTR::AccessibilityUIElement::rowIndexRange): Deleted.
2653         (WTR::AccessibilityUIElement::columnIndexRange): Deleted.
2654         (WTR::AccessibilityUIElement::rowCount): Deleted.
2655         (WTR::AccessibilityUIElement::columnCount): Deleted.
2656         (WTR::AccessibilityUIElement::rowHeaders): Deleted.
2657         (WTR::AccessibilityUIElement::columnHeaders): Deleted.
2658         (WTR::AccessibilityUIElement::selectedRowAtIndex): Deleted.
2659         (WTR::AccessibilityUIElement::disclosedByRow): Deleted.
2660         (WTR::AccessibilityUIElement::disclosedRowAtIndex): Deleted.
2661         (WTR::AccessibilityUIElement::rowAtIndex): Deleted.
2662         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): Deleted.
2663         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): Deleted.
2664         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): Deleted.
2665         (WTR::AccessibilityUIElement::ariaIsGrabbed): Deleted.
2666         (WTR::AccessibilityUIElement::ariaDropEffects): Deleted.
2667         (WTR::AccessibilityUIElement::classList): Deleted.
2668         (WTR::AccessibilityUIElement::lineForIndex): Deleted.
2669         (WTR::AccessibilityUIElement::rangeForLine): Deleted.
2670         (WTR::AccessibilityUIElement::rangeForPosition): Deleted.
2671         (WTR::AccessibilityUIElement::boundsForRange): Deleted.
2672         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
2673         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
2674         (WTR::AccessibilityUIElement::stringForRange): Deleted.
2675         (WTR::AccessibilityUIElement::attributedStringForRange): Deleted.
2676         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): Deleted.
2677         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): Deleted.
2678         (WTR::AccessibilityUIElement::uiElementForSearchPredicate): Deleted.
2679         (WTR::AccessibilityUIElement::selectTextWithCriteria): Deleted.
2680         (WTR::AccessibilityUIElement::cellForColumnAndRow): Deleted.
2681         (WTR::AccessibilityUIElement::horizontalScrollbar): Deleted.
2682         (WTR::AccessibilityUIElement::verticalScrollbar): Deleted.
2683         (WTR::AccessibilityUIElement::addNotificationListener): Deleted.
2684         (WTR::AccessibilityUIElement::removeNotificationListener): Deleted.
2685         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Deleted.
2686         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Deleted.
2687         (WTR::AccessibilityUIElement::textMarkerRangeLength): Deleted.
2688         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Deleted.
2689         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Deleted.
2690         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Deleted.
2691         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Deleted.
2692         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Deleted.
2693         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Deleted.
2694         (WTR::AccessibilityUIElement::textMarkerForPoint): Deleted.
2695         (WTR::AccessibilityUIElement::previousTextMarker): Deleted.
2696         (WTR::AccessibilityUIElement::nextTextMarker): Deleted.
2697         (WTR::AccessibilityUIElement::startTextMarker): Deleted.
2698         (WTR::AccessibilityUIElement::endTextMarker): Deleted.
2699         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Deleted.
2700         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Deleted.
2701         (WTR::AccessibilityUIElement::indexForTextMarker): Deleted.
2702         (WTR::AccessibilityUIElement::isTextMarkerValid): Deleted.
2703         (WTR::AccessibilityUIElement::textMarkerForIndex): Deleted.
2704         (WTR::AccessibilityUIElement::scrollToMakeVisible): Deleted.
2705         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Deleted.
2706         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): Deleted.
2707         (WTR::AccessibilityUIElement::supportedActions): Deleted.
2708         (WTR::AccessibilityUIElement::mathPostscriptsDescription): Deleted.
2709         (WTR::AccessibilityUIElement::mathPrescriptsDescription): Deleted.
2710         (WTR::AccessibilityUIElement::pathDescription): Deleted.
2711         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2712         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2713         (WTR::EventSendingController::create):
2714         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2715         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2716         (WTR::GCController::create):
2717         * WebKitTestRunner/InjectedBundle/GCController.h:
2718         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2719         (WTR::InjectedBundle::beginTesting):
2720         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2721         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2722         (WTR::TestRunner::create):
2723         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2724         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
2725         (WTR::TextInputController::create):
2726         * WebKitTestRunner/InjectedBundle/TextInputController.h:
2727         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2728         (WTR::AccessibilityController::accessibleElementById):
2729         (WTR::AccessibilityController::rootElement):
2730         (WTR::AccessibilityController::focusedElement):
2731         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2732         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
2733         (WTR::AccessibilityNotificationHandler::create):
2734         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2735         (WTR::AccessibilityUIElement::elementAtPoint):
2736         (WTR::AccessibilityUIElement::childAtIndex):
2737         (WTR::accessibilityElementAtIndex):
2738         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2739         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2740         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2741         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2742         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2743         (WTR::AccessibilityUIElement::rowAtIndex):
2744         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2745         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2746         (WTR::AccessibilityUIElement::titleUIElement):
2747         (WTR::AccessibilityUIElement::parentElement):
2748         (WTR::AccessibilityUIElement::disclosedByRow):
2749         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2750         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2751         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2752         (WTR::AccessibilityUIElement::horizontalScrollbar):
2753         (WTR::AccessibilityUIElement::verticalScrollbar):
2754         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2755         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2756         (WTR::AccessibilityUIElement::previousTextMarker):
2757         (WTR::AccessibilityUIElement::nextTextMarker):
2758         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2759         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2760         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2761         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2762         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2763         (WTR::AccessibilityUIElement::textMarkerForPoint):
2764         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2765         (WTR::AccessibilityUIElement::textMarkerForIndex):
2766         (WTR::AccessibilityUIElement::startTextMarker):
2767         (WTR::AccessibilityUIElement::endTextMarker):
2768         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2769         (WTR::AccessibilityController::accessibleElementById):
2770         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2771         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2772         (WTR::AccessibilityUIElement::headerElementAtIndex):
2773         (WTR::AccessibilityUIElement::linkedElement):
2774         (WTR::AccessibilityUIElement::elementAtPoint):
2775         (WTR::AccessibilityUIElement::childAtIndex):
2776         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2777         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2778         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2779         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2780         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2781         (WTR::AccessibilityUIElement::rowAtIndex):
2782         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2783         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2784         (WTR::AccessibilityUIElement::titleUIElement):
2785         (WTR::AccessibilityUIElement::parentElement):
2786         (WTR::AccessibilityUIElement::disclosedByRow):
2787         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
2788         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2789         (WTR::AccessibilityUIElement::rangeForLine):
2790         (WTR::AccessibilityUIElement::rangeForPosition):
2791         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2792         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2793         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2794         (WTR::AccessibilityUIElement::horizontalScrollbar):
2795         (WTR::AccessibilityUIElement::verticalScrollbar):
2796         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2797         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2798         (WTR::AccessibilityUIElement::previousTextMarker):
2799         (WTR::AccessibilityUIElement::nextTextMarker):
2800         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2801         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2802         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2803         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2804         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2805         (WTR::AccessibilityUIElement::textMarkerForPoint):
2806         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2807         (WTR::AccessibilityUIElement::textMarkerForIndex):
2808         (WTR::AccessibilityUIElement::startTextMarker):
2809         (WTR::AccessibilityUIElement::endTextMarker):
2810         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2811         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2812         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2813         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2814         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2815         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2816         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2817         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2818         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2819         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2820         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
2821         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
2822         (WTR::AccessibilityUIElement::supportedActions):
2823         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2824         (WTR::AccessibilityController::accessibleElementById):
2825         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
2826         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2827         (makeValueRefForValue):
2828         (-[AccessibilityNotificationHandler _notificationReceived:]):
2829         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2830         (WTR::AccessibilityUIElement::elementAtPoint):
2831         (WTR::AccessibilityUIElement::childAtIndex):
2832         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2833         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2834         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2835         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
2836         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2837         (WTR::AccessibilityUIElement::rowAtIndex):
2838         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2839         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2840         (WTR::AccessibilityUIElement::titleUIElement):
2841         (WTR::AccessibilityUIElement::parentElement):
2842         (WTR::AccessibilityUIElement::disclosedByRow):
2843         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2844         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2845         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2846         (WTR::AccessibilityUIElement::horizontalScrollbar):
2847         (WTR::AccessibilityUIElement::verticalScrollbar):
2848         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2849         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2850         (WTR::AccessibilityUIElement::previousTextMarker):
2851         (WTR::AccessibilityUIElement::nextTextMarker):
2852         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2853         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
2854         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2855         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2856         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2857         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
2858         (WTR::AccessibilityUIElement::textMarkerForPoint):
2859         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2860         (WTR::AccessibilityUIElement::textMarkerForIndex):
2861         (WTR::AccessibilityUIElement::startTextMarker):
2862         (WTR::AccessibilityUIElement::endTextMarker):
2863         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
2864         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
2865         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
2866         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
2867         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
2868         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
2869         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
2870         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
2871         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
2872         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
2873         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2874         (WTR::keyPadName):
2875         (WTR::keyName):
2876
2877 2016-11-02  Alex Christensen  <achristensen@webkit.org>
2878
2879         Remove Battery Status API from the tree
2880         https://bugs.webkit.org/show_bug.cgi?id=164213
2881
2882         Reviewed by Sam Weinig.
2883
2884         * Scripts/webkitperl/FeatureList.pm:
2885         * Scripts/webkitpy/common/config/watchlist:
2886
2887 2016-11-02  Olivier Blin  <olivier.blin@softathome.com>
2888
2889         [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation
2890         https://bugs.webkit.org/show_bug.cgi?id=163125
2891
2892         Reviewed by Michael Catanzaro.
2893
2894         * gtk/install-dependencies: List libgcrypt for WebKitGTK+ build, and gnutls for jhbuild only.
2895         gnutls is useful for glib-networking in jhbuild.
2896
2897 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2898
2899         NetworkSession: Network process crash when converting main resource to download
2900         https://bugs.webkit.org/show_bug.cgi?id=164220
2901
2902         Reviewed by Alex Christensen.
2903
2904         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
2905         converted to a download and another one to test the cancellation as the test was doing before. When doing the
2906         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
2907         download.
2908
2909         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2910         (testPolicyResponseDownload):
2911         (testPolicyResponseDownloadCancel):
2912         (beforeAll):
2913
2914 2016-11-01  Alex Christensen  <achristensen@webkit.org>
2915
2916         Remove PassRefPtr from DumpRenderTree
2917         https://bugs.webkit.org/show_bug.cgi?id=164307
2918
2919         Reviewed by Sam Weinig.
2920
2921         * DumpRenderTree/PixelDumpSupport.h:
2922         * DumpRenderTree/TestRunner.cpp:
2923         (TestRunner::create):
2924         * DumpRenderTree/TestRunner.h:
2925         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2926         (createBitmapContext):
2927         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2928         (BitmapContext::createByAdoptingBitmapAndContext):
2929         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2930         (createBitmapContextFromWebView):
2931         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2932         (createBitmapContextFromWebView):
2933         (createPagedBitmapContext):
2934         * DumpRenderTree/mac/TestRunnerMac.mm:
2935         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2936         (createBitmapContextFromWebView):
2937         * DumpRenderTree/win/TextInputController.h:
2938
2939 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2940
2941         [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp
2942         https://bugs.webkit.org/show_bug.cgi?id=161481
2943
2944         Reviewed by Michael Catanzaro.
2945
2946         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
2947         (WebKitTestBus::WebKitTestBus):
2948         (WebKitTestBus::~WebKitTestBus):
2949         (WebKitTestBus::run):
2950         (WebKitTestBus::getOrCreateConnection):
2951         (WebKitTestBus::createProxy):
2952         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
2953
2954 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2955
2956         Unreviewed. Fix /webkit2/WebKitWebContext/get-plugins in the bots after r208273.
2957
2958         The test fails now if WEBKIT_TEST_PLUGIN_DIR contains symlinks, which is the case of the GTK+ bots.
2959
2960         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2961         (testWebContextGetPlugins): Use realpath with WEBKIT_TEST_PLUGIN_DIR when building the expected plugins path.
2962
2963 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2964
2965         [Readable Streams API] Enable creation of ReadableByteStreamController
2966         https://bugs.webkit.org/show_bug.cgi?id=164014
2967
2968         Reviewed by Youenn Fablet.
2969
2970         Enable the byte stream part of Readable Streams API by default.
2971
2972         * Scripts/webkitperl/FeatureList.pm:
2973         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2974
2975 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
2976
2977         Remove CUSTOM_ELEMENTS build flag
2978         https://bugs.webkit.org/show_bug.cgi?id=164267
2979
2980         Reviewed by Antti Koivisto.
2981
2982         Removed the build flag.
2983
2984         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2985
2986 2016-11-01  Alex Christensen  <achristensen@webkit.org>
2987
2988         Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes
2989         https://bugs.webkit.org/show_bug.cgi?id=164290
2990
2991         Reviewed by Tim Horton.
2992
2993         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2994         (TestWebKitAPI::checkRelativeURL):
2995         (TestWebKitAPI::checkURLDifferences):
2996         (TestWebKitAPI::checkRelativeURLDifferences):
2997         Move helper functions to the top so I can use them from any tests.
2998         (TestWebKitAPI::shouldFail):
2999         (TestWebKitAPI::checkURL):
3000         (TestWebKitAPI::TEST_F):
3001
3002 2016-11-01  Hyowon Kim  <hw1008.kim@samsung.com>
3003
3004         [GTK] Failed to generate GeoClue2Interface files.
3005         https://bugs.webkit.org/show_bug.cgi?id=164270
3006
3007         Reviewed by Michael Catanzaro.
3008
3009         To generate codes for D-Bus interfaces,
3010         geoclue-2.0 package including D-Bus introspection XML files should be installed.
3011
3012         * gtk/install-dependencies: add geoclue-2.0 package.
3013
3014 2016-11-01  Fujii Hironori  <Hironori.Fujii@sony.com>
3015
3016         [CMake] generate-bindings-all.pl uses USES_TERMINAL which leaves a noisy line in interactive Ninja build
3017         https://bugs.webkit.org/show_bug.cgi?id=163868
3018
3019         Reviewed by Michael Catanzaro.
3020
3021         It takes long time for generate-bindings-all.pl to generate all
3022         bindings.  So, it shows the progress while running and
3023         USES_TERMINAL option of add_custom_target have been used to invoke
3024         the command.  However, USES_TERMINAL leaves a noisy line in
3025         Ninja's neat build log of interactive build.
3026
3027         A new CMake option SHOW_BINDINGS_GENERATION_PROGRESS is added to
3028         stop using USES_TERMINAL only in case of interactive Ninja build.
3029
3030         * Scripts/webkitdirs.pm:
3031         (generateBuildSystemFromCMakeProject): Enable
3032         SHOW_BINDINGS_GENERATION_PROGRESS not in case of interactive
3033         Ninja build.
3034
3035 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
3036
3037         Add basic visual/layout viewport support for fixed position layout
3038         https://bugs.webkit.org/show_bug.cgi?id=164261
3039
3040         Reviewed by Dean Jackson.
3041
3042         Don't give tests in the "visual-viewport" directory a flexible viewport.
3043
3044         * DumpRenderTree/mac/DumpRenderTree.mm:
3045         (shouldMakeViewportFlexible):
3046         * WebKitTestRunner/TestOptions.cpp:
3047         (WTR::shouldMakeViewportFlexible):
3048
3049 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
3050
3051         JSC should support SharedArrayBuffer
3052         https://bugs.webkit.org/show_bug.cgi?id=163986
3053
3054         Reviewed by Keith Miller.
3055         
3056         Use the right kind of typed array API.
3057
3058         * DumpRenderTree/TestRunner.cpp:
3059         (setAudioResultCallback):
3060
3061 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
3062
3063         Make UIScriptController::zoomToScale() work on Mac WK1 and WK2
3064         https://bugs.webkit.org/show_bug.cgi?id=164238
3065
3066         Reviewed by Dean Jackson.
3067
3068         Implement UIScriptController::zoomToScale() for WTR and DRT on Mac.
3069
3070         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3071         (WTR::UIScriptController::zoomToScale):
3072         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3073         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3074         (WTR::UIScriptController::zoomToScale):
3075
3076 2016-10-31  Dewei Zhu  <dewei_zhu@apple.com>
3077
3078         Update twisted version in webkitpy.thirdparty.autoinstalled module.
3079         https://bugs.webkit.org/show_bug.cgi?id=154667
3080
3081         Reviewed by Ryosuke Niwa.
3082
3083         Use twisted_15_5_0 for the twisted module used by run-benchmark because there is a bug in twisted 12.1.0 which sometimes stops the test.
3084         Installing twisted was introduced in https://bugs.webkit.org/show_bug.cgi?id=147082 for run-benchmark script.
3085         Since buildbot relies on twisted 12.1.0 and has not been verified the compatibility on twisted 15.5.0, it would be more secure to use an individual version for run-benchmark script.
3086
3087         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3088         * Scripts/webkitpy/thirdparty/__init__.py:
3089         (AutoinstallImportHook.find_module):
3090         (AutoinstallImportHook._install_twisted_15_5_0):
3091         (AutoinstallImportHook._install_twisted): Deleted.
3092
3093 2016-10-31  Ryosuke Niwa  <rniwa@webkit.org>
3094
3095         Enable custom elements by default everywhere
3096         https://bugs.webkit.org/show_bug.cgi?id=164242
3097
3098         Reviewed by Antti Koivisto.
3099
3100         Enable custom elements API on every port by default.
3101
3102         * Scripts/webkitperl/FeatureList.pm:
3103
3104 2016-10-31  Nan Wang  <n_wang@apple.com>
3105
3106         AX: aria-sort is not exposed on iOS
3107         https://bugs.webkit.org/show_bug.cgi?id=164245
3108
3109         Reviewed by Chris Fleizach.
3110
3111         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3112         (AccessibilityUIElement::stringAttributeValue):
3113         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3114         (WTR::AccessibilityUIElement::stringAttributeValue):
3115
3116 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
3117
3118         Implement IntersectionObserver
3119         https://bugs.webkit.org/show_bug.cgi?id=159475
3120
3121         Reviewed by Ryosuke Niwa.
3122         
3123         Add ENABLE_INTERSECTION_OBSERVER, enabled by default.
3124
3125         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3126
3127 2016-10-31  Ryan Haddad  <ryanhaddad@apple.com>
3128
3129         Unreviewed, rolling out r208154.
3130
3131         This change caused an assertion failure during API tests on
3132         macOS.
3133
3134         Reverted changeset:
3135
3136         "NetworkSession: Network process crash when converting main
3137         resource to download"
3138         https://bugs.webkit.org/show_bug.cgi?id=164220
3139         http://trac.webkit.org/changeset/208154
3140
3141 2016-10-31  Said Abou-Hallawa  <sabouhallawa@apple.com>
3142
3143         Unreviewed, change my status to be a WebKit reviewer
3144
3145         * Scripts/webkitpy/common/config/contributors.json:
3146
3147 2016-10-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3148
3149         NetworkSession: Network process crash when converting main resource to download
3150         https://bugs.webkit.org/show_bug.cgi?id=164220
3151
3152         Reviewed by Alex Christensen.
3153
3154         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
3155         converted to a download and another one to test the cancellation as the test was doing before. When doing the
3156         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
3157         download.
3158
3159         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3160         (testPolicyResponseDownload):
3161         (testPolicyResponseDownloadCancel):
3162         (beforeAll):
3163
3164 2016-10-31  Keith Miller  <keith_miller@apple.com>
3165
3166         Unreviewed, fix watchlist regexp for wasm.
3167
3168         * Scripts/webkitpy/common/config/watchlist:
3169
3170 2016-10-31  Keith Miller  <keith_miller@apple.com>
3171
3172         autogenerated files from wasm.json should be in derived sources.
3173         https://bugs.webkit.org/show_bug.cgi?id=164152
3174
3175         Reviewed by Filip Pizlo.
3176
3177         Add message to make sure that people keep the wasm.jsons up to date.
3178
3179         * Scripts/webkitpy/common/config/watchlist:
3180
3181 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
3182
3183         Holding down a key to choose an accented character should fire "insertReplacementText" input events
3184         https://bugs.webkit.org/show_bug.cgi?id=164209
3185         <rdar://problem/29019305>
3186
3187         Reviewed by Darin Adler.
3188
3189         Adds test support for inserting replacement text on Mac. This is equivalent to holding down a vowel key (e.g.
3190         'a') to bring up the menu containing accented version of the character, then selecting an accented character to
3191         insert in place of the typed character. This is exposed via UIScriptController.insertText, which takes a string
3192         and an insertion range.
3193
3194         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3195         (WTR::UIScriptController::insertText):
3196         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3197
3198         Note that there is no callback argument to insertText, since UIScriptController::insertText is synchronous in
3199         the UI process. The tests end when corresponding input events fired as a result of insertText have been received
3200         in the web process. Please see the new layout tests for more detail.
3201
3202         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3203         (WTR::UIScriptController::insertText):
3204         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3205         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3206         (WTR::nsStringFromJSString):
3207         (WTR::UIScriptController::insertText):
3208
3209 2016-10-30  Sam Weinig  <sam@webkit.org>
3210
3211         [WebIDL] Restructure IDLParser structs to better match modern WebIDL concepts
3212         https://bugs.webkit.org/show_bug.cgi?id=164208
3213
3214         Reviewed by Darin Adler.
3215
3216         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3217         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3218         Update for new struct types.
3219
3220 2016-10-29  Darin Adler  <darin@apple.com>
3221
3222         Fix failing ExtendedColor tests.
3223
3224         * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp:
3225         Changed the tests in two ways: First, use EXPECT_EQ instead of EXPECT_TRUE
3226         for the string equality comparisons. This required including WTFStringUtilities.h.
3227         Second, change expected results to match what the code is currently generating,
3228         so alpha channels are "0.25" rather than "0.25 / 1". I'll let Dean fix both these
3229         tests and the code if these results are incorrect.
3230
3231 2016-10-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3232
3233         UIScriptControllerIOS.mm should not be soft-linking UIKit
3234         https://bugs.webkit.org/show_bug.cgi?id=164171
3235
3236         Reviewed by Darin Adler.
3237
3238         Follow-up to r208090. Instead of soft-linking, we can simply grab UIKeyboardPredictionView by name instead.
3239
3240         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3241         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
3242
3243 2016-10-28  Darin Adler  <darin@apple.com>
3244
3245         Move all classes in the HTML directory from ExceptionCode to Exception
3246         https://bugs.webkit.org/show_bug.cgi?id=163876
3247
3248         Reviewed by Sam Weinig.
3249
3250         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:
3251         (TestWebKitAPI::ToString): Updated for changes to the TimeRanges class.
3252         (TestWebKitAPI::TEST): Ditto.
3253
3254 2016-10-28  Devin Rousso  <dcrousso+webkit@gmail.com>
3255
3256         Unreviewed, changed Devin Rousso's email and nick.
3257
3258         * Scripts/webkitpy/common/config/contributors.json:
3259
3260 2016-10-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3261
3262         Unreviewed, fix the iOS build after r208090.
3263
3264         Use soft-linking as needed in UIScriptControllerIOS.mm.
3265
3266         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3267         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
3268
3269 2016-10-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3270
3271         iOS autocorrection does not trigger an input event of inputType "insertReplacementText"
3272         https://bugs.webkit.org/show_bug.cgi?id=164077
3273         <rdar://problem/28987810>
3274
3275         Reviewed by Simon Fraser.
3276
3277         Adds test support for inserting text candidates on iOS in the form of
3278         UIScriptController.selectTextCandidateAtIndex(index, callback), which selects the text candidate at a given
3279         index (this needs to be a value between 0-2 on iOS) and fires the callback when done.
3280
3281         To implement this, we wait for the text prediction view to have predictions (we determine this by polling at a
3282         given interval) and then tap the center of the text prediction view at the given index.
3283
3284         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3285         (WTR::UIScriptController::selectTextCandidateAtIndex):
3286         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3287         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3288         (WTR::UIScriptController::selectTextCandidateAtIndex):
3289         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
3290         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3291         * WebKitTestRunner/ios/UIKitSPI.h:
3292         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3293         (WTR::UIScriptController::selectTextCandidateAtIndex):
3294         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
3295
3296 2016-10-28  Commit Queue  <commit-queue@webkit.org>
3297
3298         Unreviewed, rolling out r207700.
3299         https://bugs.webkit.org/show_bug.cgi?id=164168
3300
3301         We are ready after r208086 (Requested by alexchristensen on
3302         #webkit).
3303
3304         Reverted changeset:
3305
3306         "Unreviewed, rolling out r207582."
3307         https://bugs.webkit.org/show_bug.cgi?id=163819
3308         http://trac.webkit.org/changeset/207700
3309
3310 2016-10-28  Alex Christensen  <achristensen@webkit.org>
3311
3312         Partially revert 207805 after resolution in URL spec issue 87
3313         https://bugs.webkit.org/show_bug.cgi?id=164142
3314
3315         Reviewed by Andy Estes.
3316
3317         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3318         (TestWebKitAPI::TEST_F):
3319
3320 2016-10-28  Alex Christensen  <achristensen@webkit.org>
3321
3322         URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
3323         https://bugs.webkit.org/show_bug.cgi?id=164154
3324
3325         Reviewed by Andy Estes.
3326
3327         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3328         (TestWebKitAPI::TEST_F):
3329
3330 2016-10-28  Sam Weinig  <sam@webkit.org>
3331
3332         [WebIDL] Update parser and code generators to only access type information through the type property
3333         https://bugs.webkit.org/show_bug.cgi?id=164141
3334
3335         Reviewed by Anders Carlsson.
3336
3337         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3338         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3339         Update to always access type information through type accessors. Remove use of removed
3340         properties.
3341
3342 2016-10-28  Frederic Wang  <fwang@igalia.com>
3343
3344         [GTK] Upgrade HarfBuzz to version 1.3.3
3345         https://bugs.webkit.org/show_bug.cgi?id=162719
3346
3347         Reviewed by Michael Catanzaro.
3348
3349         * gtk/jhbuild.modules:
3350
3351 2016-10-27  Chris Dumez  <cdumez@apple.com>
3352
3353         Regression(r203601): Caused crashes in iBooks
3354         https://bugs.webkit.org/show_bug.cgi?id=164093
3355         <rdar://problem/28745634>
3356
3357         Reviewed by Darin Adler.
3358
3359         Add API test coverage.
3360
3361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3362         * TestWebKitAPI/Tests/mac/DOMNode.mm: Added.
3363         (-[DOMNodeTest webView:didFinishLoadForFrame:]):
3364         (TestWebKitAPI::TEST):
3365
3366 2016-10-27  Sam Weinig  <sam@webkit.org>
3367
3368         [WebIDL] Move code generators off of domSignature::type and onto domSignature::idlType
3369         https://bugs.webkit.org/show_bug.cgi?id=164089
3370
3371         Reviewed by Alex Christensen.
3372
3373         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3374         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3375         Update for the removal of domSignature::type, and new signatures of helper predicates.
3376
3377 2016-10-27  Commit Queue  <commit-queue@webkit.org>
3378
3379         Unreviewed, rolling out r207992.
3380         https://bugs.webkit.org/show_bug.cgi?id=164070
3381
3382         triggered aclocal version conflict (Requested by mcatanzaro on
3383         #webkit).
3384
3385         Reverted changeset:
3386
3387         "[GTK] Bump glib to 2.50.1 (or find alternative solution to
3388         Gtk+ CUPS build issue)"
3389         https://bugs.webkit.org/show_bug.cgi?id=163689
3390         http://trac.webkit.org/changeset/207992
3391
3392 2016-10-27  Joanmarie Diggs  <jdiggs@igalia.com>
3393
3394         [GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue)
3395         https://bugs.webkit.org/show_bug.cgi?id=163689
3396
3397         Reviewed by Michael Catanzaro.
3398
3399         In order to fix bug #163591, we need to apply an upstream patch to GTK+.
3400         But GTK+ won't build with that patch due to the following error:
3401
3402             m4_copy: won't overwrite defined macro: glib_DEFUN
3403
3404         There is an upstream GLib patch which solves that issue. We should apply
3405         that patch as well, until we bump GLib to 2.50.1 or later.
3406
3407         * gtk/jhbuild.modules: Apply upstream GLib patch.
3408         * gtk/patches/glib-deprecate-am-glib-gnu-gettext.patch: Added.
3409
3410 2016-10-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3411
3412         Unreviewed fix of GTK and EFL test bots.
3413
3414         * Scripts/webkitperl/FeatureList.pm: Deactivated media-source and
3415         legacy-encrypted-media by default for GTK and EFL.
3416
3417 2016-10-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3418
3419         [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly
3420         https://bugs.webkit.org/show_bug.cgi?id=163846
3421
3422         Reviewed by Michael Catanzaro.
3423
3424         WebAssembly is now developed for Darwin right now.
3425         Disable WASM tests in the other platforms.
3426
3427         * Scripts/run-jsc-stress-tests:
3428
3429 2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
3430
3431         [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring
3432         https://bugs.webkit.org/show_bug.cgi?id=162928
3433
3434         Reviewed by Xabier Rodriguez-Calvar.
3435
3436         Explicitly enable MSE and EME on WebKitGTK+ buildbots.
3437
3438         This patch is co-authored with Philippe Normand <philn@igalia.com> (EME support).
3439
3440         * Scripts/webkitperl/FeatureList.pm:
3441
3442 2016-10-25  Antoine Quint  <graouts@apple.com>
3443
3444         [Modern Media Controls] Media Controller: skip back support
3445         https://bugs.webkit.org/show_bug.cgi?id=163725
3446         <rdar://problem/27989480>
3447
3448         Reviewed by Dean Jackson.
3449
3450         * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
3451         access the modern-media-controls source files through the web server.
3452
3453 2016-10-19  Jer Noble  <jer.noble@apple.com>
3454
3455         Add WKWebView fullscreen delegate SPI
3456         https://bugs.webkit.org/show_bug.cgi?id=163674
3457
3458         Reviewed by Anders Carlsson.
3459
3460         Add a new API test which verifies that the fullscreen delegate receives notifications.
3461
3462         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
3463         (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]):
3464         (-[FullscreenDelegateMessageHandler _webViewWillEnterFullscreen:]):
3465         (-[FullscreenDelegateMessageHandler _webViewDidEnterFullscreen:]):
3466         (-[FullscreenDelegateMessageHandler _webViewWillExitFullscreen:]):
3467         (-[FullscreenDelegateMessageHandler _webViewDidExitFullscreen:]):
3468         (TestWebKitAPI::TEST):
3469
3470 2016-10-24  Alex Christensen  <achristensen@webkit.org>
3471
3472         URLParser should match old URL::parse with %2E in path
3473         https://bugs.webkit.org/show_bug.cgi?id=163929
3474
3475         Reviewed by Alexey Proskuryakov.
3476
3477         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3478         (TestWebKitAPI::TEST_F):
3479
3480 2016-10-24  Ryan Haddad  <ryanhaddad@apple.com>
3481
3482         Unreviewed, rolling out r207795.
3483
3484         Introduced API test failures on iOS and macOS.
3485
3486         Reverted changeset:
3487
3488         "URLParser should match old URL::parse with %2E in path"
3489         https://bugs.webkit.org/show_bug.cgi?id=163929
3490         http://trac.webkit.org/changeset/207795
3491
3492 2016-10-24  Alex Christensen  <achristensen@webkit.org>
3493
3494         URLParser should match old URL::parse with %2E in path
3495         https://bugs.webkit.org/show_bug.cgi?id=163929
3496
3497         Reviewed by Alexey Proskuryakov.
3498
3499         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3500         (TestWebKitAPI::TEST_F):
3501
3502 2016-10-21  Alex Christensen  <achristensen@webkit.org>
3503
3504         URL::port should return Optional<uint16_t>
3505         https://bugs.webkit.org/show_bug.cgi?id=163806
3506
3507         Reviewed by Darin Adler.
3508
3509         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3510         (TestWebKitAPI::TEST_F):
3511         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3512         (TestWebKitAPI::checkURL):
3513         (TestWebKitAPI::checkRelativeURL):
3514         (TestWebKitAPI::checkURLDifferences):
3515         (TestWebKitAPI::checkRelativeURLDifferences):
3516         (TestWebKitAPI::TEST_F):
3517
3518 2016-10-24  Youenn Fablet  <youenn@apple.com>
3519
3520         Activate WEB_RTC compilation flags for Mac bots
3521         https://bugs.webkit.org/show_bug.cgi?id=163886
3522
3523         Reviewed by Eric Carlson.
3524
3525         * Scripts/webkitperl/FeatureList.pm:
3526         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3527
3528 2016-10-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3529
3530         Unreviewed, add myself as a WebKit reviewer
3531
3532         * Scripts/webkitpy/common/config/contributors.json:
3533
3534 2016-10-22  Dan Bernstein  <mitz@apple.com>
3535
3536         Improve MiniBrowser window titles for URLs without paths and with no title
3537         <https://webkit.org/b/163843>
3538
3539         Reviewed by Darin Adler.
3540
3541         * MiniBrowser/mac/WK1BrowserWindowController.m:
3542         (-[WK1BrowserWindowController fetch:]): While we’re here, deploy
3543           +[NSURL _webkit_URLWithUserTypedString:] here to match the WK2BrowserWindowController
3544           version of this method.
3545         (-[WK1BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
3546           use the entire URL.
3547         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): Also while we’re here,
3548           deploy +[NSURL _web_userVisibleString] here to match the WK2BrowserWindowController
3549           behavior.
3550
3551         * MiniBrowser/mac/WK2BrowserWindowController.m:
3552         (-[WK2BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
3553           use the entire URL.
3554
3555 2016-10-21  David Kilzer  <ddkilzer@apple.com>
3556
3557         Bug 163762: IntSize::area() should used checked arithmetic
3558         <https://webkit.org/b/163762>
3559
3560         Reviewed by Darin Adler.
3561
3562         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
3563         (TestWebKitAPI::TEST): Call unsafeGet().
3564         * TestWebKitAPI/Tests/WebCore/IntSize.cpp:
3565         (TestWebKitAPI::TEST): Ditto.
3566
3567 2016-10-21  James Craig  <jcraig@apple.com>
3568
3569         Unreviewed: Added Aaron Chu <aaron_chu@apple.com> to contributors list.
3570
3571         * Scripts/webkitpy/common/config/contributors.json:
3572
3573 2016-10-21  Commit Queue  <commit-queue@webkit.org>
3574
3575         Unreviewed, rolling out r207582.
3576         https://bugs.webkit.org/show_bug.cgi?id=163819
3577
3578         Not quite ready rdar://problem/28897179 (Requested by
3579         alexchristensen on #webkit).
3580
3581         Reverted changeset:
3582
3583         "Re-enable URLParser for non-Safari Cocoa apps after r207321"
3584         https://bugs.webkit.org/show_bug.cgi?id=163690
3585         http://trac.webkit.org/changeset/207582
3586
3587 2016-10-21  Jonathan Bedard  <jbedard@apple.com>
3588
3589         WebKitTestRunnerApp packages .idl file
3590         https://bugs.webkit.org/show_bug.cgi?id=163788
3591
3592         Reviewed by Darin Adler.
3593
3594         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Removed .idl file from app package, removed bad reference to app icon.
3595
3596 2016-10-21  Csaba Osztrogonác  <ossy@webkit.org>
3597
3598         [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
3599         https://bugs.webkit.org/show_bug.cgi?id=163733
3600