[GTK] Implement custom URI schemes with CustomProtocols
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Implement custom URI schemes with CustomProtocols
4         https://bugs.webkit.org/show_bug.cgi?id=127091
5
6         Reviewed by Gustavo Noronha Silva.
7
8         Temporarily disable the WebKitWebView check until we figure out
9         how to implement it with CustomProtocols.
10
11         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
12
13 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
14
15         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
16
17         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
18         Fixed an incorrect ifdef.
19
20 2014-01-26  Brendan Long  <b.long@cablelabs.com>
21
22         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
23         https://bugs.webkit.org/show_bug.cgi?id=110602
24
25         Reviewed by Philippe Normand.
26
27         * DumpRenderTree/gtk/DumpRenderTree.cpp:
28         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
29         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
30
31 2014-01-24  Andy Estes  <aestes@apple.com>
32
33         [iOS] Upstream changes in Tools/DumpRenderTree
34         https://bugs.webkit.org/show_bug.cgi?id=127412
35
36         Reviewed by Simon Fraser.
37
38         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
39         which builds the DumpRenderTree static library into an app bundle as
40         expected by the iOS Simulator.
41
42         * DumpRenderTree/AccessibilityTextMarker.h:
43         * DumpRenderTree/AccessibilityUIElement.h:
44         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
45         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
46         * DumpRenderTree/DumpRenderTreePrefix.h:
47         * DumpRenderTree/PixelDumpSupport.cpp:
48         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
49         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
50         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
51         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
52         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
53         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
54         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
55         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
56         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
57         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
58         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
59         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
60         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
61         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
62         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
63         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
64         * DumpRenderTree/TestRunner.cpp:
65         * DumpRenderTree/TestRunner.h:
66         * DumpRenderTree/cg/ImageDiffCG.cpp:
67         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
68         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
69         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
70         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
71         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
72         * DumpRenderTree/ios/Info.plist: Added.
73         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
74         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
75         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
76         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
77         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
78         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
79         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
80         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
81         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
82         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
83         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
84         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
85         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
86         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
87         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
88         * DumpRenderTree/mac/AppleScriptController.m:
89         * DumpRenderTree/mac/Configurations/Base.xcconfig:
90         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
91         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
92         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
93         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
94         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
95         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
96         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
97         * DumpRenderTree/mac/DumpRenderTree.mm:
98         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
99         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
100         * DumpRenderTree/mac/DumpRenderTreeMac.h:
101         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
102         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
103         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
104         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
105         * DumpRenderTree/mac/EditingDelegate.h:
106         * DumpRenderTree/mac/EventSendingController.h:
107         * DumpRenderTree/mac/EventSendingController.mm:
108         * DumpRenderTree/mac/FrameLoadDelegate.mm:
109         * DumpRenderTree/mac/HistoryDelegate.h:
110         * DumpRenderTree/mac/LayoutTestHelper.m:
111         * DumpRenderTree/mac/MockGeolocationProvider.mm:
112         * DumpRenderTree/mac/NavigationController.h:
113         * DumpRenderTree/mac/ObjCPlugin.h:
114         * DumpRenderTree/mac/ObjCPlugin.m:
115         * DumpRenderTree/mac/ObjCPluginFunction.h:
116         * DumpRenderTree/mac/PolicyDelegate.h:
117         * DumpRenderTree/mac/ResourceLoadDelegate.h:
118         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
119         * DumpRenderTree/mac/TestRunnerMac.mm:
120         * DumpRenderTree/mac/TextInputController.h:
121         * DumpRenderTree/mac/TextInputController.m:
122         * DumpRenderTree/mac/UIDelegate.h:
123         * DumpRenderTree/mac/UIDelegate.mm:
124
125 2014-01-25  Darin Adler  <darin@apple.com>
126
127         Call deprecatedCharacters instead of characters at more call sites
128         https://bugs.webkit.org/show_bug.cgi?id=127631
129
130         Reviewed by Sam Weinig.
131
132         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
133         (TestWebKitAPI::expectBuilderContent):
134         (TestWebKitAPI::expectEmpty):
135         (TestWebKitAPI::TEST):
136         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
137         (TestWebKitAPI::TEST):
138         Use the new name.
139
140 2014-01-25  Anders Carlsson  <andersca@apple.com>
141
142         Modernize HashTable threading code
143         https://bugs.webkit.org/show_bug.cgi?id=127621
144
145         Reviewed by Darin Adler.
146
147         Explicitly include headers that used to be brought in by HashTable.h
148
149         * DumpRenderTree/JavaScriptThreading.cpp:
150
151 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
152
153         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
154
155         * Scripts/webkitpy/common/config/contributors.json:
156         * Scripts/webkitpy/common/config/watchlist:
157
158 2014-01-23  David Farler  <dfarler@apple.com>
159
160         Make WebKitTestRunner work with iOS
161         https://bugs.webkit.org/show_bug.cgi?id=127448
162
163         Reviewed by Simon Fraser.
164
165         Combined patch from Simon below with some additional xcconfig cleanups,
166         rebasing and stubbing out a couple of new functions that popped up
167         since then.
168
169         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
170
171                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
172
173                 Get WebKitTestRunner limping on iOS. Main parts:
174                 - Stub out lots of accessibility-related functions.
175                 - Stub out EventSender
176                 - Create target to make a bundled app that runs in the simulator,
177                   and copy the injected bundle library into it.
178                 - Make a UIWindow and WKView to load tests in
179
180                 It runs, load tests, and dumps results to output. More work will be
181                 required once we can execute it via the webkitpy scripts.
182
183         * WebKitTestRunner/Configurations/Base.xcconfig:
184         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
185         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
186         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
187         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
188         (WTR::AccessibilityController::addNotificationListener):
189         (WTR::AccessibilityController::removeNotificationListener):
190         (WTR::AccessibilityController::platformName):
191         (WTR::AccessibilityController::logAccessibilityEvents):
192         (WTR::AccessibilityController::resetToConsistentState):
193         (WTR::findAccessibleObjectById):
194         (WTR::AccessibilityController::accessibleElementById):
195         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
196         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
197         (WTR::AccessibilityTextMarker::isEqual):
198         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
199         (WTR::AccessibilityUIElement::AccessibilityUIElement):
200         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
201         (WTR::AccessibilityUIElement::isEqual):
202         (WTR::AccessibilityUIElement::getLinkedUIElements):
203         (WTR::AccessibilityUIElement::getDocumentLinks):
204         (WTR::AccessibilityUIElement::getChildren):
205         (WTR::AccessibilityUIElement::getChildrenWithRange):
206         (WTR::AccessibilityUIElement::childrenCount):
207         (WTR::AccessibilityUIElement::elementAtPoint):
208         (WTR::AccessibilityUIElement::indexOfChild):
209         (WTR::AccessibilityUIElement::childAtIndex):
210         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
211         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
212         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
213         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
214         (WTR::AccessibilityUIElement::rowAtIndex):
215         (WTR::AccessibilityUIElement::selectedChildAtIndex):
216         (WTR::AccessibilityUIElement::selectedChildrenCount):
217         (WTR::AccessibilityUIElement::selectedRowAtIndex):
218         (WTR::AccessibilityUIElement::titleUIElement):
219         (WTR::AccessibilityUIElement::parentElement):
220         (WTR::AccessibilityUIElement::disclosedByRow):
221         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
222         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
223         (WTR::AccessibilityUIElement::attributesOfChildren):
224         (WTR::AccessibilityUIElement::allAttributes):
225         (WTR::AccessibilityUIElement::stringAttributeValue):
226         (WTR::AccessibilityUIElement::numberAttributeValue):
227         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
228         (WTR::AccessibilityUIElement::uiElementAttributeValue):
229         (WTR::AccessibilityUIElement::boolAttributeValue):
230         (WTR::AccessibilityUIElement::isAttributeSettable):
231         (WTR::AccessibilityUIElement::isAttributeSupported):
232         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
233         (WTR::AccessibilityUIElement::role):
234         (WTR::AccessibilityUIElement::subrole):
235         (WTR::AccessibilityUIElement::roleDescription):
236         (WTR::AccessibilityUIElement::title):
237         (WTR::AccessibilityUIElement::description):
238         (WTR::AccessibilityUIElement::orientation):
239         (WTR::AccessibilityUIElement::stringValue):
240         (WTR::AccessibilityUIElement::language):
241         (WTR::AccessibilityUIElement::helpText):
242         (WTR::AccessibilityUIElement::x):
243         (WTR::AccessibilityUIElement::y):
244         (WTR::AccessibilityUIElement::width):
245         (WTR::AccessibilityUIElement::height):
246         (WTR::AccessibilityUIElement::clickPointX):
247         (WTR::AccessibilityUIElement::clickPointY):
248         (WTR::AccessibilityUIElement::intValue):
249         (WTR::AccessibilityUIElement::minValue):
250         (WTR::AccessibilityUIElement::maxValue):
251         (WTR::AccessibilityUIElement::valueDescription):
252         (WTR::AccessibilityUIElement::insertionPointLineNumber):
253         (WTR::AccessibilityUIElement::isPressActionSupported):
254         (WTR::AccessibilityUIElement::isIncrementActionSupported):
255         (WTR::AccessibilityUIElement::isDecrementActionSupported):
256         (WTR::AccessibilityUIElement::isEnabled):
257         (WTR::AccessibilityUIElement::isRequired):
258         (WTR::AccessibilityUIElement::isFocused):
259         (WTR::AccessibilityUIElement::isSelected):
260         (WTR::AccessibilityUIElement::isSelectedOptionActive):
261         (WTR::AccessibilityUIElement::isIndeterminate):
262         (WTR::AccessibilityUIElement::isExpanded):
263         (WTR::AccessibilityUIElement::isChecked):
264         (WTR::AccessibilityUIElement::hierarchicalLevel):
265         (WTR::AccessibilityUIElement::classList):
266         (WTR::AccessibilityUIElement::speak):
267         (WTR::AccessibilityUIElement::ariaIsGrabbed):
268         (WTR::AccessibilityUIElement::ariaDropEffects):
269         (WTR::AccessibilityUIElement::lineForIndex):
270         (WTR::AccessibilityUIElement::rangeForLine):
271         (WTR::AccessibilityUIElement::rangeForPosition):
272         (WTR::AccessibilityUIElement::boundsForRange):
273         (WTR::AccessibilityUIElement::stringForRange):
274         (WTR::AccessibilityUIElement::attributedStringForRange):
275         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
276         (WTR::uiElementCountForSearchPredicate):
277         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
278         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
279         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
280         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
281         (WTR::AccessibilityUIElement::attributesOfColumns):
282         (WTR::AccessibilityUIElement::attributesOfRows):
283         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
284         (WTR::AccessibilityUIElement::attributesOfHeader):
285         (WTR::AccessibilityUIElement::rowCount):
286         (WTR::AccessibilityUIElement::columnCount):
287         (WTR::AccessibilityUIElement::indexInTable):
288         (WTR::AccessibilityUIElement::rowIndexRange):
289         (WTR::AccessibilityUIElement::columnIndexRange):
290         (WTR::AccessibilityUIElement::cellForColumnAndRow):
291         (WTR::AccessibilityUIElement::horizontalScrollbar):
292         (WTR::AccessibilityUIElement::verticalScrollbar):
293         (WTR::AccessibilityUIElement::scrollToMakeVisible):
294         (WTR::AccessibilityUIElement::selectedTextRange):
295         (WTR::AccessibilityUIElement::setSelectedTextRange):
296         (WTR::AccessibilityUIElement::increment):
297         (WTR::AccessibilityUIElement::decrement):
298         (WTR::AccessibilityUIElement::showMenu):
299         (WTR::AccessibilityUIElement::press):
300         (WTR::AccessibilityUIElement::setSelectedChild):
301         (WTR::AccessibilityUIElement::accessibilityValue):
302         (WTR::AccessibilityUIElement::documentEncoding):
303         (WTR::AccessibilityUIElement::documentURI):
304         (WTR::AccessibilityUIElement::url):
305         (WTR::AccessibilityUIElement::addNotificationListener):
306         (WTR::AccessibilityUIElement::removeNotificationListener):
307         (WTR::AccessibilityUIElement::isFocusable):
308         (WTR::AccessibilityUIElement::isSelectable):
309         (WTR::AccessibilityUIElement::isMultiSelectable):
310         (WTR::AccessibilityUIElement::isVisible):
311         (WTR::AccessibilityUIElement::isOffScreen):
312         (WTR::AccessibilityUIElement::isCollapsed):
313         (WTR::AccessibilityUIElement::isIgnored):
314         (WTR::AccessibilityUIElement::hasPopup):
315         (WTR::AccessibilityUIElement::takeFocus):
316         (WTR::AccessibilityUIElement::takeSelection):
317         (WTR::AccessibilityUIElement::addSelection):
318         (WTR::AccessibilityUIElement::removeSelection):
319         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
320         (WTR::AccessibilityUIElement::textMarkerRangeLength):
321         (WTR::AccessibilityUIElement::previousTextMarker):
322         (WTR::AccessibilityUIElement::nextTextMarker):
323         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
324         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
325         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
326         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
327         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
328         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
329         (WTR::AccessibilityUIElement::textMarkerForPoint):
330         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
331         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
332         (WTR::AccessibilityUIElement::indexForTextMarker):
333         (WTR::AccessibilityUIElement::isTextMarkerValid):
334         (WTR::AccessibilityUIElement::textMarkerForIndex):
335         (WTR::AccessibilityUIElement::startTextMarker):
336         (WTR::AccessibilityUIElement::endTextMarker):
337         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
338         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
339         (WTR::AccessibilityUIElement::pathDescription):
340         (WTR::AccessibilityUIElement::supportedActions):
341         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
342         (WTR::activateFonts):
343         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
344         (WTR::EventSenderProxy::EventSenderProxy):
345         (WTR::EventSenderProxy::~EventSenderProxy):
346         (WTR::EventSenderProxy::updateClickCountForButton):
347         (WTR::EventSenderProxy::mouseDown):
348         (WTR::EventSenderProxy::mouseUp):
349         (WTR::EventSenderProxy::mouseMoveTo):
350         (WTR::EventSenderProxy::leapForward):
351         (WTR::EventSenderProxy::keyDown):
352         (WTR::EventSenderProxy::mouseScrollBy):
353         (WTR::EventSenderProxy::continuousMouseScrollBy):
354         (WTR::EventSenderProxy::addTouchPoint):
355         (WTR::EventSenderProxy::updateTouchPoint):
356         (WTR::EventSenderProxy::setTouchModifier):
357         (WTR::EventSenderProxy::setTouchPointRadius):
358         (WTR::EventSenderProxy::touchStart):
359         (WTR::EventSenderProxy::touchMove):
360         (WTR::EventSenderProxy::touchEnd):
361         (WTR::EventSenderProxy::touchCancel):
362         (WTR::EventSenderProxy::clearTouchPoints):
363         (WTR::EventSenderProxy::releaseTouchPoint):
364         (WTR::EventSenderProxy::cancelTouchPoint):
365         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
366         (WTR::InjectedBundle::platformInitialize):
367         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
368         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
369         * WebKitTestRunner/Makefile:
370         * WebKitTestRunner/TestController.cpp:
371         (WTR::TestController::initialize):
372         * WebKitTestRunner/TestController.h:
373         * WebKitTestRunner/TestInvocation.cpp:
374         (WTR::TestInvocation::invoke):
375         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
376         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
377         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
378         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
379         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
380         (-[AppDelegate applicationWillResignActive:]):
381         (-[AppDelegate applicationDidEnterBackground:]):
382         (-[AppDelegate applicationWillEnterForeground:]):
383         (-[AppDelegate applicationDidBecomeActive:]):
384         (-[AppDelegate applicationWillTerminate:]):
385         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
386         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
387         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
388         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
389         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
390         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
391         (main):
392         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
393         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
394         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
395         (-[WebKitTestRunnerAppTests setUp]):
396         (-[WebKitTestRunnerAppTests tearDown]):
397         (-[WebKitTestRunnerAppTests testExample]):
398         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
399         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
400         * WebKitTestRunner/cg/TestInvocationCG.cpp:
401         * WebKitTestRunner/iOS.xcconfig: Added.
402         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
403         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
404         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
405         (-[WebKitTestRunnerWindow isKeyWindow]):
406         (-[WebKitTestRunnerWindow setFrameOrigin:]):
407         (-[WebKitTestRunnerWindow setFrame:]):
408         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
409         (-[WebKitTestRunnerWindow backingScaleFactor]):
410         (WTR::PlatformWebView::PlatformWebView):
411         (WTR::PlatformWebView::resizeTo):
412         (WTR::PlatformWebView::~PlatformWebView):
413         (WTR::PlatformWebView::page):
414         (WTR::PlatformWebView::focus):
415         (WTR::PlatformWebView::windowFrame):
416         (WTR::PlatformWebView::setWindowFrame):
417         (WTR::PlatformWebView::didInitializeClients):
418         (WTR::PlatformWebView::addChromeInputField):
419         (WTR::PlatformWebView::removeChromeInputField):
420         (WTR::PlatformWebView::makeWebViewFirstResponder):
421         (WTR::PlatformWebView::windowSnapshotImage):
422         (WTR::PlatformWebView::viewSupportsOptions):
423         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
424         (WTR::TestController::notifyDone):
425         (WTR::TestController::platformInitialize):
426         (WTR::TestController::platformDestroy):
427         (WTR::TestController::initializeInjectedBundlePath):
428         (WTR::TestController::initializeTestPluginDirectory):
429         (WTR::TestController::platformRunUntil):
430         (WTR::TestController::platformInitializeContext):
431         (WTR::TestController::runModal):
432         (WTR::TestController::platformLibraryPathForTesting):
433         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
434         (createCFURLResponseFromResponseData):
435         (supportedNonImageMIMETypes):
436         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
437         (-[WebKitTestRunnerApp _runTestController]):
438         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
439         (main):
440
441 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
442
443         [GTK] Put cache files in XDG_CACHE_HOME
444         https://bugs.webkit.org/show_bug.cgi?id=123458
445
446         Reviewed by Martin Robinson.
447
448         * GtkLauncher/main.c:
449         (createBrowser):
450
451 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
452
453         Remove CSS Custom Filters code and tests
454         https://bugs.webkit.org/show_bug.cgi?id=127382
455
456         Reviewed by Simon Fraser.
457
458         * DumpRenderTree/gtk/DumpRenderTree.cpp:
459         (resetDefaultsToConsistentValues):
460         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
461         (TestRunner::overridePreference):
462
463 2014-01-23  Tim Horton  <timothy_horton@apple.com>
464
465         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
466         https://bugs.webkit.org/show_bug.cgi?id=127415
467         <rdar://problem/12482452>
468
469         Reviewed by Sam Weinig.
470
471         Adopt the new page loader client plugin load callback.
472
473         * WebKitTestRunner/TestController.cpp:
474         (WTR::TestController::createWebViewWithOptions):
475         (WTR::TestController::pluginLoadPolicy):
476         * WebKitTestRunner/TestController.h:
477
478 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
479
480         [Curl] There is no way to specify cache folder.
481         https://bugs.webkit.org/show_bug.cgi?id=125028
482
483         Reviewed by Brent Fulgham.
484
485         Enable disc cache in WinLauncher by setting cache folder location.
486
487         * WinLauncher/WinLauncher.cpp:
488         (getAppDataFolder): Added function to get app data folder.
489         (setCacheFolder): Added function to set cache folder.
490         (createCrashReport): Use new getAppDataFolder function.
491         (wWinMain): Use function setCacheFolder to set cache folder location.
492
493 2014-01-23  Daniel Bates  <dabates@apple.com>
494
495         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
496         https://bugs.webkit.org/show_bug.cgi?id=127379
497
498         Reviewed by Simon Fraser.
499
500         Teach build-webkit to recognize --sdk=X.
501
502         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
503         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
504         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
505         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
506
507         * Scripts/webkitdirs.pm:
508         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
509         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
510         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
511
512 2014-01-23  Commit Queue  <commit-queue@webkit.org>
513
514         Unreviewed, rolling out r162612.
515         http://trac.webkit.org/changeset/162612
516         https://bugs.webkit.org/show_bug.cgi?id=127488
517
518         broke the build (Requested by mhahnenberg on #webkit).
519
520         * Scripts/build-jsc:
521         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
522         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
523         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
524         * jsc-cli/jsc-cli/JSModule.h: Removed.
525         * jsc-cli/jsc-cli/JSModule.m: Removed.
526         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
527         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
528         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
529         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
530         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
531         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
532         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
533         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
534         * jsc-cli/jsc-cli/main.m: Removed.
535
536 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
537
538         Basic framework for a modern jsc CLI
539         https://bugs.webkit.org/show_bug.cgi?id=127435
540
541         Reviewed by Geoffrey Garen.
542
543         The most basic components of a modern jsc command line interface consist of the following:
544
545         - A simple REPL to enter commands and receive results
546         - The ability to define a module (which consists of various internal methods as well as a 
547           set of externally visible methods)
548         - The ability to load other modules at runtime
549         - The ability to interact with the underlying platform to perform various "privileged" 
550           functions (e.g. opening files, printing to the stdout, etc.)
551         
552         The basic architecture will look something like the following:
553         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
554           on the main thread and start a secondary thread with a run loop to handle various inputs 
555           from the REPL thread.
556         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
557           it might transitively load) within the run loop on the secondary thread while the main 
558           thread blocks until it has completed.
559
560         * Scripts/build-jsc:
561         * jsc-cli: Added.
562         * jsc-cli/jsc-cli: Added.
563         * jsc-cli/jsc-cli.xcodeproj: Added.
564         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
565         * jsc-cli/jsc-cli/CLIInstance.h: Added.
566         * jsc-cli/jsc-cli/CLIInstance.m: Added.
567         (-[CLIInstance init]):
568         (-[CLIInstance loadFile:]):
569         (-[CLIInstance run]):
570         * jsc-cli/jsc-cli/JSModule.h: Added.
571         * jsc-cli/jsc-cli/JSModule.m: Added.
572         (coreModules):
573         (isCoreModule):
574         (classForModule):
575         (coreModuleFullPath):
576         (resolveModuleAsFile):
577         (resolveModuleAsDirectory):
578         (nodeModulePaths):
579         (resolveAsNodeModule):
580         (+[JSModule resolve:atPath:]):
581         (globalModuleCache):
582         (isCached):
583         (cachedModule):
584         (cacheModule):
585         (+[JSModule require:atPath:]):
586         (+[JSModule require:atPath:inContext:]):
587         (-[JSModule platformObjectInContext:]):
588         (-[JSModule initWithId:filename:context:]):
589         (-[JSModule dealloc]):
590         (-[JSModule didStartLoading]):
591         (-[JSModule didFinishLoading]):
592         (-[JSModule require:]):
593         (-[JSModule exports]):
594         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
595         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
596         (jsThreadMain):
597         (+[JSRunLoopThread threadMain]):
598         (-[JSRunLoopThread initWithFiles:andContext:]):
599         (-[JSRunLoopThread startRunLoop]):
600         (-[JSRunLoopThread start]):
601         (-[JSRunLoopThread join]):
602         (-[JSRunLoopThread didReceiveInput:]):
603         (-[JSRunLoopThread performCallback:withError:]):
604         (-[JSRunLoopThread performCallback:withArguments:]):
605         (-[JSRunLoopThread didFinishRunLoopInitialization]):
606         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
607         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
608         (-[ReadEvalPrintLoop initWithJSThread:]):
609         (prompt):
610         (escapeStringForOutput):
611         (-[ReadEvalPrintLoop processNextInput]):
612         (-[ReadEvalPrintLoop run]):
613         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
614         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
615         (+[RunLoopThread threadMain]):
616         (-[RunLoopThread init]):
617         (-[RunLoopThread dealloc]):
618         (-[RunLoopThread didFinishRunLoopInitialization]):
619         (-[RunLoopThread start]):
620         (-[RunLoopThread join]):
621         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
622         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
623         (scriptInputSourceScheduleRoutine):
624         (scriptInputSourcePerformRoutine):
625         (scriptInputSourceCancelRoutine):
626         (-[ScriptInputSource initWithContext:]):
627         (-[ScriptInputSource dealloc]):
628         (-[ScriptInputSource addToCurrentRunLoop]):
629         (-[ScriptInputSource removeFromRemoteRunLoop]):
630         (-[ScriptInputSource didReceiveScript:]):
631         (-[ScriptInputSource didReceiveSignal]):
632         (-[ScriptInputSource runScriptRemotely:]):
633         (-[ScriptInputSource finishAsyncCallback:withResult:]):
634         * jsc-cli/jsc-cli/main.m: Added.
635         (main):
636
637 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
638
639         Remove a FIXME comment that is already fixed.
640         https://bugs.webkit.org/show_bug.cgi?id=127468
641
642         Reviewed by Csaba Osztrogonác.
643
644         * Scripts/webkitpy/style/filereader.py:
645         (TextFileReader.__init__):
646
647 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
648
649         [GLIB] Use GUniquePtr instead of GOwnPtr
650         https://bugs.webkit.org/show_bug.cgi?id=127431
651
652         Reviewed by Martin Robinson.
653
654         GUniquePtr is a template alias of std::unique_ptr with a custom
655         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
656         where the output pointer is needed, but it will also be replaced soon.
657
658         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
659         (printAccessibilityEvent):
660         (axObjectEventListener):
661         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
662         (indexRangeInTable):
663         (AccessibilityUIElement::role):
664         (AccessibilityUIElement::title):
665         (AccessibilityUIElement::description):
666         (AccessibilityUIElement::stringValue):
667         (AccessibilityUIElement::language):
668         (AccessibilityUIElement::lineForIndex):
669         (AccessibilityUIElement::selectedTextRange):
670         (AccessibilityUIElement::url):
671         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
672         (AccessibilityController::accessibleElementById):
673         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
674         (AccessibilityController::accessibleElementById):
675         * DumpRenderTree/gtk/DumpRenderTree.cpp:
676         (getOutputDir):
677         (getFontsPath):
678         (initializeFonts):
679         (dumpFramesAsText):
680         (compareHistoryItems):
681         (dumpHistoryItem):
682         (soupURIToStringPreservingPassword):
683         (resetDefaultsToConsistentValues):
684         (temporaryDatabaseDirectory):
685         (webViewTitleChanged):
686         (webFrameLoadStatusNotified):
687         (pathFromSoupURI):
688         (convertWebResourceToURLPath):
689         (urlSuitableForTestResult):
690         (descriptionSuitableForTestResult):
691         (willSendRequestCallback):
692         (frameLoadEventCallback):
693         * DumpRenderTree/gtk/EditingCallbacks.cpp:
694         (dumpNodePath):
695         (dumpRange):
696         (shouldApplyStyle):
697         * DumpRenderTree/gtk/EventSender.cpp:
698         (contextClickCallback):
699         (beginDragWithFilesCallback):
700         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
701         (TestRunner::pathToLocalResource):
702         (TestRunner::queueLoad):
703         (TestRunner::removeOriginAccessWhitelistEntry):
704         (TestRunner::setMockGeolocationPositionUnavailableError):
705         (TestRunner::setIconDatabaseEnabled):
706         (TestRunner::findString):
707         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
708         (TestRunner::overridePreference):
709         (TestRunner::addUserScript):
710         (TestRunner::addUserStyleSheet):
711         (TestRunner::setTextDirection):
712         * DumpRenderTree/gtk/TextInputController.cpp:
713         (setMarkedTextCallback):
714         (insertTextCallback):
715         (doCommandCallback):
716         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
717         (LoadHTMLStringItem::invoke):
718         * TestWebKitAPI/PlatformGTK.cmake:
719         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
720         (WebKitDOMNodeTest::testTagNames):
721         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
722         (testBackForwardListLimitAndCache):
723         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
724         (testContextMenuSmartSeparators):
725         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
726         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
727         (testDownloadLocalFile):
728         (testDownloadLocalFileError):
729         (addContentDispositionHTTPHeaderToResponse):
730         (serverCallback):
731         (testDownloadRemoteFileError):
732         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
733         (startTestServer):
734         (testInspectorServerPageList):
735         (openRemoteDebuggingSession):
736         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
737         (testPrintOperationPrint):
738         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
739         (addCacheHTTPHeadersToResponse):
740         (serverCallback):
741         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
742         (httpsServerCallback):
743         (httpServerCallback):
744         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
745         (testWebViewJavaScriptDialogs):
746         (testWebViewWindowProperties):
747         (testWebViewFileChooserRequest):
748         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
749         (testWebExtensionWindowObjectCleared):
750         (testWebExtensionIsolatedWorld):
751         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
752         (startTestServer):
753         (checkAtspiAccessible):
754         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
755         (serverCallback):
756         (testClearDatabase):
757         (testGetFaviconURI):
758         (webkitFaviconDatabaseFinalizedCallback):
759         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
760         (testWebContextGetPlugins):
761         (testWebContextURIScheme):
762         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
763         (testWebViewRunJavaScript):
764         (testWebViewMode):
765         (testWebViewPageVisibility):
766         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
767         (isStyleSheetInjectedForURLAtPath):
768         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
769         (testWebViewEditorCutCopyPasteNonEditable):
770         (testWebViewEditorCutCopyPasteEditable):
771         (testWebViewEditorSelectAllNonEditable):
772         (testWebViewEditorSelectAllEditable):
773         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
774         (sendRequestCallback):
775         (methodCallCallback):
776         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
777         (TestWebKitAPI::Util::createInjectedBundlePath):
778         (TestWebKitAPI::Util::createURLForResource):
779         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
780         (TestWebKitAPI::doKeyStroke):
781         (TestWebKitAPI::doMouseButtonEvent):
782         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
783         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
784         (loadFailedCallback):
785         (LoadTrackingTest::loadURI):
786         (LoadTrackingTest::loadHtml):
787         (LoadTrackingTest::loadPlainText):
788         (LoadTrackingTest::loadRequest):
789         (LoadTrackingTest::reload):
790         (LoadTrackingTest::goBack):
791         (LoadTrackingTest::goForward):
792         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
793         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
794         (registerGResource):
795         (removeNonEmptyDirectory):
796         (main):
797         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
798         (Test::getWebKit1TestResoucesDir):
799         (Test::getResourcesDir):
800         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
801         (WebKitTestBus::run):
802         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
803         (WebKitTestServer::WebKitTestServer):
804         (WebKitTestServer::getURIForPath):
805         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
806         (WebProcessTestRunner::runTest):
807         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
808         (resourceGetDataCallback):
809         (WebViewTest::mainResourceData):
810         (WebViewTest::mouseMoveTo):
811         (WebViewTest::keyStroke):
812         (WebViewTest::doMouseButtonEvent):
813         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
814         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
815         (WTR::AccessibilityController::accessibleElementById):
816         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
817         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
818         (WTR::AccessibilityUIElement::role):
819         (WTR::AccessibilityUIElement::title):
820         (WTR::AccessibilityUIElement::description):
821         (WTR::AccessibilityUIElement::stringValue):
822         (WTR::AccessibilityUIElement::language):
823         (WTR::AccessibilityUIElement::lineForIndex):
824         (WTR::AccessibilityUIElement::selectedTextRange):
825         (WTR::AccessibilityUIElement::url):
826         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
827         (WTR::getOutputDir):
828         (WTR::getFontsPath):
829         (WTR::initializeFontConfigSetting):
830         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
831         (WTR::topLevelPath):
832         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
833         (WTR::TestRunner::pathToLocalResource):
834         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
835         (WTR::TestController::initializeInjectedBundlePath):
836         (WTR::TestController::initializeTestPluginDirectory):
837
838 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
839
840         [GTK] [CMake] run-webkit-tests should support the CMake build
841         https://bugs.webkit.org/show_bug.cgi?id=126503
842
843         Reviewed by Daniel Bates.
844
845         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
846         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
847
848         * Scripts/run-launcher: Work properly with the gtkcmake flag.
849         * Scripts/webkitpy/port/gtk.py:
850         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
851         file to detect a CMake build.
852         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
853         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
854         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
855         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
856         (GtkPort._path_to_driver): Use the new helper.
857         (GtkPort._path_to_image_diff): Use the new helper.
858         (GtkPort._path_to_webcore_library): Use the new helper.
859         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
860
861 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
862
863         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
864         https://bugs.webkit.org/show_bug.cgi?id=127417
865
866         Reviewed by Gyuyoung Kim.
867
868         * EWebLauncher/main.c:
869         (on_key_down): Removed shortcut to test pre render.
870
871 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
872
873         Remove CSS3_TEXT_DECORATION define
874         https://bugs.webkit.org/show_bug.cgi?id=127333
875
876         This is required for unprefixing the text-decoration-* CSS properties.
877
878         Reviewed by Simon Fraser.
879
880         * Configurations/FeatureDefines.xcconfig:
881
882 2014-01-22  Andy Estes  <aestes@apple.com>
883
884         [iOS] Prepare for upstreaming DumpRenderTree changes
885         https://bugs.webkit.org/show_bug.cgi?id=127412
886
887         Reviewed by Simon Fraser.
888
889         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
890         an application bundle. Instead of upstreaming a separate target for the
891         app that duplicates the 'Compile Sources' phase of the tool, separate
892         out the compilation into a static library target that both the
893         command-line tool and the app can link against. Also, perform some
894         unrelated cleanup.
895
896         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
897         project file format from 2.4- to 3.2-compatible. Removed the
898         'Copy Headers' build phase and removed all files from the
899         'Compile Sources' build phase of DumpRenderTree. Added some files that
900         were missing from the project. Created a 'DumpRenderTree (Library)'
901         target for building the static library and made the 'DumpRenderTree'
902         target depend on it. Added a 'Compile Sources' build phase to this
903         target that builds the same files the DumpRenderTree target used to.
904         Created DumpRenderTreeMain.mm as the only source file of the
905         DumpRenderTree target, since targets won't link a binary without at
906         least one source file. Made DumpRenderTree (Library) use
907         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
908         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
909         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
910         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
911         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
912         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
913         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
914         This is needed to correctly link a static library containing an Objective-C
915         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
916         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
917         * DumpRenderTree/mac/DumpRenderTree.mm:
918         (DumpRenderTreeMain): Renamed from main.
919         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
920         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
921         (main): Called DumpRenderTreeMain from main.
922
923 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
924
925         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
926         https://bugs.webkit.org/show_bug.cgi?id=127073
927
928         Reviewed by Daniel Bates.
929
930         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
931         the new isCMakeBuild conditional. This allows us to share more code between ports.
932         Pass the build arguments to the removeCMakeCache function.
933         * Scripts/webkitdirs.pm:
934         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
935         because it's now shared with the CMake build.
936         (cachedArgumentFileOutOfDate): Renamed.
937         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
938         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
939         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
940         as well as checking if build-webkit has been run with different arguments.
941         (removeCMakeCache): Call shouldRemoveCMakeCache now.
942         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
943         (isCMakeBuild): Added.
944
945 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
946
947         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
948         https://bugs.webkit.org/show_bug.cgi?id=127119
949
950         Reviewed by Mario Sanchez Prada.
951
952         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
953
954         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
955         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
956         * DumpRenderTree/gtk/DumpRenderTree.cpp:
957         (resetDefaultsToConsistentValues):
958         (webViewWindowObjectCleared):
959         (main):
960         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
961         (WTR::AccessibilityController::platformName):
962         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
963         (WTR::AccessibilityUIElement::isIndeterminate):
964
965 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
966
967
968         [GTK] Add GUniquePtr
969         https://bugs.webkit.org/show_bug.cgi?id=127170
970
971         Reviewed by Gustavo Noronha Silva.
972
973         Add unit tests for GUniquePtr.
974
975         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
976         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
977         (log):
978         (takeLogStr):
979         (TestWebKitAPI::TEST):
980
981 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
982
983         Remove Nix files from Tools
984         https://bugs.webkit.org/show_bug.cgi?id=127418
985
986         Reviewed by Csaba Osztrogonác.
987
988         * Scripts/build-webkit:
989         * Scripts/update-webkit-libs-jhbuild:
990         * Scripts/webkitdirs.pm:
991         (determineArchitecture):
992         (argumentsForConfiguration):
993         (jscProductDir):
994         (builtDylibPathForName):
995         (isAppleWebKit):
996         (launcherPath):
997         (launcherName):
998         (checkRequiredSystemConfig):
999         (copyInspectorFrontendFiles):
1000         (jhbuildWrapperPrefixIfNeeded):
1001         (buildCMakeProjectOrExit):
1002         (cmakeBasedPortName):
1003         * Scripts/webkitpy/common/config/ports.py:
1004         (DeprecatedPort.port):
1005         (EflWK2Port.build_webkit_command):
1006         * Scripts/webkitpy/port/factory.py:
1007         (platform_options):
1008         (PortFactory):
1009         * Scripts/webkitpy/port/nix.py: Removed.
1010         * Scripts/webkitpy/port/nix_unittest.py: Removed.
1011
1012 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
1013
1014         Add Ian and Ricky to the contributor list
1015
1016         * Scripts/webkitpy/common/config/contributors.json:
1017         I am too old to remember all those email addresses :)
1018
1019 2014-01-21  David Farler  <dfarler@apple.com>
1020
1021         Upstream package-root for iOS
1022
1023         Reviewed by Daniel bates.
1024
1025         * Scripts/package-root: Added.
1026         (usage):
1027         * Scripts/webkitdirs.pm:
1028         (XcodeSDKPath): Added function.
1029
1030 2014-01-21  Daniel Bates  <dabates@apple.com>
1031
1032         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
1033         https://bugs.webkit.org/show_bug.cgi?id=127368
1034
1035         Reviewed by Tim Horton.
1036
1037         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
1038         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
1039         Tools.
1040
1041         * Makefile:
1042
1043 2014-01-21  Daniel Bates  <dabates@apple.com>
1044
1045         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
1046         https://bugs.webkit.org/show_bug.cgi?id=127364
1047
1048         Reviewed by Simon Fraser.
1049
1050         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
1051         projects fail to build because we need to upstream the relevant iOS changes.
1052         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
1053         aren't building TestWebKitAPI.
1054
1055         * Scripts/build-webkit:
1056
1057 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1058
1059         Unreviewed, remove myself from some watchlist entries.
1060
1061         * Scripts/webkitpy/common/config/watchlist:
1062
1063 2014-01-21  Zalan Bujtas  <zalan@apple.com>
1064
1065         Use 64 as the default value for the subpixel denominator.
1066
1067         Reviewed by Simon Fraser.
1068
1069         * lldb/lldb_webkit.py:
1070         (WebCoreLayoutUnitProvider.to_string):
1071
1072 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
1073
1074         [GTK] Fix a c++11 compliance issue for fontconfig
1075         https://bugs.webkit.org/show_bug.cgi?id=127283
1076
1077         Reviewed by Martin Robinson.
1078
1079         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
1080         hotfix until bumping fontconfig up.
1081
1082         * gtk/jhbuild.modules:
1083         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
1084
1085 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1086
1087         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
1088         like run_webkit_test does
1089         https://bugs.webkit.org/show_bug.cgi?id=127349
1090
1091         Reviewed by Csaba Osztrogonác.
1092
1093         * Scripts/run-jsc-stress-tests:
1094
1095 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
1096
1097         [GTK] Allow passing extra data to web extensions
1098         https://bugs.webkit.org/show_bug.cgi?id=125990
1099
1100         Reviewed by Carlos Garcia Campos.
1101
1102         Allow passing additional information to the injected bundle. On top
1103         of the string containing the path to the web extensions directory,
1104         a GVariant can be set with additional data using
1105         webkit_web_context_set_web_extensions_initialization_user_data().
1106         Also, a new initialize-web-extensions signal is emitted before
1107         launching a new WebProcess to allow setting different user data
1108         for each process. The GVariant is serialized as a string, passed
1109         to the injected bundle, and the injected bundle deserializes back
1110         the data, which is passed to web extensions which define the
1111         webkit_web_extension_initialize_with_user_data() function (for
1112         backwards compatibility, webkit_web_extension_initialize() is
1113         used as a fallback.)
1114
1115         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1116         (initializeWebExtensions): Handles the initialize-web-extensions
1117         signal, and sets the web extensions directory and the initialization
1118         user data.
1119         (testWebExtensionInitializationUserData): New test case for checking
1120         the user data passed on initialization to web extensions.
1121         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1122         (methodCallCallback): Added implementation for the
1123         GetInitializationUserData D-Bus method, used by
1124         testWebExtensionInitializationUserData().
1125         (webkit_web_extension_initialize_with_user_data): Define the
1126         initialization function with the additional user data parameter.
1127
1128 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
1129
1130         Change my email address in contributors.json.
1131
1132         Unreviewed.
1133
1134         * Scripts/webkitpy/common/config/contributors.json:
1135
1136 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
1137
1138         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
1139         https://bugs.webkit.org/show_bug.cgi?id=127291
1140
1141         Reviewed by Mario Sanchez Prada.
1142
1143         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
1144
1145         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1146         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1147         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1148         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1149
1150 2014-01-20  Zalan Bujtas  <zalan@apple.com>
1151
1152         Force float division when calculating CSS px value.
1153
1154         Reviewed by Simon Fraser.
1155
1156         Note that in Python 3, this is the default behavior.
1157
1158         * lldb/lldb_webkit.py:
1159         (WebCoreLayoutUnitProvider.to_string):
1160
1161 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1162
1163         build.webkit.org/dashboard should display information about patches in EWS
1164         https://bugs.webkit.org/show_bug.cgi?id=127006
1165
1166         Reviewed by Ryosuke Niwa.
1167
1168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
1170         (Bugzilla.prototype.detailsURLForAttachment):
1171         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
1172         which is needed when one wants to do something with a patch EWS is stuck on.
1173
1174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1175         Create a Bugzilla instance.
1176
1177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1178         (EWS.prototype.jsonQueueLengthURL):
1179         (EWS.prototype.jsonQueueStatusURL):
1180         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
1181
1182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1183         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
1184         of second guessing.
1185         (EWSQueue.prototype.get chartsPageURL): Added.
1186         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
1187         additional data already loaded (it's reset with every update).
1188         (EWSQueue.prototype.get patches): Get patch queue.
1189         (EWSQueue.prototype.get bots): Get bots.
1190         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
1191         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
1192
1193         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1194         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
1195         in the queue.
1196         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
1197         (EWSQueueView.prototype.addTextToRow): Ditto.
1198         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
1199         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
1200         (EWSQueueView.prototype._addDividerToPopover): Ditto.
1201         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
1202         relative string.
1203         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
1204         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
1205         it when done.
1206
1207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1208         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
1209         Changed a few difficult to read padding styles to padding-left.
1210
1211 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1212
1213         Fix webkitpy tests.
1214
1215         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
1216         Added a mock implementation, as we now call this function.
1217
1218 2014-01-20  Darin Adler  <darin@apple.com>
1219
1220         Update style checker and tests to deal with override instead of OVERRIDE
1221         https://bugs.webkit.org/show_bug.cgi?id=127175
1222
1223         Reviewed by Anders Carlsson.
1224
1225         * Scripts/webkitpy/style/checkers/cpp.py:
1226         (check_braces): Use override instead of OVERRIDE.
1227         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1228         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
1229
1230 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1231
1232         EWS should provide better information to Dashboard via JSON
1233         https://bugs.webkit.org/show_bug.cgi?id=127265
1234
1235         Reviewed by Ryosuke Niwa.
1236
1237         * QueueStatusServer/app.yaml: Updated version.
1238
1239         * QueueStatusServer/main.py:
1240         * QueueStatusServer/handlers/queuelengthjson.py:
1241         Added a way to cheaply get only the queue length, which is all the dashboard
1242         needs unless a popover is opened.
1243
1244         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
1245         that we will need. Changed some field names to be more meaningful. Fixed bot listing
1246         to understand that a bot can be reprurposed and used in a different queue.
1247
1248 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1249
1250         Make uploading results to EWS work despite robots.txt
1251         https://bugs.webkit.org/show_bug.cgi?id=127296
1252
1253         Reviewed by Ryosuke Niwa.
1254
1255         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
1256         checking robots.txt.
1257
1258         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
1259         Removed a comment saying that we would want to stop doing this. Not checking
1260         robots.txt is more efficient than checking it.
1261
1262 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
1263
1264         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
1265         https://bugs.webkit.org/show_bug.cgi?id=127214
1266
1267         Reviewed by Gyuyoung Kim.
1268
1269         Followed the changes of API.
1270
1271         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1272         (drtViewAdd):
1273         * EWebLauncher/main.c:
1274         (windowCreate):
1275
1276 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
1277
1278         [EFL][WK2] Add touch events option to MiniBrowser.
1279         https://bugs.webkit.org/show_bug.cgi?id=127262
1280
1281         Reviewed by Gyuyoung Kim.
1282
1283         As a default, touch events are disabled and mouse events are enabled.
1284         If touch events option sets to true, touch events are enabled and mouse
1285         events are disabled.
1286
1287         * MiniBrowser/efl/main.c:
1288         (window_create):
1289         (elm_main):
1290
1291 2014-01-19  Zalan Bujtas  <zalan@apple.com>
1292
1293         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
1294         https://bugs.webkit.org/show_bug.cgi?id=126080
1295
1296         Reviewed by Sam Weinig.
1297
1298         This changes the output of printing LayoutUnits to be in px but it also
1299         preserves the original LayoutUnit value.
1300
1301         This will lead to lldb output like: (and it works even when subpixel is disabled)
1302
1303         (const WebCore::LayoutRect) $0 = {
1304             m_location = { x = 2.25px (144), y = 1px (64)}
1305             m_size = { width = 13.75px (880), height = 20px (1280) }
1306
1307
1308         And gdb output like:
1309
1310         m_frameRect = {
1311             m_location = LayoutPoint(0px (0), 0px(0)),
1312             m_size = LayoutSize(8px (512), 5px (320))
1313         }
1314
1315         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
1316
1317         * gdb/webkit.py:
1318         (WebCoreLayoutUnitPrinter):
1319         (WebCoreLayoutUnitPrinter.__init__):
1320         (WebCoreLayoutUnitPrinter.to_string):
1321         (WebCoreLayoutSizePrinter):
1322         (WebCoreLayoutSizePrinter.__init__):
1323         (WebCoreLayoutSizePrinter.to_string):
1324         (WebCoreLayoutPointPrinter):
1325         (WebCoreLayoutPointPrinter.__init__):
1326         (WebCoreLayoutPointPrinter.to_string):
1327         (add_pretty_printers):
1328         * lldb/lldb_webkit.py:
1329         (__lldb_init_module):
1330         (WebCoreLayoutUnit_SummaryProvider):
1331         (WebCoreLayoutSize_SummaryProvider):
1332         (WebCoreLayoutPoint_SummaryProvider):
1333         (WebCoreLayoutUnitProvider):
1334         (WebCoreLayoutUnitProvider.__init__):
1335         (WebCoreLayoutUnitProvider.to_string):
1336         (WebCoreLayoutSizeProvider):
1337         (WebCoreLayoutSizeProvider.__init__):
1338         (WebCoreLayoutSizeProvider.get_width):
1339         (WebCoreLayoutSizeProvider.get_height):
1340         (WebCoreLayoutPointProvider):
1341         (WebCoreLayoutPointProvider.__init__):
1342         (WebCoreLayoutPointProvider.get_x):
1343         (WebCoreLayoutPointProvider.get_y):
1344
1345 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1346
1347         Add robots.txt to http://webkit-queues.appspot.com
1348         https://bugs.webkit.org/show_bug.cgi?id=127240
1349
1350         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
1351
1352 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1353
1354         Add robots.txt to http://webkit-queues.appspot.com
1355         https://bugs.webkit.org/show_bug.cgi?id=127240
1356
1357         Reviewed by Ryosuke Niwa.
1358
1359         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
1360
1361         * QueueStatusServer/robots.txt: Added.
1362
1363 2014-01-18  Alberto Garcia  <berto@igalia.com>
1364
1365         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
1366         https://bugs.webkit.org/show_bug.cgi?id=127217
1367
1368         Reviewed by Daniel Bates.
1369
1370         The syntax File::Temp->tempdir() was explicitly made invalid
1371         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
1372         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
1373
1374         Use File::Temp::tempdir() instead.
1375
1376         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1377
1378 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1379
1380         build.webkit.org/dashboard should have image diff links in test results popovers
1381         https://bugs.webkit.org/show_bug.cgi?id=127188
1382
1383         Reviewed by Timothy Hatcher.
1384
1385         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1386         (Buildbot.prototype.layoutTestImagesURLForIteration):
1387         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
1388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1389         (BuildbotIteration.prototype.loadLayoutTestResults):
1390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1391         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
1392         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
1393         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1394
1395 2014-01-18  Anders Carlsson  <andersca@apple.com>
1396
1397         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
1398         https://bugs.webkit.org/show_bug.cgi?id=127225
1399
1400         Reviewed by Andreas Kling.
1401
1402         This concludes the removal of over 8.8 million lines of threaded parser code.
1403
1404         * Scripts/webkitperl/FeatureList.pm:
1405
1406 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
1407
1408         build.webkit.org/dashboard should have diff links in test results popovers
1409         https://bugs.webkit.org/show_bug.cgi?id=126986
1410
1411         Reviewed by Tim Horton.
1412
1413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1414         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
1415         (Buildbot.prototype.layoutTestStderrURLForIteration):
1416         (Buildbot.prototype.layoutTestDiffURLForIteration):
1417         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
1418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1419         (BuildbotIteration.prototype.loadLayoutTestResults):
1420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1421         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1422
1423 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
1424
1425         Add the bare minimum support for branches to the bot-watchers dashboard
1426         https://bugs.webkit.org/show_bug.cgi?id=127124
1427
1428         This patch simply introduces the notion of branches into the bot-watchers dashboard.
1429         Subsequent patches will build functionality on top of this simple bit of infrastructure.
1430
1431         Reviewed by Timothy Hatcher.
1432
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1434         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
1435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1436         Initialize the Dashboard.Branch object
1437
1438 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
1439
1440         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1441         https://bugs.webkit.org/show_bug.cgi?id=127141
1442
1443         Reviewed by Alexey Proskuryakov.
1444
1445         Make sure to reset the notification handler each time.
1446
1447         * DumpRenderTree/AccessibilityController.cpp:
1448         (AccessibilityController::resetToConsistentState):
1449         * DumpRenderTree/AccessibilityController.h:
1450         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1451         (AccessibilityController::platformResetToConsistentState):
1452         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1453         (AccessibilityController::platformResetToConsistentState):
1454         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1455         (AccessibilityController::~AccessibilityController):
1456         (AccessibilityController::platformResetToConsistentState):
1457         (AccessibilityController::removeNotificationListener):
1458         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1459         (AccessibilityController::platformResetToConsistentState):
1460
1461 2014-01-17  Alberto Garcia  <berto@igalia.com>
1462
1463         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
1464         https://bugs.webkit.org/show_bug.cgi?id=82329
1465
1466         Reviewed by Carlos Garcia Campos.
1467
1468         Unskip, this is working fine now.
1469
1470         * Scripts/run-gtk-tests:
1471         (TestRunner):
1472
1473 2014-01-17  Alberto Garcia  <berto@igalia.com>
1474
1475         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
1476         https://bugs.webkit.org/show_bug.cgi?id=82328
1477
1478         Reviewed by Carlos Garcia Campos.
1479
1480         This was caused by the icon database being corrupted in the
1481         Release bot. After removing it the test works fine so it can be
1482         run again.
1483
1484         * Scripts/run-gtk-tests:
1485         (TestRunner):
1486
1487 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
1488
1489         Test results popovers at http://build.webkit.org/dashboard should link to stderr
1490         https://bugs.webkit.org/show_bug.cgi?id=126929
1491
1492         Reviewed by Timothy Hatcher.
1493
1494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1495         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
1496         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
1497
1498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1499         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
1500
1501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1502         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1503         Add a link to stderr output if present.
1504
1505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1506         (.test-results-popover .additional-link): Style with light grey (will use the same style
1507         for diff links).
1508
1509 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1510
1511         Automate DoYouEvenBench
1512         https://bugs.webkit.org/show_bug.cgi?id=124497
1513
1514         Reviewed by Geoffrey Garen.
1515
1516         * Scripts/webkitpy/performance_tests/perftest.py:
1517         (PerfTestMetric.__init__): Added the aggregator name as an argument.
1518         (PerfTestMetric.aggregator): Added.
1519         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
1520         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
1521         should be parsed as the metric and the aggregator respectively.
1522         (PerfTest._run_with_driver): Pass in the aggregator name.
1523         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
1524         which generates subtests of subtests within a single test file.
1525
1526         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1527         (test_parse_output_with_subtests_and_total): Added.
1528
1529         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1530         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
1531
1532         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1533         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
1534
1535 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
1536
1537         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1538         https://bugs.webkit.org/show_bug.cgi?id=127141
1539
1540         Reviewed by Alexey Proskuryakov.
1541
1542         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
1543
1544         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1545         (AccessibilityController::~AccessibilityController):
1546
1547 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1548
1549         EWS shouldn't comment on Bugzilla for failing builds or style errors
1550         https://bugs.webkit.org/show_bug.cgi?id=127079
1551
1552         Reviewed by Anders Carlsson.
1553
1554         Since patch authors and reviewers could retrieve this information from bubbles,
1555         we shouldn't spam the Bugzilla with useless comments.
1556
1557         We still post style errors but not python paths we used since it's a pure noise.
1558
1559         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1560         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
1561         * Scripts/webkitpy/tool/commands/queues.py:
1562         (StyleQueue.review_patch):
1563
1564 2014-01-15  Roger Fong  <roger_fong@apple.com>
1565
1566         Add support for handling WebGL load policies.
1567         https://bugs.webkit.org/show_bug.cgi?id=126935
1568         <rdar://problem/15790448>.
1569
1570         Reviewed by Timothy Horton.
1571
1572         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
1573         (WTR::TestController::createWebViewWithOptions):
1574
1575 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1576
1577         Remove workaround for compilers not supporting explicit override control
1578         https://bugs.webkit.org/show_bug.cgi?id=127111
1579
1580         Reviewed by Anders Carlsson.
1581
1582         Now all compilers support explicit override control, this workaround can be removed.
1583
1584         * DumpRenderTree/gtk/fonts/fonts.conf:
1585         * Scripts/do-webcore-rename:
1586         Removed this rename operation from the list of contemplated future renames.
1587         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1588         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1589         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1590         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1591         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1592
1593 2014-01-16  Oliver Hunt  <oliver@apple.com>
1594
1595         Stop run-jsc from consuming stderr output
1596         https://bugs.webkit.org/show_bug.cgi?id=127115
1597
1598         Reviewed by Mark Lam.
1599
1600         Simple patch to make run-jsc easier to deal with
1601
1602         * Scripts/run-jsc:
1603
1604 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
1605
1606         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
1607         https://bugs.webkit.org/show_bug.cgi?id=126323
1608
1609         Reviewed by Csaba Osztrogonác.
1610
1611         * gtk/generate-feature-defines-files:
1612
1613 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1614
1615         [EFL][WK2] Implement TestController::setHidden
1616         https://bugs.webkit.org/show_bug.cgi?id=127036
1617
1618         Reviewed by Gyuyoung Kim.
1619
1620         WebKitTestRunner needs TestController::setHidden implementation to
1621         properly handle page visibility API layout tests after r161105.
1622
1623         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1624         (WTR::TestController::setHidden):
1625
1626 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
1627
1628         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
1629         https://bugs.webkit.org/show_bug.cgi?id=127083
1630
1631         Reviewed by Carlos Garcia Campos.
1632
1633         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
1634         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
1635
1636         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
1637         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
1638         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
1639         BrowserWindow object is being finalized, preventing the callback from firing.
1640
1641         * MiniBrowser/gtk/BrowserWindow.c:
1642         (resetEntryProgress):
1643         (webViewLoadProgressChanged):
1644         (browserWindowFinalize):
1645
1646 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
1647
1648         DumpRenderTree doesn't disable web preferences autosave
1649         https://bugs.webkit.org/show_bug.cgi?id=127062
1650
1651         Reviewed by Dan Bernstein.
1652
1653         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1654         Do it.
1655
1656 2014-01-15  Dean Jackson  <dino@apple.com>
1657
1658         Improve filter-build-webkit, especially for iOS builds
1659         https://bugs.webkit.org/show_bug.cgi?id=81046
1660
1661         Reviewed by Joseph Pecoraro.
1662
1663         Lots of updates to the filtering rules, mostly from the
1664         iOS build output. Other highlights include:
1665         - ignoring escape sequences for color ouput
1666         - detecting escaped spaces in file name regexps
1667
1668         * Scripts/filter-build-webkit:
1669         (shouldIgnoreLine):
1670
1671 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1672
1673         [GTK] Web process sometimes crashes when printing in synchronous mode
1674         https://bugs.webkit.org/show_bug.cgi?id=126979
1675
1676         Reviewed by Gustavo Noronha Silva.
1677
1678         * Scripts/run-gtk-tests:
1679         (TestRunner): Unskip
1680         /webkit2/WebKitPrintOperation/close-after-print.
1681
1682 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
1683
1684         [EFL] Change test font installed path to webkitgtk-font-tests
1685         https://bugs.webkit.org/show_bug.cgi?id=126723
1686
1687         Reviewed by Gyuyoung Kim.
1688
1689         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
1690         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
1691         hard-coded in FontManagement.cpp#105
1692
1693         * DumpRenderTree/PlatformEfl.cmake:
1694         * WebKitTestRunner/PlatformEfl.cmake:
1695         * efl/jhbuild.modules:
1696
1697 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
1698
1699         Make DoYouEvenBench runnable by run-perf-tests
1700         https://bugs.webkit.org/show_bug.cgi?id=127030
1701
1702         Reviewed by Andreas Kling.
1703
1704         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
1705         ":Total" to appear at the end of a test name. We don't do anything with it for now.
1706
1707         * Scripts/webkitpy/performance_tests/perftest.py:
1708         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
1709         to the JSON in a follow up patch for the perf dashboard.
1710         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
1711
1712 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1713
1714         [GTK] UI process crashes when the web process crashes while printing
1715         https://bugs.webkit.org/show_bug.cgi?id=126977
1716
1717         Reviewed by Gustavo Noronha Silva.
1718
1719         Add new test case to check that closing the window right after
1720         printing works. It's skipped for now, because this patch only
1721         fixes the UI process crash, but not the web process one.
1722
1723         * Scripts/run-gtk-tests:
1724         (TestRunner): Skip
1725         /webkit2/WebKitPrintOperation/close-after-print.
1726         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1727         (testPrintOperationPrintPrinter):
1728         (findPrintToFilePrinter):
1729         (testPrintOperationPrint):
1730         (testPrintOperationErrors):
1731         (testPrintOperationCloseAfterPrint):
1732         (beforeAll):
1733
1734 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
1735
1736         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
1737         https://bugs.webkit.org/show_bug.cgi?id=127002
1738
1739         Reviewed by David Kilzer.
1740
1741         * Scripts/webkitdirs.pm:
1742         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
1743
1744 2014-01-14  Commit Queue  <commit-queue@webkit.org>
1745
1746         Unreviewed, rolling out r162000.
1747         http://trac.webkit.org/changeset/162000
1748         https://bugs.webkit.org/show_bug.cgi?id=127009
1749
1750         API versioning is wrong (Requested by rfong on #webkit).
1751
1752         * MiniBrowser/mac/WK2BrowserWindowController.m:
1753         (-[WK2BrowserWindowController awakeFromNib]):
1754         * WebKitTestRunner/TestController.cpp:
1755         (WTR::TestController::createOtherPage):
1756         (WTR::TestController::createWebViewWithOptions):
1757
1758 2014-01-13  Roger Fong  <roger_fong@apple.com>
1759
1760         Add support for handling WebGL load policies.
1761         https://bugs.webkit.org/show_bug.cgi?id=126935
1762         <rdar://problem/15790448>.
1763
1764         Reviewed by Brent Fulgham.
1765
1766         * MiniBrowser/mac/WK2BrowserWindowController.m:
1767         (-[WK2BrowserWindowController awakeFromNib]):
1768         * WebKitTestRunner/TestController.cpp:
1769         (WTR::TestController::createWebViewWithOptions):
1770
1771 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
1772
1773         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
1774         https://bugs.webkit.org/show_bug.cgi?id=120110
1775
1776         Reviewed by Martin Robinson.
1777
1778         Skip the FontConfig settings initialization in WebKitTestRunner if the
1779         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
1780         This is useful when profiling the WebKitTestRunner execution, where at the startup
1781         this step takes considerable amount of time and disturbs the profiling output.
1782
1783         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1784         (WTR::initializeFontConfigSetting):
1785
1786 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
1787
1788         Add ENABLE(WEB_REPLAY) feature flag to the build system
1789         https://bugs.webkit.org/show_bug.cgi?id=126949
1790
1791         Reviewed by Joseph Pecoraro.
1792
1793         * Scripts/webkitperl/FeatureList.pm:
1794
1795 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
1796
1797         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
1798         https://bugs.webkit.org/show_bug.cgi?id=126702
1799
1800         Reviewed by Alexey Proskuryakov.
1801
1802         Resolve regression and remove a FIXME comment that is already fixed.
1803
1804         * Scripts/webkitpy/common/system/filesystem.py:
1805         (FileSystem.open_text_file_for_reading):
1806         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1807         (RealFileSystemTest.test_read_and_write_file):
1808         * Scripts/webkitpy/style/filereader.py:
1809         (TextFileReader._read_lines):
1810         * Scripts/webkitpy/style/filereader_unittest.py:
1811         (TextFileReaderTest.test_count_delete_only_file):
1812         (TextFileReaderTest):
1813         (TextFileReaderTest.test_process_malformed_file):
1814
1815 2014-01-02  Brian Holt  <brian.holt@samsung.com>
1816
1817         [GTK] Parse Valgrind xml leak files
1818         https://bugs.webkit.org/show_bug.cgi?id=119446
1819
1820         Reviewed by Alejandro G. Castro.
1821
1822         Parse the xml files generated by Valgrind to yield useful
1823         information about the memory leaks.
1824
1825         * Scripts/webkitpy/port/gtk.py:
1826         (GtkPort.__init__):
1827         (GtkPort.setup_test_run): Clear the previous output files before new
1828         run.
1829         (GtkPort.print_leaks_summary):
1830
1831         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
1832         Parse the xml files generated by Valgrind and summarise leaks
1833         into an easily understandable list.
1834         (get_text_of):
1835         (get_CDATA_of):
1836         (gather_frames):
1837         (ValgrindError):
1838         (ValgrindError.__init__):
1839         (ValgrindError.__str__):
1840         (ValgrindError.unique_string):
1841         (ValgrindError.error_hash):
1842         (ValgrindError.__hash__):
1843         (ValgrindError.__eq__):
1844         (LeakDetectorValgrind):
1845         (LeakDetectorValgrind.__init__):
1846         (LeakDetectorValgrind._parse_leaks_output):
1847         (LeakDetectorValgrind.leaks_files_in_results_directory):
1848         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
1849         (LeakDetectorValgrind.parse_and_print_leaks_detail):
1850
1851         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
1852         (make_mock_valgrind_output):
1853         (make_mock_incomplete_valgrind_output):
1854         (make_mock_valgrind_results):
1855         (make_mock_valgrind_results_incomplete):
1856         (make_mock_valgrind_results_empty):
1857         (make_mock_valgrind_results_misformatted):
1858         (mock_run_cppfilt_command):
1859         (LeakDetectorValgrindTest):
1860         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
1861         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
1862         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
1863         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
1864         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
1865         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
1866         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
1867         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
1868
1869 2014-01-13  Lucas Forschler  <lforschler@apple.com>
1870
1871         Update the LLINT CLoop Bot build infrastructure
1872         https://bugs.webkit.org/show_bug.cgi?id=126604
1873         
1874         Unreviewed.
1875         
1876         * BuildSlaveSupport/build.webkit.org-config/config.json:
1877         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1878         (CompileLLINTCLoop):
1879         (RunLLINTCLoopTests):
1880         (BuildAndTestLLINTCLoopFactory):
1881         (BuildAndTestLLINTCLoopFactory.__init__):
1882
1883 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
1884
1885         [EFL][WK2] Disable failing API tests
1886         https://bugs.webkit.org/show_bug.cgi?id=126960
1887
1888         Reviewed by Gyuyoung Kim.
1889
1890         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
1891
1892         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1893         (TestWebKitAPI::TEST):
1894
1895 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
1896
1897         Remove wdiff
1898         https://bugs.webkit.org/show_bug.cgi?id=124766
1899
1900         Reviewed by Ryosuke Niwa.
1901
1902         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1903         (ResultsJSONParserTest):
1904         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1905         (TestResultWriter):
1906         (TestResultWriter.create_text_diff_and_write_result):
1907         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1908         (summarize_results):
1909         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1910         (RunTest.test_output_diffs):
1911         * Scripts/webkitpy/port/base.py:
1912         (Port.__init__):
1913         (Port.driver_stop_timeout):
1914         (Port.check_image_diff):
1915         (Port.repository_paths):
1916         (Port._path_to_lighttpd_php):
1917         * Scripts/webkitpy/port/base_unittest.py:
1918         (PortTest.test_default_child_processes):
1919         (PortTest.test_pretty_patch_script_error):
1920         * Scripts/webkitpy/port/port_testcase.py:
1921         (PortTestCase.test_diff_image_crashed):
1922         * Scripts/webkitpy/port/test.py:
1923         (TestPort.operating_system):
1924
1925 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
1926
1927         Build fix for the GTK+ CMake port
1928
1929         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
1930
1931 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
1932
1933         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
1934         https://bugs.webkit.org/show_bug.cgi?id=126881
1935
1936         Reviewed by Carlos Garcia Campos.
1937
1938         * MiniBrowser/gtk/BrowserWindow.c:
1939         (browser_window_new):
1940         Explicitly cast GtkWindow** to gpointer* in call to
1941         g_object_add_weak_pointer to avoid compiler warnings.
1942
1943 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1944
1945         Remove parsing of old-run-webkit-tests output from master.cfg
1946         https://bugs.webkit.org/show_bug.cgi?id=126690
1947
1948         Reviewed by Csaba Osztrogonác.
1949
1950         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1951         Removed parsing of ORWT output, as it is not used anymore.
1952         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1953         Updated unit tests accordingly.
1954
1955 2014-01-13  Commit Queue  <commit-queue@webkit.org>
1956
1957         Unreviewed, rolling out r161808.
1958         http://trac.webkit.org/changeset/161808
1959         https://bugs.webkit.org/show_bug.cgi?id=126874
1960
1961         This patch make several files to be always regenerated on
1962         every make (Requested by KaL on #webkit).
1963
1964         * WebKitTestRunner/GNUmakefile.am:
1965
1966 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
1967
1968         [GTK] Make MiniBrowser windows non-transient by default
1969         https://bugs.webkit.org/show_bug.cgi?id=126840
1970
1971         Reviewed by Carlos Garcia Campos.
1972
1973         Instead of making new browser windows transient as soon as they are
1974         created, save the pointer to the parent window and set the transient
1975         state later on when handling the "run-as-modal" signal. This makes
1976         it easier to use the MiniBrowser to do tests involving multiple
1977         windows, and will be useful as well when multi-web-process mode is
1978         enabled for the GTK port.
1979
1980         * MiniBrowser/gtk/BrowserWindow.c:
1981         (webViewRunAsModal): Set the parent window using
1982         gtk_window_set_transient_for() using the saved parent
1983         window.
1984         (browser_window_new): Save the parent window using
1985         g_object_set_data() instead of making the new window
1986         transient immediately.
1987
1988 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
1989
1990         [EFL][WK2] Make API tests work again
1991         https://bugs.webkit.org/show_bug.cgi?id=126769
1992
1993         Reviewed by Gyuyoung Kim.
1994
1995         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
1996         [E]WebKit2, respectively, and this causes problems because the logic to find
1997         where WebProcess is to look in the same directory of the running process and
1998         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
1999
2000         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
2001         Gtk port, which allows us to look for WebProcess initially in this directory,
2002         if it's defined.
2003
2004         * TestWebKitAPI/efl/main.cpp:
2005         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
2006
2007 2014-01-12  Daniel Bates  <dabates@apple.com>
2008
2009         [iOS] Fix the build
2010
2011         For now, ensure we build WebKit System Interface before we build WebKit.
2012         We'll remove this constraint and the constraint to build WebKit Additions
2013         in a subsequent commit.
2014
2015         * Scripts/build-webkit:
2016
2017 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2018
2019         Unreviewed. Fix make distcheck.
2020
2021         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
2022         to EXTRA_DIST.
2023
2024 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
2025
2026         --disable-dependency-tracking causes build failure due to missing directories
2027         https://bugs.webkit.org/show_bug.cgi?id=94488
2028
2029         Reviewed by Gustavo Noronha Silva.
2030
2031         Autotools build fix: Ensure output directory existing
2032         before generating DerivedSources. This allows for
2033         --disable-dependency-tracking to be run.
2034
2035
2036         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
2037
2038 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2039
2040         [GTK] Fix return value of WebKitDownload::created-destination
2041         https://bugs.webkit.org/show_bug.cgi?id=126741
2042
2043         Reviewed by Martin Robinson.
2044
2045         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
2046         value of several callbacks.
2047
2048 2014-01-11  Sam Weinig  <sam@webkit.org>
2049
2050         Add support for null StringViews
2051         https://bugs.webkit.org/show_bug.cgi?id=126827
2052
2053         Reviewed by Anders Carlsson.
2054
2055         Add new test for StringView.
2056
2057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2058         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
2059         (TestWebKitAPI::TEST):
2060
2061 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2062
2063         Remove the BlackBerry port from trunk
2064         https://bugs.webkit.org/show_bug.cgi?id=126715
2065
2066         Reviewed by Anders Carlsson.
2067
2068         * DumpRenderTree/DumpRenderTree.h:
2069         * DumpRenderTree/PixelDumpSupport.cpp:
2070
2071 2014-01-10  Daniel Bates  <dabates@apple.com>
2072
2073         [iOS] Fix project build order
2074
2075         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
2076         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
2077         time of writing.
2078
2079         * Scripts/build-webkit:
2080
2081 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2082
2083         Move platformName property from testRunner to accessibilityController
2084         https://bugs.webkit.org/show_bug.cgi?id=126689
2085
2086         Reviewed by Chris Fleizach.
2087
2088         Move the platformName property from the testRunner into
2089         accessibilityController, since this is a concept that has only be
2090         used by accessibility tests since it got added, and also because
2091         the real intention was not to distinguish among "ports" (mac, win,
2092         gtk, efl) but between platforms (atk, mac, win).
2093
2094         This change will be very useful to merge GTK's roles-exposed.html
2095         and Mac's role-subrole-roledescription.html into one single test,
2096         since we will be specifying in the test itself which elements are
2097         supported in which accessibility "platform". In this context,
2098         being able to check accessibilityController.platformName directly
2099         against a list of supported accessibility platforms (e.g. "atk,mac")
2100         will certainly maintain the code cleaner and simpler.
2101
2102         * DumpRenderTree/TestRunner.h:
2103         (TestRunner::platformName): Removed.
2104         * DumpRenderTree/TestRunner.cpp:
2105         (getPlatformNameCallback): Removed.
2106         (TestRunner::staticValues): Removed platformName
2107         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2108         (TestRunner::platformName): Removed.
2109         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2110         (TestRunner::platformName): Removed.
2111         * DumpRenderTree/mac/TestRunnerMac.mm:
2112         (TestRunner::platformName): Removed.
2113         * DumpRenderTree/win/TestRunnerWin.cpp:
2114         (TestRunner::platformName): Removed.
2115
2116         * DumpRenderTree/AccessibilityController.h:
2117         (AccessibilityController::platformName): Added.
2118         * DumpRenderTree/AccessibilityController.cpp:
2119         (getPlatformNameCallback): Added.
2120         (AccessibilityController::getJSClass): Added platformName.
2121         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2122         (AccessibilityController::platformName): Added, returning "atk".
2123         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2124         (AccessibilityController::platformName): Ditto, returning "mac".
2125         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2126         (AccessibilityController::platformName): Ditto, returning "ios".
2127         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2128         (AccessibilityController::platformName): Ditto, returning "win".
2129
2130         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2131         (platformName): Removed.
2132         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2133         (TestRunner::platformName): Removed.
2134         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2135         (TestRunner::platformName): Removed.
2136         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2137         (TestRunner::platformName): Removed.
2138         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2139         (TestRunner::platformName): Removed.
2140         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2141         (TestRunner::platformName): Removed.
2142
2143         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2144         (WTR:AccessibilityController::platformName): Added.
2145         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2146         (platformName): Added.
2147         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2148         (WTR::AccessibilityController::platformName): Added, returning "atk".
2149         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2150         (WTR::AccessibilityController::platformName): Added, returning "mac".
2151
2152 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2153
2154         Remove the BlackBerry port from trunk
2155         https://bugs.webkit.org/show_bug.cgi?id=126715
2156
2157         Reviewed by Anders Carlsson.
2158
2159         * Scripts/webkitpy/common/config/watchlist:
2160
2161 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
2162
2163         Remove the BlackBerry files outside WebCore
2164         https://bugs.webkit.org/show_bug.cgi?id=126715
2165
2166         Reviewed by Anders Carlsson.
2167
2168         * DumpRenderTree/blackberry: Removed.
2169
2170 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
2171
2172         Remove knowledge of Blackberry from build scripts
2173         https://bugs.webkit.org/show_bug.cgi?id=126766
2174
2175         Reviewed by Anders Carlsson.
2176         
2177         Remove isBlackBerry() and references to it, and rmeove
2178         blackberry-related stuff from the watchlist.
2179
2180         * Scripts/build-webkit:
2181         * Scripts/webkit-build-directory:
2182         * Scripts/webkitdirs.pm:
2183         (determineBaseProductDir):
2184         (argumentsForConfiguration):
2185         (builtDylibPathForName):
2186         (isAppleWebKit):
2187         (buildCMakeProjectOrExit):
2188         (cmakeBasedPortArguments):
2189         (cmakeBasedPortName):
2190         * Scripts/webkitperl/FeatureList.pm:
2191         * Scripts/webkitpy/common/config/watchlist:
2192
2193 2014-01-10  Daniel Bates  <dabates@apple.com>
2194
2195         [iOS] Fix up simulator build and enable default features
2196
2197         Rubber-stamped by Joseph Pecoraro.
2198
2199         * Scripts/webkitdirs.pm:
2200         (determineArchitecture):
2201         (determinePassedArchitecture):
2202         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
2203         by default only in iOS).
2204
2205 2014-01-10  Daniel Bates  <dabates@apple.com>
2206
2207         [iOS] Upstream WebCore and Tools miscellaneous changes
2208         https://bugs.webkit.org/show_bug.cgi?id=126698
2209
2210         Reviewed by David Kilzer.
2211
2212         * Scripts/check-for-inappropriate-objc-class-names:
2213         * Scripts/check-for-webkit-framework-include-consistency:
2214
2215 2014-01-09  Dan Bernstein  <mitz@apple.com>
2216
2217         [Cocoa] Promote WKBackForwardList{,Item}.h to public
2218         https://bugs.webkit.org/show_bug.cgi?id=126707
2219
2220         Reviewed by Sam Weinig.
2221
2222         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
2223         left behind in the build products directory after a private header is made public.
2224
2225 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2226
2227         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
2228         https://bugs.webkit.org/show_bug.cgi?id=126686
2229
2230         Reviewed by Martin Robinson.
2231
2232         Test that partial files are not left on disk after a download has
2233         been cancelled after the destination has been decided. To make
2234         sure the download is cancelled after the destination has been
2235         decided and before the operation finishes, we cancel the download
2236         in the destination decided callback, and we use an infinite
2237         resource that writes chunks to the response body and never
2238         completes the body.
2239
2240         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2241         (addContentDispositionHTTPHeaderToResponse): Helper function to
2242         add the Content-Disposition to the response headers.
2243         (writeNextChunkIdle): Write next chunk to response body.
2244         (writeNextChunk): Write next chunk in an idle to avoid flooding
2245         the network with the inifnite resource.
2246         (serverCallback): Add an inifinite resource.
2247         (testDownloadRemoteFileError): Check that partial file is not
2248         present after the download has been cancelled.
2249
2250 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
2251
2252         Move myself to the committers list.
2253
2254         Unreviewed.
2255
2256         * Scripts/webkitpy/common/config/contributors.json:
2257
2258 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2259
2260         [GTK] Unreviewed build fix after r161522.
2261
2262         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
2263
2264 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2265
2266         Missleading style error when mixing system and non-system header include lines.
2267         https://bugs.webkit.org/show_bug.cgi?id=126564
2268
2269         Reviewed by Ryosuke Niwa.
2270
2271         * Scripts/webkitpy/style/checkers/cpp.py:
2272         (check_include_line):
2273         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2274         (OrderOfIncludesTest.test_check_alphabetical_include_order):
2275         (OrderOfIncludesTest.test_public_primary_header):
2276
2277 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2278
2279         [EFL] Unreviewed build fix after r161522.
2280
2281         * TestWebKitAPI/CMakeLists.txt:
2282         * TestWebKitAPI/PlatformEfl.cmake:
2283
2284 2014-01-08  Anders Carlsson  <andersca@apple.com>
2285
2286         Remove WKConnectionRef tests
2287         https://bugs.webkit.org/show_bug.cgi?id=126666
2288
2289         Reviewed by Dan Bernstein.
2290
2291         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
2292         Remove the API tests as a first step towards killing the entire thing.
2293
2294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2295         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
2296         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
2297
2298 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2299
2300         Unreviewed, rolling out r161512.
2301         http://trac.webkit.org/changeset/161512
2302         https://bugs.webkit.org/show_bug.cgi?id=126655
2303
2304         Broke webkitpy tests (Requested by ap on #webkit).
2305
2306         * Scripts/webkitpy/port/gtk.py:
2307         (GtkPort.__init__):
2308         (GtkPort.setup_test_run):
2309         (GtkPort._port_specific_expectations_files):
2310         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
2311         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
2312
2313 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2314
2315         Unreviewed, rolling out r161517.
2316         http://trac.webkit.org/changeset/161517
2317         https://bugs.webkit.org/show_bug.cgi?id=126659
2318
2319         The fix didn't completely remove the problem and is now
2320         standing in the way of the rollout of the offending patch
2321         (Requested by zdobersek on #webkit).
2322
2323         * Scripts/webkitpy/port/gtk.py:
2324         (GtkPort.__init__):
2325
2326 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2327
2328         Unreviewed. Attempting to fix webkitpy tests after r161512.
2329
2330         * Scripts/webkitpy/port/gtk.py:
2331         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
2332
2333 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2334
2335         [GTK] Parse Valgrind xml leak files
2336         https://bugs.webkit.org/show_bug.cgi?id=119446
2337
2338         Reviewed by Alejandro G. Castro.
2339
2340         Parse the xml files generated by Valgrind to yield useful
2341         information about the memory leaks.
2342
2343         * Scripts/webkitpy/port/gtk.py:
2344         (GtkPort.__init__):
2345         (GtkPort.setup_test_run): Clear the previous output files before new
2346         run.
2347         (GtkPort.print_leaks_summary):
2348
2349         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2350         Parse the xml files generated by Valgrind and summarise leaks
2351         into an easily understandable list.
2352         (get_text_of):
2353         (get_CDATA_of):
2354         (gather_frames):
2355         (ValgrindError):
2356         (ValgrindError.__init__):
2357         (ValgrindError.__str__):
2358         (ValgrindError.unique_string):
2359         (ValgrindError.error_hash):
2360         (ValgrindError.__hash__):
2361         (ValgrindError.__eq__):
2362         (LeakDetectorValgrind):
2363         (LeakDetectorValgrind.__init__):
2364         (LeakDetectorValgrind._parse_leaks_output):
2365         (LeakDetectorValgrind.leaks_files_in_results_directory):
2366         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2367         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2368
2369         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2370         (make_mock_valgrind_output):
2371         (make_mock_incomplete_valgrind_output):
2372         (make_mock_valgrind_results):
2373         (make_mock_valgrind_results_incomplete):
2374         (make_mock_valgrind_results_empty):
2375         (make_mock_valgrind_results_misformatted):
2376         (LeakDetectorValgrindTest):
2377         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2378         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2379         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2380         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2381         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2382         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2383         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2384         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2385
2386 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2387
2388         Unreviewed, rolling out r161427.
2389         http://trac.webkit.org/changeset/161427
2390         https://bugs.webkit.org/show_bug.cgi?id=126645
2391
2392         Emits a stye error on any newly added files (Requested by ap
2393         on #webkit).
2394
2395         * Scripts/webkitpy/style/checkers/cpp.py:
2396         (check_style):
2397         (CppChecker):
2398         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2399         (WebKitStyleTest.test_other):
2400
2401 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2402
2403         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
2404         https://bugs.webkit.org/show_bug.cgi?id=126580
2405
2406         Reviewed by Csaba Osztrogonác.
2407
2408         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2409         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
2410         run-webkit-tests script.
2411         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
2412         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
2413
2414 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2415
2416         Update the list of non-committer u-szeged contributors
2417         https://bugs.webkit.org/show_bug.cgi?id=126640
2418
2419         Reviewed by Csaba Osztrogonác.
2420
2421         * Scripts/webkitpy/common/config/contributors.json:
2422
2423 2014-01-08  Alberto Garcia  <berto@igalia.com>
2424
2425         Fix some compilation warnings
2426         https://bugs.webkit.org/show_bug.cgi?id=126635
2427
2428         Reviewed by Csaba Osztrogonác.
2429
2430         * GtkLauncher/main.c:
2431         (createWindow): This function is not supposed to receive any
2432         parameter, yet we are passing one.
2433
2434 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2435
2436         [GTK][WK2] unskip passing unit tests
2437         https://bugs.webkit.org/show_bug.cgi?id=126637
2438
2439         Reviewed by Carlos Garcia Campos.
2440
2441         Unskip TestResources and TestAuthentication unit tests since they
2442         are passing both under Xvfb and X.
2443
2444         * Scripts/run-gtk-tests:
2445         (TestRunner):
2446
2447 2014-01-08  Alberto Garcia  <berto@igalia.com>
2448
2449         REGRESSION(r160304): [GTK] Disable libtool fast install
2450         https://bugs.webkit.org/show_bug.cgi?id=126381
2451
2452         Reviewed by Gustavo Noronha Silva.
2453
2454         Disable the libtool fast-install mode in developer/test builds.
2455
2456         In this mode binaries are generated ready to be used directly from
2457         the build tree. Otherwise they would need to be relinked when they
2458         are executed, which can take a lot of resources, particularly in
2459         debug builds.
2460
2461         * Scripts/webkitdirs.pm:
2462         (runAutogenForAutotoolsProjectIfNecessary):
2463
2464 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2465
2466         Unreviewed GTK gardening.
2467
2468         * Scripts/run-gtk-tests:
2469         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
2470         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
2471
2472 2014-01-07  Lucas Forschler  <lforschler@apple.com>
2473
2474         Add buildbot infrasctructure for building and testing JSC cloop
2475         https://bugs.webkit.org/show_bug.cgi?id=126604
2476
2477         Reviewed by Geoffrey Garen.
2478
2479         * BuildSlaveSupport/build.webkit.org-config/config.json:
2480         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2481         (CompileCLOOP):
2482         (RunCLOOPTests):
2483         (RunCLOOPTests.countFailures):
2484         (BuildAndTestCLOOP):
2485
2486 2014-01-07  Brian Burg  <bburg@apple.com>
2487
2488         Unreviewed. Add myself as a committer.
2489
2490         * Scripts/webkitpy/common/config/contributors.json:
2491
2492 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2493
2494         Popovers at build.webkit.org/dashboard could have titles
2495         https://bugs.webkit.org/show_bug.cgi?id=126495
2496
2497         Reviewed by Timothy Hatcher.
2498
2499         Added titles to all popovers except for pending revisions one, which I would like
2500         to improve more (probably add an ETA).
2501
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2503         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
2504         adding a title to base class.
2505
2506         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2507         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
2508         a divider to a separate function.
2509         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
2510         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
2511         title from above function.
2512         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
2513         variable to "content" to match all other code.
2514         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
2515         (BuildbotQueueView.prototype._addDividerToPopover): Added.
2516
2517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2518         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
2519         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
2520         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
2521
2522         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2523
2524 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2525
2526         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
2527         https://bugs.webkit.org/show_bug.cgi?id=126472
2528
2529         Reviewed by Timothy Hatcher.
2530
2531         Added a delay when quickly switching to a different popover, making it easier to
2532         move mouse pointer from active element to its popover without accidentally opening
2533         a different popover.
2534
2535         Used this code to add a delay before creating a popover. This doesn't change UI
2536         behavior, as there was alerady a delay before it became visible, but it avoids
2537         flooding buildbot server with http requests when quickly moving the mouse over
2538         dashboard page.
2539
2540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
2541         Fixed a case where popover could get stuck. If content was updated while fade-out
2542         transition was already in place, the transition was removed for no good reason.
2543
2544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2545         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
2546
2547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
2548         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
2549         popover delay from 1s to 800ms.
2550
2551 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2552
2553         Improve display of failed builds at build.webkit.org/dashboard
2554         https://bugs.webkit.org/show_bug.cgi?id=126542
2555         <rdar://problem/15753550>
2556
2557         Reviewed by Timothy Hatcher.
2558
2559         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2560         Instead of hardcoding step name, look for the first step that failed.
2561         While at it, added a popover with more links. There are multiple, and it's good
2562         to have a choice of which one to look at in each situation.
2563
2564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2565         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
2566         of having failed. Many iterations are interrupted for whatever reason internal to
2567         Buildbot, and these are suppoed to be orange, not red.
2568         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
2569         not only WillRetry ones.
2570         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
2571         actually failed, more likely indicating a problem with code base.
2572         (BuildbotIteration.prototype.get firstFailedStepName):
2573         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
2574         (BuildbotIteration.prototype.get failureLogs): Ditto.
2575         (BuildbotIteration.prototype.update): Store complete results for the failed step.
2576         Not every failure stops the iteration, so we could have multiple failed steps,
2577         but let's see if seeing just the first one will be enough.
2578
2579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2580         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
2581         terms of successful iterations.
2582         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
2583
2584         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2585         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
2586         terms of successful iterations.
2587
2588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2589         Removed code to create a path to build output, we now take it from results JSON.
2590
2591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2592         Added styles for the new popover.
2593
2594 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2595
2596         defined constants should use all uppercase names with words separated by underscores.
2597         https://bugs.webkit.org/show_bug.cgi?id=126055
2598
2599         Reviewed by Alexey Proskuryakov.
2600
2601         * Scripts/webkitpy/style/checkers/cpp.py:
2602         (check_style):
2603         (CppChecker):
2604         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2605         (WebKitStyleTest.test_define_constants):
2606
2607 2014-01-07  Brian Holt  <brian.holt@samsung.com>
2608
2609         Unreviewed. Add myself as a committer.
2610
2611         * Scripts/webkitpy/common/config/contributors.json:
2612
2613 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2614
2615         Remove the WinCE buildbot from build.webkit.org
2616         https://bugs.webkit.org/show_bug.cgi?id=126517
2617
2618         Reviewed by Alexey Proskuryakov.
2619
2620         * BuildSlaveSupport/build.webkit.org-config/config.json:
2621         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2622         (appendCustomBuildFlags):
2623
2624 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2625
2626         [EFL] Change ATK version to 2.11.4
2627         https://bugs.webkit.org/show_bug.cgi?id=126573
2628
2629         Reviewed by Gyuyoung Kim.
2630
2631         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
2632
2633         * efl/jhbuild.modules:
2634
2635 2014-01-07  Alberto Garcia  <berto@igalia.com>
2636
2637         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
2638         https://bugs.webkit.org/show_bug.cgi?id=117275
2639
2640         Reviewed by Carlos Garcia Campos.
2641
2642         If we are not using the internal jhbuild we must not use the
2643         jhbuild-wrapper script, else it will try to download and install
2644         it.
2645
2646         * Scripts/run-launcher:
2647
2648 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2649
2650         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
2651         https://bugs.webkit.org/show_bug.cgi?id=125855
2652
2653         Reviewed by Mario Sanchez Prada.
2654
2655         Added new function isIndeterminate for testing aria-checked mixed state.
2656         I provided respective, but empty function in mac port. Mac testing it differently.
2657
2658         * DumpRenderTree/AccessibilityUIElement.cpp:
2659         (getIsIndeterminate):
2660         (AccessibilityUIElement::getJSClass):
2661         * DumpRenderTree/AccessibilityUIElement.h:
2662         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2663         (AccessibilityUIElement::isIndeterminate):
2664         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
2665         (AccessibilityUIElement::isIndeterminate):
2666         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
2667         (AccessibilityUIElement::isIndeterminate):
2668         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
2669         (AccessibilityUIElement::isIndeterminate):
2670         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2671         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2672         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2673         (WTR::AccessibilityUIElement::isIndeterminate):
2674         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2675         (WTR::AccessibilityUIElement::isIndeterminate):
2676
2677 2014-01-06  Mark Rowe  <mrowe@apple.com>
2678
2679         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
2680
2681         Reviewed by Ryosuke Niwa.
2682
2683         * DumpRenderTree/mac/DumpRenderTree.mm:
2684         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
2685         with a single case. This avoids the potential for warnings about unhandled cases.
2686         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2687         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
2688
2689 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2690
2691         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
2692         https://bugs.webkit.org/show_bug.cgi?id=126342
2693
2694         Reviewed by Gustavo Noronha Silva.
2695
2696         * CMakeLists.txt: Include the new unit tests subdirectories.
2697         * Scripts/run-gtk-tests: Update to refer to the new build locations.
2698         * Scripts/webkitpy/style/checker.py: Update the style checker.
2699         * Scripts/webkitpy/style/checker_unittest.py:
2700         * TestWebKitAPI/GNUmakefile.am:
2701         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
2702         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
2703         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
2704         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
2705         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
2706         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
2707         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
2708         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
2709         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
2710         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
2711         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
2712         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
2713         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
2714         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
2715         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
2716         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
2717         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
2718         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
2719         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
2720         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
2721         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
2722         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
2723         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
2724         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
2725         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
2726         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
2727         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
2728         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
2729         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
2730         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
2731         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
2732         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
2733         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
2734         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
2735         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
2736         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
2737         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
2738         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
2739         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
2740         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
2741         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
2742         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
2743         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
2744         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
2745         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
2746         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
2747         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
2748         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
2749         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
2750         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
2751         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
2752         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
2753         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
2754         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
2755         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
2756         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
2757         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
2758         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
2759         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
2760         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
2761         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
2762         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
2763         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
2764         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
2765         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
2766         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
2767         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
2768         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
2769         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
2770         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
2771         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
2772         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
2773         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
2774         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
2775         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
2776         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
2777         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
2778         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
2779         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
2780         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
2781         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
2782         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
2783         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
2784         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
2785         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
2786         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
2787         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
2788
2789 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
2790
2791         Gtk and Efl API test results confuse the dashboard
2792         https://bugs.webkit.org/show_bug.cgi?id=126535
2793
2794         Reviewed by Tim Horton.
2795
2796         Added "API tests" step as "platform api tests".
2797
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2799         (Buildbot.prototype.platformAPITestResultsURLForIteration):
2800         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2801         (BuildbotIteration):
2802         (BuildbotIteration.prototype.update):
2803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2804         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2805         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2806
2807 2014-01-06  Tim Horton  <timothy_horton@apple.com>
2808
2809         build.webkit.org/dashboard should still function if localStorage is disabled
2810         https://bugs.webkit.org/show_bug.cgi?id=126511
2811
2812         Reviewed by Alexey Proskuryakov.
2813
2814         If localStorage is disabled, we should carry on with a warning.
2815
2816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2817         Don't show the gear if localStorage isn't working.
2818
2819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2820         (QueueView.prototype._updateHiddenState):
2821         Bail if localStorage isn't working.
2822
2823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2824         (Settings.prototype.available):
2825
2826 2014-01-02  Roger Fong  <roger_fong@apple.com>
2827
2828         Set VSINSTALLDIR in win ews start script.
2829         https://bugs.webkit.org/show_bug.cgi?id=126407
2830
2831         Reviewed by Brent Fulgham.
2832
2833         * EWSTools/start-queue-win.sh:
2834
2835 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
2836
2837         Adding myself as a reviewer.
2838
2839         Unreviewed.
2840
2841         * Scripts/webkitpy/common/config/contributors.json:
2842
2843 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
2844
2845         Unreviewed. Unbreaking JSC tests after r161328.
2846
2847         * Scripts/webkitdirs.pm:
2848         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
2849         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
2850
2851 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
2852
2853         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
2854         https://bugs.webkit.org/show_bug.cgi?id=126212
2855
2856         Reviewed by Daniel Bates.
2857
2858         Allow building the GTK+ cmake port with --gtkcmake.
2859
2860         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
2861         when appropriate. Skip the autotoos path when isGtkAutotools is false.
2862         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
2863         Add isGtk which checks isGtkCMake || isGtkAutotools
2864         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
2865         (argumentsForConfiguration): use --gtkcmake when appropriate.
2866         (jscProductDir): Look in the CMake directory when appropriate.
2867         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
2868         (determineIsGtkCMake): Added.
2869         (isGtkCMake): Added.
2870         (isGtkAutotools): Renamed from isGtk.
2871         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
2872         (determineIsGtkAutotools): Renamed from determineIsGtk.
2873         (cmakeBasedPortName): Added a GTK+ path.
2874
2875 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
2876
2877         [GTK] [CMake] Fix the video and audio build
2878         https://bugs.webkit.org/show_bug.cgi?id=126464
2879
2880         Reviewed by Philippe Normand.
2881
2882         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
2883
2884 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2885
2886         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
2887         https://bugs.webkit.org/show_bug.cgi?id=126467
2888
2889         Reviewed by Geoffrey Garen.
2890
2891         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
2892         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
2893         pointer, or to tap.
2894
2895 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2896
2897         build.webkit.org/dashboard says "failed build" even if it's another step that failed
2898         https://bugs.webkit.org/show_bug.cgi?id=126461
2899
2900         Reviewed by Geoffrey Garen.
2901
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2903         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
2904         build page if it's not the compilation that failed. Use text from buildbot for description.
2905         Show a yellow icon if it's a different kind of failure.
2906
2907         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2908         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
2909
2910 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
2911
2912         setup-git-clone fails to get email address from git
2913         https://bugs.webkit.org/show_bug.cgi?id=126446
2914
2915         Reviewed by Ryosuke Niwa.
2916
2917         The setup-git-clone command fails to get an email address from git
2918         because of a bug in VCSUtils. This patch fixes that bug, and also
2919         makes it so that when VCSUtils fails for real because of a local
2920         misconfiguration, the error message is actually presented to the user
2921         of setup-git-clone.
2922
2923         * Scripts/VCSUtils.pm:
2924         (gitConfig): Call isGit() instead of accessing $isGit directly to make
2925             sure that $isGit is properly initialized.
2926         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2927         (SetupGitClone.execute): Pull out username and email acquistion to
2928             it's own method.
2929         (SetupGitClone._get_username_and_email): Catch the exception thrown
2930             when VCSUtils fails and print out the error message so that the
2931             user actually knows why the command failed.
2932
2933 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2934
2935         It feels too hard to get rid of a popover at build.webkit.org/dashboard
2936         https://bugs.webkit.org/show_bug.cgi?id=126451
2937
2938         Reviewed by Simon Fraser.
2939
2940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
2941         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
2942         when moving the mouse from an element to its popover.
2943
2944 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2945
2946         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
2947         https://bugs.webkit.org/show_bug.cgi?id=122181
2948
2949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2950         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
2951         popover.present signature change.
2952
2953 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
2954
2955         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
2956         https://bugs.webkit.org/show_bug.cgi?id=122181
2957
2958         Reviewed by Timothy Hatcher and Timothy Horton.
2959
2960         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
2961         JSONP). Dashboard will load them on demand.
2962
2963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2964         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
2965         and made it use a function from WebKitBuildbot that builds results directory path.
2966         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
2967         a URL for full_results.json.
2968         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
2969         a URL for a crash log.
2970
2971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2972         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
2973         the iteration.
2974
2975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
2976         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
2977         popover API (see below).
2978         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
2979
2980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2981         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
2982         for iterations that were interrupted (previously, they were displayed incorrectly,
2983         often as passes). Install popover trackers for failure bubbles for which we can currently
2984         display something useful.
2985         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
2986         a popover for layout test regressions when we have the data loaded on demand.
2987         We have test paths, special indicators for crashes/timeouts, and links to test history
2988         at flakiness dashboard.
2989         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
2990         the popover for layout test regressions. Just shows "Loading..." until the data is
2991         loaded.
2992         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
2993         types of failures if there are multiple. There is a lot of similarity with
2994         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
2995
2996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2997         Create a global test history object, which is used for links in layout test popover.
2998
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3000         Changed the API to be more like WebInspector again, allowing for changing content
3001         of an existing popover. As the size of a popover can change, making the mouse pointer
3002         enter it without a mousenter event, install a handler for mousewheel instead, and block
3003         document scrolling from this event handler when needed.
3004
3005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3006         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
3007         bubble element, making it possible to install a popover on it.
3008
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3010         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
3011
3012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3013         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
3014         building a complete results URL to only building one for root results path. This is
3015         the part that depends on specific buildbot installation, everything relative to it
3016         is the same.
3017
3018         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
3019         Build a path to test history page. In the future, we may consider adding code to
3020         load the data and display it inline.
3021
3022         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3023         Added styles for this new popover.
3024
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
3026         a new file, WebKitTestHistory.js.
3027
3028 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3029
3030         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
3031         https://bugs.webkit.org/show_bug.cgi?id=126430
3032
3033         Reviewed by Martin Robinson.
3034
3035         * Scripts/run-gtk-tests:
3036         (TestRunner._setup_testing_environment):
3037         * gtk/common.py: Use common.tests_library_build_path() instead.
3038         (tests_library_build_path): Helper funtion that returns the path
3039         where the tests libraries are built.
3040
3041 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
3042
3043         [CMake] Build TestWebKitAPI tests into a directory structure
3044         https://bugs.webkit.org/show_bug.cgi?id=126358
3045
3046         Reviewed by Gyuyoung Kim.
3047
3048         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
3049         is useful for keeping the "bin" directory tidy during building and will make it easier
3050         to integrate the CMake build into the existing WebKitGTK+ scripts.
3051
3052         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
3053         and make the names simpler now that the directory identifies what category the test is in.
3054
3055 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3056
3057         Provide a visual clue when element has a popover at build.webkit.org/dashboard
3058         https://bugs.webkit.org/show_bug.cgi?id=126281
3059
3060         Reviewed by Timothy Hatcher.
3061
3062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3063         (PopoverTracker): Add a class name to elements with popovers.
3064
3065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3066         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
3067         I might have broke that recently.
3068         (*:link): Show hand cursor over links.
3069         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
3070
3071         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3072         (.status-line .message .revision-number): Show text selection cursor on our only
3073         selectable text element.
3074         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
3075         a white shadow than with a dark one on hover.
3076
3077 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3078
3079         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
3080         https://bugs.webkit.org/show_bug.cgi?id=124652
3081
3082         Reviewed by Martin Robinson.
3083
3084         * MiniBrowser/gtk/BrowserWindow.c:
3085         (webViewDecidePolicy): Use the new API instead of
3086         webkit_web_view_can_show_mime_type().
3087
3088 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3089
3090         REGRESSION(r160304): [GTK] Disable libtool fast install
3091         https://bugs.webkit.org/show_bug.cgi?id=126381
3092
3093         Reviewed by Martin Robinson.
3094
3095         Remove -no-fast-install ld flag since fast install is now disabled
3096         globally.
3097
3098         * GNUmakefile.am:
3099         * GtkLauncher/GNUmakefile.am:
3100         * MiniBrowser/gtk/GNUmakefile.am:
3101         * TestWebKitAPI/GNUmakefile.am:
3102         * WebKitTestRunner/GNUmakefile.am:
3103
3104 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
3105
3106         Unreviewed. Add myself to EFL and related watch lists.
3107
3108         * Scripts/webkitpy/common/config/watchlist:
3109
3110 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
3111
3112         [GTK] fixing ycm_extra_conf.py file
3113         https://bugs.webkit.org/show_bug.cgi?id=126371
3114
3115         It's an attempt to fix three problems with the current ycm_extra_conf file.
3116         The current implementation assumes that it's a symlink, which is not true.
3117         Usually python creates a pyc file, and this is what you get in __file__.
3118         the .pyc is not a symlink, and the current implementation doesn't work
3119         if that's the case.
3120
3121         It also assumes that the user is in the root folder.
3122         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
3123
3124         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
3125         exception since "flag" doesn't exists.
3126
3127         All those things were fixed.
3128
3129         Reviewed by Martin Robinson.
3130
3131         * gtk/ycm_extra_conf.py:
3132         (transform_relative_paths_to_absolute_paths):
3133
3134 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3135
3136         Bindings tests results links are broken at build.webkit.org/dashboard
3137         https://bugs.webkit.org/show_bug.cgi?id=126402
3138
3139         Reviewed by Tim Horton.
3140
3141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3142         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
3143         since the beginning.
3144
3145 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3146
3147         "+" is very confusing at http://build.webkit.org/dashboard
3148         https://bugs.webkit.org/show_bug.cgi?id=126400
3149
3150         Reviewed by Tim Horton.
3151
3152         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3153         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
3154         source and internal counts separately, simply add them. One can always open a popover
3155         for more detail.
3156
3157 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3158
3159         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3160         https://bugs.webkit.org/show_bug.cgi?id=126391
3161
3162         Reviewed by Dan Bernstein.
3163
3164         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
3165         One can request credentials use via Initialization.js.
3166
3167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3168         (Trac):
3169         (Trac.prototype.update):
3170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3171         (loadXML):
3172
3173 2014-01-02  Commit Queue  <commit-queue@webkit.org>
3174
3175         Unreviewed, rolling out r160846.
3176         http://trac.webkit.org/changeset/160846
3177         https://bugs.webkit.org/show_bug.cgi?id=126395
3178
3179         Breaks build scripts for Windows when Visual Studio is not
3180         installed in Program Files (Requested by rfong on #webkit).
3181
3182         * Scripts/webkitdirs.pm:
3183         (visualStudioInstallDir):
3184
3185 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
3186
3187         [GTK] [CMake] run-gtk-tests should run with the cmake build
3188         https://bugs.webkit.org/show_bug.cgi?id=126341
3189
3190         Reviewed by Carlos Garcia Campos.
3191
3192         * Scripts/run-gtk-tests:
3193         (TestRunner.__init__): Use the new calling conventions for the common script.
3194         (TestRunner._setup_testing_environment): Ditto.
3195         * gtk/common.py:
3196         (set_build_types): Added set_build_types, to avoid having build_type arguments
3197         for all functions in common.
3198         (binary_build_path): Added this function which gets the path to the built binaries.
3199         (get_build_path): Removed the build_types argument.
3200         (build_path): Removed the build_types argument and call get_build_path directly now.
3201
3202 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3203
3204         https://bugs.webkit.org/show_bug.cgi?id=126391
3205         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3206
3207         Rubber-stamped by Dan Bernstein.
3208
3209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3210         (loadXML): Quick and dirty fix, with a FIXME.
3211
3212 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
3213
3214         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
3215         https://bugs.webkit.org/show_bug.cgi?id=126349
3216
3217         Reviewed by Carlos Garcia Campos.
3218
3219         All CMake ports use "libTestNetscapePlugin," so choosing the same
3220         name in the autotools port will make the transition easier.
3221
3222         * GNUmakefile.am: Rename the plugin library.
3223
3224 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
3225
3226         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
3227         https://bugs.webkit.org/show_bug.cgi?id=126354
3228
3229         Reviewed by Carlos Garcia Campos.
3230
3231         The latest visited site for backward history should be placed on the top of a history stack
3232         as a common behavior. However currently its order is reverse.
3233
3234         * MiniBrowser/gtk/BrowserWindow.c:
3235         (browserWindowUpdateNavigationActions):
3236
3237 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
3238
3239         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
3240         https://bugs.webkit.org/show_bug.cgi?id=126297
3241
3242         Reviewed by Philippe Normand.
3243
3244         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
3245         (TestRunner): Ditto.
3246         (TestRunner._run_test): Ditto.
3247
3248 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
3249
3250         full_results.json should distinguish unexpected failures from expected ones
3251         https://bugs.webkit.org/show_bug.cgi?id=126300
3252
3253         Reviewed by Timothy Hatcher.
3254
3255         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3256         (summarize_results): Add "report" element to JSON, which tells the consumer how
3257         this result was counted for summary.
3258
3259         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3260         Updated results to include the new element.
3261
3262         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3263         (print_unexpected_results): Added a comment pointing to another place that
3264         summarizes results, and should stay in sync.
3265
3266 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
3267
3268         Replace remaning CoreIPC namespace to IPC
3269         https://bugs.webkit.org/show_bug.cgi?id=126305
3270
3271         Reviewed by Anders Carlsson.
3272
3273         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3274         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
3275         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3276         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
3277
3278 2013-12-30  Brendan Long  <self@brendanlong.com>
3279
3280         Add myself to the committers list.
3281
3282         Unreviewed.
3283
3284         * Scripts/webkitpy/common/config/contributors.json:
3285
3286 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3287
3288         [GTK] Split WebKit2APITests/TestWebKitWebView
3289         https://bugs.webkit.org/show_bug.cgi?id=126284
3290
3291         Reviewed by Philippe Normand.
3292
3293         Skip only WebKitWebView/mouse-target and all TestAuthentication
3294         tests that are timing out when running under xvfb.
3295
3296         * Scripts/run-gtk-tests:
3297         (TestRunner):
3298
3299 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3300
3301         [EFL][WK2] Disable geolocation API test
3302         https://bugs.webkit.org/show_bug.cgi?id=125851
3303
3304         Reviewed by Gyuyoung Kim.
3305
3306         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
3307
3308         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
3309
3310 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
3311
3312         [EFL] Remove ewk_view_tiled
3313         https://bugs.webkit.org/show_bug.cgi?id=125961
3314
3315         Reviewed by Gyuyoung Kim.
3316
3317         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3318         (shouldUseTiledBackingStore):
3319         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
3320         instead of switching ewk_view_tiled.
3321         (DumpRenderTreeChrome::createView):
3322         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3323         (drtViewAdd):
3324         * EWebLauncher/main.c: Removed ewk_view_tiled option.
3325         (windowCreate):
3326         (parseUserArguments):
3327
3328 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3329
3330         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
3331         https://bugs.webkit.org/show_bug.cgi?id=126278
3332
3333         Reviewed by Timothy Hatcher.
3334
3335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3336         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
3337         as StatusLineView message element has extra padding, and doesn't fit the text snugly.
3338         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
3339
3340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3341         (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
3342
3343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3344         Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
3345
3346 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3347
3348         Interrupted test runs should not count at build.webkit.org/dashboard
3349         https://bugs.webkit.org/show_bug.cgi?id=126279
3350
3351         Reviewed by Timothy Hatcher.
3352
3353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3354         (BuildbotIteration.prototype.get productive):
3355         (BuildbotIteration.prototype.get previousProductiveIteration): Replaced previous with
3356         this accessor to skips iterations that don't have relevant data. We still want to
3357         display them, but revision ranges should not be affected.
3358         (BuildbotIteration.prototype.update): Record whether the iteration was up for retry.
3359
3360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3361         Use latest productive iteration instead of latest iteration for pending revision
3362         count and popovers.
3363
3364 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3365
3366         Please display (and link to) revision ranges at build.webkit.org/dashboard
3367         https://bugs.webkit.org/show_bug.cgi?id=122187
3368
3369         Reviewed by Timothy Hatcher.
3370
3371         Added popovers for revision numbers. Removed direct links, because they were misleading -
3372         a test run covers a revision range, not just the latest revision. This also makes
3373         selecting a revision for copy easier.
3374
3375         All revision numbers have the popovers for consistency, although they are most useful
3376         for iterations that are not the last ones in a view, because the content is a delta
3377         from previous iteration.
3378
3379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3380         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
3381         revisionLinksForIteration() is now named revisionContentForIteration().
3382
3383         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3384         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3385         Ditto.
3386
3387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3388         (BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
3389
3390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3391         Refactored to support the new popover variation. Replaced revisionLinksForIteration()
3392         with a function that builds an element with popover.
3393
3394         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3395         Changed to take a function for popover presentation instead of delegate object.
3396         We only need one delegate function, and it's easier to have multiple popovers per view class
3397         this way.
3398
3399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3400         Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
3401
3402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3403         Renamed pending-commits-popover class to commit-history-popover.
3404
3405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3406         (.status-line .message .revision-number): Added a rule for revision numbers.
3407
3408 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3409
3410         Please display information about pending runs in build.webkit.org/dashboard
3411         https://bugs.webkit.org/show_bug.cgi?id=122180
3412
3413         Reviewed by Timothy Hatcher.
3414
3415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3416         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Added a semicolon at the end of a line.
3417
3418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3419         (BuildbotQueueView.prototype._latestFinishedIteration): Factored out of _appendPendingRevisionCount.
3420         (BuildbotQueueView.prototype._appendPendingRevisionCount): Install a popover tracker over the element.
3421         (BuildbotQueueView.prototype.lineForCommit): Build an element for a particular commit ot be shown in popover.
3422         (BuildbotQueueView.prototype.presentPopoverForElement): Build and show popover content when PopoverTracker
3423         asks us to.
3424
3425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Geometry.js: Added.
3426         Taken from WebInspector with minimal changes:
3427         - Changed root name from WebInspector to Dashboard.
3428         - Removed some unused functionality.
3429         - Added Rect.containsPoint.
3430
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js: Added.
3432         Popover has extensive changes compared to WebInspector version, only drawing code is the same:
3433         - Fixed to work in scrollable pages - WebInspector version assumes that window
3434         and document coordinates are the same, and also erroneously dismisses a scrollable
3435         popover if scrolling cascades out of it after reaching a bound.
3436         - Simplified API and implementation to Dashboard needs, it is no longer possible to
3437         change content of an existing popover.
3438         - Rewrote visibility tracking to be more complete, and not rely on external tracker
3439         object so much.
3440         - Added code to flash scroll bars when showing a scrollable popover.
3441
3442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js: Added.
3443         Objects of this class show and hide popovers as appropriate for registered active elements.
3444
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3446         (StatusLineView.prototype.get messageElement): Added an accessor, so that we could
3447         install a popover on message element. It's the only visible element in pending commit
3448         line, but the line has different bounds, so we can't install a popover on it (it
3449         would be incorrectly positioned if we did).
3450
3451         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3452         (Trac.prototype._convertCommitInfoElementToObject):
3453         - Some trac installations report author in a different element, updated to support that.
3454         - Changed to parse title out of description, because trac titles are ugly. Also,
3455         we get a nice HTML with links from the description.
3456
3457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3458         (Node.prototype.isAncestor): Copied from Web Inspector, only changing the form for
3459         consistency with the rest of this file (add a property on prototype with assignment
3460         instead of using Object.defineProperty).
3461         (Node.prototype.isDescendant): Ditto.
3462         (Node.prototype.isSelfOrAncestor): Ditto.
3463         (Node.prototype.isSelfOrDescendant): Ditto.
3464         (DOMTokenList.prototype.contains): Ditto.
3465
3466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css: Added.
3467         Like JS counterpart, mostly lifted from Web Inspector.
3468
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3470         Added style rules for pending commits popover.
3471
3472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3473         (.status-line.no-bubble .message): Changed to display:inline-block, so that it fits
3474         to content, and we can show the popover in a correct place.
3475
3476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added new files.
3477
3478 2013-12-27  Gavin Barraclough  <barraclough@apple.com>
3479
3480         Merge PageVisibilityState & ViewState::IsVisible in WebKit2
3481         https://bugs.webkit.org/show_bug.cgi?id=126214
3482
3483         Reviewed by Alexey Proskuryakov.
3484
3485         WebKit2 redundantly tracks the visibility of the view through two mechanisms - the visibility
3486         state, and the view state. Remove visibility state from the WebKit2 layer. The visibility
3487         state also tracks the prerender state - so split this out and handle it separately (a change
3488         we should make in WebCore, too).
3489
3490         Tools - WebKit2 no longer (poorly) supports a fake visibility state, so to test the page
3491         visibility mechanisms we should actually be changing characteristics of the view that will
3492         be detected by WebKit2 as a visibility change. This affects three things:
3493             1) On setVisibilityState WebKitTestRunner must actually change visibility of the view.
3494             2) The 'PageVisibilityState' test in the API tests is useless (as evidenced by the fact
3495                that page visibility has been broken in WebKit2 for a couple of months, and didn't
3496                catch this fact). Removed in favour of:
3497             3) 'PageVisibilityStateWithWindowChanges' - this is the good stuff. This actually tests
3498                the visibility mechanism. Beef this test up by adding coverage for: a) the prerender
3499             state, b) document.hidden, and c) too many state change notifications (it already looks
3500             for too few).
3501
3502         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3503         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Removed.
3504             - Removed PageVisibilityState - this test was ineffective, API no longer supports this
3505               test, and behaviour is covered by PageVisibilityStateWithWindowChanges.
3506         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3507         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3508         (runJavaScriptAlert):
3509             - Add checking for too many calls to the alert.
3510         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::setPrerender):
3511             - Added methods to set visibility to prerender.
3512         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3513             - Added checking of 'document.hidden'.
3514         * WebKitTestRunner/TestController.cpp:
3515         (WTR::TestController::setVisibilityState):
3516         * WebKitTestRunner/TestController.h:
3517         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3518         (WTR::TestController::setHidden):
3519         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3520         (WTR::TestController::setHidden):
3521         * WebKitTestRunner/mac/TestControllerMac.mm:
3522         (WTR::TestController::setHidden):
3523             - Add setHidden method; call this from setVisibilityState.
3524
3525 2013-12-27  Alexey Proskuryakov  <ap@apple.com>
3526
3527         Display EWS status on bot watcher's dashboard
3528         https://bugs.webkit.org/show_bug.cgi?id=126224
3529
3530         Silence spurious exceptions, no visible behavior change.
3531
3532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
3533         (EWSQueue.prototype.update): Removed code that was only needed for an experimental
3534         feature that wasn't landed.
3535
3536 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
3537
3538         Display EWS status on bot watcher's dashboard
3539         https://bugs.webkit.org/show_bug.cgi?id=126224
3540
3541         Reviewed by Timothy Hatcher.
3542
3543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added.
3545         Moved platform definitions out of Buildbot.js, as they are also needed for EWS.
3546
3547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: