Compile and link with CMake on Mac
[WebKit-https.git] / Tools / ChangeLog
1 2015-10-28  Alex Christensen  <achristensen@webkit.org>
2
3         Compile and link with CMake on Mac
4         https://bugs.webkit.org/show_bug.cgi?id=150632
5
6         Reviewed by Tim Horton.
7
8         * TestWebKitAPI/PlatformMac.cmake:
9
10 2015-10-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
11
12         Unreviewed.
13
14         * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
15
16 2015-10-28  Per Arne Vollan  <peavo@outlook.com>
17
18         Add WinCairo to list of ports in run-webkit-tests.
19         https://bugs.webkit.org/show_bug.cgi?id=150625
20
21         Reviewed by Brent Fulgham.
22
23         * Scripts/webkitpy/common/config/ports.py:
24         (DeprecatedPort.port):
25         (WinPort.run_webkit_tests_command):
26         (WinCairoPort):
27         (GtkWK2Port):
28         * Scripts/webkitpy/port/factory.py:
29         (PortFactory):
30         * Scripts/webkitpy/port/win.py:
31         (WinPort.find_system_pid):
32         (WinCairoPort):
33
34 2015-10-27  Alexey Proskuryakov  <ap@apple.com>
35
36         WebKitTestRunner leaks in generateWhitelist()
37         https://bugs.webkit.org/show_bug.cgi?id=150563
38
39         Reviewed by Andreas Kling.
40
41         * WebKitTestRunner/mac/TestControllerMac.mm:
42         (WTR::generateWhitelist):
43
44 2015-10-27  Anders Carlsson  <andersca@apple.com>
45
46         Add an API test for _WKRemoteObjectRegistry
47         https://bugs.webkit.org/show_bug.cgi?id=150597
48
49         Reviewed by Andreas Kling.
50
51         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
52         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
53         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
54         (TEST):
55         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
56         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
57         (-[RemoteObjectRegistryPlugIn sayHello:]):
58
59 2015-10-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
60
61         Add myself to the reviewers list
62         https://bugs.webkit.org/show_bug.cgi?id=150581
63
64         Unreviewed.
65
66         * Scripts/webkitpy/common/config/contributors.json:
67
68 2015-10-26  Ryan Haddad  <ryanhaddad@apple.com>
69
70         Adding myself to contributors.json
71
72         * Scripts/webkitpy/common/config/contributors.json:
73
74 2015-10-26  Tim Horton  <timothy_horton@apple.com>
75
76         Don't expose the whitelist/blacklist in _WKUserStyleSheet
77         https://bugs.webkit.org/show_bug.cgi?id=150566
78
79         Reviewed by Anders Carlsson.
80
81         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
82         (TEST):
83
84 2015-10-26  Philippe Normand  <pnormand@igalia.com>
85
86         Unreviewed, rolling out r191576.
87
88         broke
89
90         Reverted changeset:
91
92         "[GStreamer] Bump internal jhbuild versions to 1.6.0"
93         https://bugs.webkit.org/show_bug.cgi?id=149594
94         http://trac.webkit.org/changeset/191576
95
96 2015-10-26  ChangSeok Oh  <changseok.oh@collabora.com>
97
98         [GStreamer] Bump internal jhbuild versions to 1.6.0
99         https://bugs.webkit.org/show_bug.cgi?id=149594
100
101         Reviewed by Philippe Normand.
102
103         Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
104         useful so they are removed accordingly.
105
106         * gtk/jhbuild.modules:
107         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
108         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
109         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
110
111 2015-10-25  Alexey Proskuryakov  <ap@apple.com>
112
113         API tests fail on El Capitan after r191543
114         https://bugs.webkit.org/show_bug.cgi?id=150547
115
116         Reviewed by Dan Bernstein.
117
118         * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
119
120 2015-10-24  Tim Horton  <timothy_horton@apple.com>
121
122         Add a way to add user style sheets to WKUserContentController
123         https://bugs.webkit.org/show_bug.cgi?id=150531
124         <rdar://problem/23191691>
125
126         Reviewed by Darin Adler.
127
128         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
129         (TEST):
130
131 2015-10-24  Tim Horton  <timothy_horton@apple.com>
132
133         Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
134         https://bugs.webkit.org/show_bug.cgi?id=150525
135
136         Reviewed by Darin Adler.
137
138         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
139         (TEST):
140         Test the various new keys.
141
142 2015-10-24  Frederic Wang  <fred.wang@free.fr>
143
144         check-webkit-style complains about missing operator whitespace inside character literal
145         https://bugs.webkit.org/show_bug.cgi?id=150396
146
147         Reviewed by Darin Adler.
148
149         * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
150         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
151         (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
152
153 2015-10-23  Michael Saboff  <msaboff@apple.com>
154
155         REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
156         https://bugs.webkit.org/show_bug.cgi?id=150513
157
158         Reviewed by Saam Barati.
159
160         Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
161
162         * DumpRenderTree/TestRunner.cpp:
163         (simulateWebNotificationClickCallback):
164         (failNextCodeBlock):
165         (numberOfDFGCompiles):
166         (TestRunner::staticFunctions):
167         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
168         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
169         (WTR::TestRunner::setBlockAllPlugins):
170         (WTR::TestRunner::failNextCodeBlock):
171         (WTR::TestRunner::numberOfDFGCompiles):
172         * WebKitTestRunner/InjectedBundle/TestRunner.h:
173
174 2015-10-23  Anders Carlsson  <andersca@apple.com>
175
176         Simplify the WebKitLegacy menu conversion code
177         https://bugs.webkit.org/show_bug.cgi?id=150509
178
179         Reviewed by Andreas Kling.
180
181         Implement the context menu delegate method so we'll test that code path.
182
183         * MiniBrowser/mac/WK1BrowserWindowController.m:
184         (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
185
186 2015-10-23  Per Arne Vollan  <peavo@outlook.com>
187
188         [WinCairo] Improve test results for fast layouttests.
189         https://bugs.webkit.org/show_bug.cgi?id=150464
190
191         Reviewed by Alex Christensen.
192
193         Set custom device scale factor to 1.0.
194
195         * DumpRenderTree/win/DumpRenderTree.cpp:
196         (createWebViewAndOffscreenWindow):
197
198 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
199
200         [GTK] update-webkitgtk-libs should use mesa tarball
201
202         https://bugs.webkit.org/show_bug.cgi?id=150470
203
204         update-webkitgtk-libs downloads all build dependencies; in fixing
205         bug 148941 mesa was switched from ftp to git access.  Now an http
206         tarball is available, which is preferred over accessing via git.
207
208         Reviewed by Philippe Normand
209
210         * gtk/jhbuild.modules:
211         Mesa access changed to http tarball.
212
213 2015-10-22  Sam Weinig  <sam@webkit.org>
214
215         Navigations on the same host (but with different schemes and ports) should not trigger universal links
216         <rdar://problem/22811325>
217         https://bugs.webkit.org/show_bug.cgi?id=150481
218
219         Reviewed by Dan Bernstein.
220
221         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
222         Update test to test that navigations on the same host but with different schemes does not
223         trigger universal links, but that changes in the host do.
224
225 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
226
227         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
228         https://bugs.webkit.org/show_bug.cgi?id=150428
229
230         Reviewed by Antti Koivisto.
231
232         Added a regression test using WebKit API test.
233
234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
235         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
236         (TestWebKitAPI::didFinishLoadForFrame):
237         (TestWebKitAPI::TEST):
238
239 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
240
241         Unreviewed. Fix GTK+ build after r191423.
242
243         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
244
245         * gtk/webkitdom.py:
246         (WebKitDOMDocGenerator):
247
248 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
249
250         [Win][EFL][GTK] webkitpy test failed after r191374.
251         https://bugs.webkit.org/show_bug.cgi?id=150433
252
253         Reviewed by Alexey Proskuryakov.
254
255         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
256         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
257         (CrashLogsTest.test_find_log_darwin): Same.
258
259 2015-10-21  Brian Burg  <bburg@apple.com>
260
261         Unreviewed, update watchlist for JS builtins.
262
263         Add a category for JS builtins code generator, similar to other generators.
264
265         Add a nag message to rebaseline builtins generator tests when touching
266         code generator files in Source/JavaScriptCore/Scripts/builtins/.
267
268         * Scripts/webkitpy/common/config/watchlist:
269
270 2015-10-21  Brian Burg  <bburg@apple.com>
271
272         Restructure generate-js-bindings script to be modular and testable
273         https://bugs.webkit.org/show_bug.cgi?id=149929
274
275         Reviewed by Alex Christensen.
276
277         Add a stub shell script and basic webkitpy support for running builtins
278         generator tests.
279
280         * Scripts/run-builtins-generator-tests: Added.
281         (main):
282         * Scripts/webkitpy/codegen/__init__.py: Added.
283         * Scripts/webkitpy/codegen/main.py: Added.
284
285             The only interesting difference here from the inspector protocol
286             generator equivalent is that this implementation decodes the target
287             framework and output mode (combined or separate) from the test's file name.
288
289         (BuiltinsGeneratorTests):
290         (BuiltinsGeneratorTests.__init__):
291         (BuiltinsGeneratorTests.generate_from_js_builtins):
292         (BuiltinsGeneratorTests.write_error_file):
293         (BuiltinsGeneratorTests.detect_changes):
294         (BuiltinsGeneratorTests.run_tests):
295         (BuiltinsGeneratorTests.main):
296
297 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
298
299         run-webkit-tests does not copy all crash logs for layout test failures on Mac
300         https://bugs.webkit.org/show_bug.cgi?id=150407
301         <rdar://problem/22239750>
302
303         Reviewed by Alexey Proskuryakov.
304
305         * Scripts/webkitpy/port/mac.py:
306         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
307         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
308         the log directory.
309         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
310         from log directory and merge them with the list of already crashed tests.
311
312 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
313
314         Failures in PutStackSinkingPhase should be less severe
315         https://bugs.webkit.org/show_bug.cgi?id=150400
316
317         Reviewed by Geoffrey Garen.
318
319         Add a test mode for no PutStackSinkingPhase.
320
321         * Scripts/run-jsc-stress-tests:
322
323 2015-10-21  Nan Wang  <n_wang@apple.com>
324
325         AX: Expose table size and cell indexes on iOS
326         https://bugs.webkit.org/show_bug.cgi?id=150366
327
328         Reviewed by Chris Fleizach.
329
330         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
331         (AccessibilityUIElement::rowCount):
332         (AccessibilityUIElement::columnCount):
333         (AccessibilityUIElement::indexInTable):
334         (AccessibilityUIElement::numberAttributeValue):
335         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
336         (WTR::AccessibilityUIElement::numberAttributeValue):
337         (WTR::AccessibilityUIElement::rowCount):
338         (WTR::AccessibilityUIElement::columnCount):
339         (WTR::AccessibilityUIElement::indexInTable):
340
341 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
342
343         W3C test importer should not import reference files as regular tests
344         https://bugs.webkit.org/show_bug.cgi?id=150331
345
346         Reviewed by Darin Adler.
347
348         Updated test_parser to return information that a file can be a referencefile or a manual test.
349         Updated test importer to skip those files.
350         Updated/Added test parser unit tests accordingly.
351
352         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
353         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
354         to mark these files as Skip, since they are not direct tests. 
355
356         * Scripts/webkitpy/w3c/test_importer.py:
357         (TestImporter.__init__):
358         (TestImporter.find_importable_tests):
359         (TestImporter.import_tests):
360         * Scripts/webkitpy/w3c/test_parser.py:
361         (TestParser.analyze_test):
362         * Scripts/webkitpy/w3c/test_parser_unittest.py:
363         (test_analyze_non_html_file):
364         (test_reference_test):
365
366 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
367
368         run-webkit-tests does not copy all crash logs for layout test failures on iOS
369         https://bugs.webkit.org/show_bug.cgi?id=150056
370         <rdar://problem/9280656>
371
372         Reviewed by Alexey Proskuryakov.
373
374         * Scripts/webkitpy/common/system/crashlogs.py:
375         (CrashLogs.find_all_logs): Generic method to find all crash logs.
376         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
377         It iterates through log directory and returns all the logs based on timestamp.
378         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
379         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
380         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
381         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
382         * Scripts/webkitpy/layout_tests/controllers/manager.py:
383         (Manager.run): Modified start_time to start counting before simulator launch
384         so that we can capture crashes during simualator launch.
385         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
386         any test which is not already marked as CRASH to the run_results.
387         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
388         (TestExpectationsModel.get_expectations_string): return PASS in case there
389         are no expectations defined for this test.
390         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
391         (summarize_results): Add other_crashes in a separte category in full_results.json.
392         * Scripts/webkitpy/port/ios.py:
393         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
394         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
395         from the log directory.
396         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
397         logs from log directory and merge them with the list of already crashed tests.
398
399 2015-10-20  Dana Burkart  <dburkart@apple.com>
400
401         Fix the build
402
403         Unreviewed.
404
405         My previous patch was missing a necessary space character.
406
407         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
408
409 2015-10-20  Dana Burkart  <dburkart@apple.com>
410
411         svn-apply fails to apply binary diffs in some cases
412         https://bugs.webkit.org/show_bug.cgi?id=64647
413
414         Reviewed by Daniel Bates.
415
416         * Scripts/VCSUtils.pm:
417         (decodeGitBinaryPatchDeltaSize): Modified.
418         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
419         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
420
421 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
422
423         Mac Debug EWS never finishes when there are failures
424         https://bugs.webkit.org/show_bug.cgi?id=150334
425
426         Reviewed by Daniel Bates.
427
428         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
429         * Scripts/webkitpy/tool/commands/queues.py:
430
431 2015-10-20  Philippe Normand  <pnormand@igalia.com>
432
433         [GTK] Enable OpenWebRTC test video/audio sources in tests
434
435         This is needed because we can't expect the buildbots to have
436         webcam/mic devices plugged in.
437
438         Rubber-stamped by Carlos Garcia Campos.
439
440         * Scripts/run-gtk-tests:
441         (TestRunner._setup_testing_environment):
442         * Scripts/webkitpy/port/gtk.py:
443         (GtkPort.setup_environ_for_server):
444
445 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
446
447         Rename the PICTURE_SIZES flag to CURRENTSRC
448         https://bugs.webkit.org/show_bug.cgi?id=150275
449
450         Reviewed by Dean Jackson.
451
452         * Scripts/webkitperl/FeatureList.pm:
453
454 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
455
456         Unreviewed, add myself to the committers list.
457
458         * Scripts/webkitpy/common/config/contributors.json:
459
460 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
461
462         Add new EWS queues to bot watcher's dashboard
463         https://bugs.webkit.org/show_bug.cgi?id=150297
464
465         Reviewed by Darin Adler.
466
467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
468         (BubbleQueueServer):
469
470 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
471
472         REGRESSION(r190262): User media unit test failures after r190262
473         https://bugs.webkit.org/show_bug.cgi?id=149580
474
475         Reviewed by Carlos Garcia Campos.
476
477         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
478         So we do not need to skip them anymore.
479
480         * Scripts/run-gtk-tests:
481         (TestRunner): Deleted.
482
483 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
484
485         Add historical addresses to contributors.json
486         https://bugs.webkit.org/show_bug.cgi?id=150227
487
488         Reviewed by Darin Adler.
489
490         * Scripts/webkitpy/common/config/contributors.json:
491
492 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
493
494         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
495         https://bugs.webkit.org/show_bug.cgi?id=150307
496
497         Reviewed by Brent Fulgham.
498
499         The DLL build rules have been changed to generate "{Name}Lib.DLL",
500         but these changes have not yet been applied to the Visual Studio builds.
501
502         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
503
504 2015-10-16  Andreas Kling  <akling@apple.com>
505
506         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
507         <https://webkit.org/b/150153>
508
509         Unreviewed.
510
511         Just use simple arrays of LChar and UChar for this test instead of creating String
512         objects and then getting the characters8()/characters16() from them, since that
513         doesn't guarantee null-termination (the bug.)
514
515         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
516         (TestWebKitAPI::TEST):
517         (TestWebKitAPI::build): Deleted.
518
519 2015-10-16  Tim Horton  <timothy_horton@apple.com>
520
521         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
522         https://bugs.webkit.org/show_bug.cgi?id=150255
523
524         Reviewed by Simon Fraser.
525
526         * Scripts/run-api-tests:
527         (runTest):
528         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
529         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
530         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
531         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
532         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
533         Don't set the layout size until after the load finishes and we're waiting
534         for the reply, so that there is no race between the new size coming in
535         and us waiting for it.
536
537 2015-10-16  Anders Carlsson  <andersca@apple.com>
538
539         WebEditingDelegate should be a formal protocol
540         https://bugs.webkit.org/show_bug.cgi?id=150254
541         <rdar://problem/23149847>
542
543         Reviewed by Dan Bernstein.
544
545         * DumpRenderTree/mac/EditingDelegate.h:
546         Conform to the WebEditingDelegate protocol.
547
548 2015-10-16  Tim Horton  <timothy_horton@apple.com>
549
550         Hook up autolayout intrinsic sizing for WKWebView
551         https://bugs.webkit.org/show_bug.cgi?id=150219
552         <rdar://problem/20016905>
553
554         Reviewed by Simon Fraser.
555
556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
557         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
558         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
559         (-[AutoLayoutWKWebView load:expectingContentSize:]):
560         (-[AutoLayoutWKWebView expectContentSizeChange:]):
561         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
562         (TEST):
563         Add a variety of tests, including one which catches the bug that
564         the WebCore part of this patch fixes.
565
566 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
567
568         Update the help message of --system-malloc
569         https://bugs.webkit.org/show_bug.cgi?id=150169
570
571         Reviewed by Geoffrey Garen.
572
573         * Scripts/webkitperl/FeatureList.pm:
574
575 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
576
577         Update ImportExpectations according currently imported wpt tests
578         https://bugs.webkit.org/show_bug.cgi?id=150158
579
580         Reviewed by Chris Dumez.
581
582         * Scripts/webkitpy/w3c/test_downloader.py:
583         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
584
585 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
586
587         Unreviewed, Update my email address.
588
589         * Scripts/webkitpy/common/config/contributors.json:
590
591 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
592
593         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
594         https://bugs.webkit.org/show_bug.cgi?id=84960
595
596         Reviewed by Žan Doberšek.
597
598         * Scripts/run-gtk-tests:
599         (TestRunner): Unskip tests using SessionState.
600         * TestWebKitAPI/PlatformGTK.cmake: Add
601         WKPageCopySessionStateWithFiltering test.
602
603 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
604
605         [GTK] Missing return value on TestWebExtensions.cpp:193
606         https://bugs.webkit.org/show_bug.cgi?id=149755
607
608         Unreviewed. Add missing return value.
609
610         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
611         (permissionRequestCallback):
612
613 2015-10-14  Andy Estes  <aestes@apple.com>
614
615         [iOS] build-dumprendertree does not build ImageDiff
616         https://bugs.webkit.org/show_bug.cgi?id=150152
617
618         Reviewed by Tim Horton.
619
620         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
621         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
622         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
623         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
624
625         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
626         fine on that platform, and results in ImageDiff being built.
627
628         * Scripts/build-dumprendertree:
629
630 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
631
632         [Win] Enforce launcher/library naming scheme
633         https://bugs.webkit.org/show_bug.cgi?id=150124
634
635         Reviewed by Alex Christensen.
636
637         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
638         * MiniBrowser/win/CMakeLists.txt: Ditto.
639         * TestWebKitAPI/PlatformWin.cmake: Ditto.
640         * win/DLLLauncher/DLLLauncherMain.cpp:
641         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
642         original {name}.dll.
643
644 2015-10-14  Andreas Kling  <akling@apple.com>
645
646         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
647         <https://webkit.org/b/150135>
648
649         Reviewed by Geoffrey Garen.
650
651         Add a new WTF API test that covers this issue.
652
653         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
654         (TestWebKitAPI::build):
655         (TestWebKitAPI::TEST):
656
657 2015-10-14  Alex Christensen  <achristensen@webkit.org>
658
659         Add SPI for reloading without content blockers
660         https://bugs.webkit.org/show_bug.cgi?id=150058
661         rdar://problem/22742222
662
663         Reviewed by Sam Weinig.
664
665         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
666         (WTR::TestController::cocoaResetStateToConsistentValues):
667         * WebKitTestRunner/mac/TestControllerMac.mm:
668         (WTR::TestController::platformConfigureViewForTest):
669
670 2015-10-14  Mark Lam  <mark.lam@apple.com>
671
672         Rename some JSC option names to be more uniform.
673         https://bugs.webkit.org/show_bug.cgi?id=150127
674
675         Reviewed by Geoffrey Garen.
676
677         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
678         * Scripts/run-jsc-stress-tests:
679
680 2015-10-14  Anders Carlsson  <andersca@apple.com>
681
682         Change the bundle app cache APIs to take a page
683         https://bugs.webkit.org/show_bug.cgi?id=150123
684
685         Reviewed by Sam Weinig.
686
687         Update APIs.
688
689         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
690         (WTR::InjectedBundle::beginTesting):
691         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
692         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
693         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
694         (WTR::TestRunner::clearAllApplicationCaches):
695         (WTR::TestRunner::clearApplicationCacheForOrigin):
696         (WTR::TestRunner::setAppCacheMaximumSize):
697         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
698         (WTR::TestRunner::originsWithApplicationCache):
699
700 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
701
702         Update web-platform-tests tools to the latest revision
703         https://bugs.webkit.org/show_bug.cgi?id=149645
704
705         Reviewed by Darin Adler.
706
707         Disabling git submodules information conversion to json install file for web-platform-tests.
708         Disabling related python unit tests.
709         The tools submodules contain submodules and the conversion tool does not support that yet.
710
711         Updating wpt launcher script to aling it with web-platform-test main script.
712
713         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
714         (main):
715         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
716         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
717         * Scripts/webkitpy/w3c/test_importer_unittest.py:
718         (TestImporterTest.test_submodules_generation):
719
720 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
721
722         More debug queue build fixing.
723
724         Preserve the build style in one more place. Changed mock build_style from "both"
725         to "release", as we don't support testing both debug and release.
726
727         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
728         (MockCommitQueue.archive_last_test_results):
729         (MockCommitQueue):
730         (MockCommitQueue.build_style):
731         (MockCommitQueue.did_pass_testing_ews):
732         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
733         (PatchAnalysisTask._test):
734         (PatchAnalysisTask._build_and_test_without_patch):
735         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
736         (EarlyWarningSystemTest._default_expected_logs):
737         * Scripts/webkitpy/tool/commands/queues_unittest.py:
738
739 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
740
741         More debug queue build fixing.
742
743         Add build_style argument to derived classes as well.
744
745         * Scripts/webkitpy/common/config/ports.py:
746         (MacPort):
747         (MacPort.run_webkit_tests_command):
748         (WinPort.run_bindings_tests_command):
749         (WinPort):
750         (WinPort.run_webkit_tests_command):
751         (GtkWK2Port.build_webkit_command):
752         (GtkWK2Port):
753         (GtkWK2Port.run_webkit_tests_command):
754
755 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
756
757         [iOS] Build fix
758
759         Unreviewed.
760
761         Mach-O section names are limited to 16 characters.
762
763         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
764         * DumpRenderTree/mac/DumpRenderTree.mm:
765         (activateFontsIOS):
766
767 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
768
769         Build fix for mac-debug EWS queue.
770
771         Unreviewed.
772
773         Pass --debug to run-webkit-tests.
774
775         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
776         will need to be substantially modified to work in EWS, so the dummy implementation
777         was not helpful.
778
779         * Scripts/webkitpy/common/config/ports.py:
780         (DeprecatedPort.run_javascriptcore_tests_command):
781         (DeprecatedPort):
782         (DeprecatedPort.run_webkit_tests_command):
783         (DeprecatedPort.run_python_unittests_command):
784         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
785         * Scripts/webkitpy/common/config/ports_mock.py:
786         (MockPort.run_javascriptcore_tests_command):
787         (MockPort):
788         (MockPort.run_webkit_tests_command):
789         (MockPort.run_bindings_tests_command):
790         (MockPort.run_webkit_unit_tests_command): Deleted.
791         * Scripts/webkitpy/tool/commands/download_unittest.py:
792         * Scripts/webkitpy/tool/steps/runtests.py:
793         (RunTests.run):
794         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
795         (RunTestsTest.test_webkit_run_unit_tests):
796         * Scripts/webkitpy/tool/steps/steps_unittest.py:
797         (StepsTest.test_runtests_args):
798
799 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
800
801         [Win] Generate Crash Traces
802         https://bugs.webkit.org/show_bug.cgi?id=150103
803
804         Reviewed by Daniel Bates.
805
806         We were using an exception filter to try to emit "#CRASHED" to stderr
807         when a test program crashed. However, the modern Python implementation
808         seems capable of recognizing crashes on its own. Furthermore, registering
809         the exception handler was preventing the JIT debugger (NTSD) from
810         automatically attaching to the crashing program, so we were not getting
811         crash traces.
812         
813         * DumpRenderTree/win/DumpRenderTree.cpp:
814         (main): Don't register an exception filter.
815         (exceptionFilter): Deleted.
816         * Scripts/webkitpy/common/system/crashlogs.py:
817         (CrashLogs): Add another regular expression to handle a second crash trace
818         syntax I encountered during testing.
819         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
820         try the new one. The PID found by the new expression is in hexadecimal, so
821         convert it to an integer before returning it.
822         * Scripts/webkitpy/port/driver.py:
823         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
824         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
825         check for "#CRASHED" after stripping off the EOL characters.
826         * Scripts/webkitpy/port/win.py:
827         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
828         invocation. This is apparently used to signal an event when the debugger is finished.
829
830 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
831
832         Mac Debug and 32-bit queues should be separate
833         https://bugs.webkit.org/show_bug.cgi?id=150092
834
835         Reviewed by Lucas Forschler.
836
837         * QueueStatusServer/config/queues.py:
838         * QueueStatusServer/model/queues.py:
839         (Queue._capitalize_after_dash):
840         (Queue._caplitalize_after_dash): Deleted.
841         * Scripts/webkitpy/common/config/ews.json:
842
843 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
844
845         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
846         https://bugs.webkit.org/show_bug.cgi?id=150085
847
848         Reviewed by Carlos Garcia Campos.
849
850         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
851
852 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
853
854         Unreviewed, add myself to the committers list.
855
856         * Scripts/webkitpy/common/config/contributors.json:
857
858 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
859
860         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
861         https://bugs.webkit.org/show_bug.cgi?id=149983
862
863         Reviewed by Dan Bates.
864
865         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
866         (BubbleQueueServer):
867         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
868
869 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
870
871         Fix webkitpy tests after r190922.
872
873         * Scripts/webkitpy/common/config/ews.json:
874         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
875         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
876
877 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
878
879         Add a Mac debug EWS queue
880         https://bugs.webkit.org/show_bug.cgi?id=150069
881
882         Reviewed by Geoffrey Garen.
883
884         * QueueStatusServer/config/queues.py:
885         * Scripts/webkitpy/common/config/ews.json:
886         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
887         (AbstractEarlyWarningSystem):
888         (AbstractEarlyWarningSystem.archive_last_test_results):
889         (AbstractEarlyWarningSystem.build_style):
890         (AbstractEarlyWarningSystem.refetch_patch):
891         (AbstractEarlyWarningSystem.load_ews_classes):
892
893 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
894
895         [GTK] Update jhbuild's version of harfbuzz
896         https://bugs.webkit.org/show_bug.cgi?id=149749
897
898         Reviewed by Martin Robinson.
899
900         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
901
902         * gtk/jhbuild.modules: Updated details for harfbuzz.
903
904 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
905
906         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
907         https://bugs.webkit.org/show_bug.cgi?id=150026
908
909         Reviewed by Philippe Normand.
910
911         Backport upstream patch from gst-plugins-bad so that the right version
912         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
913         gets compiled properly, avoiding crashes on runtime while running tests.
914
915         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
916         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
917
918 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
919
920         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
921         https://bugs.webkit.org/show_bug.cgi?id=149777
922
923         Reviewed by Simon Fraser.
924
925         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
926         to the list of tests to preinstall at startup time.
927
928         Also, update the generation of the 'name' table in the FontWithFeatures font.
929
930         * DumpRenderTree/mac/DumpRenderTree.mm:
931         (allowedFontFamilySet):
932         (activateTestingFonts):
933         (activateFontsIOS):
934         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
935         (Generator::generate):
936         (Generator::appendCFFTable):
937         (Generator::appendNameSubtable):
938         (Generator::appendNAMETable):
939         * FontWithFeatures/FontWithFeatures/main.cpp:
940         (main):
941         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
942         (WTR::allowedFontFamilySet):
943         (WTR::activateFonts):
944         * WebKitTestRunner/mac/TestControllerMac.mm:
945         (WTR::allowedFontFamilySet):
946
947 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
948
949         Unreviewed. Add Jinyoung Hur as a committer. 
950
951         * Scripts/webkitpy/common/config/contributors.json:
952
953 2015-10-10  Dan Bernstein  <mitz@apple.com>
954
955         [iOS] Remove unnecessary iOS version checks
956         https://bugs.webkit.org/show_bug.cgi?id=150002
957
958         Reviewed by Alexey Proskuryakov.
959
960         * WebKitTestRunner/ios/HIDEventGenerator.mm:
961         (-[HIDEventGenerator _createIOHIDEventType:]):
962         (-[HIDEventGenerator _sendHIDEvent:]):
963         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
964         * WebKitTestRunner/ios/UIKitSPI.h:
965
966 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
967
968         Unreviewed, rolling out r190689
969         https://bugs.webkit.org/show_bug.cgi?id=149992
970
971         Fixed in other repository.
972
973         Reverted changesets:
974
975         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
976         https://bugs.webkit.org/show_bug.cgi?id=149897
977
978 2015-10-09  Brian Burg  <bburg@apple.com>
979
980         Teach webkitperl how to figure out IOS versions from the SDK
981         https://bugs.webkit.org/show_bug.cgi?id=149963
982
983         Reviewed by Daniel Bates.
984
985         It should be easier to check the major and minor version of IOS SDKs.
986
987         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
988         * Scripts/webkitdirs.pm:
989         (splitVersionString): Added.
990         (determineOSXVersion): Use splitVersionString.
991         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
992         (iosVersion): Added.
993
994 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
995
996         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
997         https://bugs.webkit.org/show_bug.cgi?id=149960
998
999         Reviewed by Tim Horton.
1000         
1001         Use adoptWK(), and null out some members (file is not using ARC).
1002
1003         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1004         (UIScriptContext::uiScriptComplete):
1005         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1006         (-[TestRunnerWKWebView dealloc]):
1007
1008 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1009
1010         Remove ENABLE_SUID_SANDBOX_LINUX cruft
1011         https://bugs.webkit.org/show_bug.cgi?id=149954
1012
1013         Reviewed by Darin Adler.
1014
1015         * Scripts/webkitperl/FeatureList.pm:
1016
1017 2015-10-09  Daniel Bates  <dabates@apple.com>
1018
1019         Make iOS builders generate debug information in a separate dSYM file
1020         https://bugs.webkit.org/show_bug.cgi?id=149696
1021
1022         Reviewed by Darin Adler.
1023
1024         Similar to the Mac builders, the iOS builders should write debug information
1025         into a separate dSYM file instead of including such information in the binary
1026         itself (default Xcode behavior)
1027
1028         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1029         (CompileWebKit.start):
1030
1031 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1032
1033         Fix webkitpy tests after r190779
1034         https://bugs.webkit.org/show_bug.cgi?id=149949
1035
1036         Reviewed by Ryosuke Niwa.
1037
1038         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1039         (BenchmarkResults.format):
1040         (BenchmarkResults._format_values):
1041
1042 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
1043
1044         Extend run-benchmark script to support human-readable results conversion.
1045         https://bugs.webkit.org/show_bug.cgi?id=149944
1046
1047         Reviewed by Ryosuke Niwa.
1048
1049         Add '--read-results-json' and '--no-adjust-unit' options.
1050         '--read-results-json' option converts result file to human readable format.
1051         '--no-adjust-unit' option skips scientific notation convertion.
1052         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
1053
1054         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1055         (BenchmarkResults.format):
1056         (BenchmarkResults._format_tests):
1057         (BenchmarkResults._format_values):
1058         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1059         (BenchmarkRunner.__init__):
1060         (BenchmarkRunner._run_benchmark):
1061         (BenchmarkRunner._dump):
1062         (BenchmarkRunner.show_results):
1063         (BenchmarkRunner._show_results): Deleted.
1064         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1065         (parse_args):
1066         (start):
1067
1068 2015-10-08  Daniel Bates  <dabates@apple.com>
1069
1070         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
1071         https://bugs.webkit.org/show_bug.cgi?id=149945
1072
1073         Reviewed by Dan Bernstein.
1074
1075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
1076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
1077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1078         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1079         (WebKitBuildbot):
1080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1081         (table.queue-grid tr.platform.ios-9 img.logo):
1082
1083 2015-10-08  Daniel Bates  <dabates@apple.com>
1084
1085         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
1086         https://bugs.webkit.org/show_bug.cgi?id=149943
1087
1088         Reviewed by Dan Bernstein.
1089
1090         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
1091         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
1092
1093         * Scripts/build-webkit:
1094
1095 2015-10-08  Daniel Bates  <dabates@apple.com>
1096
1097         Add LLVM binaries for iOS 9 device
1098         https://bugs.webkit.org/show_bug.cgi?id=149913
1099
1100         Reviewed by Filip Pizlo.
1101
1102         Implement support for building LLVM for ARM64-based iOS devices.
1103
1104         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
1105         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
1106         an existing build earlier in the file such that remove previously built
1107         libraries before building/copying new ones (if applicable).
1108         (fileContains): Moved function outside of if-block.
1109         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
1110         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
1111         added logic to build LLVM for ARM64-based iOS devices.
1112         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
1113         LLVM into the WebKitBuild directory.
1114
1115 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
1116
1117         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
1118         https://bugs.webkit.org/show_bug.cgi?id=149848
1119
1120         Reviewed by Darin Adler.
1121
1122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1123
1124 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
1125
1126         [Win] Support 64-bit Build and Testing
1127         https://bugs.webkit.org/show_bug.cgi?id=149904
1128
1129         Reviewed by Daniel Bates.
1130
1131         Extend our existing scripts to support 64-bit build and test operations on
1132         Windows.
1133
1134         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
1135         Windows always builds the whole stack.
1136         * Scripts/webkit-build-directory: Add an option to return the location of
1137         the executable files produced by a specific configuration. This change is
1138         actually useful for Gtk and EFL, too.
1139         * Scripts/webkitdirs.pm:
1140         (executableProductDir): Added. This function appends the proper binary
1141         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
1142         (jscProductDir): Use the new 'executableProductDir' method.
1143         (setPathForRunningWebKitApp): Ditto.
1144         (runSafari): Ditto.
1145         (runMiniBrowser): Ditto.
1146         * Scripts/webkitpy/port/factory.py:
1147         (configuration_options): Add a 64-bit option, used on Windows to specify
1148         which binary target should be used for testing.
1149         * Scripts/webkitpy/port/win.py:
1150         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
1151         processes when needed.
1152         (WinPort._build_path): Add the correct binary target path to _build_path.
1153         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1154         64-bit paths for 64-bit tests.
1155         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1156         NTSD debugger does not understand this argument.
1157
1158 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
1159
1160         Test font-variant-* and font-feature-settings with TrueType fonts
1161         https://bugs.webkit.org/show_bug.cgi?id=149776
1162
1163         Reviewed by Simon Fraser.
1164
1165         This test extends our existing FontWithFeatures project to be able to generate a
1166         TrueType font. This font is conceptually similar as the existing OpenType font,
1167         except the feature -> character mapping is different.
1168
1169         The font itself only supports the following characters:
1170         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1171         However, the shape of these letters are either an X or a check mark.
1172         The letter "A" always is a check mark.
1173         The letter "B" always is an X.
1174         Each font feature has an letter associated with it. When the font feature is enabled,
1175         that letter is shown as a check mark. For example, when
1176         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1177         mark.
1178
1179         Here are the mappings of font features to letters:
1180         kLigaturesType / kCommonLigaturesOnSelector: C
1181         kLigaturesType / kContextualLigaturesOnSelector: D
1182         kLigaturesType / kRareLigaturesOnSelector: G
1183         kLigaturesType / kHistoricalLigaturesOnSelector: I
1184         kContextualAlternatesType / kContextualAlternatesOnSelector: L
1185         kVerticalPositionType / kInferiorsSelector: O
1186         kVerticalPositionType / kSuperiorsSelector: P
1187         kLowerCaseType / kLowerCaseSmallCapsSelector: S
1188         kUpperCaseType / kUpperCaseSmallCapsSelector: V
1189         kLowerCaseType / kLowerCasePetiteCapsSelector: T
1190         kUpperCaseType / kUpperCasePetiteCapsSelector: W
1191         kLetterCaseType / 14: Y
1192         kStyleOptionsType / kTitlingCapsSelector: a
1193         kNumberCaseType / kUpperCaseNumbersSelector: c
1194         kNumberCaseType / kLowerCaseNumbersSelector: d
1195         kNumberSpacingType / kProportionalNumbersSelector: f
1196         kNumberSpacingType / kMonospacedNumbersSelector: g
1197         kFractionsType / kDiagonalFractionsSelector: i
1198         kFractionsType / kVerticalFractionsSelector: j
1199         kVerticalPositionType / kOrdinalsSelector: Q
1200         kTypographicExtrasType / kSlashedZeroOnSelector: k
1201         kLigaturesType / kHistoricalLigaturesOnSelector: K
1202         kCharacterShapeType / kJIS1978CharactersSelector: m
1203         kCharacterShapeType / kJIS1983CharactersSelector: n
1204         kCharacterShapeType / kJIS1990CharactersSelector: o
1205         kCharacterShapeType / kJIS2004CharactersSelector: p
1206         kCharacterShapeType / kSimplifiedCharactersSelector: q
1207         kCharacterShapeType / kTraditionalCharactersSelector: r
1208         kTextSpacingType / kMonospacedTextSelector: t
1209         kTextSpacingType / kProportionalTextSelector: u
1210         kRubyKanaType / kRubyKanaOnSelector: v
1211
1212         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1213         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1214         (CFFBuilder::moveTo):
1215         (CFFBuilder::lineTo):
1216         (GLYFBuilder::GLYFBuilder):
1217         (GLYFBuilder::takeResult):
1218         (GLYFBuilder::moveTo):
1219         (GLYFBuilder::lineTo):
1220         (GLYFBuilder::closePath):
1221         (GLYFBuilder::writePoint):
1222         (GLYFBuilder::append16):
1223         (generateBoxCharString):
1224         (generateCheckCharString):
1225         (generateXCharString):
1226         (itemForGlyph):
1227         (Generator::generate):
1228         (Generator::insertSelector):
1229         (Generator::insertFeature):
1230         (Generator::generateFeatureDescription):
1231         (Generator::appendCFFTable):
1232         (Generator::appendGLYFTable):
1233         (Generator::appendLOCATable):
1234         (Generator::appendFEATTable):
1235         (Generator::appendMetamorphosisChain):
1236         (Generator::appendMORXTable):
1237         (Generator::appendHEADTable):
1238         (Generator::appendHMTXTable):
1239         (Generator::appendNameSubtable):
1240         (Generator::append2ByteASCIIString):
1241         (Generator::appendNAMETable):
1242         (generateFont):
1243         (CFFBuilder::curveToCubic): Deleted.
1244         (charStringForGlyph): Deleted.
1245         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1246         * FontWithFeatures/FontWithFeatures/main.cpp:
1247         (constructFontWithTrueTypeFeature):
1248         (constructFontWithOpenTypeFeature):
1249         (drawText):
1250         (main):
1251         (drawTextWithFeature): Deleted.
1252
1253 2015-10-07  Commit Queue  <commit-queue@webkit.org>
1254
1255         Unreviewed, rolling out r190572, r190593, r190594, and
1256         r190639.
1257         https://bugs.webkit.org/show_bug.cgi?id=149897
1258
1259         Breaks Mavericks build (Requested by litherum on #webkit).
1260
1261         Reverted changesets:
1262
1263         "Allow WKRetainPtrs to be used as keys in hashing data
1264         structures"
1265         https://bugs.webkit.org/show_bug.cgi?id=149762
1266         http://trac.webkit.org/changeset/190572
1267
1268         "REGRESSION(189668?): http/tests/notifications/events.html
1269         flakily asserts or times out"
1270         https://bugs.webkit.org/show_bug.cgi?id=149218
1271         http://trac.webkit.org/changeset/190593
1272
1273         "Prospective Mavericks build fix."
1274         http://trac.webkit.org/changeset/190594
1275
1276         "Post-review cleanup after r190572."
1277         http://trac.webkit.org/changeset/190639
1278
1279 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1280
1281         [GTK] Add autocleanups
1282         https://bugs.webkit.org/show_bug.cgi?id=149588
1283
1284         Reviewed by Darin Adler.
1285
1286         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1287         (AutocleanupsTest::create):
1288         (AutocleanupsTest::testWebProcessAutocleanups):
1289         (registerTests):
1290         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1291         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1292         (testUIProcessAutocleanups):
1293         (testWebProcessAutocleanups):
1294         (beforeAll):
1295         (afterAll):
1296
1297 2015-10-06  Brian Burg  <bburg@apple.com>
1298
1299         Unreviewed, try to fix the iOS 8 build after r190368.
1300
1301         On older versions, IOHIDEventCreateForceEvent is not available.
1302
1303         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1304         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1305
1306 2015-10-06  Keith Miller  <keith_miller@apple.com>
1307
1308         Add gmalloc option to run-javascriptcore-tests.
1309         https://bugs.webkit.org/show_bug.cgi?id=149858
1310
1311         Reviewed by Geoffrey Garen.
1312
1313         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1314         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1315
1316         * Scripts/run-javascriptcore-tests:
1317
1318 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
1319
1320         Post-review cleanup after r190572.
1321
1322         Unreviewed.
1323
1324         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1325
1326 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
1327
1328         [Win] Unreviewed build correction.
1329
1330         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1331         are soft-linked at runtime.
1332
1333 2015-10-06  Keith Miller  <keith_miller@apple.com>
1334
1335         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1336         https://bugs.webkit.org/show_bug.cgi?id=149815
1337
1338         Reviewed by Filip Pizlo.
1339
1340         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1341         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1342         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1343         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1344         so should just use one test runner.
1345
1346         * Scripts/run-javascriptcore-tests:
1347         (runJSCStressTests):
1348         (runMozillaTests): Deleted.
1349         (defaultJsDriverArgsForMozillaTests): Deleted.
1350         * Scripts/run-jsc-stress-tests:
1351
1352 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1353
1354         [GTK] Make update-webkitgtk-libs work behind firewall
1355
1356         update-webkitgtk-libs can work behind a firewall with changes to
1357         a few packages.  Where outbound git and active FTP connections
1358         fail, using http protocol succeeds.  Most packages are
1359         already accessed using http.
1360
1361         https://bugs.webkit.org/show_bug.cgi?id=148941
1362
1363         Reviewed by Martin Robinson.
1364
1365         Tools
1366         * gtk/jhbuild.modules:
1367             Replace git URLs with http.  Remove no longer used ftp repositories.
1368             Update argument for libxml2's autogen.sh script (--without-python
1369             is ignored; --with-python=no is correct).
1370         * jhbuild/jhbuild-wrapper:
1371             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1372             http://git.gnome.org/browse/jhbuild.
1373
1374 2015-10-06  Daniel Bates  <dbates@webkit.org>
1375
1376         Enable XSLT when building WebKit for iOS using the public iOS SDK
1377         https://bugs.webkit.org/show_bug.cgi?id=149827
1378
1379         Reviewed by Alexey Proskuryakov.
1380
1381         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1382         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1383         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1384         headers cannot be found.
1385
1386         * Scripts/configure-xcode-for-ios-development:
1387         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1388
1389 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1390
1391         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1392         https://bugs.webkit.org/show_bug.cgi?id=149218
1393
1394         Reviewed by Alexey Proskuryakov.
1395
1396         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1397         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1398         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1399         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1400         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1401         WebNotificationProvider must be updated to appropriately handle multiple
1402         WKNotificationManagerRefs in flight at the same time.
1403
1404         * WebKitTestRunner/WebNotificationProvider.cpp:
1405         (WTR::WebNotificationProvider::~WebNotificationProvider):
1406         (WTR::WebNotificationProvider::showWebNotification):
1407         (WTR::WebNotificationProvider::closeWebNotification):
1408         (WTR::WebNotificationProvider::addNotificationManager):
1409         (WTR::WebNotificationProvider::removeNotificationManager):
1410         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1411         (WTR::WebNotificationProvider::reset):
1412         * WebKitTestRunner/WebNotificationProvider.h:
1413
1414 2015-10-05  Daniel Bates  <dabates@apple.com>
1415
1416         Disable Bitcode when building for iOS device
1417         https://bugs.webkit.org/show_bug.cgi?id=149818
1418
1419         Reviewed by Alexey Proskuryakov.
1420
1421         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1422         when building for iOS device.
1423
1424         * Scripts/webkitdirs.pm:
1425         (XcodeOptions):
1426
1427 2015-10-05  Daniel Bates  <dabates@apple.com>
1428
1429         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1430         https://bugs.webkit.org/show_bug.cgi?id=140828
1431         <rdar://problem/19520599>
1432
1433         Reviewed by Alexey Proskuryakov.
1434
1435         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1436         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1437         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1438         to build-webkit.
1439
1440         * Scripts/webkitdirs.pm:
1441         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1442         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1443         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1444         (hasIOSDevelopmentCertificate): Added.
1445
1446 2015-10-05  Daniel Bates  <dabates@apple.com>
1447
1448         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1449         https://bugs.webkit.org/show_bug.cgi?id=149766
1450
1451         Reviewed by Alexey Proskuryakov.
1452
1453         Create network storage testing session on iOS.
1454
1455         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1456         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1457         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1458         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1459         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1460         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1461         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1462         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1463         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1464
1465         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1466         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1467         returns a non-null pointer to a cookie store.
1468
1469         * DumpRenderTree/mac/DumpRenderTree.mm:
1470         (prepareConsistentTestingEnvironment):
1471
1472 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1473
1474         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1475         available.
1476
1477         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1478         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1479
1480 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1481
1482         Allow WKRetainPtrs to be used as keys in hashing data structures
1483         https://bugs.webkit.org/show_bug.cgi?id=149762
1484
1485         Reviewed by Anders Carlsson.
1486
1487         * TestWebKitAPI/PlatformGTK.cmake:
1488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1489         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1490         (TestWebKitAPI::TEST):
1491
1492 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1493
1494         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1495         available, and tidy up the #ifdefs in the UIKitSPI header.
1496
1497         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1498         (-[HIDEventGenerator _sendHIDEvent:]):
1499         * WebKitTestRunner/ios/UIKitSPI.h:
1500
1501 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1502
1503         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1504         https://bugs.webkit.org/show_bug.cgi?id=149792
1505
1506         Reviewed by Martin Robinson.
1507
1508         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1509         for WebKitTestRunner multiple times.
1510
1511 2015-10-04  Daniel Bates  <dabates@apple.com>
1512
1513         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1514         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1515
1516         For now, support calling build-layouttestrelay without --ios-simulator so long
1517         as we are building on a Mac.
1518
1519         * Scripts/build-layouttestrelay:
1520
1521 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1522
1523         Support Trac 1.0.x XML timeline link format
1524         https://bugs.webkit.org/show_bug.cgi?id=149786
1525
1526         Reviewed by Lucas Forschler.
1527
1528         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1529         (Trac.prototype._convertCommitInfoElementToObject):
1530
1531 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1532
1533         Fix some errors on bot watcher's dashboard
1534         https://bugs.webkit.org/show_bug.cgi?id=149789
1535
1536         Reviewed by Lucas Forschler.
1537
1538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1539         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1540         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1541
1542 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1543
1544         Bot watcher's dashboard builders should turn yellow when svn fails
1545         https://bugs.webkit.org/show_bug.cgi?id=149791
1546
1547         Reviewed by Lucas Forschler.
1548
1549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1550         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1551         (BuildbotBuilderQueueView.prototype.update):
1552
1553 2015-10-02  Daniel Bates  <dabates@apple.com>
1554
1555         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1556         https://bugs.webkit.org/show_bug.cgi?id=149769
1557
1558         Reviewed by Alexey Proskuryakov.
1559
1560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1564         (WebKitBuildbot):
1565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1566         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1567
1568 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1569
1570         REGRESSION(r190370): Speedometer spits out an extra console message
1571         https://bugs.webkit.org/show_bug.cgi?id=149720
1572
1573         Unreviewed. Temporarily ignore the console error message.
1574
1575         * Scripts/webkitpy/performance_tests/perftest.py:
1576         (PerfTest._filter_output):
1577
1578 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1579
1580         Provide "--no-ninja" option to avoid using Ninja
1581         https://bugs.webkit.org/show_bug.cgi?id=149757
1582
1583         Reviewed by Alex Christensen.
1584
1585         Add a new command line argument understood by webkitdirs.pm so
1586         that we can conditionally avoid using Ninja. This is an
1587         'opt-out' argument, so no existing Ninja users should be affected.
1588         
1589         * Scripts/webkitdirs.pm:
1590         (canUseNinja): Check for option and block ninja if present.
1591
1592 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
1593
1594         Flakiness dashboard should support OS X El Capitan
1595         https://bugs.webkit.org/show_bug.cgi?id=149648
1596
1597         Reviewed by Alexey Proskuryakov.
1598
1599         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1600
1601 2015-10-02  Daniel Bates  <dabates@apple.com>
1602
1603         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1604         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1605
1606         For now, pass --ios-simulator.
1607
1608         * Scripts/webkitpy/port/ios.py:
1609         (IOSSimulatorPort._build_relay):
1610
1611 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
1612
1613         Remove a "nullable" that breaks the iOS 8 build.
1614
1615         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1616         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
1617
1618 2015-10-02  Daniel Bates  <dabates@apple.com>
1619
1620         LayoutTestRelay is not built and archived when building for iOS Simulator
1621         https://bugs.webkit.org/show_bug.cgi?id=149753
1622
1623         Reviewed by Alexey Proskuryakov and Andy Estes.
1624
1625         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
1626         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
1627         product archive when building for iOS Simulator, respectively.
1628
1629         * BuildSlaveSupport/built-product-archive:
1630         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
1631         differentiate between iOS device and iOS Simulator platforms.
1632         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
1633         from determineWebKitBuildDirectories() into this function so that it can be used by both
1634         determineWebKitBuildDirectories() and archiveBuiltProduct().
1635         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
1636         webkitBuildDirectoryForConfigurationAndPlatform().
1637         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
1638         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
1639         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
1640         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
1641         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
1642         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
1643         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
1644         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
1645         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
1646         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
1647         * Scripts/build-layouttestrelay:
1648             - Remove unnecessary include of Perl module POSIX.
1649             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
1650         * Scripts/build-webkit:
1651             - Invoke script build-layouttestrelay when building for iOS Simulator.
1652
1653 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1654
1655         [Win] Unreviewed test fix.
1656
1657         You cannot run 'run-webkit-tests' from the command line because it does not know
1658         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
1659         because they explicitly set use the 'root' argument to provide the full path to
1660         the test binaries.
1661
1662         * Scripts/webkitpy/port/win.py:
1663         (WinPort._build_path): Added.
1664
1665 2015-10-02  Alex Christensen  <achristensen@webkit.org>
1666
1667         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
1668         https://bugs.webkit.org/show_bug.cgi?id=149430
1669         rdar://problem/22742222
1670
1671         Reviewed by Geoffrey Garen.
1672
1673         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1674         (WTR::TestController::cocoaResetStateToConsistentValues):
1675         * WebKitTestRunner/mac/TestControllerMac.mm:
1676         (WTR::TestController::platformConfigureViewForTest):
1677         Test what happens when you disable content blockers from the SPI.
1678
1679 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1680
1681         [Win] Unreviewed build fix for run-api-tests
1682
1683         * Scripts/run-api-tests:
1684         (testToolPaths): Windows run needs to specify the binary path.
1685
1686 2015-10-01  Daniel Bates  <dabates@apple.com>
1687
1688         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
1689         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1690
1691         Following r190424 we can now rely on webkit-build-directory to return the path to
1692         the correct configuration-specific build directory on Windows.
1693
1694         * BuildSlaveSupport/built-product-archive:
1695         (archiveBuiltProduct):
1696
1697 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1698
1699         [Win] Unreviewed build fix.
1700
1701         * Scripts/webkitdirs.pm:
1702         (setupAppleWinEnv): Use 64-bit build tools if available
1703
1704 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1705
1706         [Win] Fix TestWebKitAPI build under CMake.
1707
1708         Reviewed by Alex Christensen.
1709
1710         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
1711         for Psapi.lib.
1712
1713 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
1714
1715         [Win] Fix behavior of webkit-build-directory script
1716         https://bugs.webkit.org/show_bug.cgi?id=149718
1717
1718         Reviewed by Alex Christensen.
1719
1720         * Scripts/webkitdirs.pm:
1721         (determineConfigurationProductDir): Do not include the binary
1722         sub-directory in the configuration product directory output.
1723         (jscProductDir): Append correct binary path for Windows build.
1724         (setPathForRunningWebKitApp): Include properly binary subdirectories.
1725         (runSafari): Update for revised productDir behavior.
1726         (runMiniBrowser): Ditto.
1727
1728 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1729
1730         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
1731         use iOS SDK, like with all the others.
1732
1733         * Scripts/build-webkit:
1734
1735 2015-10-01  Daniel Bates  <dabates@apple.com>
1736
1737         Attempt to fix the iOS 9 Simulator testers
1738
1739         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
1740         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
1741         LayoutTestRelay when building for iOS Simulator.
1742
1743         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1744         * Scripts/build-webkit:
1745
1746 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1747
1748         [GTK] Websites with invalid auth header keep loading forever
1749         https://bugs.webkit.org/show_bug.cgi?id=149710
1750
1751         Reviewed by Martin Robinson.
1752
1753         Add test case to check that we can authenticate sites with an
1754         empty realm.
1755
1756         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1757         (testWebViewAuthenticationEmptyRealm):
1758         (serverCallback):
1759         (beforeAll):
1760
1761 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1762
1763         [Mac] Make run-api-tests work with System Integrity Protection
1764         https://bugs.webkit.org/show_bug.cgi?id=149711
1765         rdar://problem/22928202
1766
1767         Reviewed by Dan Bernstein.
1768
1769         * Scripts/run-api-tests:
1770         (runTest):
1771         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
1772
1773 2015-10-01  Daniel Bates  <dabates@apple.com>
1774
1775         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
1776         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1777
1778         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
1779         For now, use the path to the top-level WebKit build directory instead of using the configuration-
1780         specific build directory.
1781
1782         * BuildSlaveSupport/built-product-archive:
1783         (archiveBuiltProduct):
1784
1785 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1786
1787         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
1788         https://bugs.webkit.org/show_bug.cgi?id=145837
1789
1790         Reviewed by Philippe Normand.
1791
1792         * efl/jhbuild.modules:
1793         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
1794         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
1795
1796 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1797
1798         Unreviewed. Fix the iOS build after r190407.
1799
1800         * WebKitTestRunner/ios/IOKitSPI.h:
1801
1802 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1803
1804         Implement keyboard event sending for iOS in WebKitTestRunner
1805         https://bugs.webkit.org/show_bug.cgi?id=149676
1806
1807         Reviewed by Simon Fraser.
1808
1809         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
1810         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
1811         allows us to run code when the keyboard is shown or hidden.
1812
1813         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
1814         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1815         (WTR::UIScriptController::setDidShowKeyboardCallback):
1816         (WTR::UIScriptController::didShowKeyboardCallback):
1817         (WTR::UIScriptController::setDidHideKeyboardCallback):
1818         (WTR::UIScriptController::didHideKeyboardCallback):
1819         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1820         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1821         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1822         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1823         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1824         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1825         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
1826                 the notifications that the keyboard has been raised or lowered.
1827         (-[TestRunnerWKWebView _keyboardDidShow:]):
1828         (-[TestRunnerWKWebView _keyboardDidHide:]):
1829         * WebKitTestRunner/ios/HIDEventGenerator.h:
1830         * WebKitTestRunner/ios/HIDEventGenerator.m:
1831         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
1832         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
1833         (hidUsageCodeForCharacter): Ditto.
1834         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
1835                 a keyDown event in WebKit.
1836         * WebKitTestRunner/ios/IOKitSPI.h:
1837         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1838
1839 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1840
1841         Unreviewed, rolling out r190399.
1842
1843         Tests are still failing even after r190362
1844
1845         Reverted changeset:
1846
1847         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
1848         http://trac.webkit.org/changeset/190399
1849
1850 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1851
1852         [jhbuild] switch to new upstream usrsctp library
1853         https://bugs.webkit.org/show_bug.cgi?id=149494
1854
1855         Reviewed by Philippe Normand.
1856
1857         * efl/jhbuild.modules:
1858         * gtk/jhbuild.modules:
1859
1860 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1861
1862         Unreviewed. Unskip GTK+ user media unit tests after r190362.
1863
1864         They should pass now.
1865
1866         * Scripts/run-gtk-tests:
1867         (TestRunner):
1868
1869 2015-09-30  Daniel Bates  <dabates@apple.com>
1870
1871         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1872         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1873
1874         * BuildSlaveSupport/built-product-archive:
1875         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
1876         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
1877
1878 2015-09-30  Daniel Bates  <dabates@apple.com>
1879
1880         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1881         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1882
1883         Actually, we need to pass --configuration to script webkit-build-directory to have
1884         it return the path to the configuration-specific build directory.
1885
1886         * BuildSlaveSupport/built-product-archive:
1887         (determineWebKitBuildDirectories):
1888
1889 2015-09-30  Daniel Bates  <dabates@apple.com>
1890
1891         built-product-archive archives incorrect build directory for iOS port
1892         https://bugs.webkit.org/show_bug.cgi?id=149695
1893
1894         Reviewed by Darin Adler.
1895
1896         Fixes an issue where the script built-product-archive archives a non-existent
1897         build directory for the iOS port. Without loss of generality, the script assumes
1898         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
1899         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
1900
1901         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
1902         to determine the top-level build directory and computes the configuration-specific
1903         build directory to be the concatenation of the the top-level build directory and
1904         the configuration (e.g. Release). This is incorrect. Instead we should call
1905         webkit-build-directory omitting the flag --top-level to compute the path to the
1906         configuration-specific build directory.
1907
1908         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
1909         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
1910         its purpose and added global variable _configurationBuildDirectory to store the path
1911         to the configuration-specific build directory. Ensure that we have a non-empty string
1912         for both the top-level and configuration-specific build directories.
1913         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
1914         Compute the configuration-specific build directory and store it in the global variable
1915         _configurationBuildDirectory.
1916         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
1917         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
1918         as needed.
1919         (determineWebKitBuildDirectory): Deleted.
1920
1921 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
1922
1923         [EFL] css3/device-adapt/* tests failed after r190335.
1924         https://bugs.webkit.org/show_bug.cgi?id=149655
1925
1926         Reviewed by Simon Fraser.
1927
1928         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1929         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
1930
1931         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1932         (WTR::shouldUseFixedLayout):
1933
1934 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
1935
1936         Extend JetStream timeout for slow devices.
1937
1938         Reviewed by Chris Dumez.
1939
1940         Extend JetStream timeout to 20 minutes.
1941
1942         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1943
1944 2015-09-30  Daniel Bates  <dabates@apple.com>
1945
1946         Rename iOS builders/testers to include version
1947         https://bugs.webkit.org/show_bug.cgi?id=149685
1948
1949         Reviewed by Simon Fraser.
1950
1951         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
1952         make it clear to a reader the version of iOS these builders/testers are using.
1953
1954         * BuildSlaveSupport/build.webkit.org-config/config.json:
1955         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1956
1957 2015-09-30  Daniel Bates  <dabates@apple.com>
1958
1959         Add iOS criterion for triggering a build
1960         https://bugs.webkit.org/show_bug.cgi?id=149679
1961
1962         Rubber-stamped by Alexey Proskuryakov.
1963
1964         First pass at defining criterion for triggering an iOS build.
1965
1966         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1967         (_should_file_trigger_build):
1968         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1969         (ShouldBuildTest):
1970         (ShouldBuildTest.test_should_build):
1971
1972 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1973
1974         [iOS] Allow tests to generate user gestures for UI testing
1975         https://bugs.webkit.org/show_bug.cgi?id=149653
1976
1977         Reviewed by Tim Horton.
1978
1979         Expose functionality in UIScriptController to allow for testing single- and double-tap,
1980         and to listen for completion of scrolling and zooming in the WKWebView.
1981         
1982         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
1983         which hides the complexity of creating these events. Event dispatch is asynchronous.
1984         We detect when the last event has been handled by dispatching a vendor-specific event,
1985         which is detected via -_handleHIDEvent: in our UIApplication subclass.
1986         
1987         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
1988         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
1989         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
1990         single and double taps.
1991         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1992         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
1993         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
1994         (UIScriptContext::unregisterCallback):
1995         (UIScriptContext::callbackWithID):
1996         (UIScriptContext::fireCallback):
1997         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1998         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1999         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
2000         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
2001         (WTR::UIScriptController::setDidEndZoomingCallback):
2002         (WTR::UIScriptController::didEndZoomingCallback):
2003         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
2004         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
2005         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2006         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2007         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2008         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2009         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
2010         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2011         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
2012         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
2013         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
2014         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
2015         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2016         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
2017         (simpleDragCurve):
2018         (calculateNextLocation):
2019         (delayBetweenMove):
2020         (+[HIDEventGenerator sharedHIDEventGenerator]):
2021         (+[HIDEventGenerator nextEventCallbackID]):
2022         (-[HIDEventGenerator init]):
2023         (-[HIDEventGenerator _createIOHIDEventType:]):
2024         (-[HIDEventGenerator _sendHIDEvent:]):
2025         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2026         (-[HIDEventGenerator _updateTouchPoints:count:]):
2027         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2028         (-[HIDEventGenerator touchDown:touchCount:]):
2029         (-[HIDEventGenerator touchDown:]):
2030         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2031         (-[HIDEventGenerator liftUp:touchCount:]):
2032         (-[HIDEventGenerator liftUp:]):
2033         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2034         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2035         (-[HIDEventGenerator tap:completionBlock:]):
2036         (-[HIDEventGenerator doubleTap:completionBlock:]):
2037         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2038         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2039         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
2040         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
2041         (-[HIDEventGenerator markerEventReceived:]):
2042         * WebKitTestRunner/ios/IOKitSPI.h: Added.
2043         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2044         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2045         (WTR::globalToContentCoordinates):
2046         (WTR::UIScriptController::singleTapAtPoint):
2047         (WTR::UIScriptController::doubleTapAtPoint):
2048         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2049         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2050         * WebKitTestRunner/ios/mainIOS.mm:
2051         (-[WebKitTestRunnerApp _handleHIDEvent:]):
2052
2053 2015-09-30  Dana Burkart  <dburkart@apple.com>
2054
2055         git-add-reviewer should trim trailing spaces/newlines
2056         https://bugs.webkit.org/show_bug.cgi?id=149513
2057
2058         Reviewed by Darin Adler.
2059
2060         * Scripts/git-add-reviewer:
2061         (nonInteractive):
2062
2063 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
2064
2065         REGRESSION(r190262): User media unit test failures after r190262
2066         https://bugs.webkit.org/show_bug.cgi?id=149580
2067
2068         Reviewed by Darin Adler.
2069
2070         * WebKitTestRunner/TestController.cpp:
2071         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
2072           order to WKUserMediaPermissionRequestAllow.
2073
2074 2015-09-30  Daniel Bates  <dabates@apple.com>
2075
2076         Add iOS builders and testers
2077         https://bugs.webkit.org/show_bug.cgi?id=149549
2078
2079         Reviewed by Alexey Proskuryakov.
2080
2081         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
2082         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
2083
2084         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
2085         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2086
2087 2015-09-30  Timothy Hatcher  <timothy@apple.com>
2088
2089         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
2090         https://bugs.webkit.org/show_bug.cgi?id=149674
2091
2092         Reviewed by Lucas Forschler.
2093
2094         * WebKitLauncher/WebKitLauncher.entitlements: Added.
2095         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2096
2097 2015-09-30  Jason Marcell  <jmarcell@apple.com>
2098
2099         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
2100         have an associated trac instance.
2101         https://bugs.webkit.org/show_bug.cgi?id=149673
2102
2103         Reviewed by Alexey Proskuryakov.
2104
2105         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2106         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
2107         have an associated trac instance.
2108
2109 2015-09-30  Daniel Bates  <dabates@apple.com>
2110
2111         Prioritize testing latest build request on iOS test bots
2112         https://bugs.webkit.org/show_bug.cgi?id=149669
2113
2114         Reviewed by Darin Adler.
2115
2116         We should prioritize testing of the latest build request on the iOS test bots
2117         as we do for Mac and Windows test bots.
2118
2119         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2120         (loadBuilderConfig):
2121
2122 2015-09-30  Daniel Bates  <dabates@apple.com>
2123
2124         Add buildbot category for iOS builders and testers
2125         https://bugs.webkit.org/show_bug.cgi?id=149667
2126
2127         Reviewed by Darin Adler.
2128
2129         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
2130         for iOS to the build.webkit.org home page.
2131
2132         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2133         (loadBuilderConfig):
2134         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2135
2136 2015-09-30  Daniel Bates  <dabates@apple.com>
2137
2138         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2139         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2140
2141         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
2142         in <http://trac.webkit.org/changeset/190351>.
2143
2144         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2145         (CompileWebKit.start):
2146
2147 2015-09-30  Daniel Bates  <dabates@apple.com>
2148
2149         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2150         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2151
2152         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2153         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2154
2155         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2156         (CompileWebKit.start):
2157
2158 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2159
2160         bot210 was configured for a queue instead of bot126.
2161         
2162         Unreviewed config.json fix.
2163         
2164         * BuildSlaveSupport/build.webkit.org-config/config.json:
2165
2166 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2167
2168         Bring El Capitan buildbot infrastructure online.
2169         https://bugs.webkit.org/show_bug.cgi?id=149605
2170         
2171         Reviewed by Darin Adler.
2172
2173         * BuildSlaveSupport/build.webkit.org-config/config.json:
2174
2175 2015-09-30  Tomas Popela  <tpopela@redhat.com>
2176
2177         [GTK] Deprecation warnings in DOMNodeTest
2178         https://bugs.webkit.org/show_bug.cgi?id=149663
2179
2180         After the webkit_dom_document_get_elements_by_tag_name deprecation we
2181         need to update the tests to use webkit_dom_document_query_selector_all
2182         to avoid compilation warnings.
2183
2184         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2185         (the suggested replacement for the deprecated function).
2186
2187         Reviewed by Carlos Garcia Campos.
2188
2189         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2190         (WebKitDOMNodeTest::testTagNamesNodeList):
2191         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2192         (registerTests):
2193         (WebKitDOMNodeTest::testTagNames): Deleted.
2194         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2195         (prepareDOMForTagNamesTests):
2196         (testWebKitDOMNodeTagNamesNodeList):
2197         (testWebKitDOMNodeTagNamesHTMLCollection):
2198         (beforeAll):
2199         (testWebKitDOMNodeTagNames): Deleted.
2200
2201 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2202
2203         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2204         https://bugs.webkit.org/show_bug.cgi?id=149650
2205
2206         Reviewed by Tim Horton.
2207         
2208         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2209         looks at the file path, and not the custom options that come from file comments.
2210         
2211         Fix by computing TestOptions before making the TestInvocation, and setting them
2212         as const TestInvocation data. This meant changing various call sites to take
2213         the std::string pathOrURL, rather than the TestInvocation itself.
2214         
2215         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2216
2217         * WebKitTestRunner/CMakeLists.txt:
2218         * WebKitTestRunner/TestController.cpp:
2219         (WTR::TestController::ensureViewSupportsOptionsForTest):
2220         (WTR::testPath):
2221         (WTR::createTestURL):
2222         (WTR::updateTestOptionsFromTestHeader):
2223         (WTR::TestController::testOptionsForTest):
2224         (WTR::TestController::updateWebViewSizeForTest):
2225         (WTR::TestController::updateWindowScaleForTest):
2226         (WTR::TestController::runTest):
2227         * WebKitTestRunner/TestController.h:
2228         * WebKitTestRunner/TestInvocation.cpp:
2229         (WTR::TestInvocation::TestInvocation):
2230         (WTR::TestInvocation::invoke):
2231         (WTR::createWKURL): Deleted.
2232         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2233         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2234         * WebKitTestRunner/TestInvocation.h:
2235         (WTR::TestInvocation::options):
2236         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2237         (WTR::pathContains):
2238         (WTR::shouldMakeViewportFlexible):
2239         (WTR::shouldUseFixedLayout):
2240         (WTR::isSVGTestPath):
2241         (WTR::isHiDPITestPath):
2242         (WTR::TestOptions::TestOptions):
2243         * WebKitTestRunner/TestOptions.h:
2244         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2245         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2246         (WTR::pathContains):
2247         (WTR::shouldUseFixedLayout):
2248         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2249         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2250         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2251         * WebKitTestRunner/ios/TestControllerIOS.mm:
2252         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2253         * WebKitTestRunner/mac/TestControllerMac.mm:
2254         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2255
2256 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
2257
2258         Flakiness dashboard should support OS X El Capitan
2259         https://bugs.webkit.org/show_bug.cgi?id=149648
2260
2261         Reviewed by Alexey Proskuryakov.
2262
2263         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
2264         difference between new appscale and old Google App Engine implementation.
2265         * TestResultServer/app.yaml: Same.
2266         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2267
2268 2015-09-29  Daniel Bates  <dabates@apple.com>
2269
2270         configure-xcode-for-ios-development does not work with Xcode 7
2271         https://bugs.webkit.org/show_bug.cgi?id=149640
2272
2273         Reviewed by Alexey Proskuryakov.
2274
2275         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2276         because it cannot find the Xcode specification files for iOS simulator and device. These
2277         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2278         relevant definitions to the Xcode 7 specification files directly as opposed to creating
2279         new specification files with the added definitions (as we did in older versions of Xcode)
2280         in order for Xcode 7 to honor these definitions.
2281
2282         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2283         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2284         (updateXcode7SpecificationFile): Added.
2285         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2286         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2287         appropriate success message.
2288         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2289         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2290         (createXcodeSpecificationFromSpecificationAndId): Deleted.
2291
2292 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2293
2294         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2295         https://bugs.webkit.org/show_bug.cgi?id=149639
2296
2297         Reviewed by Alex Christensen.
2298
2299         * Scripts/VCSUtils.pm:
2300         (exitStatus): Use 'isWindows()' method.
2301         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2302         an error. This method could probably just go away.
2303         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2304         always changing to Unix style. 
2305         (unixPath): Added. Needed so Windows can always show a Unix path in the
2306         ChangeLog file.
2307         (changeLogName): Work around the fact that 'getpwuid' is not available on
2308         a pure Windows build of Perl.
2309         * Scripts/prepare-ChangeLog:
2310         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2311         path on Windows.
2312         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2313         support using arrays for 'open' arguments.
2314         (resolveChangeLogsPath): Ditto.
2315         (resolveConflictedChangeLogs): Use new helper functions.
2316         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2317         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2318         quotes. Unix systems are happy either way.
2319         (statusCommand): Ditto.
2320         * Scripts/webkitdirs.pm:
2321         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2322
2323 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2324
2325         [Win] Unreviewed 64-bit build fix after switch to CMake.
2326
2327         * Scripts/webkitdirs.pm:
2328         (determineIsWin64FromArchitecture): Added.
2329
2330 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2331
2332         printing does not use minimum page zoom factor
2333         https://bugs.webkit.org/show_bug.cgi?id=108507
2334
2335         Reviewed by Darin Adler.
2336
2337         WebKitTestRunner always takes the snapshots from the UI process
2338         (expect for IOS), so in the case of printing, the layout in the
2339         web view is not the expected one. When printing, we need to take
2340         the snapshot in the web process and ensure it's rendered with a
2341         PrintContext.
2342
2343         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2344         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2345         kWKSnapshotOptionsPrinting option to
2346         WKBundlePageCreateSnapshotWithOptions() when printing.
2347
2348 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2349
2350         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2351         https://bugs.webkit.org/show_bug.cgi?id=149595
2352
2353         Reviewed by Tim Horton.
2354
2355         All ports except IOS implement
2356         PlatformWebView::windowSnapshotImage() to generate the snapshot
2357         for the pixel tests in the UI process. But we are still generating
2358         a snapshot for pixel tests in the Web process too, that is passed
2359         to the UI process but ignored.
2360         Whether a pixel result is needed or not, is only known by the web
2361         process depending on whether the test called dumpAsText with
2362         dumpPixels == true or not. Since the pixels are now dump in the UI
2363         process, we need to pass that information to the UI process when
2364         the test is done. For that we set a PixelResultIsPending bool
2365         parameter to the Done message, and we only add the PixelResult
2366         when UI process doesn't need to generate the pixels dump.
2367
2368         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2369         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2370         m_pixelResultIsPending to false on reset.
2371         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2372         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2373         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2374         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2375         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2376         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2377         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2378         port.
2379         * WebKitTestRunner/TestInvocation.cpp:
2380         (WTR::TestInvocation::dumpResults): Use either the pixel result
2381         from the web process or generate a pixel result from the web view
2382         if need it.
2383         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2384         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2385         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2386         is created by the caller now, but the CG implementation needs to
2387         know if it's a Web or UI process snapshot.
2388         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2389         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2390         cairo surface for the given image.
2391         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2392         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2393         CGContext for the given image.
2394
2395 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2396
2397         Fix JS errors on dashboard metrics page
2398         https://bugs.webkit.org/show_bug.cgi?id=149608
2399
2400         Reviewed by Alexey Proskuryakov.
2401
2402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2403         (initPlatformsByFamily): 
2404         (updateHiddenPlatforms):
2405         (parsePlatformFamily): Deleted.
2406         (updateToggleButtons): Deleted.
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2408         (updateHiddenPlatforms): Added to remove errors.
2409         (initPlatformsByFamily): Added to remove errors.
2410         (unhiddenQueues): Updated to use Settings.
2411         (documentReady): Added logic to add toggle buttons to the settings menu.
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2413         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2414         MetricsMain.js to Settings.
2415         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2416         MetricsMain.js to Settings.
2417         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2418         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2419
2420 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2421
2422         Appscale query fails because of missing index
2423         https://bugs.webkit.org/show_bug.cgi?id=149609
2424
2425         Reviewed by Darin Adler.
2426
2427         * QueueStatusServer/index.yaml: Added the required index.
2428
2429 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2430
2431         [Win] Fix the 64-bit build after switch to cmake.
2432
2433         Reviewed by Alex Christensen.
2434
2435         * Scripts/webkitdirs.pm:
2436         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2437         run a 64-bit build.
2438
2439 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2440
2441         [Win] Allow Windows to run test-webkitpy without Cygwin
2442         https://bugs.webkit.org/show_bug.cgi?id=149602
2443
2444         Reviewed by Alex Christensen.
2445
2446         These changes mostly shift from hard-coded paths using UNIX-style
2447         separators to Python's "os.path.join" syntax that uses the correct
2448         path separator for each platform.
2449         
2450         * Scripts/webkitpy/common/system/path.py:
2451         (cygpath): Don't pass paths through Cygpath on native Windows.
2452         * Scripts/webkitpy/port/win.py:
2453         (WinPort._path_to_apache): Use os.path.join.
2454         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2455         in 64-bit environments).
2456         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2457         * Scripts/webkitpy/style/checker_unittest.py:
2458         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2459         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2460         (GlobalVariablesTest): Ditto.
2461         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2462         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2463         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2464         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2465         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2466         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2467         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2468         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2469         (StyleProcessor_CodeCoverageTest): Ditto.
2470         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2471         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2472         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2473         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2474         manual string concatenation of paths.
2475
2476 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2477
2478         Add bugzilla addresses of committers to contributors.json
2479         https://bugs.webkit.org/show_bug.cgi?id=149520
2480
2481         Reviewed by Darin Adler.
2482
2483         * Scripts/webkitpy/common/config/contributors.json:
2484
2485 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2486
2487         validate-committer-lists -b shouldn't need edituser privileges
2488         https://bugs.webkit.org/show_bug.cgi?id=149519
2489
2490         Reviewed by Darin Adler.
2491
2492         * Scripts/validate-committer-lists:
2493         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2494         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2495         (BugzillaQueries.is_invalid_bugzilla_email):
2496         (BugzillaQueries): Deleted.
2497         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2498
2499 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2500
2501         Unreviewed. Gardening: skip media stream tests failing after r190262.
2502
2503         * Scripts/run-gtk-tests:
2504         (TestRunner):
2505
2506 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2507
2508         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2509         https://bugs.webkit.org/show_bug.cgi?id=149571
2510
2511         Reviewed by Dan Bernstein.
2512
2513         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
2514
2515         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2516         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2517         * LayoutTestRelay/Configurations/Base.xcconfig:
2518         * MiniBrowser/Configurations/Base.xcconfig:
2519         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2520         * TestWebKitAPI/Configurations/Base.xcconfig:
2521         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2522         * WebEditingTester/Configurations/Base.xcconfig:
2523         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2524         * WebKitTestRunner/Configurations/Base.xcconfig:
2525         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2526         * WebKitTestRunner/iOS.xcconfig: Removed.
2527
2528 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2529
2530         Clean up user media request internal API
2531         https://bugs.webkit.org/show_bug.cgi?id=149527
2532
2533         Reviewed by Tim Horton.
2534
2535         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2536         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2537
2538         * WebKitTestRunner/TestController.cpp:
2539         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2540
2541 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2542
2543         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2544         https://bugs.webkit.org/show_bug.cgi?id=149577
2545
2546         Reviewed by Tim Horton.
2547         
2548         When calling testRunner.runUIScript() from a page load event, the script could run
2549         in the UI process before the current remote layer tree transaction had been handled
2550         there. This meant that runUIScript() could query state which was about to change.
2551         
2552         Fix by delaying the execution of the UI script until a layer tree transaction has
2553         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2554
2555         * WebKitTestRunner/TestInvocation.cpp:
2556         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2557         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2558         * WebKitTestRunner/TestInvocation.h:
2559
2560 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2561
2562         [Mac] Media tests start to time out after a few days of bot uptime
2563         https://bugs.webkit.org/show_bug.cgi?id=149468
2564
2565         Reviewed by Darin Adler.
2566
2567         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2568         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2569         all temporary and cache files go to a custom location.
2570
2571         * Scripts/webkitpy/port/base.py:
2572         * Scripts/webkitpy/port/driver.py:
2573         * Scripts/webkitpy/port/mac.py:
2574         * Scripts/webkitpy/port/win.py:
2575         (WinPort._driver_tempdir_for_environment): Deleted unused function.
2576
2577 2015-09-25  Dan Bernstein  <mitz@apple.com>
2578
2579         Removed MiniBrowser.entitlements.
2580
2581         Rubber-stamped by Anders Carlsson.
2582
2583         The entitlements weren’t used anyway.
2584
2585         * MiniBrowser/MiniBrowser.entitlements: Removed.
2586         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2587
2588 2015-09-24  Daniel Bates  <dabates@apple.com>
2589
2590         Add WebKitSystemInterface for iOS 9.0
2591         https://bugs.webkit.org/show_bug.cgi?id=149550
2592
2593         Rubber-stamped by Alexey Proskuryakov.
2594
2595         * Scripts/copy-webkitlibraries-to-product-directory:
2596
2597 2015-09-24  Daniel Bates  <dabates@apple.com>
2598
2599         Support building for arbitrary architectures
2600         https://bugs.webkit.org/show_bug.cgi?id=149539
2601
2602         Reviewed by Alexey Proskuryakov.
2603
2604         Teach buildbot to pass the architectures associated with the builder to build-webkit
2605         when building on OS X and iOS. As a side effect of this change we now support building
2606         universal binaries when multiples architectures are specified.
2607
2608         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2609         (CompileWebKit.start):
2610
2611 2015-09-24  Daniel Bates  <dabates@apple.com>
2612
2613         Fix the build after <http://trac.webkit.org/changeset/190212>
2614         (http://trac.webkit.org/changeset/190212)
2615
2616         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
2617
2618         * BuildSlaveSupport/built-product-archive:
2619         (main):
2620
2621 2015-09-24  Daniel Bates  <dabates@apple.com>
2622
2623         Support running unit tests on iOS Simulator test bot
2624         https://bugs.webkit.org/show_bug.cgi?id=149536
2625
2626         Reviewed by Alexey Proskuryakov.
2627
2628         Implements support for running unit tests on a iOS test bot. At the time of writing,
2629         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
2630
2631         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2632         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
2633         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
2634
2635 2015-09-24  Daniel Bates  <dabates@apple.com>
2636
2637         Add support infrastructure for OpenSource iOS builders and testers
2638         https://bugs.webkit.org/show_bug.cgi?id=149534
2639
2640         Reviewed by Darin Adler.
2641
2642         Towards setting up OpenSource iOS build bots, teach buildbot and its support
2643         scripts about iOS.
2644
2645         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2646         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
2647         --ios-simulator or --device for a builder/tester whose full platform name begins with
2648         "ios-simulator" or "ios", respectively.
2649         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
2650         * BuildSlaveSupport/built-product-archive:
2651         (main): Pass the full platform name to determineWebKitBuildDirectory().
2652         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
2653         command line flag when building for iOS.
2654         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
2655         parameter fullPlatform. This parameter was originally added in r125066 to support the
2656         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
2657         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
2658         * BuildSlaveSupport/clean-build:
2659         (main): Call script webkit-build-directory with the appropriate command line flag when
2660         building for iOS.
2661         * BuildSlaveSupport/delete-stale-build-files:
2662         (main): Use the same logic for iOS as we do for Mac.
2663         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
2664         flag when building for iOS.
2665         * BuildSlaveSupport/test-result-archive:
2666         (archiveTestResults): Use the same logic for iOS as we do for Mac.
2667
2668 2015-09-24  Daniel Bates  <dabates@apple.com>
2669
2670         Remove Chromium-specific changes to script built-product-archive
2671         https://bugs.webkit.org/show_bug.cgi?id=149530
2672
2673         Rubber-stamped by Csaba Osztrogonác.
2674
2675         Reverts changes made in r113074 and r113067 to support Chromium testers. The
2676         Chromium code has long since been removed from the OpenSource WebKit Project.
2677
2678         * BuildSlaveSupport/built-product-archive:
2679         (createZipManually):
2680         (createZip):
2681         (archiveBuiltProduct):
2682
2683 2015-09-24  Dan Bernstein  <mitz@apple.com>
2684
2685         Build fix.
2686
2687         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2688
2689 2015-09-24  Mark Lam  <mark.lam@apple.com>
2690
2691         Unreviewed. Make Lucas Forschler a WebKit reviewer.
2692
2693         * Scripts/webkitpy/common/config/contributors.json:
2694
2695 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2696
2697         Unreviewed. Fix GObject DOM API breaks after r190120.
2698
2699         Bring back code removed in r169931 to handle documentation of
2700         deleted classes.
2701
2702         * gtk/webkitdom.py:
2703         (WebKitDOMDocGenerator):
2704         (WebKitDOMDocGenerator.write_deleted_classes):
2705         (WebKitDOMDocGenerator.generate):
2706         (write_deleted_classes):
2707         (WebKitDOMDocGeneratorSections._deleted_class):
2708         (WebKitDOMDocGeneratorSections._deleted_class.in):
2709         (WebKitDOMDocGeneratorSections.write_deleted_classes):
2710         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
2711
2712 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
2713
2714         [Cocoa] [Font Features] Implement font-variant-*
2715         https://bugs.webkit.org/show_bug.cgi?id=148413
2716
2717         Reviewed by Darin Adler.
2718
2719         Update test font to use "lnum" feature.
2720
2721         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2722         (Generator::appendGSUBTable):
2723
2724 2015-09-22  Andy Estes  <aestes@apple.com>
2725
2726         ContentFiltering.AllowDownloadAfterAddData is very flaky
2727         https://bugs.webkit.org/show_bug.cgi?id=148885
2728         <rdar://problem/22729563>
2729
2730         Reviewed by Alexey Proskuryakov.
2731
2732         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
2733         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
2734         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
2735
2736         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2737         (downloadTest):
2738
2739 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
2740
2741         Mavericks: Media tests start to time out after a few days of bot uptime
2742         https://bugs.webkit.org/show_bug.cgi?id=149468
2743
2744         Reviewed by Chris Dumez.
2745
2746         * Scripts/webkitpy/port/base.py:
2747         * Scripts/webkitpy/port/driver.py:
2748         * Scripts/webkitpy/port/mac.py:
2749
2750 2015-09-22  Nan Wang  <n_wang@apple.com>
2751
2752         Unreviewed, add myself to the committers list.
2753
2754         * Scripts/webkitpy/common/config/contributors.json:
2755
2756 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2757
2758         Remove 'nullable' to fix older iOS builds.
2759
2760         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2761         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2762
2763 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2764
2765         [Win] Show tiled drawing debug overlay on Windows
2766         https://bugs.webkit.org/show_bug.cgi?id=149426
2767
2768         Reviewed by Dean Jackson.
2769
2770         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
2771         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
2772         * MiniBrowser/win/Common.cpp:
2773         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
2774         flag if needed.
2775         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
2776
2777 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2778
2779         [Win] Use command-line argument to launch in regular or High DPI mode.
2780         https://bugs.webkit.org/show_bug.cgi?id=149417
2781
2782         Reviewed by Dean Jackson.
2783
2784         * MiniBrowser/win/Common.cpp:
2785         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
2786         very start of execution, before the MiniBrowser.dll is loaded.
2787         * win/DLLLauncher/DLLLauncherMain.cpp:
2788         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
2789         present. On WinCairo, always use High DPI.
2790
2791 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2792
2793         32-bit Mac build fix attempt after r190065.
2794
2795         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2796
2797 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
2798
2799         [OS X] Update for Xcode 7.0 on Yosemite
2800         https://bugs.webkit.org/show_bug.cgi?id=149389
2801
2802         Reviewed by Dan Bernstein.
2803
2804         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2805         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2806         Removed unneeded declarations - conforming to a protocol is sufficient.
2807
2808         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2809         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2810         Changed the definitions to be compiled whenever the SDK requires it (so we will have
2811         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
2812
2813 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2814
2815         Add the ability for tests to run script in the UI process in WebKitTestRunner
2816         https://bugs.webkit.org/show_bug.cgi?id=149356
2817
2818         Reviewed by Tim Horton.
2819
2820         This change adds testRunner.runUIScript(script, callback), which allows a test
2821         to execute script in a JSContext which runs in the UI process. That context
2822         has bindings exposed through the UIScriptController interface; currently one test
2823         function, and some iOS-specific functions are included. UIScriptController can be
2824         async with a callback, and runUIScript() itself is asynchronous. When the UI 
2825         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
2826         is a string passed back to the web process, and given to the runUIScript()
2827         callback function.
2828         
2829         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
2830
2831         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
2832         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
2833         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2834         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
2835         complete, call back into TestRunner.
2836         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2837         (WTR::nextUIScriptCallbackID):
2838         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
2839         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
2840         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2841         * WebKitTestRunner/PlatformWebView.h:
2842         * WebKitTestRunner/TestController.cpp:
2843         (WTR::updateTestOptionsFromTestHeader):
2844         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
2845         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
2846         * WebKitTestRunner/TestInvocation.cpp:
2847         (WTR::TestInvocation::shouldUseFixedLayout):
2848         (WTR::TestInvocation::shouldUseThreadedScrolling):
2849         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2850         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2851         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
2852         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
2853         * WebKitTestRunner/TestInvocation.h:
2854         * WebKitTestRunner/TestOptions.h:
2855         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2856         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2857         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2858         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
2859         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2860         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2861         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2862         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
2863         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2864         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
2865         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
2866         (WTR::UIScriptController::doAsyncTask):
2867         (WTR::UIScriptController::zoomToScale):
2868         (WTR::UIScriptController::zoomScale):
2869         (WTR::UIScriptController::minimumZoomScale):
2870         (WTR::UIScriptController::maximumZoomScale):
2871         (WTR::UIScriptController::contentVisibleRect):
2872         * WebKitTestRunner/mac/EventSenderProxy.mm:
2873         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2874         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
2875         * WebKitTestRunner/mac/TestControllerMac.mm:
2876         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2877         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
2878         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2879         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
2880         (UIScriptContext::UIScriptContext):
2881         (UIScriptContext::~UIScriptContext):
2882         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
2883         asynchronous, call the callback.
2884         (UIScriptContext::nextTaskCallbackID):
2885         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
2886         that has a callback). Has to store the callbackID of the script, so code called from the completion
2887         callback knows which UI script invoked it.
2888         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
2889         (UIScriptContext::uiScriptComplete):
2890         (UIScriptContext::objectFromRect): Make a JS object from a rect.
2891         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2892         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
2893         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2894         (WTR::UIScriptController::UIScriptController):
2895         (WTR::UIScriptController::makeWindowObject):
2896         (WTR::UIScriptController::wrapperClass):
2897         (WTR::UIScriptController::doAsyncTask):
2898         (WTR::UIScriptController::zoomToScale):
2899         (WTR::UIScriptController::zoomScale):
2900         (WTR::UIScriptController::minimumZoomScale):
2901         (WTR::UIScriptController::maximumZoomScale):
2902         (WTR::UIScriptController::contentVisibleRect):
2903         (WTR::UIScriptController::uiScriptComplete):
2904         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2905         (WTR::UIScriptController::create):
2906         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
2907
2908 2015-09-21  Tim Horton  <timothy_horton@apple.com>
2909
2910         Turn on threaded scrolling by default in the tests
2911         https://bugs.webkit.org/show_bug.cgi?id=149377
2912
2913         Reviewed by Simon Fraser.
2914
2915         * WebKitTestRunner/mac/TestControllerMac.mm:
2916         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2917         (WTR::shouldUseThreadedScrolling): Deleted.
2918         Turn on threaded scrolling by default.
2919
2920 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2921
2922         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
2923         https://bugs.webkit.org/show_bug.cgi?id=149252
2924
2925         Reviewed by Darin Adler.
2926
2927         In case of glib tests the test runner notifies about tests
2928         crashing, but for google tests we don't get any feedback, which
2929         means that in case of a test crashing we get a list of **PASS**
2930         messages and at the summary we are notified that the test suite
2931         has failed, but it's impossible to know which test cases have failed.
2932
2933         * Scripts/run-gtk-tests:
2934         (TestRunner._run_google_test): Add a **CRASH** message if test
2935         case crashed.
2936
2937 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2938
2939         WebKitTestRunner can leak user content script results between tests
2940         https://bugs.webkit.org/show_bug.cgi?id=149391
2941
2942         Reviewed by Sam Weinig.
2943
2944         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
2945         about:blank, and thus about:blank doesn't have unintended side effects.
2946
2947         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2948         (WTR::InjectedBundle::beginTesting):
2949         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2950         (WTR::InjectedBundlePage::resetAfterTest):
2951
2952 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2953
2954         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
2955         https://bugs.webkit.org/show_bug.cgi?id=149384
2956
2957         Reviewed by Chris Fleizach.
2958
2959         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2960         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
2961         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
2962         regardless of whether someone else holds a reference (we also call -stopListening in
2963         -dealloc).
2964
2965         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2966         (AccessibilityController::platformResetToConsistentState):
2967         (AccessibilityController::addNotificationListener):
2968         Ditto.
2969
2970 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2971
2972         Remove XHR_TIMEOUT compilation guard
2973         https://bugs.webkit.org/show_bug.cgi?id=149260
2974
2975         Reviewed by Benjamin Poulain.
2976
2977         * Scripts/webkitperl/FeatureList.pm:
2978
2979 2015-09-19  Dan Bernstein  <mitz@apple.com>
2980
2981         Attempted build fix.
2982
2983         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2984
2985 2015-09-18  Commit Queue  <commit-queue@webkit.org>
2986
2987         Unreviewed, rolling out r189908.
2988         https://bugs.webkit.org/show_bug.cgi?id=149368
2989
2990         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
2991
2992         Reverted changeset:
2993
2994         "printing does not use minimum page zoom factor"
2995         https://bugs.webkit.org/show_bug.cgi?id=108507
2996         http://trac.webkit.org/changeset/189908
2997
2998 2015-09-18  Andy Estes  <aestes@apple.com>
2999
3000         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
3001         https://bugs.webkit.org/show_bug.cgi?id=149360
3002
3003         Reviewed by Tim Horton.
3004
3005         Added an API test.
3006
3007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3008         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
3009         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3010         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3011         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
3012         (TEST):
3013         * TestWebKitAPI/ios/pages.pages: Added.
3014
3015 2015-09-18  Nan Wang  <n_wang@apple.com>
3016
3017         AX: Implement ARIA 1.1 @aria-current on iOS
3018         https://bugs.webkit.org/show_bug.cgi?id=149297
3019
3020         Reviewed by Chris Fleizach.
3021
3022         Added support to test aria-current on iOS.
3023
3024         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3025         (AccessibilityUIElement::stringAttributeValue):
3026         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3027         (WTR::AccessibilityUIElement::stringAttributeValue):
3028
3029 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
3030
3031         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
3032         https://bugs.webkit.org/show_bug.cgi?id=149352
3033
3034         Reviewed by Simon Fraser.
3035
3036         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3037         m_context can be null. This may indicate a bug in webkitpy too, but
3038         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
3039         wrong with opening and immediately closing it.
3040
3041 2015-09-18  Daniel Bates  <dabates@apple.com>
3042
3043         isGitSVNDirectory() returns true when Git is not installed
3044         https://bugs.webkit.org/show_bug.cgi?id=149351
3045
3046         Reviewed by Alexey Proskuryakov.
3047
3048         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
3049         Git is not installed on the machine.
3050
3051         * Scripts/VCSUtils.pm:
3052         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
3053         status code 0 (success).
3054
3055 2015-09-18  Alex Christensen  <achristensen@webkit.org>
3056
3057         Prevent build-webkit from building four times on Windows 
3058         https://bugs.webkit.org/show_bug.cgi?id=149336
3059
3060         Reviewed by Brent Fulgham.
3061
3062         * Scripts/build-webkit:
3063         Move the Windows code out of the for loop iterating over each subdirectory to be build.
3064         They're built all at once.
3065         * Scripts/webkitdirs.pm:
3066         (buildVisualStudioProject):
3067         (cmakeGeneratedBuildfile):
3068         Don't generate the Visual Studio solution if it already exists.
3069         It will run CMake again if necessary.
3070
3071 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3072
3073         [iOS WK2] WTR fails to set the key window in the UIKit sense
3074         https://bugs.webkit.org/show_bug.cgi?id=149325
3075
3076         Reviewed by Tim Horton.
3077
3078         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
3079         This causes UIKit to bypass code that actually sets the key window, resulting in
3080         [UIAppliation sharedApplication].keyWindow always being nil.
3081
3082         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
3083         -[WebKitTestRunnerWindow isKeyWindow] call super.
3084
3085         * WebKitTestRunner/PlatformWebView.h:
3086         (WTR::PlatformWebView::setWindowIsKey): Deleted.
3087         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3088         (WTR::PlatformWebView::setWindowIsKey):
3089         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3090         (WTR::PlatformWebView::setWindowIsKey):
3091         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3092         (-[WebKitTestRunnerWindow isKeyWindow]):
3093         (WTR::PlatformWebView::PlatformWebView):
3094         (WTR::PlatformWebView::~PlatformWebView):
3095         (WTR::PlatformWebView::setWindowIsKey):
3096         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3097         (WTR::PlatformWebView::setWindowIsKey):
3098
3099 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3100
3101         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
3102         https://bugs.webkit.org/show_bug.cgi?id=149321
3103
3104         Reviewed by Tim Horton.
3105         
3106         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
3107         enabled the "testing" viewport configuration, which disables page scaling.
3108         
3109         If we're running viewport tests, we want the normal web page configuration.
3110         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
3111         based on whether the test is in a "viewport" directory.
3112
3113         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3114         (WTR::InjectedBundle::beginTesting):
3115         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3116         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
3117         * WebKitTestRunner/TestInvocation.cpp:
3118         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3119         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3120         (WTR::TestInvocation::shouldMakeViewportFlexible):
3121         (WTR::TestInvocation::invoke):
3122         * WebKitTestRunner/TestInvocation.h:
3123         * WebKitTestRunner/ios/TestControllerIOS.mm:
3124         (WTR::TestController::platformConfigureViewForTest):
3125         (WTR::shouldMakeViewportFlexible): Deleted.
3126
3127 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3128
3129         Give iOS WebKitTestRunner a launch storyboard
3130         https://bugs.webkit.org/show_bug.cgi?id=149314
3131
3132         Reviewed by Dan Bates.
3133         
3134         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
3135         that it's been built for specific device configurations, and puts the window
3136         at the top of the screen. This simplifies coordinate conversions in a future patch.
3137
3138         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3139         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
3140         * WebKitTestRunner/ios/Launch.storyboard: Added.
3141
3142 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
3143
3144         Update licence in r189890
3145         https://bugs.webkit.org/show_bug.cgi?id=149306
3146
3147         Reviewed by Dean Jackson.
3148
3149         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3150         * FontWithFeatures/FontWithFeatures/FontCreator.h:
3151         * FontWithFeatures/FontWithFeatures/main.cpp:
3152
3153 2015-09-17  Mark Lam  <mark.lam@apple.com>
3154
3155         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
3156         https://bugs.webkit.org/show_bug.cgi?id=149285
3157
3158         Reviewed by Saam Barati.
3159
3160         Just need to add an option to pass --no-jit to run-jsc-stress-test.
3161
3162         * Scripts/run-javascriptcore-tests:
3163         (runJSCStressTests):
3164
3165 2015-09-17  Alex Christensen  <achristensen@webkit.org>
3166
3167         Switch AppleWin build to use CMake
3168         https://bugs.webkit.org/show_bug.cgi?id=149163
3169
3170         Reviewed by Brent Fulgham.
3171
3172         * Scripts/build-webkit:
3173         * Scripts/run-api-tests:
3174         (runTest):
3175         (listAllTests):
3176         (prepareEnvironmentForRunningTestTool):
3177         (testToolPaths):
3178         (testToolPath): Deleted.
3179         Run the API tests as separate executables on Windows.
3180         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3181         * Scripts/webkitdirs.pm:
3182         (checkRequiredSystemConfig):
3183         (jhbuildWrapperPrefixIfNeeded):
3184         (generateBuildSystemFromCMakeProject):
3185         Fix configuration quirks.
3186
3187 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
3188
3189         Added toggle options for hiding and showing certain platform families on the dashboard.
3190         https://bugs.webkit.org/show_bug.cgi?id=148403
3191
3192         Reviewed by David Kilzer.
3193
3194         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
3195         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
3196         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
3197         in lieu of an "all" button in the toggle menu.
3198
3199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3200         (parsePlatformFamily): Helper function to parse out a platform family.
3201         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
3202         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
3203         (updateToggleButtons): Updates the status of the toggle buttons.
3204         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
3205         (documentReady): Added creation of toggle buttons.
3206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3207         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
3208         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
3209         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
3210         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
3211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3212         (QueueView): Updated to use hiddenPlatformFamilies.
3213         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3215         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
3216         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
3217         (Settings.prototype.toggleHiddenPlatform): Deleted.
3218         (Settings.prototype.clearHiddenPlatforms): Deleted.
3219         (Settings.prototype.toggleShowPlatformFamily): Deleted.
3220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3221         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
3222         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
3223         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
3224         (table.queue-grid tr.headers th):
3225         (div.settingsWrapper.hide):
3226         (div.settingsWrapper):
3227         (div.familyToggleWrapper):
3228         (div.platformFamilyToggleButton):
3229         (div.platformFamilyShowToggleButton:not(:last-child)):
3230         (div.familyShown):
3231         (div.accessibilityButton):
3232         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
3233         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
3234         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
3235         platformFamilyToggleButton and settingsWrapper class.
3236         (.accessibilityButton): Deleted.
3237
3238 2015-09-17  Tim Horton  <timothy_horton@apple.com>
3239
3240         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
3241         https://bugs.webkit.org/show_bug.cgi?id=148904
3242
3243         Reviewed by Myles Maxfield.
3244
3245         * WebKitTestRunner/TestController.cpp:
3246         (WTR::parseBooleanTestHeaderValue):
3247         (WTR::updateViewOptionsFromTestHeader):
3248         Check for the key "useThreadedScrolling".
3249         Add some code to check for "true" and "false" for boolean options.
3250
3251         (WTR::TestController::viewOptionsForTest):
3252         Apply the test's overrides last, even after the platform's.
3253
3254 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3255
3256         printing does not use minimum page zoom factor
3257         https://bugs.webkit.org/show_bug.cgi?id=108507
3258
3259         Reviewed by Darin Adler.
3260
3261         WebKitTestRunner always takes the snapshots from the UI process
3262         (expect for IOS), so in the case of printing, the layout in the
3263         web view is not the expected one. When printing, we need to take
3264         the snapshot in the web process and ensure it's rendered with a
3265         PrintContext.
3266
3267         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3268         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
3269         kWKSnapshotOptionsPrinting option to
3270         WKBundlePageCreateSnapshotWithOptions() when printing. When not
3271         printing, don't even create the snapshot, since it will be ignored
3272         by the UI process that always creates its own from the WebView (expect for IOS platform)
3273         * WebKitTestRunner/TestInvocation.cpp:
3274         (WTR::TestInvocation::dumpResults): Use always the snapshot image
3275         received from the web process if any when comparing pixel
3276         results. Now we only receive a snapshot from the web process in
3277         case of printing, or when platform is IOS. Otherwhise, generate
3278         the snapshot from the WebView as usual.
3279         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
3280         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
3281         is created by the caller now, but the CG implementation needs to
3282         know if it's a Web or UI process snapshot.
3283         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3284         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3285         cairo surface for the given image.
3286         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3287         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3288         CGContext for the given image.
3289
3290 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
3291
3292         Create a font which can be used for testing font features
3293         https://bugs.webkit.org/show_bug.cgi?id=149237
3294
3295         Reviewed by Simon Fraser.
3296
3297         This patch adds a new project in the Tools/ directory which generates a font which can
3298         be used for testing font features. This is a standalone project consisting of two files:
3299         1. A file which actually generates the byte vector representing the font. This file has
3300         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
3301         specific, and only relies on the C++ STL.
3302         2. A file with a main() which calls generateFont() and writes out the font, as well as
3303         uses the font to render some demonstration text into a .png file. This file is platform
3304         specific.
3305
3306         The font itself only supports the following characters:
3307         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
3308         However, the shape of these letters are either an X or a check mark.
3309
3310         The letter "A" always is a check mark.
3311         The letter "B" always is an X.
3312         Without any font features turned on, the rest of the letters are shown as X.
3313
3314         Each font feature has an letter associated with it. When the font feature is enabled,
3315         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
3316         as a check mark.
3317
3318         Here are the mappings of font features to letters:
3319         liga: C
3320         clig: D
3321         dlig: E
3322         hlig: F
3323         calt: G
3324         subs: H
3325         sups: I
3326         smcp: J
3327         c2sc: K
3328         pcap: L
3329         c2pc: M
3330         unic: N
3331         titl: O
3332         onum: P
3333         pnum: Q
3334         tnum: R
3335         frac: S
3336         afrc: T
3337         ordn: U
3338         zero: V
3339         hist: W
3340         jp78: X
3341         jp83: Y
3342         jp90: Z
3343         jp04: a
3344         smpl: b
3345         trad: c
3346         fwid: d
3347         pwid: e
3348         ruby: f
3349
3350         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
3351         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
3352         (integralLog2):
3353         (roundDownToPowerOfTwo):
3354         (isFourByteAligned):
3355         (clampTo):
3356         (append32):
3357         (writeCFFEncodedNumber):
3358         (CFFBuilder::CFFBuilder):
3359         (CFFBuilder::takeResult):
3360         (CFFBuilder::moveTo):
3361         (CFFBuilder::lineTo):
3362         (CFFBuilder::curveToCubic):
3363         (CFFBuilder::closePath):
3364         (CFFBuilder::writePoint):
3365         (generateBoxCharString):
3366         (generateCheckCharString):
3367         (generateXCharString):
3368         (charStringForGlyph):
3369         (Generator::generate):
3370         (Generator::Placeholder::Placeholder):
3371         (Generator::Placeholder::populate):
3372         (Generator::Placeholder::~Placeholder):
3373         (Generator::placeholder):
3374         (Generator::append16):
3375         (Generator::append32):
3376         (Generator::append32BitCode):
3377         (Generator::overwrite16):
3378         (Generator::overwrite32):
3379         (Generator::appendCFFTable):
3380         (Generator::appendSubstitutionSubtable):
3381         (Generator::appendScriptSubtable):
3382         (Generator::appendGSUBTable):
3383         (Generator::appendOS2Table):
3384         (Generator::appendFormat12CMAPTable):
3385         (Generator::appendFormat4CMAPTable):
3386         (Generator::appendCMAPTable):
3387         (Generator::appendHEADTable):
3388         (Generator::appendHHEATable):
3389         (Generator::appendHMTXTable):
3390         (Generator::appendMAXPTable):
3391         (Generator::appendNAMETable):
3392         (Generator::appendPOSTTable):
3393         (Generator::calculateChecksum):
3394         (Generator::appendTable):
3395         (generateFont):
3396         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
3397         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
3398         (drawTextWithFeature):
3399         (main):
3400
3401 2015-09-16  Commit Queue  <commit-queue@webkit.org>
3402
3403         Unreviewed, rolling out r189875 and r189878.
3404         https://bugs.webkit.org/show_bug.cgi?id=149235
3405
3406         cygwin cmake build not ready yet (Requested by alexchristensen
3407         on #webkit).
3408
3409         Reverted changesets:
3410
3411         "Switch AppleWin build to use CMake"
3412         https://bugs.webkit.org/show_bug.cgi?id=149163
3413         http://trac.webkit.org/changeset/189875
3414
3415         "Cygwin build fix after r189875"
3416         http://trac.webkit.org/changeset/189878
3417
3418 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3419
3420         Cygwin build fix after r189875
3421
3422         * Scripts/build-webkit:
3423         * Scripts/webkitdirs.pm:
3424         (jhbuildWrapperPrefixIfNeeded):
3425         (generateBuildSystemFromCMakeProject):
3426         Make things work with cygwin and cmake.
3427
3428 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3429
3430         Switch AppleWin build to use CMake
3431         https://bugs.webkit.org/show_bug.cgi?id=149163
3432
3433         Reviewed by Brent Fulgham.
3434
3435         * Scripts/build-webkit:
3436         Build with CMake.
3437         * Scripts/run-api-tests:
3438         (runTest):
3439         (listAllTests):
3440         (prepareEnvironmentForRunningTestTool):
3441         (testToolPaths):
3442         (testToolPath): Deleted.
3443         Run the API tests as separate executables on Windows.
3444         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3445
3446 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
3447
3448         Add newer build.webkit.org pages to robots.txt
3449         https://bugs.webkit.org/show_bug.cgi?id=149219
3450
3451         Reviewed by Darin Adler.
3452
3453         Indexing bot watcher's dashboard can't be good.
3454
3455         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
3456
3457 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3458
3459         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
3460
3461         * BuildSlaveSupport/built-product-archive:
3462         (unzipArchive):
3463
3464 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3465
3466         [EFL] Fix the help message of separated web process option of MiniBrowser
3467         https://bugs.webkit.org/show_bug.cgi?id=149212
3468
3469         Reviewed by Gyuyoung Kim.
3470
3471         * MiniBrowser/efl/main.c:
3472
3473 2015-09-16  Alex Christensen  <achristensen@webkit.org>
3474
3475         Fix python syntax after r189851.
3476
3477         * BuildSlaveSupport/built-product-archive:
3478         (unzipArchive):
3479         For loops need a colon.
3480
3481 2015-09-15  Alex Christensen  <achristensen@webkit.org>
3482
3483         Fix Windows test bots after changing to non-cygwin build
3484         https://bugs.webkit.org/show_bug.cgi?id=149196
3485
3486         Reviewed by Daniel Bates.
3487
3488         * BuildSlaveSupport/built-product-archive:
3489         (unzipArchive):
3490         Using different versions of python makes what I think is https://bugs.python.org/issue15795
3491         prevent us from executing files from the archive on the test bots.
3492
3493 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
3494
3495         Add ShadowRoot interface and Element.prototype.attachShadow
3496         https://bugs.webkit.org/show_bug.cgi?id=149187
3497
3498         Reviewed by Antti Koivisto.
3499
3500         * Scripts/webkitperl/FeatureList.pm:
3501
3502 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
3503
3504         Appscale queue status json output lacks bots
3505         https://bugs.webkit.org/show_bug.cgi?id=149194
3506         <rdar://problem/22171089>
3507
3508         Reviewed by Alexey Proskuryakov.
3509
3510         * QueueStatusServer/handlers/queuestatusjson.py:
3511         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
3512         * QueueStatusServer/index.yaml: Index according to appscale requirements.
3513
3514 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
3515
3516         [Win] Provide a means for viewing the layer tree
3517         https://bugs.webkit.org/show_bug.cgi?id=149165
3518
3519         Reviewed by Simon Fraser.
3520
3521         Update MiniBrowser with a new Debug menu option that will
3522         dump the current layer tree to the debug console.
3523         
3524         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
3525         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
3526         * MiniBrowser/win/Common.cpp:
3527         (WndProc): Add handler for 'Print Layer Tree' menu option.
3528         * MiniBrowser/win/MiniBrowser.cpp:
3529         (MiniBrowser::printLayerTree): Added Handler.
3530         * MiniBrowser/win/MiniBrowser.h:
3531
3532 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
3533
3534         WebKitTestRunner declarative language setting is broken for iOS
3535         https://bugs.webkit.org/show_bug.cgi?id=149119
3536
3537         Unreviewed.
3538
3539         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
3540         lost in the final version which got committed. This simply implements the existing
3541         OS X behavior on iOS.
3542
3543         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3544         (WTR::InjectedBundle::platformInitialize):
3545
3546 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
3547
3548         Unreviewed, add myself to committers list.
3549
3550         * Scripts/webkitpy/common/config/contributors.json:
3551
3552 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
3553
3554         [Cocoa] Allow testing with the system language
3555         https://bugs.webkit.org/show_bug.cgi?id=148671
3556
3557         Reviewed by Anders Carlsson and Alexey Proskuryakov.
3558
3559         React to tests marked with language=lang1,lang2,etc in their header.
3560         Once this information is parsed, pass it to
3561         WKContextConfigurationSetOverrideLanguages().
3562
3563         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3564         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
3565         list.
3566         * WebKitTestRunner/TestController.cpp:
3567         (WTR::TestController::createWebViewWithOptions): Call
3568         WKContextConfigurationSetOverrideLanguages().
3569         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
3570         * WebKitTestRunner/TestOptions.h:
3571         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3572         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
3573         option to restart the web process.
3574         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3575         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
3576
3577 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
3578
3579         [WKTR] Allow changing the WKContextConfiguration between successive tests
3580         https://bugs.webkit.org/show_bug.cgi?id=148833
3581
3582         Reviewed by Tim Horton.
3583
3584         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3585         However, there are certain tests which require specifying options in this object. This patch makes
3586         our existing code for recreating the test runner web view also recreate the WKContext.
3587
3588         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3589         class.
3590
3591         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3592         * WebKitTestRunner/PlatformWebView.h:
3593         (WTR::PlatformWebView::options):
3594         * WebKitTestRunner/TestController.cpp:
3595         (WTR::TestController::initialize):
3596         (WTR::TestController::generateContextConfiguration):
3597         (WTR::TestController::generatePageConfiguration):
3598         (WTR::TestController::createWebViewWithOptions):
3599         (WTR::TestController::ensureViewSupportsOptionsForTest):
3600         (WTR::updateContextConfigurationOptionsFromTestHeader):
3601         (WTR::TestController::contextConfigurationOptionsForTest):
3602         (WTR::TestController::platformCreateWebView):
3603         (WTR::TestController::platformCreateOtherPage):
3604         (WTR::updateViewOptionsFromTestHeader): Deleted.
3605         (WTR::TestController::viewOptionsForTest): Deleted.
3606         * WebKitTestRunner/TestController.h:
3607         (WTR::TestController::injectedBundlePath):