REGRESSION (iOS 13): Tests that simulate multiple back-to-back single taps fail or...
[WebKit-https.git] / Tools / ChangeLog
1 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         REGRESSION (iOS 13): Tests that simulate multiple back-to-back single taps fail or time out
4         https://bugs.webkit.org/show_bug.cgi?id=201129
5         <rdar://problem/51857277>
6
7         Reviewed by Tim Horton.
8
9         The tests in editing/pasteboard/ios were timing out on iOS 13 before this change. This is because they simulate
10         back-to-back single taps; while this is recognized as two single taps on iOS 12 and prior, only the first single
11         tap is recognized on iOS 13 (and the second is simply dropped on the floor). This occurs because the synthetic
12         single tap gesture is reset slightly later on iOS 13 compared to iOS 12, so when the second tap is dispatched,
13         the gesture recognizer is still in "ended" state after the first tap on iOS 13, which means the gesture isn't
14         capable of recognizing further touches yet.
15
16         In UIKit, a gesture recognizer is only reset once its UIGestureEnvironment's containing dependency subgraph no
17         longer contains gestures that are active. In iOS 12, the synthetic click gesture is a part of a dependency
18         subgraph that contains only itself and the normal (blocking) double tap gesture which requires the click to fail
19         before it can be recognized; immediately after simulating the tap, both these gestures are inactive, which
20         allows both of them to be reset.
21
22         However, in iOS 13, the synthetic click gesture is part of a gesture dependency graph that contains the double
23         tap for double click gesture, as well as the non-blocking double tap gesture, both of which are still active
24         immediately after sending the first tap. This change in dependencies is caused by the introduction of
25         UIUndoGestureInteraction's single and double three-finger tap gestures, which (in -[UIUndoGestureInteraction
26         gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]) explicitly add all other taps as failure
27         requirements. This effectively links the synthetic single tap gesture to most of the other gestures in
28         WKContentView's dependency graph by way of these tap gestures for the undo interaction.
29
30         All this means that there is now a short (~50 ms) delay after the synthetic single tap gestures is recognized,
31         before it can be recognized again. To account for this new delay in our test infrastructure, simply wait for
32         single tap gestures that have ended to reset before attempting to send subsequent single taps. We do this by
33         introducing WebKit testing SPI to invoke a completion handler after resetting the synthetic click gesture (only
34         if necessary - i.e., if the gesture is in ended state when we are about to begin simulating the tap). This
35         allows calls to `UIScriptController::singleTapAtPoint` to be reliably recognized as single taps without
36         requiring arbitrary 120 ms "human speed" delays.
37
38         This fixes a number of flaky or failing layout tests, including the tests in editing/pasteboard/ios.
39
40         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
41         * TestRunnerShared/UIScriptContext/UIScriptController.h:
42         (WTR::UIScriptController::doubleTapAtPoint):
43
44         Add a `delay` parameter to `doubleTapAtPoint`. A number of layout tests were actually simulating double click
45         gestures by simulating two back-to-back single taps; this is done for the purposes of being able to add a "human
46         speed" delay prior to the second single tap gesture. After the change to wait for the single tap gesture to
47         reset before attempting to simulate the next tap, this strategy no longer works, since the second gesture is
48         recognized only as a single tap instead of a double tap.
49
50         Instead, we add a delay parameter to `UIScriptController::doubleTapAtPoint`, which the "human speed" double tap
51         gestures use instead to wait after simulating the first tap.
52
53         * WebKitTestRunner/ios/HIDEventGenerator.h:
54         * WebKitTestRunner/ios/HIDEventGenerator.mm:
55         (-[HIDEventGenerator _waitFor:]):
56         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:delay:completionBlock:]):
57
58         Plumb the tap gesture delay through to this helper method.
59
60         (-[HIDEventGenerator tap:completionBlock:]):
61         (-[HIDEventGenerator doubleTap:delay:completionBlock:]):
62         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
63         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]): Deleted.
64         (-[HIDEventGenerator doubleTap:completionBlock:]): Deleted.
65         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
66         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
67         (WTR::UIScriptControllerIOS::waitForSingleTapToReset const):
68
69         Add a new helper to wait for the content view's single tap gesture to reset if needed; call this before
70         attempting to simulate single taps (either using a stylus, or with a regular touch).
71
72         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
73         (WTR::UIScriptControllerIOS::doubleTapAtPoint):
74         (WTR::UIScriptControllerIOS::stylusTapAtPointWithModifiers):
75
76 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
77
78         results.webkit.org: Allow clicking on the tooltip arrow
79         https://bugs.webkit.org/show_bug.cgi?id=201103
80
81         Rubber-stamped by Aakash Jain.
82
83         By design, the arrow sits above the canvas and intercepts mouse events from it.
84         This will often make an element that has a tooltip unclickable.
85
86         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
87         (xAxisFromScale):
88         (TimelineFromEndpoint.prototype.render.onDotEnterFactory):
89         (TimelineFromEndpoint.prototype.render):
90         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
91         (_ToolTip):
92         (_ToolTip.prototype.toString): Trigger onClick callback when the arrow is clicked.
93         (_ToolTip.prototype.set): Set the onClick callback.
94
95 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
96
97         [EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot
98         https://bugs.webkit.org/show_bug.cgi?id=201140
99
100         Reviewed by Jonathan Bedard.
101
102         * BuildSlaveSupport/ews-build/steps.py:
103         (TestWithFailureCount.getResultSummary): Do not append (failure) when in case of custom status.
104         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
105
106 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
107
108         run-webkit-tests: Cap the number of automatically booted simulators at 12
109         https://bugs.webkit.org/show_bug.cgi?id=201139
110
111         Reviewed by Aakash Jain.
112
113         To make local development with simulators more pleasant, machines should
114         never automatically boot more than 12 simulators.
115
116         * Scripts/webkitpy/xcode/simulated_device.py:
117         (SimulatedDeviceManager.max_supported_simulators):
118
119 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
120
121         [ews] Add EWS queue for applying watchlist
122         https://bugs.webkit.org/show_bug.cgi?id=201072
123
124         Reviewed by Jonathan Bedard.
125
126         * BuildSlaveSupport/ews-build/steps.py:
127         (ApplyWatchList): Build step to apply watchlist.
128         (ApplyWatchList.__init__): Set logEnviron to False.
129         (ApplyWatchList.getResultSummary): Updated the description in case of failure.
130         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
131         * BuildSlaveSupport/ews-build/factories.py:
132         (WatchListFactory): Build factory for WatchList.
133         * BuildSlaveSupport/ews-build/loadConfig.py:
134         * BuildSlaveSupport/ews-build/config.json:
135
136 2019-08-26  Youenn Fablet  <youenn@apple.com>
137
138         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
139         https://bugs.webkit.org/show_bug.cgi?id=196870
140
141         Reviewed by Alex Christensen.
142
143         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
144         Accept any server certificate by default.
145
146         * WebKitTestRunner/TestController.cpp:
147         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
148         (WTR::TestController::cocoaResetStateToConsistentValues):
149         (WTR::TestController::setAllowsAnySSLCertificate):
150         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
151         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
152         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
153         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
154
155 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
156
157         Increase log level for watchlist result
158         https://bugs.webkit.org/show_bug.cgi?id=201081
159
160         Reviewed by Jonathan Bedard.
161
162         * Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
163         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
164         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
165
166 2019-08-23  Chris Dumez  <cdumez@apple.com>
167
168         [geolocation] Rename interfaces and remove [NoInterfaceObject]
169         https://bugs.webkit.org/show_bug.cgi?id=200885
170
171         Reviewed by Alex Christensen.
172
173         * DumpRenderTree/mac/TestRunnerMac.mm:
174         (TestRunner::setMockGeolocationPosition):
175
176 2019-08-23  Ryan Haddad  <ryanhaddad@apple.com>
177
178         Unreviewed, rolling out r249001.
179
180         Caused one layout test to fail on all configurations and
181         another to time out on Catalina / iOS 13.
182
183         Reverted changeset:
184
185         "Add a WebsiteDataStore delegate to handle
186         AuthenticationChallenge that do not come from pages"
187         https://bugs.webkit.org/show_bug.cgi?id=196870
188         https://trac.webkit.org/changeset/249001
189
190 2019-08-23  Jonathan Bedard  <jbedard@apple.com>
191
192         results.webkit.org: Escape html in changelog
193         https://bugs.webkit.org/show_bug.cgi?id=201025
194         <rdar://problem/54564837>
195
196         Reviewed by Darin Adler.
197
198         * resultsdbpy/resultsdbpy/view/commit_view.py:
199         (CommitView.commit): Output a dictionary instead of a JSON encoded string.
200         * resultsdbpy/resultsdbpy/view/templates/commit.html: Unpack commits dictionary
201         directly into a JavaScript dictionary.
202
203 2019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
204
205         [WebAuthn] Support NFC authenticators for iOS
206         https://bugs.webkit.org/show_bug.cgi?id=188624
207         <rdar://problem/43354214>
208
209         Reviewed by Chris Dumez.
210
211         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
212         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
213         Setup NFC mock testing configuration.
214
215 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
216
217         [ews] Enable Style queue on new EWS
218         https://bugs.webkit.org/show_bug.cgi?id=201071
219
220         Reviewed by Jonathan Bedard.
221
222         * BuildSlaveSupport/ews-build/config.json: Enabled the scheduler for Style queue.
223         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled style queue bubble on new EWS.
224         * QueueStatusServer/config/queues.py: Removed style queue from old EWS.
225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
226         (BubbleQueueServer): Removed style queue from bot-watcher's dashboard.
227
228 2019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
229
230         [Win][MiniBrowser] URL bar should be updated for in-page navigations
231         https://bugs.webkit.org/show_bug.cgi?id=201032
232
233         Reviewed by Darin Adler.
234
235         * MiniBrowser/win/BrowserWindow.h: Added activeURLChanged to BrowserWindowClient interface.
236         * MiniBrowser/win/MainWindow.cpp:
237         (MainWindow::init):
238         (MainWindow::activeURLChanged): Added.
239         * MiniBrowser/win/MainWindow.h:
240         * MiniBrowser/win/MiniBrowserWebHost.cpp:
241         (MiniBrowserWebHost::didCommitLoadForFrame):
242         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Added.
243         (MiniBrowserWebHost::updateAddressBar): Deleted.
244         (MiniBrowserWebHost::loadURL): Deleted.
245         * MiniBrowser/win/MiniBrowserWebHost.h:
246         (MiniBrowserWebHost::MiniBrowserWebHost):
247         (MiniBrowserWebHost::didCommitLoadForFrame): Deleted.
248         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Deleted.
249         * MiniBrowser/win/PrintWebUIDelegate.cpp:
250         * MiniBrowser/win/WebKitBrowserWindow.cpp:
251         (WebKitBrowserWindow::create):
252         (WebKitBrowserWindow::WebKitBrowserWindow):
253         (WebKitBrowserWindow::didChangeIsLoading): Removed an unused variable.
254         (WebKitBrowserWindow::didChangeActiveURL): Added.
255         (WebKitBrowserWindow::createNewPage):
256         (WebKitBrowserWindow::didCommitNavigation): Deleted.
257         * MiniBrowser/win/WebKitBrowserWindow.h: Removed m_urlBarWnd.
258         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
259         (WebKitLegacyBrowserWindow::create):
260         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
261         (WebKitLegacyBrowserWindow::init):
262         (WebKitLegacyBrowserWindow::navigateToHistory):
263         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Removed m_urlBarWnd.
264
265 2019-08-22  Andy Estes  <aestes@apple.com>
266
267         [watchOS] Disable Content Filtering in the simulator build
268         https://bugs.webkit.org/show_bug.cgi?id=201047
269
270         Reviewed by Tim Horton.
271
272         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
273
274 2019-08-22  Chris Dumez  <cdumez@apple.com>
275
276         Try to recover nicely when getting an unexpected schema in the service workers database
277         https://bugs.webkit.org/show_bug.cgi?id=201002
278         <rdar://problem/54574991>
279
280         Reviewed by Youenn Fablet.
281
282         Add API test coverage.
283
284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
285         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
286
287 2019-08-22  Keith Rollin  <krollin@apple.com>
288
289         Remove support for tvOS < 13.0
290         https://bugs.webkit.org/show_bug.cgi?id=200963
291         <rdar://problem/54541355>
292
293         Reviewed by Tim Horton.
294
295         Update conditionals that reference __TV_OS_VERSION_MIN_REQUIRED and
296         __TV_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
297         130000. This means that expressions like "__TV_OS_VERSION_MIN_REQUIRED
298         < 130000" are always False and "__TV_OS_VERSION_MIN_REQUIRED >=
299         130000" are always True.
300
301         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
302         (TestWebKitAPI::TEST):
303
304 2019-08-22  Daniel Bates  <dabates@apple.com>
305
306         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
307         https://bugs.webkit.org/show_bug.cgi?id=200742
308
309         Reviewed by Simon Fraser.
310
311         The OptionSet synthetic provider must respond to requests for the value of m_storage
312         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
313         of the type summary.
314
315         Synthetic providers substitute alternative debug information (children) for the default
316         information for a variable. The OptionSet type summary is implemented in terms of the
317         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
318         before invoking the type summary handler then evaluating GetChildMemberWithName() on
319         the SBValue passed to the type summary handler will access the substitute information
320         instead of the original debug information. As a result OptionSet's synthetic provider's
321         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
322         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
323         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
324         should return a valid value.
325
326         * lldb/lldb_webkit.py:
327         (FlagEnumerationProvider.__init__):
328         (FlagEnumerationProvider):
329         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
330         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
331         (FlagEnumerationProvider.size): Added.
332         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
333         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
334         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
335         and removed self.size. For the latter we can just expose a getter that returns the size of
336         the list self._elements.
337         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
338         value of m_storage.
339         (WTFOptionSetProvider):
340         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
341         matches the specified index.
342         * lldb/lldb_webkit_unittest.py:
343         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Update expected result now
344         that we return the value of m_storage as the last synthetic child.
345
346 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
347
348         results.webkit.org: Remove branch and repository information from commit tooltip
349         https://bugs.webkit.org/show_bug.cgi?id=201035
350
351         Reviewed by Aakash Jain.
352
353         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
354         (xAxisFromScale): Remove branch and repository information from tooltip.
355
356 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
357
358         run-webkit-tests: Use -noBulkSymbolication when calling spindump
359         https://bugs.webkit.org/show_bug.cgi?id=201000
360         <rdar://problem/53778938>
361
362         Reviewed by Alexey Proskuryakov.
363
364         * Scripts/webkitpy/port/darwin.py:
365         (DarwinPort.sample_process): Attempt to symbolicate with -noBulkSymbolication first.
366         * Scripts/webkitpy/port/darwin_testcase.py:
367         (DarwinTest.test_tailspin):
368         (DarwinTest.test_get_crash_log): Deleted.
369         * Scripts/webkitpy/port/ios_device_unittest.py:
370         (IOSDeviceTest.test_tailspin):
371
372 2019-08-22  Zhifei Fang  <zhifei_fang@apple.com>
373
374         [results.webkit.org Webkit.css] Change input's disable style
375         The disable input style will always show the label like it has a value 
376         https://bugs.webkit.org/show_bug.cgi?id=200998
377
378         Reviewed by Jonathan Bedard.
379
380         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value
381         *resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs:
382         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
383         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
384         (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value
385         (.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,):
386         (@media (prefers-color-scheme: dark)):
387
388 2019-08-17  Darin Adler  <darin@apple.com>
389
390         Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends
391         https://bugs.webkit.org/show_bug.cgi?id=200862
392
393         Reviewed by Ryosuke Niwa.
394
395         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
396         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Use makeString.
397         * WebKitTestRunner/TestController.cpp:
398         (WTR::TestController::findAndDumpWebKitProcessIdentifiers): Ditto.
399         (WTR::TestController::downloadDidReceiveServerRedirectToURL): Ditto.
400         (WTR::TestController::downloadDidFail): Ditto.
401
402 2019-08-22  clopez@igalia.com  <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
403
404         [GTK][WPE] Support for command "--version" on the MiniBrowser (follow-up fix)
405         https://bugs.webkit.org/show_bug.cgi?id=200978
406
407         Unreviewed follow-up fix.
408
409         Update the string format specifier for unsigned it.
410
411         * MiniBrowser/gtk/main.c:
412         (main):
413         * MiniBrowser/wpe/main.cpp:
414         (main):
415
416 2019-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
417
418         [GTK][WPE] Support for command "--version" on the MiniBrowser
419         https://bugs.webkit.org/show_bug.cgi?id=200978
420
421         Reviewed by Žan Doberšek.
422
423         Printing the engine version used from the MiniBrowser is useful.
424         For example, the test scripts on WPT can use this info to better
425         tag the generated results.
426
427         * MiniBrowser/gtk/main.c: Print the engine version when called with --version or -v.
428         (main):
429         * MiniBrowser/wpe/main.cpp: Ditto.
430         (main):
431
432 2019-08-22  Youenn Fablet  <youenn@apple.com>
433
434         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
435         https://bugs.webkit.org/show_bug.cgi?id=196870
436
437         Reviewed by Alex Christensen.
438
439         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
440         Accept any server certificate by default.
441
442         * WebKitTestRunner/TestController.cpp:
443         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
444         (WTR::TestController::cocoaResetStateToConsistentValues):
445         (WTR::TestController::setAllowsAnySSLCertificate):
446         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
447         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
448         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
449         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
450
451 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
452
453         results.webkit.org: Fix drawer style
454         https://bugs.webkit.org/show_bug.cgi?id=200988
455
456         Rubber-stamped by Aakash Jain.
457
458         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
459         (Drawer): Nothing in the drawer should be selectable.
460         (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
461         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
462         (.action:hover): Disable underline on 'links' which are actually actions
463         (.unselectable): Make a div unselectable.
464         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
465         (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
466
467 2019-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
468
469         [Win][MiniBrowser] Add a progress indicator to the main window
470         https://bugs.webkit.org/show_bug.cgi?id=200970
471
472         Reviewed by Alex Christensen.
473
474         * MiniBrowser/win/BrowserWindow.h: Added BrowserWindowClient class.
475         * MiniBrowser/win/MainWindow.cpp:
476         (MainWindow::init):
477         (MainWindow::resizeSubViews):
478         (MainWindow::progressChanged):
479         (MainWindow::progressFinished):
480         * MiniBrowser/win/MainWindow.h: Inherited BrowserWindowClient.
481         Added m_hProgressIndicator.
482         (MainWindow::hwnd const): Deleted.
483         (MainWindow::browserWindow const): Deleted.
484         (): Deleted.
485         * MiniBrowser/win/MiniBrowserWebHost.cpp:
486         (MiniBrowserWebHost::onNotify):
487         * MiniBrowser/win/MiniBrowserWebHost.h:
488         * MiniBrowser/win/WebKitBrowserWindow.cpp:
489         (WebKitBrowserWindow::create):
490         (WebKitBrowserWindow::WebKitBrowserWindow):
491         (WebKitBrowserWindow::didChangeIsLoading):
492         (WebKitBrowserWindow::didChangeEstimatedProgress):
493         (WebKitBrowserWindow::createNewPage):
494         * MiniBrowser/win/WebKitBrowserWindow.h:
495         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
496         (WebKitLegacyBrowserWindow::create):
497         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
498         (WebKitLegacyBrowserWindow::init):
499         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
500
501 2019-08-21  Ryan Haddad  <ryanhaddad@apple.com>
502
503         Unreviewed, rolling out r248970.
504
505         Caused
506         lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
507         to fail.
508
509         Reverted changeset:
510
511         "[lldb-webkit] OptionSet summary shows size 0 sometimes for
512         non-empty set"
513         https://bugs.webkit.org/show_bug.cgi?id=200742
514         https://trac.webkit.org/changeset/248970
515
516 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
517
518         results.webkit.org: Add database table to save zip archives to
519         https://bugs.webkit.org/show_bug.cgi?id=200718
520
521         Rubber-stamped by Aakash Jain.
522
523         * resultsdbpy/resultsdbpy/model/archive_context.py: Added.
524         (ArchiveContext):
525         (ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
526         (ArchiveContext.ArchivesByCommit.unpack):
527         (ArchiveContext.assert_zipfile):
528         (ArchiveContext.open_zipfile):
529         (ArchiveContext.__init__):
530         (ArchiveContext.__enter__):
531         (ArchiveContext.__exit__):
532         (ArchiveContext.register): Save the provided archive to Cassandra.
533         (ArchiveContext.find_archive): Find all archives matching the specified criteria.
534         (ArchiveContext._files_for_archive):
535         (ArchiveContext.ls): List all files in the matching archives.
536         (ArchiveContext.file): Extract a file from the matching archives.
537         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
538         (ArchiveContextTest):
539         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
540         (MockModelFactory):
541         (MockModelFactory.process_results):
542         (MockModelFactory.add_mock_archives):
543         * resultsdbpy/resultsdbpy/model/model.py:
544         (Model.__init__): Add an ArchiveContext to the model.
545
546 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
547
548         [ews-build] view layout test results option should be displayed next to layout-test build step
549         https://bugs.webkit.org/show_bug.cgi?id=200048
550
551         Reviewed by Jonathan Bedard.
552
553         * BuildSlaveSupport/ews-build/steps.py:
554         (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
555         (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
556
557 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
558
559         [ews] Fix capitalization in Found x new Test failure message
560         https://bugs.webkit.org/show_bug.cgi?id=201004
561
562         Reviewed by Alexey Proskuryakov.
563
564         * BuildSlaveSupport/ews-build/steps.py:
565         (AnalyzeLayoutTestsResults.report_failure):
566         (AnalyzeAPITestsResults.analyzeResults):
567         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
568
569 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
570
571         Assign ews117 to EWS High-Sierra Debug queues
572         https://bugs.webkit.org/show_bug.cgi?id=200993
573
574         Reviewed by Jonathan Bedard.
575
576         * BuildSlaveSupport/ews-build/config.json:
577
578 2019-08-21  Daniel Bates  <dabates@apple.com>
579
580         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
581         https://bugs.webkit.org/show_bug.cgi?id=200742
582
583         Reviewed by Simon Fraser.
584
585         The OptionSet synthetic provider must respond to requests for the value of m_storage
586         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
587         of the type summary.
588
589         Synthetic providers substitute alternative debug information (children) for the default
590         information for a variable. The OptionSet type summary is implemented in terms of the
591         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
592         before invoking the type summary handler then evaluating GetChildMemberWithName() on
593         the SBValue passed to the type summary handler will access the substitute information
594         instead of the original debug information. As a result OptionSet's synthetic provider's
595         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
596         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
597         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
598         should return a valid value.
599
600         * lldb/lldb_webkit.py:
601         (FlagEnumerationProvider.__init__):
602         (FlagEnumerationProvider):
603         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
604         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
605         (FlagEnumerationProvider.size): Added.
606         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
607         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
608         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
609         and removed self.size. For the latter we can just expose a getter that returns the size of
610         the list self._elements.
611         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
612         value of m_storage.
613         (WTFOptionSetProvider):
614         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
615         matches the specified index.
616
617 2019-08-21  Alex Christensen  <achristensen@webkit.org>
618
619         Disabling text autosizing should prevent text autosizing
620         https://bugs.webkit.org/show_bug.cgi?id=200955
621         <rdar://problem/48095374>
622
623         Reviewed by Simon Fraser.
624
625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
626         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
627         (TEST):
628
629 2019-08-21  Adrian Perez de Castro  <aperez@igalia.com>
630
631         [GTK][WPE] Make debug-test-runner work
632         https://bugs.webkit.org/show_bug.cgi?id=193576
633
634         Reviewed by Michael Catanzaro.
635
636         * Scripts/webkitdirs.pm:
637         (wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
638         (setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
639         TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
640         (execUnixAppForDebugging): Added.
641         (debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
642
643 2019-08-20  Ryosuke Niwa  <rniwa@webkit.org>
644
645         Put keygen element behind a runtime flag and disable it by default
646         https://bugs.webkit.org/show_bug.cgi?id=200850
647
648         Reviewed by Antti Koivisto.
649
650         Added the support for enableKeygenElement test runner option, which enables keygen element in layout tests.
651
652         * DumpRenderTree/TestOptions.cpp:
653         (TestOptions::TestOptions):
654         * DumpRenderTree/TestOptions.h:
655         * DumpRenderTree/mac/DumpRenderTree.mm:
656         (setWebPreferencesForTestOptions):
657         * DumpRenderTree/win/DumpRenderTree.cpp:
658         (setWebPreferencesForTestOptions):
659         * WebKitTestRunner/TestController.cpp:
660         (WTR::TestController::resetPreferencesToConsistentValues):
661         (WTR::updateTestOptionsFromTestHeader):
662         * WebKitTestRunner/TestOptions.h:
663         (WTR::TestOptions::hasSameInitializationOptions const):
664
665 2019-08-21  Chris Dumez  <cdumez@apple.com>
666
667         Add internal setting to disable SecureContext checks
668         https://bugs.webkit.org/show_bug.cgi?id=200980
669         <rdar://problem/54438512>
670
671         Reviewed by Alex Christensen.
672
673         Add API test coverage.
674
675         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
676         (log):
677         (requestPermission):
678
679 2019-08-21  Keith Rollin  <krollin@apple.com>
680
681         Remove support for watchOS < 6.0
682         https://bugs.webkit.org/show_bug.cgi?id=200937
683         <rdar://problem/54524009>
684
685         Reviewed by Darin Adler.
686
687         Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and
688         __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
689         60000. This means that expressions like
690         "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and
691         "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True.
692
693         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
694         (TestWebKitAPI::TEST):
695
696 2019-08-20  Zhifei Fang  <zhifei_fang@apple.com>
697
698         [results.webkit.org Webkit.css] Add right sidebar
699         https://bugs.webkit.org/show_bug.cgi?id=200946
700
701         Reviewed by Jonathan Bedard.
702
703         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
704         (@media screen and (min-width: 600px) and (orientation: landscape)):
705         (.main.left):
706         (@media screen and (min-width: 768px) and (orientation: landscape)):
707         (.sidebar.right):
708
709 2019-08-20  Jonathan Bedard  <jbedard@apple.com>
710
711         results.webkit.org: Add ToolTips
712         https://bugs.webkit.org/show_bug.cgi?id=200801
713
714         Rubber-stamped by Aakash Jain.
715
716         When dots or scale labels are hovered over, we should display a tool tip with additional information about
717         The specific element.
718
719         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Added.
720         (.tooltip): Add class for ToolTip text box.
721         (.tooltip-arrow-up): Add class for ToolTip arrow pointing up.
722         (.tooltip-arrow-down): Add class for ToolTip arrow pointing down.
723         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
724         (_CommitBank.prototype.commitsDuringUuid): Return a list of commits which were the trunk of their respective
725         repositories at a given time.
726         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
727         (xAxisFromScale): Add callbacks triggered when the mouse enters or leaves elements in the scale canvas.
728         (TimelineFromEndpoint.render): Add callbacks triggered when the mouse enters or leaves dot elements.
729         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js: Added.
730         (isPointInElement): Given an element and a point, return true if that point is within the bounds of the element.
731         (_ToolTip):
732         (_ToolTip.prototype.set): Set the content and location of the ToolTip.
733         (_ToolTip.prototype.toString): Return the html needed to render the ToolTip.
734         (_ToolTip.prototype.unset): Clear and hide the ToolTip.
735         (_ToolTip.prototype.isIn): Check if a given point is contained within the ToolTip.
736         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
737         (Timeline.CanvasSeriesComponent): Convert onHover events to onEnter/onLeave events. Add toolTips points to both
738         dot and scale elements.
739         * resultsdbpy/resultsdbpy/view/templates/search.html: Add ToolTip.
740         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
741
742 2019-08-20  Justin Michaud  <justin_michaud@apple.com>
743
744         Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
745         https://bugs.webkit.org/show_bug.cgi?id=200782
746
747         Reviewed by Saam Barati.
748
749         * Scripts/run-jsc-stress-tests:
750
751 2019-08-20  Darin Adler  <darin@apple.com>
752
753         Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly
754         https://bugs.webkit.org/show_bug.cgi?id=200921
755
756         Reviewed by Saam Barati.
757
758         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
759         Changed tests to use EXPECT macros instead of ASSERT macros since we don't
760         need to abort after the first failure. Added three new tests to the VariadicAppend
761         test to cover various cases of upconverting from 8-bit to 16-bit strings.
762
763 2019-08-20  Dean Jackson  <dino@apple.com>
764
765         REGRESSION: Open in New Tab is missing from context menu
766         https://bugs.webkit.org/show_bug.cgi?id=200909
767         <rdar://problem/54476169>
768
769         Reviewed by Simon Fraser.
770
771         Add a new test that runs through the legacy context menu
772         flow, and verifies that it will be called if there aren't
773         appropriate delegates for the new API.
774
775         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
776         (contextMenuWebViewDriver):
777         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
778         (TEST):
779         (-[LegacyPreviewViewController previewActionItems]):
780         (-[LegacyContextMenuUIDelegate webView:shouldPreviewElement:]):
781         (-[LegacyContextMenuUIDelegate webView:previewingViewControllerForElement:defaultActions:]):
782         (-[LegacyContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
783         (-[LegacyContextMenuUIDelegate _webView:contextMenuDidEndForElement:]):
784         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
785
786 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
787
788         [JSC] OSR entry to Wasm OMG
789         https://bugs.webkit.org/show_bug.cgi?id=200362
790
791         Reviewed by Michael Saboff.
792
793         * Scripts/run-jsc-stress-tests:
794
795 2019-08-19  Zhifei Fang  <zhifei_fang@apple.com>
796
797         [results.webkit.org Timeline] Disable back gesture
798         https://bugs.webkit.org/show_bug.cgi?id=200839
799
800         Reviewed by Jonathan Bedard.
801
802         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
803         * resultsdbpy/resultsdbpy/view/templates/base.html:
804
805 2019-08-19  Jonathan Bedard  <jbedard@apple.com>
806
807         results-webkit.org: Add timeout to Redis locks
808         https://bugs.webkit.org/show_bug.cgi?id=200890
809
810         Reviewed by Aakash Jain.
811
812         * resultsdbpy/resultsdbpy/model/upload_context.py:
813         (UploadContext._find_job_with_attempts): Add timeout to Redis lock.
814
815 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
816
817         Remove IDB-specific quota
818         https://bugs.webkit.org/show_bug.cgi?id=196545
819         <rdar://problem/54201783>
820
821         Reviewed by Youenn Fablet.
822
823         * DumpRenderTree/TestRunner.cpp:
824         (TestRunner::staticFunctions):
825         (setIDBPerOriginQuotaCallback): Deleted.
826         * DumpRenderTree/TestRunner.h:
827         * DumpRenderTree/mac/DumpRenderTree.mm:
828         (runTest):
829         * DumpRenderTree/mac/TestRunnerMac.mm:
830         (TestRunner::setIDBPerOriginQuota): Deleted.
831         * DumpRenderTree/win/TestRunnerWin.cpp:
832         (TestRunner::setIDBPerOriginQuota): Deleted.
833         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
834         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
835         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
836         * WebKitTestRunner/InjectedBundle/TestRunner.h:
837         * WebKitTestRunner/TestController.cpp:
838         (WTR::TestController::resetStateToConsistentValues):
839         (WTR::TestController::setIDBPerOriginQuota): Deleted.
840         * WebKitTestRunner/TestController.h:
841         * WebKitTestRunner/TestInvocation.cpp:
842         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
843
844 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
845
846         [WTF] Style checker should tell errors when it finds std::make_unique
847         https://bugs.webkit.org/show_bug.cgi?id=200878
848
849         Reviewed by Ross Kirsling.
850
851         * Scripts/webkitpy/style/checkers/cpp.py:
852         (check_wtf_make_unique):
853         (check_style):
854         (CppChecker):
855
856 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
857
858         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
859         https://bugs.webkit.org/show_bug.cgi?id=200620
860
861         Reviewed by Geoffrey Garen.
862
863         * DumpRenderTree/TestRunner.cpp:
864         (addURLToRedirectCallback):
865         (setWillSendRequestClearHeaderCallback):
866         (TestRunner::setAccummulateLogsForChannel):
867         (TestRunner::runUIScript):
868         (TestRunner::setOpenPanelFiles):
869         * DumpRenderTree/mac/DumpRenderTree.mm:
870         (dumpFramesAsText):
871         * DumpRenderTree/mac/EventSendingController.mm:
872         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
873         * DumpRenderTree/win/DRTDataObject.cpp:
874         (DRTDataObject::SetData):
875         * DumpRenderTree/win/FrameLoadDelegate.cpp:
876         (FrameLoadDelegate::FrameLoadDelegate):
877         * DumpRenderTree/win/UIDelegate.cpp:
878         (DRTUndoManager::DRTUndoManager):
879         (UIDelegate::UIDelegate):
880         (UIDelegate::resetUndoManager):
881         * TestWebKitAPI/JavaScriptTest.cpp:
882         (TestWebKitAPI::runJSTest):
883         * TestWebKitAPI/PlatformUtilities.cpp:
884         (TestWebKitAPI::Util::toSTD):
885         * TestWebKitAPI/Tests/WTF/Expected.cpp:
886         (TestWebKitAPI::TEST):
887         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
888         (TestWebKitAPI::TEST):
889         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
890         (TestWebKitAPI::TEST):
891         (TestWebKitAPI::testMovingUsingEnsure):
892         (TestWebKitAPI::testMovingUsingAdd):
893         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
894         (TestWebKitAPI::TEST):
895         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
896         (TestWebKitAPI::TEST):
897         * TestWebKitAPI/Tests/WTF/Lock.cpp:
898         (TestWebKitAPI::runLockTest):
899         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
900         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
901         (TestWebKitAPI::TEST):
902         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
903         (TestWebKitAPI::TEST):
904         * TestWebKitAPI/Tests/WTF/Variant.cpp:
905         (TestWebKitAPI::TEST):
906         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
907         (TestWebKitAPI::TEST):
908         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:
909         (TestWebKitAPI::CARingBufferTest::SetUp):
910         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
911         (TestWebKitAPI::createTestValue):
912         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
913         (TestWebKitAPI::TEST):
914         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
915         (TestWebKitAPI::TEST_F):
916         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
917         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
918         (TestWebKitAPI::createNewPage):
919         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
920         (TestWebKitAPI::createNewPage):
921         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
922         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
923         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
924         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
925         (TestWebKitAPI::WebKit2WillLoadTest::SetUp):
926         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
927         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
928         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
929         (serverCallback):
930         (testWebViewAuthenticationProxyHTTPS):
931         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
932         (WebKitDOMDOMWindowTest::create):
933         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
934         (TestWebKitAPI::Util::toSTD):
935         * TestWebKitAPI/cocoa/TestWKWebView.mm:
936         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
937         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
938         * TestWebKitAPI/mac/TestFontOptions.mm:
939         (-[TestFontOptions initWithFontOptions:]):
940         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
941         (WTR::EventSendingController::callAfterScrollingCompletes):
942         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
943         (WTR::InjectedBundle::didCreatePage):
944         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
945         (WTR::TestRunner::setOpenPanelFiles):
946         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
947         * WebKitTestRunner/StringFunctions.h:
948         (WTR::toSTD):
949         (WTR::toWTFString):
950         * WebKitTestRunner/TestController.cpp:
951         (WTR::TestController::initialize):
952         (WTR::TestController::generatePageConfiguration):
953         (WTR::TestController::resetStateToConsistentValues):
954         (WTR::createTestURL):
955         (WTR::TestController::runTest):
956         (WTR::TestController::platformCreateWebView):
957         * WebKitTestRunner/TestInvocation.cpp:
958         (WTR::TestInvocation::runUISideScript):
959         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
960         (WTR::TestController::platformCreateWebView):
961         (WTR::TestController::setDefaultCalendarType):
962         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
963         (WTR::getGDKKeySymForKeyRef):
964         * WebKitTestRunner/ios/TestControllerIOS.mm:
965         (WTR::TestController::platformResetStateToConsistentValues):
966         (WTR::TestController::setKeyboardInputModeIdentifier):
967         * WebKitTestRunner/mac/EventSenderProxy.mm:
968         (WTR::EventSenderProxy::mouseDown):
969         (WTR::EventSenderProxy::mouseUp):
970         (WTR::EventSenderProxy::mouseMoveTo):
971         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
972         (WTR::wpeKeySymForKeyRef):
973
974 2019-08-17  Ross Kirsling  <ross.kirsling@sony.com>
975
976         [ESNext] Implement optional chaining
977         https://bugs.webkit.org/show_bug.cgi?id=200199
978
979         Reviewed by Yusuke Suzuki.
980
981         * Scripts/run-jsc-stress-tests:
982
983 2019-08-17  Tim Horton  <timothy_horton@apple.com>
984
985         Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
986         https://bugs.webkit.org/show_bug.cgi?id=200866
987         <rdar://problem/50254021>
988
989         Reviewed by Simon Fraser.
990
991         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
992         (WTR::PlatformWebView::windowSnapshotImage):
993         Replace some logging with release assertions that we are snapshotting a reasonable
994         view and get a reasonable snapshot back. Failing to snapshot is a big deal, and
995         "silently" failing with just a log that will be ignored is not helpful.
996
997 2019-08-17  Yusuke Suzuki  <ysuzuki@apple.com>
998
999         [WTF] ThreadGroupRemove test is flaky
1000         https://bugs.webkit.org/show_bug.cgi?id=200763
1001
1002         Reviewed by Mark Lam.
1003
1004         ThreadGroup.ThreadGroupRemove test is flaky since its `threadRunning` modification and check in Thread are racy.
1005         It can lead to infinite wait on waitForCompletion. We should do more idiomatic to avoid race: When notifying condition
1006         variables, we should first take a lock, modify the condition shared and notify the condition change while taking a lock,
1007         and releasing the lock after that.
1008
1009         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1010         (TestWebKitAPI::TEST):
1011
1012 2019-08-17  Eric Liang  <ericliang@apple.com>
1013
1014         Tested that accessibility WebProcessLoader bundle is loaded for the correct path.
1015         https://bugs.webkit.org/show_bug.cgi?id=200367
1016
1017         Reviewed by Darin Adler.
1018
1019         Added AccessibilityTestPlugin on the web process to report whether a bundle is loaded and its path, so that it can be tested on WKContentView. 
1020
1021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1022         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestPlugin.mm: Added.
1023         (-[AccessibilityTestPlugin webProcessPlugIn:didCreateBrowserContextController:]):
1024         (-[AccessibilityTestPlugin checkAccessibilityWebProcessLoaderBundleIsLoaded:]):
1025         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestSupportProtocol.h: Added.
1026         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1027         (TestWebKitAPI::TEST):
1028
1029 2019-08-17  Sam Weinig  <weinig@apple.com>
1030
1031         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
1032         https://bugs.webkit.org/show_bug.cgi?id=200756
1033
1034         Reviewed by Darin Adler.
1035
1036         Update call sites for rename from StringBuilder::flexibleAppend(...) to 
1037         StringBuilder::append(...).
1038
1039         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1040         (TestWebKitAPI::TEST):
1041
1042 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
1043
1044         [iOS WK2] Scroll indicators disappear sometimes
1045         https://bugs.webkit.org/show_bug.cgi?id=200791
1046
1047         Reviewed by Tim Horton.
1048
1049         Tests that test that scroll indicators survive subview replacement, and that
1050         a custom view also survives subview replacement.
1051
1052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1053         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
1054         (TestWebKitAPI::TEST):
1055         * TestWebKitAPI/cocoa/TestWKWebView.h:
1056         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1057         (-[TestWKWebView performAfterLoading:]):
1058         (-[UIView wkFirstSubviewWithClass:]):
1059         (-[UIView wkFirstSubviewWithBoundsSize:]):
1060         * TestWebKitAPI/ios/composited.html: Added.
1061         * TestWebKitAPI/ios/overflow-scroll.html: Added.
1062
1063 2019-08-16  John Wilander  <wilander@apple.com>
1064
1065         Add John Wilander as WebKit Reviewer
1066         https://bugs.webkit.org/show_bug.cgi?id=200837
1067
1068         Unreviewed update to contributors.json to change my status to reviewer.
1069         See email on reviewers mailing list for proof of granted privileges.
1070
1071         * Scripts/webkitpy/common/config/contributors.json:
1072
1073 2019-08-16  Timothy Hatcher  <timothy@apple.com>
1074
1075         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
1076         https://bugs.webkit.org/show_bug.cgi?id=200802
1077         rdar://problem/54357818
1078
1079         Reviewed by Tim Horton.
1080
1081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
1082         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
1083         (-[OpaqueTestWKWebView isOpaque]): Added.
1084         (-[NonOpaqueTestWKWebView isOpaque]): Added.
1085         (isOpaque): Added.
1086         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
1087         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
1088         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
1089
1090 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
1091
1092         [ews] Add build steps for Windows Factory
1093         https://bugs.webkit.org/show_bug.cgi?id=200813
1094
1095         Reviewed by Jonathan Bedard.
1096
1097         * BuildSlaveSupport/ews-build/factories.py:
1098         (WindowsFactory.__init__):
1099
1100 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
1101
1102         [ews] Report machine uptime in PrintConfiguration
1103         https://bugs.webkit.org/show_bug.cgi?id=200812
1104
1105         Reviewed by Jonathan Bedard.
1106
1107         * BuildSlaveSupport/ews-build/steps.py:
1108         (PrintConfiguration): Added uptime command.
1109         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1110
1111 2019-08-16  Chris Lord  <clord@igalia.com>
1112
1113         Add shared-mime-info to WPE WebKit jhbuild
1114         https://bugs.webkit.org/show_bug.cgi?id=200768
1115
1116         Reviewed by Carlos Alberto Lopez Perez.
1117
1118         * wpe/jhbuild.modules:
1119
1120 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
1121
1122         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
1123         https://bugs.webkit.org/show_bug.cgi?id=200620
1124
1125         Reviewed by Geoffrey Garen.
1126
1127         * DumpRenderTree/AccessibilityController.h:
1128         * DumpRenderTree/GCController.h:
1129         * DumpRenderTree/win/DRTDataObject.cpp:
1130         * DumpRenderTree/win/DRTDataObject.h:
1131         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1132         * DumpRenderTree/win/DRTDropSource.h:
1133         * DumpRenderTree/win/DraggingInfo.h:
1134         * DumpRenderTree/win/EditingDelegate.h:
1135         * DumpRenderTree/win/EventSender.cpp:
1136         * DumpRenderTree/win/FrameLoadDelegate.h:
1137         * DumpRenderTree/win/HistoryDelegate.h:
1138         * DumpRenderTree/win/MD5.h:
1139         * DumpRenderTree/win/PolicyDelegate.h:
1140         * DumpRenderTree/win/ResourceLoadDelegate.h:
1141         * DumpRenderTree/win/TextInputController.h:
1142         * DumpRenderTree/win/UIDelegate.cpp:
1143         * DumpRenderTree/win/UIDelegate.h:
1144         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1145         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
1146         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
1147         * TestWebKitAPI/Counters.h:
1148         * TestWebKitAPI/PlatformWebView.h:
1149         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1150         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1151         (TestWebKitAPI::DerefObserver::ref):
1152         (TestWebKitAPI::DerefObserver::deref):
1153         (TestWebKitAPI::TEST):
1154         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1155         (TestWebKitAPI::DerefObserver::ref):
1156         (TestWebKitAPI::DerefObserver::deref):
1157         (TestWebKitAPI::TEST):
1158         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
1159         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1160         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1161         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1162         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
1163         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
1164         * WebKitTestRunner/EventSenderProxy.h:
1165         * WebKitTestRunner/GeolocationProviderMock.h:
1166         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1167         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1168         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1169         * WebKitTestRunner/PlatformWebView.h:
1170         * WebKitTestRunner/TestInvocation.h:
1171
1172 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
1173
1174         Some improvements on web storage
1175         https://bugs.webkit.org/show_bug.cgi?id=200373
1176
1177         Reviewed by Geoffrey Garen.
1178
1179         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
1180         (TEST): update expectation for behavior change.
1181
1182         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to 
1183         database file.
1184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1185         (WTR::TestRunner::syncLocalStorage):
1186         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1187
1188         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
1189         (WTR::TestController::resetStateToConsistentValues):
1190         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
1191         (WTR::StorageVoidCallback):
1192         (WTR::TestController::clearIndexedDatabases):
1193         (WTR::TestController::clearLocalStorage):
1194         (WTR::TestController::syncLocalStorage):
1195         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
1196         with StorageVoidCallbackContext for general usage.
1197         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
1198         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
1199         * WebKitTestRunner/TestController.h:
1200
1201         * WebKitTestRunner/TestInvocation.cpp:
1202         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message 
1203         SyncLocalStorage.
1204
1205 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
1206
1207         results.webkit.org: Add content hook to FlaskRequestsResponse
1208         https://bugs.webkit.org/show_bug.cgi?id=200721
1209
1210         Rubber-stamped by Aakash Jain.
1211
1212         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
1213         (FlaskRequestsResponse):
1214         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
1215         Response, conforming to request's API.
1216
1217 2019-08-15  Alex Christensen  <achristensen@webkit.org>
1218
1219         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
1220         https://bugs.webkit.org/show_bug.cgi?id=200750
1221         <rdar://problem/54232261> and <rdar://problem/52355829>
1222
1223         Reviewed by Tim Horton.
1224
1225         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1226         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1227         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1228         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
1229         (contextMenuWebViewDriver):
1230         (TEST):
1231
1232 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
1233
1234         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
1235         https://bugs.webkit.org/show_bug.cgi?id=200726
1236
1237         Reviewed by Simon Fraser.
1238
1239         To get the pixels as an array of colors, draw the image into a memory
1240         context. The backing memory buffer can then be accessed to get the image
1241         pixels' colors.
1242
1243         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1244         (TestWebKitAPI::TEST):
1245
1246 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
1247
1248         Unreviewed, rolling out r248526.
1249
1250         Caused two IndexedDB perf tests to fail
1251
1252         Reverted changeset:
1253
1254         "Remove IDB-specific quota"
1255         https://bugs.webkit.org/show_bug.cgi?id=196545
1256         https://trac.webkit.org/changeset/248526
1257
1258 2019-08-14  Keith Rollin  <krollin@apple.com>
1259
1260         Remove support for macOS < 10.13
1261         https://bugs.webkit.org/show_bug.cgi?id=200694
1262         <rdar://problem/54278851>
1263
1264         Reviewed by Youenn Fablet.
1265
1266         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
1267         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
1268         101300. This means that expressions like
1269         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
1270         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
1271
1272         * MiniBrowser/AppKitCompatibilityDeclarations.h:
1273         * MiniBrowser/mac/SettingsController.m:
1274         (-[SettingsController init]):
1275         * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
1276         (TestWebKitAPI::FontCacheTest::SetUp): Deleted.
1277         (TestWebKitAPI::createPlatformFont): Deleted.
1278         (TestWebKitAPI::compareFonts): Deleted.
1279         (TestWebKitAPI::TEST_F): Deleted.
1280         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
1281         (TestWebKitAPI::TEST):
1282         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1283         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1284         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1285         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1286         (runWebsiteDataStoreCustomPaths):
1287         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
1288
1289 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
1290
1291         [JSC] Less contended MetaAllocator
1292         https://bugs.webkit.org/show_bug.cgi?id=200278
1293
1294         Reviewed by Mark Lam.
1295
1296         Update the interface.
1297
1298         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1299
1300 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
1301
1302         results.webkit.org: 500 errors on API endpoints don't return JSON
1303         https://bugs.webkit.org/show_bug.cgi?id=200722
1304
1305         Reviewed by Aakash Jain.
1306
1307         * resultsdbpy/resultsdbpy/controller/api_routes.py:
1308         (APIRoutes.response_500): We should return the response, instead of abort.
1309
1310 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
1311
1312         results.webkit.org: Don't save configuration multiple times in upload
1313         https://bugs.webkit.org/show_bug.cgi?id=200719
1314
1315         Reviewed by Aakash Jain.
1316
1317         * resultsdbpy/resultsdbpy/model/upload_context.py:
1318         (UploadContext.upload_test_results): Move registering of the configuration out
1319         of the branch loop.
1320
1321 2019-08-14  Youenn Fablet  <youenn@apple.com>
1322
1323         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
1324         https://bugs.webkit.org/show_bug.cgi?id=200706
1325
1326         Reviewed by Alex Christensen.
1327
1328         Libwebrtc is now soft-linked so we can reenable this test.
1329
1330         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
1331         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
1332
1333 2019-08-13  Sam Weinig  <weinig@apple.com>
1334
1335         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
1336         https://bugs.webkit.org/show_bug.cgi?id=200675
1337
1338         Reviewed by Darin Adler.
1339
1340         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1341         (TestWebKitAPI::TEST):
1342         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
1343
1344 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
1345
1346         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
1347         https://bugs.webkit.org/show_bug.cgi?id=200456
1348
1349         Reviewed by Jonathan Bedard.
1350
1351         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
1352
1353         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
1354
1355         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
1356         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1357         (pointPolygonCollisionDetect): Detact
1358         (pointRightRayLineSegmentCollisionDetect):
1359         (ColorBatchRender):
1360         (ColorBatchRender.prototype.lazyCreateColorSeqs):
1361         (ColorBatchRender.prototype.addSeq):
1362         (ColorBatchRender.prototype.batchRender):
1363         (ColorBatchRender.prototype.clear):
1364         (xScrollStreamRenderFactory):
1365         (Timeline.CanvasSeriesComponent):
1366         (offscreenCachedRenderFactory): Deleted.
1367
1368 2019-08-13  John Wilander  <wilander@apple.com>
1369
1370         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
1371         https://bugs.webkit.org/show_bug.cgi?id=200642
1372         <rdar://problem/53962073>
1373
1374         Reviewed by Alex Christensen.
1375
1376         This patch adds test infrastructure to query whether an origin has an
1377         isolated NSURLSession or not.
1378
1379         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1380         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1381         (WTR::TestRunner::hasStatisticsIsolatedSession):
1382         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1383         * WebKitTestRunner/TestController.cpp:
1384         (WTR::TestController::hasStatisticsIsolatedSession):
1385         * WebKitTestRunner/TestController.h:
1386         * WebKitTestRunner/TestInvocation.cpp:
1387         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1388
1389 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
1390
1391         Update my status in contributors.json to committer.
1392
1393         Reviewed by Unreviewed
1394
1395         * Scripts/webkitpy/common/config/contributors.json:
1396
1397 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
1398
1399         Adds WebAuthn and AppSSO into watchlist
1400         https://bugs.webkit.org/show_bug.cgi?id=200647
1401
1402         Reviewed by Dewei Zhu.
1403
1404         * Scripts/webkitpy/common/config/watchlist:
1405
1406 2019-08-13  Chris Dumez  <cdumez@apple.com>
1407
1408         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
1409         https://bugs.webkit.org/show_bug.cgi?id=200674
1410         <rdar://problem/50692748>
1411
1412         Reviewed by Geoff Garen.
1413
1414         Add API test coverage.
1415
1416         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1417
1418 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
1419
1420         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
1421         https://bugs.webkit.org/show_bug.cgi?id=199857
1422
1423         Reviewed by Yusuke Suzuki.
1424
1425         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1426         (TestWebKitAPI::countThreadGroups):
1427         (TestWebKitAPI::TEST):
1428
1429 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
1430
1431         AX: Homebrew is not allowed to run any script under sudo.
1432         https://bugs.webkit.org/show_bug.cgi?id=173801
1433
1434         Reviewed by Carlos Alberto Lopez Perez.
1435
1436         Latest versions of Homebrew throw an error when run as root.
1437         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
1438
1439         * gtk/install-dependencies:
1440
1441 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
1442
1443         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
1444         https://bugs.webkit.org/show_bug.cgi?id=200644
1445
1446         Reviewed by Aakash Jain.
1447
1448         * Scripts/webkitpy/port/simulator_process.py:
1449         (SimulatorProcess._start): Define system PID after launching app.
1450
1451 2019-08-12  Sam Weinig  <weinig@apple.com>
1452
1453         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
1454         https://bugs.webkit.org/show_bug.cgi?id=200614
1455
1456         Reviewed by Darin Adler.
1457
1458         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
1459         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
1460         
1461         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
1462         StringBuilder::appendSubstring(...).
1463
1464         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1465         (TestWebKitAPI::TEST):
1466         Update for renames.
1467
1468 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
1469
1470         Fix Crash in Mail Search
1471         https://bugs.webkit.org/show_bug.cgi?id=200589
1472
1473         Reviewed by Tim Horton.
1474
1475         If you search backwards first in mail, we would crash,
1476         this tests that codepath.
1477
1478         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
1479         (TEST):
1480
1481 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1482
1483         [iPadOS] Web pages sometimes load at half width in Safari
1484         https://bugs.webkit.org/show_bug.cgi?id=200624
1485         <rdar://problem/52694257>
1486
1487         Reviewed by Simon Fraser.
1488
1489         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
1490         web page is created using the post-animated-resize web view dimensions, rather than the original layout
1491         dimensions.
1492
1493         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1494
1495 2019-08-12  Daniel Bates  <dabates@apple.com>
1496
1497         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
1498         https://bugs.webkit.org/show_bug.cgi?id=200548
1499
1500         Reviewed by Darin Adler.
1501
1502         Expose infrastructure to simulate a literal raw key down and a literal key up event.
1503
1504         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1505         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1506         (WTR::UIScriptController::rawKeyDown):
1507         (WTR::UIScriptController::rawKeyUp):
1508         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
1509         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1510         (WTR::UIScriptControllerIOS::rawKeyDown):
1511         (WTR::UIScriptControllerIOS::rawKeyUp):
1512
1513 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
1514
1515         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
1516         https://bugs.webkit.org/show_bug.cgi?id=200584
1517
1518         Reviewed by Philippe Normand.
1519
1520         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
1521         Ignore style libwebrtc optionnal 'style issue'
1522
1523         * Scripts/webkitpy/style/checker.py:
1524         * gstreamer/jhbuild.modules:
1525         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
1526
1527 2019-08-12  Youenn Fablet  <youenn@apple.com>
1528
1529         Remove IDB-specific quota
1530         https://bugs.webkit.org/show_bug.cgi?id=196545
1531
1532         Reviewed by Alex Christensen.
1533
1534         * DumpRenderTree/TestRunner.cpp:
1535         (TestRunner::staticFunctions):
1536         (setIDBPerOriginQuotaCallback): Deleted.
1537         * DumpRenderTree/TestRunner.h:
1538         * DumpRenderTree/mac/DumpRenderTree.mm:
1539         (runTest):
1540         * DumpRenderTree/mac/TestRunnerMac.mm:
1541         (TestRunner::setIDBPerOriginQuota): Deleted.
1542         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1543         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1544         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
1545         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1546         * WebKitTestRunner/TestController.cpp:
1547         (WTR::TestController::resetStateToConsistentValues):
1548         (WTR::TestController::setIDBPerOriginQuota): Deleted.
1549         * WebKitTestRunner/TestController.h:
1550         * WebKitTestRunner/TestInvocation.cpp:
1551         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1552
1553 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
1554
1555         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
1556         https://bugs.webkit.org/show_bug.cgi?id=200621
1557
1558         Reviewed by Dan Bernstein.
1559
1560         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1561
1562 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1563
1564         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
1565         https://bugs.webkit.org/show_bug.cgi?id=200604
1566         <rdar://problem/51273130>
1567
1568         Reviewed by Megan Gardner.
1569
1570         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
1571         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
1572         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
1573         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
1574         remains the same.
1575
1576         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
1577         the caret rect at initial scale 1.
1578
1579         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1580
1581 2019-08-09  Ali Juma  <ajuma@chromium.org>
1582
1583         Don't allow cross-origin iframes to autofocus
1584         https://bugs.webkit.org/show_bug.cgi?id=200515
1585         <rdar://problem/54092988>
1586
1587         Reviewed by Ryosuke Niwa.
1588
1589         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
1590         of cross-origin iframes, since it depends on focusing one of the
1591         frames.
1592
1593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1594         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1595         (TestWebKitAPI::TEST):
1596         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
1597
1598 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1599
1600         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
1601         https://bugs.webkit.org/show_bug.cgi?id=200591
1602         <rdar://problem/54102238>
1603
1604         Reviewed by Ryosuke Niwa and Tim Horton.
1605
1606         Add a new API test to exercise -supportsImagePaste.
1607
1608         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1609         (TestWebKitAPI::TEST):
1610         * TestWebKitAPI/ios/UIKitSPI.h:
1611
1612 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
1613
1614         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
1615         [ews-build] Set svn:ignore to various EWS Buildbot files
1616         https://bugs.webkit.org/show_bug.cgi?id=200581
1617
1618         Reviewed by Jonathan Bedard.
1619
1620         * BuildSlaveSupport/ews-build: Added property svn:ignore.
1621
1622 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
1623
1624         [ews-build] Set svn:ignore to various EWS Buildbot files
1625         https://bugs.webkit.org/show_bug.cgi?id=200581
1626
1627         Reviewed by Jonathan Bedard.
1628
1629         * BuildSlaveSupport/ews-build: Added property svn:ignore.
1630
1631 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
1632
1633         [ews] Add buildbot.tac to repository
1634         https://bugs.webkit.org/show_bug.cgi?id=200580
1635
1636         Reviewed by Jonathan Bedard.
1637
1638         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
1639
1640 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
1641
1642         [GTK] Add missing spellchecking packages to dependencies script
1643         https://bugs.webkit.org/show_bug.cgi?id=200574
1644
1645         Reviewed by Philippe Normand.
1646
1647         These are needed for the spellchecking test in WebContext API tests.
1648
1649         * gtk/install-dependencies:
1650
1651 2019-08-08  Jon Lee  <jonlee@apple.com>
1652
1653         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
1654
1655 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
1656
1657         webkitpy: Disable shared clipboard between Simulators
1658         https://bugs.webkit.org/show_bug.cgi?id=200546
1659
1660         Reviewed by Aakash Jain.
1661
1662         * Scripts/webkitpy/xcode/simulated_device.py:
1663         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
1664         managed by run-webkit-tests.
1665
1666 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
1667
1668         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
1669         https://bugs.webkit.org/show_bug.cgi?id=200539
1670         <rdar://problem/54082550>
1671
1672         Reviewed by Dean Jackson.
1673
1674         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1675         * PlatformFTW.cmake: Added.
1676
1677 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
1678
1679         [iOS] Position image information should respect the image orientation
1680         https://bugs.webkit.org/show_bug.cgi?id=200487
1681
1682         Reviewed by Simon Fraser.
1683
1684         Add an API test to verify the position image information is drawn rotated
1685         because of respecting its image orientation.
1686
1687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1688         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1689         (TestWebKitAPI::TEST):
1690         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
1691         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
1692
1693 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
1694
1695         [GTK] Fix WebContext languages test
1696         https://bugs.webkit.org/show_bug.cgi?id=200538
1697
1698         Reviewed by Alex Christensen.
1699
1700         This test broke after the format of Accepted-Languages
1701         was changed in r238236, update.
1702
1703         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1704         (testWebContextLanguages):
1705
1706 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
1707
1708         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
1709         https://bugs.webkit.org/show_bug.cgi?id=200536
1710
1711         Reviewed by Carlos Alberto Lopez Perez.
1712
1713         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1714         (testWebsiteDataDatabases): Databases take a moment to be written,
1715         wait before fetching the data as it's done in other tests.
1716
1717 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
1718
1719         results.webkit.org: Use canvas for timeline
1720         https://bugs.webkit.org/show_bug.cgi?id=200172
1721
1722         Rubber-stamped by Aakash Jain.
1723
1724         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
1725         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
1726         (Commit.compare): Ditto.
1727         (_CommitBank.commitByUuid): Ditto.
1728         (_CommitBank._loadSiblings): Ditto.
1729         (_CommitBank._load): Ditto.
1730         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1731         (tickForCommit): Deleted.
1732         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
1733         which encompasses all results. Crucially, this function must exclude an UUIDs which may
1734         refer to results excluded because of the limit argument.
1735         (renderTimeline): Deleted.
1736         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
1737         with those results.
1738         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
1739         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
1740         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
1741         (inPlaceCombine): Combine result objects together.
1742         (statsForSingleResult): Turn a single result into a stat object.
1743         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
1744         (Dot): Deleted.
1745         (TimelineFromEndpoint): Renamed from Timeline.
1746         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
1747         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
1748         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
1749         cache contents.
1750         (TimelineFromEndpoint.reload): Remove management of nested timelines.
1751         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
1752         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
1753         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1754
1755 2019-08-08  Brady Eidson  <beidson@apple.com>
1756
1757         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
1758         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
1759
1760         Reviewed by Geoff Garen.
1761
1762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1763         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
1764
1765 2019-08-08  Rob Buis  <rbuis@igalia.com>
1766
1767         Add runtime flag for lazy image loading
1768         https://bugs.webkit.org/show_bug.cgi?id=199794
1769
1770         Reviewed by Darin Adler.
1771
1772         Set lazyImageLoading preference as part of experimental features. Add
1773         TestOption for lazy image loading.
1774
1775         * DumpRenderTree/TestOptions.cpp:
1776         (TestOptions::TestOptions):
1777         * DumpRenderTree/TestOptions.h:
1778         * DumpRenderTree/mac/DumpRenderTree.mm:
1779         (enableExperimentalFeatures):
1780         (setWebPreferencesForTestOptions):
1781         * DumpRenderTree/win/DumpRenderTree.cpp:
1782         (enableExperimentalFeatures):
1783
1784 2019-08-08  Rob Buis  <rbuis@igalia.com>
1785
1786         Import lazy loading WPT tests
1787         https://bugs.webkit.org/show_bug.cgi?id=199795
1788
1789         Reviewed by Darin Adler.
1790
1791         Only do loading/ exception for WebKit specific, non WPT tests.
1792
1793         * DumpRenderTree/mac/DumpRenderTree.mm:
1794         (shouldLogFrameLoadDelegates):
1795         * WebKitTestRunner/TestInvocation.cpp:
1796         (WTR::TestInvocation::TestInvocation):
1797
1798 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1799
1800         [Win][MiniBrowser] Add key accelerators for reload and close window
1801         https://bugs.webkit.org/show_bug.cgi?id=200497
1802
1803         Reviewed by Brent Fulgham.
1804
1805         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
1806
1807         * MiniBrowser/win/MainWindow.cpp:
1808         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
1809         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
1810         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
1811
1812 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
1813
1814         Add WHLSL and WebGPU to the watchlist file
1815         https://bugs.webkit.org/show_bug.cgi?id=200509
1816
1817         Reviewed by Robin Morisset.
1818
1819         * Scripts/webkitpy/common/config/watchlist:
1820
1821 2019-08-07  Keith Rollin  <krollin@apple.com>
1822
1823         Unreviewed build fix after r248317 -- disable XCBuild because it
1824         breaks incremental builds.
1825
1826         * Scripts/webkitdirs.pm:
1827         (canUseXCBuild):
1828
1829 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1830
1831         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
1832         https://bugs.webkit.org/show_bug.cgi?id=200465
1833
1834         Reviewed by Alex Christensen.
1835
1836         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
1837         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
1838         finishing the test.
1839         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1840         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
1841
1842 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
1843
1844         Unreviewed, a build fix after r248308
1845
1846         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
1847
1848         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1849
1850 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
1851
1852         Unreviewed, a build fix after r248319
1853
1854         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
1855
1856         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1857         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1858         (WTR::TestController::addTestKeyToKeychain):
1859         (WTR::TestController::cleanUpKeychain):
1860         (WTR::TestController::keyExistsInKeychain):
1861
1862 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
1863
1864         Unreviewed, a build fix after r248308
1865
1866         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
1867
1868         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1869         (WTR::TestController::addTestKeyToKeychain):
1870         (WTR::TestController::cleanUpKeychain):
1871         (WTR::TestController::keyExistsInKeychain):
1872
1873 2019-08-06  Keith Rollin  <krollin@apple.com>
1874
1875         Enable XCBuild for `make` and `build-webkit` builds
1876         https://bugs.webkit.org/show_bug.cgi?id=200476
1877         <rdar://problem/50771065>
1878
1879         Reviewed by Jonathan Bedard.
1880
1881         All projects have now been tested under XCBuild and successfully
1882         build. Enable the use of XCBuild when performing builds with `make` or
1883         `build-webkit` and when using a sufficient version of Xcode. We set
1884         this version to Xcode 11 since Xcode 10 -- even though it supports
1885         XCBuild -- does not support a build facility needed to build WebKit
1886         (Bug 197072, Bug 197116, Bug 197340).
1887
1888         Do not enable XCBuild in the Xcode projects themselves since these
1889         projects may need to be used under older versions of Xcode and there's
1890         no way to make those project changes sensitive to the version of Xcode
1891         being used. This means that builds performed in the Xcode IDE will not
1892         use XCBuild.
1893
1894         * Scripts/webkitdirs.pm:
1895         (canUseXCBuild):
1896
1897 2019-08-06  Chris Dumez  <cdumez@apple.com>
1898
1899         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
1900         https://bugs.webkit.org/show_bug.cgi?id=200475
1901
1902         Reviewed by Darin Adler.
1903
1904         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1905         (TestWebKitAPI::stringViewFromLiteral):
1906         (TestWebKitAPI::stringViewFromUTF8):
1907
1908 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1909
1910         Update my status in contributors.json to reviewer.
1911
1912         Regained the status after following the procedure for inactive contributors.
1913         See r247136 for further explanation.
1914
1915         * Scripts/webkitpy/common/config/contributors.json:
1916
1917 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
1918
1919         [WebAuthN] Enable LocalAuthenticator for macOS
1920         https://bugs.webkit.org/show_bug.cgi?id=182772
1921         <rdar://problem/43347920>
1922
1923         Reviewed by Brent Fulgham.
1924
1925         Add an entitlement file to WebKitTestRunner such that it can access
1926         the modern macOS keychain.
1927
1928         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
1929         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1930         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1931         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1932         (WTR::TestController::addTestKeyToKeychain):
1933         (WTR::TestController::cleanUpKeychain):
1934         (WTR::TestController::keyExistsInKeychain):
1935
1936 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
1937
1938         [results.webkit.org Timeline] Performance improvements
1939         https://bugs.webkit.org/show_bug.cgi?id=200406
1940
1941         Reviewed by Jonathan Bedard.
1942
1943         1. Unhook the scroll event when a series/axis have been removed from the container
1944         2. Fix the axis's cache data structure out of sync.
1945         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
1946         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
1947
1948
1949         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
1950         (Signal.prototype.removeListener):
1951         (prototype.stopAction): Unregsiter an action handler
1952         (Ref):
1953         (Ref.prototype.apply):
1954         (Ref.prototype.destory):
1955         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
1956         (ApplyNewChildren):
1957         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1958         (Timeline.CanvasSeriesComponent):
1959
1960 2019-08-06  Jer Noble  <jer.noble@apple.com>
1961
1962         Add test for behavior introduced in r248174
1963         https://bugs.webkit.org/show_bug.cgi?id=200446
1964
1965         Reviewed by Eric Carlson.
1966
1967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1968         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
1969         (WebKit::configureSecheuristic):
1970         (WebKit::TEST):
1971
1972 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
1973
1974         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
1975         https://bugs.webkit.org/show_bug.cgi?id=200464
1976
1977         Reviewed by Ross Kirsling.
1978
1979         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
1980         menu, Alt-F4 to close window, and etc) don't work.
1981
1982         WK1 WebView doesn't have this issue because it processes key events
1983         properly.
1984
1985         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1986         (WebKitBrowserWindow::WebKitBrowserWindow):
1987         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
1988         unhandled key events to the main window.
1989         * MiniBrowser/win/WebKitBrowserWindow.h:
1990
1991 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
1992
1993         iOS 13: Overflow:hidden on body prevents PDF scroll
1994         https://bugs.webkit.org/show_bug.cgi?id=200435
1995         rdar://problem/53942888
1996
1997         Reviewed by Tim Horton.
1998
1999         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
2000         to make sure that the scroll view is scrollable.
2001
2002         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
2003         (TestWebKitAPI::TEST):
2004
2005 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
2006
2007         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
2008         https://bugs.webkit.org/show_bug.cgi?id=200400
2009
2010         Reviewed by Jonathan Bedard.
2011
2012         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2013         (StatusBubble._build_bubble):
2014         (StatusBubble._queue_position):
2015
2016 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
2017
2018         run-webkit-tests asserts when the iPhone XR simulator is running
2019         https://bugs.webkit.org/show_bug.cgi?id=200404
2020         <rdar://problem/53878739>
2021
2022         Reviewed by Dean Jackson.
2023
2024         Support unicode in all logging statements tied to device model.
2025
2026         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2027         (Manager.run):
2028         * Scripts/webkitpy/layout_tests/views/printing.py:
2029         (Printer.print_baseline_search_path):
2030         * Scripts/webkitpy/port/device.py:
2031         (Device.__repr__):
2032         * Scripts/webkitpy/port/device_port.py:
2033         (DevicePort._install):
2034         (DevicePort.setup_test_run):
2035         (DevicePort.clean_up_test_run):
2036         (DevicePort.configuration_for_upload):
2037         * Scripts/webkitpy/port/ios.py:
2038         (IOSPort.default_baseline_search_path):
2039         * Scripts/webkitpy/xcode/device_type.py:
2040         (DeviceType.__str__):
2041         * Scripts/webkitpy/xcode/simulated_device.py:
2042         (SimulatedDeviceManager.populate_available_devices):
2043         (SimulatedDeviceManager._find_available_name):
2044         (SimulatedDeviceManager._get_device_identifier_for_type):
2045         (SimulatedDeviceManager._create_or_find_device_for_request):
2046         (SimulatedDeviceManager._does_fulfill_request):
2047         (SimulatedDeviceManager._wait_until_device_in_state):
2048         (SimulatedDeviceManager._wait_until_device_is_usable):
2049         (SimulatedDeviceManager._boot_device):
2050         (SimulatedDeviceManager.initialize_devices):
2051         (SimulatedDeviceManager.max_supported_simulators):
2052         (SimulatedDeviceManager.swap):
2053         (SimulatedDevice.is_usable):
2054         (SimulatedDevice._shut_down):
2055         (SimulatedDevice._delete):
2056         (SimulatedDevice.launch_app):
2057         (SimulatedDevice.__repr__):
2058
2059 2019-08-04  Chris Dumez  <cdumez@apple.com>
2060
2061         Ping loads should not prevent page caching
2062         https://bugs.webkit.org/show_bug.cgi?id=200418
2063         <rdar://problem/53901632>
2064
2065         Reviewed by Darin Adler.
2066
2067         Add TestOption to enable PageCache at UIProcess-level so that we can test
2068         page caching when navigating cross-origin with PSON enabled.
2069
2070         * WebKitTestRunner/TestController.cpp:
2071         (WTR::TestController::resetPreferencesToConsistentValues):
2072         (WTR::updateTestOptionsFromTestHeader):
2073         * WebKitTestRunner/TestOptions.h:
2074         (WTR::TestOptions::hasSameInitializationOptions const):
2075
2076 2019-08-02  Keith Rollin  <krollin@apple.com>
2077
2078         Consistently use Obj-C boolean literals
2079         https://bugs.webkit.org/show_bug.cgi?id=200405
2080         <rdar://problem/53880043>
2081
2082         Reviewed by Simon Fraser, Joseph Pecoraro.
2083
2084         There are places where we use equivalent but different expressions for
2085         Obj-C boolean objects. For example, we use both [NSNumber
2086         numberWithBool:YES] and @YES. There are places where both are used in
2087         the same function, such as -[WebPreferences initialize]. The boolean
2088         literal is in greater use and is more succinct, so standardize on
2089         that. Also, change @(YES/NO) to @YES/NO.
2090
2091         * DumpRenderTree/mac/ObjCController.m:
2092         (-[ObjCController objectOfClass:]):
2093         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2094         (TEST):
2095         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2096         (overrideAddObserverForName):
2097         * TestWebKitAPI/ios/mainIOS.mm:
2098         (main):
2099         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2100         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2101         * TestWebKitAPI/mac/mainMac.mm:
2102         (main):
2103         * WebKitLauncher/WebKitNightlyEnabler.m:
2104         (enableWebKitNightlyBehaviour):
2105
2106 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2107
2108         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
2109         https://bugs.webkit.org/show_bug.cgi?id=200402
2110         <rdar://problem/53823368>
2111
2112         Reviewed by Tim Horton.
2113
2114         Make it possible to run this test using the iPad simulator.
2115
2116         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2117
2118         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
2119         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
2120         since this would result in differently sized text.
2121
2122         (mainScreenReferenceBoundsOverride):
2123         * TestWebKitAPI/ios/UIKitSPI.h:
2124
2125 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
2126
2127         API tests using permanent credentials should clear credentials left by previous tests
2128         https://bugs.webkit.org/show_bug.cgi?id=199729
2129
2130         Reviewed by Alex Christensen.
2131
2132         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
2133         credentials will not affect tests running after. There is a case where permanent credentials were left on the
2134         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
2135         failure. To prevent this from happening again, add cleanup at the begining of the tests.
2136
2137         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2138         (TEST):
2139         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2140         (TestWebKitAPI::TEST):
2141
2142 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
2143
2144         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
2145         https://bugs.webkit.org/show_bug.cgi?id=200394
2146         <rdar://problem/52914964>
2147
2148         Reviewed by Chris Fleizach.
2149
2150         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
2151
2152         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2153         (WTR::AccessibilityUIElement::isInTableCell const):
2154         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2155         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2156         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2157         (WTR::AccessibilityUIElement::isInTableCell const):
2158
2159 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
2160
2161         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
2162         https://bugs.webkit.org/show_bug.cgi?id=200397
2163
2164         Reviewed by Jonathan Bedard.
2165
2166         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2167
2168 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2169
2170         [macOS 10.15] Image dragged from Safari does not appear in Notes
2171         https://bugs.webkit.org/show_bug.cgi?id=188490
2172         <rdar://problem/39462717>
2173
2174         Reviewed by Andy Estes.
2175
2176         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
2177
2178         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
2179
2180 2019-08-02  Alex Christensen  <achristensen@webkit.org>
2181
2182         Fix API test after r248139
2183         https://bugs.webkit.org/show_bug.cgi?id=200102
2184
2185         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
2186         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2187         This was supposed to be removed as part of reverting r245322.
2188
2189 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2190
2191         results.webkit.org: Force update cache when timeline updated
2192         https://bugs.webkit.org/show_bug.cgi?id=200363
2193
2194         Reviewed by Jonathan Bedard.
2195
2196         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2197         (offscreenCachedRenderFactory): Add ability to force the redraw.
2198         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
2199         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
2200
2201 2019-08-01  Alex Christensen  <achristensen@webkit.org>
2202
2203         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
2204         https://bugs.webkit.org/show_bug.cgi?id=200360
2205
2206         Reviewed by Tim Horton.
2207
2208         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2209         (cleanupITPDatabase):
2210         (TEST):
2211
2212 2019-08-01  Alex Christensen  <achristensen@webkit.org>
2213
2214         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
2215         https://bugs.webkit.org/show_bug.cgi?id=200102
2216         <rdar://problem/53275114>
2217
2218         Reviewed by Darin Adler.
2219
2220         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
2221         and because clicking on a TestWKWebView only works on Mac.
2222
2223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2224         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
2225         (-[UploadDelegate initWithDirectory:]):
2226         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2227         (-[UploadDelegate sentDirectory]):
2228         (TEST):
2229         * TestWebKitAPI/cocoa/TestWKWebView.h:
2230         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2231         (-[TestWKWebView sendClickAtPoint:]):
2232
2233 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2234
2235         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
2236         https://bugs.webkit.org/show_bug.cgi?id=200321
2237
2238         Reviewed by Jonathan Bedard.
2239
2240         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2241         Let the axis' height be defined in the option. Timeine component will use this value as
2242         padding-top for headers which allows headers start in the right position, even with multiple
2243         top axises.
2244         (Timeline.CanvasSeriesComponent):
2245         (prototype.Timeline.CanvasContainer):
2246
2247 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
2248
2249         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
2250         https://bugs.webkit.org/show_bug.cgi?id=200347
2251
2252         Reviewed by Jonathan Bedard.
2253
2254         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2255         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
2256
2257 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
2258
2259         Improve flakiness of SOAuthorizationRedirect tests
2260         https://bugs.webkit.org/show_bug.cgi?id=200320
2261         <rdar://problem/53767057>
2262
2263         Reviewed by Alex Christensen.
2264
2265         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
2266         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
2267         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
2268         is executed.
2269
2270         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2271         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2272         (resetState):
2273         (TestWebKitAPI::TEST):
2274
2275 2019-08-01  Keith Rollin  <krollin@apple.com>
2276
2277         Update TestWebKitAPI for XCBuild
2278         https://bugs.webkit.org/show_bug.cgi?id=200311
2279         <rdar://problem/53773804>
2280
2281         Reviewed by Alex Christensen.
2282
2283         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
2284         technique. Now update WebKitLegacy to build under XCBuild after those
2285         changes. This work involves adding an "Apply Configuration to
2286         XCFileLists" build target, adding a check-xcfilelists.sh script,
2287         adding a "Check xcfilelists" build phase that calls that script,
2288         adding knowledge of the project to the generate-xcfilelists script,
2289         creating new .xcfilelist files, and adding those to the project.
2290
2291         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
2292         (Application.__init__):
2293         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2294         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
2295         (TestWebKitAPIGenerator):
2296         (TestWebKitAPIGenerator._get_project_file_path):
2297         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
2298         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
2299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2300         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
2301
2302 2019-08-01  Youenn Fablet  <youenn@apple.com>
2303
2304         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
2305         https://bugs.webkit.org/show_bug.cgi?id=200317
2306
2307         Reviewed by Eric Carlson.
2308
2309         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
2310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2311         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2312         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
2313         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2314         (TestWebKitAPI::TEST):
2315
2316 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
2317
2318         New EWS: Cannot see build status page when patch is waiting for tester
2319         https://bugs.webkit.org/show_bug.cgi?id=200333
2320
2321         Reviewed by Jonathan Bedard.
2322
2323         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2324         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
2325
2326 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2327
2328         [SOUP] Switch to use libsoup WebSockets API
2329         https://bugs.webkit.org/show_bug.cgi?id=200162
2330
2331         Reviewed by Michael Catanzaro.
2332
2333         Update libsoup version to 2.67.90.
2334
2335         * gtk/jhbuild.modules:
2336         * wpe/jhbuild.modules:
2337
2338 2019-07-31  Andy Estes  <aestes@apple.com>
2339
2340         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
2341         https://bugs.webkit.org/show_bug.cgi?id=200293
2342         <rdar://problem/52937749>
2343
2344         Reviewed by Alex Christensen.
2345
2346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2347         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
2348         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2349         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2350         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
2351         (TEST):
2352
2353 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
2354
2355         [ews-build] Enable all macOS queues on new EWS
2356         https://bugs.webkit.org/show_bug.cgi?id=199944
2357
2358         Reviewed by Jonathan Bedard.
2359
2360         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
2361         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2362         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
2363         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
2364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
2365         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
2366
2367 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
2368
2369         Unreviewed test gardening, disable failing test for rdar://51752593.
2370
2371         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2372
2373 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
2374
2375         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
2376         https://bugs.webkit.org/show_bug.cgi?id=200318
2377
2378         Reviewed by Aakash Jain.
2379
2380         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2381         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
2382         (Timeline.CanvasXAxisComponent): Use getLabel function.
2383
2384 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
2385
2386         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
2387         https://bugs.webkit.org/show_bug.cgi?id=200306
2388
2389         Reviewed by Michael Catanzaro.
2390
2391         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
2392         jsc-glib-4.0-scan for example).
2393
2394         * Scripts/webkitdirs.pm:
2395         (generateBuildSystemFromCMakeProject):
2396
2397 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
2398
2399         Unreviewed test gardening, disable failing test for rdar://52355829.
2400
2401         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
2402         (TEST):
2403
2404 2019-07-31  Keith Rollin  <krollin@apple.com>
2405
2406         Update WebKitLegacy for XCBuild
2407         https://bugs.webkit.org/show_bug.cgi?id=200310
2408         <rdar://problem/53773708>
2409
2410         Reviewed by Alex Christensen.
2411
2412         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
2413         technique. Now update WebKitLegacy to build under XCBuild after those
2414         changes. This work involves adding an "Apply Configuration to
2415         XCFileLists" build target, adding a check-xcfilelists.sh script,
2416         adding a "Check xcfilelists" build phase that calls that script,
2417         adding knowledge of the project to the generate-xcfilelists script,
2418         creating new .xcfilelist files, and adding those to the project.
2419
2420         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
2421         (Application.__init__):
2422         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2423         (JavaScriptCoreGenerator):
2424         (WebCoreGenerator):
2425         (WebKitGenerator):
2426         (WebKitGenerator._get_generate_unified_sources_script):
2427         (WebKitLegacyGenerator):
2428         (WebKitLegacyGenerator._get_project_file_path):
2429         (WebKitLegacyGenerator._get_generate_unified_sources_script):
2430
2431 2019-07-31  Chris Dumez  <cdumez@apple.com>
2432
2433         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
2434         https://bugs.webkit.org/show_bug.cgi?id=200086
2435         <rdar://problem/53501721>
2436
2437         Reviewed by Alex Christensen.
2438
2439         re-enable the API test.
2440
2441         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
2442         (TEST):
2443
2444 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
2445
2446         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
2447         https://bugs.webkit.org/show_bug.cgi?id=200291
2448         <rdar://problem/53717946>
2449
2450         Reviewed by Megan Gardner.
2451
2452         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
2453         after closing the web view, while the web view's content view isn't the first responder.
2454
2455         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
2456         * TestWebKitAPI/ios/UIKitSPI.h:
2457
2458 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2459
2460         [GTK] Datalist element support for TextFieldInputType
2461         https://bugs.webkit.org/show_bug.cgi?id=98934
2462
2463         Reviewed by Michael Catanzaro.
2464
2465         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
2466
2467         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
2468         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
2469         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
2470
2471 2019-07-30  Tim Horton  <timothy_horton@apple.com>
2472
2473         Remove some needless comments that snuck into the tree
2474
2475         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2476         (WTR::UIScriptController::setHardwareKeyboardAttached):
2477         (WTR::UIScriptController::playBackEventStream):
2478
2479 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2480
2481         [WebKit] Add PageLoadState::Observer C API
2482         https://bugs.webkit.org/show_bug.cgi?id=199848
2483
2484         Reviewed by Alex Christensen.
2485
2486         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2487         (WebKitBrowserWindow::WebKitBrowserWindow):
2488         (WebKitBrowserWindow::didChangeTitle):
2489         (WebKitBrowserWindow::didFinishNavigation): Deleted.
2490         * MiniBrowser/win/WebKitBrowserWindow.h:
2491         * TestWebKitAPI/CMakeLists.txt:
2492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2493         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
2494         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
2495         (TestWebKitAPI::didChangeActiveURL):
2496         (TestWebKitAPI::didChangeCanGoBack):
2497         (TestWebKitAPI::didChangeCanGoForward):
2498         (TestWebKitAPI::didChangeCertificateInfo):
2499         (TestWebKitAPI::didChangeEstimatedProgress):
2500         (TestWebKitAPI::didChangeHasOnlySecureContent):
2501         (TestWebKitAPI::didChangeIsLoading):
2502         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
2503         (TestWebKitAPI::didChangeTitle):
2504         (TestWebKitAPI::didChangeWebProcessIsResponsive):
2505         (TestWebKitAPI::didSwapWebProcesses):
2506         (TestWebKitAPI::willChangeActiveURL):
2507         (TestWebKitAPI::willChangeCanGoBack):
2508         (TestWebKitAPI::willChangeCanGoForward):
2509         (TestWebKitAPI::willChangeCertificateInfo):
2510         (TestWebKitAPI::willChangeEstimatedProgress):
2511         (TestWebKitAPI::willChangeHasOnlySecureContent):
2512         (TestWebKitAPI::willChangeIsLoading):
2513         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
2514         (TestWebKitAPI::willChangeTitle):
2515         (TestWebKitAPI::willChangeWebProcessIsResponsive):
2516         (TestWebKitAPI::didFinishNavigation):
2517         (TestWebKitAPI::TEST):
2518
2519 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
2520
2521         DumpRenderTree.app: Add CFBundleShortVersionString
2522         https://bugs.webkit.org/show_bug.cgi?id=200269
2523         <rdar://problem/53412596>
2524
2525         Rubber-stamped by Aakash Jain.
2526
2527         * DumpRenderTree/ios/Info.plist:
2528
2529 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2530
2531         Add layout test coverage for <https://webkit.org/b/200215>
2532         https://bugs.webkit.org/show_bug.cgi?id=200245
2533         <rdar://problem/52976965>
2534
2535         Reviewed by Tim Horton.
2536
2537         Add new testing infrastructure. See below for more details.
2538
2539         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2540         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2541         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2542         (WTR::UIScriptController::setWillCreateNewPageCallback):
2543         (WTR::UIScriptController::willCreateNewPageCallback const):
2544
2545         Add platform-agnostic UIScriptController callback hooks to notify a test when a new page is being created. The
2546         new test in this patch uses this opportunity to remove and reinsert the web view into the window's hierarchy.
2547
2548         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2549         (WTR::UIScriptController::becomeFirstResponder):
2550
2551         Add and implement a Cocoa platform hook to make the web view first responder.
2552
2553         * WebKitTestRunner/TestController.cpp:
2554         (WTR::TestController::createOtherPage):
2555         * WebKitTestRunner/TestInvocation.cpp:
2556         (WTR::TestInvocation::willCreateNewPage):
2557         * WebKitTestRunner/TestInvocation.h:
2558         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
2559         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
2560         (WTR::UIScriptControllerCocoa::becomeFirstResponder):
2561
2562 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
2563
2564         [Win][MiniBrowser] Add 'reload' menu item and 'reload' toolbar button
2565         https://bugs.webkit.org/show_bug.cgi?id=200217
2566
2567         Reviewed by Alex Christensen.
2568
2569         * MiniBrowser/win/BrowserWindow.h:
2570         * MiniBrowser/win/MainWindow.cpp:
2571         (MainWindow::init):
2572         (MainWindow::resizeSubViews):
2573         (MainWindow::WndProc):
2574         * MiniBrowser/win/MainWindow.h: Added m_hReloadButtonWnd.
2575         * MiniBrowser/win/MiniBrowserLib.rc:
2576         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_RELOAD.
2577         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2578         (WebKitBrowserWindow::reload):
2579         * MiniBrowser/win/WebKitBrowserWindow.h: Added reload() interface.
2580         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2581         (WebKitLegacyBrowserWindow::reload):
2582         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2583
2584 2019-07-29  Fujii Hironori  <Hironori.Fujii@sony.com>
2585
2586         [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window
2587         https://bugs.webkit.org/show_bug.cgi?id=200218
2588
2589         Reviewed by Alex Christensen.
2590
2591         Moved the scheme supplementing logic from
2592         WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL.
2593
2594         * MiniBrowser/win/MainWindow.cpp:
2595         (MainWindow::loadURL):
2596         (MainWindow::onURLBarEnter):
2597         * MiniBrowser/win/MainWindow.h:
2598         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2599         (WebKitLegacyBrowserWindow::loadURL):
2600
2601 2019-07-29  Aakash Jain  <aakash_jain@apple.com>
2602
2603         Disable Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
2604         https://bugs.webkit.org/show_bug.cgi?id=200254
2605
2606         Unreviewed infrastructure fix.
2607
2608         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Disabled the test.
2609
2610 2019-07-29  Zhifei Fang  <zhifei_fang@apple.com>
2611
2612         [Canvas Timeline] Compact canvas timeline
2613         https://bugs.webkit.org/show_bug.cgi?id=200177
2614
2615         Reviewed by Jonathan Bedard.
2616
2617         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
2618         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2619         (Timeline.CanvasSeriesComponent):
2620
2621 2019-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2622
2623         Multiple context menu actions broken for YouTube videos
2624         https://bugs.webkit.org/show_bug.cgi?id=199999
2625
2626         Reviewed by Eric Carlson.
2627
2628         Add a test case to check copy link address, open in new window and download options are not included in the
2629         context menu for non-downloadable media.
2630
2631         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2632         (writeNextChunk):
2633         (serverCallback):
2634         (testContextMenuLiveStream):
2635         (beforeAll):
2636         (afterAll):
2637
2638 2019-07-28  Tim Horton  <timothy_horton@apple.com>
2639
2640         Reorganize UIScriptController into platform-specific subclasses
2641         https://bugs.webkit.org/show_bug.cgi?id=200027
2642
2643         Reviewed by Simon Fraser.
2644
2645         Instead of a mishmash of #ifdefs and extraneous empty functions,
2646         reorganize UIScriptController so that we have a base class
2647         with functions that assert if called (to make it harder to
2648         accidentally write a test that depends on unimplemented
2649         functionality), and override them in platform specific subclasses
2650         as functionality is added.
2651
2652         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2653         * DumpRenderTree/ios/UIScriptControllerIOS.h: Added.
2654         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2655         * DumpRenderTree/mac/UIScriptControllerMac.h: Added.
2656         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2657         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2658         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2659         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2660         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h: Added.
2661         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm: Added.
2662         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
2663         * WebKitTestRunner/gtk/UIScriptControllerGtk.h: Added.
2664         * WebKitTestRunner/ios/UIScriptControllerIOS.h: Added.
2665         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2666         * WebKitTestRunner/mac/UIScriptControllerMac.h: Added.
2667         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2668
2669 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2670
2671         [Win][MiniBrowser] Remove PageLoadTestClient
2672         https://bugs.webkit.org/show_bug.cgi?id=200155
2673
2674         Reviewed by Brent Fulgham.
2675
2676         It is not used nowadays.
2677
2678         * MiniBrowser/win/CMakeLists.txt:
2679         * MiniBrowser/win/Common.cpp:
2680         (parseCommandLine):
2681         * MiniBrowser/win/Common.h:
2682         * MiniBrowser/win/MainWindow.cpp:
2683         (MainWindow::init):
2684         * MiniBrowser/win/MainWindow.h:
2685         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2686         (MiniBrowserWebHost::updateAddressBar):
2687         (MiniBrowserWebHost::didFinishLoadForFrame):
2688         (MiniBrowserWebHost::didStartProvisionalLoadForFrame):
2689         (MiniBrowserWebHost::didFailLoadWithError):
2690         (MiniBrowserWebHost::didHandleOnloadEventsForFrame):
2691         (MiniBrowserWebHost::didFirstLayoutInFrame):
2692         * MiniBrowser/win/PageLoadTestClient.cpp: Removed.
2693         * MiniBrowser/win/PageLoadTestClient.h: Removed.
2694         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2695         (ResourceLoadDelegate::identifierForInitialRequest):
2696         (ResourceLoadDelegate::willSendRequest):
2697         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2698         (ResourceLoadDelegate::didFailLoadingWithError):
2699         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2700         (WebKitBrowserWindow::create):
2701         (WebKitBrowserWindow::createNewPage):
2702         * MiniBrowser/win/WebKitBrowserWindow.h:
2703         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2704         (WebKitLegacyBrowserWindow::create):
2705         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
2706         (WebKitLegacyBrowserWindow::exitProgram): Deleted.
2707         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2708         (WebKitLegacyBrowserWindow::pageLoadTestClient): Deleted.
2709         * MiniBrowser/win/WinMain.cpp:
2710         (wWinMain):
2711
2712 2019-07-26  Jiewen Tan  <jiewen_tan@apple.com>
2713
2714         NavigationSOAuthorizationSession should check the active URL of the responding page after waking up from waiting
2715         https://bugs.webkit.org/show_bug.cgi?id=200150
2716         <rdar://problem/53280170>
2717
2718         Reviewed by Brent Fulgham.
2719
2720         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2721         (TestWebKitAPI::TEST):
2722
2723 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
2724
2725         Follow-up fix: results.webkit.org: Suite results shouldn't be the landing page
2726         https://bugs.webkit.org/show_bug.cgi?id=200090
2727
2728         Unreviewed follow-up fix.
2729
2730         * resultsdbpy/resultsdbpy/view/view_routes.py:
2731         (ViewRoutes.__init__): Keep /search endpoint for existing links
2732
2733 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
2734
2735         results.webkit.org: Add switch to filter results by expectation
2736         https://bugs.webkit.org/show_bug.cgi?id=200134
2737
2738         Rubber-stamped by Aakash Jain.
2739
2740         Users of the results database should be able to easily differentiate tests which are expected
2741         to fail verse tests which are unexpectedly failing.
2742
2743         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2744         (Timeline.render): Respect the willFilterExpected variable.
2745         (LegendLabel): Generates html for label in the legend.
2746         (Legend): Add switch for filter results.
2747         * resultsdbpy/resultsdbpy/view/templates/search.html: GIve Legend callback to re-render timelines.
2748         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
2749
2750 2019-07-26  Aakash Jain  <aakash_jain@apple.com>
2751
2752         [ews-build] Use update-webkit script in Style EWS
2753         https://bugs.webkit.org/show_bug.cgi?id=193196
2754
2755         Reviewed by Jonathan Bedard.
2756
2757         * BuildSlaveSupport/ews-build/factories.py:
2758         (StyleFactory): Updated to use CheckOutSource step as well.
2759         * BuildSlaveSupport/ews-build/steps.py: Added build-step to UpdateWorkingDirectory.
2760         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2761
2762 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
2763
2764         results.webkit.org: Support buildbot 0.8 CI links
2765         https://bugs.webkit.org/show_bug.cgi?id=200146
2766
2767         Reviewed by Aakash Jain.
2768
2769         * resultsdbpy/resultsdbpy/model/ci_context.py:
2770         (BuildbotEightURLFactory): Buildbot 0.8 link factory.
2771         (BuildbotEightURLFactory.__init__):
2772         (BuildbotEightURLFactory.url):
2773         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py:
2774         (URLFactoryTest.test_old_builder_url):
2775         (URLFactoryTest):
2776         (URLFactoryTest.test_old_worker_url):
2777
2778 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
2779
2780         results.webkit.org: Suite results shouldn't be the landing page
2781         https://bugs.webkit.org/show_bug.cgi?id=200090
2782
2783         Reviewed by Aakash Jain.
2784
2785         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Remove search bar.
2786         * resultsdbpy/resultsdbpy/view/view_routes.py:
2787         (ViewRoutes.__init__): Make search the landing page instead of suite results.
2788         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
2789         (WebSiteUnittest.test_main):
2790
2791 2019-07-26  Jonathan Bedard  <jbedard@apple.com>
2792
2793         Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
2794         https://bugs.webkit.org/show_bug.cgi?id=200127
2795
2796         Unreviewed follow-up fix.
2797
2798         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2799         (Dot.toString): Use self instead of this in render callback.
2800
2801 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
2802
2803         WebPageProxy::receivedPolicyDecision should check navigation ID before clear pendingAPIRequest
2804         https://bugs.webkit.org/show_bug.cgi?id=200108
2805         <rdar://problem/53521238>
2806
2807         Reviewed by Chris Dumez.
2808
2809         Added an API test.
2810
2811         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
2812         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2813         (TEST):
2814
2815 2019-07-25  Jonathan Bedard  <jbedard@apple.com>
2816
2817         results.webkit.org: Color should be the worst result, count should include all results
2818         https://bugs.webkit.org/show_bug.cgi?id=200127
2819
2820         Rubber-stamped by Aakash Jain.
2821
2822         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2823         (Dot.prototype.toString): Do not differentiate the count based on the prevailing failure type.
2824
2825 2019-07-25  Zhifei Fang  <zhifei_fang@apple.com>
2826
2827         [Timeline]: Make timeline header width automatic, instead of fixed width
2828         https://bugs.webkit.org/show_bug.cgi?id=200059
2829
2830         Reviewed by Jonathan Bedard.
2831
2832         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
2833         (.dot.crash):
2834         (.timeline>.header): Deleted.
2835         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2836         (.timeline>.content):
2837         (.timeline>.header):
2838
2839 2019-07-25  Ross Kirsling  <ross.kirsling@sony.com>
2840
2841         [ESNext] Implement nullish coalescing
2842         https://bugs.webkit.org/show_bug.cgi?id=200072
2843
2844         Reviewed by Darin Adler.
2845
2846         * Scripts/run-jsc-stress-tests:
2847
2848 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2849
2850         Add Takashi Komori and Tomoki Imai as contributors
2851
2852         Unreviewed.
2853
2854         * Scripts/webkitpy/common/config/contributors.json:
2855
2856 2019-07-24  Yusuke Suzuki  <ysuzuki@apple.com>
2857
2858         [bmalloc] Add IsoHeap test to ensure that IsoHeap pages are not allocating too large VA
2859         https://bugs.webkit.org/show_bug.cgi?id=200103
2860
2861         Reviewed by Mark Lam.
2862
2863         This patch adds tests to TestWTF IsoHeap tests to ensure that IsoHeap's component is not leaking pages or not allocating too large VAs for memory allocation.
2864         We use VMTag to get the system view of the allocated VAs and check whether it is not incredibly large.
2865
2866         While the tests are white-box tests (it means that this is a bit flaky to the implementation changes of IsoHeap), I adjusted some threshold to make this less-flaky
2867         to the future implementation changes while it catches the severe issues we had.
2868
2869         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2870         (assertEmptyPointerSet):
2871         (assertHasOnlyObjects):
2872         (assertClean):
2873         (TEST):
2874         (allocateAndDeallocate):
2875
2876 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
2877
2878         [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined"
2879         https://bugs.webkit.org/show_bug.cgi?id=200074
2880
2881         Reviewed by Michael Catanzaro.
2882
2883         There was a latent issue. PluginTest::indicateTestFailure was
2884         using WTF::sleep without linking WTF.
2885
2886         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2887         Added WebKit::WTF to WebKitTestNetscapePlugIn_LIBRARIES.
2888
2889 2019-07-24  Fujii Hironori  <fujii.hironori@gmail.com>
2890
2891         [GTK][WPE][CMake] failing to build TestWebKitAPIInjectedBundle due to missing forwarding headers
2892         https://bugs.webkit.org/show_bug.cgi?id=200073
2893
2894         Reviewed by Michael Catanzaro.
2895
2896         * TestWebKitAPI/PlatformGTK.cmake:
2897         * TestWebKitAPI/PlatformWPE.cmake:
2898         Added add_dependencies(TestWebKitAPIInjectedBundle TestWebKitAPI-forwarding-headers).
2899
2900 2019-07-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2901
2902         [webkitperl] runCommand doesn't work in Windows Perl
2903         https://bugs.webkit.org/show_bug.cgi?id=199900
2904
2905         Reviewed by Don Olmstead.
2906
2907         runCommand was always failing implicit fork by using 'open' with
2908         '-|' in Windows Perl. Explicitly specify the command to 'open' not
2909         to do the implicit fork.
2910
2911         There is one more difference between Windows and Unix. 'open'
2912         successes on Windows even for non existent command while it fails
2913         on Unix. So, return the same error code on Unix as well as
2914         Windows.
2915
2916         * Scripts/VCSUtils.pm: Specified the command to 'open'.
2917         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: 'echo'
2918         command is not available on Windows. Use Perl ($^X) instead.
2919
2920 2019-07-24  Priyanka Agarwal  <pagarwal999@apple.com>
2921
2922         Allow Clients to Add Fields to the AutoFillContext Dictionary.
2923         https://bugs.webkit.org/show_bug.cgi?id=199326
2924         rdar://problem/42816957
2925
2926         Reviewed by Wenson Hsieh.
2927
2928         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2929         (TestWebKitAPI::TEST): Created a test to check that the auto fill context
2930         is being properly populated with additional context dictionary.
2931
2932         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2933         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2934         (-[TestInputDelegate setWebViewAdditionalContextForStrongPasswordAssistanceHandler:]): Setting the handler for the function
2935         which will populate the additional autofill context dictionary.
2936
2937         (-[TestInputDelegate webViewAdditionalContextForStrongPasswordAssistanceHandler]): Returns the handler for the function which
2938         populates the additional autofill context dictionary.
2939
2940         (-[TestInputDelegate _webViewAdditionalContextForStrongPasswordAssistance:]): Function which populates the additional autofill
2941         context dictionary.
2942
2943         (-[TestInputDelegate setFocusRequiresStrongPasswordAssistanceHandler:]): Setting the handler for the function which checks if the
2944         input field requires strong password work.
2945
2946         (-[TestInputDelegate focusRequiresStrongPasswordAssistanceHandler]): Returns the handler for the function which checks if the
2947         input field requires strong password work.
2948
2949         (-[TestInputDelegate _webView:focusRequiresStrongPasswordAssistance:]): Function which checks if the input field requires strong
2950         password work.
2951
2952 2019-07-24  Zhifei Fang  <zhifei_fang@apple.com>
2953
2954         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
2955         https://bugs.webkit.org/show_bug.cgi?id=199489
2956
2957         Reviewed by Aakash Jain.
2958
2959         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2960         (RunJavaScriptCoreTests.start): Skip run jsc test binaries for mips, armv7, aarch64.
2961         (RunJavaScriptCoreTests.countFailures): Pick up the test binaires failure to total failures count
2962         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2963         * Scripts/run-javascriptcore-tests: The script now failed wether the run-jsc-stress-tests failed or test binaries failed.
2964         (runTest): Record test binary failure
2965         (reportTestFailures): Report test binary failure
2966         (runJSCStressTests):
2967         * Scripts/webkitpy/common/config/ports.py: Skip run jsc test binaries for those need to run remotely
2968         (JscOnlyPort.build_jsc_command):
2969         (JscOnlyPort):
2970         (JscOnlyPort.run_javascriptcore_tests_command):
2971         * Scripts/webkitpy/common/config/ports_unittest.py:
2972         (DeprecatedPortTest.test_jsconly_port):
2973
2974 2019-07-24  Zalan Bujtas  <zalan@apple.com>
2975
2976         ASSERTION FAILED: settings().textAutosizingEnabled() && settings().textAutosizingUsesIdempotentMode() in WebCore::Page::recomputeTextAutoSizingInAllFrames()
2977         https://bugs.webkit.org/show_bug.cgi?id=200079
2978         <rdar://problem/53474325>
2979
2980         Reviewed by Wenson Hsieh.
2981
2982         Reset textAutosizingUsesIdempotentMode when transitioning to a new test.
2983
2984         * WebKitTestRunner/ios/TestControllerIOS.mm:
2985         (WTR::TestController::platformResetPreferencesToConsistentValues):
2986
2987 2019-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
2988
2989         [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
2990         https://bugs.webkit.org/show_bug.cgi?id=199927
2991
2992         Reviewed by Alex Christensen.
2993
2994         convertAbsolutepathToWebKitPath was failing to convert paths on
2995         Windows Perl due to path separators mismatch.
2996
2997         Renamed convertAbsolutepathToWebKitPath to
2998         convertAbsolutePathToRelativeUnixPath, and changed it to replace
2999         paths to relative Unix paths.
3000
3001         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3002         (convertAbsolutePathToRelativeUnixPath): Added.
3003         (convertAbsolutepathToWebKitPath): Deleted.
3004
3005 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3006
3007         Fix iOS API test after r247759
3008         https://bugs.webkit.org/show_bug.cgi?id=200045
3009
3010         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3011         (TEST):
3012         In the iOS simulator, the WebProcess was being started before we were setting the value on the WKProcessPool.
3013         To fix this, set the value on the WKProcessPool before making the WKWebView.  This makes the test always pass on Mac and iOS.
3014
3015 2019-07-23  Keith Rollin  <krollin@apple.com>
3016
3017         Remove rest of NavigatorContentUtils support
3018         https://bugs.webkit.org/show_bug.cgi?id=200052
3019         <rdar://problem/53467357>
3020
3021         Reviewed by Alex Christensen.
3022
3023         Bug 196070 removes most of the support for the never-used
3024         NavigatorContentUtils facility. However, there were still a couple of
3025         left-over references after that change. This patch sweeps those up.
3026
3027         * Scripts/webkitperl/FeatureList.pm:
3028
3029 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3030
3031         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
3032         https://bugs.webkit.org/show_bug.cgi?id=200045
3033
3034         Reviewed by Mark Lam.
3035
3036         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3037         (TEST):
3038
3039 2019-07-23  Russell Epstein  <repstein@apple.com>
3040
3041         Unreviewed, rolling out r247745.
3042
3043         This broke API test
3044         TestWebKitAPI.WKProcessPool.JavaScriptConfiguration as
3045         indicated by EWS
3046
3047         Reverted changeset:
3048
3049         "Move javaScriptConfigurationDirectory SPI from
3050         _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it
3051         runtime switchable"
3052         https://bugs.webkit.org/show_bug.cgi?id=200045
3053         https://trac.webkit.org/changeset/247745
3054
3055 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3056
3057         Move javaScriptConfigurationDirectory SPI from _WKProcessPoolConfiguration to WKProcessPoolPrivate to make it runtime switchable
3058         https://bugs.webkit.org/show_bug.cgi?id=200045
3059
3060         Reviewed by Mark Lam.
3061
3062         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3063         (TEST):
3064
3065 2019-07-23  Alex Christensen  <achristensen@webkit.org>
3066
3067         Add SPI for setting media cache and key location on _WKWebsiteDataStoreConfiguration
3068         https://bugs.webkit.org/show_bug.cgi?id=199972
3069
3070         Reviewed by Jer Noble.
3071
3072         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3073         (TEST):
3074
3075 2019-07-23  Alicia Boya García  <aboya@igalia.com>
3076
3077         [WTF] Add DataMutex and MainThreadData wrappers
3078         https://bugs.webkit.org/show_bug.cgi?id=199831
3079
3080         Reviewed by Alex Christensen.
3081
3082         Added a very simple test that checks that DataMutex<T> indeed takes
3083         the lock and indeed holds data.
3084
3085         * TestWebKitAPI/CMakeLists.txt:
3086         * TestWebKitAPI/Tests/WTF/DataMutex.cpp: Added.
3087         (TestWebKitAPI::TEST):
3088
3089 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3090
3091         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
3092         https://bugs.webkit.org/show_bug.cgi?id=200021
3093         <rdar://problem/53301325>
3094
3095         Reviewed by Ryosuke Niwa.
3096
3097         Add support for grabbing the child menu items of a context menu item.
3098
3099         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3100         (WTR::getMenuItemChildrenCallback):
3101
3102 2019-07-23  Ryosuke Niwa  <rniwa@webkit.org>
3103
3104         WebKit should strip away system font names from the pasted content
3105         https://bugs.webkit.org/show_bug.cgi?id=199975
3106         <rdar://problem/53336353>
3107
3108         Reviewed by Darin Adler.
3109
3110         Added a test to strip away system font names such as ".AppleSystemUIFont", ".SFUI-Regular", and ".SF UI Mono".
3111
3112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3113         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3114         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-system-fonts.html: Added.
3115
3116 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3117
3118         [ews-build] EWS fails to parse multi-line full_results.json
3119         https://bugs.webkit.org/show_bug.cgi?id=199992
3120
3121         Reviewed by Alexey Proskuryakov.
3122
3123         * BuildSlaveSupport/ews-build/layout_test_failures.py:
3124         (LayoutTestFailures.results_from_string): Concatenate content into single line.
3125         * BuildSlaveSupport/ews-build/steps_unittest.py:
3126         (test_parse_results_json_with_newlines): Unit-test to cover this scenario.
3127
3128 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
3129
3130         resultsdbpy: Handle case where the previous commit doesn't have the changelog
3131         https://bugs.webkit.org/show_bug.cgi?id=200015
3132
3133         Reviewed by Aakash Jain.
3134
3135         * resultsdbpy/resultsdbpy/model/repository.py:
3136         (WebKitRepository.commit_for_id.diff_changelogs): Allow the previous_response to be None.
3137
3138 2019-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3139
3140         [iOS] [WK1] UIWebView always jumps to the top left corner when scrolling to reveal the selection
3141         https://bugs.webkit.org/show_bug.cgi?id=200013
3142         <rdar://problem/52526901>
3143
3144         Reviewed by Simon Fraser.
3145
3146         Add a new API test to verify that inserting text in UIWebView causes the document to scroll.
3147
3148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3149         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollToRevealSelection.mm: Added.
3150         (-[LegacyLoadingDelegate webViewDidFinishLoad:]):
3151         (-[LegacyLoadingDelegate waitForDidFinishLoad]):
3152         * TestWebKitAPI/ios/UIKitSPI.h:
3153
3154 2019-07-22  Jer Noble  <jer.noble@apple.com>
3155
3156         REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
3157         https://bugs.webkit.org/show_bug.cgi?id=199971
3158         <rdar://problem/51951218>
3159
3160         Reviewed by Alex Christensen.
3161
3162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3163         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm: Added.
3164         (TestWebKitAPI::TEST):
3165
3166 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3167
3168         [ews-build] Add an EWS to run services tests
3169         https://bugs.webkit.org/show_bug.cgi?id=199994
3170
3171         Reviewed by Jonathan Bedard.
3172
3173         * BuildSlaveSupport/ews-build/config.json: Added Services-EWS configuration.
3174         * BuildSlaveSupport/ews-build/factories.py: Added ServicesFactory.
3175         * BuildSlaveSupport/ews-build/steps.py:
3176         (CheckPatchRelevance): Run this EWS only for patches with changes in relevant files.
3177         (RunEWSUnitTests): Build step to run EWS unit-tests.
3178         (RunEWSBuildbotCheckConfig): Build step to run buildbot checkconfig command.
3179         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3180         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added services status-bubble.
3181
3182 2019-07-22  Youenn Fablet  <youenn@apple.com>
3183
3184         Disable MediaRecorder for legacy WebKit
3185         https://bugs.webkit.org/show_bug.cgi?id=200001
3186         <rdar://problem/53400030>
3187
3188         Reviewed by Eric Carlson.
3189
3190         Enable MediaRecorder for testing purposes.
3191
3192         * DumpRenderTree/mac/DumpRenderTree.mm:
3193         (createWebViewAndOffscreenWindow):
3194
3195 2019-07-22  Jonathan Bedard  <jbedard@apple.com>
3196
3197         results.webkit.org: Timeline header is too small
3198         https://bugs.webkit.org/show_bug.cgi?id=199955
3199
3200         Reviewed by Aakash Jain.
3201
3202         * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
3203         (.timeline>.header): Make timeline header larder to fit configuration names.
3204
3205 2019-07-22  Alex Christensen  <achristensen@webkit.org>
3206
3207         Add SPI to _WKWebsiteDataStoreConfiguration for configuring application cache storage location
3208         https://bugs.webkit.org/show_bug.cgi?id=199954
3209
3210         Reviewed by Geoff Garen.
3211
3212         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3213         (TEST):
3214
3215 2019-07-22  Alex Christensen  <achristensen@webkit.org>
3216
3217         Add SPI _WKProcessPoolConfiguration.javaScriptConfigurationDirectory
3218         https://bugs.webkit.org/show_bug.cgi?id=199917
3219
3220         Reviewed by Sam Weinig.
3221
3222         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3223         (TEST):
3224
3225 2019-07-22  Aakash Jain  <aakash_jain@apple.com>
3226
3227         [ews-build] ReRunWebKitTests should use similar logic for evaluateCommand as RunWebKitTests
3228         https://bugs.webkit.org/show_bug.cgi?id=199980
3229
3230         Reviewed by Jonathan Bedard.
3231
3232         * BuildSlaveSupport/ews-build/steps.py:
3233         (ReRunWebKitTests.evaluateCommand): Updatd to use similar logic as RunWebKitTests.
3234         * BuildSlaveSupport/ews-build/steps_unittest.py:
3235         (TestRunWebKitTests): Modified to make it generic so as to re-use tests.
3236         (TestReRunWebKitTests): Run all TestRunWebKitTests unit-tests for ReRunWebKitTests as well.
3237
3238 2019-07-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3239
3240         [webkitpy] Add an unit test for setting up the driver environment without starting it.
3241         https://bugs.webkit.org/show_bug.cgi?id=199945
3242
3243         Reviewed by Michael Catanzaro.
3244
3245         This adds an unit test for the change implemented in r247663.
3246
3247         * Scripts/webkitpy/port/driver_unittest.py:
3248         (DriverTest.test_setup_environ_base_vars):
3249         (DriverTest):
3250         (DriverTest.test_setup_environ_without_starting_driver):
3251
3252 2019-07-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3253
3254         [iOS] [WebKit2] Add limited support for -isPosition:atBoundary:inDirection: in WKContentView
3255         https://bugs.webkit.org/show_bug.cgi?id=199993
3256         <rdar://problem/49523528>
3257
3258         Reviewed by Beth Dakin.
3259
3260         Add a new API test to verify the behavior of -isPosition:atBoundary:inDirection:.
3261
3262         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3263         (TestWebKitAPI::TEST):
3264         * TestWebKitAPI/cocoa/TestWKWebView.h:
3265
3266 2019-07-21  Andres Gonzalez  <andresg_22@apple.com>
3267
3268         Add accessibilityInsertText for text insertion in edit fields.
3269         https://bugs.webkit.org/show_bug.cgi?id=199973
3270
3271         Reviewed by Chris Fleizach.
3272
3273         Renamed accessibilityInsertText to _accessibilityInsertText.
3274
3275         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3276         (AccessibilityUIElement::insertText):
3277         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3278         (AccessibilityUIElement::insertText):
3279         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3280         (WTR::AccessibilityUIElement::insertText):
3281         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3282         (WTR::AccessibilityUIElement::insertText):
3283
3284 2019-07-20  Chris Dumez  <cdumez@apple.com>
3285
3286         Speed up HashTable decoding by reserving capacity and avoiding rehashing
3287         https://bugs.webkit.org/show_bug.cgi?id=199982
3288
3289         Reviewed by Saam Barati.
3290
3291         Add API test coverage.
3292
3293         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3294         (TestWebKitAPI::TEST):
3295
3296 2019-07-20  Andres Gonzalez  <andresg_22@apple.com>
3297
3298         Add accessibilityInsertText for text insertion in edit fields.
3299         https://bugs.webkit.org/show_bug.cgi?id=199973
3300
3301         Reviewed by Chris Fleizach.
3302
3303         Glue code to run new LayoutTests.
3304         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3305         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3306         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3307         (WTR::AccessibilityUIElement::insertText):
3308         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3309         (WTR::AccessibilityUIElement::insertText):
3310         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3311         (WTR::AccessibilityUIElement::insertText):
3312         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3313         (WTR::AccessibilityUIElement::insertText):
3314
3315 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
3316
3317         Move webkit.css to opensource to support resultsdbpy's frontend
3318         https://bugs.webkit.org/show_bug.cgi?id=199957
3319
3320         Reviewed by Jonathan Bedard.
3321
3322         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Added.
3323         * resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs: Added.
3324         * resultsdbpy/resultsdbpy/view/static/library/css/index.html: Added.
3325         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css: Added.
3326
3327 2019-07-19  Zhifei Fang  <zhifei_fang@apple.com>
3328
3329         Move Ref.js to WebKit to support resultsdbpy's frontend
3330         https://bugs.webkit.org/show_bug.cgi?id=199956
3331
3332         Reviewed by Jonathan Bedard.
3333
3334         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
3335         * resultsdbpy/resultsdbpy/view/static/js/search.js:
3336         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3337         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js: Added.
3338         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js: Added.
3339         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js: Added.
3340         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js: Added.
3341         * resultsdbpy/resultsdbpy/view/templates/base.html:
3342         * resultsdbpy/resultsdbpy/view/templates/commits.html:
3343         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
3344         * resultsdbpy/resultsdbpy/view/templates/search.html:
3345         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
3346         * resultsdbpy/resultsdbpy/view/view_routes.py:
3347
3348 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3349
3350         [webkitpy] Allow the testrunner driver to setup the environment completely without needing to start the server process.
3351         https://bugs.webkit.org/show_bug.cgi?id=199945
3352
3353         Reviewed by Michael Catanzaro.
3354
3355         Refactor the code to create the Driver temporal directories inside Driver._setup_environ_for_driver().
3356         This allows external callers to setup the environment for running tests by calling that method without needing to start the server process.
3357         When this callers finish testing, it is enough with calling either Driver.stop() or Driver._delete_temporal_directories().
3358
3359         * Scripts/webkitpy/port/driver.py:
3360         (Driver._setup_environ_for_driver):
3361         (Driver._create_temporal_directories):
3362         (Driver):
3363         (Driver._start):
3364         (Driver._delete_temporal_directories):
3365         (Driver.stop):
3366         * Scripts/webkitpy/w3c/wpt_runner.py: Not needed anymore to start the driver since this doesnt need the server process running.
3367         (main):
3368         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Ditto.
3369         (WebDriverTestRunner.__init__):
3370         * glib/api_test_runner.py:
3371         (TestRunner._setup_testing_environment): Ditto.
3372
3373 2019-07-19  Aakash Jain  <aakash_jain@apple.com>
3374
3375         [ews-build] Display pre-existing Layout test failure names in the build summary
3376         https://bugs.webkit.org/show_bug.cgi?id=199941
3377
3378         Reviewed by Jonathan Bedard.
3379
3380         * BuildSlaveSupport/ews-build/steps.py:
3381         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
3382
3383 2019-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3384
3385         [GTK][WPE] run-webkit-tests should run with a temporal homedir
3386         https://bugs.webkit.org/show_bug.cgi?id=199738
3387
3388         Reviewed by Michael Catanzaro.
3389
3390         Run the tests with an empty homedir that is created inside the driver tmpdir.
3391         The driver tmpdir is a random directory created for each test runner that is purged after the run.
3392
3393         This is done to ensure that the test results are not affected by the user settings of any library.
3394
3395         * Scripts/webkitpy/port/driver.py:
3396         (Driver._setup_environ_for_driver):
3397         * Scripts/webkitpy/port/driver_unittest.py:
3398         (DriverTest.test_setup_environ_base_vars):
3399         (DriverTest):
3400         (DriverTest.test_create_temporal_home_dir):
3401
3402 2019-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3403
3404         Remove pywebsockets from thirdparty
3405         https://bugs.webkit.org/show_bug.cgi?id=199710
3406
3407         Reviewed by Jonathan Bedard.
3408
3409         We have a very old version of pywebsocket in webkitpy thirdparty, but we are also importing pywebsocket as part
3410         of wpt tools. We can simply use the wpt one for all websocket tests and remove the old copy from sources.
3411
3412         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3413         (PyWebSocket._prepare_config): Use pywebsocket from imported w3c tools directory.
3414         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Removed.
3415         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Removed.
3416         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Removed.
3417         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Removed.
3418         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Removed.
3419         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Removed.
3420         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Removed.
3421         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Removed.
3422         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Removed.
3423         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Removed.
3424         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Removed.
3425         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Removed.
3426         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Removed.
3427         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Removed.
3428         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Removed.
3429         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Removed.
3430         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Removed.
3431         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Removed.
3432         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Removed.
3433         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Removed.
3434
3435 2019-07-18  Jonathan Bedard  <jbedard@apple.com>
3436
3437         results.webkit.org: Move resultsdbpy to WebKit
3438         https://bugs.webkit.org/show_bug.cgi?id=199837
3439         <rdar://problem/53172130>
3440
3441         Rubber-stamped by Aakash Jain.
3442
3443         Moving the entirety of the resultsdbpy library, which provides utilities to build
3444         a database designed to store, visualize and organize test results, into WebKit.
3445
3446         * Scripts/webkitpy/style/checker.py:
3447         (CheckerDispatcher._create_checker): resulltsdbpy is a Python 3 library.
3448         * resultsdbpy: Added.
3449         * resultsdbpy/MANIFEST.in: Added.
3450         * resultsdbpy/README.md: Added.
3451         * resultsdbpy/resultsdbpy: Added.
3452         * resultsdbpy/resultsdbpy/__init__.py: Added.
3453         * resultsdbpy/resultsdbpy/controller: Added.
3454         * resultsdbpy/resultsdbpy/controller/__init__.py: Added.
3455         * resultsdbpy/resultsdbpy/controller/api_routes.py: Added.
3456         * resultsdbpy/resultsdbpy/controller/ci_controller.py: Added.
3457         * resultsdbpy/resultsdbpy/controller/ci_controller_unittest.py: Added.
3458         * resultsdbpy/resultsdbpy/controller/commit.py: Added.
3459         * resultsdbpy/resultsdbpy/controller/commit_controller.py: Added.
3460         * resultsdbpy/resultsdbpy/controller/commit_controller_unittest.py: Added.
3461         * resultsdbpy/resultsdbpy/controller/commit_unittest.py: Added.
3462         * resultsdbpy/resultsdbpy/controller/configuration.py: Added.
3463         * resultsdbpy/resultsdbpy/controller/configuration_controller.py: Added.
3464         * resultsdbpy/resultsdbpy/controller/configuration_controller_unittest.py: Added.
3465         * resultsdbpy/resultsdbpy/controller/configuration_unittest.py: Added.
3466         * resultsdbpy/resultsdbpy/controller/suite_controller.py: Added.
3467         * resultsdbpy/resultsdbpy/controller/suite_controller_unittest.py: Added.
3468         * resultsdbpy/resultsdbpy/controller/test_controller.py: Added.
3469         * resultsdbpy/resultsdbpy/controller/test_controller_unittest.py: Added.
3470         * resultsdbpy/resultsdbpy/controller/upload_controller.py: Added.
3471         * resultsdbpy/resultsdbpy/controller/upload_controller_unittest.py: Added.
3472         * resultsdbpy/resultsdbpy/flask_support: Added.
3473         * resultsdbpy/resultsdbpy/flask_support/__init__.py: Added.
3474         * resultsdbpy/resultsdbpy/flask_support/authed_blueprint.py: Added.
3475         * resultsdbpy/resultsdbpy/flask_support/flask_test_context.py: Added.
3476         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py: Added.
3477         * resultsdbpy/resultsdbpy/flask_support/util.py: Added.
3478         * resultsdbpy/resultsdbpy/flask_support/util_unittest.py: Added.
3479         * resultsdbpy/resultsdbpy/model: Added.
3480         * resultsdbpy/resultsdbpy/model/__init__.py: Added.
3481         * resultsdbpy/resultsdbpy/model/cassandra_context.py: Added.
3482         * resultsdbpy/resultsdbpy/model/cassandra_context_unittest.py: Added.
3483         * resultsdbpy/resultsdbpy/model/casserole.py: Added.
3484         * resultsdbpy/resultsdbpy/model/casserole_unittest.py: Added.
3485         * resultsdbpy/resultsdbpy/model/ci_context.py: Added.
3486         * resultsdbpy/resultsdbpy/model/ci_context_unittest.py: Added.
3487         * resultsdbpy/resultsdbpy/model/commit_context.py: Added.
3488         * resultsdbpy/resultsdbpy/model/commit_context_unittest.py: Added.
3489         * resultsdbpy/resultsdbpy/model/configuration_context.py: Added.
3490         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py: Added.
3491         * resultsdbpy/resultsdbpy/model/docker-compose.yml: Added.
3492         * resultsdbpy/resultsdbpy/model/docker.py: Added.
3493         * resultsdbpy/resultsdbpy/model/docker_unittest.py: Added.
3494         * resultsdbpy/resultsdbpy/model/mock_cassandra_context.py: Added.
3495         * resultsdbpy/resultsdbpy/model/mock_model_factory.py: Added.
3496         * resultsdbpy/resultsdbpy/model/mock_repository.py: Added.
3497         * resultsdbpy/resultsdbpy/model/model.py: Added.
3498         * resultsdbpy/resultsdbpy/model/partitioned_redis.py: Added.
3499         * resultsdbpy/resultsdbpy/model/partitioned_redis_unittest.py: Added.
3500         * resultsdbpy/resultsdbpy/model/redis_unittest.py: Added.
3501         * resultsdbpy/resultsdbpy/model/repository.py: Added.
3502         * resultsdbpy/resultsdbpy/model/repository_unittest.py: Added.
3503         * resultsdbpy/resultsdbpy/model/suite_context.py: Added.
3504         * resultsdbpy/resultsdbpy/model/suite_context_unittest.py: Added.
3505         * resultsdbpy/resultsdbpy/model/test_context.py: Added.
3506         * resultsdbpy/resultsdbpy/model/test_context_unittest.py: Added.
3507         * resultsdbpy/resultsdbpy/model/upload_context.py: Added.
3508         * resultsdbpy/resultsdbpy/model/upload_context_unittest.py: Added.
3509         * resultsdbpy/resultsdbpy/model/wait_for_docker_test_case.py: Added.
3510         * resultsdbpy/resultsdbpy/run-tests: Added.
3511         * resultsdbpy/resultsdbpy/view: Added.
3512         * resultsdbpy/resultsdbpy/view/__init__.py: Added.
3513         * resultsdbpy/resultsdbpy/view/ci_view.py: Added.
3514         * resultsdbpy/resultsdbpy/view/commit_view.py: Added.
3515         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py: Added.
3516         * resultsdbpy/resultsdbpy/view/site_menu.py: Added.
3517         * resultsdbpy/resultsdbpy/view/static: Added.
3518         * resultsdbpy/resultsdbpy/view/static/css: Added.
3519         * resultsdbpy/resultsdbpy/view/static/css/commit.css: Added.
3520         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Added.
3521         * resultsdbpy/resultsdbpy/view/static/css/search.css: Added.
3522         * resultsdbpy/resultsdbpy/view/static/css/timeline.css: Added.
3523         * resultsdbpy/resultsdbpy/view/static/js: Added.
3524         * resultsdbpy/resultsdbpy/view/static/js/commit.js: Added.
3525         * resultsdbpy/resultsdbpy/view/static/js/common.js: Added.
3526         * resultsdbpy/resultsdbpy/view/static/js/configuration.js: Added.
3527         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Added.
3528         * resultsdbpy/resultsdbpy/view/static/js/search.js: Added.
3529         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Added.
3530         * resultsdbpy/resultsdbpy/view/suite_view.py: Added.
3531         * resultsdbpy/resultsdbpy/view/templates: Added.
3532         * resultsdbpy/resultsdbpy/view/templates/base.html: Added.
3533         * resultsdbpy/resultsdbpy/view/templates/commit.html: Added.
3534         * resultsdbpy/resultsdbpy/view/templates/commits.html: Added.
3535         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Added.
3536         * resultsdbpy/resultsdbpy/view/templates/error.html: Added.
3537         * resultsdbpy/resultsdbpy/view/templates/search.html: Added.
3538         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Added.
3539         * resultsdbpy/resultsdbpy/view/view_routes.py: Added.
3540         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py: Added.
3541         * resultsdbpy/setup.py: Added.
3542
3543 2019-07-18  Alex Christensen  <achristensen@webkit.org>
3544
3545         Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
3546         https://bugs.webkit.org/show_bug.cgi?id=199923
3547
3548         Reviewed by Youenn Fablet.
3549
3550         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3551         (TestWebKitAPI::TEST):
3552
3553 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
3554
3555         [ews-build] Enable iOS WK2 tester queue on new EWS
3556         https://bugs.webkit.org/show_bug.cgi?id=199867
3557
3558         Reviewed by Jonathan Bedard.
3559
3560         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for ios-wk2 queue.
3561         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled ios-sim (builder) and ios-wk2 (tester) bubbles.
3562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed ios-sim queue from bot-watcher's dashboard.
3563         * QueueStatusServer/config/queues.py: Removed ios-sim queue from old EWS.
3564
3565 2019-07-18  Aakash Jain  <aakash_jain@apple.com>
3566
3567         [ews-build] Add build step to AnalyzeLayoutTestsResults
3568         https://bugs.webkit.org/show_bug.cgi?id=199877
3569
3570         Reviewed by Jonathan Bedard.
3571
3572         Logic is ported from webkitpy/tool/bot/patchanalysistask.py::_retry_layout_tests()
3573
3574         * BuildSlaveSupport/ews-build/steps.py:
3575         (RunWebKitTestsWithoutPatch.evaluateCommand): invoke AnalyzeLayoutTestsResults step.
3576         (AnalyzeLayoutTestsResults): Build step to analyze layout-test results.
3577         (AnalyzeLayoutTestsResults.report_failure):
3578         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
3579         (AnalyzeLayoutTestsResults.retry_build):
3580         (AnalyzeLayoutTestsResults._results_failed_different_tests):
3581         (AnalyzeLayoutTestsResults._report_flaky_tests):
3582         (AnalyzeLayoutTestsResults.start):
3583         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3584
3585 2019-07-18  Alex Christensen  <achristensen@webkit.org>
3586
3587         Move NetworkCache ownership from NetworkProcess to NetworkSession
3588         https://bugs.webkit.org/show_bug.cgi?id=199817
3589
3590         Reviewed by Geoff Garen.
3591
3592         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3593         (TEST):
3594         * TestWebKitAPI/cocoa/TestWKWebView.h:
3595         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3596         (-[WKWebView synchronouslyLoadRequest:]):
3597
3598 2019-07-18  Youenn Fablet  <youenn@apple.com>
3599
3600         Make sure to set kCTFontFallbackOptionAttribute to kCTFontFallbackOptionSystem for system fonts
3601         https://bugs.webkit.org/show_bug.cgi?id=199769
3602         <rdar://problem/49390297>
3603
3604         Reviewed by Myles C. Maxfield.
3605
3606         Add a font containing one extended character not found in system fonts.
3607
3608         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3609         * WebKitTestRunner/fonts/FakeHelvetica-SingleExtendedCharacter.ttf: Added.
3610 <