a3ae1d39f98c867d2ea1be98c2a572736e8cc1d4
[WebKit-https.git] / Tools / ChangeLog
1 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
2
3         Adding Myles Maxfield to contributors.json.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2013-08-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
8
9         [Qt] Do not check specifically for version 5.0
10         https://bugs.webkit.org/show_bug.cgi?id=119846
11
12         Reviewed by Jocelyn Turcotte.
13
14         For Qt 5.x we should always use both wk1 and wk2 basepath results.
15
16         * Scripts/webkitpy/port/qt.py:
17         (QtPort._search_paths):
18
19 2013-08-15  Simon Pena  <simon.pena@samsung.com>
20
21         <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
22
23         Reviewed by Gustavo Noronha Silva.
24
25         Following a similar approach as in r153977, return a path string
26         that is relative to main frame URL or just file name if the
27         resource is not in the same directory subtree, and replace empty
28         strings with "(null)".
29
30         Update pathFromSoupURI so it behaves more closely to the other
31         ports, and remove the unused code after we no longer print
32         <unknown> in certain cases. Also move
33         soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
34         be used both in TestRunnerGtk and in DumpRenderTree.
35
36         * DumpRenderTree/gtk/DumpRenderTree.cpp:
37         (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
38         we can print Soup URIs with the password, since soup_uri_to_string
39         doesn't preserve them.
40         (pathFromSoupURI): Updated following EFL implementation in
41         r153977, and return a WTFString instead of a CString.
42         (convertSoupMessageToURLPath): Return "(null)" instead of empty
43         strings, and handle the new return type of pathFromSoupURI.
44         (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
45         reference, and handle the new return type of pathFromSoupURI.
46         (descriptionSuitableForTestResult): Remove unused code.
47         (didFinishLoading): Use convertResourceToURLPath.
48         (didFailLoadingWithError): Use convertResourceToURLPath.
49         (authenticationCallback): Display the URL of the authentication
50         challenge.
51         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
52         soupURIToStringPreservingPassword.
53         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
54         soupURIToStringPreservingPassword.
55
56 2013-08-14  Tim Horton  <timothy_horton@apple.com>
57
58         Un-inline dataLog dumpers for IntSize and IntPoint
59         https://bugs.webkit.org/show_bug.cgi?id=119697
60
61         Reviewed by Sam Weinig.
62
63         * TestWebKitAPI/GNUmakefile.am:
64
65 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
66
67         Flakiness dashboard build fix.
68
69         * TestResultServer/static-dashboards/flakiness_dashboard.js:
70         (processTestRunsForBuilder):
71
72 2013-08-14  Martin Robinson  <mrobinson@igalia.com>
73
74         [GTK] [CMake] Add support for building TestWebKitAPI
75         https://bugs.webkit.org/show_bug.cgi?id=116987
76
77         Reviewed by Philippe Normand.
78
79         * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
80         platform-specific file, so that GTK+ can override them.
81         * TestWebKitAPI/PlatformGTK.cmake: Added.
82
83 2013-08-14  Brent Fulgham  <bfulgham@apple.com>
84
85         [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
86         https://bugs.webkit.org/show_bug.cgi?id=119775
87
88         This bug updates the WinLauncher program with a few useful menu
89         options to toggle certain debugging and development features of
90         WebKit.
91
92         Reviewed by Tim Horton.
93
94         * WinLauncher/WinLauncher.cpp:
95         (dllLauncherEntryPoint): Clean up preference objects on exit.
96         (ToggleMenuItem): New function.
97         (LaunchInspector): New function.
98         (WndProc): Add handler for new menu items. Also properly terminate
99         CFRunLoop operation on program exit.
100         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
101         menu items.
102         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
103         resource folder to search path.
104         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
105         for new menu items.
106
107 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
108
109         Add a hyperlink from build.webkit.org to the flakiness dashboard.
110
111         Rubbers-tamped by Simon Fraser.
112
113         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
114
115 2013-08-14  Benjamin Dupont   <bdupont@nds.com>
116
117         [Qt] Activate visibility API layout tests
118         https://bugs.webkit.org/show_bug.cgi?id=119790
119
120         Reviewed by Allan Sandfeld Jensen.
121
122         * DumpRenderTree/qt/TestRunnerQt.cpp:
123         (TestRunner::resetPageVisibility):
124         (TestRunner::setPageVisibility):
125
126 2013-08-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
127
128         [GTK] WK does not link properly against libxslt
129         https://bugs.webkit.org/show_bug.cgi?id=119688
130
131         Reviewed by Gustavo Noronha Silva.
132
133         * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
134         MiniBrowser.
135         * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
136
137 2013-08-13  Alexey Proskuryakov  <ap@apple.com>
138
139         [Mac] fast/dom/attr-style-too-lazy.html is flaky
140         https://bugs.webkit.org/show_bug.cgi?id=119763
141
142         Reviewed by Darin Adler.
143
144         * DumpRenderTree/mac/UIDelegate.mm:
145         (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
146         a test, it would just semi-randomly leak to the next one.
147         (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
148         for good measure.
149
150 2013-08-13  Tim Horton  <timothy_horton@apple.com>
151
152         [mac] Give MiniBrowser a reasonable bundle identifier
153         https://bugs.webkit.org/show_bug.cgi?id=119773
154
155         Rubber-stamped by Simon Fraser.
156
157         Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
158
159         * MiniBrowser/mac/Info.plist:
160         * MiniBrowser/mac/WebBundle/Info.plist:
161
162 2013-08-13  Dean Jackson  <dino@apple.com>
163
164         <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
165
166         Reviewed by Mark Rowe.
167
168         Have prepare-ChangeLog produce webkit.org/b/id style
169         URLs rather than exposing the inner workings of our
170         cgi. I was going to use the term "Future Proofing"
171         but that seems excessive :)
172
173         * Scripts/prepare-ChangeLog:
174         (main): Generate a more human readable form.
175         (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
176
177 2013-08-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
178
179         [EFL][DRT] Simplify call to reverseFind()
180         https://bugs.webkit.org/show_bug.cgi?id=119746
181
182         Reviewed by Christophe Dumez.
183
184         Follow-up to r153977.
185
186         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
187         (pathSuitableForTestResult): Instead of defining a static variable
188         that's only used in a single place, pass '/' to reverseFind() directly.
189
190 2013-08-13  Alberto Garcia  <berto@igalia.com>
191
192         [GTK] Closing inspector window crashes wk
193         https://bugs.webkit.org/show_bug.cgi?id=110865
194
195         Reviewed by Carlos Garcia Campos.
196
197         Disconnect all signal handlers if the inspector window is
198         destroyed.
199
200         * GtkLauncher/LauncherInspectorWindow.c:
201         (inspectorWindowDestroyed):
202         (launcherInspectorWindowNew):
203
204 2013-08-12  Dan Bernstein  <mitz@apple.com>
205
206         extract-localizable-strings output is not suited for parsing by Xcode
207         https://bugs.webkit.org/show_bug.cgi?id=119728
208
209         Reviewed by Darin Adler.
210
211         Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
212         removed “ERROR” since messages that refer to a line in a file are shown as error by default,
213         added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
214         with 0).
215
216         * Scripts/extract-localizable-strings:
217
218 2013-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
219
220         [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
221         https://bugs.webkit.org/show_bug.cgi?id=119585
222
223         Reviewed by Gyuyoung Kim.
224
225         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
226         (pathSuitableForTestResult):
227         Return path string that's relative to main frame URL, or just file name if
228         the resource is not in the same directory subtree.
229         Referenced WebKitTestRunner code in r153852.
230         (descriptionSuitableForTestResult):
231         (DumpRenderTreeChrome::onFrameRedirectRequested):
232         (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
233
234 2013-08-12  Dan Bernstein  <mitz@apple.com>
235
236         extract-localizable-strings doesn't know how to verify an existing strings file
237         https://bugs.webkit.org/show_bug.cgi?id=119704
238
239         Reviewed by Darin Adler.
240
241         * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
242         exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
243         exceptions file name to omitting the --exceptions option. Added a --skip option, changing
244         the way directories to skip are specified from prefixing the directory with a “-” to
245         specifying it with --skip.
246         Finally, added a --verify option. When specified, the strings file is not written to, but
247         instead read in and checked for consistency with the comments, keys and values derived from
248         the source files and the exceptions file. Missing keys, unused keys, mismatching values and
249         mismatching comments are reported as errors.
250         * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
251         directories to skip and no exceptions file.
252
253 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
254
255         http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
256         https://bugs.webkit.org/show_bug.cgi?id=85522
257
258         Reviewed by Andy Estes.
259
260         * DumpRenderTree/mac/UIDelegate.mm:
261         (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
262         when already done with a test. We already had this check in all UI delegate functions,
263         except for -webView:addMessageToConsole:withSource: somehow.
264
265 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
266
267         https://bugs.webkit.org/show_bug.cgi?id=119693
268         [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
269         because of connect-src-websocket-allowed.html
270
271         Reviewed by Darin Adler.
272
273         Starting a load of about:blank and immediately stopping it cancels outstanding
274         resource loads, but the page has to transition to committed state to have timers
275         or WebSockets stopped too.
276
277         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
278         ensure that transition to committed state happens before we start the next test.
279
280 2013-08-12  Beth Dakin  <bdakin@apple.com>
281
282         The LayoutMilestones didLayout callback should only fire for the main frame
283         https://bugs.webkit.org/show_bug.cgi?id=119457
284
285         Reviewed by Sam Weinig.
286
287         Now that the didLayout callback only fires for the main frame, we want to make 
288         sure it will fire even when all of the content is in a subframe.
289
290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
291         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
292         (TestWebKitAPI::didLayout):
293         (TestWebKitAPI::TEST):
294         * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
295
296 2013-08-12  Beth Dakin  <bdakin@apple.com>
297
298         Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
299         https://bugs.webkit.org/show_bug.cgi?id=119658
300
301         Reviewed by Darin Adler.
302
303         * MiniBrowser/mac/WK2BrowserWindowController.m:
304         (-[WK2BrowserWindowController awakeFromNib]):
305         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
306         (WTR::InjectedBundlePage::InjectedBundlePage):
307         * WebKitTestRunner/TestController.cpp:
308         (WTR::TestController::createWebViewWithOptions):
309
310 2013-08-12  Seokju Kwon  <seokju@webkit.org>
311
312         Remove glu's libtest rule from checker.py
313         https://bugs.webkit.org/show_bug.cgi?id=119674
314
315         Reviewed by Darin Adler.
316
317         * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
318
319 2013-08-11  ChangSeok Oh  <changseok.oh@collabora.com>
320
321         Unreviewed. Change my primary mail address.
322
323         * Scripts/webkitpy/common/config/contributors.json:
324
325 2013-08-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
326
327         [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
328         https://bugs.webkit.org/show_bug.cgi?id=115751
329
330         Reviewed by Martin Robinson.
331
332         * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
333         with yum.
334
335 2013-08-09  Beth Dakin  <bdakin@apple.com>
336
337         AX: Not able to use arrow keys to read text in a WK2 app
338         https://bugs.webkit.org/show_bug.cgi?id=119605
339         -and corresponding-
340         <rdar://problem/14281275>
341
342         Reviewed by Darin Adler.
343
344         New test verifies that didNotHandleKeyEvent will be called when there is nothing 
345         to scroll. 
346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
347         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
348         (TestWebKitAPI::didFinishLoadForFrame):
349         (TestWebKitAPI::didNotHandleKeyEventCallback):
350         (TestWebKitAPI::TEST):
351
352 2013-08-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
353
354         Add support for KeyboardEvent.location attribute
355         https://bugs.webkit.org/show_bug.cgi?id=119326
356
357         Reviewed by Benjamin Poulain.
358
359         Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
360
361         * DumpRenderTree/mac/EventSendingController.mm:
362         (-[EventSendingController keyDown:withModifiers:withLocation:]):
363         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
364         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
365         (-[EventSendingController handleEvent:]):
366         (-[EventSendingController fireKeyboardEventsToElement:]):
367
368 2013-08-09  Alexey Proskuryakov  <ap@apple.com>
369
370         <unknown> is often dumped instead of path in test output
371         https://bugs.webkit.org/show_bug.cgi?id=119590
372
373         Reviewed by Anders Carlsson.
374
375         There were two reasons for <unknown>:
376         1. When delegate logging is enabled via a testRunner call, that obviously happens
377         after main resource load starts, so we don't record its URL.
378         2. Authentication delegate logging relied on URL recording, but it's only turned on
379         when enabling resource loading delegate logging, not auth one.
380
381         URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
382         landed without posted rationale and unreviewed. Just undoing that change now.
383
384         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
385         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
386         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
387         (WTR::InjectedBundlePage::didInitiateLoadForResource):
388
389 2013-08-08  Alex Christensen  <achristensen@apple.com>
390
391         Windows build fixes.
392
393         Rubberstamped by Brent Fulgham.
394
395         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
396         Removed /SAFESEH link option which doesn't work with x64.
397
398 2013-08-08  Daniel Bates  <dabates@apple.com>
399
400         Add iOS support to run-javascriptcore-tests
401         https://bugs.webkit.org/show_bug.cgi?id=119602
402
403         Reviewed by Joseph Pecoraro.
404
405         Make run-javascriptcore-tests work for iOS WebKit.
406
407         * Scripts/run-javascriptcore-tests:
408
409 2013-08-08  Alexey Proskuryakov  <ap@apple.com>
410
411         [WK2] loader/go-back-cached-main-resource.html fails
412         https://bugs.webkit.org/show_bug.cgi?id=116491
413
414         Reviewed by Tim Horton.
415
416         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
417         * DumpRenderTree/gtk/DumpRenderTree.cpp:
418         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
419         * DumpRenderTree/win/DumpRenderTree.cpp:
420         Added FIXMEs about making path printing normalization more compatible.
421
422         * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
423         Return last path component in cases where we used to return a full path, which is
424         never desirable. Added a null check to basePath to prevent potentially getting
425         an Objective C exception.
426
427         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
428         (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
429         for a currently loading one (which is different for tests that use multiple windows).
430         Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
431         last path component as last fallback.
432         (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
433         frame URL here, and it was potentially a wrong frame.
434         (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
435         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
436         (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
437         (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
438         (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
439
440 2013-08-08  Alex Christensen  <achristensen@apple.com>
441
442         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
443         https://bugs.webkit.org/show_bug.cgi?id=116125
444
445         Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
446
447         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
448         (WTR::pathSuitableForTestResult):
449         Changed string operations to match _drt_descriptionSuitableForTestResult.
450         (WTR::dumpRequestDescriptionSuitableForTestResult):
451         (WTR::dumpResponseDescriptionSuitableForTestResult):
452         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
453         (WTR::InjectedBundlePage::didInitiateLoadForResource):
454         (WTR::InjectedBundlePage::willSendRequestForFrame):
455         (WTR::InjectedBundlePage::didReceiveResponseForResource):
456         Pass the main frame's URL to pathSuitableForTestResult.
457         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
458         Added WKBundlePageRef to willPerformClientRedirectForFrame.
459
460 2013-08-07  Simon Fraser  <simon.fraser@apple.com>
461
462         Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
463         https://bugs.webkit.org/show_bug.cgi?id=119317
464
465         Reviewed by Tim Horton.
466         
467         The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
468         the test to complete, which is not power friendly. Although DRT instances
469         are generally busy anyway, not sitting in a busy loop should free up some CPU
470         cycles for other instances of DRT.
471         
472         Editing tests continue to pass. All Java tests are skipped and were not
473         tested, but when run fail similarly with and without the patch.
474
475         * DumpRenderTree/mac/DumpRenderTree.mm:
476         (dump):
477         (runTest):
478
479 2013-08-07  Daniel Bates  <dabates@apple.com>
480
481         Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
482         <https://bugs.webkit.org/show_bug.cgi?id=119558>
483
484         Reviewed by Martin Robinson.
485
486         Currently we build the command line to execute jsDriver.pl twice so as to both
487         print it to standard output and actually execute it. We should only build up
488         this command line once. Moreover, we should print to standard output the actual
489         command line that we are going to use including the GTK- and EFL-specific call
490         to /Tools/jhbuild/jhbuild-wrapper.
491
492         * Scripts/run-javascriptcore-tests:
493
494 2013-08-07  Mario Sanchez Prada  <mario.prada@samsung.com>
495
496         [EFL] REGRESSION after r153432: some accessibility tests crash.
497         https://bugs.webkit.org/show_bug.cgi?id=119333
498
499         Reviewed by Darin Adler.
500
501         Use a RefPtr to store a reference to the parent element of
502         an AccessibilityUIElement instead of the raw pointer, so we
503         never derefence a function from an invalid pointer.
504
505         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
506         (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
507
508 2013-08-07  Cosmin Truta  <ctruta@blackberry.com>
509
510         Unreviewed. Add myself as a committer.
511
512         * Scripts/webkitpy/common/config/contributors.json:
513
514 2013-08-04  Sam Weinig  <sam@webkit.org>
515
516         Remove support for HTML5 MicroData
517         https://bugs.webkit.org/show_bug.cgi?id=119480
518
519         Reviewed by Anders Carlsson.
520
521         * Scripts/webkitperl/FeatureList.pm:
522         * qmake/mkspecs/features/features.pri:
523
524 2013-07-23  David Farler  <dfarler@apple.com>
525
526         Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
527         https://bugs.webkit.org/show_bug.cgi?id=117762
528
529         Reviewed by Mark Rowe.
530
531         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
532         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
533         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
534         Add ASAN_OTHER_LDFLAGS.
535         * MiniBrowser/Configurations/DebugRelease.xcconfig:
536         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
537         * Scripts/check-for-weak-vtables-and-externals:
538         Ignore ___asan externals, these are populated by compiler-rt.
539         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
540         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
541         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
542         Add ASAN_OTHER_LDFLAGS.
543         * WebKitLauncher/Configurations/Base.xcconfig:
544         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
545         * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
546         Add ASAN_OTHER_LDFLAGS.
547         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
548         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
549         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
550         Add ASAN_OTHER_LDFLAGS.
551         * asan/asan.xcconfig: Added.
552         * asan/webkit-asan-ignore.txt: Added.
553
554 2013-08-05  Brian Holt  <brian.holt@samsung.com>
555
556         [GTK] Implement leak checking with valgrind
557         https://bugs.webkit.org/show_bug.cgi?id=118785
558
559         Reviewed by Dirk Pranke.
560
561         Launch the DRT under Valgrind to generate xml files with details
562         of leaks found.
563
564         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
565         (parse_args):
566         * Scripts/webkitpy/port/gtk.py:
567         (GtkPort.__init__):
568         (GtkPort.default_timeout_ms): Allow extra time to run under
569         Valgrind.
570         (GtkPort.setup_environ_for_server): Pass Valgrind instructions
571         using environment variables.
572
573 2013-08-02  Mario Sanchez Prada  <mario.prada@samsung.com>
574
575         [EFL] REGRESSION after r153432: some accessibility tests crash.
576         https://bugs.webkit.org/show_bug.cgi?id=119333
577
578         Reviewed by Gustavo Noronha Silva.
579
580         Add missing null-check to avoid dereferencing a non-existent parent.
581
582         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
583         (WTR::attributesOfElement): Ditto.
584
585 2013-08-02  Patrick Gansterer  <paroga@webkit.org>
586
587         Add --rmdir option to git svn dcommit
588         https://bugs.webkit.org/show_bug.cgi?id=119398
589
590         Reviewed by Ryosuke Niwa.
591
592         Add this option tells git-svn to remove empty directories
593         from the svn tree so they do not leave over there.
594
595         * Scripts/webkitpy/common/checkout/scm/git.py:
596         (Git.push_local_commits_to_server):
597
598 2013-08-01  Brent Fulgham  <bfulgham@apple.com>
599
600         [Windows] WebKit1 Fullscreen Video Play is Broken
601         https://bugs.webkit.org/show_bug.cgi?id=119415
602
603         Reviewed by Jer Noble.
604
605         * WinLauncher/WinLauncher.cpp:
606         (dllLauncherEntryPoint): Activate full screen mode via
607         IWebPreferencesInternal interface.
608
609 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
610
611         Unreviewed. Add an alternative address to show my affiliation in team.html.
612
613         * Scripts/webkitpy/common/config/contributors.json:
614
615 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
616
617         Duplicate property names can cause test to fail
618         https://bugs.webkit.org/show_bug.cgi?id=119399
619
620         Reviewed by Dirk Pranke.
621
622         This problem was noticed when porting the patch for
623         http://wkb.ug/119357 to Blink: a test would fail because the converted
624         and test property lists weren't the same length, but they contained
625         all of the same property names. It looks like this is actually caused
626         by a bug in converting the HTML, which is being currently rewritten.
627         In the meantime, as long as this compares the number of unique
628         properties, it makes the test more robust.
629
630         * Scripts/webkitpy/w3c/test_converter_unittest.py:
631         (verify_prefixed_properties):
632
633 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
634
635         Unreviewed. Adding my expertise.
636
637         * Scripts/webkitpy/common/config/contributors.json:
638
639 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
640
641         Unreviewed. Add myself as a committer. Yoo-hoo! \o/
642
643         * Scripts/webkitpy/common/config/contributors.json:
644
645 2013-08-01  Commit Queue  <commit-queue@webkit.org>
646
647         Unreviewed, rolling out r153518.
648         http://trac.webkit.org/changeset/153518
649         https://bugs.webkit.org/show_bug.cgi?id=119386
650
651         The Jhbuild dep bump of GTK+ is not actually required by
652         layout testing, is causing pango dep problems (Requested by
653         zdobersek on #webkit).
654
655         * gtk/jhbuild.modules:
656
657 2013-08-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
658
659         Unreviewed. Add myself as a committer.
660
661         * Scripts/webkitpy/common/config/contributors.json:
662
663 2013-08-01  Jaehun Lim  <ljaehun.lim@samsung.com>
664
665         Unreviewed. Add myself as a committer.
666
667         * Scripts/webkitpy/common/config/contributors.json:
668
669 2013-07-31  Jinwoo Song  <jinwoo7.song@samsung.com>
670
671         Unreviewed. Add myself as a committer.
672
673         * Scripts/webkitpy/common/config/contributors.json:
674
675 2013-08-01  Alberto Garcia  <berto@igalia.com>
676
677         Unreviewed. Add myself as a committer.
678
679         * Scripts/webkitpy/common/config/contributors.json:
680
681 2013-07-31  Seokju Kwon  <seokju@webkit.org>
682
683         Unreviewed. Add myself as a committer.
684
685         * Scripts/webkitpy/common/config/contributors.json:
686
687 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
688
689         W3C test import script prefixes some properties that it shouldn't
690         https://bugs.webkit.org/show_bug.cgi?id=119357
691
692         Reviewed by Dirk Pranke.
693
694         Some prefixed properties also have unprefixed implemetations, but when
695         the implementations aren't identical, they aren't declared in
696         CSSPropertyNames.in on the same line. This fixes the import script so
697         that it catches all instances of prefixed properties that have an
698         unprefixed variant, and does not add the prefix in those cases.
699
700         * Scripts/webkitpy/w3c/test_converter.py:
701         (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
702         the properties on every line and record if they are prefixed or not.
703         Use this information to only return prefixed properties that do not
704         have any unprefixed variant. The prefixed property list has also
705         changed to not include the '-webkit-' prefix, making it much easier to
706         do the comparison, and removing the need to remove the prefix later.
707         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
708         longer needs to remove the '-webkit-' prefix, but needs to add it in
709         the case where a property that needs a prefix is found.
710         * Scripts/webkitpy/w3c/test_converter_unittest.py:
711         (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
712         for '-webkit-' prefix, as it is no longer included in the properties
713         in the prefixed property list.
714
715 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
716
717         Update location of w3c shapes tests to reflect new import location
718         https://bugs.webkit.org/show_bug.cgi?id=118156
719
720         Reviewed by Dirk Pranke.
721
722         Partial imports should not be imported to the same place as the full
723         import, so this adds an option to allow importing to a different
724         location than the default. In doing that, I found that imports from
725         contributor directories didn't seem to be working correctly, so I
726         updated the import to be smarter about both contributor directories
727         and the test status directories. It should now be more likely that the
728         script guesses the root directory properly.
729
730         * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
731             script not working with the full set of contributors, as that is
732             no longer true, and I didn't see a good way to keep that behavior.
733             Also update documentation to properly explain what happens when a
734             contributor dir is imported.
735         (main): Attempt to find the proper repo dir by looking at the
736             directory above the "test status" in the given path, this is still
737             not exactly right, but is less error prone than just trimming.
738         (parse_args): Add -d option to set the import directory.
739         (TestImporter.__init__): Stop appending the subdirs to the
740             destination_directory because it was making things more complex
741             and isn't really needed.
742         (TestImporter.update_test_status): Remove hardcoded strings and use
743             the TEST_STATUS constants instead.
744         * Scripts/webkitpy/w3c/test_importer_unittest.py:
745         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
746             support for new option.
747         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
748
749 2013-07-31  Brent Fulgham  <bfulgham@apple.com>
750
751         [Windows] Winlauncher shouldn't look for Safari Install Directory
752         https://bugs.webkit.org/show_bug.cgi?id=119351
753
754         Reviewed by Darin Adler.
755
756         * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
757         the Safari install location. Instead, use the proper support
758         library path for the build architecture.
759
760 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
761
762         Update scripts to reference contributors.json instead of committers.py in messaging
763         https://bugs.webkit.org/show_bug.cgi?id=119342
764
765         Reviewed by Ryosuke Niwa.
766
767         Change the scripts to point people to contributors.json instead of
768         committers.py since the latter no longer contains the list of
769         contributors.
770
771         * Scripts/webkitpy/common/config/committervalidator.py:
772         (CommitterValidator._contributors_json_path):
773         (CommitterValidator._flag_permission_rejection_message):
774         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
775         (CommitterValidatorTest.test_flag_permission_rejection_message):
776         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
777         (Bugzilla._commit_queue_flag):
778         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
779         (WatchListParser._validate):
780         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
781         (WatchListParserTest.test_cc_rule_with_invalid_email):
782         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
783         * Scripts/webkitpy/tool/commands/queues_unittest.py:
784         * Scripts/webkitpy/tool/steps/validatereviewer.py:
785         (ValidateReviewer.run):
786
787 2013-07-31  Roger Fong  <roger_fong@apple.com>
788
789         Unreviewed. Re-enable WinEWS tests following r153527.
790
791         * Scripts/webkitpy/common/config/ews.json:
792
793 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
794
795         Unreviewed: Adding myself to the committers' list.
796
797         * Scripts/webkitpy/common/config/contributors.json:
798
799 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
800
801         [Qt] Build WebKit with C++11
802         https://bugs.webkit.org/show_bug.cgi?id=119337
803
804         Reviewed by Csaba Osztrogonác.
805
806         Enable building with C++11.
807
808         * qmake/mkspecs/features/default_pre.prf:
809         * qmake/mkspecs/features/unix/default_post.prf:
810         * qmake/mkspecs/features/unix/default_pre.prf:
811
812 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
813
814         [Qt] ASSERTS trigger in release builds
815         https://bugs.webkit.org/show_bug.cgi?id=119336
816
817         Reviewed by Jocelyn Turcotte.
818
819         Ensure the qmake also defaults to release if no configuration is known.
820
821         * qmake/mkspecs/features/default_post.prf:
822
823 2013-07-31  Zan Dobersek  <zdobersek@igalia.com>
824
825         [texmap][GStreamer][GTK] composited video shows tearing
826         https://bugs.webkit.org/show_bug.cgi?id=118253
827
828         Reviewed by Martin Robinson.
829
830         * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
831         The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
832         screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
833
834 2013-07-30  Ruth Fong  <ruth_fong@apple.com>
835
836         Unreviewed: Adding myself to the committers' list.
837
838         * Scripts/webkitpy/common/config/contributors.json:
839
840 2013-07-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
841
842         Unreviewed, add my new email to contributors.json.
843
844         * Scripts/webkitpy/common/config/contributors.json:
845
846 2013-07-30  Krzysztof Czech  <k.czech@samsung.com>
847
848         [EFL] REGRESSION after r153439: layout tests do not run.
849         https://bugs.webkit.org/show_bug.cgi?id=119240
850
851         Reviewed by Christophe Dumez.
852
853         Changed attribute name from check_xvfb to check_driver.
854
855         * Scripts/webkitpy/port/efl.py:
856         (EflPort.check_sys_deps):
857
858 2013-07-29  Commit Queue  <commit-queue@webkit.org>
859
860         Unreviewed, rolling out r152860.
861         http://trac.webkit.org/changeset/152860
862         https://bugs.webkit.org/show_bug.cgi?id=119227
863
864         Disable WinEWS tests until tests stop crashing (Requested by
865         rfong on #webkit).
866
867         * Scripts/webkitpy/common/config/ews.json:
868
869 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
870
871         [GTK] Add WestonDriver, use it when appropriate
872         https://bugs.webkit.org/show_bug.cgi?id=119100
873
874         Reviewed by Dirk Pranke.
875
876         Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
877         and sets up an environment that enables the test runner to run inside it.
878
879         The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
880         environment variable is set, that is when NRWT is being run under a Wayland display.
881
882         * Scripts/webkitpy/port/base.py:
883         (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
884         * Scripts/webkitpy/port/gtk.py:
885         (GtkPort):
886         (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
887         should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
888         (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
889         instead of hard-coding the XvfbDriver class in the check.
890         * Scripts/webkitpy/port/westondriver.py: Added.
891         (WestonDriver):
892         (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
893         (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
894         (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
895         driver and then launches the driver in said environment, using the driver's Weston display.
896         (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
897         (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
898         and returns the absolute path to it.
899         * Scripts/webkitpy/port/xvfbdriver.py:
900         (XvfbDriver.check_driver): Renamed from check_xvfb.
901         (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
902
903 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
904
905         [ATK] Implement attributesOfChildren() for AccessibilityUIElement
906         https://bugs.webkit.org/show_bug.cgi?id=118967
907
908         Reviewed by Gustavo Noronha Silva.
909
910         Implemented AccessibilityUIElement::attributesOfChildren() both
911         in DumpRenderTree and the WebKitTestRunner.
912
913         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
914         (AccessibilityUIElement::attributesOfChildren): Implemented.
915
916         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
917         (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
918
919 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
920
921         [ATK] Implement allAttributes() for AccessibilityUIElement
922         https://bugs.webkit.org/show_bug.cgi?id=118966
923
924         Reviewed by Gustavo Noronha Silva.
925
926         Implemented AccessibilityUIElement::allAttributes() both in
927         DumpRenderTree and the WebKitTestRunner.
928
929         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
930         (getAtkAttributeSetAsString): Moved up in the file, and refactored
931         to use StringBuilder and return a String instead of a gchar*.
932         (roleToString): Changed not to return the "AXRole: " prefix, so
933         we can use it as well from attributesOfElement().
934         (attributesOfElement): New function to dump attributes for an object.
935         (AccessibilityUIElement::allAttributes): Call attributesOfElement().
936         (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
937
938         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
939         (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
940         a String instead of a gchar*.
941
942         (WTF::roleToString): Changed not to return the "AXRole: " prefix,
943         so we can use it as well from attributesOfElement().
944         (WTF::attributesOfElement): New function to dump attributes for an object.
945         (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
946         (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
947
948 2013-07-29  Daniel Bates  <dabates@apple.com>
949
950         Add support infrastructure for iOS WebKit port
951         https://bugs.webkit.org/show_bug.cgi?id=119168
952
953         Reviewed by Ryosuke Niwa.
954
955         Implement support infrastructure towards building iOS WebKit.
956
957         * Scripts/webkitdirs.pm:
958         (xcodeSDKPlatformName): Added.
959         (determineConfigurationProductDir):
960         (builtDylibPathForName):
961         (willUseIOSDeviceSDKWhenBuilding): Added.
962         (willUseIOSSimulatorSDKWhenBuilding): Added.
963         (isIOSWebKit): Added.
964         (copyInspectorFrontendFiles):
965
966 2013-07-29  Sergio Correia  <sergio.correia@openbossa.org>
967
968         CoordinatedGraphics: Add API to get and set the active state of a WebView
969         https://bugs.webkit.org/show_bug.cgi?id=119067
970
971         Reviewed by Noam Rosenthal.
972
973         Added API tests for WKViewIsActive and WKViewSetIsActive.
974
975         * TestWebKitAPI/PlatformEfl.cmake:
976         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
977         (TestWebKitAPI::didFinishLoadForFrame):
978         (TestWebKitAPI::webProcessCrashed):
979         (TestWebKitAPI::webProcessRelaunched):
980         (TestWebKitAPI::TEST):
981         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
982         Bundle added to allow crashing the WebProcess and testing the active state of a view
983         under such condition.
984         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
985         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
986
987 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
988
989         [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
990         https://bugs.webkit.org/show_bug.cgi?id=119212
991
992         Reviewed by Carlos Garcia Campos.
993
994         * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
995         variables that are not defined during the configuration process.
996         * TestWebKitAPI/GNUmakefile.am: Ditto.
997         * WebKitTestRunner/GNUmakefile.am: Ditto.
998
999 2013-07-28  Andy Estes  <aestes@apple.com>
1000
1001         Include <stdio.h> to declare perror()
1002         https://bugs.webkit.org/show_bug.cgi?id=119198
1003
1004         Reviewed by Andreas Kling.
1005
1006         Silences an implicit declaration warning.
1007
1008         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
1009
1010 2013-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
1011
1012         [EFL] Bump required version of EFL to 1.7
1013         https://bugs.webkit.org/show_bug.cgi?id=119144
1014
1015         Reviewed by Christophe Dumez.
1016
1017         * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
1018
1019 2013-07-26  Filip Pizlo  <fpizlo@apple.com>
1020
1021         WKTR should know about the JSC extensions to testRunner
1022         https://bugs.webkit.org/show_bug.cgi?id=119154
1023
1024         Reviewed by Mark Hahnenberg and Geoffrey Garen.
1025         
1026         This makes some fast/js tests pass.
1027
1028         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1029         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1030         (WTR::TestRunner::numberOfDFGCompiles):
1031         (WTR::TestRunner::neverInlineFunction):
1032         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1033
1034 2013-07-25  Mark Rowe  <mrowe@apple.com>
1035
1036         Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
1037
1038         * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
1039         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
1040         so they pull the version out of the SDK.
1041
1042 2013-07-25  Anders Carlsson  <andersca@apple.com>
1043
1044         Localizable.strings generated by extract-localizable-strings should be UTF-8
1045         https://bugs.webkit.org/show_bug.cgi?id=119106
1046
1047         Reviewed by Mark Rowe.
1048
1049         Output strings as UTF-8.
1050
1051         * Scripts/extract-localizable-strings:
1052
1053 2013-07-25  Sam Weinig  <sam@webkit.org>
1054
1055         -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
1056         https://bugs.webkit.org/show_bug.cgi?id=119099
1057         <rdar://problem/13439291>
1058
1059         Reviewed by Enrica Casucci.
1060
1061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1062         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1063         (TestWebKitAPI::attributedString):
1064         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1065         (TestWebKitAPI::AttributedStringTest_CustomFont::url):
1066         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
1067         (TestWebKitAPI::TEST_F):
1068         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1069         (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
1070         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
1071         * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
1072         Add tests for attributed strings with strikethrough.  Refactor the attributed string tests
1073         to make adding more easier in the future.
1074
1075 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
1076
1077         fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
1078         https://bugs.webkit.org/show_bug.cgi?id=118948
1079
1080         Reviewed by Sam Weinig.
1081         
1082         - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
1083           by exporting it as a function.
1084         
1085         - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
1086           it even if you know that you've already done so. See processIRDump.sh.
1087         
1088         - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
1089           runs it through ReducedFTL automatically. You typically want to say something like:
1090           
1091           jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
1092           ./processIRDump.sh --timing < jsc-output.txt
1093
1094         * ReducedFTL/ReducedFTL.c:
1095         (webkit_osr_exit):
1096         * ReducedFTL/combineModules.rb:
1097         * ReducedFTL/processIRDump.sh: Added.
1098
1099 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
1100
1101         fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
1102         https://bugs.webkit.org/show_bug.cgi?id=118947
1103
1104         Reviewed by Dan Bernstein.
1105
1106         * Scripts/copy-webkitlibraries-to-product-directory:
1107
1108 2013-07-16  Filip Pizlo  <fpizlo@apple.com>
1109
1110         fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
1111         https://bugs.webkit.org/show_bug.cgi?id=118647
1112
1113         Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
1114
1115         Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
1116         way that the FTL would.
1117         
1118         Also add a tool that combines multiple LLVM modules generated by FTL into a
1119         single module.
1120
1121         * ReducedFTL: Added.
1122         * ReducedFTL/ReducedFTL.c: Added.
1123         (usage):
1124         (currentTime):
1125         (MemorySection):
1126         (mmAllocateCodeSection):
1127         (mmAllocateDataSection):
1128         (mmApplyPermissions):
1129         (mmDestroy):
1130         (symbolLookupCallback):
1131         (main):
1132         * ReducedFTL/build.sh: Added.
1133         * ReducedFTL/combineModules.rb: Added.
1134
1135 2013-06-09  Filip Pizlo  <fpizlo@apple.com>
1136
1137         Unreviewed, fix minor goof in profiling output layout. We weren't accounting
1138         for the "/" that is printed between engine counts.
1139
1140         * Scripts/display-profiler-output:
1141
1142 2013-05-28  Filip Pizlo  <fpizlo@apple.com>
1143
1144         testRunner should have a way of disabling inlining of functions
1145         https://bugs.webkit.org/show_bug.cgi?id=116875
1146
1147         Reviewed by Mark Hahnenberg.
1148
1149         * DumpRenderTree/TestRunner.cpp:
1150         (neverInlineFunction):
1151         (TestRunner::staticFunctions):
1152
1153 2013-05-27  Filip Pizlo  <fpizlo@apple.com>
1154
1155         testRunner should be able to tell you if a function is DFG compiled
1156         https://bugs.webkit.org/show_bug.cgi?id=116847
1157
1158         Reviewed by Mark Hahnenberg.
1159
1160         * DumpRenderTree/TestRunner.cpp:
1161         (numberOfDFGCompiles):
1162         (TestRunner::staticFunctions):
1163
1164 2013-05-21  Filip Pizlo  <fpizlo@apple.com>
1165
1166         fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
1167         https://bugs.webkit.org/show_bug.cgi?id=116556
1168
1169         Reviewed by Oliver Hunt.
1170         
1171         This adds three new capabilities:
1172         
1173         - 'display' now accepts negative compilation indices, and allows specifying
1174           wildcard hashes combined with combination indices. Previously you could say
1175           'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
1176           latter would display every compilation. This improves this so that you can
1177           say 'display *-<index>-<engine>'. It also makes it so that you can give a
1178           negative index, which allows you to say things like 'display blah--1-dfg',
1179           which displays just the last DFG compilation. Also you can say
1180           'display *--1-dfg', which displays the last DFG compilation for each code
1181           block. I realize that this is kind of ugly, but gosh is it practical.
1182         
1183         - You can now say 'sort hash', which will henceforth sort all of the output
1184           by code hash rather than by the time when it was compiled. This means that
1185           if you're doing 'dispay *--1-dfg' and then want to diff the results against
1186           something else, you can ensure that this doesn't get confused just by
1187           changes in compilation order.
1188         
1189         - You can now say 'counts off', which will henceforth disable the display of
1190           execution counts from 'bytecode' and 'display'. This is also useful for
1191           diffs, since if you're trying to figure out why two compilations are
1192           different, they probably have radically different counts. 'counts off' gets
1193           this out of the output so that it doesn't confuse your diff.
1194         
1195         Note that to use this effectively you should also have a script that scrubs
1196         pointers from text so that the diff doesn't get confused by pointers. I'll
1197         post my elimptr script to the bug. Maybe at some point I'll integrate that
1198         into display-profiler-output.
1199         
1200         Put together this is pretty awesome. I was able to do the following:
1201         
1202         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
1203         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
1204         diff -u richards-serial.asm richards-concurrent.asm
1205         
1206         And this immediately told me that the reason why richards is slower in the
1207         concurrent compilation case is just that we end up compiling *tons* more
1208         functions, most of which are trivially inlineable. Basically, concurrent
1209         compilation breaks our previous heuristics for delaying compilation of
1210         inlineables just enough that they never trigger compilation. We should fix
1211         that in a separate bug.
1212
1213         * Scripts/display-profiler-output:
1214
1215 2013-04-30  Filip Pizlo  <fpizlo@apple.com>
1216
1217         fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
1218
1219         Rubber stamped by Mark Rowe.
1220
1221         * Scripts/copy-webkitlibraries-to-product-directory:
1222
1223 2013-07-16  Oliver Hunt <oliver@apple.com>
1224
1225         Merge dfgFourthTier r148853
1226
1227     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1228
1229         fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
1230         https://bugs.webkit.org/show_bug.cgi?id=114933
1231
1232         Reviewed by Andy Estes.
1233         
1234         This makes it easy to get set up for tandem LLVM builds.
1235
1236         * Scripts/copy-webkitlibraries-to-product-directory:
1237
1238 2013-07-16  Oliver Hunt <oliver@apple.com>
1239
1240         Merge dfgFourthTier r148850
1241
1242     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1243
1244         fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
1245         https://bugs.webkit.org/show_bug.cgi?id=114926
1246
1247         Reviewed by Geoffrey Garen.
1248         
1249         If the LLVM libraries change, then touch a phony header, which will force relink
1250         of JavaScriptCore.
1251
1252         * Scripts/copy-webkitlibraries-to-product-directory:
1253         (unpackIfNecessary):
1254
1255 2013-07-16  Oliver Hunt <oliver@apple.com>
1256
1257         Merge dfgFourthTier r148848
1258
1259     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1260
1261         fourthTier: developing LLVM in tandem with WebKit should be fun and easy
1262         https://bugs.webkit.org/show_bug.cgi?id=114925
1263
1264         Reviewed by Geoffrey Garen.
1265         
1266         This enables building LLVM along with WebKit, so that build-jsc and build-webkit
1267         will also optionally build LLVM and quickly symlink LLVM's built products into
1268         the right places.
1269         
1270         Most WebKit and JSC hackers will want to rely on the checked-in already-built
1271         versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
1272         increasingly common use-case for me, and it may become a common use case for a
1273         handful of others. Currently, this is really painful: you first have to build
1274         LLVM, then you have to export-llvm-build (which takes a while), and then you
1275         have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
1276         variables are set to point to the thing you exported. The whole process loses
1277         track of dependencies very quickly: making a tiny change in LLVM requires
1278         packaging, and then unpackaging, a large number of potentially large headers and
1279         static libraries. Not only is this slow but it then causes the WebKit build
1280         system to rebuild anything that transitively includes any LLVM header, which is
1281         now quite a few files. While this sort of use pattern is still worthwhile if
1282         you're trying to package a binary drop and test it, it's not great if you're
1283         just trying to do experimental development that involves making small changes
1284         in both trees.
1285         
1286         This change fixes this use case while keeping the old use cases intact. You can
1287         do tandem development using one of two modes:
1288         
1289         Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
1290         the LLVM directory you're using. Once this is done, any invocation of a WebKit
1291         build via build-jsc or build-webkit will also build LLVM, and then quickly
1292         symlink things into place without perturbing dependency tracking.
1293         
1294         Internal LLVM directory: if you check out llvm into a directory called 'llvm'
1295         right off of the WebKit source tree, then the build system will automatically
1296         use this.
1297         
1298         Here's how this takes care of dependencies:
1299         
1300         Headers: the include/llvm and include/llvm-c directories are symlinked into
1301         $productsDir/usr/local/include. And then everything just works.
1302         
1303         Libraries: the build system detects, by reading LLVM's Makefile.config, which
1304         mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
1305         the .a files into $productsDir/<thingy>. It will ranlib those libraries only
1306         if they have changed, by checking both the modification time and also whether
1307         the last time we had a symlink, that symlink was from the same directory.
1308         This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
1309         but that build wasn't yet ranlib'd.
1310         
1311         One problem that this does not yet solve is that xcodebuild will not relink
1312         JavaScriptCore if the only thing that changed was the libraries. I will work
1313         on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
1314
1315         * Scripts/copy-webkitlibraries-to-product-directory:
1316         (unpackIfNecessary):
1317         (fileContains):
1318         (fileContentsEquals):
1319
1320 2013-04-15  Filip Pizlo  <fpizlo@apple.com>
1321
1322         fourthTier: Update LLVM-related build scripts to copy generated headers as well
1323         https://bugs.webkit.org/show_bug.cgi?id=114551
1324
1325         Reviewed by Oliver Hunt.
1326         
1327         Also added the ability to use something other than bzip2 compression, since although
1328         it is great for checking things into the tree, it increases turn-around times when
1329         experimenting.
1330
1331         * Scripts/copy-webkitlibraries-to-product-directory:
1332         (unpackIfNecessary):
1333         * Scripts/export-llvm-build:
1334
1335 2013-04-03  Filip Pizlo  <fpizlo@apple.com>
1336
1337         fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
1338         https://bugs.webkit.org/show_bug.cgi?id=113921
1339
1340         Reviewed by Oliver Hunt.
1341
1342         The LLVM community wants us to continue including all of LLVM's C++ headers. Change
1343         the export script to do this.
1344         
1345         * Scripts/export-llvm-build:
1346
1347 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
1348
1349         fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
1350         https://bugs.webkit.org/show_bug.cgi?id=113452
1351
1352         Rubber stamped by Mark Hahnenberg.
1353
1354         * Scripts/copy-webkitlibraries-to-product-directory:
1355         * Scripts/export-llvm-build:
1356
1357 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
1358
1359         fourthTier: FTL JIT should be able run some simple function
1360         https://bugs.webkit.org/show_bug.cgi?id=113481
1361
1362         Reviewed by Geoffrey Garen.
1363         
1364         Give the scripts the ability to find an LLVM build and use it.
1365         
1366         Also added a script, export-llvm-build, that allows you to take your
1367         own build of LLVM and package it for use by WebKit's build system.
1368         
1369         The build system treats a "build" of LLVM as a pair of .tar.bz2's,
1370         one for the library archives and one for the headers. It then unpacks
1371         them into your built products directory in a mannner that is mostly
1372         analogous to how WebKitSystemInterface works.
1373
1374         * Scripts/build-jsc:
1375         * Scripts/copy-webkitlibraries-to-product-directory:
1376         (unpackIfNecessary):
1377         (dittoHeaders):
1378         * Scripts/export-llvm-build: Added.
1379
1380 2013-07-24  Anders Carlsson  <andersca@apple.com>
1381
1382         Crash when calling WKPageGetProcessIdentifier after aborted process launch
1383         https://bugs.webkit.org/show_bug.cgi?id=119069
1384         <rdar://problem/14494064>
1385
1386         Reviewed by Andreas Kling.
1387
1388         Add a test.
1389
1390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1391         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
1392         (TestWebKitAPI::didFinishLoadForFrame):
1393         (TestWebKitAPI::TEST):
1394
1395 2013-07-24  Zan Dobersek  <zdobersek@igalia.com>
1396
1397         Make KURL::hasPath private
1398         https://bugs.webkit.org/show_bug.cgi?id=118279
1399
1400         Reviewed by Darin Adler.
1401
1402         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1403         (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
1404
1405 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1406
1407         [GTK] TestInspectorServer unit test is timing out
1408         https://bugs.webkit.org/show_bug.cgi?id=105866
1409
1410         Reviewed by Gustavo Noronha Silva.
1411
1412         * Scripts/run-gtk-tests:
1413         (TestRunner):
1414
1415 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1416
1417         [GTK] [WK2] Handle wheel event with delta zero
1418         https://bugs.webkit.org/show_bug.cgi?id=118973
1419
1420         Reviewed by Gustavo Noronha Silva.
1421
1422         Added handling of zero mouse scroll deltas in EventSenderProxy similar
1423         to WK1 and Qt/EFL ports.
1424
1425         fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
1426         failing on WK2.
1427
1428         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1429         (WTR::EventSenderProxy::mouseScrollBy):
1430
1431 2013-07-23  Andreas Kling  <akling@apple.com>
1432
1433         REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
1434         <rdar://problem/14324895>
1435         <http://webkit.org/b/119023>
1436
1437         Reviewed by Simon Fraser.
1438
1439         Add a test for this rather specific problem.
1440
1441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1442         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
1443         (TestWebKitAPI::TEST):
1444         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
1445         (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
1446         (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
1447         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1448
1449 2013-07-23  Tim Horton  <timothy_horton@apple.com>
1450
1451         Add a test for plug-in unavailability indicator obscurity detection
1452         https://bugs.webkit.org/show_bug.cgi?id=119007
1453
1454         Reviewed by Anders Carlsson.
1455
1456         Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
1457
1458         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1459         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1460         (WTR::TestRunner::setBlockAllPlugins):
1461         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1462         * WebKitTestRunner/TestInvocation.cpp:
1463         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1464         Add testRunner.setBlockAllPlugins function (and corresponding message to
1465         forward it through to TestController).
1466
1467         * WebKitTestRunner/TestController.cpp:
1468         Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
1469
1470         (WTR::TestController::createWebViewWithOptions):
1471         Register our pluginLoadPolicy callback.
1472
1473         (WTR::TestController::resetStateToConsistentValues):
1474         Reset m_shouldBlockAllPlugins to false.
1475
1476         (WTR::TestController::pluginLoadPolicy):
1477         Return the existing plugin load policy, unless setBlockAllPlugins(true)
1478         was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
1479
1480         * WebKitTestRunner/TestController.h:
1481         (WTR::TestController::setBlockAllPlugins):
1482
1483 2013-07-21  Andreas Kling  <akling@apple.com>
1484
1485         KURL creates duplicate strings when completing data: URIs.
1486         <http://webkit.org/b/118952>
1487         <rdar://problem/14504480>
1488
1489         Reviewed by Anders Carlsson.
1490
1491         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1492         (TestWebKitAPI::TEST_F):
1493
1494 2013-07-19  Chris Fleizach  <cfleizach@apple.com>
1495
1496         AX: VoiceOver not detecting misspelled words don't work in all cases
1497         https://bugs.webkit.org/show_bug.cgi?id=118924
1498
1499         Reviewed by Tim Horton.
1500
1501         Make the misspelled detection dependent on both types of attributes being present.
1502
1503         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1504         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1505         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1506         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1507
1508 2013-07-19  Alex Christensen  <achristensen@apple.com>
1509
1510         Improved code coverage generation.
1511         https://bugs.webkit.org/show_bug.cgi?id=118926
1512
1513         Reviewed by Tim Horton.
1514
1515         * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
1516         * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
1517         (generateReport): Moved report generation to a subroutine.
1518
1519 2013-07-19  Stephanie Lewis  <slewis@apple.com>
1520
1521         <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
1522
1523         Unreviewed.
1524
1525         Rebaseline pagination test after http://trac.webkit.org/changeset/152911
1526
1527         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1528         (TestWebKitAPI::didLayout):
1529
1530 2013-07-19  Daniel Bates  <dabates@apple.com>
1531
1532         Make Perl tools work when using git bisect with Git branch build setup
1533         https://bugs.webkit.org/show_bug.cgi?id=118512
1534
1535         Reviewed by Martin Robinson.
1536
1537         The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
1538         during a git bisect session with a Git branch build setup (i.e. git config
1539         core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
1540         specific build of WebKit because they cannot determine the branch Git is on (since
1541         git bisect puts Git into a detached HEAD state). We should teach our tooling to
1542         parse the file .git/BISECT_START (created by git bisect start) for the name of the
1543         branch Git was on when we began a git bisect session. Then the tools can determine
1544         the path to the built WebKit.
1545
1546         * Scripts/VCSUtils.pm:
1547         (gitDirectory): Added.
1548         (gitBisectStartBranch): Added.
1549         (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
1550         HEAD (e.g. running git bisect).
1551         (determineVCSRoot): Modified to call gitDirectory() to determine the path to
1552         the .git directory in the Git checkout.
1553
1554 2013-07-19  Alex Christensen  <achristensen@apple.com>
1555
1556         Added x64 configuration to Visual Studio build.
1557         https://bugs.webkit.org/show_bug.cgi?id=118888
1558
1559         Reviewed by Brent Fulgham.
1560
1561         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1562         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1563         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1564         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1565         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1566         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1567         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1568         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1569         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1570         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1571         * win/record-memory/record-memory.vcxproj:
1572
1573 2013-07-19  Martin Robinson  <mrobinson@igalia.com>
1574
1575         Add a couple people to the MathML watchlist
1576         https://bugs.webkit.org/show_bug.cgi?id=118909
1577
1578         Reviewed by Andreas Kling.
1579
1580         Add a couple people to the MathML watchlist and add Kalyan's other
1581         email address to fix style checker warnings about the watchlist
1582         contents.
1583
1584         * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
1585         list of contributors and add Kalyan's second email address.
1586         * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
1587         watchlist.
1588
1589 2013-07-19  Simon Pena  <simon.pena@samsung.com>
1590
1591         [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
1592         https://bugs.webkit.org/show_bug.cgi?id=118895
1593
1594         Reviewed by Philippe Normand.
1595
1596         In r152782 an uri is used to create an string representation without checking first if it
1597         is valid. That fails later when the string is used to check for existing redirections. This
1598         patch ensures that the uri is valid before using it.
1599
1600         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1601         (willSendRequestCallback): Ensure an uri is valid before using it.
1602
1603 2013-07-18  Timothy Hatcher  <timothy@apple.com>
1604
1605         Add extract-localizable-js-strings and use it for WebInspectorUI.
1606
1607         https://bugs.webkit.org/show_bug.cgi?id=118851
1608
1609         Reviewed by Joseph Pecoraro.
1610
1611         * Scripts/extract-localizable-js-strings: Added.
1612         * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
1613         * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
1614         the WebInspectorUI project.
1615
1616 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
1617
1618         [Windows] Build correction #2 after r152861.
1619
1620         * WinLauncher/WinLauncher.cpp: Declare proper linkage.
1621
1622 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
1623
1624         [Windows] Build correction after r152861.
1625
1626         * WinLauncher/WinLauncher.cpp: Don't reference private header.
1627
1628 2013-07-16  Brent Fulgham  <bfulgham@apple.com>
1629
1630         [Win] Support in-band text tracks.
1631         https://bugs.webkit.org/show_bug.cgi?id=103770
1632
1633         Reviewed by Eric Carlson.
1634
1635         Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
1636         libdispatch and CFRunLoop elements are services during the run loop.
1637
1638         * WinLauncher/WinLauncher.cpp:
1639         (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
1640         a CoreFoundation (or CFLite) support library.
1641         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
1642         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
1643         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
1644         and WinLauncherCFLite.props.
1645
1646 2013-07-18  Roger Fong  <roger_fong@apple.com>
1647
1648         Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
1649
1650         * Scripts/webkitpy/common/config/ews.json:
1651
1652 2013-07-18  Daniel Bates  <dabates@apple.com>
1653
1654         REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
1655         https://bugs.webkit.org/show_bug.cgi?id=118854
1656         <rdar://problem/14081339>
1657
1658         Reviewed by David Kilzer.
1659
1660         Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
1661         Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
1662         run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
1663         listen on these ports so that we can run tests that use port 8443 and 8080.
1664
1665         * Scripts/old-run-webkit-tests:
1666         (configureAndOpenHTTPDIfNeeded):
1667
1668 2013-07-17  Tim Horton  <timothy_horton@apple.com>
1669
1670         Update blocked/missing plug-in UI
1671         https://bugs.webkit.org/show_bug.cgi?id=118347
1672         <rdar://problem/14209318>
1673
1674         Reviewed by Sam Weinig.
1675
1676         * MiniBrowser/mac/WK2BrowserWindowController.m:
1677         (-[WK2BrowserWindowController awakeFromNib]):
1678         * WebKitTestRunner/TestController.cpp:
1679         (WTR::TestController::createWebViewWithOptions):
1680         Match new WKPageLoaderClient entry.
1681
1682 2013-07-17  Commit Queue  <commit-queue@webkit.org>
1683
1684         Unreviewed, rolling out r152701, r152703, r152739, r152754,
1685         and r152756.
1686         http://trac.webkit.org/changeset/152701
1687         http://trac.webkit.org/changeset/152703
1688         http://trac.webkit.org/changeset/152739
1689         http://trac.webkit.org/changeset/152754
1690         http://trac.webkit.org/changeset/152756
1691         https://bugs.webkit.org/show_bug.cgi?id=118821
1692
1693         this was a buggy fix and we're going to try something
1694         different (Requested by thorton on #webkit).
1695
1696         * MiniBrowser/mac/WK2BrowserWindowController.m:
1697         (-[WK2BrowserWindowController awakeFromNib]):
1698         * WebKitTestRunner/TestController.cpp:
1699         (WTR::TestController::createWebViewWithOptions):
1700
1701 2013-07-17  Commit Queue  <commit-queue@webkit.org>
1702
1703         Unreviewed, rolling out r151535.
1704         http://trac.webkit.org/changeset/151535
1705         https://bugs.webkit.org/show_bug.cgi?id=118804
1706
1707         Re-disable WinEWS tests (Requested by rfong on #webkit).
1708
1709         * Scripts/webkitpy/common/config/ews.json:
1710
1711 2013-07-17  Simon Pena  <simon.pena@samsung.com>
1712
1713         [GTK] Make DRT obbey testRunner's addURLToRedirect
1714         https://bugs.webkit.org/show_bug.cgi?id=118239
1715
1716         Reviewed by Gustavo Noronha Silva.
1717
1718         Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
1719         to the proper URI when indicated.
1720
1721         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1722         (willSendRequestCallback):
1723
1724 2013-07-17  Gabor Abraham  <abrhm@inf.u-szeged.hu>
1725
1726         Add a new find-resolved-bugs command to webkit-patch.
1727         https://bugs.webkit.org/show_bug.cgi?id=118060
1728
1729         Reviewed by Csaba Osztrogonác.
1730
1731         * Scripts/webkitpy/tool/commands/queries.py:
1732         (PrintBaselines._platform_for_path):
1733         (FindResolvedBugs):
1734         (FindResolvedBugs.execute):
1735
1736 2013-07-16  Balazs Kelemen  <kbalazs@webkit.org>
1737
1738         [CMake] Undefined references should be detected at build time
1739         https://bugs.webkit.org/show_bug.cgi?id=110236
1740
1741         Reviewed by Christophe Dumez.
1742
1743         Add library dependencies that were not defined explicitly before.
1744
1745         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1746         * TestWebKitAPI/CMakeLists.txt:
1747         * WebKitTestRunner/CMakeLists.txt:
1748
1749 2013-07-16  Kwang Yul Seo  <skyul@company100.net>
1750
1751         check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
1752         https://bugs.webkit.org/show_bug.cgi?id=118755
1753
1754         Reviewed by Ryosuke Niwa.
1755
1756         Fix r152719 to check "using namespace foo;" only in headers.
1757
1758         * Scripts/webkitpy/style/checkers/cpp.py:
1759         (check_using_namespace):
1760         (check_style):
1761         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1762         (WebKitStyleTest.test_using_namespace):
1763
1764 2013-07-16  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1765
1766         Get rid of multiple inheritance support from the bindings generators
1767         https://bugs.webkit.org/show_bug.cgi?id=118353
1768
1769         Reviewed by Kentaro Hara.
1770
1771         Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
1772         deprecated domInterface->parents.
1773
1774         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1775         (_parentInterface):
1776
1777 2013-07-16  Brian Holt  <brian.holt@samsung.com>
1778
1779         check-webkit-style: "using namespace foo;" should be flagged as an error in headers
1780         https://bugs.webkit.org/show_bug.cgi?id=57241
1781
1782         Reviewed by Ryosuke Niwa.
1783
1784         Added check for "using namespace foo" and unit test.
1785
1786         * Scripts/webkitpy/style/checkers/cpp.py:
1787         (check_using_namespace):
1788         (check_style):
1789         (CppChecker):
1790         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1791         (WebKitStyleTest.test_using_namespace):
1792
1793 2013-07-16  Anton Obzhirov  <a.obzhirov@samsung.com>
1794
1795         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
1796         https://bugs.webkit.org/show_bug.cgi?id=110222
1797
1798         Reviewed by Gustavo Noronha Silva.
1799
1800         Added handling of zero mouse scroll deltas in EventSender.
1801
1802         * DumpRenderTree/gtk/EventSender.cpp:
1803         (mouseScrollByCallback):
1804
1805 2013-07-16  Brian Holt  <brian.holt@samsung.com>
1806
1807         webkitpy: replace urllib with urllib2 for downloading additional modules
1808         https://bugs.webkit.org/show_bug.cgi?id=118671
1809
1810         Reviewed by Ryosuke Niwa.
1811
1812         Urllib2 is available whereever urllib is, but has better proxy support.
1813
1814         * Scripts/webkitpy/common/system/autoinstall.py:
1815         (AutoInstaller._download_to_stream):
1816
1817 2013-07-16  Krzysztof Czech  <k.czech@samsung.com>
1818
1819         [ATK] Adds support for aria-haspopup property.
1820         https://bugs.webkit.org/show_bug.cgi?id=117834
1821
1822         Reviewed by Christophe Dumez.
1823
1824         Adds implementation for testing aria-haspopup property.
1825
1826         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1827         (getAttributeSetValueForId):
1828         (AccessibilityUIElement::stringAttributeValue):
1829         (AccessibilityUIElement::hasPopup):
1830         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1831         (WTR::getAttributeSetValueForId):
1832         (WTR::AccessibilityUIElement::stringAttributeValue):
1833         (WTR::AccessibilityUIElement::hasPopup):
1834
1835 2013-07-16  Michael Brüning  <michael.bruning@digia.com>
1836
1837         [Qt] Replace Nokia references.
1838         https://bugs.webkit.org/show_bug.cgi?id=118728
1839
1840         Reviewed by Simon Hausmann.
1841
1842         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1843         (MiniBrowserApplication::MiniBrowserApplication):
1844         * QtTestBrowser/qttestbrowser.cpp:
1845         (LauncherApplication::LauncherApplication):
1846
1847 2013-07-15  Tim Horton  <timothy_horton@apple.com>
1848
1849         Update blocked/missing plug-in UI
1850         https://bugs.webkit.org/show_bug.cgi?id=118347
1851         <rdar://problem/14209318>
1852
1853         Reviewed by Sam Weinig.
1854
1855         * MiniBrowser/mac/WK2BrowserWindowController.m:
1856         (-[WK2BrowserWindowController awakeFromNib]):
1857         * WebKitTestRunner/TestController.cpp:
1858         (WTR::TestController::createWebViewWithOptions):
1859         Match new WKPageLoaderClient entry.
1860
1861 2013-07-15  Chris Fleizach  <cfleizach@apple.com>
1862
1863         Update James Craig's email address.
1864
1865         * Scripts/webkitpy/common/config/contributors.json:
1866
1867 2013-07-15  Dong-Gwan Kim  <donggwan.kim@samsung.com>
1868
1869         [EFL] Add fallback for TestWebKitAPI if opengl is not available.
1870         https://bugs.webkit.org/show_bug.cgi?id=118583
1871
1872         Reviewed by Christophe Dumez.
1873
1874         There're many fails on efl webkit2 API test if opengl is not available.
1875         So, add fallback to non-opengl evas engine.
1876
1877         * TestWebKitAPI/efl/PlatformWebView.cpp:
1878         (TestWebKitAPI::initEcoreEvas):
1879
1880 2013-07-15  Brian Holt  <brian.holt@samsung.com>
1881
1882         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
1883         https://bugs.webkit.org/show_bug.cgi?id=118592
1884
1885         Reviewed by Martin Robinson.
1886
1887         Added a suppression for pylint false positives and a unit test.
1888
1889         * Scripts/webkitpy/style/checkers/python.py:
1890         (Pylinter):
1891         * Scripts/webkitpy/style/checkers/python_unittest.py:
1892         (PythonCheckerTest.test_check):
1893         (PythonCheckerTest):
1894         (PythonCheckerTest.test_pylint_false_positives):
1895         (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
1896         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
1897         (test_popen):
1898
1899 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1900
1901         [GTK] Increase the JHBuild version of GStreamer to 1.0.7
1902         https://bugs.webkit.org/show_bug.cgi?id=115166
1903
1904         Reviewed by Philippe Normand.
1905
1906         * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
1907
1908 2013-07-12  Kwang Yul Seo  <skyul@company100.net>
1909
1910         Unreviewed. Add an email address and update my domain of experts.
1911
1912         * Scripts/webkitpy/common/config/contributors.json:
1913
1914 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
1915
1916         [jhbuild] Avoid restarting from scratch failed initial checkouts
1917         https://bugs.webkit.org/show_bug.cgi?id=118603
1918
1919         Reviewed by Martin Robinson.
1920
1921         If the initial checkout is interrupted midway (eg. because the internet
1922         connection went down) config files do not get generated and that causes
1923         the next checkout to start from scratch (the missing files cause the
1924         script to delete the build root and the downloaded sources).
1925
1926         By generating the files before invoking jhbuild, subsequent runs are able
1927         to start where the previous run left.
1928
1929         * Scripts/update-webkit-libs-jhbuild:
1930         (saveJhbuildMd5): invoke it before runJhbuild().
1931
1932 2013-07-12  Brent Fulgham  <bfulgham@apple.com>
1933
1934         [Windows] Remove single-worker restriction on tests.
1935
1936         * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
1937
1938 2013-07-12  Commit Queue  <commit-queue@webkit.org>
1939
1940         Unreviewed, rolling out r152599.
1941         http://trac.webkit.org/changeset/152599
1942         https://bugs.webkit.org/show_bug.cgi?id=118612
1943
1944         This patch includes a failing unit test (Requested by
1945         mrobinson on #webkit).
1946
1947         * Scripts/webkitpy/style/checkers/python.py:
1948         (Pylinter):
1949         * Scripts/webkitpy/style/checkers/python_unittest.py:
1950         (PythonCheckerTest.test_check):
1951         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
1952
1953 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
1954
1955         [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
1956         https://bugs.webkit.org/show_bug.cgi?id=91223
1957
1958         Reviewed by Martin Robinson.
1959
1960         When run on a clean checkout, `build-webkit` complains that no
1961         GNUmakefile exists when trying to detect the previously configured
1962         architecture, but in this case there's no previous configuration so
1963         the warning is pointless.
1964
1965         * Scripts/webkitdirs.pm:
1966         (determineArchitecture): Redirect grep stderr to /dev/null.
1967
1968 2013-07-12  Brian Holt  <brian.holt@samsung.com>
1969
1970         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
1971         https://bugs.webkit.org/show_bug.cgi?id=118592
1972
1973         Reviewed by Martin Robinson.
1974
1975         Added a suppression for pylint false positives and a unit test.
1976
1977         * Scripts/webkitpy/style/checkers/python.py:
1978         (Pylinter):
1979         * Scripts/webkitpy/style/checkers/python_unittest.py:
1980         (PythonCheckerTest.test_check):
1981         (PythonCheckerTest):
1982         (PythonCheckerTest.test_pylint_false_positives):
1983         (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
1984         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
1985         (test_popen):
1986
1987 2013-07-11  Arnaud Renevier  <a.renevier@samsung.com>
1988
1989         Unreviewed. Add myself as a committer.
1990
1991         * Scripts/webkitpy/common/config/contributors.json:
1992
1993 2013-07-10  Sergio Correia  <sergio.correia@openbossa.org>
1994
1995         Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
1996         https://bugs.webkit.org/show_bug.cgi?id=118538
1997
1998         Reviewed by Christophe Dumez.
1999
2000         When attempting some odd url such as ``foo'', MiniBrowser will now show an
2001         error message such as "Cannot resolve hostname (foo)".
2002
2003         Previously, it had the following behavior if MiniBrowser was started with
2004         such urls, e.g ``./MiniBrowser foo'':
2005
2006         - Debug:
2007         It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
2008
2009         - Release:
2010         No asserts, naturally, but the view would remain blank, even if we tried to
2011         change to a valid url.
2012
2013         * MiniBrowser/efl/main.c:
2014         (window_create):
2015
2016 2013-07-10  Simon Pena  <simon.pena@samsung.com>
2017
2018         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
2019         https://bugs.webkit.org/show_bug.cgi?id=118509
2020
2021         Reviewed by Martin Robinson.
2022
2023         In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
2024         when trying to remove an event already removed, if another event is
2025         processed in the middle. By using a Deque's takeFirst, we ensure the
2026         element is removed before we dispatch it.
2027
2028         fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
2029         crashes after this fix is added.
2030
2031         * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
2032         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2033         (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
2034         from the queue.
2035
2036 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
2037
2038         [EFL] Add ewk_view_device_pixel_ratio_set
2039         https://bugs.webkit.org/show_bug.cgi?id=118521
2040
2041         Reviewed by Gyuyoung Kim.
2042
2043         * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
2044         (windowCreate):
2045         (parseUserArguments):
2046
2047 2013-07-09  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
2048
2049         Unreviewed change of my email addresses.
2050         https://bugs.webkit.org/show_bug.cgi?id=100122
2051
2052         * Scripts/webkitpy/common/config/contributors.json:
2053
2054 2013-07-09  Anders Carlsson  <andersca@apple.com>
2055
2056         DumpRenderTree should stop sending unsupported URLs to NSWorkspace
2057         https://bugs.webkit.org/show_bug.cgi?id=118514
2058         <rdar://problem/13686836>
2059
2060         Reviewed by Sam Weinig.
2061
2062         Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
2063
2064         * DumpRenderTree/DefaultPolicyDelegate.h: Added.
2065         * DumpRenderTree/DefaultPolicyDelegate.m: Added.
2066         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2067         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2068         Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
2069
2070         * DumpRenderTree/mac/DumpRenderTree.mm:
2071         (allocateGlobalControllers):
2072         Allocate a DefaultPolicyDelegate object.
2073
2074         (resetWebViewToConsistentStateBeforeTesting):
2075         Set the policy delegate to the default policy delegate.
2076
2077         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2078         Declare the defaultPolicyDelegate object.
2079
2080         * DumpRenderTree/mac/TestRunnerMac.mm:
2081         (TestRunner::setCustomPolicyDelegate):
2082         Set the policy delegate to the default delegate if setDelegate is false.
2083
2084 2013-07-08  Zan Dobersek  <zdobersek@igalia.com>
2085
2086         KURL unit test fixture class should have a meaningful name
2087         https://bugs.webkit.org/show_bug.cgi?id=118467
2088
2089         Reviewed by Sam Weinig.
2090
2091         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2092         (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
2093         instead of the generic and inappropriate 'WebCore' name.
2094
2095 2013-07-08  Antti Koivisto  <antti@apple.com>
2096
2097         Add Deque::removeLast
2098         https://bugs.webkit.org/show_bug.cgi?id=118466
2099
2100         Reviewed by Andreas Kling.
2101
2102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2103         * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
2104         (TestWebKitAPI::TEST):
2105
2106 2013-07-08  Brian Holt  <brian.holt@samsung.com>
2107
2108         [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
2109         https://bugs.webkit.org/show_bug.cgi?id=118412
2110
2111         Reviewed by Martin Robinson.
2112
2113         An adoptRef is required to balance ref and deref calls.
2114
2115         * DumpRenderTree/gtk/EventSender.cpp:
2116         (beginDragWithFilesCallback):
2117
2118 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
2119
2120         Update list of EFL WK2 API tests
2121         https://bugs.webkit.org/show_bug.cgi?id=118443
2122
2123         Reviewed by Christophe Dumez.
2124
2125         The following tests were included:
2126
2127         Passing:
2128         - CloseThenTerminate
2129         - DidAssociateFormControls
2130         - PageVisibilityState
2131         - ResponsivenessTimerDoesntFireEarly
2132         - TerminateTwice
2133         - WillLoad
2134
2135         Failing:
2136         - ResizeReversePaginatedWebView
2137         - ScrollPinningBehaviors
2138
2139         This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
2140         alphabetical order.
2141
2142         * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
2143         * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
2144
2145 2013-07-05  Tim Horton  <timothy_horton@apple.com>
2146
2147         Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
2148         https://bugs.webkit.org/show_bug.cgi?id=118439
2149         <rdar://problem/14366120>
2150
2151         Reviewed by Anders Carlsson.
2152
2153         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2154         (TestWebKitAPI::didLayout):
2155         (TestWebKitAPI::TEST):
2156         - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
2157         - Assert that we got the right number of pages for sanity.
2158         - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
2159             so much memory that SharedMemory asserts and makes the test time out.
2160         - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
2161             because paint doesn't fire if the window is offscreen.
2162
2163 2013-07-05  Tim Horton  <timothy_horton@apple.com>
2164
2165         [wk2] Add API to lock the scroll position at the top or bottom of the page
2166         https://bugs.webkit.org/show_bug.cgi?id=118429
2167         <rdar://problem/14120323>
2168
2169         Reviewed by Anders Carlsson.
2170
2171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2172         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
2173         (TestWebKitAPI::didFinishDocumentLoadForFrame):
2174         (TestWebKitAPI::TEST):
2175         Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
2176         all work correctly in the face of resizing the view and scrolling from JS.
2177
2178 2013-07-05  Michael Pruett  <michael@68k.org>
2179
2180         Unreviewed. Add myself as a committer.
2181
2182         * Scripts/webkitpy/common/config/contributors.json:
2183
2184 2013-07-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2185
2186         [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
2187         https://bugs.webkit.org/show_bug.cgi?id=111434
2188
2189         Reviewed by Carlos Garcia Campos.
2190
2191         * Scripts/run-gtk-tests:
2192         (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
2193
2194 2013-07-04  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
2195
2196         [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
2197         https://bugs.webkit.org/show_bug.cgi?id=118370
2198
2199         Reviewed by Christophe Dumez.
2200
2201         Add fallback to software X11 engine if opengl_x11 engine creation fails.
2202
2203         * DumpRenderTree/efl/DumpRenderTree.cpp:
2204         (initEcoreEvas):
2205
2206 2013-07-04  Brian Holt  <brian.holt@samsung.com>
2207
2208         [ATK] Leak: AtkAttributeSet* should be freed
2209         https://bugs.webkit.org/show_bug.cgi?id=118307
2210
2211         Reviewed by Christophe Dumez.
2212
2213         Fixed memory leaks for AtkAttributeSet by calling
2214         atk_attribute_set_free().
2215
2216         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2217         (AccessibilityController::childElementById):
2218         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2219         (getAtkAttributeSetAsString):
2220         (AccessibilityUIElement::allAttributes):
2221         (AccessibilityUIElement::stringAttributeValue):
2222         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2223         (WTR::childElementById):
2224         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2225         (WTR::getAtkAttributeSetAsString):
2226         (WTR::AccessibilityUIElement::allAttributes):
2227         (WTR::AccessibilityUIElement::stringAttributeValue):
2228
2229 2013-07-03  David Farler  <dfarler@apple.com>
2230
2231         Add Makefile to WebKitLauncher
2232         https://bugs.webkit.org/show_bug.cgi?id=118365
2233
2234         Reviewed by Mark Rowe.
2235
2236         * WebKitLauncher/Makefile: Added.
2237
2238 2013-07-03  Brian Holt  <brian.holt@samsung.com>
2239
2240         [ATK] Leak: more leaks in AccessibilityUIElement
2241         https://bugs.webkit.org/show_bug.cgi?id=118362
2242
2243         Reviewed by Christophe Dumez.
2244
2245         Free the memory created by g_strdup_printf.
2246
2247         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2248         (AccessibilityUIElement::language):
2249         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2250         (WTR::AccessibilityUIElement::language):
2251
2252 2013-07-03  Jer Noble  <jer.noble@apple.com>
2253
2254         Xcode often gets in a state where the debugger is completely unresponsive
2255         https://bugs.webkit.org/show_bug.cgi?id=118157
2256
2257         The GetPointeeData() operations we use to retrieve strings is extremely expensive.
2258         Rather than pull the character data out of the debugger one byte at a time
2259         through the GetPointeeData() API, retrieve the memory contents of the string through
2260         the ReadMemory() API, and convert the retrieved memory into a python string.
2261
2262         Reviewed by Anders Carlsson.
2263
2264         * lldb/lldb_webkit.py:
2265         (__lldb_init_module.lldb_webkit):
2266         (guess_string_length):
2267         (ustring_to_string):
2268         (lstring_to_string):
2269
2270 2013-07-03  Morten Stenshorne  <mstensho@opera.com>
2271
2272         [GTK] Let F5 refresh the page in MiniBrowser
2273         https://bugs.webkit.org/show_bug.cgi?id=117638
2274
2275         Reviewed by Carlos Garcia Campos.
2276
2277         Also use the correct icon for the refresh button that was already there.
2278
2279         * MiniBrowser/gtk/BrowserWindow.c:
2280         (browser_window_init):
2281
2282 2013-07-02  Kondapally Kalyan  <kalyan.kondapally@intel.com>
2283
2284         Unreviewed. Add my email to a few watchlists.
2285
2286         * Scripts/webkitpy/common/config/watchlist:
2287
2288 2013-07-02  David Farler  <dfarler@apple.com>
2289
2290         Unreviewed. Adding myself to contributors.json.
2291
2292         * Scripts/webkitpy/common/config/contributors.json:
2293
2294 2013-07-02  Brian Holt  <brian.holt@samsung.com>
2295
2296         [ATK] Leak: leaks in AccessibilityUIElement
2297         https://bugs.webkit.org/show_bug.cgi?id=118297
2298
2299         Fixed memory leak.
2300
2301         Reviewed by Christophe Dumez.
2302
2303         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2304         (AccessibilityUIElement::stringValue):
2305
2306 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
2307
2308         Fix WebKitTestRunner crashes.
2309         https://bugs.webkit.org/show_bug.cgi?id=117630
2310
2311         Reviewed by Darin Adler.
2312
2313         Create static function to dump for WebProcess unresponsiveness status,
2314         and use it before calling TestController::runTest().
2315
2316         Accessing TestController::m_currentInvocation before calling
2317         TestController::runTest() can make crash because the invocation
2318         instance will be assigned at the function.
2319
2320         * WebKitTestRunner/TestController.cpp:
2321         (WTR::TestController::run):
2322         * WebKitTestRunner/TestInvocation.cpp:
2323         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
2324         * WebKitTestRunner/TestInvocation.h:
2325
2326 2013-07-02  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2327
2328         [Qt][WK1] Support WebGL with EGL on Linux
2329         https://bugs.webkit.org/show_bug.cgi?id=118251
2330
2331         Reviewed by Kenneth Rohde Christiansen.
2332
2333         * qmake/mkspecs/features/features.prf:
2334
2335 2013-07-01  Nick Diego Yamane  <nick.yamane@openbossa.org>
2336
2337         [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
2338         https://bugs.webkit.org/show_bug.cgi?id=118267
2339
2340         Reviewed by Gyuyoung Kim.
2341
2342         After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
2343         WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
2344         Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
2345
2346         * efl/jhbuildrc:
2347         * gtk/jhbuildrc:
2348
2349 2013-07-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2350
2351         [GTK] Remove unsupported AC backends
2352         https://bugs.webkit.org/show_bug.cgi?id=117362
2353
2354         Reviewed by Martin Robinson.
2355
2356         * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
2357         and cogl, so removed.
2358
2359 2013-07-01  Timothy Hatcher  <timothy@apple.com>
2360
2361         Link to WebInspectorUI.framework at build time instead of soft linking.
2362
2363         https://bugs.webkit.org/show_bug.cgi?id=118261
2364
2365         Reviewed by Joseph Pecoraro.
2366
2367         * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
2368
2369 2013-07-01  Tim Horton  <timothy_horton@apple.com>
2370
2371         Maximum scroll position can be negative in some cases
2372         https://bugs.webkit.org/show_bug.cgi?id=118175
2373         <rdar://problem/14301217>
2374
2375         Reviewed by Anders Carlsson.
2376
2377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2378         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
2379         (TestWebKitAPI::didRunJavaScript):
2380         (TestWebKitAPI::didLayout):
2381         (TestWebKitAPI::TEST):
2382         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
2383         Add a test that loads a vertical-lr document, paginates it horizontally
2384         from right to left, resizes the view to fit the entire document, and
2385         verifies that the scroll position is negative, as it must be for the
2386         document to be enclosed by the view.
2387
2388 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2389
2390         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
2391         https://bugs.webkit.org/show_bug.cgi?id=117249
2392
2393         Reviewed by Brent Fulgham.
2394
2395         Finish converting all use cases of WEBKITOUTPUTDIR to
2396         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
2397
2398         * DumpRenderTree/efl/FontManagement.cpp:
2399         (getCustomBuildDir):
2400         (getPlatformFontsPath):
2401         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2402         (getOutputDir):
2403         * Scripts/webkitdirs.pm:
2404         (determineBaseProductDir):
2405         (usesPerConfigurationBuildDirectory):
2406         * Scripts/webkitpy/port/base.py:
2407         (Port.to.setup_environ_for_server):
2408         * Scripts/webkitpy/port/driver.py:
2409         (Driver._setup_environ_for_driver):
2410         * Scripts/webkitpy/port/gtk.py:
2411         (GtkPort.setup_environ_for_server):
2412         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2413         (WTR::getOutputDir):
2414         * jhbuild/jhbuildutils.py:
2415         (get_dependencies_path):
2416
2417 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
2418
2419         Unreviewed change of my email address.
2420
2421         * Scripts/webkitpy/common/config/contributors.json:
2422
2423 2013-06-28  Andreas Kling  <akling@apple.com>
2424
2425         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
2426
2427         * DumpRenderTree/win/DumpRenderTree.cpp:
2428         (addFontFallbackIfPresent):
2429         (removeFontFallbackIfPresent):
2430
2431 2013-06-28  Anders Carlsson  <andersca@apple.com>
2432
2433         Remove String::deprecatedCharactersWithNullTermination() and related code
2434         https://bugs.webkit.org/show_bug.cgi?id=118211
2435
2436         Reviewed by Benjamin Poulain.
2437
2438         Remove all hasTerminatingNullCharacter() checks.
2439
2440         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2441         (TestWebKitAPI::TEST):
2442         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2443         (TestWebKitAPI::TEST):
2444         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2445         (TestWebKitAPI::TEST):
2446
2447 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
2448
2449         [Mac] Crash when loading is stopped from -didReceiveResponse
2450         https://bugs.webkit.org/show_bug.cgi?id=118209
2451         <rdar://problem/14259249>
2452
2453         Reviewed by Brady Eidson.
2454
2455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2456         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
2457         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
2458         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
2459         (TestWebKitAPI::TEST):
2460
2461 2013-06-28  Andy Estes  <aestes@apple.com>
2462
2463         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
2464         https://bugs.webkit.org/show_bug.cgi?id=118208
2465
2466         Reviewed by Mark Rowe.
2467
2468         Newer versions of clang use a default template depth of 128, but this
2469         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
2470         previous default.
2471
2472         Clang lowered the default to keep recursive template instantiation
2473         from overflowing the stack (see <rdar://problem/13935016>), but
2474         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
2475         higher limit. If for some reason this starts happening then we can
2476         lower the limit back down.
2477
2478         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
2479
2480 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
2481
2482         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
2483         https://bugs.webkit.org/show_bug.cgi?id=118195
2484
2485         Reviewed by Daniel Bates.
2486
2487         Currently, ports that use jhbuild fail to determine jhbuild directory
2488         when "webKitBranchBuild" git configuration property is enabled. To reproduce
2489         that issue in Efl port, enable that flag in .git/config, switch to a git branch
2490         other than "master" and try to build webkit. The build will fail to
2491         locate dependencies due to lack of pkg-config paths which should be set
2492         by jhbuild.
2493
2494         For more details about "webKitBranchBuild" option, see:
2495         https://trac.webkit.org/wiki/UsingGitWithWebKit
2496
2497         * Scripts/webkitdirs.pm:
2498         (getJhbuildPath):
2499
2500 2013-06-28  Jessie Berlin  <jberlin@apple.com>
2501
2502         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
2503         https://bugs.webkit.org/show_bug.cgi?id=118201
2504
2505         Reviewed by Dean Jackson.
2506
2507         * WebKitTestRunner/mac/main.mm:
2508         (main):
2509         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
2510         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
2511
2512 2013-06-28  David Farler  <dfarler@apple.com>
2513
2514         Upstream WebKit Nightly’s WebKitLauncher
2515         https://bugs.webkit.org/show_bug.cgi?id=117418
2516
2517         Reviewed by Mark Rowe.
2518
2519         Literal patch from Nightly's OpenSource repo.
2520
2521         * WebKitLauncher/Configurations/Base.xcconfig:
2522         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
2523         * WebKitLauncher/Info.plist:
2524         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2525         * WebKitLauncher/WebKitLauncherURLProtocol.m:
2526         (+[WebKitLauncherURLProtocol load]):
2527         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
2528         (-[WebKitLauncherURLProtocol startLoading]):
2529         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
2530         (-[WebKitLauncherURLProtocol resourceNotFound]):
2531         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2532         (initializeSparkle):
2533         * WebKitLauncher/main.m:
2534         (determineExecutablePath):
2535         (currentMacOSXVersion):
2536         (main):
2537         * WebKitLauncher/start.html:
2538
2539 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
2540
2541         [EFL] back/forward keyboard shortcuts are non-intuitive
2542         https://bugs.webkit.org/show_bug.cgi?id=118193
2543
2544         Reviewed by Christophe Dumez.
2545
2546         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
2547
2548         * EWebLauncher/main.c:
2549         (on_key_down):
2550         * MiniBrowser/efl/main.c:
2551         (on_key_down):
2552
2553 2013-06-28  Roger Fong  <roger_fong@apple.com>
2554
2555         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
2556         https://bugs.webkit.org/show_bug.cgi?id=118194.
2557
2558         Reviewed by Brent Fulgham.
2559
2560         * DumpRenderTree/win/DumpRenderTree.cpp:
2561         (dllLauncherEntryPoint):
2562         * WinLauncher/WinLauncher.cpp:
2563         (dllLauncherEntryPoint):
2564
2565 2013-06-28  Roger Fong  <roger_fong@apple.com>
2566
2567         Unreviewed build fix for AppleWin port. Fix some file paths.
2568
2569         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2570         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2571
2572 2013-06-27  Roger Fong  <roger_fong@apple.com>
2573
2574         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
2575         https://bugs.webkit.org/show_bug.cgi?id=118160.
2576
2577         Reviewed by Brent Fulgham.
2578
2579         * WinLauncher/AccessibilityDelegate.cpp: Added.
2580         (AccessibilityDelegate::QueryInterface):
2581         (AccessibilityDelegate::AddRef):
2582         (AccessibilityDelegate::Release):
2583         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
2584         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
2585         * WinLauncher/AccessibilityDelegate.h: Added.
2586         (AccessibilityDelegate::AccessibilityDelegate):
2587         * WinLauncher/WinLauncher.cpp:
2588         (dllLauncherEntryPoint):
2589         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2590         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2591
2592 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2593
2594         Clean up temporary files created by the bindings test script
2595         https://bugs.webkit.org/show_bug.cgi?id=118189
2596
2597         Reviewed by Kentaro Hara.
2598
2599         Remove temporary files created by preprocess-idls.pl script after
2600         the bindings tests are executed.
2601
2602         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
2603
2604         * Scripts/webkitpy/bindings/main.py:
2605         (BindingsTests.main):
2606
2607 2013-06-26  Dean Jackson  <dino@apple.com>
2608
2609         [Mac] Add Mavericks system font to Test systems
2610         https://bugs.webkit.org/show_bug.cgi?id=118109
2611
2612         Reviewed by Simon Fraser.
2613
2614         OS X Mavericks uses a different font for system controls. Tell DRT and
2615         WKTR about them otherwise they use a fallback font. Unfortunately the
2616         fonts are hidden (not found in the list of available fonts) so I
2617         had to add them manually.
2618
2619         Even though there is only one at the moment, I implemented this
2620         as a set so it will be easier to add new fonts if necessary.
2621
2622         * DumpRenderTree/mac/DumpRenderTree.mm:
2623         (allowedFontFamilySet): Fixed typo.
2624         (systemHiddenFontFamilySet): New method that returns the system control font.
2625         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
2626         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2627         (WTR::allowedFontFamilySet): Fixed typo.
2628         (WTR::systemHiddenFontFamilySet): As above.
2629         (WTR::wtr_NSFontManager_availableFonts):
2630
2631 2013-06-27  Anders Carlsson  <andersca@apple.com>
2632
2633         Get rid of the last uses of deprecatedCharactersWithNullTermination()
2634         https://bugs.webkit.org/show_bug.cgi?id=118159
2635
2636         Reviewed by Andreas Kling.
2637
2638         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
2639
2640         * DumpRenderTree/win/DumpRenderTree.cpp:
2641         (findFontFallback):
2642
2643 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
2644
2645         Sync up w3c import script with changes in Blink
2646         https://bugs.webkit.org/show_bug.cgi?id=118149
2647
2648         Reviewed by Dirk Pranke.
2649
2650         This is a port of the following blink changes:
2651
2652         https://codereview.chromium.org/15366004
2653         https://chromiumcodereview.appspot.com/15592005
2654         https://codereview.chromium.org/16021006
2655         https://codereview.chromium.org/15590004
2656         https://codereview.chromium.org/15901008
2657         https://codereview.chromium.org/16171009
2658         https://codereview.chromium.org/16465007
2659         https://codereview.chromium.org/15981013
2660
2661         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2662         (setUp):
2663         (test_commit_message_for_this_commit):
2664         * Scripts/webkitpy/port/base.py:
2665         (Port):
2666         * Scripts/webkitpy/port/test.py:
2667         * Scripts/webkitpy/w3c/test_converter.py:
2668         (W3CTestConverter.__init__):
2669         (W3CTestConverter.read_webkit_prefixed_css_property_list):
2670         (W3CTestConverter.convert_for_webkit):
2671         (W3CTestConverter.convert_css):
2672         (W3CTestConverter.convert_html):
2673         (W3CTestConverter.convert_testharness_paths):
2674         (W3CTestConverter.convert_prefixed_properties):
2675         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2676         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2677         * Scripts/webkitpy/w3c/test_importer.py:
2678         (main):
2679         (configure_logging):
2680         (configure_logging.LogHandler):
2681         (configure_logging.LogHandler.format):
2682         (parse_args):
2683         (TestImporter.__init__):
2684         (TestImporter.find_importable_tests):
2685         (TestImporter.import_tests):
2686         (TestImporter.setup_destination_directory):
2687         (TestImporter.remove_deleted_files):
2688         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2689         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
2690         (TestImporterTest.test_import_dir_with_no_tests):
2691         (TestImporterTest):
2692         * Scripts/webkitpy/w3c/test_parser.py:
2693         (TestParser.load_file):
2694         (TestParser.analyze_test):
2695         (TestParser.support_files):
2696         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2697
2698 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
2699
2700         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
2701         https://bugs.webkit.org/show_bug.cgi?id=118128
2702
2703         Reviewed by Ryosuke Niwa.
2704
2705         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
2706         https://bugs.webkit.org/show_bug.cgi?id=117831
2707
2708         * Scripts/webkitpy/tool/commands/download.py:
2709         (AbstractPatchSequencingCommand):
2710         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
2711         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
2712         (AbstractPatchSequencingCommand._prepare_state): Added.
2713
2714 2013-06-27  Brendan Long  <b.long@cablelabs.com>
2715
2716         [Qt] Build overrides -j when given --makeargs="-sj40"
2717         https://bugs.webkit.org/show_bug.cgi?id=116897
2718
2719         Reviewed by Csaba Osztrogonác.
2720
2721         * Scripts/webkitdirs.pm:
2722         (buildQMakeProjects):
2723         Change regex checking for -j* to also check for -*j*
2724
2725 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2726
2727         Remove [NoInterfaceObject] from WorkerGlobalScope
2728         https://bugs.webkit.org/show_bug.cgi?id=118071
2729
2730         Reviewed by Kentaro Hara.
2731
2732         Update bindings test script to pass 2 additional parameters
2733         now needed by the preprocess-idls.pl script.
2734
2735         * Scripts/webkitpy/bindings/main.py:
2736         (BindingsTests.generate_supplemental_dependency):
2737         (BindingsTests.main):
2738
2739 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2740
2741         Fixing some compiler warnings
2742         https://bugs.webkit.org/show_bug.cgi?id=117791
2743
2744         Reviewed by Martin Robinson.
2745
2746         * GNUmakefile.am: Silenced format warning.
2747         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2748         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
2749         Solved warning about uninitialized variable.
2750
2751 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2752
2753         Fix bindings tests after r152080
2754         https://bugs.webkit.org/show_bug.cgi?id=118118
2755
2756         Reviewed by Gyuyoung Kim.
2757
2758         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
2759         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
2760         accordingly.
2761
2762         * Scripts/webkitpy/bindings/main.py:
2763         (BindingsTests.generate_supplemental_dependency):
2764         (BindingsTests.main):
2765
2766 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
2767
2768         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
2769         https://bugs.webkit.org/show_bug.cgi?id=117982
2770
2771         Reviewed by Rob Buis.
2772
2773         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2774         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
2775         m_policyDelegateIsPermissive.
2776         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2777         Reset m_policyDelegateIsPermissive.
2778         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
2779         m_policyDelegateIsPermissive.
2780         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2781         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
2782         Return whether custom policy is enabled.
2783         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
2784         Return whether custom policy is permissive.
2785
2786 2013-06-26  Anders Carlsson  <andersca@apple.com>
2787
2788         Deprecate StringImpl::charactersWithNullTermination
2789         https://bugs.webkit.org/show_bug.cgi?id=118108
2790
2791         Reviewed by Beth Dakin.
2792
2793         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
2794
2795         * DumpRenderTree/win/DumpRenderTree.cpp:
2796         (findFontFallback):
2797         (addFontFallbackIfPresent):
2798         (removeFontFallbackIfPresent):
2799
2800 2013-06-26  Nico Weber  <thakis@chromium.org>
2801
2802         Remove detect-mismached-virtual-const.
2803         https://bugs.webkit.org/show_bug.cgi?id=117999
2804
2805         Reviewed by Anders Carlsson.
2806
2807         Clang warns on mismatched virtual const, so there's no need for this
2808         script any more.
2809
2810         * Scripts/detect-mismatched-virtual-const: Removed.
2811
2812 2013-06-26  Alex Christensen  <achristensen@apple.com>
2813
2814         Added a code coverage report.
2815         https://bugs.webkit.org/show_bug.cgi?id=117941
2816
2817         Reviewed by Joseph Pecoraro.
2818
2819         * CodeCoverage: Added.
2820         * CodeCoverage/results-template.html: Added.
2821         * Scripts/generate-coverage-data: Generate and open the new report.
2822
2823 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2824
2825         gdb: Remove the webcore.py pretty printer.
2826         https://bugs.webkit.org/show_bug.cgi?id=117992
2827
2828         Reviewed by Jochen Eisinger.
2829
2830         webcore.py has been only a placeholder for backwards compatibility
2831         for almost 3 years. It should be safe enough to remove it now.
2832
2833         * gdb/webcore.py: Removed.
2834
2835 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
2836
2837         Creating cURL watchlist and adding myself to it.
2838
2839         Reviewed by Csaba Osztrogonác.
2840
2841         * Scripts/webkitpy/common/config/watchlist:
2842
2843 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2844
2845         Unreviewed, change my email address for watch list.
2846
2847         * Scripts/webkitpy/common/config/watchlist:
2848
2849 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
2850
2851         [EFL] Add a script to install dependencies.
2852         https://bugs.webkit.org/show_bug.cgi?id=117968
2853
2854         Reviewed by Christophe Dumez.
2855
2856         Add a script which installs basic dependencies for building WebKit EFL.
2857
2858         The dependencies are from the current EFLWebKit wiki page.
2859         After this patch is landed, the wiki page will be updated to use
2860         this script.
2861
2862         * efl/install-dependencies: Added.
2863
2864 2013-06-24  Dean Jackson  <dino@apple.com>
2865
2866         [Mac] Update font used for Chinese in test systems
2867         https://bugs.webkit.org/show_bug.cgi?id=117970
2868
2869         Reviewed by Alexey Proskuryakov.
2870
2871         Add "Songti TC" and "Songti SC" to the list of allowed fonts
2872         in DRT and WKTR.
2873
2874         * DumpRenderTree/mac/DumpRenderTree.mm:
2875         (allowedFontFamilySet):
2876         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2877         (WTR::allowedFontFamilySet):
2878
2879 2013-06-24  Tim Horton  <timothy_horton@apple.com>
2880
2881         Make MiniBrowser paginated mode work with WebKit1
2882         https://bugs.webkit.org/show_bug.cgi?id=117950
2883
2884         Reviewed by Beth Dakin.
2885
2886         * MiniBrowser/mac/WK1BrowserWindowController.m:
2887         (-[WK1BrowserWindowController isPaginated]):
2888         (-[WK1BrowserWindowController togglePaginationMode:]):
2889         Hook up isPaginated and togglePaginationMode just as for WebKit2.
2890
2891 2013-06-24  David Kilzer  <ddkilzer@apple.com>
2892
2893         bisect-builds: improve heuristic for choosing the next build after a broken build
2894         <http://webkit.org/b/117918>
2895
2896         Reviewed by Simon Fraser.
2897
2898         * Scripts/bisect-builds: When a build is broken, use a heuristic
2899         that "bisects" the left side or the right side of the remaining
2900         revisions to pick a revision that's sufficiently different from
2901         the revision of the broken build.  This heuristic assumes there
2902         is a sequential range of broken builds whenever one broken build
2903         is found.
2904
2905 2013-06-24  Chris Rogers  <crogers@google.com>
2906
2907         WaveTable name has changed to PeriodicWave
2908         https://bugs.webkit.org/show_bug.cgi?id=117748
2909
2910         Reviewed by Jer Noble.
2911
2912         * Scripts/do-webcore-rename:
2913
2914 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
2915
2916         [EFL] Add support for MHTML save/load feature to MiniBrowser
2917         https://bugs.webkit.org/show_bug.cgi?id=106620
2918
2919         Reviewed by Christophe Dumez.
2920
2921         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
2922         from filesystem.
2923
2924         * MiniBrowser/efl/CMakeLists.txt:
2925         * MiniBrowser/efl/main.c:
2926         (page_contents_callback):
2927         (on_key_down):
2928         (show_file_entry_dialog): generic function to show file enrty
2929         selector dialogue
2930
2931 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
2932
2933         [Windows] Unreviewed crash protection for DRT
2934
2935         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
2936         to avoid crashing during test runs.
2937
2938 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2939
2940         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
2941         https://bugs.webkit.org/show_bug.cgi?id=117825
2942
2943         Reviewed by Kentaro Hara.
2944
2945         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
2946
2947         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2948         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2949         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2950         (TestRunner::overridePreference):
2951
2952 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
2953
2954         [ATK] Added support for aria-required attribute.
2955         https://bugs.webkit.org/show_bug.cgi?id=117730
2956
2957         Reviewed by Chris Fleizach.
2958
2959         Added support for testing aria-required attribute.
2960
2961         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2962         (AccessibilityUIElement::isRequired):
2963         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2964         (WTR::AccessibilityUIElement::isRequired):
2965
2966 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
2967
2968         [CMAKE][EFL] Enable DOM4 Events Constructor
2969         https://bugs.webkit.org/show_bug.cgi?id=117858
2970
2971         Reviewed by Laszlo Gombos.
2972
2973         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
2974
2975 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2976
2977         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
2978         https://bugs.webkit.org/show_bug.cgi?id=117827
2979
2980         Reviewed by Rob Buis.
2981
2982         Reset the passed in request if willSendRequestReturnsNull() is
2983         true or willSendRequestReturnsNullOnRedirect() is true and it's a
2984         redirection.
2985
2986         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2987         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
2988         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2989
2990 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
2991
2992         Commit queue shouldn't reopen unrelated bugs because of flakiness
2993         https://bugs.webkit.org/show_bug.cgi?id=117503
2994
2995         Reviewed by Ryosuke Niwa.
2996
2997         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2998         (_follow_duplicate_chain):
2999         (_update_bug_for_flaky_test):
3000
3001 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
3002
3003         [Windows] AX: Expand notification support.
3004         https://bugs.webkit.org/show_bug.cgi?id=117761
3005
3006         Reviewed by Anders Carlsson.
3007
3008         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3009         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
3010         (AccessibilityUIElement::press): Provide implementation.
3011
3012 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
3013
3014         Use the PlatformEvent timestamp when creating a DOM Event
3015         https://bugs.webkit.org/show_bug.cgi?id=117179
3016
3017         Reviewed by Darin Adler.
3018
3019         * WebKitTestRunner/mac/EventSenderProxy.mm:
3020         (WTR::EventSenderProxy::mouseDown):
3021         (WTR::EventSenderProxy::mouseUp):
3022         (WTR::EventSenderProxy::mouseMoveTo):
3023         (WTR::EventSenderProxy::keyDown):
3024
3025 2013-06-18  Alex Christensen  <achristensen@apple.com>
3026
3027         Working on coverage script, added xml to json data extraction script.
3028         https://bugs.webkit.org/show_bug.cgi?id=117648
3029
3030         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
3031         coverage data, runs the tests, and collects all of the data in json format.
3032
3033         Reviewed by Stephanie Lewis.
3034
3035         * Scripts/generate-coverage-data:
3036         (parseGcovrOutput):
3037         (getFileHitsAndBranches):
3038         (addLineCounts):
3039         (createResultName):
3040         * Scripts/webkitpy/tool/gcovr: Added.
3041
3042 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
3043
3044         Unreviewed build fix after r151699.
3045
3046         * TestWebKitAPI/CMakeLists.txt:
3047         * WebKitTestRunner/CMakeLists.txt:
3048         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
3049
3050 2013-06-18  Roger Fong  <roger_fong@apple.com>
3051
3052         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
3053         <rdar://problem/14118143>.
3054
3055         Rubberstamped by Brent Fulgham.
3056
3057         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3058         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3059         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3060         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3061         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3062         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3063         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3064         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3065         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3066         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3067         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3068         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3069         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3070         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3071         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3072         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3073         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3074         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3075         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3076         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3077         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3078         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3079         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3080         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3081         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3082         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3083         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3084         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3085         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3086         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3087         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3088         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3089         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3090         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3091         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3092         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3093         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3094         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3095         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3096         * win/record-memory/record-memory.vcxproj:
3097         * win/record-memory/record-memoryDebug.props:
3098         * win/record-memory/record-memoryDebugWinCairo.props:
3099         * win/record-memory/record-memoryProduction.props:
3100         * win/record-memory/record-memoryRelease.props:
3101         * win/record-memory/record-memoryReleaseWinCairo.props:
3102
3103 2013-06-17  Kangil Han  <kangil.han@samsung.com>
3104
3105         Unreviewed. Add my email to a DOM watchlist.
3106
3107         * Scripts/webkitpy/common/config/watchlist:
3108
3109 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
3110
3111         Unreviewed GTK gardening.
3112
3113         * Scripts/run-gtk-tests:
3114         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
3115
3116 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
3117
3118         Unreviewed. Reorder my email addresses.
3119         https://bugs.webkit.org/show_bug.cgi?id=100122
3120
3121         * Scripts/webkitpy/common/config/contributors.json:
3122
3123 2013-06-14  Enrica Casucci  <enrica@apple.com>
3124
3125         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
3126         https://bugs.webkit.org/show_bug.cgi?id=117647
3127         <rdar://problem/13881024>
3128
3129         Reviewed by Darin Adler.
3130         
3131         The test now uses content with a selection and tests both
3132         forwards and backward find as well as the case of a find
3133         that has no matches after the user selection.
3134
3135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3136         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3137         (TestWebKitAPI::didFindStringMatches):
3138         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
3139
3140 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
3141
3142         Remove myself from Qt build system watchlist
3143
3144         Reviewed by Simon Hausmann.
3145
3146         * Scripts/webkitpy/common/config/watchlist:
3147
3148 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
3149
3150         [Qt][Mac] Disable QTKit video on OS X.
3151         https://bugs.webkit.org/show_bug.cgi?id=117591
3152
3153         Reviewed by Tor Arne Vestbø.
3154
3155         Deployment of Qt binaries to different Mac OS X
3156         platform version makes it impossible to link against
3157         the correct version of the WebKitSystemInterface library,
3158         so we need to disable QTKit for media elements.
3159
3160         * qmake/mkspecs/features/features.prf:
3161
3162 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3163
3164         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
3165         https://bugs.webkit.org/show_bug.cgi?id=116610
3166
3167         Reviewed by Noam Rosenthal.
3168
3169         Remove unnecessary code adjusting context menu position to webview position.
3170         Now position is calculcated in EwkView.
3171
3172         * MiniBrowser/efl/main.c:
3173         (on_context_menu_show):
3174
3175 2013-06-12  Roger Fong  <roger_fong@apple.com>
3176
3177         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
3178
3179         * Scripts/webkitpy/common/config/ews.json:
3180
3181 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
3182
3183         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
3184         https://bugs.webkit.org/show_bug.cgi?id=115647
3185
3186         Reviewed by Martin Robinson.
3187
3188         Locale resolution is moved to WebKitAccessibleWrapperAtk using
3189         AtkObject::get_object_locale() API. Now, implementation of
3190         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
3191         be leveraged to get_object_locale() of AtkObject.
3192
3193         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
3194         method.
3195
3196         No new functionality, no new tests.
3197
3198         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3199         (AccessibilityUIElement::language): Leverage locale resolution to
3200         AtkObject::get_object_locale().
3201         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3202         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
3203         AtkObject::get_object_locale().
3204
3205 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
3206
3207         Remove last bits of GYP from build-webkit and update-webkit scripts
3208         https://bugs.webkit.org/show_bug.cgi?id=117557
3209
3210         Reviewed by Ryosuke Niwa.
3211
3212         * Scripts/build-webkit:
3213         * Scripts/update-webkit:
3214
3215 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
3216
3217         Remove forgotten unused Tools/Script/make-gypi script
3218         https://bugs.webkit.org/show_bug.cgi?id=117558
3219
3220         Reviewed by Ryosuke Niwa.
3221
3222         This script isn't used since the GYP removal from WebKit.
3223
3224         * Scripts/make-gypi: Removed.
3225
3226 2013-06-12  Andres Gomez  <agomez@igalia.com>
3227
3228         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
3229         https://bugs.webkit.org/show_bug.cgi?id=117533
3230
3231         Reviewed by Carlos Garcia Campos.
3232
3233         MiniBrowser now starts automatically the download of the documents
3234         that cannot be shown just by WebKit itself on link left clicking.
3235
3236         * MiniBrowser/gtk/BrowserWindow.c:
3237         (webViewDecidePolicy): handled the
3238         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
3239
3240 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
3241
3242         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
3243         https://bugs.webkit.org/show_bug.cgi?id=116723
3244
3245         Reviewed by Carlos Garcia Campos.
3246
3247         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
3248         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
3249         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
3250         not expensive and produces a working archive without problems even on incremental builds.
3251
3252 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
3253
3254         [EFL] Window resize should close the popupmenu
3255         https://bugs.webkit.org/show_bug.cgi?id=117391
3256
3257         Reviewed by Christophe Dumez.
3258         
3259         Added the code to close the popup when main window is resized.
3260
3261         * MiniBrowser/efl/main.c:
3262         (on_window_resize):
3263
3264 2013-06-11  Alex Christensen  <achristensen@apple.com>
3265
3266         Removed old broken code coverage tool.
3267         https://bugs.webkit.org/show_bug.cgi?id=117520
3268
3269         Reviewed by Sam Weinig.
3270
3271         * CodeCoverage: Removed.
3272         * CodeCoverage/README: Removed.
3273         * CodeCoverage/amber.png: Removed.
3274         * CodeCoverage/cov.py: Removed.
3275         * CodeCoverage/emerald.png: Removed.
3276         * CodeCoverage/gcov.css: Removed.
3277         * CodeCoverage/glass.png: Removed.
3278         * CodeCoverage/regenerate-coverage-display: Removed.
3279         * CodeCoverage/ruby.png: Removed.
3280         * CodeCoverage/run-generate-coverage-data: Removed.
3281         * CodeCoverage/snow.png: Removed.
3282
3283 2013-06-11  Timothy Hatcher  <timothy@apple.com>
3284
3285         Have build-webkit build the WebInspectorUI project.
3286
3287         * Scripts/build-webkit:
3288
3289 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
3290
3291         Add an option to run-webkit-tests to skip java dependency check
3292         https://bugs.webkit.org/show_bug.cgi?id=117516
3293
3294         Reviewed by Andreas Kling.
3295
3296         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3297         (parse_args):
3298         * Scripts/webkitpy/port/mac.py:
3299         (MacPort._check_port_build):
3300
3301 2013-06-11  Alex Christensen  <achristensen@apple.com>
3302
3303         https://bugs.webkit.org/show_bug.cgi?id=117514
3304         Removed extra Xcode code coverage flags.
3305
3306         Reviewed by Sam Weinig.
3307
3308         * Scripts/webkitdirs.pm:
3309         (XcodeCoverageSupportOptions):
3310
3311 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
3312
3313         [Windows] Implement 'attributeValue' accessor to support testing
3314         https://bugs.webkit.org/show_bug.cgi?id=117513
3315
3316         Reviewed by Anders Carlsson.
3317
3318         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3319         (comparableObject): Move earlier in file.
3320         (findAccessibleObjectById): New implemenation.
3321         (AccessibilityController::accessibleElementById): New implementation.
3322
3323 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
3324
3325         Make WTR use its own temporary directory for application cache
3326         https://bugs.webkit.org/show_bug.cgi?id=117143
3327
3328         Reviewed by Alexey Proskuryakov.
3329
3330         * WebKitTestRunner/TestController.cpp:
3331         (WTR::TestController::initialize):
3332
3333 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
3334
3335         https://bugs.webkit.org/show_bug.cgi?id=117449
3336         Remove dead code for storing fonts in __DATA section
3337
3338         Reviewed by Dan Bernstein.
3339
3340         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3341         Don't copy font resources to __DATA, as we don't have any code that reads them
3342         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
3343
3344         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
3345         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
3346         Removed comments suggesting that we want to restore the old solution.
3347
3348 2013-06-10  Bear Travis  <betravis@adobe.com>
3349
3350         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
3351         https://bugs.webkit.org/show_bug.cgi?id=117162
3352
3353         Reviewed by Alexandru Chiculita.
3354
3355         Adding the WebCore/rendering/shapes directory to the include list.
3356
3357         * DumpRenderTree/efl/CMakeLists.txt:
3358
3359 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
3360
3361         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
3362         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3363         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
3364         happends in some of the 'accessibility' test cases.
3365
3366 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
3367
3368         [WinCairo] TestWebKitAPI fails to link.
3369         https://bugs.webkit.org/show_bug.cgi?id=117345
3370
3371         Reviewed by Brent Fulgham.
3372
3373         Need to link with WTF.lib.
3374
3375         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
3376
3377 2013-06-07  Roger Fong  <roger_fong@apple.com>
3378
3379         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
3380
3381         Rubberstamped by Ryousuke Niwa.
3382
3383         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3384         (RunTest.test_build_check):
3385
3386 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
3387
3388         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
3389         https://bugs.webkit.org/show_bug.cgi?id=117315
3390
3391         Reviewed by Benjamin Poulain.
3392
3393         Qt doesn't use the default values specified on FeatureList since r44681,
3394         this patch just remove a bit of noise.
3395
3396         * Scripts/webkitperl/FeatureList.pm:
3397
3398 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
3399
3400         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
3401         https://bugs.webkit.org/show_bug.cgi?id=115890
3402
3403         Reviewed by Christophe Dumez.
3404
3405         When user clicks HTML5 input type color,
3406         color selector window is created on browser object by using elm_colorchooser_add().
3407         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
3408         The evas_object_color_set() sets a color value returning to browser.
3409
3410         * MiniBrowser/efl/main.c:
3411         (window_free): When we delete parent window, deleting the colorpicker object.
3412         (on_color_changed): Change color of rectangle to show color selected by user.
3413         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
3414         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
3415         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
3416         (on_color_picker_dismiss): Delete colorpicker object.
3417         (on_color_picker_request): Create colorpicker window object.
3418         (window_create):
3419
3420 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
3421
3422         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
3423         https://bugs.webkit.org/show_bug.cgi?id=111066
3424
3425         Reviewed by Daniel Bates.
3426
3427         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
3428
3429         ParseGitDiffHeader() should support the path which line has space characters.
3430         To support this, I changed parsing algorithm like the following:
3431         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
3432         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
3433
3434         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
3435
3436         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
3437         I added a dummy tab and revision when we convert git diff to svn diff.
3438
3439         * Scripts/VCSUtils.pm:
3440         (parseGitDiffHeader):
3441         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
3442         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
3443         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
3444           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
3445
3446 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
3447
3448         Add a menu item to MiniBrowser to toggle Transparent windows
3449         https://bugs.webkit.org/show_bug.cgi?id=117316
3450
3451         Reviewed by Anders Carlsson.
3452         
3453         Add a menu item that toggles "Transparent window" mode, which is exposed
3454         via private WebKit API and WebKit2 API.
3455
3456         * MiniBrowser/mac/BrowserWindowController.h:
3457         * MiniBrowser/mac/MainMenu.xib:
3458         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3459         * MiniBrowser/mac/WK1BrowserWindowController.m:
3460         (-[WK1BrowserWindowController validateMenuItem:]):
3461         (-[WK1BrowserWindowController toggleTransparentWindow:]):
3462         * MiniBrowser/mac/WK2BrowserWindowController.m:
3463         (-[WK2BrowserWindowController validateMenuItem:]):
3464         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3465         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
3466         when testing.
3467
3468 2013-06-06  Roger Fong  <roger_fong@apple.com>
3469
3470         Stop copying AAS binaries into build folder.
3471         https://bugs.webkit.org/show_bug.cgi?id=117319.
3472
3473         Rubberstamped by Darin Adler.
3474
3475         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
3476
3477 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
3478
3479         Aligning build-webkit command line switch names to the WebKit flag names
3480         https://bugs.webkit.org/show_bug.cgi?id=117254
3481
3482         Reviewed by Laszlo Gombos.
3483
3484         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
3485
3486 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
3487
3488         AX: iOS ignores ARIA progressbar elements
3489         https://bugs.webkit.org/show_bug.cgi?id=116727
3490
3491         Reviewed by David Kilzer.
3492
3493         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3494         (AccessibilityUIElement::minValue):
3495         (AccessibilityUIElement::maxValue):
3496
3497 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
3498
3499         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
3500         https://bugs.webkit.org/show_bug.cgi?id=117255
3501
3502         Reviewed by Daniel Bates.
3503
3504         Need to update configuration names according to solution file.
3505
3506         * Scripts/webkitdirs.pm:
3507         (determineConfiguration):
3508         (determinePassedConfiguration):
3509
3510 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
3511
3512         Remove run-performance-tests
3513         https://bugs.webkit.org/show_bug.cgi?id=117285
3514
3515         Reviewed by Andreas Kling.
3516         
3517         Remove the script since it's not used anywhere.
3518
3519         * BuildSlaveSupport/run-performance-tests: Removed.
3520
3521 2013-06-05  Bear Travis  <betravis@adobe.com>
3522
3523         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
3524         https://bugs.webkit.org/show_bug.cgi?id=117172
3525
3526         Reviewed by Alexandru Chiculita.
3527
3528         Adding the CSS_SHAPES compile flag.
3529
3530         * Scripts/webkitperl/FeatureList.pm:
3531         * qmake/mkspecs/features/features.pri:
3532
3533 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
3534
3535         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
3536         to UNIX-style they will not execute properly.
3537
3538         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
3539         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
3540
3541 2013-06-05  Roger Fong  <roger_fong@apple.com>
3542
3543         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
3544
3545         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3546         (RunWebKitTests.start):
3547
3548 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
3549
3550         [Windows] Switch to NRWT
3551         https://bugs.webkit.org/show_bug.cgi?id=117200
3552
3553         Reviewed by Anders Carlsson.
3554
3555         * Scripts/run-webkit-tests:
3556         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
3557
3558 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
3559
3560         Unreviewed name fix after r150662
3561
3562         My firstname got duplicated when fixing bug 116737.
3563
3564         * Scripts/webkitpy/common/config/contributors.json:
3565
3566 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3567
3568         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
3569         https://bugs.webkit.org/show_bug.cgi?id=117244
3570
3571         Reviewed by Daniel Bates.
3572
3573         Fixed a regression introduced by r151196: not only does webkit.org
3574         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
3575         infrastructure used by ports such as GTK+ and EFL also use on it for
3576         things such as jhbuild.
3577
3578         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
3579         both environment variables.
3580
3581         * Scripts/webkitdirs.pm:
3582         (determineBaseProductDir):
3583
3584 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
3585
3586         [GTK] Forwarding headers not generated for incremental build
3587         https://bugs.webkit.org/show_bug.cgi?id=117198
3588
3589         Reviewed by Carlos Garcia Campos.
3590
3591         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
3592
3593 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
3594
3595         [Qt][WK2] Fix layout testing with Qt 5.1
3596         https://bugs.webkit.org/show_bug.cgi?id=117203
3597
3598         Reviewed by Jocelyn Turcotte.
3599
3600         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
3601         go into loading state but directly call handler functions for
3602         finished state instead of relying on a connection.
3603         Our wrapper QQuickView uses a data URI scheme to create the root
3604         item for testing which results in a synchronous request when loading
3605         the QML data, therefore the state of the QQuickWindow immediately
3606         becomes Ready.
3607         Since the final initialization of the root item depended on the
3608         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
3609         up with a partially initialized wrapper window, thus most of our
3610         layout tests were failing.
3611         For compatibility with pre-5.1 Qt versions keep the old behaviour
3612         in case the WrapperWindow is not ready in the constructor yet.
3613
3614         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3615         (WTR::WrapperWindow::WrapperWindow):
3616         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
3617         (TestWebKitAPI::WrapperWindow::WrapperWindow):
3618
3619 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
3620
3621         Bad value in tests counter at new-run-webkit-tests
3622         in --debug-rwt-logging mode
3623         https://bugs.webkit.org/show_bug.cgi?id=116858
3624
3625         Reviewed by Dirk Pranke.
3626
3627         Fix by moving counter incrementation, from after printing line,
3628         to before printing. Also changed variable name.
3629
3630         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3631         (LayoutTestRunner.run_tests):
3632         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3633         (FakePrinter):
3634         * Scripts/webkitpy/layout_tests/views/printing.py:
3635         (Printer.__init__):
3636         (Printer._test_status_line):
3637         (Printer.print_started_test):
3638         (Printer.print_finished_test):
3639         * Scripts/webkitpy/test/printer.py:
3640         (Printer.__init__):
3641         (Printer.print_finished_test):
3642         (Printer._test_line):
3643         (Printer.print_result):
3644
3645 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
3646
3647         Move MemoryInfo under window.internals
3648         https://bugs.webkit.org/show_bug.cgi?id=117197
3649
3650         Reviewed by Ryosuke Niwa.
3651
3652         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
3653         the Automake build
3654         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
3655         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
3656
3657 2013-06-03  Roger Fong  <roger_fong@apple.com>
3658
3659         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
3660         <rdar://problem/14042021>.
3661
3662         Reviewed by Brent Fulgham.
3663
3664         * Scripts/build-api-tests:
3665         * Scripts/build-dumprendertree:
3666         * Scripts/build-webkit:
3667         * Scripts/update-webkit-dependency:
3668         * Scripts/update-webkit-support-libs:
3669         * Scripts/webkitdirs.pm:
3670         (determineBaseProductDir):
3671         (setupAppleWinEnv):
3672         (setupCygwinEnv):
3673
3674 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
3675
3676         [Windows] NRWT is not putting crash logs in proper place (corrections)
3677         https://bugs.webkit.org/show_bug.cgi?id=117212
3678
3679         Reviewed by Dirk Pranke.
3680
3681         * Scripts/webkitpy/common/system/crashlogs.py:
3682         (CrashLogs.__init__): Accept a result directory argument in constructor.
3683         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
3684         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
3685         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3686         (CrashLogsTest.test_find_log_win): Simplify test.
3687         * Scripts/webkitpy/common/system/executive.py:
3688         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
3689         * Scripts/webkitpy/port/win.py:
3690         (WinPort._get_crash_log): No longer require 'port' argument.
3691
3692 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
3693
3694         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
3695
3696         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3697
3698 2013-06-04  Greg Hughes  <ghughes@apple.com>
3699
3700         Add "VisibleOnly" key to search predicate
3701         https://bugs.webkit.org/show_bug.cgi?id=115491
3702
3703         Reviewed by Chris Fleizach.
3704
3705         Added support for accessibility clients to use the search predicate to find only visible elements
3706
3707         * DumpRenderTree/AccessibilityUIElement.cpp:
3708         (uiElementForSearchPredicateCallback):
3709         * DumpRenderTree/AccessibilityUIElement.h:
3710         (AccessibilityUIElement):
3711         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3712         (AccessibilityUIElement::uiElementForSearchPredicate):
3713         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3714         (AccessibilityUIElement::uiElementForSearchPredicate):
3715         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3716         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3717         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3718         (AccessibilityUIElement):
3719         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3720         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3721         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3722
3723 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
3724
3725         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
3726         causing build failure.
3727
3728         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
3729         DOS-style CR/LF endings.
3730
3731 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
3732
3733         [Windows] Unreviewed test correction.
3734
3735         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
3736         QuartzCore dll's, which are needed by TestWebKitAPI.
3737         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
3738         with VS2010 will run when linked against VS2005 support libraries.
3739
3740 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3741
3742         Automatically generate WorkerContext constructor attributes
3743         https://bugs.webkit.org/show_bug.cgi?id=117183
3744
3745         Reviewed by Kentaro Hara.
3746
3747         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
3748         tests.
3749
3750         * Scripts/webkitpy/bindings/main.py:
3751         (BindingsTests.generate_supplemental_dependency):
3752         (BindingsTests.main):
3753
3754 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
3755
3756         [EFL] File dialog of MiniBrowser have broken background.
3757         https://bugs.webkit.org/show_bug.cgi?id=117189
3758
3759         Reviewed by Christophe Dumez.
3760
3761         * MiniBrowser/efl/main.c:
3762         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
3763
3764 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3765
3766         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
3767         https://bugs.webkit.org/show_bug.cgi?id=117184
3768
3769         Reviewed by Gyuyoung Kim.
3770
3771         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
3772         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
3773
3774         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3775         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3776         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3777
3778 2013-06-03  Simon Pena  <simon.pena@samsung.com>
3779
3780         validate-committer-lists script is now outdated and does not work
3781         https://bugs.webkit.org/show_bug.cgi?id=115860
3782
3783         Reviewed by Brent Fulgham.
3784
3785         The script validate-committer-lists was outdated, still using the deprecated log
3786         system and having the old addresses for the mailing lists, as well as still referring
3787         to committers.py, after this was renamed to contributors.json. This patch fixes that
3788         so it can be used again.
3789
3790         * Scripts/validate-committer-lists: Replace calls to log and error with the
3791         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
3792         to committers.py, which should be contributors.json.
3793         (CommitterListFromMailingList):
3794         (CommitterListFromMailingList.check_for_emails_missing_from_list):
3795         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
3796         (CommitterListFromGit._fill_in_emails_for_old_logins):
3797         (CommitterListFromGit.print_committers_missing_from_committer_list):
3798
3799 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
3800
3801         add a script to dump the tests run most recently by a given worker
3802         https://bugs.webkit.org/show_bug.cgi?id=116571
3803
3804         Reviewed by Brent Fulgham.
3805
3806         The tests_run*.txt results files in layout-test-results/ were removed
3807         in r137356, in favor of collecting more data about how the tests were
3808         run and compressing it and storing it in stats.json. However, it was
3809         nice to just be able to look at a flat text file.
3810
3811         This script will extract the tests run by a given worker from a
3812         given stats.json file, and should help to address that.
3813
3814         * Scripts/dump-webkit-tests-run: Added.
3815         (main):
3816         (convert_trie_to_flat_paths):
3817
3818 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
3819
3820         [Windows] NRWT is not putting crash logs in proper place
3821         https://bugs.webkit.org/show_bug.cgi?id=117098
3822
3823         Reviewed by Ryosuke Niwa.
3824
3825         Provide windows-specific overloads for various Port features needed to create and capture
3826         crash logs.  This change makes it possible to view crash logs (when created) as part of the
3827         summary report at the end of the NRWT run.
3828
3829         * Scripts/webkitpy/common/system/crashlogs.py:
3830         (CrashLogs.find_newest_log): Add support for win32 crash logs
3831         (CrashLogs._find_newest_log_win): Added
3832         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3833         (make_mock_crash_report_win): Added
3834         (CrashLogsTest.test_find_log_win): Added.
3835         * Scripts/webkitpy/common/system/executive.py:
3836         (Executive.running_pids): Add support for Cygwin win32 crash logs
3837         * Scripts/webkitpy/common/system/executive_mock.py:
3838         (MockExecutive.__init__):
3839         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3840         (RealFileSystemTest.test_read_and_write_file): Add tests for
3841         malformed ascii/utf8 handling (i.e., Windows log files)
3842         * Scripts/webkitpy/port/base.py:
3843         (Port.find_system_pid): Added
3844         * Scripts/webkitpy/port/server_process.py:
3845         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
3846         * Scripts/webkitpy/port/win.py:
3847         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
3848         for user to hit enter.
3849         (WinPort._get_crash_log): Added
3850         (WinPort.look_for_new_crash_logs): Added
3851         (WinPort.find_system_pid): Added
3852         * Scripts/webkitpy/port/win_unittest.py:
3853         (WinPortTest.test_get_crash_log): Added test
3854
3855 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
3856
3857         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
3858         https://bugs.webkit.org/show_bug.cgi?id=116726
3859
3860         Reviewed by Gyuyoung Kim.
3861
3862         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
3863         the platform (it is not listed in jhbuild moduleset). That version is
3864         old-ish and contain deprecated symbols and missing API, that are blocking
3865         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
3866         moduleset, which is the same version the gtk port uses.
3867
3868         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
3869         why this is needed.
3870
3871         * efl/jhbuild.modules: Adds ATK module as dependency
3872
3873 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
3874
3875         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
3876         https://bugs.webkit.org/show_bug.cgi?id=117168
3877
3878         Reviewed by Martin Robinson.
3879
3880         The tool generate-gtkdoc internally calls pkg-config.
3881         When cross-compiling it shouldn't use pkg-config, but
3882         it should use the pkg-config which was detected by
3883         the ./configure script (for example this can be
3884         i686-w64-mingw32-pkg-config when cross-compiling)
3885
3886         * GNUmakefile.am:
3887         * gtk/gtkdoc.py:
3888         (PkgConfigGTKDoc.__init__):
3889
3890 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
3891
3892         [Windows] Unreviewed build fix.
3893
3894         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
3895         allow VS2010 builds to use VS2005 runtime libraries as needed.
3896
3897 2013-06-03  Roger Fong  <roger_fong@apple.com>
3898
3899         Nuke VS2005 files from the tree.
3900         <rdar://problem/14042021>.
3901
3902         Rubberstamped by Brent Fulgham.
3903
3904         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
3905         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
3906         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
3907         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
3908         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
3909         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
3910         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
3911         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
3912         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
3913         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
3914         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
3915         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
3916         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
3917         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
3918         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
3919         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
3920         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
3921         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
3922         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
3923         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
3924         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
3925         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
3926         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
3927         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
3928         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
3929         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
3930         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
3931         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
3932         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
3933         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
3934         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
3935         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
3936         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
3937         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
3938         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
3939         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
3940         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
3941         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
3942         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
3943         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
3944         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
3945         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
3946         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
3947         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
3948         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
3949         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
3950         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
3951         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
3952         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
3953         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
3954         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
3955         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
3956         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
3957         * Scripts/pdevenv: Removed.
3958         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
3959         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
3960         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
3961         * WebKitLauncherWin: Removed.
3962         * WebKitLauncherWin/Resource.h: Removed.
3963         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
3964         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
3965         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
3966         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
3967         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
3968         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
3969         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
3970         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
3971         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
3972         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
3973         * WebKitLauncherWin/webkit.ico: Removed.
3974         * WinLauncher/WinLauncher.ico: Removed.
3975         * WinLauncher/WinLauncher.rc: Removed.
3976         * WinLauncher/WinLauncher.vcproj: Removed.
3977         * WinLauncher/WinLauncherCommon.vsprops: Removed.
3978         * WinLauncher/WinLauncherDebug.vsprops: Removed.
3979         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
3980         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
3981         * WinLauncher/WinLauncherLauncher.rc: Removed.
3982         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
3983         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
3984         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
3985         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
3986         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
3987         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
3988         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
3989         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
3990         * WinLauncher/WinLauncherLauncherResource.h: Removed.
3991         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
3992         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
3993         * WinLauncher/WinLauncherProduction.vsprops: Removed.
3994         * WinLauncher/WinLauncherRelease.vsprops: Removed.
3995         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
3996         * WinLauncher/small.ico: Removed.
3997         * record-memory-win: Removed.
3998         * record-memory-win/main.cpp: Removed.
3999         * record-memory-win/record-memory-win-common.vsprops: Removed.
4000         * record-memory-win/record-memory-win.vcproj: Removed.
4001         * record-memory-win/record-memory-winDebug.vsprops: Removed.
4002         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
4003         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
4004         * record-memory-win/record-memory-winProduction.vsprops: Removed.
4005         * record-memory-win/record-memory-winRelease.vsprops: Removed.
4006         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
4007
4008 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
4009
4010         AX: MathML multiscripts not exposed in Accessibility
4011         https://bugs.webkit.org/show_bug.cgi?id=115069
4012
4013         Reviewed by Tim Horton.
4014
4015         Add methods to help output components of math multiscripts for accessibility.
4016
4017         * DumpRenderTree/AccessibilityUIElement.cpp:
4018         (mathPostscriptsDescriptionCallback):
4019         (mathPrescriptsDescriptionCallback):
4020         (AccessibilityUIElement::getJSClass):
4021         * DumpRenderTree/AccessibilityUIElement.h:
4022         (AccessibilityUIElement):
4023         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4024         (convertMathMultiscriptPairsToString):
4025         (AccessibilityUIElement::mathPostscriptsDescription):
4026         (AccessibilityUIElement::mathPrescriptsDescription):
4027         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4028         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
4029         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
4030         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4031         (AccessibilityUIElement):
4032         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4033         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4034         (WTR::_convertMathMultiscriptPairsToString):
4035         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
4036         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
4037
4038 2013-06-03  Commit Queue  <commit-queue@webkit.org>
4039
4040         Unreviewed, rolling out r151109.
4041         http://trac.webkit.org/changeset/151109
4042         https://bugs.webkit.org/show_bug.cgi?id=117145
4043
4044         "Plugins in WK2 aren't implemented yet." (Requested by
4045         jturcotte on #webkit).
4046
4047         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4048         * qmake/mkspecs/features/features.prf:
4049         * qmake/mkspecs/features/unix/default_pre.prf:
4050
4051 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
4052
4053         [Qt] Re-enable plugins on Mac.
4054         https://bugs.webkit.org/show_bug.cgi?id=116622
4055
4056         Reviewed by Tor Arne Vestbø.
4057
4058         Plugins on Mac were only enabled if !embedded but the later was set if
4059         QPA is enabled, which is the default since Qt 5.0.
4060
4061         Remove references to 'embedded' and fix various build issues,
4062         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
4063         months.
4064
4065         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4066         * qmake/mkspecs/features/features.prf:
4067         * qmake/mkspecs/features/unix/default_pre.prf:
4068
4069 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
4070
4071         [GTK][WK2] accessibility/placeholder.html is failing
4072         https://bugs.webkit.org/show_bug.cgi?id=106344
4073
4074         Reviewed by Gyuyoung Kim.
4075
4076         Adds support for retrieving attribute value.
4077
4078         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4079         (WTR::coreAttributeToAtkAttribute):
4080         (WTR::AccessibilityUIElement::stringAttributeValue):
4081
4082 2013-06-01  Tim Horton  <timothy_horton@apple.com>
4083
4084         Add a preferred email address and "expertise" for me.
4085
4086         * Scripts/webkitpy/common/config/contributors.json:
4087
4088 2013-05-31  Roger Fong  <roger_fong@apple.com>
4089
4090         Unreviewed. Make windows test bots search in the correct directory for build output.
4091
4092         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4093         (RunWebKitTests.start):
4094         * Scripts/webkitdirs.pm:
4095         (determineConfigurationProductDir):
4096
4097 2013-05-31  Roger Fong  <roger_fong@apple.com>
4098
4099         Unreviewed. Windows build fix...
4100
4101         * BuildSlaveSupport/built-product-archive:
4102         (createZip):
4103
4104 2013-05-31  Roger Fong  <roger_fong@apple.com>
4105
4106         Unreviewed. Windows build fix. One more time!
4107
4108         * BuildSlaveSupport/built-product-archive:
4109         (archiveBuiltProduct):
4110         (extractBuiltProduct):
4111
4112 2013-05-31  Roger Fong  <roger_fong@apple.com>
4113
4114         Unreviewed. Windows build fix.
4115
4116         * Scripts/build-webkit:
4117
4118 2013-05-31  Roger Fong  <roger_fong@apple.com>
4119
4120         Unreviewed. Windows build fix.
4121
4122         * Scripts/build-webkit:
4123
4124 2013-05-31  Roger Fong  <roger_fong@apple.com>
4125
4126         Make build-webkit output VCExpress 2010 build logs properly.
4127         https://bugs.webkit.org/show_bug.cgi?id=117096
4128
4129         Reviewed by Brent Fulgham.
4130
4131         Make it so that output from VCExpress is always printed to console.
4132         Get build log results from AssembleBuildLogs project output.
4133         We don't need those old VCExpress scripts anymore either. 
4134
4135         * Scripts/build-webkit:
4136         * Scripts/print-msvc-project-dependencies: Removed.
4137         * Scripts/print-vse-failure-logs: Removed.
4138
4139 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
4140
4141         [Windows] Use WinLauncher to display LayoutTest results
4142         https://bugs.webkit.org/show_bug.cgi?id=117085
4143
4144         Reviewed by Oliver Hunt.
4145
4146         * Scripts/webkitdirs.pm:
4147         (runSafari): Use WinLauncher to display content
4148         * WinLauncher/WinLauncher.cpp:
4149         (dllLauncherEntryPoint): Check for URL argument.
4150
4151 2013-05-31  Roger Fong  <roger_fong@apple.com>
4152
4153         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
4154
4155         * win/AssembleBuildLogs/AssembleLogs.cmd:
4156
4157 2013-05-31  Commit Queue  <commit-queue@webkit.org>
4158
4159         Unreviewed, rolling out r151022.
4160         http://trac.webkit.org/changeset/151022
4161         https://bugs.webkit.org/show_bug.cgi?id=117084
4162
4163         Also breaks build by introducing duplicate symbols (Requested
4164         by bfulgham on #webkit).
4165
4166         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
4167
4168 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
4169
4170         [Windows] Unreviewed build fix to NRWT
4171
4172         * Scripts/webkitpy/port/win.py:
4173         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
4174
4175 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
4176
4177         [Windows] Unreviewed build fix after r151012
4178
4179         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
4180         WTF library to support SHA tests
4181
4182 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
4183
4184         [Windows] Unreviewed build fix after r151012
4185
4186         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
4187         snprintf definition for Windows.
4188
4189 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
4190
4191         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
4192         https://bugs.webkit.org/show_bug.cgi?id=116445
4193
4194         Reviewed by Benjamin Poulain.
4195
4196         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
4197
4198         * TestWebKitAPI/CMakeLists.txt:
4199         * TestWebKitAPI/GNUmakefile.am:
4200         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4201         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
4202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4203         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
4204         (TestWebKitAPI):
4205         (TestWebKitAPI::expectMD5):
4206         (TestWebKitAPI::TEST):
4207         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
4208         (TestWebKitAPI):
4209         (TestWebKitAPI::expectSHA1):
4210         (TestWebKitAPI::TEST):
4211         * TestWebKitAPI/Tests/WTF/WTF.pro:
4212         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4213
4214 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
4215
4216         [Windows] Unreviewed build correction.
4217
4218         * Scripts/webkitpy/port/win.py:
4219         (WinPort.create_debugger_command_file): The directory needs to be
4220         a string, not a temporary directory object.
4221
4222 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
4223
4224         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
4225         https://bugs.webkit.org/show_bug.cgi?id=76935
4226
4227         Reviewed by Ryosuke Niwa.
4228
4229         Extend the WinPort class with commands to set and clean up various registry
4230         values needed to invoke the correct debugger to get crash files.
4231
4232         * Scripts/webkitpy/port/win.py:
4233         (WinPort): Added global caches for registry keys and settings
4234         (WinPort._ntsd_location): Added
4235         (WinPort.create_debugger_command_file): Added
4236         (WinPort.read_registry_string): Added
4237         (WinPort.write_registry_string): Added
4238         (WinPort.setup_crash_log_saving): Added
4239         (WinPort.restore_crash_log_saving): Added
4240         (WinPort.setup_test_run): Added overload to add registry settings.
4241         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
4242
4243 2013-05-30  Roger Fong  <roger_fong@apple.com>
4244
4245         Get rid of JavaScript exports file on AppleWin port.
4246         https://bugs.webkit.org/show_bug.cgi?id=117050.
4247
4248         Reviewed by Darin Adler.
4249
4250         Start linking in WTF.lib now that it's a shared library.
4251
4252         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
4253         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
4254         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
4255
4256 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
4257
4258         Web Inspector: tests in PerformanceTests/inspector/ are timing out
4259         https://bugs.webkit.org/show_bug.cgi?id=77024
4260
4261         Reviewed by Andreas Kling.
4262
4263         Remove inspector performance tests since they have been disabled for ages,
4264         and they don't use the standard parser-style performance output.
4265
4266         It's adding a lot of code complexity to our infrastructure.
4267
4268         * Scripts/webkitpy/performance_tests/perftest.py:
4269         (SingleProcessPerfTest.__init__):
4270         (PerfTestFactory):
4271         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
4272         (TestPerfTestFactory.test_regular_test):
4273         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4274         (TestDriver.run_test):
4275         (MainTest.run_test):
4276         (MainTest._tests_for_runner):
4277         (MainTest.test_run_test_set_kills_drt_per_run):
4278         (MainTest._test_run_with_json_output):
4279         (MainTest):
4280         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
4281
4282 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
4283
4284         Remove requires_http_server as Chromium Android was the only port that needed this
4285         https://bugs.webkit.org/show_bug.cgi?id=117018
4286
4287         Reviewed by Benjamin Poulain.
4288
4289         Removed the unused code that existed for Chromium Android port.
4290
4291         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4292         (LayoutTestRunner.run_tests):
4293         (LayoutTestRunner._handle_finished_test_list):
4294         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4295         (Manager._run_tests):
4296         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4297         (PerfTestsRunner._collect_tests):
4298         (PerfTestsRunner.run):
4299         * Scripts/webkitpy/port/base.py:
4300         (Port.to.start_helper):
4301         * Scripts/webkitpy/port/base_unittest.py:
4302         (PortTest.test_build_path):
4303
4304 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
4305
4306         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
4307         https://bugs.webkit.org/show_bug.cgi?id=113221
4308
4309         Reviewed by Ryosuke Niwa.
4310
4311         Teach prepare-Changelog to not list the names of modified namespaces, 
4312         classes, or structs in C++ files. Thus, if a change is made 
4313         within a namespace/class/struct yet outside a function, it will 
4314         not be reflected in the ChangeLog entry. 
4315         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
4316         for more details on how ChangeLog entries are affected.
4317
4318        &