a36626e5512c144c03475d2156c5380951d6b3c2
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-22  Chris Dumez  <cdumez@apple.com>
2
3         Delayed WebProcessLaunch may break the _relatedWebView SPI
4         https://bugs.webkit.org/show_bug.cgi?id=197160
5
6         Reviewed by Alex Christensen.
7
8         Add API test coverage.
9
10         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
11
12 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
13
14         Use curl to download packages for webkitpy autoinstaller
15         https://bugs.webkit.org/show_bug.cgi?id=197164
16
17         Reviewed by Darin Adler.
18
19         * Scripts/webkitpy/common/system/autoinstall.py:
20         (AutoInstaller._download): Use curl(1) to download packages necessary for
21         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
22         errors which are not present when using curl(1).
23
24 2019-04-22  Chris Dumez  <cdumez@apple.com>
25
26         Unreviewed, rolling out r244502.
27
28         Caused crashes on the bots
29
30         Reverted changeset:
31
32         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
33         https://bugs.webkit.org/show_bug.cgi?id=197160
34         https://trac.webkit.org/changeset/244502
35
36 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
37
38         Unreviewed, rolling out r244437.
39
40         Still breaks internal tests.
41
42         Reverted changeset:
43
44         "InjectedBundle parameters often need initialization function
45         called before unarchiving"
46         https://bugs.webkit.org/show_bug.cgi?id=189709
47         https://trac.webkit.org/changeset/244437
48
49 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
50
51         [ews-build] Use singular verb in failure description in case of single api test failure
52         https://bugs.webkit.org/show_bug.cgi?id=197013
53
54         Reviewed by Lucas Forschler.
55
56         * BuildSlaveSupport/ews-build/steps.py:
57         (AnalyzeAPITestsResults.analyzeResults):
58
59 2019-04-22  Chris Dumez  <cdumez@apple.com>
60
61         Delayed WebProcessLaunch may break the _relatedWebView SPI
62         https://bugs.webkit.org/show_bug.cgi?id=197160
63
64         Reviewed by Alex Christensen.
65
66         Add API test coverage.
67
68         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
69
70 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
71
72         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
73         https://bugs.webkit.org/show_bug.cgi?id=194630
74
75         Reviewed by Michael Catanzaro.
76
77         Return early from getAttributeSet() is passed in accessible is nullptr.
78
79         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
80
81 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
82
83         Defer EditorState updates until the next layer tree flush in a few additional circumstances
84         https://bugs.webkit.org/show_bug.cgi?id=197145
85         <rdar://problem/50078170>
86
87         Reviewed by Darin Adler.
88
89         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
90         focus, or showing the font manager.
91
92         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
93         (TestWebKitAPI::TEST):
94         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
95         (TEST):
96         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
97         (TestWebKitAPI::TEST):
98
99 2019-04-21  Brian Burg  <bburg@apple.com>
100
101         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
102         https://bugs.webkit.org/show_bug.cgi?id=197125
103         <rdar://problem/50061468>
104
105         Reviewed by Darin Adler.
106
107         Sometimes I want to run wptserve independently of tests. Make it easier to script that
108         using this class rather than making our own ./wpt serve invocation.
109
110         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
111         (WebDriverW3CWebServer):
112         (WebDriverW3CWebServer.document_root): Expose this to clients.
113         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
114
115         (WebDriverW3CWebServer.__enter__):
116         (WebDriverW3CWebServer.__exit__):
117         Make it possible to use the web server with a 'with' statement.
118
119 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
120
121         [CMake][Win] Use target oriented design for WebKitLegacy
122         https://bugs.webkit.org/show_bug.cgi?id=197112
123
124         Reviewed by Konstantin Tokarev.
125
126         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
127
128         * DumpRenderTree/CMakeLists.txt:
129         * DumpRenderTree/PlatformWin.cmake:
130         * DumpRenderTree/win/EventSender.cpp:
131
132 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
133
134         Update text for old EWS submit button
135         https://bugs.webkit.org/show_bug.cgi?id=197140
136
137         Reviewed by Alexey Proskuryakov.
138
139         * QueueStatusServer/templates/statusbubble.html:
140
141 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
142
143         [ews-app] New EWS should poll bugzilla more frequently
144         https://bugs.webkit.org/show_bug.cgi?id=197138
145
146         Reviewed by Alexey Proskuryakov.
147
148         * BuildSlaveSupport/ews-app/ews/fetcher.py:
149         (FetchLoop.__init__):
150
151 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
152
153         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
154         https://bugs.webkit.org/show_bug.cgi?id=197139
155
156         Reviewed by Alexey Proskuryakov.
157
158         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
159         * QueueStatusServer/templates/statusbubble.html:
160
161 2019-04-20  Chris Dumez  <cdumez@apple.com>
162
163         Unreviewed, fix iOS build with recent SDKs.
164
165         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
166
167 2019-04-19  Keith Miller  <keith_miller@apple.com>
168
169         Add script to merge run_benchmark jsons
170         https://bugs.webkit.org/show_bug.cgi?id=197107
171
172         Reviewed by Michael Saboff.
173
174         The script basically recursively decends through all json objects until it gets
175         to an array or JSON primitive and concats or takes the first value, respectively.
176
177         This patch also adds +x bits to the compare-results script so it
178         can be run directly from the command line. I had to add a new line so that svn
179         will accept the change... yay svn!
180
181         * Scripts/compare-results:
182         * Scripts/merge-result-jsons: Added.
183         (readJSONFile):
184         (deepAppend):
185         (mergeJSONs):
186         (main):
187
188 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
189
190         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
191         https://bugs.webkit.org/show_bug.cgi?id=197079
192
193         Reviewed by Darin Adler.
194
195         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
196
197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
198         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
199
200 2019-04-18  Commit Queue  <commit-queue@webkit.org>
201
202         Unreviewed, rolling out r244434.
203         https://bugs.webkit.org/show_bug.cgi?id=197089
204
205         caused 1 API test failure (Requested by zalan on #webkit).
206
207         Reverted changeset:
208
209         "Regression (r244291): Broken API Test
210         AutoLayoutRenderingProgressRelativeOrdering"
211         https://bugs.webkit.org/show_bug.cgi?id=196948
212         https://trac.webkit.org/changeset/244434
213
214 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
215
216         Add new compatibility mode API on WKNavigation
217         https://bugs.webkit.org/show_bug.cgi?id=197069
218         <rdar://problem/50025800>
219
220         Reviewed by Tim Horton.
221
222         Add a block property for -didCommitNavigation to TestNavigationDelegate.
223
224         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
225         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
226         (-[TestNavigationDelegate webView:didCommitNavigation:]):
227
228 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
229
230         [CMake] Make WebCore headers copies
231         https://bugs.webkit.org/show_bug.cgi?id=182512
232         <rdar://problem/37510435>
233
234         Reviewed by Alex Christensen.
235
236         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
237         ports.
238
239         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
240         of WebCore headers using "*.h" were modified to <WebCore/*.h>
241
242         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
243         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
244         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
245         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
246         * TestWebKitAPI/CMakeLists.txt:
247         * TestWebKitAPI/PlatformWin.cmake:
248         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
249         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
250         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
251
252 2019-04-18  Jer Noble  <jer.noble@apple.com>
253
254         Add support for parsing FairPlayStreaming PSSH boxes.
255         https://bugs.webkit.org/show_bug.cgi?id=197064
256
257         Reviewed by Eric Carlson.
258
259         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
260         (TestWebKitAPI::TEST):
261
262 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
263
264         InjectedBundle parameters often need initialization function called before unarchiving
265         https://bugs.webkit.org/show_bug.cgi?id=189709
266         <rdar://problem/44573653>
267
268         Reviewed by Ryosuke Niwa.
269
270         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
271         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
272
273 2019-04-18  Zalan Bujtas  <zalan@apple.com>
274
275         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
276         https://bugs.webkit.org/show_bug.cgi?id=196948
277         <rdar://problem/49927131>
278
279         Reviewed by Tim Horton.
280
281         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
282         (TEST): 
283         The expected order of incoming events is
284         1. didInvalidateIntrinsicContentSize
285         2. didFirstLayout
286         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
287         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
288         (and remember, all we care about is ordering).
289
290 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
291
292         Unreviewed, rolling out r244299.
293
294         Breaks internal tests.
295
296         Reverted changeset:
297
298         "InjectedBundle parameters often need initialization function
299         called before unarchiving"
300         https://bugs.webkit.org/show_bug.cgi?id=189709
301         https://trac.webkit.org/changeset/244299
302
303 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
304
305         [WTF] StringBuilder should set correct m_is8Bit flag when merging
306         https://bugs.webkit.org/show_bug.cgi?id=197053
307
308         Reviewed by Saam Barati.
309
310         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
311         (TestWebKitAPI::TEST):
312
313 2019-04-17  Tim Horton  <timothy_horton@apple.com>
314
315         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
316         https://bugs.webkit.org/show_bug.cgi?id=197028
317         <rdar://problem/49985290>
318
319         Reviewed by Wenson Hsieh.
320
321         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
322         (TEST):
323         Liberal application of waitForNextPresentationUpdate works around a race
324         where if the page rapidly changes its viewport arguments (or an API client
325         rapidly changes its viewport arguments), we'd get stuck thinking that the
326         user had intentionally zoomed the page, and stop resetting the initial scale.
327         This deserves a separate bug, but no need to keep the test failing while
328         we think about it.
329
330 2019-04-17  Tim Horton  <timothy_horton@apple.com>
331
332         REGRESSION (r241988): Switching tabs is slow
333         https://bugs.webkit.org/show_bug.cgi?id=197037
334         <rdar://problem/49951473>
335
336         Reviewed by Simon Fraser.
337
338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
339         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
340         (TEST):
341         * TestWebKitAPI/cocoa/TestWKWebView.h:
342         * TestWebKitAPI/cocoa/TestWKWebView.mm:
343         (-[TestWKWebView addToTestWindow]):
344         Add a test that hangs without this fix.
345
346 2019-04-17  Truitt Savell  <tsavell@apple.com>
347
348         Unreviewed, rolling out r244400.
349
350         Caused testing to exit early with assertionon Debug WK2
351
352         Reverted changeset:
353
354         "UI↔Web deadlock when printing with a JavaScript alert
355         visible"
356         https://bugs.webkit.org/show_bug.cgi?id=196839
357         https://trac.webkit.org/changeset/244400
358
359 2019-04-17  Brady Eidson  <beidson@apple.com>
360
361         Link clicks in PDFs shouldn't send referrer headers.
362         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
363
364         Reviewed by Tim Horton.
365
366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
367         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
368         (putPDFBytesCallback):
369         (emptyReleaseInfoCallback):
370         (createPDFWithLinkToURL):
371         (TEST):
372
373 2019-04-17  Tim Horton  <timothy_horton@apple.com>
374
375         UI↔Web deadlock when printing with a JavaScript alert visible
376         https://bugs.webkit.org/show_bug.cgi?id=196839
377         <rdar://problem/49157642>
378
379         Reviewed by Andy Estes.
380
381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
382         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
383         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
384         (TEST):
385
386 2019-04-17  Alex Christensen  <achristensen@webkit.org>
387
388         WKRetainPtr's adoption constructor should be private
389         https://bugs.webkit.org/show_bug.cgi?id=197019
390
391         Reviewed by Tim Horton.
392
393         * DumpRenderTree/mac/DumpRenderTree.mm:
394         (dumpFramesAsText):
395         * TestWebKitAPI/InjectedBundleController.cpp:
396         (TestWebKitAPI::InjectedBundleController::initialize):
397         * TestWebKitAPI/PlatformUtilities.cpp:
398         (TestWebKitAPI::Util::createContextWithInjectedBundle):
399         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
400         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
401         (TestWebKitAPI::Util::toWK):
402         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
403         (TestWebKitAPI::TEST):
404         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
405         (TestWebKitAPI::TEST):
406         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
407         (TestWebKitAPI::TEST):
408         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
409         (TestWebKitAPI::TEST):
410         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
411         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
412         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
413         (TestWebKitAPI::TEST):
414         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
415         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
416         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
417         (TestWebKitAPI::TEST):
418         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
419         (TestWebKitAPI::TEST):
420         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
421         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
422         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
423         (TestWebKitAPI::TEST):
424         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
425         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
426         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
427         (TestWebKitAPI::TEST):
428         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
429         (TestWebKitAPI::TEST):
430         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
431         (TestWebKitAPI::TEST):
432         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
433         (TestWebKitAPI::TEST):
434         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
435         (TestWebKitAPI::TEST):
436         * TestWebKitAPI/Tests/WebKit/Find.cpp:
437         (TestWebKitAPI::TEST):
438         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
439         (TestWebKitAPI::TEST):
440         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
441         (TestWebKitAPI::TEST):
442         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
443         (TestWebKitAPI::TEST):
444         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
445         (TestWebKitAPI::TEST):
446         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
447         (TestWebKitAPI::TEST):
448         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
449         (TestWebKitAPI::TEST):
450         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
451         (TestWebKitAPI::TEST):
452         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
453         (TestWebKitAPI::TEST):
454         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
455         (TestWebKitAPI::TEST):
456         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
457         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
458         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
459         (TestWebKitAPI::TEST):
460         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
461         (TestWebKitAPI::TEST):
462         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
463         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
464         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
465         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
466         (TestWebKitAPI::TEST):
467         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
468         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
469         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
470         (TestWebKitAPI::TEST):
471         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
472         (TestWebKitAPI::TEST):
473         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
474         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
475         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
476         (TestWebKitAPI::TEST):
477         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
478         (TestWebKitAPI::loadAlternateHTMLString):
479         (TestWebKitAPI::TEST):
480         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
481         (TestWebKitAPI::TEST):
482         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
483         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
484         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
485         (TestWebKitAPI::buildAndPerformTest):
486         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
487         (TestWebKitAPI::TEST):
488         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
489         (TestWebKitAPI::TEST):
490         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
491         (TestWebKitAPI::TEST):
492         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
493         (TestWebKitAPI::TEST):
494         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
495         (TestWebKitAPI::TEST):
496         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
497         (TestWebKitAPI::TEST):
498         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
499         (TestWebKitAPI::TEST):
500         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
501         (TestWebKitAPI::TEST):
502         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
503         (TestWebKitAPI::TEST):
504         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
505         (TestWebKitAPI::TEST):
506         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
507         (TestWebKitAPI::TEST):
508         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
509         (TestWebKitAPI::TEST):
510         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
511         (TestWebKitAPI::TEST):
512         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
513         (TestWebKitAPI::TEST):
514         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
515         (TestWebKitAPI::TEST):
516         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
517         (TestWebKitAPI::TEST):
518         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
519         (TestWebKitAPI::TEST):
520         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
521         (TestWebKitAPI::TEST):
522         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
523         (TestWebKitAPI::TEST):
524         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
525         (TestWebKitAPI::TEST):
526         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
527         (TestWebKitAPI::TEST):
528         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
529         (TestWebKitAPI::TEST):
530         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
531         (TestWebKitAPI::TEST):
532         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
533         (TestWebKitAPI::TEST):
534         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
535         (TestWebKitAPI::TEST):
536         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
537         (TestWebKitAPI::TEST):
538         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
539         (TestWebKitAPI::TEST):
540         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
541         (TestWebKitAPI::TEST):
542         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
543         (TestWebKitAPI::TEST):
544         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
545         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
546         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
547         (TestWebKitAPI::TEST):
548         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
549         (TestWebKitAPI::TEST):
550         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
551         (TestWebKitAPI::TEST):
552         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
553         (TestWebKitAPI::TEST):
554         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
555         (TestWebKitAPI::TEST):
556         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
557         (TestWebKitAPI::TEST):
558         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
559         (TestWebKitAPI::TEST):
560         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
561         (TestWebKitAPI::TEST):
562         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
563         (TestWebKitAPI::TEST):
564         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
565         (TestWebKitAPI::TEST):
566         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
567         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
568         (TEST):
569         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
570         (TEST):
571         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
572         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
573         (TEST):
574         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
575         (TestWebKitAPI::TEST):
576         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
577         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
578         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
579         (WTR::getMenuItemTitleCallback):
580         (WTR::createMouseMessageBody):
581         (WTR::EventSendingController::mouseDown):
582         (WTR::EventSendingController::mouseUp):
583         (WTR::EventSendingController::mouseMoveTo):
584         (WTR::EventSendingController::mouseForceClick):
585         (WTR::EventSendingController::startAndCancelMouseForceClick):
586         (WTR::EventSendingController::mouseForceDown):
587         (WTR::EventSendingController::mouseForceUp):
588         (WTR::EventSendingController::mouseForceChanged):
589         (WTR::EventSendingController::leapForward):
590         (WTR::EventSendingController::scheduleAsynchronousClick):
591         (WTR::createKeyDownMessageBody):
592         (WTR::EventSendingController::keyDown):
593         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
594         (WTR::EventSendingController::mouseScrollBy):
595         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
596         (WTR::EventSendingController::continuousMouseScrollBy):
597         (WTR::EventSendingController::addTouchPoint):
598         (WTR::EventSendingController::updateTouchPoint):
599         (WTR::EventSendingController::setTouchModifier):
600         (WTR::EventSendingController::setTouchPointRadius):
601         (WTR::EventSendingController::touchStart):
602         (WTR::EventSendingController::touchMove):
603         (WTR::EventSendingController::touchEnd):
604         (WTR::EventSendingController::touchCancel):
605         (WTR::EventSendingController::clearTouchPoints):
606         (WTR::EventSendingController::releaseTouchPoint):
607         (WTR::EventSendingController::cancelTouchPoint):
608         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
609         (WTR::InjectedBundle::didCreatePage):
610         (WTR::InjectedBundle::didReceiveMessage):
611         (WTR::InjectedBundle::didReceiveMessageToPage):
612         (WTR::InjectedBundle::booleanForKey):
613         (WTR::InjectedBundle::done):
614         (WTR::InjectedBundle::dumpToStdErr):
615         (WTR::InjectedBundle::outputText):
616         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
617         (WTR::InjectedBundle::postAddChromeInputField):
618         (WTR::InjectedBundle::postRemoveChromeInputField):
619         (WTR::InjectedBundle::postFocusWebView):
620         (WTR::InjectedBundle::postSetBackingScaleFactor):
621         (WTR::InjectedBundle::postSetWindowIsKey):
622         (WTR::InjectedBundle::postSetViewSize):
623         (WTR::InjectedBundle::postSimulateWebNotificationClick):
624         (WTR::InjectedBundle::postSetAddsVisitedLinks):
625         (WTR::InjectedBundle::setGeolocationPermission):
626         (WTR::InjectedBundle::setMockGeolocationPosition):
627         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
628         (WTR::InjectedBundle::isGeolocationProviderActive const):
629         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
630         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
631         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
632         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
633         (WTR::InjectedBundle::setCustomPolicyDelegate):
634         (WTR::InjectedBundle::setHidden):
635         (WTR::InjectedBundle::setCacheModel):
636         (WTR::InjectedBundle::shouldProcessWorkQueue const):
637         (WTR::InjectedBundle::processWorkQueue):
638         (WTR::InjectedBundle::queueBackNavigation):
639         (WTR::InjectedBundle::queueForwardNavigation):
640         (WTR::InjectedBundle::queueLoad):
641         (WTR::InjectedBundle::queueLoadHTMLString):
642         (WTR::InjectedBundle::queueReload):
643         (WTR::InjectedBundle::queueLoadingScript):
644         (WTR::InjectedBundle::queueNonLoadingScript):
645         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
646         (WTR::frameToStr):
647         (WTR::InjectedBundlePage::InjectedBundlePage):
648         (WTR::dumpFrameDescriptionSuitableForTestResult):
649         (WTR::dumpFrameScrollPosition):
650         (WTR::dumpDescendantFrameScrollPositions):
651         (WTR::dumpFrameText):
652         (WTR::dumpDescendantFramesText):
653         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
654         (WTR::TestRunner::shouldDumpPixels const):
655         (WTR::TestRunner::setDumpPixels):
656         (WTR::TestRunner::whatToDump const):
657         (WTR::TestRunner::setWhatToDump):
658         (WTR::TestRunner::setWaitUntilDone):
659         (WTR::TestRunner::shouldWaitUntilDone const):
660         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
661         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
662         (WTR::TestRunner::clearAllDatabases):
663         (WTR::TestRunner::setIDBPerOriginQuota):
664         (WTR::TestRunner::originsWithApplicationCache):
665         (WTR::TestRunner::setCanOpenWindows):
666         (WTR::TestRunner::setXSSAuditorEnabled):
667         (WTR::TestRunner::setMediaDevicesEnabled):
668         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
669         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
670         (WTR::TestRunner::setCustomUserAgent):
671         (WTR::TestRunner::setWebAPIStatisticsEnabled):
672         (WTR::TestRunner::setModernMediaControlsEnabled):
673         (WTR::TestRunner::setWebGL2Enabled):
674         (WTR::TestRunner::setWritableStreamAPIEnabled):
675         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
676         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
677         (WTR::TestRunner::setAllowsAnySSLCertificate):
678         (WTR::TestRunner::setPluginsEnabled):
679         (WTR::TestRunner::setValueForUser):
680         (WTR::TestRunner::setAudioResult):
681         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
682         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
683         (WTR::TestRunner::setAlwaysAcceptCookies):
684         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
685         (WTR::TestRunner::isDoingMediaCapture const):
686         (WTR::TestRunner::queueLoad):
687         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
688         (WTR::TestRunner::setHandlesAuthenticationChallenges):
689         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
690         (WTR::TestRunner::setShouldLogDownloadCallbacks):
691         (WTR::TestRunner::setAuthenticationUsername):
692         (WTR::TestRunner::setAuthenticationPassword):
693         (WTR::TestRunner::secureEventInputIsEnabled const):
694         (WTR::TestRunner::setBlockAllPlugins):
695         (WTR::TestRunner::setPluginSupportedMode):
696         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
697         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
698         (WTR::TestRunner::setNavigationGesturesEnabled):
699         (WTR::TestRunner::setIgnoresViewportScaleLimits):
700         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
701         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
702         (WTR::TestRunner::terminateNetworkProcess):
703         (WTR::TestRunner::terminateServiceWorkerProcess):
704         (WTR::TestRunner::runUIScript):
705         (WTR::TestRunner::setStatisticsDebugMode):
706         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
707         (WTR::TestRunner::setStatisticsLastSeen):
708         (WTR::TestRunner::setStatisticsPrevalentResource):
709         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
710         (WTR::TestRunner::dumpResourceLoadStatistics):
711         (WTR::TestRunner::isStatisticsPrevalentResource):
712         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
713         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
714         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
715         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
716         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
717         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
718         (WTR::TestRunner::setStatisticsGrandfathered):
719         (WTR::TestRunner::isStatisticsGrandfathered):
720         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
721         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
722         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
723         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
724         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
725         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
726         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
727         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
728         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
729         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
730         (WTR::TestRunner::statisticsUpdateCookieBlocking):
731         (WTR::TestRunner::statisticsSubmitTelemetry):
732         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
733         (WTR::TestRunner::setStatisticsIsRunningTest):
734         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
735         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
736         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
737         (WTR::TestRunner::setStatisticsGrandfatheringTime):
738         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
739         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
740         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
741         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
742         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
743         (WTR::TestRunner::statisticsDeleteCookiesForHost):
744         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
745         (WTR::TestRunner::statisticsResetToConsistentState):
746         (WTR::TestRunner::setStorageAccessAPIEnabled):
747         (WTR::TestRunner::getAllStorageAccessEntries):
748         (WTR::TestRunner::addMockMediaDevice):
749         (WTR::TestRunner::clearMockMediaDevices):
750         (WTR::TestRunner::removeMockMediaDevice):
751         (WTR::TestRunner::resetMockMediaDevices):
752         (WTR::TestRunner::connectMockGamepad):
753         (WTR::TestRunner::disconnectMockGamepad):
754         (WTR::TestRunner::setMockGamepadDetails):
755         (WTR::TestRunner::setMockGamepadAxisValue):
756         (WTR::TestRunner::setMockGamepadButtonValue):
757         (WTR::TestRunner::removeAllSessionCredentials):
758         (WTR::TestRunner::clearDOMCache):
759         (WTR::TestRunner::clearDOMCaches):
760         (WTR::TestRunner::hasDOMCache):
761         (WTR::TestRunner::domCacheSize):
762         (WTR::TestRunner::setAllowStorageQuotaIncrease):
763         (WTR::TestRunner::getApplicationManifestThen):
764         (WTR::TestRunner::injectUserScript):
765         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
766         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
767         (WTR::TestRunner::addTestKeyToKeychain):
768         (WTR::TestRunner::cleanUpKeychain):
769         (WTR::TestRunner::keyExistsInKeychain):
770         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
771         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
772         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
773         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
774         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
775         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
776         * WebKitTestRunner/TestController.cpp:
777         (WTR::TestController::initialize):
778         (WTR::parseStringTestHeaderValueAsRelativePath):
779         (WTR::updateTestOptionsFromTestHeader):
780         (WTR::TestController::runTest):
781         (WTR::TestController::didReceiveLiveDocumentsList):
782         (WTR::TestController::didReceiveMessageFromInjectedBundle):
783         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
784         (WTR::TestController::didFinishNavigation):
785         (WTR::TestController::didReceiveAuthenticationChallenge):
786         * WebKitTestRunner/TestInvocation.cpp:
787         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
788         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
789         (WTR::TestInvocation::uiScriptDidComplete):
790         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
791         * WebKitTestRunner/WebNotificationProvider.cpp:
792         (WTR::WebNotificationProvider::closeWebNotification):
793         * WebKitTestRunner/WorkQueueManager.cpp:
794         (WTR::ScriptItem::ScriptItem):
795         (WTR::WorkQueueManager::queueLoad):
796         (WTR::WorkQueueManager::queueLoadHTMLString):
797
798 2019-04-17  Alex Christensen  <achristensen@webkit.org>
799
800         Add a comment to make my test from r244139 less mysterious.
801         https://bugs.webkit.org/show_bug.cgi?id=196744
802
803         As suggested by Darin Adler.
804
805         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
806         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
807
808 2019-04-17  Chris Dumez  <cdumez@apple.com>
809
810         Remember device orientation permission for the duration of the browsing session
811         https://bugs.webkit.org/show_bug.cgi?id=196992
812         <rdar://problem/49946067>
813
814         Reviewed by Alex Christensen.
815
816         Add API test coverage.
817
818         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
819         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
820         (TEST):
821
822 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
823
824         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
825         https://bugs.webkit.org/show_bug.cgi?id=196675
826
827         Reviewed by Lucas Forschler.
828
829         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
830         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
831
832 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
833
834         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
835         https://bugs.webkit.org/show_bug.cgi?id=196919
836         <rdar://problem/41630459>
837
838         Reviewed by Tim Horton.
839
840         Add iOS support for several new testing hooks. See below for more detail.
841
842         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
843         (WTR::UIScriptController::isDismissingMenu const):
844
845         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
846         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
847         by UIKit when dismissing the callout bar (i.e. UIMenuController).
848
849         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
850         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
851         (WTR::UIScriptController::isDismissingMenu const):
852         * TestRunnerShared/UIScriptContext/UIScriptController.h:
853         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
854         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
855         (WTR::InjectedBundle::didReceiveMessageToPage):
856         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
857         (WTR::TestRunner::setAllowedMenuActions):
858
859         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
860         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
861         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
862         against the name of the custom action.
863
864         (WTR::TestRunner::installCustomMenuAction):
865
866         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
867         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
868         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
869         triggered.
870
871         (WTR::TestRunner::performCustomMenuAction):
872
873         Invoked when the custom menu action is triggered.
874
875         * WebKitTestRunner/InjectedBundle/TestRunner.h:
876         * WebKitTestRunner/TestController.cpp:
877         (WTR::TestController::installCustomMenuAction):
878         (WTR::TestController::setAllowedMenuActions):
879         * WebKitTestRunner/TestController.h:
880         * WebKitTestRunner/TestInvocation.cpp:
881         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
882         (WTR::TestInvocation::performCustomMenuAction):
883
884         Add plumbing to call back into the injected bundle when performing the custom action.
885
886         * WebKitTestRunner/TestInvocation.h:
887         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
888         (WTR::TestController::installCustomMenuAction):
889         (WTR::TestController::setAllowedMenuActions):
890         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
891         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
892         (-[TestRunnerWKWebView initWithFrame:configuration:]):
893         (-[TestRunnerWKWebView becomeFirstResponder]):
894         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
895
896         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
897         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
898         in the Mail app on iOS.
899
900         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
901         (-[TestRunnerWKWebView setAllowedMenuActions:]):
902         (-[TestRunnerWKWebView resetCustomMenuAction]):
903         (-[TestRunnerWKWebView performCustomAction:]):
904         (-[TestRunnerWKWebView canPerformAction:withSender:]):
905         (-[TestRunnerWKWebView _willHideMenu]):
906         (-[TestRunnerWKWebView _didHideMenu]):
907         * WebKitTestRunner/ios/TestControllerIOS.mm:
908         (WTR::TestController::platformResetStateToConsistentValues):
909
910         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
911         if specified.
912
913         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
914         (WTR::UIScriptController::isDismissingMenu const):
915
916 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
917
918         Allow sharing from imageSheet on an image document
919         https://bugs.webkit.org/show_bug.cgi?id=196891
920         <rdar://problem/25377386>
921
922         Reviewed by Tim Horton.
923
924         Test to make sure that the correct imageURL is extracted from an image element.
925
926         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
927         (TestWebKitAPI::TEST):
928
929 2019-04-16  Alex Christensen  <achristensen@webkit.org>
930
931         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
932         https://bugs.webkit.org/show_bug.cgi?id=196995
933
934         Reviewed by Brady Eidson.
935
936         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
937         (TEST):
938
939 2019-04-16  Chris Dumez  <cdumez@apple.com>
940
941         URL set by document.open() is not communicated to the UIProcess
942         https://bugs.webkit.org/show_bug.cgi?id=196941
943         <rdar://problem/49237544>
944
945         Reviewed by Geoff Garen.
946
947         Add API test coverage.
948
949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
950         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
951         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
952         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
953         (TEST):
954
955 2019-04-16  Commit Queue  <commit-queue@webkit.org>
956
957         Unreviewed, rolling out r244321.
958         https://bugs.webkit.org/show_bug.cgi?id=196968
959
960         Causing all WK2 Debug builds to exit early after Assertion
961         failures. (Requested by ShawnRoberts on #webkit).
962
963         Reverted changeset:
964
965         "URL set by document.open() is not communicated to the
966         UIProcess"
967         https://bugs.webkit.org/show_bug.cgi?id=196941
968         https://trac.webkit.org/changeset/244321
969
970 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
971
972         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
973         https://bugs.webkit.org/show_bug.cgi?id=196948
974
975         Reviewed by Zalan Bujtas.
976
977         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
978         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
979
980 2019-04-15  Chris Dumez  <cdumez@apple.com>
981
982         URL set by document.open() is not communicated to the UIProcess
983         https://bugs.webkit.org/show_bug.cgi?id=196941
984         <rdar://problem/49237544>
985
986         Reviewed by Geoffrey Garen.
987
988         Add API test coverage.
989
990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
991         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
992         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
993         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
994         (TEST):
995
996 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
997
998         Using Tools/Scripts/clean-webkit should not install requests
999         https://bugs.webkit.org/show_bug.cgi?id=196940
1000
1001         Reviewed by Lucas Forschler.
1002
1003         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1004         existing, depending on the path autoinstalled is run through.
1005         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1006         needed.
1007         (Port.configuration_for_upload):
1008         (Port.commits_for_upload):
1009
1010 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1011
1012         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1013         https://bugs.webkit.org/show_bug.cgi?id=196773
1014
1015         Reviewed by Jer Noble.
1016
1017         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1018         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1019         (TEST):
1020
1021 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1022
1023         ews-build should clearly indicate flaky test failures
1024         https://bugs.webkit.org/show_bug.cgi?id=196947
1025
1026         Reviewed by Lucas Forschler.
1027
1028         * BuildSlaveSupport/ews-build/steps.py:
1029         (AnalyzeAPITestsResults.analyzeResults):
1030
1031 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1032
1033         InjectedBundle parameters often need initialization function called before unarchiving
1034         https://bugs.webkit.org/show_bug.cgi?id=189709
1035         <rdar://problem/44573653>
1036
1037         Reviewed by Ryosuke Niwa.
1038
1039         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1040         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1041
1042 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1043
1044         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1045         https://bugs.webkit.org/show_bug.cgi?id=196681
1046
1047         Reviewed by Darin Adler.
1048
1049         Added tests.
1050
1051         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1052         (WTF_HashSet.RemoveIf):
1053         (WTF_HashSet.RemoveIfShrinkToBestSize):
1054
1055 2019-04-15  John Wilander  <wilander@apple.com>
1056
1057         Send delayed Ad Click Attribution conversion requests to the click source
1058         https://bugs.webkit.org/show_bug.cgi?id=196838
1059         <rdar://problem/47650157>
1060
1061         Reviewed by Chris Dumez and Youenn Fablet.
1062
1063         This patch adds test infrastructure to override the default behavior in
1064         WebKit::NetworkAdClickAttribution.
1065
1066         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1067         (TestWebKitAPI::TEST):
1068         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1069         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1070         (WTR::TestRunner::dumpAdClickAttribution):
1071         (WTR::TestRunner::clearAdClickAttribution):
1072         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1073         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1074         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1075         * WebKitTestRunner/TestController.cpp:
1076         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1077         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1078         * WebKitTestRunner/TestController.h:
1079         * WebKitTestRunner/TestInvocation.cpp:
1080         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1081
1082 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1083
1084         [ews-app] status-bubble should display position in queue
1085         https://bugs.webkit.org/show_bug.cgi?id=196607
1086
1087         Reviewed by Lucas Forschler.
1088
1089         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1090         (StatusBubble._build_bubble):
1091         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1092
1093 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1094
1095         [ews-build] Do not run clean build by default on EWS builders
1096         https://bugs.webkit.org/show_bug.cgi?id=196897
1097
1098         Reviewed by Lucas Forschler.
1099
1100         * BuildSlaveSupport/ews-build/steps.py:
1101         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1102         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1103         untracked directories like WebKitBuild).
1104         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1105         untracked files/directories (like WebKitBuild).
1106
1107 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1108
1109         TestRunner::notifyDone() should be safely reentrant
1110         https://bugs.webkit.org/show_bug.cgi?id=196898
1111
1112         Reviewed by Darin Adler.
1113
1114         It is currently possible that TestRunner::notifyDone() will call itself, since
1115         notifyDone() will force a repaint, which can start executing JavaScript, which
1116         may call notifyDone() again. This can lead to test failures and flakiness.
1117         Fix this by setting the m_waitToDump flag before calling the dump() method.
1118
1119         * DumpRenderTree/mac/TestRunnerMac.mm:
1120         (TestRunner::notifyDone):
1121         (TestRunner::forceImmediateCompletion):
1122         * DumpRenderTree/win/TestRunnerWin.cpp:
1123         (TestRunner::notifyDone):
1124         (TestRunner::forceImmediateCompletion):
1125
1126 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1127
1128         [GTK][WPE] Add enable-media websetting
1129         https://bugs.webkit.org/show_bug.cgi?id=196863
1130
1131         Reviewed by Michael Catanzaro.
1132
1133         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1134         (testWebKitSettings): Add test for the enable-media web-setting.
1135
1136 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1137
1138         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1139         https://bugs.webkit.org/show_bug.cgi?id=196905
1140         <rdar://problem/49886096>
1141
1142         Reviewed by Tim Horton.
1143
1144         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1145         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1146         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1147         delay timer, we end up with this sequence of events in the problematic (failure) case:
1148
1149         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1150             ...IPC from UI to web process...
1151         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1152             ...IPC from web to UI process...
1153         (c) [UI]    Invoke completion handler for script #1
1154         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1155             ...IPC from UI to web process...
1156         (e) [Web]   Evaluate script #2 in the web process
1157         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1158
1159         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1160         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1161         #2 is run in step (e).
1162
1163         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1164         the UI process by waiting on a script message posted by the web process, after attachment updates are
1165         dispatched.
1166
1167         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1168         (TestWebKitAPI::TEST):
1169
1170 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1171
1172         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1173         https://bugs.webkit.org/show_bug.cgi?id=196909
1174
1175         Reviewed by Wenson Hsieh.
1176
1177         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1178         (TestWebKitAPI::TEST):
1179
1180 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1181
1182         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1183         https://bugs.webkit.org/show_bug.cgi?id=196880
1184
1185         Reviewed by Yusuke Suzuki.
1186
1187         Add a new function for bytecode cache tests that does not forceDiskCache
1188         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1189         test added in this patch, since the code is invalid and therefore won't be
1190         cached. It should also be useful for tests that evaluate dynamically
1191         generated code.
1192
1193         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1194         * Scripts/run-jsc-stress-tests:
1195
1196 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1197
1198         Update AudioSession route sharing policy
1199         https://bugs.webkit.org/show_bug.cgi?id=196776
1200         <rdar://problem/46501611>
1201
1202         Reviewed by Jer Noble.
1203
1204         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1205         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1206         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1207         (TestWebKitAPI::TEST):
1208
1209 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1210
1211         [iOS] Software keyboard is shown too frequently on some websites
1212         https://bugs.webkit.org/show_bug.cgi?id=195856
1213         <rdar://problem/49191395>
1214
1215         Reviewed by Darin Adler.
1216
1217         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1218
1219         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1220         (WTR::UIScriptController::setHardwareKeyboardAttached):
1221         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1222         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1223         (WTR::UIScriptController::setHardwareKeyboardAttached):
1224         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1225         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1226
1227         Additionally link against GraphicsServices in WebKitTestRunner.
1228
1229         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1230         (WTR::TestController::platformResetStateToConsistentValues):
1231         (WTR::UIScriptController::setHardwareKeyboardAttached):
1232
1233 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1234
1235         [GTK][WPE] Fix pacman install-dependencies packages
1236         https://bugs.webkit.org/show_bug.cgi?id=196817
1237
1238         Reviewed by Žan Doberšek.
1239         
1240         python3-setuptools is called python-setuptools
1241         ruby-highline is only available on AUR
1242         libv4l-devel is incorporated in v4l-utils
1243
1244         * gtk/install-dependencies:
1245         * wpe/install-dependencies:
1246
1247 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1248
1249         [GTK] REGRESSION(r243860): Many tests failing
1250         https://bugs.webkit.org/show_bug.cgi?id=196791
1251
1252         Reviewed by Joanmarie Diggs.
1253
1254         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1255         multiple documents and check that accessibility hierarchy is updated after a navigation.
1256
1257         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1258         (loadChangedCallback):
1259         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1260         (AccessibilityTest::AccessibilityTest):
1261         (AccessibilityTest::~AccessibilityTest):
1262         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1263         (AccessibilityTest::findTestServerApplication):
1264         (AccessibilityTest::findDocumentWeb):
1265         (AccessibilityTest::findRootObject):
1266         (AccessibilityTest::waitUntilChildrenRemoved):
1267         (AccessibilityTest::ensureProxy):
1268         (testAtspiBasicHierarchy):
1269         (beforeAll):
1270         (afterAll):
1271
1272 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1273
1274         [ews-build] Handle bug titles with unicode characters
1275         https://bugs.webkit.org/show_bug.cgi?id=196802
1276
1277         Reviewed by Dewei Zhu.
1278
1279         * BuildSlaveSupport/ews-build/steps.py:
1280         (ValidatePatch._is_bug_closed):
1281
1282 2019-04-11  Michael Saboff  <msaboff@apple.com>
1283
1284         Improve the Inline Cache Stats code
1285         https://bugs.webkit.org/show_bug.cgi?id=196836
1286
1287         Reviewed by Saam Barati.
1288
1289         Added a new script to consolidate and arrange the output of --useICStats option.
1290
1291         This script merges the output from every group into one large table and sorts it from most common to
1292         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1293         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1294         Put together, this is useful to see what property accesses are not getting cached.
1295
1296         * Scripts/ic-stats.py: Added.
1297         (ICStats):
1298         (ICStats.__init__):
1299         (ICStats.parse):
1300         (ICStats.dumpStats):
1301         (usage):
1302
1303 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1304
1305         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1306         https://bugs.webkit.org/show_bug.cgi?id=196809
1307         <rdar://49800762>
1308
1309         Reviewed by Brady Eidson.
1310
1311         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1312         (TEST):
1313
1314 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1315
1316         requestAnimationFrame should execute before the next frame
1317         https://bugs.webkit.org/show_bug.cgi?id=177484
1318
1319         Reviewed by Simon Fraser.
1320
1321         Add trace points for the page RenderingUpdate.
1322
1323         * Tracing/SystemTracePoints.plist:
1324
1325 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1326
1327         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1328         https://bugs.webkit.org/show_bug.cgi?id=196760
1329
1330         Reviewed by Don Olmstead.
1331
1332         vswhere.exe has been bundled since Visual Studio 2017 version
1333         15.2. We shouldn't download vswhere.exe.
1334
1335         * Scripts/build-jsc: Do not call update-vswhere.py.
1336         * Scripts/build-webkit: Ditto.
1337         * Scripts/update-vswhere.py: Removed.
1338         * Scripts/webkitdirs.pm:
1339         (requireModulesForVSWhere): Deleted.
1340         (pickCurrentVisualStudioInstallation): Deleted.
1341         (visualStudioInstallDirVSWhere): Return the latest installed VS
1342         installation path by using the bundled vswhere.exe.
1343         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1344         (visualStudioInstallDirFallback): Removed.
1345
1346 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1347
1348         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1349         https://bugs.webkit.org/show_bug.cgi?id=196780
1350
1351         Reviewed by Alexey Proskuryakov.
1352
1353         * BuildSlaveSupport/ews-build/steps.py:
1354         * BuildSlaveSupport/ews-build/steps_unittest.py:
1355
1356 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1357
1358         Add SPI WKNavigationResponse._downloadAttribute
1359         https://bugs.webkit.org/show_bug.cgi?id=196755
1360         <rdar://49587365>
1361
1362         Reviewed by Brady Eidson.
1363
1364         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1365         (-[NavigationResponseTestDelegate navigationResponse]):
1366         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1367         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1368         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1369         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1370         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1371         (readRequest):
1372         (writeResponse):
1373         (TEST):
1374
1375 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1376
1377         Add modern API for overriding the page's specified viewport configuration
1378         https://bugs.webkit.org/show_bug.cgi?id=167734
1379         <rdar://problem/30331795>
1380
1381         Reviewed by Simon Fraser.
1382
1383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1384         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1385
1386 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1387
1388         Add support for incremental bytecode cache updates
1389         https://bugs.webkit.org/show_bug.cgi?id=195000
1390
1391         Reviewed by Filip Pizlo.
1392
1393         Exit when the initial run to generate bytecode fails.
1394
1395         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1396
1397 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1398
1399         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1400         https://bugs.webkit.org/show_bug.cgi?id=196744
1401         <rdar://49415309>
1402
1403         Reviewed by Chris Dumez.
1404
1405         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1406         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1407
1408 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1409
1410         Add a way to opt into modern compatibility mode in layout tests
1411         https://bugs.webkit.org/show_bug.cgi?id=196770
1412         <rdar://problem/49777550>
1413
1414         Reviewed by Antoine Quint.
1415
1416         Add a new test option to enable modern compatibility mode in layout tests.
1417
1418         * WebKitTestRunner/TestController.cpp:
1419         (WTR::updateTestOptionsFromTestHeader):
1420         * WebKitTestRunner/TestController.h:
1421         * WebKitTestRunner/TestOptions.h:
1422         (WTR::TestOptions::hasSameInitializationOptions const):
1423         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1424         (WTR::TestController::platformCreateWebView):
1425         (WTR::TestController::enableModernCompatibilityMode):
1426
1427 2019-04-10  Andy Estes  <aestes@apple.com>
1428
1429         Try to fix the 32-bit watchOS build.
1430
1431         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1432         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1433
1434 2019-04-10  Antoine Quint  <graouts@apple.com>
1435
1436         Enable Pointer Events on watchOS
1437         https://bugs.webkit.org/show_bug.cgi?id=196771
1438         <rdar://problem/49040909>
1439
1440         Reviewed by Dean Jackson.
1441
1442         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1443
1444 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1445
1446         Unreviewed. Fix WPE accessibility tests after r244059.
1447
1448         We are failing to load the injected bundle due to undefined symbol
1449         AccessibilityUIElement::replaceTextInRange().
1450
1451         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1452         (WTR::AccessibilityUIElement::replaceTextInRange):
1453
1454 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1455
1456         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1457         https://bugs.webkit.org/show_bug.cgi?id=196727
1458
1459         Reviewed by Fujii Hironori.
1460
1461         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1462         (WebKitBrowserWindow::create):
1463
1464 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1465
1466         [ews-build] Add unit tests for PrintConfiguration
1467         https://bugs.webkit.org/show_bug.cgi?id=196752
1468
1469         Reviewed by Dewei Zhu.
1470
1471         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1472
1473 2019-04-09  Keith Rollin  <krollin@apple.com>
1474
1475         Unreviewed build maintenance -- update .xcfilelists.
1476
1477         * DumpRenderTree/DerivedSources-input.xcfilelist:
1478         * DumpRenderTree/DerivedSources-output.xcfilelist:
1479
1480 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1481
1482         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1483         https://bugs.webkit.org/show_bug.cgi?id=196743
1484         <rdar://problem/43897551>
1485
1486         Reviewed by Tim Horton.
1487
1488         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1489         (TEST):
1490
1491 2019-04-09  Youenn Fablet  <youenn@apple.com>
1492
1493         Close service worker database on network process suspension
1494         https://bugs.webkit.org/show_bug.cgi?id=196623
1495         <rdar://problem/48930869>
1496
1497         Reviewed by Alex Christensen.
1498
1499         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1500
1501 2019-04-09  Daniel Bates  <dabates@apple.com>
1502
1503         [iPad] Should open popover when the spacebar is pressed
1504         https://bugs.webkit.org/show_bug.cgi?id=196360
1505         <rdar://problem/49389129>
1506
1507         Reviewed by Brent Fulgham.
1508
1509         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1510
1511         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1512         (WTR::UIScriptController::isShowingPopover const): Added.
1513         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1514         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1515         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1516         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1517         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1518         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1519         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1520         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1521         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1522         (WTR::UIScriptController::isShowingPopover const): Added.
1523         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1524         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1525         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1526         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1527         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1528         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1529         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1530         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1531         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1532         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1533         (WTR::UIScriptController::isShowingPopover const): Added.
1534         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1535         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1536
1537 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1538
1539         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1540         https://bugs.webkit.org/show_bug.cgi?id=196665
1541         <rdar://45115669>
1542
1543         Reviewed by Geoff Garen.
1544
1545         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1546         (goBack):
1547         (+[SimpleLookupContext sharedLookupContext]):
1548         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1549         (TEST):
1550         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1551         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1552
1553 2019-04-09  John Wilander  <wilander@apple.com>
1554
1555         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1556         https://bugs.webkit.org/show_bug.cgi?id=196558
1557         <rdar://problem/47650245>
1558
1559         Reviewed by Youenn Fablet.
1560
1561         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1562         (TestWebKitAPI::TEST):
1563             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1564
1565 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1566
1567         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1568         https://bugs.webkit.org/show_bug.cgi?id=196720
1569
1570         Reviewed by Konstantin Tokarev.
1571
1572         * TestWebKitAPI/PlatformMac.cmake:
1573
1574 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1575
1576         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1577         https://bugs.webkit.org/show_bug.cgi?id=196694
1578         <rdar://problem/48388734>
1579
1580         Rubber-stamped by Aakash Jain.
1581
1582         * Scripts/webkitpy/port/image_diff.py:
1583         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1584         * Scripts/webkitpy/port/server_process.py:
1585         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1586         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1587         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1588         * Scripts/webkitpy/port/server_process_mock.py:
1589         (MockServerProcess.has_available_stdout):
1590         * Scripts/webkitpy/port/server_process_unittest.py:
1591         (TestServerProcess.serial_test_basic):
1592
1593 2019-04-09  Jer Noble  <jer.noble@apple.com>
1594
1595         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1596         https://bugs.webkit.org/show_bug.cgi?id=196097
1597
1598         Reviewed by Eric Carlson.
1599
1600         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1601
1602         * DumpRenderTree/mac/DumpRenderTree.mm:
1603         (resetWebPreferencesToConsistentValues):
1604         * WebKitTestRunner/TestController.cpp:
1605         (WTR::TestController::resetPreferencesToConsistentValues):
1606
1607 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1608
1609         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1610         https://bugs.webkit.org/show_bug.cgi?id=196690
1611
1612         Reviewed by Michael Catanzaro.
1613
1614         * QueueStatusServer/config/queues.py:
1615         * Scripts/webkitpy/common/config/ews.json:
1616         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1617         (test_ews_name):
1618
1619 2019-04-09  Chris Dumez  <cdumez@apple.com>
1620
1621         Loads using loadHTMLString() cause flashing when process-swapping
1622         https://bugs.webkit.org/show_bug.cgi?id=196714
1623         <rdar://problem/49637354>
1624
1625         Reviewed by Antti Koivisto.
1626
1627         Add API test coverage.
1628
1629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1630
1631 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1632
1633         Unreviewed. Fix ATK accessibility tests after r244059.
1634
1635         We are failing to load the injected bundle due to undefined symbol
1636         AccessibilityUIElement::replaceTextInRange().
1637
1638         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1639         (WTR::AccessibilityUIElement::replaceTextInRange):
1640
1641 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1642
1643         AX: Support API: accessibilityReplaceRange:withText
1644         https://bugs.webkit.org/show_bug.cgi?id=196636
1645
1646         Unreviewed build fix for Windows port.
1647
1648         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1649         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1650
1651 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1652
1653         [CMake][WinCairo] Separate copied headers into different directories
1654         https://bugs.webkit.org/show_bug.cgi?id=196655
1655
1656         Reviewed by Michael Catanzaro.
1657
1658         * DumpRenderTree/CMakeLists.txt:
1659         * MiniBrowser/win/CMakeLists.txt:
1660         * TestWebKitAPI/CMakeLists.txt:
1661         * TestWebKitAPI/PlatformWin.cmake:
1662
1663 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1664
1665         Log stack-trace for run-webkit-tests when interrupted
1666         https://bugs.webkit.org/show_bug.cgi?id=176393
1667         <rdar://problem/34262310>
1668
1669         Reviewed by Lucas Forschler.
1670
1671         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1672         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1673         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1674         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1675         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1676         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1677         (main): Set handlers to log stack trace on interruption.
1678
1679 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1680
1681         AX: Support API: accessibilityReplaceRange:withText
1682         https://bugs.webkit.org/show_bug.cgi?id=196636
1683
1684         Unreviewed build fix for Windows port.
1685
1686         * DumpRenderTree/AccessibilityUIElement.cpp:
1687         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1688
1689 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1690
1691         [ews-build] Scripts using Buildbot API have CORS error
1692         https://bugs.webkit.org/show_bug.cgi?id=196709
1693
1694         Reviewed by Alexey Proskuryakov.
1695
1696         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1697
1698 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1699
1700         AX: Support API: accessibilityReplaceRange:withText
1701         https://bugs.webkit.org/show_bug.cgi?id=196636
1702
1703         Reviewed by Daniel Bates.
1704
1705         * DumpRenderTree/AccessibilityUIElement.cpp:
1706         (replaceTextInRangeCallback):
1707         (AccessibilityUIElement::replaceTextInRange):
1708         (AccessibilityUIElement::getJSClass):
1709         * DumpRenderTree/AccessibilityUIElement.h:
1710         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1711         (AccessibilityUIElement::replaceTextInRange):
1712         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1713         (AccessibilityUIElement::replaceTextInRange):
1714         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1715         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1716         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1717         (WTR::AccessibilityUIElement::replaceTextInRange):
1718         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1719         (WTR::AccessibilityUIElement::replaceTextInRange):
1720
1721 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1722
1723         [iOS] Do not allow starting selection drags when selection views are not visible
1724         https://bugs.webkit.org/show_bug.cgi?id=196686
1725         <rdar://problem/49399192>
1726
1727         Reviewed by Tim Horton.
1728
1729         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1730         also add some new API tests to cover scenarios where the web view is not first responder.
1731
1732         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1733         (TestWebKitAPI::TEST):
1734         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1735
1736         Add a switch to optionally make the web view first responder when starting the simulated drag.
1737
1738         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1739         (-[DragAndDropSimulator initWithWebView:]):
1740         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1741
1742 2019-04-08  Justin Fan  <justin_fan@apple.com>
1743
1744         [Web GPU] Fix Web GPU experimental feature on iOS
1745         https://bugs.webkit.org/show_bug.cgi?id=196632
1746
1747         Reviewed by Myles C. Maxfield.
1748
1749         Properly make Web GPU available on iOS 11+.
1750
1751         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1752
1753 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1754
1755         [ews-build] Do not upload archive when Compile Fails
1756         https://bugs.webkit.org/show_bug.cgi?id=196674
1757
1758         Reviewed by Alexey Proskuryakov.
1759
1760         * BuildSlaveSupport/ews-build/factories.py:
1761         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1762         * BuildSlaveSupport/ews-build/steps.py:
1763         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1764         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1765         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1766
1767 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1768
1769         Enable DFG on MIPS
1770         https://bugs.webkit.org/show_bug.cgi?id=196689
1771
1772         Reviewed by Žan Doberšek.
1773
1774         Since the bytecode change, we enabled the baseline JIT on mips in
1775         r240432, but DFG is still missing. With this change, all tests are
1776         passing on a ci20 board.
1777
1778         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1779
1780 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1781
1782         [Flatpak] Second run update-webkitwpe-flatpak fails
1783         https://bugs.webkit.org/show_bug.cgi?id=192702
1784
1785         Reviewed by Carlos Garcia Campos.
1786
1787         * flatpak/flatpakutils.py:
1788         (FlatpakObject.flatpak): Fix typo.
1789         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1790         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1791
1792 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1793
1794         [GTK][WPE] outlook.live.com displays old-fashioned UI
1795         https://bugs.webkit.org/show_bug.cgi?id=196642
1796
1797         Reviewed by Carlos Garcia Campos.
1798
1799         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1800         (TestWebKitAPI::TEST): New Mac platform quirk test.
1801
1802 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1803
1804         Unreviewed, rolling out r243956.
1805         https://bugs.webkit.org/show_bug.cgi?id=196688
1806
1807         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1808         by aakashjain on #webkit).
1809
1810         Reverted changeset:
1811
1812         "Clicking "Go Back" from a safe browsing warning from an
1813         iframe should navigate the WKWebView back to the previous
1814         page"
1815         https://bugs.webkit.org/show_bug.cgi?id=196665
1816         https://trac.webkit.org/changeset/243956
1817
1818 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1819
1820         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1821         https://bugs.webkit.org/show_bug.cgi?id=196669
1822
1823         Reviewed by Geoffrey Garen.
1824
1825         Added three new unit tests for WeakHashSet.
1826
1827         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1828         (WTF_WeakPtr.WeakHashSetConstObjects):
1829         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1830         (WTF_WeakPtr.WeakHashSetComputeSize):
1831
1832 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1833
1834         Hide next and previous form control buttons when WKWebView is editable
1835         https://bugs.webkit.org/show_bug.cgi?id=196672
1836         <rdar://problem/35625321>
1837
1838         Reviewed by Tim Horton.
1839
1840         Add a new API test.
1841
1842         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1843         (-[TestWKWebView lastTrailingBarButtonGroup]):
1844         (TestWebKitAPI::TEST):
1845         * TestWebKitAPI/ios/UIKitSPI.h:
1846
1847 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1848
1849         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1850         https://bugs.webkit.org/show_bug.cgi?id=196077
1851         <rdar://problem/49108202>
1852
1853         Reviewed by Chris Dumez.
1854
1855         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1856         on new web view.
1857
1858         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1859
1860 2019-04-05  Saam Barati  <sbarati@apple.com>
1861
1862         Make compare-results understand MotionMark
1863         https://bugs.webkit.org/show_bug.cgi?id=196666
1864
1865         Reviewed by Yusuke Suzuki.
1866
1867         * Scripts/compare-results:
1868         (PLT5Results):
1869         (detectMotionMark):
1870         (detectMotionMark1_1):
1871         (motionMarkResults):
1872         (motionMark1_1Results):
1873         (detectBenchmark):
1874         (biggerIsBetter):
1875         (main):
1876
1877 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1878
1879         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1880         https://bugs.webkit.org/show_bug.cgi?id=196665
1881         <rdar://45115669>
1882
1883         Reviewed by Geoff Garen.
1884
1885         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1886         (goBack):
1887         (+[SimpleLookupContext sharedLookupContext]):
1888         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1889         (TEST):
1890         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1891         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1892
1893 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1894
1895         [ews-build] Add configuration and architecture for windows builders
1896         https://bugs.webkit.org/show_bug.cgi?id=196660
1897
1898         Reviewed by Lucas Forschler.
1899
1900         * BuildSlaveSupport/ews-build/config.json:
1901
1902 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1903
1904         webkitpy: Don't run subsequent rounds if interrupted
1905         https://bugs.webkit.org/show_bug.cgi?id=196646
1906
1907         Reviewed by Aakash Jain.
1908
1909         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1910         (Manager.run): Bail out if interrupted.
1911
1912 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1913
1914         Test sessionStorage in PSON private browsing mode
1915         https://bugs.webkit.org/show_bug.cgi?id=196561
1916
1917         Reviewed by Alex Christensen.
1918
1919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1920
1921 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1922
1923         Unreviewed, rolling out r243833.
1924         https://bugs.webkit.org/show_bug.cgi?id=196645
1925
1926         This change breaks build of WPE and GTK ports (Requested by
1927         annulen on #webkit).
1928
1929         Reverted changeset:
1930
1931         "[CMake][WTF] Mirror XCode header directories"
1932         https://bugs.webkit.org/show_bug.cgi?id=191662
1933         https://trac.webkit.org/changeset/243833
1934
1935 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1936
1937         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1938         https://bugs.webkit.org/show_bug.cgi?id=196635
1939
1940         Reviewed by Antti Koivisto.
1941         
1942         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1943         for a test to enable async frame scrolling via:
1944             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1945         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1946         
1947         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1948
1949         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1950         (WTR::InjectedBundle::beginTesting):
1951         * WebKitTestRunner/TestController.cpp:
1952         (WTR::TestController::resetPreferencesToConsistentValues):
1953
1954 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1955
1956         Use a correct LC_RPATH when building with ASan
1957         https://bugs.webkit.org/show_bug.cgi?id=196576
1958
1959         Reviewed by David Kilzer.
1960
1961         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1962         so that ../Frameworks is checked. This is simpler and more reliable than updating
1963         each SPC service xcconfig.
1964
1965 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1966
1967         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1968         https://bugs.webkit.org/show_bug.cgi?id=196629
1969
1970         Reviewed by Lucas Forschler.
1971
1972         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1973
1974 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1975
1976         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1977         https://bugs.webkit.org/show_bug.cgi?id=196618
1978
1979         Reviewed by Lucas Forschler.
1980
1981         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1982         (StatusBubble): Added QUEUE_TRIGGERS.
1983         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1984         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1985         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1986         its parent(builder).
1987
1988 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1989
1990         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1991         https://bugs.webkit.org/show_bug.cgi?id=196625
1992
1993         Reviewed by Lucas Forschler.
1994
1995         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1996         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1997
1998 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1999
2000         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2001         https://bugs.webkit.org/show_bug.cgi?id=196630
2002
2003         Reviewed by Wenson Hsieh.
2004
2005         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2006
2007 2019-04-04  Youenn Fablet  <youenn@apple.com>
2008
2009         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2010         https://bugs.webkit.org/show_bug.cgi?id=196543
2011
2012         Reviewed by Alex Christensen.
2013
2014         * WebKitTestRunner/TestController.cpp:
2015         (WTR::TestController::generatePageConfiguration):
2016
2017 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2018
2019         [ews-app] Status bubble should not display skipped buildbot steps
2020         https://bugs.webkit.org/show_bug.cgi?id=196584
2021
2022         Reviewed by Lucas Forschler.
2023
2024         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2025
2026 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2027
2028         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2029         https://bugs.webkit.org/show_bug.cgi?id=196620
2030
2031         Reviewed by Lucas Forschler.
2032
2033         * BuildSlaveSupport/ews-app/ews/config.py:
2034
2035 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2036
2037         [Win] DumpRenderTreeWatchDog.py is not checked into source
2038         https://bugs.webkit.org/show_bug.cgi?id=196567
2039         <rdar://problem/49525901>
2040
2041         Reviewed by Lucas Forschler.
2042
2043         This script is used on Win EWS bots to terminate hanging DRT processes.
2044
2045         * EWSTools/dumprendertreewatchdog.py: Added.
2046
2047 2019-04-04  Chris Dumez  <cdumez@apple.com>
2048
2049         Unreviewed, roll out r243858 which made tests time out.
2050
2051         Disable new API tests on Windows instead.
2052
2053         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2054         (TestWebKitAPI::TEST):
2055
2056 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2057
2058         [ATK] Cleanup WebPageAccessibilityObjectAtk
2059         https://bugs.webkit.org/show_bug.cgi?id=196537
2060
2061         Reviewed by Michael Catanzaro.
2062
2063         Also consider files under atk directories as exceptions for GObject conventions.
2064
2065         * Scripts/webkitpy/style/checkers/cpp.py:
2066         (check_identifier_name_in_declaration):
2067
2068 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2069
2070         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2071         https://bugs.webkit.org/show_bug.cgi?id=196588
2072         <rdar://problem/49365787>
2073
2074         Unreviewed build fix for Windows port.
2075
2076         error C3861: 'kill': identifier not found
2077
2078         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2079         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2080
2081 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2082
2083         [ews-build] Cancel build and similar operations should have authentication
2084         https://bugs.webkit.org/show_bug.cgi?id=196520
2085
2086         Reviewed by Dewei Zhu.
2087
2088         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2089         environment variables.
2090
2091 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2092
2093         [ews-build] Do not trigger queues which are not in production yet
2094         https://bugs.webkit.org/show_bug.cgi?id=196581
2095
2096         Reviewed by Dewei Zhu.
2097
2098         * BuildSlaveSupport/ews-build/config.json:
2099
2100 2019-04-03  Chris Dumez  <cdumez@apple.com>
2101
2102         Unreviewed, fix typo in the name of API test added in r243848.
2103
2104         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2105         (TestWebKitAPI::TEST):
2106
2107 2019-04-03  Chris Dumez  <cdumez@apple.com>
2108
2109         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2110         https://bugs.webkit.org/show_bug.cgi?id=196588
2111         <rdar://problem/49365787>
2112
2113         Reviewed by Ryosuke Niwa.
2114
2115         Add API test coverage.
2116
2117         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2118         (TestWebKitAPI::nullJavaScriptCallback):
2119         (TestWebKitAPI::didCrashCheckFrames):
2120         (TestWebKitAPI::TEST):
2121
2122 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2123
2124         run-webkit-tests: Upload test results (new results database)
2125         https://bugs.webkit.org/show_bug.cgi?id=196577
2126         <rdar://problem/34841155>
2127
2128         Reviewed by Lucas Forschler.
2129
2130         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2131         (Manager.run): Upload results after each device shard, since the configuration will be
2132         different for each device.
2133         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2134         uploaded to a results database.
2135         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2136         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2137
2138 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2139
2140         -apple-trailing-word is needed for browser detection
2141         https://bugs.webkit.org/show_bug.cgi?id=196575
2142
2143         Unreviewed.
2144
2145         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2146
2147 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2148
2149         [CMake][WTF] Mirror XCode header directories
2150         https://bugs.webkit.org/show_bug.cgi?id=191662
2151
2152         Reviewed by Konstantin Tokarev.
2153
2154         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2155         builds.
2156
2157         * CMakeLists.txt:
2158         * DumpRenderTree/CMakeLists.txt:
2159         * DumpRenderTree/PlatformWin.cmake:
2160         * MiniBrowser/win/CMakeLists.txt:
2161         * TestWebKitAPI/CMakeLists.txt:
2162         * TestWebKitAPI/PlatformWin.cmake:
2163         * WebKitTestRunner/PlatformGTK.cmake:
2164         * WebKitTestRunner/PlatformWin.cmake:
2165
2166 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2167
2168         [ews-app] Status bubble should not display certain infrastructure status messages
2169         https://bugs.webkit.org/show_bug.cgi?id=196550
2170
2171         Reviewed by Lucas Forschler.
2172
2173         Do not display the steps which are un-needed for end-user. This information is still avaiable
2174         if the user click on the bubble and look at the Buildbot build.
2175         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2176         (StatusBubble._steps_messages):
2177         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2178
2179 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2180
2181         [ews-build] Use https for sending data to ews-app
2182         https://bugs.webkit.org/show_bug.cgi?id=196492
2183
2184         Reviewed by Lucas Forschler.
2185
2186         * BuildSlaveSupport/ews-build/events.py:
2187
2188 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2189
2190         Remove support for -apple-trailing-word
2191         https://bugs.webkit.org/show_bug.cgi?id=196525
2192
2193         Reviewed by Zalan Bujtas.
2194
2195         This CSS property is nonstandard and not used.
2196
2197         * Scripts/webkitperl/FeatureList.pm:
2198         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2199
2200 2019-04-03  Youenn Fablet  <youenn@apple.com>
2201
2202         Add a test for DOMCache on multiple browsing in case of private browsing
2203         https://bugs.webkit.org/show_bug.cgi?id=196524
2204
2205         Reviewed by Alex Christensen.
2206
2207         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2208         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2209
2210 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2211
2212         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2213         https://bugs.webkit.org/show_bug.cgi?id=196540
2214
2215         Reviewed by Aakash Jain.
2216
2217         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2218
2219 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2220
2221         Add plumbing for a compatibility mode preference in WebKit
2222         https://bugs.webkit.org/show_bug.cgi?id=196005
2223
2224         Reviewed by Tim Horton.
2225
2226         Add new API tests.
2227
2228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2229         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2230
2231 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2232
2233         [WPE][GTK] Update libsrtp dependency package for Debian
2234         https://bugs.webkit.org/show_bug.cgi?id=196528
2235
2236         Reviewed by Frédéric Wang.
2237
2238         * gtk/install-dependencies:
2239         * wpe/install-dependencies:
2240
2241 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2242
2243         [WK2] Add support for Window's beforeprint / afterprint events
2244         https://bugs.webkit.org/show_bug.cgi?id=196478
2245         <rdar://problem/49535124>
2246
2247         Unreviewed build fix for MSVC.
2248
2249         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2250
2251         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2252
2253         * WebKitTestRunner/TestController.cpp:
2254         (WTR::printFrame): Use int and float literals.
2255
2256 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2257
2258         [ews-build] Reassign bots to queues
2259
2260         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2261
2262 2019-04-02  Chris Dumez  <cdumez@apple.com>
2263
2264         [WK2] Add support for Window's beforeprint / afterprint events
2265         https://bugs.webkit.org/show_bug.cgi?id=196478
2266
2267         Reviewed by Alex Christensen.
2268
2269         Add minimal implementation for printFrame in WebKitTestRunner.
2270
2271         * WebKitTestRunner/TestController.cpp:
2272         (WTR::printFrame):
2273         (WTR::TestController::createOtherPage):
2274         (WTR::TestController::createWebViewWithOptions):
2275
2276 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2277
2278         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2279         https://bugs.webkit.org/show_bug.cgi?id=196491
2280
2281         Reviewed by Lucas Forschler.
2282
2283         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2284
2285 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2286
2287         [ews-build] Configure buildbot try credentials in environment variables
2288         https://bugs.webkit.org/show_bug.cgi?id=196501
2289
2290         Reviewed by Lucas Forschler.
2291
2292         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2293         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2294         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2295
2296 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2297
2298         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2299         https://bugs.webkit.org/show_bug.cgi?id=196496
2300         <rdar://problem/49521634>
2301
2302         Reviewed by Chris Dumez.
2303
2304         Add new API tests (see WebKit ChangeLog for more detail).
2305
2306         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2307         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2308         (TEST):
2309
2310 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2311
2312         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2313         <https://webkit.org/b/196499>
2314
2315         Reviewed by Alexey Proskuryakov.
2316
2317         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2318         ENABLE_ADDRESS_SANITIZER.
2319
2320 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2321
2322         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2323         https://bugs.webkit.org/show_bug.cgi?id=182757
2324
2325         Reviewed by Don Olmstead.
2326
2327         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2328         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2329
2330 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2331
2332         run-api-tests: Upload test results
2333         https://bugs.webkit.org/show_bug.cgi?id=196323
2334         <rdar://problem/49356714>
2335
2336         Reviewed by Lucas Forschler.
2337
2338         * Scripts/webkitpy/api_tests/manager.py:
2339         (Manager):
2340         (Manager.run): Upload results to a results database.
2341         * Scripts/webkitpy/api_tests/run_api_tests.py:
2342         (parse_args): Add upload arguments.
2343         * Scripts/webkitpy/port/base.py:
2344         (Port):
2345         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2346         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2347         with commits from any other associated repositories.
2348         * Scripts/webkitpy/port/device.py:
2349         (Device):
2350         (Device.build_version): Access build_versoin of underlying platform device.
2351         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2352         (IOSSimulatorTest):
2353         (IOSSimulatorTest.test_configuration_for_upload):
2354         * Scripts/webkitpy/port/device_port.py:
2355         (DevicePort):
2356         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2357         the same as the machine uploading results.
2358         * Scripts/webkitpy/port/mac.py:
2359         (MacPort):
2360         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2361         * Scripts/webkitpy/port/mac_unittest.py:
2362         (MacTest):
2363         (MacTest.test_configuration_for_upload):
2364         * Scripts/webkitpy/xcode/simulated_device.py:
2365         (SimulatedDeviceManager._create_device_with_runtime):
2366         (SimulatedDevice.__init__): Create simulated device with a build_version.
2367         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2368         (test_existing_simulator):
2369
2370 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2371
2372         Remove extra newline characters (Follow-up fix to r243707)
2373
2374         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2375
2376 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2377
2378         [ews-app] Use API_KEY to accept results data
2379         https://bugs.webkit.org/show_bug.cgi?id=196461
2380
2381         Reviewed by Dewei Zhu.
2382
2383         * BuildSlaveSupport/ews-app/ews/views/results.py:
2384         (Results.post): Validate EWS_API_KEY before accepting any data.
2385         * BuildSlaveSupport/ews-build/events.py:
2386         (Events.sendData): Send EWS_API_KEY if available along with event data.
2387
2388 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2389
2390         Unable to copy and paste a PDF from Notes into Mail compose body
2391         https://bugs.webkit.org/show_bug.cgi?id=196442
2392         <rdar://problem/48573098>
2393
2394         Reviewed by Tim Horton.
2395
2396         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2397         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2398         to be specified on the item providers.
2399
2400         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2401         (TestWebKitAPI::mapItemForTesting):
2402         (TestWebKitAPI::contactItemForTesting):
2403
2404 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2405
2406         Make UIWKDocumentContext rects per-character instead of per-word
2407         https://bugs.webkit.org/show_bug.cgi?id=196459
2408
2409         Reviewed by Wenson Hsieh.
2410
2411         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2412         (TEST):
2413         Adjust test results due to switching to per-character rects.
2414
2415 2019-04-01  Chris Dumez  <cdumez@apple.com>
2416
2417         UIProcess crash when a prewarmed process is terminated
2418         https://bugs.webkit.org/show_bug.cgi?id=196451
2419         <rdar://problem/49245471>
2420
2421         Reviewed by Geoffrey Garen.
2422
2423         Add API test coverage.
2424
2425         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2426         (TEST):
2427
2428 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2429
2430         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2431         https://bugs.webkit.org/show_bug.cgi?id=196449
2432
2433         Reviewed by Lucas Forschler.
2434
2435         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2436         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2437         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2438         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2439
2440 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2441
2442         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2443         https://bugs.webkit.org/show_bug.cgi?id=196444
2444
2445         Reviewed by Lucas Forschler.
2446
2447         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2448
2449 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2450
2451         Add SPI to canonicalize NSURLs with WTF::URL
2452         https://bugs.webkit.org/show_bug.cgi?id=196415
2453         <rdar://problem/44980271>
2454
2455         Reviewed by Darin Adler.
2456
2457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2458         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2459         (TestWebKitAPI::TEST):
2460
2461 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2462
2463         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2464         https://bugs.webkit.org/show_bug.cgi?id=196441
2465
2466         Reviewed by Carlos Garcia Campos.
2467
2468         Don't cache the wpe_view_backend object that might not exist yet at the
2469         time of EventSenderProxy constructor invocation, but instead retrieve
2470         that object whenever it's required for event dispatching. This should
2471         avoid crashes in this constructor now that it's invoked before any
2472         PlatformWindow has been set up (as changed in r243496).
2473
2474         * WebKitTestRunner/EventSenderProxy.h:
2475         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2476         (WTR::viewBackend):
2477         (WTR::EventSenderProxy::EventSenderProxy):
2478         (WTR::EventSenderProxy::mouseDown):
2479         (WTR::EventSenderProxy::mouseUp):
2480         (WTR::EventSenderProxy::mouseMoveTo):
2481         (WTR::EventSenderProxy::mouseScrollBy):
2482         (WTR::EventSenderProxy::keyDown):
2483         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2484
2485 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2486
2487         [Win][WebKit] MiniBrowser should support high DPI display
2488         https://bugs.webkit.org/show_bug.cgi?id=196391
2489
2490         Reviewed by Alex Christensen.
2491
2492         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2493         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2494         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2495         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2496
2497 2019-03-31  Sam Weinig  <weinig@apple.com>
2498
2499         Remove more i386 specific configurations
2500         https://bugs.webkit.org/show_bug.cgi?id=196430
2501
2502         Reviewed by Alexey Proskuryakov.
2503
2504         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2505         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2506
2507 2019-03-31  Andy Estes  <aestes@apple.com>
2508
2509         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2510         https://bugs.webkit.org/show_bug.cgi?id=196433
2511         <rdar://problem/49293305>
2512
2513         Reviewed by Tim Horton.
2514
2515         Enhanced API test coverage to include all navigation response policy decisions in both
2516         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2517
2518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2519         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2520         (TestWebKitAPI::TEST):
2521         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2522         (readFile):
2523         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2524         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2525         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2526         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2527         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2528         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2529         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2530         (-[QuickLookDelegate _downloadDidStart:]):
2531         (-[QuickLookDelegate _download:didReceiveResponse:]):
2532         (-[QuickLookDelegate _download:didReceiveData:]):
2533         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2534         (-[QuickLookDelegate _downloadDidFinish:]):
2535         (-[QuickLookDelegate _download:didFailWithError:]):
2536         (-[QuickLookDelegate _downloadDidCancel:]):
2537         (-[QuickLookDelegate verifyDownload]):
2538         (runTest):
2539         (runTestDecideBeforeLoading):
2540         (runTestDecideAfterLoading):
2541         (TEST):
2542         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2543         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2544         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2545         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2546         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2547         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2548         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2549         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2550         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2551         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2552         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2553         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2554         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2555         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2556
2557 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2558
2559         [CMake] add testdfg as target with build-jsc
2560         https://bugs.webkit.org/show_bug.cgi?id=196393
2561
2562         Reviewed by Saam Barati.
2563
2564         Added testdfg as one of the targets to build when
2565         using CMake.
2566
2567         * Scripts/build-jsc:
2568
2569 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2570
2571         Delete WebMetal implementation in favor of WebGPU
2572         https://bugs.webkit.org/show_bug.cgi?id=195418
2573
2574         Reviewed by Dean Jackson.
2575
2576         * DumpRenderTree/mac/DumpRenderTree.mm:
2577         (enableExperimentalFeatures):
2578         (resetWebPreferencesToConsistentValues):
2579         * Scripts/webkitperl/FeatureList.pm:
2580         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2582         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2583         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2584         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2585         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2586         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2587         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2588         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2589         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2590         (WTR::InjectedBundle::beginTesting):
2591         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2592         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2593         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2594
2595 2019-03-29  Chris Dumez  <cdumez@apple.com>
2596
2597         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2598         https://bugs.webkit.org/show_bug.cgi?id=196405
2599         <rdar://problem/49428130>
2600
2601         Reviewed by Wenson Hsieh.
2602
2603         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2604         the popover presentation methods to be no-ops. Use this in the new test added in
2605         r243523 so that we do not swizzle those methods for all tests. This is needed because
2606         those WatchOS tests rely on the popover getting presented and interactive.
2607
2608         * WebKitTestRunner/TestController.cpp:
2609         (WTR::updateTestOptionsFromTestHeader):
2610         * WebKitTestRunner/TestController.h:
2611         * WebKitTestRunner/TestOptions.h:
2612         (WTR::TestOptions::hasSameInitializationOptions const):
2613         * WebKitTestRunner/ios/TestControllerIOS.mm:
2614         (WTR::TestController::platformInitialize):
2615         (WTR::TestController::platformResetStateToConsistentValues):
2616
2617 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2618
2619         [Curl] Add Server Trust Evaluation Support.
2620         https://bugs.webkit.org/show_bug.cgi?id=191646
2621
2622         Reviewed by Fujii Hironori.
2623
2624         Implemented MiniBrowser UI for asking if user trusts the server.
2625
2626         * MiniBrowser/win/Common.cpp:
2627         (askServerTrustEvaluation):
2628         (replaceString):
2629         * MiniBrowser/win/Common.h:
2630         * MiniBrowser/win/MiniBrowserLib.rc:
2631         * MiniBrowser/win/MiniBrowserLibResource.h:
2632         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2633         (createPEMString):
2634         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2635         (WebKitBrowserWindow::canTrustServerCertificate):
2636         * MiniBrowser/win/WebKitBrowserWindow.h:
2637
2638 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2639
2640         Implement ResizeObserver.
2641         https://bugs.webkit.org/show_bug.cgi?id=157743
2642
2643         Reviewed by Simon Fraser.
2644
2645         Support resizeObserverEnabled webPreferences.
2646
2647         * DumpRenderTree/TestOptions.cpp:
2648         (TestOptions::TestOptions):
2649         * DumpRenderTree/TestOptions.h:
2650         * DumpRenderTree/mac/DumpRenderTree.mm:
2651         (setWebPreferencesForTestOptions):
2652         * DumpRenderTree/win/DumpRenderTree.cpp:
2653         (enableExperimentalFeatures):
2654         * Scripts/webkitperl/FeatureList.pm:
2655         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2656
2657 2019-03-28  John Wilander  <wilander@apple.com>
2658
2659         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2660         https://bugs.webkit.org/show_bug.cgi?id=196281
2661         <rdar://problem/48938748>
2662
2663         Reviewed by Alex Christensen.
2664
2665         This patch adds the function isStatisticsHasLocalStorage() to the
2666         TestRunner. With it, the page can query the WebsiteDataStore in the
2667         UI process to make sure that it sees LocalStorage.
2668
2669         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2670         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2671         (WTR::TestRunner::isStatisticsHasLocalStorage):
2672         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2673         * WebKitTestRunner/TestController.cpp:
2674         (WTR::TestController::isStatisticsHasLocalStorage):
2675         * WebKitTestRunner/TestController.h:
2676         * WebKitTestRunner/TestInvocation.cpp:
2677         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2678
2679 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2680
2681         API::Data::createWithoutCopying should do a null check before calling CFRelease
2682         https://bugs.webkit.org/show_bug.cgi?id=196276
2683         <rdar://problem/48059859>
2684
2685         Reviewed by Alex Christensen.
2686
2687         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2688
2689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2690         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2691         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2692         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2693         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2694         (TestWebKitAPI::TEST):
2695
2696 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2697
2698         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2699         https://bugs.webkit.org/show_bug.cgi?id=186276
2700
2701         Reviewed by Carlos Garcia Campos.
2702
2703         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2704         (webViewLoadChanged):
2705         (testWebResourceGetDataError):
2706         (testWebResourceGetDataEmpty):
2707         (beforeAll):
2708         (webViewloadChanged): Deleted.
2709
2710 2019-03-27  Andy Estes  <aestes@apple.com>
2711
2712         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2713         https://bugs.webkit.org/show_bug.cgi?id=196317
2714
2715         Reviewed by Dan Bernstein.
2716
2717         package-root copies built products into a staging directory using ditto(1), which does not
2718         follow symbolic links as it traverses a directory. Now that the files in
2719         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2720         itself, these become broken links when ditto'd into the staging directory.
2721
2722         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2723
2724         * Scripts/package-root:
2725
2726 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2727
2728         [ews-app] Update display text of Submit for ews analysis
2729         https://bugs.webkit.org/show_bug.cgi?id=196309
2730
2731         Reviewed by Dewei Zhu.
2732
2733         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2734
2735 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2736
2737         run-webkit-tests should check for leaks in WebKit processes
2738         <https://webkit.org/b/193772>
2739         <rdar://problem/46526680>
2740
2741         Reviewed by Ryosuke Niwa.
2742
2743         This works by doing the following:
2744         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2745           The list of child processes are returned one per line:
2746           process.name: pid
2747         - Run the "#LIST CHILD PROCESSES" command just before the
2748           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2749           processes on the ServerProcess object.
2750         - When the `--leaks` switch is handled, run check_for_leaks() on
2751           each child process after the main test harness.
2752
2753         * DumpRenderTree/mac/DumpRenderTree.mm:
2754         (handleControlCommand):
2755         - Use strncmp() instead of strcmp().
2756         - Add support for handling "#LIST CHILD PROCESSES" command.
2757
2758         * Scripts/webkitpy/port/base.py:
2759         (Port.check_for_leaks):
2760         * Scripts/webkitpy/port/darwin.py:
2761         (DarwinPort.check_for_leaks):
2762         - Rename redundant 'process_pid' argument to 'process_id'.
2763
2764         * Scripts/webkitpy/port/driver.py:
2765         (Driver.do_post_tests_work):
2766         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2767           longer the only command this sends to WebKitTestRunner.
2768         - If the `--leaks` switch is present, send the
2769           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2770           result using Port.set_webkit_processes().
2771         (Driver._parse_child_processes_output):
2772         - Add helper method to parse list of child process names and
2773           process IDs returned from WebKitTestRunner.
2774
2775         * Scripts/webkitpy/port/ios_device.py:
2776         (IOSDevicePort.check_for_leaks):
2777         - Rename redundant 'process_pid' argument to 'process_id'.
2778
2779         * Scripts/webkitpy/port/leakdetector.py:
2780         (LeakDetector._parse_leaks_output):
2781         - Return early if there is no leaks_output.
2782         (LeakDetector.check_for_leaks):
2783         - Rename redundant 'process_pid' argument to 'process_id'.
2784
2785         * Scripts/webkitpy/port/server_process.py:
2786         (ServerProcess.__init__):
2787         (ServerProcess.child_processes):
2788         (ServerProcess.set_child_processes):
2789         - Add instance variable to Port to store list of child process
2790           names and process IDs returned from WebKitTestRunner.
2791         (ServerProcess._start):
2792         - Clear self._child_processes.
2793         (ServerProcess.stop):
2794         - If self._child_processes is set, call
2795           self._port.check_for_leaks() for each child process.
2796
2797         * Scripts/webkitpy/port/server_process_unittest.py:
2798         (TrivialMockPort.check_for_leaks):
2799         - Rename redundant 'process_pid' argument to 'process_id'.
2800
2801         * Scripts/webkitpy/port/simulator_process.py:
2802         (SimulatorProcess.stop):
2803         - If self._child_processes is set, call
2804           self._port.check_for_leaks() for each child process.
2805
2806         * Scripts/webkitpy/port/watch_device.py:
2807         (WatchDevicePort.check_for_leaks):
2808         - Rename redundant 'process_pid' argument to 'process_id'.
2809
2810         * WebKitTestRunner/TestController.cpp:
2811         (WTR::TestController::dumpResponse):
2812         - Extract method from findAndDumpWorldLeaks() so that it may be
2813           reused by findAndDumpWebKitProcessIdentifiers().
2814         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2815         - Add method to output process name and process ID of both the
2816           WebContent and Networking processes.
2817         (WTR::TestController::findAndDumpWorldLeaks):
2818         - Fix missing newline in output when there were no abandoned
2819           documents.
2820         - Call dumpResponse() for extracted code.
2821         (WTR::TestController::handleControlCommand):
2822         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2823         - Use strncmp() instead of strcmp().
2824         - Call findAndDumpWebKitProcessIdentifiers() when
2825           "#LIST CHILD PROCESSES" command is sent.
2826         * WebKitTestRunner/TestController.h:
2827         (WTR::TestController::dumpResponse):
2828         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2829         - Declare methods.
2830
2831 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2832
2833         Unreviewed. Add GLib API test cases after r243434.
2834
2835         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2836         (testWebViewActiveURI):
2837         (serverCallback):
2838         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2839         (sendRequestCallback):
2840
2841 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2842
2843         Geolocation request not complete when watch request was started in a different web process
2844         https://bugs.webkit.org/show_bug.cgi?id=195996
2845
2846         Reviewed by Alex Christensen.
2847
2848         Add a test case.
2849
2850         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2851         (TestWebKitAPI::runJavaScriptAlert):
2852         (TestWebKitAPI::TEST):
2853
2854 2019-03-26  Keith Rollin  <krollin@apple.com>
2855
2856         Update the way generate-xcfilelists returns strings from functions
2857         https://bugs.webkit.org/show_bug.cgi?id=195975
2858         <rdar://problem/49040807>
2859
2860         Reviewed by Dean Jackson.
2861
2862         There are places where generate-xcfilelists executes assignments with
2863         statements like:
2864
2865             FOO=$(some_function)
2866
2867         where "some_function" return a string by echoing it. E.g.
2868
2869             some_function()
2870             {
2871                 echo "Hello, World"
2872             }
2873
2874         This is a common idiom, but it has a problem if "some_function" needs
2875         to call "exit" in an attempt to halt the entire script right then and
2876         there. Since "some_function" is called inside of $(), it's being
2877         executed in a sub-shell. Calling exit in that sub-shell simply exits
2878         that shell; it doesn't not exit the outer shell in which the main part
2879         of the script is still running. As such, the main script keeps
2880         executing when the intent was for the script to halt.
2881
2882         The solution to this is to use a different idiom for returning
2883         strings. The one we now is to pass in the name of the variable to
2884         receive the string result:
2885
2886             some_function()
2887             {
2888                 variable_name=$1
2889                 eval $variable_name ="Hello, World"
2890             }
2891
2892         The call site now looks like
2893
2894             some_function FOO
2895
2896         Because there's no invocation of a sub-shell, some_function can now
2897         call "exit" if it wants to, and the entire script will exit at that
2898         point.
2899
2900         * Scripts/generate-xcfilelists:
2901
2902 2019-03-26  Chris Dumez  <cdumez@apple.com>
2903
2904         Add basic layout test coverage for File Picker on iOS
2905         https://bugs.webkit.org/show_bug.cgi?id=196265
2906
2907         Reviewed by Wenson Hsieh.
2908
2909         Add layout test infrastructure to test the file picker on iOS.
2910
2911         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2912         (WTR::UIScriptController::dismissFilePicker):
2913         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2914         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2915         (WTR::UIScriptController::dismissFilePicker):
2916         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2917         * WebKitTestRunner/TestController.cpp:
2918         (WTR::TestController::createWebViewWithOptions):
2919         (WTR::updateTestOptionsFromTestHeader):
2920         * WebKitTestRunner/TestOptions.h:
2921         (WTR::TestOptions::hasSameInitializationOptions const):
2922         * WebKitTestRunner/ios/TestControllerIOS.mm:
2923         (overridePresentViewController):
2924         (WTR::TestController::platformInitialize):
2925         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2926         (WTR::UIScriptController::dismissFilePicker):
2927
2928 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2929
2930         Implement async paste method on UIWKInteractionViewProtocol
2931         https://bugs.webkit.org/show_bug.cgi?id=196267
2932         <rdar://problem/49236346>
2933
2934         Reviewed by Tim Horton.
2935
2936         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2937         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2938         are now a part of all iOS 12 internal SDKs.
2939
2940         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2941
2942         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2943         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2944
2945         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2946         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2947         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2948         * TestWebKitAPI/ios/UIKitSPI.h:
2949
2950 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2951
2952         [ews-build] Use PostgreSQL for ews.webkit.org database
2953         https://bugs.webkit.org/show_bug.cgi?id=196270
2954
2955         Reviewed by Lucas Forschler.
2956
2957         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2958
2959 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2960
2961         [ews] Reset simctl states on reboot
2962         https://bugs.webkit.org/show_bug.cgi?id=196260
2963
2964         Rubber-stamped by Aakash Jain.
2965
2966         * EWSTools/start-queue-mac.sh:
2967
2968 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2969
2970         [ews-build] Use PostgreSQL for ews-build database
2971         https://bugs.webkit.org/show_bug.cgi?id=196229
2972
2973         Reviewed by Lucas Forschler.
2974
2975         * BuildSlaveSupport/ews-build/master.cfg:
2976
2977 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2978
2979         [ews-build] Get master_hostname dynamically in master.cfg
2980         https://bugs.webkit.org/show_bug.cgi?id=196255
2981
2982         Reviewed by Lucas Forschler.
2983
2984         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2985         send events data in test mode.
2986
2987 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2988
2989         [ews-app] Set db_constraint to False for Foreign Keys
2990         https://bugs.webkit.org/show_bug.cgi?id=196252
2991
2992         Reviewed by Lucas Forschler.
2993
2994         * BuildSlaveSupport/ews-app/ews/models/build.py:
2995         * BuildSlaveSupport/ews-app/ews/models/step.py:
2996
2997 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2998
2999         [ews-build] is_test_mode_enabled should default to True
3000         https://bugs.webkit.org/show_bug.cgi?id=196248
3001
3002         Reviewed by Lucas Forschler.
3003
3004         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3005
3006 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3007
3008         [ews-app] Add webkitperl to ENABLED_QUEUES
3009         https://bugs.webkit.org/show_bug.cgi?id=196253
3010
3011         Reviewed by Lucas Forschler.
3012
3013         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3014
3015 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3016
3017         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3018         https://bugs.webkit.org/show_bug.cgi?id=196211
3019         rdar://problem/49110552
3020
3021         Reviewed by Tim Horton.
3022
3023         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3024         Make sure that EventSenderProxy always exists when running tests. We used to create
3025         it when resetting before the first test, which is a bit too late.
3026
3027         * WebKitTestRunner/TestController.h:
3028         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3029         (WTR::TestController::platformCreateWebView):
3030         (WTR::TestController::platformCreateOtherPage):
3031         (WTR::TestController::finishCreatingPlatformWebView):
3032         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3033         (WTR::PlatformWebView::PlatformWebView):
3034         Moved some code that made NSWindow use NSEvent during web view creation. We may
3035         need to move more if some other case us found, but this is enough for now.
3036
3037 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3038
3039         Unreviewed. Fix typo in GLib geolocation API after r243285.
3040
3041         gelocation -> geolocation.
3042
3043         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
3044         (testGeolocationManagerWatchPosition):
3045
3046 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3047
3048         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3049         https://bugs.webkit.org/show_bug.cgi?id=196213
3050
3051         Reviewed by Geoff Garen.
3052
3053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3054         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3055         (credentialWithIdentityAndKeychainPath):
3056         (-[ChallengeDelegate webView:didFinishNavigation:]):
3057         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3058         (TestWebKitAPI::TEST):
3059
3060 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3061
3062         Expected shouldn't assume its contained types are copyable
3063         https://bugs.webkit.org/show_bug.cgi?id=195986
3064
3065         Reviewed by JF Bastien.
3066
3067         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3068         (TestWebKitAPI::NonCopyable::operator== const):
3069         (TestWebKitAPI::NonCopyable::operator!= const):
3070         (TestWebKitAPI::TEST):
3071
3072 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3073
3074         Remove some now-unnecessary dynamic class lookup
3075         https://bugs.webkit.org/show_bug.cgi?id=196237
3076
3077         Reviewed by Simon Fraser.
3078
3079         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3080         (makeRequest):
3081         (TEST):
3082
3083 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3084
3085         Unreviewed, rolling out r243450.
3086
3087         AppleWin and WinCairo port builds get broken.
3088
3089         Reverted changeset:
3090
3091         "Add test for fix of #196095"
3092         https://bugs.webkit.org/show_bug.cgi?id=196097
3093         https://trac.webkit.org/changeset/243450
3094
3095 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3096
3097         Unreviewed, rolling out r243465.
3098         https://bugs.webkit.org/show_bug.cgi?id=196226
3099
3100         the test doesn't build (Requested by thorton on #webkit).
3101
3102         Reverted changeset:
3103
3104         "Do not terminate the NetworkProcess if a third party
3105         application sends a NSCredential with a SecIdentityRef"
3106         https://bugs.webkit.org/show_bug.cgi?id=196213
3107         https://trac.webkit.org/changeset/243465
3108
3109 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3110
3111         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3112         https://bugs.webkit.org/show_bug.cgi?id=196213
3113
3114         Reviewed by Geoff Garen.
3115
3116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3117         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3118         (credentialWithIdentityAndKeychainPath):
3119         (-[ChallengeDelegate webView:didFinishNavigation:]):
3120         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3121         (TestWebKitAPI::TEST):
3122
3123 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3124
3125         [ews-build] Gracefully handle missing patch_id in events
3126         https://bugs.webkit.org/show_bug.cgi?id=196216
3127
3128         Reviewed by Lucas Forschler.
3129
3130         * BuildSlaveSupport/ews-build/events.py:
3131
3132 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3133
3134         [ews-build] use lz4 compression for improving buildbot performance
3135         https://bugs.webkit.org/show_bug.cgi?id=196155
3136
3137         Reviewed by Lucas Forschler.
3138
3139         * BuildSlaveSupport/ews-build/master.cfg:
3140
3141 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3142
3143         Pull some API testing helper methods out of TestWKWebView
3144         https://bugs.webkit.org/show_bug.cgi?id=196212
3145
3146         Reviewed by Tim Horton.
3147
3148         Refactor some more API testing utility methods, so that they can be used in
3149         tests that do not use TestWKWebView.
3150
3151         * TestWebKitAPI/cocoa/TestWKWebView.h:
3152         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3153         (-[WKWebView loadTestPageNamed:]):
3154         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3155         (-[WKWebView synchronouslyLoadHTMLString:]):
3156         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3157         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3158         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3159         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3160         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3161
3162 2019-03-25  Jer Noble  <jer.noble@apple.com>
3163
3164         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3165         https://bugs.webkit.org/show_bug.cgi?id=196097
3166
3167         Reviewed by Eric Carlson.
3168
3169         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3170
3171         * DumpRenderTree/mac/DumpRenderTree.mm:
3172         (resetWebPreferencesToConsistentValues):
3173         * WebKitTestRunner/TestController.cpp:
3174         (WTR::TestController::resetPreferencesToConsistentValues):
3175
3176 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3177
3178         Pull IPadUserInterfaceSwizzler out into a separate header file
3179         https://bugs.webkit.org/show_bug.cgi?id=196193
3180
3181         Reviewed by Anders Carlsson.
3182
3183         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3184         be used in other API tests.
3185
3186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3187         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3188         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3189         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3190         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3191         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3192         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3193
3194 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3195
3196         Remove NavigatorContentUtils in WebCore/Modules
3197         https://bugs.webkit.org/show_bug.cgi?id=196070
3198
3199         Reviewed by Alex Christensen.
3200
3201         NavigatorContentUtils was to support the custom scheme spec [1].
3202         However, in WebKit side, no port has supported the feature in
3203         WebKit layer after EFL port was removed. So there has been the
3204         only IDL implementation of the NavigatorContentUtils in WebCore.
3205         So we don't need to keep the implementation in WebCore anymore.
3206
3207         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3208
3209         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3210
3211 2019-03-24  Andy Estes  <aestes@apple.com>
3212
3213         [watchOS] Remove unused Proximity Networking code
3214         https://bugs.webkit.org/show_bug.cgi?id=196188
3215
3216         Reviewed by Tim Horton.
3217
3218         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3219         (TEST):
3220
3221 2019-03-23  Keith Miller  <keith_miller@apple.com>
3222
3223         Refactor clz/ctz and fix getLSBSet.
3224         https://bugs.webkit.org/show_bug.cgi?id=196162
3225
3226         Reviewed by Saam Barati.
3227
3228         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3229
3230         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3231         (TestWebKitAPI::TEST):
3232
3233 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3234
3235         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3236         https://bugs.webkit.org/show_bug.cgi?id=196143
3237
3238         Reviewed by Michael Catanzaro.
3239
3240         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3241         directories.
3242
3243         * Scripts/webkitpy/style/checkers/cpp.py:
3244         (check_identifier_name_in_declaration):
3245         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3246         (WebKitStyleTest.test_names):
3247
3248 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3249
3250         [Flatpak] Manifest expanding fails for qt WPE extension
3251         https://bugs.webkit.org/show_bug.cgi?id=196148
3252
3253         Reviewed by Alex Christensen.
3254
3255         * flatpak/flatpakutils.py:
3256         (expand_submodules_recurse): The last recurse manifest expand
3257         iteration might lead to a single module so take it into account
3258         and don't try to recurse further.
3259
3260 2019-03-22  Chris Dumez  <cdumez@apple.com>
3261
3262         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3263         https://bugs.webkit.org/show_bug.cgi?id=195348
3264         <rdar://problem/48622090>
3265
3266         Reviewed by Alex Christensen.
3267
3268         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3269         to NO when test.options().shouldIgnoreMetaViewport is false.
3270
3271         * WebKitTestRunner/ios/TestControllerIOS.mm:
3272         (WTR::TestController::platformConfigureViewForTest):
3273
3274 2019-03-22  Chris Dumez  <cdumez@apple.com>
3275
3276         Prewarmed processes should be usable with any website data store
3277         https://bugs.webkit.org/show_bug.cgi?id=196104
3278
3279         Reviewed by Alex Christensen.
3280
3281         Add API test coverage.
3282
3283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3284         (runInitialWarmedProcessUsedTest):
3285         (TEST):
3286
3287 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3288
3289         Back out local changes to Alex's Subversion working directory
3290
3291         They were accidentally committed.
3292
3293         * Scripts/webkitpy/common/system/abstractexecutive.py:
3294         (AbstractExecutive.wait_newest):
3295         * Scripts/webkitpy/common/system/executive.py:
3296         (Executive.running_pids):
3297         * Scripts/webkitpy/common/system/executive_mock.py:
3298         (MockExecutive.running_pids):
3299         * Scripts/webkitpy/common/system/executive_unittest.py:
3300         (ExecutiveTest.serial_test_running_pids):
3301         * Scripts/webkitpy/port/darwin.py:
3302         (DarwinPort.check_for_leaks):
3303         * Scripts/webkitpy/port/leakdetector.py:
3304         (LeakDetector.check_for_leaks):
3305         - This was the hack attached to Bug 193772.
3306
3307         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3308         (+[WebKitTestRunnerEvent mouseLocation]):
3309         - This works around a crash on an internal build.
3310
3311 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3312
3313         Fix the build after r243354
3314         https://bugs.webkit.org/show_bug.cgi?id=196138
3315         <rdar://problem/49145951>
3316
3317         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3318         (TEST):
3319         * TestWebKitAPI/ios/UIKitSPI.h:
3320
3321 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3322
3323         Adopt UIWKDocumentContext
3324         https://bugs.webkit.org/show_bug.cgi?id=196040
3325         <rdar://problem/48642440>
3326
3327         Reviewed by Ryosuke Niwa.
3328
3329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3330         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3331         (makeRequest):
3332         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3333         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3334         (applyStyle):
3335         (TEST):
3336         Add tests for UIWKDocumentContext.
3337
3338         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3339         (TEST):
3340         (recursiveFindWKContentView): Deleted.
3341         * TestWebKitAPI/cocoa/TestWKWebView.h:
3342         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3343         (recursiveFindWKContentView):
3344         (-[TestWKWebView wkContentView]):
3345         * TestWebKitAPI/ios/UIKitSPI.h:
3346         Share the WKContentView finding code between tests.
3347
3348 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3349
3350         [iOS WK2] Turn on async overflow scrolling by default
3351         https://bugs.webkit.org/show_bug.cgi?id=196011
3352         rdar://problem/48453859
3353
3354         Reviewed by Antti Koivisto.
3355         
3356         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3357         since so many basic layout tests have different results when compositing is triggered for
3358         overflow.
3359         
3360         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3361
3362         * WebKitTestRunner/TestController.cpp:
3363         (WTR::TestController::resetPreferencesToConsistentValues):
3364
3365 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3366
3367         [ews-build] Retry API test in case of failures
3368         https://bugs.webkit.org/show_bug.cgi?id=196004
3369
3370         Reviewed by Lucas Forschler.
3371
3372         * BuildSlaveSupport/ews-build/steps.py:
3373         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3374         (CompileWebKitToT.doStepIf): Ditto.
3375         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3376         (ReRunAPITests): Re-run API tests.
3377         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3378         (RunAPITestsWithoutPatch): Run API tests without patch.
3379         (RunAPITestsWithoutPatch.doStepIf):
3380         (RunAPITestsWithoutPatch.hideStepIf):
3381         (RunAPITestsWithoutPatch.evaluateCommand):
3382         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3383         (AnalyzeAPITestsResults.start):
3384         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3385         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3386         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3387         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3388
3389 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3390
3391         [ews-build] Update queues configurations
3392         https://bugs.webkit.org/show_bug.cgi?id=196074
3393
3394         Reviewed by Dewei Zhu.
3395
3396         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3397         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3398
3399 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3400
3401         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3402         https://bugs.webkit.org/show_bug.cgi?id=195680
3403         <rdar://problem/48903534>
3404
3405         Unreviewed infrastructure fix.
3406
3407         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3408         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3409
3410 2019-03-21  Andy Estes  <aestes@apple.com>
3411
3412         [iOS] Apple Pay should be available in documents with no user agent scripts
3413         https://bugs.webkit.org/show_bug.cgi?id=196061
3414         <rdar://problem/48649391>
3415
3416         Reviewed by Brady Eidson.
3417
3418         Added API tests and related infrastructure.
3419
3420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3421         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3422         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3423         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3424         (TestWebKitAPI::TEST):
3425         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3426         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3427         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3428         * TestWebKitAPI/cocoa/TestProtocol.mm:
3429         (-[TestProtocol startLoading]):
3430         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3431         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3432         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3433         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3434
3435 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3436
3437         REGRESSSION (r243297): webkitpy tests broken
3438         https://bugs.webkit.org/show_bug.cgi?id=196108
3439
3440         Reviewed by Aakash Jain.
3441
3442         r243297 updated contributors.json, which broke a few unit tests.
3443
3444         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3445         (IRCCommandTest.test_whois):
3446         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3447
3448 2019-03-21  Chris Dumez  <cdumez@apple.com>
3449
3450         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3451         https://bugs.webkit.org/show_bug.cgi?id=196041
3452         <rdar://problem/49083230>
3453
3454         Reviewed by Alex Christensen.
3455
3456         Add API test coverage.
3457
3458         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3459         (TEST):
3460
3461 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3462
3463         Add SPI to inform applications of WKContentRuleList actions
3464         https://bugs.webkit.org/show_bug.cgi?id=195965
3465         <rdar://problem/42664365>
3466
3467         Reviewed by Geoff Garen.
3468
3469         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3470         (TestWebKitAPI::allActionsForResourceLoad):
3471         (TestWebKitAPI::testRequest):
3472         (TestWebKitAPI::TEST_F):
3473         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3474         (Notification::description):
3475         (Notification::operator== const):
3476         (toVector):
3477         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3478         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3479         (makeContentRuleList):
3480         (TEST):
3481         (makeWarnContentRuleList): Deleted.
3482
3483 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3484
3485         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3486         https://bugs.webkit.org/show_bug.cgi?id=196088
3487
3488         Reviewed by Brian Burg.
3489
3490         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3491         Support checks when only one platform is specified. Also deprecate macosx() and
3492         force the use of macos() instead.
3493
3494         * Scripts/webkitpy/style/checkers/cpp.py:
3495         (check_min_versions_of_wk_api_available):
3496         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3497         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3498
3499 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3500
3501         Update status inactive committers' status to 'contributor'.
3502
3503         * Scripts/webkitpy/common/config/contributors.json:
3504
3505 2019-03-21  Xan Lopez  <xan@igalia.com>
3506
3507         [JSC][x86] Drop support for x87 floating point
3508         https://bugs.webkit.org/show_bug.cgi?id=194853
3509
3510         Reviewed by Don Olmstead.
3511
3512         Force SSE2 on x86/32bit builds.
3513
3514         * Scripts/webkitdirs.pm:
3515         (generateBuildSystemFromCMakeProject):
3516
3517 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3518
3519         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3520         https://bugs.webkit.org/show_bug.cgi?id=196073
3521
3522         Reviewed by Michael Catanzaro.
3523
3524         Add test cases to check functions and constructors with no arguments but receiving user data.
3525
3526         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3527         (checkUserData):
3528         (testJSCFunction):
3529         (fooCreateWithUserData):
3530         (testJSCClass):
3531
3532 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3533
3534         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3535
3536         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3537
3538         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3539
3540 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3541
3542         [GTK][WPE] Add API to provide geolocation information
3543         https://bugs.webkit.org/show_bug.cgi?id=195940
3544
3545         Reviewed by Michael Catanzaro.
3546
3547         Add a new test to check the new API.
3548
3549         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3550         (testGeolocationManagerCurrentPosition):
3551         (testGeolocationManagerWatchPosition):
3552         (beforeAll):
3553         (afterAll):
3554         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3555         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3556         (beforeAll): Ditto.
3557         * TestWebKitAPI/glib/CMakeLists.txt:
3558
3559 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3560
3561         [GLib] Returning G_TYPE_OBJECT from a method does not work
3562         https://bugs.webkit.org/show_bug.cgi?id=195574
3563
3564         Reviewed by Michael Catanzaro.
3565
3566         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3567
3568         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3569         (getGFile):
3570         (getParent):
3571         (createGString):
3572         (getGString):
3573         (getGStringCopyWillRaise):
3574         (getGStringCopy):
3575         (getGStringStr):
3576         (getGStringLen):
3577         (freeGString):
3578         (testJSCClass):
3579
3580 2019-03-20  Saam Barati  <sbarati@apple.com>
3581
3582         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3583         https://bugs.webkit.org/show_bug.cgi?id=195721
3584
3585         Reviewed by Filip Pizlo.
3586
3587         * Scripts/run-javascriptcore-tests:
3588
3589 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3590
3591         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3592         https://bugs.webkit.org/show_bug.cgi?id=196049
3593
3594         Reviewed by Tim Horton.
3595
3596         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3597         overflow scrolling in general, so rename it.
3598
3599         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3600
3601 2019-03-20  Daniel Bates  <dabates@apple.com>
3602
3603         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3604         https://bugs.webkit.org/show_bug.cgi?id=196031
3605         <rdar://problem/49078172>
3606
3607         Reviewed by Tim Horton.
3608
3609         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3610         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3611         same code path used when the Done button is pressed to dismiss the <select> picker.
3612
3613         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3614         (TestWebKitAPI::TEST):
3615
3616 2019-03-20  Chris Dumez  <cdumez@apple.com>
3617
3618         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3619         https://bugs.webkit.org/show_bug.cgi?id=196029
3620         <rdar://problem/48954651>
3621
3622         Reviewed by Tim Horton.
3623
3624         Add API test coverage.
3625
3626         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3627
3628 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3629
3630         [ews-build] Improve failure summary string for ApplyPatch step
3631         https://bugs.webkit.org/show_bug.cgi?id=195995
3632
3633         Reviewed by Alexey Proskuryakov.
3634
3635         * BuildSlaveSupport/ews-build/steps.py:
3636         (ApplyPatch.getResultSummary): Override getResultSummary.
3637
3638 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3639
3640         AX: Implement support for new meter ARIA role
3641         https://bugs.webkit.org/show_bug.cgi?id=195966
3642
3643         Reviewed by Chris Fleizach.
3644
3645         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3646         to AXLevelIndicator.
3647
3648         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3649
3650 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3651
3652         [WebAuthN] Implement FIDO AppID extension
3653         https://bugs.webkit.org/show_bug.cgi?id=143491
3654         <rdar://problem/48298273>
3655
3656         Reviewed by Brent Fulgham.
3657
3658         Add a test that covers the new flag of convertToU2fSignCommand.
3659
3660         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3661         (TestWebKitAPI::TEST):
3662         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3663         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3664         (TestWebKitAPI::TEST):
3665
3666 2019-03-19  Keith Rollin  <krollin@apple.com>
3667
3668         Add support for more platforms to generate-xcfilelists
3669         https://bugs.webkit.org/show_bug.cgi?id=195977
3670
3671         Reviewed by Alexey Proskuryakov.
3672
3673         generate-xcfilelists incorrectly complains when involved with building
3674         WebKit for iphonesimulator:
3675
3676             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3677             …
3678             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3679
3680         Address this by teaching generate-xcfilelists about more platforms.
3681
3682         * Scripts/generate-xcfilelists:
3683
3684 2019-03-19  John Wilander  <wilander@apple.com>
3685
3686         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3687         https://bugs.webkit.org/show_bug.cgi?id=195923
3688         <rdar://problem/49001272>
3689
3690         Reviewed by Alex Christensen.
3691
3692         This patch does the following to the TestRunner:
3693         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3694         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3695         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3696
3697         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3698         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3699         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3700         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3701         * WebKitTestRunner/TestController.cpp:
3702         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3703         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3704         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3705         * WebKitTestRunner/TestController.h:
3706         * WebKitTestRunner/TestInvocation.cpp:
3707         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3708
3709 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3710
3711         [CMake] Support more clang and gcc sanitizers
3712         https://bugs.webkit.org/show_bug.cgi?id=195956
3713
3714         Reviewed by Michael Catanzaro.
3715
3716         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3717
3718 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3719
3720         [ews-build] Improve summary for PrintConfiguration step
3721         https://bugs.webkit.org/show_bug.cgi?id=195945
3722
3723         Reviewed by Lucas Forschler.
3724
3725         * BuildSlaveSupport/ews-build/steps.py:
3726         (PrintConfiguration.getResultSummary): Override getResultSummary.
3727
3728 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3729
3730         [ews-build] Improve summary for CheckOutSource step
3731         https://bugs.webkit.org/show_bug.cgi?id=195963
3732
3733         Reviewed by Lucas Forschler.
3734
3735         * BuildSlaveSupport/ews-build/steps.py:
3736         (CheckOutSource.getResultSummary):
3737
3738 2019-03-19  Daniel Bates  <dabates@apple.com>
3739
3740         [iOS] Focus not preserved when switching between tabs
3741         https://bugs.webkit.org/show_bug.cgi?id=195820
3742         <rdar://problem/43614450>
3743
3744         Reviewed by Brent Fulgham.
3745
3746         Add tests to ensure that we restore focus when resigning and becoming first responder.
3747
3748         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3749         (TestWebKitAPI::TEST):
3750
3751 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3752
3753         Make WTFLogChannelState and WTFLogLevel enum classes
3754         https://bugs.webkit.org/show_bug.cgi?id=195904
3755
3756         Reviewed by Eric Carlson.
3757
3758         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3759         (TestWebKitAPI::TEST_F):
3760
3761 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3762
3763         [GStreamer][EME] Backported mssdemux protection data crash fix
3764         https://bugs.webkit.org/show_bug.cgi?id=195918
3765
3766         Reviewed by Philippe Normand.
3767
3768         * gstreamer/jhbuild.modules:
3769         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3770
3771 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3772
3773         Unreviewed, rolling out r243132.
3774
3775         Broke GTK build
3776
3777         Reverted changeset:
3778
3779         "Make WTFLogChannelState and WTFLogLevel enum classes"
3780         https://bugs.webkit.org/show_bug.cgi?id=195904
3781         https://trac.webkit.org/changeset/243132
3782
3783 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3784
3785         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3786
3787         * Scripts/webkitdirs.pm:
3788         (builtDylibPathForName): Adjust the shared library name that's changed
3789         with the API version bump in r243073.
3790
3791 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3792
3793         Make WTFLogChannelState and WTFLogLevel enum classes
3794         https://bugs.webkit.org/show_bug.cgi?id=195904
3795
3796         Reviewed by Eric Carlson.
3797
3798         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3799         (TestWebKitAPI::TEST_F):
3800
3801 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3802
3803         Disable flaky test added in r2431100
3804         https://webkit.org/b/195785
3805
3806         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3807         (TestWebKitAPI::TEST):
3808         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3809
3810 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3811
3812         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3813         https://bugs.webkit.org/show_bug.cgi?id=195916
3814
3815         Reviewed by Tim Horton.
3816
3817         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3818         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3819
3820 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3821
3822         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3823
3824         * Scripts/webkitpy/common/config/contributors.json:
3825
3826 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3827
3828         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3829         https://bugs.webkit.org/show_bug.cgi?id=195785
3830
3831         Reviewed by Geoffrey Garen.
3832
3833         * TestWebKitAPI/TCPServer.cpp: Added.
3834         (TestWebKitAPI::TCPServer::TCPServer):
3835         (TestWebKitAPI::TCPServer::~TCPServer):
3836         (TestWebKitAPI::TCPServer::socketBindListen):
3837         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3838         * TestWebKitAPI/TCPServer.h: Added.
3839         (TestWebKitAPI::TCPServer::port const):
3840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3841         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3842         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3843         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3844         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3845         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3846         (TestWebKitAPI::respondSlowly):
3847         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3848         (TestWebKitAPI::downloadAtRate):
3849         (TestWebKitAPI::TEST):
3850
3851 2019-03-18  Saam Barati  <sbarati@apple.com>
3852
3853         Add a plan file for JetStream 2
3854         https://bugs.webkit.org/show_bug.cgi?id=190734
3855
3856         Reviewed by Mark Lam.
3857
3858         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3859
3860 2019-03-18  Chris Dumez  <cdumez@apple.com>
3861
3862         Delay WebProcess launch until a load is triggered in a Web view
3863         https://bugs.webkit.org/show_bug.cgi?id=195758
3864         <rdar://problem/48126013>
3865
3866         Reviewed by Geoff Garen.
3867
3868         Add API test coverage. Also update some existing API tests to not expect
3869         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3870
3871         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3872         (TestWebKitAPI::TEST):
3873         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3874         (TestWebKitAPI::TEST):
3875         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3876         (TEST):
3877         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3878         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3879         (TEST):
3880         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3881         (TEST):
3882         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3883
3884 2019-03-18  Xan Lopez  <xan@igalia.com>
3885
3886         [CMake] Prevent potential warning when determining $architecture
3887         https://bugs.webkit.org/show_bug.cgi?id=195891
3888
3889         Reviewed by Michael Catanzaro.
3890
3891         It's possible for generateBuildSystemForCMakeProject to be called
3892         before determineArchitecture() is ever called. This will make the
3893         first eq check with $architecture to be bogus (and print a
3894         warning). Change that to an eq check with architecture(), which
3895         implicitly calls determineArchitecture() if needed, and change all
3896         the other similar cases in the method in the same way to prevent
3897         future bugs like this one.
3898
3899         * Scripts/webkitdirs.pm:
3900         (generateBuildSystemFromCMakeProject):
3901
3902 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3903
3904         [WPE] Tarballs generated with “make dist” cannot build documentation
3905         https://bugs.webkit.org/show_bug.cgi?id=195885
3906
3907         Reviewed by Carlos Garcia Campos.
3908
3909         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3910
3911 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3912
3913         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3914         https://bugs.webkit.org/show_bug.cgi?id=195883
3915
3916         Reviewed by Carlos Garcia Campos.
3917
3918         * gtkdoc/gtkdoc.py:
3919         (GTKDoc._run_command): When commands fail to run, include the full command line for
3920         the program invocation and the output it has generated on the standard error stream.
3921
3922 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3923
3924         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3925         https://bugs.webkit.org/show_bug.cgi?id=195786
3926
3927         Reviewed by Philippe Normand.
3928
3929         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3930         * wpe/jhbuild.modules: Ditto.
3931
3932 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3933
3934         [ews-build] Don't run clean builds on EWS builders
3935         https://bugs.webkit.org/show_bug.cgi?id=195851
3936
3937         Reviewed by Geoffrey Garen.
3938
3939         * BuildSlaveSupport/ews-build/factories.py:
3940
3941 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3942
3943         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3944         https://bugs.webkit.org/show_bug.cgi?id=195849
3945
3946         Reviewed by Chris Dumez.
3947
3948         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3949
3950         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3951         (runWebsiteDataStoreCustomPaths):
3952
3953 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3954
3955         webkitpy: Upload test results
3956         https://bugs.webkit.org/show_bug.cgi?id=195755
3957         <rdar://problem/48896182>
3958
3959         Reviewed by Aakash Jain.
3960
3961         Establish a new format for uploading results that is not tied to layout tests, apply
3962         that format to webkitpy tests.
3963
3964         * Scripts/webkitpy/common/checkout/scm/git.py:
3965         (Git.native_branch): Return what branch the current checkout is on.
3966         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3967         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3968         * Scripts/webkitpy/common/checkout/scm/svn.py:
3969         (SVN.native_branch): Ditto.
3970         * Scripts/webkitpy/common/system/platforminfo.py:
3971         (PlatformInfo.build_version): Return a build version for Mac.
3972         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3973         (MockPlatformInfo.__init__):
3974         (MockPlatformInfo.build_version):
3975         * Scripts/webkitpy/results: Added.
3976         * Scripts/webkitpy/results/__init__.py: Added.
3977         * Scripts/webkitpy/results/options.py: Added.
3978         (upload_options): OptParse list for upload options.
3979         * Scripts/webkitpy/results/upload.py: Added.
3980         (Upload): Class which enforces the upload format expected by the results server.
3981         (Upload.Expectations):
3982         (Upload.create_configuration):
3983         (Upload.create_commit):
3984         (Upload.create_details):
3985         (Upload.create_run_stats):
3986         (Upload.create_test_result):
3987         (Upload.__init__):
3988         (Upload.Encoder): Encode Upload object as json.
3989         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3990         * Scripts/webkitpy/results/upload_unittest.py: Added.
3991         * Scripts/webkitpy/test/main.py:
3992         (Tester._parse_args): Add upload arguments.
3993         (Tester._run_tests): Allow results to be uploaded.
3994         * Scripts/webkitpy/test/runner.py:
3995         (Runner.__init__): Record which tests were run, rather than just counting them.
3996         (Runner.handle):
3997         * Scripts/webkitpy/test/runner_unittest.py:
3998         (RunnerTest.test_run):
3999         * Scripts/webkitpy/thirdparty/__init__.py:
4000         (AutoinstallImportHook.find_module): Add requests auto-install.
4001         (AutoinstallImportHook._install_requests):
4002         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4003         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
4004
4005 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4006
4007         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
4008         https://bugs.webkit.org/show_bug.cgi?id=195810
4009
4010         Reviewed by Tim Horton.
4011
4012         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
4013         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
4014         ending certain layout tests.
4015
4016         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4017         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4018         (-[TestRunnerWKWebView dealloc]):
4019         (-[TestRunnerWKWebView resetInteractionCallbacks]):
4020
4021         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
4022         helper method when destroying the web view, and when resetting state between tests.
4023
4024         * WebKitTestRunner/ios/TestControllerIOS.mm:
4025         (WTR::TestController::platformResetStateToConsistentValues):
4026
4027         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
4028
4029 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
4030
4031         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
4032         https://bugs.webkit.org/show_bug.cgi?id=190350
4033         <rdar://problem/45089503>
4034
4035         Reviewed by Geoffrey Garen.
4036
4037         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4038         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
4039         (TEST):
4040         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
4041         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
4042         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
4043         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
4044         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
4045         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
4046         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
4047         (runTest):
4048         (createDirectories):
4049         (TEST):
4050         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
4051         (TEST):
4052         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
4053         (TEST):
4054
4055 2019-03-15  Timothy Hatcher  <timothy@apple.com>
4056
4057         Add support to WebPage for getting the contents as an attributed string.
4058         https://bugs.webkit.org/show_bug.cgi?id=195636
4059         rdar://problem/45055697
4060
4061         Reviewed by Tim Horton.
4062
4063         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
4064         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
4065
4066 2019-03-15  Chris Dumez  <cdumez@apple.com>
4067
4068         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4069         https://bugs.webkit.org/show_bug.cgi?id=195747
4070
4071         Reviewed by Geoff Garen.
4072
4073         Add API test coverage.
4074
4075         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4076
4077 2019-03-15  Shawn Roberts  <sroberts@apple.com>
4078
4079         Unreviewed, rolling out r242952.
4080
4081         Causing API failures on iOS Simulator
4082
4083         Reverted changeset:
4084
4085         "[PSON] Make sure the WebProcessCache is leverage when
4086         relaunching a process after termination"
4087         https://bugs.webkit.org/show_bug.cgi?id=195747
4088         https://trac.webkit.org/changeset/242952
4089
4090 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
4091
4092         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
4093         https://bugs.webkit.org/show_bug.cgi?id=195740
4094
4095         Reviewed by Ross Kirsling.
4096
4097         window.open doesn't work for WebKitBrowserWindow because it is not
4098         implemented yet.
4099
4100         1. Implemented createNewPage callback of WKPageUIClient.
4101         2. Changed MainWindow to take a BrowserWindow factory function
4102           instead of BrowserWindowType to be flexible to create
4103           BrowserWindow with extra settings.
4104         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
4105           because it is not relevant with MainWindow anymore.
4106
4107         * MiniBrowser/win/Common.cpp:
4108         (parseCommandLine):
4109         * MiniBrowser/win/Common.h:
4110         (CommandLineOptions::CommandLineOptions):
4111         * MiniBrowser/win/MainWindow.cpp:
4112         (MainWindow::MainWindow):
4113         (MainWindow::create):
4114         (MainWindow::init):
4115         (MainWindow::WndProc):
4116         * MiniBrowser/win/MainWindow.h:
4117         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4118         (PrintWebUIDelegate::createWebViewWithRequest):
4119         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4120         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
4121         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
4122         (WebKitBrowserWindow::updateProxySettings):
4123         (WebKitBrowserWindow::createNewPage):
4124         * MiniBrowser/win/WebKitBrowserWindow.h:
4125         * MiniBrowser/win/WinMain.cpp:
4126         (wWinMain):
4127
4128 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
4129
4130         Make it possible to test scrolling tree layer manipulation more easily
4131         https://bugs.webkit.org/show_bug.cgi?id=195780
4132
4133         Reviewed by Tim Horton.
4134         
4135         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
4136         cuts off communication of scrolling tree scrolls back to the web process
4137         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
4138         allows tests to trigger scrolls which run the scrolling tree layer positioning
4139         logic, but never get another commit from the web process that might mask
4140         scrolling tree bugs.
4141         
4142         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
4143         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
4144         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
4145
4146         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4147         (WTR::UIScriptController::scrollUpdatesDisabled const):
4148         (WTR::UIScriptController::setScrollUpdatesDisabled):
4149         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4150         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4151         (WTR::UIScriptController::scrollUpdatesDisabled const):
4152         (WTR::UIScriptController::setScrollUpdatesDisabled):
4153         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4154         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4155         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4156         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
4157         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
4158         * WebKitTestRunner/ios/TestControllerIOS.mm:
4159         (WTR::TestController::platformResetStateToConsistentValues):
4160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4161         (WTR::UIScriptController::scrollUpdatesDisabled const):
4162         (WTR::UIScriptController::setScrollUpdatesDisabled):
4163
4164 2019-03-14  Youenn Fablet  <youenn@apple.com>
4165
4166         Move IDB storage in private browsing mode to NetworkProcess
4167         https://bugs.webkit.org/show_bug.cgi?id=195602
4168
4169         Reviewed by Brady Eidson.
4170
4171         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
4172         (TEST):
4173
4174 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4175
4176         [ews-build] Make descriptionDone messages more readable
4177         https://bugs.webkit.org/show_bug.cgi?id=195760
4178
4179         Reviewed by Lucas Forschler.
4180
4181         * BuildSlaveSupport/ews-build/steps.py:
4182         * BuildSlaveSupport/ews-build/steps_unittest.py:
4183
4184 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4185
4186         [ews-build] Generate status-bubble hover-over messages
4187         https://bugs.webkit.org/show_bug.cgi?id=195680
4188
4189         Reviewed by Lucas Forschler.
4190
4191         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4192         (StatusBubble):
4193         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
4194         on hover-over.
4195         (StatusBubble._iso_time):
4196         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
4197         hover-over message.
4198         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
4199
4200 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4201
4202         [ews-app] Gracefully handle the case when state_string is None
4203         https://bugs.webkit.org/show_bug.cgi?id=195753
4204
4205         Reviewed by Lucas Forschler.
4206
4207         * BuildSlaveSupport/ews-app/ews/models/build.py:
4208         * BuildSlaveSupport/ews-app/ews/models/step.py:
4209
4210 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4211
4212         [ews-app] Status bubble display pending for currently running build step
4213         https://bugs.webkit.org/show_bug.cgi?id=195744
4214
4215         Reviewed by Lucas Forschler.
4216
4217         * BuildSlaveSupport/ews-build/events.py:
4218         (Events.stepStarted): If state_string is pending, replace it with step name.
4219
4220 2019-03-14  Chris Dumez  <cdumez@apple.com>
4221
4222         Add WebsitePolicy for the client to specify the device orientation & motion access policy
4223         https://bugs.webkit.org/show_bug.cgi?id=195750
4224
4225         Reviewed by Geoffrey Garen.
4226
4227         Add API test coverage.
4228
4229         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4230         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
4231         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4232         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4233
4234 2019-03-14  Chris Dumez  <cdumez@apple.com>
4235
4236         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4237         https://bugs.webkit.org/show_bug.cgi?id=195747
4238
4239         Reviewed by Geoff Garen.
4240
4241         Add API test coverage.
4242
4243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4244
4245 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4246
4247         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
4248         https://bugs.webkit.org/show_bug.cgi?id=195725
4249         <rdar://problem/48545062>
4250
4251         Reviewed by Tim Horton.
4252
4253         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4254         handler is nil.
4255
4256         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4257         (TestWebKitAPI::TEST):
4258
4259 2019-03-13  Sam Weinig  <sam@webkit.org>
4260
4261         Add utility function to allow easy reverse range-based iteration of a container
4262         https://bugs.webkit.org/show_bug.cgi?id=195542
4263
4264         Reviewed by Antti Koivisto.
4265
4266         * TestWebKitAPI/CMakeLists.txt:
4267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4268         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4269         (TestWebKitAPI::TEST):
4270         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4271
4272 2019-03-13  Chris Dumez  <cdumez@apple.com>
4273
4274         Use a ServiceWorker process per registrable domain
4275         https://bugs.webkit.org/show_bug.cgi?id=195649
4276
4277         Reviewed by Youenn Fablet.
4278
4279         Update API test coverage.
4280
4281         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4282
4283 2019-03-13  Chris Dumez  <cdumez@apple.com>
4284
4285         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4286         https://bugs.webkit.org/show_bug.cgi?id=195684
4287         <rdar://problem/48294714>
4288
4289         Reviewed by Antti Koivisto.
4290
4291         Add API test coverage.
4292
4293         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4294
4295 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4296
4297         [ews-app] Remove unused patch view
4298         https://bugs.webkit.org/show_bug.cgi?id=195669
4299
4300         Reviewed by Lucas Forschler.
4301
4302         * BuildSlaveSupport/ews-app/ews/urls.py:
4303         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4304
4305 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4306
4307         [ews-app] Use Buildbot result code variables
4308         https://bugs.webkit.org/show_bug.cgi?id=195668
4309
4310         Reviewed by Alexey Proskuryakov.
4311
4312         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4313         (Buildbot): Added Buildbot result code variables.
4314         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4315         (StatusBubble._build_bubble): Used Buildbot result code variables.
4316
4317 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4318
4319         [Flatpak] Expand submodule recursively
4320         https://bugs.webkit.org/show_bug.cgi?id=195672
4321
4322         Building WPE with flatpak was impossible without that as it was raising an exception.
4323         Also update wpebackend-fdo to match what is built in jhbuild
4324
4325         Reviewed by Philippe Normand.
4326
4327         * flatpak/flatpakutils.py:
4328         (expand_submodules_recurse):
4329         (expand_manifest):
4330         * flatpak/org.webkit.WPEModules.yaml:
4331
4332 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4333
4334         [ews-app] status bubble should be hidden for certain builds
4335         https://bugs.webkit.org/show_bug.cgi?id=194597
4336
4337         Reviewed by Dewei Zhu.
4338
4339         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4340         (StatusBubble._build_bubble):
4341         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4342         because the patch didn't have relevant changes.
4343         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4344         in production yet.
4345
4346 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4347
4348