run-api-tests: inline runAllTestsInSuite() into runAllTests()
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-22  David Kilzer  <ddkilzer@apple.com>
2
3         run-api-tests: inline runAllTestsInSuite() into runAllTests()
4
5         Reviewed by Adam Roben.
6
7         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
8
9         In order to make it easy to run one or more individual suites,
10         or one more individual tests, it's easier to call a single
11         method with different data structures than individual methods.
12
13         * Scripts/run-api-tests:
14         (runAllTests): Inline runAllTestsInSuite().
15
16 2011-12-22  Adam Roben  <aroben@apple.com>
17
18         Add a --xml flag to test-webkitpy
19
20         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
21         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
22         This is useful for working with tools that consume JUnit-style XML files.
23
24         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
25         running test-webkitpy
26
27         Reviewed by Darin Adler.
28
29         * Scripts/webkitpy/test/main.py:
30         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
31         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
32
33         * Scripts/webkitpy/thirdparty/__init__.py:
34         (AutoinstallImportHook.find_module):
35         (AutoinstallImportHook._install_xmlrunner):
36         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
37         This change is untested because it's basically impossible to get a test to pass when --xml
38         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
39         the test runs).
40
41 2011-12-22  David Kilzer  <ddkilzer@apple.com>
42
43         TestWebKitAPI: initialize the main thread before running tests
44         <http://webkit.org/b/75064>
45
46         Reviewed by Adam Roben.
47
48         * TestWebKitAPI/TestsController.cpp:
49         (TestWebKitAPI::TestsController::TestsController): Call
50         WTF::initializeMainThread() to prevent assertions in Debug
51         builds.
52
53 2011-12-22  David Kilzer  <ddkilzer@apple.com>
54
55         run-api-tests: dumpAllTests() should not use global variables
56
57         Reviewed by Adam Roben.
58
59         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
60
61         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
62         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
63         global data as an argument.  Sort suite names and test names
64         alphabetically to match output when running tests.
65
66 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
67
68         [BlackBerry] Enable blob for the BlackBerry porting
69         https://bugs.webkit.org/show_bug.cgi?id=75074
70
71         Reviewed by George Staikos.
72
73         * Scripts/build-webkit:
74
75 2011-12-22  Kentaro Hara  <haraken@chromium.org>
76
77         Add unittests for the Perl parser of prepare-ChangeLog
78         https://bugs.webkit.org/show_bug.cgi?id=74994
79
80         Reviewed by David Kilzer.
81
82         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
83
84         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
85
86         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
87         Runs unittests specified in @testFiles.
88         You can reset expected results by specifying a --reset-results option.
89         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
90         Contains simple methods.
91         (func1):
92         (func2):
93         (func3):
94         (func4):
95         (func5):
96         (func6):
97         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
98         This test result is generated by the --reset-results option.
99
100 2011-12-21  Eric Seidel  <eric@webkit.org>
101
102         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
103         so that they appear in the bugzilla autocomplete CC list.
104         I also removed the "radar" irc nick (which I believe does not exist)
105         and removed the uneeded [] around the radar bugzilla email.
106
107         Unreviewed.
108
109         * Scripts/webkitpy/common/config/committers.py:
110
111 2011-12-21  Daniel Bates  <dbates@rim.com>
112
113         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
114         https://bugs.webkit.org/show_bug.cgi?id=74985
115
116         Reviewed by Eric Seidel.
117
118         * Scripts/build-jsc:
119         * Scripts/webkitdirs.pm:
120         (cmakeBasedPortName): Added.
121
122 2011-12-21  Daniel Bates  <dbates@rim.com>
123
124         Extract BlackBerry CMake arguments from build-webkit into separate function
125         https://bugs.webkit.org/show_bug.cgi?id=74981
126
127         Reviewed by Rob Buis.
128
129         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
130         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
131         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
132         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
133         that we can pass them to the CMake build system when building JavaScriptCore.
134
135         * Scripts/build-webkit: Move construction of CMake argument list from here to
136         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
137         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
138         call it from build-webkit.
139         * Scripts/webkitdirs.pm:
140         (blackberryCMakeArguments): Added.
141         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
142         BlackBerry port.
143
144 2011-12-21  Daniel Bates  <dbates@webkit.org>
145
146         Extract WinCE CMake arguments from build-webkit into separate function
147         https://bugs.webkit.org/show_bug.cgi?id=74983
148
149         Reviewed by Rob Buis.
150
151         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
152         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
153         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
154         that we can pass it to the CMake build system when building JavaScriptCore.
155
156         * Scripts/build-webkit:
157         * Scripts/webkitdirs.pm:
158         (cmakeBasedPortArguments): Added.
159
160 2011-12-21  Kentaro Hara  <haraken@chromium.org>
161
162         In prepare-ChangeLog, replace constant global variables with "use constant"
163         https://bugs.webkit.org/show_bug.cgi?id=74992
164
165         Reviewed by Ryosuke Niwa.
166
167         This patch replaces the following constant global variables with "use constant"s.
168             - $changeLogTimeZone
169             - $SVN
170             - $GIT
171             - %supportedTestExtensions
172
173         * Scripts/prepare-ChangeLog:
174         (changeLogNameFromArgs):
175         (changeLogEmailAddressFromArgs):
176         (resolveConflictedChangeLogs):
177         (generateNewChangeLogs):
178         (diffCommand):
179         (statusCommand):
180         (createPatchCommand):
181         (findOriginalFileFromSvn):
182         (determinePropertyChanges):
183         (generateFileList):
184         (reviewerAndDescriptionForGitCommit):
185
186 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
187
188         nrwt: rename field references from _fs to _filesystem
189         https://bugs.webkit.org/show_bug.cgi?id=74898
190
191         Reviewed by Adam Barth.
192
193         This is a simple cleanup; most of the code uses
194         self._filesystem, but some used self._fs; this change renames
195         the latter to the former to be more consistent.
196
197         * Scripts/webkitpy/layout_tests/controllers/manager.py:
198         (Manager.__init__):
199         (Manager.collect_tests):
200         (Manager._strip_test_dir_prefix):
201         (Manager._split_into_chunks_if_necessary):
202         (Manager.results_directory):
203         (Manager._clobber_old_results):
204         (Manager._upload_json_files):
205         (Manager.print_config):
206         (Manager._copy_results_html_file):
207         (Manager._show_results_html_file):
208         (Manager._log_worker_stack):
209         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
210         (JSONLayoutResultsGenerator._normalize_results_json):
211         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
212         (JSONResultsGeneratorBase.__init__):
213         (JSONResultsGeneratorBase.generate_json_output):
214         (JSONResultsGeneratorBase.generate_times_ms_file):
215         (JSONResultsGeneratorBase.upload_json_files):
216         (JSONResultsGeneratorBase._get_svn_revision):
217         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
218         (Base.__init__):
219
220 2011-12-20  Kentaro Hara  <haraken@chromium.org>
221
222         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
223         https://bugs.webkit.org/show_bug.cgi?id=74836
224
225         Reviewed by David Kilzer.
226
227         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
228         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
229         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
230         of prepare-ChangeLog.
231
232         Using LoadAsModule.pm, you can load a Perl script as follows.
233         The first argument is the arbitrary package name you want to use, and the second argument
234         is the name of the Perl script you want to load.
235
236             use LoadAsModule qw(RunLeaks run-leaks);
237             RunLeaks::someFunctionDefinedInRunLeaks(...);
238
239         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
240                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
241                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
242
243         * Scripts/webkitperl/LoadAsModule.pm: Added.
244         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
245         (import):
246         (readFile):
247         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
248         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
249         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
250
251 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
252
253         [Qt] WK2 Debugging quirks need some improvement
254         https://bugs.webkit.org/show_bug.cgi?id=74859
255
256         Reviewed by Simon Hausmann.
257
258         Improvements added to make debugging WebKit2 more
259         confortable and efficient:
260         1. Unify debugging quirks. From now all of them are controlled
261         by the QT_WEBKIT2_DEBUG environment variable.
262         2. Disable crash handlers for WebKitTestRunner if debugging quirks
263         are used to make it possible to use postmortem debugging via core dumps
264         which is extremely useful for debugging bugs triggered by layout tests.
265         3. Disable test timeout for WebKitTestRunner if debugging quirks
266         are used because that makes debugging impossible.
267
268         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
269         (WTR::InjectedBundle::platformInitialize):
270         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
271         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
272         * WebKitTestRunner/qt/TestControllerQt.cpp:
273         (WTR::TestController::platformRunUntil):
274
275 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
276
277         [Qt][WK2] Implement favicon support
278         https://bugs.webkit.org/show_bug.cgi?id=71082
279
280         Reviewed by Simon Hausmann.
281
282         A favorite icon was added on MiniBrowser's url bar as example.
283         We display a default icon when the page doesn't have an icon ready.
284
285         * MiniBrowser/qt/MiniBrowser.qrc:
286         * MiniBrowser/qt/icons/favicon.png: Added.
287         * MiniBrowser/qt/qml/BrowserWindow.qml:
288
289 2011-12-19  Sam Weinig  <sam@webkit.org>
290
291         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
292         https://bugs.webkit.org/show_bug.cgi?id=74907
293
294         Reviewed by Dan Bernstein.
295
296         Add ScrollByLineCommands API test.
297
298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
299         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
300         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
301
302 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
303
304         webkitpy: remove port.executive, port.filesystem, port.user properties
305         https://bugs.webkit.org/show_bug.cgi?id=74896
306
307         Reviewed by Eric Seidel.
308
309         Following on the refactoring of the port and host objects, this
310         removes the public executive, filesystem, and user properties
311         from the Port interface (protected versions of executive and
312         filesystem still exist). There is still some more clean up to
313         make the code more consistent and rearrange some other files to
314         talk to Hosts directly instead of getting them off of the Port
315         class.
316
317         * Scripts/webkitpy/layout_tests/controllers/manager.py:
318         (Manager.__init__):
319         (Manager.results_directory):
320         (Manager._log_worker_stack):
321         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
322         (ManagerTest.test_fallback_path_in_config):
323         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
324         (_InlineManager.start_worker):
325         (_InlineWorkerConnection.__init__):
326         * Scripts/webkitpy/layout_tests/controllers/worker.py:
327         (Worker.safe_init):
328         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
329         (TestConfiguration.from_port):
330         * Scripts/webkitpy/layout_tests/port/base.py:
331         (Port.__init__):
332         (Port.tests):
333         (Port.show_results_html_file):
334         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
335         (PortTest.test_layout_tests_skipping):
336         (PortTest.test_test_dirs):
337         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
338         (_set_up_derived_options):
339         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
340         (PerfTestsRunner.__init__):
341         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
342         (HtmlGenerator.__init__):
343         (HtmlGenerator.show_html):
344         (real_main):
345         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
346         (TestHtmlGenerator.make_generator):
347
348 2011-12-19  Daniel Bates  <dbates@webkit.org>
349
350         Pass command line arguments to GDB when debugging a Mac WebKit application
351         https://bugs.webkit.org/show_bug.cgi?id=72829
352
353         Reviewed by David Kilzer.
354
355         Pass through any command line arguments given to debug-{safari, minibrowser}
356         to GDB so that they may influence the application instance launched by GDB.
357
358         * Scripts/webkitdirs.pm:
359         (execMacWebKitAppForDebugging):
360
361 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
362
363         webkitpy: remove executive,filesystem,user parameters from Port constructor
364         https://bugs.webkit.org/show_bug.cgi?id=74878
365
366         Reviewed by Eric Seidel.
367
368         This change concludes the refactoring that makes Host a required
369         parameter for Port and ensures that all access to filesystem,
370         executives, etc. is going through the Host.
371
372         * Scripts/webkitpy/layout_tests/port/base.py:
373         (Port.__init__):
374
375 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
376
377         webkitpy: finish refactoring port classes to make a host mandatory
378         https://bugs.webkit.org/show_bug.cgi?id=74566
379
380         Reviewed by Eric Seidel.
381
382         This change makes all Port objects take a required (System)Host
383         parameter, and updates the TestPort object to no longer create a
384         mock filesystem or add files to the existing filesystem by
385         default.
386
387         * Scripts/webkitpy/layout_tests/port/base.py:
388         (Port.__init__):
389         * Scripts/webkitpy/layout_tests/port/factory.py:
390         (PortFactory.__init__):
391         (PortFactory._get_kwargs):
392         * Scripts/webkitpy/layout_tests/port/test.py:
393         (TestInstance.__init__):
394         (TestPort.__init__):
395         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
396         (passing_run):
397         (logging_run):
398         (get_tests_run):
399         (MainTest.test_single_file):
400         (MainTest.test_stderr_is_saved):
401         (MainTest.test_test_list):
402         (MainTest.test_test_list_with_prefix):
403         (MainTest.test_missing_and_unexpected_results):
404         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
405         (MainTest.test_crash_with_stderr):
406         (MainTest.test_no_image_failure_with_image_diff):
407         (MainTest.test_crash_log):
408         (MainTest.test_web_process_crash_log):
409         (MainTest.test_exit_after_n_failures_upload):
410         (MainTest.test_results_directory_absolute):
411         (MainTest.test_results_directory_relative):
412         (MainTest.test_retries_directory):
413         (MainTest.test_tolerance.get_port_for_run):
414         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
415         (EndToEndTest.test_end_to_end):
416         (EndToEndTest.test_reftest_with_two_notrefs):
417         (RebaselineTest.test_reset_results):
418         (RebaselineTest.test_missing_results):
419         (RebaselineTest.test_new_baseline):
420         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
421         (Rebaseliner.__init__):
422         (main):
423         (real_main):
424         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
425         (test_host_port_and_filesystem):
426         (TestRebaseliner.make_rebaseliner):
427         (TestRealMain.test_all_platforms):
428         (TestHtmlGenerator.make_generator):
429
430 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
431
432         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
433         https://bugs.webkit.org/show_bug.cgi?id=74562
434
435         Reviewed by Eric Seidel.
436
437         Apart from a minor change to style/checkers/test_expectations.py
438         to take a host as a parameter to a TestExpectationsChecker(),
439         there are only refactoring changes to unit tests here.
440
441         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
442         (TestResultWriterTest.test_reftest_diff_image):
443         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
444         (JSONGeneratorTest._test_json_generation):
445         (JSONGeneratorTest.test_test_timings_trie):
446         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
447         (Base.__init__):
448         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
449         (PortTest.make_port):
450         (PortTest.test_layout_tests_skipping):
451         (PortTest.test_test_dirs):
452         (PortTest.test_additional_platform_directory):
453         (PortTest.test_uses_test_expectations_file):
454         (PortTest.test_find_no_paths_specified):
455         (PortTest.test_find_one_test):
456         (PortTest.test_find_glob):
457         (PortTest.test_find_with_skipped_directories):
458         (PortTest.test_find_with_skipped_directories_2):
459         (PortTest.test_parse_reftest_list):
460         * Scripts/webkitpy/layout_tests/port/dryrun.py:
461         (DryRunPort.__init__):
462         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
463         (FactoryTest.setUp):
464         (FactoryTest.tearDown):
465         (FactoryTest.assert_port):
466         (FactoryTest.assert_platform_port):
467         (FactoryTest.test_unknown_specified):
468         (FactoryTest.test_unknown_default):
469         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
470         (GetGoogleChromePortTest._verify_expectations_overrides):
471         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
472         (MockDRTPortTest.make_port):
473         (MockDRTTest.assertTest):
474         (MockDRTTest.test_main):
475         (MockChromiumDRTTest.test_pixeltest__fails):
476         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
477         (QtPortTest._assert_search_path):
478         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
479         (TestWebKitPort.__init__):
480         (WebKitPortTest.test_skipped_directories_for_symbols):
481         (test_skipped_directories_for_features):
482         (test_skipped_layout_tests):
483         (test_skipped_file_search_paths):
484         (test_root_option):
485         (test_test_expectations):
486         (test_build_driver):
487         (test_linux_distro_detection):
488         (test_apache_config_file_name_for_platform):
489         (test_path_to_apache_config_file):
490         (WebKitDriverTest.test_read_block):
491         * Scripts/webkitpy/style/checkers/test_expectations.py:
492         (TestExpectationsChecker.__init__):
493         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
494         (TestExpectationsTestCase._expect_port_for_expectations_path):
495         (TestExpectationsTestCase.assert_lines_lint):
496         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
497         (get_test_config.TestMacPort):
498
499 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
500
501         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
502         https://bugs.webkit.org/show_bug.cgi?id=74854
503
504         Reviewed by Csaba Osztrogonác.
505
506         Since r101052, libewebkit.so is built in a different location, so we
507         need to adjust the path returned by builtDylibPathForName.
508
509         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
510         port also respects Release/Debug configurations.
511
512         These changes should make run-launcher finally work correctly with
513         webkit-efl.
514
515         * Scripts/webkitdirs.pm:
516         (usesPerConfigurationBuildDirectory):
517         (builtDylibPathForName):
518
519 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
520
521         [Qt][WK2] Add support for modal event loop processing for WTR
522         https://bugs.webkit.org/show_bug.cgi?id=74852
523
524         Reviewed by Kenneth Rohde Christiansen.
525
526         Rewrote event loop processing: Instead of terminating the event loop
527         in notifyDone() - something no other platform does - we now respect the
528         "bool& condition" parameter passed to platformRunUntil. This ensures
529         proper termination even when the condition is changed from within a
530         nested event loop, because only when we _exit_ from the nested event
531         loop we will check the condition and terminate the test properly.
532
533         In addition this patch implements TestController::runModal by means of
534         a nested event loop, which is passed to the platform webview that is
535         supposed to be modal. It is that view's responsibility to exit the
536         loop, upon destruction. I believe that's similar to how it works on the Mac,
537         where it doesn't seem that NSApp's runModalForWindow is terminate via
538         abort/stopModal but simply because the window is closed.
539
540         * WebKitTestRunner/PlatformWebView.h:
541         (WTR::PlatformWebView::setModalEventLoop):
542         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
543         (WTR::PlatformWebView::PlatformWebView):
544         (WTR::PlatformWebView::~PlatformWebView):
545         * WebKitTestRunner/qt/TestControllerQt.cpp:
546         (WTR::TestController::notifyDone):
547         (WTR::TestController::platformRunUntil):
548         (WTR::TestController::runModal):
549
550 2011-12-18  Kentaro Hara  <haraken@chromium.org>
551
552         REGRESSION(r103149): prepare-ChangeLog outputs a warning
553         https://bugs.webkit.org/show_bug.cgi?id=74808
554
555         Reviewed by David Kilzer.
556
557         Added the prototype declaration of main() to avoid warning messages.
558         Sorted subroutine declarations in the alphabetical order.
559
560         * Scripts/prepare-ChangeLog:
561
562 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
563
564         [Qt] Fix QtTestBrowser compilation with QtWidgets module
565         https://bugs.webkit.org/show_bug.cgi?id=74791
566
567         Reviewed by Andreas Kling.
568
569         * QtTestBrowser/QtTestBrowser.pro:
570
571 2011-12-17  Kentaro Hara  <haraken@chromium.org>
572
573         Remove top-level code completely from prepare-ChangeLog
574         https://bugs.webkit.org/show_bug.cgi?id=74698
575
576         Reviewed by Darin Adler.
577
578         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
579         This patch just moves all top-level code into main().
580
581         * Scripts/prepare-ChangeLog:
582         (main):
583
584 2011-12-16  Dean Jackson  <dino@apple.com>
585
586         Move webkit-bug-importer to Contributor. It won't
587         autocomplete as an Account.
588         See https://bugs.webkit.org/show_bug.cgi?id=74739
589         for some discussion.
590
591         Unreviewed.
592
593         * Scripts/webkitpy/common/config/committers.py:
594
595 2011-12-16  Dean Jackson  <dino@apple.com>
596
597         Add webkit-bug-importer@group.apple.com to accounts
598         so that it autocompletes in bugzilla.
599
600         Unreviewed.
601
602         * Scripts/webkitpy/common/config/committers.py:
603
604 2011-12-16  Philippe Normand  <pnormand@igalia.com>
605
606         Unreviewed, skipping 3 failing GTK API tests.
607
608         * Scripts/run-gtk-tests:
609
610 2011-12-16  Philippe Normand  <pnormand@igalia.com>
611
612         Unreviewed, GTK API tests build fix attempt.
613
614         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
615
616 2011-12-16  Philippe Normand  <pnormand@igalia.com>
617
618         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
619
620         * Scripts/run-gtk-tests:
621
622 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
623
624         [Qt] Fix the build for newer Qt5
625         https://bugs.webkit.org/show_bug.cgi?id=74703
626
627         Reviewed by Csaba Osztrogonác.
628
629         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
630         * DumpRenderTree/qt/EventSenderQt.cpp:
631         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
632         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
633         (WTR::EventSenderProxy::sendTouchEvent):
634         * MiniBrowser/qt/MiniBrowserApplication.cpp:
635         (MiniBrowserApplication::sendTouchEvent): Ditto.
636         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
637
638 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
639
640         [Qt] Detect and force clean build when feature defines are added
641
642         Reviewed by Ossy.
643
644         https://bugs.webkit.org/show_bug.cgi?id=74689
645
646         * Scripts/webkitdirs.pm:
647
648 2011-12-16  Kentaro Hara  <haraken@chromium.org>
649
650         [Refactoring] Remove all global variables from prepare-ChangeLog
651         https://bugs.webkit.org/show_bug.cgi?id=74681
652
653         Reviewed by Ryosuke Niwa.
654
655         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
656         manner. This bug is one of the incremental refactorings to remove all top-level
657         code and global variables from prepare-ChangeLog. In this patch,
658         we make the following global variables be used only through parameter passing.
659         This patch removes all global variables from prepare-ChangeLog.
660             - $mergeBase
661             - $gitCommit
662             - $gitIndex
663
664         * Scripts/prepare-ChangeLog:
665         (generateFunctionLists):
666         (changeLogNameFromArgs):
667         (changeLogEmailAddressFromArgs):
668         (generateNewChangeLogs):
669         (printDiff):
670         (diffFromToString):
671         (diffCommand):
672         (statusCommand):
673         (createPatchCommand):
674         (generateFileList):
675         (isConflictStatus):
676
677 2011-12-15  Philippe Normand  <pnormand@igalia.com>
678
679         [GTK] Rounding errors on 32-bit machines causes tests to fail
680         https://bugs.webkit.org/show_bug.cgi?id=72254
681
682         Initial patch by vanuan@gmail.com.
683         Reviewed by Martin Robinson.
684
685         * Scripts/webkitdirs.pm:
686         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
687         CXXFLAGS to autogen in an attempt to harmonize floating point
688         values between 32-bit and 64-bit architectures.
689
690 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
691
692         [GTK] Make distcheck fails during the install
693         https://bugs.webkit.org/show_bug.cgi?id=74274
694
695         No review, since this is a build fix.
696
697         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
698         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
699         always runs. This means that the gtkdoc step was always running when make was
700         invoked. Generating gtkdoc during 'make install' was triggering a race condition
701         with the library file. Later we can fix generate-forwarding-headers and unbreak
702         'make docs,' but this bandaid is sufficient to let us release.
703
704 2011-12-15  Eric Seidel  <eric@webkit.org>
705
706         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
707         https://bugs.webkit.org/show_bug.cgi?id=74650
708
709         Reviewed by Adam Barth.
710
711         * Scripts/webkitpy/common/system/platforminfo.py:
712         (PlatformInfo._compute_bytes_from_vm_stat_output):
713         * Scripts/webkitpy/layout_tests/port/base.py:
714         (Port.default_child_processes):
715         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
716         (PortTest.test_default_child_processes):
717
718 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
719
720         bencher script should support remote benchmarking on platforms that don't have ruby
721         https://bugs.webkit.org/show_bug.cgi?id=74659
722
723         Rubber-stamped by Sam Weinig.
724         
725         Added the ability to have bencher generate a benchmarking playload that consists of
726         copies of all of the benchmarks, optionally copies of all of the frameworks and
727         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
728         order, which then spits out a raw results file that bencher can parse.
729         
730         In normal operating mode, you never see this, as it just generates the payload and
731         script internally, runs it, parses the results, and spits them out.
732         
733         The --remote mode has been changed to use this style, so any remote host that has
734         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
735         a sh-compatible shell can be used for remote benchmarking.
736         
737         The feature to include VMs in the benchmarking payload is by default only activated
738         when using --remote, but it can also be activated when doing local benchmarking; the
739         benefit is that you remove any pathname-related performance pathologies. All VMs
740         become equal because they are all located in
741         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
742         (usually 0 or 1).
743         
744         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
745         through DumpRenderTree. This is only a bit slower than running in jsc.
746
747         * Scripts/bencher:
748
749 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
750
751         webkitpy: clean up TestPort to (mostly) not create a new filesystem
752         https://bugs.webkit.org/show_bug.cgi?id=74556
753
754         This change modifies the TestPort to be ready to add tests to an
755         existing filesystem instead of creating a new filesystem; we
756         leave unit_test_filesystem() in for now for compatibility.
757
758         * Scripts/webkitpy/common/host_mock.py:
759         (MockHost.__init__):
760           - call add_unit_tests_to_mock_filesystem by default to make
761             the MockHost more generally useful for layout_test unit tests.
762         * Scripts/webkitpy/layout_tests/port/test.py:
763         (TestInstance.__init__):
764         (add_unit_tests_to_mock_filesystem):
765         (add_file):
766         (unit_test_filesystem):
767         (TestPort.__init__):
768         (TestPort._set_default_overriding_none):
769
770 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
771
772         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
773         https://bugs.webkit.org/show_bug.cgi?id=74551
774
775         This is some minor cleanup prior to making all of the host/port
776         changes described in bug 74138.
777
778         * Scripts/webkitpy/common/host_mock.py:
779         (MockHost.__init__):
780           - make sure the scm object is initialized with the same mock
781             executive and filesystem objects.
782
783         * Scripts/webkitpy/common/system/filesystem_mock.py:
784         (MockFileSystem.clear_written_files):
785           - add a routine that will be useful in testing.
786         (MockFileSystem.maybe_make_directory):
787         (MockFileSystem.write_binary_file):
788           - fix bugs to make sure directories are created properly.
789         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
790         (_Process.run):
791           - add clarifying comments.
792         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
793         (MockDRTPort.__init__):
794         (MockDRT.__init__):
795           - add clarifying comments.
796
797 2011-12-15  Anders Carlsson  <andersca@apple.com>
798
799         Regression (r102866): Navigating away from or closing a page with a plugin crashes
800         https://bugs.webkit.org/show_bug.cgi?id=74655
801
802         Reviewed by Sam Weinig.
803
804         Add a bunch of tests.
805
806         * TestWebKitAPI/Tests/WTF/Functional.cpp:
807
808 2011-12-15  Stephanie Lewis  <slewis@apple.com>
809
810         https://bugs.webkit.org/show_bug.cgi?id=74469
811         Escape paths to svn commands so our tools can handle filenames with @ symbols.
812
813         Reviewed by Adam Roben.
814
815         * Scripts/VCSUtils.pm:
816         (scmMoveOrRenameFile):
817         (scmAddExecutableBit):
818         (scmRemoveExecutableBit):
819         (determineSVNRoot):
820         (svnRevisionForDirectory):
821         (pathRelativeToSVNRepositoryRootForPath):
822         (svnStatus):
823         (escapeSubversionPath):
824         * Scripts/parse-malloc-history:
825         (main):
826         * Scripts/prepare-ChangeLog:
827         (diffCommand):
828         (statusCommand):
829         (findOriginalFileFromSvn):
830         (determinePropertyChanges):
831         * Scripts/resolve-ChangeLogs:
832         (conflictFiles):
833         (resolveConflict):
834         (showStatus):
835         * Scripts/svn-apply:
836         (patch):
837         (scmCopy):
838         (scmAdd):
839         (scmRemove):
840         * Scripts/svn-create-patch:
841         (findBaseUrl):
842         (findMimeType):
843         (findSourceFileAndRevision):
844         (generateDiff):
845         (generateFileList):
846         (manufacturePatchForAdditionWithHistory):
847         * Scripts/svn-unapply:
848         (patch):
849         (revertDirectories):
850
851 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
852
853         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
854         https://bugs.webkit.org/show_bug.cgi?id=74617
855
856         Reviewed by Kenneth Rohde Christiansen.
857
858         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
859         for viewport info button, adjusted height and added rounded corners.
860
861 2011-12-15  Andy Estes  <aestes@apple.com>
862
863         TestFailures: store the name of the buildbot results directory in a property
864         https://bugs.webkit.org/show_bug.cgi?id=74663
865
866         Reviewed by Adam Barth.
867         
868         Store the name of the results directory as a property on Buildbot's
869         prototype. This allows subclasses of Buildbot to customize the results
870         directory.
871
872         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
873         (Buildbot.prototype.resultsDirectoryURL):
874
875 2011-12-15  Tony Chang  <tony@chromium.org>
876
877         [chromium] pass --delete_unversioned_trees to gclient on the bots
878         https://bugs.webkit.org/show_bug.cgi?id=74565
879
880         Reviewed by Kenneth Russell.
881
882         It was temporarily removed in r102891 to keep the bots green.  Now
883         that the bots have cycled, we can add it back.
884
885         * Scripts/update-webkit-chromium:
886
887 2011-12-15  Kentaro Hara  <haraken@chromium.org>
888
889         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
890         https://bugs.webkit.org/show_bug.cgi?id=74497
891
892         Reviewed by Ryosuke Niwa.
893
894         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
895         manner. This bug is one of the incremental refactorings to remove all top-level
896         code and global variables from prepare-ChangeLog. In this patch,
897         we make the following global variables be used only through parameter passing.
898             - $bugDescription
899             - $bugNumber
900             - $name
901             - $emailAddress
902             - $gitReviewer
903             - $writeChangeLogs
904
905         * Scripts/prepare-ChangeLog:
906         (fetchBugDescriptionFromURL):
907         (generateNewChangeLogs):
908         (reviewerAndDescriptionForGitCommit):
909
910 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
911
912         [EFL] Add a few more web database functions to ewk_settings.
913         https://bugs.webkit.org/show_bug.cgi?id=72148
914
915         Reviewed by Antonio Gomes.
916
917         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
918         (LayoutTestController::clearAllDatabases):
919         (LayoutTestController::setDatabaseQuota):
920
921 2011-12-15  Martin Kosiba  <mkosiba@google.com>
922
923         Fix find on web pages with -webkit-user-select: none for Chromium
924         https://bugs.webkit.org/show_bug.cgi?id=72281
925
926         Reviewed by Ryosuke Niwa.
927
928         Provided a partial findString implementation. This doesn't support
929         all of the FindOptions since they're not exposed via WebFindOptions.
930
931         * DumpRenderTree/chromium/LayoutTestController.cpp:
932         (LayoutTestController::LayoutTestController):
933         (LayoutTestController::findString):
934         * DumpRenderTree/chromium/LayoutTestController.h:
935
936 2011-12-15  Kenneth Russell  <kbr@google.com>
937
938         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
939         https://bugs.webkit.org/show_bug.cgi?id=74581
940
941         Reviewed by Darin Fisher.
942
943         * DumpRenderTree/chromium/LayoutTestController.cpp:
944         (LayoutTestController::overridePreference):
945         * DumpRenderTree/chromium/WebPreferences.cpp:
946         (WebPreferences::reset):
947         (WebPreferences::applyTo):
948         * DumpRenderTree/chromium/WebPreferences.h:
949
950 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
951
952         [Qt] Improve the look of the viewport info overlay
953
954         Reviewed by Tor Arne Vestbø.
955
956         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
957
958 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
959
960         [Qt] Support requestAnimationFrame API
961         https://bugs.webkit.org/show_bug.cgi?id=74528
962
963         Add build-option for requestAnimationFrame feature.
964
965         Reviewed by Kenneth Rohde Christiansen.
966
967         * qmake/mkspecs/features/features.prf:
968
969 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
970
971         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
972
973         Reviewed by Simon Hausmann.
974
975         * qmake/mkspecs/features/webcore.prf:
976
977 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
978
979         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
980         https://bugs.webkit.org/show_bug.cgi?id=72893
981
982         Reviewed by Kenneth Rohde Christiansen.
983
984         This patch extends QQuickWebViewExperimental by a property named
985         viewportInfo, which contains the viewport scalability and
986         layout and contents size information. This property is exposed to
987         QML through the experimental extension for QQuickWebView.
988
989         * MiniBrowser/qt/MiniBrowser.pro:
990         * MiniBrowser/qt/MiniBrowser.qrc:
991         * MiniBrowser/qt/icons/info.png: Added.
992         * MiniBrowser/qt/qml/BrowserWindow.qml:
993         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
994
995 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
996
997         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
998         https://bugs.webkit.org/show_bug.cgi?id=74586
999
1000         Reviewed by Hajime Morita.
1001
1002         No new tests. Covered by existing tests.
1003
1004         * DumpRenderTree/chromium/WebViewHost.cpp:
1005         (WebViewHost::requestCheckingOfText):
1006           Returns immediately if text is empty.
1007
1008 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
1009
1010         [Qt] QtWebKit fails to build on Mac OS X after r102776
1011         https://bugs.webkit.org/show_bug.cgi?id=74593
1012
1013         Reviewed by Simon Hausmann.
1014
1015         CONFIG =+ link_pkgconfig is needed such that the correct parameters
1016         are passed to the compiler.
1017
1018         * DumpRenderTree/qt/DumpRenderTree.pro:
1019
1020 2011-12-14  Tony Chang  <tony@chromium.org>
1021
1022         [chromium] Remove redundant third_party entries from chromium DEPS
1023         https://bugs.webkit.org/show_bug.cgi?id=74472
1024
1025         Reviewed by Kenneth Russell.
1026
1027         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
1028
1029 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1030
1031         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
1032         VCSUtils::isGit() and VCSUtils::isSVN().
1033         https://bugs.webkit.org/show_bug.cgi?id=74485
1034
1035         Reviewed by David Kilzer.
1036
1037         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1038         manner. This bug is one of the incremental refactorings to remove all top-level
1039         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
1040         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
1041         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
1042         just by looking at the current working directory.
1043
1044         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
1045         (diffFromToString):
1046         (diffCommand):
1047         (statusCommand):
1048         (createPatchCommand):
1049         (diffHeaderFormat):
1050         (generateFileList):
1051         (isAddedStatus):
1052         (isConflictStatus):
1053         (statusDescription):
1054         (extractLineRange):
1055
1056 2011-12-14  Sam Weinig  <weinig@apple.com>
1057
1058         Remove whitespace from InheritedPropertySheets attributes in
1059         vsprops files to appease the Visual Studio project migrator.
1060
1061         Reviewed by Adam Roben.
1062
1063         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
1064         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
1065         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
1066         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1067         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1068         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1069         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
1070         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
1071         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
1072         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1073         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1074         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1075         * DumpRenderTree/win/ImageDiffDebug.vsprops:
1076         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
1077         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
1078         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1079         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1080         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1081         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
1082         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
1083         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
1084         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1085         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1086         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1087         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1088         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1089         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
1090         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
1091         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
1092         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1093         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1094         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1095         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
1096         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
1097         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
1098         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1099         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1100         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1101         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
1102         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
1103         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
1104         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1105         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1106         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1107         * WinLauncher/WinLauncherDebug.vsprops:
1108         * WinLauncher/WinLauncherDebugAll.vsprops:
1109         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
1110         * WinLauncher/WinLauncherProduction.vsprops:
1111         * WinLauncher/WinLauncherRelease.vsprops:
1112         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1113         * record-memory-win/record-memory-winDebug.vsprops:
1114         * record-memory-win/record-memory-winDebugAll.vsprops:
1115         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
1116         * record-memory-win/record-memory-winProduction.vsprops:
1117         * record-memory-win/record-memory-winRelease.vsprops:
1118         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1119
1120 2011-12-14  Anders Carlsson  <andersca@apple.com>
1121
1122         Windows build fix.
1123
1124         Move CHECKs out of the destructor.
1125
1126         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1127         (TestWebKitAPI::B::~B):
1128         (TestWebKitAPI::TEST):
1129
1130 2011-12-14  Anders Carlsson  <andersca@apple.com>
1131
1132         binding a member function should ref/deref the object pointer if needed
1133         https://bugs.webkit.org/show_bug.cgi?id=74552
1134
1135         Reviewed by Sam Weinig.
1136
1137         Add new tests.
1138
1139         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1140         (TestWebKitAPI::B::B):
1141         (TestWebKitAPI::B::~B):
1142         (TestWebKitAPI::B::ref):
1143         (TestWebKitAPI::B::deref):
1144         (TestWebKitAPI::B::f):
1145         (TestWebKitAPI::B::g):
1146         (TestWebKitAPI::TEST):
1147
1148 2011-12-14  Hajime Morrita  <morrita@chromium.org>
1149
1150         JS_INLINE and WTF_INLINE should be visible from WebCore
1151         https://bugs.webkit.org/show_bug.cgi?id=73191
1152
1153         Reviewed by Kevin Ollivier.
1154
1155         Removed macro definitions which is now provided by Platform.h
1156
1157         * DumpRenderTree/chromium/config.h:
1158         * DumpRenderTree/config.h:
1159         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
1160         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
1161         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
1162         * TestWebKitAPI/config.h:
1163         * WebKitTestRunner/config.h:
1164
1165 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1166
1167         Unreviewed, rolling out r102761.
1168         http://trac.webkit.org/changeset/102761
1169         https://bugs.webkit.org/show_bug.cgi?id=74485
1170
1171         we came up with a better fix than this (see comments in bug
1172         74485)
1173
1174         * Scripts/prepare-ChangeLog:
1175         (generateFunctionLists):
1176         (printDiff):
1177         (diffCommand):
1178         (statusCommand):
1179         (createPatchCommand):
1180         (generateFileList):
1181         (isAddedStatus):
1182         (isConflictStatus):
1183         (statusDescription):
1184         (extractLineRange):
1185
1186 2011-12-14  Anders Carlsson  <andersca@apple.com>
1187
1188         Work around a bug in the MSVC2005 compiler
1189         https://bugs.webkit.org/show_bug.cgi?id=74550
1190
1191         Reviewed by Sam Weinig.
1192
1193         Re-enable tests.
1194
1195         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1196
1197 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1198
1199         [Qt] Test fonts are not used with Qt5
1200         https://bugs.webkit.org/show_bug.cgi?id=72513
1201
1202         My last unreviewed buildfix for this crazy bug.
1203
1204         * qmake/mkspecs/features/features.prf:
1205
1206 2011-12-14  Anders Carlsson  <andersca@apple.com>
1207
1208         Another attempt at fixing the Windows build.
1209
1210         Disable all the tests until I can figure out what's going on here.
1211
1212         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1213
1214 2011-12-14  Anders Carlsson  <andersca@apple.com>
1215
1216         Fix the Windows build.
1217
1218         Disable some of the tests for now.
1219
1220         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1221
1222 2011-12-14  Anders Carlsson  <andersca@apple.com>
1223
1224         bind should handle member functions
1225         https://bugs.webkit.org/show_bug.cgi?id=74529
1226
1227         Reviewed by Sam Weinig.
1228
1229         Add tests.
1230
1231         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1232         (TestWebKitAPI::A::A):
1233         (TestWebKitAPI::A::f):
1234         (TestWebKitAPI::A::addF):
1235         (TestWebKitAPI::TEST):
1236
1237 2011-12-14  Anders Carlsson  <andersca@apple.com>
1238
1239         Add unary and binary bind overloads
1240         https://bugs.webkit.org/show_bug.cgi?id=74524
1241
1242         Reviewed by Sam Weinig.
1243
1244         Add tests.
1245
1246         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1247         (TestWebKitAPI::TEST):
1248         (TestWebKitAPI::multiplyByTwo):
1249         (TestWebKitAPI::multiplyByOneAndAHalf):
1250         (TestWebKitAPI::multiply):
1251         (TestWebKitAPI::subtract):
1252
1253 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1254
1255         [Qt] Test fonts are not used with Qt5
1256         https://bugs.webkit.org/show_bug.cgi?id=72513
1257
1258         MIPS and SH4 buildfix after r102776 and r102795.
1259
1260         Reviewed by Csaba Osztrogonác.
1261
1262         * qmake/mkspecs/features/features.prf:
1263
1264 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1265
1266         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
1267
1268         * qmake/mkspecs/features/features.prf:
1269
1270 2011-12-14  Andreas Kling  <kling@webkit.org>
1271
1272         Make my e-mail address a little more awesome.
1273
1274         * Scripts/webkitpy/common/config/committers.py:
1275
1276 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1277
1278         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
1279
1280         * qmake/mkspecs/features/webcore.prf:
1281
1282 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
1283
1284         [Qt] Test fonts are not used with Qt5
1285         https://bugs.webkit.org/show_bug.cgi?id=72513
1286
1287         Reviewed by Simon Hausmann.
1288
1289         Don't depend on Q_WS_X11 anymore since it's not the Qt5
1290         way to detect the platform. Make the guards depend
1291         on our own configtest for fontconfig. For Qt4 we can still
1292         use the preassumption that we have it on Linux.
1293
1294         * DumpRenderTree/qt/DumpRenderTree.pro:
1295         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1296         (WebCore::DumpRenderTree::open):
1297         (WebCore::DumpRenderTree::initializeFonts):
1298         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1299         * DumpRenderTree/qt/main.cpp:
1300         (main): Additionally remove a nonsense piece of code that was
1301         trying to reset the font settings - which is not necessary -
1302         after we have already returned from main.
1303         * WebKitTestRunner/InjectedBundle/Target.pri:
1304         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1305         (WTR::activateFonts):
1306         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
1307         from WTR. It is not needed. We set up the fonts via the injected bundle.
1308         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
1309         (main):
1310         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
1311         * qmake/mkspecs/features/features.prf:
1312         * qmake/sync.profile:
1313
1314 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1315
1316         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1317
1318         Followup to r102679
1319
1320         https://bugs.webkit.org/show_bug.cgi?id=74413
1321
1322         Reviewed by Simon Hausmann.
1323
1324         * qmake/mkspecs/features/webcore.prf:
1325
1326 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
1327
1328         [Qt] Mobile theme could use a little refresh
1329         https://bugs.webkit.org/show_bug.cgi?id=74293
1330
1331         Have MiniBrowser use the mobile theme when not
1332         passed --desktop.
1333
1334         Reviewed by Kenneth Rohde Christiansen.
1335
1336         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1337         (MiniBrowserApplication::handleUserOptions):
1338
1339 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
1340
1341         [Qt] [Gardening] Remove qt-4.7 layout tests dir
1342         https://bugs.webkit.org/show_bug.cgi?id=74426
1343
1344         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
1345         on the tree.
1346
1347         Reviewed by Csaba Osztrogonác.
1348
1349         * Scripts/webkitpy/layout_tests/port/qt.py:
1350         (QtPort.qt_version):
1351         (QtPort.baseline_search_path):
1352         (QtPort._skipped_file_search_paths):
1353         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1354         (QtPortTest._assert_search_path):
1355
1356 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1357
1358         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
1359         through parameter passing
1360         https://bugs.webkit.org/show_bug.cgi?id=74485
1361
1362         Reviewed by Ryosuke Niwa.
1363
1364         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1365         manner. This bug is one of the incremental refactorings to remove all top-level
1366         code and global variables from prepare-ChangeLog. In this patch,
1367         we make the following global variables be used only through parameter passing.
1368             - $isGit
1369             - $isSVN
1370
1371         * Scripts/prepare-ChangeLog:
1372         (generateFunctionLists):
1373         (printDiff):
1374         (diffFromToString):
1375         (diffCommand):
1376         (statusCommand):
1377         (createPatchCommand):
1378         (diffHeaderFormat):
1379         (generateFileList):
1380         (isAddedStatus):
1381         (isConflictStatus):
1382         (statusDescription):
1383         (extractLineRange):
1384
1385 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
1386
1387         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
1388         https://bugs.webkit.org/show_bug.cgi?id=74417
1389
1390         Reviewed by Simon Hausmann.
1391
1392         Based on original patch by Kenneth Christiansen.
1393
1394         Already covered by current tests.
1395
1396         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1397         (WebCore::DumpRenderTree::DumpRenderTree):
1398         (WebCore::DumpRenderTree::~DumpRenderTree):
1399         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1400         (LayoutTestController::setMockDeviceOrientation):
1401
1402 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1403
1404         [GTK] Bad text rendering since r101343
1405         https://bugs.webkit.org/show_bug.cgi?id=73744
1406
1407         Reviewed by Martin Robinson.
1408
1409         Turn cairo hint metrics off for better font metrics reporting in
1410         the tests. This is especially important for SVG.
1411
1412         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1413         (initializeGtkFontSettings):
1414         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1415         (WTR::initializeGtkSettings):
1416
1417 2011-12-13  Kentaro Hara  <haraken@chromium.org>
1418
1419         [Refactoring] Remove several global variables from prepare-ChangeLog
1420         https://bugs.webkit.org/show_bug.cgi?id=74389
1421
1422         Reviewed by David Kilzer.
1423
1424         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1425         manner. This bug is one of the incremental refactorings to remove all top-level
1426         code and global variables from prepare-ChangeLog. In this patch,
1427         we make the following global variables being used only through parameter passing.
1428             - %paths
1429             - $changedFiles
1430             - $conflictFiles
1431             - $functionLists
1432             - $bugURL
1433
1434         * Scripts/prepare-ChangeLog:
1435         (findChangeLogs):
1436         (generateNewChangeLogs):
1437         (processPaths):
1438         (generateFileList):
1439         (firstDirectoryOrCwd):
1440
1441 2011-12-13  Anders Carlsson  <andersca@apple.com>
1442
1443         Add a very bare-bones implementation of bind and Function to WTF
1444         https://bugs.webkit.org/show_bug.cgi?id=74462
1445
1446         Reviewed by Sam Weinig.
1447
1448         Add basic tests for WTF::Function and WTF::bind.
1449
1450         * TestWebKitAPI/TestWebKitAPI.gypi:
1451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1452         * TestWebKitAPI/Tests/Functional.cpp: Added.
1453         (TestWebKitAPI::returnFortyTwo):
1454         (TestWebKitAPI::TEST):
1455         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1456
1457 2011-12-13  Robin Dunn  <robin@alldunn.com>
1458
1459         [wx] Add a URL argument to wxWebView constructor.
1460         https://bugs.webkit.org/show_bug.cgi?id=74316
1461         
1462         Reviewed by Kevin Ollivier.
1463
1464         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1465         (MyApp::OnInit):
1466         * wx/browser/browser.cpp:
1467         (MyApp::OnInit):
1468
1469 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1470
1471         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
1472         https://bugs.webkit.org/show_bug.cgi?id=74430
1473
1474         Reviewed by David Levin.
1475
1476         * Scripts/webkitpy/common/config/watchlist:
1477
1478 2011-12-13  Peter Beverloo  <peter@chromium.org>
1479
1480         [Chromium] Pull in FreeType and decrease check-out complexity for Android
1481         https://bugs.webkit.org/show_bug.cgi?id=74401
1482
1483         Decrease the check-out complexity by removing the need to first run
1484         "update-webkit-chromium --chromium" prior to running it with
1485         "--chromium-android", which was caused by an unversioned third_party/
1486         directory being created. This moves the Android NDK to Source/WebKit/
1487         chromium/, coming from third_party/ in that directory.
1488
1489         Reviewed by Adam Barth.
1490
1491         * Scripts/update-webkit-chromium:
1492         * Scripts/webkitdirs.pm:
1493         (buildChromiumMakefile):
1494
1495 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
1496
1497         build-jsc passing incorrect args to buildGtkProject
1498         https://bugs.webkit.org/show_bug.cgi?id=74308
1499
1500         Reviewed by Gustavo Noronha Silva.
1501
1502         * Scripts/build-webkit: Instead of invoking buildGtkProject with
1503         another argument about webkit2, unshift a --disable-webkit2
1504         argument onto the buildArgs.
1505         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
1506         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
1507         and build-jsc are run one after the other.
1508
1509 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1510
1511         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
1512         https://bugs.webkit.org/show_bug.cgi?id=74413
1513
1514         Unreviewed buildfix.
1515
1516         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
1517
1518 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1519
1520         [Qt] Unreviewed speculativ debug buildfix after r102679.
1521
1522         * QtTestBrowser/QtTestBrowser.pro:
1523         * QtTestBrowser/main.cpp:
1524
1525 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1526
1527         [Qt] Get rid of layering violations in includes
1528
1529         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
1530         in the webcore.prf, but rather in each target that specificly needs
1531         headers in these location. We used to include them directly in webcore
1532         since we had layering violations between WebCore and WebKit, but now
1533         that they are gone there's no reason to do that.
1534
1535         Reviewed by Simon Hausmann.
1536
1537         * DumpRenderTree/qt/DumpRenderTree.pro:
1538         * QtTestBrowser/launcherwindow.h:
1539         * WebKitTestRunner/InjectedBundle/Target.pri:
1540         * qmake/mkspecs/features/webcore.prf:
1541         * qmake/mkspecs/features/webkit2.prf:
1542
1543 2011-12-13  János Badics  <dicska@gmail.com>
1544
1545         [NRWT] It crashes intermittently when there are WebProcess crashes
1546         https://bugs.webkit.org/show_bug.cgi?id=73451
1547
1548         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
1549
1550         Reviewed by Kenneth Rohde Christiansen.
1551
1552         * Scripts/webkitpy/layout_tests/port/server_process.py:
1553         (ServerProcess._check_for_crash):
1554
1555 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1556
1557         Unreviewed. Fix GTK+ API docs build.
1558
1559         * gtk/generate-gtkdoc:
1560         (get_webkit2_options): Ignore WebKitUIClient since it's private
1561         API.
1562
1563 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
1564
1565         Reviewed, removed one of my email addresses to use the apprpriate one.
1566
1567         * Scripts/webkitpy/common/config/committers.py:
1568
1569 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1570
1571         [Qt] Fix skip list search path and expected file search path in ORWT
1572         https://bugs.webkit.org/show_bug.cgi?id=74281
1573
1574         Expected file search path fixed.
1575
1576         Print all used skipped list and expected search path in verbose mode similar to NRWT.
1577
1578         Reviewed by Csaba Osztrogonác.
1579
1580         * Scripts/old-run-webkit-tests:
1581         (buildPlatformResultHierarchy):
1582         (buildPlatformTestHierarchy):
1583         (readSkippedFiles):
1584
1585 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1586
1587         [Qt] Missing layoutTestController.dumpWillCacheResponse
1588         https://bugs.webkit.org/show_bug.cgi?id=74287
1589
1590         Reviewed by Csaba Osztrogonác.
1591
1592         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1593         (LayoutTestController::reset):
1594         (LayoutTestController::dumpWillCacheResponse):
1595         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1596
1597 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
1598
1599         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
1600         https://bugs.webkit.org/show_bug.cgi?id=73771
1601
1602         Reviewed by Gustavo Noronha Silva.
1603
1604         When using a fallback font during testing, always use DejaVu Sans. This prevents
1605         falling back to DejaVu Serif on some systems.
1606
1607         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
1608
1609 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1610
1611         Add myself as a committer
1612
1613         * Scripts/webkitpy/common/config/committers.py:
1614
1615 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1616
1617         [Qt] [WK2] Support customizing popup menus with QML
1618         https://bugs.webkit.org/show_bug.cgi?id=73560
1619
1620         Reviewed by Tor Arne Vestbø.
1621
1622         Add an Item Selector to our WebView using the experimental API.
1623
1624         * MiniBrowser/qt/MiniBrowser.pro:
1625         * MiniBrowser/qt/MiniBrowser.qrc:
1626         * MiniBrowser/qt/qml/BrowserWindow.qml:
1627         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
1628
1629 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
1630
1631         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
1632         https://bugs.webkit.org/show_bug.cgi?id=74283
1633
1634         Reviewed by Simon Hausmann.
1635
1636         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1637         (MiniBrowserApplication::sendTouchEvent):
1638
1639 2011-12-12  Kentaro Hara  <haraken@chromium.org>
1640
1641         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
1642         to show ChangeLogs diff and open ChangeLogs in an editor
1643         https://bugs.webkit.org/show_bug.cgi?id=74266
1644
1645         Reviewed by Ryosuke Niwa.
1646
1647         We are planning to write unit-tests for prepare-ChangeLog
1648         in a run-leaks_unittest manner. This patch is one of the incremental
1649         refactorings to remove all top-level code and global variables from
1650         prepare-ChangeLog.
1651
1652         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
1653         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
1654         Renamed @changed_files to @changedFiles.
1655         Renamed %conflict_files to %conflictFiles.
1656         (generateFunctionLists):
1657         (printDiff):
1658         (openChangeLogs):
1659
1660 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1661
1662         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
1663         https://bugs.webkit.org/show_bug.cgi?id=74257
1664
1665         Reviewed by Ryosuke Niwa.
1666
1667         We are planning to write unit-tests for prepare-ChangeLog
1668         in a run-leaks_unittest/ manner. This patch is one of the incremental
1669         refactorings to remove all top-level code and global variables from
1670         prepare-ChangeLog.
1671
1672         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
1673         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
1674         into resolveConflictedChangeLogs().
1675         (getLatestChangeLogs):
1676         (resolveConflictedChangeLogs):
1677
1678 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1679
1680         [Refactoring] Move top-level code to generate a new ChangeLog into a method
1681         https://bugs.webkit.org/show_bug.cgi?id=74253
1682
1683         Reviewed by David Kilzer.
1684
1685         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
1686         which requires to remove top-level code and global variables. This patch is one of
1687         the incremental refactorings for that.
1688
1689         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
1690         (generateFunctionLists):
1691         (findChangeLogs):
1692         (generateNewChangeLogs):
1693         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
1694
1695 2011-12-10  Kentaro Hara  <haraken@chromium.org>
1696
1697         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
1698         https://bugs.webkit.org/show_bug.cgi?id=74175
1699
1700         Reviewed by Ryosuke Niwa.
1701
1702         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1703         This requires to remove top-level code. This patch is one of the incremental refactorings
1704         for that.
1705
1706         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
1707         (findChangeLogs):
1708
1709 2011-12-10  Andreas Kling  <kling@webkit.org>
1710
1711         Add my Apple e-mail to committers.py.
1712
1713         * Scripts/webkitpy/common/config/committers.py:
1714
1715 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1716
1717         chromium win build: revert build_webkit_exes_from_webkit_gyp change
1718         https://bugs.webkit.org/show_bug.cgi?id=74225
1719
1720         This change sets build_webkit_exes_from_webkit_gyp back to 1;
1721         the "All.gyp" solution doesn't work on windows.
1722
1723         * Scripts/webkitdirs.pm:
1724         (buildChromium):
1725
1726 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
1727
1728         [Qt] Click's count is limited to three continuous clicks.
1729         https://bugs.webkit.org/show_bug.cgi?id=45666
1730
1731         Reviewed by Kenneth Rohde Christiansen.
1732
1733         Update m_time at every call to leapForward, so double clicks
1734         event are correctly sent by EventSender.
1735
1736         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1737         (WTR::EventSenderProxy::updateClickCountForButton):
1738         (WTR::EventSenderProxy::leapForward):
1739
1740 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1741
1742         [Refactoring] Reduce top-level code in prepare-ChangeLog
1743         https://bugs.webkit.org/show_bug.cgi?id=74172
1744
1745         Reviewed by Ryosuke Niwa.
1746
1747         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1748         This requires to remove top-level code. This patch is one of the incremental refactorings
1749         for that.
1750
1751         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
1752         (generateFunctionLists):
1753
1754 2011-12-09  Sam Weinig  <sam@webkit.org>
1755
1756         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
1757         https://bugs.webkit.org/show_bug.cgi?id=74218
1758
1759         Reviewed by Anders Carlsson.
1760
1761         Add a test of the WKConnectionRef API.
1762
1763         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1764         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
1765         (TestWebKitAPI::didCreateConnection):
1766         (TestWebKitAPI::connectionDidReceiveMessage):
1767         (TestWebKitAPI::connectionDidClose):
1768         (TestWebKitAPI::TEST):
1769         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
1770         (TestWebKitAPI::connectionDidReceiveMessage):
1771         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
1772         (TestWebKitAPI::WKConnectionTest::initialize):
1773
1774 2011-12-09  David Levin  <levin@chromium.org>
1775
1776         Hash* iterators should allow comparison between const and const versions.
1777         https://bugs.webkit.org/show_bug.cgi?id=73370
1778
1779         Reviewed by Darin Adler.
1780
1781         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
1782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1783         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1784         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
1785         (TestWebKitAPI::TEST): Add a test for the new functionality.
1786
1787 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1788
1789         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
1790         https://bugs.webkit.org/show_bug.cgi?id=74212
1791
1792         Reviewed by Tony Chang.
1793
1794         The change introduced in r102201 to split the executables out of
1795         WebKit.gyp apparently doesn't work right on Windows, since
1796         WebKit.gyp and Tools.gyp refer to dependent projects by
1797         different relative paths (it appears gyp doesn't normalize the
1798         paths). This change moves Tools.gyp to be in the same directory
1799         as WebKit.gyp (and All.gyp), which should fix this and
1800         conveniently will also solve the problem of how to add Tools.gyp
1801         to the chromium DEPS file.
1802
1803         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
1804
1805 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1806
1807         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
1808         https://bugs.webkit.org/show_bug.cgi?id=74173
1809
1810         Reviewed by Ryosuke Niwa.
1811
1812         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1813         This requires to remove top-level code. This patch is one of the incremental refactorings
1814         for that.
1815
1816         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
1817         (fetchBugDescriptionFromURL):
1818
1819 2011-12-09  Tony Chang  <tony@chromium.org>
1820
1821         Switch the chromium mac bots to using skia test results
1822         https://bugs.webkit.org/show_bug.cgi?id=74201
1823
1824         Reviewed by Ryosuke Niwa.
1825
1826         This is reverting http://trac.webkit.org/changeset/97781 and changing
1827         the name in master.cfg to no longer have cg in the name.
1828
1829         * BuildSlaveSupport/build.webkit.org-config/config.json:
1830         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1831         (appendCustomBuildFlags):
1832         (RunWebKitTests.start):
1833
1834 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1835
1836         [Qt] Remove a wrongly placed ASSERT.
1837
1838         Reviewed by Tor Arne Vestbø.
1839
1840         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1841         (MiniBrowserApplication::notify):
1842
1843 2011-12-09  Cary Clark  <caryclark@google.com>
1844
1845         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
1846         https://bugs.webkit.org/show_bug.cgi?id=74118
1847
1848         Reviewed by Adam Barth.
1849
1850         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1851         (get):
1852         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1853         (ChromiumMacPort.__init__):
1854         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1855         (ChromiumMacPortTest.test_versions):
1856         (ChromiumMacPortTest.test_graphics_type):
1857
1858 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1859
1860         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
1861
1862         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
1863         this failed when moving files in the source tree, as the .d file would contain
1864         stale dependencies on the old source file location. By keeping the object files
1865         (and hence the depdendency files) in a proper tree structure inside the objects
1866         directory we can prevent this failure.
1867
1868         A side benefit is that we can also have objects with the same name inside the
1869         same project.
1870
1871         Reviewed by Simon Hausmann.
1872
1873         * qmake/mkspecs/features/unix/default_pre.prf:
1874
1875 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1876
1877         Unreviewed. Update unit test after r102412.
1878
1879         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1880         (IRCCommandTest.test_whois):
1881
1882 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1883
1884         REGRESSION(r102105): run-bindings-tests should output full diff results
1885         https://bugs.webkit.org/show_bug.cgi?id=74166
1886
1887         Reviewed by Adam Barth.
1888
1889         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
1890         run-bindings-tests should output full diff results.
1891
1892         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
1893         (BindingsTests.generate_from_idl):
1894         (BindingsTests.generate_supplemental_dependency):
1895         (BindingsTests.detect_changes):
1896
1897 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
1898
1899         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
1900         https://bugs.webkit.org/show_bug.cgi?id=73990
1901
1902         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
1903
1904         Fix QtQuick includes after move from QtDeclarative to QtQuick.
1905
1906         * MiniBrowser/qt/BrowserWindow.h:
1907         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1908
1909 2011-12-08  Adam Klein  <adamk@chromium.org>
1910
1911         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
1912         https://bugs.webkit.org/show_bug.cgi?id=73492
1913
1914         Reviewed by Adam Barth.
1915
1916         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
1917         keypress event without any script on the stack.
1918
1919         * DumpRenderTree/chromium/EventSender.cpp:
1920         (EventSender::EventSender):
1921         (EventSender::keyDown):
1922         (KeyDownTask::KeyDownTask):
1923         (KeyDownTask::runIfValid):
1924         (EventSender::scheduleAsynchronousKeyDown):
1925         * DumpRenderTree/chromium/EventSender.h:
1926
1927 2011-12-08  Hayato Ito  <hayato@chromium.org>
1928
1929         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
1930         https://bugs.webkit.org/show_bug.cgi?id=73980
1931
1932         Reviewed by Tony Chang.
1933
1934         * gdb/webkit.py:
1935         (guess_string_length):
1936         (ustring_to_string):
1937         (lstring_to_string):
1938         (LCharStringPrinter):
1939         (LCharStringPrinter.to_string):
1940         (WTFStringImplPrinter.get_length):
1941         (WTFStringImplPrinter.to_string):
1942         (WTFStringImplPrinter.is_8bit):
1943         (WTFStringPrinter.stringimpl_ptr):
1944         (WTFStringPrinter.get_length):
1945         (WTFStringPrinter.to_string):
1946         (add_pretty_printers.lookup_function):
1947
1948 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1949
1950         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
1951         https://bugs.webkit.org/show_bug.cgi?id=73916
1952
1953         Reviewed by Kent Tamura.
1954
1955         * qmake/mkspecs/features/features.prf:
1956
1957 2011-12-08  Adrienne Walker  <enne@google.com>
1958
1959         Unreviewed contributor additions to committers.py.
1960
1961         * Scripts/webkitpy/common/config/committers.py:
1962
1963 2011-12-08  David Reveman  <reveman@chromium.org>
1964
1965         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
1966         https://bugs.webkit.org/show_bug.cgi?id=74017
1967
1968         Reviewed by James Robinson.
1969         
1970         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
1971
1972         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1973         (main):
1974         * DumpRenderTree/chromium/TestShell.cpp:
1975         (TestShell::TestShell):
1976         (TestShell::resetWebSettings):
1977         * DumpRenderTree/chromium/TestShell.h:
1978         (TestShell::setAcceleratedPaintingEnabled):
1979         (TestShell::setPerTilePaintingEnabled):
1980         * DumpRenderTree/chromium/WebPreferences.cpp:
1981         (WebPreferences::reset):
1982         (WebPreferences::applyTo):
1983         * DumpRenderTree/chromium/WebPreferences.h:
1984         * Scripts/webkitpy/layout_tests/port/chromium.py:
1985         (ChromiumDriver._wrapper_options):
1986         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1987         (parse_args):
1988
1989 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
1990
1991         create a "SystemHost" object for webkitpy to slim down the Host object
1992         https://bugs.webkit.org/show_bug.cgi?id=72680
1993
1994         Reviewed by Eric Siedel.
1995
1996         This creates a SystemHost object that other objects that should
1997         only have dependencies on functionality in webkitpy.common.system
1998         can use; this will allow them to not require a full Host.
1999
2000         * Scripts/webkitpy/common/host.py:
2001         * Scripts/webkitpy/common/host_mock.py:
2002         * Scripts/webkitpy/common/system/systemhost.py: Added.
2003         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
2004
2005 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
2006
2007         AX: platform/mac/accessibility/search-with-frames.html crashes
2008         https://bugs.webkit.org/show_bug.cgi?id=74093
2009
2010         Reviewed by Darin Adler.
2011
2012         Take care of the case when an incoming element is null.
2013
2014         * DumpRenderTree/AccessibilityUIElement.cpp:
2015         (uiElementForSearchPredicateCallback):
2016         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2017         (AccessibilityUIElement::uiElementForSearchPredicate):
2018         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2019         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2020
2021 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
2022
2023         [Qt] Visualize mock point ID's in the MiniBrowser
2024         https://bugs.webkit.org/show_bug.cgi?id=74098
2025
2026         Reviewed by Tor Arne Vestbø.
2027
2028         * MiniBrowser/qt/BrowserWindow.cpp:
2029         (BrowserWindow::updateVisualMockTouchPoints):
2030         * MiniBrowser/qt/qml/MockTouchPoint.qml:
2031
2032 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
2033
2034         Accessibility: AccessibilityController should support listening to notifications on all elements.
2035         https://bugs.webkit.org/show_bug.cgi?id=72866
2036
2037         Adds addNotificationListener and removeNotificationListener methods
2038         to AccessibilityController, to listen to notifications on any element
2039         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
2040         implementations are all contained in this change.
2041
2042         On Mac, refactors AccessibilityNotificationHandler into its own
2043         source file that can be used by both AccessibilityController and
2044         AccessibilityUIElement. (Both DRT and WKTR.)
2045
2046         Reviewed by Chris Fleizach.
2047
2048         * DumpRenderTree/AccessibilityController.cpp:
2049         (addNotificationListenerCallback):
2050         (removeNotificationListenerCallback):
2051         (AccessibilityController::getJSClass):
2052         * DumpRenderTree/AccessibilityController.h:
2053         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2054         * DumpRenderTree/chromium/AccessibilityController.cpp:
2055         (AccessibilityController::AccessibilityController):
2056         (AccessibilityController::notificationReceived):
2057         (AccessibilityController::addNotificationListenerCallback):
2058         (AccessibilityController::removeNotificationListenerCallback):
2059         * DumpRenderTree/chromium/AccessibilityController.h:
2060         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2061         (AccessibilityController::addNotificationListener):
2062         (AccessibilityController::removeNotificationListener):
2063         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2064         (AccessibilityController::~AccessibilityController):
2065         (AccessibilityController::addNotificationListener):
2066         (AccessibilityController::removeNotificationListener):
2067         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
2068         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
2069         (-[NSString createJSStringRef]):
2070         (-[AccessibilityNotificationHandler init]):
2071         (-[AccessibilityNotificationHandler setPlatformElement:]):
2072         (-[AccessibilityNotificationHandler dealloc]):
2073         (-[AccessibilityNotificationHandler setCallback:]):
2074         (-[AccessibilityNotificationHandler startObserving]):
2075         (-[AccessibilityNotificationHandler _notificationReceived:]):
2076         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2077         (AccessibilityUIElement::addNotificationListener):
2078         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2079         (notificationListenerProc):
2080         (AccessibilityController::addNotificationListener):
2081         (AccessibilityController::removeNotificationListener):
2082         (AccessibilityController::winNotificationReceived):
2083         (AccessibilityController::winAddNotificationListener):
2084         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2085         (AccessibilityUIElement::addNotificationListener):
2086         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2087         (WTR::AccessibilityController::addNotificationListener):
2088         (WTR::AccessibilityController::removeNotificationListener):
2089         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2090         (WTR::AccessibilityController::logAccessibilityEvents):
2091         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2092         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2093         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2094         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2095         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2096         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
2097         (WTR::AccessibilityController::addNotificationListener):
2098         (WTR::AccessibilityController::removeNotificationListener):
2099         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
2100         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
2101         (-[NSString createJSStringRef]):
2102         (-[AccessibilityNotificationHandler init]):
2103         (-[AccessibilityNotificationHandler setPlatformElement:]):
2104         (-[AccessibilityNotificationHandler dealloc]):
2105         (-[AccessibilityNotificationHandler setCallback:]):
2106         (-[AccessibilityNotificationHandler startObserving]):
2107         (-[AccessibilityNotificationHandler _notificationReceived:]):
2108         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2109         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2110         (WTR::AccessibilityUIElement::verticalScrollbar):
2111         (WTR::AccessibilityUIElement::addNotificationListener):
2112         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2113
2114 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
2115
2116         [Qt][WK2] Unreviewed buildfix after r102352.
2117
2118         * qmake/mkspecs/features/webkit2.prf:
2119
2120 2011-12-08  Adam Roben  <aroben@apple.com>
2121
2122         Make finding crash logs by PID work on Snow Leopard
2123
2124         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
2125         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
2126         read the first line of the crash log and pull the PID out of there.
2127
2128         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
2129         Snow Leopard
2130
2131         Reviewed by Darin Adler.
2132
2133         * Scripts/webkitpy/common/system/crashlogs.py:
2134         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
2135         name and PID for the log, rather than checking the Lion-only app_description extended
2136         attribute. We now also reject the log if the process name doesn't match what we expect.
2137
2138         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2139         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
2140         PID.
2141         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
2142         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
2143         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
2144         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
2145         read, files that actually contain a crash log for some other process, and files that are
2146         misformatted.
2147
2148         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
2149         unused.
2150
2151         * Scripts/webkitpy/common/system/filesystem_mock.py:
2152         (MockFileSystem.__init__): Removed xattr support, which is now unused.
2153         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
2154         ReadableTextFileObject. This function was completely broken before!
2155         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
2156         bugs like the above.
2157         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
2158         things like readline() and seek().
2159
2160         (ReadableTextFileObject.close):
2161         (ReadableTextFileObject.read):
2162         Added. We override the superclass implementation to account for using a StringIO object.
2163
2164         (ReadableTextFileObject.readline):
2165         (ReadableTextFileObject.seek):
2166         Added. These just call through to StringIO.
2167
2168         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2169         (MainTest.test_crash_log):
2170         (MainTest.test_web_process_crash_log):
2171         Changed to use make_mock_crash_report_darwin.
2172
2173 2011-12-06  Jon Lee  <jonlee@apple.com>
2174
2175         [WK2] Add permissions support (73960)
2176         https://bugs.webkit.org/show_bug.cgi?id=73960
2177         <rdar://problem/10357008>
2178
2179         Reviewed by Darin Adler.
2180
2181         Add null function item to comply with added callback to WKPageUIClient.
2182
2183         * MiniBrowser/mac/BrowserWindowController.m:
2184         (-[BrowserWindowController awakeFromNib]):
2185         * WebKitTestRunner/TestController.cpp:
2186         (WTR::TestController::createOtherPage):
2187         (WTR::TestController::initialize):
2188
2189 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
2190
2191         [Qt] Visualize mock points in the Qt MiniBrowser
2192         https://bugs.webkit.org/show_bug.cgi?id=74074
2193
2194         Reviewed by Tor Arne Vestbø.
2195
2196         * MiniBrowser/qt/BrowserWindow.cpp:
2197         (BrowserWindow::updateVisualMockTouchPoints):
2198         * MiniBrowser/qt/BrowserWindow.h:
2199         * MiniBrowser/qt/MiniBrowser.qrc:
2200         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2201         (MiniBrowserApplication::notify):
2202         (MiniBrowserApplication::sendTouchEvent):
2203         * MiniBrowser/qt/MiniBrowserApplication.h:
2204         * MiniBrowser/qt/icons/touchpoint.png: Added.
2205         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
2206
2207 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
2208
2209         [Qt] WebKitTestRunner crashes with debug builds
2210         https://bugs.webkit.org/show_bug.cgi?id=74090
2211
2212         Reviewed by Tor Arne Vestbø.
2213
2214         * WebKitTestRunner/qt/TestControllerQt.cpp:
2215         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
2216         to ensure WTF/JSC threading is initialized.
2217
2218 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
2219
2220         fix build-webkit --chromium after breakage in r102201
2221         https://bugs.webkit.org/show_bug.cgi?id=74031
2222
2223         Reviewed by Tony Chang.
2224
2225         * Scripts/webkitdirs.pm:
2226         (buildChromium):
2227
2228 2011-12-08  Kentaro Hara  <haraken@chromium.org>
2229
2230         Unreviewed, rolling out r102280.
2231         http://trac.webkit.org/changeset/102280
2232         https://bugs.webkit.org/show_bug.cgi?id=74031
2233
2234         Chromium/Windows build is broken
2235
2236         * Scripts/webkitdirs.pm:
2237         (buildChromium):
2238
2239 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
2240
2241         Adding myself to committers list.
2242
2243         Unreviewed.
2244
2245         * Scripts/webkitpy/common/config/committers.py:
2246
2247 2011-12-07  Michael Saboff  <msaboff@apple.com>
2248
2249         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
2250         https://bugs.webkit.org/show_bug.cgi?id=73995
2251
2252         Reenabled failing tests that the code part of the patch fixes.
2253
2254         Reviewed by Geoffrey Garen.
2255
2256         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2257         (TestWebKitAPI::TEST):
2258
2259 2011-12-07  MORITA Hajime  <morrita@google.com>
2260
2261         [filter-build-webkit] should not emit reset color when --no-color is given
2262         https://bugs.webkit.org/show_bug.cgi?id=73992
2263
2264         Reviewed by Daniel Bates.
2265
2266         Stop printing control sequences when --no-color is given.
2267         After this change, the filter runs nicely even on environments
2268         like Emacs compilation-mode which cannot understand the control sequence.
2269
2270         * Scripts/filter-build-webkit:
2271         (printLine):
2272
2273 2011-12-07  Eric Seidel  <eric@webkit.org>
2274
2275         Use free memory to determine if we have space for DRT instances instead of total memory
2276         https://bugs.webkit.org/show_bug.cgi?id=74021
2277
2278         Reviewed by Adam Barth.
2279
2280         This will hopefully make the Mac buildbots behave better.
2281
2282         I also reduced the expected memory needed per DRT now that
2283         we're properly accounting for the system memory in our calculations.
2284
2285         * Scripts/webkitpy/common/system/platforminfo.py:
2286         (PlatformInfo.total_bytes_memory):
2287         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
2288         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2289         (MockPlatformInfo.total_bytes_memory):
2290         * Scripts/webkitpy/layout_tests/port/base.py:
2291         (Port.default_child_processes):
2292         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2293         (PortTest.test_default_child_processes):
2294
2295 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
2296
2297         fix build-webkit --chromium after breakage in r102201
2298         https://bugs.webkit.org/show_bug.cgi?id=74031
2299
2300         Reviewed by Tony Chang.
2301
2302         r102201 introduced a change to the chromium build that splits
2303         the executables out of WebKit.gyp into other gyp files, and adds
2304         a new "All.gyp" that builds everything. However, I forgot to
2305         update the build script to use All.gyp.
2306
2307         * Scripts/webkitdirs.pm:
2308         (buildChromium):
2309
2310 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
2311
2312         Moved myself to the committers list.
2313
2314         * Scripts/webkitpy/common/config/committers.py:
2315
2316 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2317
2318         [Qt] Fix debug shlib build with V8.
2319
2320         Reviewed by Tor Arne Vestbø.
2321
2322         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
2323         v8 builds.
2324
2325 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2326
2327         [Qt] V8 build fixes.
2328
2329         Reviewed by Tor Arne Vestbø.
2330
2331         * qmake/mkspecs/features/javascriptcore.prf: Don't add
2332         Source/Thirdparty to the include search path here.
2333         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
2334         used when building WebCore as well as using it, because header files like
2335         GraphicsContext3D.h include stuff from ThirdParty.
2336
2337 2011-12-07  Peter Beverloo  <peter@chromium.org>
2338
2339         [Chromium] Fix project file generation for the Android bot after r102201
2340         https://bugs.webkit.org/show_bug.cgi?id=73996
2341
2342         The gyp refactoring in r102201 was didn't explicitly exclude
2343         the Android operating system in Tools/Tools.gyp, which broke
2344         as gcc_version is not defined for that configuration.
2345
2346         Reviewed by Andreas Kling.
2347
2348         * Tools.gyp:
2349
2350 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
2351
2352         Unreviewed. Disabled failing tests on chromium.
2353
2354         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2355         (TestWebKitAPI::TEST):
2356
2357 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
2358
2359         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
2360         https://bugs.webkit.org/show_bug.cgi?id=73382
2361
2362         Reviewed by Tony Chang.
2363
2364         XCode (and hence GYP) can't handle circular dependencies between
2365         files (and projects). Accordingly, although the binaries in
2366         WebKit.gyp depend on webkit_support and webkit_support depends
2367         on webkit, we don't mention the latter dependency in the file.
2368         To fix this, this change moves the binaries like DRT into a new
2369         GYP file, and modifies gyp_webkit to build from that file
2370         instead of WebKit.gyp.
2371
2372         * Tools.gyp: Added.
2373
2374 2011-12-06  Adam Roben  <aroben@apple.com>
2375
2376         Add a pid parameter to CrashLogs.find_newest_log
2377
2378         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
2379         considered.
2380
2381         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
2382         process whose crash log you want to find
2383
2384         Reviewed by Dirk Pranke.
2385
2386         * Scripts/webkitpy/common/system/crashlogs.py:
2387         (CrashLogs.find_newest_log): Added an optional pid parameter.
2388         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
2389         candidate log's app_description extended attribute to see if that log corresponds to a
2390         crashed process with the specified PID.
2391
2392         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2393         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
2394         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
2395         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
2396
2397         * Scripts/webkitpy/common/system/filesystem.py:
2398         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
2399         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
2400         present.
2401
2402         * Scripts/webkitpy/common/system/filesystem_mock.py:
2403         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
2404         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
2405         dictionary.
2406
2407         * Scripts/webkitpy/tool/commands/queries.py:
2408         (CrashLog): Added help text. Added an optional PID parameter.
2409         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
2410
2411 2011-12-06  Adam Roben  <aroben@apple.com>
2412
2413         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
2414
2415         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
2416         alive beyond the normal timeout limit. In cases where the crashed process was able to die
2417         faster, NRWT would assume that Crash Reporter had finished even though it often was still
2418         running, which would lead to an incorrect crash log being picked up.
2419
2420         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
2421
2422         Reviewed by Dirk Pranke.
2423
2424         * Scripts/webkitpy/layout_tests/port/server_process.py:
2425         (ServerProcess._reset):
2426         (ServerProcess.write):
2427         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
2428         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
2429         set_crashed.
2430
2431         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
2432         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
2433         we bail out of handling the failure as a timeout if we find out that the process in fact
2434         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
2435         so.
2436         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
2437         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
2438         disk.
2439
2440         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2441         (TrivialMockPort.is_crash_reporter): Added.
2442
2443         * Scripts/webkitpy/layout_tests/port/webkit.py:
2444         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
2445         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
2446
2447 2011-12-06  Adam Barth  <abarth@webkit.org>
2448
2449         NRWT fails on unreleased versions of Mac OS X
2450         https://bugs.webkit.org/show_bug.cgi?id=72748
2451
2452         Reviewed by Dirk Pranke.
2453
2454         Hopefully this patch will make NRWT work on future versions on Mac OS X.
2455         Most of the infrastructure was already in place, but there were some
2456         asserts that failed.  I've tested this patch by haxoring the version
2457         detection logic to simulate an unknown version.  We might need to
2458         iterate based on feedback from folks with a real future version.
2459
2460         * Scripts/webkitpy/layout_tests/port/apple.py:
2461         (ApplePort.__init__):
2462             - mac-future is an allowed port_name that's used internally by
2463               webkitpy to represent future versions of Mac OS X.
2464         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2465         (test_versions):
2466             - Test that we don't throw exceptions when dealing with future
2467               versions of Mac OS X.
2468         * Scripts/webkitpy/layout_tests/port/webkit.py:
2469         (WebKitPort._expectations_from_skipped_files):
2470             - Demote this logging message to "debug".  It's expected that
2471               mac-future doesn't have a Skipped file.
2472         * Scripts/webkitpy/layout_tests/port/mac.py:
2473         (MacPort.__init__):
2474         * Scripts/webkitpy/layout_tests/port/win.py:
2475         (WinPort.__init__):
2476             - Re-order some code in these constructors so that
2477               self._operating_system is available to the ApplePort constructor.
2478
2479 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
2480
2481         Added myself as a committer.
2482
2483         * Scripts/webkitpy/common/config/committers.py:
2484
2485 2011-12-06  Peter Beverloo  <peter@chromium.org>
2486
2487         Added myself as a committer.
2488
2489         * Scripts/webkitpy/common/config/committers.py:
2490
2491 2011-12-06  Kentaro Hara  <haraken@chromium.org>
2492
2493         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
2494         https://bugs.webkit.org/show_bug.cgi?id=73637
2495
2496         Reviewed by Adam Barth.
2497
2498         This patch replaces subprocess.Popen() with Executive, similar to other
2499         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
2500         works well for cases where no exception is raised, no exception is raised
2501         but diff is found, and ScriptError is raised.
2502
2503         * Scripts/run-bindings-tests:
2504         (main):
2505         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
2506         (BindingsTests.__init__):
2507         (BindingsTests.generate_from_idl):
2508         (BindingsTests.generate_supplemental_dependency):
2509         (BindingsTests.detect_changes):
2510
2511 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
2512
2513         [Qt] MiniBrowser should default to touch behavior
2514         https://bugs.webkit.org/show_bug.cgi?id=73863
2515
2516         Reviewed by Chang Shu.
2517
2518         MiniBrowser currently defaults to the traditional desktop behaviour
2519         instead of touch behaviour which is prefered.
2520
2521         * MiniBrowser/qt/BrowserWindow.cpp:
2522         (BrowserWindow::BrowserWindow):
2523         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2524         (printHelp):
2525         (MiniBrowserApplication::handleUserOptions):
2526         * MiniBrowser/qt/MiniBrowserApplication.h:
2527         (WindowOptions::WindowOptions):
2528         (WindowOptions::setUseTraditionalDesktopBehavior):
2529         (WindowOptions::useTraditionalDesktopBehavior):
2530
2531 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2532
2533         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
2534         https://bugs.webkit.org/show_bug.cgi?id=73878
2535
2536         Reviewed by Tony Chang.
2537
2538         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
2539         r98785 made webkit.py always use m_data16, which does not work when
2540         the string is an 8-bit string (such as KURL::string()).
2541
2542         I was not able to directly call StringImpl::is8Bit() in the Python
2543         code, so I just reproduced the implementation there.
2544
2545         * gdb/webkit.py:
2546         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2547         (WTFStringPrinter.to_string):
2548         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2549         (JSCUStringPrinter.to_string):
2550
2551 2011-12-05  Eric Seidel  <eric@webkit.org>
2552
2553         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
2554         in hopes of making the Snow Leopard bot stop timing out.
2555
2556         Unreviewed.
2557
2558         * Scripts/webkitpy/layout_tests/port/base.py:
2559         (Port.default_child_processes):
2560         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2561         (PortTest.test_default_child_processes):
2562
2563 2011-12-05  Eric Seidel  <eric@webkit.org>
2564
2565         NRWT creates too many workers on RAM-limited machines
2566         https://bugs.webkit.org/show_bug.cgi?id=73847
2567
2568         Reviewed by Dirk Pranke.
2569
2570         Make NRWT restrict its number of workers when there isn't enough
2571         RAM to support them.
2572         Also re-enable parallel testing on the Mac bots which were
2573         failing due to not enough ram.
2574
2575         * Scripts/run-webkit-tests:
2576         (platformIsReadyForParallelTesting):
2577         * Scripts/webkitpy/common/host.py:
2578         (Host.__init__):
2579         * Scripts/webkitpy/common/system/executive_mock.py:
2580         (MockExecutive.cpu_count):
2581         * Scripts/webkitpy/common/system/platforminfo.py:
2582         (PlatformInfo.__init__):
2583         (PlatformInfo.display_name):
2584         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2585         (MockPlatformInfo.display_name):
2586         * Scripts/webkitpy/layout_tests/port/base.py:
2587         (Port.default_child_processes):
2588         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2589         (PortTest.test_default_child_processes):
2590         (PortTest.test_pretty_patch_os_error):
2591
2592 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
2593
2594         Last mouse event could be lost if a JS call to eventSender.leapForward is made
2595         https://bugs.webkit.org/show_bug.cgi?id=73366
2596
2597         Reviewed by Kenneth Rohde Christiansen.
2598
2599         Empty the entire event queue when requested besides using
2600         sendEvent instead of postEvent to make sure all events were
2601         delivered.
2602
2603         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2604         (WTR::EventSenderProxy::EventSenderProxy):
2605         (WTR::EventSenderProxy::sendOrQueueEvent):
2606         (WTR::EventSenderProxy::replaySavedEvents):
2607
2608 2011-12-05  Adam Barth  <abarth@webkit.org>
2609
2610         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
2611         https://bugs.webkit.org/show_bug.cgi?id=73845
2612
2613         Reviewed by Darin Fisher.
2614
2615         Update includes to point to the new header locations.
2616
2617         * DumpRenderTree/chromium/AccessibilityController.cpp:
2618         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2619         * DumpRenderTree/chromium/CppBoundClass.cpp:
2620         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2621         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2622         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2623         * DumpRenderTree/chromium/EventSender.cpp:
2624         * DumpRenderTree/chromium/EventSender.h:
2625         * DumpRenderTree/chromium/GamepadController.h:
2626         * DumpRenderTree/chromium/LayoutTestController.cpp:
2627         * DumpRenderTree/chromium/LayoutTestController.h:
2628         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2629         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2630         * DumpRenderTree/chromium/PlainTextController.cpp:
2631         * DumpRenderTree/chromium/Task.cpp:
2632         * DumpRenderTree/chromium/TestNavigationController.h:
2633         * DumpRenderTree/chromium/TestShell.cpp:
2634         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2635         * DumpRenderTree/chromium/TestWebPlugin.h:
2636         * DumpRenderTree/chromium/TextInputController.cpp:
2637         * DumpRenderTree/chromium/WebPermissions.cpp:
2638         * DumpRenderTree/chromium/WebPreferences.h:
2639         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2640         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2641         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2642         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2643         * DumpRenderTree/chromium/WebViewHost.cpp:
2644
2645 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2646
2647         Add Aharon Lanin to the contributors list.
2648
2649         * Scripts/webkitpy/common/config/committers.py:
2650
2651 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
2652
2653         Moving myself from contributors to committers.
2654
2655         * Scripts/webkitpy/common/config/committers.py:
2656
2657 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2658
2659         Add myself as a committer.
2660
2661         * Scripts/webkitpy/common/config/committers.py:
2662
2663 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
2664
2665         [Qt] Rename QQuickWebView::canStop property to just loading 
2666         https://bugs.webkit.org/show_bug.cgi?id=73813
2667
2668         Reviewed by Kenneth Rohde Christiansen.
2669
2670         Replaced references to WebView.canStop with WebView.loading.
2671
2672         * MiniBrowser/qt/qml/BrowserWindow.qml:
2673
2674 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
2675
2676         run-webkit-tests: limit --child-processes properly on apple mac
2677         https://bugs.webkit.org/show_bug.cgi?id=73856
2678
2679         Reviewed by Adam Roben.
2680
2681         Fix typos in r102013 so that we correctly pass --child-processes=1 on
2682         the apple mac bots temporarily.
2683
2684         * Scripts/run-webkit-tests:
2685         (platformIsReadyForParallelTesting):
2686
2687 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2688
2689         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
2690         https://bugs.webkit.org/show_bug.cgi?id=73840
2691
2692         Reviewed by Simon Fraser.
2693
2694         Temporarily go back to single process mode on Mac.
2695
2696         * Scripts/run-webkit-tests:
2697         (platformIsReadyForParallelTesting):
2698
2699 2011-12-05  Adam Roben  <aroben@apple.com>
2700
2701         Redeploy apple-macpro-7 and apple-xserve-1
2702
2703         These slaves have been sitting idle since we removed our Leopard builders in r97496.
2704
2705         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
2706         sitting idle
2707
2708         Reviewed by Sam Weinig.
2709
2710         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
2711         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
2712         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
2713         (WebKit2 Tests)".
2714
2715 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2716
2717         [Qt] Make the UI of the MiniBrowser slightly nicer
2718
2719         Rubberstamped by Simon Hausmann.
2720
2721         - Add proper padding
2722         - Show feedback when pressing on the toolbar icons
2723         - Make the text entry better looking
2724
2725         * MiniBrowser/qt/qml/BrowserWindow.qml:
2726
2727 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2728
2729         NRWT should handle duplicated expectations
2730         https://bugs.webkit.org/show_bug.cgi?id=69750
2731
2732         Reviewed by Dirk Pranke.
2733
2734         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2735         (TestExpectations.__init__):
2736         (TestExpectations._report_errors):
2737         (TestExpectations._add_expectations):
2738         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2739         (test_add_skipped_tests):
2740         * Scripts/webkitpy/layout_tests/port/base.py:
2741         (Port.skipped_tests):
2742         * Scripts/webkitpy/layout_tests/port/webkit.py:
2743         (WebKitPort.test_expectations):
2744         (WebKitPort.skipped_tests):
2745         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2746         (test_test_expectations):
2747
2748 2011-12-04  Eric Seidel  <eric@webkit.org>
2749
2750         After success with Mac, Win and Gtk, turning on parallel testing
2751         by default for all platforms (except Qt).
2752
2753         We'll add more platforms to the blacklist if we see problems.
2754
2755         Unreviewed.
2756
2757         * Scripts/run-webkit-tests:
2758         (platformIsReadyForParallelTesting):
2759
2760 2011-12-04  Sam Weinig  <sam@webkit.org>
2761
2762         Add tests for RetainPtr::adoptNS/adoptCF
2763         https://bugs.webkit.org/show_bug.cgi?id=73470
2764
2765         Reviewed by Adam Roben and Darin Adler.
2766
2767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2768         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
2769         (TestWebKitAPI::TEST):
2770         Test that adopting using adoptCF creates a RetainPtr with a
2771         value whose retain count is 1.
2772
2773         * TestWebKitAPI/Tests/WTF/ns: Added.
2774         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
2775         (TestWebKitAPI::TEST):
2776         Test that adopting using adoptNS creates a RetainPtr with a
2777         value whose retain count is 1.
2778
2779 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
2780
2781         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
2782         https://bugs.webkit.org/show_bug.cgi?id=73748
2783
2784         Reviewed by Gustavo Noronha Silva.
2785
2786         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
2787
2788 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2789
2790         Another GTK build fix after r101922.
2791
2792         Rubber-stamped by Martin Robinson.
2793
2794         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2795         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
2796
2797 2011-12-04  Xan Lopez  <xlopez@igalia.com>
2798
2799         Fix compiler warning in LayoutTestController
2800
2801         Reviewed by Philippe Normand.
2802
2803         * DumpRenderTree/LayoutTestController.cpp:
2804         (LayoutTestController::LayoutTestController): fix warning.
2805
2806 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
2807
2808         Add missing methods used by fast/notifications tests to LayoutTestController
2809         https://bugs.webkit.org/show_bug.cgi?id=63616
2810
2811         Reviewed by Martin Robinson.
2812
2813         Add missing simulateDesktopNotificationClick method used by
2814         fast/notifications. Provide a default implementation for
2815         areDesktopNotificationPermissionRequestsIgnored and
2816         ignoreDesktopNotificationPermissionRequests.
2817
2818         * DumpRenderTree/LayoutTestController.cpp:
2819         (LayoutTestController::LayoutTestController): call into the port implementation.
2820         (simulateDesktopNotificationClickCallback): ditto.
2821         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
2822         (LayoutTestController::staticFunctions): declare new methods.
2823         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
2824         * DumpRenderTree/LayoutTestController.h:
2825         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
2826         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2827         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
2828         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2829         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2830         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2831         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2832         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2833         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2834         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2835         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2836
2837 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
2838
2839         [GTK] Don't log document events in DRT
2840         https://bugs.webkit.org/show_bug.cgi?id=73746
2841
2842         Reviewed by Martin Robinson.
2843
2844         Stop connecting globally to document-related events.
2845
2846         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2847         (connectAccessibilityCallbacks): Removed connections.
2848         (disconnectAccessibilityCallbacks): Removed disconnections.
2849
2850 2011-12-03  Dan Bernstein  <mitz@apple.com>
2851
2852         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
2853
2854         Reviewed by Darin Adler.
2855
2856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2857         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
2858         (TestWebKitAPI::TEST):
2859
2860 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2861
2862         Another GTK build fix after r101922.
2863
2864         Rubber-stamped by Martin James Robinson.
2865
2866         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2867         (LayoutTestController::pathToLocalResource): return value needs to
2868         be a URI.
2869
2870 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2871
2872         Small fix for my previous patch. Do not try to delete a member
2873         of a dictionary that does not exist.
2874
2875         Reviewed by Gustavo Noronha Silva.
2876
2877         * gtk/run-with-jhbuild:
2878         (install_and_run_jhbuild):
2879
2880 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2881
2882         Fix jhbuild installation for people who have unusual MAKE environment
2883         variables such as 'make -j4' as the jhbuild build does not handle it.
2884
2885         Reviewed by Gustavo Noronha Silva.
2886
2887         * gtk/run-with-jhbuild:
2888         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
2889
2890 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2891
2892         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
2893         when run for the first time.
2894
2895         Reviewed by Gustavo Noronha Silva.
2896
2897         * Scripts/update-webkitgtk-libs: Fix first run.
2898
2899 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2900
2901         Unreviewed, GTK build fix after r101922.
2902
2903         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2904         (LayoutTestController::pathToLocalResource): Added sentinel in
2905         g_build_filename call.
2906
2907 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2908
2909         GTK API tests build fix. Run the tests inside jhbuild.
2910
2911         Rubber-stamped by Gustavo Noronha Silva.
2912
2913         * Scripts/run-gtk-tests:
2914         (TestRunner.__init__):
2915         (TestRunner.run._error_handler):
2916         (TestRunner):
2917         (TestRunner.run):
2918
2919 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2920
2921         Small build fix. Properly specify the path to the locally installed jhbuild.
2922
2923         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
2924
2925 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
2926
2927         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2928         https://bugs.webkit.org/show_bug.cgi?id=67256
2929
2930         Reviewed by Philippe Normand.
2931
2932         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
2933         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
2934         which points to the more generic top-level path of the WebKit checkout. This code is
2935         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
2936         share code here.
2937
2938         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
2939         location. This will cause the fallback to fail if you build into a non-typical location
2940         or even fake it with a symlink. In this case it's important to use the environment variable.
2941
2942         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2943         (getTopLevelPath): Added.
2944         (initializeFonts): Use the new helper to get the font path.
2945         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
2946         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2947         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
2948         test paths.
2949         * Scripts/webkitpy/layout_tests/port/gtk.py:
2950         (GtkPort.setup_environ_for_server):Pass the top-level path of the
2951         checkout instead of passing the font path.
2952         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2953         (WTR::getTopLevelPath): Added this helper.
2954         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
2955
2956 2011-12-02  David Levin  <levin@chromium.org>
2957
2958         Rename WTF class from TemporarilyChange to TemporaryChange.
2959         https://bugs.webkit.org/show_bug.cgi?id=73479
2960
2961         Reviewed by Eric Seidel.
2962
2963         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
2964         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
2965         * TestWebKitAPI/TestWebKitAPI.gypi:
2966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2967         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
2968         (TestWebKitAPI::TEST):
2969         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2970
2971 2011-12-02  Tony Chang  <tony@chromium.org>
2972
2973         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
2974         https://bugs.webkit.org/show_bug.cgi?id=73453
2975
2976         Reviewed by Ryosuke Niwa.
2977
2978         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
2979         The verbose output will include the failure reason.
2980
2981         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
2982         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2983         (write_test_result):
2984         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
2985         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
2986         (determine_result_type):
2987         (FailureReftestNoImagesGenerated.__init__):
2988         (FailureReftestNoImagesGenerated):
2989         (FailureReftestNoImagesGenerated.message):
2990         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
2991         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
2992         (MainTest.test_run_singly_actually_runs_tests):
2993         (MainTest.test_unexpected_failures):
2994         (EndToEndTest.test_end_to_end):
2995
2996 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
2997
2998         ChangeLog should be able to parse annotated changelogs
2999         https://bugs.webkit.org/show_bug.cgi?id=72703
3000
3001         Reviewed by Eric Seidel.
3002
3003         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
3004         and extract the revision number for each entry.
3005
3006         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
3007
3008         * Scripts/webkitpy/common/checkout/changelog.py:
3009         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3010         * Scripts/webkitpy/common/checkout/scm/git.py:
3011         * Scripts/webkitpy/common/checkout/scm/scm.py:
3012         * Scripts/webkitpy/common/checkout/scm/svn.py:
3013
3014 2011-12-02  Eric Seidel  <eric@webkit.org>
3015
3016         Enable parallel testing for Win and Gtk bots
3017         after confirming with Lucas and Martin the bots should be OK.
3018
3019         Unreviewed. (I ran the idea by Lucas and Martin.)
3020
3021         * Scripts/run-webkit-tests:
3022         (platformIsReadyForParallelTesting):
3023
3024 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3025
3026         Try to fix the GTK+ build.
3027
3028         * gtk/jhbuild.modules: Properly specify the glib-networking
3029         dependency for soup.
3030
3031 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3032
3033         Fix a syntax error in the committers.py file.
3034
3035         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
3036
3037 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
3038
3039         Add Alan Stearns and Peter Linss to the contributors list.
3040
3041         * Scripts/webkitpy/common/config/committers.py:
3042
3043 2011-12-02  Kent Tamura  <tkent@chromium.org>
3044
3045         [Chromium] Fix compilation warnings for ASSERT()
3046         https://bugs.webkit.org/show_bug.cgi?id=73623
3047
3048         Reviewed by Tony Chang.
3049
3050         * DumpRenderTree/chromium/ImageDiff.cpp:
3051          - Fix fprintf format: %s -> %d for __LINE__
3052          - Do nothing for ASSERT() if NDEBUG.
3053
3054 2011-12-02  Eric Seidel  <eric@webkit.org>
3055
3056         Enable parallel testing for all Mac bots.
3057
3058         Unreviewed.
3059
3060         * Scripts/run-webkit-tests:
3061         (platformIsReadyForParallelTesting):
3062
3063 2011-12-02  Eric Seidel  <eric@webkit.org>
3064
3065         Enable parallel testing for run-webkit-tests on Mac Lion.
3066         I plan to move all the machines to parallel testing shortly
3067         but we're starting with Lion.
3068
3069         Unreviewed.
3070
3071         * Scripts/run-webkit-tests:
3072         (platformIsReadyForParallelTesting):
3073
3074 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3075
3076         Added helper method to identify whether the page has custom page size style.
3077         https://bugs.webkit.org/show_bug.cgi?id=73585
3078
3079         Reviewed by Darin Fisher.
3080
3081         * DumpRenderTree/chromium/LayoutTestController.cpp:
3082         (LayoutTestController::LayoutTestController):
3083         (LayoutTestController::hasCustomPageSizeStyle):
3084         * DumpRenderTree/chromium/LayoutTestController.h:
3085
3086 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3087
3088         [NRWT] reftest should support having multiple references per test
3089         https://bugs.webkit.org/show_bug.cgi?id=73613
3090
3091         Reviewed by Dirk Pranke.
3092
3093         Add a support for having multiple reference files for a single test.
3094
3095         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
3096         at least one of expected mismatches, we compare expected mismatches first in order to minimize
3097         the number of reference files to open on DRT.
3098
3099         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3100         (interpret_test_failures): Remove checks no longer applicable.
3101         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3102         (ResultSummaryTest.test_interpret_test_failures): Ditto.
3103         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3104         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
3105         (SingleTestRunner._driver_input):
3106         (SingleTestRunner.run):
3107         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
3108         * Scripts/webkitpy/layout_tests/models/test_input.py:
3109         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
3110         * Scripts/webkitpy/layout_tests/port/base.py:
3111         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
3112         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
3113         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3114         (PortTest.test_parse_reftest_list):
3115         * Scripts/webkitpy/layout_tests/port/test.py:
3116         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3117         (MainTest.test_unexpected_failures):
3118         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
3119         (EndToEndTest.test_end_to_end):
3120         (EndToEndTest.test_reftest_with_two_notrefs): Added.
3121
3122 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3123
3124         Build libsoup without gnome dependencies (like keyring).
3125
3126         * gtk/jhbuild.modules:
3127
3128 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3129
3130         Also build gcrypt and p11-kit, and make them dependencies of
3131         gnutls.
3132
3133         * gtk/jhbuild.modules:
3134
3135 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
3136
3137         [wx] Unreviewed build fixes for Windows build.
3138
3139         * waf/build/wxpresets.py:
3140
3141 2011-12-01  Eric Seidel  <eric@webkit.org>
3142
3143         Reviewed by Adam Barth.
3144
3145         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
3146         https://bugs.webkit.org/show_bug.cgi?id=32006
3147
3148         I decided not to make it warn, and just have it re-open the bug.
3149         That's not that different from today's behavior which will
3150         just silently attach the patch.
3151
3152         This patch makes behavior between upload and land-safely consistent
3153         (previously one would assign patches and the other would not)
3154         as well as adds the ability for both to ensure that the bug is open.
3155
3156         To test this I had to add a few more methods to MockBugzilla which
3157         (positively) affected a few other test results.
3158
3159         I also made AbstractStep keep a cached copy of the Bug object
3160         and used the cached copy where appropriate (including for 'bug_title').
3161         This should reduce the number of bug fetches we perform.
3162
3163         * Scripts/webkitpy/tool/commands/download_unittest.py:
3164         * Scripts/webkitpy/tool/commands/upload.py:
3165         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3166         * Scripts/webkitpy/tool/mocktool.py:
3167         * Scripts/webkitpy/tool/steps/__init__.py:
3168         * Scripts/webkitpy/tool/steps/abstractstep.py:
3169         * Scripts/webkitpy/tool/steps/closebug.py:
3170         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
3171         * Scripts/webkitpy/tool/steps/postdiff.py:
3172         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3173         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3174         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3175         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3176
3177 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3178
3179         Also pass --no-interact to jhbuild when updating dependencies.
3180
3181         * Scripts/update-webkitgtk-libs:
3182
3183 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
3184
3185         Make _build_path check more thoroughly that build paths exist.
3186         https://bugs.webkit.org/show_bug.cgi?id=73601
3187
3188         Reviewed by Ojan Vafai.
3189
3190         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3191         (ChromiumMacPort._build_path):
3192
3193 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3194
3195         Add libffi to the jhbuild modules list as a glib dependency.
3196
3197         Rubber-stamped by Martin Robinson.
3198
3199         * gtk/jhbuild.modules:
3200
3201 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3202
3203         Build fix. Use internal pcre on glib, make gnutls a dependency of
3204         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
3205         in non-interactive mode.
3206
3207         * Scripts/update-webkitgtk-libs:
3208         * gtk/jhbuild.modules:
3209         * gtk/run-with-jhbuild:
3210
3211 2011-12-02  Adam Roben  <aroben@apple.com>
3212
3213         Fix for Python 2.6
3214
3215         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3216         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
3217         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
3218         searching for "Tests that timed out:" etc. This makes our check less strict, but it
3219         shouldn't matter given the kinds of content we parse.
3220
3221 2011-12-02  Adam Roben  <aroben@apple.com>
3222
3223         Fix names of failed/timed out tests in run-api-tests output
3224
3225         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
3226         out tests
3227
3228         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
3229
3230         Reviewed by Simon Fraser.
3231
3232         * Scripts/run-api-tests:
3233         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
3234         of this function.
3235
3236 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
3237
3238         [GTK] generate-gtkdoc should respect build type
3239         https://bugs.webkit.org/show_bug.cgi?id=73296
3240
3241         Reviewed by Philippe Normand.
3242
3243         * Scripts/webkitdirs.pm:
3244         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
3245         * gtk/common.py: If --build is passed give preference to the Debug build directory.
3246
3247 2011-12-02  Tony Chang  <tony@chromium.org>
3248
3249         [nrwt] fix wdiff output
3250         https://bugs.webkit.org/show_bug.cgi?id=73604
3251
3252         Reviewed by Adam Barth.
3253
3254         * Scripts/webkitpy/layout_tests/port/base.py:
3255         (Port.wdiff_text):
3256         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3257         (PortTest.test_wdiff_text):
3258
3259 2011-12-02  Adam Roben  <aroben@apple.com>
3260
3261         Teach build.webkit.org to display how many unit tests failed or timed out
3262
3263         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
3264         build.webkit.org
3265
3266         We now display something like "5 unit tests failed or timed out". Eventually we might want
3267         to split out how many failure vs. timeouts there were.
3268
3269         Reviewed by Darin Adler.
3270
3271         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3272         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
3273         classes that may want to subclass it.
3274         (RunUnitTests): Changed to inherit from TestWithFailureCount.
3275         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
3276         timed out:" and "Tests that failed:" lines, if present.
3277
3278         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3279         (StubStdio):
3280         (StubRemoteCommand):
3281         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
3282
3283         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
3284         the test run correctly.
3285
3286         (RunUnitTestsTest.test_no_failures_or_timeouts):
3287         (RunUnitTestsTest.test_one_failure):
3288         (RunUnitTestsTest.test_multiple_failures):
3289         (RunUnitTestsTest.test_one_timeout):
3290         (RunUnitTestsTest.test_multiple_timeouts):
3291         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
3292         Test various cases.
3293
3294 2011-12-02  Adam Roben  <aroben@apple.com>
3295
3296         Teach prepare-ChangeLog to treat master.cfg as a Python file
3297
3298         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
3299         in buildbot's master.cfg
3300
3301         Reviewed by Darin Adler.
3302
3303         * Scripts/prepare-ChangeLog:
3304         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
3305         master.cfg.
3306
3307 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3308
3309         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
3310         https://bugs.webkit.org/show_bug.cgi?id=73669
3311
3312         Reviewed by Gustavo Noronha Silva.
3313
3314         Add a wrapper script that knows how to install jhbuild and also to wrap commands
3315         in the jhbuild shell.
3316
3317         * Scripts/webkitdirs.pm:
3318         (runAutogenForAutotoolsProject): Use the new wrapper script.
3319         (mustReRunAutogen): Ditto.
3320         (buildAutotoolsProject): Ditto.
3321         * Scripts/webkitpy/layout_tests/port/gtk.py:
3322         (GtkDriver.cmd_line): Ditto.
3323         * gtk/run-with-jhbuild: Added.
3324
3325 2011-12-01  Adam Roben  <aroben@apple.com>
3326
3327         Teach check-webkit-style how to check the syntax of JSON files
3328
3329         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3330
3331         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
3332         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
3333         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
3334         been removed, since its output differs by platform.
3335
3336         Reviewed by Darin Adler.
3337
3338         * Scripts/webkitpy/style/checker.py:
3339         (_all_categories): Added JSONChecker's categories to the set of all categories.
3340         (FileType): Added a JSON type. Incremented other types.
3341         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3342         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3343
3344         * Scripts/webkitpy/style/checker_unittest.py:
3345         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3346         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3347
3348         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3349         which would have matched our other checkers, because I couldn't figure out how to call
3350         "json.loads" without hitting namespace conflicts.)
3351         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3352         just the modified lines from a patch.
3353         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3354         exception.
3355         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3356         try to extract a line number.
3357
3358         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3359         (MockErrorHandler.__init__):
3360         (MockErrorHandler.turn_off_line_filtering):
3361         (MockErrorHandler.__call__):
3362         Helper class. Copied from xml_unittest.py.
3363
3364         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3365         line_number_from_json_exception helper method.
3366
3367         (JSONCheckerTest.assert_no_error):
3368         (JSONCheckerTest.assert_error):
3369         Helper methods to assert that we did or didn't get an error.
3370
3371         (JSONCheckerTest.mock_handle_style_error): Helper method.
3372
3373         (JSONCheckerTest.test_conflict_marker):
3374         (JSONCheckerTest.test_single_quote):
3375         (JSONCheckerTest.test_init):
3376         (JSONCheckerTest.test_no_error):
3377         Test various cases.
3378
3379 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3380
3381         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
3382         https://bugs.webkit.org/show_bug.cgi?id=73664
3383
3384         Reviewed by Martin Robinson.
3385
3386         This patch adds our HTTP library and its main dependencies; this
3387         should not affect layout or rendering.
3388
3389         * gtk/jhbuild.modules:
3390
3391 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3392
3393         [GTK] Also run DumpRenderTree under jhbuild
3394         https://bugs.webkit.org/show_bug.cgi?id=73646
3395
3396         Reviewed by Martin Robinson.
3397
3398         * Scripts/webkitpy/layout_tests/port/gtk.py:
3399         (GtkDriver.cmd_line):
3400
3401 2011-12-02  Hajime Morrita  <morrita@chromium.org>
3402
3403         Unreviewed, rolling out r101751 and r101775.
3404         http://trac.webkit.org/changeset/101751
3405         http://trac.webkit.org/changeset/101775
3406         https://bugs.webkit.org/show_bug.cgi?id=73191
3407
3408         breaks Windows build
3409
3410         * DumpRenderTree/chromium/config.h:
3411         * DumpRenderTree/config.h:
3412         * TestWebKitAPI/config.h:
3413         * WebKitTestRunner/config.h:
3414
3415 2011-12-02  Kentaro Hara  <haraken@chromium.org>
3416
3417         Move run-bindings-tests implementation to webkitpy/bindings/main.py
3418         https://bugs.webkit.org/show_bug.cgi?id=73619
3419
3420         Reviewed by Adam Barth.
3421
3422         As run-bindings-tests has been growing, this patch just moves its implementation
3423         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
3424
3425         No change in behavior.
3426
3427         * Scripts/run-bindings-tests:
3428         (main):
3429         * Scripts/webkitpy/bindings/__init__.py: Added.
3430         * Scripts/webkitpy/bindings/main.py: Added.
3431         (BindingsTests.__init__):
3432         (BindingsTests.generate_from_idl):
3433         (BindingsTests.generate_supplemental_dependency):
3434         (BindingsTests.detect_changes):
3435         (BindingsTests.run_tests):
3436
3437 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
3438
3439         Tools/Scripts: eliminate find_test_files from Port class.
3440         https://bugs.webkit.org/show_bug.cgi?id=73553
3441
3442         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
3443         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
3444         Also I'll move _is_test_file() and related functions close to Port.tests().
3445
3446         Reviewed by Dirk Pranke.
3447
3448         * Scripts/webkitpy/layout_tests/port/base.py:
3449         (Port.tests):
3450         (Port.is_reference_html_file):
3451         (Port._has_supported_extension):
3452         (Port._is_test_file):
3453         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3454         (PortTest.test_find_no_paths_specified):
3455         (PortTest.test_find_one_test):
3456         (PortTest.test_find_glob):
3457         (PortTest.test_find_with_skipped_directories):
3458         (PortTest.test_find_with_skipped_directories_2):
3459         (PortTest.test_is_test_file):
3460         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3461         (_default_tests_paths):
3462         (ChromiumGpuLinuxPort.tests):
3463         (ChromiumGpuCgMacPort.tests):
3464         (ChromiumGpuMacPort.tests):
3465         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3466         (ChromiumGpuTest.test_default_tests_paths.test_paths):
3467         (ChromiumGpuTest.test_default_tests_paths):
3468         (ChromiumGpuTest.test_test_files.test_paths):
3469         (ChromiumGpuTest):
3470         (ChromiumGpuTest.test_test_files):
3471         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3472         (get_tests_run.RecordingTestDriver.run_test):
3473         * Scripts/webkitpy/tool/commands/rebaseline.py:
3474         (OptimizeBaselines._optimize_baseline):
3475         (OptimizeBaselines.execute):
3476         (AnalyzeBaselines._analyze_baseline):
3477         (AnalyzeBaselines.execute):
3478
3479 2011-12-01  Hajime Morrita  <morrita@chromium.org>
3480
3481         JS_INLINE and WTF_INLINE should be visible from WebCore
3482         https://bugs.webkit.org/show_bug.cgi?id=73191
3483
3484         Reviewed by Kevin Ollivier.
3485
3486         Removed macro definitions which is now provided by Platform.h
3487
3488         * DumpRenderTree/chromium/config.h:
3489         * DumpRenderTree/config.h:
3490         * TestWebKitAPI/config.h:
3491         * WebKitTestRunner/config.h:
3492
3493 2011-12-01  Hayato Ito  <hayato@chromium.org>
3494
3495         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
3496         https://bugs.webkit.org/show_bug.cgi?id=73406
3497
3498         Reviewed by Ryosuke Niwa.
3499
3500         WebKitPort's image_diff uses tolerance='0.1' in default.
3501         When reftests fail, we should use tolerace=0 when diff-ing images.
3502
3503         Since ImageDiff on chromium port doesn't use tolerance value as of now,
3504         this change doesn't affect chromium port's behavior.
3505
3506         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3507         (write_test_result):
3508         * Scripts/webkitpy/layout_tests/port/base.py:
3509         (Port.diff_image):
3510         * Scripts/webkitpy/layout_tests/port/chromium.py:
3511         (ChromiumPort.diff_image):
3512         * Scripts/webkitpy/layout_tests/port/test.py:
3513         (TestPort.diff_image):
3514         * Scripts/webkitpy/layout_tests/port/webkit.py:
3515         (WebKitPort.diff_image):
3516         (WebKitPort._start_image_diff_process):
3517         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3518         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3519
3520 2011-12-01  Adam Klein  <adamk@chromium.org>
3521
3522         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
3523         https://bugs.webkit.org/show_bug.cgi?id=73599
3524
3525         Reviewed by Ojan Vafai.
3526
3527         * TestResultServer/static-dashboards/builders.js:
3528         * TestResultServer/static-dashboards/dashboard_base.js:
3529         ():
3530         (htmlForTestTypeSwitcher):
3531         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3532         (testHtmlForTestTypeSwitcherGroup):
3533
3534 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3535
3536         Parse reftest.list and extract types of ref tests
3537         https://bugs.webkit.org/show_bug.cgi?id=66837
3538
3539         Reviewed by Dirk Pranke.
3540
3541         Add support for reftest.list to base port.
3542
3543         * Scripts/webkitpy/common/find_files.py:
3544         (find):
3545         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3546         (SingleTestRunner.__init__):
3547         * Scripts/webkitpy/layout_tests/port/base.py:
3548         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
3549         to a dictionary of {test path: ("==" or "!=", reference file path)}
3550         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
3551         (Port._reference_file_for): Added; obtains the reference file name given a test name.
3552         (Port.is_reftest): Added; Calls _reference_file_for.
3553         (Port.reftest_expected_filename): Calls _reference_file_for.
3554         (Port.reftest_expected_mismatch_filename): Ditto.
3555         (Port.find_test_files):
3556         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
3557         -expected, -expected-mismach, -ref, or -notref as a reference file.
3558         (_is_test_file):
3559         (_parse_reftest_list): Added.
3560         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3561         (PortTest.test_is_test_file):
3562         (PortTest.test_parse_reftest_list):
3563         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3564         (DryrunDriver.run_test):
3565         * Scripts/webkitpy/layout_tests/port/test.py:
3566         (unit_test_filesystem.add_test_file):
3567         (unit_test_filesystem.add_file):
3568         (unit_test_filesystem):
3569         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3570         (get_tests_run.RecordingTestDriver.run_test):
3571         (MainTest.test_unexpected_failures):
3572         (MainTest.test_missing_and_unexpected_results):
3573         (EndToEndTest.test_end_to_end):
3574         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3575         (Rebaseliner._compile_rebaselining_tests):
3576
3577 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3578
3579         Unreviewed, rolling out r101711.
3580         http://trac.webkit.org/changeset/101711
3581         https://bugs.webkit.org/show_bug.cgi?id=73605
3582
3583         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
3584
3585         * Scripts/webkitpy/style/checker.py:
3586         (_all_categories):
3587         (FileType):
3588         (CheckerDispatcher._file_type):
3589         (CheckerDispatcher._create_checker):
3590         * Scripts/webkitpy/style/checker_unittest.py:
3591         (CheckerDispatcherDispatchTest.assert_checker_cpp):
3592         (CheckerDispatcherDispatchTest.test_cpp_paths):
3593         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
3594         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
3595
3596 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
3597
3598         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
3599
3600         * Scripts/webkitpy/common/config/watchlist:
3601
3602 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
3603
3604         [GTK] Read fonts from the jhbuild root
3605         https://bugs.webkit.org/show_bug.cgi?id=73487
3606
3607         Reviewed by Gustavo Noronha Silva.
3608
3609         Read fonts from the jhbuild root instead of from the system. This will ensure
3610         that all testers use the same fonts instead of leaving this up to luck.
3611
3612         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3613         (initializeFonts): Load fonts from jhbuild root.
3614         * Scripts/webkitpy/layout_tests/port/gtk.py:
3615         (GtkPort.setup_environ_for_server): Pass an environment variable containing
3616         the path to the jhbuild root.
3617         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3618         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
3619
3620 2011-12-01  Adam Roben  <aroben@apple.com>
3621
3622         Teach check-webkit-style how to check the syntax of JSON files
3623
3624         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3625
3626         Reviewed by Darin Adler.
3627
3628         * Scripts/webkitpy/style/checker.py:
3629         (_all_categories): Added JSONChecker's categories to the set of all categories.
3630         (FileType): Added a JSON type. Incremented other types.
3631         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3632         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3633
3634         * Scripts/webkitpy/style/checker_unittest.py:
3635         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3636         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3637
3638         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3639         which would have matched our other checkers, because I couldn't figure out how to call
3640         "json.loads" without hitting namespace conflicts.)
3641         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3642         just the modified lines from a patch.
3643         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3644         exception.
3645         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3646         try to extract a line number.
3647
3648         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3649         (MockErrorHandler.__init__):
3650         (MockErrorHandler.turn_off_line_filtering):
3651        &